[Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 83468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83468&action=edit
Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly

If a checkin has any messages at all, even informational like LocalUse, the
alert flag ( 4th character of the response ) will be set to Y, even if we do
not prove a corresponding alert code in the CV field. We should only set the
alert flag if we are going to send a value in the CV field.If a checkin has any
messages at all, even informational like LocalUse, the alert flag ( 4th
character of the response ) will be set to Y, even if we do not prove a
corresponding alert code in the CV field. We should only set the alert flag if
we are going to send a value in the CV field.

Test Plan:
1) Set the checked_in_ok sip account flag to 1 for an account
2) Check in an already checked in item via SIP
3) Note the alert flag is set to Y
4) Apply this patch
5) Restart SIP
6) Check the item in again
7) Note the alert flag is set to N

-- 
You are receiving this mail because:
You are watching all bug changes.