From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 01:26:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 00:26:02 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62351|0 |1 is obsolete| | --- Comment #30 from Aleisha Amohia --- Created attachment 71100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71100&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowCheckoutNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave a checkout note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage checkout notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage checkout notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an checkout note as seen. This should update the status of the checkout note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 02:32:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 01:32:15 +0000 Subject: [Koha-bugs] [Bug 19750] Overdues without a fine rule add warnings to log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19750 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 02:32:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 01:32:21 +0000 Subject: [Koha-bugs] [Bug 19750] Overdues without a fine rule add warnings to log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19750 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69509|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpull? --- Created attachment 71101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71101&action=edit Bug 19750 - Overdues without a fine rule add warnings to log Followed test plan and works as expected. Signed-off-by: Dilan Johnpull? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 04:06:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 03:06:07 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #18 from M. Tompsett --- (In reply to Fridolin SOMERS from comment #17) > (In reply to Katrin Fischer from comment #16) > > I am worried about [SNIP] > Indeed. > M. Tompsett can you work on it ? > I do it if you want. I'm not sure how to correct it. So if it is clear to you. You go ahead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 05:08:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 04:08:48 +0000 Subject: [Koha-bugs] [Bug 16662] Letsencrypt II: Return of the cryptosaurus. (make it work for existing instances) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662 --- Comment #5 from M. Tompsett --- vagrant up jessie - log in to kohadevbox cd kohaclone echo deb http://ftp.debian.org/debian jessie-backports main | sudo tee /etc/apt/sources.list.d/jessie-backports.list sudo apt-get update sudo koha-create --create-db --letsencrypt test_encrypt -- nasty traceback error. Anyone understand the messages? sudo koha-remove test_encrypt -- this does put it back to pre-koha-create state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 06:34:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 05:34:24 +0000 Subject: [Koha-bugs] [Bug 20118] New: System picks Active currency by default while adding suggestion to vendor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20118 Bug ID: 20118 Summary: System picks Active currency by default while adding suggestion to vendor Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mishravk79 at gmail.com QA Contact: testopia at bugs.koha-community.org System picks Active currency by default while adding suggestion to vendor though during purchase suggestion through staff client, currency is different than active. This creates problem while putting suggestions inside the vendor and staff needs to again select the correct currency. Tested on Koha Version 16.11.11 on Debian 1. Make active currency say "USD" 2. Make a purchase suggestion from staff client on behalf of any user and select currency different than active currency say "GBP" 3. Now enter the above suggestion in a basket. 4. See the currency by default is "GBP" while it should be "USD" Above may create problem for staff to find the correct currency again and it takes time too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:10:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 06:10:59 +0000 Subject: [Koha-bugs] [Bug 16662] Letsencrypt II: Return of the cryptosaurus. (make it work for existing instances) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662 --- Comment #6 from M. Tompsett --- vagrant up jessie - log in to kohadevbox cd kohaclone echo deb http://ftp.debian.org/debian jessie-backports main | sudo tee /etc/apt/sources.list.d/jessie-backports.list sudo apt-get update sudo python -m easy_install --upgrade pyOpenSSL sudo koha-create --create-db --letsencrypt test_encrypt This got me further. only test_encrypt.mydnsname.org doesn't exist, so it ultimately failed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:17:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 06:17:42 +0000 Subject: [Koha-bugs] [Bug 20118] System picks Active currency by default while adding suggestion to vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20118 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:18:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 06:18:16 +0000 Subject: [Koha-bugs] [Bug 20118] System picks Active currency by default while adding suggestion to vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20118 --- Comment #1 from Amit Gupta --- Hi Vinod, Can you please test on 17.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:19:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 06:19:22 +0000 Subject: [Koha-bugs] [Bug 20118] System picks Active currency by default while adding suggestion to vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20118 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:40:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 06:40:03 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71019|0 |1 is obsolete| | --- Comment #3 from paxed --- Created attachment 71102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71102&action=edit Allow translating "Cancel Rating", and use string formatting for couple other strings - Make the "Cancel rating" text translatable (and change capitalization to conform to Koha coding guidelines) - Improve the two other messages to use formatted strings instead of concatenation. - Use the exact same text for the "your rating" text, so it only appears once in the po-file. Test plan: 1. See that the "Cancel rating" -text doesn't appear in po/xx-YY-opac-bootstrap.po 2. Note how there's two versions of the your rating -text ("your rating: %s, " and "your rating:") in the po-file 3. Apply patch 4. Update the xx-YY translation 5. Check the po-file. It should now contain the "Cancel rating" and a single "your rating: %s, " 6. Translate those texts, and update & install the language. 7. Go to the OPAC detail page of a biblio, and check the rating texts. 8. Hovering over the rating minus -sign should show the translated "Cancel rating" 9. Check that the text after the stars is correct with and without your rating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:40:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 06:40:13 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:51:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 06:51:19 +0000 Subject: [Koha-bugs] [Bug 20082] Vietnamese language display name is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20082 --- Comment #1 from Katrin Fischer --- Created attachment 71103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71103&action=edit Bug 20082: Correct description of Vietnamese language and add German translation Fixes the language description of Vietnamese according to the bug report and adds the German translation for the language name. To test: - Run the database update - Verify that the new descriptions Ti?ng Vi?t shows in advanced search language pull down - Install German translations - Verify that the German translation 'Vietnamesisch' shows in the pull down when German is selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 07:51:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 06:51:42 +0000 Subject: [Koha-bugs] [Bug 20082] Vietnamese language display name is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20082 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 08:02:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 07:02:25 +0000 Subject: [Koha-bugs] [Bug 20096] Regarding duplicate data in statistics and logs data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20096 --- Comment #2 from Katrin Fischer --- I can't think of a reason, why we duplicate the entries in 2 tables like that. We could certainly think about adding the user who did the transaction to statistics as well. I think removing one or the other would be harder as people are relying on both tables for their statistical reports. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 09:20:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 08:20:19 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, | |nick at bywatersolutions.com --- Comment #4 from Mirko Tietgen --- Nick, Fridolin: Please push to 17.11 and 17.05. It's a followup to bug 18696. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 10:00:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 09:00:46 +0000 Subject: [Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 10:54:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 09:54:20 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 --- Comment #5 from Mirko Tietgen --- (In reply to Jonathan Druart from comment #2) > Please make sure the commit messages start with "Bug 12345: " > https://wiki.koha-community.org/wiki/Commit_messages#Examples Whoops, I wasn't aware of that, I think I do it wrong all the time. Sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 10:59:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 09:59:56 +0000 Subject: [Koha-bugs] [Bug 16662] Letsencrypt II: Return of the cryptosaurus. (make it work for existing instances) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662 --- Comment #7 from Dobrica Pavlinusic --- Probably stupid question, but did you installed letsencrypt package with apt-get install -t jessie-backports letsencrypt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:18:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:18:41 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #28 from Victor Grousset/tuxayo --- Created attachment 71104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71104&action=edit Bug 19928: Acquisitions: show the precise kind of CSV on export buttons That is to say on the 4 "export as CSV" buttons found, now when can read "export as semicolon separated text (.csv)". It follows the "delimiter" syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:23:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:23:10 +0000 Subject: [Koha-bugs] [Bug 20119] New: Improve orders claiming Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Bug ID: 20119 Summary: Improve orders claiming Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org We need the ability to print order claims as pdf in the late orders page. Also, we need a cron script that send claims by email. Patch is coming -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:33:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:33:44 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #29 from Victor Grousset/tuxayo --- Created attachment 71105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71105&action=edit Screenshot of new buttons Here are how the new buttons looks. I choose values of the syspref that lead to the biggest text in the button to see it it's an issue. The strings are translatable, here is how it looks in the .po files. msgid "" "%s %s %s %s %s %s %s pound (#) separated text (.csv) %s comma separated text " "(.csv) %s slash separated text (.csv) %s semicolon separated text (.csv) %s " "backslash separated text (.csv) %s tab separated text (.csv) %s %s %s " msgid "" "%s %s %s %s %s %s %s pound (#) separated text (.csv) %s comma separated text " "(.csv) %s slash separated text (.csv) %s semicolon separated text (.csv) %s " "backslash separated text (.csv) %s tab separated text (.csv) %s %s %s " msgid "" "Export as %s %s pound (#) separated text (.csv) %s comma separated text (." "csv) %s slash separated text (.csv) %s semicolon separated text (.csv) %s " "backslash separated text (.csv) %s tab separated text (.csv) %s " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:34:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:34:19 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:35:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:35:05 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #13 from Victor Grousset/tuxayo --- Wrong bug, sorry >_< -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:36:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:36:18 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19910 Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:36:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:36:18 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19928 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:36:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:36:25 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:40:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:40:34 +0000 Subject: [Koha-bugs] [Bug 20119] Improve orders claiming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 --- Comment #1 from Alex Arnaud --- Created attachment 71106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71106&action=edit Bug 20119 - Ability to print claims for late orders -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:40:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:40:40 +0000 Subject: [Koha-bugs] [Bug 20119] Improve orders claiming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 --- Comment #2 from Alex Arnaud --- Created attachment 71107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71107&action=edit Bug 20119 - Add a script to claim late orders (ordersClaim.pl) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:41:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:41:14 +0000 Subject: [Koha-bugs] [Bug 20119] Improve orders claiming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:41:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:41:06 +0000 Subject: [Koha-bugs] [Bug 20119] Improve orders claiming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:48:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:48:32 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40605|0 |1 is obsolete| | Attachment #40606|0 |1 is obsolete| | Attachment #40638|0 |1 is obsolete| | --- Comment #21 from paxed --- Created attachment 71108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71108&action=edit Add a new system preference MarcFieldDocURL Add a new system preference MarcFieldDocURL. Setting it to some URL will make all the MARC documentation links point to that in the MARC edit UI. Leaving the value empty will use the old defaults (http://loc.gov for MARC21 and http://archive.ifla.org for UNIMARC). There are some possible substitutions usable in the URL: - {MARC} is replaced with either "MARC21" or "UNIMARC" - {FIELD} is replaced by the MARC field number, eg. "000", "048", ... - {LANG} is replaced by the UI language, eg. "en", or "fi-FI" To test: 1) Go to Cataloguing > New record 2) Clicking on the question mark links in the MARC edit will open a window to either loc.gov or archive.ifla.org 3) Install patch, run updatedatabase, etc 4) Redo parts 1, and 2. 5) Set the value of MarcFieldDocURL to http://example.com/?field={FIELD}&marc={MARC}&lang={LANG} 6) Redo parts 1 and 2 7) Clicking on the question mark links in the MARC edit will open a window to example.com, with the proper substitutions in the URL for the field, marc flavour and language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 11:48:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 10:48:44 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 12:09:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 11:09:25 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #6 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #5) > Please create a system preference for this behaviour instead of just > silently removing a feature some libraries rely on. That's the plan. We initially though that the first feature was completely superseded by the second one. By the way, how to name the "first feature"? (email that groups the prints of user without email addresses) Because I don't know how to name the future syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 12:30:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 11:30:15 +0000 Subject: [Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #2 from Ere Maijala --- Created attachment 71109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71109&action=edit Bug 19365 - link_bibs_to_authorities.pl doesn't work with Elasticsearch Fix several issues with the Elasticsearch code and optimize it to be usable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 12:33:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 11:33:56 +0000 Subject: [Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Ere Maijala --- Attached patch provides a slew of fixes and optimizations to the Elasticsearch code and related linking functionality. The optimizations are crucial for a usable process. On my development machine I could only achieve speed of about 1 record per second before the changes. After that it can handle 10-20 modified records and 100 checked records per second. Additionally, avoiding creating a new indexer or searcher every time it's used avoids crashing after a few thousand records due to file handles being exhausted in the Catmandu or Elasticsearch modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 12:54:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 11:54:23 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #8 from Katrin Fischer --- Not feeling really creative :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 12:54:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 11:54:14 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #7 from Katrin Fischer --- EmailOverduesNoEmail? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 13:35:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 12:35:06 +0000 Subject: [Koha-bugs] [Bug 19750] Overdues without a fine rule add warnings to log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19750 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71101|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 71110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71110&action=edit Bug 19750 - Overdues without a fine rule add warnings to log Followed test plan and works as expected. Signed-off-by: Dilan Johnpull? Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 13:35:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 12:35:04 +0000 Subject: [Koha-bugs] [Bug 19750] Overdues without a fine rule add warnings to log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19750 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 14:43:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 13:43:16 +0000 Subject: [Koha-bugs] [Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1 [Using QueryParser] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #18) > Ok, I reproduce with UseQueryParser turned on. The built query is incorrect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:20:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:20:06 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71102|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 71111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71111&action=edit Bug 11827: Untranslatable "Cancel Rating" in jQuery rating plugin - Make the "Cancel rating" text translatable (and change capitalization to conform to Koha coding guidelines) - Improve the two other messages to use formatted strings instead of concatenation. - Use the exact same text for the "your rating" text, so it only appears once in the po-file. Test plan: 1. See that the "Cancel rating" -text doesn't appear in po/xx-YY-opac-bootstrap.po 2. Note how there's two versions of the your rating -text ("your rating: %s, " and "your rating:") in the po-file 3. Apply patch 4. Update the xx-YY translation 5. Check the po-file. It should now contain the "Cancel rating" and a single "your rating: %s, " 6. Translate those texts, and update & install the language. 7. Go to the OPAC detail page of a biblio, and check the rating texts. 8. Hovering over the rating minus -sign should show the translated "Cancel rating" 9. Check that the text after the stars is correct with and without your rating Signed-off-by: Pasi Kallinen Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:20:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:20:03 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:46:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:46:00 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71090|0 |1 is obsolete| | --- Comment #40 from David Gustafsson --- Created attachment 71112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71112&action=edit Bug 19575: Use canonical field names and resolve aliased fields Adjust elastic search mappings to more closely match Zebra equivalents resolving serveral issues with coded Zebra searches in templates and sorting of search results in UI. Also make field names in search strings case insensitive to accept case variations in template links and user input. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:47:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:47:15 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #41 from David Gustafsson --- Fixed hard coded field name in Koha/SearchEngine/ElasticSearch/Search.pm ('au' to 'authority-number') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:47:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:47:44 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #42 from David Gustafsson --- *('an' to 'authority-number') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:49:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:49:41 +0000 Subject: [Koha-bugs] [Bug 20120] New: Writeoffs for individual fees allows an amount to be written off more than the amount of the fee Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Bug ID: 20120 Summary: Writeoffs for individual fees allows an amount to be written off more than the amount of the fee Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:49:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:49:47 +0000 Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20120 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:49:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:49:47 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11210 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 [Bug 11210] Allow partial writeoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:49:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:49:53 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:51:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:51:46 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:51:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:51:49 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #1 from Kyle M Hall --- Created attachment 71113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71113&action=edit Bug 20120 - Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative 3) Apply this patch 4) Attempt to repeat step 1, you should not be able to over-writeoff the fee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 15:51:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 14:51:57 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:03:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 15:03:12 +0000 Subject: [Koha-bugs] [Bug 20121] New: Can't send email by "forgotten password" on opac. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20121 Bug ID: 20121 Summary: Can't send email by "forgotten password" on opac. Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: delcastillovictorandres at gmail.com QA Contact: testopia at bugs.koha-community.org i've been setting all parameters in koha administration, my smtp service, and i can't make working the "forgotten password" in opac. when i click in link "forgotten password" it save the "email/message" in table of database, i installed postfix and mailutil to make it work (with an external smtp server) but it doesn't send email, but when i enter to the terminal and i execute this command "sudo koha-shell library(instance name)" and then i execute "/usr/share/koha/bin/cronjobs/process_message_queue.pl" After those steps, finally i receive the email, so i think that i have to make it manual way to make it work, i've been investigatin a lot! i read every document and solution i've saw here and others page but i can't solve my problem, i hope you can help guys, i will really aprecciate it! Koha V17.05.06.000 Database: Mariadb SO: Ubuntu 16.04.3 LTS Using: External smtp service postfix mailutil -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:11:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 15:11:50 +0000 Subject: [Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71109|0 |1 is obsolete| | --- Comment #4 from Ere Maijala --- Created attachment 71114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71114&action=edit Bug 19365 - link_bibs_to_authorities.pl doesn't work with Elasticsearch Fix the copyrightdate cast when it's empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:34:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 15:34:10 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Owen Leonard --- This did not work in my test. a) A superlibrarian - This user could only set circ rules for their own library b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). - This user could only set circ rules for their own library c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). - This user could set circ rules for all libraries. d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. - This user could only set circ rules for their own library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:39:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 15:39:41 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Owen Leonard --- Never mind, my db update didn't run correctly. This looks like it's (still) working correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:50:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 15:50:17 +0000 Subject: [Koha-bugs] [Bug 20122] New: Empty and close link on cart page not working (js security) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20122 Bug ID: 20122 Summary: Empty and close link on cart page not working (js security) Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mark.gavillet at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Clicking the 'Empty cart and close' link when viewing the contents of a cart at /cgi-bin/koha/opac-basket.pl does not work. There are javascript security errors because the page opens in a new window but scripts in /opac-tmpl/bootstrap/js/basket.js such as updateBasket try to access and change values in the parent window (referred to as top.opener) - this is blocked by the browser. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 16:56:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 15:56:25 +0000 Subject: [Koha-bugs] [Bug 19762] Add option for PREDUE notices to take calendar into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19762 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:09:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 16:09:39 +0000 Subject: [Koha-bugs] [Bug 20122] Empty and close link on cart page not working (js security) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20122 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:14:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 16:14:19 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Frank Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:34:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 16:34:33 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #64 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #63) > (In reply to Jonathan Druart from comment #62) > > Do we need it in patroncards/manage.tt as well? > > Created and took bug 20111 for that. I am waiting for it to push these ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:40:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 16:40:13 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70563|0 |1 is obsolete| | --- Comment #16 from Victor Grousset/tuxayo --- Created attachment 71116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71116&action=edit Bug 13560 - Unit tests To test: 1 - apply all patches 2 - update database 3 - prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:40:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 16:40:18 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70613|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo --- Created attachment 71117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71117&action=edit Bug 13560: Add an 'Add' option for marc modification templates Add/Update would update a field or create new if it existed, but didn't allow for creating new if the field existed. This patchset splits the options to 'Add & Update' so that 'Add' will always add a field and 'Update' will operate as it always has To test: 1 - Have a record with a known existing field (make a copy) 2 - Define a marc modification template that 'Add/update' on that field 3 - Define an 'Add/Update' on a field that doesn't exist 4 - Batch modify the copy of record using the above template 5 - Verify the existing field was updated 6 - Verify the non-existing field was updated 7 - Apply patch and update database 8 - Make another copy 9 - Modify the copy with the same template as above 10 - Should match initial modification 11 - Add a new rule to add a new field 12 - Modify using the updated template 13 - Ensure your new field is created 14 - Test various options in the modification tool 15 - prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:40:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 16:40:08 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70562|0 |1 is obsolete| | --- Comment #15 from Victor Grousset/tuxayo --- Created attachment 71115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71115&action=edit Bug 13560 - Database changes Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 17:41:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 16:41:12 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 --- Comment #18 from Victor Grousset/tuxayo --- I forgot to sign off the first two patches. So here they are. To no loose my previous comment: As for step ?14 - Test various options in the modification tool? I only moved one field to another to ensure that the target is overwritten without error. Is that enough? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:22:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:22:16 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:22:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:22:05 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display active currency |Add the ability to |symbol on currency output |customize and display the |and input |symbol for a currency --- Comment #23 from Jonathan Druart --- I am stealing this bug to add a new column to the currency table. It will allow to display or not a space between the symbol and the value. The problem we also have is that the with_symbol flag is not correctly handled in template (not passed from Koha::Template::Plugin::Price to Koha::Format::Price) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:01 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:06 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45888|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 71118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71118&action=edit Bug 4078: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:10 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #25 from Jonathan Druart --- Created attachment 71119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71119&action=edit Bug 4078: Update DB entry - add new column currency.p_sep_by_space -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:15 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #26 from Jonathan Druart --- Created attachment 71120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71120&action=edit Bug 4078: Add the checkbox to the UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:19 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #27 from Jonathan Druart --- Created attachment 71121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71121&action=edit Bug 4078: Pass with_symbol to module The template plugin did not pass the with_symbol flag to the module and so was not taken into account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:23 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #28 from Jonathan Druart --- Created attachment 71122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71122&action=edit Bug 4078: Add the ability to display and configure the symbol for prices The symbol of currencies are not displayed (or not correctly) so far. This patch set adds the ability to configure the display of the symbol (with or without a whitespace between the symbol and the price). Test plan: 1. Execute the update DB entry, go to the currency admin page and tick the new "Space separation between symbol and value" checkbox 2. Add a fine to a patron and use their credentials to login at the OPAC 3. You should see the "$ 42 due fines and charges" info in the dashboard 4. Untick the new checkbox to remove the space and reload the OPAC main page. => The space should not be longer displayed ($42) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:27 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #29 from Jonathan Druart --- Created attachment 71123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71123&action=edit Bug 4078: Add a new test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:38 +0000 Subject: [Koha-bugs] [Bug 16940] Show active currency's symbol to users in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16940 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:38 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16940 [Bug 16940] Show active currency's symbol to users in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:45 +0000 Subject: [Koha-bugs] [Bug 16940] Show active currency's symbol to users in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16940 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=4078 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:43:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:43:45 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16940 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:44:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:44:02 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:44:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:44:32 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #8 from Jonathan Druart --- Created attachment 71124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71124&action=edit Bug 19188: Use the Price template plugin with_symbol => 1 To make it displayed correctly depending on the configuration of the currency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:45:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:45:07 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff Depends on| |4078 --- Comment #9 from Jonathan Druart --- I have added a follow-up based on top of bug 4078. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 18:45:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 17:45:07 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 [Bug 19188] Self checkout: missing space if fine amount is blocking renewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 19:21:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 18:21:39 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 19:21:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 18:21:34 +0000 Subject: [Koha-bugs] [Bug 20123] New: Allow multiple instances of Koha to have different timezones on the same server Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Bug ID: 20123 Summary: Allow multiple instances of Koha to have different timezones on the same server Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Most of Koha depends on the local timezone of the server, except for Koha::Database which support an ENV override with the key TZ. We should take this a step further. We should not only accept the TZ environment variable for all of Koha, we should really be able to set the timezone in the koha conf file as well so we don't have to pass that environment variable to things like cronjobs and one-off scripts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 19:43:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 18:43:44 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 19:43:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 18:43:46 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #1 from Kyle M Hall --- Created attachment 71125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71125&action=edit Bug 20123 - Allow multiple instances of Koha to have different timezones on the same server Most of Koha depends on the local timezone of the server, except for Koha::Database which support an ENV override with the key TZ. We should take this a step further. We should not only accept the TZ environment variable for all of Koha, we should really be able to set the timezone in the koha conf file as well so we don't have to pass that environment variable to things like cronjobs and one-off scripts. Test Plan: 1) Apply this patch 2) Set a timzone in your koha_conf file, that is *not* your local time zone Available timzones are listed here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones 3) Restart apache/plack 4) Perform some actions, check the timestamps in the database and in the html output, note they are for the set timezone and not the local timezone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 19:54:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 18:54:25 +0000 Subject: [Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 19:55:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 18:55:53 +0000 Subject: [Koha-bugs] [Bug 19026] System Preferences that include a list of fields is not displayed correctly in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19026 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 20:08:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 19:08:00 +0000 Subject: [Koha-bugs] [Bug 19115] Advanced editor - Rancor does not load on https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19115 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca --- Comment #6 from Marjorie Barry-Vila --- (In reply to Josef Moravec from comment #5) > Is my configuration issues, sorry and thank Katrin and Robin (on IRC) for > attention and advice. Hi Josef, I have same problem in 17.05 but I understand that it depends on system configurations. Can you tell me what are the good configurations? Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 20:19:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 19:19:54 +0000 Subject: [Koha-bugs] [Bug 15876] Removing a course-reserved item with no initial shelving location does not revert items.location to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15876 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |baptiste.wojtkowski at biblibr | |e.com Assignee|koha-bugs at lists.koha-commun |baptiste.wojtkowski at biblibr |ity.org |e.com Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13311 CC| |fridolin.somers at biblibre.co | |m Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #1 from Baptiste --- This behaviour is common for all location changes: In the code in C4/Items.pl -> _do_column_fixes_for_mod, is is explicitely written that any change in item.location (except toward 'CART' and 'PROC'), if permanent_location is empty, it will be populated. The question is now to know, is it pertinent to add an exception and not run this function for location in case of reserve course, but I don't think so. --- Comment #2 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 10382 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 20:19:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 19:19:54 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod at lib.auth.gr --- Comment #33 from Kyle M Hall --- *** Bug 15876 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 20:24:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 19:24:53 +0000 Subject: [Koha-bugs] [Bug 16662] Letsencrypt II: Return of the cryptosaurus. (make it work for existing instances) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662 --- Comment #8 from M. Tompsett --- (In reply to Dobrica Pavlinusic from comment #7) > Probably stupid question, but did you installed letsencrypt package with > > apt-get install -t jessie-backports letsencrypt That's part of the koha-create script. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 21:25:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 20:25:37 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16940 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 21:25:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 20:25:37 +0000 Subject: [Koha-bugs] [Bug 16940] Show active currency's symbol to users in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16940 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=4078 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 21:30:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 20:30:15 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #66 from Liz Rea --- Hi, Lots of conflicts applying this now. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 22:48:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 21:48:04 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64662|0 |1 is obsolete| | --- Comment #31 from Aleisha Amohia --- Created attachment 71126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71126&action=edit Bug 17698: [FOLLOW-UP] Changing to Koha Objects style, adding circ sidebar Marcel, can you please have a look at this patch. I tried to implement the change my @notes = $schema->resultset('Issue')->search({ 'me.note' => { '!=', undef } }, { prefetch => [ 'borrower', { item => 'biblionumber' } ] }); to my @notes = Koha::Checkouts->search({ 'me.note' => { '!=', undef } }, { prefetch => [ 'borrower', { item => 'biblionumber' } ] }); but am having problems on the template side. I can access the item and biblio information about the issue, but not the borrower information, even though the query is definitely pulling it correctly. Any suggestions or ideas as to why this breaks? This patch also adds the implementation of the circSidebar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 22:56:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 21:56:12 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 22:56:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 21:56:18 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64835|0 |1 is obsolete| | --- Comment #32 from Aleisha Amohia --- Created attachment 71127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71127&action=edit Bug 17698: [FOLLOW-UP] Koha Objects, access borrower through patron sub See Comment 27 This is ready to be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 22:58:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 21:58:34 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #33 from Aleisha Amohia --- Patches rebased, please test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 22:59:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 21:59:07 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #15 from Joy Nelson --- Cait- I can appreciate that your libraries have workflows related to analytics here. However, the vast majority of other libraries using MARC21 standard do not intend the Leader position 7 to indicate that there are analytics present. I believe that Koha should be displaying the bibliographic data in a way that is accurate to the data that is entered. In this case not display an analytic tag just because leader position 7 =s. I have a number of libraries who would love to see this 'feature' removed and have Koha catalog and display in the correct fashion (according to marc21 standards). joy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 22:59:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 21:59:14 +0000 Subject: [Koha-bugs] [Bug 20119] Improve orders claiming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Alex, maybe this should be 2 bugs? Also please make sure to add test plans and a bit more information to your commit messages! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 23:00:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 22:00:01 +0000 Subject: [Koha-bugs] [Bug 20119] Improve orders claiming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 --- Comment #4 from Katrin Fischer --- By splitting into 2 bugs with better descriptions this will also stand out more in the release notes :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 23:03:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 22:03:53 +0000 Subject: [Koha-bugs] [Bug 20121] Can't send email by "forgotten password" on opac. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20121 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Please bring this up on the mailing list - it's more likely to be a setup/configuration issue than a bug and a lot more people will read it there! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 23:11:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 22:11:46 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #67 from Chris Cormack --- We'd really like this patch in, does Biblibre plan to work on it more, if not please let us know so we can perhaps try to get it fixed to pass QA ourselves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 23:15:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 22:15:30 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #16 from Katrin Fischer --- (In reply to Joy Nelson from comment #15) > Cait- > I can appreciate that your libraries have workflows related to analytics > here. However, the vast majority of other libraries using MARC21 standard > do not intend the Leader position 7 to indicate that there are analytics > present. I believe that Koha should be displaying the bibliographic data in > a way that is accurate to the data that is entered. In this case not > display an analytic tag just because leader position 7 =s. > > I have a number of libraries who would love to see this 'feature' removed > and have Koha catalog and display in the correct fashion (according to > marc21 standards). > > joy I am not sure how to hide it by default and make it display on demand. At the moment you can hide it with one line of CSS. Would hiding it in the default CSS and unhiding in OpacUserCSS work? We also hide it for a lot of libraries as most don't have analytics - and then they don't have analytics on all records. I just wanted to say: don't kill it by assuming everyone uses EasyAnalytics. I am open to suggestions on how to make this work better - Ideally it should only display when there are linked records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 23:51:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 22:51:35 +0000 Subject: [Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 23:53:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 22:53:31 +0000 Subject: [Koha-bugs] [Bug 20096] Regarding duplicate data in statistics and logs data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20096 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 1 23:53:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 22:53:16 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 00:31:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Feb 2018 23:31:05 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #17 from Joy Nelson --- Cait- I agree that this could be a responsive feature in Koha. However, to most librarians it appears that Koha is 'doing something' (displaying analytic links) that is not supported by the correct cataloging of records. Catalogers put a lot of effort into correctly cataloging their collections. And when this cataloging results in behavior that is not related to the industry standards, it causes frustration, confusion and some lack of confidence in the tool. Yes, it could be hidden, but by doing so we are expecting the bulk of Marc21 libraries to hide something that should never be there in the first place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 05:02:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 04:02:12 +0000 Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016 sokunrotanak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ssrey at asianhope.org --- Comment #18 from sokunrotanak --- Hi, How do I download script to fix corrupted data? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 07:12:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 06:12:16 +0000 Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016 --- Comment #19 from Katrin Fischer --- The script is not finished and not recommended for production use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 07:15:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 06:15:37 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #18 from Katrin Fischer --- Joy, I understand. Let's try to figure out something that works for us both. What about my suggestion to turn the CSS around from the last comment? (hide by default, make it possible to unhide) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 07:23:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 06:23:29 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #19 from Katrin Fischer --- I'd be happiest with a solution where we fixed the idea from Jonathan so that it works for both use cases - EasyAnalytics and simple 773 linking. Looking at the patch it seems to be missing the code to actually calculate the $analytics_flag? I think we could all agree that this would be a nice enhancement, showing a link only when there are analytics. Or just never show a link if EasyAnalytics is used? I am just not sure how to do it, which is the whole reason it was not implemented like that from the beginning :( With some guidance I would be happy to give it a try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 07:25:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 06:25:32 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 [Bug 5959] Add search link for analytics to serial records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 07:25:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 06:25:32 +0000 Subject: [Koha-bugs] [Bug 5959] Add search link for analytics to serial records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 07:37:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 06:37:32 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 07:43:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 06:43:10 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #20 from Marcel de Rooy --- (In reply to Joy Nelson from comment #17) > Cait- > I agree that this could be a responsive feature in Koha. However, to most > librarians it appears that Koha is 'doing something' (displaying analytic > links) that is not supported by the correct cataloging of records. > Catalogers put a lot of effort into correctly cataloging their collections. > And when this cataloging results in behavior that is not related to the > industry standards, it causes frustration, confusion and some lack of > confidence in the tool. > > Yes, it could be hidden, but by doing so we are expecting the bulk of Marc21 > libraries to hide something that should never be there in the first place. Sounds reasonable to me. 'Can you hide it' should not be the approach imo.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 07:48:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 06:48:26 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #21 from Katrin Fischer --- Can we all start working on a solution instead of chiming in that a feature added 2006 is bad? ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 07:49:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 06:49:43 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #22 from Katrin Fischer --- Sorry, 2011. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 08:08:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 07:08:05 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #27 from Marcel de Rooy --- Working on this one now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 08:43:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 07:43:39 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:06:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 08:06:16 +0000 Subject: [Koha-bugs] [Bug 20124] New: Allow translating did you mean config save message Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20124 Bug ID: 20124 Summary: Allow translating did you mean config save message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When saving the "Did you mean?" setting, a popup with the message "Successfully saved configuration" is shown, but it cannot be translated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:08:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 08:08:07 +0000 Subject: [Koha-bugs] [Bug 20124] Allow translating did you mean config save message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20124 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | --- Comment #1 from paxed --- Created attachment 71128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71128&action=edit Bug 20124: Allow translating did you mean config save message When saving the "Did you mean?" setting, a popup with the message "Successfully saved configuration" is shown, but it cannot be translated. Make it translatable. Test plan: 1) Go to Home -> Administration -> Did you mean? 2) Change the settings, click on "Save configuration" 3) Popup with "Successfully saved configuration" 4) Apply patch, update po-files, etc. 5) Check that the msgid "Successfully saved configuration" is in fi-FI-staff-prog.po, and translate the message 6) install the fi-FI language 7) Change your UI language to finnish 8) Repeat 1, 2, 3. You should now see the same popup message translated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:19:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 08:19:54 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:35:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 08:35:34 +0000 Subject: [Koha-bugs] [Bug 19839] invoice.pl warns about bad variable scope In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.09 Less warn in logs saves trees ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:36:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 08:36:33 +0000 Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not links to biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:37:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 08:37:39 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:40:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 08:40:00 +0000 Subject: [Koha-bugs] [Bug 19971] typo in the comments of parseQuery routine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 09:53:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 08:53:58 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:02:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:02:57 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70629|0 |1 is obsolete| | Attachment #70630|0 |1 is obsolete| | Attachment #70631|0 |1 is obsolete| | Attachment #70632|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy --- Created attachment 71129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71129&action=edit Bug 15494 - Unit tests prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:03:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:03:01 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #29 from Marcel de Rooy --- Created attachment 71130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71130&action=edit Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:03:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:03:06 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #30 from Marcel de Rooy --- Created attachment 71131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71131&action=edit Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:02:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:02:54 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:03:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:03:10 +0000 Subject: [Koha-bugs] [Bug 20119] Improve orders claiming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 --- Comment #5 from Alex Arnaud --- (In reply to Katrin Fischer from comment #4) > By splitting into 2 bugs with better descriptions this will also stand out > more in the release notes :) You are right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:03:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:03:10 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #31 from Marcel de Rooy --- Created attachment 71132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71132&action=edit Bug 15494 - Add syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:03:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:03:15 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #32 from Marcel de Rooy --- Created attachment 71133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71133&action=edit Bug 15494: (QA follow-up) Additional polishing [1] Fix two typos in Circulation.t. Although the test does not fail, line 2127 contains two typos. Changing INVISILE to INVISIBLE :) And type should be itype. [2] Remove $yaml as leftover from older code. [3] Add a next when the split on /:/ does not give two results. This will prevent uninit warnings (although still disabled now in Circulation). [4] For the same reason we should switch the lines for NULL and empty string. The undefs you insert should trigger a warn. [5] The line for empty string should not insert undef, but empty string. For the same reason adding the condition defined($_) ... And proving it by adding two tests for the opposite values of callnumber and itemnotes. [6] Adding a strip spaces around the fieldname. User friendly.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:04:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:04:55 +0000 Subject: [Koha-bugs] [Bug 20119] Improve orders claiming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:05:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:05:25 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71129|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy --- Created attachment 71134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71134&action=edit Bug 15494 - Unit tests prove -v t/db_dependent/Circulation.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:05:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:05:30 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71130|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 71135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71135&action=edit Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:05:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:05:35 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71131|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy --- Created attachment 71136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71136&action=edit Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:05:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:05:39 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71132|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Created attachment 71137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71137&action=edit Bug 15494 - Add syspref Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:05:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:05:45 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71133|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy --- Created attachment 71138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71138&action=edit Bug 15494: (QA follow-up) Additional polishing [1] Fix two typos in Circulation.t. Although the test does not fail, line 2127 contains two typos. Changing INVISILE to INVISIBLE :) And type should be itype. [2] Remove $yaml as leftover from older code. [3] Add a next when the split on /:/ does not give two results. This will prevent uninit warnings (although still disabled now in Circulation). [4] For the same reason we should switch the lines for NULL and empty string. The undefs you insert should trigger a warn. [5] The line for empty string should not insert undef, but empty string. For the same reason adding the condition defined($_) ... And proving it by adding two tests for the opposite values of callnumber and itemnotes. [6] Adding a strip spaces around the fieldname. User friendly.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:09:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:09:04 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #38 from Marcel de Rooy --- Has been tested already before, spent sufficient time on changes now. Looks good to me. No blocker, but slightly confusing in staff checkouts table: 0 Renewal denied by syspref (10 of 10 renewals remaining) If I can't renew, what is the value of these 10? :) Passed QA with follow-up for some minor issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:14:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:14:23 +0000 Subject: [Koha-bugs] [Bug 20125] New: Add a cron script to claim late orders Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 Bug ID: 20125 Summary: Add a cron script to claim late orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org We need a script that automatically send order claims by mail to the booksellers. The script should take 3 important paramters: delay: Number of days from which an orders is considered as late claimed-for: Minimum number of days since the last claim max-claim: Maximum number of claims -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:14:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:14:52 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:14:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:14:58 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:17:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:17:09 +0000 Subject: [Koha-bugs] [Bug 20119] Improve orders claiming In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71107|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud --- Comment on attachment 71107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71107 Bug 20119 - Add a script to claim late orders (ordersClaim.pl) >From 2c7a930cf6e6cb12b4a7963d34e86bbfde0ceb42 Mon Sep 17 00:00:00 2001 >From: Alex Arnaud >Date: Wed, 31 Jan 2018 15:16:16 +0000 >Subject: [PATCH] Bug 20119 - Add a script to claim late orders > (ordersClaim.pl) > >--- > misc/cronjobs/ordersClaim.pl | 162 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 162 insertions(+) > create mode 100755 misc/cronjobs/ordersClaim.pl > >diff --git a/misc/cronjobs/ordersClaim.pl b/misc/cronjobs/ordersClaim.pl >new file mode 100755 >index 0000000..a0d046c >--- /dev/null >+++ b/misc/cronjobs/ordersClaim.pl >@@ -0,0 +1,162 @@ >+#!/usr/bin/perl >+ >+# Copyright 2018 Biblibre >+# >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see . >+ >+=head1 NAME >+ >+ordersClaim.pl - cron script that put late orders in message queue grouped by basket. >+ >+=head1 SYNOPSIS >+ >+./ordersClaim.pl --delay 40 --claimed-for 10 --max-claims 3 >+ >+=head1 DESCRIPTION >+ >+This script get all late orders (depending on --delay parameter, >+group them by basket and put an entry in message_queue table. >+ >+=cut >+ >+use Modern::Perl; >+ >+use Getopt::Long; >+use Pod::Usage; >+ >+use C4::Letters; >+use C4::Acquisition; >+ >+=head1 NAME >+ >+ordersClaim.pl - cron script that put late orders in message queue grouped by basket. >+ >+=head1 SYNOPSIS >+ >+perl ordersClaim.pl >+ [ --delay|d ][ --claimed-for|c ][ --max-claims ] >+ >+=head1 OPTIONS >+ >+=over >+ >+=item B<--help> >+ >+Print a brief help message and exits. >+ >+=item B<--delay> >+ >+Number of days from which an orders is considered as late. >+Default is the booseller's delivery time or 0. >+ >+=item B<--claimed-for> >+ >+Minimum number of days since the last claim. Default is 0. >+ >+=item B<--max-claim> >+ >+Number of claims beyond which we stop sending others. >+Default is 1; >+ >+=cut >+ >+my $help; >+my $delay; >+my $claimed_for = 0; >+my $max_claims = 1; >+ >+GetOptions( >+ 'help|?' => \$help, >+ 'delay|d:i' => \$delay, >+ 'claimed-for|c:i' => \$claimed_for, >+ 'max-claims|m:i' => \$max_claims, >+) or pod2usage(1); >+ >+pod2usage(1) if $help; >+ >+my @lateorders = GetLateOrders( ($delay) ); >+ >+# Sort orders by basket >+my $baskets_orders; >+push @{ $baskets_orders->{ $_->{basketno} } }, $_->{ordernumber} for @lateorders; >+ >+while (my ($basketno, $orderids) = each %$baskets_orders) { >+ my $schema = Koha::Database->new->schema; >+ >+ my $basket = $schema->resultset('Aqbookseller')->find( >+ { id => $basketno }, >+ { result_class => 'DBIx::Class::ResultClass::HashRefInflator' }); >+ >+ my $booksellerid = $basket->{booksellerid}; >+ my $bookseller = $schema->resultset('Aqbookseller')->find( >+ { id => $booksellerid }, >+ { result_class => 'DBIx::Class::ResultClass::HashRefInflator' }); >+ >+ my $contact = $schema->resultset('Aqcontact')->find( >+ { booksellerid => $booksellerid, claimacquisition => 1 }, >+ { result_class => 'DBIx::Class::ResultClass::HashRefInflator' }); >+ >+ unless ( defined( $delay ) ) { >+ $delay = $bookseller->{deliverytime} || 0; >+ } >+ >+ my $dbh = C4::Context->dbh; >+ >+ my $orderids_str = join(',', ('?') x @$orderids); >+ my $orders = $dbh->selectall_arrayref(qq{ >+ SELECT aqorders.*, aqbasket.*, biblio.* >+ FROM aqorders >+ LEFT JOIN biblio ON aqorders.biblionumber = biblio.biblionumber >+ LEFT JOIN aqbasket ON aqorders.basketno = aqbasket.basketno >+ WHERE aqorders.ordernumber IN ($orderids_str) >+ AND aqorders.claims_count < $max_claims >+ AND (aqorders.claimed_date IS NULL or aqorders.claimed_date <= DATE_SUB(CAST(now() AS date),INTERVAL $claimed_for DAY)) >+ }, {Slice => {}}, @$orderids); >+ >+ next unless @$orders; >+ >+ my $letter = GetPreparedLetter( >+ module => 'claimacquisition', >+ letter_code => 'ACQCLAIM', >+ message_transport_type => 'email', >+ tables => { >+ 'aqbooksellers' => $bookseller, >+ 'aqcontacts' => $contact, >+ 'aqbasket' => $basket >+ }, >+ repeat => $orders, >+ ) or next; >+ >+ my $admin_address = C4::Context->preference('KohaAdminEmailAddress'); >+ my $id = C4::Letters::EnqueueLetter({ >+ letter => $letter, >+ from_address => $admin_address, >+ to_address => $contact->{email}, >+ message_transport_type => $letter->{message_transport_type} >+ }); >+ >+ continue unless $id >+ >+ my $today = Koha::DateUtils::dt_from_string; >+ foreach my $o ( @$orders ) { >+ my $order = $schema->resultset('Aqorder')->find($o->{ordernumber}); >+ my $count = $order->get_column('claims_count') || 0; >+ $order->set_columns({ >+ claimed_date => $today->ymd, >+ claims_count => $count+1 >+ })->update_or_insert; >+ } >+} >-- >2.7.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:17:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:17:57 +0000 Subject: [Koha-bugs] [Bug 20119] Ability to print claims for late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve orders claiming |Ability to print claims for | |late orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 10:39:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 09:39:23 +0000 Subject: [Koha-bugs] [Bug 19455] Circulation/SwitchOnSiteCheckouts.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin SOMERS --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:01:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:01:43 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 --- Comment #1 from Alex Arnaud --- Created attachment 71139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71139&action=edit Bug 20125 - Add a script to claim late orders (ordersClaim.pl) Test plan: - Put some orders late from different baskets by changing the closedate column in aqbasket table, Testing delay parameters: - launch "perl misc/cronjobs/ordersClaim.pl" with the following parameters: - delay: Up to the number of days from the basket's closedate, - claimed-for: no matter for the first claim, - Check that there is one entry in message_queue *for each basket with late order(s)* - Check these late orders in database: - claims_count column should be set to 1, - claimed_date should be today Testing claimed-for parameter: - change the claimed_date column in database for all orders (i.e 2 days back), - launch "perl misc/cronjobs/ordersClaim.pl" again with the following parameters: - delay: Same than for the first test, - claimed-for: 3 (if set claimed_date 2 days back), - max-claims: at least 2 - check that there is no new entry in message_queue - launch "perl misc/cronjobs/ordersClaim.pl" again by moving only claimed-for to 1 - There should be new entry in message_queue - claims_count column should be set to 2 - claimed_date should be today Testing max-claims parameter: - change the claimed_date column in database for all orders (i.e 2 days back), - launch "perl misc/cronjobs/ordersClaim.pl" again with the following parameters: - delay: Same than for the first and second test, - claimed-for: 1 (if set claimed_date 2 days back), - max-claims: 1 and 2 (test the two options), - There should be new entry in message_queue - launch "perl misc/cronjobs/ordersClaim.pl" again by moving only max-claims to 3 - There should be new entry in message_queue - claims_count column should be set to 3 - claimed_date should be today -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:02:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:02:08 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:26:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:26:38 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #54 from Marcel de Rooy --- This change has interesting side-effects ! - $sth = $dbh->prepare("UPDATE biblioitems SET marc=?,marcxml=? WHERE biblionumber=?"); - $sth->execute( $record->as_usmarc(), $record->as_xml_record($encoding), $biblionumber ); + $sth = $dbh->prepare("UPDATE biblioitems SET marcxml=? WHERE biblionumber=?"); + $sth->execute( $record->as_xml_record($encoding), $biblionumber ); It seems that since we do no longer call the sub as_usmarc, the automatic field lengths in the marc are not calculated anymore. This needs our attention. Will open a new report now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:27:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:27:50 +0000 Subject: [Koha-bugs] [Bug 20126] New: Saving a biblio does no longer update MARC field lengths Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 Bug ID: 20126 Summary: Saving a biblio does no longer update MARC field lengths Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 10455. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:28:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:28:10 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:32:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:32:43 +0000 Subject: [Koha-bugs] [Bug 20127] New: Label Making Solution Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20127 Bug ID: 20127 Summary: Label Making Solution Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jesse at bywatersolutions.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org 1) Determine if functionality should be submitted as Koha patch, or as a Koha plugin 2) Add the ability to define CSS based Label Templates 3) Add the ability to define CSS based Printer Profiles 4) Add the ability to define Template Toolkit based Layouts 5) Implement logic to parse and display the labels for printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:32:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:32:45 +0000 Subject: [Koha-bugs] [Bug 20128] New: Permission for advanced editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Bug ID: 20128 Summary: Permission for advanced editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle at bywatersolutions.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Work to be done: 1) Create a new permission, under the "cataloguing" module, that controls whether the professional cataloging editor is available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:39:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:39:35 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 [Bug 10455] remove redundant 'biblioitems.marc' field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:39:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:39:35 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 [Bug 20126] Saving a biblio does no longer update MARC field lengths -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:39:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:39:48 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:41:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:41:14 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 --- Comment #1 from Marcel de Rooy --- Created attachment 71140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71140&action=edit Bug 20126: Restore MARC field length calculation in ModBiblioMarc Trivial fix. Problem raised by bug 10455. Test plan: [1] Create or edit biblio record. [2] Save and check leader field lengths in MARC view. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:42:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:42:42 +0000 Subject: [Koha-bugs] [Bug 20129] New: MetadataPrefix=marc21 doesn't use specified xslt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20129 Bug ID: 20129 Summary: MetadataPrefix=marc21 doesn't use specified xslt Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: martin.stastny at teamlibrary.cz QA Contact: testopia at bugs.koha-community.org Hello, Since 17.11, metadaPrefix marc21 uses some default xslt stylesheet instead of our edited one in the OAI. We got defined marc21 format by yaml conf file, but OAI uses another one. If we rename format e.g. to marc2 it works fine. Specifically, with those 2 defined formats, will "nkp" works as expected, but "marc21" output will be different from "nkp" and wrong: nkp: metadataPrefix: nkp metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd xsl_file: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/cs-CZ/xslt/MARC21NKP.xsl marc21: metadataPrefix: marc21 metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd xsl_file: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/cs-CZ/xslt/MARC21NKP.xsl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:49:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:49:04 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:49:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:49:08 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59962|0 |1 is obsolete| | Attachment #59963|0 |1 is obsolete| | Attachment #59964|0 |1 is obsolete| | Attachment #59965|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 71141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71141&action=edit Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices By allowing the use of Template Toolkit for generating the outgoing Talking Tech CSV files, we can give libaries more control over the data they send to Itiva. This enhancement would also make it possible to use the script for other services since the output is no longer fixed to a single format. Test Plan: 1) Apply this patch 2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout 3) Generate the CSV file via the script misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl 4) Enable Template Toolkit for the notices and update the notice text to be: [% FILTER remove("\r\n") %] "[% format %]", "[% language %]", "[% type %]", "[% level %]", "[% borrower.cardnumber %]", "[% borrower.title %]", "[% borrower.firstname %]", "[% borrower.surname %]", "[% borrower.phone %]", "[% borrower.email %]", "[% library_code %]", "[% branch.id %]", "[% branch.branchname %]", "[% item.barcode %]", "[% due_date %]", "[% biblio.title %]", "__MESSAGE_ID__" [% END %] 5) Regenerate the notices 6) Compare the originals, note the format is the same Signed-off-by: Sean McGarvey Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:49:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:49:15 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #30 from Kyle M Hall --- Created attachment 71142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71142&action=edit Bug 15969 - Add unit test of substitution param Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:49:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:49:19 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #31 from Kyle M Hall --- Created attachment 71143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71143&action=edit Bug 15969 - Unit test use of __MESSAGE_ID__ Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:49:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:49:22 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #32 from Kyle M Hall --- Created attachment 71144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71144&action=edit Bug 15969 - Fetch the message instead of substituting Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:49:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:49:50 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15969 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:49:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:49:50 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17981 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 [Bug 17981] Add the ability to preview generated notice templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 11:50:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 10:50:51 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #33 from Kyle M Hall --- (In reply to Jonathan Druart from comment #27) > I'd like to know what it the plan here, I have done a lot of work on bug > 17981 to make the different notices work with the TT syntax. > This patch will conflict with it. > > It would also be good to get an independent QA point of view. Let's hold this one off until your bug is pushed to master. At that point I'll revisit this and make whatever changes are necessary to integrate them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 12:07:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 11:07:44 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 12:07:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 11:07:46 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 --- Comment #2 from Marcel de Rooy --- Created attachment 71145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71145&action=edit Bug 20126: Add simple test for ModBiblioMarc Just to confirm that we see record length and base address in a record that has been passed through ModBiblioMarc. Test plan: Run the test. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 12:08:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 11:08:40 +0000 Subject: [Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #55 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #54) > This change has interesting side-effects ! > > - $sth = $dbh->prepare("UPDATE biblioitems SET marc=?,marcxml=? WHERE > biblionumber=?"); > - $sth->execute( $record->as_usmarc(), $record->as_xml_record($encoding), > $biblionumber ); > + $sth = $dbh->prepare("UPDATE biblioitems SET marcxml=? WHERE > biblionumber=?"); > + $sth->execute( $record->as_xml_record($encoding), $biblionumber ); > > It seems that since we do no longer call the sub as_usmarc, the automatic > field lengths in the marc are not calculated anymore. > This needs our attention. Will open a new report now! Trivial fix submitted. Please have a look and sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 13:12:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 12:12:40 +0000 Subject: [Koha-bugs] [Bug 20130] New: matching authorities the difference shows biblionumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20130 Bug ID: 20130 Summary: matching authorities the difference shows biblionumber Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org when updating authorities values using record matching, when you click on the diff links ... it shows the biblionumber instead of the authority.. and it is scaring ;) but it works fine! when loading and matching records koha diff link musst show authority record, not bibliographic vs authority uploaded record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 13:39:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 12:39:04 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 13:39:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 12:39:06 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71140|0 |1 is obsolete| | Attachment #71145|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 71146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71146&action=edit Bug 20126: Restore MARC field length calculation in ModBiblioMarc Trivial fix. Problem raised by bug 10455. Test plan: [1] Create or edit biblio record. [2] Save and check leader field lengths in MARC view. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 13:39:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 12:39:09 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 --- Comment #4 from Nick Clemens --- Created attachment 71147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71147&action=edit Bug 20126: Add simple test for ModBiblioMarc Just to confirm that we see record length and base address in a record that has been passed through ModBiblioMarc. Test plan: Run the test. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:13:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:13:06 +0000 Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu --- Comment #16 from Tom Misilo --- Hi, I tried finding it, but is there going to be routes for Course Reserves? For example something that would return the courses, the instructors, and departments? And then something that would find the items that belong to each of the above? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:19:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:19:50 +0000 Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 --- Comment #17 from Tom?s Cohen Arazi --- (In reply to Tom Misilo from comment #16) > Hi, I tried finding it, but is there going to be routes for Course Reserves? > > For example something that would return the courses, the instructors, and > departments? And then something that would find the items that belong to > each of the above? > > Thanks! You should add an entry (or set of entries) on the RFCs page: https://wiki.koha-community.org/wiki/REST_api_RFCs And then ask people to comment or do their counter proposals for an eventual vote on a dev meeting. I'll try to keep an eye on it, keep me informed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:30:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:30:49 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #34 from Jonathan Druart --- It's not pushed to master yet, still in NQA. (In reply to Jonathan Druart from comment #7) > Hi Kyle, > This patch does a bit more than advertise :) > 1/ __MESSAGE_ID__ could be used everywhere, not only for phone notice. I > think this should be covered by tests and documented somewhere (eventually > added to the notice editor) Still valid. > 2/ > + if ( $use_tt ) { > + $letter->{content} =~ s/__MESSAGE_ID__/$message_id/g; > + print $OUT $letter->{content}; > + } > > Don't you think it would be better to retrieve the notice instead of > duplicating the substitution? It would be less error prone. > Btw, why does the script output something different if tt syntax is used? Still need an answer. Does the --tt flag really makes sense? (In reply to Jonathan Druart from comment #27) > It would also be good to get an independent QA point of view. Still needed. I will do it myself if no one else does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:32:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:32:45 +0000 Subject: [Koha-bugs] [Bug 20131] New: Inventory optional filters always shows "For loan" for value 0 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Bug ID: 20131 Summary: Inventory optional filters always shows "For loan" for value 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In inventory, optional filters are build from authorize values categories used for items.notforloan, items.itemlost, items.withdrawn and items.damaged. The bug is that description of value 0 is always "For loan". This seems to be only for "notforloan". Second bug is that if a description exists for "notforloan" value 0, it is not used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:32:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:32:53 +0000 Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:33:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:33:19 +0000 Subject: [Koha-bugs] [Bug 9607] pagination wrong if OPACShowUnusedAuthorities set to "don't show" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9607 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:40:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:40:58 +0000 Subject: [Koha-bugs] [Bug 17787] Suppressed items seems so still be included in number of search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:44:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:44:04 +0000 Subject: [Koha-bugs] [Bug 20031] CGI param in list context warn in guided_reports.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20031 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- I was going to submit it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:44:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:44:11 +0000 Subject: [Koha-bugs] [Bug 20031] CGI param in list context warn in guided_reports.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20031 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:53:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:53:45 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:53:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:53:48 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52310|0 |1 is obsolete| | Attachment #52311|0 |1 is obsolete| | Attachment #52312|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall --- Created attachment 71148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71148&action=edit Bug 14364 - Allow automatically canceled expired waiting holds to fill the next hold Right now, if a library automatically cancels expired waiting holds, a librarian must still re-checkin an item to trap the next available hold for that item. It would be better if the next hold was automatically trapped and the librarians receive an email notification so they can make any changes to the item if need be ( hold area, hold slip in item, etc ). Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with one item 4) Place two holds on that record 5) Check in the item and set it to waiting for the first patron 6) Set ReservesMaxPickUpDelay to 1 7) Enable ExpireReservesMaxPickUpDelay 8) Enable ExpireReservesAutoFill 9) Set an email address in ExpireReservesAutoFillEmail 10) Modify the holds waitingdate to be in the past 11) Run misc/cronjobs/holds/cancel_expired_holds.pl 12) Note the hold is now waiting for the next patron 12) Note a waiting hold notification email was sent to that patron 13) Note a hold changed notification email was sent to the library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:54:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:54:22 +0000 Subject: [Koha-bugs] [Bug 12913] Fix wrong inventory results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20131 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 [Bug 20131] Inventory optional filters always shows "For loan" for value 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:54:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:54:22 +0000 Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12913 --- Comment #1 from Fridolin SOMERS --- "For loan" string has been added by Bug 12913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 [Bug 12913] Fix wrong inventory results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:54:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:54:54 +0000 Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 14:54:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 13:54:57 +0000 Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 --- Comment #2 from Fridolin SOMERS --- Created attachment 71149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71149&action=edit Bug 20131: Inventory optional filters correct "For loan" addition In inventory, optional filters are build from authorize values categories used for items.notforloan, items.itemlost, items.withdrawn and items.damaged. The bug is that description of value 0 is always "For loan". This seems to be only for "notforloan". Second bug is that if a description exists for "notforloan" value 0, it is not used. This patch corrects by adding "For loan" only for "notforloan" authorized values and if there is no 0 value. It changes the description added by code from "ignore" to a more unlikly user defined "__IGNORE__". Test plan: 1) Make sure you have authorized values defined on items.notforloan, say "NFL" category, with at least a value and description but no 0 value 2) Make sure you have authorized values defined on items.itemlost, say "LOST" category, with 0 = "Not lost" and 1 = "Lost" 3) Go to inventory /cgi-bin/koha/tools/inventory.pl 4) Without patch you see "For loan" on both items.notforloan and items.itemlost 5) With patch you see "For loan" only in items.notforloan, you see for items.itemlost : "Not lost" and "Lost" 6) Create in authorized values category "NFL" a value 0 with description "Available" 7) Go to inventory /cgi-bin/koha/tools/inventory.pl 8) Without patch you see "For loan" in items.notforloan for value 0 9) With patch you see "Available" in items.notforloan for value 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:13:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 14:13:48 +0000 Subject: [Koha-bugs] [Bug 20119] Ability to print claims for late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71106|0 |1 is obsolete| | --- Comment #7 from Alex Arnaud --- Created attachment 71150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71150&action=edit Bug 20119 - Ability to print claims for late orders Test plan: - create a notice: module: claimacquisition, code: ACQCLAIM: transport: print - create at least a bookseller, basket and orders, - close the basket and change the closedate to make orders late, - go to cgi-bin/koha/acqui/lateorders.pl, - select one or more order(s) to claim and click on "Print claim", - check the pdf downloaded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:13:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 14:13:53 +0000 Subject: [Koha-bugs] [Bug 20119] Ability to print claims for late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 --- Comment #8 from Alex Arnaud --- Created attachment 71151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71151&action=edit Bug 20119 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:14:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 14:14:27 +0000 Subject: [Koha-bugs] [Bug 20119] Ability to print claims for late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:21:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 14:21:52 +0000 Subject: [Koha-bugs] [Bug 18964] Add a --debugger flag to koha-plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens --- Awesome work all, enhancement, not backported for 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:21:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 14:21:52 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Bug 20079 depends on bug 18964, which changed state. Bug 18964 Summary: Add a --debugger flag to koha-plack https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:55:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 14:55:06 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #39 from Jonathan Druart --- 1. In tests, prefer Koha::IssuingRules->search->update($what_you_need_to_be_set); instead of the DELETE then INSERT. It makes the changes more readable in my opinion. 2. What about "NULL" string values? :) 3. Should not we have the same code for OpacHiddenItems and ItemsDeniedRenewal (and UpdateNotForLoanStatusOnCheckin?) There is also UpdateItemLocationOnCheckin (bug 14576) The minimum would be a new get_rules_from_prefs sub Marking as FQA for discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 15:56:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 14:56:39 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #40 from Jonathan Druart --- We should also tell people that a new item_denied_renewal condition must be added to AUTO_RENEWALS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:09:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:09:31 +0000 Subject: [Koha-bugs] [Bug 19750] Overdues without a fine rule add warnings to log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19750 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Dilan, please do not remove the original commit message when signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:10:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:10:45 +0000 Subject: [Koha-bugs] [Bug 20031] CGI param in list context warn in guided_reports.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20031 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Jonathan Druart --- Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:10:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:10:57 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:11:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:11:04 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:11:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:11:16 +0000 Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use biblio_metadata.timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:11:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:11:25 +0000 Subject: [Koha-bugs] [Bug 19750] Overdues without a fine rule add warnings to log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19750 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:11:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:11:37 +0000 Subject: [Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:13:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:13:36 +0000 Subject: [Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Nick Clemens --- Awesome work all! Enhancement, not backporting to 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:20:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:20:56 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:21:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:21:09 +0000 Subject: [Koha-bugs] [Bug 20126] Saving a biblio does no longer update MARC field lengths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 16:33:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 15:33:54 +0000 Subject: [Koha-bugs] [Bug 20132] New: Source: vs. In: in result list and detail pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20132 Bug ID: 20132 Summary: Source: vs. In: in result list and detail pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In the OPAC we display 773$t in the result list as "Source" 598 599 600 601 602 Source: 603 604 605 606 607 On the detail page the same information is labelled as In: and shows many more subfields. We should improve both displays to be the same in detal/result in OPAC/intranet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:19:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 16:19:11 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by George Williams -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:19:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 16:19:34 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 71152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71152&action=edit Bug 20120 - Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative 3) Apply this patch 4) Attempt to repeat step 1, you should not be able to over-writeoff the fee Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:19:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 16:19:25 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71113|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:25:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 16:25:41 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:51:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 16:51:00 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #223 from Jonathan Druart --- library_groups.created_on and updated_on are DATETIME in kohastructure but timestamp in atomic update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:53:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 16:53:50 +0000 Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #12 from Kyle M Hall --- Created attachment 71154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71154&action=edit Bug 19066 - Add branchcode to accountlines For the purposes of statistics, it appears that it would help many libraries to have branchcode recorded in the accountlines table. For payments, the field would contain the code for the branch the payment was made at. For manual invoices, it would be the code of the library that created the invoice. Test Plan: 1) Apply this patch set 2) Create and pay some fees 3) Note the branchcode for those fees and payments is set to your logged in branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:53:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 16:53:53 +0000 Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #13 from Kyle M Hall --- Created attachment 71155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71155&action=edit Bug 19066 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 17:53:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 16:53:42 +0000 Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65769|0 |1 is obsolete| | Attachment #65770|0 |1 is obsolete| | Attachment #65771|0 |1 is obsolete| | Attachment #67757|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 71153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71153&action=edit Bug 19066 - Update Database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:02:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:02:27 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:02:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:02:39 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #20 from Nick Clemens --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:02:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:02:52 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:03:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:03:03 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:03:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:03:49 +0000 Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron category report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #17 from Nick Clemens --- (In reply to Jonathan Druart from comment #16) > (In reply to Jonathan Druart from comment #10) > > (In reply to Kyle M Hall from comment #9) > > > Created attachment 70030 [details] [review] [review] [review] > > > Bug 19669 [QA Followup] - Remove itemstypes.plugin > > > > > > Signed-off-by: Kyle M Hall > > > > Kyle, Are you sure about that? > > If yes we should remove it on a specific bug report, as well as the > > reports/manager.pl stuffs. > > Oops, I forgot to remove this commit before the push, I am going to revert > it. Reverted last patch for stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:04:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:04:22 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:20:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:20:33 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 [Bug 20133] "Hide patron information" feature should not affect all library groups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:20:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:20:33 +0000 Subject: [Koha-bugs] [Bug 20133] New: "Hide patron information" feature should not affect all library groups Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Bug ID: 20133 Summary: "Hide patron information" feature should not affect all library groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 18403 The feature added by bug 18403 should not apply to all library groups. We should add the ability to enable/disable it only for specific hierarchies. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:28:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:28:15 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:28:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:28:19 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #1 from Jonathan Druart --- Created attachment 71156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71156&action=edit Bug 20133: Add new column library_groups.ft_hide_patron_info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:28:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:28:22 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #2 from Jonathan Druart --- Created attachment 71157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71157&action=edit Bug 20133: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:28:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:28:27 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #3 from Jonathan Druart --- Created attachment 71158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71158&action=edit Bug 20133: UI Changes Add a checkbox to enable/disable the feature for given group of libraries. Important note: Only the top level node can turn the feature, the idea is to avoid confusion, ease testing (by limiting the number of cases) and force libraries to define one tree per feature (Maybe this is wrong, but maybe good to start) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:28:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:28:31 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #4 from Jonathan Druart --- Created attachment 71159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71159&action=edit Bug 20133: Enable/disable the "Hide patron information" feature per group of libraries In order to control this feature correctly it needs to be enabled for group of libraries and not for all groups defined in the system. Groups will be used for different usages and so the feature must not be enabled by default for all of them. Test plan: Retest bug 18403 with the feature turned on/off for a given tree -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:28:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:28:31 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #41 from Katrin Fischer --- (In reply to Jonathan Druart from comment #40) > We should also tell people that a new item_denied_renewal condition must be > added to AUTO_RENEWALS Can you explain that one? People? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:29:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:29:35 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #224 from Jonathan Druart --- Patches do not apply but rebased on https://github.com/joubu/Koha/commits/bug_18403 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:29:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:29:46 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #80 from Jonathan Druart --- Patches do not apply but rebased on https://github.com/joubu/Koha/commits/bug_18403 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 18:41:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 17:41:49 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #42 from Jonathan Druart --- s/people/Koha administrators In the update DB process I guess, a warning to tell this new code is added and must be taken into account in the template of the notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:37:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 18:37:03 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #43 from Katrin Fischer --- Ah! Not sure the reason is available in the template tho. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:50:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 18:50:30 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:50:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 18:50:44 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #59 from Kyle M Hall --- Created attachment 71161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71161&action=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:50:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 18:50:35 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64124|0 |1 is obsolete| | Attachment #64125|0 |1 is obsolete| | Attachment #64126|0 |1 is obsolete| | --- Comment #58 from Kyle M Hall --- Created attachment 71160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71160&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:59:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 18:59:47 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71160|0 |1 is obsolete| | Attachment #71161|0 |1 is obsolete| | --- Comment #60 from Kyle M Hall --- Created attachment 71162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71162&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 19:59:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 18:59:57 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #61 from Kyle M Hall --- Created attachment 71163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71163&action=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 20:02:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 19:02:21 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #62 from Kyle M Hall --- > > I think it's confusing that there are two buttons, 'Add guarantor', 'Set to > patron.' They could potentially mean the same thing. I think we might have > the initial state of this form have only two links: 'Search to add > guarantor' and 'Add guarantor manually' (see attached image). > > Clicking the 'Add manually' link would display the form along with a submit > button, and the "Clear" link would be shown. > > The manual add form should prevent the user from submitting empty data. > > Sorry, I know that's a lot, and I'm willing to help with follow-ups if folks > think these are good ideas. I'm absolutely down with that. Are you able to post a followup for that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 20:05:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 19:05:13 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 20:05:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 19:05:15 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65184|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 71164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71164&action=edit Bug 18958 - If patron has multiple record level holds on one record transferring first hold causes next hold to become item level Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB and LibraryC respectively. Now, a patron places to record level holds for pickup at LibraryD. When any of the items are checked in, that item is trapped to fill the first hold, but a side affect is that the next open hold because item level for the item that was just checked in! This is clearly incorrect and prevents the patron from placing more record level holds on the record. Test Plan: 1. Create and use a patron that can place multiple record level holds per record 2. Create a record with X items, each at a different library 3. Place X 'Next available' holds on the record for the patron using the 'Holds to place' box 4. Rebuild the holds queue 5. Check in LibraryA's copy as LibraryA and confirm the hold 6. Revisit request.pl for the record, notice the next hold in line is now item-specific 7. Attempt to place another hold for your patron, notice that it requires an item-specific hold 8. Apply this patch 9. Repeat steps 1-4 10. Revisit request.pl for the record, notice the next hold in line has *not* become item-specific Signed-off-by: Kyle M Hall Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 20:31:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 19:31:04 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 20:31:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 19:31:07 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58163|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 71165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71165&action=edit Bug 15985 - Include transacting library in fines Some librarians would like to see the library an item was checked out from in the fines table on the fines payment page. Test Plan: 1) Apply this patch 2) Find a patron with overdue items that have fines 3) Browse to the pay fines page 4) Note the new "checked out from" column Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 20:31:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 19:31:35 +0000 Subject: [Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 20:34:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 19:34:41 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71075|0 |1 is obsolete| | --- Comment #3 from Maksim Sen --- Created attachment 71166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71166&action=edit Bug 20098: Inventory tool: CVS export: fix itemlost column It was mapped with "lost" instead of "itemlost". == Test plan == 1. Have a lost item 2. Go to staff:/cgi-bin/koha/tools/inventory.pl 3. Tick "Optional filters" ? "items.itemlost" ? "name of Authorized values for the lost state" 4. Tick "Export to CSV file" 5. Submit 6. Open the CSV 7. Check that the lost item is in the list 8. You should observe that the "Lost status" column is empty for all items This is the problem 9. Apply this patch 10. Click submit to re-export the CSV 11. Open the CSV 12. Check that the lost item is in the list 13. You should observe that the "Lost status" column now filled with the expected values. 14. Smile because it works! :D Signed-off-by: Mark Tompsett Signed-off-by: Maksim Sen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 20:41:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 19:41:47 +0000 Subject: [Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #8 from Tom?s Cohen Arazi --- (In reply to Galen Charlton from comment #7) > Reopening. Saw this happen on a Debian 8.10 system with a fresh install of > 17.11.02 from package. > > A (truly terrible workaround) got Plack running: > > /usr/share/perl5/Mojolicious/Plugin && ln -s /usr/share/koha/lib/Koha Koha > > Version of Mojolicious is 7.21 from the 7.21+dfsg-1~kohadev1 package. I don't manage to reproduce it. I have installed 17.11.02-1 (17.11 repo) on a clean box: $ vagrant init debian/jessie64 only added port mappings to be able to access Koha (in Vagrantfile): config.vm.network :forwarded_port, guest: 80, host: 8080, auto_correct: true # OPAC config.vm.network :forwarded_port, guest: 8080, host: 8081, auto_correct: true # INTRA I then added 8080 to /etc/apache2/ports.conf and tweaked /etc/apache2/sites-enabled/kohadev.conf so intranet uses port 8080. Once I populate the DB I manage to access the API (with and without Plack enabled). The only problem I noticed is that the rewrite bits for the API (in apache) are not working, so I needed to use /api/v1/app.pl/api/v1/patrons to access the API when Plack is disabled. If you still have the VM in which you see the failure, could you try using a + sufix in the V1.pm line that includes the pagination plugin ? I'm not sure right now what was the way to avoid Mojolicious prefixing hte plugin name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:19:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 21:19:25 +0000 Subject: [Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #9 from Marcel de Rooy --- I still have this problem on an older Jessie 8 box. A fresh Jessie install on another box does not have it. Looks to me that it is connected to the install history of various related dependencies to the Mojo stuff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:37:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 21:37:57 +0000 Subject: [Koha-bugs] [Bug 16784] Export suggestions from OPAC as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:38:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 21:38:36 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:38:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 21:38:53 +0000 Subject: [Koha-bugs] [Bug 12219] Purchase Suggestions branch level permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12219 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:40:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 21:40:35 +0000 Subject: [Koha-bugs] [Bug 19885] Allow MaxOpenSuggestions to be set by patron type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19885 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:41:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 21:41:09 +0000 Subject: [Koha-bugs] [Bug 15678] Make pickup branch editable on holds tab on circulation/patron detail screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15678 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 22:43:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 21:43:03 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 23:11:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 22:11:22 +0000 Subject: [Koha-bugs] [Bug 20124] Allow translating did you mean config save message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20124 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71128|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour --- Created attachment 71167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71167&action=edit Bug 20124: Allow translating did you mean config save message When saving the "Did you mean?" setting, a popup with the message "Successfully saved configuration" is shown, but it cannot be translated. Make it translatable. Test plan: 1) Go to Home -> Administration -> Did you mean? 2) Change the settings, click on "Save configuration" 3) Popup with "Successfully saved configuration" 4) Apply patch, update po-files, etc. 5) Check that the msgid "Successfully saved configuration" is in fi-FI-staff-prog.po, and translate the message 6) install the fi-FI language 7) Change your UI language to finnish 8) Repeat 1, 2, 3. You should now see the same popup message translated. Signed-off-by: Pasi Kallinen Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 23:11:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 22:11:19 +0000 Subject: [Koha-bugs] [Bug 20124] Allow translating did you mean config save message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20124 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 2 23:22:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 22:22:45 +0000 Subject: [Koha-bugs] [Bug 7047] renewing serials note not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Maksim Sen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69474|0 |1 is obsolete| | --- Comment #5 from Maksim Sen --- Created attachment 71168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71168&action=edit Bug 7047 - Storing subscription renewal note in suggestion to be displayed on the suggestion page. Additionally I have added a library input field in case the librarian wants to set a library branch whilst renewing a subscription. With the use case being they may have ommitted to set the branchcode whilst creating the subscription. Test plan: 1. Create a subscription (if one does not already exist) 2. Set the RenewSerialAddsSuggestion syspref to 'Add' 3. Renew the item making sure to write in a value into the note field 3. Visit the suggestions page and notice that the note is not displayed for the newly created suggestion 4. Apply patch 5. Repeat step 3. Notice that there is now a new branchcode dropdown box. Select one of your libraries and write in the value into the note field 6. Visit suggestions and notice there is now a 'Suggestion note' column in the table containing the note. Also note that the suggestion has the correct branchcode associated with it Sponsored-By: Catalyst IT Signed-off-by: Maksim Sen -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 3 00:00:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 23:00:10 +0000 Subject: [Koha-bugs] [Bug 19179] Email option for SMSSendDriver is not documented as a valid setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19179 Roch D'Amour changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour at inlibro.com --- Comment #3 from Roch D'Amour --- Could you please rebase the patch, I tried to apply it and got a SHA1 error: fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref). error: could not build fake ancestor. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 3 00:29:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Feb 2018 23:29:10 +0000 Subject: [Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #10 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #9) > I still have this problem on an older Jessie 8 box. A fresh Jessie install > on another box does not have it. Looks to me that it is connected to the > install history of various related dependencies to the Mojo stuff. Can you share that VM image? Send me a link by pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 3 09:27:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Feb 2018 08:27:08 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Just wondering: we configure a delay value for each vendor, can this be used in the script? I think it would make sense and have the delay value as a possible overwrite if you haven't used the field maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 3 09:30:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Feb 2018 08:30:32 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 --- Comment #3 from Katrin Fischer --- It's called grace period actually in the interface. The thought is that you can treat vendors differently. Your local bookstore will be usually faster than something you ordered from outside the country. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 3 12:22:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Feb 2018 11:22:49 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 3 12:23:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Feb 2018 11:23:03 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 3 12:23:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Feb 2018 11:23:04 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Bug 20072 depends on bug 18696, which changed state. Bug 18696 Summary: Change debian/source/format to quilt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 02:18:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 01:18:09 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Mason James --- i finally have a working patch for this, will upload soon(TM)... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:21:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:21:54 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:21:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:21:57 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71078|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 71169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71169&action=edit Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches The warn comes from undefined C4::Context->userenv->{branch}. Can be triggered by calling mainpage.pl when being logged out in staff. Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:22:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:22:10 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- localhost:8081/cgi-bin/koha/mainpage.pl did it for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:32:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:32:27 +0000 Subject: [Koha-bugs] [Bug 20109] Allow translating "Remove" in Add Fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:32:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:32:32 +0000 Subject: [Koha-bugs] [Bug 20109] Allow translating "Remove" in Add Fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71088|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71170&action=edit Bug 20109: Allow translating "Remove" in Add Fund When a user has been added to the fund, the link to "Remove" that user is not translatable. Test plan: 1) Install language xx-YY 2) Go to Home -> Administration -> Budgets -> Funds -> Add Fund 3) Add a user to the fund 4) Notice how the "Remove" link after the user's name is not translated 5) Apply patch 6) Look in xx-YY-staff-prog.po, and if needed, translate the msgid "Remove" 7) Update and reinstall the language 8) Do 2 and 3 again. The "Remove" link should now be translated. Signed-off-by: Pasi Kallinen Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=10209 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:37:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:37:42 +0000 Subject: [Koha-bugs] [Bug 20124] Allow translating did you mean config save message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:37:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:37:45 +0000 Subject: [Koha-bugs] [Bug 20124] Allow translating did you mean config save message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71167|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71171&action=edit Bug 20124: Allow translating did you mean config save message When saving the "Did you mean?" setting, a popup with the message "Successfully saved configuration" is shown, but it cannot be translated. Make it translatable. Test plan: 1) Go to Home -> Administration -> Did you mean? 2) Change the settings, click on "Save configuration" 3) Popup with "Successfully saved configuration" 4) Apply patch, update po-files, etc. 5) Check that the msgid "Successfully saved configuration" is in fi-FI-staff-prog.po, and translate the message 6) install the fi-FI language 7) Change your UI language to finnish 8) Repeat 1, 2, 3. You should now see the same popup message translated. Signed-off-by: Pasi Kallinen Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:44:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:44:12 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:49:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:49:59 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71111|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 71172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71172&action=edit Bug 11827: Untranslatable "Cancel Rating" in jQuery rating plugin - Make the "Cancel rating" text translatable (and change capitalization to conform to Koha coding guidelines) - Improve the two other messages to use formatted strings instead of concatenation. - Use the exact same text for the "your rating" text, so it only appears once in the po-file. Test plan: 1. See that the "Cancel rating" -text doesn't appear in po/xx-YY-opac-bootstrap.po 2. Note how there's two versions of the your rating -text ("your rating: %s, " and "your rating:") in the po-file 3. Apply patch 4. Update the xx-YY translation 5. Check the po-file. It should now contain the "Cancel rating" and a single "your rating: %s, " 6. Translate those texts, and update & install the language. 7. Go to the OPAC detail page of a biblio, and check the rating texts. 8. Hovering over the rating minus -sign should show the translated "Cancel rating" 9. Check that the text after the stars is correct with and without your rating Signed-off-by: Pasi Kallinen Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:55:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:55:45 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71166|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71173&action=edit Bug 20098: Inventory tool: CVS export: fix itemlost column It was mapped with "lost" instead of "itemlost". == Test plan == 1. Have a lost item 2. Go to staff:/cgi-bin/koha/tools/inventory.pl 3. Tick "Optional filters" ? "items.itemlost" ? "name of Authorized values for the lost state" 4. Tick "Export to CSV file" 5. Submit 6. Open the CSV 7. Check that the lost item is in the list 8. You should observe that the "Lost status" column is empty for all items This is the problem 9. Apply this patch 10. Click submit to re-export the CSV 11. Open the CSV 12. Check that the lost item is in the list 13. You should observe that the "Lost status" column now filled with the expected values. 14. Smile because it works! :D Signed-off-by: Mark Tompsett Signed-off-by: Maksim Sen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 12:55:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 11:55:42 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 13:21:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 12:21:50 +0000 Subject: [Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Looking at the logs the interface is shown as 'opac', should this not be command-line? Otherwise patches work ok, but please fix the patch subjects to match: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 13:24:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 12:24:18 +0000 Subject: [Koha-bugs] [Bug 20110] Adding same user multiple times to same budget fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20110 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 13:24:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 12:24:21 +0000 Subject: [Koha-bugs] [Bug 20110] Adding same user multiple times to same budget fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20110 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71099|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71174&action=edit Bug 20110: Adding same user multiple times to same budget In javascript, using indexOf to test if a number exists in an array of strings doesn't work, and makes it possible to add the same user multiple times into the same budget fund. Make borrowernumber into string and compare that instead. Test plan: 1) Go to Home -> Administration -> Budgets -> Funds -> Add Fund 2) Add a user to the fund 3) Try to add the same user again to the same fund. No error. 4) Apply patch 5) Do 1, 2, and 3 again. You should now get an error message saying the user is already in the list. Signed-off-by: Pasi Kallinen Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 13:29:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 12:29:10 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71087|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 71175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71175&action=edit Bug 12932: When all modules installed, Perl version check ignored The description in comment #0 is quite true, because the scope of the $checkmodule variable is local to just the module checking. If we change the scope, we can include the perl check as part of the new scope, and thus properly set its value. As Debian Jessie, Stretch and Ubuntu Xenial all have good versions of Perl by default, the easiest way to test this is to: - make sure to have some optional modules not installed. - change the system preference 'Version' to one just under the current version in your SQL client. - modify the version check line to 5.030000 - restart_all and try going to the staff client. -- This should not inform you that your perl version is bad. - git reset hard back to origin/master - apply the patch - modify the version check line to 5.030000 - change the system preference 'Version' to one just under the current version in your SQL client. - restart_all and try going to the staff client. -- This should trigger the patch, and you should be informed your perl version is bad. - git reset hard back to origin/master - apply the patch - run koha qa test tools Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 13:29:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 12:29:06 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 13:56:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 12:56:58 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71152|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71176&action=edit Bug 20120: Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative 3) Apply this patch 4) Attempt to repeat step 1, you should not be able to over-writeoff the fee Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 13:56:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 12:56:54 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 13:58:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 12:58:25 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71176|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 71177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71177&action=edit Bug 20120: Prevent individual writeoffs to have an amount more than the amount of the fee In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit. Test Plan: 1) Attempt to writeoff a single fee, set the amount input to more than the amount of the fee. 2) Note the writeoff makes the fee go negative 3) Apply this patch 4) Attempt to repeat step 1, you should not be able to over-writeoff the fee Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 13:59:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 12:59:09 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Fixed commit message, please keep on mind: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:04:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:04:27 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |charlotte.cordwell123 at gmail |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:05:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:05:58 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 --- Comment #3 from Katrin Fischer --- Created attachment 71178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71178&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:06:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:06:52 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:06:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:06:55 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70903|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71179&action=edit Bug 20020: use Modern::Perl in XT scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; author/podcorrectness.t author/show-template-structure.pl author/translatable-templates.t author/valid-templates.t find-license-problems fix-old-fsf-address single_quotes.t verify-debian-docbook.t Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:09:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:09:46 +0000 Subject: [Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70902|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71180&action=edit Bug 20019: use Modern::Perl in misc perl scripts Test Plan: Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; services/itemrecorddisplay.pl suggestion/suggestion.pl tags/list.pl tags/review.pl virtualshelves/sendshelf.pl help.pl changelanguage.pl koha_perl_deps.pl debian/bd-to-depends debian/build-git-snapshot debian/list-deps docs/CAS/CASProxy/examples/koha_webservice.pl docs/CAS/CASProxy/examples/proxy_cas.pl docs/CAS/CASProxy/examples/proxy_cas_callback.pl docs/CAS/CASProxy/examples/proxy_cas_data.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:10:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:10:00 +0000 Subject: [Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |terauhina.jackson at gmail.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:09:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:09:42 +0000 Subject: [Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:10:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:10:38 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |zoebennett1308 at gmail.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:11:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:11:34 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:11:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:11:37 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 --- Comment #3 from Katrin Fischer --- Created attachment 71181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71181&action=edit Bug 20018: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins perl scripts enqueue_koc.pl list.pl process.pl process_koc.pl service.pl https://bugs.koha-community.org/show_bug.cgi?id=20018 Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:12:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:12:45 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |jwayway at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:14:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:14:42 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:14:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:14:46 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70900|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71182&action=edit Bug 20017: use Modern::Perl in Tools perl scripts Test plan: Check that the following files don't contain use strict; use warnings; and have use Modern::Perl instead. background-job-progress.pl batchMod.pl copy-holidays.pl exceptionHolidays.pl holidays.pl import_borrowers.pl koha-news.pl letter.pl manage-marc-import.pl newHolidays.pl overduerules.pl quotes-upload.pl quotes.pl quotes/quotes-upload_ajax.pl quotes/quotes_ajax.pl scheduler.pl stage-marc-import.pl upload-cover-image.pl Also the credits have been added to newHolidays.pl https://bugs.koha-community.org/show_bug.cgi?id=20017 Signed-off-by: Jon Knight -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:15:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:15:28 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 --- Comment #4 from Katrin Fischer --- Good job! Please always be careful to put the right bug number in the commit message as this will be used to generate the release notes. Fixed it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:15:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:15:44 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70901|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:16:18 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 --- Comment #4 from Katrin Fischer --- Good job! Please always be careful to write the right bug number in the commit message as this will be used to generate the release notes. Fixed it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:20:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:20:01 +0000 Subject: [Koha-bugs] [Bug 20016] use Modern::Perl in svc scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:20:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:20:04 +0000 Subject: [Koha-bugs] [Bug 20016] use Modern::Perl in svc scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70899|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71183&action=edit Bug 20016: use Modern::Perl in svc scripts Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins svc scripts authentication bib bib_profile checkouts config/systempreferences import_bib new_bib https://bugs.koha-community.org/show_bug.cgi?id=20016 Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:21:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:21:02 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |jwayway at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:22:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:22:18 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:22:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:22:21 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70898|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71184&action=edit Bug 20015: use Modern::Perl in Serials perl script Test plan: Check that use strict; use warnings; doesn't exist in the following files and use Modern::Perl; is written instead. acqui-search-result.pl acqui-search.pl checkexpiration.pl reorder_members.pl routing-preview.pl routing.pl serials-collection.pl serials-edit.pl subscription-add.pl subscription-bib-search.pl subscription-renew.pl viewalerts.pl Signed-off-by: Jon Knight -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:26:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:26:11 +0000 Subject: [Koha-bugs] [Bug 20013] use Modern::Perl in Reserves perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:26:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:26:15 +0000 Subject: [Koha-bugs] [Bug 20013] use Modern::Perl in Reserves perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70824|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71185&action=edit Bug 20013: use Modern::Perl in Reserve perl script Test plan: Check the following files that use strict; use warnings; doesn't exist and use Modern::Perl; is written instead. modrequest.pl modrequest_suspendall.pl placerequest.pl Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:26:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:26:44 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71184|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71186&action=edit Bug 20015: use Modern::Perl in Serials perl script Test plan: Check that use strict; use warnings; doesn't exist in the following files and use Modern::Perl; is written instead. acqui-search-result.pl acqui-search.pl checkexpiration.pl reorder_members.pl routing-preview.pl routing.pl serials-collection.pl serials-edit.pl subscription-add.pl subscription-bib-search.pl subscription-renew.pl viewalerts.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:27:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:27:34 +0000 Subject: [Koha-bugs] [Bug 20016] use Modern::Perl in svc scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |zoebennett1308 at gmail.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:28:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:28:35 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |charlotte.cordwell123 at gmail |ity.org |.com CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:29:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:29:38 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:29:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:29:42 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70897|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71187&action=edit Bug 20012: use Modern::Perl in Reports perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; borrowers_out.pl cat_issues_top.pl catalogue_out.pl catalogue_stats.pl dictionary.pl issues_avg_stats.pl issues_stats.pl itemslost.pl manager.pl reports-home.pl serials_stats.pl stats.print.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:31:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:31:39 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:31:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:31:42 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70890|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71188&action=edit Bug 20011: use Modern::Perl in plugins perl scripts Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins perl scripts plugins-home.pl plugins-uninstall.pl plugins-upload.pl run.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:31:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:31:54 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |zoebennett1308 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:32:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:32:41 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |gracesmythh at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:33:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:33:26 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70891|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71189&action=edit Bug 20010: use Modern::Perl in Patroncards perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; create-pdf.pl edit-batch.pl edit-layout.pl edit-profile.pl edit-template.pl home.pl image-manage.pl manage.pl print.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:33:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:33:51 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:35:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:35:18 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 --- Comment #4 from Katrin Fischer --- Created attachment 71190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71190&action=edit Bug 20009: use Modern::Perl in Members perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; boraccount.pl default_messageprefs.pl deletemem.pl files.pl mancredit.pl maninvoice.pl member-flags.pl member-password.pl memberentry.pl members-home.pl members-update-do.pl moremember.pl notices.pl pay.pl paycollect.pl printfeercpt.pl printinvoice.pl printslip.pl readingrec.pl routing-lists.pl setstatus.pl update-child.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:35:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:35:41 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |terauhina.jackson at gmail.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:36:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:36:10 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:36:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:36:12 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70892|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:40:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:40:37 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:40:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:40:41 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70840|0 |1 is obsolete| | Attachment #70841|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 71191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71191&action=edit Bug 20000: use Modern::Perl in installer perl scripts Test Plan: - Check that it now says 'use Modern::Perl' and not 'use strict; use warnings;' in the following installer perl scripts: data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 14:41:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 13:41:19 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Squashed patches as both had the same author and were signed by Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:08:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:08:34 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |terauhina.jackson at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:10:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:10:05 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:10:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:10:08 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70893|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71192&action=edit Bug 19998: use Modern::Perl in error perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; 400.pl 401.pl 402.pl 403.pl 404.pl 500.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:10:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:10:30 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |charlotte.cordwell123 at gmail |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:11:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:11:59 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:12:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:12:03 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70894|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 71193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71193&action=edit Bug 19997: use Modern::Perl in Circulation perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; bookcount.pl branchoverdues.pl branchtransfers.pl circulation.pl hold-transfer-slip.pl reserveratios.pl returns.pl selectbranchprinter.pl transfer-slip.pl transferstoreceive.pl view_holdsqueue.pl waitingreserves.pl ypattrodue-attr-search-authvalue.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:13:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:13:13 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |gracesmythh at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:28:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:28:54 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:28:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:28:57 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70884|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71194&action=edit Bug 19996: use Modern::Perl in cataloguing perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; addbiblio.pl addbooks.pl additem.pl linkitem.pl moveitem.pl value_builder/normarc_field_007.pl value_builder/normarc_field_008.pl value_builder/normarc_leader.pl value_builder/unimarc_field_010.pl value_builder/unimarc_field_100.pl value_builder/unimarc_field_105.pl value_builder/unimarc_field_106.pl value_builder/unimarc_field_110.pl value_builder/unimarc_field_115a.pl value_builder/unimarc_field_115b.pl value_builder/unimarc_field_116.pl value_builder/unimarc_field_117.pl value_builder/unimarc_field_120.pl value_builder/unimarc_field_121a.pl value_builder/unimarc_field_121b.pl value_builder/unimarc_field_122.pl value_builder/unimarc_field_123a.pl value_builder/unimarc_field_123d.pl value_builder/unimarc_field_123e.pl value_builder/unimarc_field_123f.pl value_builder/unimarc_field_123g.pl value_builder/unimarc_field_123i.pl value_builder/unimarc_field_123j.pl value_builder/unimarc_field_124.pl value_builder/unimarc_field_124a.pl value_builder/unimarc_field_124b.pl value_builder/unimarc_field_124c.pl value_builder/unimarc_field_124d.pl value_builder/unimarc_field_124e.pl value_builder/unimarc_field_124f.pl value_builder/unimarc_field_124g.pl value_builder/unimarc_field_125.pl value_builder/unimarc_field_125a.pl value_builder/unimarc_field_125b.pl value_builder/unimarc_field_126.pl value_builder/unimarc_field_126a.pl value_builder/unimarc_field_126b.pl value_builder/unimarc_field_127.pl value_builder/unimarc_field_128a.pl value_builder/unimarc_field_128b.pl value_builder/unimarc_field_128c.pl value_builder/unimarc_field_130.pl value_builder/unimarc_field_135a.pl value_builder/unimarc_field_140.pl value_builder/unimarc_field_141.pl value_builder/unimarc_field_210c.pl value_builder/unimarc_field_210c_bis.pl value_builder/unimarc_field_225a.pl value_builder/unimarc_field_4XX.pl value_builder/unimarc_field_686a.pl value_builder/unimarc_field_700-4.pl value_builder/unimarc_leader.pl z3950_auth_search.pl z3950_search.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:29:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:29:24 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 --- Comment #4 from Katrin Fischer --- Created attachment 71195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71195&action=edit Bug 19996: (QA follow-up) Remove commented use warnings; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:36:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:36:37 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |zoebennett1308 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:39:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:39:34 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71195|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 71196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71196&action=edit Bug 19996: (QA follow-up) Remove commented use warnings; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:41:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:41:30 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:41:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:41:34 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70895|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71197&action=edit Bug 19995: use Modern::Perl in Catalogue perl scripts Test Plan: - Check that it now says 'use Modern::Perl;' and not 'use strict; use warnings;' in the following catalogue perl scripts. MARCdetail.pl export.pl image.pl imageviewer.pl issuehistory.pl labeledMARCdetail.pl moredetail.pl search.pl showmarc.pl updateitem.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:43:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:43:37 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:43:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:43:41 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70828|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71198&action=edit Bug 19993: use Modern::Perl in Acquisition perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; acqui-home.pl addorder.pl basketgroup.pl basketheader.pl booksellers.pl check_budget_total.pl check_duplicate_barcode_ajax.pl edi_ean.pl edifactmsgs.pl edimsg.pl finishreceive.pl histsearch.pl invoice.pl invoices.pl neworderbiblio.pl neworderempty.pl newordersuggestion.pl ordered.pl orderreceive.pl parcel.pl parcels.pl pdfformat/layout2pages.pm pdfformat/layout2pagesde.pm pdfformat/layout3pages.pm pdfformat/layout3pagesfr.pm spent.pl supplier.pl uncertainprice.pl updatesupplier.pl z3950_search.pl Signed-off-by: Owen Leonard Corrected a single semicolon in edimsg.pl during signoff. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:44:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:44:37 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jwayway at hotmail.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:45:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:45:48 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:45:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:45:52 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70896|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71199&action=edit Bug 19992: use Modern::Perl in Admin perl scripts Test plan: Check use warnings; use strict doesn't exist and use Modern::Perl is written instead in the following files: admin/admin-home.pl admin/aqcontract.pl admin/aqplan.pl admin/auth_tag_structure.pl admin/branch_transfer_limits.pl admin/check_budget_parent.pl admin/check_parent_total.pl admin/checkmarc.pl admin/classsources.pl admin/clone-rules.pl admin/didyoumean.pl admin/edi_accounts.pl admin/edi_ean_accounts.pl admin/import_export_framework.pl admin/item_circulation_alerts.pl admin/marctagstructure.pl admin/matching-rules.pl admin/printers.pl admin/smart-rules.pl admin/systempreferences.pl admin/transport-cost-matrix.pl Signed-off-by: Jon Knight Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20020, 20019, 20018, 20017, | |20016, 20015, 20012, 20013, | |20011, 20010, 20009, 20000, | |19998, 19997, 19996, 19995, | |19993, 19992 --- Comment #27 from Katrin Fischer --- This bug hasn't seen much attention for a few years now. During the Open Source Academy 2018 the students switched a lot (all?) scripts over to use Modern::Perl; instead of the separate use strict; use warnings; pragmas. I think by not using use warnings; in those scripts, we have possibly been hiding problems and switching it on globally might now be the way to go. We can keep an eye on the logs as we are still rather early in the release cycle and keep fixing warns as we find them. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 [Bug 19992] use Modern::Perl in Admin perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 [Bug 19993] use Modern::Perl in Acquisition perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 [Bug 19995] use Modern::Perl in Catalogue perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 [Bug 19996] use Modern::Perl in cataloguing perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 [Bug 19997] use Modern::Perl in Circulation perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 [Bug 19998] use Modern::Perl in error perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 [Bug 20000] use Modern::Perl in installer perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 [Bug 20009] use Modern::Perl in Members perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 [Bug 20010] use Modern::Perl in Patroncards perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 [Bug 20011] use Modern::Perl in plugins perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 [Bug 20012] use Modern::Perl in Reports perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 [Bug 20013] use Modern::Perl in Reserves perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 [Bug 20015] use Modern::Perl in Serials perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 [Bug 20016] use Modern::Perl in svc scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 [Bug 20017] use Modern::Perl in Tools perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 [Bug 20018] use Modern::Perl in offline circulation perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 [Bug 20019] use Modern::Perl in miscellaneous perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 [Bug 20020] use Modern::Perl in XT scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20013] use Modern::Perl in Reserves perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20016] use Modern::Perl in svc scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:51:50 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:56:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:56:43 +0000 Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Internet Explorer 7, release notes| |released in 2006, is no | |longer supported by Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:57:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:57:13 +0000 Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 15:57:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 14:57:17 +0000 Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70818|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 71200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71200&action=edit Bug 20062: Remove support for Internet Explorer 7 in the staff client This patch removes JavaScript files which were added to support Internet Explorer 7. Templates which included the files have been modified accordingly. To test, apply the patch and clear your browser cache if necessary. Perform a catalog search in the staff client and click through to view one of the search results. The search results navigation menu in the left-hand sidebar should work correctly. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:22:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:22:18 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- 1) With the patch applied the paging (next page, previous page) when ordering from z39.50 are no longer working. 2) Transferring from the invoice page opens in a new tab, while transferring from the basket page opens a new window - shouldn't both behave the same? Outside of the scope of this bug, as it's the same with and without the patches. Owen, should we file a new bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:22:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:22:29 +0000 Subject: [Koha-bugs] [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:26:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:26:22 +0000 Subject: [Koha-bugs] [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:26:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:26:25 +0000 Subject: [Koha-bugs] [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70616|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71201&action=edit Bug 19989: Fix the FIXME so that new requests replace old request Test: 1) Make a change to the user in the OPAC 2) In the staff client make sure this is the only request Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:26:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:26:37 +0000 Subject: [Koha-bugs] [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |zoebennett1308 at gmail.com CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:28:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:28:28 +0000 Subject: [Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Depends on 19709 which is not signed off yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:31:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:31:40 +0000 Subject: [Koha-bugs] [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70668|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71202&action=edit Bug 19960: Update popup window templates to use Bootstrap grid: Add to list This patch updates add-to-list template to use the Bootstrap grid instead of the YUI grid. To test, open the detail page for a bibliographic record in the staff client and choose "Add to -> List." The resulting pop-up window should look correct. Signed-off-by: Zoe Bennett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:31:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:31:37 +0000 Subject: [Koha-bugs] [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:33:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:33:52 +0000 Subject: [Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Depends on a bug not signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:34:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:34:20 +0000 Subject: [Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Same here - depends on a bug not signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:38:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:38:39 +0000 Subject: [Koha-bugs] [Bug 19950] Update popup window templates to use Bootstrap grid: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:38:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:38:43 +0000 Subject: [Koha-bugs] [Bug 19950] Update popup window templates to use Bootstrap grid: Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70677|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71203&action=edit Bug 19950: Update popup window templates to use Bootstrap grid: Serials This patch updates the two serials templates to use the Bootstrap grid instead of the YUI grid. Apply the patch and go to Serials and locate an existing subscription. - Click the "Edit routing list" in the sidebar. - Save the routing list, and click "Save and preview routing slip." - The routing slip preview should look correct and buttons should work correctly. - When viewing the details of a subscription, click the "Renew" button in the toolbar. The popup window should look correct. Signed-off-by: Zoe Bennett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:39:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:39:16 +0000 Subject: [Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |BLOCKED --- Comment #3 from Katrin Fischer --- Dependency requires sign-off still. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:39:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:39:35 +0000 Subject: [Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Dependency is Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:49:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:49:37 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:49:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:49:40 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70716|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 71204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71204&action=edit Bug 19946: Update popup window templates to use Bootstrap grid: Authority Z39.50 search This patch updates the authority Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Some capitalization corrections, better handling. This patch does not fix Bug 17119. To test, apply the patch and go to Authorities -> New from Z39.50. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com> Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 16:54:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 15:54:01 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19932-70-BJVkGsuOqW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- With the patch the save/cancel options are outside of the visible area. (Firefox Quantum 58 on Ubuntu). Without the patch it's ok. Could you take another look? Everything else seems to work perfectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 17:18:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 16:18:53 +0000 Subject: [Koha-bugs] [Bug 20035] Switch single-column templates to Bootstrap grid: Patron clubs In-Reply-To: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20035-70-nQKRidvxiJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70848|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71205&action=edit Bug 20035: Switch single-column templates to Bootstrap grid: Patron clubs This patch updates two single-column Patron clubs templates to use the Bootstrap grid. - clubs/clubs-add-modify.tt - Tools -> Patron clubs -> New club. - clubs/templates-add-modify.tt - Tools -> Patron clubs -> New club template. Also changed in this file: Markup corrections. Label "for" attribute should match the form field's id attribute. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 17:18:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 16:18:50 +0000 Subject: [Koha-bugs] [Bug 20035] Switch single-column templates to Bootstrap grid: Patron clubs In-Reply-To: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20035-70-XE28s8Jtoz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 17:27:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 16:27:39 +0000 Subject: [Koha-bugs] [Bug 20036] Switch single-column templates to Bootstrap grid: Offline circulation In-Reply-To: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20036-70-YgJxN9kSR3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 17:27:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 16:27:43 +0000 Subject: [Koha-bugs] [Bug 20036] Switch single-column templates to Bootstrap grid: Offline circulation In-Reply-To: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20036-70-b1UF6oWOeG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70849|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71206&action=edit Bug 20036: Switch single-column templates to Bootstrap grid: Offline circulation This patch updates three single-column offline circulation templates to use the Bootstrap grid. - offline_circ\process_koc.tt - Circulation -> Upload offline circulation. - offline_circ\enqueue_koc.tt - After uploading offline circulation file -> Add to offline circulation queue. The confirmation page is the page to be tested. - offline_circ\list.tt - From the confirmation page -> View pending offline circulation actions. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 17:31:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 16:31:25 +0000 Subject: [Koha-bugs] [Bug 20034] Switch single-column templates to Bootstrap grid: Circulation In-Reply-To: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20034-70-Ydlz5ubfRy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20034 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 17:31:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 16:31:28 +0000 Subject: [Koha-bugs] [Bug 20034] Switch single-column templates to Bootstrap grid: Circulation In-Reply-To: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20034-70-yGTSN7DiI3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20034 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70838|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71207&action=edit Bug 20034: Switch single-column templates to Bootstrap grid: Circulation This patch updates two single-column circulation templates to use the Bootstrap grid. - circulation-home.tt - Circulation home page. This patch corrects what appears to have been a long-broken three-column layout. - article-requests.tt - Article requests list. Turn on the ArticleRequests system preference if necessary. Go to Circulation -> Article requests. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 18:53:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 17:53:31 +0000 Subject: [Koha-bugs] [Bug 20033] Switch single-column templates to Bootstrap grid: Catalog In-Reply-To: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20033-70-ZIwOKuyxvb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20033 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 18:53:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 17:53:35 +0000 Subject: [Koha-bugs] [Bug 20033] Switch single-column templates to Bootstrap grid: Catalog In-Reply-To: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20033-70-lhttox3BJt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20033 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70844|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71208&action=edit Bug 20033: Switch single-column templates to Bootstrap grid: Catalog This patch updates a few catalog-related single-column templates to use the Bootstrap grid. - basket/basket.tt - The staff client cart. Add some items to the cart and open the cart. - catalogue/advsearch.tt - The advanced search page. - catalogue/itemsearch.tt - The item search page, both the initial form and the search results. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 19:00:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 18:00:51 +0000 Subject: [Koha-bugs] [Bug 20032] Switch single-column templates to Bootstrap grid: Tools In-Reply-To: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20032-70-UIA0eu0G3J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 19:00:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 18:00:55 +0000 Subject: [Koha-bugs] [Bug 20032] Switch single-column templates to Bootstrap grid: Tools In-Reply-To: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20032-70-MXquVWX2bp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70819|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71209&action=edit Bug 20032: Switch single-column templates to Bootstrap grid: Tools This patch updates several single-column Tools templates to use the Bootstrap grid. - batchMod-del.tt - Tools -> Batch item deletion -> Submit barcodes or item numbers for deletion. The grid is changed for the results and confirmation screens. - batchMod-edit.tt - Tools -> Batch item modification -> Submit barcodes or item numbers for modification. The grid is changed for the results and confirmation screens. - koha-news.tt - Tools -> News -> Edit or create a new news item. The grid is changed for the edit screen. - letter.tt - Tools -> Notices and Slips -> Edit or create a notice. The grid is changed for the edit screen. Each of these pages should look correct. The News and Notices page should have a single centered column with wide margins on either side. At lower browser widths the margins should disappear. The batch mod screens should be displayed at full screen width. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 19:02:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 18:02:12 +0000 Subject: [Koha-bugs] [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons In-Reply-To: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19982-70-t7P1A5YPHd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |BLOCKED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Depends on bug that still requires sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:07:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:07:20 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-6csUsQYeBi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've tried, but failed: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ ./installer/data/mysql/updatedatabase.pl DEV atomic update: bug_18336_utf8mb4.perl Upgrade to XXX done (Bug 18336: Convert DB tables to utf8mb4) kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/www/search_utf8.t t/db_dependent/www/auth_values_input_www.t t/db_dependent/www/search_utf8.t ............ 1/99 Link not found at t/db_dependent/www/search_utf8.t line 146. # Looks like your test exited with 255 just after 4. t/db_dependent/www/search_utf8.t ............ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 95/99 subtests t/db_dependent/www/auth_values_input_www.t .. 3/34 Error POSTing http://kohadev-intra.myDNSname.org:8080/cgi-bin/koha/admin/authorised_values.pl: Internal Server Error at t/db_dependent/www/auth_values_input_www.t line 85. # Looks like your test exited with 255 just after 5. t/db_dependent/www/auth_values_input_www.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 29/34 subtests Test Summary Report ------------------- t/db_dependent/www/search_utf8.t (Wstat: 65280 Tests: 4 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 99 tests but ran 4. t/db_dependent/www/auth_values_input_www.t (Wstat: 65280 Tests: 5 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 34 tests but ran 5. Files=2, Tests=9, 7 wallclock secs ( 0.03 usr 0.00 sys + 2.71 cusr 0.80 csys = 3.54 CPU) Result: FAIL Did I miss something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:13:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:13:38 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-J2LXr7oJap@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm it worked on a clean db (of course) :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:20:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:20:54 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-ZtqtJSOnR8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Without the sample data the tests fail - but I guess that's ok. Passing QA on that assumption, please stop me if I am mistaken ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:23:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:23:18 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-rhGx9oZI56@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Need to fix the QA tools? FAIL installer/data/mysql/kohastructure.sql FAIL charset_collate The table columns_settings does not have the current charset collate (see bug 11944) ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:24:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:24:10 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-RmB1f8AUOn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70904|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71210&action=edit Bug 18336: Full stack tests for supplemental UTF-8 chars This patch introduces tests for Koha's support for 4-byte supplemental UTF-8 chars. encoding/decoding tools handle this gracefuly. The missing piece is the MySQL DB backend. The tests in this patch: - Adds a couple records for each flavour (MARC21 and UNIMARC) so search_utf8.t tests 4-byte chars are handled correctly - Adds emoji testing in auth_values_input_www.t To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => FAIL: It should fail if the DB hasn't been migrated into using utf8mb4 Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:24:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:24:16 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-EhDBdFEdRY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70905|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71211&action=edit Bug 18336: SET NAMES utf8mb4 in Koha::Database Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:24:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:24:28 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-Ri1OoXjZ2M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70907|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71213&action=edit Bug 18336: DBIC update Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:24:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:24:22 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-l6pyN6F2Ov@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70906|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71212&action=edit Bug 18336: Convert schema from utf8 to utf8mb4 This patch adapts the DB structure so it uses utf8mb4 encoding and utf8mb4_generic_ci collation. Indexes for columns of type VARCHAR with prefix lenght higher than 191 are shortened because of the smaller max index lenght for utf8mb4 Note: please beware that testing this patchset risks your data and the patchset includes reinitializing the DB. To test: - Be on the master branch - Have a clean DB: $ reset_all (y) - Apply the first patch (Unit tests) - Run: $ kshell k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => FAIL: Tests fail because Koha doesn't support supplemental (UTF-8) chars. - Apply the rest of this patchset - Upgrade the schema: $ kshell k$ perl installer/data/mysql/updatedatabase.pl - Run the tests: k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => SUCCESS: Tests pass! - Now start from a clean DB - Run: $ reset_all (y) - Run the tests: k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => SUCCESS: Tests pass! Verify you can use emojis all over the place (MARC records, AV descriptions, etc). Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:24:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:24:32 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-N5xud2NhkW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70908|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71214&action=edit Bug 18336: Atomic update Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:24:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:24:36 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-IfEwJVBFGP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70909|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71215&action=edit Bug 18336: Add explicit index names to kohastructure.sql This patch just adds an explicit index name to the search_marc_map table. The atomicupdate on this patchset is a good example of why we better have them. Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:24:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:24:42 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-VsYElY7PJx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71022|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71216&action=edit Bug 18336: Fix missing utf8_bin > utf8mb4_bin translation in kohastructure.sql Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:26:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:26:24 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-Il7CmnvXvi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:31:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:31:11 +0000 Subject: [Koha-bugs] [Bug 20080] Test for utf8mb4 encoding and collation In-Reply-To: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20080-70-IMOxQrjZUo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, have a problem with this one: An error occurred : Use of uninitialized value $_ in concatenation (.) or string at /home/vagrant/qa-test-tools/QohA/File/Specific/Kohastructure.pm line 39. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 21:33:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 20:33:08 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-Tpi8eishfd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thought a bit more about it - could we get a second QA opinion please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 4 23:50:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Feb 2018 22:50:00 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-WlE8d4fOIh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #36 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #25) > Hm it worked on a clean db (of course) :) If by clean you mean the result of reset_all, then the failure might be related to not restarting the plack process, then the DB connection isn't properly configured. It is important to be sure the upgrade process goes smooth! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 09:17:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 08:17:44 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: <bug-19908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19908-70-12evtDhHA1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71217&action=edit Bug 18908: Do not use .optional in password match validation function Test plan: 0) Aplly only first patch 1) You will be able to submit a from on member-password.pl even if the passwords don't match 2) Apply this patch -> you can't be able to submit the form if the paswords don't match, but you'll be able to submit the form when password fields are blank -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 09:20:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 08:20:53 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: <bug-19908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19908-70-NpA7L93VFX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Jonathan Druart from comment #2) > On members/member-password.pl I can submit the form without confirming the > password. Should be fixed by this second patch. This is restoring the original behavior, but there is still room for imporvements: It is not possible to change only userid from here. When you submit the blank passwords, then you get the same form again - not very useful I think. So probably adding the ability to change only userid from here would be nice enhancement here I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 09:38:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 08:38:16 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: <bug-15985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15985-70-MZC1KWMG60@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Sorry Kyle, but not ready to pass QA yet: first, thing reported by qa tools: FAIL Koha/Checkout.pm FAIL pod in file Koha/Checkout.pm Unknown command 'head' *** ERROR: FAIL pod coverage POD is missing for 'library' FAIL members/pay.pl FAIL valid members/pay.pl had compilation errors. Global symbol "$accountline" requires explicit package name Then: When the item with fine is checked out, I can see the name of library, but when I check it in, it disappear. Shouldn't it be still visible? In pay.pl you are doing this: $account_line->{checkout} = Koha::Checkouts->find($accountline->{issue_id}); Maybe be better could be to add new sub to Koha::Account::Line object. You can take care of issue/old_issue table relation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 09:51:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 08:51:38 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-qx8WJP0jyu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 --- Comment #19 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 70967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70967 Bug 19360 - Give items URL a link text Review of attachment 70967: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19360&attachment=70967) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ +1215,4 @@ > <th id="item_priority" data-colname="item_priority">Item hold queue priority</th> > [% END %] > [% IF ( ShowCourseReservesHeader ) %] > + <th id="item_coursereserves">Course reserves</th> Why do you changed this line? How it is related to this issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 09:54:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 08:54:43 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-M5tc5k6z1u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 --- Comment #20 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 70968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70968 Bug 19360 - Added missing atomicupdate SQL file Review of attachment 70968: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19360&attachment=70968) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/Bug-19360_Add_Link_text_field_to_items.sql @@ +9,5 @@ > +(952, 'k', 'Link text', 'Link text', 0, 0, 'items.link_text', 10, 1, 0, 'IR', NULL), > +(952, 'k', 'Link text', 'Link text', 0, 0, 'items.link_text', 10, 1, 0, 'KT', NULL), > +(952, 'k', 'Link text', 'Link text', 0, 0, 'items.link_text', 10, 1, 0, 'SER', NULL), > +(952, 'k', 'Link text', 'Link text', 0, 0, 'items.link_text', 10, 1, 0, 'SR', NULL), > +(952, 'k', 'Link text', 'Link text', 0, 0, 'items.link_text', 10, 1, 0, 'VR', NULL) I think you should add this field only to frameworks that does exist, have field 952 defined and 952$k not defined. Also, this field needs to be added to installer data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 09:54:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 08:54:57 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-6rbtKEvEIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:06:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:06:24 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-qOJCpcEuO5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It worked with a reset_all db, but didn't work when I tried a fresh install, patches applied after my initial testing. (drop database, create database, web installer with mandatory data + onboarding tool). Didn't work = tests didn't pass. That got me confused a bit so asking for a second opinion now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:08:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:08:44 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: <bug-15520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15520-70-PEBiAtQ0AJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:12:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:12:17 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: <bug-15520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15520-70-Z8vDVojtHU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Jesse, this is working good, but I have found some small issues though: The new permission option is added only for existing installation, we need this in installer data too. Would be good to have test for the new functionality of haspermission sub. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:34:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:34:46 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-hil3khNi5f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:34:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:34:49 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-HilCc7U0lZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67974|0 |1 is obsolete| | Attachment #67975|0 |1 is obsolete| | Attachment #67976|0 |1 is obsolete| | Attachment #67977|0 |1 is obsolete| | Attachment #67978|0 |1 is obsolete| | --- Comment #118 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71218&action=edit Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. You can also: - check some biblios from several pages - add them to the cart - add them to a list Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:34:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:34:55 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-0sgA5fqdmW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #119 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71219&action=edit Bug 10858: Define the NO_RECORD_SELECTED msg in any case And not only when cart or list are defined. Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:35:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:35:00 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-6CBQ1614Hd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #120 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71220&action=edit Bug 10858: Replace the unique jQuery function with our own Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:35:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:35:04 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-n1VPH2CUfG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #121 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71221&action=edit Bug 10858: Show checkbox if OpacBrowseResult is set Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:35:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:35:09 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-j0lkOfosmZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #122 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71222&action=edit Bug 10858: Add 2 missing nav class Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:35:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:35:15 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-57Fcap5nEG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #123 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71223&action=edit Bug 10858: (QA follow-up) Fix translatibility Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:35:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:35:34 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-wVOLRewb5B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:36:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:36:09 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-kNXs1ptoSI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, we don't have a lot of subfields left and $k and $u are rather far apart in the form, so editing won't be nice. I'd prefer something like url|text and maybe make the field repeatable as well in the future. with $k and $u separate, this would be a lot harder. We could also think about a plugin hiding the way we store the data but displaying it nicely. This patch is in competition with bug 18760 for the last available free subfield $k. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:36:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:36:45 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-TyO93T3T7x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18760 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:36:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:36:45 +0000 Subject: [Koha-bugs] [Bug 18760] printable checkin alerts In-Reply-To: <bug-18760-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18760-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18760-70-5G14GgvYb9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19360 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 10:46:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 09:46:59 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-9gxTGuKXQW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 --- Comment #22 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Katrin Fischer from comment #21) > Hm, we don't have a lot of subfields left and $k and $u are rather far apart > in the form, so editing won't be nice. I'd prefer something like url|text > and maybe make the field repeatable as well in the future. with $k and $u > separate, this would be a lot harder. We could also think about a plugin > hiding the way we store the data but displaying it nicely. > > This patch is in competition with bug 18760 for the last available free > subfield $k. I agree, the plugin and only one field in database looks like better aproach here. We need the link text to bind with the URL - imagine somebody wants to have more then one URL field on item... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:25:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 10:25:56 +0000 Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron category report In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19669-70-4132bROncS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Nick Clemens from comment #17) > > Reverted last patch for stable for 17.11.03 Same for 17.05 then, reverted in v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:28:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 10:28:27 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19705-70-Tkav7pAOLU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 --- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:28:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 10:28:36 +0000 Subject: [Koha-bugs] [Bug 19423] DecreaseLoanHighHolds.t is failing randomly In-Reply-To: <bug-19423-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19423-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19423-70-yDuOC6udYD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:28:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 10:28:36 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19705-70-akdXNIDgYI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 Bug 19705 depends on bug 19423, which changed state. Bug 19423 Summary: DecreaseLoanHighHolds.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:28:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 10:28:36 +0000 Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs category_type In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19776-70-Bb6wKAfErN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776 Bug 19776 depends on bug 19423, which changed state. Bug 19423 Summary: DecreaseLoanHighHolds.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:34:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 10:34:49 +0000 Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19596-70-TI1OZdoy0B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 --- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Mason James from comment #10) > (In reply to Mason James from comment #9) > > (In reply to Jonathan Druart from comment #7) > > > Pushed to master for 17.11, thanks to everybody involved! > > > > Fridolin, can we get this backported to 17.05.x please :) > > fyi: it seems this patch can be skipped for 16.11.x Thanks for pointing this. Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 11:35:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 10:35:05 +0000 Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19596-70-f02CgFQxYk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:33:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 11:33:40 +0000 Subject: [Koha-bugs] [Bug 19179] Email option for SMSSendDriver is not documented as a valid setting In-Reply-To: <bug-19179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19179-70-UmwjUNvI30@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19179 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:45:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 11:45:12 +0000 Subject: [Koha-bugs] [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed In-Reply-To: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19989-70-uE1sYSZa6N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |17091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091 [Bug 17091] Add AUTOLOAD to Koha::Objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:45:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 11:45:12 +0000 Subject: [Koha-bugs] [Bug 17091] Add AUTOLOAD to Koha::Objects In-Reply-To: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17091-70-LEIhLFPJi8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19989 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:47:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 11:47:34 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-D0zrtJihGS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #38 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Katrin Fischer from comment #37) > It worked with a reset_all db, but didn't work when I tried a fresh install, > patches applied after my initial testing. (drop database, create database, > web installer with mandatory data + onboarding tool). > Didn't work = tests didn't pass. > That got me confused a bit so asking for a second opinion now. I tried it too, recreate db manually. Added all mandatory and optional data, go through onboarding tool. And the test started failing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:49:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 11:49:28 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-DhLV2D1NXJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It looks like you have an item that have an item type not defined in your system. To know the item types that are not defined in Koha, you can execute the following query: If item-level_itypes is "specific item" select distinct(itype) from items left join itemtypes on itype=itemtype where itemtype is null; If item-level_itypes is "biblio record" select distinct(bi.itemtype) from biblioitems bi left join itemtypes it on bi.itemtype=it.itemtype where bi.itemtype is null; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:49:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 11:49:38 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-6igEdZD4ty@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|17.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 12:56:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 11:56:42 +0000 Subject: [Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19290-70-89kxg4Ejpq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | Status|Signed Off |Patch doesn't apply --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Needs rebase because of bug 19697 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:14:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:14:51 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20115-70-PVqLcwzHuB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #5 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Is there a test plan for this? I loaded en-NZ and de-DE translations onto my Kohadevbox but the order still seems pretty random (its different between the staff and the OPAC for example, even after doing a restart_all and refreshing both web pages). Or is it random because the sorting in the syspref isn't written yet? Is that part of this bug (in which case it can't be signed off really) or should it be considered as a separate bug that this one depends on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:17:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:17:13 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-dTi98bTCdb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- How? Can you detail the main changes you applied? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:27:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:27:09 +0000 Subject: [Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts In-Reply-To: <bug-2505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2505-70-2QssjyoJTG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 --- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #27) > This bug hasn't seen much attention for a few years now. During the Open > Source Academy 2018 the students switched a lot (all?) scripts over to use > Modern::Perl; instead of the separate use strict; use warnings; pragmas. Nope, still few left. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:33:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:33:48 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-A8V55KcbnQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The patch adds use strict for scripts that were used in a very old upgrade (3.01). I do not think it is a good idea to update them (or spend time to improve them). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:37:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:37:53 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20017-70-lGwltOocnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #3) > Also the credits have been added to newHolidays.pl But not the good one. I am going to amend the patch to remove this part. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:41:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:41:00 +0000 Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client In-Reply-To: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20062-70-K0bitpY3Ei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:42:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:42:33 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-mj0IcfG1Cq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #39 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Josef Moravec from comment #38) > (In reply to Katrin Fischer from comment #37) > > It worked with a reset_all db, but didn't work when I tried a fresh install, > > patches applied after my initial testing. (drop database, create database, > > web installer with mandatory data + onboarding tool). > > Didn't work = tests didn't pass. > > That got me confused a bit so asking for a second opinion now. > > I tried it too, recreate db manually. Added all mandatory and optional data, > go through onboarding tool. And the test started failing. It seems to me that then there's a problem with the tests, depending on non-existent data. Can you please test if this is a problem with this patchset or just master fails too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:48:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:48:33 +0000 Subject: [Koha-bugs] [Bug 19999] use Modern::Perl in Labels perl scripts In-Reply-To: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19999-70-tICaTXE0Ec@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19999 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |zoebennett1308 at gmail.com |u | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:48:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:48:40 +0000 Subject: [Koha-bugs] [Bug 19999] use Modern::Perl in Labels perl scripts In-Reply-To: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19999-70-cUmlEvbZUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19999 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:48:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:48:55 +0000 Subject: [Koha-bugs] [Bug 19999] use Modern::Perl in Labels perl scripts In-Reply-To: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19999-70-YQNrEzJcza@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19999 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Skipping SO and QA, trivial changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:56:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:56:16 +0000 Subject: [Koha-bugs] [Bug 20109] Allow translating "Remove" in Add Fund In-Reply-To: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20109-70-GmMkRsnvpT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71224&action=edit Bug 20109: (follow-up) Use double quote instead of simple-quote -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:57:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:57:02 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11827-70-82y1ZQvC6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71225&action=edit Bug 11827: (follow-up) Use double quote instead of simple-quote -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:58:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:58:12 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19992-70-fNkKkrmDqD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patch pushed to master. Congratulations Jenny for you first patch in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:58:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:58:19 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11827-70-hmWo18WW6g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:58:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:58:25 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12932-70-pz0GecpU3c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:58:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:58:31 +0000 Subject: [Koha-bugs] [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed In-Reply-To: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19989-70-S72hYZpRom@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:58:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:58:42 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19993-70-GhumG2q4VV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:58:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:58:49 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19995-70-93pBsGFJjw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:58:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:58:55 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19996-70-VUPLHuyUve@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:59:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:59:02 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19997-70-shS0p1U4wO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:59:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:59:08 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19998-70-c595vECype@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:59:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:59:20 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20009-70-nkZ9ldQyoW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:59:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:59:14 +0000 Subject: [Koha-bugs] [Bug 19999] use Modern::Perl in Labels perl scripts In-Reply-To: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19999-70-BlrZiU9Kq1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19999 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:59:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:59:27 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20010-70-wI43lwyVjv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:59:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:59:33 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20011-70-YnU6wxlEy2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:59:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:59:39 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20012-70-aD1QoosXsV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:59:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:59:45 +0000 Subject: [Koha-bugs] [Bug 20013] use Modern::Perl in Reserves perl scripts In-Reply-To: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20013-70-rGsM8A3XN6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:59:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:59:51 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20015-70-W9O8ygDBkt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 13:59:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 12:59:58 +0000 Subject: [Koha-bugs] [Bug 20016] use Modern::Perl in svc scripts In-Reply-To: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20016-70-LI28OnGDSl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:00:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:00:05 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20017-70-qQosMtyNRo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:00:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:00:20 +0000 Subject: [Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts In-Reply-To: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20019-70-zA7kV1mPdH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:00:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:00:11 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20018-70-YhRQ4qEQpL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:00:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:00:26 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20020-70-1i1wz6Rcf3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:00:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:00:32 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20060-70-eaQ7jkZvJx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:00:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:00:39 +0000 Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client In-Reply-To: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20062-70-aiUdb7vZha@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:00:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:00:46 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20098-70-mZR8cx1akN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:00:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:00:53 +0000 Subject: [Koha-bugs] [Bug 20109] Allow translating "Remove" in Add Fund In-Reply-To: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20109-70-FWc3B06KdJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:00:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:00:59 +0000 Subject: [Koha-bugs] [Bug 20110] Adding same user multiple times to same budget fund In-Reply-To: <bug-20110-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20110-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20110-70-1iHE6kakCX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20110 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:01:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:01:05 +0000 Subject: [Koha-bugs] [Bug 20124] Allow translating did you mean config save message In-Reply-To: <bug-20124-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20124-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20124-70-Vp5j5xB1gy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20124 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:02:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:02:40 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-to6hEckdZc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #397 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71226&action=edit Bug 7143: Update about page for new dev - Jenny Way -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:03:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:03:23 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-DW66kZHX5R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #398 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #397) > Created attachment 71226 [details] [review] > Bug 7143: Update about page for new dev - Jenny Way Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:07:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:07:54 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-ep5vp4rDpF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70962|0 |1 is obsolete| | --- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 71227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71227&action=edit Bug 18818: Display in quick add list now depends on a field in database This patch allows to manage the patron categories contained in 'Quick add new patron'. Test plan: 1) Apply patches but not "define new column as boolean in DBIC Schema" 2) Update database structure : installer/data/mysql/updatedatabase.pl 3) Apply patch "define new column as boolean in DBIC Schema" 4) Update DBIx shema : misc/devel/update_dbix_class_files.pl 5) Go to Administation > Patron categories 6) Check there is a field named "Display in quick add" with "Yes" 7) Edit a category to set "No" and save 8) Check change is well saved 9) Go to "Patrons" and click on "Quick add patron" 10) Check the list contains only wanted categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:08:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:08:07 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-LLlJkAVB0f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70963|0 |1 is obsolete| | --- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 71228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71228&action=edit Bug 18818: (followup) correct template Main change is the use of Yes/No instead if Display/Don't display. It is more compact and more explicit. And fixes in categories.tt : - Template Toolkit markup inside HTML in <select id="quick_add_display"> - Missing double-quotes in HTML attributes - Missing value display in delete confirmation table - Correct capitalization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:08:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:08:24 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-g4RXBMvKUy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70964|0 |1 is obsolete| | --- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 71229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71229&action=edit Bug 18818: define new column as boolean in DBIC Schema See https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:10:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:10:21 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-i5Rrepw4Nm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Owen Leonard from comment #16) > I'm getting this error when I run updatedatabase.pl: > > > {UNKNOWN}: DBIx::Class::ResultSource::column_info(): No such column > quick_add_display at /home/vagrant/kohaclone/Koha/Schema/Result/Category.pm > line 273 > Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm > line 150. at /usr/share/perl5/Class/C3/Componentised.pm line 155 > Compilation failed in require at /home/vagrant/kohaclone/Koha/Database.pm > line 50. Indeed, I have changed test plan to apply last patch only after updatedatabase. I could not find another bug dealing with this DBIx change. This bug can then not be tested with a sandbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:16:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:16:20 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: <bug-17704-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17704-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17704-70-5wPvAVsn9J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OAI-PMH compatiblity with |Fix OAI breakage when using |Ubuntu Xenial and Debian |HTTP::OAI 4.03+ |Stretch | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:20:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:20:25 +0000 Subject: [Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19290-70-nsrX3GTqop@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:20:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:20:30 +0000 Subject: [Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19290-70-REvbjMZ9iv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68918|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71230&action=edit Bug 19290: Browse selected bibliographic records - Staff interface This patch adds the same feature as bug 10858 for the OPAC interface: after a search, librarians will be able to browse selected results. The results can be selected from several pages. By extension it is possible to add results from several pages to a list or the cart. When at least one result is selected, a new "Browse selected records" button becomes usable and change the behaviour of the existing browser. The whole feature can be turned off with the pref BrowseResultSelection. Test plan: - Launch a search (on the staff interface) - Check some biblios - Go on another page - Check some biblios - Come back to a page you already check results and confirm that they are still checked - Click on the "Browse selected records" button - Check that you are able to browse results you had checked. You can also: - add them to the cart - add them to a list QA note: the browsers at the OPAC and the one at the staff interface are completely different That's why the code is not mimicking what has been done on bug 10858. The behaviour must stay the same anyway. Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:21:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:21:20 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: <bug-17704-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17704-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17704-70-yoNs1CQKMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- [Koha-devel] State of HTTP::OAI versions http://lists.koha-community.org/pipermail/koha-devel/2018-February/044302.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:21:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:21:42 +0000 Subject: [Koha-bugs] [Bug 18096] BnF Authorities Z39.50 search and access In-Reply-To: <bug-18096-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18096-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18096-70-BurEZQY3eG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18096 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:25:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:25:11 +0000 Subject: [Koha-bugs] [Bug 20134] New: Remove /api/v1/app.pl from the generated URLs Message-ID: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Bug ID: 20134 Summary: Remove /api/v1/app.pl from the generated URLs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com The REST api is exposed using /api/v1, but that is rewritten to hit /api/v1/app.pl/api/v1 (app.pl being a Mojolicious::Command wrapper for running in Mojolicious under Plack). The problem is that Mojolicious then creates URLs containing that unneeded /api/v1/app.pl prefix. We should strip that out. To reproduce: - Point your browser to http://your_host_name/api/v1/ (don't forget about the trailing slash) => FAIL: Notice basePath: "/api/v1/app.pl/api/v1" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:34:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:34:17 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15449-70-ffuoyb7tQu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:34:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:34:24 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15449-70-d2orUqr9le@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:41:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:41:03 +0000 Subject: [Koha-bugs] [Bug 9566] Only run analytics code if analytics are enabled In-Reply-To: <bug-9566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9566-70-jyOW3nQ11q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9566 S?verine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 14:46:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 13:46:11 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20115-70-bcAoUdKNys@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I retest and everything looks ok. You need to 1. Install the patch 2. Install or update new languages, for instance: sudo koha-translate --install en-NZ --dev kohadev sudo koha-translate --install fr-FR --dev kohadev sudo koha-translate --install es-ES --dev kohadev 3. Restart all (memcached, plack) Test plan: Search for "language" in the I18N/L10N syspref section and tick/untick and reorder the values as you wish. On the OPAC and staff interfaces you should see the languages displayed with the same order as the pref, and preserved from one reload to the other -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:00:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 14:00:21 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15165-70-iqM2rIDocw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #62 from Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> --- I guess this patch doesn't apply anymore? I tried on 17.11 and on master but with no luck. Guess it need to be rebased/updated to incorporate Mojolicious::Plugin::OpenAPI (and JSON::Validator?)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:10:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 14:10:28 +0000 Subject: [Koha-bugs] [Bug 20135] New: Staff client language choose pop-up can appear off-screen Message-ID: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Bug ID: 20135 Summary: Staff client language choose pop-up can appear off-screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 71231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71231&action=edit Screenshot showing the off-screen menu In the staff client, the language-selection menu pop-up at the bottom of the page can appear off-screen under some circumstances: - StaffLangSelectorMode is set to "only footer" or "both top and footer" - The first language option (from left to right) includes more than one choice (for example: en-US and en-GB). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:12:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 14:12:48 +0000 Subject: [Koha-bugs] [Bug 20136] New: Test Bug Message-ID: <bug-20136-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20136 Bug ID: 20136 Summary: Test Bug Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle at bywatersolutions.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This is a test bug. Please ignore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:30:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 14:30:38 +0000 Subject: [Koha-bugs] [Bug 20136] Test Bug In-Reply-To: <bug-20136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20136-70-Wf29gadZTH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20136 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:35:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 14:35:53 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18958-70-fyo6aAqlIj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:35:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 14:35:56 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18958-70-ySNjMWVD7t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71164|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71232&action=edit Bug 18958 - If patron has multiple record level holds on one record transferring first hold causes next hold to become item level Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB and LibraryC respectively. Now, a patron places to record level holds for pickup at LibraryD. When any of the items are checked in, that item is trapped to fill the first hold, but a side affect is that the next open hold because item level for the item that was just checked in! This is clearly incorrect and prevents the patron from placing more record level holds on the record. Test Plan: 1. Create and use a patron that can place multiple record level holds per record 2. Create a record with X items, each at a different library 3. Place X 'Next available' holds on the record for the patron using the 'Holds to place' box 4. Rebuild the holds queue 5. Check in LibraryA's copy as LibraryA and confirm the hold 6. Revisit request.pl for the record, notice the next hold in line is now item-specific 7. Attempt to place another hold for your patron, notice that it requires an item-specific hold 8. Apply this patch 9. Repeat steps 1-4 10. Revisit request.pl for the record, notice the next hold in line has *not* become item-specific Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jason Robb <jrobb at sekls.org> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:36:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 14:36:05 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18958-70-BZTfH1Oeua@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:43:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 14:43:14 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-1lOsK0A0jq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #6 from Mohd Hafiz Yusoff <mhby87 at gmail.com> --- Created attachment 71233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71233&action=edit Result NULL After run query, result is NULL, how next step to do? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 15:44:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 14:44:17 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-v6Z9bSffg0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- In order to accomplish Bug 14546 ("Make staff client templates responsive") we can build on the already-included Bootstrap library and make incremental changes to the templates. The simplest way to start this process is to modify pages which have the simplest YUI grid: Single columns, no sidebar. There are two variations on this layout: - Fixed-width centered page with no sidebars - Fluid-width page with no sidebar See: https://wiki.koha-community.org/wiki/Interface_patterns#Common_page_layouts A typical change will look something like this: -<div id="doc2" class="yui-t7"> -<div id="bd"> - <div id="yui-main"> + <div class="main container-fluid"> + <div class="row"> + <div class="col-md-8 col-md-offset-2"> + I think using standard Bootstrap classes makes sense because it makes it easy for developers to use Bootstrap documentation to understand what the classes are doing. In this case, the "container-fluid" class makes the contents fluid rather than fixed-width. The "row" class delineates a grid row. The "col-md-8" class means that the (single, in this case) column occupies 8 of 12 grid columns when the browser width is at or above 970px (the "md" part of the class name). Below 970px the column is full-width. There are very few YUI-specific selectors in staff-global.css. Almost all of the existing ones affect multi-column layouts and can be addressed when we start making changes to those layouts. Regarding codifying this change in the QA scripts, we may want to wait until removal of the YUI grid is complete. It would be easier to look for any "yui" class than try to pick out only a few. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:12:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:12:32 +0000 Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff client menu bar In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19851-70-bZB984aJap@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20135 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 [Bug 20135] Staff client language choose pop-up can appear off-screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:12:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:12:32 +0000 Subject: [Koha-bugs] [Bug 20135] Staff client language choose pop-up can appear off-screen In-Reply-To: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20135-70-6cYZUh61Ik@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 [Bug 19851] Improve responsive layout handling of staff client menu bar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:15:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:15:28 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-pGQ4297PKz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am sorry I have no idea then. Do you have something else in the log? Maybe your item does not have an item type defined? Make sure your items have an item type correctly defined. Otherwise you could apply this change: diff --git a/members/summary-print.pl b/members/summary-print.pl index a6a0e36194..bb57ee0d00 100755 --- a/members/summary-print.pl +++ b/members/summary-print.pl @@ -100,6 +100,7 @@ sub build_issue_data { if ( $issue->{replacementprice} ); #find the charge for an item + warn "Getting charges for " . $issue->{itemnumber}; my ( $charge, $itemtype ) = GetIssuingCharges( $issue->{itemnumber}, $borrowernumber ); Restart plack, then reload the page. In the log you should see the "Getting charges for " line with the itemnumber that cause problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:19:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:19:44 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-sPDKejJKWF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Jens Weber <jens.weber at phsh.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jens.weber at phsh.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:22:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:22:34 +0000 Subject: [Koha-bugs] [Bug 20122] Empty and close link on cart page not working (js security) In-Reply-To: <bug-20122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20122-70-mj8nY1Sbj4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20122 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Which version of Koha? Which browser? Works for me on master with Firefox 58.0.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:34:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:34:04 +0000 Subject: [Koha-bugs] [Bug 20137] New: UK , 448000903854 Netgear router tech support phone number uk Message-ID: <bug-20137-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20137 Bug ID: 20137 Summary: UK , 448000903854 Netgear router tech support phone number uk Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: search-tried-port-move at mailsucker.net QA Contact: testopia at bugs.koha-community.org UK , 448000903854 Netgear router tech support phone number ukUK , 448000903854 Netgear router tech support phone number uk UK , 448000903854 Netgear router tech support phone number uk UK , 448000903854 Netgear router tech support phone number uk https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Hp-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44.8000903854-Netgear-Router-Customer-Support-Phone-Number-jobs.html https://www.indeed.com/q-UK-,-44,800,090,3854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-Uk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Talk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Contact-us,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://dsdigs78dtgdub.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone.html https://www.classifiedads.com/electronics/347xb2jv213z1 https://ewodh89dhi.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone_5.html https://kdp.amazon.com/community/thread.jspa?threadID=1460970 https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Hp-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44.8000903854-Netgear-Router-Customer-Support-Phone-Number-jobs.html https://www.indeed.com/q-Netgear-UK,-44,8000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Netgear,-UK-44,800903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44,800,090,3854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-Uk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Talk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Contact-us,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://dsdigs78dtgdub.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone.html https://www.classifiedads.com/electronics/347xb2jv213z1 https://ewodh89dhi.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone_5.html https://kdp.amazon.com/community/thread.jspa?threadID=1460970 https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Hp-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44.8000903854-Netgear-Router-Customer-Support-Phone-Number-jobs.html https://www.indeed.com/q-Netgear-UK,-44,8000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Netgear,-UK-44,800903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44,800,090,3854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-Uk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Talk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Contact-us,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://dsdigs78dtgdub.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone.html https://www.classifiedads.com/electronics/347xb2jv213z1 https://ewodh89dhi.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone_5.html https://kdp.amazon.com/community/thread.jspa?threadID=1460970 https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Hp-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44.8000903854-Netgear-Router-Customer-Support-Phone-Number-jobs.html https://www.indeed.com/q-Netgear-UK,-44,8000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Netgear,-UK-44,800903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44,800,090,3854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-Uk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Talk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Contact-us,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://dsdigs78dtgdub.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone.html https://www.classifiedads.com/electronics/347xb2jv213z1 https://ewodh89dhi.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone_5.html https://kdp.amazon.com/community/thread.jspa?threadID=1460970 https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Hp-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44.8000903854-Netgear-Router-Customer-Support-Phone-Number-jobs.html https://www.indeed.com/q-Netgear-UK,-44,8000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Netgear,-UK-44,800903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44,800,090,3854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-Uk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Talk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Contact-us,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://dsdigs78dtgdub.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone.html https://www.classifiedads.com/electronics/347xb2jv213z1 https://ewodh89dhi.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone_5.html https://kdp.amazon.com/community/thread.jspa?threadID=1460970 https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Hp-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44.8000903854-Netgear-Router-Customer-Support-Phone-Number-jobs.html https://www.indeed.com/q-Netgear-UK,-44,8000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Netgear,-UK-44,800903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44,800,090,3854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-Uk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Talk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Contact-us,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://dsdigs78dtgdub.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone.html https://www.classifiedads.com/electronics/347xb2jv213z1 https://ewodh89dhi.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone_5.html https://kdp.amazon.com/community/thread.jspa?threadID=1460970 https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Hp-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44.8000903854-Netgear-Router-Customer-Support-Phone-Number-jobs.html https://www.indeed.com/q-Netgear-UK,-44,8000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Netgear,-UK-44,800903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44,800,090,3854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-Uk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Talk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Contact-us,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://dsdigs78dtgdub.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone.html https://www.classifiedads.com/electronics/347xb2jv213z1 https://ewodh89dhi.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone_5.html https://kdp.amazon.com/community/thread.jspa?threadID=1460970 https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Hp-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44.8000903854-Netgear-Router-Customer-Support-Phone-Number-jobs.html https://www.indeed.com/q-Netgear-UK,-44,8000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Netgear,-UK-44,800903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-HP-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-UK,-448000903854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-UK-,-44,800,090,3854-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs~-Netgear-Router-Helpline-Number-UK-jobs.html https://www.indeed.com/q-Uk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Talk,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://www.indeed.com/q-Contact-us,-+448000903854-Contact-Netgear-Router-Customer-Support-Netgeare-Router-Tech-Support-Phone-Number-UK-Jobs-Netgear-Router-Support-Number-UK-jobs.html https://dsdigs78dtgdub.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone.html https://www.classifiedads.com/electronics/347xb2jv213z1 https://ewodh89dhi.wordpress.com/2018/02/05/netgear-router-tech-support-phone-numbernetgeare-router-tech-support-number-uk/ http://dgystds.blogspot.co.uk/2018/02/netgear-router-tech-support-phone_5.html https://kdp.amazon.com/community/thread.jspa?threadID=1460970 Contact[Only Call On This number uk@%+44-800-090-3854@% Netgear router tech support number uk Netgear router teC ? Netgear tech support number uk tollfree Netgear tech support number uk tollfree Netgear router support number uk Netgear router support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support number uk Netgear router tech support number uk Netgear router tech support number uk Netgear router support phone number uk Netgear router support phone number uk Netgear router tech support phone number uk Netgear router tech support phone number uk Netgear router customer service phone number uk. Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support phone number uk, Netgear tech support phone number uk, Netgear customer support phone number uk, Netgear router tech support phone number uk, Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear tech support number uk Netgear tech support phone number uk Netgear router support number uk Netgear router support phone number uk Netgear router tech support number uk Netgear router tech support phone number uk Netgear router customer support phone number uk Netgear router customer service phone number uk Netgear router technical support number uk Netgear router technical support phone number uk Netgear router tech support number uk Netgear router customer support Netgear router customer service phone number uk Netgear technical support reviews telephone Netgear router Netgear tech support phone number uk Netgear router tech support phone number uk Netgear customer service billing Netgear customer service email address Netgear customer service reviews contact Netgear customer service Netgear tech support number uk usa Netgear router contact number uk Netgear customer service phone number uk Netgear tech support phone Netgear tech support number uk Netgear customer service telephone number uk Netgear router customer support number uk Netgear router customer support phone number uk Netgear router customer service phone number uk contact Netgear router customer service phone number uk Netgear security support phone number uk Netgear internet security phone number uk in usa Netgear router contact phone number uk in usa Netgear router tech support phone number uk free in usa Netgear router phone number uk support for technical issue in usa phone number uk for Netgear router technical support Netgear router customer service telephone number uk Netgear router toll free customer care number uk Netgear router customer service telephone number uk Netgear support telephone number uk Netgear support telephone number uk Netgear router technical support phone number uk Netgear customer service phone number uk Netgear phone number uk customer service Netgear customer support phone number uk Netgear security phone number uk customer service phone number uk for Netgear customer service Netgear router customer support phone number uk Netgear router help desk support phone number uk free in usa phone number uk for Netgear router technical support Netgear technical support number uk free in usa Netgear technical support cutomer phone number uk Netgear internet security technical support Netgear router customer support number uk Netgear router customer service number uk Netgear router customer service billing Netgear router customer service email address Netgear router phone number uk customer service us Netgear router phone number uk support Netgear router support phone number uk Netgear router tech support phone number uk Netgear router technical support number uk Netgear router telephone number uk Netgear router customer care phone number uk Netgear router support phone number uk phone number uk for Netgear router Netgear router phone number uk support Netgear router phone support number uk phone number uk for Netgear router support Netgear router phone support Netgear technical support phone number uk Netgear router technical support number uk Netgear router technical support Netgear technical support number uk Netgear technical support Netgear internet security technical support Netgear router customer support number uk Netgear router customer service phone Netgear customer service telephone number uk Netgear customer services email Netgear customer support email address Netgear customer support phone number uk Netgear internet security contact phone number ukContact@%+44-800-090-3854@% Netgear router tech support number uk Netgear router tech support phone number uk Contact@%+44-800-090-3854@% Netgear router tech support number uk Netgear router tech support phone number uk Netgear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:38:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:38:53 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: <bug-15504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15504-70-EvcBS6Owgt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16276 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:38:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:38:53 +0000 Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16276-70-CL93rqD6kk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15504 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:43:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:43:24 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-nV3RuvBB3C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Confirmed, it fails for me as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:47:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:47:59 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-fKfOGf3Y2H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #40) > Confirmed, it fails for me as well. And all green on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:52:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:52:50 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-slOjfhDFrX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- All green after an upgrade tambi?n! So it only fails for new installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 16:53:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 15:53:59 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-K0OGvzaWoj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #43 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Jonathan Druart from comment #41) > (In reply to Jonathan Druart from comment #40) > > Confirmed, it fails for me as well. > > And all green on master. Not for me - without data, it fails on master the same way, when I do reset_all on kohadevbox then it is green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:03:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:03:00 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-zDgv5gGGp4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Josef Moravec from comment #43) > (In reply to Jonathan Druart from comment #41) > > (In reply to Jonathan Druart from comment #40) > > > Confirmed, it fails for me as well. > > > > And all green on master. > > Not for me - without data, it fails on master the same way, > > when I do reset_all on kohadevbox then it is green I am always using misc4dev to populate the DB, so with the sample data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:03:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:03:18 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-osNV4Lq64E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This is certainly not expected: Fresh install (with and without the patches): | biblio | CREATE TABLE `biblio` ( `biblionumber` int(11) NOT NULL AUTO_INCREMENT, `frameworkcode` varchar(4) COLLATE utf8_unicode_ci NOT NULL DEFAULT '', `author` mediumtext COLLATE utf8_unicode_ci, `title` mediumtext COLLATE utf8_unicode_ci, `unititle` mediumtext COLLATE utf8_unicode_ci, `notes` mediumtext COLLATE utf8_unicode_ci, Fresh master intall + upgrade: | biblio | CREATE TABLE `biblio` ( `biblionumber` int(11) NOT NULL AUTO_INCREMENT, `frameworkcode` varchar(4) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', `author` longtext COLLATE utf8mb4_unicode_ci, `title` longtext COLLATE utf8mb4_unicode_ci, `unititle` longtext COLLATE utf8mb4_unicode_ci, `notes` longtext COLLATE utf8mb4_unicode_ci, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:05:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:05:34 +0000 Subject: [Koha-bugs] [Bug 20135] Staff client language choose pop-up can appear off-screen In-Reply-To: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20135-70-JfX3RxLsrU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:05:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:05:36 +0000 Subject: [Koha-bugs] [Bug 20135] Staff client language choose pop-up can appear off-screen In-Reply-To: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20135-70-UUCtbTpjLj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71234&action=edit Bug 20135: Staff client language choose pop-up can appear off-screen This patch fixes a bug which was introduced by Bug 19851 ("Improve responsive layout handling of staff client menu bar."). The changes in that patch did not take into account the effects it would have on the language menus in the footer. This patch adds some additional classes to some menus and adds some CSS for those classes so that menus are correctly aligned left or right based on their position on the screen. To test, apply the patch and clear your cache if necessary. You should have multiple translations installed and enabled, at least one of which should have more than one "sub-language" (e.g. en-GB and en-US). In the staff client, test the appearance of various drop-down menus with the browser width above and below 800 pixels wide: - Search and More menus in the header - User/Library menu in the header - Language selection in the footer - Language selection in the header In all cases, menus should look correct and should not be aligned in such a way that they disappear off the left or right sides of the screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:13:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:13:07 +0000 Subject: [Koha-bugs] [Bug 20138] SPAM In-Reply-To: <bug-20138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20138-70-hsjqC7fOBY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20138 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Microsoft UK |SPAM |+44-800-014-8239 Outlook | |Tech Support Phone Number | |UK @ADOBE.@ | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:13:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:13:51 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-kkYYgfCXf1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:14:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:14:54 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-4JjLpl6PmT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68573|0 |1 is obsolete| | Attachment #71065|0 |1 is obsolete| | Attachment #71066|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71235&action=edit Bug 19530: Prevent multiple transfers from existing for one item We have found multiple open branch transfers for a given item. While I'm not sure how it is happening at this point, it seems that it would make sense to cancel any existing branch transfers when initiating a new one. Test Plan: 1) prove t/db_dependent/Circulation/transfers.t Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:14:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:14:58 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-9Cd1YcAwcH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #12 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71236&action=edit Bug 19530: Added commentary for last test when prove -v Before patch, prove -v had no comment for the last test. After patch, it says something in line with second last test. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:15:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:15:01 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-GI42BE0K6f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #13 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71237&action=edit Bug 19530: Don't update the date arrived for closed transfers Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:17:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:17:04 +0000 Subject: [Koha-bugs] [Bug 20137] SPAM In-Reply-To: <bug-20137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20137-70-VK4Zwlob7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20137 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|UK , 448000903854 Netgear |SPAM |router tech support phone | |number uk | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:18:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:18:19 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-hOifq9470K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:23:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:23:14 +0000 Subject: [Koha-bugs] [Bug 20077] Patroncards are printed blank In-Reply-To: <bug-20077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20077-70-sP4ajt2oww@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20077 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to martin.stastny from comment #0) > Hello, Hi Martin, > we're experiencing problems with printing patroncards from Koha. The final > result depends on used browser, for instance in opera I'm able to download > blank pdf, however, in firefox I end up with "Not found. The document has > moved here." error(under "here" link is nothing->nothing happens). What is the url of the link? > We use self-build Koha with several changes from upstream, but we haven't > edited this fuction. Which version of Koha do you use? What version of Firefox? > The logged errors are as following: At first glance they are not related. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:43:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:43:04 +0000 Subject: [Koha-bugs] [Bug 2193] Lost Item Fines - Editable if $0 In-Reply-To: <bug-2193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2193-70-Pi1HkXhA0y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2193 Maksim Sen <maksim.sen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:49:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:49:08 +0000 Subject: [Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19290-70-jB2Xs5s8xp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 17:49:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 16:49:11 +0000 Subject: [Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19290-70-l7rsMQKDAS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71230|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71238&action=edit Bug 19290: Browse selected bibliographic records - Staff interface This patch adds the same feature as bug 10858 for the OPAC interface: after a search, librarians will be able to browse selected results. The results can be selected from several pages. By extension it is possible to add results from several pages to a list or the cart. When at least one result is selected, a new "Browse selected records" button becomes usable and change the behaviour of the existing browser. The whole feature can be turned off with the pref BrowseResultSelection. Test plan: - Launch a search (on the staff interface) - Check some biblios - Go on another page - Check some biblios - Come back to a page you already check results and confirm that they are still checked - Click on the "Browse selected records" button - Check that you are able to browse results you had checked. You can also: - add them to the cart - add them to a list QA note: the browsers at the OPAC and the one at the staff interface are completely different That's why the code is not mimicking what has been done on bug 10858. The behaviour must stay the same anyway. Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:10:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 18:10:02 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-cgrdRYB94k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:09:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 18:09:40 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-T1PIz2Nomu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 71239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71239&action=edit Bug 20134: Remove /api/v1/app.pl from the generated URLs This patch removes the /api/v1/app.pl prefix from generated baseUrl. It has the consequence of hardcoding / as the base path for the API. This is ok because we don't currently support mounting Koha pieces in different than hardcoded paths (/cgi-bin/koha?), but certainly worth mentioning because this will need to depend on a syspref or config entry when someone chages this behviour. To test: - On master, point your browser to: http://kohadev.mydnsname.org:8080/api/v1/ => FAIL: basePath looks like /api/v1/app.pl/api/v1 - Apply this patch - Restart memcached and plack: $ restart_all or $ sudo systemctl restart memcached && sudo systemctl restart koha-common - Reload http://kohadev.mydnsname.org:8080/api/v1/ => SUCCESS: basePath is /api/v1 - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:12:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 18:12:01 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-ncuB6YXZL9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:39:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 18:39:08 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-AKrTc5K8hr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 5 19:55:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Feb 2018 18:55:18 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-SckUdV8nF6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #46 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #45) > This is certainly not expected: > > Fresh install (with and without the patches): > | biblio | CREATE TABLE `biblio` ( > `biblionumber` int(11) NOT NULL AUTO_INCREMENT, > `frameworkcode` varchar(4) COLLATE utf8_unicode_ci NOT NULL DEFAULT '', > `author` mediumtext COLLATE utf8_unicode_ci, > `title` mediumtext COLLATE utf8_unicode_ci, > `unititle` mediumtext COLLATE utf8_unicode_ci, > `notes` mediumtext COLLATE utf8_unicode_ci, > > Fresh master intall + upgrade: > | biblio | CREATE TABLE `biblio` ( > `biblionumber` int(11) NOT NULL AUTO_INCREMENT, > `frameworkcode` varchar(4) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', > `author` longtext COLLATE utf8mb4_unicode_ci, > `title` longtext COLLATE utf8mb4_unicode_ci, > `unititle` longtext COLLATE utf8mb4_unicode_ci, > `notes` longtext COLLATE utf8mb4_unicode_ci, It is interesting that the atomicupdate DOESN'T touch the biblio table besides changing the collation and encoding! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 04:18:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 03:18:18 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-tZVQuHnjVj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #8 from Mohd Hafiz Yusoff <mhby87 at gmail.com> --- Created attachment 71240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71240&action=edit Log after edit code For your info, this problem come affer upgrade from KOHA 16.05 to 17.11 After add code warn "Getting charges for " . $issue->{itemnumber}; Error log in attachment -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 06:41:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 05:41:04 +0000 Subject: [Koha-bugs] [Bug 20139] New: Improve MARC mapping translatable strings Message-ID: <bug-20139-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20139 Bug ID: 20139 Summary: Improve MARC mapping translatable strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr There's one untranslatable error message, and couple other messages that are annoying to translate due to using concatenation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 06:42:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 05:42:51 +0000 Subject: [Koha-bugs] [Bug 20139] Improve MARC mapping translatable strings In-Reply-To: <bug-20139-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20139-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20139-70-et2m8qj6dE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20139 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71241&action=edit Bug 20139: Improve MARC mapping translatable strings - Allow translating one error message - Use string formatting with placeholders instead of concatenation Test plan: 1) Go to Home -> Administration -> Koha to MARC Mapping 2) Click on the "Add" button to add a new mapping 3) Note the popup text looks correct 4) Enter something invalid 5) Note the error message 6) Click on any of the "Remove" buttons to remove a mapping 7) Note the popup text looks correct 8) Update, translate the new msgid's, and install a language 9) Repeat 1-7, note how the message are in the correct language -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 07:42:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 06:42:49 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18064-70-j5R7NfUBLs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #2 from Barton Chittenden <barton at bywatersolutions.com> --- I think this is a bug, not an enhancement -- this is causes confusing and seemingly inconsistent behavior of overdue_notices.pl and fines.pl (when longoverdue.pl runs before the third overdue notice, because the longoverdue delay stays the same, but notices are delayed, or when fines seemingly stop prematurely because items are marked longoverdue). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 07:47:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 06:47:29 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18064-70-0H4IUX2nPr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- If overdue_notices and fines ignore the calendar or use it is determined by system preferences (OverdueNoticeCalendar, finescalendar). So I think we might either tie this to one of them or have another? Otherwise this might be inconsistent for people not using the calendar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 07:52:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 06:52:08 +0000 Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19279-70-6HhNiXnChd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|performance of linked items |Performance of linked items |in search |in search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:11:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:11:12 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-cxL6kKBrEw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Owen, I think you had a fix somewhere for the missing tooltip, but couldn't find the bug. Can you have a look maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:13:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:13:14 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-fIWZNTxkGo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The title is already helpful and a clear improvement over the 'vanishing' of the button. Moving to PQA with the option of a later follow-up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:14:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:14:03 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-cUosP0sA9p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71242&action=edit Bug 10032: Improve GUI when uncertain price prevents closing the basket Added disabled "Close this basket" button when uncertain prices are present. Note that whilst this has a "title" attribute, there is no tooltip shown because JQueryUI disabled buttons don't get DOM events. https://bugs.koha-community.org/show_bug.cgi?id=10032 Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:14:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:14:07 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-VkACL7Irdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71243&action=edit Bug 10032: (follow-up) Move title attribute to button container This patch modifies the "Close basket" button markup so that the title attribute on a disabled button is added to the button wrapper <div> instead of the <a> tag. This allows the title attribute tooltip to appear when the cursor is hovered over the button. To test, follow the original patch's test plan and confirm that when the "Close basket" button is disabled, hovering the mouse over the button triggers the title attribute tooltip. Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:14:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:14:30 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-9h4rM5zRtY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:14:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:14:33 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-pkqV8HVrSE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70526|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:14:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:14:36 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-FfVGJ4585X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70527|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:16:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:16:49 +0000 Subject: [Koha-bugs] [Bug 18790] Add ability to void payments In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18790-70-ULHNPKphaN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 --- Comment #13 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 69161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69161 Bug 18790 - Add ability to void payments Review of attachment 69161: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18790&attachment=69161) ----------------------------------------------------------------- ::: installer/data/mysql/account_offset_types.sql @@ +9,5 @@ > ('Dropbox'), > ('Rental Fee'), > ('Fine Update'), > +('Fine'), > +('Void Payment'); This needs to be added as atomic update too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:18:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:18:27 +0000 Subject: [Koha-bugs] [Bug 18790] Add ability to void payments In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18790-70-5ujIfJdGoU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Also, wrong capitalization? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:19:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:19:41 +0000 Subject: [Koha-bugs] [Bug 18790] Add ability to void payments In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18790-70-kR36IpcQK3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com --- Comment #15 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Katrin Fischer from comment #12) > Should we consider logging reversing or voiding payments somewhere? We have > talked to libraries that have to report regularly on money collected and > changing payments later on could cause confusing results if not used very > carefully. I agree, we definitely need this for financial reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:21:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:21:18 +0000 Subject: [Koha-bugs] [Bug 18790] Add ability to void payments In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18790-70-nUJDhij3yR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 --- Comment #16 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Katrin Fischer from comment #14) > Also, wrong capitalization? Yes, wrong capitalization too - for all the values, but these values are only db keys, they are not showing anywhere (as I know), so no blocker for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:28:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:28:16 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-Xb0mFj6CEz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:29:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:29:13 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-NThERd1FtD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Owen, could you take a look at the screenshots please? Bit worried they might get even longer with translations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 08:58:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 07:58:49 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-kthedv7Hl3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|For non-package |For non-package release notes|installations, the |installations, the |following rewrite rules |following rewrite rules |will need to be added to |will need to be added to |the apache config file: |the apache config file: |RewriteRule ^(.*)_(.*).js$ |RewriteRule ^(.*)_(.*).js$ |$1.js [R=301,N,L] |$1.js [N,L] |RewriteRule ^(.*)_(.*).css$ |RewriteRule |$1.css [R=301,N,L] |^(.*)_(.*).css$ $1.css | |[N,L] QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 09:35:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 08:35:55 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-85NK0gtPN3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- I just discovered that I can go to http://kohadev.mydnsname.org:8080/api/v1.html to have the API spec in a readable format, which is nice :) And also that it doesn't work in CGI mode (http://kohadev.mydnsname.org/api/v1/.json works curiously, but not the html version ; etc/koha-httpd.conf probably needs some changes) Anyway, the patch works, so, sign-off coming soon ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 09:36:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 08:36:24 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-v63wU1xON7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71239|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71244&action=edit Bug 20134: Remove /api/v1/app.pl from the generated URLs This patch removes the /api/v1/app.pl prefix from generated baseUrl. It has the consequence of hardcoding / as the base path for the API. This is ok because we don't currently support mounting Koha pieces in different than hardcoded paths (/cgi-bin/koha?), but certainly worth mentioning because this will need to depend on a syspref or config entry when someone chages this behviour. To test: - On master, point your browser to: http://kohadev.mydnsname.org:8080/api/v1/ => FAIL: basePath looks like /api/v1/app.pl/api/v1 - Apply this patch - Restart memcached and plack: $ restart_all or $ sudo systemctl restart memcached && sudo systemctl restart koha-common - Reload http://kohadev.mydnsname.org:8080/api/v1/ => SUCCESS: basePath is /api/v1 - Sign off :-D Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 09:36:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 08:36:33 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-csZOCTNtmB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 10:20:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 09:20:54 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: <bug-8628-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8628-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8628-70-3zkUB3LT4P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #24 from Magnus Enger <magnus at libriotech.no> --- I wonder if this would be better as a plugin... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 10:26:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 09:26:24 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-OaE0YtoShh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #87 from Josef Moravec <josef.moravec at gmail.com> --- Looks good, just small issues: the staff-global.css and reset-fonts-grids.css in intranet are not versioned The staff-global.css needs to be adressed in file koha-tmpl/intranet-tmpl/prog/en/includes/intranetstylesheet.inc reset-fonts-grids.css is using through @import in staff-global.css, but could be leaved as is, it probably never change and I believe it will be removed in the future as it is part of yui library. in opac the opac.css is needs to be addressed in file koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc script.js and enquiry.min.js needs to be addressed in file koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 10:33:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 09:33:50 +0000 Subject: [Koha-bugs] [Bug 20140] New: Allow translating more of OAI sets Message-ID: <bug-20140-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 Bug ID: 20140 Summary: Allow translating more of OAI sets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr There's two untranslatable strings in OAI set config: "setDescription" and "Remove" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 10:35:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 09:35:26 +0000 Subject: [Koha-bugs] [Bug 20140] Allow translating more of OAI sets In-Reply-To: <bug-20140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20140-70-1Bwkl47qsL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71245&action=edit Bug 20140: Allow translating more of OAI sets Allow translating two strings in the OAI set config: "setDescription" and "Remove" Test plan: 1) Go to Home -> Administrator -> OAI sets config -> Add a new OAI set 2) Click on "New set" 3) Click on "Add description" 4) Note the "setDescription:" and "Remove" -texts 5) Install patch, update language, translate the new strings 6) Redo 1-4, note how the strings in part 4 are now translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 11:37:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 10:37:07 +0000 Subject: [Koha-bugs] [Bug 20141] New: Untranslatable string in Transport cost matrix Message-ID: <bug-20141-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20141 Bug ID: 20141 Summary: Untranslatable string in Transport cost matrix Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The "Disable" checkboxes in transport cost matrix are untranslatable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 11:38:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 10:38:29 +0000 Subject: [Koha-bugs] [Bug 20141] Untranslatable string in Transport cost matrix In-Reply-To: <bug-20141-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20141-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20141-70-19BBuY7uq6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20141 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71246&action=edit Bug 20141: Untranslatable string in transport cost matrix Make the "Disable" checkboxes in transport cost matrix translatable Test plan: 1) Go to Home -> Administration -> Transport cost matrix 2) Click on any cell 3) Note the "Disable" checkbox text 4) Install patch, add a language, translate the text, etc 5) Repeat 1-3, the "Disable" text should now be translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 12:29:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 11:29:54 +0000 Subject: [Koha-bugs] [Bug 20142] New: Allow translating offline circ message Message-ID: <bug-20142-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20142 Bug ID: 20142 Summary: Allow translating offline circ message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When using the offline circ, there's a notification "You cannot change your branch or logout while using offline circulation" which is not translatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 12:31:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 11:31:10 +0000 Subject: [Koha-bugs] [Bug 20142] Allow translating offline circ message In-Reply-To: <bug-20142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20142-70-mY65e2yQdb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20142 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71247&action=edit Bug 20142: Allow translating offline circ message Allow translating the notification saying you cannot change branch or logout while offline. Test plan: 1) Enable AllowOfflineCirculation 2) Go to Home -> Circulation -> Built-in offline circulation interface 3) Try to change your branch. Note the notification message 4) Apply patch, install language, translate the notification 5) Repeat 2 and 3 in that language. The message should be translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 12:35:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 11:35:28 +0000 Subject: [Koha-bugs] [Bug 19938] C4::Overdues::checkoverdues has inconsistent return type In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-oMhZye3M4m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:53:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 12:53:15 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-tM12kEEOqM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #88 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Josef Moravec from comment #87) > reset-fonts-grids.css is using through @import in staff-global.css, but > could be leaved as is, it probably never change and I believe it will be > removed in the future as it is part of yui library. That is my goal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:56:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 12:56:34 +0000 Subject: [Koha-bugs] [Bug 14749] Add API route to get top issues In-Reply-To: <bug-14749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14749-70-wxCy9efblM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42408|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71248&action=edit Bug 14749: Add API route /v1/topissues See Swagger specification for documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 13:56:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 12:56:37 +0000 Subject: [Koha-bugs] [Bug 14749] Add API route to get top issues In-Reply-To: <bug-14749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14749-70-a7TArMPT8C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 --- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71249&action=edit Bug 14749: Add unit tests for /topissues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:04:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:04:50 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-5daaF6E2JP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #89 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Owen Leonard from comment #88) > (In reply to Josef Moravec from comment #87) > > > reset-fonts-grids.css is using through @import in staff-global.css, but > > could be leaved as is, it probably never change and I believe it will be > > removed in the future as it is part of yui library. > > That is my goal. Great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:05:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:05:48 +0000 Subject: [Koha-bugs] [Bug 14749] Add API route to get top issues In-Reply-To: <bug-14749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14749-70-B4iH48hLfr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> --- Patch rebased on master + tests Test plan: 1) Go to http://OPAC/cgi-bin/koha/opac-topissues.pl and http://OPAC/api/v1/topissues and compare the results. They must be the same, given a set of parameters Parameters matching: "Show the top" corresponds to api parameter 'count' "From" corresponds to api parameter 'branch' "Limit to" corresponds to api parameter 'itemtype' "Acquired in the last" corresponds to api parameter 'newness' (in days) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:13:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:13:42 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-AUIgg84DRV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:31:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:31:56 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: <bug-8244-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8244-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8244-70-JpL0F6VqJS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #26 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Marc V?ron from comment #25) > Still valid? Probably not. 3 years without activity, and it doesn't work at all anymore. Changing status to WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:34:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:34:30 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-pCLQqLfU0g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What are the return of these queries: select itype from items where itemnumber=322947; select itemtype from biblioitems bi left join items it on bi.biblionumber=it.biblionumber where it.itemnumber=322947; select value from systempreferences where variable="item-level_itypes"; select itemtype from itemtypes; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:41:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:41:37 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-RQBQZlAwPY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:41:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:41:46 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-jAxJ5Vb12i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #90 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71250&action=edit Bug 12904: Fix occurrences not caught by script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:42:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:42:24 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-QyHncTBsm4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #91 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Great catches Josef, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:52:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:52:24 +0000 Subject: [Koha-bugs] [Bug 16246] Return all reserves columns in ILS-DI GetRecords response In-Reply-To: <bug-16246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16246-70-RojzlriKL8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Jonathan Druart from comment #15) > Julian, on but 17736 I remove occurrences of GetReservesFromBiblionumber. Bug 17736 also removed completely the usefulness of this bug :) Changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:56:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:56:41 +0000 Subject: [Koha-bugs] [Bug 20122] Empty and close link on cart page not working (js security) In-Reply-To: <bug-20122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20122-70-DMknyH8kA6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20122 --- Comment #2 from mark.gavillet at ptfs-europe.com --- Sorry, thought I'd mentioned the Koha version! It's Koha 17.05.08, browsers tested are: Chrome 63.0.3239.132 Safari 11.0.2 Edge 40.15063.674.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:58:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:58:18 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-WNv3zdnYWK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:58:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:58:22 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-4p1U7Hce65@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70831|0 |1 is obsolete| | Attachment #70832|0 |1 is obsolete| | Attachment #70833|0 |1 is obsolete| | Attachment #70834|0 |1 is obsolete| | Attachment #71250|0 |1 is obsolete| | --- Comment #92 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71251&action=edit Bug 12904: Apache configuration Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:58:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:58:26 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-9IWP3rYm2e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #93 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71252&action=edit Bug 12904: Add mod_expire to etc/koha-httpd.conf Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:58:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:58:31 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-aJ1HlONJhr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #94 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71253&action=edit Bug 12904: Pass KOHA_VERSION in C4::Auth Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:58:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:58:36 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-7rzVLLwu6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #95 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71254&action=edit Bug 12904: Force browser to load new javascript files after upgrade This patch has been automatically generated using: perl kv.pl **/*.tt **/*.inc Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 14:58:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 13:58:42 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-LxtmsA4VbE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #96 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71255&action=edit Bug 12904: Fix occurrences not caught by script Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 15:00:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 14:00:54 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-evS8lUFuWL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #97 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Jonathan Druart from comment #90) > Created attachment 71250 [details] [review] > Bug 12904: Fix occurrences not caught by script Thanks for quick reaction! Passed QA. I just fixed the first patch, which was made as fix of apache configuration, which was part of original patch. Now should apply cleanly on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 16:38:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 15:38:46 +0000 Subject: [Koha-bugs] [Bug 20143] New: Allow separate system preferences for Self Checkout specific to Circulation Message-ID: <bug-20143-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20143 Bug ID: 20143 Summary: Allow separate system preferences for Self Checkout specific to Circulation Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Using Koha's self checkout module limits functions due to global system preferences set up. For example, if the system preference : allfinesneeedoverride is set to require, any amount of money owed by the patron will restrict that patron to use the self checkout module. It would be nice to have separate circulation system preferences for selfcheckout and circulation desk. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:03:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:03:02 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-hfNqkEO5EL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #10 from Mohd Hafiz Yusoff <mhby87 at gmail.com> --- Created attachment 71256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71256&action=edit Result on test query Before I run the query, I edit biblio dan itemnumber for 322947 - Sorry for this. Now I try with new error log, I found the error on itemnumber=274334 and biblionumber=121544 At biblio, Koha [default] item type 942 is NULL and Koha item type BOOK. After run the query, result like attachment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:04:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:04:01 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-TIjGXIDd5z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #11 from Mohd Hafiz Yusoff <mhby87 at gmail.com> --- Created attachment 71257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71257&action=edit Another error log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:04:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:04:56 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-od8lKS438p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #12 from Mohd Hafiz Yusoff <mhby87 at gmail.com> --- Created attachment 71258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71258&action=edit 942 is NULL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:05:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:05:33 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-uRt1maj297@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #13 from Mohd Hafiz Yusoff <mhby87 at gmail.com> --- Created attachment 71259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71259&action=edit Koha Item type BOOK -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:16:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:16:04 +0000 Subject: [Koha-bugs] [Bug 20143] Allow separate system preferences for Self Checkout specific to Circulation In-Reply-To: <bug-20143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20143-70-iDof06zhuC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20143 Lisa <lisa at hchlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisa at hchlibrary.org --- Comment #1 from Lisa <lisa at hchlibrary.org> --- Hi! We love our self checkout, but patrons cannot check out items if they have a 10 cent fine. We want our staff members to be stopped during checkout so they can inform patrons of any overdues or fines, but this same setting shows very minute fines and stops the self checkout process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:23:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:23:59 +0000 Subject: [Koha-bugs] [Bug 20077] Patroncards are printed blank In-Reply-To: <bug-20077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20077-70-dzqvZPSXuE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20077 --- Comment #2 from martin.stastny at teamlibrary.cz --- (In reply to Jonathan Druart from comment #1) > (In reply to martin.stastny from comment #0) > > Hello, > > Hi Martin, > > > we're experiencing problems with printing patroncards from Koha. The final > > result depends on used browser, for instance in opera I'm able to download > > blank pdf, however, in firefox I end up with "Not found. The document has > > moved here." error(under "here" link is nothing->nothing happens). > > What is the url of the link? /cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=1&layout_id=&layout_back_id=&start_card=1 > > We use self-build Koha with several changes from upstream, but we haven't > > edited this fuction. > > Which version of Koha do you use? 17.11.00.000 > What version of Firefox? 58.0.1 (64-bit) UBUNTU 17.10 also tested in a kind of 57.X Windows 10 64bit version > > > The logged errors are as following: > > At first glance they are not related. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:33:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:33:20 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-SPNSJi6Zwg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- You have item types defined at biblio level (item-level_itypes=0), but not defined in biblioitems table (942$c is empty), you need to fix your records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:46:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:46:17 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11708-70-MjTdmBJkDP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61018|0 |1 is obsolete| | --- Comment #173 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71260&action=edit Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast at iepg.fr> Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Patch updated: Use atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:46:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:46:23 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11708-70-20PYO8wd0z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61019|0 |1 is obsolete| | --- Comment #174 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71261&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast at iepg.fr> Signed-off-by: Paola Rossi <paola.rossi at cineca.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:46:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:46:29 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11708-70-OleKk8oHBC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61020|0 |1 is obsolete| | --- Comment #175 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71262&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast <juliette.levast at iepg.fr> Signed-off-by: Paola Rossi <paola.rossi at cineca.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:46:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:46:37 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11708-70-6vk74NW4FW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61021|0 |1 is obsolete| | --- Comment #176 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71263&action=edit Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Patch updated: use atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:46:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:46:43 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11708-70-U3hMprN7l9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61022|0 |1 is obsolete| | --- Comment #177 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71264&action=edit Bug 11708: Place "Basket groups" menu entry on top of the side navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:46:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:46:50 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11708-70-CIpga0juNp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61023|0 |1 is obsolete| | --- Comment #178 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71265&action=edit Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:46:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:46:56 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11708-70-Hx1vfFdJec@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61024|0 |1 is obsolete| | --- Comment #179 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71266&action=edit Bug 11708: UT: Replace 'ok' by 'is' where appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:47:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:47:02 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11708-70-DGKCCC5vY9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61025|0 |1 is obsolete| | --- Comment #180 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71267&action=edit Bug 11708: UT: Use DateTime instead of localtime+sprintf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:47:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:47:09 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11708-70-D6xnuaWTwH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61026|0 |1 is obsolete| | --- Comment #181 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71268&action=edit Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace and fix Koha::Acquisition::Order usage everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:47:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:47:52 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11708-70-3hlbvX6VMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #182 from Julian Maurice <julian.maurice at biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 17:52:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 16:52:49 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18064-70-lWy8aZsLHu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #4 from Barton Chittenden <barton at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3) > If overdue_notices and fines ignore the calendar or use it is determined by > system preferences (OverdueNoticeCalendar, finescalendar). So I think we > might either tie this to one of them or have another? Otherwise this might > be inconsistent for people not using the calendar. You're absolutely right; I think this should follow OverdueNoticeCalendar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:02:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:02:47 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: <bug-17776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17776-70-SCnJtFArqa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 --- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Can someone explain how to reproduce the problem? It seems to me that if we need to inject ENV variables on a per-request basis we can write a Plack middleware to take care of that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:09:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:09:52 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-NsuebwgDej@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:09:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:09:55 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-rW9QTqAlf9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70707|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71269&action=edit Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:11:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:11:34 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-qM4wcoFbxN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Since MySQL 5.7 and MariaDB 10.2.4, the default value for SQL modes is MySQL: ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION MariaDB: NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:11:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:11:55 +0000 Subject: [Koha-bugs] [Bug 19248] install.pl: DBD::mysql::st execute failed In-Reply-To: <bug-19248-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19248-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19248-70-AFB3GqgCEl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:11:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:11:55 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-zfXZsfXJFb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19248 [Bug 19248] install.pl: DBD::mysql::st execute failed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:12:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:12:24 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-f9W83lrqvo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 [Bug 20144] Test suite is failing with new default SQL modes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:12:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:12:24 +0000 Subject: [Koha-bugs] [Bug 20144] New: Test suite is failing with new default SQL modes Message-ID: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Bug ID: 20144 Summary: Test suite is failing with new default SQL modes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:13:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:13:38 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-2irZJo6dCF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Test plan: Edit /etc/mysql/my.cnf (or equivalent), and add the following line to the mysqld block: sql-mode = "ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION" Then restart mysql and execute the test suite. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:20:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:20:11 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-aTnwpSsj0f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- I submitted a follow-up to make this patch more consistent, but: It's not that acqui-search.tt was missing the Bootstrap grid, it's that it has minimal Bootstrap markup because it's a very simple template. It's not really necessary to define columns and rows when there aren't multiples of either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:30:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:30:22 +0000 Subject: [Koha-bugs] [Bug 19892] Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC In-Reply-To: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19892-70-D8mglXMb2O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:33:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:33:19 +0000 Subject: [Koha-bugs] [Bug 19892] Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC In-Reply-To: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19892-70-F4rqgNAGaC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 20:47:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 19:47:55 +0000 Subject: [Koha-bugs] [Bug 20145] New: borrowers.datexpiry eq '0000-00-00' means expired? Message-ID: <bug-20145-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145 Bug ID: 20145 Summary: borrowers.datexpiry eq '0000-00-00' means expired? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org See bug http://lists.koha-community.org/pipermail/koha-devel/2018-February/044322.html Koha::Patron->is_expired returns 0 if $self->dateexpiry eq '0000-00-00' And there is a test I wrote for it on bug 17578 (commit 5a0a2ce584dec74808f471b0f92b2114c3d6029e , GetMemberDetails - Remove is_expired) But then we also have, in C4::Circulation::CanBookBeIssued: 752 if ( !defined $patron->dateexpiry || $patron->dateexpiry eq '0000-00-00') { 753 $issuingimpossible{EXPIRED} = 1; 754 } else { With a test: is( $issuingimpossible->{EXPIRED}, 1, 'The patron should be considered as expired if dateexpiry is 0000-00-00' ); So, my questions, do you have a very old Koha installations to search if there is borrowers.is_expired == "0000-00-00" in it? Do you remember if it meant expired or not at some point? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:47:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:47:34 +0000 Subject: [Koha-bugs] [Bug 20146] New: Add 040 $e in the source's column in Z39.50 search's results Message-ID: <bug-20146-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20146 Bug ID: 20146 Summary: Add 040 $e in the source's column in Z39.50 search's results Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, It would be great to add the subfield 040 $e in the source's column in a z39.50 search in the authorities's module. this subfield show the name of the description rule and it would be interesting to have this information in the page's results. Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:47:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:47:35 +0000 Subject: [Koha-bugs] [Bug 18170] Show damaged status on check-in In-Reply-To: <bug-18170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18170-70-z5a2iTnXth@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Lisette <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:47:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:47:34 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19919-70-q7HJG8AGLI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Lisette <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:52:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:52:09 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-cw5FIHIl9B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- See https://github.com/joubu/Koha/tree/bug_20144 for the patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:52:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:52:15 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-XFEcKF7t4L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:52:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:52:33 +0000 Subject: [Koha-bugs] [Bug 19492] Field 'lowestPriority' doesn't have a default value (MariaDB) In-Reply-To: <bug-19492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19492-70-cv1mi1N2hp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19492 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Will be fixed by bug 20144. *** This bug has been marked as a duplicate of bug 20144 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:52:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:52:33 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-t3ZG8MWeRu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 19492 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:52:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:52:33 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-BWmZ7QhM1n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 19492, which changed state. Bug 19492 Summary: Field 'lowestPriority' doesn't have a default value (MariaDB) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19492 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:52:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:52:56 +0000 Subject: [Koha-bugs] [Bug 17860] [SQL strict mode] MARC records will stage, but Manage for import shows 'no data in table' In-Reply-To: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17860-70-J9e0gYq5M2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Will be fixed by bug 20144 *** This bug has been marked as a duplicate of bug 20144 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:52:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:52:56 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-tNQ5yDLDVB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 17860, which changed state. Bug 17860 Summary: [SQL strict mode] MARC records will stage, but Manage for import shows 'no data in table' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:53:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:53:06 +0000 Subject: [Koha-bugs] [Bug 18836] MySQL 5.7 - Table 'koha_library.club_enrollments' doesn't exist In-Reply-To: <bug-18836-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18836-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18836-70-leIlX962Kb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Will be fixed by bug 20144 *** This bug has been marked as a duplicate of bug 20144 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:53:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:53:07 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-hsMHz5sXox@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |CJSH at CJSHayward.com --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 18836 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:53:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:53:08 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-kh9vAMahr0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 18836, which changed state. Bug 18836 Summary: MySQL 5.7 - Table 'koha_library.club_enrollments' doesn't exist https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 21:52:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 20:52:56 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-5PxgCYg8bK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gale at rabbat.net --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 17860 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 22:36:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 21:36:04 +0000 Subject: [Koha-bugs] [Bug 9230] selectively delete reading history In-Reply-To: <bug-9230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9230-70-HaKSu146he@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9230 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org --- Comment #1 from Chris Slone <cslone at camdencountylibrary.org> --- We have had multiple patrons (and staff) express an interest in a feature like this as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 6 23:24:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Feb 2018 22:24:20 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-QXMstRLbK6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #47 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #44) > (In reply to Josef Moravec from comment #43) > > (In reply to Jonathan Druart from comment #41) > > > (In reply to Jonathan Druart from comment #40) > > > > Confirmed, it fails for me as well. > > > > > > And all green on master. > > > > Not for me - without data, it fails on master the same way, > > > > when I do reset_all on kohadevbox then it is green > > I am always using misc4dev to populate the DB, so with the sample data The sample data doesn't include biblios. The one containing them is misc4dev. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 02:33:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 01:33:07 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-gbFgLztKqs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #15 from Mohd Hafiz Yusoff <mhby87 at gmail.com> --- How to query all biblio number with 942$c is empty? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 07:17:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 06:17:38 +0000 Subject: [Koha-bugs] [Bug 20147] New: Allow translating prompt in label edit batch Message-ID: <bug-20147-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20147 Bug ID: 20147 Summary: Allow translating prompt in label edit batch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Untranslatable "Are you sure you want to remove label number(s): " + item_msg + " from this batch?" in label batch edit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 07:19:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 06:19:29 +0000 Subject: [Koha-bugs] [Bug 20147] Allow translating prompt in label edit batch In-Reply-To: <bug-20147-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20147-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20147-70-tv81pj6Alj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20147 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71270&action=edit Bug 20147: Allow translating prompt in label edit batch Fix one untranslatable prompt in the label batch edit. Test plan: 1) Go to Home -> Tools -> Label creator 2) Click on New -> Label batch 3) Add items to the batch 4) Select any of the items 5) Click on "Remove selected items" 6) Note the popup text 7) Apply patch, update a language, translate the msgid "Are you sure you want to remove label number(s): %s from this batch?" 8) Repeat 1-6. The popup text should now be translated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 07:37:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 06:37:41 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-9igy0fencQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- https://wiki.koha-community.org/wiki/SQL_Reports_Library#Biblio_Items_without_a_Koha_Item_Type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 07:53:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 06:53:15 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-wpWNiUvM5z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Both patches work very nicely, I especially tested for translations. The only thing I am not happy about it the length of the buttons - I think Victor had similar thoughts on posting the screenshots. It's bad in English, but it will be even worse in translation for example to German. Maybe a more generic term would help? "Export file"? If you have a global setting, it might not be necessary to point it out everywhere, because people will know after first time they use it. I am attaching the 2 patches with my sign-off, but at the moment would only prefer the first to be pushed. Not setting to PQA quite yet, waiting for some feedback on the button description issue first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 07:54:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 06:54:00 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-2BNVdtLMA6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70750|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71271&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 07:54:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 06:54:05 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-e2o8zaCNaF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71104|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71272&action=edit Bug 19928: Acquisitions: show the precise kind of CSV on export buttons That is to say on the 4 "export as CSV" buttons found, now when can read "export as semicolon separated text (.csv)". It follows the "delimiter" syspref. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:08:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 07:08:28 +0000 Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers In-Reply-To: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19017-70-at1anbs16J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I agree with Jonathan: - The French country code +33 is hard coded into the script which makes it only useful for French telephone numbers, but not usable for example for German ones (+41). This could easily be more generic and then much more useful. - There is an option --country-option, but it doesn't appear to be used? - It adds a new module to C4, which we should not do anymore. - It doesn't include tests. I think if we want something like that, it might be better as a clean-up script in misc/maintenance. Possibly without a separate module? I think it's not quite ready, sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:12:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 07:12:55 +0000 Subject: [Koha-bugs] [Bug 19325] Enable padding of printed barcodes In-Reply-To: <bug-19325-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19325-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19325-70-fi0xgkJD3v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I agree with Julian that it would be cleaner to keep all the configuration options for the labels within the layouts. So far only the options for the quick label print are in prefs, so this would be a first one too. Alex, could you take a look at the comments please and give us some feedback? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:25:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 07:25:55 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-vHcjfyyW8R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I get a not found trying to access: http://localhost:8080/api/v1 Am I missing something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:31:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 07:31:33 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12802-70-M3gnpAb1vs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #99 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Patches no longer apply, please rebase! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:35:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 07:35:24 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-mFKbft6sgO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Patches no longer apply, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9573: Lost items report - Add items.notforloan as a filter Applying: Bug 9573: Lost items report - Move filters code to a separate js file Applying: Bug 9573: Lost items report - add KohaTable to itemlost fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9573: Lost items report - add KohaTable to itemlost The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9573-Lost-items-report---add-KohaTable-to-item-M_2w8X.patc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:39:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 07:39:05 +0000 Subject: [Koha-bugs] [Bug 13840] Don't show library filter on full serial issue history in OPAC for single branch libraries In-Reply-To: <bug-13840-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13840-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13840-70-4K9J6Dr4VK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13840 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:54:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 07:54:22 +0000 Subject: [Koha-bugs] [Bug 20148] New: Adding same user multiple times to acq basket Message-ID: <bug-20148-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 Bug ID: 20148 Summary: Adding same user multiple times to acq basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org When adding a user to manage acquisitions basket, it is possible to add the same user multiple times. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 08:55:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 07:55:40 +0000 Subject: [Koha-bugs] [Bug 20148] Adding same user multiple times to acq basket In-Reply-To: <bug-20148-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20148-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20148-70-6gpaLbmN8K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71273&action=edit Bug 20148: Adding same user multiple times to acq basket When adding a user to manage acquisitions basket, it is possible to add the same user multiple times. Prevent that. Test plan: 1) Go to Home -> Acquisitions -> [bookseller] -> [basket] 2) On the "Add user" in the Managed by-part, and try adding the same user multiple times. 3) Apply patch 4) Repeat 1 and 2. You should now get an error message saying the user is already in the list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 09:23:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 08:23:22 +0000 Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron category report In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19669-70-s4Cy5w9JLu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #19 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Just for anyone else who might have also a doubt: it's indeed reverted in master (commit 7cb86656956131ed81cc74069a765a37664edd8e) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 09:36:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 08:36:33 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-aT0ST4cq5R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Hi Jonathan, I just started to testing, found two issues till now: Can't recreate database, when creating table structure, I got: there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE clause I am on mysql 5.5.59, which is still default in jessie, more timestamp columns are possible from mysql 5.6.5: https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html Second one: Shouldn't be there atomic update for this change? https://github.com/joubu/Koha/commit/de14e25c7b03ca9a4812df627dec397eae4261ad -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:00:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 10:00:48 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-iH3Il6pRYc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Katrin Fischer from comment #4) > I get a not found trying to access: > http://localhost:8080/api/v1 > > Am I missing something? Working for me: http://localhost:8080/api/v1/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:08:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 10:08:02 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-KJePFLDBeP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Josef, feel free to pass QA then - I think my devbox might just be a bit outdated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:26:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 10:26:12 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-SVqceddKVU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #4) > I get a not found trying to access: > http://localhost:8080/api/v1 > > Am I missing something? Yes, the trailing slash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:32:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 10:32:05 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-tNxVJjTSqt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Few another ones: The tests t/db_dependent/www/batch.t and t/db_dependent/www/search_utf8.t are failing, probably because of this: When you try to open batch in manage marc import tool, you get: DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_kohadev.me.frameworktext' isn't in GROUP BY t/db_dependent/Circulation/dateexpiry.t is failing with: Incorrect date value: '0000-00-00' for column 'dateexpiry' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 11:37:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 10:37:13 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-sDbkF9fW6o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hah! Will try again in the evening. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:32:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 11:32:17 +0000 Subject: [Koha-bugs] [Bug 20149] New: 264 Field Display on Item Searches Message-ID: <bug-20149-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20149 Bug ID: 20149 Summary: 264 Field Display on Item Searches Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nglhelpdesk at cogc.ac.uk QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This refers to the Publication Date not showing on item level searches where a 264 field has been used. showRDAtag264 element is in in the delivered xslt but no tag is present. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 12:52:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 11:52:36 +0000 Subject: [Koha-bugs] [Bug 20149] 264 Field Display on Item Searches In-Reply-To: <bug-20149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20149-70-3caxhwlyaN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20149 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The item search is not using XSLT. The problem is, that you can only map either 260 or 264 to copyrightdate in the Koha-2-MARC-Mappings in older versions, which is used for display. This will be fixed by: bug 10306 and dependencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 13:00:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 12:00:52 +0000 Subject: [Koha-bugs] [Bug 20149] 264 Field Display on Item Searches In-Reply-To: <bug-20149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20149-70-14hPg3zp67@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20149 Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 13:43:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 12:43:21 +0000 Subject: [Koha-bugs] [Bug 18891] Download Reports Directly In-Reply-To: <bug-18891-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18891-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18891-70-WpCIPknItz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18891 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- As far as I can tell the main problem with implementing this is that before initiating a download, Koha has to have received any search parameters you're submitting along with the SQL. A direct download button would give you unlimited results in cases where runtime parameters are used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:03:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 13:03:18 +0000 Subject: [Koha-bugs] [Bug 20150] New: Acquisitions wizard always uses listprice Message-ID: <bug-20150-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Bug ID: 20150 Summary: Acquisitions wizard always uses listprice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When using the acquisitions wizard, you can choose between different options: - Amount: - Ordered amount: - Spent amount: The calculations are always done with listprice. Especially for the amount spent this makes the wizard not match up with the amounts on the acquisition homepage as the actual amount spent can be quite different from the list price used when ordering. I think it probably should be calculated like this: - Amount: list price of ordered items + actual price of received items - Ordered amount: list price - Spent amount: actual price -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:03:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 13:03:48 +0000 Subject: [Koha-bugs] [Bug 20150] Acquisitions wizard falsely uses list price for calculating amounts spent In-Reply-To: <bug-20150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20150-70-SdxlzVuXFs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acquisitions wizard always |Acquisitions wizard falsely |uses listprice |uses list price for | |calculating amounts spent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:10:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 13:10:47 +0000 Subject: [Koha-bugs] [Bug 20149] 264 Field Display on Item Searches In-Reply-To: <bug-20149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20149-70-1ycdZNQTuM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20149 --- Comment #2 from GCLG <nglhelpdesk at cogc.ac.uk> --- Many thanks for the feedback. The rationale behind this came from our vendor following submitted samples of the 260 showing but the 264 not showing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:12:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 13:12:51 +0000 Subject: [Koha-bugs] [Bug 20129] MetadataPrefix=marc21 doesn't use specified xslt In-Reply-To: <bug-20129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20129-70-WnxlJBJCdq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20129 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- It is duplicate of bug 19353 You can test it and sign off ;) *** This bug has been marked as a duplicate of bug 19353 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:12:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 13:12:51 +0000 Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template for marcxml and marc21 metadata prefixes in OAI server In-Reply-To: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19353-70-o1nNNzxBIZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.stastny at teamlibrary. | |cz --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- *** Bug 20129 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 14:21:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 13:21:00 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-oC9tS9Os8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:06:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:06:12 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: <bug-20125-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20125-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20125-70-e1l2iTbUVo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71139|0 |1 is obsolete| | --- Comment #4 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 71274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71274&action=edit Bug 20125 - Add a script to claim late orders (ordersClaim.pl) Test plan: - Put some orders late from different baskets by changing the closedate column in aqbasket table, Testing delay parameters: - launch "perl misc/cronjobs/ordersClaim.pl" with the following parameters: - delay: Up to the number of days from the basket's closedate, - claimed-for: no matter for the first claim, - Check that there is one entry in message_queue *for each basket with late order(s)* - Check these late orders in database: - claims_count column should be set to 1, - claimed_date should be today Testing claimed-for parameter: - change the claimed_date column in database for all orders (i.e 2 days back), - launch "perl misc/cronjobs/ordersClaim.pl" again with the following parameters: - delay: Same than for the first test, - claimed-for: 3 (if set claimed_date 2 days back), - max-claims: at least 2 - check that there is no new entry in message_queue - launch "perl misc/cronjobs/ordersClaim.pl" again by moving only claimed-for to 1 - There should be new entry in message_queue - claims_count column should be set to 2 - claimed_date should be today Testing max-claims parameter: - change the claimed_date column in database for all orders (i.e 2 days back), - launch "perl misc/cronjobs/ordersClaim.pl" again with the following parameters: - delay: Same than for the first and second test, - claimed-for: 1 (if set claimed_date 2 days back), - max-claims: 1 and 2 (test the two options), - There should be new entry in message_queue - launch "perl misc/cronjobs/ordersClaim.pl" again by moving only max-claims to 3 - There should be new entry in message_queue - claims_count column should be set to 3 - claimed_date should be today -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:06:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:06:24 +0000 Subject: [Koha-bugs] [Bug 20151] New: Search is broken when stemming has no language Message-ID: <bug-20151-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20151 Bug ID: 20151 Summary: Search is broken when stemming has no language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org When stemming is enable in catalog searching, C4::Search::_build_stemmed_operand will transform operand into stemmed operand using stemmer Lingua::Stem::Snowball with a specified language. This stemmer returns undef is no language is defined. In classic catalog search, current language is used. But in other pages acqui/neworderbiblio.pl and cataloguing/addbooks.pl no language is defined so operand is empty. Any search returns entire catalog. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:06:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:06:33 +0000 Subject: [Koha-bugs] [Bug 20151] Search is broken when stemming has no language In-Reply-To: <bug-20151-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20151-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20151-70-qiIHiH2jj6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20151 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:10:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:10:50 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: <bug-20125-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20125-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20125-70-3RFOFVnNSe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 --- Comment #5 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to Katrin Fischer from comment #2) > Just wondering: we configure a delay value for each vendor, can this be used > in the script? I think it would make sense and have the delay value as a > possible overwrite if you haven't used the field maybe? The delay paramter of the script is set to the vendor's delivery time by default (if not used in the command) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:26:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:26:40 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-XeOQsO6JKU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:26:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:26:51 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-qINbLAKSZo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71276&action=edit Bug 9573: Lost items report - Move filters code to a separate js file For the next patches we will need to reuse what is already done on the bibliographic record detail page. This patch moves the code to make it reusable easily and avoid copy and paste. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:26:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:26:46 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-9RRo00owmA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68398|0 |1 is obsolete| | Attachment #68399|0 |1 is obsolete| | Attachment #68400|0 |1 is obsolete| | Attachment #68401|0 |1 is obsolete| | Attachment #68402|0 |1 is obsolete| | Attachment #68403|0 |1 is obsolete| | Attachment #68404|0 |1 is obsolete| | Attachment #68405|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71275&action=edit Bug 9573: Lost items report - Add items.notforloan as a filter This patch adds a new "Not for loan" status filter to the lost items report. Test plan: 0/ Apply all patches from this patch set 1/ Use the new "Not for loan" filter to search lost items 2/ The table result must be consistent and a new "Not for loan" column should be there 3/ Confirm that you are able to hide/show this column with the column settings tool. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:26:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:26:56 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-98G5RWNiTW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71277&action=edit Bug 9573: Lost items report - add KohaTable to itemlost Before this patch set, we used KohaTable to display a table with the column visibility plugin, and an usual dataTable initialisation for the filters. For the lost items report table we will need both. To do so we need to reorganize the code a bit We cannot pass a selector but the id of the node which represents the table. Indeed it is how works currently the filters (we may want to improve that later) Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:27:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:27:00 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-khSMMM2H3M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71278&action=edit Bug 9573: Lost items report - Add a new itemlost_on column This patch adds a new "Lost on" column to the result table Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:27:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:27:08 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-2JEYlwzETR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71280&action=edit Bug 9573: Lost items report - Add the CSV export ability Finally we add the ability to export the list of lost items. The items will be export in CSV format using a CSV profile defined. Test plan: 0/ Apply all the patches from this patch set 1/ Define a CSV profile (type=SQL, Usage=Export lost items in report) Try something like that to get the same columns as the default table: Title=biblio.title |Author=biblio.author |Lost status=items.itemlost |Lost on=items.itemlost_on |Barcode=items.barcode |Call number=items.itemcallnumber |Date last seen=items.datelastseen |Price=items.price |Rep. price=items.replacementprice |Library=items.homebranch |item type=items.itype |Current location=items.holdingbranch |Location=items.location |Not for loan status=items.notforloan |Notes=items.itemnotes 2/ Use the filters and select items to export 3/ Export the list of items you want and make sure the CSV is correctly formatted and contains the items you selected QA Notes: - I think we should add default CSV profiles for the different "usage", but I would consider it as a separate enhancement since none of them is defined yet - Most of the code to export CSV is no reusable. We should make Koha::Exporter::Record support CSV export for type=SQL (it only supports MARC type so far). Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:27:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:27:04 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-TMITosbEP4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71279&action=edit Bug 9573: Lost items report - Add a new "Export selected items" link Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:27:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:27:12 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-ltLdMX13qR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71281&action=edit Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:27:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:27:16 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-8ae3GD0ahl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71282&action=edit Bug 9573: Add missing use statement Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:28:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:28:21 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-AoBefcy7On@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #399 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71283&action=edit Bug 7143: Fix typo developper vs developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:28:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:28:49 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19932-70-bmu7SbWi7g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:28:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:28:51 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19932-70-qVJbpCNJgT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71284&action=edit Bug 19932: (Follow-up) Add fixed footer to cataloging Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:45:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:45:22 +0000 Subject: [Koha-bugs] [Bug 17787] Suppressed items seem to be included in count of search results In-Reply-To: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17787-70-ptnd2msdxA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Summary|Suppressed items seems so |Suppressed items seem to be |still be included in number |included in count of search |of search results |results Component|OPAC |Searching -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:46:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:46:53 +0000 Subject: [Koha-bugs] [Bug 19984] Software error Cant call method In-Reply-To: <bug-19984-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19984-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19984-70-FOPFBfz0Gb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19984 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:48:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:48:59 +0000 Subject: [Koha-bugs] [Bug 18944] ITEMTYPECAT description incorrect if itemtype is using the same code In-Reply-To: <bug-18944-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18944-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18944-70-OO3uml9BAg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18944 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ITEMTYPECAT description not |ITEMTYPECAT description |correct is itemtype is |incorrect if itemtype is |using the same code |using the same code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:58:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:58:31 +0000 Subject: [Koha-bugs] [Bug 20146] Add 040 $e in the source's column in Z39.50 search's results In-Reply-To: <bug-20146-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20146-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20146-70-wLCzv6eTuI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20146 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:58:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:58:50 +0000 Subject: [Koha-bugs] [Bug 20146] Add 040 $e in the source's column in Z39.50 search's results In-Reply-To: <bug-20146-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20146-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20146-70-4YnI4RKEJV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20146 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|BLOCKED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 15:59:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 14:59:05 +0000 Subject: [Koha-bugs] [Bug 20146] Add 040 $e in the source's column in Z39.50 search's results In-Reply-To: <bug-20146-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20146-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20146-70-cs3c1dIXOW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20146 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:30:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:30:28 +0000 Subject: [Koha-bugs] [Bug 20151] Search is broken when stemming has no language In-Reply-To: <bug-20151-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20151-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20151-70-k6NaMj3uA5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20151 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:30:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:30:30 +0000 Subject: [Koha-bugs] [Bug 20151] Search is broken when stemming has no language In-Reply-To: <bug-20151-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20151-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20151-70-r9KiCr4AS3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20151 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 71285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71285&action=edit Bug 20151: always use current language for stemming When stemming is enable in catalog searching, C4::Search::_build_stemmed_operand will transform operand into stemmed operand using stemmer Lingua::Stem::Snowball with a specified language. This stemmer returns undef is no language is defined. In classic catalog search, current language is used. But in other pages acqui/neworderbiblio.pl and cataloguing/addbooks.pl no language is defined so operand is empty. Any search returns entire catalog. This patch corrects by returning operand without change if no langage is defined in C4::Search::_build_stemmed_operand. And uses current langage in pages acqui/neworderbiblio.pl and cataloguing/addbooks.pl. Test plan : 1) Enable system preferences QueryStemming and QueryWeightFields 2) Disable system preferences QueryAutoTruncate, QueryFuzzy and UseQueryParser 3) Perform an search in catalog (without index) that uses the stemming, for example "historical" will search "histor*" 4) Go to "Cataloging" 5) Perform a search on same word in "Cataloging search" 6) Without patch you have entire catalog, with patch you have correct number of results 7) Go to aquisition on a basket and click "Add to basket" 8) Perform search in "From an existing record" 9) Without patch you have entire catalog, with patch you have correct number of results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:30:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:30:50 +0000 Subject: [Koha-bugs] [Bug 20152] New: Searching for title includes all subfields from field 780 Message-ID: <bug-20152-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20152 Bug ID: 20152 Summary: Searching for title includes all subfields from field 780 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: christian.stelzenmueller at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When searching for a title in the field 'title' (OPAC), the search includes all subfiels from marc field 780 it seems. Also 780 subfield 'd', which is "Place, publisher, and date of publication" It should only include subfield 't' - Title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:31:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:31:41 +0000 Subject: [Koha-bugs] [Bug 20145] borrowers.datexpiry eq '0000-00-00' means expired? In-Reply-To: <bug-20145-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20145-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20145-70-cYIpO5WpEU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20144 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:31:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:31:41 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-lyH32uAquu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20145 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Josef Moravec from comment #6) > Hi Jonathan, I just started to testing, found two issues till now: > > Can't recreate database, when creating table structure, I got: > there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or > ON UPDATE clause > > I am on mysql 5.5.59, which is still default in jessie, more timestamp > columns are possible from mysql 5.6.5: > https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html Erk, yes we should continue and support both. I have added a follow-up to default to NULL instead. > Second one: > Shouldn't be there atomic update for this change? > https://github.com/joubu/Koha/commit/de14e25c7b03ca9a4812df627dec397eae4261ad Yep, commit amended. (In reply to Josef Moravec from comment #7) > Few another ones: > > The tests t/db_dependent/www/batch.t and t/db_dependent/www/search_utf8.t > are failing, probably because of this: > When you try to open batch in manage marc import tool, you get: > DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_kohadev.me.frameworktext' > isn't in GROUP BY I forgot the www tests! Fixed now. > t/db_dependent/Circulation/dateexpiry.t is failing with: Incorrect date > value: '0000-00-00' for column 'dateexpiry' Yes, see this commit: """ Bug 20144: [sql_modes] NOT FIXED - Incorrect date value: '0000-00-00' for column 'dateexpiry' See bug 20145. t/db_dependent/Circulation/dateexpiry.t """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:31:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:31:49 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-JHf4RWxHej@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:37:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:37:45 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: <bug-19336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19336-70-gYmjD1nFEg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #6 from Alex Arnaud <alex.arnaud at biblibre.com> --- Hello David, What about $type and $unitcounttotal variables? If maxfinesdays is defined and amount != 0, they are empty. Indeed, $type is always empty since chargename is never populated. But this could be fixed in another BZ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:37:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:37:53 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: <bug-19336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19336-70-ohcoA80jG1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:42:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:42:25 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-wHbAAT8JTs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate --- Comment #118 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Would be good to have it for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:43:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:43:12 +0000 Subject: [Koha-bugs] [Bug 17883] Manage Patron Lists Permission incorrectly displaying hidden columns In-Reply-To: <bug-17883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17883-70-EEIk38PSII@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17883 --- Comment #4 from Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> --- Hi Grace, the display was broken library column (not the search), under stated conditions. But now it's okay in 16.11 it seems, we just checked. Thanks for looking :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:43:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:43:38 +0000 Subject: [Koha-bugs] [Bug 17883] Manage Patron Lists Permission incorrectly displaying hidden columns In-Reply-To: <bug-17883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17883-70-XV0t9zngDR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17883 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:57:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:57:09 +0000 Subject: [Koha-bugs] [Bug 20153] New: Add new column "source" in the authorities pages's result Message-ID: <bug-20153-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20153 Bug ID: 20153 Summary: Add new column "source" in the authorities pages's result Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl hi, It would be nice if we could add a new column in the results page of a search in authority's module.In this new column we could se the subfield 040 $a who show the Organization that performed the original cataloging. With this new column with this new column titled "source", like the column in the z39.50 search, we would not need to go back to the authority record to see if it's a locally created authority or if it's imported. Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 16:57:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 15:57:57 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-HNk9obnVaQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Josef Moravec <josef.moravec at gmail.com> --- Thanks Jonathan, looks good for me now For signed-off patches see https://github.com/xmorave2/Koha/commits/bug_20144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:03:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:03:09 +0000 Subject: [Koha-bugs] [Bug 20153] Add new column "source" in the authorities pages's result In-Reply-To: <bug-20153-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20153-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20153-70-rRINGjzRY3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20153 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:05:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:05:46 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19801-70-Xf6IzhpFt4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 --- Comment #13 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 71286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71286&action=edit Bug 7143: Update about page for new dev - Jenny Way Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:06:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:06:13 +0000 Subject: [Koha-bugs] [Bug 18919] "Transaction Branch" select field broken in Cash register statistics In-Reply-To: <bug-18919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18919-70-SaUKkv6TMt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18919 Lisette <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:07:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:07:18 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19801-70-hzcl51Ndl8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71286|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:07:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:07:57 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19801-70-kcwxKOWb8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70403|0 |1 is obsolete| | --- Comment #15 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 71288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71288&action=edit Bug 19801 - Fixes for QA - Fixes indentation - changes messages to patron_messages (even though it's not like that on the circulation page.) Signed-off-by: Marjorie Vila <marjorie.barry-vila at collecto.ca> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:07:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:07:51 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19801-70-9JaKMPLZmQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70402|0 |1 is obsolete| | --- Comment #14 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 71287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71287&action=edit Bug 19801 - Display messages on user details page as well as on Check Out page To test: Look up a borrower, add a message (internal or opac) Click the Details tab for that borrower Messages should be displayed above the user information [is this the right place? it could go below] adding messages on this page should make them immediately available deleting messages on this page should delete them immediately and bring you back to the detail page. Basically, make sure messages work from both the Check out and detail pages and that there are no typos. Messages should work the same as they always have from the Check Out page. sponsored-by: Catalyst IT Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Marjorie Vila <marjorie.barry-vila at collecto.ca> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:12:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:12:01 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19801-70-PtZEoTbhqu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:14:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:14:35 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-xKxjrlQady@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #119 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Very quick QA feedbacks: * +use Koha::Account::Line; added in C4/Overdues.pm * in getDatesInfo + select => [ 'date', { DATE => 'date' } ], + as => [qw/ date date /], What does this? * Mix of snake_case and camelCase in method names (stick to snake_case) * Same for columns in DB (isopened => is_opened) * "DFLT" for the default is confusing, use empty string instead like in other areas of Koha * Why did not you use Koha::Object[s]? * + my ($self, $title, $weekday, $holidaytype, $openHour, $closeHour, $startDate, $endDate, $deleteType, $today) = @_; You should use a hashref instead * Types of holidays (E, F, N, R, W): please use global variables with readable value ($holidays->{Exception} = "E"; for instance, or $EXCEPTION_HOLIDAY = 'E') It will make this kind of lines easier to read: + }elsif ($holidaytype eq 'E' || $holidaytype eq 'F' || $holidaytype eq 'N') { * When you use DBIx::Class you should avoid to write SQL, for instance: date BETWEEN DATE(?) AND DATE(?) should be: date => { '>=' => $from, '<=' => $to } or: date => { -between => [$from, $to] } * Isn't DAYOFWEEK a MySQLism? We think we should find another way to do that. * At first glance DateTime::Format::Strptime->new should be replaced with my $dtf = $schema->storage->datetime_parser * misc/cronjobs/add_days_discrete_calendar.pl is using SQL statements, use your new module instead * This same cronjob must use $schema->storage->txn_begin or ->txn_do instead of turning off the AutoCommit flag of DBI * t/db_dependent/Fines.t: Do not use DateTime directly, dt_from_string instead: dt_from_string->add( day => 42 ) * tools/discrete_calendar.pl Use C4::Context::only_my_library for $onlymine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:20:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:20:50 +0000 Subject: [Koha-bugs] [Bug 20129] MetadataPrefix=marc21 doesn't use specified xslt In-Reply-To: <bug-20129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20129-70-TZMZ6Vsgvq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20129 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #2 from Mike <black23 at gmail.com> --- Here is how sign-off pathes: https://wiki.koha-community.org/wiki/Sign_off_on_patches or kohadevbox: https://github.com/digibib/kohadevbox -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:25:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:25:44 +0000 Subject: [Koha-bugs] [Bug 19106] Pop up MARC preview window appears when searching in Chrome, cannot be closed In-Reply-To: <bug-19106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19106-70-h9eBPYdyQ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19106 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|REOPENED |RESOLVED --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This bug was reopened without any new information. If you believe this is a valid bug please re-open and provide information about how to reproduce the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:29:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:29:38 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-DUH6mpD6yn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #120 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- * There no link to the new page from the navbar * What about the old pages? * What about the old modules? I would expect them to be removed * cronjob must be added to the debian cronjob file (debian/koha-common.cron.*) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:34:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:34:52 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-zrw0Ec7F7f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:36:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:36:57 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-PrKgXS5h4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:37:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:37:00 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-TQ1ygQYcTO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70724|0 |1 is obsolete| | Attachment #70725|0 |1 is obsolete| | Attachment #70726|0 |1 is obsolete| | Attachment #70953|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71289&action=edit Bug 19641: Move patron templates to the footer This patch modifies the staff client patron module templates so that JavaScript is included in the footer instead of the header. This patch touches a lot of files because the changes are all interdependent, affecting a couple of module-wide include files. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Patrons -> Patrons home, patron search results -> Manage pending modification requests -> Patron detail page -> Edit patron -> Set guarantor -> Fines -> Account, Pay fines, Create manual invoice, Create manual credit -> Print receipts for different kinds of charges -> Routing lists -> Circulation history -> Holds history -> Notices -> Statistics -> Files -> Purchase suggestions -> Discharges -> Housebound -> Set permissions -> Change password -> Print summary, slips, and overdues -> Update child to adult patron type Patron toolbar and patron search bar operations should work correctly on all pages. This patch also updates the template for searching the Norwegian national patron database, but it has NOT been tested. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=19682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:37:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:37:05 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-UoMNvfS57v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #18 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71290&action=edit Bug 19641: (Follow-up) Update circulation.tt too This patch makes the same JS-to-footer changes to circulation.tt. Inclusion of this template in this bug is necessary because it includes members-toolbar.inc. To test, apply the patch and clear your browser cache if necessary. - Enter a patron card for checkout - Test any JavaScript-driven actions on the checkout page, for instance: - Select all/clear all controls - Datepicker/timepickers - Datatable sorting, columns configuration - Renewals, check-ins - Patron message interactions, print slip, and other toolbar actions - Checkout exports - Search to hold - Tab loading: Restrictions, Holds, Clubs Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=19682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:37:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:37:07 +0000 Subject: [Koha-bugs] [Bug 19799] [16.11] Changing language on OPAC redirects back to homepage In-Reply-To: <bug-19799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19799-70-B75hokltBp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I cannot reproduce this problem in 16.11.15. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:37:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:37:10 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-rOX67JlGrj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #19 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71291&action=edit Bug 19641: (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=19682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:37:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:37:14 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-M0iowlgtaz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #20 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71292&action=edit Bug 19641: (Follow-up) Fix update child menu option This follow-up corrects handling of clicks on the "Update child" menu option when the patron is an adult. Previously the click handler was conditionally added via template markup. This patch modifies it to use the data-tooltip attribute as an indicator that the option is disabled. To test, apply the patch and clear your browser cache if necessary. - Open an adult patron's record for viewing. - Choose More -> Update child from the toolbar menu. - The menu item should be disabled, and should show a tooltip. - Clicking the menu item should do nothing. - Open a child patron's record for viewing. - Choose More -> Update child from the toolbar menu. - The patron should be updated to an adult category. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=19682 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:37:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:37:59 +0000 Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related tools In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19682-70-Q0atwOEEWQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:38:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:38:04 +0000 Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related tools In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19682-70-sxQpnrWkCL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70467|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71293&action=edit Bug 19682: Move JS to the footer: Two patron-related tools This patch modifies two patron-related tools templates in the staff client so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Import patrons - Upload patron images Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Edit for QA: Fixed datepickers on import patron form Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 17:55:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 16:55:25 +0000 Subject: [Koha-bugs] [Bug 20154] New: stay in the open tab when going into edit mode Message-ID: <bug-20154-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20154 Bug ID: 20154 Summary: stay in the open tab when going into edit mode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, When we consult an authority in the authorities module, it would be nice too stay in the tab that are actually open when we switch to edit mode. Currently when you consult an authority notice and you open a tab (for exemple the tab 2) if you switch to the edit mode we will automaticaly arrive at the record in edit mode but with tab "0" open. Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:08:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:08:40 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-qLFibk8buR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #121 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am not familiar enough with the current UI or how the calendar is used by libraries. So it is hard to give my point of view on the UI changes. About the performances: * did you take a look at Date::Holidays? * What about loading the calendar in memory (with the existing data) with a home-made structure and improve is_holiday * What were the bottlenecks? Do you still have the nytprof raw files, or the html files? You only provided the global result so we cannot identify what are the slow areas. Switched to in discussion for this comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:11:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:11:56 +0000 Subject: [Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons In-Reply-To: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19954-70-wIW5VBYajt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:12:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:12:02 +0000 Subject: [Koha-bugs] [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons In-Reply-To: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19982-70-T2dMbWVlK2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:15:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:15:09 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18421-70-dgzxCMClX7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com, | |eric.begin at inLibro.com Assignee|koha-bugs at lists.koha-commun |charles.farmer at inlibro.com |ity.org | --- Comment #1 from Charles Farmer <charles.farmer at inlibro.com> --- > When turned on, Coce cover images appear in the OPAC only, not staff interface. (Coce Cover images - settings in enhanced content.) Desired setting would be like Amazon cover settings - the ability to turn on Coce images for the OPAC and/or the staff interface separately. There's a patch developed on our end that would offer just that: giving the option to control Coce's behavior separately between OPAC and the staff intranet. I'll join it to this bug instead of creating a new one. > Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC. This is false, from what I understand. Coce is queried after the page is loaded, yes, but the results should be dynamically appended to the page if images were found. What might've happened on your end is multiple image providers returning empty results, which were in turn cached by redis and given back every time you made a subsequent request. In that case, it's more related to Coce's backend than Coce itself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:15:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:15:51 +0000 Subject: [Koha-bugs] [Bug 20155] New: Improve readability of OPAC header language menu Message-ID: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 Bug ID: 20155 Summary: Improve readability of OPAC header language menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The language menu in the OPAC's header has light blue links which aren't very readable because of their low contrast. This menu should be styled to match the Lists menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:16:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:16:14 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-wvpGP20vTw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #124 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- As bug 19290 adds a new pref to turn the feature on/off, should not we do the same for the OPAC? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:16:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:16:54 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios - OPAC In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-5MJvVLJ3jx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Browse selected biblios |Browse selected biblios - | |OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:17:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:17:09 +0000 Subject: [Koha-bugs] [Bug 19290] Browse selected biblios - Staff In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19290-70-QYIuiuCUU1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the ability to filter a |Browse selected biblios - |result list on staff client |Staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:17:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:17:13 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18421-70-13tr2Y4SDt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:17:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:17:29 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios - OPAC In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-6jgLQuFghU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:17:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:17:33 +0000 Subject: [Koha-bugs] [Bug 19290] Browse selected biblios - Staff In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19290-70-mdY8c0VnKL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:26:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:26:51 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-SGdMYN006A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71294&action=edit Bug 20155 - Improve readability of OPAC header language menu This patch makes some minor HTML and CSS changes in order to make the header's language-chooser menu more readable and consistent with the Lists menu. To test, apply this patch and the patch with the compiled CSS. - Install and enable more than one translation. - Set the OpacLangSelectorMode to either "top" or "both top and footer." - View the OPAC's header menu and confirm that the links and menus look correct whether or not a user is logged in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:26:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:26:49 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-XVbpyN0VyX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:26:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:26:54 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-RUeaga62sX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71295&action=edit Bug 20155 (Follow-up) Compiled CSS This patch contains the compiled opac.css file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:37:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:37:39 +0000 Subject: [Koha-bugs] [Bug 20156] New: Staff client header language menu doesn't show check mark for current language Message-ID: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Bug ID: 20156 Summary: Staff client header language menu doesn't show check mark for current language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The markup for the staff client header's language menu is supposed to show a check mark next to the currently-selected language. Because of copy-paste from the OPAC (which uses Glyphicons), the check mark doesn't appear. It should use Font Awesome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:41:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:41:26 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-kohnbZRU04@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71296&action=edit Bug 20133 [QA Followup] - Tweak new 'group features' section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:48:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:48:00 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16735-70-00DEywpJmP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20157 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:48:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:48:00 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-94XojVARpX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20157 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:48:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:48:00 +0000 Subject: [Koha-bugs] [Bug 20157] New: Use group 'features' to decide which groups to use for group searching functionality Message-ID: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Bug ID: 20157 Summary: Use group 'features' to decide which groups to use for group searching functionality Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 16735, 20133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 [Bug 20133] "Hide patron information" feature should not affect all library groups -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:49:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:49:06 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-vth0HCzL05@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:49:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:49:23 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-LvE1RtXxdW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:50:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:50:58 +0000 Subject: [Koha-bugs] [Bug 20156] Staff client header language menu doesn't show check mark for current language In-Reply-To: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20156-70-nId34eFX9O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:51:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:51:00 +0000 Subject: [Koha-bugs] [Bug 20156] Staff client header language menu doesn't show check mark for current language In-Reply-To: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20156-70-d4xXqLEkG4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71297&action=edit Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:59:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:59:58 +0000 Subject: [Koha-bugs] [Bug 19848] Course module contents stuck to left side of page In-Reply-To: <bug-19848-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19848-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19848-70-98a5GLEmm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19848 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This will be fixed by Bug 19981. *** This bug has been marked as a duplicate of bug 19981 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 18:59:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 17:59:58 +0000 Subject: [Koha-bugs] [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves In-Reply-To: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19981-70-hfIEzJh3Fw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 19848 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:08:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:08:29 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-aa92ny7jqN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #122 from Blou <philippe.blouin at inlibro.com> --- I think the old page was not removed because the developper didn't want to "shock" the testers, and allow for easy comparison. I think David will create a separate patch for it. Regarding the other points: - This was coded 18 months ago. The nytprof has been written over. But I remember the main culprit was addDay, which created tons of object for simple calculation. - Fundamentaly, the old(and current) system is flawed, so although we did use in-memory hash for storing the holidays (along with our custom open/close hours) for years on our clients, that was not a good system. Calculation on past dates was always flawed because any change to an holiday rule would skewed calculation. This method stores for good the opening/close dates and hours, so any future change through the interface won't affect past dates. The new UI offers more flexibility. The calculations are always good. And extremely fast. It adds opening and close time. And it's clean and easy to add on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:18:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:18:04 +0000 Subject: [Koha-bugs] [Bug 20156] Staff client header language menu doesn't show check mark for current language In-Reply-To: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20156-70-itgQ9Uml0k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:18:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:18:06 +0000 Subject: [Koha-bugs] [Bug 20156] Staff client header language menu doesn't show check mark for current language In-Reply-To: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20156-70-BCpEhS9DR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71297|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 71298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71298&action=edit Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:23:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:23:40 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-qKsFXRVjqK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71294|0 |1 is obsolete| | Attachment #71295|0 |1 is obsolete| | --- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 71299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71299&action=edit [SIGNED-OFF] Bug 20155 - Improve readability of OPAC header language menu This patch makes some minor HTML and CSS changes in order to make the header's language-chooser menu more readable and consistent with the Lists menu. To test, apply this patch and the patch with the compiled CSS. - Install and enable more than one translation. - Set the OpacLangSelectorMode to either "top" or "both top and footer." - View the OPAC's header menu and confirm that the links and menus look correct whether or not a user is logged in. Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:23:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:23:37 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-zai166rb1H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:23:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:23:43 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-bw0YhVu3tP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 --- Comment #4 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 71300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71300&action=edit [SIGNED-OFF] Bug 20155 (Follow-up) Compiled CSS This patch contains the compiled opac.css file. Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:32:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:32:24 +0000 Subject: [Koha-bugs] [Bug 20149] 264 Field Display on Item Searches In-Reply-To: <bug-20149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20149-70-JdTFtKG30a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20149 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Result list, detail pages and lists can use XSLT, in other places often the database fields are used for a quick summary display. *** This bug has been marked as a duplicate of bug 10306 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:32:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:32:24 +0000 Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264) In-Reply-To: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10306-70-zPF9LeUlOE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nglhelpdesk at cogc.ac.uk --- Comment #81 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 20149 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:36:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:36:19 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-bsK1MdeGG9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64211|0 |1 is obsolete| | Attachment #64212|0 |1 is obsolete| | Attachment #64213|0 |1 is obsolete| | Attachment #64214|0 |1 is obsolete| | Attachment #64215|0 |1 is obsolete| | Attachment #64216|0 |1 is obsolete| | Attachment #64218|0 |1 is obsolete| | Attachment #64219|0 |1 is obsolete| | Attachment #64221|0 |1 is obsolete| | Attachment #64229|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71301&action=edit Bug 18789: Send Koha::Patron object to the templates In order to simplify and make uniform the code, the controller scripts send a Koha::Patron object to the templates instead of all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. The variable "patron" sent to the templates is supposed to represent the patron the librarian is editing the detail. In the members module and some scripts of the circulation module, the patron's detail are sent one by one to the template. That leads to frustration from developpers (making sure everything is passed from all scripts) and to regression (we got tone of bugs in the last year because of this way to do). With this patch set it will be easy access patron's detail, passing only 1 variable from the controllers. Test plan: Play with the patron and circulation module and make sur the detail of the patron you are editing/seeing info are correctly displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:36:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:36:28 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-CoT8u4v2Xj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71303&action=edit Bug 18789: Use Koha::Patron->image from the templates Now that we have the 'patron' variable in all our templates, we can call Koha::Patron->image and do the check from the templates. Test plan: On the different pages of the patron module, you should see the default image if there is no image attached or the one that has been attached (see pref patronimages) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:36:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:36:24 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-NwHdx157pE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71302&action=edit Bug 18789: Pass a Koha::Patron object from returns.pl This is a specific patch for returns.pl Test plan: Do some checkin for a patron and make sure the info are correctly displayed (and info from someone that has placed a hold on this item) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:36:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:36:33 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-PjESlLjs6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71304&action=edit Bug 18789: add tests for is_adult and is_child This patch add 2 methods to the Koha::Patron module: is_adult and is_child. That way the business logic is at only one place and covered by tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:36:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:36:37 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-cztVub91Si@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71305&action=edit Bug 18789: Use Koha::Patron->is_child where needed Test plan: When you are on a page related to a child you should see the "Update child to adult patron" button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:36:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:36:41 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-BHJBIRYcAE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71306&action=edit Bug 18789: Use Koha::Patron->is_adult where needed Test plan: When editing adult's info you must see the "Add child" button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:36:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:36:44 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-WQiZNr1jx9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71307&action=edit Bug 18789: Remove useless IS_ADULT variable Test plan: git grep IS_ADULT must not return any results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:36:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:36:48 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-WVh1J5IfBZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71308&action=edit Bug 18789: Remove adultborrower from the pay* scripts This flag is not used in the templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:36:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:36:52 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-r1esRwlpS2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71309&action=edit Bug 18789: Update other occurences where is->child should be used Trivial changes here, just do a code review on the QA step -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:36:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:36:55 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-eFQV46TXw7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71310&action=edit Bug 18789: (follow-up)Send Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:37:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:37:55 +0000 Subject: [Koha-bugs] [Bug 20125] Add a cron script to claim late orders In-Reply-To: <bug-20125-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20125-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20125-70-4Xqwd0JKEj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Ah, so it's optional? Great :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:38:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:38:20 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-x6Q6Y00Hxw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff Keywords| |RM_priority --- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This is very hard to rebase and will introduce a lot of issues if not pushed quickly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:43:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:43:05 +0000 Subject: [Koha-bugs] [Bug 19801] Display messages on user details page as well as on check out page In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19801-70-ovv68tlzGo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Internal note added to the |Display messages on user |detail's user page |details page as well as on | |check out page --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Changing title for release notes to match patch description! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:45:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:45:47 +0000 Subject: [Koha-bugs] [Bug 19799] [16.11] Changing language on OPAC redirects back to homepage In-Reply-To: <bug-19799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19799-70-5afIV5fegk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, still seeing it in our 16.11.15 installation. How did you test? 1) Select English 2) Do a search in the OPAC 3) Switch language 4) You are returned to the start page instead of remaining on the result list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 19:54:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 18:54:49 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-hbr2NafPgt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71311&action=edit Bug 18789: (follow-up) Use Koha::Patron->image from the templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:16:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:16:00 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-tdkxHUy6G0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68750|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:16:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:16:05 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-PqlVOslI6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:16:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:16:09 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-bgTwVGSvyH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68752|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:16:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:16:13 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19479-70-JvvG3OWGoW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:16:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:16:13 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-pBfZrPNFpP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:16:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:16:16 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19479-70-SBmKDhinA8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68972|0 |1 is obsolete| | --- Comment #9 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 71312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71312&action=edit Attempt to display price formatted according to CurrencyFormat syspref using templates, with the English template as an example. 1) Create some baskets with items in them. 2) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 3) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:16:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:16:20 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-2HC5n2mouL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:16:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:16:25 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-BYEBWEBXki@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68730|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:16:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:16:28 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-i4098hwPhz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68731|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:17:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:17:31 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19479-70-sKcYdVM6Lx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71312|0 |1 is obsolete| | --- Comment #10 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 71313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71313&action=edit Bug 19479 - Display prices in basket group with correct currency formatting Attempt to display price formatted according to CurrencyFormat syspref using templates, with the English template as an example. 1) Create some baskets with items in them. 2) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 3) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:18:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:18:05 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-h2DdaltrIo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #46 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 71314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71314&action=edit Bug 15486: DB structure change This patch adds a new column __max_holds_per_day__ to the issuingrules table. It's going to be used to set a daily limit for holds. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:18:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:18:10 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-8Lgs4gGjwR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #47 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 71315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71315&action=edit Bug 15486: DBIC update schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:18:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:18:15 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-Aqir8psnMi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #48 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 71316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71316&action=edit Bug 15486: Unit tests This patch introduces unit tests for the new circulation rules option that allows setting a max holds per day limit. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: CanItemBeReserved doesn't check the amount of holds per day and the introduced error code is not returned. OK is returned instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:18:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:18:25 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-x3O9Jz4gRX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #50 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 71318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71318&action=edit Bug 15486: Modify request.tt to handle the new error string This patch makes reserve/request.pl display a convenient error description when a hold cannot be placed due to the new daily limit configuration. To test: - Apply this patchset - Upgrade - Configure your circulation rules so there's a daily limit for holds - Place holds so the patron reaches the maximum - Place one more hold - Notice the hold cannot be placed and a convenient error message is displayed. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:18:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:18:20 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-b3sxswvGWe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #49 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 71317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71317&action=edit Bug 15486: Extend CanItemBeReserved so it handles daily holds limits This patch implements the required changes in C4::Reserves::CanItemBeReserved so it implements a daily limit on holds. It returns the 'tooManyReservesToday' string if the policy doesn't allow placing the hold. It returns 'OK' (current behaviour) otherwise. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: Tests fail because the error condition is not making CanItemBeReserved return the desired error code. - Apply this patch - Run: k$ prove t/db_dependent/Holds.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:18:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:18:30 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-a93mEhuPu2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #51 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 71319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71319&action=edit Bug 15486: Make circ rules UI handle holds_per_day This patch makes the staff UI correctly handle the holds_per_day configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:19:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:19:47 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19479-70-bfhozda3iE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #11 from Jon Knight <J.P.Knight at lboro.ac.uk> --- One thing to note is that if I use the templates rather than my original patch that just altered basketgroup.pl to do the formatting, I'm guessing that each language that Koha is in will also need its basketgroup.tt template updated? Is that right? I've only done the en (default English) one in this current patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:19:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:19:31 +0000 Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15486-70-eyQKKOIh8L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:27:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:27:34 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-hIFNZ7YuUC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #34 from Owen Leonard <oleonard at myacpl.org> --- I think "CSV" is commonly understood to include more than just comma-separated values. Is it really necessary to be so specific? For instance, an application like phpMyAdmin offers export in "CSV" format, but it doesn't limit you to comma-separated output. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:27:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:27:36 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19479-70-VNT0AWtGLl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jon Knight from comment #11) > One thing to note is that if I use the templates rather than my original > patch that just altered basketgroup.pl to do the formatting, I'm guessing > that each language that Koha is in will also need its basketgroup.tt > template updated? Is that right? I've only done the en (default English) > one in this current patch. Thx for thinking about translations :) But you are fine - the translated templates are generated automatically from the English templates with scripts. Changing the English 'master' template is enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:32:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:32:19 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: <bug-19933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19933-70-6cslun4iNF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:56:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:56:24 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-kbvwQPfSHr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:56:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:56:26 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-7YVyaIEHvQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71320&action=edit Bug 20157 - Use group 'features' to decide which groups to use for group searching functionality Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. Test Plan: 1) Check to ensure existing group searches still show as they used to -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 20:56:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 19:56:32 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-RsyL97JnbR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71321&action=edit Bug 20157 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:07:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:07:23 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18421-70-LUA0CYFK8u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #2 from Charles Farmer <charles.farmer at inlibro.com> --- Created attachment 71322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71322&action=edit Bug18421 - Add Coce to the staff intranet TEST PLAN: 1) Apply the patch with git-bz 2) Run updatedatabase.pl 2.1) Console output should confirm database modification 3) Visit the 'Enhanced Content' tab of admin/syspref 3.1) ressource is /cgi-bin/koha/admin/preferences.pl?tab=enhanced_content 3.2) You should see that the previous preference, Coce, is now CoceOPAC, and that a new preference was added, CoceIntranet 4) Activate CoceIntranet 5) Do a search for a book for which you have a Coce cover 5.1) The cover image url should now point to a provider you defined in Coce 5.2) Your Coce log should show a query 6) Click on the book's name to visit the detail.pl page 6.1) The book's cover should also be provided by Coce on that page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:09:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:09:27 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18421-70-WiU4J9ssqp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:12:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:12:30 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18421-70-vlQLxuXrWE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:14:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:14:40 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-9TGFggDog8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71320|0 |1 is obsolete| | Attachment #71321|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71323&action=edit Bug 20157 - Use group 'features' to decide which groups to use for group searching functionality Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. Test Plan: 1) Check to ensure existing group searches still show as they used to -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:14:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:14:48 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-jbYyPl3JZ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71324&action=edit Bug 20157 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:25:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:25:05 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-npHYXq69md@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- ... and it sure was the trailing slash! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:25:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:25:54 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-adqS7s7s7f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71244|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71325&action=edit Bug 20134: Remove /api/v1/app.pl from the generated URLs This patch removes the /api/v1/app.pl prefix from generated baseUrl. It has the consequence of hardcoding / as the base path for the API. This is ok because we don't currently support mounting Koha pieces in different than hardcoded paths (/cgi-bin/koha?), but certainly worth mentioning because this will need to depend on a syspref or config entry when someone chages this behviour. To test: - On master, point your browser to: http://kohadev.mydnsname.org:8080/api/v1/ => FAIL: basePath looks like /api/v1/app.pl/api/v1 - Apply this patch - Restart memcached and plack: $ restart_all or $ sudo systemctl restart memcached && sudo systemctl restart koha-common - Reload http://kohadev.mydnsname.org:8080/api/v1/ => SUCCESS: basePath is /api/v1 - Sign off :-D Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:25:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:25:50 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-cCj7zpT3Cd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:26:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:26:22 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-N7JpXDH3yR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:27:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:27:12 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-XhSa1B5jCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx for your comment, Owen! My suggestion is to keep the current descriptions then and make sure the delimiter is used properly everywhere :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:27:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:27:26 +0000 Subject: [Koha-bugs] [Bug 10708] Make fine receipt customizable In-Reply-To: <bug-10708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10708-70-GlxR3hySmM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 karen.fellows at citruslibraries.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karen.fellows at citruslibrari | |es.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:36:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:36:10 +0000 Subject: [Koha-bugs] [Bug 16124] Checking "is a url" box in MARC subfield does not turn it into a link In-Reply-To: <bug-16124-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16124-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16124-70-VnXS68xBjq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16124 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:54:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:54:48 +0000 Subject: [Koha-bugs] [Bug 20158] New: add a new column in the tables of the list's module Message-ID: <bug-20158-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20158 Bug ID: 20158 Summary: add a new column in the tables of the list's module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, at the intranet, it would be nice to add a new column in the tables of the list's module. In this new column we would see the barcodes of the records that this list holds. This would be usefull. Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:56:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:56:25 +0000 Subject: [Koha-bugs] [Bug 20158] add a new column in the tables of the list's module In-Reply-To: <bug-20158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20158-70-glbP0srHGE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20158 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Patrick, as the lists are record level and not item level, so far no item information is shown. There could be a lot of items making the display hard to read. Maybe a link would work? Or just the number of items? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 21:58:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 20:58:17 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-J7oQF2PCIb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Retesting... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:02:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:02:52 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-p32Ju8uS6E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #3) > 1) With the patch applied the paging (next page, previous page) when > ordering from z39.50 are no longer working. Owen asked me to retest this and he was right - works like a charm now. > 2) Transferring from the invoice page opens in a new tab, while transferring > from the basket page opens a new window - shouldn't both behave the same? > Outside of the scope of this bug, as it's the same with and without the > patches. > > Owen, should we file a new bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:03:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:03:16 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-SzMNOQIQ2u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:03:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:03:20 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-87j4f2Rh1x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70873|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71326&action=edit Bug 19755: Move template JavaScript to the footer: Acquisitions, part 3 This patch modifies even more staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Vendor -> Vendor details - Contracts datatable - Edit vendor - Add contacts, form validation - Acquisitions -> Vendor -> Invoices -> Invoice -> "Go to receipt" - Datatables, MARC and Card previews - Transfer - Confirmation of transfer, window closes - Acquisitions -> Vendor -> Receive shipments - Datatables, date pickers - Acquisitions -> Available funds table -> Spent report - Datatables - Acquisitions -> Vendor -> Uncertain prices - Datatables, form validation - Acquisitions -> Vendor -> Basket -> Add to basket from external source - Select and clear all on search form - Search results - Datatables, MARC and Card previews, in-table pop-up controls (click any table cell) Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:14:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:14:04 +0000 Subject: [Koha-bugs] [Bug 17328] Koha fixes for Mysql 5.7 In-Reply-To: <bug-17328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17328-70-LxJFg1xSmf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17328 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20144 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:14:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:14:04 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-OepXXCjqS6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17328 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:14:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:14:06 +0000 Subject: [Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present In-Reply-To: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19451-70-mbbQefWtnf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68844|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71327&action=edit Bug 19451: Add no_overwrite option to borrowers-force-messaging-defaults.pl This option allows you to add preferences only when they are not yet present. In other words: skip patrons that already set their prefs. Test plan: [1] Delete all borrower messaging prefs for a patron. [2] Run borrowers-force-messaging-defaults.pl -no-overwrite -doit Verify that the patron now has default msg preferences. [3] Change his settings and make them non-default. For instance, increase days in advance. [4] Run borrowers-force-messaging-defaults.pl -no-overwrite -doit Verify that the patron still has the non-default settings. [5] Run borrowers-force-messaging-defaults.pl -doit Verify that the patron msg prefs have been overwritten. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:13:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:13:59 +0000 Subject: [Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present In-Reply-To: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19451-70-eQebEnbu3r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:14:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:14:12 +0000 Subject: [Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present In-Reply-To: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19451-70-Xkvc9OyPo6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451 --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71328&action=edit Bug 19451: (QA follow-up) Change parameter name no_overwrite to no-overwrite for consistency Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:14:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:14:23 +0000 Subject: [Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present In-Reply-To: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19451-70-O9w4jOTb5y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:16:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:16:36 +0000 Subject: [Koha-bugs] [Bug 20156] Staff client header language menu doesn't show check mark for current language In-Reply-To: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20156-70-okDpwuZXOr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:20:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:20:00 +0000 Subject: [Koha-bugs] [Bug 20156] Staff client header language menu doesn't show check mark for current language In-Reply-To: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20156-70-ZQHxE7Vds7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:20:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:20:04 +0000 Subject: [Koha-bugs] [Bug 20156] Staff client header language menu doesn't show check mark for current language In-Reply-To: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20156-70-oQltfBagEQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71298|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71329&action=edit Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:20:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:20:42 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-llZTkmzCaa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:22:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:22:56 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-2xrB83fFPo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Owen, great patches as usual :) Fixed the bug descriptions a bit to fit the new guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:23:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:23:55 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-9X8MBbpteN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71330&action=edit Bug 20155: Improve readability of OPAC header language menu This patch makes some minor HTML and CSS changes in order to make the header's language-chooser menu more readable and consistent with the Lists menu. To test, apply this patch and the patch with the compiled CSS. - Install and enable more than one translation. - Set the OpacLangSelectorMode to either "top" or "both top and footer." - View the OPAC's header menu and confirm that the links and menus look correct whether or not a user is logged in. Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:23:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:23:59 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-xOpoSMSka8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71331&action=edit Bug 20155: (follow-up) Compiled CSS This patch contains the compiled opac.css file. Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:24:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:24:30 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-fPDw9atyR3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:24:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:24:32 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-EdJvAzxUxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71299|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:24:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:24:35 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-UzkajaNhfD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71300|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:25:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:25:49 +0000 Subject: [Koha-bugs] [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons In-Reply-To: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19982-70-11vRpeFN3I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:36:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:36:33 +0000 Subject: [Koha-bugs] [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons In-Reply-To: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19982-70-QMUkVukyaK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:36:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:36:36 +0000 Subject: [Koha-bugs] [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons In-Reply-To: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19982-70-XxPTcyGPZg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70839|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71332&action=edit Bug 19982: Switch single-column templates to Bootstrap grid: Patrons This patch updates two single-column patron module templates to use the Bootstrap grid: - discharges.tt - The list of pending discharges. One or more discharges must have been made via the OPAC. From the staff client home page, look for "Discharge requests pending." - members-update.tt - The list of pending patron updates. One or more updates must have been submitted via the OPAC. From the staff client home page, look for "Patrons requesting modifications." Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 7 22:37:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 21:37:17 +0000 Subject: [Koha-bugs] [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons In-Reply-To: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19982-70-T0aIdtZ54w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Tested on top of dependent bug 19641 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 00:05:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 23:05:00 +0000 Subject: [Koha-bugs] [Bug 15013] test option (-t) does not work in batchRebuildItemsTables.pl In-Reply-To: <bug-15013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15013-70-VSTgwcMLAG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15013 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Joy Nelson <joy at bywatersolutions.com> --- This appears to have been corrected? I see the following code which fixed this issue pod2usage(1) if $help || ( !$confirm && !$test_parameter ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 00:30:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 23:30:07 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18421-70-VYTpWGhPcU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #3 from Agnes Rivers-Moore <arm at hanover.ca> --- (In reply to Charles Farmer from comment #1) > > When turned on, Coce cover images appear in the OPAC only, not staff interface. > (Coce Cover images - settings in enhanced content.) > Desired setting would be like Amazon cover settings - the ability to turn on > Coce images for the OPAC and/or the staff interface separately. > > There's a patch developed on our end that would offer just that: giving the > option to control Coce's behavior separately between OPAC and the staff > intranet. > > I'll join it to this bug instead of creating a new one. > > > Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC. > > This is false, from what I understand. > > Coce is queried after the page is loaded, yes, but the results should be > dynamically appended to the page if images were found. What might've > happened on your end is multiple image providers returning empty results, > which were in turn cached by redis and given back every time you made a > subsequent request. > > In that case, it's more related to Coce's backend than Coce itself. I am very glad this is being addressed, thank you! Re the behaviour - I found that none of the images would load when the search was initially done. However, paging forward and then returning, or repeating the search would load all the images (or almost all). If the search had been done before, and was done again, then images loaded right away in the search results, without needing a refresh. This behaviour is not consistent with your description of how Coce & Koha is expected to work - the images were not dynamically appended unless the page was refreshed in some way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 00:31:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Feb 2018 23:31:27 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18421-70-rBcWGg34RH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #4 from Agnes Rivers-Moore <arm at hanover.ca> --- (In reply to Charles Farmer from comment #1) > > When turned on, Coce cover images appear in the OPAC only, not staff interface. > (Coce Cover images - settings in enhanced content.) > Desired setting would be like Amazon cover settings - the ability to turn on > Coce images for the OPAC and/or the staff interface separately. > > There's a patch developed on our end that would offer just that: giving the > option to control Coce's behavior separately between OPAC and the staff > intranet. > > I'll join it to this bug instead of creating a new one. > > > Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC. > > This is false, from what I understand. > > Coce is queried after the page is loaded, yes, but the results should be > dynamically appended to the page if images were found. What might've > happened on your end is multiple image providers returning empty results, > which were in turn cached by redis and given back every time you made a > subsequent request. > > In that case, it's more related to Coce's backend than Coce itself. I am very glad this is being addressed, thank you! Re the behaviour - I found that none of the images would load when the search was initially done. However, paging forward and then returning, or repeating the search would load all the images (or almost all). If the search had been done before, and was done again, then images loaded right away in the search results, without needing a refresh. This behaviour is not consistent with your description of how Coce & Koha is expected to work - the images were not dynamically appended unless the page was refreshed in some way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 04:01:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 03:01:19 +0000 Subject: [Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16330-70-z5eSBWDZ3g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 --- Comment #86 from Bob Birchall <bob at calyx.net.au> --- (In reply to Tom?s Cohen Arazi from comment #85) > Created attachment 70038 [details] [review] > Bug 16330: Remove validation code from Koha::Patron > > This patch removes previously added validation code from Koha::Patron > as we will rely on the DB structure and relationships to catch the same > problems. This is implemented on bug 19828. > > This patch also adapts the API controller class to expect this behaviour > change from Koha::Patron. The expected exceptions are adjusted, and some > minor changes take place. The API tests are adjusted as well. > > To test: > - Run: > $ kshell > k$ prove t/db_dependent/Koha/Patrons.t > k$ prove t/db_dependent/api/v1/patrons.t > => SUCCESS: Tests should still pass > > Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Is this waiting for extra sign-offs or is it ready for QA? If we (ie Dilan) can help, please let us know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 07:31:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 06:31:41 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-8zsRLEMFhX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 07:48:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 06:48:19 +0000 Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML link element in last breadcrumb In-Reply-To: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19729-70-46LjmWRSB0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I like Owen's suggestion, it makes sense to me. Should we move this onto a bug to change this globally? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 08:00:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 07:00:00 +0000 Subject: [Koha-bugs] [Bug 17241] Start using Bower for installing and managing Koha's JavaScript Dependencies In-Reply-To: <bug-17241-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17241-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17241-70-kr3XRN7Xsp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17241 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Marcel de Rooy from comment #11) > Thinks this needs more discussion. > Please put it on the agenda of a dev meeting. Agree with Marcel, I think we need to talk about possible next steps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 08:24:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 07:24:58 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: <bug-8628-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8628-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8628-70-O9fT8RKGSC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It might be an option. But I really wish we could fix the translation problem of plugins so that we can really have fun with them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 08:27:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 07:27:52 +0000 Subject: [Koha-bugs] [Bug 17489] Allow Koha plugins to have translations In-Reply-To: <bug-17489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17489-70-iCzMiIVF2Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17489 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this deserves more attention. Plugins are a great way to add extra functionality to Koha, but by being non-translatable we invite forking instead of sharing and improving one version of the plugin together. I think a translation system is at this point much needed to move them further. I think this should be seen as a bug in the current plugin implementation even. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 09:52:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 08:52:43 +0000 Subject: [Koha-bugs] [Bug 5788] Move ReservesMaxPickupDelay system preference to the Circulation Matrix. In-Reply-To: <bug-5788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5788-70-ybCq1hHnQS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 09:54:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 08:54:27 +0000 Subject: [Koha-bugs] [Bug 20159] New: Acq: Allow to change discount on receive Message-ID: <bug-20159-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20159 Bug ID: 20159 Summary: Acq: Allow to change discount on receive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if you could change the discount rate similar to the how you can change the tax rate on receive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:29:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:29:57 +0000 Subject: [Koha-bugs] [Bug 20160] New: Sort translated languages by code Message-ID: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 Bug ID: 20160 Summary: Sort translated languages by code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org The language tabs in Change notices -page are in random order, and will rearrange at every page reload. This is quite irritating. Make getTranslatedLanguages return the languages always in the same order, sorted by the language code. This is better than returning them in a random one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:30:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:30:32 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18595-70-HVL9mOYf6W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #58 from Alex Arnaud <alex.arnaud at biblibre.com> --- Starting QA now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:30:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:30:42 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18595-70-psDyMma44U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:31:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:31:01 +0000 Subject: [Koha-bugs] [Bug 20160] Sort translated languages by code In-Reply-To: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20160-70-j9iwb2mL40@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71333&action=edit Bug 20160: Sort translated languages by code The language tabs in Change notices -page are in random order, and will rearrange at every page reload. This is quite irritating. Make getTranslatedLanguages return the languages always in the same order, sorted by the language code. This is better than returning them in a random one. Test plan: 1) Enable TranslateNotices 2) Install multiple languages 3) Go to Home -> Tools -> Notices & slips 4) Edit any notice 5) Reload the page multiple times. The language tabs will rearrange at random 6) Apply patch 7) Repeat 1-5. The language tabs should now always be in the same order, sorted by the language code. Do the same test to Home -> Tools -> News -> Add News item (Check the "Display location" dropdown) Check Home -> Patrons -> Add patron (the "Preferred language for notices" dropdown) Check Home -> Administration -> System preferences -> i18n/l10n (Note the order of languages listed for "language" and "opaclanguages") Check Home -> Administration -> System preferences -> Local use (Create a new preference with variable type Languages, check the language pref listed in the table) Check Home -> Administration -> Item types -> Add item type (After the Description-field, there's "Translate into other languages", click on that. In the pop-up that opens, check the language drop-down) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:30:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:30:43 +0000 Subject: [Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account In-Reply-To: <bug-19204-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19204-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19204-70-1AgheKDYOn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:46:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:46:28 +0000 Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users In-Reply-To: <bug-2093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2093-70-DtTuqeK8JW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #24 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- new feature not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:46:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:46:29 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-AdF8VtF1W0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Bug 20068 depends on bug 2093, which changed state. Bug 2093 Summary: Add OPAC dashboard for logged-in users https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:47:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:47:59 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-O3E1xiNgoy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Bug 2093 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:50:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:50:43 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18477-70-a0JVDPlSFD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #21 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:52:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:52:37 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19985-70-ySH9eCWpD1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:55:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:55:09 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19932-70-6E1yxaPMWF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:55:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:55:12 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19932-70-ln4b9oJao6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70713|0 |1 is obsolete| | Attachment #71284|0 |1 is obsolete| | --- Comment #5 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71334&action=edit [SIGNED-OFF] Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:55:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:55:15 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19932-70-GrMdJdbvZ1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 --- Comment #6 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71335&action=edit [SIGNED-OFF] Bug 19932: (Follow-up) Add fixed footer to cataloging Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 10:56:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 09:56:53 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-a2xUwe0tWI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 11:10:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 10:10:43 +0000 Subject: [Koha-bugs] [Bug 20161] New: Show same information for format, material type etc. on the detail page as in the result list Message-ID: <bug-20161-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20161 Bug ID: 20161 Summary: Show same information for format, material type etc. on the detail page as in the result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org A lot of libraries ask, why there is less information about the material type, format and literary format shown on the detail page than in the result list. I suggest to match both displays and make it possible to hide with CSS as you can already do on the result list (using the same classes). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 11:11:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 10:11:45 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18595-70-dfJSeklF9s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #59 from Alex Arnaud <alex.arnaud at biblibre.com> --- Hello Lari, Koha::Patron::Message::Preferences package is missing Koha::Patron::set_default_messaging_preferences method is missing You use Koha::Patron::Message::Attributes but only in unit tests. And package is missing. Also, don't forget to provide unit tests for all new subroutine created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 12:12:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 11:12:48 +0000 Subject: [Koha-bugs] [Bug 7474] Error handling for 100$a incorrect value In-Reply-To: <bug-7474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7474-70-W2gIUC6sOo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7474 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|adrien.saurat at biblibre.com |koha-bugs at lists.koha-commun | |ity.org CC| |victor.grousset at biblibre.co | |m Status|ASSIGNED |NEW --- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Adrien doesn't work anymore at BibLibre. Unassigning this bug to give it more visibility. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 12:16:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 11:16:30 +0000 Subject: [Koha-bugs] [Bug 7662] Choosing if a new branch will have transfer limits or not In-Reply-To: <bug-7662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7662-70-PhaoF92MwC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7662 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|adrien.saurat at biblibre.com |koha-bugs at lists.koha-commun | |ity.org CC| |victor.grousset at biblibre.co | |m --- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Adrien doesn't work anymore at BibLibre. Unassigning this bug to give it more visibility. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 12:16:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 11:16:40 +0000 Subject: [Koha-bugs] [Bug 7774] Transfer limits: describing check/uncheck all actions In-Reply-To: <bug-7774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7774-70-ZdTAWcTCpE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7774 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|adrien.saurat at biblibre.com |koha-bugs at lists.koha-commun | |ity.org CC| |victor.grousset at biblibre.co | |m --- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Adrien doesn't work anymore at BibLibre. Unassigning this bug to give it more visibility. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 12:23:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 11:23:32 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-FoKz6zvL4D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m Assignee|baptiste.wojtkowski at biblibr |alex.arnaud at biblibre.com |e.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 12:41:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 11:41:56 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: <bug-12812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12812-70-qeZL92fuE5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 12:41:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 11:41:59 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: <bug-12812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12812-70-rKexjpc3jb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71336&action=edit Bug 12812 - Longoverdue.pl --mark-returned doesn't return items The longoverdue.pl option --mark-returned doesn't work unless the --charge option is used as well. Test Plan: 1) Run long overdue with --mark-returned and not --charge, note your items are marked lost but not returned 2) Apply this patch 3) Repeat step 1, the items should now get returned! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 13:47:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 12:47:39 +0000 Subject: [Koha-bugs] [Bug 20162] New: Format descriptions not properly formatted in XSLT result list Message-ID: <bug-20162-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20162 Bug ID: 20162 Summary: Format descriptions not properly formatted in XSLT result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In some cases Koha displays in the result list something like: Format: print available online print and available online are different things generated from different information in the MARC record. There shoudl be some kind of punctuation in between. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:28:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:28:11 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: <bug-12812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12812-70-4t2kBXGm0T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:29:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:29:49 +0000 Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha) In-Reply-To: <bug-18618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18618-70-ps9I9maIPl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m Assignee|baptiste.wojtkowski at biblibr |koha-bugs at lists.koha-commun |e.com |ity.org --- Comment #11 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug it still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:31:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:31:33 +0000 Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12310-70-3LUuTnJBq6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m Assignee|baptiste.wojtkowski at biblibr |koha-bugs at lists.koha-commun |e.com |ity.org --- Comment #34 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:32:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:32:05 +0000 Subject: [Koha-bugs] [Bug 18922] Mana - Share review In-Reply-To: <bug-18922-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18922-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18922-70-Y0ptgS8tde@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|baptiste.wojtkowski at biblibr |koha-bugs at lists.koha-commun |e.com |ity.org CC| |victor.grousset at biblibre.co | |m --- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:33:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:33:50 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: <bug-18055-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18055-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18055-70-lqzQ1XGW3o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m Assignee|baptiste.wojtkowski at biblibr |chris at bigballofwax.co.nz |e.com | --- Comment #37 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:37:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:37:12 +0000 Subject: [Koha-bugs] [Bug 15408] Timestamp on funds not updated when you duplicate a budget In-Reply-To: <bug-15408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15408-70-t0g7r9WQNm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m Assignee|baptiste.wojtkowski at biblibr |koha-bugs at lists.koha-commun |e.com |ity.org --- Comment #19 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:37:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:37:38 +0000 Subject: [Koha-bugs] [Bug 18874] Add unique constraint to repeatable_holidays and special_holidays In-Reply-To: <bug-18874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18874-70-D5djcpXttk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m Assignee|baptiste.wojtkowski at biblibr |koha-bugs at lists.koha-commun |e.com |ity.org --- Comment #7 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:37:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:37:54 +0000 Subject: [Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule In-Reply-To: <bug-18125-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18125-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18125-70-RP1Cl3V212@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m Assignee|baptiste.wojtkowski at biblibr |koha-bugs at lists.koha-commun |e.com |ity.org --- Comment #18 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:39:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:39:30 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: <bug-10726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10726-70-76i5YgxSVN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m Assignee|sonia.lemaire at biblibre.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #13 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Sonia doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:40:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:40:02 +0000 Subject: [Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t In-Reply-To: <bug-12605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12605-70-IxtUCdbJBN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|yohann.dufour at biblibre.com |chris at bigballofwax.co.nz CC| |victor.grousset at biblibre.co | |m --- Comment #5 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Yohann doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:40:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:40:02 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-Bq58sfQOns@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #48 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 71337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71337&action=edit Bug 18336: Shift *TEXT columns size Because of the 3-byte vs. 4-byte char size change in utf8mb4, altering a column's encoding from utf8 into utf8mb4 results in this changes: TEXT => MEDIUMTEXT MEDIUMTEXT => LONGTEXT The column size in the rows (the text itself goes to a separate object storage) shifts by 1 byte, because all chars are shifted in bytes size too, so there needs to be room for the byte-count in the column. This is a debatable change, but the path needs to be included along with the rest of the patchset for consistency. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:40:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:40:19 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-GWi3lGrio6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:43:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:43:20 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-0nj6LDtrQl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:43:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:43:24 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-6GFZ4yGIy4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69343|0 |1 is obsolete| | Attachment #70948|0 |1 is obsolete| | Attachment #70949|0 |1 is obsolete| | Attachment #70950|0 |1 is obsolete| | Attachment #70951|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71338&action=edit Bug 14769: Put ControlledIndicators to work This patch does: [1] Adds Koha::Authority->controlled_indicators (with a test). [2] Adds a call to controlled_indicators in AuthoritiesMarc::merge. Unit test Merge.t is extended too. [3] Simplifies the code in authorities/blinddetail-biblio-search.pl by calling controlled_indicators. Test plan: [1] Run t/db_dependent/Koha/Authorities.t [2] Run t/db_dependent/Authority/Merge.t [3] Steps 3 to 7 for MARC21: Create a PERSO_NAME authority with 008/11=r and ind1=3 [4] Edit a biblio and add a 600 linked to the new authority. [5] Verify that the biblio has ind1==3 and ind2==7 and $2==aat. (If $2 is not visible, check the metadata in biblio_metadata.) [6] Edit the PERSO_NAME authority and change 008/11 to '|' (bar). [7] Verify that merge updated your biblio record: $ind2==4 and $2 gone. [8] UNIMARC: Follow the pattern from steps 3 to 7. Create authority, link it in a biblio, check indicators (they should be copied both). Edit authority, change indicators and verify the merge results in the biblio record. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Tested PERSO_NAME and UNIF_TITLE. For UNIF_TITLE the second authority indicator is copied to ind1 or ind2, depending on the biblio tag involved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:43:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:43:44 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-1Yr4IYJSn8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71338|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71339&action=edit Bug 14769: Introduce Koha::Authority::ControlledIndicators This module reads its settings from pref AuthorityControlledIndicators. The get method allows you to retrieve indicator values for specific biblio fields. Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:43:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:43:48 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-6RfzHMuG6J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71340&action=edit Bug 14769: Biblio indicators based on authority's thesaurus code Original patch from Janusz Kaczmarek on November 24, 2017. Amended by Marcel de Rooy on February 6, 2018. Code moved from AuthoritiesMarc.pm to ControlledIndicators.pm. Special attention has been paid to the proper application of 008/11 while controlling 6XX in MARC 21, specially if 008/11 =~ /[rsz]/ (and if it is 'z' and 040 $f is defined). Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> The construction $thes_mapping{ $code } // $code // '4' will still get some attention on a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:43:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:43:53 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-5iEhd3TzXM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71341&action=edit Bug 14769: Add tests for _thesaurus_info in ControlledIndicators.t Apart from adding tests for this sub, we make the following change too and support it with a test. The fallback to $code in the construction $thes_mapping{ $code } // $code // '4' is removed by this patch. When $code is not in $thes_mapping, we cannot assume that it is a valid code for a biblio indicator. In this case it is more safe to mark it as 4 (Source not specified). Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:43:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:43:57 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-F0Z6XuoopN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71342&action=edit Bug 14769: Add preference AuthorityControlledIndicators Including: [1] Atomic update to add pref for existing installs [2] Add new pref to sysprefs.sql for new installs [3] Add description to authorities preference file. Test plan: [1] Run new install or upgrade to add pref. [2] Check value of pref via System preferences in staff interface. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:44:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:44:02 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-gO8POabPep@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71343&action=edit Bug 14769: Put ControlledIndicators to work This patch does: [1] Adds Koha::Authority->controlled_indicators (with a test). [2] Adds a call to controlled_indicators in AuthoritiesMarc::merge. Unit test Merge.t is extended too. [3] Simplifies the code in authorities/blinddetail-biblio-search.pl by calling controlled_indicators. Test plan: [1] Run t/db_dependent/Koha/Authorities.t [2] Run t/db_dependent/Authority/Merge.t [3] Steps 3 to 7 for MARC21: Create a PERSO_NAME authority with 008/11=r and ind1=3 [4] Edit a biblio and add a 600 linked to the new authority. [5] Verify that the biblio has ind1==3 and ind2==7 and $2==aat. (If $2 is not visible, check the metadata in biblio_metadata.) [6] Edit the PERSO_NAME authority and change 008/11 to '|' (bar). [7] Verify that merge updated your biblio record: $ind2==4 and $2 gone. [8] UNIMARC: Follow the pattern from steps 3 to 7. Create authority, link it in a biblio, check indicators (they should be copied both). Edit authority, change indicators and verify the merge results in the biblio record. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Tested PERSO_NAME and UNIF_TITLE. For UNIF_TITLE the second authority indicator is copied to ind1 or ind2, depending on the biblio tag involved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:49:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:49:49 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-lP3omP7hff@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Ready for signoff please. Further refinements for the default preference value for the UNIMARC side should go to another report. (This should do it in most cases.) Another observation for a new report: # 240 is not connected to UNIF_TITLE in installer script # 751 is not connected to GEOGR_NAME in installer script Hoping for feedback.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:53:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:53:08 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: <bug-17908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17908-70-8RyP7cdNI9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- One of the last steps in this omnibus is bug 14769. Ready for some attention from your part :) Be welcome! About biblio indicators controlled by authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:53:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:53:52 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: <bug-17908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17908-70-JisFvd8dwu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:56:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:56:52 +0000 Subject: [Koha-bugs] [Bug 20030] Authority merge does not always fill $2 correctly In-Reply-To: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20030-70-15JtYSLYgy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20030 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 14:56:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 13:56:39 +0000 Subject: [Koha-bugs] [Bug 20030] Authority merge does not always fill $2 correctly In-Reply-To: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20030-70-qUbqMsgbMz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20030 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Finally, this got fixed on bug 14769 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:10:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:10:10 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-hCHk6miUIe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58746|0 |1 is obsolete| | --- Comment #85 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71345&action=edit Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi <paola.rossi at cineca.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:10:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:10:05 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-SaDpjCV5O0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58745|0 |1 is obsolete| | --- Comment #84 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71344&action=edit Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on "Order" link in column "More" (previously "View record") 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on "Receive" link 6/ Your name should appear in front of "Created by" label, to the right of the page. Patch updated with use of atomic update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:10:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:10:15 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-95bydIkNpD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58747|0 |1 is obsolete| | --- Comment #86 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71346&action=edit Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi <paola.rossi at cineca.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:10:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:10:19 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-LwAaza4W5P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58748|0 |1 is obsolete| | --- Comment #87 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71347&action=edit Bug 12395: Make received orders table consistent with pending orders table (links of More column) Also change "Created by" with "Ordered by" in receive page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:10:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:10:24 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-1txABvgDU9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58749|0 |1 is obsolete| | --- Comment #88 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71348&action=edit Bug 12395: QA follow-up - Add class/id to body tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:10:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:10:29 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-ih6QAjwrhg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58750|0 |1 is obsolete| | --- Comment #89 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71349&action=edit Bug 12395: Use standard <fieldset> + <ol> markup for showorder.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:10:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:10:48 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-6jv1e3oxKU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #90 from Julian Maurice <julian.maurice at biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:17:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:17:14 +0000 Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19582-70-hQ5EYz4vdw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #7 from Alex Arnaud <alex.arnaud at biblibre.com> --- Hello Nick, I have nothing to say from a QA point of view about the current changes in the code but i'm wondering if we should not do the same work for autocomplete feature (it still use C4::AuthoritiesMarc::SearchAuthorities) or do it in another BZ. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:35:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:35:15 +0000 Subject: [Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat In-Reply-To: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19582-70-7BJx7SJ5bX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #7) > Hello Nick, > > I have nothing to say from a QA point of view about the current changes in > the code but i'm wondering if we should not do the same work for > autocomplete feature (it still use C4::AuthoritiesMarc::SearchAuthorities) > or do it in another BZ. Yes of course, every occurrence of SearchAuthorities must be replaced. Please open a new bug report and put on QA stamp on this one ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:36:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:36:28 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-RPs1QxHaQ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:36:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:36:31 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-ZNn8yYhu61@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71269|0 |1 is obsolete| | --- Comment #7 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71350&action=edit Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:46:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:46:35 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: <bug-17885-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17885-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17885-70-QE7RD9PsGs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |alex.arnaud at biblibre.com CC| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 15:49:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 14:49:07 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: <bug-17885-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17885-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17885-70-gs0hvjEkfh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 --- Comment #11 from Alex Arnaud <alex.arnaud at biblibre.com> --- Hello Oli, Could you please add unit tests for sub reset_elasticsearch_mappings? At least to check that it deletes mappings as it is what you change in the behavior. But more tests are welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 16:05:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 15:05:51 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: <bug-19908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19908-70-UrfpuakTAh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com Status|Needs Signoff |Failed QA --- Comment #5 from Claire Gravely <claire_gravely at hotmail.com> --- Hi, I got as far as applying the first patch to test. BorrowerMandatoryField is empty I was unable to save the patron record without entering a username. I get the following message: The following fields are wrong. Please fix them. - Username/password already exists. It will not let me save until I have entered a username for the patron. Previous behaviour was that one was automatically generated if left blank. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 16:24:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 15:24:47 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-GCymeX7RVu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71339|0 |1 is obsolete| | --- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71351&action=edit Bug 14769: Introduce Koha::Authority::ControlledIndicators This module reads its settings from pref AuthorityControlledIndicators. The get method allows you to retrieve indicator values for specific biblio fields. Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 16:24:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 15:24:51 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-NmmR5exzwJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71340|0 |1 is obsolete| | --- Comment #29 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71352&action=edit Bug 14769: Biblio indicators based on authority's thesaurus code Original patch from Janusz Kaczmarek on November 24, 2017. Amended by Marcel de Rooy on February 6, 2018. Code moved from AuthoritiesMarc.pm to ControlledIndicators.pm. Special attention has been paid to the proper application of 008/11 while controlling 6XX in MARC 21, specially if 008/11 =~ /[rsz]/ (and if it is 'z' and 040 $f is defined). Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> The construction $thes_mapping{ $code } // $code // '4' will still get some attention on a follow-up. Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 16:24:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 15:24:55 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-hmmFpUiioO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71341|0 |1 is obsolete| | --- Comment #30 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71353&action=edit Bug 14769: Add tests for _thesaurus_info in ControlledIndicators.t Apart from adding tests for this sub, we make the following change too and support it with a test. The fallback to $code in the construction $thes_mapping{ $code } // $code // '4' is removed by this patch. When $code is not in $thes_mapping, we cannot assume that it is a valid code for a biblio indicator. In this case it is more safe to mark it as 4 (Source not specified). Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 16:24:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 15:24:59 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-0sU1IVIuQW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71342|0 |1 is obsolete| | --- Comment #31 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71354&action=edit Bug 14769: Add preference AuthorityControlledIndicators Including: [1] Atomic update to add pref for existing installs [2] Add new pref to sysprefs.sql for new installs [3] Add description to authorities preference file. Test plan: [1] Run new install or upgrade to add pref. [2] Check value of pref via System preferences in staff interface. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 16:25:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 15:25:03 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-dLVRgAvj7F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71343|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71355&action=edit Bug 14769: Put ControlledIndicators to work This patch does: [1] Adds Koha::Authority->controlled_indicators (with a test). [2] Adds a call to controlled_indicators in AuthoritiesMarc::merge. Unit test Merge.t is extended too. [3] Simplifies the code in authorities/blinddetail-biblio-search.pl by calling controlled_indicators. Test plan: [1] Run t/db_dependent/Koha/Authorities.t [2] Run t/db_dependent/Authority/Merge.t [3] Steps 3 to 7 for MARC21: Create a PERSO_NAME authority with 008/11=r and ind1=3 [4] Edit a biblio and add a 600 linked to the new authority. [5] Verify that the biblio has ind1==3 and ind2==7 and $2==aat. (If $2 is not visible, check the metadata in biblio_metadata.) [6] Edit the PERSO_NAME authority and change 008/11 to '|' (bar). [7] Verify that merge updated your biblio record: $ind2==4 and $2 gone. [8] UNIMARC: Follow the pattern from steps 3 to 7. Create authority, link it in a biblio, check indicators (they should be copied both). Edit authority, change indicators and verify the merge results in the biblio record. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Tested PERSO_NAME and UNIF_TITLE. For UNIF_TITLE the second authority indicator is copied to ind1 or ind2, depending on the biblio tag involved. Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 16:26:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 15:26:22 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-MATXZgBnnH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #33 from Julian Maurice <julian.maurice at biblibre.com> --- Patches work as expected. I signed off the patches but I think another sign-off from a MARC21 expert would be great. A few comments on the code: - I think that the subroutine controlled_indicators doesn't belong in Koha::Authority. The FIXME added in C4::AuthoritiesMarc strengthens that opinion - In Koha::Authority::ControlledIndicators, there is a package variable $cached_indicators. Maybe this module should use Koha::Cache instead ? Also, I'm not sure if this is a problem, but it seems that there is no way to tell Koha to change only one of the two indicators. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 16:39:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 15:39:17 +0000 Subject: [Koha-bugs] [Bug 20163] New: Position of NoLoginInstructions text is inconsistent Message-ID: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Bug ID: 20163 Summary: Position of NoLoginInstructions text is inconsistent Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: margaret at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 71356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71356&action=edit Side By Side NoLoginInstructions Text Comparison The position of NoLoginInstructions text is inconsistent between the "log into your account" popup and the "log into your account" main login form. In this case directional language is used in the NoLoginInstructions to have patrons look "above" for the Register here link. However in the popup the position of the two texts are flipped, so that the Register here link appears bellow the NoLoginInstructions. See Screenshot, "Side By Side NoLoginInstructions Text Comparison" for this illustration. To replicate: 1) Enable PatronSelfRegistration system preference. 2) Enable the OpacResetPassword system preference. 3) Input directional language, ie. "look [above or bellow] for the Register here link, into the NoLoginInstructions syspref. 4) Open OPAC and look at the "log into your account" popup and the "log into your account" main login form. Your instructions to look above or bellow will be wrong in one one of these login windows. Can the order in which the editable (ie. NoLoginInstructions) and non-editable (ie. Register here and Forgot Password) text that appears in the "log into your account" main login form and popup be made consistent? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 16:45:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 15:45:14 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: <bug-19908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19908-70-bDxW9av4dV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #6 from Claire Gravely <claire_gravely at hotmail.com> --- (In reply to Claire Gravely from comment #5) > Hi, > > I got as far as applying the first patch to test. > BorrowerMandatoryField is empty > > I was unable to save the patron record without entering a username. I get > the following message: > > The following fields are wrong. Please fix them. > - Username/password already exists. > > It will not let me save until I have entered a username for the patron. > Previous behaviour was that one was automatically generated if left blank. Sorry, should add this was for patron categories with type Org. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 16:59:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 15:59:50 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18421-70-O1KxKPA6G5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> --- Because of the variables involved in the deployment of Coce -- the koha version, the nodejs version, whether passenger is used or not for clustering, the communication with the in-memory cache behind, the webserver that might be used to proxy to the app, etc. -- it can get finicky real quick. Without detailed information about your particular setup, I would recommend opening a new bug ticket, since you feel confident about the reproducibility of this issue on your end. I'd be more than happy to look over your setup :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 17:06:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 16:06:09 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18421-70-GStNDPL4RZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #6 from Agnes Rivers-Moore <arm at hanover.ca> --- I appreciate the response, many thanks. We are planning an upgrade in the next few months - perhaps the behaviour will change after that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 17:09:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 16:09:18 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios - OPAC In-Reply-To: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-LVE9HTEW3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 17:14:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 16:14:26 +0000 Subject: [Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order In-Reply-To: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19947-70-w0m9Dq2Ocu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Dependency is Passed QA now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 17:22:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 16:22:55 +0000 Subject: [Koha-bugs] [Bug 20164] New: Suspend Waiting Hold in OPAC loophole Message-ID: <bug-20164-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20164 Bug ID: 20164 Summary: Suspend Waiting Hold in OPAC loophole Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: margaret at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There is a loophole where after a hold has arrived and is placed on the hold shelf (in Waiting status) patrons can still suspend the hold via the OPAC. After a hold moves to Waiting status the suspend option is no longer available from the Koha Staff Patron Holds window. To Replicate: 1) create a hold using either the OPAC or Staff Client 2) look at the OPAC and Staff Client and see the suspend button is visible 3) checkin an item to fill that hold via the staff client 4) look at the OPAC and Staff Client and see the suspend button is visible in only the OPAC. Clicking on the button will suspend the hold even though it is arrived and Waiting for pickup. This is related to Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message. Likewise there is no staff side messaging to indicate that a patron has suspended a Waiting Hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 17:23:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 16:23:18 +0000 Subject: [Koha-bugs] [Bug 20164] Suspend Waiting Hold in OPAC loophole In-Reply-To: <bug-20164-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20164-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20164-70-bwI6XvHmAW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20164 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18856 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 17:23:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 16:23:18 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-XOtzrfzDvR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20164 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 18:21:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 17:21:12 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19946-70-9DdLfitYaP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Did not we agree that the action buttons should be grouped only if there are more than 2? I also see this: https://screenshots.firefox.com/jDHvackVDkBUUjlC/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 18:28:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 17:28:31 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19946-70-QTJ9VQNpE4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #4) > Did not we agree that the action buttons should be grouped only if there are > more than 2? It is displayed when a row is clicked, so it is not valid here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 18:35:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 17:35:54 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: <bug-14962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14962-70-BypLLcD9PB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 18:44:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 17:44:08 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-UWCO6eqzEo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Before: https://screenshots.firefox.com/aiunxdJJDVm8KUyk/pro.kohadev.org After: https://screenshots.firefox.com/hNHmyPk4g8VNpj0C/pro.kohadev.org Why is it better? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 18:47:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 17:47:32 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-xOOV2SxF6O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Same for the brief view: Before: https://screenshots.firefox.com/62t0wbESsXjcuKaO/pro.kohadev.org After: https://screenshots.firefox.com/oAnGeNsYW9s3qvTv/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 18:47:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 17:47:53 +0000 Subject: [Koha-bugs] [Bug 16703] Home > Reports > Circulation statistics showing no circulation In-Reply-To: <bug-16703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16703-70-ulmf4MSSyc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16703 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|enhancement |normal Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 18:49:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 17:49:37 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-8RMLAjIUFy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #27) > I do not understand why the .css is no longer part of the codebase. Do not > you think RM should generate it? ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 19:01:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 18:01:37 +0000 Subject: [Koha-bugs] [Bug 19452] The -truncate option in borrowers-force-messaging-defaults.pl should not remove category preferences In-Reply-To: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19452-70-x5Boa0kOMJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr, | |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Fr?d?ric, as you are the author of this script can you confirm this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 19:04:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 18:04:30 +0000 Subject: [Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present In-Reply-To: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19451-70-lDbCjqEv90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- + if( $no_overwrite ) { + $sql .= " AND (SELECT COUNT(*) FROM borrower_message_preferences mp WHERE mp.borrowernumber=bo.borrowernumber) = 0" + } This is weird, I think you want to add a join here instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 19:08:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 18:08:50 +0000 Subject: [Koha-bugs] [Bug 19801] Display messages on user details page as well as on check out page In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19801-70-FcJTqflAYZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I will accept the use of onclick here because it mimics what is done in another template, but keep in mind it is not allowed usually. Both patches will be squashed for readability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 19:12:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 18:12:51 +0000 Subject: [Koha-bugs] [Bug 15191] Serials display improvements In-Reply-To: <bug-15191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15191-70-tHeVdMLEnJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15191 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 19:26:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 18:26:35 +0000 Subject: [Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent In-Reply-To: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20163-70-12GWRoqfVw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 20:00:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 19:00:45 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-XjlhYXk3oU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #98 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 1. Must misc4dev deal with apache *-git.conf files? If so, how? I think we will have to ask devs to add these 2 lines to /etc/koha/apache-shared-*-git.conf 2. <Joubu> 20 RewriteRule ^(.*)_(.*).js$ $1.js [N,L]. <Joubu> [N,L]? <tcohen> it looks like L shouldn't be there? or N? <tcohen> L = Last <tcohen> N = Next <tcohen> using N is very tricky <tcohen> and need to have a perfect understanding of how all defined rules make sense together Does someone know? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 20:01:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 19:01:03 +0000 Subject: [Koha-bugs] [Bug 19637] jsPrintSetup not supported in Firefox Quantum In-Reply-To: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19637-70-3Fs5M4FIlP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19637 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 20:18:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 19:18:59 +0000 Subject: [Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent In-Reply-To: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20163-70-4i8n2wJBa3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71357&action=edit Bug 20163: Position of NoLoginInstructions text is inconsistent This patch modifies the markup for two login forms, making the markup more consistent between them. The order of NoLoginInstructions, "Forgot your password?" and "Don't have an account?" should now be the same. This patch also updates some classes in each login form to allow for more consistent custom styling. A couple of capitalization corrections are included. To test, enable the PatronSelfRegistration and OpacResetPassword preferences. Put some text in the NoLoginInstructions preference. View the login form as associated links on the OPAC main page. Compare to the login form which appears in a modal window when you click the login link at the top of the page. The two areas should look consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 20:18:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 19:18:57 +0000 Subject: [Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent In-Reply-To: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20163-70-xiwVtmmmRX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 20:25:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 19:25:43 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-5U5R6k5Ga8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #33) > Created attachment 71272 [details] [review] > Bug 19928: Acquisitions: show the precise kind of CSV on export buttons The delimiter for customized CSV profiles (tools/csv-profiles.pl) is configurable so it does not make sense to use the sysprefs to adapt the text of these buttons (at least for basket export). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 20:35:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 19:35:46 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20120-70-0zq07PLxKP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 1. How bad is that? 2. If it should lead to a credit, what would be the procedure? write off then credit, so 2 lines? 3. in pay.pl, maybe we should refuse instead of assuming it is what the user wanted. 4. Should use Price TT plugin instead of format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 20:37:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 19:37:09 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20120-70-QYR59l2QYP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71358&action=edit Bug 20120: Use the Price TT plugin to format amounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 20:44:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 19:44:12 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18958-70-pimbdW3HuS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hum, I am going to postpone this change for my mental health (holds...) But at first glance there is something wrong: the diffbranch flag will never be set and we will have a lot of useless code in the template. Are you sure this change is correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 20:51:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 19:51:40 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-TtyidZxJ5T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sounds like something is going wrong before that point and we are going to hide the problem. Should not we add a debug message to the logs with some useful information? Marcel, are you ok to push it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 21:02:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 20:02:07 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20120-70-bguMqZT5A1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I don't think we should imply it's a credit, at least not silently. I think the change will avoid errors for now and is a bug fix. I'd treat an option to create a credit as a separate enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 21:02:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 20:02:38 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20120-70-EWQhTgkKIc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, thinking about it: when you writeoff, you don't get any money from the customer, so even more reason NOT to assume a credit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:15:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:15:58 +0000 Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0 In-Reply-To: <bug-20131-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20131-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20131-70-dgGDv2u332@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:33:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:33:22 +0000 Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff In-Reply-To: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19524-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19524-70-UMUy7E7VVi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:33:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:33:42 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-G1dpketiMN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:35:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:35:00 +0000 Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber In-Reply-To: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19837-70-ZYhDZjhnfb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:36:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:36:13 +0000 Subject: [Koha-bugs] [Bug 19459] New suggestions sent via email In-Reply-To: <bug-19459-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19459-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19459-70-XXsmpbnH1q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19459 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:36:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:36:54 +0000 Subject: [Koha-bugs] [Bug 19458] Self-check module highlighting In-Reply-To: <bug-19458-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19458-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19458-70-GRbT51plax@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19458 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:43:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:43:22 +0000 Subject: [Koha-bugs] [Bug 18816] Make CataloguingLog work in production by preventing circulation from spamming the log In-Reply-To: <bug-18816-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18816-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18816-70-sVdtSKpXU3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18816 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:44:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:44:26 +0000 Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines In-Reply-To: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19066-70-75VhZRn1cu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:46:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:46:13 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-TonzGZIa12@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:48:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:48:32 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18958-70-zdAxl3MbMJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:55:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:55:36 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-xKtvUeL4Bc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 8 22:56:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 21:56:47 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15986-70-AVoMMspiVv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 00:22:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Feb 2018 23:22:34 +0000 Subject: [Koha-bugs] [Bug 19676] Debian 9 vs. Plack vs. /tmp -- attention to PrivateTmp for apache2 In-Reply-To: <bug-19676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19676-70-8bTQq0TcBq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19676 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea <liz at catalyst.net.nz> --- For Debian Stretch (9), with plack enabled, you will need to do the following for the noted functions to work (as root or sudo, of course): #> vi /etc/system/multi-user.target.wants/apache2.service Change PrivateTmp:true to PrivateTmp:false #> systemctl daemon-reload #> systemctl restart apache2 #> systemctl show apache | grep PrivateTmp Result should be: PrivateTmp=no Ideal solution is to deal with the fact that when we fork the process, we can't read the old process's tempfiles, but this does solve the immediate problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 01:27:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 00:27:51 +0000 Subject: [Koha-bugs] [Bug 19676] Debian 9 vs. Plack vs. /tmp -- attention to PrivateTmp for apache2 In-Reply-To: <bug-19676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19676-70-pWBsfzv40i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19676 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 06:58:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 05:58:51 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: <bug-18055-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18055-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18055-70-46wGe6lS5G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #38 from Mason James <mtj at kohaaloha.com> --- (In reply to Jonathan Druart from comment #30) > (In reply to Jonathan Druart from comment #29) > > Solved! > I upgraded Test::Simple from 1.001014 to 1.302075 and the tests now pass! Hi Jonathan Mirko has packaged libtest-simple-perl in BZ-18993 (resolved) ..therefore this bug can be switched back to PASSED-QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 07:07:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 06:07:18 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18979-70-GmmBq0iJyl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 --- Comment #15 from Mason James <mtj at kohaaloha.com> --- (In reply to Mason James from comment #14) > > hiya, i'd vote for option 1/ as quick fix, and then a separate bug for a > > leisurely switch to Test2::Suite > > oops, i meant option 2, then a follow-up for option 1 :) Marcel, lets go for option 2 here... i'll obsolete the newer Test2::Suite patch, for now ..and set the status back to SIGNED-OFF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 07:08:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 06:08:18 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18979-70-Lr2oLnhCFe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69150|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 07:08:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 06:08:30 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18979-70-aTKgzGZOxI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 07:33:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 06:33:28 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-VrLc9yOxMl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #14) > Sounds like something is going wrong before that point and we are going to > hide the problem. > Should not we add a debug message to the logs with some useful information? > > Marcel, are you ok to push it? Will have another look today -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 07:54:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 06:54:35 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-i5DbcxV33K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, I think now I understand better how this works: DefaultPatronSearchFields currently defines what is used for the "standard" search option but doesn't change the pull down. I think the description of the pref needs to be improved to be more clear about its use: Comma separated list defining the default fields to be used during a patron search Should be currently mroe something like: Comma separated list defining the default fields to be used during a spatron search using the 'standard' search option. With the new behaviour then: Comma separated list defining the default fields to be used during a spatron search using the 'standard' search option. If left empty, Koha will use: ... If you add additional fields not in the default, they will also show as separate search options in the drop down. This about right? Nick, would it make sense to you to adapt the pref description a bit? I think my problem mostly was not understanding how this is supposed to work and others might have the same problem :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 07:55:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 06:55:38 +0000 Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha) In-Reply-To: <bug-18618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18618-70-u0gMokkFfd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |BLOCKED --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- BLOCKED by failed base patch bug 17047 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:02:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:02:08 +0000 Subject: [Koha-bugs] [Bug 20165] New: Capitalization: Street Address should be Street address in patron search options Message-ID: <bug-20165-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20165 Bug ID: 20165 Summary: Capitalization: Street Address should be Street address in patron search options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The search options for patron search include "Street Address". This should be fixed to be "Street address" instead to follow our capitalization rules. To test: - Go to "Patrons" - Switch in top search to tab "Search patrons" - Click on + sign - Check "Search fields" pull down - Compare to same pull down in the filters at the right side -> top search option is spelled wrong, the one on the right is correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:14:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:14:13 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-rg1EHwgSgY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71360&action=edit Bug 15752: (follow-up) Search for patrons only if param barcode is defined Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:14:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:14:18 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-DitSApDoQ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71361&action=edit Bug 15752: (QA follow-up) Inform user that patron was automatically switched Test plan: 1) Start checking out to some patron - there should be no message about auto switching 2) read the another patrons card - note the patron is switched and there is a message about it at top of the main page content Followed test plan, patch worked as described. Passed QA test tool Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:14:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:14:09 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-WrumVNaKDM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71359&action=edit Bug 15752: Automatically switch to patron when cardnumber is read during circulation With this syspref enabled scanning a patron barcode into the item barcode field during circulation will redirect you to the patron's circulation page. This allows circulation with only a barcode scanner. Testing: - Enable the AutoSwitchPatron syspref - Navigate to a patron's check out screen - Enter a patron barcode into the "Enter item barcode" field Result - Browser should be redirected to the entered patron Signed-off-by: Joel <aloi54 at live.fr> Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:14:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:14:22 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-5e9DfSpH3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71362&action=edit Bug 15752: (QA follow-up) Remove unecessary redirect We are on circulation.pl, no need to redirect. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:14:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:14:27 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-vdMsDC6WE6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 --- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71363&action=edit Bug 15752: (QA follow-up) Remove unecessary redirect If the borrowernumber is defined in query, it starts to get information about previous borrower and the new one is taken into account fully on second page reload Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:15:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:15:19 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-ALxvnBn9hC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69994|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:15:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:15:22 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-vbZzXp0jBW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:15:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:15:16 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-aaX7zoKmK0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:15:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:15:25 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-r1zU4FaW6I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:15:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:15:29 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-grsxnu08ZE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:15:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:15:31 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-pCCHATboQ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70085|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:15:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:15:48 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned during circulation In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-JjggrKtDtK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatically switch from |Automatically switch from |circulation to new patron |circulation to new patron |when a cardnumber is |when a cardnumber is |scanned |scanned during circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:16:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:16:41 +0000 Subject: [Koha-bugs] [Bug 20166] New: Untranslatable course reserves delete prompt Message-ID: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20166 Bug ID: 20166 Summary: Untranslatable course reserves delete prompt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Having a Template Toolkit statements inside the javascript translation function _() prevents it from being picked for translation. The only example of such is the course reserve delete prompt. To see if there are other such TT statements: rgrep -E '\b_\("[^"]*\[%' koha-tmpl/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:17:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:17:46 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned during circulation In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-ktQkxd33ZH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The new system preference release notes| |AutoSwitchPatron allows to | |automatically switch to | |another patron record on | |scanning the cardnumber | |during circulation. This | |will allow to streamline | |processes at the | |circulation desk a bit | |more. Note: Use only if | |there is no overlap in your | |cardnumber and barcode | |ranges. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:17:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:17:55 +0000 Subject: [Koha-bugs] [Bug 20166] Untranslatable course reserves delete prompt In-Reply-To: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20166-70-IysKtvaCiU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20166 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71364&action=edit Bug 20166: Untranslatable course reserves delete prompt Having a Template Toolkit statements inside the javascript translation function _() prevents it from being picked for translation. The only example of such is the course reserve delete prompt. Move the TT statement outside the string. Test plan: 1) Update and install language xx-YY. Check that the msgids "Are you sure you want to delete this course? There is %s attached item." and "Are you sure you want to delete this course? There are %s attached items." do not exist in the xx-YY-staff-prog.po 2) Check the translated file intranet-tmpl/prog/fi-FI/modules/course_reserves/course-details.tt It should have two prompt texts above in English 3) Install patch 4) Update the language. Check that the msgids show up in xx-YY-staff-prog.po, translate them, and install the language. 5) Repeat 2, the prompts should now show up in the correct language. 6) Enable UsecourseReserves 7) Go to Home -> Course reserves 8) Create a new course, and add reserves to it 9) See the course details. Click on Delete course, the prompt should be correctly translated 10) Remove all but one of the reserves from the course 11) Repeat 9 To see if there are other such TT statements: rgrep -E '\b_\("[^"]*\[%' koha-tmpl/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:29:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:29:23 +0000 Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search facets In-Reply-To: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19376-70-jaiiN1UKm3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 08:29:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 07:29:08 +0000 Subject: [Koha-bugs] [Bug 19376] Add 655$a (Genre/Form) to zebra search facets In-Reply-To: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19376-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19376-70-7RQAY7tJUz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19376 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi David, this is almost there, sorry to bug you again: <index_subfields tag="655" subfields="a"> <target_index>Index-term-genre:w</target_index> <target_index>Index-term-genre:p</target_index> - <target_index>Subject:w</target_index> - <target_index>Subject:p</target_index> + <target_index>gen-for:w</target_index> + <target_index>gen-for:p</target_index> </index_subfields> These lines remove 655 from the general Subject index. Could you please keep it in the general index and only add your specific one? Otherwise I think this looks good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 09:07:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 08:07:47 +0000 Subject: [Koha-bugs] [Bug 19801] Display messages on user details page as well as on check out page In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19801-70-DfNjjFoVJj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71287|0 |1 is obsolete| | Attachment #71288|0 |1 is obsolete| | --- Comment #18 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 71365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71365&action=edit Bug 19801 - Display messages on user details page as well as on Check Out page To test: Look up a borrower, add a message (internal or opac) Click the Details tab for that borrower Messages should be displayed above the user information [is this the right place? it could go below] adding messages on this page should make them immediately available deleting messages on this page should delete them immediately and bring you back to the detail page. Basically, make sure messages work from both the Check out and detail pages and that there are no typos. Messages should work the same as they always have from the Check Out page. sponsored-by: Catalyst IT Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Marjorie Vila <marjorie.barry-vila at collecto.ca> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 09:08:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 08:08:30 +0000 Subject: [Koha-bugs] [Bug 19801] Display messages on user details page as well as on check out page In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19801-70-ObOTmHIAuU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 --- Comment #19 from Alex Arnaud <alex.arnaud at biblibre.com> --- Patches squashed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 09:50:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 08:50:44 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-OGosOS5nI4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #37 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- (In reply to Katrin Fischer from comment #31) > The only thing I am not happy about it the length of the buttons > I think Victor had similar thoughts on posting the screenshots. Actually I would be fine with these long descriptive names. (and with short names) But I don't have much experience about UX. (To have a reliable opinion if it's better than shorter but less informative names.) However I'm sure many people won't think such long names are good. Hence the screenshots to not hide the potential issue. It seems that it worked ^^" (In reply to Owen Leonard from comment #34) > I think "CSV" is commonly understood to include more than just > comma-separated values. Is it really necessary to be so specific? For > instance, an application like phpMyAdmin offers export in "CSV" format, but > it doesn't limit you to comma-separated output. +1 it's not necessary (In reply to Katrin Fischer from comment #35) > My suggestion is to keep the current descriptions then and make sure the > delimiter is used properly everywhere :) Current as in master[1][3] or current are in the current patches[2][4] of this bug? If [2] then bug 19910 must be changed as well. [3] this is consistent with Owen's comment [4] this is consistent with you switching this bug to "Passed QA" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 09:53:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 08:53:29 +0000 Subject: [Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack In-Reply-To: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16520-70-5Zp8mFOtSJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #35 from Magnus Enger <magnus at libriotech.no> --- Reading this bug, I thought I had to do thos step in order to be able to set per-OPAC variables in my Apache config: Add the following line to your plack.psgi (near the bottom, just above "mount ..."): enable "+Koha::Middleware::Plack"; But there is no such thing as Koha::Middleware::Plack, so adding the line made this error show up in the Plack error log: Error while loading /etc/koha/sites/x/plack.psgi: Can't locate Koha/Middleware/Plack.pm in @INC (you may need to install the Koha::Middleware::Plack module) (@INC contains: /usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /usr/share/perl5/Plack/Util.pm line 23, <DATA> line 309. Turns out Koha::Middleware::Plack is not needed, all you need is already in the out-of-the-box .psgi file. Not sure why. Maybe Koha::Middleware::Plack was just a typo for Koha::Middleware::SetEnv all along? http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=1e6df24d6cbf44c865805712e6a15ecc601273aa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 09:58:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 08:58:57 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-HvDQbeIzCN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 10:15:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 09:15:34 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-K4sh3hBwxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71366&action=edit Bug 14769: (Follow-up) Reduce number of preference parses In sub merge the Koha::Authority object was already created, so it was kind of silly to recreate it each time with new. In Koha::Authority, the ControlledIndicators object can be saved in the object too for reuse during its life time. Similarly, we prevent repeated lookups for the reporting tag (via authority type). Test plan: [1] Run t/db_dependent/Authority/Merge.t [2] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Limited benchmarking shows me a reduction of 11% on Merge.t and a reduction of 4% on Authorities.t when comparing with and without this last patch. The larger impact on Merge.t could be expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 10:22:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 09:22:44 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19709-70-dAayft2rdO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #6 from Claire Gravely <claire_gravely at hotmail.com> --- (In reply to Owen Leonard from comment #5) > (In reply to Claire Gravely from comment #3) > > - clicking 'add items' without entering any barcodes opens an empty frame > > My updated patch fixes this. This is now working > > > - When exporting items or a batch, the 'cancel' link in the first frame > > doesn't work > > - After exporting, the 'done' button doesn't work > > I can't reproduce these problems. Can you please try again and let me know > if it's still happening? yep. I still have these issues. These are my steps - From 'Manage' I go to 'Label Batches' - select one of the batches and click 'Export selected' - Click the Cancel link in the frame ... and nothing happens. - Clicking 'Export' on the same page takes me to the options to download the Batch. - The 'Done' button in this frame does nothing. Whether I have downloaded something or not. It can be closed using the 'Close' link in the top right corner. Both the 'Cancel' link and 'Done' button work on Master branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 10:35:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 09:35:56 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-oiilBEIAMr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Julian Maurice from comment #33) Thanks Julian! > A few comments on the code: > - I think that the subroutine controlled_indicators doesn't belong in > Koha::Authority. The FIXME added in C4::AuthoritiesMarc strengthens that > opinion I removed the FIXME and optimized it a bit in the last follow-up. I thought about where to put this code when developing, and it is somewhat harder. This translated in putting the essential code in a separate object. (Parsing the pref and applying its rules on a MARC record should imo not be in Koha::Authority.) But since the indicators really are determined by the specific values of a given authority record, I decided to add the main controlled_indicators method to Koha::Authority. > - In Koha::Authority::ControlledIndicators, there is a package variable > $cached_indicators. Maybe this module should use Koha::Cache instead ? I do not really see the advantage. We do not win time imo by saving the structure to the L2 cache. We could argue about putting it in L1 only (and check if we would gain time), but that seems not possible now. Since the internal structure is kept only during the lifetime of the object, the name could be misleading. If required, I could rename it. > Also, I'm not sure if this is a problem, but it seems that there is no way > to tell Koha to change only one of the two indicators. I am not sure if I understand this correctly. The current approach with the pref allows for great flexibility. If you say e.g. MARC21,100,ind1:auth1 you only copy the first indicator. The second indicator will be empty when creating a new field or will be taken from the biblio record when updating/merging. But if you say e.g. MARC21,830,,ind2:auth2 you only copy the second indicator. One of the unit tests contains an example where indicators are swapped. So for UNIMARC you can also make all changes you want by adding specific rules. In comment27 I proposed to open a new report if we need further refinements for UNIMARC specifically. Hope this helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 11:29:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 10:29:49 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-vUuWyRyc27@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #14) > Sounds like something is going wrong before that point and we are going to > hide the problem. > Should not we add a debug message to the logs with some useful information? > > Marcel, are you ok to push it? Yes, ok. But we could indeed add a warn, because we are combatting symptoms.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 11:36:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 10:36:25 +0000 Subject: [Koha-bugs] [Bug 20167] New: Item hold is set to bibliographic hold when changing pickup location Message-ID: <bug-20167-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Bug ID: 20167 Summary: Item hold is set to bibliographic hold when changing pickup location Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a patron has an item level hold with pickup location set to library A and staff then (via the Holds tab in the patron view) changes pickup location to library B, itemnumber is lost from the hold. This is a definite problem when the items within a bibliographic record are different things (separate volumes for example). This can be fixed by adding some code in Koha/REST/V1/Hold.pm This bit before the ModReserve call: if($hold->itemnumber()) { $params->{itemnumber} = $hold->itemnumber(); } However, given the FIXME comment in C4/Reserves.pm for ModReserve, I'm wondering if this is the desired fix: "Note that the forgoing can have the effect of causing item-level hold requests to turn into title-level requests. This will be fixed once reserves has separate columns for requested itemnumber and supplying itemnumber." A different method of solving this issue could be to provide itemnumber as part of the pickup-location-change call instead and keep the rest of the REST-API and ModReserve the way it works now. I'm somewhat unfamiliar with the how the Mojolicious system works, so I haven't looked into that method yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 11:38:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 10:38:16 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-0EbLbOGbZE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #36 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Marcel de Rooy from comment #35) > > - In Koha::Authority::ControlledIndicators, there is a package variable > > $cached_indicators. Maybe this module should use Koha::Cache instead ? > > I do not really see the advantage. We do not win time imo by saving the > structure to the L2 cache. We could argue about putting it in L1 only (and > check if we would gain time), but that seems not possible now. Since the > internal structure is kept only during the lifetime of the object, the name > could be misleading. If required, I could rename it. I'm just saying that maybe we should use Koha::Cache for consistency (I can totally be wrong :)) You're saying that the structure is kept only during the lifetime of the object, but with Plack, isn't the object's lifetime infinite ? > > > Also, I'm not sure if this is a problem, but it seems that there is no way > > to tell Koha to change only one of the two indicators. > > I am not sure if I understand this correctly. The current approach with the > pref allows for great flexibility. > If you say e.g. MARC21,100,ind1:auth1 you only copy the first indicator. The > second indicator will be empty when creating a new field or will be taken > from the biblio record when updating/merging. > But if you say e.g. MARC21,830,,ind2:auth2 you only copy the second > indicator. One of the unit tests contains an example where indicators are > swapped. With "MARC21,100,ind1:auth1" for instance, if I manually put something in the 2nd indicator, when I choose an authority it erases the content of the 2nd indicator. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 11:42:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 10:42:23 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-swktvYZqrE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Julian Maurice from comment #36) > You're saying that the structure is kept only during the lifetime of the > object, but with Plack, isn't the object's lifetime infinite ? No. The code is cached for some time, but we create a new Controller object for each new Authority object. And in new we clear the saved structure. (We could also save it in $self alternatively.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 11:49:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 10:49:49 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-7q6WIpfheW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #38 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Marcel de Rooy from comment #37) > (In reply to Julian Maurice from comment #36) > > You're saying that the structure is kept only during the lifetime of the > > object, but with Plack, isn't the object's lifetime infinite ? > > No. The code is cached for some time, but we create a new Controller object > for each new Authority object. And in new we clear the saved structure. (We > could also save it in $self alternatively.) Ah sorry, I missed that. I don't know what is best, there is nothing about this in coding guidelines, so I guess it's okay to keep it like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 11:51:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 10:51:06 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-NIbaSp27nO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Julian Maurice from comment #36) > With "MARC21,100,ind1:auth1" for instance, if I manually put something in > the 2nd indicator, when I choose an authority it erases the content of the > 2nd indicator. OK. When you first add an indicator and then run the authority plugin. Will add a fix.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 11:51:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 10:51:18 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-1Zl5vfTNWw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 12:04:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 11:04:55 +0000 Subject: [Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present In-Reply-To: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19451-70-xYkCUihWLD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71367&action=edit Bug 19451: (QA follow-up) Replace weird subquery As requested, we add a JOIN and make the SELECT distinct. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Tested that no-overwrite still works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 12:26:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 11:26:44 +0000 Subject: [Koha-bugs] [Bug 19765] Special library groups should have a 'translated' title and should not be editable In-Reply-To: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19765-70-Tl7xBRjexT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19765 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |MOVED --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- This is no longer needed due to bug 20157. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 12:43:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 11:43:34 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-enobX3gopU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 12:43:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 11:43:36 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-QC9R9A93zB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71156|0 |1 is obsolete| | Attachment #71157|0 |1 is obsolete| | Attachment #71158|0 |1 is obsolete| | Attachment #71159|0 |1 is obsolete| | Attachment #71296|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71368&action=edit Bug 20133: Add new column library_groups.ft_hide_patron_info Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 12:44:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 11:44:01 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-kDOhKcsKYM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71368|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71369&action=edit Bug 20133: Add new column library_groups.ft_hide_patron_info Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 12:44:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 11:44:07 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-u3I5GRPYQa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71370&action=edit Bug 20133: DBIC Schema changes Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 12:44:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 11:44:10 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-HvOtyS8eaZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71371&action=edit Bug 20133: UI Changes Add a checkbox to enable/disable the feature for given group of libraries. Important note: Only the top level node can turn the feature, the idea is to avoid confusion, ease testing (by limiting the number of cases) and force libraries to define one tree per feature (Maybe this is wrong, but maybe good to start) Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 12:44:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 11:44:13 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-FxHlRcJKOZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71372&action=edit Bug 20133: Enable/disable the "Hide patron information" feature per group of libraries In order to control this feature correctly it needs to be enabled for group of libraries and not for all groups defined in the system. Groups will be used for different usages and so the feature must not be enabled by default for all of them. Test plan: Retest bug 18403 with the feature turned on/off for a given tree Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 12:44:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 11:44:15 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-DT5bKLY7OK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71373&action=edit Bug 20133 [QA Followup] - Tweak new 'group features' section Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 12:51:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 11:51:35 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-ey7RFzkVOw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- You got me a little confused there. Short form was: - Push only first patch, leave button descriptions alone. If this affects another bug, please change accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:17:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:17:05 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-d8Y3hlSo4q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71374&action=edit Bug 14769: (Follow-up) Let blinddetail look at indicator values If the indicators are not controlled, blinddetail should not overwrite what the user already entered. Very strictly seen, we could say that it is outside the scope. But it is strongly related. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Tested with 100 and 600 in the cataloging editor. For 100 the second indicator should not be overwritten. For 600 it should. Also tested "ind2:" which should blank ind2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:23:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:23:55 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-LelnJz2KZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71351|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71375&action=edit Bug 14769: Introduce Koha::Authority::ControlledIndicators This module reads its settings from pref AuthorityControlledIndicators. The get method allows you to retrieve indicator values for specific biblio fields. Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Amended: Added a test to show that "ind1:" returns empty string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:24:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:24:00 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-G6oNaIlrJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71352|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71376&action=edit Bug 14769: Biblio indicators based on authority's thesaurus code Original patch from Janusz Kaczmarek on November 24, 2017. Amended by Marcel de Rooy on February 6, 2018. Code moved from AuthoritiesMarc.pm to ControlledIndicators.pm. Special attention has been paid to the proper application of 008/11 while controlling 6XX in MARC 21, specially if 008/11 =~ /[rsz]/ (and if it is 'z' and 040 $f is defined). Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> The construction $thes_mapping{ $code } // $code // '4' will still get some attention on a follow-up. Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:24:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:24:04 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-aG0hU3FIcG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71353|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71377&action=edit Bug 14769: Add tests for _thesaurus_info in ControlledIndicators.t Apart from adding tests for this sub, we make the following change too and support it with a test. The fallback to $code in the construction $thes_mapping{ $code } // $code // '4' is removed by this patch. When $code is not in $thes_mapping, we cannot assume that it is a valid code for a biblio indicator. In this case it is more safe to mark it as 4 (Source not specified). Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:24:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:24:09 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-RGmfP4kwrj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71354|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71378&action=edit Bug 14769: Add preference AuthorityControlledIndicators Including: [1] Atomic update to add pref for existing installs [2] Add new pref to sysprefs.sql for new installs [3] Add description to authorities preference file. Test plan: [1] Run new install or upgrade to add pref. [2] Check value of pref via System preferences in staff interface. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:24:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:24:13 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-3YAyAqqmtZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71355|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71379&action=edit Bug 14769: Put ControlledIndicators to work This patch does: [1] Adds Koha::Authority->controlled_indicators (with a test). [2] Adds a call to controlled_indicators in AuthoritiesMarc::merge. Unit test Merge.t is extended too. [3] Simplifies the code in authorities/blinddetail-biblio-search.pl by calling controlled_indicators. Test plan: [1] Run t/db_dependent/Koha/Authorities.t [2] Run t/db_dependent/Authority/Merge.t [3] Steps 3 to 7 for MARC21: Create a PERSO_NAME authority with 008/11=r and ind1=3 [4] Edit a biblio and add a 600 linked to the new authority. [5] Verify that the biblio has ind1==3 and ind2==7 and $2==aat. (If $2 is not visible, check the metadata in biblio_metadata.) [6] Edit the PERSO_NAME authority and change 008/11 to '|' (bar). [7] Verify that merge updated your biblio record: $ind2==4 and $2 gone. [8] UNIMARC: Follow the pattern from steps 3 to 7. Create authority, link it in a biblio, check indicators (they should be copied both). Edit authority, change indicators and verify the merge results in the biblio record. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Tested PERSO_NAME and UNIF_TITLE. For UNIF_TITLE the second authority indicator is copied to ind1 or ind2, depending on the biblio tag involved. Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:24:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:24:18 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-VKcO0SWXV1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71366|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71380&action=edit Bug 14769: (Follow-up) Reduce number of preference parses In sub merge the Koha::Authority object was already created, so it was kind of silly to recreate it each time with new. In Koha::Authority, the ControlledIndicators object can be saved in the object too for reuse during its life time. Similarly, we prevent repeated lookups for the reporting tag (via authority type). Test plan: [1] Run t/db_dependent/Authority/Merge.t [2] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Limited benchmarking shows me a reduction of 11% on Merge.t and a reduction of 4% on Authorities.t when comparing with and without this last patch. The larger impact on Merge.t could be expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:24:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:24:23 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-q9e0Fww9fG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71374|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71381&action=edit Bug 14769: (Follow-up) Let blinddetail look at indicator values If the indicators are not controlled, blinddetail should not overwrite what the user already entered. Very strictly seen, we could say that it is outside the scope. But it is strongly related. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Tested with 100 and 600 in the cataloging editor. For 100 the second indicator should not be overwritten. For 600 it should. Also tested "ind2:" which should blank ind2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:27:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:27:30 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18958-70-D0iTHT4EAG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:30:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:30:51 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-VlAxRRYUdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #0) > We have found multiple open branch transfers for a given item. While I'm not > sure how it is happening at this point, it seems that it would make sense to > cancel any existing branch transfers when initiating a new one. Kyle, can you give more details please? Which version? On only 1 installation or more? Using other developments (fork)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:34:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:34:53 +0000 Subject: [Koha-bugs] [Bug 20168] New: update to bootstrap v4 Message-ID: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Bug ID: 20168 Summary: update to bootstrap v4 Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: elias.dehler at thulb.uni-jena.de QA Contact: testopia at bugs.koha-community.org I'm currently working on updating the bootstrap template to bootstrap v4. This requires to update jQuery as well. My work is based on the current 17.11.02 koha release. I'm trying to keep the design as close to the current design as possible. At the moment i have nothing to show of my current process but as soon as everything plays nice i will post a link to my repository. The goal is to get a template based on the current version of bootstrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:36:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:36:00 +0000 Subject: [Koha-bugs] [Bug 20168] update the OPAC to bootstrap v4 In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20168-70-iaOQcjspkU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Elias <elias.dehler at thulb.uni-jena.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|update to bootstrap v4 |update the OPAC to | |bootstrap v4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 13:39:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 12:39:30 +0000 Subject: [Koha-bugs] [Bug 20168] update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20168-70-nAhrMrFexZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Elias <elias.dehler at thulb.uni-jena.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|update the OPAC to |update of the OPAC |bootstrap v4 |bootstrap template to | |bootstrap v4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 14:00:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 13:00:59 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-FjPIxz81ji@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71382&action=edit Bug 20157: Save the features that have been checked Previous patch forgot to modify the controller script to save the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 14:10:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 13:10:53 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-xM5QISTfoP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71383&action=edit Bug 20157: Correctly hide the features for non first level groups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 14:21:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 13:21:33 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19946-70-sKfsFcFD7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 14:21:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 13:21:35 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19946-70-gyvvL0gfUR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71384&action=edit Bug 19946: (Follow-up) Add fixed footer to authorities Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. This patch also adds some whitespace to the "Author (meeting/conference)" label to enable better word wrapping. To test, apply the patch and go to Authorities -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 14:33:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 13:33:32 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-N0n9KRqY8M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 14:48:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 13:48:57 +0000 Subject: [Koha-bugs] [Bug 20168] update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20168-70-PybYK1xzqK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |OPAC Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |elias.dehler at thulb.uni-jena | |.de --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Please base your work on master! The patch would not be accepted on a stable release branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 14:57:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 13:57:55 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-F6PbX5FovQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71385&action=edit Bug 20157 [QA Followup] - Fix error triggered by subgroups being added to group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 14:58:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 13:58:17 +0000 Subject: [Koha-bugs] [Bug 20168] update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20168-70-RrU8QB5e6t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Consider also how your work might conflict with these in-progress patches: https://bugs.koha-community.org/bugzilla3/buglist.cgi?bug_status=Needs%20Signoff&bug_status=Signed%20Off&bug_status=Passed%20QA&component=OPAC&list_id=228043&query_format=advanced -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 15:08:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 14:08:31 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-L3IyOYuR9Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com --- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> --- Passed QA! Since this a git branch I'll just change the bug status. You can add me s/o when the commits are pushed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 15:14:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 14:14:01 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: <bug-17704-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17704-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17704-70-ES0mwwgfqT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/LibreCat | |/perl-oai-lib/issues/4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 15:40:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 14:40:51 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16735-70-K2QiArGgu0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #81 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71386&action=edit Bug 16735: Remove unecessary use of Koha::LibraryCategories in onboarding This was not used, it has been copied/pasted from admin/branches.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 15:44:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 14:44:44 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16735-70-jAxSCX60W2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 15:51:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 14:51:30 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20120-70-PswwYnAPsc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10) > Hm, thinking about it: when you writeoff, you don't get any money from the > customer, so even more reason NOT to assume a credit. Right. I think we've addressed everything sufficiently. If I'm wrong, please update the bug status of course! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 16:01:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 15:01:38 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-GIqjffVMeG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71387&action=edit Bug 20157: Group search groups together We do not actually need 2 groups, the previous feature worked for both OPAC and STAFF interface. The only difference was the "show_in_pulldown" feature. Here we are going to REMOVE this feature for ergonomic reasons. We will already have 3 features and it will surcharge the interface to add another one. Moreover the feature will have to be applied at the OPAC (and so will add lot of JS checks to keep data consistent: only useful if ft_search_groups_opac is set). Moreover it is quite easy to remove entry from the dropdown list in JavaScript. If people was really using this feature, we will re-add it, just let us know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 16:05:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 15:05:39 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-BvlgbuLdLd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #71385|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 71385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71385 Bug 20157 [QA Followup] - Fix error triggered by subgroups being added to group Moved to bug 18403 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 16:27:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 15:27:12 +0000 Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's Account When Charge is Paid In-Reply-To: <bug-18895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18895-70-NTRCDHB8oA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 Lisette <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 16:55:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 15:55:35 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-wK6TpEsfrx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #17) > (In reply to Kyle M Hall from comment #0) > > We have found multiple open branch transfers for a given item. While I'm not > > sure how it is happening at this point, it seems that it would make sense to > > cancel any existing branch transfers when initiating a new one. > > Kyle, can you give more details please? Which version? On only 1 > installation or more? Using other developments (fork)? It's happened on a few partners. No changes to the code. We just were unable to figure out how the librarians were cause the issue. It's been happening for the 16.x and 17.x at the very least, possibly longer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 17:02:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 16:02:21 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-C6G8j8IE8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #19 from NancyK. <nkeener at washoecounty.us> --- We noticed this when we went to 17.05. If an item on hold gets put in transit, but is thrown in the wrong bin and gets sent to the wrong library, when they check the item in, it stays in transit. That's different behavior. They are used to being able to just put it in transit again to the correct library. When that second in-transit happens its chaos. NancyK Washoe County Library System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 17:57:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 16:57:14 +0000 Subject: [Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons In-Reply-To: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19954-70-4U0IOCHrMJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Jonathan Druart from Bug 19641) > Before: > https://screenshots.firefox.com/aiunxdJJDVm8KUyk/pro.kohadev.org > After: > https://screenshots.firefox.com/hNHmyPk4g8VNpj0C/pro.kohadev.org > > Why is it better? > > Same for the brief view: > Before: > https://screenshots.firefox.com/62t0wbESsXjcuKaO/pro.kohadev.org > After: > https://screenshots.firefox.com/oAnGeNsYW9s3qvTv/pro.kohadev.org I was not trying to change the layout per se, it's a consequence of the grid change. I find the changes to be neutral, especially since the view people will see normally is the small popup. The patron brief view triggered from the duplicate patron warning is always going to look strange if no primary contact information appears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 17:58:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 16:58:51 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-QAg7xpB3w8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #20 from NancyK. <nkeener at washoecounty.us> --- We noticed this when we went to 17.05. If an item on hold gets put in transit, but is thrown in the wrong bin and gets sent to the wrong library, when they check the item in, it stays in transit. That's different behavior. They are used to being able to just put it in transit again to the correct library. When that second in-transit happens its chaos. NancyK Washoe County Library System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:08:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:08:48 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-mFF6km3Su9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:08:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:08:57 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-9pMddjgTzG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #99 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:09:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:09:04 +0000 Subject: [Koha-bugs] [Bug 19801] Display messages on user details page as well as on check out page In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19801-70-mqUsTZYPS9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:09:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:09:12 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-a4kgbnLvrk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:09:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:09:19 +0000 Subject: [Koha-bugs] [Bug 20134] Remove /api/v1/app.pl from the generated URLs In-Reply-To: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20134-70-SON0QIRpQg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:09:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:09:25 +0000 Subject: [Koha-bugs] [Bug 20156] Staff client header language menu doesn't show check mark for current language In-Reply-To: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20156-70-JOIQIKTVtX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:12:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:12:04 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-eSEKREXB1Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #400 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #399) > Created attachment 71283 [details] [review] > Bug 7143: Fix typo developper vs developer Pushed to master for 18.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:15:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:15:05 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-5NreJqvE1g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #14 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- @Nick: Does the last discussion in bug 19928 affects this one? See from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928#c29 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:26:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:26:46 +0000 Subject: [Koha-bugs] [Bug 20169] New: Two tests are failing with DBD::mysql 4.041 Message-ID: <bug-20169-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20169 Bug ID: 20169 Summary: Two tests are failing with DBD::mysql 4.041 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Two tests are failing with DBD::mysql 4.041 prove t/db_dependent/Accounts.t t/db_dependent/Bookseller.t t/db_dependent/Accounts.t .... 17/23 # Failed test 'Correct amount logged to statistics' # at t/db_dependent/Accounts.t line 398. # got: '100' # expected: '100.0000' # Looks like you failed 1 test of 8. t/db_dependent/Accounts.t .... 20/23 # Failed test 'More Koha::Account::pay tests' # at t/db_dependent/Accounts.t line 400. # Failed test 'Correct amount logged to statistics' # at t/db_dependent/Accounts.t line 452. # got: '60' # expected: '60.0000' # Looks like you failed 1 test of 8. t/db_dependent/Accounts.t .... 21/23 # Failed test 'Even more Koha::Account::pay tests' # at t/db_dependent/Accounts.t line 454. t/db_dependent/Accounts.t .... 23/23 # Looks like you failed 2 tests of 23. t/db_dependent/Accounts.t .... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/23 subtests t/db_dependent/Bookseller.t .. 2/86 # Failed test 'Koha::Acquisition::Booksellers->search returns the right informations about supplier Name2' # at t/db_dependent/Bookseller.t line 120. # Structures begin differing at: # $got->{discount} = '2' # $expected->{discount} = '2.0000' # Failed test 'Returns right fields of Supplier1 and Supplier2' # at t/db_dependent/Bookseller.t line 133. # Structures begin differing at: # $got->[0]{discount} = '2' # $expected->[0]{discount} = '2.0000' # Failed test 'Get Supplier1 (find a bookseller by id)' # at t/db_dependent/Bookseller.t line 152. # Structures begin differing at: # $got->{discount} = '1' # $expected->{discount} = '1.0000' # Looks like you failed 3 tests of 86. t/db_dependent/Bookseller.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/86 subtests Test Summary Report ------------------- t/db_dependent/Accounts.t (Wstat: 512 Tests: 23 Failed: 2) Failed tests: 20-21 Non-zero exit status: 2 t/db_dependent/Bookseller.t (Wstat: 768 Tests: 86 Failed: 3) Failed tests: 9, 11, 15 Non-zero exit status: 3 Files=2, Tests=109, 12 wallclock secs ( 0.05 usr 0.01 sys + 4.63 cusr 0.75 csys = 5.44 CPU) Result: FAIL Tests pass with DBD::mysql 4.028 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:28:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:28:41 +0000 Subject: [Koha-bugs] [Bug 19076] Renewal via Checkout screen is logged as both a renewal and a checkout In-Reply-To: <bug-19076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19076-70-zFrduF4D83@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19076 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:32:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:32:50 +0000 Subject: [Koha-bugs] [Bug 20169] Two tests are failing with DBD::mysql 4.041 In-Reply-To: <bug-20169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20169-70-wmiWRpaXOj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20169 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |julian.maurice at biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:32:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:32:35 +0000 Subject: [Koha-bugs] [Bug 20169] Two tests are failing with DBD::mysql 4.041 In-Reply-To: <bug-20169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20169-70-ov7nIhHaLQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20169 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71388&action=edit Bug 20169: Fix two tests when DBD::mysql is 4.041 Tests pass with DBD::mysql 4.028, but not with 4.041. I'm not sure which exact version makes those tests to fail. The problem is that with newer versions of DBD::mysql, 'float' columns get converted to numbers instead of string, thus the comparison fail. This patch converts the expected values to numbers so the comparison should succeed with both versions of DBD::mysql Test plan: 1. Install DBD::mysql 4.041 or newer 2. prove t/db_dependent/Accounts.t t/db_dependent/Bookseller.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:37:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:37:39 +0000 Subject: [Koha-bugs] [Bug 20170] New: Clicking Reregistration Link Causes Enrollment Periods to Stack Message-ID: <bug-20170-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20170 Bug ID: 20170 Summary: Clicking Reregistration Link Causes Enrollment Periods to Stack Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cslone at camdencountylibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you renew a patron's registration by using the 'Renew' link that is displayed after the expiration warning on the checkout screen, and you click said link more than once, the dateexpiry gets changed and extended a requisite number of times. In other words, if your enrollment period is two years and you double-click this link, the new expiration date will be end up being four years from today. If you triple click it, it will be 6 years. Quadruple click it for 8 years. (It's not possible to do this using the dropdown renewal option as it produces a dialogue box asking for the user to confirm the registration renewal.) To replicate: 1.) Create or select a patron category that has an enrollment period that is calculated in months (not a fixed date, for this example I use 24 months 2.) Find or create a patron in that category with an expired account 3.) Open this patron's account for checkout and find the warning about the patron's expired account 4.) Double click 'Renew' 5.) When the page reloads confirm that the expiration date is now 48 months from today (rather than the 24 dictated by the category enrollment period) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:39:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:39:49 +0000 Subject: [Koha-bugs] [Bug 20170] Clicking Reregistration Link Causes Enrollment Periods to Stack In-Reply-To: <bug-20170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20170-70-tRi4iQmS9Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20170 --- Comment #1 from Chris Slone <cslone at camdencountylibrary.org> --- This may be related to bug 15792. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:39:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:39:50 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-vmJQ9uqwB5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:40:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:40:23 +0000 Subject: [Koha-bugs] [Bug 20171] New: Item search should honor syspref 'delimiter' Message-ID: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171 Bug ID: 20171 Summary: Item search should honor syspref 'delimiter' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org Same cause and fix as bug 19928 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:41:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:41:03 +0000 Subject: [Koha-bugs] [Bug 20171] Item search should honor syspref 'delimiter' In-Reply-To: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20171-70-OSxIY9KOKW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |victor.grousset at biblibre.co | |m Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19928, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17031 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:41:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:41:03 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-isDH2Ub7SV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20171 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:41:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:41:03 +0000 Subject: [Koha-bugs] [Bug 17031] Use delimeter system preference for Overdues report download In-Reply-To: <bug-17031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17031-70-aAaQXD7GUE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17031 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20171 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:45:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:45:57 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-BuGdNZkIFN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #40 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Thanks for the clarification. Yay this one finishes just in time as can start bug 20171 :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:46:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:46:43 +0000 Subject: [Koha-bugs] [Bug 18891] Download Reports Directly In-Reply-To: <bug-18891-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18891-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18891-70-4gnSMWGhGY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18891 --- Comment #2 from Chris Slone <cslone at camdencountylibrary.org> --- (In reply to Owen Leonard from comment #1) > As far as I can tell the main problem with implementing this is that before > initiating a download, Koha has to have received any search parameters > you're submitting along with the SQL. A direct download button would give > you unlimited results in cases where runtime parameters are used. I was thinking that too. Perhaps this can be addressed in two steps: 1.) Add a download link to the options menu (along with run, duplicate, etc...) there can be an option to download the report on the page where you set the parameters. a.)If the report requires no parameters to be set before being run, then it would download it directly. b.) If parameters do need to be set it would continue on to the page where these may be entered 2.) Add an option next to the parameters page to download the report directly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 18:50:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 17:50:06 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-QOiUKywCNl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71389&action=edit Bug 19928: Mock delimiter pref in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 19:24:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 18:24:42 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-Qq79EnfM2i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70565|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71390&action=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 20:02:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 19:02:01 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-PEWKs7UcZg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> --- The following commit: Bug 20144: [sql_modes] Fix output_pref with dateformat=iso makes another test to fail in t/DateUtils.t: # Failed test 'iso output 12hr' # at t/DateUtils.t line 47. # got: '2011-06-16 12:00' # expected: '2011-06-16 12:00 PM' # Looks like you failed 1 test of 67. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 20:45:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 19:45:52 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4319-70-9gkqtj5SgJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #82 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- WARNING: I have rebased bug 19301 on top of this one to avoid a rebase, but if this is not unblocked quickly I am going to rebase bug 19301 against master instead! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 20:52:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 19:52:50 +0000 Subject: [Koha-bugs] [Bug 20166] Untranslatable course reserves delete prompt In-Reply-To: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20166-70-FDpvGjW2y0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20166 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 20:52:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 19:52:52 +0000 Subject: [Koha-bugs] [Bug 20166] Untranslatable course reserves delete prompt In-Reply-To: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20166-70-JiNBNDirtp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20166 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71364|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour <roch.damour at inlibro.com> --- Created attachment 71391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71391&action=edit Bug 20166: Untranslatable course reserves delete prompt Having a Template Toolkit statements inside the javascript translation function _() prevents it from being picked for translation. The only example of such is the course reserve delete prompt. Move the TT statement outside the string. Test plan: 1) Update and install language xx-YY. Check that the msgids "Are you sure you want to delete this course? There is %s attached item." and "Are you sure you want to delete this course? There are %s attached items." do not exist in the xx-YY-staff-prog.po 2) Check the translated file intranet-tmpl/prog/fi-FI/modules/course_reserves/course-details.tt It should have two prompt texts above in English 3) Install patch 4) Update the language. Check that the msgids show up in xx-YY-staff-prog.po, translate them, and install the language. 5) Repeat 2, the prompts should now show up in the correct language. 6) Enable UsecourseReserves 7) Go to Home -> Course reserves 8) Create a new course, and add reserves to it 9) See the course details. Click on Delete course, the prompt should be correctly translated 10) Remove all but one of the reserves from the course 11) Repeat 9 To see if there are other such TT statements: rgrep -E '\b_\("[^"]*\[%' koha-tmpl/ Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 20:54:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 19:54:13 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight circulation of reference books In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6796-70-FImhN4cynO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 20:59:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 19:59:17 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-shcdGt0GEe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71392&action=edit Bug 18403: Add POD for output_and_exit_if_error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:01:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:01:02 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16735-70-fOXBIavtzb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 --- Comment #82 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71393&action=edit Bug 16735: Fix POD format for Koha::Library::Groups methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:03:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:03:40 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-7i7CJVozZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71392|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71394&action=edit Bug 18403: Add POD for output_and_exit_if_error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:07:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:07:49 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-9ij02c6BNv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:07:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:07:53 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-U2nhZLqP2H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71323|0 |1 is obsolete| | Attachment #71324|0 |1 is obsolete| | Attachment #71382|0 |1 is obsolete| | Attachment #71383|0 |1 is obsolete| | Attachment #71387|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71395&action=edit Bug 20157 - Use group 'features' to decide which groups to use for group searching functionality Instead of basing the group searches on the group name, which is an inherently touchy system, we should use the same checkbox style that Jonathan introduced for the patron limits by group feature. Test Plan: 1) Check to ensure existing group searches still show as they used to Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:07:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:07:41 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15707-70-tIhf4M155C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 --- Comment #225 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #223) > library_groups.created_on and updated_on are DATETIME in kohastructure but > timestamp in atomic update. I kept TIMESTAMP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:07:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:07:56 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-UiVLBms3FX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71396&action=edit Bug 20157 - Update Schema Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:07:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:07:59 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-TEUA96OHGo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71397&action=edit Bug 20157: Save the features that have been checked Previous patch forgot to modify the controller script to save the changes. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:08:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:08:03 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-s7ksjPQMfa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71398&action=edit Bug 20157: Correctly hide the features for non first level groups Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:08:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:08:06 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-0ojbxpENvM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71399&action=edit Bug 20157: Do not display OPAC groups on the staff interface Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:08:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:08:09 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-GtNcVwx27D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71400&action=edit Bug 20157: Group search groups together We do not actually need 2 groups, the previous feature worked for both OPAC and STAFF interface. The only difference was the "show_in_pulldown" feature. Here we are going to REMOVE this feature for ergonomic reasons. We will already have 3 features and it will surcharge the interface to add another one. Moreover the feature will have to be applied at the OPAC (and so will add lot of JS checks to keep data consistent: only useful if ft_search_groups_opac is set). Moreover it is quite easy to remove entry from the dropdown list in JavaScript. If people was really using this feature, we will re-add it, just let us know. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:20:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:20:55 +0000 Subject: [Koha-bugs] [Bug 20172] New: Add a search bar in list tables Message-ID: <bug-20172-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20172 Bug ID: 20172 Summary: Add a search bar in list tables Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, It would be nice to add a search bar fot the tables in the list's module like comme les autres tableaux qui sont diponibles dans les diff?rents module de Koha. This search box will help us when we have a lot of records in a list. It would be useful. It could be a tables like on this page circ/overdue.pl. Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:26:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:26:32 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19996-70-5zx9PXIQLq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- We got a lot of warnings in cataloguing/value_builder scripts now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:31:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:31:06 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19996-70-M0QVuomUQm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7) > We got a lot of warnings in cataloguing/value_builder scripts now and cataloguing/additem.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:58:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:58:56 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-Kxhu3CWyoT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70636|0 |1 is obsolete| | --- Comment #3 from Roch D'Amour <roch.damour at inlibro.com> --- Created attachment 71401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71401&action=edit Bug 20008 - Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr Test Plan: 1) Set TimeFormat to 12 hour 2) Add a restriction with an expiration date via memberentry.pl 3) Note the restriction exists, but has no expiration date 4) Apply this patch 5) Repeat step 2 6) Note the restriction exists and has an expiration date! Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 21:58:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 20:58:54 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-9bYQnSNOea@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 22:30:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 21:30:04 +0000 Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from installer files In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19790-70-o7PdYvg5JO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com --- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> --- Installed first without the patch, then with the patch. The second time around, no "additionalauthors" appeared in my database dump. However, minor nitpick: setting a value to NULL in your atomicupdate script is not the same as setting it to the empty string ''. Perhaps you'd want change your updatedb script in order to have the same end result, whether you're installing fresh or running updatedatabase over existing data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 22:32:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 21:32:49 +0000 Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from installer files In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19790-70-JtG09z1MOK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 22:32:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 21:32:52 +0000 Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from installer files In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19790-70-YjPEyGaioc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69679|0 |1 is obsolete| | --- Comment #6 from Charles Farmer <charles.farmer at inlibro.com> --- Created attachment 71402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71402&action=edit Bug 19790: Remove additionalauthors.author from installer files In the upgrade from 2.2 to 3.0 (some time ago already) the table additionalauthors has been dropped. Unfortunately, a reference to this table has not been removed from the MARC framework installer files. This patch clears kohafield for 700$a or 200$g in 32 installer files. Note: The reference to additionalauthors in field kohafield is silently ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio, _koha_add_biblioitem, _koha_modify_biblio and _koha_modify_biblioitem_nonmarc simply do not use it. You can define a Koha to MARC mapping for a biblio/biblioitem field but if the field is not referenced in one of those routines, nothing happens.. Also note that C4::Items::_koha_modify_item does not hardcode all fields and will respond to a new item mapping. Test plan: [1] Run a new install or verify somehow that the change to these sql files is correct. The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g" Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Run a new install with MARC21 and English. This includes the mandatory file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted correctly (without additionalauthors). Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 22:32:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 21:32:56 +0000 Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from installer files In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19790-70-Kh94Ra3jSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69680|0 |1 is obsolete| | --- Comment #7 from Charles Farmer <charles.farmer at inlibro.com> --- Created attachment 71403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71403&action=edit Bug 19790: Add a db revision for existing installs Since many installs may still have the additionalauthors kohafield, this patch adds a dbrev in atomicupdate to clear it. Test plan: [1] Run updatedatabase. Check that you see no additionalauthors anymore in marc_subfield_structure.kohafield. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 22:37:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 21:37:15 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-FYLbA4foks@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #100 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- We should improve the rewrite rule, it fails for few files (for instance editor_plugin.js on admin/branches.pl?op=add_form&branchcode=CPL) Could anyone take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 22:45:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 21:45:50 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-kQgxl2WQzc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am going to push this change along with bug 16735 and bug 20133. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 9 22:46:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Feb 2018 21:46:21 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-8z1JhK2PPf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am going to push this change along with bug 18403. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 10 23:11:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Feb 2018 22:11:05 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20168-70-Hejb7Ubssr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|update of the OPAC |Update of the OPAC |bootstrap template to |bootstrap template to |bootstrap v4 |bootstrap v4 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 10 23:12:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Feb 2018 22:12:18 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20168-70-RWsXsEfQPV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Please also avoid one big change patch - smaller steps are always easier to test and integrate! Not sure, maybe it would make sense to split jQuery update and Bootstrap update into 2 separate bugs and patch sets? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 10 23:15:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Feb 2018 22:15:14 +0000 Subject: [Koha-bugs] [Bug 20172] Add a search bar in list tables In-Reply-To: <bug-20172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20172-70-XwQRgoGiaD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20172 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Patrick, sorry, not sure what you mean. Can you try to rephrase/explain a bit more? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:26:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:26:39 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18979-70-N3szMReOsn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Marcel, could you have another look here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:29:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:29:53 +0000 Subject: [Koha-bugs] [Bug 20166] Untranslatable course reserves delete prompt In-Reply-To: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20166-70-aY0zv4Vit7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20166 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is an improvement, but the variable in the case of 1 seems a little strange ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:30:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:30:39 +0000 Subject: [Koha-bugs] [Bug 20166] Untranslatable course reserves delete prompt In-Reply-To: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20166-70-72QazEO1Gq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20166 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:30:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:30:42 +0000 Subject: [Koha-bugs] [Bug 20166] Untranslatable course reserves delete prompt In-Reply-To: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20166-70-4QpEkc6DvC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20166 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71391|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71404&action=edit Bug 20166: Untranslatable course reserves delete prompt Having a Template Toolkit statements inside the javascript translation function _() prevents it from being picked for translation. The only example of such is the course reserve delete prompt. Move the TT statement outside the string. Test plan: 1) Update and install language xx-YY. Check that the msgids "Are you sure you want to delete this course? There is %s attached item." and "Are you sure you want to delete this course? There are %s attached items." do not exist in the xx-YY-staff-prog.po 2) Check the translated file intranet-tmpl/prog/fi-FI/modules/course_reserves/course-details.tt It should have two prompt texts above in English 3) Install patch 4) Update the language. Check that the msgids show up in xx-YY-staff-prog.po, translate them, and install the language. 5) Repeat 2, the prompts should now show up in the correct language. 6) Enable UsecourseReserves 7) Go to Home -> Course reserves 8) Create a new course, and add reserves to it 9) See the course details. Click on Delete course, the prompt should be correctly translated 10) Remove all but one of the reserves from the course 11) Repeat 9 To see if there are other such TT statements: rgrep -E '\b_\("[^"]*\[%' koha-tmpl/ Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:38:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:38:10 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-rUQuPGU3zg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:38:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:38:14 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-SPlvI2VdpP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71401|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71405&action=edit Bug 20008: Fix restrictions added from memberentry.pl if TimeFormat is 12hr Test Plan: 1) Set TimeFormat to 12 hour 2) Add a restriction with an expiration date via memberentry.pl 3) Note the restriction exists, but has no expiration date 4) Apply this patch 5) Repeat step 2 6) Note the restriction exists and has an expiration date! Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:43:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:43:25 +0000 Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from installer files In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19790-70-YJK4PuqFA2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71402|0 |1 is obsolete| | Attachment #71403|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71406&action=edit Bug 19790: Remove additionalauthors.author from installer files In the upgrade from 2.2 to 3.0 (some time ago already) the table additionalauthors has been dropped. Unfortunately, a reference to this table has not been removed from the MARC framework installer files. This patch clears kohafield for 700$a or 200$g in 32 installer files. Note: The reference to additionalauthors in field kohafield is silently ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio, _koha_add_biblioitem, _koha_modify_biblio and _koha_modify_biblioitem_nonmarc simply do not use it. You can define a Koha to MARC mapping for a biblio/biblioitem field but if the field is not referenced in one of those routines, nothing happens.. Also note that C4::Items::_koha_modify_item does not hardcode all fields and will respond to a new item mapping. Test plan: [1] Run a new install or verify somehow that the change to these sql files is correct. The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g" Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Run a new install with MARC21 and English. This includes the mandatory file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted correctly (without additionalauthors). Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:43:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:43:21 +0000 Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from installer files In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19790-70-GxcBMD9pvC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:43:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:43:43 +0000 Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from installer files In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19790-70-06y4EcaHnp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71407&action=edit Bug 19790: Add a db revision for existing installs Since many installs may still have the additionalauthors kohafield, this patch adds a dbrev in atomicupdate to clear it. Test plan: [1] Run updatedatabase. Check that you see no additionalauthors anymore in marc_subfield_structure.kohafield. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:44:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:44:37 +0000 Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from installer files In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19790-70-7uhWh8v3WN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Patch complexity|Trivial patch |Medium patch --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- DB update - not trivial :) https://wiki.koha-community.org/wiki/Submitting_A_Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 16:49:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 15:49:14 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-jUOQsdiN2J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Julian Maurice from comment #10) > The following commit: > > Bug 20144: [sql_modes] Fix output_pref with dateformat=iso > > makes another test to fail in t/DateUtils.t: > > # Failed test 'iso output 12hr' > # at t/DateUtils.t line 47. > # got: '2011-06-16 12:00' > # expected: '2011-06-16 12:00 PM' > # Looks like you failed 1 test of 67. Confirmed. Setting to FQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 11 17:14:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Feb 2018 16:14:35 +0000 Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18975-70-kfqa2YEvAK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Should this be NSO? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 03:44:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 02:44:19 +0000 Subject: [Koha-bugs] [Bug 20173] New: Clean up koha-tmpl directory Message-ID: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173 Bug ID: 20173 Summary: Clean up koha-tmpl directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org At the moment, there are the following files in git: koha-tmpl/favicon.ico koha-tmpl/index.html koha-tmpl/intranet.html koha-tmpl/opac.html As far as I can tell, these files aren't actually used for anything. Looking at the git log, it looks like these are a holdover from 2003 when koha-tmpl replaced koha-html? Looks quite safe to remove these files now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 03:45:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 02:45:40 +0000 Subject: [Koha-bugs] [Bug 20173] Clean up koha-tmpl directory In-Reply-To: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20173-70-m76COl4rfV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 03:45:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 02:45:43 +0000 Subject: [Koha-bugs] [Bug 20173] Clean up koha-tmpl directory In-Reply-To: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20173-70-AQ9rEJccJh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173 --- Comment #1 from David Cook <dcook at prosentient.com.au> --- Created attachment 71408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71408&action=edit Bug 20173 - Clean up koha-tmpl directory This patch removes some HTML and ico files that are no longer used in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 03:51:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 02:51:31 +0000 Subject: [Koha-bugs] [Bug 20173] Clean up koha-tmpl directory In-Reply-To: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20173-70-XUev9RO6rA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- Note: These files don't even make it through the build process of Koha, as far as I can tell. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 03:53:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 02:53:58 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-Dfn0qaefJC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68571|0 |1 is obsolete| | --- Comment #69 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71409&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 03:59:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 02:59:20 +0000 Subject: [Koha-bugs] [Bug 20174] New: Remove xml_sax.pl target from Makefile.pl Message-ID: <bug-20174-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20174 Bug ID: 20174 Summary: Remove xml_sax.pl target from Makefile.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org A line was added to Makefile.PL with Bug #5033 but it doesn't seem like it's used anymore? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 05:16:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 04:16:25 +0000 Subject: [Koha-bugs] [Bug 20173] Clean up koha-tmpl directory In-Reply-To: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20173-70-iUfjT3VcPO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Assignee|oleonard at myacpl.org |dcook at prosentient.com.au CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- I confirmed the favicon.ico, but then your patch to remove things didn't include it. I also noticed that the apache configuration files had ProxyPass, ProxyPassReverse, and ScriptAlias values related to index.html as well, so perhaps we should clean those up too? And yes, intranet and opac html files are only in the index.html file. I'll mark this "Failed QA" for definitely the first point, but I would like clarification on why not the second paragraph. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 07:08:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 06:08:49 +0000 Subject: [Koha-bugs] [Bug 20173] Clean up koha-tmpl directory In-Reply-To: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20173-70-baAiM2sgea@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Why do you think the favicon is not used? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 07:11:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 06:11:29 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-cB60uIz2Be@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #70 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Aleihsa, please keep in mind that the notices need to be added to all the translated installers as well. It's ok to add them in English, but they should be there to ease translation and don't have different behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 07:28:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 06:28:05 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20168-70-6d2BNgUbzY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 08:39:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 07:39:29 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4319-70-yJceZAseG0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #83 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #82) > WARNING: I have rebased bug 19301 on top of this one to avoid a rebase, but > if this is not unblocked quickly I am going to rebase bug 19301 against > master instead! Here you are :) You blocked it yourself and you didnt respond to my question in comment78. Please do. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 09:52:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 08:52:16 +0000 Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers In-Reply-To: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19017-70-s22FoU6tbS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017 --- Comment #11 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to Katrin Fischer from comment #10) > I agree with Jonathan: > > - The French country code +33 is hard coded into the script which makes it > only useful for French telephone numbers, but not usable for example for > German ones (+41). This could easily be more generic and then much more > useful. +33 (or 0033) is not hard coded into the script. Only in the pod. It is only in the C4::SMSNumber::Fr package which is dedicated to french number. You can add a C4::SMSNumber::De package with a german logic for transforming number and add to the pod: - De: Checks german mobile number. options: '+41', ... \n" like i did for french > - There is an option --country-option, but it doesn't appear to be used? Yes, forgot to remove this from the pod > - It adds a new module to C4, which we should not do anymore. Better in Koha/SMSNumber/* ? > - It doesn't include tests. Right. > > I think if we want something like that, it might be better as a clean-up > script in misc/maintenance. Possibly without a separate module? Separate modules contain the logic specific to each area. It's not easy/clear/possible to have a script that check and transform number for all the areas as the format of number could be different (i.e not the number of digit). So the area paramter determines which area module to use. > > I think it's not quite ready, sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 09:57:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 08:57:14 +0000 Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers In-Reply-To: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19017-70-HltiuAxONS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017 --- Comment #12 from Alex Arnaud <alex.arnaud at biblibre.com> --- An other point i'm wondering about is the libraries having borrowers from different areas. It is the case for many universities. But, for now, the script runs for all the users in database without being aware of their country/area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:17:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:17:25 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-vQfisQaZwY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> --- The git branch contains more than 60 commits (mostly independents from each other). Some commits are OK while others require more work. In order to not block the whole thing, I'm going to attach the patches that pass QA, and maybe open new reports for problematic patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:18:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:18:15 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-6a4UHe4vxB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71410&action=edit Bug 20144: [sql_modes] Fix borrowers table structure surname, address and city can be NULL Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:23:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:23:50 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-zUBIOK7Jpp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71411&action=edit Bug 20144: [sql_modes] Set a default value for lowestPriority Fix for: Field 'lowestPriority' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:30:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:30:22 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-QPVegE1StL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71412&action=edit Bug 20144: [sql_modes] Fix default value for statistics.amount Must be an integer, not empty string Fix for: Data truncated for column 'value' Found with t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:38:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:38:17 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-Df0fOXmPnz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71413&action=edit Bug 20144: [sql_modes] Fix generated value for account_offsets.amount Fix error: Out of range value for column 'amount' DBD::mysql::st execute failed: Out of range value for column 'amount' at row 1 [for Statement "INSERT INTO `account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=7925469795795194609664.000000, 1='10', 2='Manual Debit'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. 7925469795795194609664.000000 => Should be lower anyway Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:39:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:39:52 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-SkQuAnq63M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71414&action=edit Bug 20144: [sql_modes] Set default value for Aqbookseller in TestBuilder Fix for: Out of range value for column 'tax_rate' t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:43:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:43:58 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-0sLkf33w8c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71415&action=edit Bug 20144: [sql_modes] Fix datatype for aqbasket.authorisedby It's defined as a VARCHAR(10) in DB, but it is expecting a borrowernumber instead Fix for Data too long for column 'authorisedby' Must be a FK but first a borrowernumber Need to update kohastructure for the comment? Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:46:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:46:23 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-fuv96WqiJw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71416&action=edit Bug 20144: [sql_modes] Set default value for aqbasket.is_standing Fix for: Column 'is_standing' cannot be null t/db_dependent/Koha/Acquisition/Booksellers.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:49:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:49:42 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-varm7I39yd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71417&action=edit Bug 20144: [sql_modes] Fix date format in tests Fix for: Incorrect date value: '01-01-2013' for column 'startdate' Incorrect date value: '01-01-2016' for column 'budget_period_enddate' Incorrect date value: '30-11-2013' for column 'enddate' Incorrect date value: '31-12-2015' for column 'budget_period_enddate' Incorrect date value: '12-31-2015' for column 'budget_period_enddate' Incorrect date value: '01-01-2014' for column 'entrydate' Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:55:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:55:41 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-2YK1CWMYKP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71418&action=edit Bug 20144: [sql_modes] Set missinglist and recievedlist in subscriptionhistory Fix for: Field 'missinglist' doesn't have a default value t/db_dependent/Koha/Acquisition/Booksellers.t from mysql doc: BLOB, TEXT, GEOMETRY, and JSON columns cannot be assigned a default value. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 10:57:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 09:57:47 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-oXFiwCVeFP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #22 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71419&action=edit Bug 20144: [sql_modes] Set auth_header.marcxml to an empty string in tests Fix for: Field 'marcxml' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:03:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:03:51 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-NRhNFkpXA2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #23 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71420&action=edit Bug 20144: [sql_modes] Shorten cities.city_zipcode It's a varchar(20) Fix for: Data too long for column 'city_zipcode' Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:08:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:08:56 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-ZxchtsPzuk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #24 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71421&action=edit Bug 20144: [sql_modes] Add default values for export_format columns Fix for: Field 'field_separator' doesn't have a default value Field 'encoding' doesn't have a default value field_separator and subfield_separator are only used for MARC csv profiles, no need to specify a default value Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:10:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:10:52 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-EyqKhzUlud@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #25 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71422&action=edit Bug 20144: [sql_modes] Correct quotes.timestamp values in tests Fix for: Incorrect datetime value: '0000-00-00 00:00:00' for column 'timestamp' t/db_dependent/Koha/GetDailyQuote.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:12:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:12:40 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-N9JdPlEkAw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #26 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71423&action=edit Bug 20144: [sql_modes] Shorten items.barcode It's a varchar(20) Fix for: Data too long for column 'barcode' t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:14:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:14:05 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-G3R9VTxruc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71424&action=edit Bug 20144: [sql_modes] Add a value for borrower_attribute_types.description in tests Fix for: Field 'description' doesn't have a default value t/db_dependent/Koha/Patron/Attribute/Types.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:18:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:18:48 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-noWQjPe5sH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71425&action=edit Bug 20144: [sql_modes] Fix default value for statistics.itemnumber Must be an integer, not empty string Fix for: Incorrect integer value: '' for column 'itemnumber' Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:19:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:19:24 +0000 Subject: [Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent In-Reply-To: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20163-70-onYYaFSVIr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:19:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:19:27 +0000 Subject: [Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent In-Reply-To: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20163-70-BJTbN6R3HE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71357|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71426&action=edit Bug 20163: Position of NoLoginInstructions text is inconsistent This patch modifies the markup for two login forms, making the markup more consistent between them. The order of NoLoginInstructions, "Forgot your password?" and "Don't have an account?" should now be the same. This patch also updates some classes in each login form to allow for more consistent custom styling. A couple of capitalization corrections are included. To test, enable the PatronSelfRegistration and OpacResetPassword preferences. Put some text in the NoLoginInstructions preference. View the login form as associated links on the OPAC main page. Compare to the login form which appears in a modal window when you click the login link at the top of the page. The two areas should look consistent. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:22:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:22:03 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-X7kprFgjEb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #29 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71427&action=edit Bug 20144: [sql_modes] Set default value for Acccountline in TestBuilder Fix for: Data too long for column 'proccode' t/db_dependent/Accounts.t FIXME LATER - It's a varchar(4), must be integer! Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:25:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:25:48 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-7qsFhFWAZg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #30 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71428&action=edit Bug 20144: [sql_modes] Shorten aqbudgets.budget_code Fix for: Data too long for column 'budget_code' Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:28:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:28:55 +0000 Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers In-Reply-To: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19017-70-bMIrIK67qx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- You are right, the country-code is in the module. I am worried that different modules will be hard to maintain while containing a lot of duplicated code, at least for the European countries. I think better in Koha - but please check with Joubu for general approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:30:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:30:16 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-wHkZ7U1wY3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #31 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71429&action=edit Bug 20144: [sql_modes] Remove HAVING clause in GetLateOrders More attention needed here! Fix for: Non-grouping field 'quantity' is used in HAVING clause Having is useless, and certainly slower t/db_dependent/Acquisition.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:32:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:32:36 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-xuR1t5Rka2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71430&action=edit Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests Fix for: Field 'description' doesn't have a default value t/db_dependent/AdditionalField.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:37:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:37:15 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-7e1x18rcWx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #33 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71431&action=edit Bug 20144: [sql_modes] Set issuingrules.no_auto_renewal_after to NULL in tests Fix for: Incorrect integer value: '' for column 'no_auto_renewal_after' FIXME - must we update values for existing installs? TODO - check if can be set to an empty string from the interface Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:40:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:40:43 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-Sb7cY0v25u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #34 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71432&action=edit Bug 20144: [sql_modes] Remove HAVING clause in GetUpcomingDueIssues More attention needed here! Fix for: Non-grouping field 'days_until_due' is used in HAVING clause t/db_dependent/Circulation.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:43:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:43:21 +0000 Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does not populate itemtype descriptions correctly In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19671-70-nbV12YKjgx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:43:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:43:25 +0000 Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does not populate itemtype descriptions correctly In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19671-70-vhEg4FR5x2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69951|0 |1 is obsolete| | --- Comment #7 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71433&action=edit Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl To test: 1 - Run the circulation wizard with itemtypes as columns, shelving locations as rows - display on screen 2 - Note all itemtype values are blank 3 - Switch rows/columns - same issue 4 - Apply patch 5 - Re-run reports 6 - Itemtypes should display correctly Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:49:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:49:38 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-xAdwOYGxa0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #35 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71434&action=edit Bug 20144: [sql_modes] Set import_records.marcxml_old to '' on INSERT Fix for: Field 'marcxml_old' doesn't have a default value t/db_dependent/ImportBatch.t Fixme - need to update existing DB? Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:52:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:52:21 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-uaKHgLLVkk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #36 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71435&action=edit Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests When created without Koha::Biblio. Fix for: Field 'datecreated' doesn't have a default value t/db_dependent/Items.t TODO LATER - Use Koha::Biblio instead Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 11:54:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 10:54:29 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-xRW9TyJVWe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71422|0 |1 is obsolete| | --- Comment #37 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71436&action=edit Bug 20144: [sql_modes] Correct quotes.timestamp values in tests Fix for: Incorrect datetime value: '0000-00-00 00:00:00' for column 'timestamp' t/db_dependent/Koha.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:02:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:02:45 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-72UU13iIUJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #38 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71437&action=edit Bug 20144: [sql_modes] Fix GROUP BY clause in GetLetters This subroutine is wrong and must be rewritten using Koha::Notice::Templates. Mainly because the DB structure is bad. Meanwhile we remove the branchcode from the SELECT to get correct results, it was not used by callers anyway. Fix for: 'koha_kohadev.letter.module' isn't in GROUP BY t/db_dependent/Letters.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:06:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:06:42 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-qmi1YVr67m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #39 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71438&action=edit Bug 20144: [sql_modes] Set default value for marc_modification_template_actions Cannot be empty strings. Fix for: Data truncated for column 'conditional' Data truncated for column 'conditional_comparison' Incorrect integer value: '' for column 'conditional_regex' t/db_dependent/MarcModificationTemplates.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:08:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:08:35 +0000 Subject: [Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus. In-Reply-To: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20078-70-gAn59m7PsJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:08:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:08:37 +0000 Subject: [Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus. In-Reply-To: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20078-70-NTkWiIVaiT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71439&action=edit Bug 20078: Add accelerated reading indexes to getIndexes To test: 1 - Find a bib with 526$c and 526$d populated, or populate them e.g. 526$a 5.5 | 526$d 14 2 - Try searching for 'arl:5.5' or 'arp:14' 3 - Your record should be returned in results 4 - Add the indexes as dropdowns by entering the following in intranetuserjs: $(document).ready(function(){ // Add Accelerated Reading Level to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append('<option value="arl">Accelerated Reading Level</option>'); } // Add Accelerated Reading Point to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append('<option value="arp">Accelerated Reading Point</option>'); } }); 5 - Search using these in the dropdown, your record will not be found 6 - Apply patch 7 - Repeat searches directly and by using dropdown, your record should be returned. 8 - prove t/db_dependent/Search.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:10:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:10:33 +0000 Subject: [Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus. In-Reply-To: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20078-70-cokGIuLStc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:15:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:15:07 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-DlH7yXqIZS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #40 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71440&action=edit Bug 20144: [sql_modes] Remove HAVING clause in GetBorrowersToExpunge Special attention needed here! Fix for: Non-grouping field 'currentissue' is used in HAVING clause t/db_dependent/Members.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:16:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:16:33 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-XD6A9I9Sln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71430|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71441&action=edit Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests Fix for: Field 'description' doesn't have a default value t/db_dependent/Serials.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:23:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:23:16 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-yT6SdwkVix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71435|0 |1 is obsolete| | --- Comment #42 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71442&action=edit Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests Should call Koha::Biblio->new instead Fix for: Field 'datecreated' doesn't have a default value t/db_dependent/UsageStats.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:33:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:33:07 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-RbQnMpvQhp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71419|0 |1 is obsolete| | --- Comment #43 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71443&action=edit Bug 20144: [sql_modes] Set auth_header.marcxml to an empty string in tests Fix for: Field 'marcxml' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:35:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:35:46 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-7nkeCbvCeL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #44 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71444&action=edit Bug 20144: [sql_modes] Shorten auth_header.authtypecode values in tests Fix for: Data too long for column 'authtypecode' Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:37:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:37:19 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-Cy6w91GC3w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #45 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71445&action=edit Bug 20144: [sql_modes] Set correct value for old_issues.issue_id in tests Fix for: Column 'issue_id' cannot be null Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:39:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:39:50 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-gnc4TXnnJr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #46 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71446&action=edit Bug 20144: [sql_modes] Shorten values for virtualshelfshares.invitekey in tests It's a varchar(10) Fix for: Data too long for column 'invitekey' Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:54:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:54:39 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-SywvKn0E2n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #47 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71447&action=edit Bug 20144: [sql_modes] Add default value for export_basket.description in tests Fix for: Field 'description' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:57:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:57:40 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-LA4nztdagh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #48 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71448&action=edit Bug 20144: [sql_modes] Fix GROUP BY clause in GetBasketsInfosByBookseller This need to be tested from the interface! Fix for: 'koha_kohadev.aqbasket.basketname' isn't in GROUP BY t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t We need this group by. We should not need to list all fields, from mysql 5.7 doc: https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html "The query is valid if name is a primary key of t or is a unique NOT NULL column. In such cases, MySQL recognizes that the selected column is functionally dependent on a grouping column. " However, MariaDB did not implemented yet: https://jira.mariadb.org/browse/MDEV-11588 Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 12:59:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 11:59:35 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-EXvAZZVAnq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #49 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71449&action=edit Bug 20144: [sql_modes] Fix GROUP BY clause in GetInvoices Need to be tested from the interface! Fix for: 'koha_kohadev.aqinvoices.invoicenumber' isn't in GROUP BY Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:02:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:02:29 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-8ZvhrPQBUy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #50 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71450&action=edit Bug 20144: [sql_modes] Set default value for Itemtype fees in TestBuilder Fix for: Out of range value for column 'amount' t/db_dependent/Circulation/Chargelostitem.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:05:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:05:35 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-HJswuS4VxH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #51 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71451&action=edit Bug 20144: [sql_modes] Remove 'Null' string values from GetHardDueDate.t Must be undef or correct integer value Fix for: Incorrect integer value: 'Null' for column 'enrolmentperiod' Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:11:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:11:07 +0000 Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers In-Reply-To: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19017-70-tt65Lvmuls@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at joensuu.fi --- Comment #14 from paxed <pasi.kallinen at joensuu.fi> --- Like Katrin, I'm also worried about having numbers from different countries. Couldn't this functionality basically be done with a phone number validator written in javascript and hooked on to the borrower edit/add form inputs? And for checking the phone numbers in the database, a simple report could be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:13:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:13:44 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-1Z38vqLTZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Hiya, The patch has fixed the error message. However, in the OPAC advanced search under the Item type tab, there is a checkbox for my new ITEMTYPECAT but no description (label) is displayed. If I select only the new category checkbox to perform a search (no keywords etc), nothing happens and the advanced search page refreshes. If I check the new category and also another itype category (eg: music) with no keywords, then search results are displayed as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:29:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:29:38 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-Yoml5ZwAQu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #52 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71452&action=edit Bug 20144: [sql_modes] Remove HAVING clause from GetTopIssues Fix for: 'koha_kohadev.b.title' isn't in GROUP BY t/db_dependent/Circulation/GetTopIssues.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:32:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:32:45 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-tRN4ETR5vT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #53 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71453&action=edit Bug 20144: [sql_modes] Set value for pending_offline_operations.timestamp Not null Fix for: Incorrect datetime value: 'null' for column 'timestamp' Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:35:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:35:31 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-KS0tVQaUuI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71442|0 |1 is obsolete| | --- Comment #54 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71454&action=edit Bug 20144: [sql_modes] Set default value for biblio.datecreated in tests Fix for: Field 'datecreated' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:37:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:37:47 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-fLnazFbY8D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #55 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71455&action=edit Bug 20144: [sql_modes] Set value for creator_batches.timestamp Fix for: Incorrect datetime value: 'now()' for column 'timestamp' Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:40:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:40:26 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-WAHLAUZYz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #56 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71456&action=edit Bug 20144: [sql_modes] Remove useless ORDER BY clauses in tests Fix for: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:44:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:44:22 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-aopUugdrDA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #57 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71457&action=edit Bug 20144: [sql_modes] Remove ORDER BY clause for COUNT(*) in GetItemsForInventory Fix for: DBD::mysql::st execute failed: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause [for Statement 'SELECT COUNT(*) Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:46:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:46:36 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-nwBsQOGfed@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #58 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71458&action=edit Bug 20144: [sql_modes] Set default value for opac_news.content in tests Fix for: Field 'content' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:48:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:48:41 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-O5PqQdFJSX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #59 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71459&action=edit Bug 20144: [sql_modes] Fix values when creating a sql report in tests For fix: Data too long for column 'report_area' Incorrect integer value: 'null' for column 'cache_expiry' Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:51:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:51:24 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-k1GjppuhVt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #60 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71460&action=edit Bug 20144: [sql_modes] Fix search history tests Incorrect datetime value: '1374978877' for column 'time' Need to investigate this: Why did I put that value in the test? Does the feature correctly works? Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:53:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:53:31 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-GgA6UT1cuh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71441|0 |1 is obsolete| | --- Comment #61 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71461&action=edit Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests Fix for: Field 'description' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:56:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:56:28 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-KhRK7Z4bXh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #62 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71462&action=edit Bug 20144: [sql_modes] Set subscription.numberlength and weeklength to NULL if not passed Fix for: Incorrect integer value: '' for column 'numberlength' Incorrect integer value: '' for column 'weeklength' t/db_dependent/Serials/ReNewSubscription.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 13:58:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 12:58:23 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-D5I59o4RCE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #63 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71463&action=edit Bug 20144: [sql_modes] Fix GROUP BY clause in Virtualshelves search (DT) Fix for: 'koha_kohadev.vs.shelfname' isn't in GROUP BY t/db_dependent/Utils/Datatables_Virtualshelves.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:07:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:07:56 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-rNYcTGy8R1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #64 from Julian Maurice <julian.maurice at biblibre.com> --- All attached patches are ready to be pushed. I will create other bug reports for the other patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:16:18 +0000 Subject: [Koha-bugs] [Bug 20175] New: Set a correct default value for club_enrollments.date_created Message-ID: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Bug ID: 20175 Summary: Set a correct default value for club_enrollments.date_created Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: julian.maurice at biblibre.com Blocks: 17258 This bug is a continuation of bug 20144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:16:18 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-vG1qL5jncn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 [Bug 20175] Set a correct default value for club_enrollments.date_created -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:16:18 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-PiJamFtaxt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20175 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:18:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:18:58 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20175-70-rEuh3w950F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71464&action=edit Bug 20175: [sql_modes] Set a correct default value for club_enrollments.date_created 0000-00-00 00:00:00 is not a valid timestamp. It will fix the installer and upgrade process Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:19:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:19:01 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20175-70-r2Jy3Ylg42@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71465&action=edit Bug 20175: [sql_modes] (follow-up) Set a correct default value for club_enrollments.date_created >From comment 6: """ Can't recreate database, when creating table structure, I got: there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE clause I am on mysql 5.5.59, which is still default in jessie, more timestamp columns are possible from mysql 5.6.5: https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html """ Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:19:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:19:53 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20175-70-8SQ8Ww3FQx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:19:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:19:58 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20175-70-bf4AnA0k9t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:23:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:23:42 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20175-70-mLfEz04BTe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Not sure about this one. Shouldn't date_created be set to "now" in Koha::Club::Enrollment->store ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:31:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:31:15 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20175-70-KzrEk5DE8y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It is set in svc/club/enroll 50 date_enrolled => \'NOW()', 51 date_created => \'NOW()', Which it weird and wrong. I considered it as out of the scope if there is no regression. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:33:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:33:24 +0000 Subject: [Koha-bugs] [Bug 20176] New: Set biblio.datecreated to NOW if not defined Message-ID: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176 Bug ID: 20176 Summary: Set biblio.datecreated to NOW if not defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: julian.maurice at biblibre.com Blocks: 17258 This bug is a continuation of bug 20144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:33:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:33:24 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-ejTJ7vEpud@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20176 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176 [Bug 20176] Set biblio.datecreated to NOW if not defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:33:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:33:24 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-CdPzNWYaG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20176 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:33:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:33:55 +0000 Subject: [Koha-bugs] [Bug 20173] Clean up koha-tmpl directory In-Reply-To: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20173-70-QZb2F74lY9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173 --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Katrin Fischer from comment #4) > Why do you think the favicon is not used? Because the templates only use the ones in the image subdirectories, not the koha-tmpl directory directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:34:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:34:44 +0000 Subject: [Koha-bugs] [Bug 20176] Set biblio.datecreated to NOW if not defined In-Reply-To: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20176-70-88MxucBEjj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71466&action=edit Bug 20176: [sql_modes] Set biblio.datecreated to NOW if not defined Fix at constructor level, this issue appears in lot of places. Fix for: Field 'datecreated' doesn't have a default value Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:34:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:34:59 +0000 Subject: [Koha-bugs] [Bug 20176] Set biblio.datecreated to NOW if not defined In-Reply-To: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20176-70-bnirTgBuua@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:35:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:35:04 +0000 Subject: [Koha-bugs] [Bug 20176] Set biblio.datecreated to NOW if not defined In-Reply-To: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20176-70-HsNQfS4ywH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:38:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:38:10 +0000 Subject: [Koha-bugs] [Bug 20176] Set biblio.datecreated to NOW if not defined In-Reply-To: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20176-70-Ms6ccj1LT6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- There are other places where the default values are enforced in 'store' subroutine (Koha::Patron::Category for example). Why does this patch enforce a default value in 'new' subroutine ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:42:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:42:18 +0000 Subject: [Koha-bugs] [Bug 13580] New: item circ history has 'last seen' labeled wrong Message-ID: <bug-13580-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13580 Bug ID: 13580 Summary: item circ history has 'last seen' labeled wrong Change sponsored?: --- Product: Koha Version: master Hardware: All URL: cgi-bin/koha/circ/bookcount.pl?&biblionumber=106124&bi =106124&itm=140197 OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: katrin.fischer at bsz-bw.de, sophie.meynieux at biblibre.com CC: katrin.fischer at bsz-bw.de CC: sophie.meynieux at biblibre.com On this page: cgi-bin/koha/circ/bookcount.pl?&biblionumber=106124&bi=106124&itm=140197 the 'last seen' column is actually the timestamp - not the date last seen so it's confusing. The label should be changed or the value should be changed. --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 13581 has been marked as a duplicate of this bug. *** --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, it's not quite the timestamp either. It looks like a calculated date on when the item was 'last seen' in this library. It uses the newest date and time from issues, old_issues and branchtransfers. Maybe 'last seen at library'? --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, it's not quite the timestamp either. It looks like a calculated date on when the item was 'last seen' in this library. It uses the newest date and time from issues, old_issues and branchtransfers. Maybe 'last seen at library'? --- Comment #4 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- The pb with this timestamp is that it is changed by anonymisation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:42:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:42:25 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-OISsrET7AL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #65 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71467&action=edit Bug 20144: [sql_modes] Do not store 0000-00-00 This patch needs to be linked with bug 20145. Fix for: Incorrect date value: '0000-00-00' for column 'dateexpiry' We cannot longer store 0000-00-00, but no need to. The tests must be kept for now as long as bug 20145 has a solution Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:43:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:43:53 +0000 Subject: [Koha-bugs] [Bug 13580] item circ history has 'last seen' labeled wrong In-Reply-To: <bug-13580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13580-70-6qH3z4cEgr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13580 --- Comment #5 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- What data do we really want to see there ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:45:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:45:20 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-TwMTjBj0ur@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 [Bug 20177] Remove GROUP BY clause in GetCourses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:45:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:45:20 +0000 Subject: [Koha-bugs] [Bug 20177] New: Remove GROUP BY clause in GetCourses Message-ID: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 Bug ID: 20177 Summary: Remove GROUP BY clause in GetCourses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: julian.maurice at biblibre.com Blocks: 17258 This bug is a continuation of bug 20144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:45:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:45:20 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-45t69k4WlZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20177 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:46:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:46:40 +0000 Subject: [Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses In-Reply-To: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20177-70-doLpEvZA8f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71468&action=edit Bug 20177: [sql_modes] Remove GROUP BY clause in GetCourses Fix for: 'koha_kohadev.courses.department' isn't in GROUP BY t/db_dependent/CourseReserves.t no need to group by here Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:46:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:46:53 +0000 Subject: [Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses In-Reply-To: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20177-70-ZJj4ikgXKE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:46:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:46:48 +0000 Subject: [Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses In-Reply-To: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20177-70-UzIqIQXPRi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:48:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:48:04 +0000 Subject: [Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses In-Reply-To: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20177-70-OLNOQkuqUg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- The GROUP BY is needed here. Otherwise you can see the same course multiple times in /cgi-bin/koha/course_reserves/course-reserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:48:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:48:44 +0000 Subject: [Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses In-Reply-To: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20177-70-kFTOm4GOEp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- But maybe the joins are useless ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:49:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:49:28 +0000 Subject: [Koha-bugs] [Bug 20178] New: Fix output_pref with dateformat=iso Message-ID: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Bug ID: 20178 Summary: Fix output_pref with dateformat=iso Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: julian.maurice at biblibre.com Blocks: 17258 This bug is a continuation of bug 20144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:49:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:49:28 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-363Tvxmazd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 [Bug 20178] Fix output_pref with dateformat=iso -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:49:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:49:28 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-aTlmEORVRw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20178 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:50:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:50:37 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-pX9Yco999o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:50:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:50:24 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-ksukyztCcb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71469&action=edit Bug 20178: [sql_modes] Fix output_pref with dateformat=iso Fix for: Incorrect date value: '2018-02-05 06:30 PM' for column 'entrydate' TODO - check other occurrences, put to a separate bug report Then `git grep output_pref|grep iso` and make sure no other calls are impacted. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:50:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:50:41 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-JcoL9p8ujc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:52:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:52:09 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-cIJHXzhb55@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- This patch makes t/DateUtils.t fail # Failed test 'iso output 12hr' # at t/DateUtils.t line 47. # got: '2011-06-16 12:00' # expected: '2011-06-16 12:00 PM' # Looks like you failed 1 test of 67. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:53:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:53:00 +0000 Subject: [Koha-bugs] [Bug 20179] New: Remove GROUP BY in get_shelves_containing_record Message-ID: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179 Bug ID: 20179 Summary: Remove GROUP BY in get_shelves_containing_record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: julian.maurice at biblibre.com Blocks: 17258 This bug is a continuation of bug 20144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:53:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:53:00 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-RTgrbLQD5O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179 [Bug 20179] Remove GROUP BY in get_shelves_containing_record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:53:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:53:00 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-YfRxQYvJos@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20179 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:53:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:53:53 +0000 Subject: [Koha-bugs] [Bug 20179] Remove GROUP BY in get_shelves_containing_record In-Reply-To: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20179-70-RaABoVJNks@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71470&action=edit Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Is that right? Fix for: 'koha_kohadev.me.shelfname' isn't in GROUP BY t/db_dependent/Virtualshelves.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:54:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:54:02 +0000 Subject: [Koha-bugs] [Bug 20179] Remove GROUP BY in get_shelves_containing_record In-Reply-To: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20179-70-8ZyYvSIhN8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:54:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:54:01 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-lhvtQacOL8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:54:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:54:04 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-BMJ9AITa83@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70551|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71471&action=edit Bug 19978: Fix ITEMTYPECAT behaviour ITEMTYPECAT permits to group and hide item types at the OPAC (see bug 10937 for a complete description). Since commit 091d6c513bcbee224ff06477e79be48cea7fe825 Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes the code assume that they are item types. Before it just assigned undef to the description. Test plan: Create ITEMTYPECAT authorised values Assign an item type to this authorised value group Search for a item using this item type at the OPAC Without this patch applied you get: Can't call method "translated_description" on an undefined value at /home/vagrant/kohaclone/opac/opac-search.pl line 231. With this patch applied the search result is displayed. Make sure the original feature still works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:54:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:54:07 +0000 Subject: [Koha-bugs] [Bug 20179] Remove GROUP BY in get_shelves_containing_record In-Reply-To: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20179-70-MrxlrFfceV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:55:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:55:05 +0000 Subject: [Koha-bugs] [Bug 20179] Remove GROUP BY in get_shelves_containing_record In-Reply-To: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20179-70-BVgUBJ7DZf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- If there are multiple virtualshelfshares, get_shelves_containing_record can return the same virtualshelf multiple times. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:58:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:58:53 +0000 Subject: [Koha-bugs] [Bug 20180] New: Remove GROUP BY clause in manage-marc-import.pl Message-ID: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Bug ID: 20180 Summary: Remove GROUP BY clause in manage-marc-import.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: julian.maurice at biblibre.com Blocks: 17258 This bug is a continuation of bug 20144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:58:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:58:53 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-VkHAuVSgnm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20180 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 14:58:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 13:58:53 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-UpHXJlTh89@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20180 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:00:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:00:04 +0000 Subject: [Koha-bugs] [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl In-Reply-To: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20180-70-3Wthji7zYD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71472&action=edit Bug 20180: [sql_modes] Remove GROUP BY clause in manage-marc-import.pl Fix for: 'koha_kohadev.me.frameworktext' isn't in GROUP BY t/db_dependent/www/search_utf8.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:00:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:00:22 +0000 Subject: [Koha-bugs] [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl In-Reply-To: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20180-70-BilDXkPeCv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:00:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:00:27 +0000 Subject: [Koha-bugs] [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl In-Reply-To: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20180-70-QeXkCYCT39@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:01:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:01:06 +0000 Subject: [Koha-bugs] [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl In-Reply-To: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20180-70-KXU3TVz2uX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- The GROUP BY is needed here, otherwise you have the same MARC framework displayed multiple times in the dropdown list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:01:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:01:55 +0000 Subject: [Koha-bugs] [Bug 20172] Add a search bar in list tables In-Reply-To: <bug-20172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20172-70-QTdJmUYPA0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20172 --- Comment #2 from Patrick Robitaille <patrick.robitaille at collecto.ca> --- Hi, Sorry for the sentence in french. What I meant, is that it would be nice to have a search box in the table of a list. This would make it possible to search within the records included in a list. Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:02:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:02:55 +0000 Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18975-70-3c5jsqR3RZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I do not have time to investigate more the other scripts, but this one patch can be tested yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:04:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:04:16 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-mNEEsChdeT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:04:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:04:19 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-YiF3JvKs4D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70056|0 |1 is obsolete| | --- Comment #8 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71473&action=edit Bug 19466: Check if cardnumber is mandatory Changes the appearance of the cardnumber entry field in memberentrygen.tt The "Leave empty for autocalc" message has been moved to the hint div under the input field. If AutoMemberNum and BorrowerMandatoryField interfere with each other, the auto calc hint is replace by a warning telling the user that auto calc has been disabled. Cardnumber should now correctly appear as mandatory if marked as such in BorrowerMandatoryField. Test plan: 0] Apply patch 1} Disable AutoMemberNum, remove cardnumber from BorrowerMandatoryField 2) Edit or create a patron, scroll down to cardnumber input field Hint is some form of "Cardnumber must be this long" Cardnumber input is not marked as required There is no mention of auto calc 3> Enable AutoMemberNum Hint includes "Leave empty for auto calc" message 4~ Add cardnumber to BorrowerMandatoryField Hint warns you that your sysprefs are conflicting. Cardnumber input is marked as required 5: Disable AutoMemberNum Hint is some form of "Cardnumber must be this long" Cardnumber input is marked as required Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:08:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:08:14 +0000 Subject: [Koha-bugs] [Bug 20181] New: Allow plugins to add css and javascript to OPAC Message-ID: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 Bug ID: 20181 Summary: Allow plugins to add css and javascript to OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org A number of Koha plugins have been written that enhance Koha's public catalog. These plugins often make due to adding css and javascript to the various opac system preferences. It would be nice if the plugin system had hooks so plugin developers could add code the the head block and the area where we include javascript in the opac template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:08:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:08:18 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-nze1k78TbO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:08:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:08:22 +0000 Subject: [Koha-bugs] [Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2 In-Reply-To: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19754-70-hP6totXUom@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69543|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71474&action=edit Bug 19754: Move template JavaScript to the footer: Acquisitions, part 2 This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Invoices - Datepickers - Search for invoices - Datatable - Acquisitions -> Late orders - Datepickers, datatables, selection controls (when searching by vendor) - Acquisitions -> Vendor -> Basket -> Add to basket -> From an existing record -> Search - Datatables, View MARC modal - Acquisitions -> Vendor -> Basket -> Add to basket -> From a new (empty) record - Form validation, inactive fund control, add users to notify on receiving. - Acquisitions -> Vendor -> Basket -> Add to basket -> From a subscription -> Search - Datatables, show only renewed, show/hide search form - Acquisitions -> Vendor -> Basket -> Add to basket -> From a suggestion - Datatables, "Show" controls - Acquisitions - "Ordered" link in table of funds - Datatables - Acquisitions -> Vendor -> Receive shipment -> Invoice -> Receive - Datepickers, item add form plugins (test with AcqCreateItem set to 'receiving an order.' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:21:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:21:20 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-dOMJzZClQb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 --- Comment #4 from Claire Gravely <claire_gravely at hotmail.com> --- Retested: I have two ITEMTYPECAT categories. Only one of them is showing a description in the OPAC Adv search. The other is still an empty checkbox. :( Searching by selecting only one (or both together) of my ITEMTYPECAT checkboxes is still not working. Selecting a 'Normal' itype (not in a category) performs a search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:29:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:29:38 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-tTyWvHHMtX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20182 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182 [Bug 20182] Remove group by clause in search_patrons_to_anonymise -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:29:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:29:39 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-6xRlk1WUWi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20182 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:29:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:29:38 +0000 Subject: [Koha-bugs] [Bug 20182] New: Remove group by clause in search_patrons_to_anonymise Message-ID: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182 Bug ID: 20182 Summary: Remove group by clause in search_patrons_to_anonymise Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: julian.maurice at biblibre.com Blocks: 17258 This bug is a continuation of bug 20144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:30:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:30:40 +0000 Subject: [Koha-bugs] [Bug 20182] Remove group by clause in search_patrons_to_anonymise In-Reply-To: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20182-70-8dvWtgkdOk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71475&action=edit Bug 20182: [sql_modes] Remove group by clause in search_patrons_to_anonymise Not trivial, more attention needed on this one! Fix for: 'koha_kohadev.me.cardnumber' isn't in GROUP BY Looks like the query is complexified, perf tests needed, see bug 19599. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:33:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:33:43 +0000 Subject: [Koha-bugs] [Bug 20182] Remove group by clause in search_patrons_to_anonymise In-Reply-To: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20182-70-QbRDjRsvEO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:33:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:33:49 +0000 Subject: [Koha-bugs] [Bug 20182] Remove group by clause in search_patrons_to_anonymise In-Reply-To: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20182-70-q4CWmBtp0L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:35:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:35:52 +0000 Subject: [Koha-bugs] [Bug 20182] Remove group by clause in search_patrons_to_anonymise In-Reply-To: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20182-70-fsHIDLKlzy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182 --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- perl -MKoha::Patrons -E 'my $patrons = Koha::Patrons->search_patrons_to_anonymise; $patrons->next' generated the following SQL query: SELECT `me`.`borrowernumber`, `me`.`cardnumber`, `me`.`surname`, `me`.`firstname`, `me`.`title`, `me`.`othernames`, `me`.`initials`, `me`.`streetnumber`, `me`.`streettype`, `me`.`address`, `me`.`address2`, `me`.`city`, `me`.`state`, `me`.`zipcode`, `me`.`country`, `me`.`email`, `me`.`phone`, `me`.`mobile`, `me`.`fax`, `me`.`emailpro`, `me`.`phonepro`, `me`.`B_streetnumber`, `me`.`B_streettype`, `me`.`B_address`, `me`.`B_address2`, `me`.`B_city`, `me`.`B_state`, `me`.`B_zipcode`, `me`.`B_country`, `me`.`B_email`, `me`.`B_phone`, `me`.`dateofbirth`, `me`.`branchcode`, `me`.`categorycode`, `me`.`dateenrolled`, `me`.`dateexpiry`, `me`.`date_renewed`, `me`.`gonenoaddress`, `me`.`lost`, `me`.`debarred`, `me`.`debarredcomment`, `me`.`contactname`, `me`.`contactfirstname`, `me`.`contacttitle`, `me`.`guarantorid`, `me`.`borrowernotes`, `me`.`relationship`, `me`.`sex`, `me`.`password`, `me`.`flags`, `me`.`userid`, `me`.`opacnote`, `me`.`contactnote`, `me`.`sort1`, `me`.`sort2`, `me`.`altcontactfirstname`, `me`.`altcontactsurname`, `me`.`altcontactaddress1`, `me`.`altcontactaddress2`, `me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`, `me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`, `me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_checkouts`, `me`.`checkprevcheckout`, `me`.`updated_on`, `me`.`lastseen`, `me`.`lang`, `me`.`login_attempts`, `me`.`overdrive_auth_token` FROM `borrowers` `me` LEFT JOIN `old_issues` `old_issues` ON `old_issues`.`borrowernumber` = `me`.`borrowernumber` WHERE ( ( `old_issues`.`borrowernumber` IS NOT NULL AND `privacy` <> '0' AND `returndate` < '2018-02-12 15:32:29' ) ) GROUP BY `me`.`borrowernumber`, `me`.`cardnumber`, `me`.`surname`, `me`.`firstname`, `me`.`title`, `me`.`othernames`, `me`.`initials`, `me`.`streetnumber`, `me`.`streettype`, `me`.`address`, `me`.`address2`, `me`.`city`, `me`.`state`, `me`.`zipcode`, `me`.`country`, `me`.`email`, `me`.`phone`, `me`.`mobile`, `me`.`fax`, `me`.`emailpro`, `me`.`phonepro`, `me`.`B_streetnumber`, `me`.`B_streettype`, `me`.`B_address`, `me`.`B_address2`, `me`.`B_city`, `me`.`B_state`, `me`.`B_zipcode`, `me`.`B_country`, `me`.`B_email`, `me`.`B_phone`, `me`.`dateofbirth`, `me`.`branchcode`, `me`.`categorycode`, `me`.`dateenrolled`, `me`.`dateexpiry`, `me`.`date_renewed`, `me`.`gonenoaddress`, `me`.`lost`, `me`.`debarred`, `me`.`debarredcomment`, `me`.`contactname`, `me`.`contactfirstname`, `me`.`contacttitle`, `me`.`guarantorid`, `me`.`borrowernotes`, `me`.`relationship`, `me`.`sex`, `me`.`password`, `me`.`flags`, `me`.`userid`, `me`.`opacnote`, `me`.`contactnote`, `me`.`sort1`, `me`.`sort2`, `me`.`altcontactfirstname`, `me`.`altcontactsurname`, `me`.`altcontactaddress1`, `me`.`altcontactaddress2`, `me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`, `me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`, `me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_checkouts`, `me`.`checkprevcheckout`, `me`.`updated_on`, `me`.`lastseen`, `me`.`lang`, `me`.`login_attempts`, `me`.`overdrive_auth_token` So it basically just added a GROUP BY with all columns. Can it affect performances ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:36:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:36:56 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-Q4HE0AavGk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71326|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71476&action=edit Bug 19755: Move template JavaScript to the footer: Acquisitions, part 3 This patch modifies even more staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Vendor -> Vendor details - Contracts datatable - Edit vendor - Add contacts, form validation - Acquisitions -> Vendor -> Invoices -> Invoice -> "Go to receipt" - Datatables, MARC and Card previews - Transfer - Confirmation of transfer, window closes - Acquisitions -> Vendor -> Receive shipments - Datatables, date pickers - Acquisitions -> Available funds table -> Spent report - Datatables - Acquisitions -> Vendor -> Uncertain prices - Datatables, form validation - Acquisitions -> Vendor -> Basket -> Add to basket from external source - Select and clear all on search form - Search results - Datatables, MARC and Card previews, in-table pop-up controls (click any table cell) Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:37:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:37:29 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-EfvR3YSKSu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:38:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:38:21 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20175-70-swL4Tt6DqM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71464|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71477&action=edit Bug 20175: [sql_modes] Set a correct default value for club_enrollments.date_created 0000-00-00 00:00:00 is not a valid timestamp. It will fix the installer and upgrade process Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:38:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:38:25 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20175-70-0RP77dVdgo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71465|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71478&action=edit Bug 20175: [sql_modes] (follow-up) Set a correct default value for club_enrollments.date_created >From comment 6: """ Can't recreate database, when creating table structure, I got: there can be only one TIMESTAMP column with CURRENT_TIMESTAMP in DEFAULT or ON UPDATE clause I am on mysql 5.5.59, which is still default in jessie, more timestamp columns are possible from mysql 5.6.5: https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html """ Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:38:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:38:33 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20175-70-86lhzkB9zk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:40:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:40:30 +0000 Subject: [Koha-bugs] [Bug 20005] Posibility to change the number of results shown by default in label creator In-Reply-To: <bug-20005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20005-70-R3Ljy7PIzp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20005 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:44:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:44:29 +0000 Subject: [Koha-bugs] [Bug 20135] Staff client language choose pop-up can appear off-screen In-Reply-To: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20135-70-GONRr2Eaal@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 15:44:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 14:44:32 +0000 Subject: [Koha-bugs] [Bug 20135] Staff client language choose pop-up can appear off-screen In-Reply-To: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20135-70-mnvMj2JuqY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71234|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71479&action=edit Bug 20135: Staff client language choose pop-up can appear off-screen This patch fixes a bug which was introduced by Bug 19851 ("Improve responsive layout handling of staff client menu bar."). The changes in that patch did not take into account the effects it would have on the language menus in the footer. This patch adds some additional classes to some menus and adds some CSS for those classes so that menus are correctly aligned left or right based on their position on the screen. To test, apply the patch and clear your cache if necessary. You should have multiple translations installed and enabled, at least one of which should have more than one "sub-language" (e.g. en-GB and en-US). In the staff client, test the appearance of various drop-down menus with the browser width above and below 800 pixels wide: - Search and More menus in the header - User/Library menu in the header - Language selection in the footer - Language selection in the header In all cases, menus should look correct and should not be aligned in such a way that they disappear off the left or right sides of the screen. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 16:04:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 15:04:48 +0000 Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18975-70-lO7Ib0Cpwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 16:04:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 15:04:51 +0000 Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18975-70-EbklluGOeW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70084|0 |1 is obsolete| | --- Comment #6 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71480&action=edit Bug 18975: Retrieve up-to-date CGISESSID when just logged in If a user is asked to login before sending a card, the wrong (old) CGISESSID cookie is used. We need to retrieve the one that has just been created. This will certainly need more work, I guess other scripts are affected too. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 16:08:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 15:08:16 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-u138NWukCP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 16:08:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 15:08:18 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-AkX2RwfPPw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71481&action=edit Bug 20181: Allow plugins to add css and javascript to OPAC A number of Koha plugins have been written that enhance Koha's public catalog. These plugins often make due to adding css and javascript to the various opac system preferences. It would be nice if the plugin system had hooks so plugin developers could add code the the head block and the area where we include javascript in the opac template. Test Plan: 1) Apply this patch 2) Download and install the Kitchen Sink plugin ( v2.1.12 or later ) https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.12/koha-plugin-kitchen-sink-v2.1.12.kpz 3) Install the plugin 4) Restart all the things if you can ( restart_all if you are using kohadevbox ) This will ensure the plugin takes effect right away, it should be necessary but it won't hurt anything! 5) Load the opac, notice you get an alert message and the background for your opac is now orange ( assuming you've not customized the opac in any way ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 16:41:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 15:41:00 +0000 Subject: [Koha-bugs] [Bug 20183] New: Posibility to change the number of results shown by default in authorities Message-ID: <bug-20183-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20183 Bug ID: 20183 Summary: Posibility to change the number of results shown by default in authorities Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, In the authorities module, by default it show only the 20 first results. It will be great if we could choose the numbers of results shown by default for tables. It could be a systeme preference like numSearchRSSResults. Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 16:53:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 15:53:19 +0000 Subject: [Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator In-Reply-To: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19959-70-8wVcOE68PH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70714|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71482&action=edit Bug 19959: Update popup window templates to use Bootstrap grid: Label creator This patch updates two label creator templates to use the Bootstrap grid instead of the YUI grid. To test, apply the patch and go to Label creator -> Manage -> Label batches. - Create a new or open an existing label batch. - Click "Add items." - The resulting pop-up window should look correct. - Perform a search - The search results screen should look correct. Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 16:53:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 15:53:42 +0000 Subject: [Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator In-Reply-To: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19959-70-i3RSiMQtqe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:15:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:15:58 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-HGB9B9oWie@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71483&action=edit Bug 20181 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:17:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:17:30 +0000 Subject: [Koha-bugs] [Bug 20172] Add a search bar in list tables In-Reply-To: <bug-20172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20172-70-21X0qyz0UW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20172 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Note that the table in circ/overdue.pl contains all results which are then organized into "pages" by the DataTables plugin. That's why the table controls at the top can include a search box. The table of titles on a list is paged server-side, so a DataTables search wouldn't be useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:17:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:17:41 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-C0WzTpIbsq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:18:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:18:13 +0000 Subject: [Koha-bugs] [Bug 20171] Item search should honor syspref 'delimiter' In-Reply-To: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20171-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20171-70-K51L40fnX0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Keywords| |Academy Assignee|victor.grousset at biblibre.co |oleonard at myacpl.org |m | Patch complexity|--- |Trivial patch --- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Sorry, won't have the time to work on this (there will be always more problematic stuff for me to fix). But it's a reasonably low hanging fruit/beginner friendly bug and I'll be glad to provide advice if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:26:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:26:36 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19709-70-w75wf52KUK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- I'm going to put this back to "needs signoff" in hopes that getting some more testers might shed some light on why it works fine for me but not Claire. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:34:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:34:04 +0000 Subject: [Koha-bugs] [Bug 18775] The "Password Reset" notice should use the patron's homebranch's email as "from" address In-Reply-To: <bug-18775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18775-70-234qenlQ8C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #10 from Owen Leonard <oleonard at myacpl.org> --- VikDC: This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:36:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:36:31 +0000 Subject: [Koha-bugs] [Bug 813] OPAC lists should store comments In-Reply-To: <bug-813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-813-70-AQV3TmkpGM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=813 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|OPAC |Database -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:37:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:37:32 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-g7X7895lqJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Found a small issue. The last patch renamed the routine logout_required to logout_if_required, but misses to change the import: C4/Auth.pm: import C4::Auth_with_cas qw(check_api_auth_cas checkpw_cas login_cas logout_cas login_cas_url logout_required); We'll fix locally and continue testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:39:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:39:46 +0000 Subject: [Koha-bugs] [Bug 19748] 3M Cloud library integration In-Reply-To: <bug-19748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19748-70-rUd5y40t1X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19748 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:40:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:40:32 +0000 Subject: [Koha-bugs] [Bug 16181] Limit number of tags loaded initially for tag cloud In-Reply-To: <bug-16181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16181-70-YETKv4suqM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16181 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:46:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:46:11 +0000 Subject: [Koha-bugs] [Bug 20184] New: Posibility to add a box to enter a specific page number in authorities result search. Message-ID: <bug-20184-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20184 Bug ID: 20184 Summary: Posibility to add a box to enter a specific page number in authorities result search. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, It would be a nice addition if in the results page of an authorities search to add a box to enter a specific page number. It could be a box at the top of the search results table where you could enter the page number of your search. This addition would help to search more efficiently the authorities of the local bank. Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:51:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:51:08 +0000 Subject: [Koha-bugs] [Bug 18515] Use news based help system for OPAC In-Reply-To: <bug-18515-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18515-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18515-70-8xP9fYNviA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18515 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:57:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:57:25 +0000 Subject: [Koha-bugs] [Bug 20185] New: Some scripts does not pass perl -wc Message-ID: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Bug ID: 20185 Summary: Some scripts does not pass perl -wc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:58:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:58:11 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-wxNeypIyix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I guess it's the consequence of the push of patches related to bug 2505 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 17:58:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 16:58:42 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-z2gVNRf1fk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71484&action=edit Bug 20185: Remove warnings from aqplan.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:10:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:10:12 +0000 Subject: [Koha-bugs] [Bug 19511] Local cover images not centered in table column in staff client search results In-Reply-To: <bug-19511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19511-70-r6lqK5Tkse@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19511 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Summary|local cover images not |Local cover images not |centered in table on OPAC |centered in table column in | |staff client search results Version|unspecified |master Component|OPAC |Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:10:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:10:50 +0000 Subject: [Koha-bugs] [Bug 5594] Option to configure default sort order for items on bib records In-Reply-To: <bug-5594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5594-70-mre9pmed6Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:44:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:44:01 +0000 Subject: [Koha-bugs] [Bug 18815] OpenLibrarySearch is broken In-Reply-To: <bug-18815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18815-70-esT6j94h27@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18815 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:19 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-kVQFSkyImX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:29 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-TQgADIy2NS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71486&action=edit Bug 18789: Pass a Koha::Patron object from returns.pl This is a specific patch for returns.pl Test plan: Do some checkin for a patron and make sure the info are correctly displayed (and info from someone that has placed a hold on this item) Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:22 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-F0oW31WXxV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71301|0 |1 is obsolete| | Attachment #71302|0 |1 is obsolete| | Attachment #71303|0 |1 is obsolete| | Attachment #71304|0 |1 is obsolete| | Attachment #71305|0 |1 is obsolete| | Attachment #71306|0 |1 is obsolete| | Attachment #71307|0 |1 is obsolete| | Attachment #71308|0 |1 is obsolete| | Attachment #71309|0 |1 is obsolete| | Attachment #71310|0 |1 is obsolete| | Attachment #71311|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71485&action=edit Bug 18789: Send Koha::Patron object to the templates In order to simplify and make uniform the code, the controller scripts send a Koha::Patron object to the templates instead of all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. The variable "patron" sent to the templates is supposed to represent the patron the librarian is editing the detail. In the members module and some scripts of the circulation module, the patron's detail are sent one by one to the template. That leads to frustration from developpers (making sure everything is passed from all scripts) and to regression (we got tone of bugs in the last year because of this way to do). With this patch set it will be easy access patron's detail, passing only 1 variable from the controllers. Test plan: Play with the patron and circulation module and make sur the detail of the patron you are editing/seeing info are correctly displayed. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:32 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-SW8p07bIlW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71487&action=edit Bug 18789: Use Koha::Patron->image from the templates Now that we have the 'patron' variable in all our templates, we can call Koha::Patron->image and do the check from the templates. Test plan: On the different pages of the patron module, you should see the default image if there is no image attached or the one that has been attached (see pref patronimages) Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:34 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-P1hI5ppzZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71488&action=edit Bug 18789: add tests for is_adult and is_child This patch add 2 methods to the Koha::Patron module: is_adult and is_child. That way the business logic is at only one place and covered by tests. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:37 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-92bpJRWsBC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71489&action=edit Bug 18789: Use Koha::Patron->is_child where needed Test plan: When you are on a page related to a child you should see the "Update child to adult patron" button Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:40 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-kkhQPipTmJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71490&action=edit Bug 18789: Use Koha::Patron->is_adult where needed Test plan: When editing adult's info you must see the "Add child" button Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:42 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-uj1IVQIeeW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71491&action=edit Bug 18789: Remove useless IS_ADULT variable Test plan: git grep IS_ADULT must not return any results Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:48 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-PCyaNyK0Dw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71493&action=edit Bug 18789: Update other occurences where is->child should be used Trivial changes here, just do a code review on the QA step Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:45 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-9bDuYEgpOu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71492&action=edit Bug 18789: Remove adultborrower from the pay* scripts This flag is not used in the templates Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:51 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-mzVXcDN48k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71494&action=edit Bug 18789: (follow-up)Send Koha::Patron object to the templates Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:53 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-wBFAXLKIOr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71495&action=edit Bug 18789: (follow-up) Use Koha::Patron->image from the templates Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:54:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:54:56 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18789-70-E5lZPjDV6Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71496&action=edit Bug 18789: Fix number of unit tests Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 18:59:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 17:59:09 +0000 Subject: [Koha-bugs] [Bug 12290] Gracefully handle errors in datatables.js In-Reply-To: <bug-12290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12290-70-bKmp4x1t5p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12290 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- IE 8 is too old to support. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:00:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:00:57 +0000 Subject: [Koha-bugs] [Bug 11558] Collector bug for Academy bootstrap3 upgrading work - Not ready (not even close) for use yet In-Reply-To: <bug-11558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11558-70-ZtAfT05PoQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11558 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #53 from Owen Leonard <oleonard at myacpl.org> --- This has clearly been abandoned. Bug 20168 has taken its place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:04:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:04:46 +0000 Subject: [Koha-bugs] [Bug 8729] Browse results from OPAC detail page should allow paging through results In-Reply-To: <bug-8729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8729-70-FYj61VhBrN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8729 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:07:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:07:20 +0000 Subject: [Koha-bugs] [Bug 18056] Self registration generates error 500, and log file shows: End of script output before headers: opac-memberentry.pl In-Reply-To: <bug-18056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18056-70-janXwngWFk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18056 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- No new information for a year so I think this can be considered invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:07:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:07:48 +0000 Subject: [Koha-bugs] [Bug 18988] OPAC password not going by autoemailprimaryaddress preference In-Reply-To: <bug-18988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18988-70-bf3RNp8X4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18988 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:08:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:08:11 +0000 Subject: [Koha-bugs] [Bug 15500] Add FRBRized View to OPAC Results In-Reply-To: <bug-15500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15500-70-Tmyx7nMc5B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15500 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:15:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:15:02 +0000 Subject: [Koha-bugs] [Bug 13309] opac-search.pl Holds count incorrect In-Reply-To: <bug-13309-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13309-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13309-70-398oRS8wMg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13309 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:26:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:26:30 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-vVCscydME2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Claire Gravely from comment #4) > Retested: > > I have two ITEMTYPECAT categories. Only one of them is showing a description > in the OPAC Adv search. The other is still an empty checkbox. :( I guess you forgot to fill the OPAC description field. It should pick the staff value, but I would prefer to fix that minor bug somewhere else. > Searching by selecting only one (or both together) of my ITEMTYPECAT > checkboxes is still not working. Selecting a 'Normal' itype (not in a > category) performs a search. This sounds like it was a bug since the beginning. Fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:39:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:39:30 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-wbRxxuIaoD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71497&action=edit Bug 20185: Remove warnings from stats.print.pl This needs a full rewrite! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:47:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:47:20 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15707-70-ojzg3EiSKZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #226 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:47:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:47:27 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16735-70-8L44qSa3bG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #83 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:47:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:47:34 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-i9RXFyBWfB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:47:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:47:41 +0000 Subject: [Koha-bugs] [Bug 20133] "Hide patron information" feature should not affect all library groups In-Reply-To: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20133-70-BkvXQ1TnI2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:47:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:47:46 +0000 Subject: [Koha-bugs] [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality In-Reply-To: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20157-70-0icLGfRO9f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:50:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:50:00 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-uzyWjEXrV4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20178 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Related to bug 20178 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:50:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:50:00 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-oYbtfpOEt1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 19:58:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 18:58:55 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: <bug-13219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13219-70-tF8GFJbZ3H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #22 from Magnus Enger <magnus at libriotech.no> --- Looks like the patches here are getting quite old. Could we say this is a duplicate of Bug 17282? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:00:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:00:42 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-lmgFlFIoYh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sounds like there are no more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:06:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:06:41 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-xeAsUTHsMp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:06:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:06:45 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-xDBxHRvdVu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71498&action=edit Bug 20178: Fix test - iso formatted dates should not use timeformat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:07:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:07:45 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-QlGTcLvwDL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It seems that we must be the module instead. Kyle can you take a look at bug 20178 and tell me if the patch fixes your issue? *** This bug has been marked as a duplicate of bug 20178 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:07:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:07:45 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-ZjgKn7EqWx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 20008 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:12:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:12:55 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-a8f6caX30b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Indranil, the patch does not longer apply, can you rebase? It sounds like it would be better to regenerate it, I guess you wrote a small script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:13:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:13:42 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-XKzHbuDKSi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Indranil, the patch does not longer apply, can you rebase? It sounds like it would be better to regenerate it, I guess you wrote a small script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:14:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:14:59 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-1Z1y3ZsRHG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:15:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:15:10 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-h5TX22jijI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7) > Hi Indranil, the patch does not longer apply, can you rebase? > It sounds like it would be better to regenerate it, I guess you wrote a > small script? This comment was for bug 20053. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:15:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:15:57 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-j7De48ceRD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71027|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71499&action=edit Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: maksim <maksim at inlibro.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:33:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:33:14 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-sw26OCwUmA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71500&action=edit Bug 18403: Hide patron information if not part of the logged in user library group This patchset adds a new feature that will allow libraries inside a single Koha installation to restrict access to information of patrons that The group of libraries feature is introduced by bug 15707, see this bug for more information. Let's imagine that 2 groups G1 and G2 are defined and that they include 2 libraries each G1a, G1b and G2c, G2d: logged in users attached to G1a will only see patron's information from G1a and G1b. To add more flexibility, a new user permission named 'view_borrower_infos_from_any_libraries' will drive this behavior. If set, the patron will be able to see patron's information of any libraries. If the restriction is set, the logged in user will not be able to search, show, edit, delete patron's information of patrons attached to groups of libraries outside his own group. In situations we need to refer to a patron, for holds and checkouts for instance, and his information cannot be viewed, a text "A patron from library G1A" will be displayed. Considered unecessary or outside the scope of this bug report: * The report module is not affected by this feature for obvious reasons * The firstname and surname of guarantors, basket (acq) managers, patrons linked to orders are still displayed. * Log viewer: Can only be staff * patron list: you cannot add patrons from another group of librairies, but can see/delete from list (too much rewrite, or we can test for patron one by one?). * "Patron card creator" tool is not impacted by this feature. * Upload patron images is not impacted by this patch, should it be? * Tools: - Upload patrons - Clean borrowers tool (This can can done easily updating Koha::Patrons->search with Koha::Patrons->search_limited in search_upcoming_membership_expires and search_patrons_to_anonymise but we will need to move GetBorrowersToExpunge to Koha::Patrons first) We can discuss these different points but will be other bug reports not to add more complexity to this first patchset. Test plan: You will find a test plan in the following commit messages. Start by creating different group of libraries and patrons with and without the new permission. Open different browser sessions to ease the tests. Note that all patches have to be applied to test the different test plans. Technical notes: For QAers (and others) a techical note will be added to the commit messages of this patchset. I would recommend you to read them one by one to understand the different steps of this development. + Special attention should be payed to the REST api changes + Should we restrict the logged in user to libraries from his group when he wants to set his library (Home ? Circulation ? Set library)? Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:33:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:33:22 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-7gHdxkp0N5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71501&action=edit Bug 18403: Add new method Koha::Library->library_group This is more a follow-up for bug 15707. It could be moved on its own bug report if necessary. Test plan: prove t/db_dependent/LibraryGroups.t should return green Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:33:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:33:28 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-uoHCFgHcr9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #65 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71502&action=edit Bug 18403: Add new method Koha::Library::Group->has_child This is more a follow-up for bug 15707. It could be moved on its own bug report if necessary. IMPORTANT NOTE: At the moment the feature only works for 1 level depth, see bug 15707 comment 166+ for the discussion It means that if we have: root_group + groupA + groupA1 + groupA1_library2 + groupA_library1 + groupA2 + groupB + groupB_library1 groupA1_library2 is not considered a child of groupA1. Note that this can change. Test plan: prove t/db_dependent/LibraryGroups.t should return green Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:33:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:33:33 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-VRxsztByUQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #66 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71503&action=edit Bug 18403: Send logged_in_user to template from C4::Auth Technical note: To ease future changes we are passing a logged_in_user variable to templates. It contains the Koha::Patron object representing the logged in patron. This will be very useful for this patch and even after (for instance we will be able to replace easily loggedinusername and loggedinusernumber). Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:33:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:33:39 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-bTdtpzGoo4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #67 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71504&action=edit Bug 18403: Add new method Koha::Patron->can_see_patron_info Technical note: This is the method that will be called on the logged_in_user variable sent to the template. Moreover we will check that the logged in user can access patron' information when access to members/* and some circulation scripts will be done. Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:33:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:33:44 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-Yd4K5vblyA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #68 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71505&action=edit Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' Test plan: Login with a patron that only have the 'edit_borrowers' permission. You should be able to access patron's information of patrons inside of your group. Technical note: Before this patchset the borrowers permission module contains only 1 permission 'edit_borrowers'. That meant borrowers => 1 and borrowers => '*' had the same behavior. Moreover, now that we have 2 permissions, 'CAN_user_borrowers' is set when all permissions of 'borrowers' are set. We need to update the different occurrences of these tests. Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:33:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:33:51 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-ghTJFW4b68@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #69 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71506&action=edit Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos Test plan: Login with a patron that is not allowed to see patron's information for patrons outside of his group. Try to access patron's information from scripts of the patron module (members/*) and circ/circulation.pl. You should be able to access patron's information of patrons outside of your group and get "You are not allowed to see the information of this patron." If you try and access a patron page with a borrowernumber that does not exist, you should get "This patron does not exist" Technical note: A new C4::Output subroutine is created in this patch: "output_and_exit_if_error" Executed at the beginning of the script it will permit not to copy/paste all the different checks to know if the logged in user is authorised to see patron's information. The design here can be discussed, but I did not find an alternative with as less changes. On the way I refactor what we did with 'unknowuser' previously: it will now work with all patron pages, not only the few that used it. Note that the 'or die "Not logged in";' part should not be needed, but... who trusts C4::Auth? I think it could be used as a safeguard later. I am willing to sed and remove them if required. Changes in discharge.pl are mainly indentation changes. With this patch we should now have a $patron variable that refer to the patron we want to access. That will be very useful to remove plenty of code in members/* and only pass this variable to the template (instead of 1 variable per patron's attribute). Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:33:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:33:56 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-0vZtey3TSd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #70 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71507&action=edit Bug 18403: Adapt patron search This patch modifies the patron search code to limit the libraries to the ones the logged in user is allowed to access Test plan: Search for patrons You should not see patrons you are not allowed to see. Technical note: I am really glad to have refactored all the patron searches before having to write this patch. It tooks me ~40 l to acchieve this job and affect all patron searches. Thanks refactoring! Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:01 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-NF5blh0ip0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #71 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71508&action=edit Bug 18403: Only display libraries from group in dropdown lists >From where patrons it's about patrons, we do not want to display the libraries from all the system, but only the ones from the group. Test plan: - See the overdues (circ/overdue.pl) and make sure you can only see overdues from patrons part of your group (do not forget to test the CSV export). - Search for patrons, the 'library' filters (headers and left side) should only display libraries from your group - Search for article request by patron's library: only the libraries from your group should be displayed Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:06 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-nULnBeXofv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #72 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71509&action=edit Bug 18403: Use patron-title.inc when hidepatronname is used There is already a HidePatronName syspref to hide patron's information on bibliographic record detail pages and the hold list. Test plan: With the HidePatronName enabled, make sure the patron's information are hidden from the catalogue and hold list pages. If the logged in user is not allowed to see the patron's info, no link and no cardnumber will be displayed With he HidePatronName disabled, make sure the patron's information are displayed if the logged in user is allowed to see the patron's info. Technical note: This patch improves the existing patron-title.inc include file to display patron's information. Using it everywhere patron's details are displayed will permit to homogenise the way they are displayed. The file takes now a patron object (what should be, in the future, the only way to use it), that way we can call the new method on it to know if patron's information can be shown by the logged in used. NOTE: I am not sure this syspref makes sense anymore. Should not we remove it? Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:11 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-b6tYMVqvHW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #73 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71510&action=edit Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] On this page we do not have the patron object sent to the template, let's pass it! Test plan: Go on the checkout history of a bibliographic record (catalogue/issuehistory.pl) You should not see patron's information that are not part of your group if you are not allowed to see them. Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:15 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-snYi7hf73w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #74 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71511&action=edit Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for view_holdsqueue] Same that the previous patch but for the holds queue Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:20 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-5ARsILGBtk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #75 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71512&action=edit Bug 18403: Batch patron modification tool Do not allow a logged in staff user to modify patrons that are not part of his group if he is not allowed. Test plan: Make sure you are not allowed to modify patrons that are not part of your group from the batch patron modification tool Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:24 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-ggNwNKmgW2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #76 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71513&action=edit Bug 18403: output_and_exit_if_error for circulation.pl This is a follow-up for a previous patch, changes have been tested already Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:28 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-zNlfdK1TUj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #77 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71514&action=edit Bug 18403: Add new methods Koha::Patrons->search_limited and use it where needed Most of the time when we search for patrons we do not want to search for all patrons, but just the ones the logged in user is allowed to see the information. This patch takes care of that by adding a new search_limited method to Koha::Patrons. When called this method only search for patrons that the logged in user is allowed to see. Test plan: Patron autocomplete search should be limited Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:33 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-pDBShM9kdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71515&action=edit Bug 18403: Refactor and add Koha::Patron->libraries_where_can_see_patrons Technical note: Here we are just refactoring a code that have been copied into 3 different places. libraries_where_can_see_patrons is a terrible method's name, feel free to suggest something better. The method return a list of branchcodes to be more efficient, instead of Koha::Libraries Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:37 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-fc8hxfUivD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #79 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71516&action=edit Bug 18403: Add tests for Koha::Patrons A bit late but here are the tests for Koha::Patron->libraries_where_can_see_patrons Koha::Patron->can_see_patron_infos Koha::Patron->search_limited Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:42 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-8INpIMXahL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #80 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71517&action=edit Bug 18403: Add new method Koha::Patron->can_see_patrons_from Technical note: Sometimes we do not have the patron object, for instance for the patron modifications we will need to know if the logged in user can modify patron's from a given library. This new subroutine 'can_see_patrons_from' will then be useful Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:48 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-gYy1NRJ0ZQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #81 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71518&action=edit Bug 18403: Patron modification requests Limit patron's modifications based on logged in patron permissions. Test plan: Create some patron's modification requests at the OPAC Make sure the logged in staff user see (or not) the modification depending his permissions. The number of modification displayed on the mainpage should be correct as well. Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:53 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-2SK0MuP32v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #82 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71519&action=edit Bug 18403: Patron reviews This patch adds a new method Koha::Reviews->search_limited to return the reviews a logged in user is allowed to see depending his permissions. Test plan: Create some reviews at the OPAC and make sure a staff user is limited (or not) to approve or decline it. The number of reviews displayed on the mainpage should be correct as well. Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:34:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:34:58 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-t1P306Z7lg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #83 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71520&action=edit Bug 18403: Patron discharges This patch deals with patron's discharges. Test plan: Same as previously you will need to request dischages at the OPAC. On the staff interface the logged in user should not be allowed to see discharge from patrons outside his library group. The number of discharges waiting displayed on the mainpage should be correct as well. Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Bug 18403: (follow-up) Patron discharges Fix QA issue: forbidden pattern: Do not assume male gender, use they/them instead (bug 18432) (line 150) Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:35:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:35:02 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-85v4R6hmOT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #84 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71521&action=edit Bug 18403: Article requests Same as previously but for article requests. Test plan: Test article requests and make sure you do not need the requests for patrons that are attached to a group that is not part of your library's group Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:35:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:35:07 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-D5Shu43SQY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #85 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71522&action=edit Bug 18403: Guarantors Technically a kid from your library group could have a guarantor attached to another group of library, let's deal with this case. Test plan: - Create a kid from your library group - With a superlibrarian staff user create a guarantor that is outside of the group of libraries of the kid - Login with a limited staff user and confirm that on the patron detail page you do not see the link to the guarantor detail page. Note that you see the firstname and surname of the guarantor Q. should it be hidden? Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:35:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:35:13 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-7OsUMiuntS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #86 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71523&action=edit Bug 18403: REST API - patrons endpoint There is something wrond here, the userenv is no set and so we cannot user search_limited. Should we set the userenv or filter on the libraries using libraries_where_can_see_patrons? WAITING FOR FEEDBACK HERE. Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:35:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:35:18 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-IGAh65RJUf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #87 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71524&action=edit Bug 18403: Deal with the DB user On first login, Koha explodes before the logged in user does not exist in DB. This patch deals with that by adding several checks when it's needed. Test plan: Use the DB user to create a superlibrarian user. The DB user should no be allowed to do anything else. Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Bug 18403: Fix patron creation memberentry.pl can be called to create a new patron, in that case the patron does not exist yet. Signed-off-by: Signed-off-by: Jon McGowan <jon.mcgowan at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:35:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:35:24 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-zo3legCrPP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #88 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71525&action=edit Bug 18403: Fix error triggered by subgroups being added to group With one root group and two child groups and it works fine. But if I create any groups under *those* groups, not only does it not work, I get the following error: Template process failed: undef error - SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before v1.75 used to generate incorrect SQL when the -IN operator was given an undef-containing list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based version of SQL::Abstract will emit the logically correct SQL instead of raising this exception) at /home/vagrant/kohaclone/Koha/Objects.pm line 269 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:35:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:35:29 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-4d2Bmfs0hG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71394|0 |1 is obsolete| | --- Comment #89 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71526&action=edit Bug 18403: Add POD for output_and_exit_if_error Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 20:35:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 19:35:34 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-Kk7Xo0Bf1p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #90 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71527&action=edit Bug 18403: Fix few errors found with hit_pages.t Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:04:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:04:23 +0000 Subject: [Koha-bugs] [Bug 19430] Can't receive serials from subscription detail page In-Reply-To: <bug-19430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19430-70-Yxj2fYKAcg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19430 acovaliov at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acovaliov at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:17:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:17:02 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-ngIKFOAvk0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19992 --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Jonathan Druart from comment #1) > I guess it's the consequence of the push of patches related to bug 2505 And people changing strict/warnings, or some combination thereof, into Modern::Perl, without checking? I did comment in a warning fashion on bug 20000 comment #2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:17:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:17:02 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19992-70-5HeFYVxVR6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20185 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:17:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:17:27 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20012-70-nY55ugEwbf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20185 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:17:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:17:27 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-LlVlmc7fVu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:18:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:18:50 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-1TbYSirLF9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #9 from Indranil Das Gupta <indradg at l2c2.co.in> --- I will get to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:22:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:22:09 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-hiudnGiXe7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- Running the following to confirm comment #4: for i in `find . -type f -name "*.p[lm]"`; do perl -wc $i; done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:22:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:22:12 +0000 Subject: [Koha-bugs] [Bug 20173] Clean up koha-tmpl directory In-Reply-To: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20173-70-eocVIBjG6V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Owen confirmed on IRC that the favicon.ico can go. Do we have an idea if the rest of the files is needed or why they were added in the first place? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:25:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:25:11 +0000 Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18975-70-bXVLuZ07uu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:30:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:30:33 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: <bug-13219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13219-70-e3NjStwaDu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 17282 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:30:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:30:33 +0000 Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports In-Reply-To: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17282-70-YWZrfF1JRf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 13219 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:31:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:31:30 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-lKuecUcTn0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |oleonard at myacpl.org --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #14) > @Nick: Does the last discussion in bug 19928 affects this one? > > See from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928#c29 I suppose it does if the buttons here seem too long too. Let me describe the issue here though: 1 - Staff member without access to system preferences uses a report to get some data to load back into koha (or another system) 2 - The click 'Download as CSV' and get a *.csv file 3 - They assume the file is actually comma separated 4 - They try to load the file into Koha (or another system) which wants actual commas in a csv 5 - Things don't work 6 - They don't know why 7 - :-( Now, if you open the file in libreoffice/excel/etc. you can fix the delimiters, but sometimes you lose leading zeros etc. And it is an extra step. I just want to make sure someone who can't see the pref understands what they are getting. It could be a tooltip and not on the button It could be a note under the button We could provide selection of delimiter at export and use the pref only to determine default. What would folks prefer? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:35:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:35:07 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: <bug-13219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13219-70-Llh5ZoHVql@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think there might still be some need for this as the other tool is for saved sql reports, but we should decide on one JavaScript library to include. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:36:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:36:57 +0000 Subject: [Koha-bugs] [Bug 13580] item circ history has 'last seen' labeled wrong In-Reply-To: <bug-13580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13580-70-lhdoU676ET@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13580 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe the datelastseen from items would work? I haven't verified, but if it's updated on checkout/checkin then that would work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:42:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:42:12 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-xZfNzOgeCC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #92 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71529&action=edit Bug 18403: Fix perlcritic on Koha::Patron Perl::Critic found these violations in "Koha/Patron.pm": "return" statement followed by "sort" at line 798, column 5. Behavior is undefined if called in scalar context. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:41:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:41:57 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-SoLwe7FMzY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #91 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71528&action=edit Bug 18403: rename Koha::Patron->can to has_permission I do not exactly why but there is a conflict in the name of the method prove t/db_dependent/api/v1/patrons.t failed with [Mon Feb 12 17:13:16 2018] [error] Can't use string ("TO_JSON") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Auth.pm line 2053. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:44:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:44:41 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-WsdyMo2vj0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 --- Comment #93 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71530&action=edit Bug 18403: Fix POD for C4::Output::output_and_exit_if_error xt/author/podcorrectness.t C4/Output.pm (310): Expected text after =item, not a bullet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:46:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:46:39 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-1wp62Ujp9e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- >It could be a tooltip and not on the button >It could be a note under the button >We could provide selection of delimiter at export and use the pref only to >determine default. I think of those suggestions none work really well with a menu type button like the one in the toolbar in reports. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:50:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:50:00 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4319-70-PagvWCsx3A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #84 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- As referred to on IRC by Jonathan: === Looking at bug 4319: We also have C4::Reserves::IsItemOnHoldAndFound that does exactly the same thing. So maybe "is_cancelable" is too specific? What could we do to keep this code simple, understandable and consistent? === I would personally not block this patch for that reason. We use IsItemOnHoldAndFound here to reduce yet more code to check the same; but this report is not about that sub. I would prefer to move the sub to Koha::Holds too, but that could well be done a its own report. If 4319 gets pushed and the other one follows, a new report can merge them. Just my thoughts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:55:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:55:30 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-6MMhIU47rw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- This patch has been pushed to 17.11.x and will be in 17.11.03. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:56:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:56:01 +0000 Subject: [Koha-bugs] [Bug 20088] Use of uninitialized value in array element in svc/holds In-Reply-To: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20088-70-HSlV0QimmV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20088 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:56:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:56:16 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-BiLVQQbPof@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:56:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:56:29 +0000 Subject: [Koha-bugs] [Bug 19827] checkuniquemember is exported from C4::Members but has been removed In-Reply-To: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19827-70-ATBjkJhcmm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:56:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:56:42 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-uKIPrL6t8m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thinking about it again... as this only changes the options in the menu, the button remains the same nice length. So this should be ok? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:56:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:56:43 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-oDZe45W9b9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:56:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:56:56 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-FbkQpadNoA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #20 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:57:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:57:16 +0000 Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course reserves In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19230-70-sYBAB3ricD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:57:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:57:31 +0000 Subject: [Koha-bugs] [Bug 20041] ILL module missing from more menu in staff when activated In-Reply-To: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20041-70-3bTKRmU8ID@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:57:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:57:57 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-NHWY9vxxIJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:57:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:57:43 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn't appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-6Bn4LmcWcl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 21:58:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 20:58:21 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-jWcKRul8Yq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:07:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:07:42 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-axSCy0HaX6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #401 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71531&action=edit Bug 7143: Update about page for new dev - Chad Billman -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:08:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:08:23 +0000 Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to new patron when a cardnumber is scanned during circulation In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15752-70-s4V8ZzCyea@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patches pushed to master for 18.05. Congratulations Chad for your first patch in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:08:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:08:53 +0000 Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from installer files In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19790-70-Yt9n59nAuD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:08:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:08:58 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-tfvfx9pFUt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:08:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:08:46 +0000 Subject: [Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present In-Reply-To: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19451-70-ZHUYjl7ngE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:09:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:09:05 +0000 Subject: [Koha-bugs] [Bug 20155] Improve readability of OPAC header language menu In-Reply-To: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20155-70-sphOgtSNAR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20155 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:09:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:09:10 +0000 Subject: [Koha-bugs] [Bug 20166] Untranslatable course reserves delete prompt In-Reply-To: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20166-70-ttyQcaacor@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20166 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:09:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:09:15 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20175-70-9h1fXMSb6r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:12:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:12:03 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-sQR1Us8e8e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #402 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #401) > Created attachment 71531 [details] [review] > Bug 7143: Update about page for new dev - Chad Billman Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:12:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:12:35 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-1Z9VSqsmJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:13:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:13:42 +0000 Subject: [Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present In-Reply-To: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19451-70-Kq1DIx5j9X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:22:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:22:46 +0000 Subject: [Koha-bugs] [Bug 8676] show vendor name in source of acquisition In-Reply-To: <bug-8676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8676-70-C9EkioSz53@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think the screenshot shows the table above the edit item form. I just checked there and the table still shows the number. But it also shows unformatted dates and has other display issues that are not in line with the rest of Koha. Also, the source of acquisition field is used for an id if you use acq, but also used in other ways by libraries not using acq (free text or AV value controlled). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:25:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:25:51 +0000 Subject: [Koha-bugs] [Bug 8571] Add search suggestions on the OPAC ("Did you mean?" feature) In-Reply-To: <bug-8571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8571-70-GgYVYkkiS5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this can be closed in favor or a more specific bug - looking at the code it seems very similar to the did you mean plugins. *** This bug has been marked as a duplicate of bug 8209 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:25:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:25:51 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-heixhMY8H9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcapovilla at live.ca --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 8571 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 12 22:26:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 21:26:32 +0000 Subject: [Koha-bugs] [Bug 8676] Show vendor name in source of acquisition In-Reply-To: <bug-8676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8676-70-9ovuMqJFEH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|show vendor name in source |Show vendor name in source |of acquisition |of acquisition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 00:14:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Feb 2018 23:14:19 +0000 Subject: [Koha-bugs] [Bug 20186] New: Problem printing batches Message-ID: <bug-20186-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20186 Bug ID: 20186 Summary: Problem printing batches Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: office at waimatemain.school.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I am finding it very hard to talk to someone about this ongoing problem. I am having trouble printing a batch (class) list. I work at a school. The older 2 classes are fine, so something must have changed to Koha whilst adding the newer students that prevents me from printing off a barcode list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 02:06:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 01:06:41 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-nP2PT9jbcO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #7 from M. Tompsett <mtompset at hotmail.com> --- After getting Catmandu stuff better installed, and hacking softlinks in the path to VerboseWarnings.pm and TmplTokenizer.pm, most problems go away. These two patches are fine. However, what about the horrors of files with multiple packages: C4/Barcodes.pm and OpenILS/QueryParser.pm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 02:07:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 01:07:51 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-u3092c65jc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #8 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 71484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71484 Bug 20185: Remove warnings from aqplan.pl Review of attachment 71484: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20185&attachment=71484) ----------------------------------------------------------------- ::: admin/aqplan.pl @@ +36,4 @@ > use C4::Debug; > use Koha::Acquisition::Currencies; > > +our $input = new CGI; If we are already tweaking the line, why not the new syntax? CGI->new? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 07:05:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 06:05:53 +0000 Subject: [Koha-bugs] [Bug 20186] Problem printing batches In-Reply-To: <bug-20186-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20186-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20186-70-XhdgVNHJ06@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20186 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Jo, can you please bring up your problem on the mailing list? Bugzilla is for reporting bugs and enhancement wishes but very few people read all the interactions here. Also: 3.22 is on longer supported and won't receive any bugfixes. But if you haven't updated, the issue is probably something else. Please include the steps on how you print a batch list - it's not clear to me which functionality in Koha you use for this, so hard to see where the problem is. How did you add the students? Manually or did you import them? What information doe you need on the list and where is it stored in the patron record? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 07:24:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 06:24:07 +0000 Subject: [Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent In-Reply-To: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20163-70-lNsdi3FO5e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 07:24:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 06:24:11 +0000 Subject: [Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent In-Reply-To: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20163-70-d179gqHSjR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71426|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71532&action=edit Bug 20163: Position of NoLoginInstructions text is inconsistent This patch modifies the markup for two login forms, making the markup more consistent between them. The order of NoLoginInstructions, "Forgot your password?" and "Don't have an account?" should now be the same. This patch also updates some classes in each login form to allow for more consistent custom styling. A couple of capitalization corrections are included. To test, enable the PatronSelfRegistration and OpacResetPassword preferences. Put some text in the NoLoginInstructions preference. View the login form as associated links on the OPAC main page. Compare to the login form which appears in a modal window when you click the login link at the top of the page. The two areas should look consistent. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 07:28:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 06:28:17 +0000 Subject: [Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent In-Reply-To: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20163-70-xZYVAw1oaq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Includes string changes! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 07:34:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 06:34:01 +0000 Subject: [Koha-bugs] [Bug 20135] Staff client language choose pop-up can appear off-screen In-Reply-To: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20135-70-4sQHEeEzDd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71479|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71533&action=edit Bug 20135: Prevent staff client language choose pop-up from appearing off-screen This patch fixes a bug which was introduced by Bug 19851 ("Improve responsive layout handling of staff client menu bar."). The changes in that patch did not take into account the effects it would have on the language menus in the footer. This patch adds some additional classes to some menus and adds some CSS for those classes so that menus are correctly aligned left or right based on their position on the screen. To test, apply the patch and clear your cache if necessary. You should have multiple translations installed and enabled, at least one of which should have more than one "sub-language" (e.g. en-GB and en-US). In the staff client, test the appearance of various drop-down menus with the browser width above and below 800 pixels wide: - Search and More menus in the header - User/Library menu in the header - Language selection in the footer - Language selection in the header In all cases, menus should look correct and should not be aligned in such a way that they disappear off the left or right sides of the screen. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 07:33:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 06:33:58 +0000 Subject: [Koha-bugs] [Bug 20135] Staff client language choose pop-up can appear off-screen In-Reply-To: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20135-70-r4VNngf4Nn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 07:56:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 06:56:48 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-HedKa2A0gp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 07:56:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 06:56:52 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-CMwoVsRFe6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71473|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71534&action=edit Bug 19466: Warn about conflicting settings of autoMemberNum and BorrowerMandatoryField for cardnumber Changes the appearance of the cardnumber entry field in memberentrygen.tt The "Leave empty for autocalc" message has been moved to the hint div under the input field. If AutoMemberNum and BorrowerMandatoryField interfere with each other, the auto calc hint is replace by a warning telling the user that auto calc has been disabled. Cardnumber should now correctly appear as mandatory if marked as such in BorrowerMandatoryField. Test plan: 0] Apply patch 1} Disable AutoMemberNum, remove cardnumber from BorrowerMandatoryField 2) Edit or create a patron, scroll down to cardnumber input field Hint is some form of "Cardnumber must be this long" Cardnumber input is not marked as required There is no mention of auto calc 3> Enable AutoMemberNum Hint includes "Leave empty for auto calc" message 4~ Add cardnumber to BorrowerMandatoryField Hint warns you that your sysprefs are conflicting. Cardnumber input is marked as required 5: Disable AutoMemberNum Hint is some form of "Cardnumber must be this long" Cardnumber input is marked as required Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 07:57:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 06:57:50 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-YCFNM4b3ps@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |katrin.fischer at bsz-bw.de Patch complexity|--- |Small patch --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Please remember that the commit message subject should describe what has been fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 07:57:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 06:57:57 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-Bc3hri4CDU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 08:09:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 07:09:58 +0000 Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does not populate itemtype descriptions correctly In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19671-70-qh5NYlIpJR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 08:10:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 07:10:01 +0000 Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does not populate itemtype descriptions correctly In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19671-70-k67iOYLmQL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71433|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71535&action=edit Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl To test: 1 - Run the circulation wizard with itemtypes as columns, shelving locations as rows - display on screen 2 - Note all itemtype values are blank 3 - Switch rows/columns - same issue 4 - Apply patch 5 - Re-run reports 6 - Itemtypes should display correctly Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 08:14:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 07:14:07 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-eHPB8kGHOt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #101 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It seems to break other functionality too, like the modal on translating itemtype descriptions: Loading failed for the <script> with source ?http://localhost:8081/intranet-tmpl/lib/greybox/gb_scripts.js?. Should we file a separate bug? This is quite a blocker and hinders testing of other functionalities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 08:30:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 07:30:06 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-979q43cvVK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 --- Comment #6 from Claire Gravely <claire_gravely at hotmail.com> --- (In reply to Jonathan Druart from comment #5) > (In reply to Claire Gravely from comment #4) > > Retested: > > > > I have two ITEMTYPECAT categories. Only one of them is showing a description > > in the OPAC Adv search. The other is still an empty checkbox. :( > > I guess you forgot to fill the OPAC description field. It should pick the > staff value, but I would prefer to fix that minor bug somewhere else. You are right, I had only added an OPAC description for one of the categories. > > > Searching by selecting only one (or both together) of my ITEMTYPECAT > > checkboxes is still not working. Selecting a 'Normal' itype (not in a > > category) performs a search. > > This sounds like it was a bug since the beginning. Fixed. When 'More options' are displayed in the adv. search the categories work correctly. It is still broken if 'More Options' hasn't been selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 12:22:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 11:22:15 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-dj4bMa36zh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71536&action=edit Bug 17374: (follow-up) update description of syspref DefaultPatronSearchFields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:20:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:20:07 +0000 Subject: [Koha-bugs] [Bug 20187] New: New rewrite rules can break custom css Message-ID: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Bug ID: 20187 Summary: New rewrite rules can break custom css Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha has the ability to include custom css in the apache configuration. If a library has any custom css ( or adds a custom js file in some way ), and that file has an underscore in it ( e.g. my_custom.css ), the apache rewrite rule will convert it to my.css and thus it will 404. We should make the rewrite rules as specific as possible for the format we are using. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:21:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:21:24 +0000 Subject: [Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system In-Reply-To: <bug-18483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18483-70-YU2lTBkWay@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:21:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:21:31 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-0jzm9QfEip@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:23:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:23:15 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-i8nHUDN3PH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |claire_gravely at hotmail.com --- Comment #10 from Claire Gravely <claire_gravely at hotmail.com> --- Hullo, when merging two authorities (merge.pl) I get: ReferenceError: _ is not defined merge.pl:54:9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:24:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:24:01 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-MOVTFWD3zM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:24:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:24:04 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-OlxFiBx2E0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71537&action=edit Bug 20187: New rewrite rules can break custom css Koha has the ability to include custom css in the apache configuration. If a library has any custom css ( or adds a custom js file in some way ), and that file has an underscore in it ( e.g. my_custom.css ), the apache rewrite rule will convert it to my.css and thus it will 404. We should make the rewrite rules as specific as possible for the format we are using. Test Plan: 1) Set OPAC_CSS_OVERRIDE to a file with an underscore in it 2) Note it does not work 3) Apply this patch 4) Update the apache rewrite rules to match those in the patch For kohadevbox, just run /home/vagrant/misc4dev/cp_debian_files.pl 5) Restart apache 6) Reload the page, your custom css should load now! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:24:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:24:13 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-V9ILR2D7ot@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12904 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 [Bug 12904] Force browser to load new javascript files after upgrade -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:24:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:24:13 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-D1adxb0odZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 [Bug 20187] New rewrite rules can break custom css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:25:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:25:49 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-N07Vvaanwa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:40:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:40:13 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-r2YudHutdW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #102 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #101) > It seems to break other functionality too, like the modal on translating > itemtype descriptions: Loading failed for the <script> with source > ?http://localhost:8081/intranet-tmpl/lib/greybox/gb_scripts.js?. > > Should we file a separate bug? This is quite a blocker and hinders testing > of other functionalities. I confirm this is fixed by bug 20187. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:42:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:42:42 +0000 Subject: [Koha-bugs] [Bug 20188] New: New rewrite rules break web installer Message-ID: <bug-20188-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20188 Bug ID: 20188 Summary: New rewrite rules break web installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 12904 KOHA_VERSION is not passed to templates, so all JS and CSS urls are wrong. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 [Bug 12904] Force browser to load new javascript files after upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:42:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:42:42 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-Ixg5HWq4Hq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20188 [Bug 20188] New rewrite rules break web installer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:44:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:44:20 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-hDqzRsIJiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #103 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #98) > <Joubu> [N,L]? > <tcohen> it looks like L shouldn't be there? or N? > <tcohen> L = Last > <tcohen> N = Next > <tcohen> using N is very tricky N,L is wrong imo N would give other rules a chance to make further rewrites looks to me that normally L would be fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:46:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:46:44 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-XCBH25bM2A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71537|0 |1 is obsolete| | --- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 71538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71538&action=edit Bug 20187: New rewrite rules can break custom css Koha has the ability to include custom css in the apache configuration. If a library has any custom css ( or adds a custom js file in some way ), and that file has an underscore in it ( e.g. my_custom.css ), the apache rewrite rule will convert it to my.css and thus it will 404. We should make the rewrite rules as specific as possible for the format we are using. Test Plan: 1) Set OPAC_CSS_OVERRIDE to a file with an underscore in it 2) Note it does not work 3) Apply this patch 4) Update the apache rewrite rules to match those in the patch For kohadevbox, just run /home/vagrant/misc4dev/cp_debian_files.pl 5) Restart apache 6) Reload the page, your custom css should load now! Signed-off-by: Victor Grousset <victor.grousset at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:47:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:47:01 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-IY2TjnuP8m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 14:52:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 13:52:46 +0000 Subject: [Koha-bugs] [Bug 20188] New rewrite rules break web installer In-Reply-To: <bug-20188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20188-70-lKiFX28lJF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20188 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|ASSIGNED |RESOLVED Severity|major |minor --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- It seems I've been too quick to open this bug report, the rewrite rules work even when KOHA_VERSION is empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:07:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:07:17 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19709-70-thZB2RWigo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:08:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:08:28 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-OKspTvvtaa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Claire, I do not recreate. I am not willing to fix all the issues this feature has (from when it has been written) anyway :) The goal here is to fix regressions with previous versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:12:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:12:17 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-WG5kgRceOc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to M. Tompsett from comment #6) > Running the following to confirm comment #4: > for i in `find . -type f -name "*.p[lm]"`; do perl -wc $i; done or simply `find . -name "*.pl" -exec perl -wc {} \;` yes. (In reply to M. Tompsett from comment #7) > After getting Catmandu stuff better installed, and hacking softlinks in the > path to VerboseWarnings.pm and TmplTokenizer.pm, most problems go away. > These two patches are fine. However, what about the horrors of files with > multiple packages: C4/Barcodes.pm and OpenILS/QueryParser.pm? The rewrite of these modules is for somewhere else (and somebody else :)) (In reply to M. Tompsett from comment #8) > If we are already tweaking the line, why not the new syntax? CGI->new? Feel free to open a bug report to replace all the occurrence of "new CGI" if you think it is useful/major. The variable scoping problem is critical under plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:16:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:16:57 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-Id42ixDBNu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 --- Comment #8 from Claire Gravely <claire_gravely at hotmail.com> --- (In reply to Jonathan Druart from comment #7) > Claire, I do not recreate. > I am not willing to fix all the issues this feature has (from when it has > been written) anyway :) > The goal here is to fix regressions with previous versions. OK I'll sign off as is and see if there is a bug report for the other issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:18:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:18:19 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-NjxPbXmTpm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:18:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:18:21 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-KZxS29RqPF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71471|0 |1 is obsolete| | --- Comment #9 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71539&action=edit Bug 19978: Fix ITEMTYPECAT behaviour ITEMTYPECAT permits to group and hide item types at the OPAC (see bug 10937 for a complete description). Since commit 091d6c513bcbee224ff06477e79be48cea7fe825 Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes the code assume that they are item types. Before it just assigned undef to the description. Test plan: Create ITEMTYPECAT authorised values Assign an item type to this authorised value group Search for a item using this item type at the OPAC Without this patch applied you get: Can't call method "translated_description" on an undefined value at /home/vagrant/kohaclone/opac/opac-search.pl line 231. With this patch applied the search result is displayed. Make sure the original feature still works. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:26:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:26:15 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-2rVYxQYjfw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Intranet login fails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:30:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:30:54 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-JPZqlNpQYX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 --- Comment #4 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Intranet login works for me, do you have more details? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:32:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:32:47 +0000 Subject: [Koha-bugs] [Bug 20026] Add new permission related to personal data In-Reply-To: <bug-20026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20026-70-eLeersZ8ZQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20026 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:34:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:34:43 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: <bug-20028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20028-70-cqye2rFAQP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:35:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:35:20 +0000 Subject: [Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu In-Reply-To: <bug-19939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19939-70-uOH3ubIPxY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:35:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:35:23 +0000 Subject: [Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu In-Reply-To: <bug-19939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19939-70-X1rabmO2oU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70393|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71540&action=edit Bug 19939 - Move cataloging Z39.50 results actions into menu This patch modifies the template which displays cataloging Z39.50 search results so that the "MARC," "Card," and "Import" links are moved out of separate table cells and into one menu. The old menu which would appear when any table cell is clicked has been removed, and code added to display the same Bootstrap menu if a table cell is clicked. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. - Perform a Z39.50 search which will return more than one result. - Confirm that clicking the "Actions" button triggers a drop-down menu. - Confirm that the links in the menu trigger actions for the correct bibliographic record. - Confirm that clicking any other table cell in the table of results will trigger the display of the same menu. - Confirm that this menu works correctly for the correct record. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:42:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:42:56 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-PYh0Ect5Ga@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71541&action=edit Bug 20187: Add another KOHA_VERSION in C4/Auth Needed when logging out and in again.. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:48:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:48:24 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-GHtsqI0b4F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71541|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71542&action=edit Bug 20187: Add another KOHA_VERSION in C4/Auth Needed when logging out and in again.. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:51:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:51:58 +0000 Subject: [Koha-bugs] [Bug 20189] New: No style on authentication and installer pages Message-ID: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 Bug ID: 20189 Summary: No style on authentication and installer pages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: m.de.rooy at rijksmuseum.nl Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 12904 Caused by bug 12904, no KOHA_VERSION passed and the css/js files are not loaded correctly Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 [Bug 12904] Force browser to load new javascript files after upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:51:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:51:58 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-2cPbiCahws@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20189 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 [Bug 20189] No style on authentication and installer pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:52:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:52:16 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-L9fDaAryN1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #6) > Created attachment 71542 [details] [review] > Bug 20187: Add another KOHA_VERSION in C4/Auth > > Needed when logging out and in again.. > > Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Moved to bug 20189 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:53:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:53:13 +0000 Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted In-Reply-To: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17355-70-0xRJgAAwVT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:54:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:54:27 +0000 Subject: [Koha-bugs] [Bug 20189] No style on authentication and installer pages In-Reply-To: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20189-70-1vWXOit1Jm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:54:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:54:39 +0000 Subject: [Koha-bugs] [Bug 20189] No style on authentication and installer pages In-Reply-To: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20189-70-VxR9b67YjR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71543&action=edit Bug 20189: Fix style on the authentication page Needed when logging out and in again.. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:55:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:55:26 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-ZqEYDVmnoa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:56:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:56:58 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-FiUPkAQwH6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71538|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71544&action=edit Bug 20187: New rewrite rules can break custom css Koha has the ability to include custom css in the apache configuration. If a library has any custom css ( or adds a custom js file in some way ), and that file has an underscore in it ( e.g. my_custom.css ), the apache rewrite rule will convert it to my.css and thus it will 404. We should make the rewrite rules as specific as possible for the format we are using. Test Plan: 1) Set OPAC_CSS_OVERRIDE to a file with an underscore in it 2) Note it does not work 3) Apply this patch 4) Update the apache rewrite rules to match those in the patch For kohadevbox, just run /home/vagrant/misc4dev/cp_debian_files.pl 5) Restart apache 6) Reload the page, your custom css should load now! Signed-off-by: Victor Grousset <victor.grousset at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:57:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:57:02 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-wvdU8CtEPD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71545&action=edit Bug 20187: (QA follow-up) Replace N,L flag by L flag The flags [N,L] make no sense: next and last combined. Choosing here for L to stop the rewriting process. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:57:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:57:46 +0000 Subject: [Koha-bugs] [Bug 20189] No style on authentication and installer pages In-Reply-To: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20189-70-As6ii98CtS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 --- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 71546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71546&action=edit Bug 20187: Add another KOHA_VERSION in C4/Auth Needed when logging out and in again.. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Victor Grousset <victor.grousset at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 15:58:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 14:58:50 +0000 Subject: [Koha-bugs] [Bug 20189] No style on authentication and installer pages In-Reply-To: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20189-70-d9KLuhtsWu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor.grousset at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:00:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:00:47 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-S87Y3U86Px@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:01:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:01:00 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-5LvlMNVQFy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:01:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:01:22 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-Bt3QqmAk1d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71547&action=edit Bug 20187: Fix Tiny MCE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:01:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:01:26 +0000 Subject: [Koha-bugs] [Bug 20190] New: TinyMCE is broken and not displayed Message-ID: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 Bug ID: 20190 Summary: TinyMCE is broken and not displayed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle.m.hall at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 12904 This is caused by bug 12904 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 [Bug 12904] Force browser to load new javascript files after upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:01:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:01:26 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-o10f5NCxka@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 [Bug 20190] TinyMCE is broken and not displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:02:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:02:19 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-3qYJuDFrKL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:06:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:06:31 +0000 Subject: [Koha-bugs] [Bug 20189] No style on authentication and installer pages In-Reply-To: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20189-70-65at0nnvUQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71543|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 71548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71548&action=edit Bug 20189: Fix style on the authentication page Needed when logging out and in again.. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Victor Grousset <victor.grousset at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:07:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:07:09 +0000 Subject: [Koha-bugs] [Bug 20189] No style on authentication and installer pages In-Reply-To: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20189-70-ZgAm620mxG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71546|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:07:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:07:10 +0000 Subject: [Koha-bugs] [Bug 20190] TinyMCE is broken and not displayed In-Reply-To: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20190-70-ixTpAWx3Ge@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:07:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:07:13 +0000 Subject: [Koha-bugs] [Bug 20190] TinyMCE is broken and not displayed In-Reply-To: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20190-70-dkx9s6HKcQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71549&action=edit Bug 20190: TinyMCE is broken and not displayed Changes made by bug 12904 appear to have affected TinyMCE. Test plan: 1) Edit a library, note the OPAC info editor is missing 2) Apply this patch 3) Reload the page 4) The editor is back! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:12:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:12:56 +0000 Subject: [Koha-bugs] [Bug 20190] TinyMCE is broken and not displayed In-Reply-To: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20190-70-5OnyP1lM54@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QA tools complains.. forbidden patterns? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:16:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:16:23 +0000 Subject: [Koha-bugs] [Bug 20190] TinyMCE is broken and not displayed In-Reply-To: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20190-70-3k0sMGzZ76@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:16:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:16:25 +0000 Subject: [Koha-bugs] [Bug 20190] TinyMCE is broken and not displayed In-Reply-To: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20190-70-IhKHPlNcIW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71549|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71550&action=edit Bug 20190: TinyMCE is broken and not displayed Changes made by bug 12904 appear to have affected TinyMCE. Test plan: 1) Edit a library, note the OPAC info editor is missing 2) Apply this patch 3) Reload the page 4) The editor is back! Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:18:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:18:50 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17602-70-PvkZzrFXij@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:26:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:26:24 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library In-Reply-To: <bug-13153-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13153-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13153-70-Z8muxMV7WU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:33:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:33:47 +0000 Subject: [Koha-bugs] [Bug 20190] TinyMCE is broken and not displayed In-Reply-To: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20190-70-F6W8dh8q5x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71551&action=edit Bug 20190: Replace intranet-tmpl with [% interface %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:39:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:39:04 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18979-70-EbZC0BtaUl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:39:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:39:07 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18979-70-pzpJGpbmGy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67484|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71552&action=edit Bug 18979: Speed up 'valid-templates.t' tests Test plan: Confirm than prove xt/author/valid-templates.t is quicker with this patch. Before I got: Files=1, Tests=840, 21 wallclock secs ( 0.18 usr 0.02 sys + 20.28 cusr 0.32 csys = 20.80 CPU) After: Files=1, Tests=840, 17 wallclock secs ( 0.06 usr 0.01 sys + 21.56 cusr 0.48 csys = 22.11 CPU) Signed-off-by: David Bourgault <david.bourgault at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:42:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:42:38 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18979-70-2CCwDfllzW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #16) > Marcel, could you have another look here? I added a forgotten signoff line from David. I have no objection to this patch, but also note that forking makes us unaware of the warnings raised by the tests like: # excluding template /usr/share/koha/devclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc because it cannot stand on its own etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:42:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:42:39 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-YWURKuWCgr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:42:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:42:42 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-fKouBE8aFU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71390|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71553&action=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:42:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:42:49 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18979-70-e9dhF3NkBp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:44:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:44:08 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-XcE4rbbH4K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71545|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 71554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71554&action=edit Bug 20187: (QA follow-up) Replace N,L flag by L flag The flags [N,L] make no sense: next and last combined. Choosing here for L to stop the rewriting process. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Victor Grousset <victor.grousset at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:47:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:47:51 +0000 Subject: [Koha-bugs] [Bug 20189] No style on authentication and installer pages In-Reply-To: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20189-70-Uqsi1F65CL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71555&action=edit Bug 20189: Fix style on installer and onboarding pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:54:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:54:45 +0000 Subject: [Koha-bugs] [Bug 20189] No style on authentication and installer pages In-Reply-To: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20189-70-qLEI6Pvral@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71555|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71556&action=edit Bug 20189: Fix style on installer and onboarding pages Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:56:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:56:30 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19709-70-eZEhagf8pv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:56:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:56:33 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19709-70-DMFjl99db9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70432|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71557&action=edit Bug 19709 - Move template JavaScript to the footer: Labels This patch modifies the staff client label creator templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Creating and managing layouts - Creating and managing batches - Creating and managing templates - Creating and managing printer profiles - Creating quick spine labels Edit: Fixed footer include error causing blank popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:58:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:58:08 +0000 Subject: [Koha-bugs] [Bug 20189] No style on authentication and installer pages In-Reply-To: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20189-70-8y9mc7hrhh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 16:58:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 15:58:23 +0000 Subject: [Koha-bugs] [Bug 20190] TinyMCE is broken and not displayed In-Reply-To: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20190-70-tgG9qk1BHH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:00:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:00:31 +0000 Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does not populate itemtype descriptions correctly In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19671-70-lA5fhMIhJC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:00:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:00:46 +0000 Subject: [Koha-bugs] [Bug 20163] Position of NoLoginInstructions text is inconsistent In-Reply-To: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20163-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20163-70-Jk5JyFlG0H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:00:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:00:38 +0000 Subject: [Koha-bugs] [Bug 20135] Staff client language choose pop-up can appear off-screen In-Reply-To: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20135-70-WGbqifD9xb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20135 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:00:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:00:51 +0000 Subject: [Koha-bugs] [Bug 20187] New rewrite rules can break custom css In-Reply-To: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20187-70-Hru1WWiLPN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20187 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:00:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:00:58 +0000 Subject: [Koha-bugs] [Bug 20189] No style on authentication and installer pages In-Reply-To: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20189-70-g9YncSymOC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20189 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:01:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:01:32 +0000 Subject: [Koha-bugs] [Bug 20190] TinyMCE is broken and not displayed In-Reply-To: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20190-70-XYkJxgkv4j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20190 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:03:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:03:36 +0000 Subject: [Koha-bugs] [Bug 20120] Writeoffs for individual fees allows an amount to be written off more than the amount of the fee In-Reply-To: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20120-70-DJloTFLj7G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7) > 3. in pay.pl, maybe we should refuse instead of assuming it is what the user > wanted. I think this is still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:14:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:14:57 +0000 Subject: [Koha-bugs] [Bug 18531] REST api: Add an endpoint for use by GOBI In-Reply-To: <bug-18531-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18531-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18531-70-nSQzVE3j0Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:15:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:15:15 +0000 Subject: [Koha-bugs] [Bug 18531] REST api: Add an endpoint for use by GOBI In-Reply-To: <bug-18531-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18531-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18531-70-rglE4vNogY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18531 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:24:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:24:35 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-3glSdg7eo2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- "Leave blank for auto calc during registration" vs "Leave empty for auto calc during registration" Is it really needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:32:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:32:16 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-tzQzI1SjsW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71419|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:32:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:32:17 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-GumwR6X8Yl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71422|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:32:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:32:19 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-ivTNU3qny8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71430|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:32:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:32:22 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-ONapeiJU0z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71441|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:32:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:32:20 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-aZvHz9Kt69@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71435|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:32:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:32:24 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-rzow4m7O4h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71442|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:33:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:33:16 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-oc9we5nhPJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 13:31 < kidclamp_dnd> I would lean towards 'blank' over 'empty' - makes more sense for a form, but either works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 17:34:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 16:34:44 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-nqBCmrjoe7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71558&action=edit Bug 19466: Restore original sentence to avoid additional translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 18:15:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 17:15:11 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15136-70-SAvBuPTIZ7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 18:15:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 17:15:14 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15136-70-WY9dPt0st1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44681|0 |1 is obsolete| | Attachment #44682|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71559&action=edit Bug 15136: Add homebranch of borrowed items to patron accounts tab Test plan: 1 - View the accounts tab for a patron with fines 2 - Note there is no homebranch displayed to see where charges came from 3 - Apply patch 4 - Reload the page and note that you see the 'Home library' column Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 18:15:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 17:15:17 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15136-70-LOaeNlUHmW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71560&action=edit Bug 15136: Use TT plugin to display the branch's name Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 18:17:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 17:17:49 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-xC5a45jMEn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 18:17:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 17:17:43 +0000 Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19301-70-QjAjX865Av@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 18:17:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 17:17:54 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-fISKmE9xqy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 18:18:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 17:18:01 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-yzL4xz47Qx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #66 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 18:18:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 17:18:08 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4319-70-36GpAFPPMu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #85 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 18:21:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 17:21:33 +0000 Subject: [Koha-bugs] [Bug 15136] Display item's homebranch in patron's fines list In-Reply-To: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15136-70-xurDp7KO5j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15136 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Nick: $data->{title} = $biblio->title; + $data->{homebranch} = $biblio->{homebranch}; This reads wrong. Moreover GetMemberAccountRecords will be removed by bug 12001. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 19:23:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 18:23:41 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-OdXGAfj2bD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71497|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71562&action=edit Bug 20185: Remove warnings from stats.print.pl This needs a full rewrite! Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 19:23:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 18:23:38 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-Q2TPCMquF8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71484|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71561&action=edit Bug 20185: Remove warnings from aqplan.pl Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 19:24:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 18:24:05 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-Mzbt6tDt6y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 19:53:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 18:53:50 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-TCvVShhFmM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71563&action=edit Bug 20181: Followup to ensure test runs If EnablePlugins was 0, this test before this patch fails. After this patch, it passes. TEST PLAN --------- 1) Apply all but this patch 2) Run the following commands kshell prove t/Koha_Template_Plugin_KohaPlugins.t -- two tests fail, if you have the conf or syspref set to 0. 3) Apply this patch 4) Repeat step 2. -- all tests pass, including the positive and negative case checks. 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 19:55:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 18:55:05 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-EPUVEBWGbx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to M. Tompsett from comment #3) > Created attachment 71563 [details] [review] > Bug 20181: Followup to ensure test runs > > If EnablePlugins was 0, this test before this patch fails. > After this patch, it passes. > > TEST PLAN > --------- > 1) Apply all but this patch > 2) Run the following commands > kshell > prove t/Koha_Template_Plugin_KohaPlugins.t > -- two tests fail, if you have the conf or syspref set to 0. > 3) Apply this patch > 4) Repeat step 2. > -- all tests pass, including the positive and negative case checks. > 5) run koha qa test tools Doh, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 19:56:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 18:56:40 +0000 Subject: [Koha-bugs] [Bug 18815] OpenLibrarySearch is broken In-Reply-To: <bug-18815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18815-70-7T1dRbjD5x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18815 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6624 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 [Bug 6624] Allow Koha to use the new read API from OpenLibrary -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 19:56:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 18:56:40 +0000 Subject: [Koha-bugs] [Bug 6624] Allow Koha to use the new read API from OpenLibrary In-Reply-To: <bug-6624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6624-70-y5d8VQey6n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18815 [Bug 18815] OpenLibrarySearch is broken -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 19:56:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 18:56:43 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-YUTOUMFido@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #67 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 71564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71564&action=edit Bug 20144: (follow-up) Adjust /patrons endpoint Fields 'address' and 'city' have been maybe nullable by this bug. This patch makes them nullable on the API as well. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail (randomly) when address or city are set to null by TestBuilder. - Apply this patch - Run: k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:01:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:01:10 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-b3ZNTYegix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- On a fresh install, I edit a patron and see: "AutoMemberNum is set to enabled, but cardnumber is marked as mandatory in BorrowerMandatoryField: auto calc has been disabled." That sounds wrong, what can we do? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:08:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:08:38 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-TznL2cOOes@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71565&action=edit Bug 20181: Add POD for new plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:16:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:16:13 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-f5oVaitkxX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71481|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71566&action=edit Bug 20181: Allow plugins to add css and javascript to OPAC A number of Koha plugins have been written that enhance Koha's public catalog. These plugins often make due to adding css and javascript to the various opac system preferences. It would be nice if the plugin system had hooks so plugin developers could add code the the head block and the area where we include javascript in the opac template. Test Plan: 1) Apply this patch 2) Download and install the Kitchen Sink plugin ( v2.1.12 or later ) https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.12/koha-plugin-kitchen-sink-v2.1.12.kpz 3) Install the plugin 4) Restart all the things if you can ( restart_all if you are using kohadevbox ) This will ensure the plugin takes effect right away, it should be necessary but it won't hurt anything! 5) Load the opac, notice you get an alert message and the background for your opac is now orange ( assuming you've not customized the opac in any way ) Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:16:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:16:16 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-5TGPhhb1Wo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71483|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71567&action=edit Bug 20181 - Unit Tests Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:16:18 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-ruVLUv8xbY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71563|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71568&action=edit Bug 20181: Followup to ensure test runs If EnablePlugins was 0, this test before this patch fails. After this patch, it passes. TEST PLAN --------- 1) Apply all but this patch 2) Run the following commands kshell prove t/Koha_Template_Plugin_KohaPlugins.t -- two tests fail, if you have the conf or syspref set to 0. 3) Apply this patch 4) Repeat step 2. -- all tests pass, including the positive and negative case checks. 5) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:16:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:16:22 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-IzeDiAWcDs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71565|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71569&action=edit Bug 20181: Add POD for new plugin Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:16:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:16:56 +0000 Subject: [Koha-bugs] [Bug 20181] Allow plugins to add css and javascript to OPAC In-Reply-To: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20181-70-S9jDp2a7af@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:24:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:24:22 +0000 Subject: [Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers In-Reply-To: <bug-18794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18794-70-rJtGlby5o3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 [Bug 20191] OAI/Server.t still fails on slow servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:24:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:24:22 +0000 Subject: [Koha-bugs] [Bug 20191] New: OAI/Server.t still fails on slow servers Message-ID: <bug-20191-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Bug ID: 20191 Summary: OAI/Server.t still fails on slow servers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 18794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794 [Bug 18794] OAI/Server.t fails on slow servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:25:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:25:08 +0000 Subject: [Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers In-Reply-To: <bug-20191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20191-70-mXKepG8OuP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- https://jenkins.koha-community.org/job/Koha_Master_D8/lastCompletedBuild/console # Failed test 'ListIdentifiers with resumptionToken 2' # at t/db_dependent/OAI/Server.t line 153. # Structures begin differing at: # $got->{ListIdentifiers}{header}[2]{datestamp} = '2018-02-13T17:46:23Z' # $expected->{ListIdentifiers}{header}[2]{datestamp} = '2018-02-13T17:46:22Z' # PARAM:--- # resumptionToken: marcxml/6/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # verb: ListIdentifiers # EXPECTED:--- # ListIdentifiers: # header: # - datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # - datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # - datestamp: 2018-02-13T17:46:22Z # identifier: TEST:688 # resumptionToken: # content: marcxml/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListIdentifiers: # header: # - datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # - datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # - datestamp: 2018-02-13T17:46:23Z # identifier: TEST:688 # resumptionToken: # content: marcxml/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Failed test 'ListRecords marcxml with resumptionToken 2' # at t/db_dependent/OAI/Server.t line 153. # Structures begin differing at: # $got->{ListRecords}{record}[2]{header}{datestamp} = '2018-02-13T17:46:23Z' # $expected->{ListRecords}{record}[2]{header}{datestamp} = '2018-02-13T17:46:22Z' # PARAM:--- # resumptionToken: marcxml/6/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # verb: ListRecords # EXPECTED:--- # ListRecords: # record: # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 6 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 686 # - code: d # content: 586 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 7 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 687 # - code: d # content: 587 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:688 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 8 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 688 # - code: d # content: 588 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # resumptionToken: # content: marcxml/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListRecords: # record: # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 6 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 686 # - code: d # content: 586 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 7 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 687 # - code: d # content: 587 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # - header: # datestamp: 2018-02-13T17:46:23Z # identifier: TEST:688 # metadata: # record: # controlfield: # content: ' lng' # tag: 008 # datafield: # - ind1: ' ' # ind2: ' ' # subfield: # code: a # content: Title 8 # tag: 245 # - ind1: ' ' # ind2: ' ' # subfield: # - code: c # content: 688 # - code: d # content: 588 # tag: 999 # leader: 00126 a2200061 4500 # xmlns: http://www.loc.gov/MARC21/slim # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd # resumptionToken: # content: marcxml/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Failed test 'ListRecords oai_dc with resumptionToken 2' # at t/db_dependent/OAI/Server.t line 153. # Structures begin differing at: # $got->{ListRecords}{record}[2]{header}{datestamp} = '2018-02-13T17:46:23Z' # $expected->{ListRecords}{record}[2]{header}{datestamp} = '2018-02-13T17:46:22Z' # PARAM:--- # resumptionToken: oai_dc/6/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # verb: ListRecords # EXPECTED:--- # ListRecords: # record: # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 6 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 7 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:688 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 8 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # resumptionToken: # content: oai_dc/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # RESPONSE:--- # ListRecords: # record: # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:686 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 6 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # - header: # datestamp: 2018-02-13T17:46:22Z # identifier: TEST:687 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 7 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # - header: # datestamp: 2018-02-13T17:46:23Z # identifier: TEST:688 # metadata: # oai_dc:dc: # dc:language: lng # dc:title: Title 8 # dc:type: {} # xmlns:dc: http://purl.org/dc/elements/1.1/ # xmlns:oai_dc: http://www.openarchives.org/OAI/2.0/oai_dc/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/oai_dc/ http://www.openarchives.org/OAI/2.0/oai_dc.xsd # resumptionToken: # content: oai_dc/9/1970-01-01T00:00:00Z/2018-02-13T23:59:59Z//0/0 # cursor: 9 # request: http://localhost # xmlns: http://www.openarchives.org/OAI/2.0/ # xmlns:xsi: http://www.w3.org/2001/XMLSchema-instance # xsi:schemaLocation: http://www.openarchives.org/OAI/2.0/ http://www.openarchives.org/OAI/2.0/OAI-PMH.xsd # Looks like you failed 3 tests of 29. [17:46:24] t/db_dependent/OAI/Server.t .................................... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:25:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:25:27 +0000 Subject: [Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers In-Reply-To: <bug-20191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20191-70-1GxPnmiAvB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I did not manage to mock DateTime->now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:26:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:26:08 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-GSj7hqncDU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 --- Comment #68 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:52:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:52:17 +0000 Subject: [Koha-bugs] [Bug 19330] Selenium test for Tool module functionality In-Reply-To: <bug-19330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19330-70-o9SS3Xb2zT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19330 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This patch needs to be rewritten to follow the patterns introduced by bug 19243. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:52:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:52:23 +0000 Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19466-70-qQSr0ksd77@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Because it's on a fresh installation? I think either remove autocalc... or mandatory. I'd lean towards removing the autocalc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:55:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:55:54 +0000 Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19802-70-pFNAUCEvwf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am skipping QA, we need selenium tests to catch regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:56:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:56:03 +0000 Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19802-70-eOJBIJOTWt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patches pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:58:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:58:10 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality - part 1 In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19243-70-0QyRESDpWM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:57:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:57:55 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality - part 1 In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19243-70-UXcs1T2JEM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- These patches will serve as examples for other selenium tests. I am skipping QA as we need these tests to catch possible regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:58:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:58:31 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality - part 1 In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19243-70-qdmg76DiSH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patches pushed to master for 18.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 20:59:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 19:59:09 +0000 Subject: [Koha-bugs] [Bug 14302] Remove GRS1 indexing related code In-Reply-To: <bug-14302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14302-70-tY8Fdg7tHZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:01:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:01:06 +0000 Subject: [Koha-bugs] [Bug 14302] Remove GRS1 indexing related code In-Reply-To: <bug-14302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14302-70-xb3HiRIlj7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60469|0 |1 is obsolete| | Attachment #60470|0 |1 is obsolete| | Attachment #60471|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71570&action=edit Bug 14302: Remove GRS1 related files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:01:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:01:13 +0000 Subject: [Koha-bugs] [Bug 14302] Remove GRS1 indexing related code In-Reply-To: <bug-14302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14302-70-NwOhFmCdwL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71571&action=edit Bug 14302: Remove GRS1 specific code Remove: - BIB_INDEX_MODE and AUTH_INDEX_MODE env var - bib_index_mode and auth_index_mode options from scripts - Warnings from about page, just kept one if zebra_bib_index_mode or zebra_auth_index_mode still exist in config and are set to grs1 Test plan: - Install Koha from src - Install Koha from pkg - Read the code, carefully! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:01:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:01:23 +0000 Subject: [Koha-bugs] [Bug 14302] Remove GRS1 indexing related code In-Reply-To: <bug-14302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14302-70-i9l5eTUyXV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71572&action=edit Bug 14302: Remove grs1 records from test data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:08:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:08:15 +0000 Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19820-70-SRIhIbpkED@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69823|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71573&action=edit Bug 19820: Add unsafe param to GetMarcSubfieldStructure Add unsafe param to GetMarcSubfieldStructure and use this options where it's safe to do so to increase performance Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:08:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:08:08 +0000 Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19820-70-9nyno4D8VC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:08:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:08:53 +0000 Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19820-70-6DLwan0jCt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16365 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:08:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:08:53 +0000 Subject: [Koha-bugs] [Bug 16365] Selectively introduce GetMarcStructure() "unsafe" variant for better performance In-Reply-To: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16365-70-bHxXbzmW6g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16365 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19820 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:10:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:10:28 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19479-70-Qw9EGPaFyt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4078 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- You should base your patch on top of bug 4078 instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:10:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:10:28 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: <bug-4078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4078-70-NlA0idHxmj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 [Bug 19479] Price display on a basketgroup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:10:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:10:36 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19479-70-S1M4sD4sG5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:13:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:13:26 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-oYbPgWHbi8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:13:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:13:29 +0000 Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19820-70-zWHjRkF653@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:13:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:13:29 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7923-70-QOArYOHUKK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820 [Bug 19820] Add unsafe param to GetMarcSubfieldStructure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 21:13:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 20:13:26 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7923-70-j4Xu0DAwPc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20116 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 [Bug 20116] Cache language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:00:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:00:14 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-BhjvOSo8re@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69876|0 |1 is obsolete| | --- Comment #71 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71574&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:00:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:00:21 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-Fbvd058CGb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69877|0 |1 is obsolete| | --- Comment #72 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71575&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add <tr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:00:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:00:27 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-jrBEcfqSh7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69878|0 |1 is obsolete| | --- Comment #73 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71576&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:00:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:00:32 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-YpJAVMClqo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69879|0 |1 is obsolete| | --- Comment #74 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71577&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:00:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:00:41 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-H31yF9zlBZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69880|0 |1 is obsolete| | --- Comment #75 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71578&action=edit Bug 19532: Overdue recalls report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:00:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:00:47 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-qhXVAqxL51@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69881|0 |1 is obsolete| | --- Comment #76 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71579&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:00:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:00:52 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-clWKxAgNsd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69882|0 |1 is obsolete| | --- Comment #77 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71580&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:00:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:00:59 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-OnnPvQabtH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69883|0 |1 is obsolete| | --- Comment #78 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71581&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:01:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:01:04 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-35ZpBb72Kv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69884|0 |1 is obsolete| | --- Comment #79 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71582&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:01:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:01:10 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-I6BaqStEoO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69885|0 |1 is obsolete| | --- Comment #80 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71583&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:01:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:01:16 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-Q2zm7CAMd6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69886|0 |1 is obsolete| | --- Comment #81 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71584&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:01:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:01:22 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-BOYDeKzN9D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69887|0 |1 is obsolete| | --- Comment #82 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71585&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:01:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:01:27 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-AraclLhiJo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69888|0 |1 is obsolete| | --- Comment #83 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71586&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:01:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:01:34 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-2mpkolURAI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69889|0 |1 is obsolete| | --- Comment #84 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71587&action=edit Bug 19532: Tests for Koha/Recalls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:01:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:01:40 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-HLydBZ0QSb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69890|0 |1 is obsolete| | --- Comment #85 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71588&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:01:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:01:47 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-Ic96vjojEk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69986|0 |1 is obsolete| | --- Comment #86 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71589&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:01:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:01:53 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-gDWtdmer8Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70093|0 |1 is obsolete| | --- Comment #87 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71590&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:01:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:01:59 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-KyoLxWVKaN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71409|0 |1 is obsolete| | --- Comment #88 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71591&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 13 23:48:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 22:48:02 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-bGXGgcHtrU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71591|0 |1 is obsolete| | --- Comment #89 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 71592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71592&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 00:31:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 23:31:10 +0000 Subject: [Koha-bugs] [Bug 9938] batch patron deletion based on cardnumber or borrowernumber In-Reply-To: <bug-9938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9938-70-hGkuXqO3C3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9938 NancyK. <nkeener at washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nkeener at washoecounty.us --- Comment #2 from NancyK. <nkeener at washoecounty.us> --- Our library will be needing something like this also. NancyK Washoe County Library System -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 00:48:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Feb 2018 23:48:38 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18888-70-JTtomEzxIH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Maybe this patch should take into account the new fields that will be added by bug 4078. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 02:52:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 01:52:11 +0000 Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test In-Reply-To: <bug-18055-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18055-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18055-70-rqkwLYTenY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 04:46:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 03:46:31 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-e6706QYB2t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71469|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71593&action=edit Bug 20178: [sql_modes] Fix output_pref with dateformat=iso Fix for: Incorrect date value: '2018-02-05 06:30 PM' for column 'entrydate' TODO - check other occurrences, put to a separate bug report Then `git grep output_pref|grep iso` and make sure no other calls are impacted. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 04:46:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 03:46:34 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-adi463gLIo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71498|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71594&action=edit Bug 20178: Fix test - iso formatted dates should not use timeformat Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 04:47:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 03:47:01 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-3oSXlJsnbp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 05:15:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 04:15:21 +0000 Subject: [Koha-bugs] [Bug 20169] Two tests are failing with DBD::mysql 4.041 In-Reply-To: <bug-20169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20169-70-GqbW8RJoFo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20169 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 05:15:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 04:15:24 +0000 Subject: [Koha-bugs] [Bug 20169] Two tests are failing with DBD::mysql 4.041 In-Reply-To: <bug-20169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20169-70-7Nu7QcUxS9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20169 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71388|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71595&action=edit Bug 20169: Fix two tests when DBD::mysql is 4.041 Tests pass with DBD::mysql 4.028, but not with 4.041. I'm not sure which exact version makes those tests to fail. The problem is that with newer versions of DBD::mysql, 'float' columns get converted to numbers instead of string, thus the comparison fail. This patch converts the expected values to numbers so the comparison should succeed with both versions of DBD::mysql Test plan: 1. Install DBD::mysql 4.041 or newer 2. prove t/db_dependent/Accounts.t t/db_dependent/Bookseller.t Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 06:11:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 05:11:30 +0000 Subject: [Koha-bugs] [Bug 20160] Sort translated languages by code In-Reply-To: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20160-70-92JElEEF76@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- This sort doesn't quite sort. Install multiple regional English languages, and see if it is the order you would expect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 06:22:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 05:22:42 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: <bug-20123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20123-70-Mg2GPCafjZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- This adds a new function to C4::Context with no test coverage. Our current RM will Fail QA for this. Write some tests please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 06:56:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 05:56:46 +0000 Subject: [Koha-bugs] [Bug 20160] Sort translated languages by code In-Reply-To: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20160-70-QpFCDTMb3s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 --- Comment #3 from paxed <pasi.kallinen at joensuu.fi> --- (In reply to M. Tompsett from comment #2) > This sort doesn't quite sort. Install multiple regional English languages, > and see if it is the order you would expect. Good point, didn't think to test that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 07:17:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 06:17:43 +0000 Subject: [Koha-bugs] [Bug 20160] Sort translated languages by code In-Reply-To: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20160-70-REA2JGrghG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71333|0 |1 is obsolete| | --- Comment #4 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71596&action=edit Bug 20160: Sort translated languages by code The language tabs in Change notices -page are in random order, and will rearrange at every page reload. This is quite irritating. Make getTranslatedLanguages return the languages always in the same order, sorted by the language code. This is better than returning them in a random one. Test plan: 1) Enable TranslateNotices 2) Install multiple languages, including multiple regional English languages 3) Go to Home -> Tools -> Notices & slips 4) Edit any notice 5) Reload the page multiple times. The language tabs will rearrange at random 6) Apply patch 7) Repeat 1-5. The language tabs should now always be in the same order, sorted by the language code. Do the same test to Home -> Tools -> News -> Add News item (Check the "Display location" dropdown) Check Home -> Patrons -> Add patron (the "Preferred language for notices" dropdown) Check Home -> Administration -> System preferences -> i18n/l10n (Note the order of languages listed for "language" and "opaclanguages") Check Home -> Administration -> System preferences -> Local use (Create a new preference with variable type Languages, check the language pref listed in the table) Check Home -> Administration -> Item types -> Add item type (After the Description-field, there's "Translate into other languages", click on that. In the pop-up that opens, check the language drop-down) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 07:17:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 06:17:54 +0000 Subject: [Koha-bugs] [Bug 20160] Sort translated languages by code In-Reply-To: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20160-70-V3H8LZmhEu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:04:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:04:06 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-8e0EoAfnip@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:05:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:05:01 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-zh5F8OuZdX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Would have accepted a change to just .pref :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:13:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:13:59 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-wadKx19egv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71597&action=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:14:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:14:03 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-6xhUvnuMIG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71598&action=edit Bug 17374: (QA follow-up) Skip invalid field names and add fields to sidebar Skip invlid field names Add fields to sidebar Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:14:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:14:11 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-6JLcfibs5r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71600&action=edit Bug 17374: (QA follow-up) Update description of syspref DefaultPatronSearchFields Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:14:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:14:07 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-dIOqah0URQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 71599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71599&action=edit Bug 17374: (QA follow-up) Add cardnumber to list of searchable patron fields To test: 1 - Apply patch 2 - Perform a 'cardnumber' search for patrons 3 - Verify results as expected Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:14:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:14:53 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-AViTCUucIL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:14:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:14:56 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-6fBIsGhKok@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66400|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:14:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:14:58 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-KG9pGwOUtV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71536|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:15:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:15:01 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-6QLfDrlmFh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:15:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:15:04 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-mTDNt1ttEd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 08:15:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 07:15:43 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17374-70-X0Hjg9KPfN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Fixed koha to Koha in the last commit and changed commit subject lines to meet standard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 09:09:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 08:09:51 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-xb2T4Q8BIz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 09:09:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 08:09:54 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-fWtHhTnZSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71553|0 |1 is obsolete| | --- Comment #12 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71601&action=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 09:15:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 08:15:03 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-G0gdmKbDSW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- What if I want to display dates in ISO format but time in 12 hours format ? It is actually possible in master, but this patch prevents this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 09:19:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 08:19:21 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-EmiVwaMEpW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at joensuu.fi --- Comment #90 from paxed <pasi.kallinen at joensuu.fi> --- These two messages in recalls.js don't seem to be translatable: message = "The recall may have already been cancelled. Please refresh the page."; message = "Cancelled" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 09:56:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 08:56:00 +0000 Subject: [Koha-bugs] [Bug 20192] New: ILS-DI: Comment entered in VuFind when placing a hold does not show up in Koha Message-ID: <bug-20192-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20192 Bug ID: 20192 Summary: ILS-DI: Comment entered in VuFind when placing a hold does not show up in Koha Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: roland.keck at bibb.de QA Contact: testopia at bugs.koha-community.org In VuFind you can enter a comment when placing a hold. This comment is currently not visible in Koha. May contain important information for handling in Koha and should therefore be transmitted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:06:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:06:59 +0000 Subject: [Koha-bugs] [Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2 In-Reply-To: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19754-70-Bvgm6AgNg2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:07:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:07:02 +0000 Subject: [Koha-bugs] [Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2 In-Reply-To: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19754-70-5fMTasCe5a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71474|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71602&action=edit Bug 19754: Move template JavaScript to the footer: Acquisitions, part 2 This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Invoices - Datepickers - Search for invoices - Datatable - Acquisitions -> Late orders - Datepickers, datatables, selection controls (when searching by vendor) - Acquisitions -> Vendor -> Basket -> Add to basket -> From an existing record -> Search - Datatables, View MARC modal - Acquisitions -> Vendor -> Basket -> Add to basket -> From a new (empty) record - Form validation, inactive fund control, add users to notify on receiving. - Acquisitions -> Vendor -> Basket -> Add to basket -> From a subscription -> Search - Datatables, show only renewed, show/hide search form - Acquisitions -> Vendor -> Basket -> Add to basket -> From a suggestion - Datatables, "Show" controls - Acquisitions - "Ordered" link in table of funds - Datatables - Acquisitions -> Vendor -> Receive shipment -> Invoice -> Receive - Datepickers, item add form plugins (test with AcqCreateItem set to 'receiving an order.' Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:28:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:28:57 +0000 Subject: [Koha-bugs] [Bug 20193] Label export displaying on never-ending webpage In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-Cx4ACc4Q7L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 [Bug 19709] Move template JavaScript to the footer: Labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:28:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:28:57 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19709-70-Kuy3eaZT1t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 [Bug 20193] Label export displaying on never-ending webpage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:28:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:28:36 +0000 Subject: [Koha-bugs] [Bug 20193] New: Label export displaying on never-ending webpage Message-ID: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Bug ID: 20193 Summary: Label export displaying on never-ending webpage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: claire_gravely at hotmail.com QA Contact: testopia at bugs.koha-community.org When trying to export a label batch, the pop up frame to display export options is not being correctly created. Instead the export information is at the bottom of a never-ending page. (Scrolling never reaches it). To reproduce: Go to Manage Label batches (label-manage.pl) and/or edit a batch (label-edit-batch.pl) and try to export. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:36:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:36:24 +0000 Subject: [Koha-bugs] [Bug 20194] New: Display items.ccode as well as both biblioitems.itemtype and items.itype in circulation screens Message-ID: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Bug ID: 20194 Summary: Display items.ccode as well as both biblioitems.itemtype and items.itype in circulation screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: gaetan.boisson at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com At the moment in circulation screens only one "item type" is displayed, biblioitems.itemtype or items.itype, depending on the item-level_itypes system preference. It is however possible for libraries to use both, biblioitems.itemtype to qualify the record, and items.itype to qualify the item itself. In such a scenario only one of the two will be displayed on the circulation screen. It is also possible for libraries to use items.ccode to further refine the description of their items, but this information is not displayed on circulation screens. This enhancement will make all this information more visible in circulation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:37:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:37:50 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20111-70-D7JlRC9jp7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 71603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71603&action=edit Bug 20111: Coding style: Fix indentation before doing actual change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:37:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:37:53 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20111-70-PpdARYLGxQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 --- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 71604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71604&action=edit Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unit?s" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unit?s" dropdown with french units -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:42:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:42:00 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20111-70-wmdrtW6SRh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Actually the Patron card creator didn't lack as much i18n as the Label creator. I was fooled by the french translations not being complete in master when they were in Pootle. ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:42:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:42:22 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20111-70-1eXBT2TJqb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:49:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:49:55 +0000 Subject: [Koha-bugs] [Bug 19823] Move template JavaScript to the footer: MARC21 editor plugins In-Reply-To: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19823-70-CyTdxeu7M4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:49:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:49:58 +0000 Subject: [Koha-bugs] [Bug 19823] Move template JavaScript to the footer: MARC21 editor plugins In-Reply-To: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19823-70-TteI2HyuKK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69827|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 71605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71605&action=edit Bug 19823: Move template JavaScript to the footer: MARC21 editor plugins This patch modifies the templates for MARC21 editor plugins so that JavaScript is included in the footer. To test, you must link the plugins to their corresponding tag + subfield (if they aren't already): In a bibliographic framework: 000 -> marc21_leader.pl 006 -> marc21_field_006.pl 007 -> marc21_field_007.pl 008 -> marc21_field_008.pl 773$t -> marc21_linking_section.tt In an authorities framework: 000 -> marc21_leader_authorities.tt 008 -> marc21_field_008_authorities.tt -> marc21_field_008_classifications.tt For each field, trigger the plugin by clicking the plugin link. Test JavaScript-driven functionality in each plugin window and confirm that your selections are correctly saved to the editor. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:58:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:58:24 +0000 Subject: [Koha-bugs] [Bug 20195] New: Untranslatable Show/Hide title attr replacement in opac detail Message-ID: <bug-20195-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 Bug ID: 20195 Summary: Untranslatable Show/Hide title attr replacement in opac detail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr opac-detail.tt contains this: var newtitle = $(this).attr('title').replace('Show', 'Hide') $(this).attr('title',newtitle); This tries to replace "Show" in the title attribute of this element: <a href="#" id="a_listResults" title="Show pagination list ([% indexPag %]-[% indexPagEnd %] / [% totalPag %])">Browse results</a> Which will of course fail on other languages. (There's also the matching code to replace "Hide" with "Show") -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 11:59:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 10:59:46 +0000 Subject: [Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail In-Reply-To: <bug-20195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20195-70-ayxoa8JHyC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71606&action=edit [PATCH] Bug 20195: Untranslatable Show/Hide title attr replacement There's javascript code in opac detail view that tries to replace the word "Show" with "Hide" (and vice versa) in a title attribute. In addition to those words being untranslatable, a word replacement like that would not work properly when using other languages. Replace the single title attribute with two translatable strings, one for the "Show" case and one "Hide", and use the whole string instead of trying to replace a single word. Test plan: 1) Make sure OpacBrowseResults is on 2) in OPAC, search the catalog and go to the detail view 3) Hover the mouse over the "Browse results" text in the grey box on the right side. The popup text should show something like "Show pagination list (1-5 / 5)" 4) Click on the "Browse results" 5) Hover the mouse again over the text. The popup should show "Hide pagination list (1-5 / 5)" 6) Update a language xx-YY, translate the new msgids "Show pagination list (%s-%s / %s)" and "Hide pagination list (%s-%s / %s)", and install the language 7) Repeat 2-5 with that language, making sure the popup texts show up correctly in that language -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 12:05:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 11:05:24 +0000 Subject: [Koha-bugs] [Bug 20194] Display items.ccode as well as both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20194-70-rUWySupYKE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 14:51:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 13:51:27 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-d83aAn823F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #8 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Julian Maurice from comment #7) > What if I want to display dates in ISO format but time in 12 hours format ? > It is actually possible in master, but this patch prevents this. ISO format includes times, and they must be 24 hour. This is why I took a little longer signing off, because I had to confirm that 12 hour times were not valid in ISO formatting. You could custom tweak your system preference to something that triggers the fallback else case. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:01:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:01:44 +0000 Subject: [Koha-bugs] [Bug 20196] New: [Omnibus] Prepare Koha to ElasticSearch6 - ES6 Message-ID: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 Bug ID: 20196 Summary: [Omnibus] Prepare Koha to ElasticSearch6 - ES6 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: claire.hernandez at biblibre.com ES6 is out, earlier we make Koha compliant, better it will be. Could be more than one issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:02:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:02:19 +0000 Subject: [Koha-bugs] [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-zt5lGkDEbm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:02:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:02:19 +0000 Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6 In-Reply-To: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20196-70-48MI1G4EBH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18969 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:02:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:02:47 +0000 Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6 In-Reply-To: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20196-70-7idkkleGJ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:02:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:02:39 +0000 Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6 In-Reply-To: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20196-70-sLaMCt81vq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:03:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:03:21 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-Y4Vtu1hekK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Yes, what Mark said, dateformat='iso' means, actually, a 'sql' format. This is an historical issue (introduced by me when I improved Koha::DateUtils), we should distinguish these 2 formats but we do not have this need for so far. But in both case the date should be formatted with a date in 24h format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:08:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:08:43 +0000 Subject: [Koha-bugs] [Bug 20193] Label export displaying on never-ending webpage In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-gE85B6CBQb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |oleonard at myacpl.org |u | Depends on| |12904 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 [Bug 12904] Force browser to load new javascript files after upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:08:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:08:43 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-sdB4mm3FGi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 [Bug 20193] Label export displaying on never-ending webpage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:12:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:12:06 +0000 Subject: [Koha-bugs] [Bug 20193] Path to Greybox CSS broken after Bug 12904 In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-Lp08tzxSis@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Path to Greybox CSS broken |Path to Greybox CSS broken |after Bug 120904 |after Bug 12904 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:11:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:11:44 +0000 Subject: [Koha-bugs] [Bug 20193] Path to Greybox CSS broken after Bug 120904 In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-Z49hOFFOrU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Label export displaying on |Path to Greybox CSS broken |never-ending webpage |after Bug 120904 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:14:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:14:24 +0000 Subject: [Koha-bugs] [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-ZuZdwC3ml9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #1 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 71607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71607&action=edit Bug 18969: ES6 - remove use of field [include_in_all] (WIP for biblios only) Test plan: 1) apply this patch, 2) update your elasticsearch server to the version 6 (6.2?), 3) reinstall icu plugin, 4) reindex your authoroties and biblios, 5) check that there is no error in /var/log/elasticsearch/elasticsearch.log, 6) try a search on biblios 7) check that facet work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:19:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:19:26 +0000 Subject: [Koha-bugs] [Bug 20193] Path to Greybox CSS broken after Bug 12904 In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-yoEo8Gs2qa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71608&action=edit Bug 20193: Path to Greybox CSS broken after Bug 12904 Bug 12904 changed the way CSS and JS assets should be linked, but the Greybox CSS path wasn't changed in the process. This patch adds the required VERSION template variable to greybox.inc. To test, apply the patch and test usage of Greybox in the staff client. For instance: - Go to Tools -> Labels -> Manage -> Label batches - Select a batch for export and click the 'Export selected' button - A Greybox modal should be triggered, and the export process should proceed correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:19:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:19:24 +0000 Subject: [Koha-bugs] [Bug 20193] Path to Greybox CSS broken after Bug 12904 In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-0aPmSfxeda@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:23:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:23:25 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-tRH6RAS6M3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> --- It looks like a misuse of output_pref. Shouldn't the result of this subroutine be used only for display ? Anyway there is a lack of documentation here. It should be documented at least in POD and in description of both sysprefs IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:40:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:40:57 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-XLEbNsFx29@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71056|0 |1 is obsolete| | --- Comment #30 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71609&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:41:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:41:00 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-47ukhpoEMl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71057|0 |1 is obsolete| | Attachment #71058|0 |1 is obsolete| | --- Comment #31 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71610&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:41:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:41:34 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-d4lBM9KnAN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #32 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71611&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:41:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:41:38 +0000 Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted In-Reply-To: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17355-70-98bGYQbi0L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at collect | |o.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:41:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:41:46 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-7e7jt3oKp7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71059|0 |1 is obsolete| | --- Comment #33 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71612&action=edit Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:41:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:41:48 +0000 Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted In-Reply-To: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17355-70-08s0yzAjFC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:45:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:45:39 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-GxP3kcdm1Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #34 from Owen Leonard <oleonard at myacpl.org> --- I've modified the first patch in two ways: 1. staff-global.css now remains in git 2. .gitignore no longer ignores staff-global.css QA team: Should I seek another signoff? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:55:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:55:05 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-KJbaIN7bgm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:56:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:56:03 +0000 Subject: [Koha-bugs] [Bug 20194] Display items.ccode as well as both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20194-70-YjFew9jxqU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71614&action=edit Bug 20194: Display both itemtypes in checkin table And move ccode in its own column Test plan: 1. Check in an item and verify that both itemtypes are displayed in the table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:56:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:56:07 +0000 Subject: [Koha-bugs] [Bug 20194] Display items.ccode as well as both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20194-70-6PwkbFxbea@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71615&action=edit Bug 20194: Display ccode and both itemtypes in pending reserves table Test plan: 1. Go to /cgi-bin/koha/circ/pendingreserves.pl (Holds to pull) and verify that ccodes and both itemtypes are displayed in the table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:56:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:56:16 +0000 Subject: [Koha-bugs] [Bug 20194] Display items.ccode as well as both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20194-70-rTQHsP2V6t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 15:56:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 14:56:00 +0000 Subject: [Koha-bugs] [Bug 20194] Display items.ccode as well as both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20194-70-QWZS2fOkVu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71613&action=edit Bug 20194: Display ccode and both itemtypes in checkouts tables Test plan: 1. Verify that biblioitems.itemtype, items.itype and items.ccode are mapped to a MARC field. Otherwise create those mappings. 2. Create a biblio with an itemtype 3. Create an item with a ccode and a different itemtype for this biblio 4. Check out this item to a patron (P1) 5. Verify that both itemtypes and the ccode are displayed in the checkouts table 6. Create a patron whose guarantor is P1 and verify that both itemtypes and the ccode are displayed in the 'relatives checkouts' table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 16:17:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 15:17:57 +0000 Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15395-70-KpcMJtqhmM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 16:26:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 15:26:03 +0000 Subject: [Koha-bugs] [Bug 20197] New: Missing rfc3339 in systempreference choices for dateformat Message-ID: <bug-20197-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20197 Bug ID: 20197 Summary: Missing rfc3339 in systempreference choices for dateformat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org Koha::DateUtils.pm has logic for rfc3339 in output_pref, but there is no way for the end user to get that value into the system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 16:26:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 15:26:24 +0000 Subject: [Koha-bugs] [Bug 20197] Missing rfc3339 in systempreference choices for dateformat In-Reply-To: <bug-20197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20197-70-JNmTylFn8N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20197 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 16:47:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 15:47:18 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-YkzsvwPK6Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 16:53:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 15:53:17 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-B6dkhcg8f2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 16:53:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 15:53:21 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-yNfOvQY0JE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #35 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71616&action=edit Bug 19474: (follow-up) Catch up with changes to staff-global.css This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css: - Bug 15707: (QA follow-up) Fix UI issues - Bug 20135: Prevent staff client language choose pop-up from appearing off-screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 16:53:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 15:53:40 +0000 Subject: [Koha-bugs] [Bug 20197] Missing rfc3339 in systempreference choices for dateformat In-Reply-To: <bug-20197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20197-70-DELalo70sp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20197 --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71617&action=edit Bug 20197: RFC3339 missing from options The output_pref in Koha::DateUtils has rfc3339 logic, but there is no way to set the system preference to rfc3339. This adds that option. TEST PLAN ---------- 0) back up your DB if you wish. 1) apply this patch. 2) Run the following commands: $ mysql -u koha_kohadev -p > use koha_kohadev; > SELECT options FROM systempreferences WHERE variable='dateformat'; -- no rfc3339 listed. 3) Run the following commands: > quit $ updatedatabase $ mysql -u koha_kohadev -p > use koha_kohadev; > SELECT options FROM systempreferences WHERE variable='dateformat'; -- rfc3339 now listed. 4) Run the following commands: > quit $ reset_all $ mysql -u koha_kohadev -p > use koha_kohadev; > SELECT options FROM systempreferences WHERE variable='dateformat'; -- rfc3339 still listed. 5) Log into the staff client 6) Home -> Administration -> Global System Preferences -> i18n/l10n -- rfc3339 should be listed in the dateformat syspref drop-down. 7) run koha qa test tools 8) restore DB if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 16:53:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 15:53:38 +0000 Subject: [Koha-bugs] [Bug 20197] Missing rfc3339 in systempreference choices for dateformat In-Reply-To: <bug-20197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20197-70-GFgVzd21SG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20197 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:04:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:04:42 +0000 Subject: [Koha-bugs] [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-sPoacPCNcz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71607|0 |1 is obsolete| | --- Comment #2 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 71618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71618&action=edit Bug 18969: ES6 - replace use of field include_in_all by copy_to Test plan: 1) apply this patch, 2) update your elasticsearch server to the version 6 (6.2?), 3) reinstall icu plugin, 4) reindex your authorities and biblios, 5) check that there is no error in /var/log/elasticsearch/elasticsearch.log, 6) try a search on biblios, 7) check that facet work, 8) try a search on authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:05:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:05:08 +0000 Subject: [Koha-bugs] [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-i1invx4ltj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:08:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:08:22 +0000 Subject: [Koha-bugs] [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-7XdhPWXK55@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71618|0 |1 is obsolete| | --- Comment #3 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 71619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71619&action=edit Bug 18969: ES6 - replace use of field include_in_all by copy_to Test plan: 1) apply this patch, 2) update your elasticsearch server to the version 6 (6.2?), 3) reinstall icu plugin, 4) reindex your authorities and biblios, 5) check that there is no error in /var/log/elasticsearch/elasticsearch.log, 6) try a search on biblios, 7) check that facet work, 8) try a search on authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:19:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:19:46 +0000 Subject: [Koha-bugs] =?utf-8?b?W0J1ZyAyMDE5OF0gTmV3OiBg4oC6YG1pc3Npbmcg?= =?utf-8?q?in_breadcrumb_of_translated_pages_of_aqbudgets=2Epl?= Message-ID: <bug-20198-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20198 Bug ID: 20198 Summary: `?`missing in breadcrumb of translated pages of aqbudgets.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Just after `Budgets` the `›` is somehow eaten by the translation process. https://gitlab.com/koha-community/Koha/blob/0ad922011cc330397d9b680b0d045bfd48e85f44/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt#L17 == Going further == Other pages affected? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:38:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:38:50 +0000 Subject: [Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses In-Reply-To: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20177-70-bMUywLJtcR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:38:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:38:54 +0000 Subject: [Koha-bugs] [Bug 20177] Remove GROUP BY clause in GetCourses In-Reply-To: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20177-70-dGGWXuMb4x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20177 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71468|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71620&action=edit Bug 20177: [sql_modes] Fix GROUP BY clause in GetCourses Fix for: 'koha_kohadev.courses.department' isn't in GROUP BY t/db_dependent/CourseReserves.t A better fix would be to remove the joins and only return values from the courses table. But more work is needed to acchieve that goal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:42:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:42:09 +0000 Subject: [Koha-bugs] [Bug 20160] Sort translated languages by code In-Reply-To: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20160-70-l9DsExb3yx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 [Bug 20193] Path to Greybox CSS broken after Bug 12904 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:42:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:42:09 +0000 Subject: [Koha-bugs] [Bug 20193] Path to Greybox CSS broken after Bug 12904 In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-RdQK4faRXY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 [Bug 20160] Sort translated languages by code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:43:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:43:09 +0000 Subject: [Koha-bugs] [Bug 20193] Path to Greybox CSS broken after Bug 12904 In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-TjTH7S6hCl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:43:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:43:12 +0000 Subject: [Koha-bugs] [Bug 20193] Path to Greybox CSS broken after Bug 12904 In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-2xLDWHpZx5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71608|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71621&action=edit Bug 20193: Path to Greybox CSS broken after Bug 12904 Bug 12904 changed the way CSS and JS assets should be linked, but the Greybox CSS path wasn't changed in the process. This patch adds the required VERSION template variable to greybox.inc. To test, apply the patch and test usage of Greybox in the staff client. For instance: - Go to Tools -> Labels -> Manage -> Label batches - Select a batch for export and click the 'Export selected' button - A Greybox modal should be triggered, and the export process should proceed correctly. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:44:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:44:21 +0000 Subject: [Koha-bugs] [Bug 20160] Sort translated languages by code In-Reply-To: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20160-70-Z9wh34txP2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:44:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:44:23 +0000 Subject: [Koha-bugs] [Bug 20160] Sort translated languages by code In-Reply-To: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20160-70-n7XWN0VHxL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20160 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71596|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71622&action=edit Bug 20160: Sort translated languages by code The language tabs in Change notices -page are in random order, and will rearrange at every page reload. This is quite irritating. Make getTranslatedLanguages return the languages always in the same order, sorted by the language code. This is better than returning them in a random one. Test plan: 1) Enable TranslateNotices 2) Install multiple languages, including multiple regional English languages 3) Go to Home -> Tools -> Notices & slips 4) Edit any notice 5) Reload the page multiple times. The language tabs will rearrange at random 6) Apply patch 7) Repeat 1-5. The language tabs should now always be in the same order, sorted by the language code. Do the same test to Home -> Tools -> News -> Add News item (Check the "Display location" dropdown) Check Home -> Patrons -> Add patron (the "Preferred language for notices" dropdown) Check Home -> Administration -> System preferences -> i18n/l10n (Note the order of languages listed for "language" and "opaclanguages") Check Home -> Administration -> System preferences -> Local use (Create a new preference with variable type Languages, check the language pref listed in the table) Check Home -> Administration -> Item types -> Add item type (After the Description-field, there's "Translate into other languages", click on that. In the pop-up that opens, check the language drop-down) Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:46:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:46:10 +0000 Subject: [Koha-bugs] [Bug 20193] Path to Greybox CSS broken after Bug 12904 In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-aDRb7KFki1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Another test case is the Translate into other languages step in bug 20160. If you do not apply this, the popup failed to popup. It was quite frustrating. Thank you for this patch, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 17:57:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 16:57:29 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-1Yhyx7pyD8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I forgot this value existed in the syspref, so I guess this is not the right fix. I am wondering if this value is really in used, I am expecting several side-effects using it. Maybe we should fix the test by mocking the pref instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:19:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:19:00 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-BB02z6utgQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #71593|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:18:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:18:50 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-0VkJWg3KTI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|jonathan.druart at bugs.koha-c |chris at bigballofwax.co.nz |ommunity.org | --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This need to be fixed globally or at least check all the occurrences to estimate the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:19:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:19:39 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-aH1kZl4mkV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20144, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20008 | Status|ASSIGNED |NEW Blocks|17258 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:19:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:19:11 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-B3aQpxZJzY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:19:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:19:39 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-BR2Cft4o5Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20178 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 [Bug 20178] Fix output_pref with dateformat=iso -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:19:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:19:39 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-NWPZ7A12EM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20178 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:19:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:19:39 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-1KodmNEWX0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20178 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:20:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:20:57 +0000 Subject: [Koha-bugs] [Bug 20199] New: Letters.t does not pass with new SQL modes Message-ID: <bug-20199-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Bug ID: 20199 Summary: Letters.t does not pass with new SQL modes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org DBD::mysql::st execute failed: Incorrect date value: '2018-02-14 02:03 PM' for column 'entrydate' at row 1 [for Statement "INSERT INTO `aqorders` ( `basketno`, `biblionumber`, `budget_id`, `entrydate`, `ordernum ber`, `quantity`, `quantityreceived`) VALUES ( ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='14', 1='454', 2='13', 3='2018-02-14 02:03 PM', 4=undef, 5=1, 6=0] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 183 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:20:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:20:57 +0000 Subject: [Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes In-Reply-To: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20144-70-EL4o28IIIX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20199 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:21:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:21:49 +0000 Subject: [Koha-bugs] [Bug 20178] Fix output_pref with dateformat=iso In-Reply-To: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20178-70-RXa0CWekvp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20178 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20199 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I have opened bug 20199 for the Letters.t failure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:21:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:21:49 +0000 Subject: [Koha-bugs] [Bug 20199] Letters.t does not pass with new SQL modes In-Reply-To: <bug-20199-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20199-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20199-70-5mav1ay4vr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20178 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:24:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:24:43 +0000 Subject: [Koha-bugs] [Bug 20199] Letters.t does not pass with new SQL modes In-Reply-To: <bug-20199-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20199-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20199-70-RJIz8CnW9Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:24:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:24:47 +0000 Subject: [Koha-bugs] [Bug 20199] Letters.t does not pass with new SQL modes In-Reply-To: <bug-20199-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20199-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20199-70-CdT9oc2XvX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71623&action=edit Bug 20199: Add tests for Koha::Acq::Order->store -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:24:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:24:51 +0000 Subject: [Koha-bugs] [Bug 20199] Letters.t does not pass with new SQL modes In-Reply-To: <bug-20199-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20199-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20199-70-q79i9w6KgT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71624&action=edit Bug 20199: Send a DateTime to DBIC instead of an iso formatted date We do not need to format the date, DBIC handles DateTime correctly. It fixes t/db_dependent/Letters.t with new SQL modes Test plan: prove t/db_dependent/Letters.t prove t/db_dependent/Koha/Acquisition/Order.t Must return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:34:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:34:03 +0000 Subject: [Koha-bugs] [Bug 20193] Path to Greybox CSS broken after Bug 12904 In-Reply-To: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20193-70-UvZDgKsxUw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- Also, noticed that the patch that made it into master (the apache conf tweak) was [0-9][0-9]... instead of just (.*), so part of the problems may have been the fix was partially broken by use of a bad regular expression. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:37:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:37:58 +0000 Subject: [Koha-bugs] [Bug 20176] Set biblio.datecreated to NOW if not defined In-Reply-To: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20176-70-5URmOz5vV1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Julian Maurice from comment #2) > There are other places where the default values are enforced in 'store' > subroutine (Koha::Patron::Category for example). Why does this patch enforce > a default value in 'new' subroutine ? There is no default value defined at DB level (and cannot) so ->new will explode: DBIx::Class::Storage::DBI::_dbh_execute(): Field 'datecreated' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 124 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:45:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:45:02 +0000 Subject: [Koha-bugs] [Bug 20200] New: Show MARC 770 Supplement/Special Issue Entry on detail pages Message-ID: <bug-20200-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20200 Bug ID: 20200 Summary: Show MARC 770 Supplement/Special Issue Entry on detail pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Currently 770 is not shown in Koha on the detail pages. We should add the display of this field. Examples: 770 08 _iAnfangs darin, sp?ter selbst. _aGesellschaft f?r Verbreitung von Volksbildung _tJahresbericht der Gesellschaft f?r Verbreitung von Volksbildung _dBerlin, 1872 _w015234347 770 08 _iBeil. ab 1902 _aDie Volks-Bibliothek _dBerlin, 1896 _w014944286 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:46:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:46:45 +0000 Subject: [Koha-bugs] [Bug 20200] Show MARC 770 Supplement/Special Issue Entry on detail pages In-Reply-To: <bug-20200-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20200-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20200-70-suhSirQEvZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20200 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- http://www.loc.gov/marc/bibliographic/bd770.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:48:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:48:58 +0000 Subject: [Koha-bugs] [Bug 20182] Remove group by clause in search_patrons_to_anonymise In-Reply-To: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20182-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20182-70-oxgdFcjSEd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20182 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Julian Maurice from comment #2) > So it basically just added a GROUP BY with all columns. Can it affect > performances ? EXPLAIN tells me it should not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:54:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:54:17 +0000 Subject: [Koha-bugs] [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl In-Reply-To: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20180-70-enpB6wistw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:54:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:54:22 +0000 Subject: [Koha-bugs] [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl In-Reply-To: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20180-70-31v6gEhUvV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71472|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71625&action=edit Bug 20180: [sql_modes] Remove GROUP BY clause in manage-marc-import.pl Replaced with a distinct. Fix for: 'koha_kohadev.me.frameworktext' isn't in GROUP BY t/db_dependent/www/search_utf8.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:57:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:57:18 +0000 Subject: [Koha-bugs] [Bug 20179] Remove GROUP BY in get_shelves_containing_record In-Reply-To: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20179-70-ALTujditRR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 18:57:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 17:57:21 +0000 Subject: [Koha-bugs] [Bug 20179] Remove GROUP BY in get_shelves_containing_record In-Reply-To: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20179-70-yqreDFt4zg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20179 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71470|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71626&action=edit Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Replaced with distinct. Fix for: 'koha_kohadev.me.shelfname' isn't in GROUP BY t/db_dependent/Virtualshelves.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:11:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:11:32 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-esnv6Fhs8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #24 from M. Tompsett <mtompset at hotmail.com> --- Rebasing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:14:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:14:31 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-QoD1RlN7lW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70187|0 |1 is obsolete| | --- Comment #25 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71627&action=edit Bug 18736 - Add OrerPriceRounding syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:14:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:14:36 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-NWrGzrzCuk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70188|0 |1 is obsolete| | --- Comment #26 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71628&action=edit Bug 18736 - Use rounding syspref to determine correct prices in calculations To test: Place an order (no tax just for simplicity) listprice/rrp = 16.99 discount = 42% quantity = 8 estimated calculated at 9.85 but order total is 78.83, but 8 times 9.85 = 78.80 Apply patches, set OrderPriceRounding syspref to 'Nearest cent' Not order total is now as expected View ordered.pl and confirm values are correct Complete order, view invoice and confirm values View spent.pl and confirm values Go through acquisitions module and confirm prices throughout are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:14:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:14:40 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-dKpAPYnr92@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70189|0 |1 is obsolete| | --- Comment #27 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71629&action=edit Bug 18736 - Unit tests for rounding Unit tests to highlight the issue To test: Prove t/db_dependent/Budgets.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:14:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:14:44 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-An4Fot3SPs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70768|0 |1 is obsolete| | --- Comment #28 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71630&action=edit Bug 18736: Followup - Fix SQL and uncomment db update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:14:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:14:49 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-BOfGdJgzYQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71062|0 |1 is obsolete| | --- Comment #29 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71631&action=edit Bug 18736: (follow-up) fix wrong call to _get_rounding_sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:14:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:14:53 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-1E1aaeipij@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71063|0 |1 is obsolete| | --- Comment #30 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71632&action=edit Bug 18736 (follow-up) Use CAST instead of CEIL for appropriate rounding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:19:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:19:18 +0000 Subject: [Koha-bugs] [Bug 20145] borrowers.datexpiry eq '0000-00-00' means expired? In-Reply-To: <bug-20145-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20145-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20145-70-DdGqUukQzF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71633&action=edit Bug 20145: Do not insert 0000-00-00 in patron tests (and more) We should call Koha::Patron->is_expired in CanBookBeIssued instead of doing the same calculation. Tests have been adapted to pass with new SQL modes. We should not need to update the values in DB, we already have Bug 14717: Prevent 0000-00-00 dates in patron data (3.21.00.023) Test plan: prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/Koha/Patrons.t must return green -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:19:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:19:37 +0000 Subject: [Koha-bugs] [Bug 20145] borrowers.datexpiry eq '0000-00-00' means expired? In-Reply-To: <bug-20145-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20145-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20145-70-lmwYXJogbJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:19:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:19:13 +0000 Subject: [Koha-bugs] [Bug 20145] borrowers.datexpiry eq '0000-00-00' means expired? In-Reply-To: <bug-20145-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20145-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20145-70-8SKnuRaASJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 19:50:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 18:50:27 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-DBN7dfsIlM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #31 from M. Tompsett <mtompset at hotmail.com> --- The only thing lacking is test coverage of C4::Budgets::GetBudgetsPlanCell, where some changes were made. As a result, this is Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:01:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:01:31 +0000 Subject: [Koha-bugs] [Bug 10941] MARC21 documentation links while adding an authority In-Reply-To: <bug-10941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10941-70-EdpuhDiuh3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10941 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:17:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:17:16 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-pSYojPvm5f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 David Bourgault <david.bourgault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68392|0 |1 is obsolete| | --- Comment #123 from David Bourgault <david.bourgault at inlibro.com> --- Created attachment 71634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71634&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:17:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:17:28 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-PYMB2XHzRS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 David Bourgault <david.bourgault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68393|0 |1 is obsolete| | --- Comment #124 from David Bourgault <david.bourgault at inlibro.com> --- Created attachment 71635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71635&action=edit Bug 17015 - Tests for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:17:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:17:54 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-LprcU6sakI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 David Bourgault <david.bourgault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68394|0 |1 is obsolete| | Attachment #68395|0 |1 is obsolete| | --- Comment #125 from David Bourgault <david.bourgault at inlibro.com> --- Created attachment 71636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71636&action=edit Bug 17015 - Koha now uses the new DiscreteCalendar module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:18:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:18:03 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-NAcx7h0QFA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 David Bourgault <david.bourgault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68396|0 |1 is obsolete| | --- Comment #126 from David Bourgault <david.bourgault at inlibro.com> --- Created attachment 71637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71637&action=edit Bug 17015 - Peformance tests for Koha::DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:18:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:18:44 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-AfiR4gdx7P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 David Bourgault <david.bourgault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:18:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:18:48 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-tYR5HV5pu4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 David Bourgault <david.bourgault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71637|0 |1 is obsolete| | --- Comment #127 from David Bourgault <david.bourgault at inlibro.com> --- Created attachment 71638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71638&action=edit Bug 17015 - Remove old Koha::Calendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:19:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:19:41 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-apFJnCyZ8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 David Bourgault <david.bourgault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71637|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:19:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:19:22 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-PYiN3tQWWN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 David Bourgault <david.bourgault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68397|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:27:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:27:09 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-QBZsgaLXLM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #128 from David Bourgault <david.bourgault at inlibro.com> --- I recreated and rebased the patch to keep the git history clean. I also added a patch that removes files used by the old calendar code. Because this new patch changes database column names (as requested by Jonathan in his quick feedback), if you've tested this patch before make sure to drop the table and recreate it. Test plan and functionality is same as before. This change is only a code cleanup to match QA standards. == Changes from last patch == * Fixed many SQL queries, removing useless code and changing much of the "where" clauses to a DBIx:: syntax. Not all queries can be written using DBIx syntax, so some SQL is still present. * Change most functions to snake_case (from camelCase). Some functions have the same name as in Koha::Calendar to minify changes other Koha files; they were left unchanged. * Added underscores to database columns, and their matching variables. THIS WILL CAUSE ERRORS if you still have the table in your database. If that is the case, drop and recreate the discrete_calendar table before testing. * edit_holidays now uses a hashref for parameters. Default parameters have been made explicit. Calls to the function have been simplified taking default parameters into account. * Holiday types ({E, F, N, R, W}) are now called through a global hash in perl files. (e.g.: $HOLIDAYS->{EXCEPTION}) * add_days_discrete_calendar.pl use txn_begin txn_do for transactions. * discrete_calendar.pl uses C4::Context::only_my_library == Unresolved/Unchanged == > Isn't DAYOFWEEK an MySQLism? It is. I was however unable to find a cross-implementation way of obtaining that information. If anyone has an idea I'm open to suggestions > add_days_discrete_calendar.pl is using SQL statements, use your new > module instead. Koha::DiscreteCalendar does not have any functions to insert new days in the database, as this is only done by the cronjob. >* At first glance DateTime::Format::Strptime->new should be replaced with my $dtf = $schema->storage->datetime_parser At first try it cannot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 20:29:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 19:29:51 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-qg6R3uGS3W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #129 from David Bourgault <david.bourgault at inlibro.com> --- Test plan in comment 84 is still valid, but if you apply last patch "Discrete Calendar" tool is now simply "Calendar". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 21:17:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 20:17:26 +0000 Subject: [Koha-bugs] [Bug 20201] New: Silence warnings in admin/aqplan.pl Message-ID: <bug-20201-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 Bug ID: 20201 Summary: Silence warnings in admin/aqplan.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org Floody logs distracts from debugging real problems. This will clean up warnings triggered in admin/aqplan.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 21:18:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 20:18:49 +0000 Subject: [Koha-bugs] [Bug 20201] Silence warnings in admin/aqplan.pl In-Reply-To: <bug-20201-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20201-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20201-70-U9A9kMMq4H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20185 Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | Status|NEW |ASSIGNED --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- 20185 cleans up some of them while addressing perl -wc issues. This cleans up more. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 [Bug 20185] Some scripts does not pass perl -wc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 21:18:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 20:18:49 +0000 Subject: [Koha-bugs] [Bug 20185] Some scripts does not pass perl -wc In-Reply-To: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20185-70-UVtVsBQLwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20185 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 [Bug 20201] Silence warnings in admin/aqplan.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 21:25:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 20:25:32 +0000 Subject: [Koha-bugs] [Bug 20201] Silence warnings in admin/aqplan.pl In-Reply-To: <bug-20201-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20201-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20201-70-6dRVJsNOga@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71639&action=edit Bug 20201: Silence warnings triggered by admin/aqplan.pl TEST PLAN --------- 0) back up DB 1) Run the following commands on a kohadevbox: reset_all git bz apply 20185 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 2) Navigate in a staff client: Home -> Administration -> Budgets -> Edit -> Planning by libraries -- could be any of the planning, but by libraries is nicely visible on screen. 3) Run the following commands: cat /var/log/koha/kohadev/plack-error.log -- several warnings. 4) Run the following commands: git bz apply 20201 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 5) repeat step 2 and refresh the staff client page. -- this time warnings related to aqplan.pl are not there. 6) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 21:35:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 20:35:19 +0000 Subject: [Koha-bugs] [Bug 20201] Silence warnings in admin/aqplan.pl In-Reply-To: <bug-20201-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20201-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20201-70-GUSMya6mNT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 21:44:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 20:44:05 +0000 Subject: [Koha-bugs] [Bug 19487] Internal server error when writing off lost fine for item not checked out In-Reply-To: <bug-19487-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19487-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19487-70-qWrtpQS6D3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19487 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 14 22:24:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Feb 2018 21:24:36 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-6nSYgGSHjz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to M. Tompsett from comment #31) > The only thing lacking is test coverage of C4::Budgets::GetBudgetsPlanCell, > where some changes were made. As a result, this is Failed QA. Does it mean you tested everything and it works as you expect? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 01:01:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 00:01:42 +0000 Subject: [Koha-bugs] [Bug 20202] New: Link EDI account to Create Edi order Message-ID: <bug-20202-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20202 Bug ID: 20202 Summary: Link EDI account to Create Edi order Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: cunha at monterey.org QA Contact: testopia at bugs.koha-community.org Currently to send create an EDI order you click "Create EDIFACT order" and are taken to a page to select, if you have multiple EDI accounts, your vendor account from a drop-down menu. It would be great if the Vendor and EDI account could be linked, so there would be no possibility of sending the order to the wrong account. We started with the ByWater beta version of EDI, that was the way it worked in beta. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 01:21:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 00:21:51 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-QtM6J59i9D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #33 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Jonathan Druart from comment #32) > Does it mean you tested everything and it works as you expect? No, that was from an eyeball stance only. I just tested what was there, and my Total tax exc. (USD) column is 8?! Regardless of system preference setting. There is a mistake somewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 06:49:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 05:49:02 +0000 Subject: [Koha-bugs] [Bug 20192] ILS-DI: Comment entered in VuFind when placing a hold does not show up in Koha In-Reply-To: <bug-20192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20192-70-IGYtIWWfH5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20192 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Roland, as we don't know how your Koha and VuFind interact with each other, we have no way of fixing this for you. We'd need more information and also a way to determine if this is a Koha or a VuFind issue. If you can give a step by step how the same problem appears when placing a hold from Koha, that could help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 07:00:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 06:00:14 +0000 Subject: [Koha-bugs] [Bug 20194] Display items.ccode as well as both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20194-70-ethxHw1ar0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Looking at the code there seems no way to hide one or the other or be clear about which itemtype is from the record or the item? They will just show up next to each other. I don't think that every library will like this change, as often they are the same and it would result in a double up of information. Can you explain what the use case is for seeing both? If you have item-level itypes and items exist, I think seeing the item itype should be the right choice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 07:02:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 06:02:51 +0000 Subject: [Koha-bugs] [Bug 20192] ILS-DI: Comment entered in VuFind when placing a hold does not show up in Koha In-Reply-To: <bug-20192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20192-70-75gmgTKSuk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20192 --- Comment #2 from Roland Keck <roland.keck at bibb.de> --- Hi Katrin, It's an issue in both sides - on the Vufind as well as on the Koha side. I already fixed this issue for my organisation and I will try to supply a proposal for a patch for Koha as well. It'll take some time, because I first have to get familiar with the procedures, how changes are implemented in Koha. I am currently reading the documentation and will come up with a proposal. It's a rather small enhancement on the Koha side and I hope it doesn't break anything else. BTW: we are using the KohaILSDI driver on the VuFind side which interacts with ilsdi.pl on the Koha side. Are there other and probably better ways for this kind of communication with VuFind? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 07:15:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 06:15:29 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20115-70-fpOzSZn1rz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Dilan Johnpull? <dilan at calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan at calyx.net.au --- Comment #7 from Dilan Johnpull? <dilan at calyx.net.au> --- Works as described on the staff client side but the order on the opac side remains unchanged regardless of the order of languages set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 08:15:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 07:15:42 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: <bug-4078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4078-70-rwUGUXlPnW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #30 from Claire Gravely <claire_gravely at hotmail.com> --- Hi, I applied the patch, did an updatedatabase, restart_all and emptied cache. I am not seeing the checkbox on the currency admin page or any currency symbols in the OPAC. Am I missing a step still? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 08:40:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 07:40:51 +0000 Subject: [Koha-bugs] [Bug 4078] Add the ability to customize and display the symbol for a currency In-Reply-To: <bug-4078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4078-70-NvvKWNLj6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #31 from Claire Gravely <claire_gravely at hotmail.com> --- (In reply to Claire Gravely from comment #30) > Hi, > > I applied the patch, did an updatedatabase, restart_all and emptied cache. I > am not seeing the checkbox on the currency admin page or any currency > symbols in the OPAC. Am I missing a step still? sorry, I do see the currency symbol in the OPAC, just not the checkbox to add a space. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:05:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:05:00 +0000 Subject: [Koha-bugs] [Bug 20176] Set biblio.datecreated to NOW if not defined In-Reply-To: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20176-70-YIFMW1RYvu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20176 --- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> --- /home/vagrant/kohaclone/Koha/Object.pm line 124 is in "store" subroutine, so it is "store" that explodes, not "new", which is why I ask: why not override "store" to set default values (like it is done in others "Koha::Object"s) ? $ perl -MKoha::Biblio -E 'Koha::Biblio->new' # No errors $ perl -MKoha::Biblio -E 'Koha::Biblio->new->store' DBD::mysql::st execute failed: Field 'datecreated' doesn't have a default value [for Statement "INSERT INTO `biblio` () VALUES ()"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. DBIx::Class::Storage::DBI::_dbh_execute(): Field 'datecreated' doesn't have a default value at /home/koha/koha/Koha/Object.pm line 124 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:13:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:13:30 +0000 Subject: [Koha-bugs] [Bug 20203] New: Add info about contributing to koha-community.org/documentation/ Message-ID: <bug-20203-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20203 Bug ID: 20203 Summary: Add info about contributing to koha-community.org/documentation/ Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org It might be nice if the page at https://koha-community.org/documentation/ said something about how to contribute to the documentation, or linked to such info published elsewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:17:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:17:36 +0000 Subject: [Koha-bugs] [Bug 20204] New: FrameworkPlugin.t shoud not depend on CPL branch Message-ID: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20204 Bug ID: 20204 Summary: FrameworkPlugin.t shoud not depend on CPL branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Triggered by: <Joubu> could you take a look at the noise of t/db_dependent/FrameworkPlugin.t? I took a look. And saw something else :) If you dont have CPL, the test crashes. Note that the noise is not from the test, but from poorly written plugins. Especially the unimarc plugins generate much uninitialized value and substr outside of string warnings. We should not have added Modern::Perl in one pass imo, but consider them one by one.. See bug 19996. I have been working on those plugins, but stranded so far on lack of support. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:17:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:17:49 +0000 Subject: [Koha-bugs] [Bug 20204] FrameworkPlugin.t shoud not depend on CPL branch In-Reply-To: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20204-70-9hQqOANFe8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20204 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:18:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:18:46 +0000 Subject: [Koha-bugs] [Bug 20004] Adapt /v1/cities to new naming guidelines In-Reply-To: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20004-70-FjpFo7PPnj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |claire_gravely at hotmail.com --- Comment #3 from Claire Gravely <claire_gravely at hotmail.com> --- Patch does not apply Applying: Bug 20004: Adapt /v1/cities to new naming guidelines fatal: sha1 information is lacking or useless (api/v1/swagger/parameters.json). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:22:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:22:57 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-1eXIGxqInH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #130 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Mehdi Hamidi from comment #84) > Patch test plan: > > 1- Apply patch > 2- Run installer/data/mysql/updatedatabase.pl > 3- Run the script add_days_discrete_calendar.pl to add couple days in the > future with debug option Will this step be needed on production system after upgrade to 18.05 ? > 4- Run test t/db_dependent/DiscreteCalendar.t > 5- Run all of Koha's tests in t/ > -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:25:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:25:10 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-9uf2JYs2dY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #131 from Josef Moravec <josef.moravec at gmail.com> --- Just quick test but I always get "No library set! You are using the default calendar." in the UI. I'm not able to copy anything from default to specific library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:25:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:25:33 +0000 Subject: [Koha-bugs] [Bug 20204] FrameworkPlugin.t shoud not depend on CPL branch In-Reply-To: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20204-70-SQiMxR40SE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20204 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:25:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:25:36 +0000 Subject: [Koha-bugs] [Bug 20204] FrameworkPlugin.t shoud not depend on CPL branch In-Reply-To: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20204-70-4nVe7KG5q9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20204 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71640&action=edit Bug 20204: Add TestBuilder to replace CPL branch Remove CPL; without this branch, the test crashes. Rearrange modules at the start. Add Koha::Database calls. Move a few global my vars to our level. Remove intermediate rollbacks. Test plan: [1] Run prove t/db_dependent/FrameworkPlugin.t Ignore noise from unimarc plugins :) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:27:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:27:33 +0000 Subject: [Koha-bugs] [Bug 20204] FrameworkPlugin.t shoud not depend on CPL branch In-Reply-To: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20204-70-wxLrfBFWfE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20204 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Signing off myself: trivial edits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:29:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:29:33 +0000 Subject: [Koha-bugs] [Bug 20204] FrameworkPlugin.t should not depend on CPL branch In-Reply-To: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20204-70-X6ngm2MJcX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20204 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|FrameworkPlugin.t shoud not |FrameworkPlugin.t should |depend on CPL branch |not depend on CPL branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 09:29:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 08:29:24 +0000 Subject: [Koha-bugs] [Bug 20204] FrameworkPlugin.t shoud not depend on CPL branch In-Reply-To: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20204-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20204-70-Gdwo8ezdM2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20204 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 10:08:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 09:08:37 +0000 Subject: [Koha-bugs] [Bug 20205] New: Add IDs to buttons in patron-toolbar.inc Message-ID: <bug-20205-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Bug ID: 20205 Summary: Add IDs to buttons in patron-toolbar.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 3534 added the "Quick add new patron" button to patron-toolbar.inc. The button is displayed if either PatronQuickAddFields or BorrowerMandatoryField (or both) is set. This means there is no way to turn off the button if you still want to have mandatory fields. An alternative way to remove the button is to hide it with CSS, but the buttons in patron-toolbar.inc do not have unique IDs, so this harder than it needs to be. This bug will add ID elements to the buttons in patron-toolbar.inc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 10:19:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 09:19:27 +0000 Subject: [Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc In-Reply-To: <bug-20205-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20205-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20205-70-ZXdXBZocSl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 10:19:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 09:19:30 +0000 Subject: [Koha-bugs] [Bug 20205] Add IDs to buttons in patron-toolbar.inc In-Reply-To: <bug-20205-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20205-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20205-70-lEGy9HV2nK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- Created attachment 71641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71641&action=edit Bug 20205 - Add IDs to buttons in patron-toolbar.inc The buttons in patron-toolbar.inc lack unique IDs, making them hard to style/remove with CSS. This patch adds IDs to all three buttons. To test: - Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc and verify there are no IDs - Apply the patch and look at the file again to verify the IDs have been added - Test the "New patron" and "Quick add new patron" buttons to verify they still work as intended - Check that the new buttons are globally unique: $ grep -rn "new-patron-button" * $ grep -rn "patron-lists-button" * -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 15 10:56:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Feb 2018 09:56:03 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-cHdjLuJXsO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #132 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 71634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71634 Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts Review of attachment 71634: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17015&attachment=71634) ----------------------------------------------------------------- Just quickly read the code and found few issues which should be addressed I think ::: Koha/DiscreteCalendar.pm @@ +16,5 @@ > +# along with Koha; if not, see <http://www.gnu.org/licenses>. > + > +#####Sets holiday periods for each branch. Datedues will be extended if branch is closed -TG > +use strict; > +use warnings; Should be: use Modern::Perl; @@ +72,5 @@ > + > +=cut > + > +sub new { > + my ( $classname, %options ) = @_; You are using hash for options, but should be hashref - we use hashrefs in other packages of Koha namespace at least, see https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_should_be_used_as_arguments @@ +156,5 @@ > +=head2 add_new_branch > + > + Koha::DiscreteCalendar->add_new_branch($copyBranch, $newBranch) > + > +This methode will copy everything from a given branch to a new branch Typo: "methode" -> "method" ::: installer/data/mysql/atomicupdate/bug_17015_part1_create_discrete_calendar.sql @@ +9,5 @@ > + `holiday_type` varchar(1) DEFAULT '', > + `note` varchar(30) DEFAULT '', > + `open_hour` time NOT NULL, > + `close_hour` time NOT NULL, > + PRIMARY KEY (`branchcode`,`date`) Please specify the encoding of the table. The table is also missing in kohastructure.sql ::: installer/data/mysql/atomicupdate/bug_17015_part2_fill_discrete_calendar.perl @@ +29,5 @@ > + > +if ($help) { > + print $usage; > + exit; > +} I think atomic update should not take params. ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/discrete_calendar.tt @@ +3,5 @@ > +<title>Koha › Tools › [% Branches.GetName( branch ) %] calendar > +[% INCLUDE 'doc-head-close.inc' %] > +[% INCLUDE 'calendar.inc' %] > + > + Javascript should be at and of page, see: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS12:_Include_javascript_at_the_end_of_template @@ +376,5 @@ > + }); > + //]]> > + > + > +