[Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Feb 4 12:49:59 CET 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #71111|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 71172
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71172&action=edit
Bug 11827: Untranslatable "Cancel Rating" in jQuery rating plugin
- Make the "Cancel rating" text translatable (and change
capitalization to conform to Koha coding guidelines)
- Improve the two other messages to use formatted strings
instead of concatenation.
- Use the exact same text for the "your rating" text, so it
only appears once in the po-file.
Test plan:
1. See that the "Cancel rating" -text doesn't appear in
po/xx-YY-opac-bootstrap.po
2. Note how there's two versions of the your rating -text
("your rating: %s, " and "your rating:") in the po-file
3. Apply patch
4. Update the xx-YY translation
5. Check the po-file. It should now contain the "Cancel rating"
and a single "your rating: %s, "
6. Translate those texts, and update & install the language.
7. Go to the OPAC detail page of a biblio, and check the
rating texts.
8. Hovering over the rating minus -sign should show the translated
"Cancel rating"
9. Check that the text after the stars is correct with and without
your rating
Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list