[Koha-bugs] [Bug 20145] New: borrowers.datexpiry eq '0000-00-00' means expired?
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Feb 6 20:47:55 CET 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145
Bug ID: 20145
Summary: borrowers.datexpiry eq '0000-00-00' means expired?
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
See bug
http://lists.koha-community.org/pipermail/koha-devel/2018-February/044322.html
Koha::Patron->is_expired returns 0 if $self->dateexpiry eq '0000-00-00'
And there is a test I wrote for it on bug 17578 (commit
5a0a2ce584dec74808f471b0f92b2114c3d6029e , GetMemberDetails - Remove
is_expired)
But then we also have, in C4::Circulation::CanBookBeIssued:
752 if ( !defined $patron->dateexpiry || $patron->dateexpiry eq
'0000-00-00') {
753 $issuingimpossible{EXPIRED} = 1;
754 } else {
With a test:
is( $issuingimpossible->{EXPIRED}, 1, 'The patron should be considered as
expired if dateexpiry is 0000-00-00' );
So, my questions, do you have a very old Koha installations to search if there
is borrowers.is_expired == "0000-00-00" in it?
Do you remember if it meant expired or not at some point?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
More information about the Koha-bugs
mailing list