[Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree with Jonathan:

- The French country code +33 is hard coded into the script which makes it only
useful for French telephone numbers, but not usable for example for German ones
(+41). This could easily be more generic and then much more useful.
- There is an option --country-option, but it doesn't appear to be used?
- It adds a new module to C4, which we should not do anymore.
- It doesn't include tests.

I think if we want something like that, it might be better as a clean-up script
in misc/maintenance. Possibly without a separate module? 

I think it's not quite ready, sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.