[Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Feb 9 13:24:18 CET 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769
Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #71366|0 |1
is obsolete| |
--- Comment #46 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 71380
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71380&action=edit
Bug 14769: (Follow-up) Reduce number of preference parses
In sub merge the Koha::Authority object was already created, so it was kind
of silly to recreate it each time with new.
In Koha::Authority, the ControlledIndicators object can be saved in the
object too for reuse during its life time. Similarly, we prevent repeated
lookups for the reporting tag (via authority type).
Test plan:
[1] Run t/db_dependent/Authority/Merge.t
[2] Run t/db_dependent/Koha/Authorities.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Limited benchmarking shows me a reduction of 11% on Merge.t and a
reduction of 4% on Authorities.t when comparing with and without this
last patch. The larger impact on Merge.t could be expected.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list