[Koha-bugs] [Bug 20195] Untranslatable Show/Hide title attr replacement in opac detail

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20195

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #1 from paxed <pasi.kallinen at joensuu.fi> ---
Created attachment 71606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71606&action=edit
[PATCH] Bug 20195: Untranslatable Show/Hide title attr replacement

There's javascript code in opac detail view that tries to replace
the word "Show" with "Hide" (and vice versa) in a title attribute.
In addition to those words being untranslatable, a word replacement
like that would not work properly when using other languages.

Replace the single title attribute with two translatable strings,
one for the "Show" case and one "Hide", and use the whole
string instead of trying to replace a single word.

Test plan:

1) Make sure OpacBrowseResults is on
2) in OPAC, search the catalog and go to the detail view
3) Hover the mouse over the "Browse results" text in the grey box on the
   right side. The popup text should show something like
   "Show pagination list (1-5 / 5)"
4) Click on the "Browse results"
5) Hover the mouse again over the text. The popup should show
   "Hide pagination list (1-5 / 5)"
6) Update a language xx-YY, translate the new msgids
   "Show pagination list (%s-%s / %s)" and
   "Hide pagination list (%s-%s / %s)", and install the language
7) Repeat 2-5 with that language, making sure the popup
   texts show up correctly in that language

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.