[Koha-bugs] [Bug 9573] Ability to download items lost report

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

there are some conflicts about the new VERSION variable for .js files. I've
tried to resolve those, but get tons of errors in the QA scripts. Can you
please take a look? I will paste some examples below:


 FAIL   koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/sco/help.tt
   FAIL   forbidden patterns
                forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug
12904) - May be false positive (line 13)

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/opac-user.tt
   FAIL   forbidden patterns
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 742)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 719)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 862)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 46)
   OK     git manipulation
   FAIL   spelling
                 transfered  ==> transferred

   FAIL   valid
                        (Missing operator before shelfbrowser?)
                String found where operator expected 
                syntax error 
                        (Missing operator before  'shelfbrowser.inc'?)
                koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/shelfbrowser.tt
had compilation errors.
                Bareword found where operator expected 
                Unquoted string "shelfbrowser" may clash with future reserved
word 

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/suggestion.tt
   FAIL   critic
                Code before strictures are enabled at line 1, column 1. See
page 429 of PBP.
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     spelling
   FAIL   valid
                Bareword found where operator expected 
                        (Missing operator before  'doc-head-open.inc'?)
                        (Missing operator before  'doc-head-close.inc'?)
                koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/suggestion.tt
had compilation errors.
                Unquoted string "render" may clash with future reserved word 
                        (Missing semicolon on previous line?)
                        (Missing operator before suggestion?)
                        (Missing operator before divider?)
                syntax error 
                Unquoted string "label" may clash with future reserved word 
                        (Missing operator before Koha?)
                        (Missing operator before jsinclude?)
                Unquoted string "html" may clash with future reserved word 
                        (Missing operator before  'opac-bottom.inc'?)
                Unknown regexp modifier "/v" 
                Unquoted string "divider" may clash with future reserved word 
                String found where operator expected 
                Unquoted string "opac" may clash with future reserved word 
                Unknown regexp modifier "/n" 
                Unquoted string "jsinclude" may clash with future reserved word 
                Unquoted string "suggestions" may clash with future reserved
word 
                Unquoted string "cssinclude" may clash with future reserved
word 
                Unquoted string "koha" may clash with future reserved word 
                Unquoted string "title" may clash with future reserved word 
                        (Missing operator before cssinclude?)
                Unquoted string "pl" may clash with future reserved word

-- 
You are receiving this mail because:
You are watching all bug changes.