[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 70043
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70043
Bug 11373: Add a "cash register" feature to the fine payment form.

Review of attachment 70043:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11373&attachment=70043)
-----------------------------------------------------------------

I am wondering about the usability here. For paying a partial fine I am forced
to manually edit 2 input fields which adds more steps for the busy circulation
desk and also might cause more potential for errors. Maybe it would make sense
to automatically change the amount collected to the amount paid when it's
changed? Or to make this optional?

I'd like to get some librarians to weigh in on these changes if possible. 

Some other small issues noted below. QA tools are clean.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
@@ +98,5 @@
>  </ul>
>  <div class="tabs-container">
> +[% IF (error_negative) %]
> +    <div id="error_message" class="dialog alert">
> +        <span>The amount paid can't be negative!</span>

Why the additional spans everywhere? A message inside a div should not need it
(see also other cases below).

@@ +175,5 @@
> +        [% give_change %]
> +    </li>
> +    [% ELSE %]
> +    <li>
> +        <label for="paid">Amount paid :</label>

No additional spaces between text and : please :)

::: members/paycollect.pl
@@ +128,5 @@
> +    elsif ($total_paid < $total_due and $total_collected ne $total_paid) {
> +         $template->param(
> +            amount_paid => sprintf('%.2f', $total_paid),
> +            amount_collected => sprintf('%.2f', $total_collected),
> +            give_change => sprintf('%.2f',($total_collected-$total_paid))

I am wondering about the formatting done in various spots in the patch. I'll
ask a second opinion about that. Please note that we have a TT plugin for
displaying prices in different ways and CurrencyFormat system preference
(entering prices still happens with . ).

-- 
You are receiving this mail because:
You are watching all bug changes.