[Koha-bugs] [Bug 15336] Script for merging vendors

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 68676
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68676
Bug 15336 - New command-line script: merge_bookseller.pl

Review of attachment 68676:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15336&attachment=68676)
-----------------------------------------------------------------

Hi Alex, 

started QA on this, but found some issues, please fix:

1) QA tools fail:

FAIL    Koha/Acquisition/Bookseller.pm
   FAIL   pod
                empty =head3
                 in file Koha/Acquisition/Bookseller.pm
                *** ERROR: 

   FAIL   pod coverage
                POD is missing for 'merge_with'

2) Please fix your commit message to include the correct script name! I think
you also change subscriptions and items? Please document in your test plan.

::: Koha/Acquisition/Bookseller.pm
@@ +77,5 @@
> +
> +    my $from_vendor = Koha::Acquisition::Booksellers->find( $mergefrom );
> +    my $result = $from_vendor->merge_with($mergeto);
> +
> +merge source vendor (-f) into target vendor (-t)

3) ...merge with :)

::: misc/migration_tools/merge_vendors.pl
@@ +102,5 @@
> +
> +=item B<--confirm>
> +
> + --confirm              Commit the changes in database. Running without this
> +                        parameter is like testing. It is recommanded to run without

4) ... recommended

@@ +107,5 @@
> +                        --confirm first to be sure of the changes.
> +
> +=item B<--from>
> +
> + --from=<vendorid>  The source vendor identifier that will be merged in

5) Suggestion: The identifier of the source vendor that will be merged with the
target vendor.

@@ +112,5 @@
> +                        target vendor.
> +
> +=item B<--to>
> +
> + --to=<vendorid>    The target vendor identifier in which merge

6) Suggestion: The identifier of the target vendor that the source vendor is
merged with.

::: t/Bookseller.t
@@ +1,3 @@
>  #!/usr/bin/perl
>  #
> +# This Koha test module is a stub!

7) Could possibly remove this now :)
All tests pass for me.

-- 
You are receiving this mail because:
You are watching all bug changes.