[Koha-bugs] [Bug 11897] Stock Rotation for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #183 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 70521
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70521
Bug 11897: Add Stock Rotation atomic update schema.

Review of attachment 70521:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11897&attachment=70521)
-----------------------------------------------------------------

::: installer/data/mysql/atomicupdate/stockrot_tables.sql
@@ +6,5 @@
> +    description text NOT NULL default '',   -- Description for this rota
> +    cyclical tinyint(1) NOT NULL default 0, -- Should items on this rota keep cycling?
> +    active tinyint(1) NOT NULL default 0,   -- Is this rota currently active?
> +    PRIMARY KEY (`rota_id`)
> +) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

2) Should now be: ... ENGINE=InnoDB DEFAULT CHARSET=utf8mb4
COLLATE=utf8mb4_unicode_ci; (see bug 18336)

::: installer/data/mysql/kohastructure.sql
@@ +4156,5 @@
> +    description text NOT NULL default '',   -- Description for this rota
> +    cyclical tinyint(1) NOT NULL default 0, -- Should items on this rota keep cycling?
> +    active tinyint(1) NOT NULL default 0,   -- Is this rota currently active?
> +    PRIMARY KEY (`rota_id`)
> +) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

3) Same here as above:
ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

::: installer/data/mysql/sysprefs.sql
@@ +601,5 @@
>  ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'),
>  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'),
> +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'),
> +('StockRotation','0',NULL,'If ON, enables the stock rotation module','YesNo'),
> +('RotationPreventTransfers','0',NULL,'If ON, prevent any transfers for items on stock rotation rotas, except for stock rotation transfers','YesNo')

4) Preferences in this file are sorted alphabetically, please move into the
right spot.

::: koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
@@ +21,4 @@
>      [%- CASE 'lists' -%]<span>Lists</span>
>      [%- CASE 'clubs' -%]<span>Patron clubs</span>
>      [%- CASE 'ill' -%]<span>Create and modify Interlibrary loan requests</span>
> +    [%- CASE 'stockrotation' -%]<span>Manage stockrotation operations</span>

5) Descriptions for the sub-permissions appear to be  missing?

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ +879,5 @@
> +            - pref: RotationPreventTransfers
> +              choices:
> +                  yes: Enable
> +                  no: Disable
> +            - "Prevent branchtransfers on items in stockrotation rotas"

6) These preferences don't form sentences and are not nicely formatted. Please
avoid use of 'branch' in favor of 'library'. Also, should it be stock rotation
or stockrotation? Both are used here. It should probably be something like:

- yes: Enable
- no: Disable
- "library transfers on items in stockrotation rotas."

-- 
You are receiving this mail because:
You are watching all bug changes.