[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Feb 21 21:23:03 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #115 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #114)
> From AddMember, added by bug 19841:
> 
>     my $category = Koha::Patron::Categories->find( $data{categorycode} );
>     unless ($category) {
>         Koha::Exceptions::BadParameter->throw(
>             error => 'Invalid parameter passed',
>             parameter => 'categorycode'
>         );
>     }
> 
> Must not we remove that?

This belongs to a separate bug, of course. The thing is: we need the category
object to specify a default expiration date and default privacy. We need that
information before ->store. And if the category object is undef, then we have
nothing to do... so better exit before doing more calculations (set values if
defined $category, etc).

I think it is ok as it is.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list