[Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #116 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tomás Cohen Arazi from comment #115)
> (In reply to Jonathan Druart from comment #114)
> > From AddMember, added by bug 19841:
> > 
> >     my $category = Koha::Patron::Categories->find( $data{categorycode} );
> >     unless ($category) {
> >         Koha::Exceptions::BadParameter->throw(
> >             error => 'Invalid parameter passed',
> >             parameter => 'categorycode'
> >         );
> >     }
> > 
> > Must not we remove that?
> 
> This belongs to a separate bug, of course. The thing is: we need the
> category object to specify a default expiration date and default privacy. We
> need that information before ->store. And if the category object is undef,
> then we have nothing to do... so better exit before doing more calculations
> (set values if defined $category, etc).
> 
> I think it is ok as it is.

The problem is that the whole stuff is not done in a transaction, in that case
we will not need it.

-- 
You are receiving this mail because:
You are watching all bug changes.