[Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Feb 23 11:44:55 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

--- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 72106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72106&action=edit
Bug 13287: (QA follow-up) Add db revision

Added missing upgrade SQL system preference.
Corrected system preference screen message
Fixes on purge_suggestions.pl
- perlcritic friendlier
- address $PERL5LIB comment by using $PROGRAM_NAME (comment #10)
- used STDERR (comment #10)
- perltidy

TEST PLAN
---------
$ ./installer/data/mysql/updatedatabase.pl
-- should run upgrade and generate new systempreference in table
$ ./misc/cronjobs/purge_suggestions.pl --help
-- should give help with a real path used instead of $PERL5LIB.
$ ./misc/cronjobs/purge_suggestions.pl -days -1
-- should give error message as expected
$ ./misc/cronjobs/purge_suggestions.pl -days 0
-- should give error message as expected

Go to OPAC system preferences tab and check the
PurgeSuggestionsOlderThan system preference
-- message should be as expected (see comment #9)

run koha qa test tools
-- all should pass

Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Moved new pref from OPAC to Acquisitions preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list