[Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sat Feb 24 01:44:46 CET 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784
Kyle M Hall <kyle at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72026|0 |1
is obsolete| |
Attachment #72027|0 |1
is obsolete| |
Attachment #72028|0 |1
is obsolete| |
--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 72171
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72171&action=edit
Bug 19784: Unit tests for /api/v1/patrons
This patch adapts the existing endpoint's tests so they expect:
- 'patron_id' for 'borrowernumber'
- 'library_id' for 'branchcode'
- 'category_id' for 'categorycode'
In the process, I tried to make the tests more robust, by creating random
data that gets deleted to make sure our tests cases can't have false
positives.
Independent subtests are wrapped inside transactions to avoid
eventual interference.
To test:
- Apply the patch
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: The api doesn't implement the expected behaviour and attributes
for endpoint responses
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list