[Koha-bugs] [Bug 20140] Allow translating more of OAI sets

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20140

--- Comment #4 from paxed <pasi.kallinen at joensuu.fi> ---
(In reply to Katrin Fischer from comment #3)
> Hi Paxed, patch is fine as usual, but wondering about setDescription. I
> think the term was taken from the OAI spec:
> 
> https://www.openarchives.org/OAI/openarchivesprotocol.html 
> a setDescription -- an optional and repeatable container that may hold
> community-specific XML-encoded data about the set; the accompanying
> Implementation Guidelines document provides suggestions regarding the usage
> of this container.
> 
> So maybe we want to change it in English too? "Description
> (setDescription):" ?

Perhaps, but there were two reasons for why I made it translatable:

1) The same "setDescription" text header in the table, and the same label above
in the template are translatable - so why not this instance of it?

2) Leaving a text string in javascript like that is a bad example - perhaps
someone will look at it and add similar untranslatable strings elsewhere.
Better have everything translatable that sometimes some strings not.

-- 
You are receiving this mail because:
You are watching all bug changes.