[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 64704
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64704
Bug 8137 - Add Default checkout limit by patron category with priority.

Review of attachment 64704:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8137&attachment=64704)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ +548,5 @@
>             no limit applies, except possibly for a limit you define for a specific item type.
>          </p>
> +        <p>
> +            <b>Has priority: </b>If checked, the rule will override those for all branches. Else
> +            it behaves like a default one: used if no rule existe for the coresponding branch.

exists, corresponding. -- typos.

@@ +559,4 @@
>                      <th>Patron category</th>
>                      <th>Total current checkouts allowed</th>
>                      <th>Total current on-site checkouts allowed</th>
> +                    [% UNLESS humanbranch %]<th>Has priority</th>[% END %]

humanbranch?! I haven't read the code, but this seems strange to read.

::: t/db_dependent/Circulation/Branch.t
@@ +201,5 @@
> +    (categorycode, maxissueqty, maxonsiteissueqty, has_priority)
> +    VALUES( ?, ?, ?, ? )
> +|;
> +$dbh->do($query, {}, $samplecat->{categorycode}, 3, 3, 0);
> +

Why is this change so far away from the other?

-- 
You are receiving this mail because:
You are watching all bug changes.