[Koha-bugs] [Bug 12310] Accept different monetary formats as input

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Feb 26 16:27:35 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |ASSIGNED

--- Comment #40 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
That was hard but it's rebased (not tested if it still works)

After the rebase I checked the diff between the old and new patch to ensure
that there was no lost code or mistakenly added. And it was useful as 3
iterations were necessary to have a clean and reliable result.

== conflict that could be problematic ==
<<<<<<< 673a40d2acc5c8c58b7f3e7e6d11c329d0587fc6
        <input name="paid" id="paid" value="[% amountoutstanding %]" />
||||||| merged common ancestors
        <input name="paid" id="paid" value="[% amountoutstanding |
format('%.2f') %]" />
=======
        <input name="paid" id="paid" value="[% amountoutstanding |
format('%.2f') %]" onchange="Check(document.payindivfine.paid)"/>
>>>>>>> Bug 12310 : Modify scripts in order to convert any string to the good format

Solved as:
        <input name="paid" id="paid" value="[% amountoutstanding %]"
onchange="Check(document.payindivfine.paid)"/>
Maybe the patch is impacted by the fact that the value isn't
"format('%.2f')"-ed anymore.

This should be found out when testing.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list