[Koha-bugs] [Bug 11897] Stock Rotation for Koha

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Feb 27 08:20:28 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #191 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Alex,

patches now apply and updatedatabase works.

1) QA script returns some errors (have removed the OK parts):

 FAIL   t/db_dependent/Koha/Libraries.t

   FAIL   valid
                Global symbol "$retrieved_category_2" requires explicit package
name 
                Global symbol "$nb_of_categories" requires explicit package
name 
                t/db_dependent/Koha/Libraries.t had compilation errors.

 FAIL   Koha/StockRotationStages.pm
   FAIL   pod coverage
                POD is missing for 'object_class'

 FAIL   Koha/StockRotationRotas.pm
   FAIL   pod coverage
                POD is missing for 'object_class'

 FAIL   Koha/StockRotationItems.pm
   FAIL   pod coverage
                POD is missing for 'object_class'


 FAIL   Koha/Schema/Result/Stockrotationstage.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 FAIL   Koha/Schema/Result/Stockrotationitem.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

 FAIL   Koha/Schema/Result/Stockrotationrota.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

Not sure about the last 3, but please take a look.

2) Missing notice template

> I have now implemented all your recommendations and further improved the POD
> for the Stockrotation API.
> 
> There are two caveats:
> - I have not modified the API file (outside of POD) as it works as is?
> - I have not implemented notice template based report for the stockrotation
> cronscript.
> 
> For the latter, to be honest, I'm in over my head.  If you feel that is a
> blocker, then perhaps someone who has worked with the templates before can
> point me in the right direction?

I have thought about it, but I think we should really not introduce a harcoded
notice like this as it will be a step back from what we have achieved now with
all messages being translatable. I'd suggest starting at the GUI, taking a look
at messages that have recently been added, like the article request ones and
see how it was done there maybe? 

3) Documentation

Can you share how the attached PDF was created? Would it be possible to submit
a patch to our manual too? (note: we are using Sphinx now) I read it and
thought it was very helpful, but I couldn't figure out what 'Add "in demand"'
does, can you explain?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list