[Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #12 from Magnus Enger <magnus at libriotech.no> ---
This is also a problem when you return a book and click on "Print slip and
confirm": the email version of HOLD_SLIP is printed, not the print one. 

Contrary to what Katrin says in Comment 5, it looks like the email version is
both displayed in the popup for printing *and* added to the message_queue. The
messages show as "print" and "pending" on the patron account of the patron that
has the hold on the book. 

In this case the print popup displays circ/hold-transfer-slip.pl, which calls
C4::Reserves::ReserveSlip():

  54 if ( my $letter = ReserveSlip ($session->param('branch') ||
$userenv->{branch}, $borrowernumber, $biblionumber) ) {
  55     $slip = $letter->{content};
  56     $is_html = $letter->{is_html};
  57 }

ReserveSlip() calls C4::Letters::GetPreparedLetter without a
message_transport_type parameter:

1886     return  C4::Letters::GetPreparedLetter (
1887         module => 'circulation',
1888         letter_code => 'HOLD_SLIP',
1889         branchcode => $branch,
1890         lang => $patron->lang,
1891         tables => {
1892             'reserves'    => $reserve,
1893             'branches'    => $reserve->{branchcode},
1894             'borrowers'   => $reserve->{borrowernumber},
1895             'biblio'      => $reserve->{biblionumber},
1896             'biblioitems' => $reserve->{biblionumber},
1897             'items'       => $reserve->{itemnumber},
1898         },
1899     );

And C4::Letters::GetPreparedLetter() assumes email for the missing
message_transport_type parameter: 

 694     my $mtt         = $params{message_transport_type} || 'email';

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.