From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 09:48:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2018 08:48:02 +0000 Subject: [Koha-bugs] [Bug 19900] New: edadasdfasd Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19900 Bug ID: 19900 Summary: edadasdfasd Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: Macintosh OS: Mac OS Status: NEW Severity: blocker Priority: P5 - low Component: Hea Assignee: chris at bigballofwax.co.nz Reporter: tinotasi at tm2mail.com QA Contact: jonathan.druart at bugs.koha-community.org Created attachment 70218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70218&action=edit bugrits asdfasdfasdfasdfasdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 12:51:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2018 11:51:13 +0000 Subject: [Koha-bugs] [Bug 19900] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|edadasdfasd |SPAM Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 15:46:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2018 14:46:13 +0000 Subject: [Koha-bugs] [Bug 19901] New: KOHA process high, load average over 150 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19901 Bug ID: 19901 Summary: KOHA process high, load average over 150 Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mhby87 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 70219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70219&action=edit opac-detail.pl over process. My KOHA process is too high over 150 load average. KOHA also hang. Refer attachment. After disable port 80 for OPAC, KOHA can work for intranet dan load average is stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 16:13:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2018 15:13:46 +0000 Subject: [Koha-bugs] [Bug 19901] KOHA process high, load average over 150 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19901 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Mohd, this is more likely to be an issue with your setup. For example your OPAC might have been hit by one of the less nice search engines - in this case we would recommend to add a robots.txt. Please take your problem to the mailing list! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 16:24:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2018 15:24:08 +0000 Subject: [Koha-bugs] [Bug 19901] KOHA process high, load average over 150 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19901 --- Comment #2 from Mohd Hafiz Yusoff --- (In reply to Katrin Fischer from comment #1) > Hi Mohd, this is more likely to be an issue with your setup. For example > your OPAC might have been hit by one of the less nice search engines - in > this case we would recommend to add a robots.txt. Please take your problem > to the mailing list! Hi Katrin, can I refer this link https://wiki.koha-community.org/wiki/Koha_Tuning_Guide#Reduce_CPU_usage_of_webcrawlers:_robots.txt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 16:53:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2018 15:53:03 +0000 Subject: [Koha-bugs] [Bug 19901] KOHA process high, load average over 150 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19901 --- Comment #3 from Mohd Hafiz Yusoff --- I add robots.txt but still overload. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 17:10:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2018 16:10:28 +0000 Subject: [Koha-bugs] [Bug 19901] KOHA process high, load average over 150 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19901 --- Comment #4 from Katrin Fischer --- Sorry, I am not the right person to help you further - please try the mailing list where a lot more people will read and can help you with your question. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 1 21:27:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jan 2018 20:27:44 +0000 Subject: [Koha-bugs] [Bug 18783] Allow automatic claims for serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783 --- Comment #6 from Katrin Fischer --- Would be nice to see this progressing, it's often asked for! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 08:11:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 07:11:24 +0000 Subject: [Koha-bugs] [Bug 19902] New: Add column configuration to bibliographic record checkouts history table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902 Bug ID: 19902 Summary: Add column configuration to bibliographic record checkouts history table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 08:14:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 07:14:42 +0000 Subject: [Koha-bugs] [Bug 17527] Hidden settings in MARC framework don' t work correctly on results list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527 --- Comment #28 from Katrin Fischer --- Marc, could you take another look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 08:42:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 07:42:07 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #8 from Katrin Fischer --- This is still quite a problem for users of article requests - can we agree on a fix? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 08:46:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 07:46:41 +0000 Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 08:46:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 07:46:44 +0000 Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902 --- Comment #1 from Josef Moravec --- Created attachment 70220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70220&action=edit Bug 19902: Add column settings to bibliographic record checkouts history table Test plan: 0) Apply the patch 1) Go to administration -> Configure columns, note there is new checkoutshistory-table in Catalogue section 2) Make some configuration in this table settings 3) Go to detail of any record -> Checkout history 4) The columns should be visible according to your configuration from step 2 5) Play with Column visibility, to ensure it does work as it should -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 08:47:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 07:47:13 +0000 Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 09:27:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 08:27:50 +0000 Subject: [Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 09:28:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 08:28:13 +0000 Subject: [Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 09:28:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 08:28:15 +0000 Subject: [Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68107|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 70221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70221&action=edit Bug 19303: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address This new Koha::Patron->first_valid_email_address already exists, it should be called directly Test plan: - With a logged in user who have an email address defined, send a basket. The email should be marked sent by this email address - On the "Holds awaiting pickup", the email address must be displayed as well Signed-off-by: David Bourgault Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 09:46:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 08:46:30 +0000 Subject: [Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 09:46:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 08:46:53 +0000 Subject: [Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 09:46:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 08:46:59 +0000 Subject: [Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 --- Comment #6 from Josef Moravec --- Created attachment 70223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70223&action=edit Bug 19304: (QA follow-up) Fix number of tests in Members.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 09:46:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 08:46:56 +0000 Subject: [Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68111|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 70222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70222&action=edit Bug 19304: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address This subroutine is quite trivial and can be replaced easily with a new method of Koha::Patron Test plan: Overdue notices and shelf sharing must be send the to an email address, according to the value of the pref AutoEmailPrimaryAddress Signed-off-by: David Bourgault Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 10:33:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 09:33:12 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |josef.moravec at gmail.com --- Comment #142 from Josef Moravec --- Hi, these patchset doesn't apply. So just few comments from quick reading of the code: You don't have to change signature of GetHiddenItemnumbers, you can ask for patron category here... And you can than leave the $search_context as is. Also the "opac" param in GetMarcBiblio and EmbedItemsInMarcBiblio is not needed, you can use C4::Context->interface when you need to know the actual interface And some squashing would be nice here ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:28:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 10:28:08 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com Status|Signed Off |Patch doesn't apply --- Comment #5 from Josef Moravec --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:46:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 10:46:06 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #16 from Josef Moravec --- Comment on attachment 67802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67802 Bug 12365 - Notes for rules Review of attachment 67802: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12365&attachment=67802) ----------------------------------------------------------------- ::: Koha/Schema/Result/Issuingrule.pm @@ +300,5 @@ > extra => { list => ["no", "yes", "bib_only", "item_only"] }, > is_nullable => 0, > }, > + "note", > + { data_type => "varchar", is_nullable => 1, size => 100 }, The Schema files changes should be generated by update_dbix_class_files.pl script and should be in separate commit. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ +436,5 @@ > Item level holds > Article requests > Rental discount (%) > + Note > +   The colspan parameter is not needed here and should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:46:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 10:46:28 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:59:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 10:59:01 +0000 Subject: [Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:59:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 10:59:16 +0000 Subject: [Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 11:59:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 10:59:19 +0000 Subject: [Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67821|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 70224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70224&action=edit Bug 18183: jQuery append error related to script tags in cloneItemBlock See the detailed explanation of the error on Bugzilla. As a workaround, we move the append of clone to outeritemblock before the append of data (long string with item fields and script tags) to clone. This patch also moves two vars inside the success function, since they are not used outside of it. Test plan: [1] Set AcqCreateItem to receiving. [2] Receive an order. Verify that adding, updating or deleting an item block still works as expected. Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:20:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 11:20:32 +0000 Subject: [Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:20:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 11:20:36 +0000 Subject: [Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68071|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Created attachment 70225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70225&action=edit Bug 15378: Allow removal of lost items from course reserves It seems that this restriction is not necessary, it should be possible to remove lost items from course reserves. Test plan: Create a course and add reserve with a lost item => Without this patch the "Remove" button is disabled and the item cannot be removed from the course => With this patch applied the button is enable and the item can be removed Signed-off-by: S?verine QUEUNE Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:20:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 11:20:50 +0000 Subject: [Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 12:54:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 11:54:21 +0000 Subject: [Koha-bugs] [Bug 19886] Two Factor Authentication: Yubikey In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #1 from Jon Knight --- Is this something that needs to be built into Koha, or is it better to make use of existing third party systems such as PrivacyIDEA (https://www.privacyidea.org/) that can be used in conjuction with normal SSO mechanisms? For example we (Loughborough University) have tested Yubikeys with PrivacyIDEA and simpleSAMLphp IdP and it works, and we already know that Koha can use the SAML2.0 authentication assertions from the IdP (as that's what we're doing in production with PTFS-E). PrivacyIDEA also can also support Google Authentication as suggested in Bug 19887. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:20:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 12:20:06 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #187 from Nick Clemens --- Tried testing, seems to be some issues: 1 - Template code in subscription-add.js file breaks serial biblio search: 620 //[% IF Koha.Preference('Mana') == 1 %] 2 - When I attempt to save a serial: Variable "$loggedinuser" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 371. Variable "$template" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 372. Variable "$loggedinuser" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 371. Variable "$template" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 372. Can't use string ("koha_login_context") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/Koha/Subscription/Numberpatterns.pm line 63. 3 - Blank modal when attempting to share report with no notes 4 - Internal server error when trying to share a new report with notes: Use of uninitialized value $loggedinuser in string ne at /home/vagrant/kohaclone/Koha/SharedContent.pm line 106. Can't call method "first_valid_email_address" on an undefined value at /home/vagrant/kohaclone/Koha/SharedContent.pm line 108. I stopped testing at this point -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 13:56:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 12:56:30 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #9 from Nick Clemens --- Created attachment 70226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70226&action=edit Bug 17374 - Add cardnumber to list of searchable patron fields To test: 1 - Apply patch 2 - Perform a 'cardnumber' search for patrons 3 - Verify results as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 14:01:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 13:01:10 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Nick Clemens --- (In reply to Katrin Fischer from comment #8) > 1) If you leave the preference empty, the default will show. The default > doesn't include cardnumber, I think it might be good to include it on top. > > 2) When using the preference, the default will still show, so there is no > way to remove fields. Wouldn't it make more sense to use the non-empty pref > instead of the default? For example a lot of libraries don't use the sort > fields and could remove them from the list this way. > > The current behaviour seems especially confusing since the preference is not > empty by default but includes a list of values. Deleting one of them will > have no effect as long as the value is in the list of default. > > Failing for 2). 1 - Attached patch (this may be better as its own report) 2 - I think this is beyond scope here. The preference is intended to simply control the fields searched when using a 'standard' search. Adding these the dropdown is a convenience feature. I think removing fields is better done by javascript for customization. The list of fields here and the list in the pref didn't have parity before so introducing now would be a bigger change. Moving back to QA queue for second opinion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:08:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 14:08:18 +0000 Subject: [Koha-bugs] [Bug 19903] New: Add Koha::Patron::Restrictions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19903 Bug ID: 19903 Summary: Add Koha::Patron::Restrictions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org We need a Koha::Object-based class to replace (the so-called) Koha::Patron::Debarments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:08:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 14:08:31 +0000 Subject: [Koha-bugs] [Bug 19903] Add Koha::Patron::Restrictions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19903 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:30:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 14:30:11 +0000 Subject: [Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 15:45:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 14:45:00 +0000 Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- I do not recreate the bug, and I do not understand the fix. Could you detail please? (In reply to Victor Grousset/tuxayo from comment #0) > It's very likely to also affect the OPAC Does it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:01:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:01:49 +0000 Subject: [Koha-bugs] [Bug 18303] Release team omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19904 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19904 [Bug 19904] Release team 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:01:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:01:49 +0000 Subject: [Koha-bugs] [Bug 19904] New: Release team 18.05 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19904 Bug ID: 19904 Summary: Release team 18.05 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 18303 Updating about team page for 18.05 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 [Bug 18303] Release team omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:02:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:02:52 +0000 Subject: [Koha-bugs] [Bug 19904] Release team 18.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:12:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:12:40 +0000 Subject: [Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:12:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:12:46 +0000 Subject: [Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:12:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:12:51 +0000 Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:12:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:12:56 +0000 Subject: [Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:13:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:13:02 +0000 Subject: [Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:13:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:13:07 +0000 Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for transfer-slip. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:25:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:25:40 +0000 Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 --- Comment #5 from Katrin Fischer --- It doesn't effect the OPAC from what I could tell when testing. It just switches the indexes in the new search options pull down on the simple search according to the pref from ,wrdl to ,phr for callnumber, copying the existing behaviour for advanced search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:26:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:26:25 +0000 Subject: [Koha-bugs] [Bug 19905] New: Don't append wildcard to query terms Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 Bug ID: 19905 Summary: Don't append wildcard to query terms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com Discovered this issue while testing the search links in biblio-details. The links are hard-coded in the template with queries not using quotes for field values, which makes QueryBuilder::_truncate_terms append '*' to the search term. Since wild card searches skips the analyzer-phase, most of our links does not work (since a lot of field values has word boundaries and/or punctuation marks, for example the query "Provider:Taschen," will be converted to "Provider:Taschen,*" and since the indexed value for Provider is "Taschen" this search will produce no results. In my opinion (if I'm not misunderstanding the purpose of this code) appending '*' to words should be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:26:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:26:39 +0000 Subject: [Koha-bugs] [Bug 19905] Don't append wildcard to query terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:43:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:43:21 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Ed Veal changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:52:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:52:42 +0000 Subject: [Koha-bugs] [Bug 19905] Don't append wildcard to query terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 --- Comment #1 from David Gustafsson --- Created attachment 70227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70227&action=edit Bug 19905 - Don't append wildcard to query terms Appending '*' to query terms makes Elasticsearch skip search analysis. This will for example cause issues with search links in biblio details for values other than a just single term, since the indexed value has been tokenized. How to test: 1) Find a biblio with a field value containing word boundaries and/or punctuation marks. For example: "au:Author, Name". 2) Perform a search using this query, this should not produce any results. 3) Apply patch. 4) Search using the same query again, it should now produce the expected results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:57:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:57:10 +0000 Subject: [Koha-bugs] [Bug 19905] Don't append wildcard to query terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from David Gustafsson --- I just now discovered that the link I was testing this with (Publisher, using the query Provider:, is not quoting the value, but most (perhaps all) of the other links are. So an alternative solution to this issue could be add quotes in the xsl-template. Still we have received serveral complaints from libraries failing to perform searches using unquoted field values, and though we could tell everyone to always use quotes, it feels like Koha would provide a better user experience if wildcard queries where not the default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 16:58:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 15:58:19 +0000 Subject: [Koha-bugs] [Bug 19905] Don't append wildcard to query terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 --- Comment #3 from David Gustafsson --- *librarians, not libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:00:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:00:44 +0000 Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Note to myself: the variable is not sent from all the scripts that include search_indexes.inc. Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:08:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:08:16 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #9 from Jonathan Druart --- Created attachment 70228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70228&action=edit Bug 18477: Use ->store to update the timestamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:09:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:09:27 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Jonathan Druart --- There is a big lack of test and add a test here will take me too much time. The fix sounds trivial and the ->store method is obviously missing. I am willing to push these patches as it, if QA is ok with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:11:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:11:58 +0000 Subject: [Koha-bugs] [Bug 19905] Don't append wildcard to query terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 --- Comment #4 from David Gustafsson --- Looking through the tests I now saw there is an "QueryAutoTruncate" option that was enabled in my instance. So turning this off will most likely fix this issue for us, and I now realize it cannot just be removed (without also removing this option), making this fix an incorrect one. I have not tested it out myself, but I think there may be other issues with the current autotruncation, should not the whole phrase be searched (the "raw" field for example) or else you will get strange results for wildcard queries containing multiple tokens (since it is the tokanized values that will be matched against)? But that is another possible issue, and should perhaps not be addressed here. But for now I'm disabling the option, and this issues should perhaps be closed. There is still an issue with the Provider-link not being quoted (and might not work if "QueryAutoTruncate" is enabled), but better to open another issue for that one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:13:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:13:28 +0000 Subject: [Koha-bugs] [Bug 19905] Don't append wildcard to query terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:22:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:22:26 +0000 Subject: [Koha-bugs] [Bug 19883] Add a selenium script to hit all the pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19883 --- Comment #4 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #3) > Nice goal on itself. Protecting the database is obviously needed. > Do several scripts need basic parameters at the beginning already (not only > what is filled on a form)? So the script needs to know these; could be a > maintenance headache? I plan to test with GET parameters only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:26:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:26:23 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #14 from Jonathan Druart --- QA: Please make sure bug 19772 is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:28:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:28:42 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |J.P.Knight at lboro.ac.uk --- Comment #11 from Jon Knight --- (In reply to Jonathan Druart from comment #6) > (In reply to Jonathan Druart from comment #3) > > Please provide tests! > > Reading the code the change is obvious (the same call exists for other > methods), but why do we call $self->SUPER::store instead of $self->store? > > Back to NQA I just had a look at this and it would appear to call the parent's store method because if it calls its own there's a loop: the $self->store() method in Koha/ArticleRequest.pm can call its $self->open() method. I tested it by doing the obvious: replacing $self-SUPER::store with $self->store and sure enough its a memory hogging loop that crashed by dev VM's web server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:38:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:38:26 +0000 Subject: [Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins , part 7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 --- Comment #1 from Owen Leonard --- Created attachment 70229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70229&action=edit Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:38:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:38:23 +0000 Subject: [Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins , part 7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:39:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:39:44 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70202|0 |1 is obsolete| | --- Comment #5 from David Gustafsson --- Created attachment 70230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70230&action=edit Bug 19893 - Alternative optimized indexing for Elasticsearch Add alternative optimized indexing for Elasticsearch How to test: 1) Time a full elasticsearch re-index by running the rebuild_elastic_search.pl with the -d flag: `koha-shell -c "time rebuild_elastic_search.pl -d"`. 2) Enable ExperimentalElasticSearchIndexing system preference (found under Global System preferences -> Administration -> Search Engine). 3) Time a full re-index again, it should be about twice at fast (for a couple of thousand biblios, with fewer biblios results may be more unpredictable). Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 17:41:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 16:41:42 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #6 from David Gustafsson --- Fixed an instance of hard-coded Elasticsearch mapping document type in update_mappings(). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:03:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 17:03:07 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #13 from Jonathan Druart --- Hi David, It looks like you find a good place where we can improve speed performance, good catch. However it is like we are going backward reintroducing raw SQL queries. I would prefer to avoid such changes. Did you try to make a mix of both approaches, like: generate only 1 query with my $items = Koha::Items->search({ -in => $barcodes }); in place of your my $items = C4::Items::GetItems($itemnumbers); I guess we will need to call $items->unblessed and an interesting addition would be to fill itype according to ->effective_itemtype (so perf will be impacted if not item-level_itypes, like in your patch). Does it make sense? Something else, did you make sure serials will not be impacted? GetItem fetches serialseq and publisheddate. At first glance it looks safe but we need to be sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:27:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 17:27:28 +0000 Subject: [Koha-bugs] [Bug 19816] output_pref must raised an exception if called with dateformat => rfc3339 and > dateonly => 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Tom?s Cohen Arazi --- Even if the RFC doesn't target date-only representations, full-date is proposed to be used in OpenAPI, so we should support it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:37:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 17:37:35 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #12 from Jonathan Druart --- Created attachment 70231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70231&action=edit Bug 18477: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:38:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 17:38:12 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Jonathan Druart --- Indeed Jon, so we need tests :) Thanks for the catch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:38:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 17:38:26 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:59:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 17:59:04 +0000 Subject: [Koha-bugs] [Bug 19890] authorised value branches is not visible from dropdown in Admin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- There are 3 authorised value "special categories": branches, itemtypes, cn_source. They are used to link a MARC subfield to a branchcode, itemtype or classification source. They are not proper authorised values (in the sense of the authorised_values table), but are needed to restrict the input. We could add them to the category dropdown list and remove the ability to add value to them (display a friendly message instead to explain the situation). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 18:59:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 17:59:18 +0000 Subject: [Koha-bugs] [Bug 19890] authorised value branches is not visible from dropdown in Admin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:11:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 18:11:33 +0000 Subject: [Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - " Cannot process file as an image" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- The relevant code of the warning is: 1084 my $branches = { map { $_->branchcode => $_->unblessed } Koha::Libraries->search }; 1085 if ( $type ne 'opac' and C4::Context->boolean_preference('AutoLocation') ) { 1086 1087 # we have to check they are coming from the right ip range 1088 my $domain = $branches->{$branchcode}->{'branchip'}; 1089 $domain =~ s|\.\*||g; 1090 if ( $ip !~ /^$domain/ ) { 1091 $loggedin = 0; 1092 $cookie = $query->cookie( 1093 -name => 'CGISESSID', 1094 -value => '', 1095 -HttpOnly => 1 1096 ); 1097 $info{'wrongip'} = 1; 1098 } 1099 } It says that you have AutoLocation turned on and the "branchip" field of the branches table does not match your IP. It also says that you are using a non superlibrarian account. Could you confirm this? If the IP does not match, it is expected that you are rejected, but in that case it should be the same behaviour with other scripts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:30:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 18:30:08 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:30:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 18:30:12 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68934|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall --- Created attachment 70232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70232&action=edit Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off Test Plan: 1) Apply patch 2) Turn off AllowOnShelfHolds 3) Create a bib with one item, mark the item as 'on order' 4) Attempt to place a hold on the item, you should now be able to do so -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:45:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 18:45:51 +0000 Subject: [Koha-bugs] [Bug 18593] Suggestions aren' t updated when one biblio is merged with another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:45:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 18:45:54 +0000 Subject: [Koha-bugs] [Bug 18593] Suggestions aren' t updated when one biblio is merged with another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 --- Comment #5 from Jonathan Druart --- Created attachment 70233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70233&action=edit Bug 18593: Move suggestions when bibliographic records are merged When bibliographic records are merged, the suggestions.biblionumber field should be replaced with the new record. Ideally we should have kept an history of the merges, to know what was the original record. Now we cannot fix the broken links. Test plan: 1) Create a suggestion in OPAC 2) Accept the suggestion in staff 3) Add order from this suggestion 4) Go to cataloguing search and search for the record and another 5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists) 6) Verify that after merging, the new title displays in the acquisition record 7) Verify that the suggestion info no longer displays in basket >From Katrin's test plan: 8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated) => This is the title from suggestions.title, I think it makes sense to show this one. Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 19:46:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 18:46:15 +0000 Subject: [Koha-bugs] [Bug 18593] Suggestions aren' t updated when one biblio is merged with another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:19:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 19:19:33 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19906 [Bug 19906] Move template JavaScript to the footer: NORMARC editor plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:19:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 19:19:33 +0000 Subject: [Koha-bugs] [Bug 19906] New: Move template JavaScript to the footer: NORMARC editor plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19906 Bug ID: 19906 Summary: Move template JavaScript to the footer: NORMARC editor plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 17858 NORMARC plugin templates already have JavaScript at the bottom of the template instead of the top, but they should still be modified to be consistent with other templates which have been updated as part of Bug 17858. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:58:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 19:58:21 +0000 Subject: [Koha-bugs] [Bug 19906] Move template JavaScript to the footer: NORMARC editor plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19906 --- Comment #1 from Owen Leonard --- Created attachment 70234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70234&action=edit Bug 19906: Move template JavaScript to the footer: NORMARC editor plugins This patch updates NORMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a NORMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - normarc_field_007.tt - normarc_field_008.tt - normarc_leader.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:58:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 19:58:18 +0000 Subject: [Koha-bugs] [Bug 19906] Move template JavaScript to the footer: NORMARC editor plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19906 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 20:58:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 19:58:47 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com Status|Signed Off |Failed QA --- Comment #4 from Josef Moravec --- Hi Owen, looks good, but few thinks: So, if I want to update child to adult, and have more patron categories for adults, than I should see the form for choosing one of them, but I get blank page... Also the javascript function confirm_updatechild is defined twice: in members-menu.js and update-child.tt. Few buttons in patron toolbar on checkouts screen does not work - circulation.tt is not part of this patch and so does not include members-menu.js. I think you will fix this bug 19728, true? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 21:09:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 20:09:58 +0000 Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com Status|Signed Off |Failed QA --- Comment #6 from Josef Moravec --- The datepicker in import patrons tool is shown only by dateofbirth field. Should be also on dateexpiry and dateenrolled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:03:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:03:27 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:03:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:03:48 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:04:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:04:01 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68349|0 |1 is obsolete| | Attachment #68350|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 70235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70235&action=edit Bug 11046: Better handling of uncertain years for publicationyear This patch makes it possible that uncertain year like 18.. or 197x are converted to 1800 or 1970 in Koha field copyrightdate (MARC21) or publicationyear (UNIMARC). (The corresponding MARC record will not be changed obviously.) This change will allow for better results when sorting search results or list contents on copyrightdate. Currently, things like 18.. will sort together with zero. Note: The regex now allows four possible uncertain year markers: x or X, question mark or dot. Test plan: [1] Run t/db_dependent/Biblio/TransformMarcToKoha.t [2] Edit a biblio record. Save 18.. into 260c. Check biblio.copyrightdate. Signed-off-by: Marcel de Rooy Followed test plan, patch worked as described, it also passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:04:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:04:06 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #10 from Josef Moravec --- Created attachment 70236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70236&action=edit Bug 11046: Add the form YYY-? for uncertain years This form occurred in Dutch ISBD rules. The question mark should follow the hyphen(s). Test plan: Run t/db_dependent/Biblio/TransformMarcToKoha.t Signed-off-by: Marcel de Rooy TransformMarcToKoha tests passed. Also this patch passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:18:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:18:26 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68509|0 |1 is obsolete| | Attachment #68510|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 70237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70237&action=edit Bug 18417 - Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) To test: 1 - Apply patch 2 - Open advanced cataloging editor 3 - Try using Alt+P and Alt+C and note symbols are added 4 - Save record and ensure symbols are saved Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:18:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:18:31 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 --- Comment #9 from Josef Moravec --- Created attachment 70238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70238&action=edit Bug 18417: (follow-up) Document new shortcuts in dropdown Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:18:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:18:21 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:18:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:18:47 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:44:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:44:26 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 --- Comment #5 from Liz Rea --- Created attachment 70239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70239&action=edit Bug 19801 - Fixes for QA - Fixes indentation - changes messages to patron_messages (even though it's not like that on the circulation page.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:44:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:44:23 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:46:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:46:54 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #18 from Liz Rea --- Thankfully this still applies. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 2 22:50:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jan 2018 21:50:55 +0000 Subject: [Koha-bugs] [Bug 13376] Include a user-editable area/ page for terms and conditions of use in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #5 from Liz Rea --- This bug got derailed, I still think the original feature proposal is a good one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 01:21:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 00:21:05 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #143 from M. Tompsett --- (In reply to Josef Moravec from comment #142) > these patchset doesn't apply. Thanks for looking and noticing this. > So just few comments from quick reading of the > code: > > You don't have to change signature of GetHiddenItemnumbers, you can ask for > patron category here... And you can than leave the $search_context as is. I can't recall the reason off the top of my head, and even after rebasing this locally -- I have yet to test and put it back up. But I've got a feeling it had something to so with the nesting of some search functions which were not easily determined to be opac or intranet otherwise. > Also the "opac" param in GetMarcBiblio and EmbedItemsInMarcBiblio is not > needed, you can use C4::Context->interface when you need to know the > actual interface. It is better to pass it in my opinion to refactor the parameters list, so that test functions don't require special mocking to get the C4::Context function to return the correct value in different cases (like shell script utilities). And this makes maintenance for other changes in the future easier for others, and brings the code up to preferred coding style (https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_should_be_used_as_arguments) > And some squashing would be nice here ;) I was tweaking, testing, fixing, repeating multiple times. Also, smaller patches are easier to test individually. I will squash as much as possible. I do, however, not want to lose the fact that Aleisha Amohia put in a massive effort which helped me see how to solve my C4::Search mess problem that I had hit while working on originally in bug 10589. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 01:59:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 00:59:16 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #144 from Liz Rea --- a+ preserving attribution. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 02:27:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 01:27:39 +0000 Subject: [Koha-bugs] [Bug 19890] authorised value branches is not visible from dropdown in Admin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19890 Hugh Rundle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at hughr.me --- Comment #2 from Hugh Rundle --- Yep that would be perfect. That way it's clear they already exist, and also that authorised_values is not the place to change them. Something like "[category name] is listed here for information only. To change or add values for [category name] use [appropriate place]. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 02:42:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 01:42:06 +0000 Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837 --- Comment #3 from Nick Clemens --- Created attachment 70240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70240&action=edit Bug 19837 - Add error feedback for duplicatred or unfound cardnumbers To test: 1 - Enter some patrons on a list 2 - 'Enter multiple cardnumbers' 3 - Make sure to add some that are already in list, some that don't exist, and some new patrons 4 - Verify results are as expected with warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 02:43:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 01:43:11 +0000 Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- I added some error feedback, it could certainly be made prettier, take a look please Owen? Ideally we would be able to add by borrowernumber as well, but I think that is for another bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 02:46:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 01:46:05 +0000 Subject: [Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - " Cannot process file as an image" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898 --- Comment #3 from Craig --- (In reply to Jonathan Druart from comment #2) > The relevant code of the warning is: > > 1084 my $branches = { map { $_->branchcode => > $_->unblessed } Koha::Libraries->search }; > 1085 if ( $type ne 'opac' and > C4::Context->boolean_preference('AutoLocation') ) { > 1086 > 1087 # we have to check they are coming from the > right ip range > 1088 my $domain = > $branches->{$branchcode}->{'branchip'}; > 1089 $domain =~ s|\.\*||g; > 1090 if ( $ip !~ /^$domain/ ) { > 1091 $loggedin = 0; > 1092 $cookie = $query->cookie( > 1093 -name => 'CGISESSID', > 1094 -value => '', > 1095 -HttpOnly => 1 > 1096 ); > 1097 $info{'wrongip'} = 1; > 1098 } > 1099 } > > > It says that you have AutoLocation turned on and the "branchip" field of the > branches table does not match your IP. It also says that you are using a non > superlibrarian account. > > Could you confirm this? > If the IP does not match, it is expected that you are rejected, but in that > case it should be the same behaviour with other scripts. Hi Jonathan, Thanks for this. I am indeed using a superlibrarian account, so I'm surprised that it is reporting otherwise. I have only one patron in the system, me, and it was initially setup as superlibrarian staff. You are correct about Autolocation, it was turned on. But I have since disabled it. The IP address field in the bramches table is blank. Unfortunately, after turning off Autolocation, restarting Koha, and restarting memcache, the error still persists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 03:29:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 02:29:58 +0000 Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 03:30:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 02:30:02 +0000 Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 --- Comment #6 from Liz Rea --- Created attachment 70241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70241&action=edit Bug 16804 - semicolons break series search in 490 To test: * have OPACSuppression on * have a record with a 490 field a la: 490 _a something ; _v 123 * go to the opac and search for this record * click the Series link from the detail Without this patch, there will be no results. With this patch, you will get relevant results (possibly the same record back) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 03:31:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 02:31:05 +0000 Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Liz Rea --- Hi Katrin, I put a chopPunctuation on the href attribute, it'll chop of whatever ending punctuation people feel inclined to put there. What do you think? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 03:32:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 02:32:14 +0000 Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67622|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 03:47:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 02:47:57 +0000 Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 --- Comment #8 from Liz Rea --- well not *any*, specifically these: .:,;/ ' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 03:48:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 02:48:05 +0000 Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:41:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 09:41:27 +0000 Subject: [Koha-bugs] [Bug 19907] New: Email validation on patron add/edit not working Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Bug ID: 19907 Summary: Email validation on patron add/edit not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When entering a new patron or editing an existing one, the email address should be validated while typing. This is a regression to former behaviour. The validation still works as expected in other places like for library email in administration > libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:48:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 09:48:45 +0000 Subject: [Koha-bugs] [Bug 19908] New: Password should not be mandatory Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Bug ID: 19908 Summary: Password should not be mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When password is not set as a mandatory patron field, it should not be required. To test: - make sure BorrowerMandatoryField is empty and doesn't list password - add a new patron, leave password fields empty - try to save - you will be forced to enter a password with the field now being highlighted as required. I have also tried changing RequireStrongPassword and emptying minPasswordLength. Often libraries will leave password and username empty for patrons that won't ever use the OPAC. For example when they are not using the OPAC functionalities in general or for internal users. Making the password mandatory is a regression to former behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:49:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 09:49:46 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Depends on| |18298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 [Bug 18298] Allow enforcing password complexity -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 10:49:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 09:49:46 +0000 Subject: [Koha-bugs] [Bug 18298] Allow enforcing password complexity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 [Bug 19908] Password should not be mandatory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:05:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:05:55 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #1 from Josef Moravec --- Created attachment 70242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70242&action=edit Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference Test plan: 0) Do not apply the patch, note the password field is always required 1) Apply the patch 2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting 3) Use "Change password" button in patron toolbar, the password field should be never required here - when leaved blank, the password is unchanged 4) Play with minPasswordLength and RequireStrongPassword preferences, to ensure they work as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:05:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:05:53 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:06:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:06:24 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:08:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:08:50 +0000 Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | CC| |josef.moravec at gmail.com Status|NEW |ASSIGNED Depends on| |19908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 [Bug 19908] Password should not be mandatory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:08:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:08:50 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19907 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 [Bug 19907] Email validation on patron add/edit not working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:14:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:14:29 +0000 Subject: [Koha-bugs] [Bug 19909] New: Show attributes in patron search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 Bug ID: 19909 Summary: Show attributes in patron search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This will add a new column (hidden by default) in the results table to displays all attributes associated to the corresponding patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:15:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:15:01 +0000 Subject: [Koha-bugs] [Bug 19909] Show attributes in patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 --- Comment #1 from Julian Maurice --- Created attachment 70243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70243&action=edit Bug 19909: Show attributes in patron search results Add a new column (hidden by default) in the results table which displays all attributes associated to the corresponding patron. New subroutine Koha::Patron::Attribute::display_value that returns the authorised value description and defaults to the raw value if the attribute's type is not associated to an authorised value category Test plan: 1. Create some patron attribute types, with and without an associated authorised value category 2. Choose an existing patron and set a value for each attribute 3. Go to patron search and do a search that will return your patron (and some others to avoid the redirection) 4. Show column 'Extended attributes' by clicking on 'Column visibility' button 5. Note that all attributes are displayed correctly 6. prove t/db_dependent/Koha/Patron/Attributes.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:15:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:15:11 +0000 Subject: [Koha-bugs] [Bug 19909] Show attributes in patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:23:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:23:34 +0000 Subject: [Koha-bugs] [Bug 19698] "Add message" for patron don' t use OPAC description if message type is OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19698 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #2 from Sophie MEYNIEUX --- Yes they are displayed in the right place but not with the right description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:24:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:24:14 +0000 Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 12:24:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 11:24:17 +0000 Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 --- Comment #1 from Josef Moravec --- Created attachment 70244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70244&action=edit Bug 19907: Fix email validation in patron edit form Test plan: 0) Confirm that email validation is not working in add/edit patron form 1) Apply the patch 2) Edit/add patron, the e-mail validation should be working now 3) Ensure the password validation is still working (use test plan from bug 19908) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:23:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 12:23:13 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #14 from David Gustafsson --- Hi! I'm not sure I understand, but where you thinking of skipping the pure-SQL optimization but keeping the one loading multiple items at once using search instead of find and then unblessing? Unfortunately that does not make that much of a difference it seems. I tried benchmarking with a biblio with 10 items (which is pretty rare, think most of our biblios has only 1 or 2 items): Loading each item separately took 372 seconds. Loading multiple (10) items at once took 47 seconds: This is not bad (about 8 times faster, for 10 items, which is to be expected since results in 1/10 of DBIx calls). Unfortunately since most libraries probably only have a couple of items per biblio, averaging below 2, in practice the speedup is probably below 2 times faster. With the pure SQL variant loading multiple items it took 7.4 seconds. All benchmarks where performed with item-level_types = 1, and loaded the items 20000 times. I tried to make sure serials where not affected by adjusting the code for the fethching of multiple items, and all tests passes (not sure if there are tests for serials), but I could have another look at this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:30:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 12:30:54 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #15 from Tom?s Cohen Arazi --- (In reply to David Gustafsson from comment #14) > Hi! I'm not sure I understand, but where you thinking of skipping the > pure-SQL optimization but keeping the one loading multiple items at once > using search instead of find and then unblessing? Unfortunately that does > not make that much of a difference it seems. DBIx::Class is the same as using plain DBI. So the speed gain doesn't come from the plain SQL (you could write the same query using the SQL::Abstract syntax DBIC uses), but from the fact that you are using a more fine-tuned approach on the query, to get all data at the same time. What I think Jonathan is saying, is that we need to solve this in a way that doesn't break our object system for the rest of the functionalities. I will try to think about it today too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 13:49:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 12:49:45 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #16 from David Gustafsson --- Just to clarify, the performance gain comes from using DBI directly. DBIx::Abstract could potentially be faster then DBIx::Class::ResultSet::search, but in my opinion not much is gained by the abstraction for such a simple at static query. If you are saying that the speed gain mainly comes from loading multiple items at once and not the low-level SQL, that is actually not the case as demonstrated by the previous benchmark. Loading multiple items with search (10 at the time) takes 50 seconds. Loading multiple items (10 at the time) with pure-SQL 7.4 seconds. And as previously noted, 10 items is pretty rare, so in practice the code using search will produce an even worse result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:00:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:00:43 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #17 from Tom?s Cohen Arazi --- (In reply to David Gustafsson from comment #16) > Just to clarify, the performance gain comes from using DBI directly. > DBIx::Abstract could potentially be faster then > DBIx::Class::ResultSet::search, but in my opinion not much is gained by the > abstraction for such a simple at static query. > > If you are saying that the speed gain mainly comes from loading multiple > items at once and not the low-level SQL, that is actually not the case as > demonstrated by the previous benchmark. > > Loading multiple items with search (10 at the time) takes 50 seconds. > > Loading multiple items (10 at the time) with pure-SQL 7.4 seconds. > > And as previously noted, 10 items is pretty rare, so in practice the code > using search will produce an even worse result. Can you profile it using ntyprof? I bet the bottleneck comes from effective_itemtype when unblessing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:17:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:17:59 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:18:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:18:01 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 --- Comment #4 from Nick Clemens --- Created attachment 70245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70245&action=edit Bug 18947 - Use report id to retrieve saved SQL instead of passing param This patch takes some of the code when executing report and moves it to a sub to be reused when downloading To test: 1 - Run some very long report (see comment #1) 2 - Try to download, erk! 3 - Apply patch 4 - Run report, results hould not have changed 5 - Try to download, success! 6 - Ensure reports work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:18:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:18:25 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:18:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:18:53 +0000 Subject: [Koha-bugs] [Bug 19803] SQL report export can fail HTTP 414 Request-URI Too Large In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19803 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 18497 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:18:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:18:53 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Nick Clemens --- *** Bug 19803 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:33:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:33:14 +0000 Subject: [Koha-bugs] [Bug 19903] Add Koha::Patron::Restrictions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19903 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:39:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:39:16 +0000 Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:41:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:41:55 +0000 Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #16 from Fridolin SOMERS --- Ah the patch does not apply easily. I it not a major problem, I choose not to backport to 17.05.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:41:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:41:56 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Bug 18403 depends on bug 19456, which changed state. Bug 19456 Summary: Some pages title tag contains html https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:43:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:43:45 +0000 Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.05.x, will be in v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 14:58:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 13:58:52 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #18 from David Gustafsson --- When item-level_itypes = 0, the code run is pretty similar to master with patch applied, the only difference being ->search is used to fetch multiple items instead of ->find for each one. But this only results in a pretty small performance gain as demonstrated by the above benchmarks. So the interesting case to benchmark is when item-level_itypes = 1 (which also seems to be the most commonly used setting), and the NYTProf screenshots attached should clearly show that DBIx::Class::ResultSet::find (or DBIx::Class::ResultSet::search which has similar performance) is the culprit. But I can generate two new ones for DBIx::Class::ResultSet::search with multiple items (10 like in the previous example) to show that the same is true for ->search when loading multiple items. effective_itemtype() is only expensive when item-level_itypes = 0 the biblio is fetched though a relation, but this fix is not designed to address the case when item-level_itypes = 0 since it is much harder to optimize. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:07:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:07:00 +0000 Subject: [Koha-bugs] [Bug 19910] New: Download report as 'Comma separated' is misleading Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Bug ID: 19910 Summary: Download report as 'Comma separated' is misleading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The system preference 'delimiter' is actually used for determining how the report will be formatted, we should name it accordingly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:07:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:07:10 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:09:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:09:17 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 [Bug 19910] Download report as 'Comma separated' is misleading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:09:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:09:17 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18497 Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 [Bug 18497] Downloading a report passes the constructed SQL as a parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:09:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:09:19 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #1 from Nick Clemens --- Created attachment 70246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70246&action=edit Bug 19910 - Use the delimiter syspref to name download link To test: 1 - Set delimiter syspref to anything but comma 2 - Donwload report results as comma separated text 3 - They actually follow the syspref 4 - Apply patch 5 - Download link should now match pref selection 6 - Change pref, note link changes 7 - Verify things still work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:13:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:13:55 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #19 from David Gustafsson --- Created attachment 70247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70247&action=edit DBIX_search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:14:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:14:25 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #20 from David Gustafsson --- Created attachment 70248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70248&action=edit search_unblessed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:21:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:21:58 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #21 from David Gustafsson --- Uploaded the benchmarks. Koha::Object::unblessed takes 3.63s, and Koha::Schema::Result::Item::effective_itemtype 3.70s (of 157s) when item-level_itypes = 1, so not much of an impact. Also: with patch applied, C4::Context::dbh takes an unreasonable 3.71s (of 17.6s), but that can be fixed using this patch: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:25:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:25:43 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:52:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:52:53 +0000 Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 --- Comment #10 from David Gustafsson --- :) Thanks for the tests! Will apply and test this tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:58:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:58:14 +0000 Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 15:58:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 14:58:16 +0000 Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69822|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 70249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70249&action=edit Bug 19819: C4::Context->dbh is unreasonably slow Locally cache Koha::Database->schema->storage->dbh in state variable in C4::Context->dbh to get rid of retrieval overhead Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:14:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 15:14:36 +0000 Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from David Gustafsson --- I had time to do so today. Don't know if I am allowed to sign this off, but can vouch for that the tests are working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:15:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 15:15:47 +0000 Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:17:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 15:17:10 +0000 Subject: [Koha-bugs] [Bug 18984] Remove support for NORMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:22:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 15:22:42 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- On members/member-password.pl I can submit the form without confirming the password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:25:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 15:25:47 +0000 Subject: [Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - " Cannot process file as an image" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898 --- Comment #4 from Jonathan Druart --- (In reply to Craig from comment #3) > Unfortunately, after turning off Autolocation, restarting Koha, and > restarting memcache, the error still persists. Do you still have the warning in the logs? What is the exact version of Koha you are using? Did you try on a sandbox? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:47:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 15:47:11 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69748|0 |1 is obsolete| | --- Comment #6 from Jon Knight --- Created attachment 70250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70250&action=edit Bug 10032: Uncertain prices hide 'close basket' without explanation Added disabled "Close this basket" button when uncertain prices are present. Note that whilst this has a "title" attribute, there is no tooltip shown because JQueryUI disabled buttons don't get DOM events. To test: 1) Before applying the patch, go to staff UI, and select Acquisitions, pick one of your existing vendors (or create a new one) and then open a new basket (call it anything you want). 2) Add a new (empty) record order to the basket. 3) Give the new record a made up title, add a single item (no need to fill in any details), set a price of 10.00 and check the "Uncertain price" checkbox before saving the record. 4) Confirm that the resulting summary page has a button bar that does NOT include any button for closing the basket. 5) Modify the record and remove the check mark from the "Uncertain price" checkbox before saving. 6) Confirm that the resulting basket summary page button bar now does have a "Close this basket" button (as the basket no longer has uncertain prices). 7) Apply the patch. 8) Modify the record again to check the "Uncertain price" checkbox again, then save it. 9) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button but that this button is greyed out and inoperative. 10) Modify the record again to remove the check mark in the "Uncertain price" checkbox, then save the record. 11) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button which is now active (as the order no longer has an uncertain price). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 16:55:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 15:55:27 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #22 from Jonathan Druart --- David, I was talking about something like that: diff --git a/C4/Biblio.pm b/C4/Biblio.pm index b26c767ef8..373d9f8330 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -2840,7 +2840,7 @@ sub EmbedItemsInMarcBiblio { && ( C4::Context->preference('OpacHiddenItems') !~ /^\s*$/ ); require C4::Items; - my $items = C4::Items::GetItems($itemnumbers); + my $items = Koha::Items->search({ itemnumber => { -in => $itemnumbers } })->unblessed; if ($opachiddenitems) { my %hidden_items = map { $_ => undef } C4::Items::GetHiddenItemnumbers(@{$items}); # Reduce items to non hidden items diff --git a/Koha/Item.pm b/Koha/Item.pm index bea05f8317..73306f54a2 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -235,6 +235,14 @@ sub current_holds { return Koha::Holds->_new_from_dbic($hold_rs); } +sub unblessed { + my ($self) = @_; + my $itype = $self->effective_itemtype; + my $h = $self->SUPER->unblessed; + $h->{itype} = $itype; + return $h; +} Can you share the script you use to benchmark, I could use it to compare different situations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:07:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 16:07:06 +0000 Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- Did you try this patch in production? I am expecting regressions on the issues with had on bug 14778 (like "server has gone away"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:16:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 16:16:29 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #23 from David Gustafsson --- I was using this to benchmark: https://gist.github.com/gnucifer/5b2119f656592c4d6b3f6dab0b8087f1 Which is more or less equivalent to your code example (when comparing approaches to improve performance). And this to run the benchmark: https://gist.github.com/gnucifer/fa3bb31d49f1258a4d1af270d235d76f (biblionumber probably needs replacing if running on different instance). So to replace find with search using this approach will unfortunately not increase performance very much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:21:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 16:21:20 +0000 Subject: [Koha-bugs] [Bug 19698] "Add message" for patron don' t use OPAC description if message type is OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Sophie, I think the authorised_value is used in an untypical way here (like MAN_INV or INVENTORY). It allows you to store a text snippet or template for a text that then can be changed and edited before saving the message. When the message is pulled for display, it will pull the stored text from the database, the authorised_value code is not stored. Because of this the current behaviour makes sense to me - the OPAC value has no meaning here. I think if we wanted it to pull different template texts depending on if you selected staff or OPAC we'd need to use Ajax similar to what we do for statistic values depending on fund selection on the acquisition order page. It might also cause problems if the text will be overwritten after you already edited it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:21:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 16:21:38 +0000 Subject: [Koha-bugs] [Bug 19698] "Add message" for patron don' t use OPAC description if message type is OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:23:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 16:23:26 +0000 Subject: [Koha-bugs] [Bug 19890] authorised value branches is not visible from dropdown in Admin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19890 --- Comment #3 from Jonathan Druart --- I have just tried: If you try to create a AV category "branches", there is a warning box with "The authorized value category 'branches', 'itemtypes' and 'cn_source' are used internally by Koha and are not valid." That seems enough to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:24:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 16:24:45 +0000 Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 --- Comment #10 from David Gustafsson --- Good catch, I have only run it locally, but it will be included the next release for us. I'm not very knowledge about the inner working of Plack, but if the connection is persisted over time, and never closed, I understand how this can be an issue. I could try too look into this some more trying to figure out if the current fix if safe, and if not if there is some other way of going about this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 17:36:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 16:36:31 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #24 from David Gustafsson --- There is by the way a way of getting equivalent performance (as the SQL-hack) out of GetItems, if biblios where batch loaded all the way down. (Multiple biblio ids sent to EmbedItemsInMarcBiblio so that all items could be loaded in one batch (requireing requiring only one search query for x number of biblios). But this would be a much more complicated change, and require existing code to use this new API (loading multiple biblios at once). Still, might be worth having a look at in the long run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:15:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 17:15:39 +0000 Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 tmcmahon at wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tmcmahon at wlpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 18:15:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 17:15:41 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 tmcmahon at wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tmcmahon at wlpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:16:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 18:16:55 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #25 from Jonathan Druart --- We, of course, know that an ORM will impact performance a bit. I do not think the script you are testing to compare is fair, you are using the DBMS cache as the query is always the same. I think we should use a loop on all X biblionumbers, then retrieve the items info. With DBIx::Class::ResultClass::HashRefInflator, I'd expect more x4 instead of x10, which is still to high, I admit. If we have to provide a way to fetch a row from its id, I would prefer to introduce a generic way (at Koha::Object level) to do it and use it only for batch/heavy operations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:24:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 18:24:07 +0000 Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |J.P.Knight at lboro.ac.uk --- Comment #2 from Jon Knight --- Tried to apply the patch to an up-to-date kohadevbox but it fails: vagrant at kohadevbox:kohaclone(master)$ git fetch vagrant at kohadevbox:kohaclone(master)$ git rebase origin/master Current branch master is up to date. vagrant at kohadevbox:kohaclone(master)$ git checkout -b bug_19907 Switched to a new branch 'bug_19907' vagrant at kohadevbox:kohaclone(bug_19907)$ git bz apply 19907 Bug 19907 - Email validation on patron add/edit not working 70244 - Bug 19907: Fix email validation in patron edit form Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19907: Fix email validation in patron edit form Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Failed to merge in the changes. Patch failed at 0001 Bug 19907: Fix email validation in patron edit form The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19907-Fix-email-validation-in-patron-edit-form-LYJrg8.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:24:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 18:24:38 +0000 Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:27:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 18:27:31 +0000 Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 --- Comment #3 from Jon Knight --- (In reply to Jon Knight from comment #2) > Tried to apply the patch to an up-to-date kohadevbox but it fails: Ignore me - I didn't notice the dependency on 19908. However as that bug currently has an issue with not requiring the second entry of the password, should testing this patch wait until that is fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:27:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 18:27:29 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #26 from Jonathan Druart --- Created attachment 70251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70251&action=edit Bug 19884: Add benchmark script to compare DBIC vs plain SQL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:27:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 18:27:51 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #27 from Jonathan Druart --- Still x10 :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:38:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 18:38:51 +0000 Subject: [Koha-bugs] [Bug 19911] New: Passwords displayed to user during self-registration are not HTML-encoded Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Bug ID: 19911 Summary: Passwords displayed to user during self-registration are not HTML-encoded Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: library at sll.texas.gov QA Contact: testopia at bugs.koha-community.org Created attachment 70252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70252&action=edit Example of the generated password not displaying properly due to the less-than character treated as opening HTML tag If self-registration is enabled and the PatronSelfRegistrationPrefillForm system preference is set to "Display and prefill," self-registered users are shown their password upon successfully registering. If the password contains a less-than character, browsers treat this as the beginning of an HTML element, and so the less-than character and anything after it does not display since the password is not HTML-encoded. If Koha is set to generate passwords automatically during self-registration (i.e., users are not allowed or required to enter a password in the self-registration form), any generated password containing the less-than character will not display correctly. Users who are expected to copy/save their password at this time cannot do so, and there is no way to recover that generated password. Attached is a screenshot showing what I mean. A solution would to HTML-encode the passwords when they are displayed as part of the self-registration process, regardless of whether the user must verify their e-mail address first (opac-registration-verify.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 19:57:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 18:57:21 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Arturo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library at sll.texas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:15:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 19:15:33 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:15:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 19:15:38 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:17:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 19:17:04 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 --- Comment #1 from Jonathan Druart --- Created attachment 70253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70253&action=edit Bug 19911: Escape password value during self-registration confirmation The password must be correctly escape, it can contains html character and break the display. Test plan: Apply first patch and confirm that the display is broken Apply second patch (this one) and confirm that the display is fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:17:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 19:17:00 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:24:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 19:24:36 +0000 Subject: [Koha-bugs] [Bug 13044] Deprecate old book drop mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 --- Comment #3 from Kyle M Hall --- I suppose we could make bookdrop mode find the last date open and recalculate the fine in full from there. That way it looks the same from a user perspective. The problem with bookdrop mode is that it is quite fragile. For example, if fines.pl doesn't run for a night, and does the following night, then using bookdrop mode will decrement the fine by double the expected amount. The backdating returns feature does not suffer from this kind of fragility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:34:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 19:34:14 +0000 Subject: [Koha-bugs] [Bug 13376] Include a user-editable area/ page for terms and conditions of use in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- While a general solution for adding pages to the OPAC would be nice, I agree this would be a good addition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 20:44:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 19:44:14 +0000 Subject: [Koha-bugs] [Bug 19912] New: PrintNoticesMaxLines message should print after list of items not at end of notice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19912 Bug ID: 19912 Summary: PrintNoticesMaxLines message should print after list of items not at end of notice Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: michael at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 70254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70254&action=edit showing message at bottom of notice PrintNoticesMaxLines prints a message about too many items to list on an overdue notice, but prints it at the very bottom of the notice. It would be more clear to the reader if this message could follow the list of items on the notice, as they might not notice the message at the bottom of the page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 21:03:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 20:03:54 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #28 from Jonathan Druart --- *Thinking loud Months ago I wrote Koha::Object::Simple (for a different need, it was AV and caching related). Now it sounds like we could need something similar here, see https://github.com/joubu/Koha/commits/koha_object_simple to understand what I have in mind (this is a very quick draft!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 22:10:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 21:10:27 +0000 Subject: [Koha-bugs] [Bug 18754] Translatability: Get rid of exposed tt directives in opac-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 [Bug 19913] Embedded HTML5 videos are broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 22:10:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 21:10:27 +0000 Subject: [Koha-bugs] [Bug 19913] New: Embedded HTML5 videos are broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Bug ID: 19913 Summary: Embedded HTML5 videos are broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 18754 The video element is badly generated. Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754 [Bug 18754] Translatability: Get rid of exposed tt directives in opac-detail.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 22:15:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 21:15:51 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 3 22:15:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 21:15:54 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 --- Comment #1 from Jonathan Druart --- Created attachment 70255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70255&action=edit Bug 19913: Fix embedded HTML5 videos at the OPAC Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt A space is missing between 'source' and 'src' Test plan: Set HTML5MediaEnabled to OPAC Put a video link to 856$u See the OPAC detail page, tab video, click the video => Should play with this patch applied Note that this does not affect intranet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 00:09:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 23:09:39 +0000 Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer --- There is a complaint in the QA tools about a file being added and removed - this is due to the change from .perl to .sql for the file. As all 3 patches have different authors, this can't be fixed by squashing (not a blocker in my opinion). FAIL installer/data/mysql/atomicupdate/Bug-18231-id_to_ussingrules_table.sql FAIL git manipulation The file has been added and deleted in the same patchset t/db_dependent/Koha/IssuingRules.t are ok. BUT: Cloning isusing rules from one of the library (default to Union for example) fails: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 00:44:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jan 2018 23:44:59 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #165 from Katrin Fischer --- I've taken a look at the patches for a first QA review. 1) Currently fails QA script: FAIL t/db_dependent/Koha/Patrons/Import.t FAIL critic "$headerrow_0" is declared but not used at line 320, column 5. Unused variables clutter code and make it harder to read. 2) Tests fail: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ perl t/db_dependent/Koha/Patrons/Import.t 1..124 ok 1 - use Koha::Patrons::Import; ok 2 - An object of class 'Koha::Patrons::Import' isa 'Koha::Patrons::Import' # Subtest: test_methods 1..1 ok 1 - Koha::Patrons::Import->can(...) ok 3 - test_methods # Subtest: test_attributes 1..1 ok 1 - Koha::Patrons::Import->can(...) ok 4 - test_attributes ok 5 - Koha::Patrons::Import->import_patrons carps if no file handle is passed ok 6 - Got the expected undef from import_patrons with nothing much ok 7 - Koha::Patrons::Import->import_patrons carps if no file handle is passed ok 8 - Got the expected undef from import_patrons with no file handle Use of uninitialized value $matchpoint in string eq at /home/vagrant/kohaclone/Koha/Patrons/Import.pm line 170, <$handle_1> line 2. # Looks like your test exited with 255 just after 8. 3) Might be me, but trying to run the script always gives me the help, no error or anything. Used -c and -f with a random file. Can you please take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 01:30:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 00:30:57 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add custom export notices |Add custom export formats | |for bibliographic records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 01:34:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 00:34:07 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #39 from Katrin Fischer --- Patch doesn't apply, please also take a look at comment#38. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17006: Add API route for changing patron's password Using index info to reconstruct a base tree... M Koha/Patron.pm M Koha/REST/V1/Patron.pm M api/v1/swagger/paths.json M api/v1/swagger/paths/patrons.json M t/db_dependent/api/v1/patrons.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/api/v1/patrons.t Auto-merging api/v1/swagger/paths/patrons.json Auto-merging api/v1/swagger/paths.json CONFLICT (content): Merge conflict in api/v1/swagger/paths.json Auto-merging Koha/REST/V1/Patron.pm Auto-merging Koha/Patron.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 17006: Add API route for changing patron's password The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17006-Add-API-route-for-changing-patrons-passw-7eNHth.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:03:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:03:28 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #145 from M. Tompsett --- Created attachment 70256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70256&action=edit Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Edit: Fixing merge conflicts in - t/db_dependent/Items.t - t/db_dependent/Search.t - C4/Search.pm Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items Signed-off-by: Claire Gravely Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:03:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:03:34 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #146 from M. Tompsett --- Created attachment 70257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70257&action=edit Bug 14385 Followup: C4::Borrowers not found GetMember is in C4::Members, not C4::Borrowers Signed-off-by: Claire Gravely Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:03:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:03:40 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #147 from M. Tompsett --- Created attachment 70258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70258&action=edit Bug 14385: Followup: changes to sysprefs.sql and atomicupdate Run updatedatabase.pl when testing Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:03:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:03:47 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #148 from M. Tompsett --- Created attachment 70259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70259&action=edit Bug 14385: A lot of patches - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:05:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:05:21 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66520|0 |1 is obsolete| | Attachment #66521|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:05:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:05:26 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66522|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:05:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:05:21 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:05:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:05:48 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:05:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:05:55 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:05:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:05:39 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:06:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:06:03 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66526|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:06:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:06:09 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:06:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:06:17 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66528|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:06:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:06:25 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:06:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:06:31 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66530|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:06:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:06:38 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:06:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:06:43 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:06:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:06:50 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66533|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:06:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:06:56 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:07:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:07:03 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66535|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:07:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:07:10 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66536|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:07:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:07:16 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66537|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:07:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:07:25 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66538|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:07:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:07:35 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:07:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:07:41 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:07:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:07:48 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:07:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:07:55 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:08:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:08:01 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66543|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:08:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:08:09 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66544|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:08:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:08:14 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66545|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 02:11:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 01:11:20 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #149 from M. Tompsett --- Still in the midst of retesting after squash. Once I'm happy, I'll post back up a full test plan, and change to needs sign off, just to make sure I didn't miss something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:31:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 07:31:21 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:31:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 07:31:24 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67128|0 |1 is obsolete| | Attachment #67129|0 |1 is obsolete| | Attachment #67130|0 |1 is obsolete| | Attachment #67131|0 |1 is obsolete| | Attachment #67132|0 |1 is obsolete| | --- Comment #40 from Josef Moravec --- Created attachment 70260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70260&action=edit Bug 17006: Add API route for changing patron's password PATCH /patrons/{borrowernumber}/password (change password) Required body params: - current_password - new_password To test: 1. Apply patch 2. Run t/db_dependent/api/v1/patrons.t 3. Send PATCH request to http://library/api/v1/patrons/YYY/password where YYY is existing borrowernumber (borrowers flag required) 4. Make sure that password was changed. 5. Try also too short password, and wrong current password and observe that errors are displayed appropriately. You may find this useful for testing: curl -X PATCH http://library/api/v1/patrons/123/password --data '{"current_password":"123456", "new_password":"1234"}' --cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10' Signed-off-by: Aleisha Amohia Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:31:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 07:31:28 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #41 from Josef Moravec --- Created attachment 70261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70261&action=edit Bug 17006: Respect system preference "OpacPasswordChange" Allow patron to change their own password without borrowers-flag only if OpacPasswordChange system preference is enabled. To test: 1. Apply patch 2. Run t/db_dependent/api/v1/patrons.t 3. Set OpacPasswordChange system preference to "Don't allow". 4. Send PATCH request to http://library/api/v1/patrons/YYY/password where YYY is existing borrowernumber for a borrower that does not have any permissions 5. Observe permission error. 6. Set OpacPasswordChange system preference to "Allow". 7. Repeat step 4 and make sure that password was changed. Signed-off-by: Aleisha Amohia Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:31:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 07:31:32 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #42 from Josef Moravec --- Created attachment 70262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70262&action=edit Bug 17006: (follow-up) Test for changing another user's password The previous patches work for changing your own password, but the tests are lacking a case where librarian attempts to change patron's password. This feature was unnoticed and not implemented. To test: 1. Run t/db_dependent/api/v1/patrons.t 2. Observe failing test 3. Proceed to next patch to fix the failing test Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:31:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 07:31:36 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #43 from Josef Moravec --- Created attachment 70263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70263&action=edit Bug 17006: (follow-up) Let librarians change patron's passwords This should obviously be part of this feature but was left unnoticed in the first patch. If user has "borrowers"-flag, they should be able to change patron's password without providing old password. To test: 1. Run t/db_dependent/api/v1/patrons.t 2. Observe failing test 3. Apply patch 4. Run t/db_dependent/api/v1/patrons.t 5. Observe passing test 6. Send PATCH request to http://library/api/v1/patrons/YYY/password where YYY is existing borrowernumber (borrowers flag required) and where YYY is not the same borrowernumber as your logged-in user's borrowernumber 7. Make sure that password was changed for YYY. You may find this useful for testing: curl -X PATCH http://library/api/v1/patrons/123/password \ --data '{"new_password":"1234"}' \ --cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10' Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:31:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 07:31:40 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #44 from Josef Moravec --- Created attachment 70264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70264&action=edit Bug 17006: (follow-up) Use Koha::Exceptions for change password endpoint Koha::Exceptions are a nice way to handle erros and they should be used much more than they are now. This patch adds Koha::Exceptions into Koha::Patron->change_password_to sub and catches the exceptions in the controller. 1. Apply patch 2. Run t/db_dependent/api/v1/patrons.t 3. Send PATCH request to http://library/api/v1/patrons/YYY/password where YYY is existing borrowernumber (borrowers flag required) 4. Make sure that password was changed. 5. Try also too short password, and wrong current password and observe that errors are displayed appropriately. curl -X PATCH http://library/api/v1/patrons/123/password \ --data '{"current_password":"123", "new_password":"1234"}' \ --cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10' Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 08:32:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 07:32:04 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #45 from Josef Moravec --- Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:06:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:06:52 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:07:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:07:04 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #166 from Jonathan Druart --- Created attachment 70265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70265&action=edit Bug 12598: Remove warnings from tests and make them pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:07:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:07:19 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #167 from Jonathan Druart --- Created attachment 70266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70266&action=edit Bug 12598: Use Pod::Usage and make the help more explicit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:09:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:09:55 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #168 from Jonathan Druart --- (In reply to Katrin Fischer from comment #165) > I've taken a look at the patches for a first QA review. 1 & 2 have been fixed. > 3) Might be me, but trying to run the script always gives me the help, no > error or anything. Used -c and -f with a random file. I improved the POD for the script, --matchpoint is required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:23:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:23:39 +0000 Subject: [Koha-bugs] [Bug 19914] New: Cannot locate the "Delete" in the library list table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Bug ID: 19914 Summary: Cannot locate the "Delete" in the library list table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 19243 On the library list table, a link (href=/cgi-bin/koha/admin/branches.pl?op=delete_confirm&branchcode=[% library.branchcode %]") has been replaced with a button (on bug 19560). On bug 19243 (Selenium tests) we need an easy way to locate this button, so we should add an id to this element. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 [Bug 19243] Selenium test for testing the administration module functionality - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:23:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:23:39 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19914 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 [Bug 19914] Cannot locate the "Delete" in the library list table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:29:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:29:03 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:29:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:29:07 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 --- Comment #1 from Jonathan Druart --- Created attachment 70267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70267&action=edit Bug 19914: Add an id to the Delete button on the library list view To ease selenium tests, see bug 19243. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:30:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:30:54 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19243 Depends on|19243 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 [Bug 19243] Selenium test for testing the administration module functionality - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:30:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:30:54 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19914 | Depends on| |19914 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 [Bug 19914] Cannot locate the "Delete" in the library list table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:31:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:31:50 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 --- Comment #31 from Jonathan Druart --- Created attachment 70269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70269&action=edit Bug 19243: Fix tests for AV The tricky part here was to find an alternative for ends-with in Xpath version 1 Indeed there are 2 button with "/admin/authorised_values.pl?op=add_form", and the first one was picked (/admin/authorised_values.pl?op=add_form&category=Asort1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:31:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:31:59 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 --- Comment #32 from Jonathan Druart --- Created attachment 70270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70270&action=edit Bug 19243: Fix tests for patron categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:31:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:31:45 +0000 Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70162|0 |1 is obsolete| | Attachment #70163|0 |1 is obsolete| | Attachment #70164|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 70268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70268&action=edit Bug 19243: The "delete library" is now a button with id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 14:55:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 13:55:09 +0000 Subject: [Koha-bugs] [Bug 6812] Set up enrollment, renewal, duplicate card, hold fees by branch and memberhip category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6812 Anne Murray changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne.murray at eastdunbarton.g | |ov.uk --- Comment #2 from Anne Murray --- It would be useful to have hold fees for different itypes within the patron category. All our junior books don't have a fee, but when adults request a junior book, we have to waive the fee. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:02:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 14:02:22 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 --- Comment #2 from Jonathan Druart --- Created attachment 70271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70271&action=edit Bug 19911: Do not escape html characters when saving passwords When the password is not generated automatically, we should not escape the html characters. Otherwise it will be changed without any warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:28:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 14:28:20 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #29 from David Gustafsson --- Thanks, I looked through the code. My general feeling is it would be better for an optimized more low level interface to just fetch the data still would reside under the Koha::Objects namespace, since the table metadata should be available there, and having to manage basically the same meta-data in multiple places creates a possible source for bugs. I can perhaps have a look at how feasible it would be to introduce a general search_unblessed for Koha::Objects (as suggested), using the available metadata, and introducing some new metadata for search conditions for example. In my opinion this still might be overkill since items are probably the only Koha entity in need of this heavy optimization. Creating a special case (with admittedly pretty ugly code) communicates more clearly that this really is a hack, and not something that one would/should generally use. Regarding performance and DBMS cache, I did initially benchmark this with production data, but decided to provide a benchmarking script requiring only one biblio with items so it would be easier for someone else to reproduce. There might be a difference in results, but not depending on DBMS cache. I think the SQL-execution constitutes a very small proportion of the execution time (when running un-cached queries with production data, not repeating the same query. 1.84s was spent by mysql executing the query (DBI::st::execute), of total 462s, so 0.4% of total time is spent executing SQL, the rest is data-mangling in Perl (if I'm not missing something). There was however a 30x difference in the results I posted earlier in this thread, and that may be an artificial result (since I'm only getting around 10x when running with production data). I check the average number of items per biblio for us, and its about 1.4. (SELECT AVG(item_count) FROM (select biblionumber, count(itemnumber) as item_count FROM items GROUP BY biblionumber) as item_counts). So to load items in batches of 10 is really not representative of production data. Running this script (https://gist.github.com/gnucifer/84b5ede7b06f0f4103400f8c89714f52) with 2000 items, in batches of 2, for our production data takes 256s, and 49s with patch. So 5x differance. In batches of 1 the difference should be around 8-10. I might explore the option of instead try working with biblios in batches, and load all the items for a batch of biblios at a time. Then the horrible DBIx-performance should not matter much at all since there is only one search query for items for every x number of biblios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:30:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 14:30:33 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 --- Comment #7 from Owen Leonard --- Created attachment 70272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70272&action=edit Bug 10032: (Follow-up) Move title attribute to button container This patch modifies the "Close basket" button markup so that the title attribute on a disabled button is added to the button wrapper
instead of the tag. This allows the title attribute tooltip to appear when the cursor is hovered over the button. To test, follow the original patch's test plan and confirm that when the "Close basket" button is disabled, hovering the mouse over the button triggers the title attribute tooltip. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:42:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 14:42:07 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70267|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 70273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70273&action=edit Bug 19914: Add an id to the Delete button on the library list view To ease selenium tests, see bug 19243. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:42:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 14:42:05 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:58:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 14:58:58 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #30 from David Gustafsson --- I looked through the code, and batching biblios might be easier than I first thought (as only Koha::BiblioUtils really needs to be modified to use the new API). I will probably be able to submit a suggestion using this approach instead, possibly providing around the same performance as the SQL-hack (when using unique queries Koha::Object::unblessed and Koha::Schema::Result::Item::effective_itemtype performed much worse though ~20% of total time, so it would still be nice to be able to bypass those if possible). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 15:59:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 14:59:56 +0000 Subject: [Koha-bugs] [Bug 19915] New: Inventory tool doesn't use cn_sort for callnumber ranges Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Bug ID: 19915 Summary: Inventory tool doesn't use cn_sort for callnumber ranges Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When doing an inventory a range of GT90 to GT100 for LC callnumbers the results won't include GT95 We should convert the numbers and use the cn_sort column for fetching items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:05:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:05:48 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:05:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:05:50 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #1 from Nick Clemens --- Created attachment 70274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70274&action=edit Bug 19915 - Unit test prove -v t/db_dependent/Items/GetItemsForInventory.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:05:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:05:52 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #2 from Nick Clemens --- Created attachment 70275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70275&action=edit Bug 19915 - Use cn_sort values for getting inventory items To test: 1 - Catalog an item under LCC with callnumber GT95 2 - cn_sort should calculate as GT0095 3 - Go to inventory tool 4 - Enter a range that should have your item e.g LC GT90 to GT100 5 - Item is not returned 6 - Apply patch 7 - Item should be returned 8 - Verify things otherwise work as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:05:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:05:58 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:08:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:08:14 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #3 from Nick Clemens --- *** Bug 14983 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:08:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:08:14 +0000 Subject: [Koha-bugs] [Bug 14983] tools/ inventory.pl uses itemcallnumber rather than cn_sort to determine shelf order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14983 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #1 from Nick Clemens --- Moving this to where the patches are *** This bug has been marked as a duplicate of bug 19915 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:14:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:14:58 +0000 Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837 --- Comment #5 from Owen Leonard --- Thanks Nick! I think it looks fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:26:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:26:43 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:31:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:31:49 +0000 Subject: [Koha-bugs] [Bug 19916] New: Can' t search keyword or standard ID from Acquisitions external source / z3950 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19916 Bug ID: 19916 Summary: Can't search keyword or standard ID from Acquisitions external source / z3950 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:33:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:33:40 +0000 Subject: [Koha-bugs] [Bug 19917] New: Holds for self registered patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19917 Bug ID: 19917 Summary: Holds for self registered patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There needs to be a switch in place that does not allow a hold to be triggered if the hold is for a patron in the self registered category. Our library workflow: * Allows self registered patrons to place a couple of holds. * Doesn't assign an automatic card number. * Prints specialized hold slips * Allows self pickup Ideally, we would want the preference to not trigger the hold if the self registration category is in use on the patron with the hold, and a message to come up asking staff to go ahead and assign a card number, or something to that effect. Right now, when the hold is triggered, the slip comes out wrong because there is data missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:33:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:33:56 +0000 Subject: [Koha-bugs] [Bug 19916] Can' t search keyword or standard ID from Acquisitions external source / z3950 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19916 --- Comment #1 from Nick Clemens --- Created attachment 70276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70276&action=edit Bug 19916 - Add keyword and standard ID fields to acq external search To test: 1 - Add an order from external source 2 - Note you don't have keyword or standard ID fields 3 - Add a catalog record from Z3950, note those fields are there 4 - Apply patch 5 - Check acq and note you do have those fields 6 - Do some searches to verify they work as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:33:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:33:54 +0000 Subject: [Koha-bugs] [Bug 19916] Can' t search keyword or standard ID from Acquisitions external source / z3950 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19916 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:34:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:34:03 +0000 Subject: [Koha-bugs] [Bug 19916] Can' t search keyword or standard ID from Acquisitions external source / z3950 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19916 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:38:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:38:20 +0000 Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69913|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 70277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70277&action=edit Bug 19837 - Add multiple patrons to a list by barcode This patch adds the interface change and basic functionality for an option to add multiple patrons to a patron list by scanning barcodes. To test, apply the patch and go to Tools -> Patron lists. - Create a patron list if necessary, and got to the "Add patrons" screen. - Test the process for adding patrons using the "Patron search" text input. - Test the process for adding patrons using the "Enter multiple card numbers" option. This should really have some error-handling added to it: Onscreen messages when a non-existing patron card number is submitted or when a patron already exists on the list. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 16:49:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 15:49:20 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- +my $schema = Koha::Database->new()->schema(); +my @class_sources = $schema->resultset('ClassSource')->search(); Koha::Object ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:21:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 16:21:49 +0000 Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:21:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 16:21:51 +0000 Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70240|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 70278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70278&action=edit Bug 19837 - Add error feedback for duplicatred or unfound cardnumbers To test: 1 - Enter some patrons on a list 2 - 'Enter multiple cardnumbers' 3 - Make sure to add some that are already in list, some that don't exist, and some new patrons 4 - Verify results are as expected with warnings Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:34:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 16:34:14 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 --- Comment #3 from Arturo --- Thank you for the patches, Jonathan! I've tested this out on a sandbox and it works great! There is only one issue that I found -- the tag on line 45 of opac-registration-confirmation.tt is missing a closing tag. Right now both of the tags are opening tags, so it is causing an HTML validation error. Despite that, I was able to complete the detailed test plan below and found no errors. These patches work both when e-mail verification is required and when it is not. They also work when the user supplies a password and when it is randomly generated by Koha. My full test plan is below. These are the sample passwords I tested with: <%20>   <password>

link ¥ Test plan: 1. Make sure a valid e-mail is stored in KohaAdminEmailAddress. 2. Set OpacPublic to Enable. 3. Set PatronSelfRegistration to Allow. 4. Be sure there is a valid patron category in PatronSelfRegistrationDefaultCategory. 5. Set PatronSelfRegistrationBorrowerMandatoryField to include at least "firstname|surname|email|password" so that these are required fields. 6. Set PatronSelfRegistrationPrefillForm to "Display and prefill" so that you can see the password and have it prefilled. To test when e-mail verification is NOT required: 1. Set PatronSelfRegistrationVerifyByEmail to "Don't require". 2. Go to the OPAC and fill out the self-registration form. Supply a password that contains the less-than character. 3. Confirm that upon account creation, your password is correctly displayed on the confirmation page. 4. Also confirm that you can log in to your account. To test when e-mail verification IS required: 1. Be sure that OPACBaseUrl has a value since it is called by the OPAC_REG_VERIFY e-mail template. 2. Set PatronSelfRegistrationVerifyByEmail to "Require." 3. Go to the OPAC and fill out the self-registration form. Supply a password that contains the less-than character. 4. Follow the e-mail verification link created by Koha. 5. Confirm that upon account creation, your password is correctly displayed on the confirmation page. 6. Also confirm that you can log in to your account. To test when a password is generated randomly: 1. Remove "password" from the list of fields in PatronSelfRegistrationBorrowerMandatoryField and repeat the two blocks of steps above. Be sure that the randomly generated password contains a less-than character and that it displays properly. Since these are generated randomly, you may need to self-register multiple times until your generated password contains this character. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 17:51:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 16:51:21 +0000 Subject: [Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #2 from Mohd Hafiz Yusoff --- Anybody can help? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:06:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 18:06:55 +0000 Subject: [Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |normal --- Comment #3 from Jonathan Druart --- Hi Mohd, How did you install Koha? Are you sure it is not a customized version of Koha? What returns the following commands? cd /usr/share/koha; grep -r noreturn | grep -v translator I do not find any relevant occurrences of "noreturn" in our code that could produce such error. Do you have something else in the Koha log file? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 19:21:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 18:21:08 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 4 23:43:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jan 2018 22:43:29 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #15 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #14) > QA: Please make sure bug 19772 is fixed. Yes this has been fixed. The problem was I'd missed a case when changing PATRON_NOTE to CHECKOUT_NOTE in svc/checkout_notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 07:19:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 06:19:44 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #11 from Marcel de Rooy --- (In reply to Josef Moravec from comment #10) > Signed-off-by: Josef Moravec Thanks Josef. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 07:45:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 06:45:30 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy --- - $patron = Koha::Patrons->find( $borrower->{borrowernumber} ); + $patron = Koha::Patrons->find( $patron->borrowernumber ); # FIXME Refetch just in case, to avoid regressions. But must not be needed [...] my $toomany = TooMany( $patron_unblessed, $item->{biblionumber}, $item, { onsite_checkout => $onsite_checkout, switch_onsite_checkout => $switch_onsite_checkout, } ); You do not refetch $patron_unblessed. I would opt for not refetching $patron. But this is not consistent.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 07:45:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 06:45:36 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 07:45:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 06:45:41 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 07:58:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 06:58:31 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67820|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 70279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70279&action=edit Bug 17457 - Adv. Acquisition search with ISBN variations Advanced acquisition search will now follow the "SearchWithISBNVariations" system preference. Test plan : 0) Make sure you have orders pending or completed 1) Enable SearchWithISBNVariations if it is not enabled 2) Search for one of your orders by its ISBN, it should appear 3) Search for the same order by a variation of its ISBN, I used this website to find it : http://www.hahnlibrary.net/libraries/isbncalc.html You should not get a result. 4) Apply patch 5) Repeat step 2-3. You should get a hit both times. 6) prove t/db_dependent/Acquisition.t Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 07:58:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 06:58:41 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 07:58:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 06:58:28 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:01:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:01:07 +0000 Subject: [Koha-bugs] [Bug 18002] Aquisitions onboarding tool - to help users set up acquisitions the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:06:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:06:17 +0000 Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl --- Comment #58 from Marcel de Rooy --- Applying: Bug 17492: (followup) Added missing tests fatal: sha1 information is lacking or useless (Koha/Patron.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:12:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:12:25 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #15 from Marcel de Rooy --- # Looks like you failed 8 tests of 14. t/db_dependent/Circulation.t .. 114/114 # Failed test 'ItemsDeniedRenewal preference' # at t/db_dependent/Circulation.t line 2153. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:15:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:15:28 +0000 Subject: [Koha-bugs] [Bug 17218] New list add attempt while logged in as dbadmin should be prevented pre-emptively In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17218 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:29:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:29:26 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:29:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:29:47 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:29:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:29:28 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68159|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 70280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70280&action=edit Bug 13660 - rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. When looking for a bad MARC Record using the rebuild_zebra_sliced.sh, it is useful to skip the complete MARCXML exporting from Koha and reuse the exported files for Zebra indexing. This patch adds a new parameter: -x | --exclude-export Do not export Biblios from Koha, but use the existing export-dir Which depends on the: -d | --export-dir Where rebuild_zebra.pl will export data Default: $EXPORTDIR !---------! ! TEST PLAN ! !---------! 1. Run "./rebuild_zebra_sliced.sh --length 1000" to export 1000 MARC Records and slice them to one big 1000-Record chunk. 2. Realize that you get an imaginary "stack smashing detected"-error crashing your indexing at some Record you dont know of and can't make out from the indexing logging. 3. Start looking for the bad Record by running: "./rebuild_zebra_sliced.sh --exlude-export --chunk-size 10" To skip Biblios export from Koha which takes ~2h and get straight into splitting your exported biblios to chunks of 10, and indexing them. You know which chunk fails so it is much easier to find the issue there. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:37:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:37:00 +0000 Subject: [Koha-bugs] [Bug 17241] Start using Bower for installing and managing Koha' s JavaScript Dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17241 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from Marcel de Rooy --- Thinks this needs more discussion. Please put it on the agenda of a dev meeting. Why should we use it in view of the arguments listed in comment7's link ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:55:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:55:29 +0000 Subject: [Koha-bugs] [Bug 17833] _initilize_memcached() warns if errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:55:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:55:32 +0000 Subject: [Koha-bugs] [Bug 17833] _initilize_memcached() warns if errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68162|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 70281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70281&action=edit Bug 17833 - _initilize_memcached() warns if errors If memcached or the connection to it is misconfigured, show simple warnings to help identify the problem. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 08:55:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 07:55:46 +0000 Subject: [Koha-bugs] [Bug 17833] _initilize_memcached() warns if errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 09:41:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 08:41:33 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #59 from Marcel de Rooy --- +eval { eval "require $linker_module"; }; Does not look good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 09:48:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 08:48:47 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 09:50:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 08:50:09 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #60 from Marcel de Rooy --- Bouzid: I will still continue on this one. But how do you make sure that you do not save a personal name into say field 610 that should only include corporate names ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 11:54:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 10:54:05 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Nick Clemens --- Hmmm...they all pass for me, can you try again and paste the full results? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:02:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 12:02:33 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #31 from David Gustafsson --- Created attachment 70284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70284&action=edit Add new functions GetMarcBiblios and EmbedItemsInMarcBiblios for embedding items in multiple records at once for improved performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:20:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 12:20:42 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #32 from David Gustafsson --- I made variants of GetMarcBiblio and EmbedItemsInMarcBiblio (GetMarcBiblios and EmbedItemsInMarcBiblio) that accepts multiple biblionumbers instead of just one. This way all items can be loaded at once for all of these biblios, avoiding the overhead of callings search/find once for each item. Running this script (https://gist.github.com/gnucifer/1e33f9aa7155b1b771baaa357dfc7141) it seems to give about the same performance boost as the SQL-hack. When using this strategy just benchmarking GetItems is not feasible since the speedup is because GetItems now need to run a fraction of the times (about 1/2000 for a batch size of 2000) as before, making the impact of DBIx-search having a large overhead preparing the query compared to the low lever interface not matter that much. I will try to produce a before/after NYTProf-flamegraph with the latest benchmarking script (it's a little bit messy since does not have the production data available in my dev-box, and need to produce the results in our staging environment). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:23:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 12:23:21 +0000 Subject: [Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #4 from Mohd Hafiz Yusoff --- Fresh install koha using this instruction: https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages After install, I restore old database (from KOHA 16.05). And then upgrade schema "koha-upgrade-schema {instance}" Last reindex "koha-rebuild-zebra -v -f {instance}" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:27:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 12:27:21 +0000 Subject: [Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #5 from Mohd Hafiz Yusoff --- Return from command lib/C4/Circulation.pm: noreturn: do not return, let item remain where checked in (floating collections) lib/C4/Circulation.pm: # if $hbr was "noreturn" or any other non-item table value, then it should 'float' (i.e. stay at this branch) intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [% IF ( default_returnbranch == 'noreturn' ) %] intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: intranet/cgi-bin/installer/data/mysql/kohastructure.sql: `returnbranch` varchar(15) default NULL, -- the branch the item returns to (homebranch, holdingbranch, noreturn) man/man3/C4::Circulation.3pm: noreturn: do not return, let item remain where checked in (floating collections) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:31:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 12:31:30 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #33 from David Gustafsson --- Forgot to add my results of running the script: Batching enabled + SQL-hack: 32.422s Batching enabled (using ->search, no SQL-hack): 33.387s Batching disabled + SQL-hack: 38.269s Batching disabled (using ->search, no SQL-hack): 59.755s The benchmarks for ->search includes unblessing the item and calling effective_itemtype(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:44:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 12:44:29 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #34 from David Gustafsson --- Also note that this latest benchmark includes all work done in GetMarcBiblio, so more illustrates the actual speedup of loading biblios for indexing (for example), not how much faster items loading is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:46:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 12:46:21 +0000 Subject: [Koha-bugs] [Bug 19015] Searches fail with error Fielddata is disabled on text fields by default for elastic search 5.3 and 5.4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19015 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:52:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 12:52:27 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #35 from David Gustafsson --- Created attachment 70285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70285&action=edit search_not_batched -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:53:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 12:53:14 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #36 from David Gustafsson --- Created attachment 70286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70286&action=edit search_batched -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 13:57:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 12:57:01 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #37 from David Gustafsson --- The last two flamegraphes are from running this script (https://gist.github.com/gnucifer/1e33f9aa7155b1b771baaa357dfc7141) without the SQL-hack and batching enabled/disabled. On the last graph the long thin flame to the left corresponds to the Koha::Obects::Search one on the first (without batching). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 14:48:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 13:48:41 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #38 from David Gustafsson --- The SQL-hack is still included in the last patch, but if you like the biblio-batch-loading approach, I can polish and test this some more (add subroutine documentation etc), and even remove the SQL-hack since it no longer needed to speed up indexing at least. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:00:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:00:35 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:00:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:00:40 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 --- Comment #7 from Jonathan Druart --- Created attachment 70287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70287&action=edit Bug 19280: refresh unblessed patron too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:01:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:01:45 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > - $patron = Koha::Patrons->find( $borrower->{borrowernumber} ); > + $patron = Koha::Patrons->find( $patron->borrowernumber ); # FIXME > Refetch just in case, to avoid regressions. But must not be needed > > [...] > > my $toomany = TooMany( $patron_unblessed, $item->{biblionumber}, $item, > { onsite_checkout => $onsite_checkout, switch_onsite_checkout => > $switch_onsite_checkout, } ); > > You do not refetch $patron_unblessed. I would opt for not refetching > $patron. But this is not consistent.. Good catch Marcel. I also think it's not needed, that's why I added the FIXME. But I would prefer not to do it on this bug report as it will need more attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:08:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:08:58 +0000 Subject: [Koha-bugs] [Bug 19918] New: span tag not closed in opac-registration-confirmation.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Bug ID: 19918 Summary: span tag not closed in opac-registration-confirmation.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 13599 In opac-registration-confirmation.tt: 43

44 Password: 45 [% password_cleartext %] 46

Introduced by: commit 06f4950aa21ff889cff81f27b2f4e79788db193f Bug 13599 - Add patron cardnumber to self registration confirmation Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 [Bug 13599] Add patron cardnumber to self registration confirmation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:08:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:08:58 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19918 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 [Bug 19918] span tag not closed in opac-registration-confirmation.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:11:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:11:23 +0000 Subject: [Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:11:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:11:27 +0000 Subject: [Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 --- Comment #1 from Jonathan Druart --- Created attachment 70288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70288&action=edit Bug 19918: Close span tag in opac-registration-confirmation.tt Introduced by: commit 06f4950aa21ff889cff81f27b2f4e79788db193f Bug 13599 - Add patron cardnumber to self registration confirmation Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:11:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:11:38 +0000 Subject: [Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:11:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:11:45 +0000 Subject: [Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:11:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:11:59 +0000 Subject: [Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart --- Trivial, patch pushed for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:13:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:13:17 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70253|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 70289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70289&action=edit Bug 19911: Escape password value during self-registration confirmation The password must be correctly escape, it can contains html character and break the display. Test plan: Apply first patch and confirm that the display is broken Apply second patch (this one) and confirm that the display is fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:14:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:14:25 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19918 --- Comment #5 from Jonathan Druart --- (In reply to Arturo from comment #3) > Thank you for the patches, Jonathan! I've tested this out on a sandbox and > it works great! There is only one issue that I found -- the tag on > line 45 of opac-registration-confirmation.tt is missing a closing > tag. Right now both of the tags are opening tags, so it is causing an HTML > validation error. Well spotted! I have opened, filled and pushed bug 19918 to fix that. And rebased the patch on top. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 [Bug 19918] span tag not closed in opac-registration-confirmation.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:14:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:14:25 +0000 Subject: [Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:15:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:15:30 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:22:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:22:21 +0000 Subject: [Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #6 from Jonathan Druart --- Do you have something else in the Koha log file? I will need the file and line number where the error occurs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:26:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:26:32 +0000 Subject: [Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Software error while check |Software error while check |in, The method noreturn is |in, The method noreturn is |not covered by tests! after |not covered by tests! |upgrade from 16.05 to 17.11 | Severity|normal |critical Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Version|17.11 |master --- Comment #7 from Jonathan Druart --- Ok I recreate the problem, it happens when "Return policy" is "Item floats" (value noreturn) in circ rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:26:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:26:42 +0000 Subject: [Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:32:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:32:24 +0000 Subject: [Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18276 --- Comment #8 from Jonathan Druart --- Certainly caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:32:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:32:24 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 [Bug 19899] Software error while check in, The method noreturn is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:43:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:43:24 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:47:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:47:28 +0000 Subject: [Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:47:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:47:38 +0000 Subject: [Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #9 from Jonathan Druart --- Created attachment 70290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70290&action=edit Bug 19899: Restore Item floats feature - do not crash Error is "The method noreturn is not covered by tests!" caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn) the library must be the current library (from userenv). This behaviour is used in C4::Circulation::AddReturn On bug 18276 I assumed that the value was either holdingbranch or homebranch, and forgot it could be "noreturn" Test plan: Set Return policy to Item floats Check an item in => without this patch it explodes => With this patch applied it will check the item in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:49:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:49:12 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Software error while check |The float items feature is |in, The method noreturn is |broken - cannot checkin |not covered by tests! | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:54:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:54:17 +0000 Subject: [Koha-bugs] [Bug 19783] make check_kohastructure.t compatible to package build process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- What is the error? The file does not exist? intranetdir does not exist? We should not use intranetdir in t (DB independent)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:54:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:54:49 +0000 Subject: [Koha-bugs] [Bug 19783] make check_kohastructure.t compatible to package build process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19422 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 [Bug 19422] kohastructure.sql missing DROP TABLES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 15:54:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 14:54:49 +0000 Subject: [Koha-bugs] [Bug 19422] kohastructure.sql missing DROP TABLES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 [Bug 19783] make check_kohastructure.t compatible to package build process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:09:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:09:44 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:09:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:09:46 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68916|0 |1 is obsolete| | Attachment #70287|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 70291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70291&action=edit Bug 19280: Pass a Koha::Patron to CanBookBeIssued We need to make subroutine from C4 use more Koha::Object objects Seeing bug 19276, starting here is a good start. Test plan: The tests should still pass. Signed-off-by: Jon Knight Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:09:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:09:51 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 --- Comment #10 from Marcel de Rooy --- Created attachment 70292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70292&action=edit Bug 19280: refresh unblessed patron too Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:12:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:12:47 +0000 Subject: [Koha-bugs] [Bug 19919] New: Writing off a Lost Item Fee marks as "Paid for by patron" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Bug ID: 19919 Summary: Writing off a Lost Item Fee marks as "Paid for by patron" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: lisetteslatah at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 70293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70293&action=edit An example A replacement copy was ordered for an item that was "long lost overdue" on a patron's account. The librarian wanted the old copy deleted from the system to keep the record clean. We checked in the item, marked it as lost, and then wrote off the fee associated with the item. Finally we reapplied the fee manually, no longer associated with the item. We noticed that at the point of the write off, the item gets a line that says paid for by (Patron name and barcode) DATE TIME. This also happens if the book is checked in and no longer marked as lost (say it was returned by the borrower so we wrote off the lost item fee.) The borrower has not paid for the book in either situation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:14:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:14:09 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Marcel de Rooy --- # Subtest: ItemsDeniedRenewal preference 1..14 not ok 1 - Renewal allowed when no rules # Failed test 'Renewal allowed when no rules' # at t/db_dependent/Circulation.t line 2108. # got: '0' # expected: '1' not ok 2 - Renewal allowed when no rules # Failed test 'Renewal allowed when no rules' # at t/db_dependent/Circulation.t line 2109. # got: 'overdue' # expected: undef ok 3 - Renewal blocked when 1 rules (withdrawn) ok 4 - Renewal blocked when 1 rule (withdrawn) not ok 5 - Renewal allowed when 1 rules not matched (withdrawn) # Failed test 'Renewal allowed when 1 rules not matched (withdrawn)' # at t/db_dependent/Circulation.t line 2121. # got: '0' # expected: '1' not ok 6 - Renewal allowed when 1 rules not matched (withdrawn) # Failed test 'Renewal allowed when 1 rules not matched (withdrawn)' # at t/db_dependent/Circulation.t line 2122. # got: 'overdue' # expected: undef ok 7 - Renewal blocked when 2 rules matched (withdrawn, itype) ok 8 - Renewal blocked when 2 rules matched (withdrawn,itype) not ok 9 - Renewal allowed when 2 rules not matched (withdrawn, itype) # Failed test 'Renewal allowed when 2 rules not matched (withdrawn, itype)' # at t/db_dependent/Circulation.t line 2135. # got: '0' # expected: '1' not ok 10 - Renewal allowed when 2 rules not matched (withdrawn, itype) # Failed test 'Renewal allowed when 2 rules not matched (withdrawn, itype)' # at t/db_dependent/Circulation.t line 2136. # got: 'overdue' # expected: undef ok 11 - Renewal blocked when 3 rules matched (withdrawn, itype, location) ok 12 - Renewal blocked when 3 rules matched (withdrawn,itype, location) not ok 13 - Renewal allowed when 3 rules not matched (withdrawn, itype, location) # Failed test 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' # at t/db_dependent/Circulation.t line 2150. # got: '0' # expected: '1' not ok 14 - Renewal allowed when 3 rules not matched (withdrawn, itype, location) # Failed test 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' # at t/db_dependent/Circulation.t line 2151. # got: 'overdue' # expected: undef # Looks like you failed 8 tests of 14. not ok 114 - ItemsDeniedRenewal preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:14:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:14:21 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:14:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:14:49 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:14:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:14:52 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #9 from Kyle M Hall --- Created attachment 70294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70294&action=edit Bug 18856 [QA Followup] - Catch missed instance of is_cancelable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:15:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:15:38 +0000 Subject: [Koha-bugs] [Bug 19897] Make status 'on hold' more specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19897 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:18:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:18:00 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #39 from Jonathan Druart --- David, my main concern with your approach is that we are adding new subroutines to C4 (against our coding guidelines) and too specific methods (for items only when we should think Koha::Object[s] instead). Moreover IIRC the IN clause should not be used for big ranges, there is a maximum number of elements we can passed in [ref needed]. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:38:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:38:43 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #5 from Owen Leonard --- *** Bug 19728 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:38:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:38:44 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug 17858 depends on bug 19728, which changed state. Bug 19728 Summary: Move template JavaScript to the footer: Circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19728 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:38:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:38:43 +0000 Subject: [Koha-bugs] [Bug 19728] Move template JavaScript to the footer: Circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19728 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 19641 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:41:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:41:02 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:41:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:41:06 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #18 from Nick Clemens --- Created attachment 70295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70295&action=edit Bug 15494 - Followup: Make sure items in tests are not overdue prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:41:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:41:40 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #7 from Marcel de Rooy --- (In reply to David Bourgault from comment #6) > I don't think I can move the recursive sub out of GetBudgetHierarchy, since > it calls variables local to that function. If it were moved out it would > need to either rebuild them everytime, which voids the perf boost, or > receive them as parameters, which would make the code less readable, and > requires the dev to know the exact SQL query result to pass. > > In this case I strongly believe an anonymous inner function is the best way > to go. As for tests, the current test to budgets.t should be sufficient as > this does not (should not!) change behavior. It is supposed to replace the > inner workings of the function with no impact on input or output. Will add a (trivial) follow-up that times around the same, and improves imo readability. Since we just pass references to hash structures, we are not rebuilding structures. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:41:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:41:56 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #19 from Nick Clemens --- It seems due dates were being set to now. If the tests take long enough to run then the items were overdue. Set the date in the future now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:42:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:42:26 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #6 from Owen Leonard --- (In reply to Josef Moravec from comment #4) > Few buttons in patron toolbar on checkouts screen does not work - > circulation.tt is not part of this patch and so does not include > members-menu.js. I think you will fix this bug 19728, true? I've marked 19728 as a duplicate of this bug and will submit a follow-up that includes circulation.tt and circulation_batch_checkouts.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:43:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:43:32 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69960|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 70296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70296&action=edit Bug 19792 - Perf. boost for GetBudgetHierarchy This patches reduces the number of SQL calls by combining multiple calls to the recursive functions GetBudgetSpent(), GetBudgetOrdered(), etc. into 4 big queries. It also removes duplicate function calls from acqui-home.pl Test plan: 0) Visit Acquisition home 0) Apply patch 1) Refresh page. It shoud look identical. 2) prove t/db_dependent/budgets.t Signed-off-by: Jon Knight Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:43:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:43:37 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #9 from Marcel de Rooy --- Created attachment 70297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70297&action=edit Bug 19792: (QA follow-up) Move anonymous sub out of GetHierarchy Test plan: Run t/db_dependent/Budgets.t. Without both patches, running the test is slower than with only the first or both patches. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:54:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:54:02 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:53:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:53:46 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70297|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 70298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70298&action=edit Bug 19792: (QA follow-up) Move anonymous sub out of GetHierarchy Test plan: Run t/db_dependent/Budgets.t. Without both patches, running the test is slower than with only the first or both patches. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 16:56:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 15:56:48 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:02:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:02:37 +0000 Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice previews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:02:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:02:43 +0000 Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice previews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69413|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 70299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70299&action=edit Bug 18007: Interface updates to notices and notice previews This patch makes changes to the form for adding and editing notices, and to the template for viewing a rendered preview of notices. - Preview now shows side-by-side comparisons - JavaScript has been movied out of template into separate file - Validation of the add/edit form improved through use of validation plugin - There is now better visual feedback for AJAX form checks To test, apply the patch on top of those for Bug 17981 - Add a new notice. - Confirm that the form can't be submitted without data in the "code" and "name" fields. - Confirm that the form can't be submitted without filling in at least one message template (subject and body). - Confirm that you cannot submit the form while using an existing notice code. - Follow Bug 17981's test plan for testing the preview function. Confirm that the preview loads correctly and looks correct. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:03:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:03:26 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:03:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:03:32 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67144|0 |1 is obsolete| | Attachment #67145|0 |1 is obsolete| | Attachment #67146|0 |1 is obsolete| | Attachment #67147|0 |1 is obsolete| | Attachment #67148|0 |1 is obsolete| | Attachment #67152|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart --- Created attachment 70300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70300&action=edit Bug 17981: Move svc/letters to svc/letters/get To allow another script under svc/letters Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:03:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:03:40 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #38 from Jonathan Druart --- Created attachment 70301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70301&action=edit Bug 17981: Add a 'letter' param to GetPreparedLetter This will allow us to call GetPreparedLetter with a letter content that does not exist in the DB Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:03:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:03:55 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #40 from Jonathan Druart --- Created attachment 70303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70303&action=edit Bug 17981: Better error handling Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:04:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:04:01 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #41 from Jonathan Druart --- Created attachment 70304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70304&action=edit Bug 17981: Move the divs to the top of the modal Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:03:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:03:46 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #39 from Jonathan Druart --- Created attachment 70302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70302&action=edit Bug 17981: Add a preview mode for notice templates This patch is a first step to provide a preview mode for notice templates. CHECKIN, CHECKOUT and HOLD_SLIP are supported so far. Maybe more, but I have not tested yet and the interface will not allow you to generate the preview. The idea is to provide an idea of how will render the messages generated from a notice template. A new "Preview" button is added close to each textarea on the editing notice templates view. For each notice template code (letter_code), we will need some input data to produce the preview. For instance, for CHECKIN we need an barcode. From the barcode we can guess all the other data. For CHECKOUT we will need the borrowernumber and the barcode. Note that the way to enter the data for the preview is not really user-friendly, for CHECKOUT you will have to fill 'borrowernumber|barcode', but the placeholder will help you to know how and what to fill. In the modal window, you will see 4 blocks: 1/ the content of the letter (with the placeholds << >>) 2/ the generated message (with the data filled) 3/ if the letter contained historical syntax markers, the screen will try to generate a notice template using the TT syntax 4/ the generated message from this TT syntax => You will be able to compare the 2 generated messages. What is the goal of this first patchset: - Show this first POC and get feedback from other developpers - Add a way to easily visualise the differences between the 2 syntaxes - Confort users with the TT syntax and the migration step from the historical syntax. I'd like to get opinions before going further. The possibilities: - Mock data to get fully working generated messages for any notice templates. For instance, for CHECKIN and CHECKOUT, the item is not checked in/out yet. So we cannot access the issue's information. (I have no idea how to do that) - Browse the data to get the ones we want to use for the preview (big). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:04:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:04:11 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #42 from Jonathan Druart --- Created attachment 70305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70305&action=edit Bug 17981: Remove uneeded module JS var As we only support CHECKIN and CHECKOUT for now, we do not need this module variable. It may be useful to re-add it later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:07:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:07:03 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #20 from Marcel de Rooy --- (In reply to Nick Clemens from comment #19) > It seems due dates were being set to now. If the tests take long enough to > run then the items were overdue. Set the date in the future now Yes, that works better. Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:11:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:11:36 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #40 from David Gustafsson --- As far as I know the Mysql 'max_allowed_packet' setting is the only concern for large IN-clauses, 1MB is the default I think (but can be raised if necessary). 1MB is about 1_000_000 characters, it's probably safe to assume that the average IN-argument doesn't exceed 10 bytes. So as long as itemnumbers for each batch < 100_000 it's probably fine (and if it's not one can simply raise the conf-setting). Right now batch size is set to 2000, and with an average number of items per biblio of around 1.3 there is absolutely no risk of exceeding the max_allowed_packet limit. Regarding C4 I did not know that was depricated, but if things are to be moved into the Koha-namespace, and subroutines in C4 will become methods on the appropriate objects, it's not very feasable to place the current addition of pluralized subroutines to Koha:: right now before that refactoring has taken place. I'm quite confident that the addition of the pluralized subroutines will not make this future change more difficult. It is only really GetMarcBiblios that "needs" to be exposed (since it's used in Koha::BiblioUtils, all the others can be considered private helpers. I understand that adding pluralized versions is not a insignificant addition to to API, but I have made no alternations of the current API, and architecturally I think this is the way to go for opening up several optimization paths for Koha. Drupal for example uses the very same technique for loading fields for it's "entities" (biblios could be considered an entity in this context), and without it performance would be horrible. We have also been working on a hook-system (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19306). Invoking hooks for each biblio/item etc would probably be quite expensive, but instead placing those hooks where biblios etc can be loaded in bulk would mean that the addition of hooks would not degrade performance as much, if at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:40:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:40:50 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #11 from Jonathan Druart --- I am not convinced. 1. I prefer the version without Marcel's patch (especially because of the size of the parameter list) 2. GetBudgetHierarchy is called from a lot of other places, with a budget_id For all these calls we are going to get worst performance(?) 3. GetBudgetHierarchy is not tested when called without parameter 4. There is a FIXME you removed, but you did not fix the problem, you hid it 5. > This causes slow downs and performance issues for some libraries. How many budgets/funds? What are the performances before/after this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:42:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:42:17 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #12 from Jonathan Druart --- Created attachment 70306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70306&action=edit Bug 19792: Few minor fixes - No string extrapolation needed on SQL queries - '== undef' must be written 'if not defined' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:47:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:47:46 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #13 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #11) > 1. I prefer the version without Marcel's patch (especially because of the > size of the parameter list) I have seen worse :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 17:49:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 16:49:34 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Marcel de Rooy --- + unless ($item) { carp "No item passed in!" && return } Not our preferred coding style + return () if (! $yaml =~ /\S/ ); Just return here. The only call is in scalar context. We do not need a list. Shorter: return if $yaml !~ /\S/; + eval { + $denyingrules = YAML::Load($yaml); + }; How much time are we spending on doing this? What is the performance effect? If the pref always looks like field1: [val]\nfield2: [val2] we can just split on newline and split on ':', etc. Give me some convincing numbers please. + return (); Same as above + my $val; + if (exists $item->{$field}) { + $val = $item->{$field}; + } + $val = '' unless defined $val; Why not in just one line: my $val = $item->{$field} // ''; + - How to write these rules is documented on the Koha wiki. This is from the preference file. Not sure if this is the preferred way. A wiki page could be gone just as easily. Why not just provide an example as close as possible to the pref itself. Just another 40 chars ? Just curious too if this supports denying renewal on an empty string? If so, the conversion from undef to empty string might not be what we want. Can we signal empty string or undef to be a blocking value? [No blocker for me btw :)] Changing status. Please make some adjustments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:03:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:03:10 +0000 Subject: [Koha-bugs] [Bug 17833] _initilize_memcached() warns if errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 --- Comment #8 from Jonathan Druart --- Created attachment 70307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70307&action=edit Bug 17833: Make sure this warning will not be ignored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:17:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:17:19 +0000 Subject: [Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19920 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920 [Bug 19920] changepasswordis exported from C4::Members but has been removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:17:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:17:19 +0000 Subject: [Koha-bugs] [Bug 19920] New: changepasswordis exported from C4:: Members but has been removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920 Bug ID: 19920 Summary: changepasswordis exported from C4::Members but has been removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 16853 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 [Bug 16853] Move changepassword to Koha::Patron->update_password -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:17:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:17:57 +0000 Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4:: Members but has been removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|changepasswordis exported |changepassword is exported |from C4::Members but has |from C4::Members but has |been removed |been removed --- Comment #1 from Jonathan Druart --- C4/Members.pm: &changepassword But bug 16853 removed this subroutine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:23:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:23:10 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Arturo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:23:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:23:30 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70271|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:23:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:23:35 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70289|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:23:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:23:43 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 70308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70308&action=edit Bug 19911: Do not escape html characters when saving passwords When the password is not generated automatically, we should not escape the html characters. Otherwise it will be changed without any warnings. Signed-off-by: Arturo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:23:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:23:46 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 --- Comment #8 from sandboxes at biblibre.com --- Created attachment 70309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70309&action=edit Bug 19911: Escape password value during self-registration confirmation The password must be correctly escape, it can contains html character and break the display. Test plan: Apply first patch and confirm that the display is broken Apply second patch (this one) and confirm that the display is fixed Signed-off-by: Arturo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:26:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:26:29 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 --- Comment #9 from Arturo --- Just tested again and it looks great to me. Thank you for your work on this, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:43:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:43:04 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:43:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:43:07 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66854|0 |1 is obsolete| | Attachment #69428|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 70310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70310&action=edit Bug 18071: Add authorities maintenance script With bug 9988 the manual merge option of merge_authorities was removed. (Note that it did not work any more too.) This patch reintroduces this functionality on the command line. This maintenance script now allows you to force renumbering field 001 for selected authid's, to delete authid's including the removal of references in biblio records, as well as merging several authid's into one reference record. Test plan: [1] Test the -renumber parameter. Field 001 and 005 should be updated. [2] Test the -delete parameter. Check if a linked biblio does no longer contain a reference to the deleted authority. [3] Test the -merge parameter. Create two PERSO_NAME records (say A,B) and attach biblios to them. Pick a CORPO_NAME record as reference record C. Now pass -merge -reference C -authid A,B Verify that A and B are gone, and the records link to C now. Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:43:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:43:10 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 --- Comment #17 from Nick Clemens --- Created attachment 70311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70311&action=edit Bug 18071: (QA follow-up) Add commit parameter, add warning Addressing points mentioned in comment12: [1] Commit parameter. [2] Warning if authid does not exist for -merge. Test plan: [1] Run update_authorities.pl -authid X -merge -ref Y -c where X does not exist in your db and Y does. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:43:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:43:14 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 --- Comment #18 from Nick Clemens --- Created attachment 70312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70312&action=edit Bug 18071: (QA Followup) - Add additional feedback and expand commit option To test: Test as before, verify commit option makes no changes and provides additional feedback when verbose Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 18:44:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 17:44:09 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | --- Comment #19 from Nick Clemens --- Added some additional feedback, please verify you are okay with changes Marcel, otherwise looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:01:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 18:01:09 +0000 Subject: [Koha-bugs] [Bug 19921] New: Error when updating child to adult patron on system with only one adult patron category Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Bug ID: 19921 Summary: Error when updating child to adult patron on system with only one adult patron category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Patrons Assignee: jonathan.druart at bugs.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 19641 To reproduce this bug you must test in a system which has only one patron category of the "adult" type. View the details of a patron with a child-type patron category and choose More -> Update child to adult patron. This results in an error: Can't call method "category_type" on an undefined value at /home/vagrant/kohaclone/members/update-child.pl line 84. The URL of the error page shows a problem with the parameters being passed: members/update-child.pl?op=update&borrowernumber=12345&catcode=Koha::Patron::Category=HASH(0xa168a18)&catcode_multi= Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 19:01:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 18:01:09 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 [Bug 19921] Error when updating child to adult patron on system with only one adult patron category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:14:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 19:14:59 +0000 Subject: [Koha-bugs] [Bug 19922] New: Reordering of fields in elasticsearch mapping configuration does not work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19922 Bug ID: 19922 Summary: Reordering of fields in elasticsearch mapping configuration does not work Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/searchengine/elasticsearch/mapping s.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org If I navigate to /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl and try reordering fields under the 'Biblios' or 'Authorities' tabs, after clicking 'Save' the fields are still where they are to begin with. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:36:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 19:36:10 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15407 --- Comment #1 from Jonathan Druart --- Caused by commit cae4b980607be083e5e0fb163c4949c73d6347db Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 [Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:36:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 19:36:10 +0000 Subject: [Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 [Bug 19921] Error when updating child to adult patron on system with only one adult patron category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:39:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 19:39:09 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:39:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 19:39:13 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 --- Comment #2 from Jonathan Druart --- Created attachment 70313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70313&action=edit Bug 19921: Fix update child when only one adult patron category exist We are passing the Koha::Patron::Category object to the template instead of the categorycode. To reproduce this bug you must test in a system which has only one patron category of the "adult" type. View the details of a patron with a child-type patron category and choose More -> Update child to adult patron. This results in an error: Can't call method "category_type" on an undefined value at /home/vagrant/kohaclone/members/update-child.pl line 84. The URL of the error page shows a problem with the parameters being passed: members/update-child.pl?op=update&borrowernumber=12345&catcode=Koha::Patron::Category=HASH(0xa168a18)&catcode_multi= Test plan: Make sure you have only 1 adult patron category Update a child to adult => With this patch applied the error is gone and the patron has been correctly updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:47:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 19:47:58 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #1 from Jonathan Druart --- Created attachment 70314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70314&action=edit Bug 12001: Move C4::Members::GetMemberAccountRecords -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:48:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 19:48:28 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #8 from Owen Leonard --- Created attachment 70315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70315&action=edit Bug 19474 (Follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 20:48:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 19:48:27 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 5 23:56:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jan 2018 22:56:38 +0000 Subject: [Koha-bugs] [Bug 13520] add rental to circ matrix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13520 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 15:53:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 14:53:04 +0000 Subject: [Koha-bugs] [Bug 19923] New: conceptual searching in koha Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19923 Bug ID: 19923 Summary: conceptual searching in koha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: reza0770 at gmail.com QA Contact: testopia at bugs.koha-community.org Dear Friends, Why can?t we used the references systems (conceptual searching) based on our authority files in the OPAC of KOHA. What is the matter exactly and what should we do for using its benefits. Mainly, we have some authority files including subjective authority data, name authority data, etc., But our end users can?t do conceptual searches in the OPAC. For instance, where a user searches a non-preferred term of a name or a subject, the KOHA searching system (in the OPAC environment) cannot recognizes the relationship between the searched terms to the related preferred term in an authority file. While KOHA supports such kind of search in the authority data module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 16:46:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 15:46:44 +0000 Subject: [Koha-bugs] [Bug 19923] conceptual searching in koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19923 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Can you explain with an example how you'd like this to work? Have you seen the "did you mean" plugins under administration and the IncludeSeeFromInSearches system preference? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 17:52:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 16:52:06 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #10 from Mohd Hafiz Yusoff --- Created attachment 70316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70316&action=edit Error after edit code line 279 After edit code at line 279, the error like attachment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 17:59:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 16:59:27 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Hi Mohd, did you manually edit the files or apply the patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 18:00:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 17:00:44 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #12 from Katrin Fischer --- Hm, you could try adding a ; to the end of this line: $returnbranch = $hbr eq 'noreturn' ? $item->$hbr : $userenv_branch; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 18:08:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 17:08:08 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #13 from Mohd Hafiz Yusoff --- I manually edit the files, after add semicolon, error same "manually edit the files" How to apply the patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 18:21:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 17:21:19 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #14 from Jonathan Druart --- Oops indeed, there is a semicolon missing at the end. I am going to reattach a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 18:24:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 17:24:10 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70290|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 70317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70317&action=edit Bug 19899: Restore Item floats feature - do not crash Error is "The method noreturn is not covered by tests!" caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn) the library must be the current library (from userenv). This behaviour is used in C4::Circulation::AddReturn On bug 18276 I assumed that the value was either holdingbranch or homebranch, and forgot it could be "noreturn" Test plan: Set Return policy to Item floats Check an item in => without this patch it explodes => With this patch applied it will check the item in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 18:43:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 17:43:25 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #16 from Mohd Hafiz Yusoff --- Created attachment 70318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70318&action=edit Successful fix the problem, thank you Your code has been successful fix the problem. Now I can return my book easier. Thank you all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 18:44:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 17:44:12 +0000 Subject: [Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - " Cannot process file as an image" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898 --- Comment #5 from Craig --- (In reply to Jonathan Druart from comment #4) > (In reply to Craig from comment #3) > > Unfortunately, after turning off Autolocation, restarting Koha, and > > restarting memcache, the error still persists. > > Do you still have the warning in the logs? > What is the exact version of Koha you are using? > Did you try on a sandbox? Hi Jonathan, I'm running 17.11.01.000. No new intranet error logs, no new opac error logs relevant to cover image upload. I don't have a sandbox to test, unfortunately. I created a new super librarian patron, logged in as that user, and tried to upload. The problem persists. I also entered my public IP address into the branches table, tried to upload, and still nothing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 19:44:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 18:44:13 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #17 from Jonathan Druart --- Thanks Mohd for the confirmation. You should read this wiki page (https://wiki.koha-community.org/wiki/Sign_off_on_patches) to know how to apply patches (using git-bz) and learn how to sign off on these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 6 19:47:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 18:47:28 +0000 Subject: [Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - " Cannot process file as an image" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898 --- Comment #6 from Jonathan Druart --- Can you confirm you do not have any warnings related to upload files on the about page (tab "system information")? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 00:05:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jan 2018 23:05:49 +0000 Subject: [Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - " Cannot process file as an image" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898 --- Comment #7 from Craig --- (In reply to Jonathan Druart from comment #6) > Can you confirm you do not have any warnings related to upload files on the > about page (tab "system information")? Confirmed. There are no warnings posted here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 13:09:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2018 12:09:10 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #18 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Mohd Hafiz Yusoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 13:09:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2018 12:09:33 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70317|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 13:09:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2018 12:09:41 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #19 from sandboxes at biblibre.com --- Created attachment 70319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70319&action=edit Bug 19899: Restore Item floats feature - do not crash Error is "The method noreturn is not covered by tests!" caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn) the library must be the current library (from userenv). This behaviour is used in C4::Circulation::AddReturn On bug 18276 I assumed that the value was either holdingbranch or homebranch, and forgot it could be "noreturn" Test plan: Set Return policy to Item floats Check an item in => without this patch it explodes => With this patch applied it will check the item in Signed-off-by: Mohd Hafiz Yusoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 15:14:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2018 14:14:41 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_19924=5D_New=3A__Gmail_customer_serv?= =?utf-8?q?ice_1-844-370-6818_Gmail_customer_service_number_Gmail_customer?= =?utf-8?q?_service_phone_number_=3D=3FUTF-8=3FQ=3F=3D20sdfsd=3D20=3DC2=3D?= =?utf-8?b?QTY9MjA/PT8=?= Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19924 Bug ID: 19924 Summary: Gmail customer service 1-844-370-6818 Gmail customer service number Gmail customer service phone number sdfsd ? ? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: pozerhaul at yopmail.com QA Contact: testopia at bugs.koha-community.org http://oguppsupport.blogspot.com/2018/01/sdbvs-cxfderfbber.html https://bunoinv.wordpress.com/2018/01/07/sdebv-dxfdfedr/ http://forums.moneysavingexpert.com/showthread.php?p=73677300 https://bugs.eclipse.org/bugs/show_bug.cgi?id=529486 Gmail customer service 1-844-370-6818 Gmail customer service number Gmail customer service phone number sdfsd ? ?Gmail customer service 1-844-370-6818 Gmail customer service number Gmail customer service phone number sdfsd ? ?Gmail customer service 1-844-370-6818 Gmail customer service number Gmail customer service phone number sdfsd ? ?Gmail customer service 1-844-370-6818 Gmail customer service number Gmail customer service phone number sdfsd ? ?Gmail customer service 1-844-370-6818 Gmail customer service number Gmail customer service phone number sdfsd ? ?Gmail customer service 1-844-370-6818 Gmail customer s! ! com support help with ! a.c.c.o.u.n.t ! a.c.c.o.u.n.t help phone number how do i contact 1 by phone ! chat support ! a.c.c.o.u.n.t help 1 ! support email number to ! customer service ! support number 1 ! a.c.c.o.u.n.t help call ! for help number for 1 customer service 1 email support chat 1 customer care number contact 1 customer service by phone contact ! phone ! customer service phone 1 customer support phone number ! customer support phone number usa contact number for 1 support ! security support ! contact number toll free contact 1 ! support ! toll free number ?????? ????????? ! ! issues call 1 customer support 1 number customer service 1 ! problems 1 tech support phone 1 phone number customer service 800 number for ! 0 phone number to call 1 customer service contact ! for help ! a.c.c.o.u.n.t recovery ! help contact ! team number of ! users ! recovery a.c.c.o.u.n.t ! online customer service ! support email ! m?steri hizmetleri 1 tech support usa ! com phone number phone ! assistance ! t?l?phone how to contact 1 for email support ! phone number support call ! how to contact ! com ! customer care complaints ! phone support ! customer care number usa ! help contact number ! customer support phone number get my emails from ! hack ! a.c.c.o.u.n.t 1 ! help contact ! help center ! contacts phone numbers ! a.c.c.o.u.n.t recovery help l.i.v.e chat ! support ! support contact call ! support 1 phone number for customer service ! contact number canada ! com customer service ! help center phone number ! not working ! support phone number ! contact us telephone number for ! com 1 email customer service phone number ! problems contact 1 contact number for email ! tech support phone number contact ! help desk ! phone number ! customer service email ! call support contact ! support via email call 1 support phone number how to contact 1 about ! contact 1 customer service phone 1 customer service phone number for ! 0 ! login issues ! help l.i.v.e chat ! support number india how can i contact 1 customer service 1 support contact number call ! support phone number contact 1 ! support by phone 0 ! support number uk phone no for 1 help 1 customer care service number 1 helpline number ! technical helpline number 1 support number 0 1 mail phone number how can i contact ! password recovery for ! a.c.c.o.u.n.t contact for ! ! l.i.v.e chat support ! a.c.c.o.u.n.t contact number ! helpline phone number get email from ! how to contact 1 by phone 1 tech support 800 number how to get a ! phone number does ! have a phone number customer care ! ! customer service phone number how to contact ! support 1 contact support number phone number for ! a.c.c.o.u.n.t is there a phone number for ! support ! help center email address ! helpline email address customer service 1 phone number ! customer phone number 1 support for ! 1 ! helpline email 1 customer support 1 a.c.c.o.u.n.t recovery phone number customer service phone number for ! help 1 customer service phone number ! helpline contact number 1 email recovery contact number 1 ! customer service phone number ! toll free phone number recovery ! phone number contact ! customer service by phone 1 tech support email ! email problems ! tech support 1 email phone number how to contact ! support by email 1 mail help number ! customer service toll free number 1 mail customer support ! technical support phone number 800 number for ! support 1 email help number 1 mail help desk ! business a.c.c.o.u.n.t ! technical support phone number canada ! technical support phone number ! customer service email address ! tech help support 1 mail email address for ! support 1 ! customer service phone number uk ! customer care email 1 mail tech support phone number 1 customer support email ! service ! customer service usa 1 ! a.c.c.o.u.n.t recovery ! help 1 ! support number ! customer service phone number ! help desk phone number ! customer service phone number toll free 1 a.c.c.o.u.n.t help phone number contact 1 customer service phone number call from ! ! customer service phone number how to call 1 customer service ! customer service telephone number 1 mail customer service 1 email customer service ! support number 1 help support phone number how to contact 1 tech support ! login support 0 ! tech ! com customer service number 1 ! customer service number ! contact info ! technical support number 1 contact support how to find your ! a.c.c.o.u.n.t 1 ! customer service phone number us how to call 1 ! support problems with ! contact ! support team i need a phone number for 1 customer service 1 email tech support number contact 1 phone number get ! email a.c.c.o.u.n.t 1 helpline email ! customer care number toll free contact 1 regarding ! contact ! via phone ! customer care number ! usa contact 1 about ! telephone number for 1 ! 1 support 800 number contact ! help by phone recovery a.c.c.o.u.n.t ! ! support online chat ! email hacked service ! ! call center ! support number canada email search ! 1 contact phone number ! technical support usa ! customer care usa 1 mail helpline 1 ! tech support number contact 1 support email ! help desk toll free number for ! 1 contact number customer service 1 mail contact number ! a.c.c.o.u.n.t customer service ! l.i.v.e support chat ! phone number 1 support team phone number ! customer service support phone number ! trouble ! help phone number usa how do you find your ! a.c.c.o.u.n.t how can i contact ! by phone ! password recovery how can i call 1 customer service ! customer service number 1 wallet contact number ! telephone support 1 helpline phone number usa ! technical support number canada 1 customer care service change password on ! a.c.c.o.u.n.t customer service phone number for 1 phone number to 1 support ! support hotline ! help telephone number ! help desk phone number usa ! contact us phone number ! customer support number usa contact ! about password ! help contact 1 support phone number ! customer support chat sign in ! ! help ! customer support usa ! contact number password recovery phone number ! customer service customer service ! 1 ! support phone number ! hotline what is ! customer service number contact 1 tech support ! a.c.c.o.u.n.t help desk how to contact ! via phone telephone number for 1 customer service ! customer care email address email 1 support ! support phone number usa what is ! phone number phone number for help with ! 0 1 com customer service phone number ! l.i.v.e support 1 customer service phone 1 customer service support number phone number 1 tech support ! support l.i.v.e chat contact information for ! ! help phone number customer service number for 1 1 technical support contact number 1 a.c.c.o.u.n.t customer service number customer service ! com 1 email support phone number how to get phone number from ! ! password recovery helpline number technical support ! 1 ! support ! customer service 800 number 800 number for 1 support ! customer service uk 1 mail help contact www 1 com support phone number ! password recovery not working ! a.c.c.o.u.n.t recovery contact number ! contact help ! customer care email id 1 email helpline ! number ! tech support phone number usa contact ! by phone ! tech support phone number ! tech support number 1 email help phone number trouble with ! 1 email tech support phone number password recovery ! a.c.c.o.u.n.t ! contacts help ! contacts number 1 tech support toll free number ! customer care toll free number india ! a.c.c.o.u.n.t recovery customer service 0 ! online support chat how to contact ! support team ! customer support number contact number for ! how to contact 1 support by email contact ! help customer service number for ! ! customer number ! call phone customer support ! number for ! help 1 customer service contact number how to get ! phone number 1 customer service 800 number 1 ! phone number 1 ! customer service 1 ! customer support phone number ! technical support chat ! support phone number support ! contact 1 phone number support how to contact ! customer service ! assistance page 1 help with ! ! online help 1 a.c.c.o.u.n.t support phone number 1 tech support ! helpline chat ! tech support phone number 1 ! help ! assistance phone number ! email support phone number ! problems today ! toll free no my emails at ! recover ! with phone number 1 customer care phone number ! security phone number hotline ! 1 help phone number ! support phone number ! customer support 1 a.c.c.o.u.n.t helpline how do i contact ! support ! assistance ! helpline 1 mail customer service number help with my ! a.c.c.o.u.n.t ! phone ! customer support email address contact 1 support contact ! security 1 800 number customer service ! phone number canada ! support phone number how to call ! support phone number for ! tech support 1 support ! contact ! support canada how to contact ! ! technical support number ! tech support number 1 help for ! ! phone number free ! helpline no ! customer support toll free number ! l.i.v.e chat tech support help with ! a.c.c.o.u.n.t phone number ! technical support toll free number ! password reset email need help with ! a.c.c.o.u.n.t phone ! support 1 customer support phone number usa 1 customer phone number ! tech support number usa customer care number for ! a.c.c.o.u.n.t ! phone number ! helpline number usa ! login phone number contact details for ! ! customer service line ! password help how to recover password for ! a.c.c.o.u.n.t ! support number how to call ! contact ! support phone number ! support phone number ! problems telephone number for 1 email support ! login problems what is the phone number for 1 customer service i can t access my a.c.c.o.u.n.t how to retrieve your ! password ! help desk email address contact number in ! ! help phone number canada ! customer care toll free no call 1 a.c.c.o.u.n.t support ! helpline number canada 1 ! tech support how do you contact ! customer service ! business support call 1 support 0 ! information phone number phone number for ! customer service ! online support ! com tech support ! help email ! password recovery tech support ! help center phone number india 1 help number 1 ! help phone number call 1 customer care phone number for ! ! toll free number canada ! service phone number ! customer service canada how to email ! support contact 1 mail support telephone number for 1 support call ! for password ! free phone number ! toll free phone contact ! ! tech support l.i.v.e chat ! contact ! contact number ! telephone help ! ! password recovery phone number usa ! customer service support number 0 phone number for 1 tech support ! phone number for help 1 customer service ! technical customer support 1 contact customer service ! help number usa ! support helpline 1 a.c.c.o.u.n.t recovery phone support chat with ! support ! customer service phone number usa ! support services ! customer service number usa contact 1 email customer service business ! a.c.c.o.u.n.t ! customer service number canada ! a.c.c.o.u.n.t support phone number customer care number of ! recover password for ! a.c.c.o.u.n.t 0 ! com customer service phone number contact ! support ! support usa 1 tech support number contact 1 via phone how to contact ! by phone ! help email address how do i contact ! tech support reset password on ! a.c.c.o.u.n.t call 1 helpline ! toll free contact number how do i call 1 customer service ! support number ! contact number uk ! l.i.v.e chat help contact ! by email ! help phone ! email issues ! number for help ! customer service phone number tech support for ! contact 1 tech support phone phone number to contact ! contact 1 mail how to contervice number Gmail customer service phone number sdfsd ? ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 16:55:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2018 15:55:57 +0000 Subject: [Koha-bugs] [Bug 19924] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19924 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Gmail customer service |SPAM |1-844-370-6818 Gmail | |customer service number | |Gmail customer service | |phone number sdfsd ? ? | CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 7 23:53:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jan 2018 22:53:46 +0000 Subject: [Koha-bugs] [Bug 19890] authorised value branches is not visible from dropdown in Admin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19890 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |aleisha at catalyst.net.nz Resolution|--- |FIXED --- Comment #4 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #3) > I have just tried: If you try to create a AV category "branches", there is a > warning box with "The authorized value category 'branches', 'itemtypes' and > 'cn_source' are used internally by Koha and are not valid." > > That seems enough to me. I agree, this seems like the message the bug report asks for. Setting to Resolved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 01:33:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 00:33:15 +0000 Subject: [Koha-bugs] [Bug 19416] Make it possible to hide "Show checkouts to guarantor" on patron's detail page in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19416 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Aleisha Amohia --- I think this would be fixed with a patch for Bug 19818. I'll mark this one as a duplicate because I'm hoping to get a patch for the other one in this years academy. :) *** This bug has been marked as a duplicate of bug 19818 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 01:33:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 00:33:15 +0000 Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 --- Comment #2 from Aleisha Amohia --- *** Bug 19416 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 03:07:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 02:07:47 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #1 from Aleisha Amohia --- Can you please provide a plan of how to reproduce this and where the message shows? I can't seem to reproduce the bug but I may be trying to create it in the wrong place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 03:10:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 02:10:41 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #2 from Katrin Fischer --- It's been a little while, did you try the web based self check with a fine amount on the account over what is set in OPACFineNoRenewals? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 03:15:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 02:15:28 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #3 from Katrin Fischer --- The problem is here: sco-main.tt 55 [% ELSIF ( circ_error_DEBT ) %] 56 You owe the library [% amount %] and cannot check out. opac / sco / sco-main.pl 165 if ($issue_error eq 'DEBT') { 166 $template->param(amount => $currencySymbol.$impossible->{DEBT}); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 08:51:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 07:51:46 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70312|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Created attachment 70320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70320&action=edit Bug 18071: (QA Followup) - Add additional feedback and expand commit option To test: Test as before, verify commit option makes no changes and provides additional feedback when verbose Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 08:55:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 07:55:11 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 --- Comment #21 from Marcel de Rooy --- (In reply to Nick Clemens from comment #19) > Added some additional feedback, please verify you are okay with changes > Marcel, otherwise looks good. Fine with me. Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 11:25:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 10:25:07 +0000 Subject: [Koha-bugs] [Bug 6851] A utility that will search out analytics records and set the MARC header appropriately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|A utility that will search |A utility that will search |out analytics records and |out analytics records and |set the MARC header |set the MARC header |appropriately. |appropriately -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 11:25:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 10:25:31 +0000 Subject: [Koha-bugs] [Bug 6851] A utility that will search out analytics records and set the MARC header appropriately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6851 --- Comment #13 from Katrin Fischer --- I think it could still be useful, but not sure it should still be assigned to Robin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 13:06:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 12:06:22 +0000 Subject: [Koha-bugs] [Bug 19925] New: Account restrictions applied during closure periods. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19925 Bug ID: 19925 Summary: Account restrictions applied during closure periods. Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: r.delahunty at arts.ac.uk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com While Koha can be configured to stop fines from being levied, and stop items being due on (or auto-renewing during) closed days, Koha continues to check accounts to see if they need to be restricted during closure periods. With a 2 week closure at Christmas and ODUE2 triggering an account restriction after 7 days, users who are unable to return items on hold (reserved) and due back in the final few days before the closure have their account restricted during the closure period, meaning all other items stop auto-renewal when the library opens again, potentially leading to large fines. Account restricting should be (optionally) deferred until the opening of the library after the closure period- when we are on holiday Koha should also take a complete holiday too. Ray Delahunty University of the Arts London -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 14:34:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 13:34:50 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:16:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 14:16:42 +0000 Subject: [Koha-bugs] [Bug 19324] New Inventory workflow eliminates "mark item seen" and doesn' t show data in table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324 --- Comment #3 from Jessie Zairo --- Thanks Marcel. Here are 2 major changes that library staff have contacted us about. Items that get checked in - if you don't use the 'Do not check in items scanned during inventory' option, the items get checked in but there's no longer a way to identify that. Previously a yellow box would report check-ins so staff could follow-up and make sure the items were mistakenly checked in, or if fines need written off. Lost statuses get removed - if an item has a lost status, the inventory tool removes it but no longer reports that the status was removed. It was handy knowing which items changed, as often items marked 'Missing' were misshelved and the list of scanned barcodes can help identify where they are on the shelf. It would be great if the resulting report would list removal of a lost status for each affected item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:17:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 14:17:19 +0000 Subject: [Koha-bugs] [Bug 19324] New Inventory workflow eliminates "mark item seen" and doesn' t show data in table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 15:18:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 14:18:21 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #38 from Koha Team Lyon 3 --- Hey Alex, Happy new year I tested again the three periodicity and it works like a charm ! I agree with you about not renewing automatically and being able to modify irregularities. The more flexibility, the better. Just a thing about why I don't sign yet : I tested on top master and I had to solve a conflict (in the first patch : staff-global.css file) to be able to apply the patch. I leave you rebase the commit and I will sign it right away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:39:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 15:39:57 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:40:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 15:40:00 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68648|0 |1 is obsolete| | Attachment #68649|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 70322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70322&action=edit Bug 16782 - disclose JSON URL for reports on the saved report page It has always annoyed me that you had to look at the help to divine the url for a report. This patch works it out and displays it for you in a new column on the saved reports table. Requirements: - OPACBaseURL and staffClientBaseURL preferences must be set for the urls to be complete. It's ok if they are not, but it's better if they are. - You must have a saved report that is public to your OPAC, and one that is not public. To test: - create a public saved report and a private staff report. They can be anything. - view the saved reports page, note that under a new heading of JSON URL the link to the json feed for that report shows. - copying and pasting that link into the address bar, or clicking it, should take you to the results of the selected report. sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:40:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 15:40:03 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #20 from Nick Clemens --- Created attachment 70323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70323&action=edit Bug 16782 - missing , fixed now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 16:40:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 15:40:06 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #21 from Nick Clemens --- Created attachment 70324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70324&action=edit Bug 16782: (QA Followup) Use Koha.Preference for staffClientBaseURL and provide classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:25:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 16:25:37 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70230|0 |1 is obsolete| | --- Comment #7 from David Gustafsson --- Created attachment 70325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70325&action=edit Bug 19893 - Alternative optimized indexing for Elasticsearch Add alternative optimized indexing for Elasticsearch How to test: 1) Time a full elasticsearch re-index by running the rebuild_elastic_search.pl with the -d flag: `koha-shell -c "time rebuild_elastic_search.pl -d"`. 2) Enable ExperimentalElasticSearchIndexing system preference (found under Global System preferences -> Administration -> Search Engine). 3) Time a full re-index again, it should be about twice at fast (for a couple of thousand biblios, with fewer biblios results may be more unpredictable). Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:27:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 16:27:52 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #8 from David Gustafsson --- Fixed decoding of marc records returned from Elasticsearch (depending on setting) in some places where this was missing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:54:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 16:54:46 +0000 Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 --- Comment #5 from Nick Clemens --- Created attachment 70326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70326&action=edit Bug 19267: Followup - only fire if changes and don't use javascript -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:54:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 16:54:44 +0000 Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 17:58:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 16:58:15 +0000 Subject: [Koha-bugs] [Bug 19926] New: Add the Koha::Object->unblessed_all_relateds method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 Bug ID: 19926 Summary: Add the Koha::Object->unblessed_all_relateds method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org In order to refactor our legacy code step-by-step, we will need to provide code with the exact same behaviors and then improve it. The same idea appears for the TT syntax for notices: we will want to deprecate the existing syntax in order to support only one syntax. Currently we fetch all the values from the related tables, without knowing which are actually used. I am suggestion to introduce a Koha::Object->unblessed_all_relateds method which will return a hash containing all the fields from the related tables (with the problems we know: collision in column names). It is the existing behavior of GetOverduesForPatron and GetPendingIssues for instance, they are used to send notices and so we have to provide all the data needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:00:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:00:16 +0000 Subject: [Koha-bugs] [Bug 19926] Add the Koha::Object->unblessed_all_relateds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:00:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:00:21 +0000 Subject: [Koha-bugs] [Bug 19926] Add the Koha::Object->unblessed_all_relateds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 --- Comment #1 from Jonathan Druart --- Created attachment 70327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70327&action=edit Bug 19926: Add the Koha::Object->unblessed_all_relateds method In order to refactor our legacy code step-by-step, we will need to provide code with the exact same behaviors and then improve it. The same idea appears for the TT syntax for notices: we will want to deprecate the existing syntax in order to support only one syntax. Currently we fetch all the values from the related tables, without knowing which are actually used. I am suggestion to introduce a Koha::Object->unblessed_all_relateds method which will return a hash containing all the fields from the related tables (with the problems we know: collision in column names). It is the existing behavior of GetOverduesForPatron and GetPendingIssues for instance, they are used to send notices and so we have to provide all the data needed. See dependent bugs to understand the context and test this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:00:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:00:26 +0000 Subject: [Koha-bugs] [Bug 19926] Add the Koha::Object->unblessed_all_relateds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 --- Comment #2 from Jonathan Druart --- Created attachment 70328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70328&action=edit Bug 19926: Add tests for Koha::Object->unblessed_all_relateds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:02:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:02:56 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:02:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:02:59 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70273|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 70329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70329&action=edit Bug 19914: Add an id to the Delete button on the library list view To ease selenium tests, see bug 19243. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:03:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:03:23 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- I added a space for readability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:14:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:14:52 +0000 Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com --- Comment #7 from Jessie Zairo --- *** Bug 18793 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:14:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:14:52 +0000 Subject: [Koha-bugs] [Bug 18793] Shipping Cost can not be added after closing an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18793 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jessie Zairo --- *** This bug has been marked as a duplicate of bug 19694 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:19:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:19:38 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:19:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:19:40 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 --- Comment #10 from Jonathan Druart --- Created attachment 70331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70331&action=edit Bug 17553: Move GetOverduesForPatron to Koha::Patron->get_overdues With the help of Koha::Object->unblessed_all_relateds we are going to replace GetOverduesForPatron without introducing regressions (hopefully) on both template notice syntaxes. Test plan: 0/ Do not apply any patches 1/ Check some items in to a given patron, with and without overdues. 2/ Print the overdues slip (Circulation module > Print > Print overdues) 3/ Apply these patches 4/ Print again and compare the result => The 2 generated slips must be exactly the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:19:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:19:29 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:19:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:19:43 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70319|0 |1 is obsolete| | --- Comment #20 from Nick Clemens --- Created attachment 70332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70332&action=edit Bug 19899: Restore Item floats feature - do not crash Error is "The method noreturn is not covered by tests!" caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn) the library must be the current library (from userenv). This behaviour is used in C4::Circulation::AddReturn On bug 18276 I assumed that the value was either holdingbranch or homebranch, and forgot it could be "noreturn" Test plan: Set Return policy to Item floats Check an item in => without this patch it explodes => With this patch applied it will check the item in Signed-off-by: Mohd Hafiz Yusoff Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:19:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:19:35 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57202|0 |1 is obsolete| | Attachment #57312|0 |1 is obsolete| | Attachment #57313|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 70330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70330&action=edit Bug 17553: Move existing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:20:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:20:35 +0000 Subject: [Koha-bugs] [Bug 19926] Add the Koha::Object->unblessed_all_relateds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 [Bug 17553] Move GetOverduesForPatron to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:20:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:20:35 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19926 --- Comment #11 from Jonathan Druart --- I have moved the Koha::Object->unblessed_all_related method to its own bug report, see bug 19926. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 [Bug 19926] Add the Koha::Object->unblessed_all_relateds method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 18:28:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 17:28:11 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 20:03:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 19:03:50 +0000 Subject: [Koha-bugs] [Bug 14228] fill in patron info by scanning an ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 20:50:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 19:50:53 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 20:54:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 19:54:56 +0000 Subject: [Koha-bugs] [Bug 19927] New: Editing an item Type (Modify Item Type) Causes Remote Image Value to be Lost Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19927 Bug ID: 19927 Summary: Editing an item Type (Modify Item Type) Causes Remote Image Value to be Lost Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: michael at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When editing an item type in the staff client, if you have set a remote image url as an icon, that image link is lost, thus removing the remote image. To re-create 1.) Set remote image for an item type 2.) Save 3.) Confirm image is present 4.) Edit Item Type 5.) Go to Remote image tab, image link in field has disappeared Link should persist during editing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:16:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 20:16:11 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes at biblibre.com --- Patch tested with a sandbox, by George -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:16:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 20:16:25 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70255|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:16:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 20:16:38 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 --- Comment #3 from sandboxes at biblibre.com --- Created attachment 70333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70333&action=edit Bug 19913: Fix embedded HTML5 videos at the OPAC Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt A space is missing between 'source' and 'src' Test plan: Set HTML5MediaEnabled to OPAC Put a video link to 856$u See the OPAC detail page, tab video, click the video => Should play with this patch applied Note that this does not affect intranet Signed-off-by: George -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 21:17:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 20:17:04 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 22:01:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 21:01:30 +0000 Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 22:26:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 21:26:12 +0000 Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 8 22:28:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jan 2018 21:28:48 +0000 Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 --- Comment #1 from Jessie Zairo --- This would be a great feature for libraries that get order records from an outside vendor. Current functionality only allows staff to attach a suggestion from the purchases suggestions and not directly from a staged file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:02:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:02:27 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:02:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:02:44 +0000 Subject: [Koha-bugs] [Bug 10102] don't show empty novelist tab if no data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10102 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:01:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:01:23 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle field to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:59:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:59:33 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:59:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:59:13 +0000 Subject: [Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:02:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:02:59 +0000 Subject: [Koha-bugs] [Bug 10060] Self Checkout module does not honour circ control In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:00:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:00:25 +0000 Subject: [Koha-bugs] [Bug 11953] print receipt from self checkout should be a choice of slip type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11953 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:59:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:59:23 +0000 Subject: [Koha-bugs] [Bug 12468] copyright symbol not translating right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12468 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:59:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:59:24 +0000 Subject: [Koha-bugs] [Bug 19939] New: Move cataloging Z39.50 results actions into menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939 Bug ID: 19939 Summary: Move cataloging Z39.50 results actions into menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 19932 The cataloging Z39.50 popup window of search results can be very crowded, so it might be good to move the "actions," (MARC, Card, Import), into a menu. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:01:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:01:55 +0000 Subject: [Koha-bugs] [Bug 11071] RDA Helper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11071 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:59:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:59:24 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939 [Bug 19939] Move cataloging Z39.50 results actions into menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:43:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:43:01 +0000 Subject: [Koha-bugs] [Bug 19930] New: Dropbox mode statistical report Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19930 Bug ID: 19930 Summary: Dropbox mode statistical report Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice to have a way to identify dropbox mode returned items. Now there's no way to do that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:59:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:59:02 +0000 Subject: [Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:01:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:01:11 +0000 Subject: [Koha-bugs] [Bug 11836] population of template variables used by cat-toolbar.inc should be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11836 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:58:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:58:47 +0000 Subject: [Koha-bugs] [Bug 13033] Waiting holds do not alert on check-in. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13033 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:00:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:00:52 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:01:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:01:04 +0000 Subject: [Koha-bugs] [Bug 11837] generation of template-variables used by members-toolbar.inc should be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11837 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:58:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:58:27 +0000 Subject: [Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:21:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 16:21:49 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:21:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 16:21:55 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61043|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 70379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70379&action=edit Bug 18255: Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem The subroutine GetBiblioItemByBiblioNumber considers that we have a 1-N relation between biblio and biblioitems, which is wrong (it's 1-1). So the calls can be replaced with Koha::biblio->biblioitem, it will ease the read of the code. Test plan: 1. Use the ILSDI service to display info of a bibliographic record, biblioitems fields must be displayed 2. Search for items, biblioitems info must be displayed as well in the result table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:55 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #9 from Jonathan Druart --- Created attachment 70373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70373&action=edit Bug 19936: Remove the subroutine Generate_Userid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:06:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:06:09 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:55:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:55:12 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:06:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:06:23 +0000 Subject: [Koha-bugs] [Bug 5770] email librarian when purchase suggestion made In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:55:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:55:14 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 --- Comment #1 from Owen Leonard --- Created attachment 70341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70341&action=edit Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:28 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:06:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 16:06:59 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > Waiting for an answer from the mailing list - > http://lists.koha-community.org/pipermail/koha-devel/2017-March/043530.html This was not for this bug, it was for bug 18242. I have no idea why this comment is here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:07:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:07:06 +0000 Subject: [Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream, and fudge flavors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|trea at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:05:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:05:31 +0000 Subject: [Koha-bugs] [Bug 7030] Define maximum number of holds on branch level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7030 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:33 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #3 from Jonathan Druart --- Created attachment 70367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70367&action=edit Bug 19936: Replace Check_userid - Update the occurrences We previously prove that the method and the subroutine were equivalent, we know update the controller calls. Test plan: - Add and update a patron with different variations of userid (automatically generated or not) - Import patrons with and without userid, as well as with existing userid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:05:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:05:49 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:40 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #5 from Jonathan Druart --- Created attachment 70369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70369&action=edit Bug 19936: Move and add tests for Generate_Userid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:30 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #2 from Jonathan Druart --- Created attachment 70366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70366&action=edit Bug 19936: Add the Koha::Patron->has_valid_userid method Reuse how C4::Members::Check_Userid works and adapt it to write Koha::Patron->check_userid Adapt the tests to use this new method. The tests still pass, we can adapt the different callers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:36 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #4 from Jonathan Druart --- Created attachment 70368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70368&action=edit Bug 19936: Remove the subroutine Check_Userid It is no longer in user, we can remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:24 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:43 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #6 from Jonathan Druart --- Created attachment 70370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70370&action=edit Bug 19936: Add the Koha::Patron->generate_userid method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:04:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:04:50 +0000 Subject: [Koha-bugs] [Bug 7386] Label batches cannot be batch deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:07:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:07:29 +0000 Subject: [Koha-bugs] [Bug 4373] Placing and Processing Items Simultaneously causes multiple issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4373 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:27 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #1 from Jonathan Druart --- Created attachment 70365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70365&action=edit Bug 19936: Replace Check_userid - just move the tests This patch moves the tests related to Check_userid out of Members.t The tests must pass with only this patch applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:47 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #7 from Jonathan Druart --- Created attachment 70371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70371&action=edit Bug 19936: Adapt tests And prove that we are not cheating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:05:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:05:19 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:04:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:04:26 +0000 Subject: [Koha-bugs] [Bug 9717] localuse recorded for holds/transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9717 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jminges at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:07:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:07:45 +0000 Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn' t take precedence over a hold transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|smoreland at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:59 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #10 from Jonathan Druart --- Created attachment 70374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70374&action=edit Bug 19936: Remove warnings from tests C4::Members did not "use warnings;" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:51 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #8 from Jonathan Druart --- Created attachment 70372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70372&action=edit Bug 19936: Replace Generate_Userid - Update the occurrences Test plan: Same test plan as previous patch: add/update/import patrons and watch the userid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:08:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:08:18 +0000 Subject: [Koha-bugs] [Bug 4040] Placing a hold on an item while it is in transit results in duplicate dialogs upon check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4040 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:25:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 16:25:23 +0000 Subject: [Koha-bugs] [Bug 18255] Koha::Biblio - Remove GetBiblioItemByBiblioNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18255 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > Waiting for an answer from the mailing list - > http://lists.koha-community.org/pipermail/koha-devel/2017-March/043530.html I am not sure to understand why I sent this email, the $bibitems parameter of AddReserve is not used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:49:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:49:44 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:49:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:49:53 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #17 from sandboxes at biblibre.com --- Created attachment 70376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70376&action=edit Bug 18915: Fix checkout note email message This patch replaces the <> in the email with <> and uses CHECKOUT_NOTE instead of PATRON_NOTE. This patch also adds the notice to installer/data/mysql/en/mandatory/sample_notices.sql, and updates the PATRON_NOTE entry in installer/data/mysql/updatedatabase.pl To test: 1) Apply patch and update database 2) View the message_queue table in mysql 3) Check out an item if haven't already 4) Go to OPAC and set a checkout note for an item 5) View message_queue table and confirm it the title is included in the email and all instances of 'patron note' have been replaced with 'checkout note' 6) Disable javascript in browser 7) repeat steps 4 and 5 and confirm all works as expected Sponsored-by: Catalyst IT Signed-off-by: Marjorie Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:08:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:08:49 +0000 Subject: [Koha-bugs] [Bug 3367] Overdue Rules not processed for patrons with checkouts more than 90 days overdue. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3367 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mcoalwell at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:09:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:09:31 +0000 Subject: [Koha-bugs] [Bug 3298] Independent item "Status Check" functionality needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3298 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|smoreland at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:09:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:09:52 +0000 Subject: [Koha-bugs] [Bug 3153] 'maxoutstanding' syspref does not disallow placing holds on staff side In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3153 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mcoalwell at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:49:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:49:44 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #1 from M. Tompsett --- Created attachment 70375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70375&action=edit Bug 19938: Refactor checkoverdues TEST PLAN --------- 0) back up plack error log if you care. 1) Run these on your kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. However, the log file will have noise. 2) Run these on your kohadevbox: git bz apply 19938 restart_all echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. This time the log file will have no noise. 3) run koha qa test tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:09:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:09:40 +0000 Subject: [Koha-bugs] [Bug 3288] Transit prompt not immediately triggered after hold is canceled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3288 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|smoreland at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:50:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:50:00 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #19 from sandboxes at biblibre.com --- Created attachment 70378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70378&action=edit Bug 18915: Renaming svc/patron_notes to svc/checkout_notes For consistency. Signed-off-by: Marjorie Barry-Vila https://bugs.koha-community.org/show_bug.cgi?id=19801 Signed-off-by: Marjorie Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:10:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:10:02 +0000 Subject: [Koha-bugs] [Bug 2838] Checking in an in-transit item to its originating branch causes improper error message (s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2838 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mcoalwell at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:10:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:10:32 +0000 Subject: [Koha-bugs] [Bug 813] OPAC lists should store comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=813 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:51:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:51:32 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70313|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 70340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70340&action=edit Bug 19921: Fix update child when only one adult patron category exist We are passing the Koha::Patron::Category object to the template instead of the categorycode. To reproduce this bug you must test in a system which has only one patron category of the "adult" type. View the details of a patron with a child-type patron category and choose More -> Update child to adult patron. This results in an error: Can't call method "category_type" on an undefined value at /home/vagrant/kohaclone/members/update-child.pl line 84. The URL of the error page shows a problem with the parameters being passed: members/update-child.pl?op=update&borrowernumber=12345&catcode=Koha::Patron::Category=HASH(0xa168a18)&catcode_multi= Test plan: Make sure you have only 1 adult patron category Update a child to adult => With this patch applied the error is gone and the patron has been correctly updated Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:49:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:49:41 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:09:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:09:10 +0000 Subject: [Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|smoreland at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:08:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:08:31 +0000 Subject: [Koha-bugs] [Bug 3765] Road Types and Street Numbers on Patron Rec Inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3765 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mcoalwell at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:51:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:51:17 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:49:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:49:37 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:10:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:10:22 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|smoreland at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:51:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:51:29 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:49:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:49:31 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:49:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:49:57 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #18 from sandboxes at biblibre.com --- Created attachment 70377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70377&action=edit Bug 18915: Giving CHECKOUT_NOTE access to issues table This patch allows the notice to reference the issues table so that the checkout note itself can be added to the note if wanted, such as in Comment 9. Sponsored-by: Catalyst IT Signed-off-by: Marjorie Barry-Vila https://bugs.koha-community.org/show_bug.cgi?id=19801 Signed-off-by: Marjorie Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:55:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:55:27 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:04:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:04:48 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:04:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:04:58 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #4 from Jonathan Druart --- Created attachment 70344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70344&action=edit Bug 12001: Move GetMemberAccountBalance to Koha::Account->non_issues_charges As said previously, GetMemberAccountBalance returns ( the balance, the non issues charges, the other charges) The other charges are the balance - the non issues charges. In this patch we remove the subroutine from C4::Members and use the new Koha::Account->non_issues_charges subroutine instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:04:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:04:51 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70314|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 70342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70342&action=edit Bug 12001: Move GetMemberAccountRecords to the Koha namespace The GetMemberAccountRecords may be a perf killer, it retrieves all the account lines of a patron and then the related item and biblio information. Most of the time we only want to know how much the patron owns to the library (sum of amountoutstanding). We already have this information in Koha::Patron->account->balance. This patch replaces the occurrences of this subroutine by fetching only the information we need, either the balance, the detail, or both. It removes the formatting done in the module, to use the TT plugin 'Price' instead. There is a very weird and error-prone behavior/feature in GetMemberAccountBalance (FIXME): as the accountlines.accounttype is a varchar(5), the value of the authorised value used for the ManInvInNoissuesCharge pref (category MANUAL_INV) is truncated to the 5 first characters. That could lead to unexpected behaviors. On the way, this patchset also replace the GetMemberAccountBalance subroutine, which returns the balance, the non issues charges and the other charges. We only need to have the balance and the non issues charges to calcul the third one. Test plan: Add several fees for a patron and play with HoldsInNoissuesCharge, RentalsInNoissuesCharge and ManInvInNoissuesCharge. The information (biblio and item info, as well as the account line) must be correctly displayed on the different screens: 'Fines' module, fine slips, circulation module Note that this patchset could introduce regression on price formatting, but will be easy to fix using the TT plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:17:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:17:05 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 --- Comment #7 from George Williams (NEKLS) --- (In reply to Jonathan Druart from comment #5) > (In reply to sandboxes at biblibre.com from comment #2) > > Patch tested with a sandbox, by George > > George, I have modified your signed-off-by line to add your surname. I hope > it is ok with you. Jonathan - not a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 12:46:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 11:46:53 +0000 Subject: [Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:55:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:55:22 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 12:44:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 11:44:55 +0000 Subject: [Koha-bugs] [Bug 19929] New: Add Koha Objects for class_source and class_sort_rules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Bug ID: 19929 Summary: Add Koha Objects for class_source and class_sort_rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:04:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:04:55 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #3 from Jonathan Druart --- Created attachment 70343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70343&action=edit Bug 12001: Add tests Yes, we need tests to make sure we understand what is going on in this subroutine. The different combination of HoldsInNoissuesCharge, RentalsInNoissuesCharge and ManInvInNoissuesCharge are tested here with the subroutine we are going to remove (GetMemberAccountBalance). In one of the next patches the new methods will be used to make sure we are not modifying the calculated values (except the formatting). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:05:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:05:02 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #5 from Jonathan Druart --- Created attachment 70345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70345&action=edit Bug 12001: Prove that result are the same \o/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:55:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:55:32 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:05:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:05:05 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #6 from Jonathan Druart --- Created attachment 70346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70346&action=edit Bug 12001: Format DEBT correctly Before this patchset, DEBT was formatted in the module, now it should be done template-side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 12:46:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 11:46:55 +0000 Subject: [Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 --- Comment #1 from Nick Clemens --- Created attachment 70337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70337&action=edit Bug 19929 - Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassificationSorters.t prove -v t/db_dependent/Koha/ClassificationSources.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:37:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 16:37:47 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70239|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:38:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 16:38:03 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69798|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:49:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:49:10 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #16 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Marjorie Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 02:20:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 01:20:29 +0000 Subject: [Koha-bugs] [Bug 16483] Ampersand breaks search for analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16483 Feli Kramer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|feli at interkatz.de |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 02:20:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 01:20:25 +0000 Subject: [Koha-bugs] [Bug 13644] Paging Javascript breaks links with anchor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13644 Feli Kramer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|feli at interkatz.de |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:38:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 16:38:22 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:38:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 16:38:32 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 17:39:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 16:39:06 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 --- Comment #9 from Alex Arnaud --- I removed the 2 previous patches. Sent to the wrong BZ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:03:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:03:25 +0000 Subject: [Koha-bugs] [Bug 9834] Should reverting a waiting hold keep the item number? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mcoalwell at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:03:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:03:58 +0000 Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for items "Waiting" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org, |george at nekls.org |mcoalwell at nekls.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:15:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:15:06 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:14:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:14:39 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19934 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19934 [Bug 19934] Move C4::Members::patronflags to the Koha namespace - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:26:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:26:15 +0000 Subject: [Koha-bugs] [Bug 19938] New: Refactor C4::Overdues::checkoverdues Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Bug ID: 19938 Summary: Refactor C4::Overdues::checkoverdues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com While retesting a bug, I ran a prove -r -v t, which generated a lot of log noise. One such entry was: [Tue Jan 9 03:54:58 2018] starman: Use of uninitialized value $overdues_count in numeric gt (>) at /home/vagrant/kohaclone/opac/opac-main.pl line 76. The $overdues_count was set by a call to checkoverdues. Reading the code I noticed someone actually commented: # returning the count and the results is silly So, this is a refactor of the function and all the calls. It was surprisingly small. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:03:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:03:36 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12001 --- Comment #24 from Jonathan Druart --- Bug 12001 - GetMemberAccountRecords slows down display of patron details and checkout pages Will remove GetMemberAccountRecords and GetMemberAccountBalance Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:15:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:15:06 +0000 Subject: [Koha-bugs] [Bug 19934] Move C4::Members::patronflags to the Koha namespace - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:03:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:03:36 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:15:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:15:06 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19933, 19934 --- Comment #21 from Jonathan Druart --- Bug 19933 - Move C4::Members::patronflags to the Koha namespace - part 1 Bug 19934 - Move C4::Members::patronflags to the Koha namespace - part 2 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19934 [Bug 19934] Move C4::Members::patronflags to the Koha namespace - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:14:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:14:39 +0000 Subject: [Koha-bugs] [Bug 19934] New: Move C4::Members:: patronflags to the Koha namespace - part 2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19934 Bug ID: 19934 Summary: Move C4::Members::patronflags to the Koha namespace - part 2 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 19933 See bug 19933 for the part 1 I will need help for the SIP code (C4::SIP::ILS::Patron->new) At this point there is only one occurrence of C4::Members::patronflags left in this module and I have no idea how to remove it safely Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:01:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:01:52 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70274|0 |1 is obsolete| | Attachment #70275|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 70338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70338&action=edit Bug 19915 - Unit test prove -v t/db_dependent/Items/GetItemsForInventory.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:01:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:01:50 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:01:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:01:55 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #6 from Nick Clemens --- Created attachment 70339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70339&action=edit Bug 19915 - Use cn_sort values for getting inventory items To test: 1 - Catalog an item under LCC with callnumber GT95 2 - cn_sort should calculate as GT0095 3 - Go to inventory tool 4 - Enter a range that should have your item e.g LC GT90 to GT100 5 - Item is not returned 6 - Apply patch 7 - Item should be returned 8 - Verify things otherwise work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:34:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:34:53 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:24:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:24:50 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:25:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:25:18 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:26:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:26:57 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:25:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:25:18 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:24:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:24:59 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #3 from Jonathan Druart --- Created attachment 70349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70349&action=edit Bug 19933: Remove patronflags - easy ones This patch replaces the easy occurrences of patronflags. These calls only need the CHARGES->amount value, that is the non issues charges. Luckily we now have a Koha::Account->non_issues_charges that deal with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:24:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:24:53 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #1 from Jonathan Druart --- Created attachment 70347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70347&action=edit Bug 19933: Remove patronflags - unused vars oldamount/amountold in circulation.pl There is oldamound/amountold variable that is sent to the template but never used later. Let remove it now to avoid useless replacement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:25:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:25:03 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #4 from Jonathan Druart --- Created attachment 70350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70350&action=edit Bug 19933: Remove patronflags - tricky ones Here we are, patronflags is used in a couple of places where (almost) all flags were really useful: C4::SIP::ILS::Patron->new and circulation.pl This patch only deal with the circulation code as I am not convident enough with SIP code. The change does not seems trivial because of the complexity of the existing code, but the logic is the same. We send a variable to the template depending on the situation of the patron. I guess only code eyes ball could catch issue in this patch quickly. Maybe we need to find a good place in a Koha module to move this code and provide code coverage (especially when C4::SIP::ILS::Patron will reuse it). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:24:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:24:56 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #2 from Jonathan Druart --- Created attachment 70348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70348&action=edit Bug 19933: Remove patronflags - In CanBookBeIssued The change is trivial here, we only want to pass gonenoaddress, lost and is_debared to the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:26:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:26:42 +0000 Subject: [Koha-bugs] [Bug 19935] New: Move C4::Members::GetPendingIssues to the Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Bug ID: 19935 Summary: Move C4::Members::GetPendingIssues to the Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:35:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:35:47 +0000 Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get emailed as indicated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:26:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:26:57 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19935 --- Comment #22 from Jonathan Druart --- Bug 19935 - Move C4::Members::GetPendingIssues to the Koha namespace Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:54:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:54:14 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 --- Comment #5 from Jonathan Druart --- (In reply to sandboxes at biblibre.com from comment #2) > Patch tested with a sandbox, by George George, I have modified your signed-off-by line to add your surname. I hope it is ok with you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:23 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #3 from Jonathan Druart --- Created attachment 70353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70353&action=edit Bug 19935: Replace GetPendingIssues - ILSDI Here we should only access to what we want in the template, but let do it as it for now. Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=542&show_contact=0&show_loans=1 With 42 a borrowernumber with checkouts Before and after these patches the XML must be the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:18:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:18:30 +0000 Subject: [Koha-bugs] [Bug 19923] conceptual searching in koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19923 --- Comment #2 from Hussain A --- Dear Katrin Fischer, Thanks for your guidance. I found the solution based on changing the default status of "IncludeSeeFromSearches" feature to "include". Best Regards. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:35 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #7 from Jonathan Druart --- Created attachment 70357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70357&action=edit Bug 19935: Replace GetPendingIssues - opac-ics.pl We only need the biblio title and the barcode, we should not need the whole prefetch. Test plan: On your OPAC summary page export your checkout list using the "Download as iCal/.ics file" link. Before and after the patchset, the generated files must be the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:19 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #2 from Jonathan Druart --- Created attachment 70352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70352&action=edit Bug 19935: Replace GetPendingIssues - IssueSlip Luckily we have a good test coverage here! Test plan: Print issue slips before and after these patches (with overdues, etc.) They should be the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:48 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #11 from Jonathan Druart --- Created attachment 70361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70361&action=edit Bug 19935: Replace GetPendingIssues - Remove the residue Here we are, no more occurrences of GetPendingIssues, we can remove the tests and subroutine \o/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:21:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:21:07 +0000 Subject: [Koha-bugs] [Bug 18923] Resolve a warn in Biblio::GetCOinSBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18923 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Fridolin SOMERS --- Pushed to 17.05.x for 17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:38 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #8 from Jonathan Druart --- Created attachment 70358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70358&action=edit Bug 19935: Replace GetPendingIssues - opac-user.pl At first glance we just need the biblio title and the subtitle (in addition of the fines info), we should not need the prefetch. Test plan: Loggin at the OPAC, on the summary page you should see your checkouts and overdues with the correct values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:41 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #9 from Jonathan Druart --- Created attachment 70359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70359&action=edit Bug 19935: Replace GetPendingIssues - sco-main Same as previously, we do not need all the prefetched values here, just a few. Test plan: Use the self checkout module to check some items out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:16 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #1 from Jonathan Druart --- Created attachment 70351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70351&action=edit Bug 19935: Add Koha::Patron->pending_checkouts To move this subroutine out of the C4 namespace we face the same problematic as bug 17553 (with GetOverduesForPatron). We need to provide an equivalent method and so return all the related value for a given checkout. We can acchieve the easily using Koha::Object->unblessed_all_relateds, but we need to keep in mind that it is a temporary move. Indeed we will want to use our API to only access/retrive values we really need. The whole trick could be removed when the current syntax for notices will be deprecated and removed. Note: this method returns the same number of elements than ->checkouts They indeed returns the same things, but it sounds better to me to have a different method to highlight (from the callers) where does it come from (C4::Members::GetPendingIssues). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:13 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 09:41:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 08:41:46 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #41 from Alex Arnaud --- (In reply to Koha Team Lyon 3 from comment #38) > > Just a thing about why I don't sign yet : I tested on top master and I had > to solve a conflict (in the first patch : staff-global.css file) to be able > to apply the patch. > I leave you rebase the commit and I will sign it right away. Hello Olivier, patches rebased. Happy new year! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:32 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #6 from Jonathan Druart --- Created attachment 70356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70356&action=edit Bug 19935: Replace GetPendingIssues - summary-print We are in the notices part, so we need to fetch all the data to avoid regressions. Test plan: Print a summary slip before and after this patch. They must be the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:45 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #10 from Jonathan Druart --- Created attachment 70360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70360&action=edit Bug 19935: Replace GetPendingIssues - SIP Sounds like we do not need related fields or 'overdue' flag here. No idea how to confirm there is no regression here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 11:23:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 10:23:38 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:33:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:33:12 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Marjorie Barry-Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:29 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #5 from Jonathan Druart --- Created attachment 70355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70355&action=edit Bug 19935: Replace GetPendingIssues - deletemem.pl Same as previously, we just want Koha::Patron->checkouts->count to know if a patron has checkouts. Test plan: Confirm that you cannot delete a patron's card if they have pending checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:20:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:20:45 +0000 Subject: [Koha-bugs] [Bug 18923] Resolve a warn in Biblio::GetCOinSBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18923 --- Comment #14 from Fridolin SOMERS --- (In reply to Marcel de Rooy from comment #13) > Not backported? Oh I missed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:31:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:31:26 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #4 from Jonathan Druart --- Created attachment 70354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70354&action=edit Bug 19935: Replace GetPendingIssues - Discharges We should actually use Koha::Patron->checkouts here to avoid the prefetch. Test plan: A patron with checkouts cannot get a discharge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:51:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 09:51:53 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #42 from Koha Team Lyon 3 --- it works, thank you Alex ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 09:39:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 08:39:26 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69915|0 |1 is obsolete| | --- Comment #40 from Alex Arnaud --- Created attachment 70336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70336&action=edit Bug 17656 - Update irregularities on subscription renewals Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Renew subscription from 2017-10-16 - Check that you have the prediction pattern table on renwal page - Submit renewal - Check that irregularity and permanent_irregularity column have been updated. - Do the same for a monthly and weekly subscription -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:00:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:00:18 +0000 Subject: [Koha-bugs] [Bug 19940] New: Koha::Biblio - Remove GetBiblioItemInfosOf Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 Bug ID: 19940 Summary: Koha::Biblio - Remove GetBiblioItemInfosOf Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This subroutine is only used once and can be replaced easily with a Koha::Biblioitems->search call -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:00:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:00:35 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19940 --- Comment #7 from Jonathan Druart --- Bug 19940 - Koha::Biblio - Remove GetBiblioItemInfosOf Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:00:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:00:35 +0000 Subject: [Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:36:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:36:23 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:24:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:24:13 +0000 Subject: [Koha-bugs] [Bug 11251] Be able to configure HTML Opac preferences per library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11251 Johnny Rotten changed: What |Removed |Added ---------------------------------------------------------------------------- CC|georgew at latahlibrary.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:24:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:24:51 +0000 Subject: [Koha-bugs] [Bug 19324] New Inventory workflow eliminates "mark item seen" and doesn' t show data in table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 16:08:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 15:08:04 +0000 Subject: [Koha-bugs] [Bug 4115] print a batch of patron cards from an import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4115 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:36:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:36:10 +0000 Subject: [Koha-bugs] [Bug 19937] New: Silence warnings t/db_dependent/www/batch.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Bug ID: 19937 Summary: Silence warnings t/db_dependent/www/batch.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:04:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:04:16 +0000 Subject: [Koha-bugs] [Bug 19941] New: 'alt' and 'title' attributes not set when a hold is placed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Bug ID: 19941 Summary: 'alt' and 'title' attributes not set when a hold is placed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Hold requests Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com >From reserve/request.tt: - [% biblioloo.itypename %] But this itypename is never set. >From the controller: $biblioloopiter{description} = $biblioitem->{description}; $biblioloopiter{itypename} = $biblioitem->{description}; $biblioitem comes from GetBiblioItemInfosOf which does not retrieve "description" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:04:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:04:35 +0000 Subject: [Koha-bugs] [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'alt' and 'title' |'alt' and 'title' |attributes not set when a |attributes of the item type |hold is placed |image are not set when a | |hold is placed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:07:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:07:18 +0000 Subject: [Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:07:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:07:18 +0000 Subject: [Koha-bugs] [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:33:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:33:50 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19936 --- Comment #23 from Jonathan Druart --- Bug 19936 - Move Check_userid and Generate_Userid to Koha::Patron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:33:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:33:29 +0000 Subject: [Koha-bugs] [Bug 19936] New: Move Check_userid and Generate_Userid to Koha::Patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 Bug ID: 19936 Summary: Move Check_userid and Generate_Userid to Koha::Patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:31:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:31:29 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 02:13:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 01:13:40 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70333|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 70334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70334&action=edit Bug 19913: Fix embedded HTML5 videos at the OPAC Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt A space is missing between 'source' and 'src' Test plan: Set HTML5MediaEnabled to OPAC Put a video link to 856$u See the OPAC detail page, tab video, click the video => Should play with this patch applied Note that this does not affect intranet Signed-off-by: George Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:30:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:30:40 +0000 Subject: [Koha-bugs] [Bug 19931] New: Update popup window templates to use Bootstrap grid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Bug ID: 19931 Summary: Update popup window templates to use Bootstrap grid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 14546 The templates for popup windows are fairly simple -- one or two columns, so they could be easily updated to use the Bootstrap grid instead of YUI. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:21:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:21:51 +0000 Subject: [Koha-bugs] [Bug 9750] bring routing lists in to notices & slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9750 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:33:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:33:43 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 70362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70362&action=edit Bug 18915: Giving CHECKOUT_NOTE access to issues table This patch allows the notice to reference the issues table so that the checkout note itself can be added to the note if wanted, such as in Comment 9. Sponsored-by: Catalyst IT Signed-off-by: Marjorie Barry-Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:33:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:33:46 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 --- Comment #8 from sandboxes at biblibre.com --- Created attachment 70363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70363&action=edit Bug 18915: Renaming svc/patron_notes to svc/checkout_notes For consistency. Signed-off-by: Marjorie Barry-Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:30:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:30:40 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:33:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:33:35 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:08:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:08:20 +0000 Subject: [Koha-bugs] [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:33:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:33:29 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69798|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:33:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:33:50 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:31:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:31:29 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 02:13:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 01:13:37 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:42:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:42:45 +0000 Subject: [Koha-bugs] [Bug 5153] Patron Import tool does not show progress of upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5153 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:42:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:42:28 +0000 Subject: [Koha-bugs] [Bug 5153] Patron Import tool does not show progress of upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5153 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:08:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:08:23 +0000 Subject: [Koha-bugs] [Bug 19941] 'alt' and 'title' attributes of the item type image are not set when a hold is placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19941 --- Comment #1 from Jonathan Druart --- Created attachment 70380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70380&action=edit Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf This subroutine is only used once and can be replaced easily with a Koha::Biblioitems->search call Test plan: Test this on top of bug 19941 and confirm that the correct item types are displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:35:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:35:00 +0000 Subject: [Koha-bugs] [Bug 19696] HoldsQueue.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19696 --- Comment #2 from Jonathan Druart --- https://jenkins.koha-community.org/job/Koha_Master_D8/329/console # Failed test 'Holds queue filling 1st correct hold for default holds policy 'from home library'' # at t/db_dependent/HoldsQueue.t line 295. # got: 'q1ZyoBV1Rhutm9IoDlYbsJ6' # expected: 'voiWWxpt0eRUZNR2asguksbNxwjxlt' # Failed test 'Holds queue filling 2nd correct hold for default holds policy 'from home library'' # at t/db_dependent/HoldsQueue.t line 296. # got: 'voiWWxpt0eRUZNR2asguksbNxwjxlt' # expected: 'q1ZyoBV1Rhutm9IoDlYbsJ6' # Looks like you failed 2 tests of 44. [13:07:51] t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:27:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:27:05 +0000 Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get emailed as indicated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496 --- Comment #14 from Fridolin SOMERS --- Pushed to 17.05.x for 17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 13:26:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 12:26:38 +0000 Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get emailed as indicated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496 --- Comment #13 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #12) > (In reply to Fridolin SOMERS from comment #9) > > Patch does not apply to 17.05.x because it is still $member hash instead of > > $patron object. > > Rebase looks tricky, please provide rebased patches. > > Done, please test! Works perfect thanks a lot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:46:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:46:34 +0000 Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|georgew at latahlibrary.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:47:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:47:18 +0000 Subject: [Koha-bugs] [Bug 16766] Merging two records with title level holds for the same patron creates two holds on one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16766 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 09:39:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 08:39:15 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69820|0 |1 is obsolete| | --- Comment #39 from Alex Arnaud --- Created attachment 70335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70335&action=edit Bug 17656 - Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for monthly, daily or weekly serials ( 1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:40:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:40:15 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19931 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:43:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:43:38 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 --- Comment #1 from M. Tompsett --- Created attachment 70364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70364&action=edit Bug 19937: Silence warnings t/db_dependent/www/batch.t TEST PLAN --------- 1) Run the following on a kohadevbox: git checkout -b bug_19937 origin/master sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered at the end of the log file: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. 2) Run the following on a kohadevbox: exit git bz apply 19937 restart_all sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The log file will end with the restarting of plack, not the errors. 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:49:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:49:22 +0000 Subject: [Koha-bugs] [Bug 15937] Batch checkout buggy behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15937 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:42:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:42:32 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:50:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:50:18 +0000 Subject: [Koha-bugs] [Bug 15683] Inconsistent population of lastreneweddate between AddRenewal and AddIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15683 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:40:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:40:15 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19755 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:50:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:50:50 +0000 Subject: [Koha-bugs] [Bug 15528] Updating the authorised value for a report subgroup removes the previous value assigned from all report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15528 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:43:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:43:36 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:53:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:53:05 +0000 Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:43:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:43:37 +0000 Subject: [Koha-bugs] [Bug 16207] Incorporate circulation and fine rules for library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16207 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:42:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:42:32 +0000 Subject: [Koha-bugs] [Bug 19932] New: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Bug ID: 19932 Summary: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 14546, 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be z3950_search.tt, the template for Z39.50 searches from the cataloging interface. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:48:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:48:21 +0000 Subject: [Koha-bugs] [Bug 16181] Limit number of tags loaded initially for tag cloud In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16181 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:29:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:29:02 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:52:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:52:40 +0000 Subject: [Koha-bugs] [Bug 15371] Staff vs. OPAC advanced search options are different and have different sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15371 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:13:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:13:05 +0000 Subject: [Koha-bugs] [Bug 19933] New: Move C4::Members:: patronflags to the Koha namespace - part 1 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Bug ID: 19933 Summary: Move C4::Members::patronflags to the Koha namespace - part 1 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org C4::Members::patronflags does a lot of things and most of the time they are not even used by the callers. We should split this subroutine and fetch only the data we need. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:29:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:29:02 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19935 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:44:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:44:05 +0000 Subject: [Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:50:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:50:02 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search ) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:42:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:42:32 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:51:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:51:45 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:19:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:19:27 +0000 Subject: [Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 --- Comment #1 from Jonathan Druart --- Created attachment 70381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70381&action=edit Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf This subroutine is only used once and can be replaced easily with a Koha::Biblioitems->search call Test plan: Test this on top of bug 19941 and confirm that the correct item types are displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:19:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:19:24 +0000 Subject: [Koha-bugs] [Bug 19940] Koha::Biblio - Remove GetBiblioItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19940 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:05:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 09:05:53 +0000 Subject: [Koha-bugs] [Bug 19928] New: Acquisitions' CSV exports should honor syspref "delimiter " Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Bug ID: 19928 Summary: Acquisitions' CSV exports should honor syspref "delimiter" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org 1. Set syspref "delimiter" to "tabs" 2. Create a vendor with minimal info 3. Create a basket with minimal info 4. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 5. "Export as CSV" 6. You should see that the file contains commas "," This is the bug. 7. Create a basket group with minimal info 8. Close this basket group 9. Go to the "Closed" tab to see your basket group 10. "Export as CSV" 11. You should see that the file contains commas "," This is the bug. 12. Create a basket with minimal info 13. Add a item to the basket 14. Close the basket 15. Go to /cgi-bin/koha/acqui/lateorders.pl 16. "Export as CSV" 17. You should see that the file contains commas "," This is the bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:54:19 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:06:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 09:06:31 +0000 Subject: [Koha-bugs] [Bug 17031] Use delimeter system preference for Overdues report download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17031 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19928 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:54:37 +0000 Subject: [Koha-bugs] [Bug 15038] Move BatchCheckoutsValidCategories into the categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15038 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:58:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:58:18 +0000 Subject: [Koha-bugs] [Bug 13165] Active Hold Limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13165 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 14:47:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 13:47:45 +0000 Subject: [Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684 --- Comment #3 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #2) > I am not sure I understand the changes, how can we know it will not > introduce side-effects? > Tests are missing. The facets links are composed of an index and a value separated by ":", for example su:History. But real CCL syntax is index=value so ":" must be replaced by "=". But actual code replaces all ":" even in value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:56:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:56:09 +0000 Subject: [Koha-bugs] [Bug 14373] Disallow payment of accruing fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14373 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:55:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:55:05 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|georgew at latahlibrary.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:57:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:57:31 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:56:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:56:48 +0000 Subject: [Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:54:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:54:52 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:58:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:58:01 +0000 Subject: [Koha-bugs] [Bug 13239] MySQL Character encoding utf8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13239 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 11:14:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 10:14:53 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #1 from Victor Grousset/tuxayo --- Everything come from here: http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv;hb=94cd27677d8febd2979f9f618f1e8cd1bd2d68d7 3 templates with commas hardcoded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:06:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 09:06:31 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17031 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 15:57:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 14:57:43 +0000 Subject: [Koha-bugs] [Bug 13551] Add the ability to sort results on cataloguing (addbooks.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13551 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 10:06:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 09:06:09 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |victor.grousset at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 18:29:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 17:29:06 +0000 Subject: [Koha-bugs] [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 --- Comment #5 from M. Tompsett --- Comment on attachment 70348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70348 Bug 19933: Remove patronflags - In CanBookBeIssued Review of attachment 70348: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19933&attachment=70348) ----------------------------------------------------------------- Nice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:03:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:03:51 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:08:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:08:33 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org Status|Needs Signoff |Signed Off --- Comment #6 from George Williams (NEKLS) --- Signed off based on video that Jesse put together for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:09:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:09:12 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:10:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:10:40 +0000 Subject: [Koha-bugs] [Bug 15812] Checkout search with too many results (single character search ) causes poor performance or timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:10:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:10:52 +0000 Subject: [Koha-bugs] [Bug 15683] Inconsistent population of lastreneweddate between AddRenewal and AddIssue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15683 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:12:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:12:19 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library' s circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:12:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:12:44 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gwilliams at nekls.org |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:16:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:16:58 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #2 from M. Tompsett --- This may conflict with 19933 which removes C4::Members::patronflags if 19933 is pushed first. In which case, I believe removing C4/Member's from this patch should be sufficient. I'll split. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:17:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:17:11 +0000 Subject: [Koha-bugs] [Bug 19942] New: Children's search interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19942 Bug ID: 19942 Summary: Children's search interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Would like to see an alternative OPAC search for patrons geared towards children. Something like this: http://www2.hampton.lib.nh.us:8080/kids?config=default#/categories It would be easy enough to customize searches, but it would be great to be able to customize a background, and add big buttons to the search topics. You will notice that the general search bar at the top limits to children's materials, and the layout of the results is EXTREMELY kid friendly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:17:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:17:51 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #3 from M. Tompsett --- Created attachment 70382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70382&action=edit Bug 19938: Split C4/Members.pm to avoid conflict issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:17:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:17:54 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70375|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 70383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70383&action=edit Bug 19938: Refactor checkoverdues TEST PLAN --------- 0) back up plack error log if you care. 1) Run these on your kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. However, the log file will have noise. 2) Run these on your kohadevbox: git bz apply 19938 restart_all echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. This time the log file will have no noise. 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:21:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:21:17 +0000 Subject: [Koha-bugs] [Bug 15937] Batch checkout buggy behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15937 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gmcharlt at gmail.com, | |oleonard at myacpl.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:25:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:25:50 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 [Bug 19929] Add Koha Objects for class_source and class_sort_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:25:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:25:50 +0000 Subject: [Koha-bugs] [Bug 19929] Add Koha Objects for class_source and class_sort_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19929 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:37:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:37:19 +0000 Subject: [Koha-bugs] [Bug 19943] New: Koha::Biblio - Remove GetBiblioItemData Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Bug ID: 19943 Summary: Koha::Biblio - Remove GetBiblioItemData Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:37:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:37:35 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17628 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 [Bug 17628] Move bibliographic related code to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:37:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:37:35 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19943 --- Comment #8 from Jonathan Druart --- Bug 19943 - Koha::Biblio - Remove GetBiblioItemData Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 [Bug 19943] Koha::Biblio - Remove GetBiblioItemData -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:47:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:47:42 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:47:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:47:46 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 --- Comment #1 from Jonathan Druart --- Created attachment 70384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70384&action=edit Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued Just a preliminary step to clean the code a bit in CanBookBeIssued. The effective item type is already set from GetItem and we do not need to deal with that again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:47:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:47:49 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 --- Comment #2 from Jonathan Druart --- Created attachment 70385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70385&action=edit Bug 19943: Koha::GetBiblioItemData - Replace existing occurrences The biblioitem's info can be retrieved with Koha::Biblio->biblioitem Test plan: 1. Use the age restriction to restrict checkouts for a given patron 2. Check some items of a biblio out, go to "Items" tab, then "View item's checkout history" link. Compare views with and without patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:47:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:47:52 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 --- Comment #3 from Jonathan Druart --- Created attachment 70386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70386&action=edit Bug 19943: Remove C4::Biblio::GetBiblioItemData It is no longer used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:57:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:57:50 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library' s circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67177|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 70387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70387&action=edit Bug 15520: Add permission to restrict circ rules editing to own library Test plan: 1) Ensure that you have four users: a) A superlibrarian b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. 2) As all four users, load the "Circulation and fine rules" administration page (admin/smart-rules.pl). 3) The page should be unchanged for the first three users. It should be possible to view and edit the circ rules for all libraries. 4) The last (restricted) user should only be able to view and edit the circ rules for their own library. Followed test plan, patch worked as described Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 19:58:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 18:58:46 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library' s circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- I have fixed an easy conflict with commit 971591d4ee8576d6782d32610bbae7cfe4674231 Bug 19029: Add JavaScript security question for cloning circ rules - + -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:00:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:00:28 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #7 from Jonathan Druart --- (In reply to George Williams (NEKLS) from comment #6) > Signed off based on video that Jesse put together for me. Well, none of the dependencies apply cleanly, where are the patches ? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:05:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:05:07 +0000 Subject: [Koha-bugs] [Bug 18472] Add system preferences to manage online help system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19817 --- Comment #27 from Jonathan Druart --- I am waiting for answers, feedbacks and suggestions on bug 19817. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:05:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:05:07 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18472 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:15:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:15:33 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #75 from Jonathan Druart --- Comment on attachment 69815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69815 Bug 4319: [OPAC] Allow holds on waiting/transit items Review of attachment 69815: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=4319&attachment=69815) ----------------------------------------------------------------- ::: Koha/Biblio.pm @@ +319,5 @@ > } > > +=head3 hasItemswaitingOrInTransit > + > +=cut Why are you cheating the QA script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:17:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:17:42 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #76 from Jonathan Druart --- Additionally, do you think adding camelCase method's name in a module containing only snake_case is a good idea? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:19:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:19:33 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #77 from Jonathan Druart --- Also, when I see: @@ -1141,18 +1141,9 @@ sub IsAvailableForItemLevelRequest { } return $any_available ? 0 : 1; + } else { # on_shelf_holds == 0 "If any unavailable" (the description is rather cryptic and could still be improved) + return $item->{onloan} || IsItemOnHoldAndFound( $item->{itemnumber} ); } - - if ($item->{onloan}) { - return 1; - } - - if ( Koha::Holds->search({itemnumber => $item->{itemnumber}, - found => ['W', 'T']})->count ) { - return 1; - } Then: +sub hasItemswaitingOrInTransit { + my ( $self ) = @_; + + if ( Koha::Holds->search({ biblionumber => $self->id, + found => ['W', 'T'] })->count ) { + return 1; + } I am pretty sure something is wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:50:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:50:40 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #22 from Jonathan Druart --- Can we rename commit with confirm? We use commit 3x in misc instead of 8x for confirm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:56:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:56:17 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #16 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #15) > QA Comment > Interesting feature! Limited testing did not reveal problems. > > Functionality issue: > In Administration, smart-rules, the section "Default checkout limit by > patron category" contains the item "Maximum total holds allowed (count)". I've submitted a patch to improve the section name. > Not sure if the label should contain total and count btw. Removed > But the section should be renamed. This does not pertain any longer to > checkout limits only. Agreed. > Furthermore I would expect to have max_holds also under Default checkout, > hold and return policy. It seems consistent to add it also without a patron > category restriction. That behavior is controlled by the maxreserves system preference. We should move that out of a syspref and into the circ rules. I'd be happy to do that on another bug but it's definitely out of the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:56:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:56:58 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 --- Comment #23 from Jonathan Druart --- Created attachment 70388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70388&action=edit Bug 18071: Improve parameters handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:57:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:57:28 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:57:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:57:31 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67180|0 |1 is obsolete| | Attachment #67181|0 |1 is obsolete| | Attachment #67531|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 70389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70389&action=edit Bug 15524 - Set limit on maximum possible holds per patron by category It's possible to set a limit on the maximum number of holds for a particular branch/category/itemtype, but not on the total number of holds for a given patron (by branch/category). This new rule works in conjunction with the existing branch/borrower/item rules in that Koha will use the lower of the two limits. This new rule counts all holds of all types, which prevents bib-level holds from not being counted for the purpose of these limits. This makes the most sense and was also requested by the sponsor. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:57:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:57:39 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #18 from Kyle M Hall --- Created attachment 70390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70390&action=edit Bug 15524 - Update Schema Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:57:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:57:42 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #19 from Kyle M Hall --- Created attachment 70391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70391&action=edit Bug 15524: (follow-up) Rename database update This ensures that this update is applied in the correct order relative to its dependent bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 20:57:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 19:57:47 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #20 from Kyle M Hall --- Created attachment 70392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70392&action=edit Bug 15524 [QA Followup] - Change language used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:05:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:05:09 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #21 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #15) > QA Comment > Interesting feature! Limited testing did not reveal problems. > > Functionality issue: > In Administration, smart-rules, the section "Default checkout limit by > patron category" contains the item "Maximum total holds allowed (count)". I've submitted a patch to improve the section name. > Not sure if the label should contain total and count btw. Removed > But the section should be renamed. This does not pertain any longer to > checkout limits only. Agreed. > Furthermore I would expect to have max_holds also under Default checkout, > hold and return policy. It seems consistent to add it also without a patron > category restriction. That behavior is controlled by the maxreserves system preference. We should move that out of a syspref and into the circ rules. I'd be happy to do that on another bug but it's definitely out of the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:07:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:07:37 +0000 Subject: [Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:07:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:07:40 +0000 Subject: [Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939 --- Comment #1 from Owen Leonard --- Created attachment 70393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70393&action=edit Bug 19939 - Move cataloging Z39.50 results actions into menu This patch modifies the template which displays cataloging Z39.50 search results so that the "MARC," "Card," and "Import" links are moved out of separate table cells and into one menu. The old menu which would appear when any table cell is clicked has been removed, and code added to display the same Bootstrap menu if a table cell is clicked. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. - Perform a Z39.50 search which will return more than one result. - Confirm that clicking the "Actions" button triggers a drop-down menu. - Confirm that the links in the menu trigger actions for the correct bibliographic record. - Confirm that clicking any other table cell in the table of results will trigger the display of the same menu. - Confirm that this menu works correctly for the correct record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:14:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:14:17 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #12 from Jonathan Druart --- Created attachment 70394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70394&action=edit Bug 11046: Improve the readability of the regex using named capture The tests tell me I am good -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:15:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:15:38 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart --- Can we have a patch for the manual please? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:21:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:21:15 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #22 from Jonathan Druart --- Created attachment 70395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70395&action=edit Bug 16782: Use uri filter instead of html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:26:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:26:35 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #23 from Liz Rea --- You could have asked me to fix those things, I'd have been happy to. Thank you for the extra patches all the same. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:27:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:27:31 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:27:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:27:37 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:27:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:27:42 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:27:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:27:47 +0000 Subject: [Koha-bugs] [Bug 17833] _initilize_memcached() warns if errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:27:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:27:52 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:27:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:27:57 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:30:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:30:11 +0000 Subject: [Koha-bugs] [Bug 19568] Wrong html filter used in opac-opensearch.tt url In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |Architecture, internals, | |and plumbing Group|Koha security | Status|Passed QA |Pushed to Master Product|Koha security |Koha --- Comment #9 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:29:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:29:53 +0000 Subject: [Koha-bugs] [Bug 19319] Reflected XSS Vulnerability in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |Architecture, internals, | |and plumbing Product|Koha security |Koha Status|Passed QA |Pushed to Master Group|Koha security | --- Comment #27 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:30:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:30:37 +0000 Subject: [Koha-bugs] [Bug 19569] X-Frame-Options=SAMEORIGIN is not set from opac-showmarc.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Status|Passed QA |Pushed to Master Component|Koha |Architecture, internals, | |and plumbing QA Contact| |testopia at bugs.koha-communit | |y.org Group|Koha security | --- Comment #10 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:30:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:30:40 +0000 Subject: [Koha-bugs] [Bug 19570] autocomplete="off" no set for login forms at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Product|Koha security |Koha Component|Koha |Architecture, internals, | |and plumbing Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:31:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:31:11 +0000 Subject: [Koha-bugs] [Bug 19611] XSS Flaws in supplier.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Component|Koha |Architecture, internals, | |and plumbing Product|Koha security |Koha Status|Passed QA |Pushed to Master QA Contact| |testopia at bugs.koha-communit | |y.org --- Comment #9 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:31:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:31:14 +0000 Subject: [Koha-bugs] [Bug 19612] Fix XSS in /cgi-bin/koha/members/memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Status|Passed QA |Pushed to Master Component|Koha |Architecture, internals, | |and plumbing Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org --- Comment #10 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:31:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:31:16 +0000 Subject: [Koha-bugs] [Bug 19614] Fix XSS in /cgi-bin/koha/members/pay.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19614 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | QA Contact| |testopia at bugs.koha-communit | |y.org Status|Passed QA |Pushed to Master Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Component|Koha |Architecture, internals, | |and plumbing Product|Koha security |Koha --- Comment #8 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:32:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:32:58 +0000 Subject: [Koha-bugs] [Bug 19614] Fix XSS in /cgi-bin/koha/members/pay.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19614 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:33:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:33:10 +0000 Subject: [Koha-bugs] [Bug 19612] Fix XSS in /cgi-bin/koha/members/memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:33:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:33:14 +0000 Subject: [Koha-bugs] [Bug 19611] XSS Flaws in supplier.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:33:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:33:19 +0000 Subject: [Koha-bugs] [Bug 19570] autocomplete="off" no set for login forms at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:33:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:33:22 +0000 Subject: [Koha-bugs] [Bug 19569] X-Frame-Options=SAMEORIGIN is not set from opac-showmarc.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:33:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:33:35 +0000 Subject: [Koha-bugs] [Bug 19568] Wrong html filter used in opac-opensearch.tt url In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19568 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:33:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:33:42 +0000 Subject: [Koha-bugs] [Bug 19319] Reflected XSS Vulnerability in opac-MARCdetail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:35:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:35:12 +0000 Subject: [Koha-bugs] [Bug 19611] XSS Flaws in supplier.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14568 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:35:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:35:12 +0000 Subject: [Koha-bugs] [Bug 19612] Fix XSS in /cgi-bin/koha/members/memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14568 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:35:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:35:12 +0000 Subject: [Koha-bugs] [Bug 19614] Fix XSS in /cgi-bin/koha/members/pay.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19614 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14568 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:38:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:38:12 +0000 Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:48:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:48:48 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_19715=5D_Add_the_amount_of_contract?= =?utf-8?q?=27s_in_the_vendor=27_s_d=C3=A9tails_page=2E?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19715 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:58:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:58:43 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:58:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:58:45 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70382|0 |1 is obsolete| | --- Comment #5 from Lee Jamison --- Created attachment 70396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70396&action=edit Bug 19938: Split C4/Members.pm to avoid conflict issues Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 9 21:58:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jan 2018 20:58:55 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70383|0 |1 is obsolete| | --- Comment #6 from Lee Jamison --- Created attachment 70397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70397&action=edit Bug 19938: Refactor checkoverdues TEST PLAN --------- 0) back up plack error log if you care. 1) Run these on your kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. However, the log file will have noise. 2) Run these on your kohadevbox: git bz apply 19938 restart_all echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. This time the log file will have no noise. 3) run koha qa test tools Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:23:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 07:23:47 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Katrin Fischer --- Fixed the patch subjects according to guidelines (XXXX: (follow-up) state what was fixed) Should is_cancelable be removed after this change? It seems the only remaining occurrences are in tests: Koha/Hold.pm:=head3 is_cancelable Koha/Hold.pm:sub is_cancelable { t/db_dependent/Hold.t:# Test method is_cancelable t/db_dependent/Hold.t:ok( $hold->is_cancelable(), "Unfound hold is cancelable" ); t/db_dependent/Hold.t:ok( $hold->is_cancelable, "Waiting hold is cancelable" ); t/db_dependent/Hold.t:ok( !$hold->is_cancelable, "In transit hold is not cancelable" ); Sorry Marcel, forgot to check the QA contact first! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:24:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 07:24:17 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #11 from Katrin Fischer --- Created attachment 70398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70398&action=edit Bug 18856: Don't show cancel option for waiting holds in OPAC If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds Signed-off-by: Kyle M Hall Signed-off-by: Caroline Cyr La Rose Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:24:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 07:24:21 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #12 from Katrin Fischer --- Created attachment 70399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70399&action=edit Bug 18856: (follow-up) Catch missed instance of is_cancelable Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:26:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 07:26:06 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 08:26:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 07:26:09 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 09:44:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 08:44:36 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:07:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 09:07:09 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #43 from Josef Moravec --- Comment on attachment 70335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70335 Bug 17656 - Keep irregularities during subscription renewals Review of attachment 70335: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17656&attachment=70335) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc @@ +1,5 @@ > +

> + If there is a day (or more) in the week where issues are never > + published, you can check corresponding boxes below. > +

> +[% daily_choice = [ {name => 'monday', desc => 'Monday', value => 1}, {name => 'tuesday', desc => 'Tuesday', value => 2}, {name => 'wednesday', desc => 'Wednesday', value => 3}, {name => 'thursday', desc => 'Thursday', value => 4}, {name => 'friday', desc => 'Friday', value => 5}, {name => 'saturday', desc => 'Saturday', value => 6}, {name => 'sunday', desc => 'Sunday', value => 7} ] %] This way the day names are not translatable ::: koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_monthly_choice.inc @@ +1,5 @@ > +

> + If there is a month (or more) in the year where issues are never > + published, you can check corresponding boxes below. > +

> +[% monthly_choice = [ {name => 'january', desc => 'January', value => 1}, {name => 'february', desc => 'February', value => 2}, {name => 'march', desc => 'March', value => 3}, {name => 'april', desc => 'April', value => 4}, {name => 'may', desc => 'May', value => 5}, {name => 'june', desc => 'June', value => 6}, {name => 'july', desc => 'July', value => 7}, {name => 'august', desc => 'August', value => 8}, {name => 'september', desc => 'September', value => 9}, {name => 'october', desc => 'October', value => 10}, {name => 'november', desc => 'November', value => 11}, {name => 'december', desc => 'December', value =>12} ] %] Month names are not translatable ::: t/Koha/DateUtils.t @@ +26,5 @@ > + > +my $dt = DateTime->new(year => 2017, month => 1, day => 1); > + > +eval { issue_number('2017', 'day'); }; > +is($@, 'Date passed to issue_number is not a valid DateTime object'); Could you please also test if the ref() of exception has right class? @@ +40,5 @@ > +is(issue_number($dt, 'day'), 6, '2022-09-17 is the sixth day of week'); > + > +is(issue_number($dt, 'week'), 37, '2022-09-17 is the week #37 of the year'); > + > +is(issue_number($dt, 'month'), 9, '2017-09-17 is the ninth month of the year'); should be 2022-09-17 ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:12:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 09:12:05 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #58 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #56) > As this would be a change of behavior now after a long time of dom > indexing... should we make it possible to switch the one that is used in the > GUI when selecting 'keyword'? Ineed, maybe we could create a system pref that defines which index is used when no index is specified : any, anywhere or other custom index maybe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:31:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 09:31:11 +0000 Subject: [Koha-bugs] [Bug 19944] New: Make the default index configurable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19944 Bug ID: 19944 Summary: Make the default index configurable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org It would be nice if a library could configure which index is searched when no search index is specified (e.g. in simple search from the OPAC front page.) See also bug 8962, comments 54-59, for discussion on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:32:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 09:32:01 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19944 --- Comment #59 from Magnus Enger --- (In reply to Fridolin SOMERS from comment #58) > (In reply to Katrin Fischer from comment #56) > > As this would be a change of behavior now after a long time of dom > > indexing... should we make it possible to switch the one that is used in the > > GUI when selecting 'keyword'? > > Ineed, maybe we could create a system pref that defines which index is used > when no index is specified : any, anywhere or other custom index maybe. Yups, that sounds like an excellent idea. But probably something for a new bug. I have reported it here: "Bug 19944 - Make the default index configurable" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:32:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 09:32:01 +0000 Subject: [Koha-bugs] [Bug 19944] Make the default index configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19944 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8962 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:37:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 09:37:43 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #44 from Josef Moravec --- Comment on attachment 70336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70336 Bug 17656 - Update irregularities on subscription renewals Review of attachment 70336: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17656&attachment=70336) ----------------------------------------------------------------- ::: C4/Serials.pm @@ +2713,4 @@ > return @$serials; > } > > +=head2 GessEnddate typo @@ +2718,5 @@ > +my $enddate = GessEnddate($startdate_iso $frequencyid, $numberlength, $weeklength, $monthlength); > + > +=cut > + > +sub GuessEnddate { Better to add new subs just to Koha namespace... but I understand it here - we do not have all the objects needed for serials management (frequencies and number patterns are missing) and calling C4 subs from Koha namespace is not good idea... If you are not willing to add needed objects, we could just fill a bug for now... ::: Koha/Subscription.pm @@ +77,5 @@ > +Return the length type (issues, weeks, months) > + > +=cut > + > +sub subtype { Maybe lengthtype would be better name? Not blocker ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt @@ +52,5 @@ > + > + > + > + > + Why do you include all the data when renewing subscription? It should be not needed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:40:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 09:40:55 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Josef Moravec --- One more thing - you missed to add the new db column to kohastructure.sql. Also, the atomic update must be idempotent - you should always use IGNORE or helper subs like column_exists and so on - see https://wiki.koha-community.org/wiki/Database_updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 10:59:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 09:59:57 +0000 Subject: [Koha-bugs] [Bug 19945] New: ILSDI - Return the reason a reserve is impossible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Bug ID: 19945 Summary: ILSDI - Return the reason a reserve is impossible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org Currently, the ILDSI services HoldTitle and HoldItem always return a "NotHoldable" code is the reserve is impossible. We need to know why. Patch is coming... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:01:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 10:01:13 +0000 Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:01:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 10:01:18 +0000 Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:29:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 10:29:32 +0000 Subject: [Koha-bugs] [Bug 17876] Show more invoice information in subscription details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17876 Maura Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maura.stephens at gmit.ie --- Comment #1 from Maura Stephens --- I would fully support this enhancement. We also have the issue here of paying for print and online versions on the same subscription, so we would have at least 2 invoices per title every year. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 11:31:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 10:31:18 +0000 Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Fridolin SOMERS --- I set back to NSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:09:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 11:09:40 +0000 Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Josef Moravec --- Please, squash the patches and ask for new sign-off, it's completely different code now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:14:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 11:14:28 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:54:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 11:54:17 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- (In reply to M. Tompsett from comment #0) > While retesting a bug, I ran a prove -r -v t, which generated a lot of log > noise. One such entry was: > [Tue Jan 9 03:54:58 2018] starman: Use of uninitialized value > $overdues_count in numeric gt (>) at > /home/vagrant/kohaclone/opac/opac-main.pl line 76. Prove generated a log entry from opac-main.pl? How? https://jenkins.koha-community.org/job/Koha_Master_D8/lastCompletedBuild/console -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 12:55:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 11:55:16 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #8 from Jonathan Druart --- "Bug 19938: Split C4/Members.pm to avoid conflict issues" => What does it mean? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:13:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 12:13:05 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #78 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #77) > Also, when I see: > @@ -1141,18 +1141,9 @@ sub IsAvailableForItemLevelRequest { > > } > > return $any_available ? 0 : 1; > > + } else { # on_shelf_holds == 0 "If any unavailable" (the description is > rather cryptic and could still be improved) > + return $item->{onloan} || IsItemOnHoldAndFound( $item->{itemnumber} > ); > > } > - > - if ($item->{onloan}) { > > - return 1; > > - } > > - > - if ( Koha::Holds->search({itemnumber => $item->{itemnumber}, > > - found => ['W', 'T']})->count ) { > > - return 1; > > - } > > Then: > +sub hasItemswaitingOrInTransit { > + my ( $self ) = @_; > + > + if ( Koha::Holds->search({ biblionumber => $self->id, > + found => ['W', 'T'] })->count ) { > + return 1; > + } > > I am pretty sure something is wrong. It might be helpful to explain what you think is wrong. You are comparing pieces of code here that have different goals. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:15:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 12:15:36 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #15 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #13) > Can we have a patch for the manual please? :) Does the Manual keyword trigger someone of the Documentation team to do so? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:27:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 12:27:43 +0000 Subject: [Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec at gmail.com CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:27:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 12:27:58 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:28:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 12:28:06 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #60 from Katrin Fischer --- I think for this bug an option to switch between Any and Anywhere would be good. Then for existing installations keep the current behaviour and for new installations (default setting) use the 'smaller' index. The custom one is definitely for a new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:33:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 12:33:55 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 --- Comment #24 from Marcel de Rooy --- Created attachment 70400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70400&action=edit Bug 18071: (QA follow-up) Rename commit to confirm parameter Trivial edit. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:34:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 12:34:35 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 --- Comment #25 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #22) > Can we rename commit with confirm? We use commit 3x in misc instead of 8x > for confirm. Yes we can. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 13:36:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 12:36:51 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #3 from Katrin Fischer --- We have since used these patches successfully in production for several months, at first as a backport to 3.22, now in 16.11. No issues so far. The CAS logout will only happen if the CAS server is set up to sent a logout request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:20:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:20:48 +0000 Subject: [Koha-bugs] [Bug 18964] koha-plack should have a --debugger switch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:20:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:20:52 +0000 Subject: [Koha-bugs] [Bug 18964] koha-plack should have a --debugger switch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65318|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 70401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70401&action=edit Bug 18964: Add --debugger option to koha-plack CAVEAT: This patch is only about allowing koha-plack to start a debugging session on a remote target. Configuring all the needed pieces to make it work is out of the scope of the bug. Testing should be focused (mainly) on making sure this introduces NO REGRESSIONS on regular use (i.e. not debugging). This patch adds the following option switches to koha-plack: --debugger ---------- Toggle debugging --debugger-key -------------- Some IDEs require a key, this needs to match because they are picky about it --debugger-location ------------------- This option switch is used to specify the host:port your IDE is listening at. Inside kohadevbox (using Vdebug with Vim) this would be localhost:9000. Outside kohadevbox it would be 192.168.50.1:9000 --debugger-path --------------- This is the path in which you installed the Komodo Remote Debugger library [1]. In kohadevbox you could put the contents of the downloaded .tar.gz in /home/vagrant/dbgp/perllib. That perllib seems to be required for things to work [2]. You can test with a simple CLI script things work: PERL5LIB=/home/vagrant/dbgp/perllib:$PERL5LIB \ PERLDB="BEGIN { require q(/home/vagrant/dbgp/perllib/perl5db.pl) }" \ PERLDB_OPTS="RemotePort=192.168.50.1:9000" perl -d t/Prices.t If you see action on your IDE, you are on the right track on the IDE side. To test: - Apply this patch - Enable remote debugging on your IDE, on port 9000 (or adjust the command below to match your IDE's listening port). - Download the Komodo Remote Debugger package, and place the package's contents in /home/vagrant/dbgp/perllib (you should see perl5db.pl in there). - Run: $ sudo koha-plack --stop kohadev $ sudo kohaclone/debian/koha-plack --start \ --debugger \ --debugger-path /home/vagrant/dbgp/perllib \ --debugger-location 192.168.50.1:9000 \ kohadev => SUCCESS: You IDE/tool gets a connection from the Plack process. - Sign off :-D The explanation on how to use it assumes you are running kohadevbox. WARNING: The main difficulty I found was setting the right dir/file mappings. [1] http://code.activestate.com/komodo/remotedebugging/ [2] https://github.com/Komodo/KomodoEdit/issues/644#issuecomment-236268012 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:23:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:23:39 +0000 Subject: [Koha-bugs] [Bug 18964] koha-plack should have a --debugger switch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Note: You will need the python3 version of vdebug if you are running python3: https://github.com/markkimsal/vdebug/tree/python3 (which does not work really well) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:24:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:24:13 +0000 Subject: [Koha-bugs] [Bug 18964] Add a --debugger flag to koha-plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-plack should have a |Add a --debugger flag to |--debugger switch |koha-plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:24:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:24:26 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 --- Comment #5 from Hugo Agud --- Good morning I have insall the patch into kohadev, I have checked out and checked in several items with different configuration and it works.. I have created a rule of 1 suspension day for every 2 delay Case 1 Cumulative on Calendar without holidays--> works as espected Calendar with holiday --> work as expected Cumulative off Calendar without holidays --> works as expected Calendar with holidays --> works as expected I missed something to check, if not I will sign it asap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:30:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:30:08 +0000 Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- This is too specific, we should provide a generic way to do that. The prefix code should be a parameter of the script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:31:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:31:42 +0000 Subject: [Koha-bugs] [Bug 16820] Add possibility to edit fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.bourgault at inlibro.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:32:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:32:06 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |J.P.Knight at lboro.ac.uk |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Price diplay on a |Price display on a |basketgroup |basketgroup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:32:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:32:34 +0000 Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup screen and add classes to borrower info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:34:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:34:07 +0000 Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup screen and add classes to borrower info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 --- Comment #3 from Jonathan Druart --- Why did not you choose to use patron-title.inc? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:35:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:35:29 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart --- The price formatting must be done template side, search for '$Price' or '[% USE Price %]' in **/*.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:37:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:37:05 +0000 Subject: [Koha-bugs] [Bug 16820] Add possibility to edit fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Kyle M Hall --- Needed to pass qa: 1) Implement use of Account Offsets. Any change to a fee or payment needs to add to the account offsets table from now on. The point of it is to create a full accounting of all changes to accountlines 2) Add a user permission for this functionality 3) Implement using Koha::Account::Line(s)/Offset(s) instead of using direct SQL queries. These new subs should live in Koha::Account::Line since they are operating on individual accountlines. We need to reduce the number of subs in the C4 namespace instead of adding to them ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:37:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:37:45 +0000 Subject: [Koha-bugs] [Bug 16820] Add possibility to edit fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #6 from Jonathan Druart --- So... once and for all: new subroutines cannot be added to the C4 namespace and you have to provide test coverage. We are moving the code from C4 to Koha, so I will not accept more subroutines to C4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:40:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:40:47 +0000 Subject: [Koha-bugs] [Bug 16820] Add possibility to edit fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #7 from Kyle M Hall --- 4) Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:49:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:49:26 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 14:54:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 13:54:33 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #9 from M. Tompsett --- (In reply to Jonathan Druart from comment #8) > "Bug 19938: Split C4/Members.pm to avoid conflict issues" > > => What does it mean? because 19933 might trigger a conflict in C4/Members with the removal of patronflags, so put the possible conflict area elsewhere. I split it from a single commit, so as to avoid the conflict as needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 15:02:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 14:02:11 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Marjorie Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 15:02:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 14:02:27 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69798|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 15:02:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 14:02:32 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 15:02:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 14:02:41 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 --- Comment #11 from sandboxes at biblibre.com --- Created attachment 70402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70402&action=edit Bug 19801 - Display messages on user details page as well as on Check Out page To test: Look up a borrower, add a message (internal or opac) Click the Details tab for that borrower Messages should be displayed above the user information [is this the right place? it could go below] adding messages on this page should make them immediately available deleting messages on this page should delete them immediately and bring you back to the detail page. Basically, make sure messages work from both the Check out and detail pages and that there are no typos. Messages should work the same as they always have from the Check Out page. sponsored-by: Catalyst IT Signed-off-by: Simon Pouchol Signed-off-by: Marjorie Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 15:02:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 14:02:44 +0000 Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 --- Comment #12 from sandboxes at biblibre.com --- Created attachment 70403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70403&action=edit Bug 19801 - Fixes for QA - Fixes indentation - changes messages to patron_messages (even though it's not like that on the circulation page.) Signed-off-by: Marjorie Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 16:07:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 15:07:48 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69783|0 |1 is obsolete| | --- Comment #6 from Hugo Agud --- Created attachment 70404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70404&action=edit Bug 19804: Add new DB column issuingrules.suspension_chargeperiod Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 16:07:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 15:07:54 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69785|0 |1 is obsolete| | --- Comment #8 from Hugo Agud --- Created attachment 70406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70406&action=edit Bug 19804: Add a 'Fine charging interval' for suspension days We already have a chargeperiod (Fine charging interval) value which is taken into account for fine ($) for not for the suspension period. This patch adds a new column suspension_chargeperiod (Fine day charging interval) to add the same behaviour when a suspension is calculated. Test plan: Add overdue item and play with the circulation rules (and the calendar). The suspension period must be correctly calculated. Please provide the different tests you made. Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 16:07:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 15:07:51 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69784|0 |1 is obsolete| | --- Comment #7 from Hugo Agud --- Created attachment 70405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70405&action=edit Bug 19804: DBIC Schema changes Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 16:07:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 15:07:57 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69786|0 |1 is obsolete| | --- Comment #9 from Hugo Agud --- Created attachment 70407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70407&action=edit Bug 19804: Add the new column to the circ rules interface Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 16:08:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 15:08:20 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 16:30:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 15:30:41 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 16:30:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 15:30:44 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66306|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 70408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70408&action=edit Bug 19160 CAS Single logout CAS supports single logout, where if you logout of one application it logs you out of all of them. This bug implements this You will need a CAS server (with single logout configure), and at least 2 applications (one being Koha) 1/ In Koha login via CAS 2/ Login to the other application via CAS 3/ Logout of the other application 4/ Notice you are still logged into Koha 5/ Log out of Koha 6/ Apply patch 7/ Login to Koha via CAS, login to other app via CAS 8/ Log out of other app 9/ Notice you are logged out of Koha If you dont have CAS, this patch should be a no op, you could test that 1/ Login and logout normally 2/ Apply patch 3/ Login and logout still work fine Signed-off-by: Katrin Fischer Patch works as described, local login still works correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 16:38:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 15:38:56 +0000 Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 --- Comment #1 from Alex Arnaud --- Created attachment 70409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70409&action=edit Bug 19945 - ILSDI - Return the reason a reserve is impossible Currently, the ILDSI services HoldTitle and HoldItem always return a "NotHoldable" code is the reserve is impossible. We need to know why Test plan: - Apply this patch - Place a hold on a non reservable title using ILS-DI web service (http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=) - you should get the reason instead of NotHoldable, - Place a hold on a non reservable item using ILS-DI web service (http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1) - you should get the reason instead of NotHoldable, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 16:40:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 15:40:20 +0000 Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 16:40:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 15:40:54 +0000 Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 17:09:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 16:09:14 +0000 Subject: [Koha-bugs] [Bug 19946] New: Update popup window templates to use Bootstrap grid: Authority Z39.50 search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 Bug ID: 19946 Summary: Update popup window templates to use Bootstrap grid: Authority Z39.50 search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be z3950_auth_search.tt, the template for Z39.50 searches from the authorities interface. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 17:09:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 16:09:14 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 17:30:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 16:30:23 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 17:30:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 16:30:25 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70364|0 |1 is obsolete| | --- Comment #2 from Lee Jamison --- Created attachment 70410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70410&action=edit Bug 19937: Silence warnings t/db_dependent/www/batch.t TEST PLAN --------- 1) Run the following on a kohadevbox: git checkout -b bug_19937 origin/master sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered at the end of the log file: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. 2) Run the following on a kohadevbox: exit git bz apply 19937 restart_all sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The log file will end with the restarting of plack, not the errors. 3) run koha qa test tools Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 17:30:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 16:30:59 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 17:31:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 16:31:01 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 --- Comment #1 from Owen Leonard --- Created attachment 70411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70411&action=edit Bug 19946: Update popup window templates to use Bootstrap grid: Authority Z39.50 search This patch updates the authority Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Some capitalization corrections, better handling. This patch does not fix Bug 17119. To test, apply the patch and go to Authorities -> New from Z39.50. In the popup window, both the search form and search results pages should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 17:53:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 16:53:30 +0000 Subject: [Koha-bugs] [Bug 19942] Children's search interface In-Reply-To: <bug-19942-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19942-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19942-70-e8r5bqqNzN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19942 Lisette <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 17:54:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 16:54:08 +0000 Subject: [Koha-bugs] [Bug 19917] Holds for self registered patrons In-Reply-To: <bug-19917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19917-70-7snWaaffH1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19917 Lisette <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:01:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:01:49 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-Nh8XBCTnjM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Lisette <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:15:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:15:56 +0000 Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13715-70-zMsACLN7Dj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |cbrannon at cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:17:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:17:17 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-WrGF5XdJ0G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:17:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:17:17 +0000 Subject: [Koha-bugs] [Bug 19947] New: Update popup window templates to use Bootstrap grid: Acquisitions transfer order Message-ID: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 Bug ID: 19947 Summary: Update popup window templates to use Bootstrap grid: Acquisitions transfer order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 19755 Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be transferorder.tt, the template for transferring an order from one vendor to another in acquisitions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:17:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:17:17 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19931-70-WhrI5EwIeT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:18:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:18:13 +0000 Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13715-70-O09AwRZvrl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:18:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:18:24 +0000 Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13715-70-D3kgulUbK4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 Lisette <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:25:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:25:23 +0000 Subject: [Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order In-Reply-To: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19947-70-n62gRa00t2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:25:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:25:25 +0000 Subject: [Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order In-Reply-To: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19947-70-IfNg90qQuw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70412&action=edit Bug 19947: Update popup window templates to use Bootstrap grid: Acquisitions transfer order This patch updates the acquisitions transfer order template to use the Bootstrap grid instead of the YUI grid. Also fixed: Corrected footer include for popup window. To test, apply the patch and go to Acquisitions -> Vendor -> Open order -> Transfer. In the popup window search for a vendor, select, and choose a basket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:30:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:30:20 +0000 Subject: [Koha-bugs] [Bug 19948] New: Rest API documentation is out of date in Koha manual Message-ID: <bug-19948-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19948 Bug ID: 19948 Summary: Rest API documentation is out of date in Koha manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The 'REST services' documentation does not fit the current implementation of the koha rest API. For instance, the documentation shows a 'user' endpoint: GET user/byid/:borrowernumber/holds GET user/:user_name/holds GET user/byid/:borrowernumber/issues GET user/:user_name/issues GET user/:user_name/issues_history GET user/byid/:borrowernumber/issues_history GET user/today GET user/all POST user But the endpoint implemented in api/v1 is "patrons", e.g. https://intranet.bywatersolutions.com/api/v1/patrons/221 The best current documentation that I'm aware of is https://wiki.koha-community.org/wiki/REST_api_RFCs It would be nice to build this documentation via api/v1/spec see also bug 17694 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:34:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:34:05 +0000 Subject: [Koha-bugs] [Bug 19948] Rest API documentation is out of date in Koha manual In-Reply-To: <bug-19948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19948-70-TEB9MmSAau@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19948 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:42:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:42:24 +0000 Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13715-70-TPcvWLBkMp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 Christopher Davis <cgdavis at uintah.utah.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgdavis at uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:55:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:55:07 +0000 Subject: [Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2 In-Reply-To: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19786-70-z4KHUMUhwC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949 [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:55:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:55:07 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19931-70-ZhQXBxqrsY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949 [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 18:55:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 17:55:07 +0000 Subject: [Koha-bugs] [Bug 19949] New: Update popup window templates to use Bootstrap grid: Cataloging authority search Message-ID: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949 Bug ID: 19949 Summary: Update popup window templates to use Bootstrap grid: Cataloging authority search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 19786 Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be auth_finder.tt and searchresult-auth.tt, the templates for cataloging authority searches. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786 [Bug 19786] Move template JavaScript to the footer: Authorities, part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 19:17:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 18:17:14 +0000 Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13715-70-CuH8z6XtsK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 19:23:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 18:23:25 +0000 Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13715-70-XBzKZnSJc6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 --- Comment #6 from rkuiper at roundrocktexas.gov --- The bug is problematic for our staff and patrons. Need to limit to items that are actually available for loan excluding checked out, damaged, or not for loan. There is a related bug 9810 that has some work being done on it. It is currently in 'FailedQA' status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 19:34:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 18:34:53 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19166-70-4fJowA71Cr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67599|0 |1 is obsolete| | Attachment #67600|0 |1 is obsolete| | Attachment #67602|0 |1 is obsolete| | Attachment #67890|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70413&action=edit Bug 19166 - Database changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 19:34:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 18:34:57 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19166-70-JLUqXQ4pvi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #20 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70414&action=edit Bug 19166 - Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Conflicts: C4/Budgets.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 19:35:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 18:35:05 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19166-70-KKUFGlHsC9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #22 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70416&action=edit Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 19:35:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 18:35:01 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19166-70-I0s51lHBJV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #21 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70415&action=edit Bug 19166: DO NOT PUSH - Schema updates Included to ease testing :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 19:49:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 18:49:13 +0000 Subject: [Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search In-Reply-To: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19949-70-vhKvxnglqL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 19:49:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 18:49:16 +0000 Subject: [Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search In-Reply-To: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19949-70-DztAdsI3Ns@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70417&action=edit Bug 19949: Update popup window templates to use Bootstrap grid: Cataloging authority search This patch updates the cataloging authority search templates to use the Bootstrap grid instead of the YUI grid. To test you must have a MARC subfield configured with "Thesaurus" linked to an authority type. Apply the patch and go to Cataloging -> New record. Click the plugin link for the field which is linked to authorities. In the popup window, the search form and search results should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:17:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:17:11 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19931-70-w6SZfaigSI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950 [Bug 19950] Update popup window templates to use Bootstrap grid: Serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:17:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:17:11 +0000 Subject: [Koha-bugs] [Bug 19950] New: Update popup window templates to use Bootstrap grid: Serials Message-ID: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950 Bug ID: 19950 Summary: Update popup window templates to use Bootstrap grid: Serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be routing-preview-slip.tt (Routing slip preview) and subscription-renew.tt (Subscription renew). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:31:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:31:14 +0000 Subject: [Koha-bugs] [Bug 19950] Update popup window templates to use Bootstrap grid: Serials In-Reply-To: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19950-70-XdeXwDCCra@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:31:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:31:17 +0000 Subject: [Koha-bugs] [Bug 19950] Update popup window templates to use Bootstrap grid: Serials In-Reply-To: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19950-70-8nbD9SGYMd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70418&action=edit Bug 19950: Update popup window templates to use Bootstrap grid: Serials This patch updates the two serials templates to use the Bootstrap grid instead of the YUI grid. Apply the patch and go to Serials and locate an existing subscription. - Click the "Edit routing list" in the sidebar. - Save the routing list, and click "Save and preview routing slip." - The routing slip preview should look correct and buttons should work correctly. - When viewing the details of a subscription, click the "Renew" button in the toolbar. The popup window should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:34:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:34:40 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-kSomc7pGiU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am not going to test this patch, but I would like to make sure the changes make sense. 1. I do not understand the code in opac-user.pl, why is it here? It sounds like it will be better at its place in C4::Auth. 2. You should move out get_session the code you copy/pasted from there 3. I guess it is just my undestanding of CAS that is bad but why do we call get_session then delete it? Is cas_ticket == sessionID? Side note: it will not work if SessionStorage=memcached (but we should remove that), CGI::Session::Driver::memcached->traverse does nothing. Another one: from the pod of CGI::Session->find : "Experimental feature. Note: find() is meant to be convenient, not necessarily efficient. It's best suited in cron scripts." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:43:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:43:55 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-VtKla2lW5F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to Jonathan Druart from comment #5) > > Another one: from the pod of CGI::Session->find : > "Experimental feature. > Note: find() is meant to be convenient, not necessarily efficient. It's best > suited in cron scripts." Yes, but it is still a lot faster than opening every session and checking them all by hand. It's only called when a user logs out of another application other than Koha, and only by the CAS server, never by the user. So it is essentially a background process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:50:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:50:55 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-BgRZbAbW6L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70398|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70419&action=edit [ALTERNATIVE-PATCH] Bug 18856: Don't show cancel option for waiting holds in OPAC This is the alternative patch of Kyle's """ If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds """ It sounds better to keep the ->is_cancelable method, for readability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:53:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:53:06 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-2oVik5neW1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Kyle, Katrin and Marcel, could you take a look at this l ast patch? It sounds better to me to keep the method and fix its behaviour instead of testing is_found that can be confusing. Feel free to obsolete it if you disagree and I will pushed Kyle's patches with a follow-up to remove the method and the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:55:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:55:01 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: <bug-18071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18071-70-796czoDzaU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:56:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:56:25 +0000 Subject: [Koha-bugs] [Bug 19471] Show creation date in patron restrictions list In-Reply-To: <bug-19471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19471-70-SXoMyD1pXF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19471 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Passed QA --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:56:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:56:51 +0000 Subject: [Koha-bugs] [Bug 19471] Show creation date in patron restrictions list In-Reply-To: <bug-19471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19471-70-h48i2rkqph@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19471 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 20:58:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 19:58:52 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-HHn7QNi5fx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #5) > 3. I guess it is just my undestanding of CAS that is bad but why do we call > get_session then delete it? > Is cas_ticket == sessionID? And of course it's not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 21:14:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 20:14:38 +0000 Subject: [Koha-bugs] [Bug 19644] When editing items Tag editor [ellipses (...)] by date accessioned is non functional In-Reply-To: <bug-19644-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19644-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19644-70-cbaCaoxUrX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19644 J Schmidt <jschmidt at switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpalmer at switchinc.org, | |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 21:29:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 20:29:03 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-tE0n7TkxxG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #15 from Barton Chittenden <barton at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #14) > Kyle, Katrin and Marcel, could you take a look at this l > ast patch? > It sounds better to me to keep the method and fix its behaviour instead of > testing is_found that can be confusing. Feel free to obsolete it if you > disagree and I will pushed Kyle's patches with a follow-up to remove the > method and the tests. The problem with 'is_cancelable' is that staff and opac have different views of whether the item is cancelable or not, whereas is_found is un-ambiguous. is_cancelable *sounds* like it's clearer because it signals its intent, but under the circumstances, I think 'is_found' is better. Just my humble opinion; I'm also probably missing context because I haven't taken the time to read the code, so take my words with a large grain of salt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 21:53:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 20:53:40 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: <bug-10821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10821-70-I0Rbimfwb8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 21:53:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 20:53:57 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-eeB2unYFln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70398|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 21:55:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 20:55:05 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-RBLoD4tUtk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Yes Barton you are right, that's why I added a comment to the POD of the method to tell it only applies for the OPAC. Maybe rename the method to something more verbose (is_cancelable_from_opac) to remove the ambiguity? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 22:05:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 21:05:36 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-WHgDNExwG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- is_found is also a bit confusing, because this also includes transit items. found = F in the reserves table is for waiting. So you might not think about the transit items as well immediately. It confused me on testing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 22:43:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 21:43:01 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-YfXNIHo38T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #8 is|1 |0 private| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 23:03:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 22:03:57 +0000 Subject: [Koha-bugs] [Bug 19948] Rest API documentation is out of date in Koha manual In-Reply-To: <bug-19948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19948-70-Ne0ZTebTJG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19948 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- https://koha-community.org/manual/17.11/en/html/17_miscellaneous.html?highlight=rest#rest-services is not about our current implementation but about a patch/scripts Biblibre provided in the past to implement a REST API for Koha. I suggest removing that paragraph as Koha's REST API is still being developed and it will be hard to keep up with changes. Fast changing technical documentation seems better suited for the wiki atm. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 23:20:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 22:20:15 +0000 Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13715-70-T9liBeYmA0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 --- Comment #7 from Christopher Brannon <cbrannon at cdalibrary.org> --- This is in desperate need of attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 23:41:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 22:41:52 +0000 Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers In-Reply-To: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19017-70-8TfJlIhCpl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |dependency --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Should we set this to In discussion or failed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 10 23:57:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jan 2018 22:57:58 +0000 Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records with multiple items where 1 is not available (checked out) but others are In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13715-70-L2TvO1ui4F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 Candice Hope <candiceh at payson.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |candiceh at payson.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 01:56:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 00:56:49 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: <bug-11677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11677-70-suH8gps9ZF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Ed Veal <eveal at mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 08:40:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 07:40:56 +0000 Subject: [Koha-bugs] [Bug 19951] New: ; Literary form: not translated on search results with de-DE installed Message-ID: <bug-19951-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951 Bug ID: 19951 Summary: ; Literary form: not translated on search results with de-DE installed Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: elias.dehler at thulb.uni-jena.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Created attachment 70420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70420&action=edit Shows the bug "; Literary form:" isn't translated on the search results when the german is selected. steps to reproduce: 1. install the german translation de-DE 2. switch to german on the opac 3. make a search for something (as long as it has a literary form) 4. on the results everything is translated except ; Literary form: -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 10:16:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 09:16:04 +0000 Subject: [Koha-bugs] [Bug 19951] ; Literary form: not translated on search results with de-DE installed In-Reply-To: <bug-19951-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19951-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19951-70-bwjReKGxta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It works in our 16.11.13, will try to check on master too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 11:24:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 10:24:19 +0000 Subject: [Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items In-Reply-To: <bug-9810-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9810-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9810-70-dJjYvwVNVg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 12:33:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 11:33:37 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-hDQNRwX6c6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70421&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 12:37:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 11:37:03 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-Vz6qkTKVSS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70421|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70422&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 12:37:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 11:37:50 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-xjLi1cIn4m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Thanks Joubu for this explanation: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=8403799c7212349bee70090249e3425afd62423b About the part "in order to make it a have-to-read for next changes." How would the next person find this? As it won't be the last commit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 12:38:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 11:38:58 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-OzYyv5M42q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 13:56:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 12:56:52 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-oMIdklVdsL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #4) > Thanks Joubu for this explanation: > http://git.koha-community.org/gitweb/?p=koha.git;a=commit; > h=8403799c7212349bee70090249e3425afd62423b > About the part "in order to make it a have-to-read for next changes." > How would the next person find this? As it won't be the last commit. (It could be a have-to-read if I fix all the grammar errors!) At least you, Katrin and me are aware of this commit and the problem. So we can guide people to this commit message when they need it :) Feel free to create a wiki page if you think it is a good idea (and you have time). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 13:58:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 12:58:41 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-fztLLRikZz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- About your patches, it should not be needed but it is the behaviour of other occurrences: you do not default to ';', ',' or '\t' if the pref 'delimiter' does not exist. Maybe ',' is better here as it was the value before your changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 14:32:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 13:32:45 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-AhZ5NLBt17@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- (In reply to Jonathan Druart from comment #6) > [...] you do not default to ';', ',' or '\t' if the pref 'delimiter' > does not exist. > > Maybe ',' is better here as it was the value before your changes. You're right, I though that the pref 'delimiter' always existed. Is giving 'delimiter' a default value in the DB[1] also an option? [1] INSERT in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 14:32:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 13:32:54 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-OkYXPdkp2R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 14:54:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 13:54:15 +0000 Subject: [Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins , part 7 In-Reply-To: <bug-19878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19878-70-yTsMaoXCcJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 14:54:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 13:54:15 +0000 Subject: [Koha-bugs] [Bug 19952] New: Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins Message-ID: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 Bug ID: 19952 Summary: Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 19878 Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be two UNIMARC cataloging plugins: unimarc_field_210c_bis.tt and unimarc_field_686a.tt. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins, part 7 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 14:54:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 13:54:15 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19931-70-TmLoR63gWA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 15:00:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 14:00:17 +0000 Subject: [Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins In-Reply-To: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19952-70-ogAhYBm3dO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70423&action=edit Bug 19952: Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins This patch updates two UNIMARC cataloging plugin templates to use the Bootstrap grid instead of the YUI grid. - unimarc_field_210c_bis.tt - unimarc_field_686a.tt To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that the page in the popup window looks correct. Confirm that changes made in the popup window are saved to the corresponding field in the editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 15:00:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 14:00:15 +0000 Subject: [Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins In-Reply-To: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19952-70-RX3DeOcRgC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 15:07:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 14:07:07 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-ZnpUOyEZ2H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Axelle Aix-Marseille Universit? <axelle.clarisse at univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 15:44:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 14:44:42 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-fmWfFge0u5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 15:44:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 14:44:45 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-KrXDU5EaXX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70398|0 |1 is obsolete| | Attachment #70399|0 |1 is obsolete| | Attachment #70419|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70424&action=edit Bug 18856: Don't show cancel option for waiting holds in OPAC This is the alternative patch of Kyle's """ If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds """ It sounds better to keep the ->is_cancelable method, for readability Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 15:44:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 14:44:53 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-ldvWt7yNOV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70425&action=edit Bug 18856 [QA Followup] - Rename method to avoid confusion Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 16:24:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 15:24:53 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-703rrFfLlL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70422|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70426&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 16:26:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 15:26:26 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-rofSXREmRJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #9 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- "," is now used by default if the syspref is missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 17:21:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 16:21:12 +0000 Subject: [Koha-bugs] [Bug 19953] New: Record page: acquisition details: add column for invoice Message-ID: <bug-19953-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Bug ID: 19953 Summary: Record page: acquisition details: add column for invoice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 70427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70427&action=edit Screenshot proposed change See the attachment for how it would look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 17:23:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 16:23:15 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: <bug-19953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19953-70-Qu120XxumB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70427|Screenshot proposed change |Screenshot of proposed description| |change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 17:30:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 16:30:05 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-QoVKHG8YJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69415|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70428&action=edit Bug 19641: Move patron templates to the footer This patch modifies the staff client patron module templates so that JavaScript is included in the footer instead of the header. This patch touches a lot of files because the changes are all interdependent, affecting a couple of module-wide include files. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Patrons -> Patrons home, patron search results -> Manage pending modification requests -> Patron detail page -> Edit patron -> Set guarantor -> Fines -> Account, Pay fines, Create manual invoice, Create manual credit -> Print receipts for different kinds of charges -> Routing lists -> Circulation history -> Holds history -> Notices -> Statistics -> Files -> Purchase suggestions -> Discharges -> Housebound -> Set permissions -> Change password -> Print summary, slips, and overdues -> Update child to adult patron type Patron toolbar and patron search bar operations should work correctly on all pages. This patch also updates the template for searching the Norwegian national patron database, but it has NOT been tested. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 17:30:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 16:30:08 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-3RrJLQz67n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70429&action=edit Bug 19641 (Follow-up) Update circulation.tt too This patch makes the same JS-to-footer changes to circulation.tt. Inclusion of this template in this bug is necessary because it includes members-toolbar.inc. To test, apply the patch and clear your browser cache if necessary. - Enter a patron card for checkout - Test any JavaScript-driven actions on the checkout page, for instance: - Select all/clear all controls - Datepicker/timepickers - Datatable sorting, columns configuration - Renewals, check-ins - Patron message interactions, print slip, and other toolbar actions - Checkout exports - Search to hold - Tab loading: Restrictions, Holds, Clubs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 17:31:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 16:31:52 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-1rFN87QYtp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 17:32:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 16:32:16 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-ABE4hT75Im@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #46 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to Josef Moravec from comment #44) > Comment on attachment 70336 [details] [review] > Bug 17656 - Update irregularities on subscription renewals > > Review of attachment 70336 [details] [review]: > ----------------------------------------------------------------- > > > Better to add new subs just to Koha namespace... but I understand it here - > we do not have all the objects needed for serials management (frequencies > and number patterns are missing) and calling C4 subs from Koha namespace is > not good idea... If you are not willing to add needed objects, we could just > fill a bug for now... Don't understand. You mean create Koha::Subscription->GuessEnddate? > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt > @@ +52,5 @@ > > + <input type="hidden" id="numbering3" value="[% numbering3 %]" /> > > + <input type="hidden" id="whenmorethan1" value="[% whenmorethan1 %]" /> > > + <input type="hidden" id="whenmorethan2" value="[% whenmorethan2 %]" /> > > + <input type="hidden" id="whenmorethan3" value="[% whenmorethan3 %]" /> > > + <input type="hidden" id="locale" value="[% locale %]" /> > > Why do you include all the data when renewing subscription? It should be not > needed! Yes. testPredictionPattern js function needs all the data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 17:33:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 16:33:20 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-aTRObo6n6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #47 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 70430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70430&action=edit Bug 17656 - Fix QA comments - Make day and month names translatable, - Update unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 17:34:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 16:34:39 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: <bug-19953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19953-70-EwMVzIyxck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70431&action=edit Bug 19953: Record page: acquisition details: add column for invoice Test plan: 1. create a vendor with minimal info 2. create a basket with minimal info 3. add a item to the basket 4. close the basket 5. receive a shipment 6. on the "receipt summary" click on "receive" for the wanted item (it should be the only one) 7. items ? receive? ? tick this checkbox 8. save 9. click on "finish receiving" 10. Go to the record ? Acquisition details 11. Apply this patch 12. Refresh the page 13. You should see the new column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 17:35:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 16:35:24 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: <bug-19953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19953-70-SnDiNnTGvo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 17:56:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 16:56:42 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-6iAaFVPodl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #17) > is_found is also a bit confusing, because this also includes transit items. > found = F in the reserves table is for waiting. So you might not think about > the transit items as well immediately. It confused me on testing this. found=W is waiting found=F is finished (only in deleted reserves) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 18:00:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 17:00:52 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-cWUHvUsFYE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #16) > Yes Barton you are right, that's why I added a comment to the POD of the > method to tell it only applies for the OPAC. > Maybe rename the method to something more verbose (is_cancelable_from_opac) > to remove the ambiguity? Maybe include a parameter for opac/intranet/api ? $hold->is_cancelable{( from => 'opac' or opac=>1 }) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 18:01:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 17:01:07 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-JqsIUfSKjS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- You are absolutely right, Marcel. Tired brain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 18:04:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 17:04:52 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-qIlr6PmZF7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #23 from Barton Chittenden <barton at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #21) > (In reply to Jonathan Druart from comment #16) > > Yes Barton you are right, that's why I added a comment to the POD of the > > method to tell it only applies for the OPAC. > > Maybe rename the method to something more verbose (is_cancelable_from_opac) > > to remove the ambiguity? > > Maybe include a parameter for opac/intranet/api ? > $hold->is_cancelable{( from => 'opac' or opac=>1 }) ? This strikes the right balance for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 18:12:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 17:12:49 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19709-70-O1eZEqwdvm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69418|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70432&action=edit Bug 19709 - Move template JavaScript to the footer: Labels This patch modifies the staff client label creator templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Creating and managing layouts - Creating and managing batches - Creating and managing templates - Creating and managing printer profiles - Creating quick spine labels Edit: Fixed footer include error causing blank popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 18:12:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 17:12:46 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19709-70-bMs3y6itt0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 18:13:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 17:13:35 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19709-70-G9pSa1e9sp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Claire Gravely from comment #3) > - clicking 'add items' without entering any barcodes opens an empty frame My updated patch fixes this. > - When exporting items or a batch, the 'cancel' link in the first frame > doesn't work > - After exporting, the 'done' button doesn't work I can't reproduce these problems. Can you please try again and let me know if it's still happening? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 18:24:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 17:24:54 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-UZ3AtLonM5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 18:24:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 17:24:54 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19931-70-OOtAC0zIlC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 18:24:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 17:24:54 +0000 Subject: [Koha-bugs] [Bug 19954] New: Update popup window templates to use Bootstrap grid: Patrons Message-ID: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 Bug ID: 19954 Summary: Update popup window templates to use Bootstrap grid: Patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 19641 Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be two patron-related templates: moremember-brief.tt and update-child.tt. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 18:44:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 17:44:05 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-O5iuvijGMk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70433&action=edit Bug 19641 (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:00:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:00:18 +0000 Subject: [Koha-bugs] [Bug 19955] New: Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl Message-ID: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Bug ID: 19955 Summary: Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:00:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:00:58 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl In-Reply-To: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19955-70-nN5LGddsaG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:01:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:01:01 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl In-Reply-To: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19955-70-9r9XC50AbI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70434&action=edit Bug 19955 - Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:01:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:01:10 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl In-Reply-To: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19955-70-Xr6gd4wpft@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:05:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:05:15 +0000 Subject: [Koha-bugs] [Bug 19956] New: Adjusting fine block on SIP connected self-check - Coffeyville Message-ID: <bug-19956-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19956 Bug ID: 19956 Summary: Adjusting fine block on SIP connected self-check - Coffeyville Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jesse at bywatersolutions.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org 1) Add a new parameter "ignore_AllFinesNeedOverride" to SIP2 config on a per-account basis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:06:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:06:19 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19919-70-LnvgP4fOU3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Christopher Davis <cgdavis at uintah.utah.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgdavis at uintah.utah.gov --- Comment #1 from Christopher Davis <cgdavis at uintah.utah.gov> --- Thanks Lisette, We have seen this behavior in Koha at our institution as well. This bug is more annoying and confusing than anything, but it would be good to have it patched. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:19:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:19:09 +0000 Subject: [Koha-bugs] [Bug 19957] New: Allow continued editing after saving a report Message-ID: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Bug ID: 19957 Summary: Allow continued editing after saving a report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:19:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:19:15 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-EYsVb1lkOI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:22:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:22:34 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl In-Reply-To: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19955-70-AJ4XEiNyyS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:26:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:26:41 +0000 Subject: [Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons In-Reply-To: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19954-70-jf99VLdWeJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:26:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:26:43 +0000 Subject: [Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons In-Reply-To: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19954-70-fnHUDn4N0t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70435&action=edit Bug 19954: Update popup window templates to use Bootstrap grid: Patrons This patch updates two patron-related templates to use the Bootstrap grid instead of the YUI grid. This patch also corrects an unrelated error in update-child.tt where some JS variable declarations required by members-menu.js were missing. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - The table of patron categories should be sortable. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:30:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:30:41 +0000 Subject: [Koha-bugs] [Bug 19958] New: Allow the system preference AutoMemberNum to include a combination of numbers and letters when creating a new barcode Message-ID: <bug-19958-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19958 Bug ID: 19958 Summary: Allow the system preference AutoMemberNum to include a combination of numbers and letters when creating a new barcode Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently the system preference "automembernum" only allows for the patron's barcode to default the card number field on the patron addition screen to the next available card number (for example, if the largest currently used card number is 26345000012941, then this field will default to 26345000012942). It would be nice for the library to choose the format of the barcode (for example : system preference autobarcode). Then a library could choose to include letters and numbers to their patron's barcode instead of just numbers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:31:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:31:11 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl In-Reply-To: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19955-70-EZrb89bqT3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70434|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70436&action=edit Bug 19955 - Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:32:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:32:05 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl In-Reply-To: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19955-70-gDeAm5b0kY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70436|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70437&action=edit Bug 19955 - Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:32:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:32:50 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19709-70-ZxDEWeY0cy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:32:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:32:50 +0000 Subject: [Koha-bugs] [Bug 19959] New: Update popup window templates to use Bootstrap grid: Label creator Message-ID: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 Bug ID: 19959 Summary: Update popup window templates to use Bootstrap grid: Label creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 19709 Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be two label creator templates: result.tt, search.tt. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 [Bug 19709] Move template JavaScript to the footer: Labels https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:32:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:32:50 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19931-70-0MgiwJWm0L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:35:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:35:31 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17978-70-RHHoKC92jU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Ed Veal <eveal at mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:41:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:41:21 +0000 Subject: [Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator In-Reply-To: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19959-70-rOZf7BCx5U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:41:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:41:24 +0000 Subject: [Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator In-Reply-To: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19959-70-pTiVf98van@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70438&action=edit Bug 19959: Update popup window templates to use Bootstrap grid: Label creator This patch updates two label creator templates to use the Bootstrap grid instead of the YUI grid. To test, apply the patch and go to Label creator -> Manage -> Label batches. - Create a new or open an existing label batch. - Click "Add items." - The resulting pop-up window should look correct. - Perform a search - The search results screen should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:45:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:45:38 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-HRMsx8twrl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:45:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:45:40 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-WW4fUgfhlI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70439&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 9 - Note errors stil display as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:46:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:46:44 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-kq7i3fKMQ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70440&action=edit Bug 19160: Move duplicated code to its own private subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:46:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:46:57 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-0OEeHXJswA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70441&action=edit Bug 19160: Move the code from controller to C4::Auth_with_cas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:47:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:47:02 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-apl5Qh4EQO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70442&action=edit Bug 19160: Isolate CAS code into its own module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:49:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:49:01 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-Ks24Sr3ZLc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This is what I had in mind. The first 2 patches just move code, the last one may be problematic if I missed something in the logic. In discussion. Please obsolete these patches if you prefer another QAer opinion or switch back to NSO if you agree with testing them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:53:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:53:00 +0000 Subject: [Koha-bugs] [Bug 19960] New: Update popup window templates to use Bootstrap grid: Add to list Message-ID: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 Bug ID: 19960 Summary: Update popup window templates to use Bootstrap grid: Add to list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be one lists template: addbybiblionumber.tt. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:53:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:53:00 +0000 Subject: [Koha-bugs] [Bug 19931] Update popup window templates to use Bootstrap grid In-Reply-To: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19931-70-IwUiNBgeT5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:58:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:58:11 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-9spZM4UiXH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70443&action=edit Bug 19957 - Hide saved message once editing report To test: 1 - Apply this patch 2 - Save/Update report 3 - Note when you focus on the 'sql' area the saved message dissappears -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:58:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:58:50 +0000 Subject: [Koha-bugs] [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list In-Reply-To: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19960-70-8718cBVDWH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:58:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:58:52 +0000 Subject: [Koha-bugs] [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list In-Reply-To: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19960-70-EZQMieDZu6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70444&action=edit Bug 19960: Update popup window templates to use Bootstrap grid: Add to list This patch updates add-to-list template to use the Bootstrap grid instead of the YUI grid. To test, open the detail page for a bibliographic record in the staff client and choose "Add to -> List." The resulting pop-up window should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 19:59:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 18:59:19 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-qK8oaTDKfR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 20:05:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 19:05:48 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17858-70-BplsxEpG1D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19961 [Bug 19961] Move template JavaScript to the footer: Patron card creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 20:05:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 19:05:48 +0000 Subject: [Koha-bugs] [Bug 19961] New: Move template JavaScript to the footer: Patron card creator Message-ID: <bug-19961-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19961 Bug ID: 19961 Summary: Move template JavaScript to the footer: Patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for patron card creator templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 20:44:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 19:44:42 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-ty2bk1mi35@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- I don't think it's necessary to show all the links from the old confirmation page. They're all in the toolbar or the sidebar. I would prefer that we instead put a standard "message" type dialog saying "Your report has been saved." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 21:53:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 20:53:00 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-Mgiua8anqo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 11 21:53:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jan 2018 20:53:59 +0000 Subject: [Koha-bugs] [Bug 16639] Split item data from description in Fines tab into separate columns In-Reply-To: <bug-16639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16639-70-gx6eH3vf4v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16639 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 02:36:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 01:36:37 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-4cfszbRLZQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> --- Looks good to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 08:18:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 07:18:03 +0000 Subject: [Koha-bugs] [Bug 19951] ; Literary form: not translated on search results with de-DE installed In-Reply-To: <bug-19951-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19951-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19951-70-Om7P7BSuiN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The translation displays on master and the po files for 17.11 contain the string. Did you make any changes to the default XSLT files? That could cause strings to appear untranslated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 08:18:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 07:18:36 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: <bug-11046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11046-70-H6tJ5Uzl3x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The manual team is still small, maybe write something up and send it to them? ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 08:19:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 07:19:04 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-l0V1a4iOQ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Thx for your adjustments! Looks good to me. Final comments: This is not a blocker for me, but OpacExportOptions controls the options listed by detail sidebar. Your custom exports are listed no matter what. It might be better to let OpacExportOptions also control if the custom exports should be added to the list somehow. Maybe not one by one, but just on directory level (show them all or not)? But do not make big adjustments here. It could be handled on a new report or we could simply state: remove the xsl files from biblioexport. XSLTParse4Display is not yet tested, but your change should officially be tested ;) Also I recommend to remove the opac parameter. It is not consistent with the approach followed in the sub. Not changing the parameters could help you here. Please send XSLTCustomExport and OPACXSLTCustomExport to the routine; this is consistent and does the same thing. Since your change only deals with the $xslfilename, I could live without a test script (but I am not sure about the RM). CustomXSLTExportList is new and should really have its own test (should not be hard) Mock opachtdocs and create the dir in a tempdir. Check on returned title and method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 08:23:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 07:23:08 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19911-70-D7qvHuFxJh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 08:25:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 07:25:12 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-dXAAHPbVw2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #60) > Bouzid: I will still continue on this one. But how do you make sure that you > do not save a personal name into say field 610 that should only include > corporate names ? QA: Looking here again little bit. Bouzid: A response would have been helpful to expedite QA now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 08:28:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 07:28:33 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19911-70-NKZ783Hq7K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70309|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 70446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70446&action=edit Bug 19911: Escape password value during self-registration confirmation The password must be correctly escape, it can contains html character and break the display. Test plan: Apply first patch and confirm that the display is broken Apply second patch (this one) and confirm that the display is fixed Signed-off-by: Arturo <alongoria at sll.texas.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 08:28:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 07:28:29 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19911-70-sTs4LcZluc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70308|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 70445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70445&action=edit Bug 19911: Do not escape html characters when saving passwords When the password is not generated automatically, we should not escape the html characters. Otherwise it will be changed without any warnings. Signed-off-by: Arturo <alongoria at sll.texas.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 08:29:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 07:29:22 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19911-70-evidcUFCir@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx, Arturo, for documenting your tests and the sign-off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 08:39:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 07:39:21 +0000 Subject: [Koha-bugs] [Bug 19951] ; Literary form: not translated on search results with de-DE installed In-Reply-To: <bug-19951-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19951-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19951-70-elFyDphysw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951 --- Comment #3 from Elias <elias.dehler at thulb.uni-jena.de> --- (In reply to Katrin Fischer from comment #2) > The translation displays on master and the po files for 17.11 contain the > string. > > Did you make any changes to the default XSLT files? That could cause strings > to appear untranslated. The default XSLT files are unchanged, but after another 'sudo koha-translate --update de-DE' the translation seems fixed. Thank you for the fast response. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 08:41:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 07:41:07 +0000 Subject: [Koha-bugs] [Bug 19951] ; Literary form: not translated on search results with de-DE installed In-Reply-To: <bug-19951-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19951-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19951-70-kla1FBcpsY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951 Elias <elias.dehler at thulb.uni-jena.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:21:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:21:34 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-VMHZsDrbBE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #62 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Thx for submitting your work. But I am still having serious doubts about this development. In the editor we normally work with the authority popup. You completely go around that here, but I still need to undo the plugin assignments before I can really get your function working. If I disconnect 600, you still assume that it is a personal name. But I may not want to work with your approach? If I enter an incorrect authid into $9, it accepts the name in $a and does not create an authority. But in another field (650), I see one is not accepted with an invalid authid, and another one with invalid authid is accepted. This is not stable. To get short, I would recommend to remove the link button, move your function to a plugin and minimize the changes to existing code to get it working. In that way we can choose which plugin we want to use. It might provide evidence for being stable and making a transition. tests for LinkBibHeadingsToAuthorities ? new sub AddAuthorityFromHeading Please note that the RM does no longer want to add C4 routines. What about UNIMARC btw? And adding an authority should not be in C4::Biblio! + # Get the first heading found in the biblio informations + foreach my $field ( $record->fields() ) { + my $heading = C4::Heading->new_from_bib_field($field); + next unless defined $heading; Isn't there a smarter way than just passing each field to Heading ? +is(C4::Biblio::AddAuthorityFromHeading(), 0, 'AddAuthorityFromHeading returns zero if not passed heading, field or bib'); This is not enough to test a new sub. Double eval (comment 59) There are enough reasons listed to postpone further QA for now. I am sorry for the amount of work here, but imo it needs larger adjustments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:27:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:27:09 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-KupZ2cn5Oz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #63 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Please squash the patches and correct the bug titles. See guidelines. We need them to be of the form Bug 12345: What does this patch do? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:34:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:34:51 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19937-70-WHY7BN9wqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:41:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:41:39 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19937-70-n5Tj45Tm1M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:41:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:41:42 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19937-70-DJuTBQGYTW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70410|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70447&action=edit Bug 19937: Silence warnings t/db_dependent/www/batch.t TEST PLAN --------- 1) Run the following on a kohadevbox: git checkout -b bug_19937 origin/master sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered at the end of the log file: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. 2) Run the following on a kohadevbox: exit git bz apply 19937 restart_all sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The log file will end with the restarting of plack, not the errors. 3) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison at marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Amended handling of $results_per_page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:44:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:44:19 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19921-70-OTdIsj19aH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:47:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:47:06 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19921-70-pWwCgoHmPy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:47:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:47:08 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19921-70-fIDooPEmf7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70340|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70448&action=edit Bug 19921: Fix update child when only one adult patron category exist We are passing the Koha::Patron::Category object to the template instead of the categorycode. To reproduce this bug you must test in a system which has only one patron category of the "adult" type. View the details of a patron with a child-type patron category and choose More -> Update child to adult patron. This results in an error: Can't call method "category_type" on an undefined value at /home/vagrant/kohaclone/members/update-child.pl line 84. The URL of the error page shows a problem with the parameters being passed: members/update-child.pl?op=update&borrowernumber=12345&catcode=Koha::Patron::Category=HASH(0xa168a18)&catcode_multi= Test plan: Make sure you have only 1 adult patron category Update a child to adult => With this patch applied the error is gone and the patron has been correctly updated Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:51:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:51:34 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-q6zeQg1Vv7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #64 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Marcel, > In the editor we normally work with the authority popup. You completely go > around that here, but I still need to undo the plugin assignments before I > can really get your function working. I didn't do that in my testing. I still could use the normal plugin with the link on $a IIRC. I know I didn't change the frameworks. > If I disconnect 600, you still assume that it is a personal name. But I may > not want to work with your approach? If I enter an incorrect authid into $9, > it accepts the name in $a and does not create an authority. > But in another field (650), I see one is not accepted with an invalid > authid, and another one with invalid authid is accepted. This is not stable. > > To get short, I would recommend to remove the link button, move your > function to a plugin and minimize the changes to existing code to get it > working. In that way we can choose which plugin we want to use. It might > provide evidence for being stable and making a transition. I think you can't achieve the same functionality with a plugin, a button to check all fields at the same time and give you a summary report of the ones linked/unlinked. And you shouldn't have to choose - both should always be possible, manual (with search) and automatic linking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:53:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:53:52 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-DuJnNBo2mz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #65 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think it should work like this: Check the framework for the authority type linked to a field and check for authorities of that type to link it with automatically. Fields not linked to an authority type, should not be auto-linked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:59:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:59:08 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-NaTqdODLPO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70016|0 |1 is obsolete| | --- Comment #49 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70449&action=edit Bug 19522: Coding style: Fix alignement after previous patch Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:59:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:59:16 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-F26cnONf4N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70017|0 |1 is obsolete| | --- Comment #50 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70450&action=edit Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unit?s" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unit?s" dropdown with french units Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:59:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:59:21 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-xTO4RualIU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70018|0 |1 is obsolete| | --- Comment #51 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70451&action=edit Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:59:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:59:25 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-nUPY16IqSg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70019|0 |1 is obsolete| | --- Comment #52 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70452&action=edit Bug 19522: Label creator: translate empty list message The name of the element wasn't translated in the message. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. ensure that the list is empty 4. then you should see "pas de Batches actuellement" 5. then you should see "cr?er un nouveau batch." 6. apply this patch 7. install the language 8. refresh the page 9. then you should see "pas de Lots actuellement" 10. then you should see "cr?er un nouveau lot ." Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:59:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:59:29 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-wU59n90caH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70020|0 |1 is obsolete| | --- Comment #53 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70453&action=edit Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. install the fr_FR locale 8. refresh the page 9. then you should see "Cote" in the column names Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 09:59:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 08:59:34 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-hIl6lq4Xqi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70021|0 |1 is obsolete| | --- Comment #54 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70454&action=edit Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des ?tiquettes" Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:04:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:04:50 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-J0cWlrieLy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #66 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #65) > I think it should work like this: Check the framework for the authority type > linked to a field and check for authorities of that type to link it with > automatically. Fields not linked to an authority type, should not be > auto-linked. Currently this is hardcoded in Heading somewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:08:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:08:22 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-hS8HR6EQAI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #55 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- (In reply to Jonathan Druart from comment #48) > error: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt). I resolved the conflict in this file. The strange thing is that there didn't seem to be a conflict. A git diff between my previous local branch for this bug and a new one (used for the conflict resolution) showed nothing on the involved file. But the patches successfully apply now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:09:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:09:42 +0000 Subject: [Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack In-Reply-To: <bug-17776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17776-70-fCGG0pKt47@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- ShibUseHeaders On|Off Defaults to "Off", this turns on the use of request headers to publish attributes to applications. Use of this option should be avoided. Be sure to review the topic on spoof checking if you enable it. You are suggesting to disable ShibUseEnvironment and enable ShibUseHeaders. Please explain. It is not recommended.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:29:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:29:07 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX ) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-duKXVICLAn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #67 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Marcel de Rooy from comment #66) > (In reply to Katrin Fischer from comment #65) > > I think it should work like this: Check the framework for the authority type > > linked to a field and check for authorities of that type to link it with > > automatically. Fields not linked to an authority type, should not be > > auto-linked. > > Currently this is hardcoded in Heading somewhere. Hm, yeah, I seem to remember that this was used for importing authorities in order to assign the correct framework. Maybe this could be seen as a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:38:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:38:42 +0000 Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19580-70-YT9v9zV3DV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:39:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:39:53 +0000 Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19580-70-hRAz7dRfDl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:39:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:39:55 +0000 Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19580-70-3NSADhY56Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69094|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70455&action=edit Bug 19580: Unit tests Signed-off-by: David Bourgault <david.bourgault at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:40:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:40:04 +0000 Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19580-70-vXHoXRRMEg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69095|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70456&action=edit Bug 19580: Exclude period as splitting character for autotrunction To test: 0 - Apply Unit test patch only 1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t 2 - Should fail 3 - Apply this patch 4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t 5 - should pass 6 - search for 'Local-number.raw:"4"' (or a vlid biblionumber) 7 - should get expected result Signed-off-by: David Bourgault <david.bourgault at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:41:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:41:05 +0000 Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19580-70-eYyVeFfjXu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looks good to me. Not tested with ES. No harm expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:42:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:42:43 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-1Ayt41slIf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:52:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:52:30 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4319-70-hohiKZHAWQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #79 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 70457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70457&action=edit Bug 4319 - [QA follow-up] Rename hasItemswaitingOrInTransit to has_items_waiting_or_intransit and update pod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 10:55:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 09:55:31 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4319-70-9OZyER6HMg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #80 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to Jonathan Druart from comment #77) > > I am pretty sure something is wrong. As already asked by Marcel, can you give me more explanation about what is wrong? Otherwise, i renamed hasItemswaitingOrInTransit to has_items_waiting_or_intransit and and added pod description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:06:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:06:34 +0000 Subject: [Koha-bugs] [Bug 19962] New: Introduce koha-sip to replace koha-*-sip Message-ID: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962 Bug ID: 19962 Summary: Introduce koha-sip to replace koha-*-sip Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: pongtawat at punsarn.asia QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Introduce a new koha-sip script which use new command style (as koha-plack, etc) to replace old set of SIP commands. Also add an ability to disable SIP. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:14:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:14:38 +0000 Subject: [Koha-bugs] [Bug 19962] Introduce koha-sip to replace koha-*-sip In-Reply-To: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19962-70-cC3V2epsK9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962 --- Comment #1 from Pongtawat <pongtawat at punsarn.asia> --- Created attachment 70458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70458&action=edit Bug 19962 - Introduce koha-sip to replace koha-*-sip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:19:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:19:03 +0000 Subject: [Koha-bugs] [Bug 19962] Introduce koha-sip to replace koha-*-sip In-Reply-To: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19962-70-wFGOBmsTls@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962 Pongtawat <pongtawat at punsarn.asia> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Pongtawat <pongtawat at punsarn.asia> --- To test: - Apply this patch - koha-sip --start koha1 => same as koha-start-sip koha1 - koha-sip --stop koha1 => same as koha-stop-sip koha1 - koha-sip --restart koha1 => same as koha-stop-sip koha1 && koha-start-sip koha1 - koha-sip --enable koha1 => same as koha-enable-sip koha1 - koha-sip --disable koha1 => new, move SIP config file Note: - stop use start-stop-daemon (same as koha-plack) to make sure it really stop - enable and disable is a bit different from koha-plack. It will continue even if some instances are already enabled (or disabled). In contrast, koha-plack --enable will just stop at the instance that was already enabled without processing the following instances. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:24:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:24:25 +0000 Subject: [Koha-bugs] [Bug 19962] Introduce koha-sip to replace koha-*-sip In-Reply-To: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19962-70-KZpfscUEAW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962 Pongtawat <pongtawat at punsarn.asia> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70458|1 |0 is patch| | Attachment #70458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:24:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:24:43 +0000 Subject: [Koha-bugs] [Bug 19962] Introduce koha-sip to replace koha-*-sip In-Reply-To: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19962-70-XrRJY42C1k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962 --- Comment #3 from Pongtawat <pongtawat at punsarn.asia> --- Created attachment 70459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70459&action=edit Bug 19962 - Introduce koha-sip to replace koha-*-sip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:35:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:35:36 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-hxWoEpOWtq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70377|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70461&action=edit Bug 18915: Giving CHECKOUT_NOTE access to issues table This patch allows the notice to reference the issues table so that the checkout note itself can be added to the note if wanted, such as in Comment 9. Sponsored-by: Catalyst IT Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> https://bugs.koha-community.org/show_bug.cgi?id=19801 Signed-off-by: Marjorie Vila <marjorie.barry-vila at collecto.ca> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:35:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:35:40 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-M2EYzRuXMI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70378|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70462&action=edit Bug 18915: Renaming svc/patron_notes to svc/checkout_notes For consistency. Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> https://bugs.koha-community.org/show_bug.cgi?id=19801 Signed-off-by: Marjorie Vila <marjorie.barry-vila at collecto.ca> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:35:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:35:46 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-rMZ3lRRvpV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70463&action=edit Bug 18915: (QA follow-up) Add note for installs after 17.05 Since the 17.05 upgrade adds the note and the sql file did not yet include the note, we should add it when it is not there (for example new 17.11s). Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Tested by running the dbrev while there is a letter and while not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:35:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:35:31 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-5tVqb1ywgo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70376|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70460&action=edit Bug 18915: Fix checkout note email message This patch replaces the <<biblio.item>> in the email with <<biblio.title>> and uses CHECKOUT_NOTE instead of PATRON_NOTE. This patch also adds the notice to installer/data/mysql/en/mandatory/sample_notices.sql, and updates the PATRON_NOTE entry in installer/data/mysql/updatedatabase.pl To test: 1) Apply patch and update database 2) View the message_queue table in mysql 3) Check out an item if haven't already 4) Go to OPAC and set a checkout note for an item 5) View message_queue table and confirm it the title is included in the email and all instances of 'patron note' have been replaced with 'checkout note' 6) Disable javascript in browser 7) repeat steps 4 and 5 and confirm all works as expected Sponsored-by: Catalyst IT Signed-off-by: Marjorie Vila <marjorie.barry-vila at collecto.ca> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:36:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:36:08 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-bM6tQVqsUU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 11:57:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 10:57:15 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-GSTcqC19Xd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:25:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:25:31 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-le3rB0UyJ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to M. Tompsett from comment #9) > (In reply to Jonathan Druart from comment #8) > > "Bug 19938: Split C4/Members.pm to avoid conflict issues" > > > > => What does it mean? > > because 19933 might trigger a conflict in C4/Members with the removal of > patronflags, so put the possible conflict area elsewhere. I split it from a > single commit, so as to avoid the conflict as needed. I don't see how they can conflict. Bug 19933 only adds a comment to C4/Members.pm, and not very close to the lines modified by this bug's patches. I think it's safe to squash the patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:44:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:44:04 +0000 Subject: [Koha-bugs] [Bug 19963] New: ethnicity and ethnicity tables and columns survived update Message-ID: <bug-19963-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19963 Bug ID: 19963 Summary: ethnicity and ethnicity tables and columns survived update Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The database update for 3.21.00.033 should have removed the ethnicity table and the ethnicity and ethnotes columns from borrowers, deletedborrowers and borrower_modifications. This didn't work right in all cases. I just noticed that all those survived in our older databases. The reason is that the database update only checked for NULL when counting existing data, but not for "": 11054 $DBversion = "3.21.00.033"; 11055 if ( CheckVersion($DBversion) ) { 11056 11057 my $done = 0; 11058 my $count_ethnicity = $dbh->selectrow_arrayref(q| 11059 SELECT COUNT(*) FROM ethnicity 11060 |); 11061 my $count_borrower_modifications = $dbh->selectrow_arrayref(q| 11062 SELECT COUNT(*) 11063 FROM borrower_modifications 11064 WHERE ethnicity IS NOT NULL 11065 OR ethnotes IS NOT NULL 11066 |); 11067 my $count_borrowers = $dbh->selectrow_arrayref(q| 11068 SELECT COUNT(*) 11069 FROM borrowers 11070 WHERE ethnicity IS NOT NULL 11071 OR ethnotes IS NOT NULL 11072 |); 11073 # We don't care about the ethnicity of the deleted borrowers, right? 11074 if ( $count_ethnicity->[0] == 0 11075 and $count_borrower_modifications->[0] == 0 11076 and $count_borrowers->[0] == 0 11077 ) { 11078 $dbh->do(q| 11079 DROP TABLE ethnicity 11080 |); 11081 $dbh->do(q| 11082 ALTER TABLE borrower_modifications 11083 DROP COLUMN ethnicity, 11084 DROP COLUMN ethnotes 11085 |); 11086 $dbh->do(q| 11087 ALTER TABLE borrowers 11088 DROP COLUMN ethnicity, 11089 DROP COLUMN ethnotes 11090 |); 11091 $dbh->do(q| 11092 ALTER TABLE deletedborrowers 11093 DROP COLUMN ethnicity, 11094 DROP COLUMN ethnotes 11095 |); 11096 $done = 1; 11097 } 11098 if ( $done ) { 11099 print "Upgrade to $DBversion done (Bug 10020: Drop table ethnicity and columns ethnicity and ethnotes)\n"; 11100 } 11101 else { 11102 print "Upgrade to $DBversion done (Bug 10020: This database contains data related to 'ethnicity'. No change will be done on the DB structure but note that the Koha codebase does not use it)\n"; 11103 } 11104 11105 SetVersion ($DBversion); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:51:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:51:24 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table In-Reply-To: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13667-70-pZgQViVUpt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Provide script to regularly |Provide script to regularly |clean deletedpatrons table |clean deletedborrowers | |table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:51:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:51:49 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table In-Reply-To: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13667-70-E5DNzh4WhJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Blocks| |18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:51:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:51:49 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-oi58URYBzk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13667 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 [Bug 13667] Provide script to regularly clean deletedborrowers table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:52:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:52:28 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table In-Reply-To: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13667-70-evOGYyL1mZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18081 | --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is quite a big privacy issue. If a patron asks for his data to be deleted, it should be deleted. Keeping it might even be against law in some contexts. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:52:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:52:28 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-eH8z3JZSjO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13667 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 [Bug 13667] Provide script to regularly clean deletedborrowers table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:52:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:52:55 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table In-Reply-To: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13667-70-A6KURIbHrG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:52:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:52:55 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-AIOjZEubTI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13667 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 [Bug 13667] Provide script to regularly clean deletedborrowers table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:53:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:53:05 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table In-Reply-To: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13667-70-GqijJtvwjG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18081 Depends on|18081 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:53:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:53:05 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-8lar1CAY7C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13667 | Depends on| |13667 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 [Bug 13667] Provide script to regularly clean deletedborrowers table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 12:55:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 11:55:07 +0000 Subject: [Koha-bugs] [Bug 19964] New: Can't call method "fields" on an undefined value at /usr/ share/koha/lib/C4/Biblio.pm line 2438 Message-ID: <bug-19964-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19964 Bug ID: 19964 Summary: Can't call method "fields" on an undefined value at /usr/share/koha/lib/C4/Biblio.pm line 2438 Change sponsored?: --- Product: Koha Version: master Hardware: PC OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: mjoao at reitoria.ulisboa.pt QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 70464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70464&action=edit 3 images as described in comment This error occurs on records that are data as deleted, but actually appear in the results of an OPAC and Intranet environment search (image 1). What appears to give rise to these failures is some power failure when creating a new bibliographic record. The record gets an error in some field, does not allow us to have access to continue to edit or correct, but appears in the search results (image 1); and when trying to open this error appears (image 2 & 3). can anyone help find a solution, especially so that erroneous bibliographic records do not appear in the OPAC and Intranet search results? Thanks Maria Nunes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 13:07:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 12:07:55 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-Tx8xnXD6P2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Jonathan Druart from comment #7) > (In reply to M. Tompsett from comment #0) > > While retesting a bug, I ran a prove -r -v t, which generated a lot of log > > noise. One such entry was: > > [Tue Jan 9 03:54:58 2018] starman: Use of uninitialized value > > $overdues_count in numeric gt (>) at > > /home/vagrant/kohaclone/opac/opac-main.pl line 76. > > Prove generated a log entry from opac-main.pl? How? > > https://jenkins.koha-community.org/job/Koha_Master_D8/lastCompletedBuild/ > console t/db_dependent/www/search_utf8.t use Test::WWW::Mechanize to do various HTTP requests to Koha, that's how. I can confirm that warnings disappear after applying the patches, but before I mark this as Passed QA, please rewrite the commit message. It's not really a refactoring because it changes behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 13:11:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 12:11:51 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-rQfhrWHIhr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 13:11:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 12:11:42 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-gwOk75ooJs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Julian Maurice from comment #10) > I don't see how they can conflict. Bug 19933 only adds a comment to > C4/Members.pm, and not very close to the lines modified by this bug's > patches. > I think it's safe to squash the patches. I didn't realize the code modified by this patch was inside patronflags(), so feel free to squash the patches or not, but if you decide to keep both patches separated, please rewrite the first commit message too, it doesn't describe what the patch does -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 13:20:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 12:20:43 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: <bug-19191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19191-70-hKabWlEOlK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70465&action=edit Bug 19191 [QA Followup] - Remove db update so feature is disabled by default for existing installations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 13:23:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 12:23:19 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: <bug-19191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19191-70-HKtM9i0zyg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70465|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70466&action=edit Bug 19191 [QA Followup] - Remove db update so feature is disabled by default for existing installations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 13:45:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 12:45:23 +0000 Subject: [Koha-bugs] [Bug 19964] Can't call method "fields" on an undefined value at /usr/share /koha/lib/C4/Biblio.pm line 2438 In-Reply-To: <bug-19964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19964-70-DQN41fkJCf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19964 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |nick at bywatersolutions.com Status|NEW |RESOLVED --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- It sounds like an indexing error - you should run a full rebuild of your indexes to make sure these are all cleared out. As to why it happened, that is harder to say. If records were deleted via the db the zebra queue may not have been updated. You can ask in IRC or on the mailing lists for more information, but I think it is not a bug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 14:17:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 13:17:10 +0000 Subject: [Koha-bugs] [Bug 19931] Omnibus: Update popup window templates to use Bootstrap grid In-Reply-To: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19931-70-rEZG0lHj6W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update popup window |Omnibus: Update popup |templates to use Bootstrap |window templates to use |grid |Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 14:17:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 13:17:31 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: <bug-11046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11046-70-S6WMnxWUIu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #15) > (In reply to Jonathan Druart from comment #13) > > Can we have a patch for the manual please? :) > > Does the Manual keyword trigger someone of the Documentation team to do so? I think the author or someone involved in the development/testing of the patch should write something to explain to the manual team what the feature/change is. And then the manual team could adapt it correctly to the manual and make a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 14:34:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 13:34:11 +0000 Subject: [Koha-bugs] [Bug 19325] Enable padding of printed barcodes In-Reply-To: <bug-19325-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19325-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19325-70-4o4Beb7jx3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> --- Why new system preferences ? Shouldn't it be configurable at the layout level ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 14:38:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 13:38:18 +0000 Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related tools In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19682-70-mHW3sXBp87@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 14:38:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 13:38:21 +0000 Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related tools In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19682-70-QDjPU9LbOW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69737|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70467&action=edit Bug 19682: Move JS to the footer: Two patron-related tools This patch modifies two patron-related tools templates in the staff client so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Import patrons - Upload patron images Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Edit for QA: Fixed datepickers on import patron form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 14:53:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 13:53:09 +0000 Subject: [Koha-bugs] [Bug 19703] Some items have the incorrect item type displayed in the ' Most popular' section in OPAC In-Reply-To: <bug-19703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19703-70-pXV4IKIuk1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19703 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|17.05 |master --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- The query in Circulation.pm is pulling itemtype from biblioitems, so it looks like the information being displayed is accurate if unexpected. I'm not sure how one reconciles the notion of item-level item types with a limit on item type which groups by biblionumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 14:53:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 13:53:17 +0000 Subject: [Koha-bugs] [Bug 19483] t/db_dependent/www/ * crashes test harness due to misconfigured test plan In-Reply-To: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19483-70-i9VT416H5d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19483 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 14:53:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 13:53:35 +0000 Subject: [Koha-bugs] [Bug 19483] t/db_dependent/www/ * crashes test harness due to misconfigured test plan In-Reply-To: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19483-70-sqxZ7gTkR2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19483 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68307|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 70468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70468&action=edit Bug 19483: Fix test plan in t/db_dependent/www/* t/db_dependent/www/* crashes test harness due to misconfigured test plan prove t/db_dependent/www/ without defining KOHA_INTRANET_URL bails out and marks the whole test suite as failed. Test suite should not be failed if this optional WWW::Mechanize test suite is not activated. After this patch, the tests are properly skipped without failing the whole tests. This is important when running all tests under t, as this needlessly fails the test suite. Also handling of 'skip_all' is inconsistent in t/db_dependent/www -tests, so this normalizes it to skip_all instead of bail_out Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 14:58:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 13:58:31 +0000 Subject: [Koha-bugs] [Bug 19483] t/db_dependent/www/ * crashes test harness due to misconfigured test plan In-Reply-To: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19483-70-3gYnrrKn4M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19483 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 15:37:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 14:37:52 +0000 Subject: [Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in In-Reply-To: <bug-19394-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19394-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19394-70-w8NHKKUEHb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:24:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:24:43 +0000 Subject: [Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in In-Reply-To: <bug-19394-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19394-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19394-70-bDIKj0anF8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> --- Hi Alex, Here are a few things you need to change: 1. Remove all occurences of onboardingrequired, it's stored in a bad place, it's badly used and you don't need it (explanation below:) a. userflags contain name and description of user permissions, it's not a place to store arbitrary flags (despite its name) b. if we decide to skip the onboarding tool, the first time the DB user logs in they are not redirected to the onboarding tool because onboardingrequired's value is 0 (it's set to 1 only at this moment), so the user need to reload the page to be redirected to the onboarding tool. Moreover onboardingrequired is still equals to 1 after the onboarding process c. you don't need it because you have another check that is (IMO) enough : if there is at least one user that have permission superlibrarian, it means that someone is gone through the onboarding process (or someone has manually configured Koha, which means the onboarding process is not needed) 2. check_if_patrons_have_flags is not needed: you can replace it by Koha::Patrons->search({flags => { '!=' => undef }}) (and anyway the previous check is enough IMO, so it could be completely removed) 3. I think that changes in installer/onboarding.pl are not needed: a. you changed the redirection to installer/install.pl to mainpage.pl, which then redirects to installer/install.pl, so it adds one more redirection for the same result b. there seems to be no scenario where $op == 'skip', can you confirm that ? Now that's a personal opinion but I believe that a warning message would be better than an automatic redirect. There might be some cases where I don't want to go through the onboarding process at all and this redirect could become annoying -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:33:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:33:31 +0000 Subject: [Koha-bugs] [Bug 19470] Add information about item being in rotating collection on detail page In-Reply-To: <bug-19470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19470-70-7wXFXVhQ9s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19470 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |BLOCKED --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Changing status to BLOCKED because it depends on a NSO bug (bug 18606) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:35:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:35:57 +0000 Subject: [Koha-bugs] [Bug 19965] New: 008 tag editor not showen completely Message-ID: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19965 Bug ID: 19965 Summary: 008 tag editor not showen completely Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: reza0770 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl We updating Koha from 3.18 to 17.11 But we encountered a problem after the update was complete When create a new bibliographic record and click on 008 tag editor, does not showing completely. How we can fix this problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:42:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:42:01 +0000 Subject: [Koha-bugs] [Bug 19965] 008 tag editor not showen completely In-Reply-To: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19965-70-JDR8XbBpAS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19965 --- Comment #1 from Hussain A <reza0770 at gmail.com> --- Created attachment 70469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70469&action=edit 008 tag editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:45:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:45:33 +0000 Subject: [Koha-bugs] [Bug 19966] New: Add ability to pass objects directly to slips and notices Message-ID: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Bug ID: 19966 Summary: Add ability to pass objects directly to slips and notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Koha spends an incredible amount of time on parsing and processing parameters passed in to slips and notices. It would be immensely more efficient to be able to pass objects directly to GetPreparedLetter so it doesn't need to do any fetching / processing on them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:45:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:45:38 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19966-70-tDzK4l5s6P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:48:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:48:07 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19966-70-aqiQYYYzWP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:48:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:48:09 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19966-70-ltmzdO9z6G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70470&action=edit Bug 19966 - Add ability to pass objects directly to slips and notices Koha spends an incredible amount of time on parsing and processing parameters passed in to slips and notices. It would be immensely more efficient to be able to pass objects directly to GetPreparedLetter so it doesn't need to do any fetching / processing on them. Test plan: 1) Apply this patch 2) prove t/db_dependent/Letters/TemplateToolkit.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:49:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:49:29 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: <bug-19191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19191-70-Q3sPEsCDaW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68812|0 |1 is obsolete| | Attachment #70466|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70471&action=edit Bug 19191 - Add ability to email receipts for account payments and write-offs Some libraries are paperless and require all payment receipts to be emailed. Koha should give libraries the option to send email receipts if a patron has an email address. If a notice for the type of "credit" exists ( payment or writeoff ), then an email receipt will be sent. These notices only support Template Toolkit syntax. Test Plan: 1) Apply this patch and dependencies 2) Add the two new notices, you can find them in installer/data/mysql/en/mandatory/sample_notices.sql 3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF 4) Find or create a patron with an email address that owes some amount of money 5) Make a payment for one or more fees 6) Note a new email is queued for the patron 7) Make a writeoff for one or more fees 8) Note a new new email is queued for the patron Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:50:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:50:06 +0000 Subject: [Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs In-Reply-To: <bug-19191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19191-70-CKqNYUHf7a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 [Bug 19966] Add ability to pass objects directly to slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 16:50:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 15:50:06 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19966-70-LoUNvrVeeF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191 [Bug 19191] Add ability to email receipts for account payments and write-offs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 17:15:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 16:15:58 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-Cd3UYaTcYW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #13 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70472&action=edit Bug 19938: Refactor checkoverdues call in C4/Members.pm Due to concerns that another bug may conflict, this was purposefully split. The other bug removes patronflags(). It is this function that has the C4::Overdues::checkoverdues call refactored. TEST PLAN --------- Apply both patches and follow the test plan in the larger one. Signed-off-by: Lee Jamison <ldjamison at marywood.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 17:16:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 16:16:24 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-5G1ugwPV24@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70396|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 17:16:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 16:16:02 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-v4Ah6GKB0N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70397|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70473&action=edit Bug 19938: Refactor checkoverdues TEST PLAN --------- 0) back up plack error log if you care. 1) Run these on your kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. However, the log file will have noise. 2) Run these on your kohadevbox: git bz apply 19938 restart_all echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. This time the log file will have no noise. 3) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison at marywood.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 17:20:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 16:20:24 +0000 Subject: [Koha-bugs] [Bug 10708] Make fine receipt customizable In-Reply-To: <bug-10708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10708-70-jYmsa5B29l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 17:20:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 16:20:39 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-AhSAmmGFA8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from M. Tompsett <mtompset at hotmail.com> --- It seemed from comment #11 and comment #12, that the FailedQA was for the git commit messages, not the actual code. Changing the return value and tweaking code based on that is a refactor, just not in a huge rewrite from scratch sense. Perhaps there is a better word, but I can't think of it right now. As I only changed the commit message, I'm moving this back to Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 17:21:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 16:21:41 +0000 Subject: [Koha-bugs] [Bug 19967] New: Search patrons with non-Latin languages is brocken if DefaultPatronSearchFields includes dateofbirth Message-ID: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967 Bug ID: 19967 Summary: Search patrons with non-Latin languages is brocken if DefaultPatronSearchFields includes dateofbirth Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: ulrich.kleiber at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In this particular case you get the mysql error message: Illegal mix of collations for operation 'like' You can prevent this error by removing dateofbirth from DefaultPatronSearchFields or by the following patch: diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm index 2446703..ba32a12 100644 --- a/C4/Utils/DataTables/Members.pm +++ b/C4/Utils/DataTables/Members.pm @@ -117,7 +117,12 @@ sub search { my @where_strs_or; for my $searchfield ( split /,/, $searchfields->{$searchfieldstype} ) { - push @where_strs_or, "borrowers." . $dbh->quote_identifier($searchfield) . " LIKE ?"; + if ( $searchfield eq 'dateofbirth' ) { + push @where_strs_or, "DATE_FORMAT(borrowers." . $dbh->quote_identifier($searchfield) . ", '%Y-%m-%d') LIKE ?"; + } else { + push @where_strs_or, "borrowers." . $dbh->quote_identifier($searchfield) . " LIKE ?"; + } + push @where_args, $term; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 17:52:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 16:52:56 +0000 Subject: [Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets In-Reply-To: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17661-70-kTrPFWygnD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 17:52:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 16:52:58 +0000 Subject: [Koha-bugs] [Bug 19567] Development In-Reply-To: <bug-19567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19567-70-4CYiKRFguu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19567 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 9302 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 17:52:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 16:52:58 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-YcYMw3pGST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- *** Bug 19567 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 18:03:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 17:03:15 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-80YQR6s3Ez@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- basket.tt and basketgroup.tt aren't [%- delimiter -%]. I believe the hyphens are important to the formatting of the file. Please correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 18:10:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 17:10:17 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-brebhmwP2u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #11 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- (In reply to M. Tompsett from comment #10) > basket.tt and basketgroup.tt aren't [%- delimiter -%]. I believe the hyphens > are important to the formatting of the file. Please correct. I remember removing the post/pre-chomp after having checked that the output was still correct. Is there another caveat? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 18:15:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 17:15:36 +0000 Subject: [Koha-bugs] [Bug 19968] New: Undefined subroutine &Date::Calc::Today Message-ID: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 Bug ID: 19968 Summary: Undefined subroutine &Date::Calc::Today Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: Jean-Daniel.Tissot at univ-fcomte.fr QA Contact: testopia at bugs.koha-community.org Software error: Undefined subroutine &Date::Calc::Today called at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/unimarc_field_100.pl line 75. Jonathan Druart propose to add "use Date::Calc;" after other use statements in file /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/unimarc_field_100.pl After adding this line, the problem is solved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 18:18:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 17:18:56 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-M9p28dXpEr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 --- Comment #1 from Jean-Daniel Tissot <Jean-Daniel.Tissot at univ-fcomte.fr> --- OS is Debian Jessie and Koha is installed from http://debian.koha-community.org/koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 18:20:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 17:20:15 +0000 Subject: [Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes dateofbirth In-Reply-To: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19967-70-LapD9T2jLn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Search patrons with |Search patrons with |non-Latin languages is |non-Latin languages is |brocken if |broken if |DefaultPatronSearchFields |DefaultPatronSearchFields |includes dateofbirth |includes dateofbirth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 18:30:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 17:30:30 +0000 Subject: [Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes dateofbirth In-Reply-To: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19967-70-Mb87NprofY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think we need to do the fix for all date fields, I just tried adding datexpiry and it breaks the search as well. (dateexpiry, dateenrolled, lastseen, updated_on..?) To test: - Configure DefaultPatronSearchFields including dateofbirth and surname - Add a patron to your database with a cyrillig surname - Try to search for the patron - > keeps loading forever -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 18:45:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 17:45:35 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-EGGibgYPYd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #12 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Victor Grousset/tuxayo from comment #11) > I remember removing the post/pre-chomp after having checked that the output > was still correct. Is there another caveat? If you say it is the same, I'll test it. But it just didn't eyeball well. It if works, I'll set to signed off. If not, I'll confirm that it didn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 18:51:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 17:51:34 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-v6Fam3SvhJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68606|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70474&action=edit Bug 9302 - Add ability to merge patron records It would be great if there were a merge patrons feature. If you accidentally end up with one patron with two cards it would be nice to merge their records together so that you don't lose their history or holds or anything. This patch adds a basic patron merge feature. It attempts to relink all patron related tables from the patron(s) to be merged. It does not attempt to relink librarian account related tables at this time. This feature does not attempt to automatically resolve issues such as duplicate holds. Such a feature could build upon this one though. Test Plan: 1) Apply this patch 2) Find two or more patrons 3) Perform a patron search that will bring them up on the same page of results, or add them all to a list of patrons. 4) Use the 'merge' button to begin the merging process 5) Choose a patron to keep 6) Verify the deleted patrons data ( checkouts, holds, etc ) are now linked to the kept patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 18:51:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 17:51:31 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-BVCy3qPMVQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 19:13:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 18:13:54 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14407-70-tYBakYcfAc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #40 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70475&action=edit Bug 14407: Allow restricting SCO to IP or IP range Converted this to actual applicable patches. I think the test plan is comment #28. -- Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 19:16:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 18:16:34 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14407-70-OLqABeljdY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #41 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70476&action=edit Bug 14407: Unit tests for in_ipset TEST PLAN --------- 1) apply all pathches 2) sudo koha-shell -c bash kohadev prove t/Auth.t -- should run. 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 19:18:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 18:18:18 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14407-70-bn1dWUXIwy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #68836|0 |1 is obsolete| | --- Comment #42 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 68836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68836 Allow restricting SCO to IP or IP range Patch attached in a non-patch way making things harder to git bz. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 20:23:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 19:23:03 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-bloLRsZ2Tc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70477&action=edit Bug 9302 [QA Followup] - Copy merged patrons to deletedborrowers table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 20:29:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 19:29:08 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-1I62rMBfQm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 20:29:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 19:29:12 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-xHtgat0yzH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70474|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70478&action=edit Bug 9302 - Add ability to merge patron records It would be great if there were a merge patrons feature. If you accidentally end up with one patron with two cards it would be nice to merge their records together so that you don't lose their history or holds or anything. This patch adds a basic patron merge feature. It attempts to relink all patron related tables from the patron(s) to be merged. It does not attempt to relink librarian account related tables at this time. This feature does not attempt to automatically resolve issues such as duplicate holds. Such a feature could build upon this one though. Test Plan: 1) Apply this patch 2) Find two or more patrons 3) Perform a patron search that will bring them up on the same page of results, or add them all to a list of patrons. 4) Use the 'merge' button to begin the merging process 5) Choose a patron to keep 6) Verify the deleted patrons data ( checkouts, holds, etc ) are now linked to the kept patron Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 20:29:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 19:29:15 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-73fyQZeQep@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #18 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70479&action=edit Bug 9302 [QA Followup] Copy merged patrons to deletedborrowers table Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 20:30:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 19:30:14 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-TEGZXS8Eu3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 21:27:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 20:27:41 +0000 Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15707-70-UYF4rRILaM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 21:29:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 20:29:00 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-jYFkp2TVwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 21:29:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 20:29:32 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16735-70-ZBJmbPEYiT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 21:29:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 20:29:50 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-zu896yBlWv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 21:50:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 20:50:31 +0000 Subject: [Koha-bugs] [Bug 19969] New: Adding a manual restriction in memberentrypl with a date does not restrict the patron Message-ID: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19969 Bug ID: 19969 Summary: Adding a manual restriction in memberentrypl with a date does not restrict the patron Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When entering a patron manual restriction with a specific date in the memberentry.pl page- the restriction is not carried over into the checkout page and patron is not restricted. Entering a manual restriction on the memberentry.pl page without a date will carry over the restriction and not allow patron to checkout. This is seen in Koha Version 17.05.07. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 12 23:35:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 22:35:46 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-T0XEp4tPXr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from M. Tompsett <mtompset at hotmail.com> --- Failed QA test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 00:41:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jan 2018 23:41:37 +0000 Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19875-70-HpLjaL3zwn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour at inlibro.com --- Comment #4 from Roch D'Amour <roch.damour at inlibro.com> --- I applied the patch, searched for results with a "&" in the title, and subscribed to the RSS feed. The feed show up, but I only get entrys up untill the records with the "&" in the title. After this records, nothing else show up. I followed the test plan, and I was wondering what do you meant by "subscribe is ok | nok"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 01:27:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 00:27:12 +0000 Subject: [Koha-bugs] [Bug 18923] Resolve a warn in Biblio::GetCOinSBiblio In-Reply-To: <bug-18923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18923-70-w83IVZxLRQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18923 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 16.11.x will be in 16.11.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 06:17:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 05:17:06 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: <bug-17553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17553-70-y24QGUiAMr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 --- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Why 'get_overdues' instead of 'overdues'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 09:19:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 08:19:15 +0000 Subject: [Koha-bugs] [Bug 19413] Move the location of the Ok and cancel buttons to the 008 cataloguing builder In-Reply-To: <bug-19413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19413-70-eOsNfH6Dum@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 70480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70480&action=edit Screenshot of translated Plugin This doesn't work so well with languages where the term "Cancel" is translated to a longer word. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 09:22:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 08:22:03 +0000 Subject: [Koha-bugs] [Bug 19970] New: Revise change of bug 19413 to work better for translations Message-ID: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Bug ID: 19970 Summary: Revise change of bug 19413 to work better for translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 19413 Created attachment 70481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70481&action=edit screenshot de-DE Bug 19413 moved the buttons in the cataloguing plugins to the top, this doesn't work well for translations where the terms 'cancel' and 'ok' can be longer. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 [Bug 19413] Move the location of the Ok and cancel buttons to the 008 cataloguing builder -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 09:22:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 08:22:03 +0000 Subject: [Koha-bugs] [Bug 19413] Move the location of the Ok and cancel buttons to the 008 cataloguing builder In-Reply-To: <bug-19413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19413-70-DKdo1lfLBC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19413 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 [Bug 19970] Revise change of bug 19413 to work better for translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 09:31:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 08:31:41 +0000 Subject: [Koha-bugs] [Bug 19969] Adding a manual restriction in memberentrypl with a date does not restrict the patron In-Reply-To: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19969-70-bPwpG2FGBs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19969 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kelly, I just tested on master and it seems to work ok. Which date did you try? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 09:33:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 08:33:58 +0000 Subject: [Koha-bugs] [Bug 19965] 008 tag editor not showing completely In-Reply-To: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19965-70-kH5QE2FWdT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19965 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|008 tag editor not showen |008 tag editor not showing |completely |completely CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Hussain, i just tested on master and it works ok there. Are you looking at the translated page or the English one? Is there a Javascript error on the page? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 09:44:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 08:44:09 +0000 Subject: [Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better for translations In-Reply-To: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19970-70-GkDZkx0fUx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 09:57:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 08:57:07 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-DtMGwqN2Ru@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Please check that the translated export still works nicely after this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 09:59:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 08:59:27 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-87RCvxoroz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- See bug 18331 - we have broken the translations of the CSV files more times than I can count - should not repeat that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 14:45:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 13:45:08 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-mV6meADAUI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #16 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Katrin Fischer from comment #14) > Please check that the translated export still works nicely after this change. That's his test plan in comment #8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 13 18:21:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jan 2018 17:21:51 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-cecVDN0q8F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It's missing steps. - you need to update the po files after the patch was applied - you have to check that the string got not marked as 'fuzzy' - you have to reinstall the language Only then the test gives you a correct result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 14 19:27:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jan 2018 18:27:09 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-0Z0PWoRlkZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 ByWaterSandboxes at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ByWaterSandboxes at gmail.com --- Comment #19 from ByWaterSandboxes at gmail.com --- Patch tested with a sandbox, by Ed Veal <eveal at mckinneytexas.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 14 19:27:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jan 2018 18:27:22 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-Rhjl06BGLz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 ByWaterSandboxes at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 14 19:27:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jan 2018 18:27:26 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-9mYZNmxviC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 ByWaterSandboxes at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 14 19:27:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jan 2018 18:27:32 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-Pb725vShjD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #20 from ByWaterSandboxes at gmail.com --- Created attachment 70482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70482&action=edit Bug 9302 - Add ability to merge patron records It would be great if there were a merge patrons feature. If you accidentally end up with one patron with two cards it would be nice to merge their records together so that you don't lose their history or holds or anything. This patch adds a basic patron merge feature. It attempts to relink all patron related tables from the patron(s) to be merged. It does not attempt to relink librarian account related tables at this time. This feature does not attempt to automatically resolve issues such as duplicate holds. Such a feature could build upon this one though. Test Plan: 1) Apply this patch 2) Find two or more patrons 3) Perform a patron search that will bring them up on the same page of results, or add them all to a list of patrons. 4) Use the 'merge' button to begin the merging process 5) Choose a patron to keep 6) Verify the deleted patrons data ( checkouts, holds, etc ) are now linked to the kept patron Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Ed Veal <eveal at mckinneytexas.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 14 19:27:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jan 2018 18:27:35 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9302-70-XeEjf2tIDy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #21 from ByWaterSandboxes at gmail.com --- Created attachment 70483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70483&action=edit Bug 9302 [QA Followup] Copy merged patrons to deletedborrowers table Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Ed Veal <eveal at mckinneytexas.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 14 19:40:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jan 2018 18:40:11 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-WLMkEeOhPz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 ByWaterSandboxes at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ByWaterSandboxes at gmail.com --- Comment #129 from ByWaterSandboxes at gmail.com --- Patch tested with a sandbox, by Ed Veal <eveal at mckinneytexas.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 14 19:40:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jan 2018 18:40:34 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-gtF9ZbkY14@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #130 from ByWaterSandboxes at gmail.com --- Created attachment 70484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70484&action=edit Bug 8000 - Redirect all emails to SendAllEmailsTo Koha/Email.pm Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) Signed-off-by: Ed Veal <eveal at mckinneytexas.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 14 19:40:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jan 2018 18:40:25 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-gEml1n4zYy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 ByWaterSandboxes at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70087|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 08:58:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 07:58:34 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-Ti4WoODJ9Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|baptiste.wojtkowski at biblibr |fridolin.somers at biblibre.co |e.com |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 09:49:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 08:49:38 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-q57iuSPAdN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to M. Tompsett from comment #15) > It seemed from comment #11 and comment #12, that the FailedQA was for the > git commit messages, not the actual code. > > Changing the return value and tweaking code based on that is a refactor, > just not in a huge rewrite from scratch sense. Perhaps there is a better > word, but I can't think of it right now. According to Wikipedia, > Code refactoring is the process of restructuring existing computer code > without changing its external behavior. IMO the return value is part of the external behavior of a subroutine, so it's not a refactor. But I won't block this any longer for such a minor issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 09:51:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 08:51:23 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-XXCKSq55Hp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70472|0 |1 is obsolete| | --- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 70485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70485&action=edit Bug 19938: Refactor checkoverdues call in C4/Members.pm Due to concerns that another bug may conflict, this was purposefully split. The other bug removes patronflags(). It is this function that has the C4::Overdues::checkoverdues call refactored. TEST PLAN --------- Apply both patches and follow the test plan in the larger one. Signed-off-by: Lee Jamison <ldjamison at marywood.edu> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 09:51:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 08:51:28 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-ukYqgZJ1VX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70473|0 |1 is obsolete| | --- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 70486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70486&action=edit Bug 19938: Refactor checkoverdues TEST PLAN --------- 0) back up plack error log if you care. 1) Run these on your kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. However, the log file will have noise. 2) Run these on your kohadevbox: git bz apply 19938 restart_all echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. This time the log file will have no noise. 3) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison at marywood.edu> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 09:51:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 08:51:43 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-HHNLuFm8Fw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:12:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:12:05 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-wpLkf10wJj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70487&action=edit Bug 19968: Add missing use Date::Calc statement It has been reported than the missing use statement can cause a compilation error: Undefined subroutine &Date::Calc::Today called at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/unimarc_field_100.pl line 75. Test plan: Use this UNIMARC plugin and make sure it fixes the error or at least does not break it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:12:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:12:02 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-13kE05GQWD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:14:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:14:20 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-LOMPtzjE68@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |m.de.rooy at rijksmuseum.nl Component|Notices |Cataloging Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:14:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:14:23 +0000 Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron category report In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19669-70-A4fDY0zsnn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:14:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:14:42 +0000 Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during self-registration if PatronSelfRegistrationVerifyByEmail is enabled In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19845-70-uVkJzeQmJR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:15:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:15:05 +0000 Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when date changes during test run In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17770-70-2YZj7KKhf5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:15:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:15:22 +0000 Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing method In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19450-70-JrMZte5nHL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:16:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:16:35 +0000 Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers In-Reply-To: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19017-70-QFApTvKy2J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I did not switch the status to get another QA point of view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:17:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:17:20 +0000 Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11210-70-i63L6EIcVN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:18:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:18:13 +0000 Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool patron creation In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19514-70-sgGByTk5Vg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:18:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:18:35 +0000 Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19444-70-q1ftNihl7i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #23 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:18:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:18:50 +0000 Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19510-70-ijytnnhMoi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:19:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:19:46 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18201-70-Ks4IMjiDFP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #26 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:20:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:20:09 +0000 Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19694-70-pvY0fE7NV4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:20:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:20:25 +0000 Subject: [Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method In-Reply-To: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19830-70-XjKyxXGejx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:20:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:20:38 +0000 Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on large systems In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19599-70-QD3MFt9nfM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:30:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:30:56 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: <bug-17553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17553-70-hQY9m38wsZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Tom?s Cohen Arazi from comment #12) > Why 'get_overdues' instead of 'overdues'? I guess because I initially wrote these patches more than a year ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:34:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:34:20 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: <bug-17553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17553-70-UO6Mhz8SpV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Tom?s Cohen Arazi from comment #12) > Why 'get_overdues' instead of 'overdues'? It comes from "Bug 17580: Add the Koha::Patron->get_overdues method", we could rename it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:53:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:53:35 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-uQz7XbVrug@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:53:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:53:37 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-3tmosWlSLj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70487|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70488&action=edit Bug 19968: Add missing use Date::Calc statement It has been reported than the missing use statement can cause a compilation error: Undefined subroutine &Date::Calc::Today called at /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/unimarc_field_100.pl line 75. Test plan: Use this UNIMARC plugin and make sure it fixes the error or at least does not break it Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:54:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:54:11 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-y5bFJQSPbS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- SO en QA in one run -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:54:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:54:26 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-HbQRG7vmnG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4) > SO en QA in one run en = and -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:54:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:54:55 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-RXlbW28uSl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Linux |All -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 14:56:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 13:56:24 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13560-70-tkr5Qd6hGm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 --- Comment #8 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Does anyone know which value should be elected between the conflicting commits? (or maybe if another one should) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 15:32:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 14:32:43 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-0MHdUGlonX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #15) > (In reply to Jonathan Druart from comment #14) > > QA: Please make sure bug 19772 is fixed. > > Yes this has been fixed. The problem was I'd missed a case when changing > PATRON_NOTE to CHECKOUT_NOTE in svc/checkout_notes. No it is not fixed, if the notice template does not exist I do receive a success message "Your note about ITEM_TITLE has been saved and sent to the library." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 15:46:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 14:46:34 +0000 Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron category report In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19669-70-euLopjm9K2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 15:49:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 14:49:53 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl) In-Reply-To: <bug-17457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17457-70-rS7R1wv7g1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Tests are MARC21 specific, please provide a version for UNIMARC. I would suggest to create a MARC::Record manually instead of using a MARC XML. See what is done in t/db_dependent/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 15:54:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 14:54:20 +0000 Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during self-registration if PatronSelfRegistrationVerifyByEmail is enabled In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19845-70-BxVFSpSkQh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- This line has been changed by Bug 18298: Add server-side checks and refactor stuffs Note sure it can be applied on 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 15:54:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 14:54:35 +0000 Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during self-registration if PatronSelfRegistrationVerifyByEmail is enabled In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19845-70-vum8HolVEK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 [Bug 18298] Allow enforcing password complexity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 15:54:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 14:54:35 +0000 Subject: [Koha-bugs] [Bug 18298] Allow enforcing password complexity In-Reply-To: <bug-18298-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18298-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18298-70-3asPepmO4o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19845 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845 [Bug 19845] Patron password is ignored during self-registration if PatronSelfRegistrationVerifyByEmail is enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:02:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:02:32 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-SXCKsq1R1O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70489&action=edit Bug 19938: Do not fetch dashboard's info if no logged in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:02:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:02:58 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-FDwtOVXIe9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- So actually we are trying to remove a warning because there are wrong calls in opac-main. The dashboard's info should be fetched only if a patron is logged in. I did this change on bug 12001 already. I am suggesting a new patch to avoid the change of the subroutine's prototype (which is wrong instead, but let remove the subroutine instead) and future conflict (with bug 19933). Deal? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:12:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:12:18 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18856-70-fQs6Zx01Dk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Looking at bug 4319: We also have C4::Reserves::IsItemOnHoldAndFound that does exactly the same thing. So maybe "is_cancelable" is too specific? What could we do to keep this code simple, understandable and consistent? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:13:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:13:34 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4319-70-U9xSOCRVyg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #81 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- See bug 18856 comment 24. I do not have the time right now to deep into it but I am collecting ideas to keep the code smart. Marked as blocked by 18856. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:16:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:16:42 +0000 Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when date changes during test run In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17770-70-19iyZ3NQ3i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #28 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:23:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:23:13 +0000 Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing method In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19450-70-hbkXyAqG6l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:25:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:25:20 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-wluGvpQrsN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:25:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:25:26 +0000 Subject: [Koha-bugs] [Bug 19483] t/db_dependent/www/ * crashes test harness due to misconfigured test plan In-Reply-To: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19483-70-rAyVTBAqLn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19483 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:25:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:25:32 +0000 Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19580-70-9LXG3DK8Cz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:25:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:25:48 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19921-70-VKcaTOkGzd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:25:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:25:53 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19937-70-QIYF8BJz7z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:25:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:25:42 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19911-70-uZRxZZ59YY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:28:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:28:11 +0000 Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11210-70-dNDzH6fB0B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 Small enhancement so I decided to push to oldstable branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:29:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:29:50 +0000 Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool patron creation In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19514-70-0zcbiewJZ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:30:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:30:42 +0000 Subject: [Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes dateofbirth In-Reply-To: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19967-70-4lRLluPgIP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967 --- Comment #2 from Ulrich Kleiber <ulrich.kleiber at bsz-bw.de> --- Created attachment 70490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70490&action=edit Bug 19967: Search patrons with non-Latin languages is brocken. If DefaultPatronSearchFields includes a column with type date, datetime or timestamp, search patrons with non-Latin languages hangis on 'Processing...'. Converting columns with type date, datetime or timestamp to type string eliminates this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:37:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:37:02 +0000 Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during self-registration if PatronSelfRegistrationVerifyByEmail is enabled In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19845-70-UKDdyiPmAB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #9) > This line has been changed by Bug 18298: Add server-side checks and refactor > stuffs > Note sure it can be applied on 17.05.x yes the bug exists in 17.05.x The same fixes would be: - $borrower{password} = random_string(".........."); + $borrower{password} = random_string("..........") unless $borrower{password}; The problem is that we cannot force the user to choose a strong password (and default min password length is 3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:39:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:39:34 +0000 Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19444-70-g9U9UrLgYV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #24 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:43:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:43:30 +0000 Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19510-70-Js6dAXRCcw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:45:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:45:19 +0000 Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality In-Reply-To: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18201-70-kxBvlnHOEh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #27 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:45:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:45:43 +0000 Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19694-70-vGceEf0Gfu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:46:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:46:38 +0000 Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19694-70-DzZYMEBEvk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694 --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:47:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:47:36 +0000 Subject: [Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method In-Reply-To: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19830-70-yGLQjlZNtO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:47:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:47:36 +0000 Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on large systems In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19599-70-sCWFI89WTu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599 Bug 19599 depends on bug 19830, which changed state. Bug 19830 Summary: Add the Koha::Patron->old_checkout method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:50:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:50:33 +0000 Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on large systems In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19599-70-QCpR9EG6DP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 19830 that is not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 16:54:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 15:54:06 +0000 Subject: [Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes dateofbirth In-Reply-To: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19967-70-JmIkN6OZjh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Ulrich, you are using a MySQLism, you should use Koha::Objects->columns instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:02:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:02:22 +0000 Subject: [Koha-bugs] [Bug 12468] copyright symbol not translating right In-Reply-To: <bug-12468-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12468-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12468-70-qeLTWcJa1l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12468 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |FIXED --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I guess this is solved, please reopen if not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:06:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:06:23 +0000 Subject: [Koha-bugs] [Bug 3765] Road Types and Street Numbers on Patron Rec Inconsistent In-Reply-To: <bug-3765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3765-70-eEixAli42x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3765 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |FIXED --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This seems to be fixed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:06:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:06:24 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address In-Reply-To: <bug-3766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3766-70-ph2ZvfDU8H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Bug 3766 depends on bug 3765, which changed state. Bug 3765 Summary: Road Types and Street Numbers on Patron Rec Inconsistent https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3765 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:21:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:21:07 +0000 Subject: [Koha-bugs] [Bug 19971] New: typo in the comments of parseQuery routine Message-ID: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 Bug ID: 19971 Summary: typo in the comments of parseQuery routine Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org In the instructions of use, buildQuery is written instead of parseQuery -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:29:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:29:13 +0000 Subject: [Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes date or datetime field In-Reply-To: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19967-70-aK11jr8gOw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search patrons with |Search patrons with |non-Latin languages is |non-Latin languages is |broken if |broken if |DefaultPatronSearchFields |DefaultPatronSearchFields |includes dateofbirth |includes date or datetime | |field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:29:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:29:28 +0000 Subject: [Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes date or datetime field In-Reply-To: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19967-70-ieHdLHEj4d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:29:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:29:47 +0000 Subject: [Koha-bugs] [Bug 19972] New: Holds to pull (pendingreserves.pl) should honor syspref " item-level_itypes" Message-ID: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Bug ID: 19972 Summary: Holds to pull (pendingreserves.pl) should honor syspref "item-level_itypes" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:35:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:35:06 +0000 Subject: [Koha-bugs] [Bug 19971] typo in the comments of parseQuery routine In-Reply-To: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19971-70-2Pgp4gOohP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 70491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70491&action=edit Typo in the comments of parseQuery routine -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:35:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:35:13 +0000 Subject: [Koha-bugs] [Bug 19971] typo in the comments of parseQuery routine In-Reply-To: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19971-70-vRPDctZS4P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:41:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:41:59 +0000 Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers should use biblio_metadata.timestamp In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19725-70-AqIQqctWf1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:42:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:42:11 +0000 Subject: [Koha-bugs] [Bug 11976] Add column settings + new column "Publication date" to the subscription table In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11976-70-gSqcFVAza3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:42:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:42:28 +0000 Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC only appears / works if no other list already exists In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19573-70-6VGAC8oHQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:42:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:42:46 +0000 Subject: [Koha-bugs] [Bug 19756] Encoding issues when update DB is run from the interface In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19756-70-qeqe8JxHKe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:43:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:43:03 +0000 Subject: [Koha-bugs] [Bug 19429] No confirm message when deleting an invoice from invoice search In-Reply-To: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19429-70-ZnZvEQ6zGF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:43:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:43:14 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-gUVXyxcyxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 --- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70492&action=edit Bug 18915: Add CHECKOUT_NOTE notice template for other languages Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:43:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:43:20 +0000 Subject: [Koha-bugs] [Bug 19401] No confirm message when deleting an invoice from invoice detail page In-Reply-To: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19401-70-RpeBEUmh7M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:43:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:43:35 +0000 Subject: [Koha-bugs] [Bug 19867] HouseboundRoles.t is failing randomly In-Reply-To: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19867-70-AMNlIVhSLF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19867 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:43:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:43:51 +0000 Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not accessible In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19760-70-jTc0YZwOrn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:44:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:44:09 +0000 Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19200-70-9uj7TJuEei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:44:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:44:24 +0000 Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag not existing In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19813-70-KtDtdTwJsM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:44:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:44:45 +0000 Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders subfields In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18458-70-55kUolRwu9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:45:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:45:02 +0000 Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing 'Holds history' tab for a patron In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19621-70-wa1SmYPYB5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:45:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:45:16 +0000 Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19840-70-2Qveh0Eqod@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:45:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:45:29 +0000 Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19702-70-Zpwu7ZzJbN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:45:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:45:37 +0000 Subject: [Koha-bugs] [Bug 18537] Update Ukrainian installer sample files for 17.05 In-Reply-To: <bug-18537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18537-70-V8H0Nu27KS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 [Bug 19973] SQL syntax error in uk-UA/mandatory/sample_notices.sq -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:45:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:45:37 +0000 Subject: [Koha-bugs] [Bug 19973] New: SQL syntax error in uk-UA/mandatory/sample_notices.sq Message-ID: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 Bug ID: 19973 Summary: SQL syntax error in uk-UA/mandatory/sample_notices.sq Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 18537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 [Bug 18537] Update Ukrainian installer sample files for 17.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:45:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:45:45 +0000 Subject: [Koha-bugs] [Bug 19788] Case sensitivity is not preserved when creating local system preferences In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19788-70-bJGVsKkx0r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:45:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:45:57 +0000 Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in patron modification screen In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19857-70-KKpECdPnNj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:46:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:46:04 +0000 Subject: [Koha-bugs] [Bug 19973] SQL syntax error in uk-UA/mandatory/sample_notices.sql In-Reply-To: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19973-70-gLpTBpkCM7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SQL syntax error in |SQL syntax error in |uk-UA/mandatory/sample_noti |uk-UA/mandatory/sample_noti |ces.sq |ces.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:46:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:46:12 +0000 Subject: [Koha-bugs] [Bug 16764] Update printers administration page In-Reply-To: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16764-70-MXud01YkYH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:46:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:46:26 +0000 Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff client menu bar In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19851-70-Ktl2YkqlxH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:46:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:46:40 +0000 Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19860-70-s0qaDPEmc0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:46:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:46:52 +0000 Subject: [Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt In-Reply-To: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19338-70-N7LwYtVU9k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:47:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:47:06 +0000 Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for transfer-slip. In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19798-70-t419cbg1Za@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:47:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:47:22 +0000 Subject: [Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock In-Reply-To: <bug-18183-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18183-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18183-70-AsaT3giCSr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:47:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:47:35 +0000 Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase In-Reply-To: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19807-70-4HSBAhErAW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:47:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:47:47 +0000 Subject: [Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt In-Reply-To: <bug-19918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19918-70-d3zjHa8Shi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:47:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:47:51 +0000 Subject: [Koha-bugs] [Bug 19973] SQL syntax error in uk-UA/mandatory/sample_notices.sql In-Reply-To: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19973-70-XwUaPxTaEp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:47:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:47:55 +0000 Subject: [Koha-bugs] [Bug 19973] SQL syntax error in uk-UA/mandatory/sample_notices.sql In-Reply-To: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19973-70-NMuucnQFnp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70493&action=edit Bug 19973: Fix SQL syntax error in uk-UA/mandatory/sample_notices.sql Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:48:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:48:05 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: <bug-19899-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19899-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19899-70-8ebrHwddrJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #22 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:48:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:48:18 +0000 Subject: [Koha-bugs] [Bug 19973] SQL syntax error in uk-UA/mandatory/sample_notices.sql In-Reply-To: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19973-70-XCzhScVuFG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:48:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:48:18 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: <bug-19914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19914-70-InRVgquUV0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:48:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:48:31 +0000 Subject: [Koha-bugs] [Bug 19973] SQL syntax error in uk-UA/mandatory/sample_notices.sql In-Reply-To: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19973-70-09CG0LCK2F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:48:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:48:30 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: <bug-19913-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19913-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19913-70-XWVFI5C1E0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:48:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:48:25 +0000 Subject: [Koha-bugs] [Bug 19973] SQL syntax error in uk-UA/mandatory/sample_notices.sql In-Reply-To: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19973-70-GP6IfD4hYH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:48:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:48:44 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: <bug-18417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18417-70-GH1eLpV7OA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:49:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:49:01 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: <bug-16782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16782-70-Kd1S0yjFZY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 17:49:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 16:49:08 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-wtEAJNzc3Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patch pushed to master for 18.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 18:29:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 17:29:34 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-2PE0vVQcFT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69507|0 |1 is obsolete| | --- Comment #31 from David Gustafsson <glasklas at gmail.com> --- Created attachment 70494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70494&action=edit Bug 19575: Use canonical field names and resolve aliased fields Adjust elastic search mappings to more closely match Zebra equivalents resolving serveral issues with coded Zebra searches in templates and sorting of search results in UI. Also make field names in search strings case insensitive to accept case variations in template links and user input. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 18:51:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 17:51:19 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-dKSTNa2rC9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #32 from David Gustafsson <glasklas at gmail.com> --- Case insensitive field names in searches is now fixed. A few changes I made could use some extra motivation/explanation: # sub _convert_index_strings_freeform() (line 685): changed from: sub _convert_index_strings_freeform { my ( $self, $search ) = @_; while ( my ( $zeb, $es ) = each %index_field_convert ) { $search =~ s/\b$zeb(?:,[\w\-]*)?:/$es:/g; } return $search; } to: my $field_name_pattern = '[\w\-]+'; my $multi_field_pattern = "(?:\\.$field_name_pattern)*"; ... sub _convert_index_strings_freeform { my ( $self, $search ) = @_; $search =~ s/($field_name_pattern)(?:,[\w-]*)?($multi_field_pattern):/\L$1\E$2:/og; $search =~ s/($field_name_pattern)($multi_field_pattern):/(exists $index_field_convert{$1} ? $index_field_convert{$1} : $1)."$2:"/oge; return $search; } (Excluding comments) With new regexps for lower-casing field names etc there is a lot of duplication for things like field names, possible multiple/subfields etc, so created some variables for components that are often reused to prevent some pitfalls in possible future refactoring. I'm not sure it really matters performance wise, but also replaced the alias replacement code with a more efficient code since the %index_field_convert hash is now much larger than before. Also, the regexp in sub _truncate_terms() has been changed to also use $field_name_pattern and $multi_field_pattern. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:01:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:01:30 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-WoUxV7mHBm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70494|0 |1 is obsolete| | --- Comment #33 from David Gustafsson <glasklas at gmail.com> --- Created attachment 70495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70495&action=edit Bug 19575: Use canonical field names and resolve aliased fields Adjust elastic search mappings to more closely match Zebra equivalents resolving serveral issues with coded Zebra searches in templates and sorting of search results in UI. Also make field names in search strings case insensitive to accept case variations in template links and user input. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:02:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:02:14 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-czfQfTPvBZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #34 from David Gustafsson <glasklas at gmail.com> --- Found some more places where hard coded fields needed to be changed to lower-case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:16:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:16:02 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-fDIX0mZ9zC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65737|0 |1 is obsolete| | --- Comment #153 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70496&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:17:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:17:56 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-waBD7pIznt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70496|0 |1 is obsolete| | --- Comment #154 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70497&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:18:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:18:05 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-mHKL11BQ4Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65738|0 |1 is obsolete| | --- Comment #155 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70498&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:18:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:18:13 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-wrZLNG1uqv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65739|0 |1 is obsolete| | --- Comment #156 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70499&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:18:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:18:21 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-QSYIf2cGdW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65740|0 |1 is obsolete| | --- Comment #157 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70500&action=edit Bug 11897: Add Koha::Objects for Stockrotation module. * Koha/Stockrotationitem.pm: New file. * Koha/Stockrotationitems.pm: New file. * Koha/Stockrotationrota.pm: New file. * Koha/Stockrotationrotas.pm: New file. * Koha/Stockrotationstage.pm: New file. * Koha/Stockrotationstages.pm: New file. * t/db_dependent/Stockrotationitems.t: New file. * t/db_dependent/Stockrotationrotas.t: New file. * t/db_dependent/Stockrotationstages.t: New file. * Koha/Item.pm (stockrotationitem, add_to_rota, biblio): New procedures. * Koha/Library.pm (stockrotationstages): New procedure. * t/db_dependent/Items.t: Add tests. * t/db_dependent/Koha/Libraries.t: Add tests. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:18:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:18:31 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-HZI0yTeV3x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65741|0 |1 is obsolete| | --- Comment #158 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70501&action=edit Bug 11897: Add stockrotation cron script. * misc/cronjobs/stockrotation.pl: New file. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:18:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:18:38 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-8xpOzTxJaa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65742|0 |1 is obsolete| | --- Comment #159 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70502&action=edit Bug 11897: Add Utils library for Stockrotation module * Koha/Util/Stockrotation.pm: new file Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:18:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:18:45 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-Y9OLA406OI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65743|0 |1 is obsolete| | --- Comment #160 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70503&action=edit Bug 11897: REST API - add path defs, controller & tests * Koha/REST/V1/Stage.pm: New file * api/v1/swagger/paths.json: Add route for stage manipulation * api/v1/swagger/paths/rotas.json: New file * t/db_dependent/api/v1/stockrotationstage.t: New file Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:19:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:19:00 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-JihrT7hrrx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65745|0 |1 is obsolete| | --- Comment #162 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70505&action=edit Bug 11897: Add Stockrotation CSS rules * koha-tmpl/intranet-tmpl/prog/css/staff-global.css: New rules Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:19:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:19:09 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-XA635JTFPg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65746|0 |1 is obsolete| | --- Comment #163 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70506&action=edit Bug 11897: Add Stock Rotation permissions to list * koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc: Add new permissions Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:18:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:18:53 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-D7K1WSG1N8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65744|0 |1 is obsolete| | --- Comment #161 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70504&action=edit Bug 11897: Add JS to provide rota stage manipulation * koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js: new file Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:19:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:19:16 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-U2oPnvzbFD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65747|0 |1 is obsolete| | --- Comment #164 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70507&action=edit Bug 11897: Interface for rotas from Tools menu * tools/stockrotation.pl: New file * koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt: New file * koha-tmpl/intranet-tmpl/prog/en/includes/stockrotation-toolbar.inc: Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:19:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:19:24 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-1aULCaP1ZR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65748|0 |1 is obsolete| | --- Comment #165 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70508&action=edit Bug 11897: Interface for rota items from biblio * catalogue/stockrotation.pl: New file * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt: New file Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:19:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:19:31 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-EmdIdZJrWD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65749|0 |1 is obsolete| | --- Comment #166 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70509&action=edit Bug 11897: Add menu options for Stock Rotation * koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc: Add menu option * koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc: Add menu option * koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt: Add menu option Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:19:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:19:40 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-VUQxGo57kA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65750|0 |1 is obsolete| | --- Comment #167 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70510&action=edit Bug 11897: Bugfixes, unit tests, feedback, documentation. A (squashed) patch implementing significant changes to many parts of the module. Also adds thorough unit tests. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:19:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:19:46 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-GTxEchgMsC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65751|0 |1 is obsolete| | --- Comment #168 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70511&action=edit Bug 11897: Fix style of button links, & form wording. * koha-tmpl/intranet-tmpl/prog/en/includes/stockrotation-toolbar.inc * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt * koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:19:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:19:54 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-b782SxkP54@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65752|0 |1 is obsolete| | --- Comment #169 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70512&action=edit Bug 11897: Add documentation for the cron script. * misc/cronjobs/stockrotation.pl: Add documentation. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:20:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:20:03 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-d0EOF1Zk4O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65753|0 |1 is obsolete| | --- Comment #170 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70513&action=edit Bug 11897: Use camel case in Koha namespace modules. * Koha/Item.pm (stockrotationitem, add_to_rota): Use camel case. * Koha/Library.pm (stockrotationstages): Use camel case. * Koha/REST/V1/Stage.pm (move): Use camel case. * Koha/StockRotationItem.pm: New name for 'Koha/Stockrotationitem.pm'. (stage, advance): Use camel case. * Koha/StockRotationItems.pm: New name for 'Koha/Stockrotationitems.pm'. (object_class): Use camel case. * Koha/StockRotationRota.pm: New name for 'Koha/Stockrotationrota.pm'. (stockrotationstages, stockrotationitems, add_item): Use camel case. * Koha/StockRotationRotas.pm: New name for 'Koha/Stockrotationrotas.pm'. (object_class): Use camel case. * Koha/StockRotationStage.pm: New name for 'Koha/Stockrotationstage.pm'. (stockrotationitems, rota, siblings, next_siblings, previous_siblings) (next_sibling, previous_sibling, first_sibling, last_sibling): Use camel case. * Koha/StockRotationStages.pm: New name for 'Koha/Stockrotationstages.pm'. (object_class): Use camel case. * Koha/Util/StockRotation.pm: New name for 'Koha/Util/Stockrotation.pm'. (toggle_indemand, move_to_next_stage, remove_from_stage): Use camel case. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Improve wording. * misc/cronjobs/stockrotation.pl: Use camel case. * catalogue/stockrotation.pl: Use camel case. * tools/stockrotation.pl: Use camel case. * t/db_dependent/Items.t: Use camel case. * t/db_dependent/Koha/Libraries.t: Use camel case. * t/db_dependent/StockRotationItems.t: New name for 't/db_dependent/Stockrotationitems.t' & use camel case. * t/db_dependent/StockRotationRotas.t: New name for 't/db_dependent/Stockrotationrotas.t' & use camel case. * t/db_dependent/StockRotationStages.t: New name for 't/db_dependent/Stockrotationstages.t' & use camel case. * t/db_dependent/api/v1/stockrotationstage.t: Use camel case. https://bugs.koha-community.org/show_bug.cgi?id=11897 Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:20:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:20:10 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-c1rw7ISkCO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65754|0 |1 is obsolete| | --- Comment #171 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70514&action=edit Bug 11897: Bugfix: Handle empty rotas. * Koha/StockRotationRota.pm (investigate): If current rota has no stages, return empty items & log entries in report. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:20:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:20:19 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-G0zWuYoYlQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65755|0 |1 is obsolete| | --- Comment #172 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70515&action=edit Bug 11897: Follow up: Update userflags/permission id. * installer/data/mysql/atomicupdate/stockrot_tables.sql: Set the ID for permissions and userflags to 22. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:20:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:20:27 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-hYM6ZdWzhf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65756|0 |1 is obsolete| | --- Comment #173 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70516&action=edit Bug 11897: Follow up: Use "btn-xs" instead of "btn-sm". * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt: Replace "btn-sm" with "btn-xs". * koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt: Replace "btn-sm" with "btn-xs". Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:20:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:20:34 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-Nsci5sFDES@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65757|0 |1 is obsolete| | --- Comment #174 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70517&action=edit Bug 11897: Follow up: Check syspref before stockrotation access. * koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc: Add check for syspref. * koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc: Add check for syspref. * koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt: Add check for syspref. * tools/stockrotation.pl: Add check for syspref. * catalogue/stockrotation.pl: Add check for syspref. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:20:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:20:40 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-kYCJ6RyjE6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65758|0 |1 is obsolete| | --- Comment #175 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70518&action=edit Bug 11897: Move from ::Swagger to ::OpenAPI. * Koha/REST/V1/Stage.pm * api/v1/swagger/paths/rotas.json Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:20:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:20:48 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-lT8LSPLy22@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66381|0 |1 is obsolete| | --- Comment #176 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70519&action=edit Bug 11897: Follow up: Add more error conditions. * api/v1/swagger/paths/rotas.json: Add 401, 500 & 503 error conditions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:20:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:20:56 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-HGpUiJsmJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #177 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70520&action=edit Bug 11897: Rebase bugfixes. * api/v1/swagger/paths.json: Fix missing commas. * api/v1/swagger/paths/rotas.json: Fix missing commas. * installer/data/mysql/atomicupdate/stockrot_tables.sql: Up perms counter to 23. * installer/data/mysql/userpermissions.sql: Up perms counter to 23. * t/db_dependent/StockRotationItems.t: Fix builder semantics. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:32:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:32:37 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: <bug-18822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18822-70-Zjm3m9FU6h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Comment10 did not receive an answer. Changing the status sometimes helps :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:52:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:52:25 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-iKKL1GGGji@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70497|0 |1 is obsolete| | Attachment #70498|0 |1 is obsolete| | Attachment #70499|0 |1 is obsolete| | Attachment #70500|0 |1 is obsolete| | Attachment #70501|0 |1 is obsolete| | Attachment #70502|0 |1 is obsolete| | Attachment #70503|0 |1 is obsolete| | Attachment #70504|0 |1 is obsolete| | Attachment #70505|0 |1 is obsolete| | Attachment #70506|0 |1 is obsolete| | Attachment #70507|0 |1 is obsolete| | Attachment #70508|0 |1 is obsolete| | Attachment #70509|0 |1 is obsolete| | Attachment #70510|0 |1 is obsolete| | Attachment #70511|0 |1 is obsolete| | Attachment #70512|0 |1 is obsolete| | Attachment #70513|0 |1 is obsolete| | Attachment #70514|0 |1 is obsolete| | Attachment #70515|0 |1 is obsolete| | Attachment #70516|0 |1 is obsolete| | Attachment #70517|0 |1 is obsolete| | Attachment #70518|0 |1 is obsolete| | Attachment #70519|0 |1 is obsolete| | Attachment #70520|0 |1 is obsolete| | --- Comment #178 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70521&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:52:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:52:46 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-UAhztFai8E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #179 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70522&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:52:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:52:56 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-WO1Bshq1md@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #180 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70523&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 19:53:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 18:53:05 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11897-70-teNOcaZYvk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #181 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> --- Created attachment 70524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70524&action=edit Bug 11897: Add bulk of Stockrotation module. This commit replaces a set of about 20 commits into one large commit. This makes working with the module way easier from bugzilla. As it stands the patches on this bug provide a fully functioning stock rotation feature set for Koha. All previous patches that added functionality were signed off, so I'm retaining that flag. Signed-off-by: Kathleen Milne <kathleen.milne at cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 21:01:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 20:01:50 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: <bug-16782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16782-70-za2nbr9bqp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #26 from Liz Rea <liz at catalyst.net.nz> --- Hm, this'd be a feature not a bug. It's harmless but we should remember not to push features to stable branches. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 22:05:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 21:05:53 +0000 Subject: [Koha-bugs] [Bug 19974] New: Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) Message-ID: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 Bug ID: 19974 Summary: Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: charles.farmer at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When modifying an item through the intranet at the page /cgi-bin/koha/cataloguing/additem.pl?op=edititem, instead of changing the active item's information, the markaslost parameter will be applied to the first Item in the database that has no itemnumber. I'll submit a patch soon with a clear test plan. This should fortunately not take too long to test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 22:06:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 21:06:33 +0000 Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) In-Reply-To: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19974-70-ZJCwvtLXUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com, | |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 22:06:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 21:06:42 +0000 Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) In-Reply-To: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19974-70-ONPTnHJ6fb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |charles.farmer at inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 23:05:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 22:05:47 +0000 Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) In-Reply-To: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19974-70-nmAjG9xusJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 --- Comment #1 from Charles Farmer <charles.farmer at inlibro.com> --- Created attachment 70525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70525&action=edit Bug19974 - Marking an item as 'lost' in additem.pl will not modify the current item TEST PLAN: 1) Log in with your superlibrarian account 2) Borrow any book 3) Visit your Checkouts page, and click 'Show Checkouts' 4) Click on the item's barcode to visit the item's page 5) On the item's page, click the 'Edit' button, and choose 'Edit items' 6) In the items table, click the 'Actions->Edit' button of the item you borrowed 7) Mark that item as lost (it should be the first row of the form) and click the button 'Save changes' 8) Visit your Checkouts page. The item should still be there, despite BZ12363 claiming it should've been automagically returned 8.1) Your koha-log should also output a warning message: 'DBIx::Class::Storage::DBI::select_single(): Query returned more than one row...' 8.2) If you visit the item's page, the modification had no effect. It should not be marked as lost. 9) APPLY PATCH 10) Start back from step 2), but this time, after marking the item as lost, the item's page should reflect the change, and the item you borrowed should've been automatically returned to the library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 23:07:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 22:07:15 +0000 Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) In-Reply-To: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19974-70-UBR7xRtUnr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 15 23:23:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jan 2018 22:23:45 +0000 Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) In-Reply-To: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19974-70-0vrbXUe2D8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 --- Comment #2 from Charles Farmer <charles.farmer at inlibro.com> --- To my knowledge, emptying $itemnumber is only done so we don't fall back onto the same item after saving changes. On one hand, we load back into the $op=additem interface if changes were accepted, otherwise, we load the same item again. What's lost on me is the reason why we'd want to proceed with the deletion logic at all if the newitem has a barcode already used. Is there code anywhere edging on that voodoo logic of deleting an item from an unsaved biblionotice? What would make sense, imo, is pushing that deletion logic upward inside the 'else' block and doing that at the same time as ModItemFromMarc. But again, without a strong regression test suite of that particular part, I went with the easy way out and changed as little as I could with my patch, behavior-wise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 01:42:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 00:42:37 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-MuTT3qcdE3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70272|0 |1 is obsolete| | --- Comment #9 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70527&action=edit Bug 10032: (Follow-up) Move title attribute to button container This patch modifies the "Close basket" button markup so that the title attribute on a disabled button is added to the button wrapper <div> instead of the <a> tag. This allows the title attribute tooltip to appear when the cursor is hovered over the button. To test, follow the original patch's test plan and confirm that when the "Close basket" button is disabled, hovering the mouse over the button triggers the title attribute tooltip. Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 01:42:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 00:42:33 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-Hali4gYl5e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70250|0 |1 is obsolete| | --- Comment #8 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70526&action=edit Added disabled "Close this basket" button when uncertain prices are present. Note that whilst this has a "title" attribute, there is no tooltip shown because JQueryUI disabled buttons don't get DOM events. https://bugs.koha-community.org/show_bug.cgi?id=10032 Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 01:43:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 00:43:37 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-2RhghVgVzO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |charlotte.cordwell123 at gmail | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 01:46:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 00:46:41 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-sHy6EBhKKw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #21 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Jonathan Druart from comment #20) > So actually we are trying to remove a warning because there are wrong calls > in opac-main. > The dashboard's info should be fetched only if a patron is logged in. > I did this change on bug 12001 already. > I am suggesting a new patch to avoid the change of the subroutine's > prototype (which is wrong instead, but let remove the subroutine instead) > and future conflict (with bug 19933). > > Deal? While the problem that triggered this code change is that, and your simpler change would suffice, I was hoping for a more thorough fix of the checkoverdues function. Granted, this is only an intermediary step towards one that deals with Koha::Checkouts filtered on is_overdue. If you prefer, I could attempt to Koha::Checkouts the checkoverdues accessing areas of code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:09:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:09:23 +0000 Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-4TB85UphOc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:09:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:09:25 +0000 Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-i5ajiV6DwN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69454|0 |1 is obsolete| | --- Comment #2 from Grace <gracesmythh at gmail.com> --- Created attachment 70528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70528&action=edit Bug 16603: When processing uploaded offline circulation file, "apply directly" option fails This patch is a temporary mitigation of whatever the real problem is. The patch hides the "Apply directly" button so that the option isn't available. To test, apply the patch and generate a .koc file with some transactions. Upload the file via Circulation -> Offline circulation file upload. After the file is uploaded, you should see only a "Add to offline circulation queue" button, which should work correctly. Signed-off-by: Grace Smyth <gracesmythh at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:13:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:13:07 +0000 Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not links to biblio In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19825-70-wQ8ZMSvSCx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:13:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:13:09 +0000 Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not links to biblio In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19825-70-g5KA7SXNqk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69838|0 |1 is obsolete| | --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70529&action=edit Bug 19825: Make links to biblios on pending offline circulation page working again 0) Do not apply the patch 1) Have pending offline circulation operations - you can use standalone application, Firefox add-on or built-in offline circulatin client - it does not matter in this case 2) Go to Circulation -> pending offline circulation actions 3) You see all barcode in red and without links - even if the item and biblio existed 4) Apply the patch 5) Repeat 1-3, now you should see the links to biblio on existing items Note: Don't add non-existent barcodes actions and payment actions unti bug 19771 is not fixed Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:24:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:24:55 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-aisZHSbuxW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #18 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Katrin Fischer from comment #17) > It's missing steps. > > - you need to update the po files after the patch was applied > - you have to check that the string got not marked as 'fuzzy' > - you have to reinstall the language > > Only then the test gives you a correct result. So in short, the test plan in comment #8 combined with this should work. However, this is still Failed QA for not passing the koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:34:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:34:14 +0000 Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display in opac or staff side In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19677-70-88ByrRcagS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69850|0 |1 is obsolete| | --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70530&action=edit Bug 19677 - Properly escape enumchrom/serialseq data Some serial issues use angle brackets for denoting certain data. Currently this is not displayed in Koha. This patch escapes the data so that angle brackets will display. To test: 1 - Add an enumchron field to an item containg angle brackets: "This is a <test>" 2 - View the record in the staff and opac, not the field displays as: "This is a" 3 - Apply patch 4 - Note full text now displays Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:39:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:39:36 +0000 Subject: [Koha-bugs] [Bug 19584] Inventory: Trivial interface improvements In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19584-70-i6jjH2lOW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:39:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:39:39 +0000 Subject: [Koha-bugs] [Bug 19584] Inventory: Trivial interface improvements In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19584-70-huOaXOAVzF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69739|0 |1 is obsolete| | --- Comment #6 from Grace <gracesmythh at gmail.com> --- Created attachment 70531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70531&action=edit Bug 19584: Check compare barcodes box when uploading barcodes This patch makes two trivial changes in the inventory interface: [1] If you have uploaded a barcode file, the compare barcodes checkbox is automatically checked. In most cases this will be the option the user wants. The compare will report missed items on the shelf. [2] If the compare barcodes checkbox is checked, the Skip items on loan- checkbox is automatically checked. This again is often desirable. If you compare, you normally are not interested in seeing items reported missing while they are checked out. Test plan: [1] Upload a barcode file on inventory. Is the compare checked? [2] Toggle compare. Does 'skip items on loan' change accordingly? Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Grace Smyth <gracesmythh at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:43:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:43:31 +0000 Subject: [Koha-bugs] [Bug 5993] tags not searchable In-Reply-To: <bug-5993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5993-70-JNTGBJqCd6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5993 lulihua at ibwya.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lulihua at ibwya.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:53:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:53:18 +0000 Subject: [Koha-bugs] [Bug 19975] New: Tag cloud searching does not working Message-ID: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Bug ID: 19975 Summary: Tag cloud searching does not working Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lulihua at ibwya.net QA Contact: testopia at bugs.koha-community.org Created attachment 70532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70532&action=edit Screenshot of the error >From OPAC click Tag cloud-->click any of the tags that listed will return the following error No results found! You did not specify any search criteria. Error: Koha::ItemType::get_column generated this error: DBIx::Class::Row::get_column(): No such column 'translated_description' on Koha::Schema::Result::Itemtype at /usr/share/koha/lib/Koha/Object.pm line 307 but if click the "GO" button again, will display the results correctly! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:55:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:55:03 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-mYmZRbwWb1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 lulihua at ibwya.net changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |lib.ibwya.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 02:57:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 01:57:45 +0000 Subject: [Koha-bugs] [Bug 19743] Header and Footer should be updated on each item for checkin / checkout / renewal notices In-Reply-To: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19743-70-YY3Y7J5aAw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terauhina.jackson at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 03:05:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 02:05:16 +0000 Subject: [Koha-bugs] [Bug 19743] Header and Footer should be updated on each item for checkin / checkout / renewal notices In-Reply-To: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19743-70-tAL9oEpYLh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69482|0 |1 is obsolete| | Attachment #69484|0 |1 is obsolete| | --- Comment #3 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70533&action=edit Bug 19743 - Header and Footer should be updated on each item for checkin / checkout / renewal notices When generating the checkout notice for a patron we only update the section in between the '---' tags For template toolkit purposes it means we cannot affect the content based on more than a single item. For instance, we want to add the total cost of all items checked out. Test Plan: 1) Add "Thank you for visiting <<branches.branchname>>." to the bottom of the checkout notice. Below the second '----'. 2) Check out an item to a patron to generate that notice 3) Note the branch name in the notice 4) Update the branch name in the branches editor, change it to something else 5) Check out a 2nd item to that patron 6) Notice the items list updated, but the branch name did not 7) Apply this patch 8) Check out a 3rd item to that patron 9) Notice the branch name updated this time Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 03:05:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 02:05:19 +0000 Subject: [Koha-bugs] [Bug 19743] Header and Footer should be updated on each item for checkin / checkout / renewal notices In-Reply-To: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19743-70-vmlr3PlZdz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743 --- Comment #4 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70534&action=edit Bug 19743 - Unit Tests Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 03:11:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 02:11:35 +0000 Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a barcode file In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19585-70-csA1kgDTbg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69154|0 |1 is obsolete| | --- Comment #6 from jwayway at hotmail.com --- Created attachment 70535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70535&action=edit Bug 19585: Inventory: Allow additional separators in a barcode file This patch makes \n, \r, |, comma, semicolon and hyphen ('-') all valid separators between barcodes passed to inventory. An additional grep removes empty barcodes. (Note: The grep looks for at least one non-whitespace character. We could be more specific, but this allows for more flexibility like testing with alphanumeric barcodes etc.) Test plan: Upload a barcode file that contains various allowed separators. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jenny Way <jwayway at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 03:12:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 02:12:18 +0000 Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a barcode file In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19585-70-pJtQjbmJs2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwayway at hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 03:16:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 02:16:23 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-ZnAqHWBoFM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #1 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70536&action=edit Bug 19832:Turn on EnhancedMessagingPreferences by default for new installations 1)Create a new installation 2)On staff go adminisation --> and search EnchancedMessagingPreferences 3)Check that it is automaticaly on allow. If it is the it has worked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 03:16:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 02:16:21 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-Kp7LBjMSyk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 03:27:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 02:27:33 +0000 Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) In-Reply-To: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19974-70-MEvTip4rIX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 --- Comment #3 from Charles Farmer <charles.farmer at inlibro.com> --- I made a mistake describing what happens at point 8.2 of the test plan: the item _will_ surely be marked as lost, make no mistake about that. If you filled information inside additem.pl's form, it will definitely have an impact on the item you were editing (i.e. you _should_ see the item marked as lost in your account and on the item's page). What's missing from BZ12363 is the _LostItem_ logic that should happen right after an item is newly marked as lost. My apologies for the misunderstanding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 03:30:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 02:30:01 +0000 Subject: [Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields In-Reply-To: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18878-70-UfBMfZExfZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 03:30:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 02:30:03 +0000 Subject: [Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields In-Reply-To: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18878-70-EoeBIBBaU7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 --- Comment #2 from Grace <gracesmythh at gmail.com> --- Created attachment 70537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70537&action=edit Bug 18878: Align labels in item form to the right Test Plan [1.] Search for an item and click on it [2.] Press the edit button to edit an item [3.] Notice that the labels are aligned to the left and very far away from the boxes [4.] Load the patch and now notice that the labels are closer to the boxes and are easier to read -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 03:53:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 02:53:28 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6918-70-0ijn3SDc9V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Keywords| |Academy -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:08:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:08:44 +0000 Subject: [Koha-bugs] [Bug 19179] Email option for SMSSendDriver is not documented as a valid setting In-Reply-To: <bug-19179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19179-70-Cv1K8rjXXv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19179 --- Comment #1 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70538&action=edit Bug 19179: Email option for SMSSendDriver is not documented as a valid setting 1) Apply patch. 2) Go to Administration --> search SMSSendDriver 3) Check if this message is at th end of the box:"If you would prefer to receive SMS via E-mail set SMSSendDriv -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:08:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:08:27 +0000 Subject: [Koha-bugs] [Bug 19179] Email option for SMSSendDriver is not documented as a valid setting In-Reply-To: <bug-19179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19179-70-XYIlYbVAJ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19179 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:10:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:10:19 +0000 Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19818-70-lDnNb2wUd4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:10:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:10:22 +0000 Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19818-70-Q630QefkbL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 --- Comment #3 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70540&action=edit Bug 19818: Added id's to the li tags for labels To test: 1)Go to the screen: /cgi-bin/koha/members/moremember.pl 2)On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:10:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:10:05 +0000 Subject: [Koha-bugs] [Bug 19179] Email option for SMSSendDriver is not documented as a valid setting In-Reply-To: <bug-19179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19179-70-pdBk8aCSXP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19179 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70538|0 |1 is obsolete| | --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70539&action=edit Bug 19179: Email option for SMSSendDriver is not documented as a valid setting 1) Apply patch. 2) Go to Administration --> search SMSSendDriver 3) Check if this message is at th end of the box:"If you would prefer to receive SMS via E-mail set SMSSendDriver to E-mail " -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:15:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:15:26 +0000 Subject: [Koha-bugs] [Bug 17869] Don' t show pick-up library for holds in OPAC account when there is only one branch In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17869-70-EPNhaq9491@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:15:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:15:28 +0000 Subject: [Koha-bugs] [Bug 17869] Don' t show pick-up library for holds in OPAC account when there is only one branch In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17869-70-rivaaZwzw4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 --- Comment #1 from Grace <gracesmythh at gmail.com> --- Created attachment 70541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70541&action=edit Bug 17869 Holds location removal Test Plan [1.] Type in browser http://localhost:8080/ (If you aren't logged in then log in) [2.] Then search for anything and click on the link 'Place hold' which is directly underneath the stars for an item [3.] Notice that there is a pick up location with only one location [4.] Load the patch and now notice that there is no location (as it is not necessary with only one location) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:22:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:22:15 +0000 Subject: [Koha-bugs] [Bug 18083] Don't show 'library' selection on popular titles page for single-branch libraries In-Reply-To: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18083-70-RStciaszxW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:22:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:22:18 +0000 Subject: [Koha-bugs] [Bug 18083] Don't show 'library' selection on popular titles page for single-branch libraries In-Reply-To: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18083-70-eUqrHWe2gM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 --- Comment #1 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70542&action=edit Bug 18083: Don't show 'library' selection on popular titles page for single-branch libraries This patch hides the search filter labelled "From" that offers you to select a library branch which is located on the 'popular titles' page on the OPAC. It is hidden when the library only has one branchas it would be unneccessary to have an option for other branches when there is only one. Test Plan: 1) Make sure you have a single-branch library 2) Make sure OPACTopIssue is allowed in the OPAC preferences 3) In the OPAC, got to 'Most Popular' page 4) Check that there is no "From" filter in the refine search 5) Create a new branch so that you have more than one branch 6) Check that there is a "From" filter in the refine search on the Most Popular page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:33:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:33:44 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19856-70-9Wa8yzFbsy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:33:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:33:47 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19856-70-oEwM4894DN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 --- Comment #1 from jwayway at hotmail.com --- Created attachment 70543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70543&action=edit Bug 19856: Improve styling of reports sidebar Test Plan 1. Open tools page and click on any of the links with a sidebar 2. Note the layout of the sidebar 3. Open reports page and click on any of the links with a sidebar 4. All the sidebars should have the same layout as the tools one -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:45:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:45:31 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6918-70-9lKXqz6xvO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |zoebennett1308 at gmail.com --- Comment #34 from Zoe Bennett <zoebennett1308 at gmail.com> --- I tested the patch by setting On Shelf Holds to "If all unavailable" and then "If any unavailable". I set 7-Not for Loan to 'ordered' and was still unable to place a hold on the order. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:46:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:46:19 +0000 Subject: [Koha-bugs] [Bug 19839] invoice.pl warns about bad variable scope In-Reply-To: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19839-70-Jbo940Okpj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 04:46:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 03:46:21 +0000 Subject: [Koha-bugs] [Bug 19839] invoice.pl warns about bad variable scope In-Reply-To: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19839-70-co2yitHJv0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839 --- Comment #1 from Grace <gracesmythh at gmail.com> --- Created attachment 70544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70544&action=edit Bug 19839: Removed Warning Test Plan [1.] Check the patch to see that I have removed: $template->param( uncertainprices => 1 ); from line 204 as Mr Druart has instructed to do (to get to the patch see the comment above by Mr Druart) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 05:03:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 04:03:10 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-5kNLmQdGOP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 05:03:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 04:03:12 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-BE1Kqg9dmB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70545&action=edit Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn 1)apply patch 2) go into administration --> search for OPACSearchForTitleIn 3) *click to edit* 4) look at the link and read the google scholar one. 5) check that the start link is https://scholar.google.com. 6) http://www.scholar.google is incorrect -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 06:01:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 05:01:00 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-ZqEftlccz0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 --- Comment #22 from M. Tompsett <mtompset at hotmail.com> --- > (In reply to Jonathan Druart from comment #20) > > The dashboard's info should be fetched only if a patron is logged in. Re-read checkoverdue code... The problem case is "or return". Tweak to return (0,{}); perhaps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 08:02:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 07:02:05 +0000 Subject: [Koha-bugs] [Bug 19976] New: data restoration in newly installed koha 17.11.X Message-ID: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19976 Bug ID: 19976 Summary: data restoration in newly installed koha 17.11.X Change sponsored?: --- Product: Koha Version: 17.11 Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: rasheed at psmchs.edu.sa QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Dear Experts I have installed koha 17.11.X and try to restore data backup taken from koha 16.05.X with following steps given below: Database Restoration command, mysql -uroot -p koha_library < koha_library.sql [Check name of your source Koha database] koha_library - name of database in new installation koha.sql - name of database in old installation Enter the MySQL root password. 4. Upgrade Database Schema Database schema of old Koha should upgrade to new one. Apply following commands in a terminal, sudo su koha-upgrade-schema library 5. Rebuild the Zebra Index. Apply following command in a terminal, sudo koha-rebuild-zebra -v -f library When I try to go staff interface the installation begins after Web installer ? Selecting default settings try to import, installation stuck with the error given below: Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_library.search_field' doesn't exist at /usr/share/koha/lib/Koha/Objects.pm line 110 For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 09:42:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 08:42:24 +0000 Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display in opac or staff side In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19677-70-1Y6RLhRYSb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Switching to Signed off - thx, Charlotte! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 09:56:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 08:56:36 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-5V1UINrPXa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 09:56:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 08:56:39 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-2sKHaGG7nY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70545|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70546&action=edit Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn 1)apply patch 2) go into administration --> search for OPACSearchForTitleIn 3) *click to edit* 4) look at the link and read the google scholar one. 5) check that the start link is https://scholar.google.com. 6) http://www.scholar.google is incorrect Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 10:12:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 09:12:57 +0000 Subject: [Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields In-Reply-To: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18878-70-Qmy5whqe1F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 10:13:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 09:13:00 +0000 Subject: [Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields In-Reply-To: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18878-70-WoKLTLJB06@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70537|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70547&action=edit Bug 18878: Align labels in item form to the right Test Plan [1.] Search for an item and click on it [2.] Press the edit button to edit an item [3.] Notice that the labels are aligned to the left and very far away from the boxes [4.] Load the patch and now notice that the labels are closer to the boxes and are easier to read Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 10:19:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 09:19:26 +0000 Subject: [Koha-bugs] [Bug 19977] New: Local Use tab in systempreferences tries to open text editor' s temporary files, and die Message-ID: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Bug ID: 19977 Summary: Local Use tab in systempreferences tries to open text editor's temporary files, and die Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Steps to reproduce: 1. Open koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Observe the error: Can't use string ("b0VIM 8.0") as a HASH ref while "strict refs" in use at /home/koha/koha/admin/systempreferences.pl line 413. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 10:24:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 09:24:04 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-oJpj7nQEwC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 10:23:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 09:23:53 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-2wI4OzP0cX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 70548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70548&action=edit Bug 19977: Open only .pref files in Local Use tab (sysprefs) Test plan: 1. Open .../prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Confirm that the page works normally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:13:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:13:46 +0000 Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19494-70-J10M7KhCRw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:14:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:14:19 +0000 Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC exceptions and raise Koha::Exceptions In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19828-70-htZyInx5vw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:14:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:14:21 +0000 Subject: [Koha-bugs] [Bug 19871] Use new exceptions Koha::Exceptions::Object:: DuplicateID and FKConstraint In-Reply-To: <bug-19871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19871-70-FqqCoHhDjX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19871 Bug 19871 depends on bug 19828, which changed state. Bug 19828 Summary: Koha::Object->store should catch DBIC exceptions and raise Koha::Exceptions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:14:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:14:20 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16330-70-4ebevq2aKn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Bug 16330 depends on bug 19828, which changed state. Bug 19828 Summary: Koha::Object->store should catch DBIC exceptions and raise Koha::Exceptions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:14:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:14:57 +0000 Subject: [Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml In-Reply-To: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17951-70-6xGKWxJIio@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |FIXED --- Comment #22 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:15:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:15:47 +0000 Subject: [Koha-bugs] [Bug 19744] Move template JavaScript to the footer: Offline circulation In-Reply-To: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19744-70-rTLH6D3snh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:15:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:15:48 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17858-70-YpXLewbBFR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug 17858 depends on bug 19744, which changed state. Bug 19744 Summary: Move template JavaScript to the footer: Offline circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:16:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:16:04 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17858-70-p4l2VERyKj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug 17858 depends on bug 19753, which changed state. Bug 19753 Summary: Move template JavaScript to the footer: Acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:16:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:16:04 +0000 Subject: [Koha-bugs] [Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2 In-Reply-To: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19754-70-khYYXPDdS5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Bug 19754 depends on bug 19753, which changed state. Bug 19753 Summary: Move template JavaScript to the footer: Acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:16:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:16:04 +0000 Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer: Acquisitions In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19753-70-cIZkYpn7Q5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:16:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:16:04 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-wdWNUcAJQD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Bug 19755 depends on bug 19753, which changed state. Bug 19753 Summary: Move template JavaScript to the footer: Acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:16:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:16:28 +0000 Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition:: Fund(s) In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19826-70-x7kn8krnnc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #31 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:16:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:16:29 +0000 Subject: [Koha-bugs] [Bug 19661] Funds endpoint In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-OOlBrhkYaS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Bug 19661 depends on bug 19826, which changed state. Bug 19826 Summary: Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition::Fund(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:17:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:17:09 +0000 Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the footer: The rest In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19608-70-C1f3TDCak5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:17:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:17:09 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17858-70-Oqh3drdkuF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug 17858 depends on bug 19608, which changed state. Bug 19608 Summary: Move admin templates JavaScript to the footer: The rest https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:17:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:17:09 +0000 Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the footer: Patrons and circulation In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19603-70-RtnkK5Jzss@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 Bug 19603 depends on bug 19608, which changed state. Bug 19608 Summary: Move admin templates JavaScript to the footer: The rest https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:17:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:17:10 +0000 Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer: Cataloging In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19623-70-InJuB1wtLM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Bug 19623 depends on bug 19608, which changed state. Bug 19608 Summary: Move admin templates JavaScript to the footer: The rest https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:17:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:17:33 +0000 Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer: Cataloging In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19623-70-7ObZTQHFMG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:17:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:17:34 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17858-70-UZjFcviAtR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug 17858 depends on bug 19623, which changed state. Bug 19623 Summary: Move template JavaScript to the footer: Cataloging https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:18:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:18:04 +0000 Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if categorycode is invalid In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19841-70-lPJNGDHe0E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |nick at bywatersolutions.com --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:18:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:18:04 +0000 Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16330-70-tDY8f92Q6v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Bug 16330 depends on bug 19841, which changed state. Bug 19841 Summary: AddMember should raise an exception if categorycode is invalid https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:06 +0000 Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the footer: Patrons and circulation In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19603-70-9fvogWVlZs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:07 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17858-70-pdiXkGH3lT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug 17858 depends on bug 19603, which changed state. Bug 19603 Summary: Move admin templates JavaScript to the footer: Patrons and circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:07 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-aK7drTOQwz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Bug 19641 depends on bug 19603, which changed state. Bug 19603 Summary: Move admin templates JavaScript to the footer: Patrons and circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:34 +0000 Subject: [Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace In-Reply-To: <bug-17728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17728-70-5NCDI1YhU9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 Bug 17728 depends on bug 19300, which changed state. Bug 19300 Summary: Move C4::Reserves::OPACItemHoldsAllowed to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:35 +0000 Subject: [Koha-bugs] [Bug 19297] Standardize "can place hold" calculations In-Reply-To: <bug-19297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19297-70-Juvr5aaS9d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19297 Bug 19297 depends on bug 19300, which changed state. Bug 19300 Summary: Move C4::Reserves::OPACItemHoldsAllowed to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:35 +0000 Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19301-70-EmFs31TLv2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301 Bug 19301 depends on bug 19300, which changed state. Bug 19300 Summary: Move C4::Reserves::OPACItemHoldsAllowed to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:35 +0000 Subject: [Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest In-Reply-To: <bug-19302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19302-70-yHQ7zJzUxg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Bug 19302 depends on bug 19300, which changed state. Bug 19300 Summary: Move C4::Reserves::OPACItemHoldsAllowed to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:34 +0000 Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to the Koha namespace In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19300-70-bg2ujRm3jx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |nick at bywatersolutions.com Status|Pushed to Master |RESOLVED --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:53 +0000 Subject: [Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address In-Reply-To: <bug-19304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19304-70-MYktpIHZT7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Bug 19304 depends on bug 19303, which changed state. Bug 19303 Summary: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:52 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: <bug-16846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16846-70-LjeRoCCoSL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug 16846 depends on bug 19303, which changed state. Bug 19303 Summary: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:21:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:21:52 +0000 Subject: [Koha-bugs] [Bug 19303] Move C4::Members::GetFirstValidEmailAddress to Koha::Patron-> first_valid_email_address In-Reply-To: <bug-19303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19303-70-NzI0zlva0B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:22:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:22:07 +0000 Subject: [Koha-bugs] [Bug 19304] Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address In-Reply-To: <bug-19304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19304-70-iZNciYfuDE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:22:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:22:08 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: <bug-16846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16846-70-9EbYeUTPDP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug 16846 depends on bug 19304, which changed state. Bug 19304 Summary: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:24:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:24:20 +0000 Subject: [Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter In-Reply-To: <bug-19280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19280-70-O9AxCI4DHI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |nick at bywatersolutions.com --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:24:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:24:37 +0000 Subject: [Koha-bugs] [Bug 17833] _initilize_memcached() warns if errors In-Reply-To: <bug-17833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17833-70-3rZCMIogu5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:25:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:25:09 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: <bug-13660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13660-70-61FqjHQ083@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |FIXED --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:25:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:25:50 +0000 Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate In-Reply-To: <bug-11046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11046-70-MZ1JeIknc6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:30:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:30:13 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6918-70-1vi2CmkKzX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Zoe Bennett from comment #34) > I tested the patch by setting On Shelf Holds to "If all unavailable" and > then "If any unavailable". I set 7-Not for Loan to 'ordered' and was still > unable to place a hold on the order. What is the value of your "On order" status? It needs to be a negative number. In Koha this indicates that the item will be available for loan in the future. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:32:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:32:35 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: <bug-18570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18570-70-ZXwzh6BgjQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:35:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:35:47 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19856-70-iZGA2mNseb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jwayway at hotmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:36:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:36:32 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-cD64gpYY3i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |charlotte.cordwell123 at gmail |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:36:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:36:47 +0000 Subject: [Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields In-Reply-To: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18878-70-gg8fQjkEJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gracesmythh at gmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:36:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:36:56 +0000 Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19818-70-xI9fqD5ArZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |zoebennett1308 at gmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:37:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:37:04 +0000 Subject: [Koha-bugs] [Bug 18083] Don't show 'library' selection on popular titles page for single-branch libraries In-Reply-To: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18083-70-F5cJuzIPdn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |terauhina.jackson at gmail.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:37:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:37:11 +0000 Subject: [Koha-bugs] [Bug 17869] Don' t show pick-up library for holds in OPAC account when there is only one branch In-Reply-To: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17869-70-VQs9eIaie8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|oleonard at myacpl.org |gracesmythh at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:37:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:37:22 +0000 Subject: [Koha-bugs] [Bug 19839] invoice.pl warns about bad variable scope In-Reply-To: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19839-70-juQ4msz8EC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gracesmythh at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:37:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:37:48 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-jNvWhZyph9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |charlotte.cordwell123 at gmail |ity.org |.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 13:50:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 12:50:19 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6918-70-LNi2dSNr3e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Ordered should be -1 if the sample data was used. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:22:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:22:01 +0000 Subject: [Koha-bugs] [Bug 18944] ITEMTYPECAT description not correct is itemtype is using the same code In-Reply-To: <bug-18944-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18944-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18944-70-wPQ0O7XIGd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18944 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10937 Version|16.11 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 [Bug 10937] Advanced search: Hide itemtypes from search form & Group itemtypes together into one search option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:22:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:22:01 +0000 Subject: [Koha-bugs] [Bug 10937] Advanced search: Hide itemtypes from search form & Group itemtypes together into one search option In-Reply-To: <bug-10937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10937-70-rQUj9fVg2X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18944 [Bug 18944] ITEMTYPECAT description not correct is itemtype is using the same code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:23:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:23:56 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: <bug-17843-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17843-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17843-70-HyNsKvOkM3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 [Bug 19978] ITEMTYPECAT is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:23:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:23:56 +0000 Subject: [Koha-bugs] [Bug 19978] New: ITEMTYPECAT is broken Message-ID: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 Bug ID: 19978 Summary: ITEMTYPECAT is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 17843 Since commit 091d6c513bcbee224ff06477e79be48cea7fe825 Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:26:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:26:33 +0000 Subject: [Koha-bugs] [Bug 19979] New: Search.t fails on facet info with one branch Message-ID: <bug-19979-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19979 Bug ID: 19979 Summary: Search.t fails on facet info with one branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:26:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:26:44 +0000 Subject: [Koha-bugs] [Bug 19979] Search.t fails on facet info with one branch In-Reply-To: <bug-19979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19979-70-vmqWokyEec@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19979 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:27:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:27:13 +0000 Subject: [Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method In-Reply-To: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19830-70-cYcrlJt0UP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830 --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Fridolin SOMERS from comment #6) > Enhancement not pushed to 17.05.x I've changed my mind and push to 17.05.x for v17.05.08 in order to push Bug 19599 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:28:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:28:13 +0000 Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on large systems In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19599-70-KMri9gUniY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599 --- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Fridolin SOMERS from comment #12) > Depends on Bug 19830 that is not in 17.05.x I've changed my mind and push to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:29:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:29:00 +0000 Subject: [Koha-bugs] [Bug 19972] Holds to pull (pendingreserves.pl) should honor syspref " item-level_itypes" In-Reply-To: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19972-70-P7XCWcFr3y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70549&action=edit Bug 19972: pendingreserves.pl now honors syspref "item-level_itypes" And reflect that in the UI strings + variable names Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. 10. Apply this patch 11. Go to /cgi-bin/koha/circ/pendingreserves.pl 12. See that the displayed type now follows the syspref 13. Set syspref "item-level_itypes" to "specific item" 14. Go to /cgi-bin/koha/circ/pendingreserves.pl 15. See that the displayed type still follows the syspref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:29:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:29:19 +0000 Subject: [Koha-bugs] [Bug 19972] Holds to pull (pendingreserves.pl) should honor syspref " item-level_itypes" In-Reply-To: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19972-70-8VWaLk6swm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:30:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:30:24 +0000 Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on large systems In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19599-70-NDGW5hcvw2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599 --- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- I think not needed for 16.11.x because does not contain Bug 16966 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:32:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:32:18 +0000 Subject: [Koha-bugs] [Bug 19979] Search.t fails on facet info with one branch In-Reply-To: <bug-19979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19979-70-FeVPCtKm5g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19979 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:32:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:32:20 +0000 Subject: [Koha-bugs] [Bug 19979] Search.t fails on facet info with one branch In-Reply-To: <bug-19979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19979-70-kjEbFyUHjJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19979 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70550&action=edit Bug 19979: Fix get_facets_info test in Search.t The test should remove the holdingbranch key in the expected results when there is only one branch. See the logic in C4::Koha. Test plan: [1] Run Search.t on a database with multiple branches. [2] Run Search.t on a database with one branch. Without this patch the test would fail: Failed test '_get_facets_info returns the correct data'. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:33:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:33:01 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-SqmkwxjahW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70551&action=edit Bug 19978: Fix ITEMTYPECAT behaviour ITEMTYPECAT permits to group and hide item types at the OPAC (see bug 10937 for a complete description). Since commit 091d6c513bcbee224ff06477e79be48cea7fe825 Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes the code assume that they are item types. Before it just assigned undef to the description. Test plan: Create ITEMTYPECAT authorised values Assign an item type to this authorised value group Search for a item using this item type at the OPAC Without this patch applied you get: Can't call method "translated_description" on an undefined value at /home/vagrant/kohaclone/opac/opac-search.pl line 231. With this patch applied the search result is displayed. Make sure the original feature still works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:32:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:32:57 +0000 Subject: [Koha-bugs] [Bug 19978] ITEMTYPECAT is broken In-Reply-To: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19978-70-SfzGVui02Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:35:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:35:16 +0000 Subject: [Koha-bugs] [Bug 19979] Search.t fails on facet info with one branch In-Reply-To: <bug-19979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19979-70-SWXSdWymyR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19979 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:38:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:38:58 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: <bug-18822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18822-70-j7S6vJxZFM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #10) > + my $fixed_rec; > + eval { $fixed_rec = MARC::Record::new_from_xml( $set->{hits}->[$j], > 'UTF-8' ) }; > + $set->{hits}->[$j] = $fixed_rec unless $@; > > No way to know what to expect ? Is it from internal or external ? Do we have > properties of these external ones ? > And can we check ref($set->{hits}->[$j]) to see if it is already > MARC::Record ? We have a slightly larger issue here of sometimes returning MARC::Records and sometimes returning marcxml. I suppose we could test the type, or assume in this case always marcxml, this was the simplest band-aid, we will need to address the larger problem on another report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:49:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:49:18 +0000 Subject: [Koha-bugs] [Bug 19839] invoice.pl warns about bad variable scope In-Reply-To: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19839-70-yth7uAaZJI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:49:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:49:21 +0000 Subject: [Koha-bugs] [Bug 19839] invoice.pl warns about bad variable scope In-Reply-To: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19839-70-by1HGaENcz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70544|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70552&action=edit Bug 19839: Removed Warning Test Plan [1.] Check the patch to see that I have removed: $template->param( uncertainprices => 1 ); from line 204 as Mr Druart has instructed to do (to get to the patch see the comment above by Mr Druart) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:49:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:49:41 +0000 Subject: [Koha-bugs] [Bug 19839] invoice.pl warns about bad variable scope In-Reply-To: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19839-70-j09pZw5SnI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:49:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:49:36 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-ZOOVF7Ghvv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- I think the update needs to target only http://www.scholar.google.com Current code also updates bookfinder URL and breaks it (https seems to work, but requires keeping the 'www.') We can update both above links specifically so we don't hit any extra custom ones -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:54:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:54:01 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-kbQuI9LZ3z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:54:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:54:04 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-JzAaxGuprX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70536|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70553&action=edit Bug 19832: Turn on EnhancedMessagingPreferences by default for new installations Test plan: 1) Create a new installation 2) On staff go adminisation --> and search EnchancedMessagingPreferences 3) Check that it is automaticaly on allow. If it is the it has worked. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:54:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:54:19 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-VKvivwgWjn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:58:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:58:52 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19856-70-ZPss74FV9x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 14:58:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 13:58:54 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19856-70-ay3HLKdnch@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70543|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70554&action=edit Bug 19856: Improve styling of reports sidebar Test Plan 1. Open tools page and click on any of the links with a sidebar 2. Note the layout of the sidebar 3. Open reports page and click on any of the links with a sidebar 4. All the sidebars should have the same layout as the tools one Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:00:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:00:22 +0000 Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19818-70-NykN7OCVUS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:00:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:00:25 +0000 Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19818-70-Wt9fsySspN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70540|0 |1 is obsolete| | --- Comment #4 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70555&action=edit Bug 19818: Added id's to the li tags for labels To test: 1)Go to the screen: /cgi-bin/koha/members/moremember.pl 2)On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:24:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:24:25 +0000 Subject: [Koha-bugs] [Bug 18298] Allow enforcing password complexity In-Reply-To: <bug-18298-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18298-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18298-70-heLZWsAFIx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 [Bug 19514] No Password restrictions in onboarding tool patron creation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:24:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:24:25 +0000 Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool patron creation In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19514-70-2mNKRzRGtF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18298 --- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Ouch depends on Bug 18298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 [Bug 18298] Allow enforcing password complexity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:25:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:25:13 +0000 Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool patron creation In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19514-70-vfM1fOJjpk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 --- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Fridolin SOMERS from comment #16) > Pushed to 17.05.x for v17.05.08 I choose to revert since depends on new 17.11 feature Bug 18298 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:25:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:25:25 +0000 Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool patron creation In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19514-70-2xlO9ctSxk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:25:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:25:26 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18308-70-pN4Zf0LXh8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Bug 18308 depends on bug 19514, which changed state. Bug 19514 Summary: No Password restrictions in onboarding tool patron creation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:31:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:31:15 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-qU2kueYteG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #200 from Julian Maurice <julian.maurice at biblibre.com> --- test git bz edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:31:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:31:50 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-qhsLoX6RhS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #201 from Julian Maurice <julian.maurice at biblibre.com> --- test git bz edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:38:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:38:50 +0000 Subject: [Koha-bugs] [Bug 19106] Pop up MARC preview window appears when searching in Chrome, cannot be closed In-Reply-To: <bug-19106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19106-70-R35XbKCzxw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19106 Bosco <brothersteve24 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brothersteve24 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 15:40:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 14:40:02 +0000 Subject: [Koha-bugs] [Bug 19106] Pop up MARC preview window appears when searching in Chrome, cannot be closed In-Reply-To: <bug-19106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19106-70-QGd2gFtHpB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19106 Bosco <brothersteve24 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:00:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:00:40 +0000 Subject: [Koha-bugs] [Bug 19980] New: Omnibus: Update single-column templates to use Bootstrap grid Message-ID: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Bug ID: 19980 Summary: Omnibus: Update single-column templates to use Bootstrap grid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: dcook at prosentient.com.au, josef.moravec at gmail.com, misilot at fit.edu, nengard at gmail.com, testopia at bugs.koha-community.org Blocks: 14546 Templates in the staff client which are a single column can be easily converted from using YUI grids to using Bootstrap grids. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:00:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:00:40 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14546-70-NnZHibrMwL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:00:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:00:40 +0000 Subject: [Koha-bugs] [Bug 19931] Omnibus: Update popup window templates to use Bootstrap grid In-Reply-To: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19931-70-KpQqb4aLkh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19980 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:02:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:02:31 +0000 Subject: [Koha-bugs] [Bug 19981] New: Switch single-column templates to Bootstrap grid: Course reserves Message-ID: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Bug ID: 19981 Summary: Switch single-column templates to Bootstrap grid: Course reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: dcook at prosentient.com.au, josef.moravec at gmail.com, misilot at fit.edu, nengard at gmail.com, testopia at bugs.koha-community.org Blocks: 14546, 19980 There are three single-column templates in the Course Reserves module which can be updated to use Bootstrap: course-details.tt course-reserves.tt invalid-course.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:02:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:02:31 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-0F5Qu1M4i7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19981 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:02:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:02:31 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14546-70-Cx9875boBl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19981 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:06:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:06:26 +0000 Subject: [Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields In-Reply-To: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18878-70-kTy1qrhCpp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:06:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:06:28 +0000 Subject: [Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields In-Reply-To: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18878-70-QoL2wDTg5K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70547|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70556&action=edit Bug 18878: Align labels in item form to the right Test Plan [1.] Search for an item and click on it [2.] Press the edit button to edit an item [3.] Notice that the labels are aligned to the left and very far away from the boxes [4.] Load the patch and now notice that the labels are closer to the boxes and are easier to read Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:08:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:08:16 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-B6NzwIijzh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #202 from Julian Maurice <julian.maurice at biblibre.com> --- test git bz edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:21:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:21:08 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-iGHY3oaEso@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #35 from David Gustafsson <glasklas at gmail.com> --- Here is a github-diff that might be easier on the eyes: https://github.com/ub-digit/Koha/commit/8be850d2cdc93e5d121afa19c5eed1e1cc683f1c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:29:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:29:54 +0000 Subject: [Koha-bugs] [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves In-Reply-To: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19981-70-TjIzw2TI8d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:29:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:29:56 +0000 Subject: [Koha-bugs] [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves In-Reply-To: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19981-70-3zyC8YenBi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70557&action=edit Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves This patch updates three single-column course reserves templates to use the Bootstrap grid: - course-reserves.tt - The main Course Reserves page - course-details.tt - The detail view of an individual course - invalid-course.tt - The error page shown if you try to view course_reserves/course-details.pl directly without passing a course id in the URL - Also changed in this template: Error message has been wrapped in the standard "dialog alert" <div>. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:36:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:36:57 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-hfAki5ZcuR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70495|0 |1 is obsolete| | --- Comment #36 from David Gustafsson <glasklas at gmail.com> --- Created attachment 70558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70558&action=edit Bug 19575: Use canonical field names and resolve aliased fields Adjust elastic search mappings to more closely match Zebra equivalents resolving serveral issues with coded Zebra searches in templates and sorting of search results in UI. Also make field names in search strings case insensitive to accept case variations in template links and user input. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 16:38:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 15:38:19 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-OU0RIwJYG7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #37 from David Gustafsson <glasklas at gmail.com> --- Found one (hopefully) last place that needed case-adjustment. New diff: https://github.com/ub-digit/Koha/commit/a6fda51b59c65c2459d460fd374377b56b5f10cc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:03:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:03:46 +0000 Subject: [Koha-bugs] [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves In-Reply-To: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19981-70-l0lkQyi1tt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Missed: course.tt add_items-step1.tt add_items-step2.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:04:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:04:37 +0000 Subject: [Koha-bugs] [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves In-Reply-To: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19981-70-RECmsBL42A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70557|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70559&action=edit Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves This patch updates three single-column course reserves templates to use the Bootstrap grid: - course-reserves.tt - The main Course Reserves page - course-details.tt - The detail view of an individual course - course.tt - Editing a course - add_items-step1.tt - Adding items to a course, step 1 (scan barcode) - add_items-step2.tt - Adding items to a course, step 2 - invalid-course.tt - The error page shown if you try to view course_reserves/course-details.pl directly without passing a course id in the URL - Also changed in this template: Error message has been wrapped in the standard "dialog alert" <div>. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:11:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:11:11 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-QDlOiJsl72@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:11:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:11:11 +0000 Subject: [Koha-bugs] [Bug 19982] New: Switch single-column templates to Bootstrap grid: Patrons Message-ID: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 Bug ID: 19982 Summary: Switch single-column templates to Bootstrap grid: Patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 19641 Blocks: 19980 There are two single-column templates in the Patrons module which can be updated to use Bootstrap: discharges.tt members-update.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:11:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:11:11 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-qyRKbxyiZv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:21:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:21:04 +0000 Subject: [Koha-bugs] [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons In-Reply-To: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19982-70-Xu4zX90oVr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:21:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:21:06 +0000 Subject: [Koha-bugs] [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons In-Reply-To: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19982-70-PE66EfSzDH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70560&action=edit Bug 19982 - Switch single-column templates to Bootstrap grid: Patrons This patch updates two single-column patron module templates to use the Bootstrap grid: - discharges.tt - The list of pending discharges. One or more discharges must have been made via the OPAC. From the staff client home page, look for "Discharge requests pending." - members-update.tt - The list of pending patron updates. One or more updates must have been submitted via the OPAC. From the staff client home page, look for "Patrons requesting modifications." Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:26:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:26:58 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-AQA4Y4ZErU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #188 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 70561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70561&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:27:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:27:20 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-X4TElw1gFJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:27:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:27:38 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13560-70-AgA8GXmb0T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:27:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:27:40 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13560-70-0bkZPM3bSI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68540|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70562&action=edit Bug 13560 - Database changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:27:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:27:44 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13560-70-vETZQkPO3J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70563&action=edit Bug 13560 - Unit tests To test: 1 - apply all patches 2 - update database 3 - prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:27:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:27:48 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13560-70-mrejIEnOx4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70564&action=edit Bug 13560: Add an 'Add' option for marc modification templates Add/Update would update a field or create new if it existed, but didn't allow for creating new if the field existed. This patchset splits the options to 'Add & Update' so that 'Add' will always add a field and 'Update' will operate as it always has To test: 1 - Have a record with a known existing field (make a copy) 2 - Define a marc modification template that 'Add/update' on that field 3 - Define an 'Add/Update' on a field that doesn't exist 4 - Batch modify the copy of record using the above template 5 - Verify the existing field was updated 6 - Verify the non-existing field was updated 7 - Apply patch and update database 8 - Make another copy 9 - Modify the copy with the same template as above 10 - Should match initial modification 11 - Add a new rule to add a new field 12 - Modify using the updated template 13 - Ensure your new field is created 14 - Test various options in the modification tool 15 - prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:28:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:28:22 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13560-70-B9KWfBfy4y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- fixed the conflict, split the patches, added DB update to instructions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:47:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:47:26 +0000 Subject: [Koha-bugs] [Bug 15115] Editing item information on active course reserves should not be allowed. In-Reply-To: <bug-15115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15115-70-CpNtQx19gk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15115 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:52:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:52:21 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: <bug-19908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19908-70-aXoEwPmCtD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 acovaliov at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acovaliov at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 17:54:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 16:54:33 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-IQcwUkb6AF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 18:20:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 17:20:03 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-XZLuvN7rRR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 18:19:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 17:19:49 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-HNLW1D0JPX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69683|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70565&action=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 18:25:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 17:25:13 +0000 Subject: [Koha-bugs] [Bug 19969] Adding a manual restriction in memberentrypl with a date does not restrict the patron In-Reply-To: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19969-70-E4Z5SPWruv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19969 --- Comment #2 from Kelly McElligott <kelly at bywatersolutions.com> --- Katrin, I tried Jan 26th, but now am trying it on another site and not finding that I can replicate it. Let me dig further into this. Kelly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 18:29:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 17:29:41 +0000 Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible when it should In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12497-70-ZcpJVUSSxx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Chris, could you consider this for 16.11.x? We've just run into it and borrowers permission on opac-search-history.pl makes no sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 18:29:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 17:29:44 +0000 Subject: [Koha-bugs] [Bug 19983] New: Switch single-column templates to Bootstrap grid: Authorities Message-ID: <bug-19983-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Bug ID: 19983 Summary: Switch single-column templates to Bootstrap grid: Authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 19785, 19786 Blocks: 19980 There are several single-column templates in the Authorities module which can be updated to use Bootstrap: authorities-home.tt authorities.tt blinddetail-biblio-search.tt detail.tt merge.tt searchresultlist.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786 [Bug 19786] Move template JavaScript to the footer: Authorities, part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 18:29:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 17:29:44 +0000 Subject: [Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2 In-Reply-To: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19786-70-Ka5Uc48l65@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 18:29:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 17:29:44 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-XyHm4Bey7c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 18:29:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 17:29:44 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-Ky7pMVeYXQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 18:38:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 17:38:13 +0000 Subject: [Koha-bugs] [Bug 19984] New: Software error Cant call method Message-ID: <bug-19984-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19984 Bug ID: 19984 Summary: Software error Cant call method Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kachomanic at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 70566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70566&action=edit Image of error My koha installation is working fine on local network but if I try to access via public network I had that error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 19:11:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 18:11:15 +0000 Subject: [Koha-bugs] [Bug 19969] Adding a manual restriction in memberentrypl with a date does not restrict the patron In-Reply-To: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19969-70-AyEx6xSbKE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19969 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- If you accidentally picked a date in the past that could explain - but not sure if that's possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 19:35:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 18:35:18 +0000 Subject: [Koha-bugs] [Bug 19985] New: TestBuilder.t fails if default circ rule exists Message-ID: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Bug ID: 19985 Summary: TestBuilder.t fails if default circ rule exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Set a default circ rule vagrant at kohadevbox:kohaclone(BUGFUN)$ prove t/db_dependent/TestBuilder.t t/db_dependent/TestBuilder.t .. 1/13 Violation of unique constraint in DefaultCircRule at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 241. # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1. t/db_dependent/TestBuilder.t .. 3/13 # Failed test 'Build all sources' # at t/db_dependent/TestBuilder.t line 84. t/db_dependent/TestBuilder.t .. 12/13 # Looks like you failed 1 test of 13. t/db_dependent/TestBuilder.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/13 subtests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 19:35:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 18:35:39 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19985-70-my9EcT1otX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 20:35:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 19:35:43 +0000 Subject: [Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-6EuRkQOeO4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70485|0 |1 is obsolete| | Attachment #70486|0 |1 is obsolete| | --- Comment #23 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70567&action=edit Bug 19938: Bad return value triggers noise TEST PLAN --------- 0) back up plack error log if you care. 1) Run these on your kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. However, the log file will have noise. 2) Run these on your kohadevbox: git bz apply 19938 restart_all echo | sudo tee /var/log/koha/kohadev/plack-error.log sudo koha-shell -c bash kohadev prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/www/search_utf8.t ./misc/cronjobs/staticfines.pl exit They will all pass or run without error. This time the log file will have no noise. 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 20:38:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 19:38:43 +0000 Subject: [Koha-bugs] [Bug 19938] C4::Overdues::checkoverdues has inconsistent return type In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-zylTjo5qLL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Refactor |C4::Overdues::checkoverdues |C4::Overdues::checkoverdues |has inconsistent return | |type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 20:39:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 19:39:45 +0000 Subject: [Koha-bugs] [Bug 19938] C4::Overdues::checkoverdues has inconsistent return type In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-tM8zrHbZaF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70489|0 |1 is obsolete| | --- Comment #24 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70489 Bug 19938: Do not fetch dashboard's info if no logged in Fixing the return type makes this check not necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 20:48:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 19:48:19 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18786-70-8ztOcu447C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #19) > Found it - it was bug 5620! That bug doesn't do what this one does. That one is specifically about SIP payment types. Moreover, I see some issues with it since it hardcodes a bunch of payment type values that aren't specified by the SIP2 protocol : \ If this one gets pushed I'd be willing to assist in fixing up 5620. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 20:49:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 19:49:19 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5620-70-rtwIX6Ucwu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 --- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Charles Farmer from comment #38) > Is there any consensus on how to move this bug forward? > > One of the implementation touches on SIP, the other does not. Are we sure > they're really duplicates? I don't consider these bugs to be duplicates. The big issue I think we have with this one is that it hard codes a set up SIP payment values that are not in the SIP2 protocol specification. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 20:58:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 19:58:05 +0000 Subject: [Koha-bugs] [Bug 19938] C4::Overdues::checkoverdues has inconsistent return type In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-2xXgzlzHKl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70489|1 |0 is obsolete| | --- Comment #25 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70489 Bug 19938: Do not fetch dashboard's info if no logged in Sorry. Let's include this optimization which will reduce output times. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:02:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:02:23 +0000 Subject: [Koha-bugs] [Bug 19938] C4::Overdues::checkoverdues has inconsistent return type In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-SsKb8lir44@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #26 from M. Tompsett <mtompset at hotmail.com> --- Both can be applied together or independently. Both solve the warning issue. However, JD's has the added advantage of also trimming unnecessary calls, meaning fast page output time. Mine is short and pretty, bringing consistency to the checkoverdues return value, but does nothing to trim times. Test plan is comment #23. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:17:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:17:24 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-O6zZLj4COu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:17:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:17:26 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-4TobFSH2Mw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 --- Comment #5 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70568&action=edit Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn Amended the sql statement so it only affects the http://www.scholar.google.com url Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:28:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:28:59 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-3tvqs1qxcQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #3 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70569&action=edit Bug 19831:Turn on EnhancedMessagingPreferences by default for new installations 1)Create a new installation 2)On staff go adminisation --> and search EnchancedMessagingPreferences 3)Check that it is automaticaly on allow. If it is the it has worked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:47:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:47:00 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18236-70-kFe3WpaA5L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:47:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:47:03 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18236-70-Cv4Vkmm9Vb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 --- Comment #1 from jwayway at hotmail.com --- Created attachment 70570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70570&action=edit Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_book -Kit = m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:49:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:49:45 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18236-70-D5abgkcyXI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70570|Bug-18236: Add classes to |Bug-18236: Add classes to description|material type Test plan: 1. |material type |Open a list of results 2. |Test plan: |Use fn+f12 to inspect |1. Open a list of results |element 3. Without patch it |2. Use fn+f12 to inspect |should show that the image |element |class is 'materialtype' 4. |3. Without patch |With patch the class should |it should show that the |have changed -Books = |image class is |mt_icon_book -Kit = m |'materialtype' | |4. With | |patch the class should have | |changed | |-Books = | |mt_icon_book | |-Kit = | |mt_icon_kit | |-Continuous | |resource = | |mt_icon_cresource | |-Mixed | |material = mixmaterial | |-Computer files = | | | |mt_icon_computer | |-Map = | |mt_icon_map | |-Score = | |mt_icon_score | |-Music = | |mt_icon_music | |OR | |1. Try | |using the classes in css to | |change the style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:53:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:53:38 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18236-70-GNIQg2C0vV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70570|0 |1 is obsolete| | --- Comment #2 from jwayway at hotmail.com --- Created attachment 70571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70571&action=edit Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_book -Kit = mt_icon_kit -Continuous resource = mt_icon_cresource -Mixed material = mixmaterial -Computer files = mt_icon_computer -Map = mt_icon_map -Score = mt_icon_score -Music = mt_icon_music OR 1. Try using the classes in css to change the style Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_bo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:55:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:55:34 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18236-70-DgV5AP1xZH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwayway at hotmail.com --- Comment #3 from jwayway at hotmail.com --- Bug-18236: Add classes to material type Test plan: 1. Open a list of results 2. Use fn+f12 to inspect element 3. Without patch it should show that the image class is 'materialtype' 4. With patch the class should have changed -Books = mt_icon_book -Kit = mt_icon_kit -Continuous resource = mt_icon_cresource -Mixed material = mixmaterial -Computer files = mt_icon_computer -Map = mt_icon_map -Score = mt_icon_score -Music = mt_icon_music OR 1. Try using the classes in css to change the style My commit message stuffed up so please use this test plan :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:55:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:55:44 +0000 Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron attributes" default on patron import In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18661-70-CwPYs7CArp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 21:55:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 20:55:46 +0000 Subject: [Koha-bugs] [Bug 18661] Make "Replace only included patron attributes" default on patron import In-Reply-To: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18661-70-M9ObuKnQrb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661 --- Comment #1 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70572&action=edit Made "Replace only included patron attributes" default on patron import Test Plan: 1) Go to the import patrons page and notice that "Replace all patron attributes" is selected by default in the Patron Attributes section. 2) Apply this patch 3) Go back to the import patrons page and notice that "Replace only included patron attributes" is delected by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 22:11:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 21:11:02 +0000 Subject: [Koha-bugs] [Bug 17883] Manage Patron Lists Permission incorrectly displaying hidden columns In-Reply-To: <bug-17883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17883-70-wUROGmYEwr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17883 --- Comment #1 from Grace <gracesmythh at gmail.com> --- Created attachment 70573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70573&action=edit User-with-permissions This is what it looks like when a user has all permissions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 22:12:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 21:12:17 +0000 Subject: [Koha-bugs] [Bug 17883] Manage Patron Lists Permission incorrectly displaying hidden columns In-Reply-To: <bug-17883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17883-70-QUMpMikN5I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17883 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gracesmythh at gmail.com --- Comment #2 from Grace <gracesmythh at gmail.com> --- Created attachment 70574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70574&action=edit User-without-permission This is what it looks like for a user without the permission - ?manage patron lists? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 22:32:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 21:32:21 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19221-70-aahU1J4KD8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 22:32:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 21:32:23 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19221-70-qhpDo4RH3z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 --- Comment #3 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70575&action=edit Onboarding tool says user need to be made superlibrarian I changed the "To give new patron superlibrarian permissions go to:" message to "To edit patron permissions, go to:". Please clarify if this is clearer or not. Test plan: 1) Apply patch 2) Go through the web installer 3) At the create koha administrator patron step, notice that at the bottom, there is a message saying "To edit patron permissions, go to:" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 22:44:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 21:44:18 +0000 Subject: [Koha-bugs] [Bug 17883] Manage Patron Lists Permission incorrectly displaying hidden columns In-Reply-To: <bug-17883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17883-70-jKLwk6xX0S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17883 --- Comment #3 from Grace <gracesmythh at gmail.com> --- Hi Christian, I tried to reproduce the bug, I had one user that was the super librarian and one that was a user without the permission to manage patron lists and I can't seem to see the bug and the problems the bug produces. Thanks :) P.S please ignore the previous screen shots I sent they were wrong -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 23:06:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 22:06:17 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-YBsOigWD7g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 23:06:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 22:06:20 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-WubkCff0zE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #1 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70576&action=edit Bug 19833: Kill the "biblios" " 1) Check files modules/about.tt, modules/acqui/booksellers.tt and modules/acqui/invoices.tt for typos nad check that there are no "biblio" and only "biblographic record". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 23:17:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 22:17:00 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19188-70-RUeFmmZlDa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 --- Comment #4 from jwayway at hotmail.com --- Created attachment 70577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70577&action=edit Bug-19188: Self checkout missing space for price Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. Login to localhost:8081 and issue a book 3. In OPAC give user fine by going to 'my account' at top right 4. Then under fines tab 'create manual invoice' 5. Make sure this amount is more than OPACFineNoRenenwals which can be changed under System prefernces 6. Back in localhost:8081, try renewing the book 7. Error 'Item cannot be checked out' should occur 8. Without patch the currency symbol and amount is together 9. With patch there should be a space in between -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 23:16:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 22:16:58 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19188-70-oPIkBK1RVr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 23:45:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 22:45:07 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-GZhIPlyUow@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 23:45:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 22:45:10 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-B7BIZGLSn4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #24 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70578&action=edit Bug 16486: [FOLLOW-UP] Show original date and timestamp for fines This patch has two columns in fines tables, one showing the original date and one showing the timestamp (when the patch was last updated) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 16 23:57:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 22:57:24 +0000 Subject: [Koha-bugs] [Bug 15554] Organize entries in ccl.properties In-Reply-To: <bug-15554-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15554-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15554-70-japkwG5osU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15554 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gracesmythh at gmail.com Status|NEW |Needs Signoff --- Comment #2 from Grace <gracesmythh at gmail.com> --- Hi David, I have checked ccl.properties and it seems like this bug has been patched and the code is organised. Thanks :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:11:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:11:05 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-cdPNHOb5Ew@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68302|0 |1 is obsolete| | --- Comment #25 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70579&action=edit Bug 16486: Display the timestamp for account payments/writeoffs To test: 1) Apply patch 2) Go to the patron account page, Fines tab 3) Click Account tab 4) Confirm timestamp shows next to payments and writeoffs 5) Go to Admin -> TimeFormat syspref, change the format 6) Refresh the fines page, confirm time format changes Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:12:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:12:35 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-J8UvkzOuhF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68303|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70580&action=edit Bug 16486: [FOLLOW-UP] Putting time in date column In reply to Comment 6, I have moved the time into a column separate from the description. Unfortunately the timestamp has the date and the time, so I figured it was easier to just have them in the same column and replace the original date column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:14:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:14:02 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-JkN405v44S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70581&action=edit Bug 19833: Kill the "biblios" Check the following files to see that all "biblio" or "biblio record" are changed to "bibliograhic records" modules/admin/admin-home.tt modules/admin/authtypes.tt modules/admin/checkmarc.tt modules/admin/preferences/authorities.pref modules/admin/preferences/cataloguing.pref modules/admin/preferences/circulation.pref modules/admin/preferences/opac.pref modules/admin/preferences/searching.pref modules/admin/preferences/serials.pref modules/admin/z3950servers.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:14:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:14:10 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-1kengBmwFX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68316|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70582&action=edit Bug 16486: [FOLLOW-UP] Adding timestamp to date in other places As suggested in Comment 7. The timestamp has also been added to printfeercpt.tt, printinvoice.tt, and opac-account.tt To test: 1) In Staff side, go to member account, go to Fines, go to Account tab 2) Click the Print button next to a payment 3) Confirm timestamp shows on print slip 4) Create a manual invoice 5) Go back to the Account tab 6) Click the Print button next to the invoice 7) Confirm timestamp shows on print slip 8) Log into OPAC 9) Go to your fines 10) Confirm timestamp shows Works as intended. Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:15:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:15:11 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-9t3FG5SLF7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70578|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70583&action=edit Bug 16486: [FOLLOW-UP] Show original date and timestamp for fines This patch has two columns in fines tables, one showing the original date and one showing the timestamp (when the patch was last updated) Fixed merge conflicts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:17:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:17:15 +0000 Subject: [Koha-bugs] [Bug 2601] Order fines by date and time In-Reply-To: <bug-2601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2601-70-tlNpn8lQs0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2601 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #8 from Aleisha Amohia <aleisha at catalyst.net.nz> --- I think this would be fixed by the patch from Bug 16486, which adds the timestamp as a column to fines tables, so it could be sorted on -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:22:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:22:29 +0000 Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17765-70-YxBXDwgiVx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 --- Comment #1 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70584&action=edit Bug 17765: Hid 'Holds' link on the 'Details' and 'Checkout' pages when the user does not have the permission to 'reserveforothers'. Test Plan: 1) With a user who has the permission to 'reserveforothers' check that the 'Holds' link is on the 'Details' and 'Check out' pages 2) Then with a user who does not have the permission to 'reserveforothers' check that on the 'Details' and 'Check out' pages there is no longer the 'Holds' link next to the 'Checkouts' and 'Fines & Charges' tabs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:34:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:34:36 +0000 Subject: [Koha-bugs] [Bug 19986] New: 'Server name' doesn' t appear as required when creating new z39.50/sru server Message-ID: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Bug ID: 19986 Summary: 'Server name' doesn't appear as required when creating new z39.50/sru server Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The server name field is a required field, but it is not red and does not say required like the other required fields. To reproduce: 1) Go to Admin -> z39.50/SRU servers 2) Make a new z39.50 server 3) Fill in the required fields (hostname, port, database) 4) Save the server 5) Notice the form does not submit, tells you that server name is required. The behaviour is the same for making a new SRU server too, so also needs to be fixed there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:34:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:34:41 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn' t appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-OLD3nAAPGN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:37:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:37:46 +0000 Subject: [Koha-bugs] [Bug 19987] New: If no z39.50/SRU servers, the z39.50/ SRU buttons should not show Message-ID: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Bug ID: 19987 Summary: If no z39.50/SRU servers, the z39.50/SRU buttons should not show Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In cataloguing and in authorities, we can import bibliographic records and authorities through z39.50/SRU servers, however if we have none set up (in system administration) then these buttons should not show. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:37:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:37:53 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-Cjdi1l5r6x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:59:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:59:10 +0000 Subject: [Koha-bugs] [Bug 3116] ISBD parsing does not preserve subfield order In-Reply-To: <bug-3116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3116-70-zZeFqG99fi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3116 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|aleisha at catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 00:58:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jan 2018 23:58:59 +0000 Subject: [Koha-bugs] [Bug 3116] ISBD parsing does not preserve subfield order In-Reply-To: <bug-3116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3116-70-FAdlLvTQMY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3116 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 02:03:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 01:03:02 +0000 Subject: [Koha-bugs] [Bug 9678] fields in wrong tab in books framework In-Reply-To: <bug-9678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9678-70-nom9hX21ak@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9678 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |aleisha at catalyst.net.nz --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Setting to Resolved as this no longer appears to be a bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 02:05:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 01:05:34 +0000 Subject: [Koha-bugs] [Bug 9661] Allow choosing of sort direction when editing lists In-Reply-To: <bug-9661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9661-70-fvh5dxv5ei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9661 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |aleisha at catalyst.net.nz Resolution|--- |FIXED --- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> --- This is no longer a bug, we choose sorting direction when creating and editing the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 02:13:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 01:13:51 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-YZb5MVIgrn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70581|0 |1 is obsolete| | --- Comment #3 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70585&action=edit Bug 19833: Kill the "biblios" Check the following files to see that all "biblio" or "biblio record" are changed to "bibliograhic records" modules/help/catalogue/search-history.tt modules/help/cataloguing/additem.tt modules/basket/sendbasket.tt modules/catalogue/labeledMARCdetail.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 02:30:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 01:30:54 +0000 Subject: [Koha-bugs] [Bug 19988] New: Change 'sex' to 'gender' Message-ID: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 Bug ID: 19988 Summary: Change 'sex' to 'gender' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com By Koha terminology guidelines, we should use gender instead of sex. Most cases have been fixed but I found one missed case: /koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.pl - Reproduce by changing gender for a user in OPAC, then viewing the patron modification request in the staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 02:30:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 01:30:59 +0000 Subject: [Koha-bugs] [Bug 19988] Change 'sex' to 'gender' In-Reply-To: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19988-70-fFsYYTs4im@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 02:49:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 01:49:08 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-XkseCMQN4R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #4 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70586&action=edit Bug 19833: Kill the "biblios" - most of the catalouging Check the following files to see that all "biblio" or "biblio record" are changed to "bibliograhic records" modules/cataloguing/addbooks.tt modules/cataloguing/value_builder/marc21_field_008_authorities.tt modules/cataloguing/value_builder/unimarc_field_110.tt modules/cataloguing/value_builder/unimarc_field_126a.tt modules/cataloguing/value_builder/unimarc_field_140.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 02:57:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 01:57:41 +0000 Subject: [Koha-bugs] [Bug 19989] New: opac-memberentry.pl has a FIXME that can be fixed Message-ID: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 Bug ID: 19989 Summary: opac-memberentry.pl has a FIXME that can be fixed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org There is a FIXME that was waiting for Bug 17091 to be pushed; it has now been pushed. Line 275 To test if the recommended fix works, submit a change to the user's details through the OPAC, then confirm that this request is the only request from the user back in the staff client (members/members-update.pl). New requests replace old requests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 02:57:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 01:57:47 +0000 Subject: [Koha-bugs] [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed In-Reply-To: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19989-70-0aDlLKln3v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:08:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:08:37 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-lQ8ajjZrK5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #5 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70587&action=edit Bug 19833 : Changing the "biblios" - most of admin To Test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/admin/authtypes.tt modules/admin/biblio_framework.tt modules/admin/preferences/authorities.pref modules/admin/preferences/cataloguing.pref modules/admin/preferences/circulation.pref modules/admin/preferences/opac.pref modules/admin/preferences/searching.pref modules/admin/preferences/serials.pref modules/admin/preferences/web_services.pref modules/admin/searchengine/elasticsearch/mappings.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:15:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:15:02 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-v5UNu9lcU6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #6 from Grace <gracesmythh at gmail.com> --- Created attachment 70588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70588&action=edit Bug 19833: Kill the "biblios" part 1 of the help To test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". Please enter the commit message for your changes. Lines starting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:17:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:17:55 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-6pay6djkJi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gracesmythh at gmail.com --- Comment #7 from Grace <gracesmythh at gmail.com> --- whoops the following files are these: (for part 1 of help) modules/help/admin/authtypes.tt modules/help/admin/biblio_framework.tt modules/help/admin/marc_subfields_structure.tt modules/help/admin/matching-rules.tt modules/help/admin/z3950servers.tt: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:29:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:29:47 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-0gGNdEelAi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #8 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70589&action=edit Bug 19833: Kill all the "bibilos" - help (continued) Check the following files to see that all "biblio" or "biblio record" are changed to "bibliograhic records" and there are no typos. modules/help/members/member-flags.tt modules/help/tools/batchMod.tt modules/help/tools/export.tt modules/help/tools/letter.tt modules/help/tools/marc_modification_templates.tt modules/help/tools/stage-marc-import.tt EXTRA I have updated the "add a new subscription so that it says "bibliographic record" instead of "record" 1) go into serials --> new subscription, there should be "record" and a box to type in the record. 2) apply th patch 3) it should now say "Bibliographic Record" instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:32:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:32:06 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-ucmbjmcDVq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #9 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70590&action=edit Bug 19833: Changing the "biblios" - most of reports To Test: Check the following files that all the "biblio" or "biblio record" are now written in full as "bibliographic record". modules/reports/acquisitions_stats.tt modules/reports/cash_register_status.tt modules/reports/catalogue_stats.tt modules/reports/issues_stats.tt modules/reports/reserves_stats.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:33:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:33:38 +0000 Subject: [Koha-bugs] [Bug 19990] New: opac/opac-discharge.pl has a FIXME that can be fixed Message-ID: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 Bug ID: 19990 Summary: opac/opac-discharge.pl has a FIXME that can be fixed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The variable $available is unnecessary and can be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:33:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:33:49 +0000 Subject: [Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed In-Reply-To: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19990-70-FmluzudsSu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:41:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:41:18 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-NSDr32PAU4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #10 from Grace <gracesmythh at gmail.com> --- Created attachment 70591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70591&action=edit Bug 19833: Changing the "biblios" acqui To test: Check the following files that all all "biblio" or "biblo record" are now writen in full as "bibliographic record". modules/acqui/addorderiso2709.tt:44 modules/acqui/booksellers.tt:3 modules/acqui/invoices.tt:3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:41:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:41:23 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-i6FQtteM2e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:41:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:41:26 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-mzJ9pV7JvR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70592&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch set adds a new colum to saved_sql 'combine_params' If set, parameters that have the same name and data type will only be asked for once from the user To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <<cat>> AS one, <<dog|branches>> AS two, <<dog|YES_NO>> as three, <<cat>> as four, <<dog|branches>> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are still asked for five parameters 6 - Edit report, note the 'Combine params' options, say YES!!!!! 7 - Re-run the report, you shoudl be asked for three parameters 8 - Verify the results reflect the supplied parameters 9 - Create a new report (perhaps something more substantive) 10 - Save with 'combine params' checke 11 - View in saved reports and see the new 'combine params' column 12 - Verify it is correctly set 13 - Run the report and verify correct results 14 - prove -v t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:42:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:42:05 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-IpDcZVQFRh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |nick at bywatersolutions.com Keywords| |Academy CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 03:43:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 02:43:32 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-sA0pKUeCb5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 04:00:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 03:00:05 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-95BFM4iZKW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #11 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70593&action=edit Bug 19833: Changing the "biblios" To Test: Check the following files that all the "biblio" or "biblio record" are now written in rull as "bibliographic record". modules/about.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 04:04:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 03:04:30 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-XDNvYGBdjD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #12 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70594&action=edit Bug 19833: Kill all the "bibilos" - final couple Check the following files to see that all "biblio" or "biblio record"are changed to "bibliograhic records" and there are no typos. modules/ill/ill-requests.tt modules/installer/step3.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 04:31:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 03:31:31 +0000 Subject: [Koha-bugs] [Bug 19988] Change 'sex' to 'gender' In-Reply-To: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19988-70-55XAiwaWNE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 --- Comment #1 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70595&action=edit Bug 19988: Fixing the case where terminolgy referred to sex instead of gender. To test: 1) Change a users gender in the OPAC 2) View it in the patron request in the staff client 3) Check that under 'Field' it now says 'Gender' instead of 'Sex' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 04:43:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 03:43:32 +0000 Subject: [Koha-bugs] [Bug 19660] Set borrower password on first login from self registration In-Reply-To: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19660-70-F2sNo7M3zo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 04:43:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 03:43:35 +0000 Subject: [Koha-bugs] [Bug 19660] Set borrower password on first login from self registration In-Reply-To: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19660-70-X9fFgXGIkW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 --- Comment #1 from jwayway at hotmail.com --- Created attachment 70596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70596&action=edit Bug-19660: Set password after self registration Test plan: 1. Enable PatronSelfRegistration 2. Add a PatronSelfRegistrationDefaultCategory too 3. In OPAC register a user 4. Without patch after hitting submit, password is displayed onscreen 5. After applying patch, password is changed afterwards by sending a email 6. Note how primary email is required Notes - Email is now required for this to work since a unique key was needed for password-recovery.pl to work - A password is randomly generated for the user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 04:44:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 03:44:36 +0000 Subject: [Koha-bugs] [Bug 19991] New: use Modern::Perl in opac-user.pl to get rid of FIXME Message-ID: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 Bug ID: 19991 Summary: use Modern::Perl in opac-user.pl to get rid of FIXME Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 04:44:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 03:44:41 +0000 Subject: [Koha-bugs] [Bug 19991] use Modern::Perl in opac-user.pl to get rid of FIXME In-Reply-To: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19991-70-fQ7kNLVwxL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 04:45:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 03:45:40 +0000 Subject: [Koha-bugs] [Bug 19988] Change 'sex' to 'gender' In-Reply-To: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19988-70-QsnvdLgzgY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jwayway at hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:01:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:01:37 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10943-70-Ni0NjfsNDA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:01:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:01:40 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10943-70-9qZ9bfIXpx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #11 from Grace <gracesmythh at gmail.com> --- Created attachment 70597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70597&action=edit Bug 10943: Manage files without borrowers permission Test Plan: - If the patch is correctly applied then the fines tab should be present without the 'borrowers' permission as long as it has the update charges permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:02:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:02:01 +0000 Subject: [Koha-bugs] [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit In-Reply-To: <bug-15284-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15284-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15284-70-x8geWWkrg0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:02:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:02:04 +0000 Subject: [Koha-bugs] [Bug 15284] Switch default ISSUESLIP notice to Template Toolkit In-Reply-To: <bug-15284-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15284-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15284-70-2ikuZNvlLX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15284 --- Comment #3 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70598&action=edit Bug 15284: Switch default ISSUESLIP notice to Template Toolkit Updated for english version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:02:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:02:52 +0000 Subject: [Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed In-Reply-To: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19990-70-x6uUId0EgH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 --- Comment #1 from jwayway at hotmail.com --- Created attachment 70599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70599&action=edit Bug-19960: FIXME $available is not needed Test plan: 1. Open opac-discharge.pl 2. Check that $available doesn't exist -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:03:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:03:18 +0000 Subject: [Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed In-Reply-To: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19990-70-RgQ2iI2EGX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwayway at hotmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:04:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:04:03 +0000 Subject: [Koha-bugs] [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed In-Reply-To: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19989-70-1pvZ6cP5XM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:04:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:04:05 +0000 Subject: [Koha-bugs] [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed In-Reply-To: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19989-70-O5yn44vFDp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 --- Comment #1 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70600&action=edit Bug 19989: fixing th FIXME so that new requests replace old request Test: 1)Make a change to the user in the OPAC 2)In the staff client make sure this is the only request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:27:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:27:09 +0000 Subject: [Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts In-Reply-To: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19991-70-yVewZQjs40@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|use Modern::Perl in |use Modern::Perl in OPAC |opac-user.pl to get rid of |perl scripts |FIXME | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:29:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:29:12 +0000 Subject: [Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts In-Reply-To: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19991-70-CL6tAzS53D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 --- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Relevant in the following cases: errors/400.pl errors/401.pl errors/402.pl errors/403.pl errors/404.pl errors/500.pl opac-account-pay-paypal-return.pl opac-alert-subscribe.pl opac-authorities-home.pl opac-authoritiesdetail.pl opac-browser.pl opac-ics.pl opac-image.pl opac-imageviewer.pl opac-messaging.pl opac-modrequest-suspend.pl opac-modrequest.pl opac-mymessages.pl opac-overdrive-search.pl opac-passwd.pl opac-patron-image.pl opac-privacy.pl opac-ratings-ajax.pl opac-ratings.pl opac-readingrecord.pl opac-renew.pl opac-sendshelf.pl opac-serial-issues.pl opac-showreviews.pl opac-suggestions.pl opac-tags_subject.pl opac-topissues.pl opac-user.pl sco/help.pl sco/printslip.pl sco/sco-patron-image.pl svc/overdrive_proxy svc/suggestion unapi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:32:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:32:03 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19992-70-wagQAniqJ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:31:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:31:57 +0000 Subject: [Koha-bugs] [Bug 19992] New: use Modern::Perl in Admin perl scripts Message-ID: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 Bug ID: 19992 Summary: use Modern::Perl in Admin perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com use Modern::Perl in the place of use strict; use warnings; Relevant in following cases admin/admin-home.pl admin/aqcontract.pl admin/aqplan.pl admin/auth_tag_structure.pl admin/branch_transfer_limits.pl admin/check_budget_parent.pl admin/check_parent_total.pl admin/checkmarc.pl admin/classsources.pl admin/clone-rules.pl admin/didyoumean.pl admin/edi_accounts.pl admin/edi_ean_accounts.pl admin/import_export_framework.pl admin/item_circulation_alerts.pl admin/marctagstructure.pl admin/matching-rules.pl admin/printers.pl admin/smart-rules.pl admin/systempreferences.pl admin/transport-cost-matrix.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:33:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:33:27 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19993-70-rdhP2hyIjP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:33:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:33:22 +0000 Subject: [Koha-bugs] [Bug 19993] New: use Modern::Perl in Acquisition perl scripts Message-ID: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Bug ID: 19993 Summary: use Modern::Perl in Acquisition perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: acqui/spent.pl acqui/supplier.pl acqui/uncertainprice.pl acqui/updatesupplier.pl acqui/z3950_search.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:35:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:35:51 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19993-70-QABcPsOojV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 --- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Oops I missed a few. This is the full list of acqui perl scripts: acqui-home.pl addorder.pl basketgroup.pl basketheader.pl booksellers.pl check_budget_total.pl check_duplicate_barcode_ajax.pl edi_ean.pl edifactmsgs.pl edimsg.pl finishreceive.pl histsearch.pl invoice.pl invoices.pl neworderbiblio.pl neworderempty.pl newordersuggestion.pl ordered.pl orderreceive.pl parcel.pl parcels.pl pdfformat/layout2pages.pm pdfformat/layout2pagesde.pm pdfformat/layout3pages.pm pdfformat/layout3pagesfr.pm spent.pl supplier.pl uncertainprice.pl updatesupplier.pl z3950_search.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:37:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:37:13 +0000 Subject: [Koha-bugs] [Bug 19994] New: use Modern::Perl in Authorities perl scripts Message-ID: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Bug ID: 19994 Summary: use Modern::Perl in Authorities perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: auth_finder.pl authorities-home.pl authorities-list.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:38:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:38:45 +0000 Subject: [Koha-bugs] [Bug 19995] New: use Modern::Perl in Catalogue perl scripts Message-ID: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Bug ID: 19995 Summary: use Modern::Perl in Catalogue perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: MARCdetail.pl export.pl image.pl imageviewer.pl issuehistory.pl labeledMARCdetail.pl moredetail.pl search.pl showmarc.pl updateitem.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:38:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:38:50 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19995-70-Mcm59xBTU7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:39:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:39:02 +0000 Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19994-70-Hi3iTQT9pb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:41:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:41:06 +0000 Subject: [Koha-bugs] [Bug 19996] New: use Modern::Perl in cataloguing perl scripts Message-ID: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Bug ID: 19996 Summary: use Modern::Perl in cataloguing perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl use Modern::Perl should be used instead of use strict; use warnings; Relevant in: addbiblio.pl addbooks.pl additem.pl linkitem.pl moveitem.pl value_builder/normarc_field_007.pl value_builder/normarc_field_008.pl value_builder/normarc_leader.pl value_builder/unimarc_field_010.pl value_builder/unimarc_field_100.pl value_builder/unimarc_field_105.pl value_builder/unimarc_field_106.pl value_builder/unimarc_field_110.pl value_builder/unimarc_field_115a.pl value_builder/unimarc_field_115b.pl value_builder/unimarc_field_116.pl value_builder/unimarc_field_117.pl value_builder/unimarc_field_120.pl value_builder/unimarc_field_121a.pl value_builder/unimarc_field_121b.pl value_builder/unimarc_field_122.pl value_builder/unimarc_field_123a.pl value_builder/unimarc_field_123d.pl value_builder/unimarc_field_123e.pl value_builder/unimarc_field_123f.pl value_builder/unimarc_field_123g.pl value_builder/unimarc_field_123i.pl value_builder/unimarc_field_123j.pl value_builder/unimarc_field_124.pl value_builder/unimarc_field_124a.pl value_builder/unimarc_field_124b.pl value_builder/unimarc_field_124c.pl value_builder/unimarc_field_124d.pl value_builder/unimarc_field_124e.pl value_builder/unimarc_field_124f.pl value_builder/unimarc_field_124g.pl value_builder/unimarc_field_125.pl value_builder/unimarc_field_125a.pl value_builder/unimarc_field_125b.pl value_builder/unimarc_field_126.pl value_builder/unimarc_field_126a.pl value_builder/unimarc_field_126b.pl value_builder/unimarc_field_127.pl value_builder/unimarc_field_128a.pl value_builder/unimarc_field_128b.pl value_builder/unimarc_field_128c.pl value_builder/unimarc_field_130.pl value_builder/unimarc_field_135a.pl value_builder/unimarc_field_140.pl value_builder/unimarc_field_141.pl value_builder/unimarc_field_210c.pl value_builder/unimarc_field_210c_bis.pl value_builder/unimarc_field_225a.pl value_builder/unimarc_field_4XX.pl value_builder/unimarc_field_686a.pl value_builder/unimarc_field_700-4.pl value_builder/unimarc_leader.pl z3950_auth_search.pl z3950_search.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:41:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:41:18 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19996-70-JrUTdNaDvN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:43:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:43:14 +0000 Subject: [Koha-bugs] [Bug 19997] New: use Modern::Perl in Circulation perl scripts Message-ID: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Bug ID: 19997 Summary: use Modern::Perl in Circulation perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com use Modern::Perl should be used instead of use strict; use warnings; Relevant in: bookcount.pl branchoverdues.pl branchtransfers.pl circulation.pl hold-transfer-slip.pl reserveratios.pl returns.pl selectbranchprinter.pl transfer-slip.pl transferstoreceive.pl view_holdsqueue.pl waitingreserves.pl ypattrodue-attr-search-authvalue.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:43:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:43:19 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19997-70-MQloobGhOD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:44:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:44:31 +0000 Subject: [Koha-bugs] [Bug 19998] New: use Modern::Perl in error perl scripts Message-ID: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Bug ID: 19998 Summary: use Modern::Perl in error perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: 400.pl 401.pl 402.pl 403.pl 404.pl 500.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:44:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:44:36 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19998-70-XyhTmerM4i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:45:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:45:34 +0000 Subject: [Koha-bugs] [Bug 19999] New: use Modern::Perl in Labels perl scripts Message-ID: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19999 Bug ID: 19999 Summary: use Modern::Perl in Labels perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: label-create-csv.pl label-create-pdf.pl label-create-xml.pl label-edit-batch.pl label-edit-layout.pl label-edit-profile.pl label-edit-template.pl label-home.pl label-item-search.pl label-print.pl spinelabel-home.pl spinelabel-print.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:46:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:46:33 +0000 Subject: [Koha-bugs] [Bug 20000] New: use Modern::Perl in installer perl scripts Message-ID: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Bug ID: 20000 Summary: use Modern::Perl in installer perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com use Modern::Perl should be used instead of use strict; use warnings; Relevant in: data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:46:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:46:37 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-IQI9wZMWRF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 05:46:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 04:46:41 +0000 Subject: [Koha-bugs] [Bug 19999] use Modern::Perl in Labels perl scripts In-Reply-To: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19999-70-gXIjCKmHLV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19999 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 07:42:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 06:42:18 +0000 Subject: [Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities In-Reply-To: <bug-19983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19983-70-Y9sCDo6HXP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 07:51:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 06:51:15 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-3U8nAEP608@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 08:19:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 07:19:02 +0000 Subject: [Koha-bugs] [Bug 20001] New: ILL: Adding a 'new request' from OPAC is not possible Message-ID: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Bug ID: 20001 Summary: ILL: Adding a 'new request' from OPAC is not possible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de The button to add a 'new request' from the OPAC doesn't work, it doesn't matter if there is one or multiple backends installed: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?method=create&backend=ARRAY(0xa943760) Internal server error Can't locate Koha/Illbackends/ARRAY(0xb154640)/Base.pm in @INC (you may need to install the Koha::Illbackends::ARRAY(0xb154640)::Base module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer /home/vagrant/kohaclone/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /home/vagrant/kohaclone/Koha/Illrequest.pm line 153. When there are mulitple backends installed the button is a menu on the staff side that lets you pick, what you want to do. I think the same should probably happen on the OPAC. Marking critical for ILL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 08:22:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 07:22:49 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-vAADoJ0lS6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker Summary|ILL: Adding a 'new request' |ILL: Adding a 'new request' |from OPAC is not possible |is not possible --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Actually it's the same from the staff side. The button is nicer, but once you click on it, it breaks: Button: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm Internal server error Template process failed: file error - : not found at /home/vagrant/kohaclone/C4/Templates.pm line 122. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 08:33:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 07:33:00 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7317-70-nU6wEQ8vVR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 [Bug 20001] ILL: Adding a 'new request' is not possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 08:33:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 07:33:00 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-A4yTJChtta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 08:33:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 07:33:39 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-fBZn93GLvx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've followed installation instructions on bug 20001 comment20 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 08:47:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 07:47:02 +0000 Subject: [Koha-bugs] [Bug 19931] Omnibus: Update popup window templates to use Bootstrap grid In-Reply-To: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19931-70-UmpEeoZeP2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 08:48:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 07:48:09 +0000 Subject: [Koha-bugs] [Bug 14446] More noisy warns in admin/preferences.pl In-Reply-To: <bug-14446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14446-70-zu3Dbqy3To@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Marian <marianm at newro.co> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marianm at newro.co --- Comment #2 from Marian <marianm at newro.co> --- I also have this problem did you have found a fix for it ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 08:59:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 07:59:30 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-FYwsTE9VTo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #48 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 70430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70430 Bug 17656 - Fix QA comments - Make day and month names translatable, - Update unit tests, - Fix a typo in C4/Serials.pm (GessEndDate), - rename subtype subroutine to lengthtype - DB Change: add changes in kohastructure.sql and Bug_17656-add-permanent Review of attachment 70430: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17656&attachment=70430) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc @@ +4,2 @@ > </em></p> > [% daily_choice = [ {name => 'monday', desc => 'Monday', value => 1}, {name => 'tuesday', desc => 'Tuesday', value => 2}, {name => 'wednesday', desc => 'Wednesday', value => 3}, {name => 'thursday', desc => 'Thursday', value => 4}, {name => 'friday', desc => 'Friday', value => 5}, {name => 'saturday', desc => 'Saturday', value => 6}, {name => 'sunday', desc => 'Sunday', value => 7} ] %] Looks like you do not need the "desc" values here now, is that true? ::: koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_monthly_choice.inc @@ +4,2 @@ > </em></p> > [% monthly_choice = [ {name => 'january', desc => 'January', value => 1}, {name => 'february', desc => 'February', value => 2}, {name => 'march', desc => 'March', value => 3}, {name => 'april', desc => 'April', value => 4}, {name => 'may', desc => 'May', value => 5}, {name => 'june', desc => 'June', value => 6}, {name => 'july', desc => 'July', value => 7}, {name => 'august', desc => 'August', value => 8}, {name => 'september', desc => 'September', value => 9}, {name => 'october', desc => 'October', value => 10}, {name => 'november', desc => 'November', value => 11}, {name => 'december', desc => 'December', value =>12} ] %] Looks like you do not need the "desc" values here now, is that true? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 09:05:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 08:05:14 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-DHQBcMEvJS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #49 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Alex Arnaud from comment #46) > (In reply to Josef Moravec from comment #44) > > Comment on attachment 70336 [details] [review] [review] > > Bug 17656 - Update irregularities on subscription renewals > > > > Review of attachment 70336 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > > > Better to add new subs just to Koha namespace... but I understand it here - > > we do not have all the objects needed for serials management (frequencies > > and number patterns are missing) and calling C4 subs from Koha namespace is > > not good idea... If you are not willing to add needed objects, we could just > > fill a bug for now... > > Don't understand. You mean create Koha::Subscription->GuessEnddate? Yes, that is what I ment. > > > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt > > @@ +52,5 @@ > > > + <input type="hidden" id="numbering3" value="[% numbering3 %]" /> > > > + <input type="hidden" id="whenmorethan1" value="[% whenmorethan1 %]" /> > > > + <input type="hidden" id="whenmorethan2" value="[% whenmorethan2 %]" /> > > > + <input type="hidden" id="whenmorethan3" value="[% whenmorethan3 %]" /> > > > + <input type="hidden" id="locale" value="[% locale %]" /> > > > > Why do you include all the data when renewing subscription? It should be not > > needed! > > Yes. testPredictionPattern js function needs all the data. Then I think the showpredictionpattern.pl script should be changed to use stored data for parameters which weren't changed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 09:40:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 08:40:12 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-wMvrJfqM87@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Charlotte Cordwell from comment #3) > Created attachment 70569 [details] [review] > Bug 19831:Turn on EnhancedMessagingPreferences by default for new > installations 1)Create a new installation 2)On staff go adminisation --> and > search EnchancedMessagingPreferences 3)Check that it is automaticaly on > allow. If it is the it has worked. Why did you submit the patch again ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 09:55:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 08:55:00 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-VxcEQl17Pp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Francesco Rivetti <oha at oha.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oha at oha.it --- Comment #3 from Francesco Rivetti <oha at oha.it> --- in our implementation (NNCIP) the creation of a new request come from a xml requests on a different component. The backend properly create the request and everything else work reasonably fine. It's probable than that the issue is on the user interface HTH -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 09:56:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 08:56:58 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-Z7KRVPFhU7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #4 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- (In reply to Katrin Fischer from comment #2) > I've followed installation instructions on bug 20001 comment20 bug 20001 comment20? 20001 is this bug and there aren't 20 comments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 10:01:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 09:01:42 +0000 Subject: [Koha-bugs] [Bug 20002] New: Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. Message-ID: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 Bug ID: 20002 Summary: Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print .pl line 107. Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: mhby87 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 70601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70601&action=edit Software error: Error on print summary -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 10:30:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 09:30:46 +0000 Subject: [Koha-bugs] [Bug 20003] New: Result summary of remaining checkouts items not displaying. Message-ID: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Bug ID: 20003 Summary: Result summary of remaining checkouts items not displaying. Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: ianuj.singhx18 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 70602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70602&action=edit Result Summary that need to be show while returning of books. On the previous build Koha v17.05, after checking an item, the Check-in items table (patron cell), numbers of remaining items is visible below the patron's name, but now in v17.11 it is not visible even if patron has remaining checkout books. I am attaching the older screenshot of the result summary marking with red block in the screenshot that is not visible/displaying in the newer build. Please also help me, if there is an system preferences that need to be changed / modify to view results summary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 11:25:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 10:25:42 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-RE7vbG1WKy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Sorry, bug 7317 comment 20 I have tested on master, maybe it works on 17.11? I haven't had time to verify this yet. The problem appears in the GUI, I think your .it implementation is not listed on the wiki, so can't test. Dummy and FreeForm don't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 11:51:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 10:51:06 +0000 Subject: [Koha-bugs] [Bug 19661] Funds endpoint In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-OPv26QN5Im@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #5 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Created attachment 70603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70603&action=edit Bug 19661 - Use Koha::Acquisition::Funds instead of C4::Budgets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 11:51:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 10:51:49 +0000 Subject: [Koha-bugs] [Bug 19661] Funds endpoint In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-dyPS5aHxHS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 12:09:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 11:09:20 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-NrwQni4CIE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Marcel, this change has terrible side-effects: commit 7e222bb0796196f1e466b73d909fd28d529cab75 Bug 18811: Change visibility checks in authorities.pl next if $tagslib->{$tag}->{$subfield}->{hidden}; I was trying to test the AuthDisplayHierarchy behaviour and notice that the $9 was not filled with the related (broader) authority id. Indeed it is hidden. Can you fix ASAP? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 12:16:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 11:16:36 +0000 Subject: [Koha-bugs] [Bug 19661] Funds endpoint In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-I1ddMPCRcF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #6 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Documentation updated here: https://wiki.koha-community.org/wiki/Acquisitions_funds_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:10:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:10:02 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-9xYE7eZlI6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70439|0 |1 is obsolete| | Attachment #70443|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70604&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:11:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:11:30 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-1iOWNYcGd8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70604|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70605&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:26:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:26:36 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-gaOZhAsC5j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #33) > Marcel, this change has terrible side-effects: > > commit 7e222bb0796196f1e466b73d909fd28d529cab75 > Bug 18811: Change visibility checks in authorities.pl > > next if $tagslib->{$tag}->{$subfield}->{hidden}; > > I was trying to test the AuthDisplayHierarchy behaviour and notice that the > $9 was not filled with the related (broader) authority id. Indeed it is > hidden. > Can you fix ASAP? I am not really familiar with AuthDisplayHierarchy. The third patch added a script auth_show_hidden_data.pl to detect hidden fields, prompting the user to change them in the frameworks. At the time we considered this to be enough.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:27:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:27:23 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-HGNXsh0MVq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- We could more or less revert the change but return to the older inconsistent situation.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:39:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:39:19 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18236-70-jSwAmLTxW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- This looks great, but can I ask for more? It would be helpful if the icons kept the "materialtype" class along with the new class: <img src="/intranet-tmpl/prog/img/famfamfam/silk/book.png" alt="book" title="book" class="materialtype mt_icon_book"/> That would let us define common styles for all material type icons in addition to specific ones for specific types. Also: Could you include changes to MARC21slim2intranetDetail.xsl too? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:39:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:39:56 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19884-70-qFasztQdCS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70284|0 |1 is obsolete| | --- Comment #41 from David Gustafsson <glasklas at gmail.com> --- Created attachment 70606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70606&action=edit Add new functions GetMarcBiblios and EmbedItemsInMarcBiblios for embedding items in multiple records at once for improved performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:15 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-ptvnRDEGsz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:15 +0000 Subject: [Koha-bugs] [Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins , part 4 In-Reply-To: <bug-19872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19872-70-VCxZlGxY3o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:15 +0000 Subject: [Koha-bugs] [Bug 19869] Move template JavaScript to the footer: UNIMARC editor plugins , part 3 In-Reply-To: <bug-19869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19869-70-0qEzglETiS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:15 +0000 Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1 In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19785-70-b4krKTRBrj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:16 +0000 Subject: [Koha-bugs] [Bug 19874] Move template JavaScript to the footer: UNIMARC editor plugins , part 5 In-Reply-To: <bug-19874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19874-70-U6FX0Y1iLP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:16 +0000 Subject: [Koha-bugs] [Bug 19823] Move template JavaScript to the footer: MARC21 editor plugins In-Reply-To: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19823-70-AIYYe3hek6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:16 +0000 Subject: [Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2 In-Reply-To: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19786-70-gKDdZkH0bZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:16 +0000 Subject: [Koha-bugs] [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins , part 1 In-Reply-To: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19866-70-za6tyPiqjm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:15 +0000 Subject: [Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins , part 7 In-Reply-To: <bug-19878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19878-70-hGixEff3xT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:17 +0000 Subject: [Koha-bugs] [Bug 19877] Move template JavaScript to the footer: UNIMARC editor plugins , part 6 In-Reply-To: <bug-19877-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19877-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19877-70-OwGhTjrj7M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19877 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:16 +0000 Subject: [Koha-bugs] [Bug 19868] Move template JavaScript to the footer: UNIMARC editor plugins , part 2 In-Reply-To: <bug-19868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19868-70-grHioqymFs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:17 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-y2iIX5uGDf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:43:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:43:17 +0000 Subject: [Koha-bugs] [Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2 In-Reply-To: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19754-70-8yfZ5lj9yO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:44:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:44:17 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19932-70-H6TNOQTZOU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:44:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:44:17 +0000 Subject: [Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order In-Reply-To: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19947-70-RIGHxZ6zuK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:44:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:44:17 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19946-70-oxfVDnJmhJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:44:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:44:17 +0000 Subject: [Koha-bugs] [Bug 19950] Update popup window templates to use Bootstrap grid: Serials In-Reply-To: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19950-70-jZNrrnyND6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:44:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:44:18 +0000 Subject: [Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins In-Reply-To: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19952-70-BLdc8ArpYI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:44:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:44:18 +0000 Subject: [Koha-bugs] [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list In-Reply-To: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19960-70-FHmcxXd1qy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:44:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:44:18 +0000 Subject: [Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search In-Reply-To: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19949-70-hTZ5WqxDlQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:44:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:44:18 +0000 Subject: [Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons In-Reply-To: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19954-70-fwhEyYgUAu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:44:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:44:18 +0000 Subject: [Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator In-Reply-To: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19959-70-sfXYKOUfYl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:49:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:49:13 +0000 Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19884-70-CtYlQLopMd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #42 from David Gustafsson <glasklas at gmail.com> --- Fixed a minor error handling broken marc records (where indexing crashed when should just skip the record). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:49:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:49:34 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19221-70-S3XpK7paXy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70575|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70607&action=edit Bug 19221: Onboarding tool says user needs to be made superlibrarian I changed the "To give new patron superlibrarian permissions go to:" message to "To edit patron permissions, go to:". Please clarify if this is clearer or not. Test plan: 1) Apply patch 2) Go through the web installer 3) At the create koha administrator patron step, notice that at the bottom, there is a message saying "To edit patron permissions, go to:" https://bugs.koha-community.org/show_bug.cgi?id=19221 Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 13:49:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 12:49:32 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19221-70-0pWe3Da416@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:04:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:04:57 +0000 Subject: [Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes date or datetime field In-Reply-To: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19967-70-BPljpcfIJ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967 --- Comment #4 from Ulrich Kleiber <ulrich.kleiber at bsz-bw.de> --- Hi Jonathan, is it possible to get the data type of a column with Koha::Objects->columns? Katrin mentioned, that you could not reproduce the error under MariaDB. Our MySQL Version is '14.14 Distrib 5.5.58, for debian-linux-gnu (x86_64)'. Perhaps the implicit type conversion has changed in MariaDB. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:07:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:07:24 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-hiB8QeBqxJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Make an exception for $9 as a special use case? Not sure if that is a valid option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:08:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:08:29 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-QFFuZbRI3i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #36) > Make an exception for $9 as a special use case? Not sure if that is a valid > option. Yeah that might not be a bad idea.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:12:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:12:56 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19188-70-W5N4jjwAk0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:12:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:12:58 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19188-70-5hkqYYUOZN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70577|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70608&action=edit Bug 19188: Self checkout missing space for price Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. Login to localhost:8081 and issue a book 3. In OPAC give user fine by going to 'my account' at top right 4. Then under fines tab 'create manual invoice' 5. Make sure this amount is more than OPACFineNoRenenwals which can be changed under System prefernces 6. Back in localhost:8081, try renewing the book 7. Error 'Item cannot be checked out' should occur 8. Without patch the currency symbol and amount is together 9. With patch there should be a space in between Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:19:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:19:38 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-htSsv6smIC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69753|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:19:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:19:44 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-rhv4Ig6t6O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:19:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:19:41 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-5TABenR9P6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:20:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:20:06 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-hSKjWdwvZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70609&action=edit Bug 19784: Unit tests for /api/v1/patrons This patch adapts the existing endpoint's tests so they expect: - 'patron_id' for 'borrowernumber' - 'library_id' for 'branchcode' - 'category_id' for 'categorycode' In the process, I tried to make the tests more robust, by creating random data that gets deleted to make sure our tests cases can't have false positives. Independent subtests are wrapped inside transactions to avoid eventual interference. To test: - Apply the patch - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: The api doesn't implement the expected behaviour and attributes for endpoint responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:20:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:20:10 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-Rrny6szx5I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 --- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70610&action=edit Bug 19784: Remove reference to 'borrowernumber' param from other endpoints This patch removes the $ref occurences for borrowernumber in not patron-specific endpoints. 'borrowernumber' is still used on them, but as a hardcoded parameter. The param rename will happen on a separate bug for each endpoint. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:20:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:20:14 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-7ylcFM5YDH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 --- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70611&action=edit Bug 19784: Adapt /v1/patrons to new naming guidelines This patch introduces two functions to the patrons endpoint: - _to_api - _to_model This are in charge of field mappings in order to comply with the guidelines. Koha::REST::V1:Auth is adjusted to handle 'patron_id' as well. To test: - Apply the patches - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:20:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:20:50 +0000 Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19686-70-ScIXJQGk9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19784 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 [Bug 19784] Adapt /v1/patrons to new naming guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:20:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:20:50 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-1DoEY3BWaR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on|19686 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686 [Bug 19686] objects.search helper needs a to_model param -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:23:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:23:55 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-XhB9y9h9Ip@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:24:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:24:00 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-TcqCOt7US3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70611|0 |1 is obsolete| | --- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70612&action=edit Bug 19784: Adapt /v1/patrons to new naming guidelines This patch introduces two functions to the patrons endpoint: - _to_api - _to_model This are in charge of field mappings in order to comply with the guidelines. Koha::REST::V1:Auth is adjusted to handle 'patron_id' as well. To test: - Apply the patches - Run: $ kshell k$ prove t/db_dependent/api/v1/*.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:26:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:26:01 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13560-70-Y6XLKCNxot@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70564|0 |1 is obsolete| | --- Comment #13 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70613&action=edit Bug 13560: Add an 'Add' option for marc modification templates Add/Update would update a field or create new if it existed, but didn't allow for creating new if the field existed. This patchset splits the options to 'Add & Update' so that 'Add' will always add a field and 'Update' will operate as it always has To test: 1 - Have a record with a known existing field (make a copy) 2 - Define a marc modification template that 'Add/update' on that field 3 - Define an 'Add/Update' on a field that doesn't exist 4 - Batch modify the copy of record using the above template 5 - Verify the existing field was updated 6 - Verify the non-existing field was updated 7 - Apply patch and update database 8 - Make another copy 9 - Modify the copy with the same template as above 10 - Should match initial modification 11 - Add a new rule to add a new field 12 - Modify using the updated template 13 - Ensure your new field is created 14 - Test various options in the modification tool 15 - prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Victor Grousset <victor.grousset at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:27:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:27:22 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-dVlWNqiQiQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 --- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- My last submission implements the changes voted with the RFC as a basis [1] Tests should pass, and the changes to the patrons.json file should make sense in terms of the RFC. I removed the dependency on objects.search as the query parameters used in this endpoint require a more fine grained approach as you can see on the patch. Enjoy! [1] https://wiki.koha-community.org/wiki/Patrons_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:27:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:27:54 +0000 Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17765-70-7BjzMaO5lJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- I'm not sure if this is ready for testing or not, but in it's current state it doesn't work for me: "my" variable $flags masks earlier declaration in same scope at /home/vagrant/kohaclone/circ/circulation.pl line 464. Can't call method "flags" on an undefined value at /home/vagrant/kohaclone/circ/circulation.pl line 179. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:28:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:28:24 +0000 Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19784-70-b0KEcr7Uje@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Patrons_endpoint_ | |RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:28:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:28:47 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn' t appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-8wWPhuwgnX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:29:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:29:01 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13560-70-v2YTtKZwzX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- As for step ?14 - Test various options in the modification tool? I only moved one field to another to ensure that the target is overwritten without error. Is that enough? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:29:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:29:11 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-DBA1imxa1l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:31:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:31:20 +0000 Subject: [Koha-bugs] [Bug 20004] New: Adapt /v1/cities to new naming guidelines Message-ID: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Bug ID: 20004 Summary: Adapt /v1/cities to new naming guidelines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:31:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:31:43 +0000 Subject: [Koha-bugs] [Bug 20004] Adapt /v1/cities to new naming guidelines In-Reply-To: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20004-70-iZWJLmv4ml@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Cities_endpoint_R | |FC Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:32:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:32:24 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-Hbw61SxTPE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70614&action=edit Bug 18811: (QA follow-up) Allow hidden $9 subfields Although we could argue that the user should make all $9 subfields visible, this might be a good compromise. It selectively reverts the change from the first patch by accepting $9 subfields without checking the hidden flag in the framework. Test plan: [1] Make a subfield $9 visible for some authority field. [2] Put a value in it somewhere in authorities.pl [3] Make subfield $9 invisible in the auth framework. [4] Open and save the adjusted authority record. [5] Check the marcxml of this record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:32:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:32:57 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-1RtY4H4Dxk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Could you test this one, Jonathan ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:34:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:34:32 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-PxaM8cBV24@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #35 from S?verine Queune <severine.queune at bulac.fr> --- Did I miss a dependency ? The patch doesn?t seem to apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:35:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:35:21 +0000 Subject: [Koha-bugs] [Bug 19988] Change 'sex' to 'gender' In-Reply-To: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19988-70-b7RkG3igvY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:35:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:35:23 +0000 Subject: [Koha-bugs] [Bug 19988] Change 'sex' to 'gender' In-Reply-To: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19988-70-j61nkbIqZf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70595|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70615&action=edit Bug 19988: Fixing the case where terminolgy referred to sex instead of gender. To test: 1) Change a users gender in the OPAC 2) View it in the patron request in the staff client 3) Check that under 'Field' it now says 'Gender' instead of 'Sex' Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:42:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:42:57 +0000 Subject: [Koha-bugs] [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed In-Reply-To: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19989-70-QkEOT0g58E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:42:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:42:59 +0000 Subject: [Koha-bugs] [Bug 19989] opac-memberentry.pl has a FIXME that can be fixed In-Reply-To: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19989-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19989-70-MVmGiiLjXU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19989 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70600|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70616&action=edit Bug 19989: fixing the FIXME so that new requests replace old request Test: 1) Make a change to the user in the OPAC 2) In the staff client make sure this is the only request Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:55:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:55:03 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-kmFbW4ittr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #50 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to Josef Moravec from comment #49) > (In reply to Alex Arnaud from comment #46) > > (In reply to Josef Moravec from comment #44) > > > Comment on attachment 70336 [details] [review] [review] [review] > > > Bug 17656 - Update irregularities on subscription renewals > > > > > > Review of attachment 70336 [details] [review] [review] [review]: > > > ----------------------------------------------------------------- > > > > Yes. testPredictionPattern js function needs all the data. > > Then I think the showpredictionpattern.pl script should be changed to use > stored data for parameters which weren't changed... Why? testPredictionPattern JS function get this data and pass them to showpredictionpattern.pl. It works exactly like in subscription-add.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 14:56:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 13:56:05 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-bUFo60WTWs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 15:06:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 14:06:29 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10943-70-jrmVlfOBfC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #12 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- (In reply to Grace from comment #11) > Created attachment 70597 [details] [review] > Bug 10943: Manage files without borrowers permission > > Test Plan: > - If the patch is correctly applied then the fines tab should be present > without the 'borrowers' permission as long as it has the update charges > permission Hi Grace, I tested on sandbox and i do not see tab Fines if borrower permission is not checked. See attached screenshots. Do I understand your test plan? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 15:07:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 14:07:29 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10943-70-T6TbHypcmU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #13 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- Created attachment 70617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70617&action=edit permission borrowers not checked -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 15:08:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 14:08:05 +0000 Subject: [Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission In-Reply-To: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10943-70-g6Kpa3ovee@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #14 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- Created attachment 70618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70618&action=edit Tab Fines not displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 15:19:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 14:19:40 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-AR2sml46LJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #29 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- (In reply to Aleisha Amohia from comment #28) > Created attachment 70583 [details] [review] > Bug 16486: [FOLLOW-UP] Show original date and timestamp for fines > > This patch has two columns in fines tables, one showing the original > date and one showing the timestamp (when the patch was last updated) > > Fixed merge conflicts Hi Aleisha, I tested on a sandbox and it works very well. But I was wondering if the column Updated should not appear also in the report Cash register statistics (reports/cash_register_stats.pl)? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 15:26:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 14:26:40 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-vLxeEAfsZo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #51 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to Josef Moravec from comment #49) > (In reply to Alex Arnaud from comment #46) > > (In reply to Josef Moravec from comment #44) > > > Comment on attachment 70336 [details] [review] [review] [review] > > > Bug 17656 - Update irregularities on subscription renewals > > > > > > Review of attachment 70336 [details] [review] [review] [review]: > > > ----------------------------------------------------------------- > > > > > > > > > Better to add new subs just to Koha namespace... but I understand it here - > > > we do not have all the objects needed for serials management (frequencies > > > and number patterns are missing) and calling C4 subs from Koha namespace is > > > not good idea... If you are not willing to add needed objects, we could just > > > fill a bug for now... > > > > Don't understand. You mean create Koha::Subscription->GuessEnddate? > > Yes, that is what I ment. I see one obstacle. GuessEnddate is used with the subscription's data itself in subscription-renew.pl and with data coming from the html form in subscription-add.pl. So method calls will be: $subscription_object->GuessEnddate() in the first case, and $subscription_object->GuessEnddate($firstacquidate, $periodicity, ...) in the second one Quite tricky no? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 15:27:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 14:27:00 +0000 Subject: [Koha-bugs] [Bug 20005] New: Posibility to change the number of results shown by default in label creator Message-ID: <bug-20005-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20005 Bug ID: 20005 Summary: Posibility to change the number of results shown by default in label creator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org Hi, In the tool label creator, by default it show only the 20 first results. It will be great if we could choose the numbers of results shown by default for those tables. Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 15:30:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 14:30:32 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-D9GzaXf61A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #52 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 70619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70619&action=edit Bug 17656 - [QA followup] Remove useless description in subscription_daily_choice.inc and subscription_monthly_choice.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 15:37:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 14:37:29 +0000 Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19818-70-6JfHRkWSwj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- Looking good, just a small isuue: the spaces need to be used for indentation, not tabs. QA tool reports: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL forbidden patterns forbidden pattern: tab char (line 495) forbidden pattern: tab char (line 492) forbidden pattern: tab char (line 396) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:00:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:00:14 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19856-70-KuWwrOVMpV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- With this patch, it only worsk for guided reports. You should also change the file reports-menu.inc, to get this working on any of reports with sidebar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:10:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:10:07 +0000 Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers In-Reply-To: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19017-70-1wrsSydqTW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017 --- Comment #9 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to Jonathan Druart from comment #6) > This is too specific, we should provide a generic way to do that. > The prefix code should be a parameter of the script. Prefix code is passed to the script with -o|--options. It is intentionally generic in the case an other country package needs a different parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:14:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:14:36 +0000 Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display in opac or staff side In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19677-70-FDDV7x2MsL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:14:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:14:40 +0000 Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display in opac or staff side In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19677-70-G2M8qM7iig@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70530|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 70620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70620&action=edit Bug 19677 - Properly escape enumchrom/serialseq data Some serial issues use angle brackets for denoting certain data. Currently this is not displayed in Koha. This patch escapes the data so that angle brackets will display. To test: 1 - Add an enumchron field to an item containg angle brackets: "This is a <test>" 2 - View the record in the staff and opac, not the field displays as: "This is a" 3 - Apply patch 4 - Note full text now displays Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:15:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:15:26 +0000 Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display in opac or staff side In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19677-70-zPg6V87ZeE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | Assignee|oleonard at myacpl.org |nick at bywatersolutions.com Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:23:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:23:39 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-eeRL7ac1py@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70553|0 |1 is obsolete| | Attachment #70569|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70621&action=edit Bug 19831: Turn on EnhancedMessagingPreferences by default for new installations Test plan: 1) Create a new installation 2) On staff go adminisation --> and search EnchancedMessagingPreferences 3) Check that it is automaticaly on allow. If it is the it has worked. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:25:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:25:06 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-9TE9be425f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4) > (In reply to Charlotte Cordwell from comment #3) > > Created attachment 70569 [details] [review] [review] > > Bug 19831:Turn on EnhancedMessagingPreferences by default for new > > installations 1)Create a new installation 2)On staff go adminisation --> and > > search EnchancedMessagingPreferences 3)Check that it is automaticaly on > > allow. If it is the it has worked. > > Why did you submit the patch again ? Oh I see. Wrong bugnumber. I corrected the signed patch, because resubmitting the original one would result in loosing the signoff. (As well as additional editing; your test plan is on one line.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:28:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:28:13 +0000 Subject: [Koha-bugs] [Bug 19988] Change 'sex' to 'gender' In-Reply-To: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19988-70-XVVLo1guxX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:28:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:28:15 +0000 Subject: [Koha-bugs] [Bug 19988] Change 'sex' to 'gender' In-Reply-To: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19988-70-FnE20b7uFh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70615|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70622&action=edit Bug 19988: Fixing the case where terminolgy referred to sex instead of gender. To test: 1) Change a users gender in the OPAC 2) View it in the patron request in the staff client 3) Check that under 'Field' it now says 'Gender' instead of 'Sex' Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:28:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:28:43 +0000 Subject: [Koha-bugs] [Bug 19988] Change 'sex' to 'gender' In-Reply-To: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19988-70-FWy4Ny4QAQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Assignee|koha-bugs at lists.koha-commun |zoebennett1308 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:44:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:44:18 +0000 Subject: [Koha-bugs] [Bug 18083] Don't show 'library' selection on popular titles page for single-branch libraries In-Reply-To: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18083-70-jmTLrUPlvh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:44:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:44:21 +0000 Subject: [Koha-bugs] [Bug 18083] Don't show 'library' selection on popular titles page for single-branch libraries In-Reply-To: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18083-70-x1v9MMGS90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70542|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70623&action=edit Bug 18083: Don't show 'library' selection on popular titles page for single-branch libraries This patch hides the search filter labelled "From" that offers you to select a library branch which is located on the 'popular titles' page on the OPAC. It is hidden when the library only has one branchas it would be unneccessary to have an option for other branches when there is only one. Test Plan: 1) Make sure you have a single-branch library 2) Make sure OPACTopIssue is allowed in the OPAC preferences 3) In the OPAC, got to 'Most Popular' page 4) Check that there is no "From" filter in the refine search 5) Create a new branch so that you have more than one branch 6) Check that there is a "From" filter in the refine search on the Most Popular page. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Amended white space on second change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:44:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:44:46 +0000 Subject: [Koha-bugs] [Bug 18083] Don't show 'library' selection on popular titles page for single-branch libraries In-Reply-To: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18083-70-uFME4DFhYx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:51:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:51:23 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19188-70-RN8m5BoJj5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:51:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:51:26 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19188-70-PnEf26IGB7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70608|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70624&action=edit Bug 19188: Self checkout missing space for price Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. Login to localhost:8081 and issue a book 3. In OPAC give user fine by going to 'my account' at top right 4. Then under fines tab 'create manual invoice' 5. Make sure this amount is more than OPACFineNoRenenwals which can be changed under System prefernces 6. Back in localhost:8081, try renewing the book 7. Error 'Item cannot be checked out' should occur 8. Without patch the currency symbol and amount is together 9. With patch there should be a space in between Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 16:51:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 15:51:50 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19188-70-ahpG16hJOQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |jwayway at hotmail.com |ity.org | QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 17:04:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 16:04:34 +0000 Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a barcode file In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19585-70-Dstx93x6Gv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70535|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 70625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70625&action=edit Bug 19585: Inventory: Allow additional separators in a barcode file This patch makes \n, \r, |, comma, semicolon and hyphen ('-') all valid separators between barcodes passed to inventory. An additional grep removes empty barcodes. (Note: The grep looks for at least one non-whitespace character. We could be more specific, but this allows for more flexibility like testing with alphanumeric barcodes etc.) Test plan: Upload a barcode file that contains various allowed separators. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jenny Way <jwayway at hotmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 17:04:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 16:04:31 +0000 Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a barcode file In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19585-70-AZbGEBOijo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 17:07:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 16:07:12 +0000 Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a barcode file In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19585-70-KICVDII99G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 17:12:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 16:12:58 +0000 Subject: [Koha-bugs] [Bug 18363] Delink analytical records is gone In-Reply-To: <bug-18363-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18363-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18363-70-uxGS0TP3mx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18363 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu --- Comment #2 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> --- I agree that this needs to be addressed. My library is now on 17.05 and the 17.05 manual still describes editing analytical records by using "Edit in Host" and "Delink" which disappeared in 16.11: https://koha-community.org/manual/17.05/html/06_cataloging.html?highlight=analytics#editing-analytics I can confirm that the following process worked for me for withdrawing a volume linked to an analytical record: 1) Delete the 773 in the MARC record of the analytical (child) record. Result: the record no longer had an item attached. 2) Delete the bibliographic record that was the analytical (child) record. -- Repeat 1 & 2 for all child records attached to the host -- 3) Go to the host record. 4) Delete the item. 5) Delete the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 17:40:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 16:40:08 +0000 Subject: [Koha-bugs] [Bug 18363] Delink analytical records is gone In-Reply-To: <bug-18363-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18363-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18363-70-ruVUc89yaH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18363 --- Comment #3 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> --- I may need to revise my last comment. The first pair of linked analytical records I was looking at did not have the "Edit in Host" or "Delink" links available in the Action dropdown menu on the Edit Items page. The second pair of linked analytical records I'm looking at now do offer these as options. Perhaps there was something corrupt in the first pair of records I was looking at. I can now confirm that in 17.05 when going to Edit Items in an analytical (child) record, the options available are: Edit in Host, Delink, and OPAC View. Selecting "Delink" removes the host item from the record. Perhaps this is not a bug after all? Or perhaps a bug still exists in versions prior to 17.05? Or perhaps it exists when you've tried to manipulate the record in other ways while it was still linked? For example, attempting to delete the host item from the analytical (child) record by using "Delete all items" did not return an error, but the host item still appeared and the Actions menu did not have the Delink option. Hoping this makes sense to others. (In reply to Myka Kennedy Stephens from comment #2) > I agree that this needs to be addressed. My library is now on 17.05 and the > 17.05 manual still describes editing analytical records by using "Edit in > Host" and "Delink" which disappeared in 16.11: > https://koha-community.org/manual/17.05/html/06_cataloging. > html?highlight=analytics#editing-analytics > > I can confirm that the following process worked for me for withdrawing a > volume linked to an analytical record: > 1) Delete the 773 in the MARC record of the analytical (child) record. > Result: the record no longer had an item attached. > 2) Delete the bibliographic record that was the analytical (child) record. > -- Repeat 1 & 2 for all child records attached to the host -- > 3) Go to the host record. > 4) Delete the item. > 5) Delete the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:35:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:35:00 +0000 Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19686-70-4f9vhgFkZg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686 --- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70626&action=edit Bug 19686: (followup) Add to_api param for completeness This patch adds (yet) another param to objects.search: a reference to a to_api function to be applied when processing the search results for output. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Test count raised, and tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:42:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:42:26 +0000 Subject: [Koha-bugs] [Bug 19686] Add to_model and to_api params to objects.search helper In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19686-70-y7rNU5Omqa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|objects.search helper needs |Add to_model and to_api |a to_model param |params to objects.search | |helper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:42:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:42:38 +0000 Subject: [Koha-bugs] [Bug 19686] Add to_model and to_api params to objects.search helper In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19686-70-v2sIQIJiFz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:46:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:46:43 +0000 Subject: [Koha-bugs] [Bug 20004] Adapt /v1/cities to new naming guidelines In-Reply-To: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20004-70-iPGDo9YXFi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70628&action=edit Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:46:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:46:37 +0000 Subject: [Koha-bugs] [Bug 20004] Adapt /v1/cities to new naming guidelines In-Reply-To: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20004-70-1vYzAj2KwY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70627&action=edit Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:47:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:47:09 +0000 Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19774-70-1EsLkuPXTm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 [Bug 20004] Adapt /v1/cities to new naming guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:47:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:47:09 +0000 Subject: [Koha-bugs] [Bug 20004] Adapt /v1/cities to new naming guidelines In-Reply-To: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20004-70-Iv67JFAskC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19774 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:47:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:47:54 +0000 Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19774-70-wmjbTWMIhl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |julian.maurice at biblibre.com | |, lari.taskula at jns.fi, | |matthias.meusburger at biblibr | |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:50:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:50:22 +0000 Subject: [Koha-bugs] [Bug 20006] New: Adapt /v1/holds to new naming guidelines Message-ID: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Bug ID: 20006 Summary: Adapt /v1/holds to new naming guidelines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:51:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:51:01 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20006-70-2E6VS3V73e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19774 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | URL| |https://wiki.koha-community | |.org/wiki/Holds_endpoint_RF | |C Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:51:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:51:01 +0000 Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19774-70-aBTqhv8Inh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 [Bug 20006] Adapt /v1/holds to new naming guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:54:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:54:54 +0000 Subject: [Koha-bugs] [Bug 20004] Adapt /v1/cities to new naming guidelines In-Reply-To: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20004-70-5uHkxf0RN6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19686 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686 [Bug 19686] Add to_model and to_api params to objects.search helper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:54:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:54:54 +0000 Subject: [Koha-bugs] [Bug 19686] Add to_model and to_api params to objects.search helper In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19686-70-ONW8b2Ytq0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 [Bug 20004] Adapt /v1/cities to new naming guidelines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:57:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:57:55 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15494-70-yAYEKjqKYY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:58:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:58:01 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15494-70-8uIW17ohMz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #23 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70630&action=edit Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:57:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:57:58 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15494-70-AEmWh2Go7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68146|0 |1 is obsolete| | Attachment #68147|0 |1 is obsolete| | Attachment #68148|0 |1 is obsolete| | Attachment #68149|0 |1 is obsolete| | Attachment #70295|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70629&action=edit Bug 15494 - Unit tests prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:58:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:58:04 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15494-70-wGsTEKnVJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #24 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70631&action=edit Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 18:58:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 17:58:08 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15494-70-7chfGQFeDJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #25 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70632&action=edit Bug 15494 - Add syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 19:02:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 18:02:35 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15494-70-FHxTZsR5B4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #26 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #21) > + unless ($item) { carp "No item passed in!" && return } > Not our preferred coding style This was just copying others in this file, changed to "return unless $item" > + return () if (! $yaml =~ /\S/ ); > Just return here. Removed > + eval { > + $denyingrules = YAML::Load($yaml); > + }; > How much time are we spending on doing this? What is the performance effect? Was about .037 seconds (with 2 fields and 1000 values) Using split is about .014 seconds, okay, I switched > + return (); Yup > Why not in just one line: my $val = $item->{$field} // ''; Good point >Why not just provide an example as close as possible to the pref itself? Okay > Just curious too if this supports denying renewal on an empty string? If so, > the conversion from undef to empty string might not be what we want. Okay, can use "" or NULL for specific now (see the pref explanation) > Changing status. Please make some adjustments. Improved, squashed, sent back for SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 19:17:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 18:17:06 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18477-70-rzRzuLb23I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70231|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70633&action=edit Bug 18477: Add tests Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 19:17:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 18:17:09 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18477-70-TRc1enUcZp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63261|0 |1 is obsolete| | --- Comment #15 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70634&action=edit Bug 18477 - AR_PENDING notice does not populate values from article_requests table The default AR_PENDING letter does not print populate <<article_requests.*>> fields. Test Plan: 1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes ) 2) Search for a title, click in to catalog detail, click 'Request Article' button. 3) Select Patron 4) Fill out request information 5) Click 'Place request' 6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display. 7) Apply this patch 8) Repeat steps 2-6, not the fields now display! Signed-off-by: Eric Phetteplace <phette23 at gmail.com> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 19:18:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 18:18:14 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18477-70-2OgfAF9tq5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset at hotmail.com --- Comment #16 from M. Tompsett <mtompset at hotmail.com> --- Tests added trigger code change. Apply tests only. Test fail. Apply both patches. Test passes. This is expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 19:22:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 18:22:22 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-X3pwQ13NIO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #18 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70187 Bug 18736 - Add OrerPriceRounding syspref Review of attachment 70187: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18736&attachment=70187) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug18736_add_rounding_syspref.perl @@ +1,3 @@ > +$DBversion = 'XXX'; # will be replaced by the RM > +if( CheckVersion( $DBversion ) ) { > + # $dbh->do( "INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('OrderPriceRounding',NULL,'Local preference for rounding orders before calculations to ensure correct calculations','|nearest_cent','Choice')" ); This line is commented out. Why? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 19:28:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 18:28:16 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20006-70-es6uTcT5Qv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 19:33:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 18:33:45 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-1iz5UjqdyY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #19 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70188 Bug 18736 - Use rounding syspref to determine correct prices in calculations Review of attachment 70188: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18736&attachment=70188) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +2010,5 @@ > + > +sub _get_rounding_sql { > + my $round_string = @_; > + my $rounding_pref = C4::Context->preference('OrderPriceRounding'); > + if ( $rounding_pref eq "nearest_cent" ) { return ("ROUND($round_string,2)"); } ROUND() is not ANSI SQL. CEIL($round_string*100)/100 would be ANSI SQL 2003, I believe. ::: C4/Budgets.pm @@ +1291,5 @@ > + > +sub _get_rounding_sql { > + my $to_round = shift; > + my $rounding_pref = C4::Context->preference('OrderPriceRounding'); > + if ($rounding_pref eq 'nearest_cent') { return "ROUND($to_round,2)"; } Same problem here. Not ANSI SQL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 19:36:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 18:36:38 +0000 Subject: [Koha-bugs] [Bug 20007] New: build_browser_and_cloud.pl contains hard-coded text in French Message-ID: <bug-20007-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20007 Bug ID: 20007 Summary: build_browser_and_cloud.pl contains hard-coded text in French Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr build_browser_and_cloud.pl is not translatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:10:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:10:17 +0000 Subject: [Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16330-70-0Si3QbwA67@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: add routes to |Add routes to add, update |add, update and delete |and delete patrons |patrons | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:14:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:14:27 +0000 Subject: [Koha-bugs] [Bug 19864] UNIMARC field 100 plugin broken In-Reply-To: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19864-70-45qYcGTxbV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19866 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins, part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:14:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:14:27 +0000 Subject: [Koha-bugs] [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins , part 1 In-Reply-To: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19866-70-0snrpKnYop@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19864 |19968 CC| |mtompset at hotmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864 [Bug 19864] UNIMARC field 100 plugin broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 [Bug 19968] Undefined subroutine &Date::Calc::Today -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:14:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:14:27 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-ifFMbQwHiI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins, part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:16:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:16:01 +0000 Subject: [Koha-bugs] [Bug 19864] UNIMARC field 100 plugin broken In-Reply-To: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19864-70-Yq2rNTaQSX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |mtompset at hotmail.com Status|Needs Signoff |RESOLVED --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- *** This bug has been marked as a duplicate of bug 19968 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:16:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:16:01 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-kolqGjktx2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #7 from M. Tompsett <mtompset at hotmail.com> --- *** Bug 19864 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:26:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:26:39 +0000 Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17765-70-4iJJQ7Q5FH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:26:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:26:45 +0000 Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17765-70-DC4aZaEdDp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:29:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:29:26 +0000 Subject: [Koha-bugs] [Bug 20008] New: Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr Message-ID: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Bug ID: 20008 Summary: Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1) Set TimeFormat to 12 hour 2) Add a restriction with an expiration date via memberentry.pl 3) Note the restriction exists, but has no expiration date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:29:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:29:30 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-5zpNjmWEj8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> --- This is ready for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:29:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:29:30 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-iPGaC4KkWB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:30:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:30:28 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19814-70-OiYn84FNMh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 Martha Fuerst <mfuerst at hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #1 from Martha Fuerst <mfuerst at hmcpl.org> --- Seconding the usefulness of such a feature. -Marti -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:31:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:31:17 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-FGPYbKumDv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:31:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:31:19 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-f9lYOF8Ngk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70635&action=edit Bug 20008 - Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr Test Plan: 1) Set TimeFormat to 12 hour 2) Add a restriction with an expiration date via memberentry.pl 3) Note the restriction exists, but has no expiration date 4) Apply this patch 5) Repeat step 2 6) Note the restriction exists and has an expiration date! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:34:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:34:19 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-3pJ6D4QYdm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:40:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:40:32 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20008-70-JVyfwvoAQ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70635|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70636&action=edit Bug 20008 - Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr Test Plan: 1) Set TimeFormat to 12 hour 2) Add a restriction with an expiration date via memberentry.pl 3) Note the restriction exists, but has no expiration date 4) Apply this patch 5) Repeat step 2 6) Note the restriction exists and has an expiration date! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:44:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:44:23 +0000 Subject: [Koha-bugs] [Bug 20009] New: use Modern::Perl in Members perl scripts Message-ID: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Bug ID: 20009 Summary: use Modern::Perl in Members perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: boraccount.pl default_messageprefs.pl deletemem.pl files.pl mancredit.pl maninvoice.pl member-flags.pl member-password.pl memberentry.pl members-home.pl members-update-do.pl moremember.pl notices.pl pay.pl paycollect.pl printfeercpt.pl printinvoice.pl printslip.pl readingrec.pl routing-lists.pl setstatus.pl update-child.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:44:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:44:28 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20009-70-mJYLxLmRqn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:45:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:45:40 +0000 Subject: [Koha-bugs] [Bug 20010] New: use Modern::Perl in Patroncards perl scripts Message-ID: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Bug ID: 20010 Summary: use Modern::Perl in Patroncards perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: create-pdf.pl edit-batch.pl edit-layout.pl edit-profile.pl edit-template.pl home.pl image-manage.pl manage.pl print.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:45:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:45:47 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20010-70-klA1wTEjdS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:47:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:47:00 +0000 Subject: [Koha-bugs] [Bug 20011] New: use Modern::Perl in plugins perl scripts Message-ID: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Bug ID: 20011 Summary: use Modern::Perl in plugins perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: plugins-home.pl plugins-uninstall.pl plugins-upload.pl run.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:47:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:47:07 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20011-70-KeXHLRdRBW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:48:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:48:40 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20012-70-NrKyz8Lqy0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:48:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:48:34 +0000 Subject: [Koha-bugs] [Bug 20012] New: use Modern::Perl in Reports perl scripts Message-ID: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 Bug ID: 20012 Summary: use Modern::Perl in Reports perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: borrowers_out.pl cat_issues_top.pl catalogue_out.pl catalogue_stats.pl dictionary.pl issues_avg_stats.pl issues_stats.pl itemslost.pl manager.pl reports-home.pl serials_stats.pl stats.print.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:49:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:49:57 +0000 Subject: [Koha-bugs] [Bug 20013] New: use Modern::Perl in Reserves perl scripts Message-ID: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 Bug ID: 20013 Summary: use Modern::Perl in Reserves perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: modrequest.pl modrequest_suspendall.pl placerequest.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:50:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:50:02 +0000 Subject: [Koha-bugs] [Bug 20013] use Modern::Perl in Reserves perl scripts In-Reply-To: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20013-70-56Ajbiqu9c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:52:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:52:42 +0000 Subject: [Koha-bugs] [Bug 20014] New: When adding to basket from a staged file item budgets are selected my matching on code , not id Message-ID: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Bug ID: 20014 Summary: When adding to basket from a staged file item budgets are selected my matching on code, not id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Budget codes are not unique (duplicated on rollover) currently if you have two codes two will be marked selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:52:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:52:43 +0000 Subject: [Koha-bugs] [Bug 20015] New: use Modern::Perl in Serials perl scripts Message-ID: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 Bug ID: 20015 Summary: use Modern::Perl in Serials perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: acqui-search-result.pl acqui-search.pl checkexpiration.pl reorder_members.pl routing-preview.pl routing.pl serials-collection.pl serials-edit.pl subscription-add.pl subscription-bib-search.pl subscription-renew.pl viewalerts.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:52:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:52:51 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20015-70-OzGvpeAI9e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:53:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:53:14 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-xvuDnSwBnL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65338|0 |1 is obsolete| | CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70637&action=edit Sample SQL query to trigger bug. Revised query that works with master and default data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:55:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:55:32 +0000 Subject: [Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code , not id In-Reply-To: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20014-70-TZbrtjHzgI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 20:55:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 19:55:34 +0000 Subject: [Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code , not id In-Reply-To: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20014-70-ZOwecBy0k5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70638&action=edit Bug 20014: Preselect item budget based on id not code To test: 1 - Have the same fund code in two budgets 2 - Have budget code defined in MarcItemFieldsToOrder 3 - Stage a file with some order items as defined above 4 - Inspect the fuinds drop down in the item, notice two lines are marked selected 5 - Apply patch 6 - Repeat 7 - Only one field should be selected, with a preference for active budget -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:00:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:00:52 +0000 Subject: [Koha-bugs] [Bug 20016] New: use Modern::Perl in svc scripts Message-ID: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Bug ID: 20016 Summary: use Modern::Perl in svc scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: authentication bib bib_profile checkouts config/systempreferences import_bib new_bib -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:02:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:02:33 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-SXpbVBDRWq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- The message dialog should replace "<div class="alert alert-info">" ...with... <div class="dialog message"> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:02:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:02:47 +0000 Subject: [Koha-bugs] [Bug 20017] New: use Modern::Perl in Tools perl scripts Message-ID: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Bug ID: 20017 Summary: use Modern::Perl in Tools perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: background-job-progress.pl batchMod.pl copy-holidays.pl exceptionHolidays.pl holidays.pl import_borrowers.pl koha-news.pl letter.pl manage-marc-import.pl newHolidays.pl overduerules.pl quotes-upload.pl quotes.pl quotes/quotes-upload_ajax.pl quotes/quotes_ajax.pl scheduler.pl stage-marc-import.pl upload-cover-image.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:03:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:03:00 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20017-70-4EloPcTppJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:09:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:09:33 +0000 Subject: [Koha-bugs] [Bug 20018] New: use Modern::Perl in offline circulation perl scripts Message-ID: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Bug ID: 20018 Summary: use Modern::Perl in offline circulation perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: enqueue_koc.pl list.pl process.pl process_koc.pl service.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:09:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:09:39 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20018-70-ZkQvJaTqO7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:13:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:13:52 +0000 Subject: [Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts In-Reply-To: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20019-70-QScRCbQyDS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:13:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:13:46 +0000 Subject: [Koha-bugs] [Bug 20019] New: use Modern::Perl in miscellaneous perl scripts Message-ID: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 Bug ID: 20019 Summary: use Modern::Perl in miscellaneous perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: services/itemrecorddisplay.pl suggestion/suggestion.pl tags/list.pl tags/review.pl virtualshelves/sendshelf.pl help.pl changelanguage.pl koha_perl_deps.pl debian/bd-to-depends debian/build-git-snapshot debian/list-deps docs/CAS/CASProxy/examples/koha_webservice.pl docs/CAS/CASProxy/examples/proxy_cas.pl docs/CAS/CASProxy/examples/proxy_cas_callback.pl docs/CAS/CASProxy/examples/proxy_cas_data.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:15:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:15:59 +0000 Subject: [Koha-bugs] [Bug 20020] New: use Modern::Perl in XT scripts Message-ID: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 Bug ID: 20020 Summary: use Modern::Perl in XT scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: author/podcorrectness.t author/show-template-structure.pl author/translatable-templates.t author/valid-templates.t find-license-problems fix-old-fsf-address single_quotes.t verify-debian-docbook.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:16:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:16:04 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20020-70-Cjb6k8A2u3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:16:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:16:27 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-K6cMADsARD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:16:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:16:30 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-NDTs384xts@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70245|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70639&action=edit Bug 18497 - Use report id to retrieve saved SQL instead of passing param This patch takes some of the code when executing report and moves it to a sub to be reused when downloading To test: 1 - Run some very long report (see comment #1) 2 - Try to download, erk! 3 - Apply patch 4 - Run report, results hould not have changed 5 - Try to download, success! 6 - Ensure reports work as before https://bugs.koha-community.org/show_bug.cgi?id=18497 Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:16:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:16:31 +0000 Subject: [Koha-bugs] [Bug 20021] New: Shelving location labelled Home library in Staff interface and OPAC with Branches Message-ID: <bug-20021-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20021 Bug ID: 20021 Summary: Shelving location labelled Home library in Staff interface and OPAC with Branches Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: eb at efdss.org QA Contact: testopia at bugs.koha-community.org Created attachment 70640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70640&action=edit Incorrect label in staff interface. Home library is $c Shelving location We have a test system with branches enabled. The 952 $c (Shelving location) is consistently displaying as "Home Library" in both the staff interface and OPAC. The production system doesn't have branches enabled and 952$c displays correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:18:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:18:54 +0000 Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19818-70-CWYqEvcK9Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 --- Comment #6 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70641&action=edit Bug 19818: Fixing forbidden pattern by using spaces rather than tabs for indentation on lines 396, 492 & 495 in koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:18:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:18:52 +0000 Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19818-70-BG6MAE9Fhb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:20:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:20:04 +0000 Subject: [Koha-bugs] [Bug 20022] New: use Modern::Perl in t (test) perl scripts Message-ID: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Bug ID: 20022 Summary: use Modern::Perl in t (test) perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: 00-checkdatabase-version.t 00-deprecated.t 00-valid-xml.t AuthoritiesMarc_MARC21.t AuthoritiesMarc_UNIMARC.t Barcodes_EAN13.t Barcodes_annual.t Barcodes_hbyymmincr.t Barcodes_incremental.t Bookseller.t Budgets.t ClassSortRoutine.t ClassSortRoutine_Dewey.t ClassSortRoutine_Generic.t ClassSortRoutine_LCC.t ClassSource.t Contract.t Creators.t EdiInvoice.t Edifact.t Ediorder.t Ediordrsp.t External/Syndetics.t Form_MessagingPreferences.t Heading.t HtmlTags.t Installer_PerlDependencies.t Installer_pm.t ItemCirculationAlertPreference.t Koha_Util_MARC.t Labels.t Labels_split_ccn.t Labels_split_ddcn.t Labels_split_lccn.t Log.t Members_Attributes.t Members_Messaging.t Output.t Output_JSONStream.t Patroncards.t Patroncards_Batch.t Patroncards_Layout.t Patroncards_Lib.t Patroncards_Patroncard.t Patroncards_Profile.t Patroncards_Template.t Print.t QueryParser.t Scheduler.t Scrubber.t Stats.t SuggestionEngine.t TmplToken.t db_dependent/00-strict.t db_dependent/Amazon.t db_dependent/Heading_MARC21.t db_dependent/LDAP/test_ldap_add.pl db_dependent/Languages.t db_dependent/MungeMarcPrice.t db_dependent/Record/Record.t db_dependent/RecordProcessor_EmbedSeeFromHeadings.t db_dependent/Reports.t db_dependent/Service.t db_dependent/SuggestionEngine_ExplodedTerms.t db_dependent/Tags.t smolder_smoke_signal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:23:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:23:21 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19856-70-b7r7i1oHzC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70554|0 |1 is obsolete| | --- Comment #4 from jwayway at hotmail.com --- Created attachment 70642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70642&action=edit Bug 19856: Improve styling of reports sidebar Added divs to report-menu.inc as well. Should work on any reports page with sidebar now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:23:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:23:19 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19856-70-rvrspKvpv3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:24:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:24:11 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-IxIPNIjoGZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:24:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:24:14 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-dPlz5HbZ0q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70246|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70643&action=edit Bug 19910 - Use the delimiter syspref to name download link To test: 1 - Set delimiter syspref to anything but comma 2 - Donwload report results as comma separated text 3 - They actually follow the syspref 4 - Apply patch 5 - Download link should now match pref selection 6 - Change pref, note link changes 7 - Verify things still work as expected Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:49:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:49:55 +0000 Subject: [Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts In-Reply-To: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19991-70-EV5rW6g1XP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:49:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:49:57 +0000 Subject: [Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts In-Reply-To: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19991-70-uP04tVOqWu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70644&action=edit Bug 19991: use Modern::Perl in OPAC perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; errors/400.pl errors/401.pl errors/402.pl errors/403.pl errors/404.pl errors/500.pl opac-account-pay-paypal-return.pl opac-alert-subscribe.pl opac-authorities-home.pl opac-authoritiesdetail.pl opac-browser.pl opac-ics.pl opac-image.pl opac-imageviewer.pl opac-messaging.pl opac-modrequest-suspend.pl opac-modrequest.pl opac-mymessages.pl opac-overdrive-search.pl opac-passwd.pl opac-patron-image.pl opac-privacy.pl opac-ratings-ajax.pl opac-ratings.pl opac-readingrecord.pl opac-renew.pl opac-sendshelf.pl opac-serial-issues.pl opac-showreviews.pl opac-suggestions.pl opac-tags_subject.pl opac-topissues.pl opac-user.pl sco/help.pl sco/printslip.pl sco/sco-patron-image.pl svc/overdrive_proxy svc/suggestion unapi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:51:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:51:20 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-R5pF29HUcY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 --- Comment #13 from Grace <gracesmythh at gmail.com> --- Created attachment 70645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70645&action=edit Bug 19986: 'Server name' doesn't appear as required Test plan: [1.] Go to Admin -> z39.50/SRU servers [2.] Make a new z39.50 server [3.] Fill in the required field (hostname, port, database) [4.] Save the server [5.] Notice that the form does not submit, tells you that Sever name is required [6.] Repeat steps 2 - 5 but this time make a new SRU server [6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server and a new SRRU server) [7.] See that now 'Server name:' is red and on the right side of the box there is a required note [8.] Save both servers and it should have created a new z39.50 server and a new SRU server -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:53:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:53:00 +0000 Subject: [Koha-bugs] [Bug 19833] Kill the "biblios" In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19833-70-RuEynKbAcM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70645|0 |1 is obsolete| | --- Comment #14 from Grace <gracesmythh at gmail.com> --- Comment on attachment 70645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70645 Bug 19986: 'Server name' doesn't appear as required Sorry wrong bug number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:54:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:54:06 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn' t appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-wr7NiXWHpp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:54:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:54:24 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn' t appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-a05D5jJdna@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 --- Comment #1 from Grace <gracesmythh at gmail.com> --- Created attachment 70646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70646&action=edit Bug 19986: 'Server name' doesn't appear as required Test plan: [1.] Go to Admin -> z39.50/SRU servers [2.] Make a new z39.50 server [3.] Fill in the required field (hostname, port, database) [4.] Save the server [5.] Notice that the form does not submit, tells you that Sever name is required [6.] Repeat steps 2 - 5 but this time make a new SRU server [6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server and a new SRRU server) [7.] See that now 'Server name:' is red and on the right side of the box there is a required note [8.] Save both servers and it should have created a new z39.50 server and a new SRU server https://bugs.koha-community.org/show_bug.cgi?id=19833 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:55:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:55:29 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn' t appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-WLij7b9I4J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gracesmythh at gmail.com --- Comment #2 from Grace <gracesmythh at gmail.com> --- (In reply to Grace from comment #1) > Created attachment 70646 [details] [review] > Bug 19986: 'Server name' doesn't appear as required > > Test plan: > [1.] Go to Admin -> z39.50/SRU servers > [2.] Make a new z39.50 server > [3.] Fill in the required field (hostname, port, database) > [4.] Save the server > [5.] Notice that the form does not submit, tells you that Sever name is > required > [6.] Repeat steps 2 - 5 but this time make a new SRU server > [6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server > and a new SRRU server) > [7.] See that now 'Server name:' is red and on the right side of the box > there is a required note > [8.] Save both servers and it should have created a new z39.50 server > and a new SRU server > > https://bugs.koha-community.org/show_bug.cgi?id=19833 P.S the link was added by accident and is not relevant to this bug :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:57:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:57:14 +0000 Subject: [Koha-bugs] [Bug 20023] New: Password recovery should be case insensitive Message-ID: <bug-20023-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20023 Bug ID: 20023 Summary: Password recovery should be case insensitive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org When entering an email (or arguably, a userid) to recover the password, a user should not have to know or remember the casing of the given email. Quick exercise for a quick solution led to no results. $search_results = [ Koha::Patrons->search( { -or => { email => $email, emailpro => $email, B_email => $email } } ) ]; Using search_like is not available, and using email => { 'like', $email} does not lead to the intended result. Here's hoping a similarly simple fix exists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 21:57:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 20:57:46 +0000 Subject: [Koha-bugs] [Bug 20023] Password recovery should be case insensitive In-Reply-To: <bug-20023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20023-70-otwkPtWheh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20023 Blou <philippe.blouin at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 22:53:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 21:53:13 +0000 Subject: [Koha-bugs] [Bug 19969] Adding a manual restriction in memberentrypl with a date does not restrict the patron In-Reply-To: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19969-70-vYLOSQec8J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19969 --- Comment #4 from Kelly McElligott <kelly at bywatersolutions.com> --- Katrin, Kyle found that this was a separate issue and also created a bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Can I delete or clear this bug? Or do you need to? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 22:54:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 21:54:52 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19992-70-kNpJYJKt5C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 22:54:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 21:54:54 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19992-70-teywH3fwA4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 --- Comment #1 from jwayway at hotmail.com --- Created attachment 70647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70647&action=edit Bug-19992: use Modern::Perl in Admin perl scripts Test plan: Check use warnings; use strict doesn't exist and use Modern::Perl is written instead in the following files: admin/admin-home.pl admin/aqcontract.pl admin/aqplan.pl admin/auth_tag_structure.pl admin/branch_transfer_limits.pl admin/check_budget_parent.pl admin/check_parent_total.pl admin/checkmarc.pl admin/classsources.pl admin/clone-rules.pl admin/didyoumean.pl admin/edi_accounts.pl admin/edi_ean_accounts.pl admin/import_export_framework.pl admin/item_circulation_alerts.pl admin/marctagstructure.pl admin/matching-rules.pl admin/printers.pl admin/smart-rules.pl admin/systempreferences.pl admin/transport-cost-matrix.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 23:49:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 22:49:18 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-dlGoA85FgI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 17 23:49:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 22:49:20 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-nzssvZuKTH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #1 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70648&action=edit Bug 20000: Changing 'use strict: use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use strict; use warnings;' in the following installer perl scripts: data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:00:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:00:26 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-0hPkxLV94u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Failed to include update for fresh install, only upgrade alter table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:04:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:04:46 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-gl6Edo5rmO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70648 Bug 20000: Changing 'use strict: use warnings;' to 'use Modern::Perl;' Review of attachment 70648: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20000&attachment=70648) ----------------------------------------------------------------- ::: installer/data/mysql/labels_upgrade.pl @@ +17,4 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > +use Modern::Perl; Commented out with '# FIXME - Bug 2505' would make more sense. @@ -17,5 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > -#use strict; > -#use warnings; FIXME - Bug 2505 These are commented out. ::: installer/data/mysql/patroncards_upgrade.pl @@ +17,4 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > +use Modern::Perl; not commented? @@ -17,5 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > -#use strict; > -#use warnings; FIXME - Bug 2505 commented. ::: installer/data/mysql/update22to30.pl @@ -11,5 @@ > # - Would also be a good idea to offer to do a backup at this time... > > # NOTE: If you do something more than once in here, make it table driven. > -use strict; > -#use warnings; FIXME - Bug 2505 This is a strange case. Do we have anyone really using pre-3.0 still? I thought this script might be pointless by now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:06:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:06:48 +0000 Subject: [Koha-bugs] [Bug 19999] use Modern::Perl in Labels perl scripts In-Reply-To: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19999-70-tZwaSwwAXb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19999 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:06:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:06:50 +0000 Subject: [Koha-bugs] [Bug 19999] use Modern::Perl in Labels perl scripts In-Reply-To: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19999-70-4g2GZvo8NT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19999 --- Comment #1 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70649&action=edit Bug 19999: Replacing 'use strict; use warnings;' with 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl;' and not 'use strict; use warnings;' in the following labels perl scripts: label-create-csv.pl label-create-pdf.pl label-create-xml.pl label-edit-batch.pl label-edit-layout.pl label-edit-profile.pl label-edit-template.pl label-home.pl label-item-search.pl label-print.pl spinelabel-home.pl spinelabel-print.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:10:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:10:25 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-4OOqu6sgZW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #30 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70650&action=edit Bug 16486: Adding timestamp column to cash register statistics To test: 1) Go to Reports -> Cash Register 2) Fill in some fields and submit the report 3) Confirm the timestamp (updated) column is correct 4) Confirm there are no warns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:12:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:12:26 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: <bug-15283-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15283-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15283-70-sg04n24Gn5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:12:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:12:28 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: <bug-15283-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15283-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15283-70-wNBOlZDWwi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 --- Comment #10 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70651&action=edit Bug 15283: Switch default ISSUEQSLIP notice to Template Toolkit Please test if changes are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:20:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:20:10 +0000 Subject: [Koha-bugs] [Bug 19827] checkuniquemember is exported from C4:: Members but has been removed In-Reply-To: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19827-70-DNpSyleIBi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:20:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:20:12 +0000 Subject: [Koha-bugs] [Bug 19827] checkuniquemember is exported from C4:: Members but has been removed In-Reply-To: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19827-70-ZxebwhtCpN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827 --- Comment #1 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70652&action=edit Bug 19827: Removing &checkuniquemember from the export in C4/Members.pm Test Plan: - Check that the line &checkuniquemember has been removed from the export in C4/Members.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:24:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:24:00 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18236-70-rrenV543BD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70571|0 |1 is obsolete| | --- Comment #5 from jwayway at hotmail.com --- Created attachment 70653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70653&action=edit Bug-18236: Add classes to material type Test plan: -Following the test plan above, the class should still have 'materialtype' but also the new class: Books = mt_icon_BK Kit = mt_icon_MX Article = mt_icon_AR Mixed material = mt_icon_MX Computer files = mt_icon_CF Map = mt_icon_MP Music = mt_icon_MU Sound = mt_icon_MU Score = mt_icon_PR Visual material = mt_icon_VM -When viewing the details of a record, the material type img should also have the same changes -Check that the material type classes in the results page is the same as the details page Notes -The class names have changed from the previous patch in accordance to $materialTypeCode in MARC21slim2intranetDetail.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 00:23:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jan 2018 23:23:57 +0000 Subject: [Koha-bugs] [Bug 18236] Add classes to material type icons on result lists and detail pages In-Reply-To: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18236-70-xaTL0dFUSV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18236 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 01:32:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 00:32:27 +0000 Subject: [Koha-bugs] [Bug 19971] typo in the comments of parseQuery routine In-Reply-To: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19971-70-Oab2bIpltu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 01:32:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 00:32:29 +0000 Subject: [Koha-bugs] [Bug 19971] typo in the comments of parseQuery routine In-Reply-To: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19971-70-Y5UopWeVVt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70491|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70654&action=edit Bug 19971 Typo in the comments of parseQuery routine TEST PLAN --------- 1) Run these commands: git checkout master git pull perldoc C4::Search 2) look for parseQuery -- NOTE: The sample code provided below this heading has the wrong function name! 3) Run these commands: git checkout -b bug_19971 origin/master perldoc C4::Search 4) look for parseQuery -- NOTE: The wrong function name is corrected. 5) Run koha qa test tools Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 01:43:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 00:43:45 +0000 Subject: [Koha-bugs] [Bug 20013] use Modern::Perl in Reserves perl scripts In-Reply-To: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20013-70-R1tmIK0Udi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 01:43:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 00:43:47 +0000 Subject: [Koha-bugs] [Bug 20013] use Modern::Perl in Reserves perl scripts In-Reply-To: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20013-70-u8E8WcvPMY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 --- Comment #1 from jwayway at hotmail.com --- Created attachment 70655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70655&action=edit Bug-20013: use Modern::Perl in Reserve perl script Test plan: Check the following files that use strict; use warnings; doesn't exist and use Modern::Perl; is written instead. modrequest.pl modrequest_suspendall.pl placerequest.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 01:48:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 00:48:33 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19995-70-86XXCXb8KY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 01:48:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 00:48:35 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19995-70-aD8E3Y8Qx4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 --- Comment #1 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70656&action=edit Bug 19995: Replacing 'use strict; use warnings;' with 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl;' and not 'use strict; use warnings;' in the following catalogue perl scripts. MARCdetail.pl export.pl image.pl imageviewer.pl issuehistory.pl labeledMARCdetail.pl moredetail.pl search.pl showmarc.pl updateitem.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 01:51:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 00:51:59 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19993-70-RnYcQtGRxn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70657&action=edit Bug 19993: use Modern::Perl in Acquisition perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; acqui-home.pl addorder.pl basketgroup.pl basketheader.pl booksellers.pl check_budget_total.pl check_duplicate_barcode_ajax.pl edi_ean.pl edifactmsgs.pl edimsg.pl finishreceive.pl histsearch.pl invoice.pl invoices.pl neworderbiblio.pl neworderempty.pl newordersuggestion.pl ordered.pl orderreceive.pl parcel.pl parcels.pl pdfformat/layout2pages.pm pdfformat/layout2pagesde.pm pdfformat/layout3pages.pm pdfformat/layout3pagesfr.pm spent.pl supplier.pl uncertainprice.pl updatesupplier.pl z3950_search.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 01:51:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 00:51:57 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19993-70-uO12bLYS1E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 01:59:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 00:59:39 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20015-70-mknLl0LpKm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 --- Comment #1 from jwayway at hotmail.com --- Created attachment 70658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70658&action=edit Bug-20015: use Modern::Perl in Serials perl script Test plan: Check that use strict; use warnings; doesn't exist in the following files and use Modern::Perl; is written instead. acqui-search-result.pl acqui-search.pl checkexpiration.pl reorder_members.pl routing-preview.pl routing.pl serials-collection.pl serials-edit.pl subscription-add.pl subscription-bib-search.pl subscription-renew.pl viewalerts.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 01:59:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 00:59:37 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20015-70-eaAN0hBJCU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 02:25:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 01:25:51 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-GLdHGV18Ix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 --- Comment #1 from Grace <gracesmythh at gmail.com> --- Created attachment 70659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70659&action=edit Bug 19987: If no z39.50/SRU servers the button should not show Test plan: [1.] Load the patch and make sure you have some Z39.50/SRU servers (Administration => Z39.50/SRU servers administration) [2.] Then go to authorities and notice that the 'New from Z39.50/SRU' button is there [3.] Next go to cataloging and notice that the 'New from Z39.50/SRU' button is there too [4.] Now make sure you have no Z39.50/SRU servers (remove the servers) (Administration => Z39.50/SRU servers administration) [5.] Go to authorities and notice that the 'New from Z39.50/SRU' button is not there [6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU' button is not there too -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 02:25:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 01:25:48 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-ye71OUeDE2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 02:31:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 01:31:37 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: <bug-19943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19943-70-kbwCOlluDf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70385 Bug 19943: Koha::GetBiblioItemData - Replace existing occurrences Review of attachment 70385: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19943&attachment=70385) ----------------------------------------------------------------- ::: circ/bookcount.pl @@ +39,5 @@ > my $biblionumber = $input->param('biblionumber'); > > my $idata = itemdatanum($itm); > +my $biblio = Koha::Biblios->find( $biblionumber ); > +die "No valid biblionumber passed" unless $biblio; # FIXME A bit rude! I believe if you purposefully call bookcount.pl directly so as to trigger this, GetBiblioItemData wouldn't die this way in the old code. Also, you can only call this from an existing catalogue/moredetail.tt page. Perhaps the uglier: $data = $biblio ? $biblio->unblessed : {}; ::: t/db_dependent/Biblio.t @@ +198,5 @@ > is( $marc->subfield( $title_field, $title_subfield ), $title, ); > > + my $biblioitem = Koha::Biblioitems->find( $biblioitemnumber ); > + is( $biblioitem->_result->biblio->title, $title, # Should be $biblioitem->biblio instead, but not needed elsewhere for now > + 'Do not know if this makes sense - compare result of previous two GetBiblioData tests.'); This test was proving that the GetBiblioItemData function worked by confirming that the title set in the Biblio was the one retrieved in this function. Given that this bug patch set removes the function, I'm not sure this test is needed at all. I'd recommend removing this one test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 02:33:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 01:33:10 +0000 Subject: [Koha-bugs] [Bug 19892] Replace numbersphr variable with Koha.Preference(' OPACNumbersPreferPhrase') in OPAC In-Reply-To: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19892-70-L69xH4iztX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892 --- Comment #1 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70660&action=edit Bug 19892: Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC Test Case 1) Check that the following files have been changed properly. opac/opac-search.pl opac/opac-main.pl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt 2)Apply bug 3) Check that there are no differences in behaviour as a result of the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 02:33:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 01:33:08 +0000 Subject: [Koha-bugs] [Bug 19892] Replace numbersphr variable with Koha.Preference(' OPACNumbersPreferPhrase') in OPAC In-Reply-To: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19892-70-lA7Rrn6JWT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 02:45:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 01:45:30 +0000 Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19994-70-Meaq1JDkam@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 02:45:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 01:45:32 +0000 Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19994-70-pOje99BX9v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 --- Comment #1 from Grace <gracesmythh at gmail.com> --- Created attachment 70661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70661&action=edit Bug 19994: use Modern::Perl in Authorities perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; auth_finder.pl authorities-home.pl authorities-list.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 02:50:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 01:50:10 +0000 Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17765-70-BAXwtCBcsQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 --- Comment #3 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70662&action=edit Bug 17765: Changed variable $flags to $userflags to eliminate the issue of masking declaration in the same scope. Hides 'Holds' link on the 'Details' and 'Checkout' pages when the user does not have the permission to 'reserveforothers'. Test Plan: 1) With a user who has the permission to 'reserveforothers' check that the 'Holds' link is on the 'Details' and 'Check out' pages 2) Then with a user who does not have the permission to 'reserveforothers' check that on the 'Details' and 'Check out' pages there is no longer the 'Holds' link next to the 'Checkouts' and 'Fines & Charges' tabs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 02:50:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 01:50:08 +0000 Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17765-70-uCN0gU6KR8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 02:59:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 01:59:31 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19997-70-A4AAms21G3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 --- Comment #1 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70663&action=edit Bug 19997: use Modern::Perl in Circulation perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; bookcount.pl branchoverdues.pl branchtransfers.pl circulation.pl hold-transfer-slip.pl reserveratios.pl returns.pl selectbranchprinter.pl transfer-slip.pl transferstoreceive.pl view_holdsqueue.pl waitingreserves.pl ypattrodue-attr-search-authvalue.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 03:11:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 02:11:15 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20017-70-Kl91AGwqbO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 03:11:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 02:11:18 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20017-70-2UhS4RFqEk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 --- Comment #1 from jwayway at hotmail.com --- Created attachment 70664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70664&action=edit Bug-29917: use Modern::Perl in Tools perl scripts Test plan: Check that the following files don't contain use strict; use warnings; and have use Modern::Perl instead. background-job-progress.pl batchMod.pl copy-holidays.pl exceptionHolidays.pl holidays.pl import_borrowers.pl koha-news.pl letter.pl manage-marc-import.pl newHolidays.pl overduerules.pl quotes-upload.pl quotes.pl quotes/quotes-upload_ajax.pl quotes/quotes_ajax.pl scheduler.pl stage-marc-import.pl upload-cover-image.pl Also the credits have been added to newHolidays.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 03:12:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 02:12:16 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19997-70-sjjFXQ3HOf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70663|0 |1 is obsolete| | --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70665&action=edit Bug 19997: use Modern::Perl in Circulation perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; bookcount.pl branchoverdues.pl branchtransfers.pl circulation.pl hold-transfer-slip.pl reserveratios.pl returns.pl selectbranchprinter.pl transfer-slip.pl transferstoreceive.pl view_holdsqueue.pl waitingreserves.pl ypattrodue-attr-search-authvalue.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 03:12:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 02:12:13 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19997-70-aWsGsmcvQn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 03:44:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 02:44:42 +0000 Subject: [Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code , not id In-Reply-To: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20014-70-jJIbmq7D7w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zoebennett1308 at gmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Zoe Bennett <zoebennett1308 at gmail.com> --- We couldn't reproduce the bug we have tried putting two funds with the same code in one budget and two funds with the same code in two separate budgets and both times nothing was selected in the drop down. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 03:50:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 02:50:21 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16427-70-40ldzF4wjI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 03:50:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 02:50:24 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16427-70-PxdmgCMCxn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 --- Comment #4 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70666&action=edit Bug 16427 - Direct link to authority records missing staff detail view I added a magnigying glass icon in the staff detail view that links to the authority records. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: Topical Term. 2) When creating authority, in tab 1 under -HEADING--TOPICAL TERM enter the topical term or geographic name entry element and then save the new authority e.g. science. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 6, scroll down the - SUBJECT ADDED ENTRY--TOPICAL TERM and repeat this tag (the icon next to the title). 5) Edit the Topical term or geographic name entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your topical term e.g. science. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new topical term will be in the 'Subject(s)' list of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the topical term. 12) Click on the magnifying glass and it will take you directly to the authorities records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:01:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:01:28 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20012-70-lTdTTuA3On@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:01:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:01:30 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20012-70-oq5zQjjru6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 --- Comment #1 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70667&action=edit Bug 20012:use Modern::Perl in Reports perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; borrowers_out.pl cat_issues_top.pl catalogue_out.pl catalogue_stats.pl dictionary.pl issues_avg_stats.pl issues_stats.pl itemslost.pl manager.pl reports-home.pl serials_stats.pl stats.print.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:06:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:06:55 +0000 Subject: [Koha-bugs] [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list In-Reply-To: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19960-70-5A2vmyeNZr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:06:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:06:57 +0000 Subject: [Koha-bugs] [Bug 19960] Update popup window templates to use Bootstrap grid: Add to list In-Reply-To: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19960-70-feLmVtCnHi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19960 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70444|0 |1 is obsolete| | --- Comment #2 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70668&action=edit Bug 19960: Update popup window templates to use Bootstrap grid: Add to list This patch updates add-to-list template to use the Bootstrap grid instead of the YUI grid. To test, open the detail page for a bibliographic record in the staff client and choose "Add to -> List." The resulting pop-up window should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:17:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:17:42 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20011-70-ECUJeKDgj7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:18:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:18:04 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19998-70-tRZvnyrE4V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:17:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:17:44 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20011-70-KBL2y7hKSD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 --- Comment #1 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70669&action=edit Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins perl scripts plugins-home.pl plugins-uninstall.pl plugins-upload.pl run.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:18:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:18:06 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19998-70-hp9xbnSf8K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 --- Comment #1 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70670&action=edit Bug 19998 - use Modern::Perl in error perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; 400.pl 401.pl 402.pl 403.pl 404.pl 500.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:26:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:26:24 +0000 Subject: [Koha-bugs] [Bug 20016] use Modern::Perl in svc scripts In-Reply-To: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20016-70-bGm1xd8qYP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:26:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:26:26 +0000 Subject: [Koha-bugs] [Bug 20016] use Modern::Perl in svc scripts In-Reply-To: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20016-70-QuFWKXncKy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 --- Comment #1 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70671&action=edit Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins svc scripts authentication bib bib_profile checkouts config/systempreferences import_bib new_bib -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:33:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:33:03 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19996-70-VMFENy8T5p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:33:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:33:06 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19996-70-tWNa9YS92z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 --- Comment #1 from Grace <gracesmythh at gmail.com> --- Created attachment 70672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70672&action=edit Bug 19996: use Modern::Perl in cataloguing perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; addbiblio.pl addbooks.pl additem.pl linkitem.pl moveitem.pl value_builder/normarc_field_007.pl value_builder/normarc_field_008.pl value_builder/normarc_leader.pl value_builder/unimarc_field_010.pl value_builder/unimarc_field_100.pl value_builder/unimarc_field_105.pl value_builder/unimarc_field_106.pl value_builder/unimarc_field_110.pl value_builder/unimarc_field_115a.pl value_builder/unimarc_field_115b.pl value_builder/unimarc_field_116.pl value_builder/unimarc_field_117.pl value_builder/unimarc_field_120.pl value_builder/unimarc_field_121a.pl value_builder/unimarc_field_121b.pl value_builder/unimarc_field_122.pl value_builder/unimarc_field_123a.pl value_builder/unimarc_field_123d.pl value_builder/unimarc_field_123e.pl value_builder/unimarc_field_123f.pl value_builder/unimarc_field_123g.pl value_builder/unimarc_field_123i.pl value_builder/unimarc_field_123j.pl value_builder/unimarc_field_124.pl value_builder/unimarc_field_124a.pl value_builder/unimarc_field_124b.pl value_builder/unimarc_field_124c.pl value_builder/unimarc_field_124d.pl value_builder/unimarc_field_124e.pl value_builder/unimarc_field_124f.pl value_builder/unimarc_field_124g.pl value_builder/unimarc_field_125.pl value_builder/unimarc_field_125a.pl value_builder/unimarc_field_125b.pl value_builder/unimarc_field_126.pl value_builder/unimarc_field_126a.pl value_builder/unimarc_field_126b.pl value_builder/unimarc_field_127.pl value_builder/unimarc_field_128a.pl value_builder/unimarc_field_128b.pl value_builder/unimarc_field_128c.pl value_builder/unimarc_field_130.pl value_builder/unimarc_field_135a.pl value_builder/unimarc_field_140.pl value_builder/unimarc_field_141.pl value_builder/unimarc_field_210c.pl value_builder/unimarc_field_210c_bis.pl value_builder/unimarc_field_225a.pl value_builder/unimarc_field_4XX.pl value_builder/unimarc_field_686a.pl value_builder/unimarc_field_700-4.pl value_builder/unimarc_leader.pl z3950_auth_search.pl z3950_search.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:34:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:34:23 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20020-70-21asoToDpe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:34:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:34:26 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20020-70-Jjm5GbpNzb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 --- Comment #1 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70673&action=edit Bug 20020: use Modern::Perl in XT scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; author/podcorrectness.t author/show-template-structure.pl author/translatable-templates.t author/valid-templates.t find-license-problems fix-old-fsf-address single_quotes.t verify-debian-docbook.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:34:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:34:49 +0000 Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19994-70-lv0Dp2jGst@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gracesmythh at gmail.com Attachment #70661|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:34:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:34:49 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20018-70-QJkzMTzmg9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 --- Comment #1 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70674&action=edit Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins perl scripts enqueue_koc.pl list.pl process.pl process_koc.pl service.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:34:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:34:47 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20018-70-wO8a1dYBYB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:44:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:44:13 +0000 Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19994-70-fRZuE6lb3o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 --- Comment #2 from Grace <gracesmythh at gmail.com> --- Created attachment 70675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70675&action=edit Bug 19994: use Modern::Perl in Authorities perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; auth_finder.pl authorities-home.pl authorities-list.pl authorities.pl blinddetail-biblio-search.pl detail-biblio-search.pl detail.pl export.pl merge.pl merge_ajax.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:47:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:47:04 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20009-70-YkhyPwZZFg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:47:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:47:07 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20009-70-NXyHyn3WUS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 --- Comment #1 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70676&action=edit Bug 20009 - use Modern::Perl in Members perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; boraccount.pl default_messageprefs.pl deletemem.pl files.pl mancredit.pl maninvoice.pl member-flags.pl member-password.pl memberentry.pl members-home.pl members-update-do.pl moremember.pl notices.pl pay.pl paycollect.pl printfeercpt.pl printinvoice.pl printslip.pl readingrec.pl routing-lists.pl setstatus.pl update-child.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:51:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:51:25 +0000 Subject: [Koha-bugs] [Bug 19950] Update popup window templates to use Bootstrap grid: Serials In-Reply-To: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19950-70-nZuGw8Ddt9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:51:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:51:27 +0000 Subject: [Koha-bugs] [Bug 19950] Update popup window templates to use Bootstrap grid: Serials In-Reply-To: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19950-70-xCfrtYaHZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19950 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70418|0 |1 is obsolete| | --- Comment #2 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70677&action=edit Bug 19950: Update popup window templates to use Bootstrap grid: Serials This patch updates the two serials templates to use the Bootstrap grid instead of the YUI grid. Apply the patch and go to Serials and locate an existing subscription. - Click the "Edit routing list" in the sidebar. - Save the routing list, and click "Save and preview routing slip." - The routing slip preview should look correct and buttons should work correctly. - When viewing the details of a subscription, click the "Renew" button in the toolbar. The popup window should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:56:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:56:48 +0000 Subject: [Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons In-Reply-To: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19954-70-gH4JtN0yLT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70435|0 |1 is obsolete| | --- Comment #2 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70678&action=edit Bug 19954: Update popup window templates to use Bootstrap grid: Patrons This patch updates two patron-related templates to use the Bootstrap grid instead of the YUI grid. This patch also corrects an unrelated error in update-child.tt where some JS variable declarations required by members-menu.js were missing. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - The table of patron categories should be sortable. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:58:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:58:16 +0000 Subject: [Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons In-Reply-To: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19954-70-ajIAtz8VgL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70678|0 |1 is obsolete| | --- Comment #3 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70679&action=edit Bug 19954: Update popup window templates to use Bootstrap grid: Patrons This patch updates two patron-related templates to use the Bootstrap grid instead of the YUI grid. This patch also corrects an unrelated error in update-child.tt where some JS variable declarations required by members-menu.js were missing. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - The table of patron categories should be sortable. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 04:58:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 03:58:13 +0000 Subject: [Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons In-Reply-To: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19954-70-9vBtMxZUUg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 05:01:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 04:01:34 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20010-70-7AubTvoPSb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 05:01:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 04:01:36 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20010-70-OeHNiCerts@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 --- Comment #1 from Grace <gracesmythh at gmail.com> --- Created attachment 70680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70680&action=edit Bug 20010: use Modern::Perl in Patroncards perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; create-pdf.pl edit-batch.pl edit-layout.pl edit-profile.pl edit-template.pl home.pl image-manage.pl manage.pl print.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 06:50:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 05:50:15 +0000 Subject: [Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in In-Reply-To: <bug-17466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17466-70-2roYG6YfLg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 [Bug 20003] Result summary of remaining checkouts items not displaying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 06:50:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 05:50:15 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-pnuW3fF6cG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17466 Severity|major |normal CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Adding the bug number of the original patch for adding this feature. I also confirmed it's no longer working. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 [Bug 17466] Show number of outstanding issues when checking in -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 06:52:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 05:52:43 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/ share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-PaBvk5h0UF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Mohd, please always include some step by step information on what you did in order for the error message to show up. Thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 06:55:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 05:55:25 +0000 Subject: [Koha-bugs] [Bug 19969] Adding a manual restriction in memberentrypl with a date does not restrict the patron In-Reply-To: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19969-70-8OgXu4cLhY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19969 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kelly, you can change it to either RESOLVED INVALID or RESOLVED WORKSFORME usually, I think MOVED works ok here too. Changing it, but anyone can do. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 07:02:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 06:02:45 +0000 Subject: [Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds In-Reply-To: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17765-70-Qg3eqlAO1u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Zoe, small thing: I filed this for the result page - can you change the title of the bug to match your changes and maybe file a new one for the result list page if the problem still shows there? The titles of bugs are used for the release notes, so it's always good to give a good description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 07:19:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 06:19:40 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-3CcgCsXAQh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Sorry, silly me. I don't know exactly what happened yet, but I somehow managed to end up with empty Illbackends directories after the initial cloning (had checked contents then). So it's right, Base.pm was absolutely not there. I think some unintentional git magic. There is no RESOLVED SILLYME, so picking INVALID :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 07:28:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 06:28:31 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-5XlMS9fnj3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILL: Adding a 'new request' |ILL: Adding a 'new request' |is not possible |from OPAC is not possible Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The problem with the broken button in OPAC remains: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?method=create&backend=ARRAY(0xa943760) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 08:04:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 07:04:52 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-GSIlGDLcGY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This appears to get the split button in OPAC working, not a good fix, but a clue on how to fix it maybe: <div id="illrequests-create-button" class="dropdown btn-group"> - [% IF backends.size > 1 %] + [% IF backends.0.size > 1 %] [...] Now stuck with: Template process failed: file error - : not found at /home/vagrant/kohaclone/C4/Templates.pm line 122. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 08:23:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 07:23:37 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/ share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-BpqExD0V5W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #2 from Mohd Hafiz Yusoff <mhby87 at gmail.com> --- I test Some error show when patron borrow over 80 item. But not all patron have this error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 08:55:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 07:55:07 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-0gaIXOKKrQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #203 from Julian Maurice <julian.maurice at biblibre.com> --- test git bz edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 09:04:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 08:04:31 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/ share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-eBNJeb868D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #3 from Mohd Hafiz Yusoff <mhby87 at gmail.com> --- On summary-print.pl line 107 $row{'itemtype_description'} = $itemtype->description; #FIXME Should not it be translated_description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 09:05:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 08:05:43 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-ysRJiOoWXK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 09:05:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 08:05:45 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-mG6cRdYP6g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 70681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70681&action=edit Bug 20003: Fix showing number of remaining checkouts during checking in Test plan: 0) Do not apply the patch 1) Have a patron with more then one checkout 2) Return one of patron's checkout and confirm the remaining number of checkout is not shown 3) Apply the patch 4) Try it again and confirm the number is now shown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 09:07:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 08:07:28 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-LESr2LAgma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 10:29:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 09:29:54 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: <bug-19008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19008-70-Vp3U1UZ5W9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 10:47:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 09:47:36 +0000 Subject: [Koha-bugs] [Bug 20024] New: Backup files should be encrypted Message-ID: <bug-20024-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20024 Bug ID: 20024 Summary: Backup files should be encrypted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: josef.moravec at gmail.com, katrin.fischer at bsz-bw.de, magnus at libriotech.no, paul.poulain at biblibre.com, rbit at rbit.cz Blocks: 18081 File produced by koha-dump should be encrypted. It contents personal data. It's GDPR related stuff. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 10:47:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 09:47:36 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-8a6n59ZYmv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20024 [Bug 20024] Backup files should be encrypted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 10:50:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 09:50:23 +0000 Subject: [Koha-bugs] [Bug 20025] New: Running of koha-* scripts should be logged Message-ID: <bug-20025-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20025 Bug ID: 20025 Summary: Running of koha-* scripts should be logged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: josef.moravec at gmail.com, katrin.fischer at bsz-bw.de, magnus at libriotech.no, paul.poulain at biblibre.com, rbit at rbit.cz, robin at catalyst.net.nz Blocks: 18081 GDPR related. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 10:50:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 09:50:23 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-zvOKhV4rS1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20025 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20025 [Bug 20025] Running of koha-* scripts should be logged -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 10:52:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 09:52:16 +0000 Subject: [Koha-bugs] [Bug 20025] Running of koha-* scripts should be logged In-Reply-To: <bug-20025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20025-70-26dDeocOIP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20025 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Mike, can you give an example of a script to be logged? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 10:56:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 09:56:15 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-8TsvAjsrYj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 11:03:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 10:03:00 +0000 Subject: [Koha-bugs] [Bug 20026] New: Add new permission related to personal data Message-ID: <bug-20026-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20026 Bug ID: 20026 Summary: Add new permission related to personal data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, josef.moravec at gmail.com, katrin.fischer at bsz-bw.de, magnus at libriotech.no, paul.poulain at biblibre.com, rbit at rbit.cz Blocks: 18081 Add new permission related to personal data. We should grant access to personal data at reports, plugins etc. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 11:03:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 10:03:00 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-xzcsdYVGj0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20026 [Bug 20026] Add new permission related to personal data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 11:09:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 10:09:47 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-uj5w7OlxWS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18242, 18003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 [Bug 18242] Move of checkouts to old_issues is not handled correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 11:09:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 10:09:47 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: <bug-18003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18003-70-lkXdIqwyml@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 11:09:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 10:09:47 +0000 Subject: [Koha-bugs] [Bug 18242] Move of checkouts to old_issues is not handled correctly In-Reply-To: <bug-18242-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18242-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18242-70-5BhwFpyVRY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 11:31:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 10:31:14 +0000 Subject: [Koha-bugs] [Bug 20027] New: Generate password at patron detail edit page Message-ID: <bug-20027-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20027 Bug ID: 20027 Summary: Generate password at patron detail edit page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, josef.moravec at gmail.com, katrin.fischer at bsz-bw.de, kyle.m.hall at gmail.com, magnus at libriotech.no, paul.poulain at biblibre.com, rbit at rbit.cz Blocks: 18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 11:31:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 10:31:14 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-8EtcuvF5hx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20027 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20027 [Bug 20027] Generate password at patron detail edit page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 11:31:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 10:31:50 +0000 Subject: [Koha-bugs] [Bug 20027] Generate password at patron detail edit page In-Reply-To: <bug-20027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20027-70-u2VokH3loj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20027 --- Comment #1 from Mike <black23 at gmail.com> --- Same like Change password page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 11:51:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 10:51:08 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-1rUbDO0Fmi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 [Bug 20028] Export all petron related personal data in one package -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 11:51:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 10:51:08 +0000 Subject: [Koha-bugs] [Bug 20028] New: Export all petron related personal data in one package Message-ID: <bug-20028-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Bug ID: 20028 Summary: Export all petron related personal data in one package Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, josef.moravec at gmail.com, katrin.fischer at bsz-bw.de, kyle.m.hall at gmail.com, magnus at libriotech.no, mirko at abunchofthings.net, paul.poulain at biblibre.com, rbit at rbit.cz Blocks: 18081 At least in CVS, maybe in JSON or other machnine readable formats. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 12:06:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 11:06:06 +0000 Subject: [Koha-bugs] [Bug 19325] Enable padding of printed barcodes In-Reply-To: <bug-19325-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19325-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19325-70-oCupc1hLL9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 12:16:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 11:16:57 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17229-70-FjPggr85QN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62036|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 70682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70682&action=edit Bug 17229: Check if patron is expired in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 12:17:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 11:17:01 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17229-70-M3zuBAlcBu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62037|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 70683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70683&action=edit Bug 17229: Add unit test for BlockExpiredPatronOpacActions check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 12:17:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 11:17:06 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-kobJUXV64a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Needs Signoff |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looks like this is a Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 12:17:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 11:17:36 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17229-70-5FoEJbFg8V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 12:30:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 11:30:09 +0000 Subject: [Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is debarred In-Reply-To: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17247-70-Ijj2vqCYET@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55174|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 70684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70684&action=edit Bug 17247: Check if patron is debarred in CanItemBeReserved This way, calls to ILS-DI HoldTitle and HoldItem do this check too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 12:32:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 11:32:26 +0000 Subject: [Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is debarred In-Reply-To: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17247-70-uhAjrOSoh7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> --- Hi H?ctor, I cannot reproduce the error in comment 2, and the tests pass for me. Can you try again ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 12:56:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 11:56:24 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-fh9Gm4H0Cg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 12:56:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 11:56:27 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-rcS92YEZh2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70685&action=edit Bug 9634 [QA Followup] - Add new column to kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 12:58:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 11:58:07 +0000 Subject: [Koha-bugs] [Bug 20028] Export all patron related personal data in one package In-Reply-To: <bug-20028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20028-70-LCvsg61Fyc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Mike <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Export all petron related |Export all patron related |personal data in one |personal data in one |package |package -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 13:56:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 12:56:40 +0000 Subject: [Koha-bugs] [Bug 20021] Shelving location labelled Home library in Staff interface and OPAC with Branches In-Reply-To: <bug-20021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20021-70-40PurnIAXg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20021 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70686&action=edit Screenshot showing shelving location under library name It looks like there's a problem with either your branch data or the item data. Shelving location is usually displayed under the branch information (see attached). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:07:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:07:06 +0000 Subject: [Koha-bugs] [Bug 19661] Funds endpoint In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-PMjmVOPDnb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I think this work needs a review, as some (relevant) attributes are missing on the fund definition: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/Schema/Result/Aqbudget.pm;h=12a8c8d730afe8a1557e836742a7cafd33255388;hb=HEAD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:26:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:26:11 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-4L2eR2FP8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #31 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:26:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:26:40 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-WoUAYITlwo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:26:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:26:47 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-0obJ6DNCwN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:26:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:26:53 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-3yQ2SOqRcF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70582|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:26:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:26:59 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-mIaDLJNHBl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:27:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:27:05 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-2j0w4ZvJP8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:27:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:27:15 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-zJX031owvD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #32 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 70687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70687&action=edit Bug 16486: Display the timestamp for account payments/writeoffs To test: 1) Apply patch 2) Go to the patron account page, Fines tab 3) Click Account tab 4) Confirm timestamp shows next to payments and writeoffs 5) Go to Admin -> TimeFormat syspref, change the format 6) Refresh the fines page, confirm time format changes Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:27:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:27:19 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-2FFJBNnR27@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #33 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 70688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70688&action=edit Bug 16486: [FOLLOW-UP] Putting time in date column In reply to Comment 6, I have moved the time into a column separate from the description. Unfortunately the timestamp has the date and the time, so I figured it was easier to just have them in the same column and replace the original date column. Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:27:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:27:23 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-ndKGxhfiO5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #34 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 70689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70689&action=edit Bug 16486: [FOLLOW-UP] Adding timestamp to date in other places As suggested in Comment 7. The timestamp has also been added to printfeercpt.tt, printinvoice.tt, and opac-account.tt To test: 1) In Staff side, go to member account, go to Fines, go to Account tab 2) Click the Print button next to a payment 3) Confirm timestamp shows on print slip 4) Create a manual invoice 5) Go back to the Account tab 6) Click the Print button next to the invoice 7) Confirm timestamp shows on print slip 8) Log into OPAC 9) Go to your fines 10) Confirm timestamp shows Works as intended. Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:27:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:27:27 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-BbKGW3wV3h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #35 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 70690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70690&action=edit Bug 16486: [FOLLOW-UP] Show original date and timestamp for fines This patch has two columns in fines tables, one showing the original date and one showing the timestamp (when the patch was last updated) Fixed merge conflicts Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 14:27:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 13:27:30 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-Lx5TZNzCjS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 --- Comment #36 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 70691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70691&action=edit Bug 16486: Adding timestamp column to cash register statistics To test: 1) Go to Reports -> Cash Register 2) Fill in some fields and submit the report 3) Confirm the timestamp (updated) column is correct 4) Confirm there are no warns Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:00:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:00:10 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-TZclVijJbG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Does this patch depend on another one? It doesn't apply for me on master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:08:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:08:08 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-ccqMALgJ9M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 --- Comment #7 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 69837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69837 Bug 19771: Fix crashing in pending offline circulation actions list Review of attachment 69837: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19771&attachment=69837) ----------------------------------------------------------------- ::: offline_circ/list.pl @@ +50,5 @@ > + if ($item) { > + my $biblio = $item->biblio; > + $_->{'bibliotitle'} = $biblio->title; > + $_->{'biblionumber'} = $biblio->biblionumber; > + } Uses same type of logic as $patron below. Nice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:11:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:11:51 +0000 Subject: [Koha-bugs] [Bug 20029] New: Verbosity issue that makes the QA tools test suite report 2 failures Message-ID: <bug-20029-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20029 Bug ID: 20029 Summary: Verbosity issue that makes the QA tools test suite report 2 failures Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: QA tools Assignee: jonathan.druart at bugs.koha-community.org Reporter: victor.grousset at biblibre.com 1. On a fresh Jessie DevBox 2. As vagrant, allow the kohadev-koha user to run the QA tool test suite sudo chown -R kohadev-koha /home/koha/qa-test-tools 3. kshell 4. cd /home/koha/qa-test-tools 5. prove -v t/Perl.t 6. Then you should see two failures According to Joubu: > it is just an output issue I guess > try `qa -c 1 -v 1` and `qa -c 1 -v 2` > the output is the same, -v 1 should only display the filename, not the details Results of this test ################################################################### kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ qa -c 1 -v 1 testing 1 commit(s) (applied to e1770d0 'Bug 19973: Fix SQL syntax error in uk') Processing files before patches |========================>| 1 / 1 (100.00%) Processing files after patches |========================>| 1 / 1 (100.00%) OK cataloguing/value_builder/unimarc_field_100.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ qa -c 1 -v 2 testing 1 commit(s) (applied to e1770d0 'Bug 19973: Fix SQL syntax error in uk') Processing files before patches |========================>| 1 / 1 (100.00%) Processing files after patches |========================>| 1 / 1 (100.00%) OK cataloguing/value_builder/unimarc_field_100.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid ################################################################### -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:19:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:19:13 +0000 Subject: [Koha-bugs] [Bug 20030] Authority merge does not always fill $2 correctly In-Reply-To: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20030-70-k73lDVKqST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20030 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:18:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:18:59 +0000 Subject: [Koha-bugs] [Bug 20030] New: Authority merge does not always fill $2 correctly Message-ID: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20030 Bug ID: 20030 Summary: Authority merge does not always fill $2 correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org >From bug 14769. Trying to separate both issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:21:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:21:48 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-QwAtDjAs2w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I could rebase this one as-is, but I'd rather separate the $2 issue from filling the indicators in general. I opened up report 20030 for the $2 issue and would like to submit them separately. Janusz: Please let me know if you see any issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:26:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:26:04 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16427-70-Djso3dkOYm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- This looks good, but can I suggest one minor edit? I think a little space before the icon would improve readability: <xsl:if test="marc:subfield[@code=9]"> + <xsl:text> </xsl:text> <a class='authlink'> The XSL usually ignores whitespace, so the <xsl:text> block can put a single space before the icon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:26:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:26:38 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16427-70-4A427z6vyI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |terauhina.jackson at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:40:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:40:04 +0000 Subject: [Koha-bugs] [Bug 20031] New: CGI param in list context warn in guided_reports.pl Message-ID: <bug-20031-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20031 Bug ID: 20031 Summary: CGI param in list context warn in guided_reports.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:44:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:44:41 +0000 Subject: [Koha-bugs] [Bug 20031] CGI param in list context warn in guided_reports.pl In-Reply-To: <bug-20031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20031-70-tUrWjPBbxt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20031 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:44:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:44:43 +0000 Subject: [Koha-bugs] [Bug 20031] CGI param in list context warn in guided_reports.pl In-Reply-To: <bug-20031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20031-70-8xRs0SqapS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20031 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70692&action=edit Bug 20031: CGI param in list context warn in guided_reports.pl Resolve warn: CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_shadowclone_reports_guided_reports_2epl line 794, this can lead to vulnerabilities. [NOTE: line number from older Koha version.] Test plan: Looking at this change should convince you already. Another look at this routine in C4/Output.pm would be bonus. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:45:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:45:01 +0000 Subject: [Koha-bugs] [Bug 20031] CGI param in list context warn in guided_reports.pl In-Reply-To: <bug-20031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20031-70-42mFA7aM8O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20031 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:52:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:52:50 +0000 Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19289-70-rohov4oyma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #16 from Nicolas Legrand <nicolas.legrand at bulac.fr> --- is it me or there is a catalog_details.js that should be there and is not? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:57:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:57:33 +0000 Subject: [Koha-bugs] [Bug 20030] Authority merge does not always fill $2 correctly In-Reply-To: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20030-70-JxQ9fENORn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20030 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 15:57:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 14:57:40 +0000 Subject: [Koha-bugs] [Bug 20030] Authority merge does not always fill $2 correctly In-Reply-To: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20030-70-VO6Ufd8Dkf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20030 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:02:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:02:39 +0000 Subject: [Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities In-Reply-To: <bug-19983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19983-70-YQ6ilWfXUh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:02:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:02:41 +0000 Subject: [Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities In-Reply-To: <bug-19983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19983-70-jm6E8MHHzg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70693&action=edit Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:12:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:12:31 +0000 Subject: [Koha-bugs] [Bug 14461] API authentication for SwaggerUI In-Reply-To: <bug-14461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14461-70-Hd0XptUa0m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14461 Bug 14461 depends on bug 14458, which changed state. Bug 14458 Summary: Add SwaggerUI documentation for RESTful API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14458 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:12:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:12:30 +0000 Subject: [Koha-bugs] [Bug 14458] Add SwaggerUI documentation for RESTful API In-Reply-To: <bug-14458-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14458-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14458-70-O9vAUuyzeD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14458 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Assignee|julian.maurice at biblibre.com |koha-bugs at lists.koha-commun | |ity.org Status|In Discussion |RESOLVED --- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> --- Closing this as I doubt it is wanted in Koha. But feel free to reopen if you think otherwise. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:12:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:12:43 +0000 Subject: [Koha-bugs] [Bug 14461] API authentication for SwaggerUI In-Reply-To: <bug-14461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14461-70-eJYIbXh7yA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14461 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:14:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:14:32 +0000 Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets In-Reply-To: <bug-11176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11176-70-d9qUWM5WHH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Maura Stephens <maura.stephens at gmit.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maura.stephens at gmit.ie --- Comment #5 from Maura Stephens <maura.stephens at gmit.ie> --- I would very much support some work to be done on this bug and this issue gaining some traction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:27:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:27:26 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-WcMUPHNEAv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #8 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Matthias Meusburger from comment #6) > Your patch works well, it prevents from crashing on a unknown barcode. > > However, I couldn't reproduce the crash on a payment. I will revise test plan so it is explicitly clear. I confirmed it does fail on payments. I am also pleased to announce that FINALLY, I RTFM'd regarding the offline client, and am much happier about it now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:28:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:28:05 +0000 Subject: [Koha-bugs] [Bug 20032] New: Switch single-column templates to Bootstrap grid: Tools Message-ID: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 Bug ID: 20032 Summary: Switch single-column templates to Bootstrap grid: Tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: dcook at prosentient.com.au, josef.moravec at gmail.com, misilot at fit.edu, nengard at gmail.com, testopia at bugs.koha-community.org Blocks: 19980 There are several single-column templates in the Tools section which can be updated to use Bootstrap: batchMod-del.tt batchMod-edit.tt koha-news.tt letter.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:28:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:28:05 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-dpYfUIeiGZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 [Bug 20032] Switch single-column templates to Bootstrap grid: Tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:33:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:33:31 +0000 Subject: [Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities In-Reply-To: <bug-19983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19983-70-6ZN7BwLuWF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:33:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:33:46 +0000 Subject: [Koha-bugs] [Bug 20032] Switch single-column templates to Bootstrap grid: Tools In-Reply-To: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20032-70-jqTyLPA3ql@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:38:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:38:57 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-XiQCmngybP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #19 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- (In reply to M. Tompsett from comment #13) > Failed QA test tools. It passed for me. Did I make any mistake? ########################################################## kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ git show HEAD commit 50d3119a32ce0f8ecb0ab88404975f9cfab03b43 Author: Victor Grousset <victor.grousset at biblibre.com> Date: Wed Jan 10 16:07:36 2018 +0100 Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" ################################################################# kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ qa -v 1 -c 1 testing 1 commit(s) (applied to 94cd276 'Bug 19918: Close span tag in opac-reg') Processing files before patches |========================>| 6 / 6 (100.00%) Processing files after patches |========================>| 6 / 6 (100.00%) OK koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/basket.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/basketgroup.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/lateorders.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/basket.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/basketgroup.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/lateorders.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template ################################################################# -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:41:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:41:29 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-2rzdMiz44q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #20 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Tested also with current master without error. commit 129ffee791da9f8ab4ad85a4473a138fc81ccbef Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jan 15 10:10:41 2018 -0300 Bug 19968: Add missing use Date::Calc statement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:46:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:46:31 +0000 Subject: [Koha-bugs] [Bug 20032] Switch single-column templates to Bootstrap grid: Tools In-Reply-To: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20032-70-ZblRwz0TIL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:46:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:46:33 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-XAJGZ2t53g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #21 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- (In reply to Katrin Fischer from comment #17) > It's missing steps. > > - you need to update the po files after the patch was applied > - you have to check that the string got not marked as 'fuzzy' > - you have to reinstall the language > > Only then the test gives you a correct result. I don't get, isn't this covered in the steps 18? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:46:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:46:34 +0000 Subject: [Koha-bugs] [Bug 20032] Switch single-column templates to Bootstrap grid: Tools In-Reply-To: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20032-70-WuCYDtgfmG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70694&action=edit Bug 20032: Switch single-column templates to Bootstrap grid: Tools This patch updates several single-column Tools templates to use the Bootstrap grid. - batchMod-del.tt - Tools -> Batch item deletion -> Submit barcodes or item numbers for deletion. The grid is changed for the results and confirmation screens. - batchMod-edit.tt - Tools -> Batch item modification -> Submit barcodes or item numbers for modification. The grid is changed for the results and confirmation screens. - koha-news.tt - Tools -> News -> Edit or create a new news item. The grid is changed for the edit screen. - letter.tt - Tools -> Notices and Slips -> Edit or create a notice. The grid is changed for the edit screen. Each of these pages should look correct. The News and Notices page should have a single centered column with wide margins on either side. At lower browser widths the margins should disappear. The batch mod screens should be displayed at full screen width. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:48:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:48:01 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-xYYBK0nP2Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69837|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70695&action=edit Bug 19771: Fix crashing in pending offline circulation actions list When the barcode is empty or invalid, an "Internal Server Error" is triggered on the kohadev box. TEST PLAN --------- 0) back up your database if you care about it. 1) Run the following commands: git checkout master git pull git checkout -b bug_19771 origin/master git bz apply 19771 -- This should be quite uneventful. Standard promptings. 2) Continue to run the following commands: git checkout master reset_all sudo koha-shell -c bash kohadev ./misc/cronjobs/create_te_koc_db.pl --sqlite3 -- This will create a borrowers.db in your current directory. 3) On the host where you intend on running the koct install it. -- https://sourceforge.net/projects/koha-oc/files/ download and install. 4) get the borrowers.db file to your host where you installed koct 5) point koct at the file you downloaded Database -> Select Borrowers DB File 6) Create a .koc file with the following transactions. check in, check out, check in (bad barcode), pay fines (any non-zero amount). 7) Run the following commands: restart_all -- we want to make sure caching for plack isn't in the way. 8) In the staff client: Home -> Circulation -> Upload offline circulation file (.koc) 9) Choose the file created and click 'Upload file'. 10) Add to offline circulation queue. 11) View pending offline circulation actions -- This should die. Reading /var/log/koha/kohadev/plack-error.log should be the same error as comment #0. However, this was only the bad biblio error. 12) Run the following commands: git checkout bug_19771 restart_all 13) Refresh staff client page. -- it should all come up. 14) Select the bad biblio line, and delete it. 15) Run the following commands: git checkout master restart_all 16) Refresh the staff client page. -- it should die. Same error as comment #0. This confirms the fine payment issue. 17) Run the following commands git checkout bug_19771 restart_all 18) Refresh the staff client page. -- it should all come up. 19) run the koha qa test tools 20) if you backed up your database, restore it. :) Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:50:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:50:00 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-Ft0vbCjBMn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:50:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:50:04 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-5dqNwKt6qg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70696&action=edit Bug 20001: Fix confusion between array and arrayref Illrequest->available_backends always returned only 1 element -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:51:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:51:13 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-HhmPfs4Gjt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:52:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:52:56 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-WjsTaZOZ09@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|victor.grousset at biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 16:56:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 15:56:19 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-bmDeSEtVLp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:00:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:00:43 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-qC8ZULEyZN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- > 3) On the host where you intend on running the koct install it. > -- https://sourceforge.net/projects/koha-oc/files/ > download and install. https://koha-community.org/manual/18.05/en/html/05_circulation.html#offline-circ-tool-for-windows-label I didn't read this. This is the newer KOCT. Still, doesn't change the test plan. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:06:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:06:00 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-JTswXBimlP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20033 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20033 [Bug 20033] Switch single-column templates to Bootstrap grid: Catalog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:06:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:06:00 +0000 Subject: [Koha-bugs] [Bug 20033] New: Switch single-column templates to Bootstrap grid: Catalog Message-ID: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20033 Bug ID: 20033 Summary: Switch single-column templates to Bootstrap grid: Catalog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 19980 There are a few single-column catalog-related templates which can be updated to use Bootstrap: basket\basket.tt catalogue\advsearch.tt catalogue\itemsearch.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:13:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:13:22 +0000 Subject: [Koha-bugs] [Bug 20033] Switch single-column templates to Bootstrap grid: Catalog In-Reply-To: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20033-70-2IHOaqMR0l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20033 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:13:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:13:25 +0000 Subject: [Koha-bugs] [Bug 20033] Switch single-column templates to Bootstrap grid: Catalog In-Reply-To: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20033-70-g7rhVxR58Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20033 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70697&action=edit Bug 20033: Switch single-column templates to Bootstrap grid: Catalog This patch updates a few catalog-related single-column templates to use the Bootstrap grid. - basket/basket.tt - The staff client cart. Add some items to the cart and open the cart. - catalogue/advsearch.tt - The advanced search page. - catalogue/itemsearch.tt - The item search page, both the initial form and the search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:23:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:23:25 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-SMk4RBDLPI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Victor Grousset/tuxayo from comment #19) > (In reply to M. Tompsett from comment #13) > > Failed QA test tools. > > It passed for me. Did I make any mistake? Nope. It would seem I did. It passed after: sudo koha-shell -c bash kohadev ~vagrant/qa-test-tools/koha-qa.pl -v 2 -c 1 But running it from vagrant directly does not exit qa -v 2 -c 1 As for comment #21, I will leave QA to pass or fail it. I'm signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:24:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:24:22 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-gKKigG5H6N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70426|0 |1 is obsolete| | --- Comment #23 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70698&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:24:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:24:19 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-wMRkQTJmWj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:32:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:32:05 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-9Rw3s2L07o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70696 Bug 20001: Fix confusion between array and arrayref Review of attachment 70696: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20001&attachment=70696) ----------------------------------------------------------------- ::: Koha/Illrequest.pm @@ +478,4 @@ > > sub available_backends { > my ( $self ) = @_; > + my $backends = $self->_config->available_backends; YIKES! Line 117 of Koha/Illrequest/Config.pm in available_backends returns \@backends, which should be this, and not what it was. Nice fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:42:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:42:26 +0000 Subject: [Koha-bugs] [Bug 20034] New: Switch single-column templates to Bootstrap grid: Circulation Message-ID: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20034 Bug ID: 20034 Summary: Switch single-column templates to Bootstrap grid: Circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 19980 There are two single-column Circulation templates which can be updated to use Bootstrap: article-requests.tt circulation-home.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 17:42:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 16:42:26 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-Qr8dVj3HiI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20034 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20034 [Bug 20034] Switch single-column templates to Bootstrap grid: Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:01:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:01:30 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-pT4ak5CIbi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #11 from M. Tompsett <mtompset at hotmail.com> --- I can't sign off, because I can't figure out how to set up my koha-conf.xml file for inter-library loans. Anyone have documentation or links? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:01:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:01:35 +0000 Subject: [Koha-bugs] [Bug 20034] Switch single-column templates to Bootstrap grid: Circulation In-Reply-To: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20034-70-oRlBQI18TD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20034 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:01:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:01:37 +0000 Subject: [Koha-bugs] [Bug 20034] Switch single-column templates to Bootstrap grid: Circulation In-Reply-To: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20034-70-e6izgwtyHi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20034 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70699&action=edit Bug 20034: Switch single-column templates to Bootstrap grid: Circulation This patch updates two single-column circulation templates to use the Bootstrap grid. - circulation-home.tt - Circulation home page. This patch corrects what appears to have been a long-broken three-column layout. - article-requests.tt - Article requests list. Turn on the ArticleRequests system preference if necessary. Go to Circulation -> Article requests. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:18:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:18:58 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-IzZlmeQQ4e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #12 from M. Tompsett <mtompset at hotmail.com> --- (In reply to M. Tompsett from comment #11) > I can't sign off, because I can't figure out how to set up my koha-conf.xml > file for inter-library loans. Anyone have documentation or links? Bug 7317 comment #20 was helpful for addressing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:31:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:31:30 +0000 Subject: [Koha-bugs] [Bug 20035] New: Switch single-column templates to Bootstrap grid: Patron clubs Message-ID: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Bug ID: 20035 Summary: Switch single-column templates to Bootstrap grid: Patron clubs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 19980 There are two single-column Patron clubs templates which can be updated to use Bootstrap: clubs\clubs-add-modify.tt clubs\templates-add-modify.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:31:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:31:30 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-6PThnp7IZU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20035 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 [Bug 20035] Switch single-column templates to Bootstrap grid: Patron clubs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:36:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:36:17 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-qLEBCmWOZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70696|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70700&action=edit Bug 20001: Fix confusion between array and arrayref Illrequest->available_backends always returned only 1 element TEST PLAN --------- See bug 7317 comment #20 for configuring ILL Make sure to restart_all Strangely, ILLIBS didn't exist, but IL did in default install, so use that as the patron code in your koha-conf.xml Make sure to turn on the ILL related system preference. 1) Configure ILL. -- this is the hard part. Hopefully the above will give you enough. 2) open OPAC and log in 3) Click the 'your interlibrary loan request' in the left pane 4) Click the 'Create a new request' button. -- when you hover your mouse over the links for the backends, they will have ARRAY(...) instead of a meaningful name. This is what triggers the error (see comment #7). 5) Run the following commands git checkout -b bug_20001 origin/master git bz apply 20001 reset_all 6) Refresh the OPAC page, and repeat step 4. -- when hovering your mouse over the links for the backends, they will have meaningful values now. 7) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:39:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:39:41 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-YrO2Bj1LEH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:39:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:39:44 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-CXkq7GcM7k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70700|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70701&action=edit Bug 20001: Fix confusion between array and arrayref Illrequest->available_backends always returned only 1 element TEST PLAN --------- See bug 7317 comment #20 for configuring ILL Make sure to restart_all Strangely, ILLIBS didn't exist, but IL did in default install, so use that as the patron code in your koha-conf.xml Make sure to turn on the ILL related system preference. 1) Configure ILL. -- this is the hard part. Hopefully the above will give you enough. 2) open OPAC and log in 3) Click the 'your interlibrary loan request' in the left pane 4) Click the 'Create a new request' button. -- when you hover your mouse over the links for the backends, they will have ARRAY(...) instead of a meaningful name. This is what triggers the error (see comment #7). 5) Run the following commands git checkout -b bug_20001 origin/master git bz apply 20001 restart_all 6) Refresh the OPAC page, and repeat step 4. -- when hovering your mouse over the links for the backends, they will have meaningful values now. 7) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:41:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:41:06 +0000 Subject: [Koha-bugs] [Bug 20035] Switch single-column templates to Bootstrap grid: Patron clubs In-Reply-To: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20035-70-PvXK0fbhQq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:41:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:41:08 +0000 Subject: [Koha-bugs] [Bug 20035] Switch single-column templates to Bootstrap grid: Patron clubs In-Reply-To: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20035-70-vK2WO5UCSA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70702&action=edit Bug 20035: Switch single-column templates to Bootstrap grid: Patron clubs This patch updates two single-column Patron clubs templates to use the Bootstrap grid. - clubs/clubs-add-modify.tt - Tools -> Patron clubs -> New club. - clubs/templates-add-modify.tt - Tools -> Patron clubs -> New club template. Also changed in this file: Markup corrections. Label "for" attribute should match the form field's id attribute. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:45:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:45:46 +0000 Subject: [Koha-bugs] [Bug 19873] Make it possible to search on value 0 In-Reply-To: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19873-70-N4bS2nfdvE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70122 Bug 19873 - Ability to search on 0 value Review of attachment 70122: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19873&attachment=70122) ----------------------------------------------------------------- ::: C4/Search.pm @@ +1532,4 @@ > for ( my $i = 0 ; $i <= @operands ; $i++ ) { > > # COMBINE OPERANDS, INDEXES AND OPERATORS > + if ( $operands[$i] ne '' ) { perhaps a $operands[$i] // q{} ne q{} would be in order. We don't want floody logs if $operands[$i] is undef. @@ +1677,4 @@ > query_desc => $query_desc, > operator => ($operators[ $i - 1 ]) ? $operators[ $i - 1 ] : '', > parsed_operand => $operand, > + original_operand => ($operands[$i] ne '') ? $operands[$i] : '', perhaps a $operands[$i] // q{} is sufficient? We don't want floody logs if $operands[$i] is undef. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:48:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:48:47 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-hXagpJHVJO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- One would hope this case never happens. And if it does, stop editing the files on a live system. That being said, this is a straight-forward regexp tightening. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:54:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:54:22 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-T9bGY1lvHb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:54:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:54:24 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-s9U4BXZupg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70548|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70703&action=edit Bug 19977: Open only .pref files in Local Use tab (sysprefs) Test plan: 1. Open .../prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Confirm that the page works normally Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:59:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:59:10 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-oj6zWpizPt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20036 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036 [Bug 20036] Switch single-column templates to Bootstrap grid: Offline circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 18:59:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 17:59:10 +0000 Subject: [Koha-bugs] [Bug 20036] New: Switch single-column templates to Bootstrap grid: Offline circulation Message-ID: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036 Bug ID: 20036 Summary: Switch single-column templates to Bootstrap grid: Offline circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 19980 There are three single-column Offline circulation templates which can be updated to use the Bootstrap grid: offline_circ\enqueue_koc.tt offline_circ\list.tt offline_circ\process_koc.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 19:07:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 18:07:55 +0000 Subject: [Koha-bugs] [Bug 20036] Switch single-column templates to Bootstrap grid: Offline circulation In-Reply-To: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20036-70-aNXqGDBk2G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 19:07:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 18:07:57 +0000 Subject: [Koha-bugs] [Bug 20036] Switch single-column templates to Bootstrap grid: Offline circulation In-Reply-To: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20036-70-VtCgvWqIos@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70704&action=edit Bug 20036: Switch single-column templates to Bootstrap grid: Offline circulation This patch updates three single-column offline circulation templates to use the Bootstrap grid. - offline_circ\process_koc.tt - Circulation -> Upload offline circulation. - offline_circ\enqueue_koc.tt - After uploading offline circulation file -> Add to offline circulation queue. The confirmation page is the page to be tested. - offline_circ\list.tt - From the confirmation page -> View pending offline circulation actions. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 19:08:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 18:08:42 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-5bhxdSeYBX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 19:10:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 18:10:21 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-ZZWUNFhiHD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 19:10:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 18:10:38 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-ecdh1QhSc1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70705&action=edit Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list The goal to this enhancement is to add the ability to cancel a hold and mark items as lost from the 'Holds to pull' page. A new pref is added to control the behaviour, default is off To mark items as lost you need to set the new pref CanMarkHoldsToPullAsLost to one of these two values: - "Allow to mark items as lost" => The item will be marked as lost and the hold will be cancelled - "Allow to mark items as lost and notify the patron" => Same as previously but the patron will be notified as well. The notification is done using a new notice template (code=CANCEL_HOLD_ON_LOST). Feel free to suggest another default wording. To update the values of the items when one of these 2 buttons are used, you need to fill the UpdateItemWhenLostFromHoldList with something like: 'itemlost: 1' Test plan: 1/ Place holds on some items 2/ Go to Home > Circulation > Holds to pull >From here you can cancel the hold or 3/ Mark the items as lost => You will receive feedback messages depending on different situations: * The CANCEL_HOLD_ON_LOST does not exist * The patron does not have an email address (but the notice has been enqueued! It is the current behaviour with other notices) * The notice has been enqueued * The hold has been cancelled QA Notes: >From which library do we want to pick the notice? This patch use reserves.branchcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 19:11:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 18:11:10 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-vvV2uLLy9Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to S?verine Queune from comment #35) > Did I miss a dependency ? The patch doesn?t seem to apply. It applied correctly here, could you test again with this rebased version? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 19:14:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 18:14:53 +0000 Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19289-70-oksz3ZhE1l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70706&action=edit Bug 19289: Remove reference to a non-existent .js file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 19:15:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 18:15:43 +0000 Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19289-70-HJHD6GHa8i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Nicolas Legrand from comment #16) > is it me or there is a catalog_details.js that should be there and is not? It was a first try, but I did not create this file finally. This line should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 19:31:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 18:31:51 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-JOZYnWJ0Sr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20037 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 [Bug 20037] Switch single-column templates to Bootstrap grid: Serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 19:31:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 18:31:51 +0000 Subject: [Koha-bugs] [Bug 20037] New: Switch single-column templates to Bootstrap grid: Serials Message-ID: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Bug ID: 20037 Summary: Switch single-column templates to Bootstrap grid: Serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 19980 There are several single-column Circulation templates which can be updated to use the Bootstrap grid. - serials\acqui-search-result.tt - serials\acqui-search.tt - serials\result.tt - serials\subscription-bib-search.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 20:04:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 19:04:50 +0000 Subject: [Koha-bugs] [Bug 18023] Add "New from Z39.50" button on search results in Authorities module In-Reply-To: <bug-18023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18023-70-ll6bZ1YLkK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18023 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 20:06:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 19:06:54 +0000 Subject: [Koha-bugs] [Bug 18034] Pseudonym records not found in a research by author In-Reply-To: <bug-18034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18034-70-ZK7AYEFnuL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18034 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 20:08:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 19:08:43 +0000 Subject: [Koha-bugs] [Bug 19863] Add more save options when edditing authorities In-Reply-To: <bug-19863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19863-70-YvN0zFyEfu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19863 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 20:21:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 19:21:31 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-K6G5jU5Zat@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70707&action=edit Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 20:21:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 19:21:28 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-nOKZuz3x9J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 20:33:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 19:33:47 +0000 Subject: [Koha-bugs] [Bug 19864] UNIMARC field 100 plugin broken In-Reply-To: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19864-70-x60IBXKxRz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 20:49:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 19:49:52 +0000 Subject: [Koha-bugs] [Bug 20038] New: Switch single-column templates to Bootstrap grid: Acquisitions Message-ID: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 Bug ID: 20038 Summary: Switch single-column templates to Bootstrap grid: Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 19980 There are several single-column templates in the Acquisitions module which can be updated to use Bootstrap. acqui\addorder.tt acqui\z3950_search.tt acqui\basketheader.tt acqui\cancelorder.tt acqui\modordernotes.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 20:49:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 19:49:52 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-ED4Z9GSp2b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:03:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:03:37 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18725-70-EMHWAhbxZK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset at hotmail.com --- Comment #9 from M. Tompsett <mtompset at hotmail.com> --- Bug 18894 broke this easily applying... I'll get around to fixing it later, if Kyle doesn't beat me to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:24:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:24:16 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16427-70-5a5NzxZ6O4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:24:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:24:18 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16427-70-2KwFJEiCBs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70666|0 |1 is obsolete| | --- Comment #6 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70708&action=edit Bug 16427 - Direct link to authority records missing staff detail view Thanks Owen, I've just added the whitespace before the magnifying glass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:32:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:32:35 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-pAQU9AvHWn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:32:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:32:38 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-mbT0bHi8L4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70659|0 |1 is obsolete| | --- Comment #3 from Grace <gracesmythh at gmail.com> --- Created attachment 70709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70709&action=edit Bug 19987: If no z39.50/SRU servers the button should not show Test plan: [1.] Load the patch and make sure you have some Z39.50/SRU servers (Administration => Z39.50/SRU servers administration) [2.] Then go to authorities and notice that the 'New from Z39.50/SRU' button is there [3.] Next go to cataloging and notice that the 'New from Z39.50/SRU' button is there too [4.] Now make sure you have no Z39.50/SRU servers (remove the servers) (Administration => Z39.50/SRU servers administration) [5.] Go to authorities and notice that the 'New from Z39.50/SRU' button is not there [6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU' Z39.50/SRU' button is not there too :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:38:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:38:59 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-yPMbEfuBMP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #4 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70710&action=edit Bug 20000: Fixing problems with the change to 'use strict: use warnings;' to 'use Modern::Perl;' in the follwing installer script data/mysql/labels_upgrade.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:38:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:38:57 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-QbPZ2jQNYW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:43:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:43:04 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-Zg5fQp6Tjl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #5 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70711&action=edit Bug 20000: Fixing problems with the change to 'use strict: use warnings;' to 'use Modern::Perl;' in the following installer scripts data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:43:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:43:42 +0000 Subject: [Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts In-Reply-To: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20019-70-UJH5l93gFw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:43:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:43:45 +0000 Subject: [Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts In-Reply-To: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20019-70-dEE5WUlgYr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 --- Comment #1 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70712&action=edit Bug-20019 - use Modern::Perl in misc perl scripts Test Plan: Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; services/itemrecorddisplay.pl suggestion/suggestion.pl tags/list.pl tags/review.pl virtualshelves/sendshelf.pl help.pl changelanguage.pl koha_perl_deps.pl debian/bd-to-depends debian/build-git-snapshot debian/list-deps docs/CAS/CASProxy/examples/koha_webservice.pl docs/CAS/CASProxy/examples/proxy_cas.pl docs/CAS/CASProxy/examples/proxy_cas_callback.pl docs/CAS/CASProxy/examples/proxy_cas_data.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:52:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:52:21 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19932-70-5kwMHhtvuz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70341|0 |1 is obsolete| | --- Comment #2 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70713&action=edit Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search This patch updates the cataloging Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Several un-quoted HTML attributes have been corrected. To test, apply the patch and go to Cataloging -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:52:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:52:18 +0000 Subject: [Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search In-Reply-To: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19932-70-CDGJBA73q8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:58:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:58:48 +0000 Subject: [Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator In-Reply-To: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19959-70-dj38LwShXQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:58:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:58:50 +0000 Subject: [Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator In-Reply-To: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19959-70-pvO7nn8Zsh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70438|0 |1 is obsolete| | --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70714&action=edit Bug 19959: Update popup window templates to use Bootstrap grid: Label creator This patch updates two label creator templates to use the Bootstrap grid instead of the YUI grid. To test, apply the patch and go to Label creator -> Manage -> Label batches. - Create a new or open an existing label batch. - Click "Add items." - The resulting pop-up window should look correct. - Perform a search - The search results screen should look correct. Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:59:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:59:13 +0000 Subject: [Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search In-Reply-To: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19949-70-LWJb5wFM3u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 21:59:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 20:59:15 +0000 Subject: [Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search In-Reply-To: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19949-70-iViU6C7tlE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70417|0 |1 is obsolete| | --- Comment #2 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70715&action=edit Bug 19949: Update popup window templates to use Bootstrap grid: Cataloging authority search This patch updates the cataloging authority search templates to use the Bootstrap grid instead of the YUI grid. To test you must have a MARC subfield configured with "Thesaurus" linked to an authority type. Apply the patch and go to Cataloging -> New record. Click the plugin link for the field which is linked to authorities. In the popup window, the search form and search results should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:01:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:01:02 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19946-70-gOQzW5ay49@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70411|0 |1 is obsolete| | --- Comment #2 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70716&action=edit Bug 19946: Update popup window templates to use Bootstrap grid: Authority Z39.50 search This patch updates the authority Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Some capitalization corrections, better <title> handling. This patch does not fix Bug 17119. To test, apply the patch and go to Authorities -> New from Z39.50. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com> Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:01:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:01:00 +0000 Subject: [Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search In-Reply-To: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19946-70-jNO2mPwDoj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:11:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:11:49 +0000 Subject: [Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts In-Reply-To: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20022-70-8WrFU9PbAs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Grace <gracesmythh at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:11:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:11:51 +0000 Subject: [Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts In-Reply-To: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20022-70-0qRRSgRceB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 --- Comment #1 from Grace <gracesmythh at gmail.com> --- Created attachment 70717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70717&action=edit Bug 20022 - use Modern::Perl in t (test) perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; 00-checkdatabase-version.t 00-deprecated.t 00-valid-xml.t AuthoritiesMarc_MARC21.t AuthoritiesMarc_UNIMARC.t Barcodes_EAN13.t Barcodes_annual.t Barcodes_hbyymmincr.t Barcodes_incremental.t Bookseller.t Budgets.t ClassSortRoutine.t ClassSortRoutine_Dewey.t ClassSortRoutine_Generic.t ClassSortRoutine_LCC.t ClassSource.t Contract.t Creators.t EdiInvoice.t Edifact.t Ediorder.t Ediordrsp.t External/Syndetics.t Form_MessagingPreferences.t Heading.t HtmlTags.t Installer_PerlDependencies.t Installer_pm.t ItemCirculationAlertPreference.t Koha_Util_MARC.t Labels.t Labels_split_ccn.t Labels_split_ddcn.t Labels_split_lccn.t Log.t Members_Attributes.t Members_Messaging.t Output.t Output_JSONStream.t Patroncards.t Patroncards_Batch.t Patroncards_Layout.t Patroncards_Lib.t Patroncards_Patroncard.t Patroncards_Profile.t Patroncards_Template.t Print.t QueryParser.t Scheduler.t Scrubber.t Stats.t SuggestionEngine.t TmplToken.t db_dependent/00-strict.t db_dependent/Amazon.t db_dependent/Heading_MARC21.t db_dependent/LDAP/test_ldap_add.pl db_dependent/Languages.t db_dependent/MungeMarcPrice.t db_dependent/Record/Record.t db_dependent/RecordProcessor_EmbedSeeFromHeadings.t db_dependent/Reports.t db_dependent/Service.t db_dependent/SuggestionEngine_ExplodedTerms.t db_dependent/Tags.t smolder_smoke_signal :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:13:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:13:47 +0000 Subject: [Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order In-Reply-To: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19947-70-tCxVtkZrTb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70412|0 |1 is obsolete| | --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123 at gmail.com> --- Created attachment 70718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70718&action=edit Bug 19947: Update popup window templates to use Bootstrap grid: Acquisitions transfer order This patch updates the acquisitions transfer order template to use the Bootstrap grid instead of the YUI grid. Also fixed: Corrected footer include for popup window. To test, apply the patch and go to Acquisitions -> Vendor -> Open order -> Transfer. In the popup window search for a vendor, select, and choose a basket. Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:13:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:13:45 +0000 Subject: [Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order In-Reply-To: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19947-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19947-70-8L2jLo1RAx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 Charlotte Cordwell <charlotte.cordwell123 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:15:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:15:12 +0000 Subject: [Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page In-Reply-To: <bug-15595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15595-70-VdbVHnucNK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 --- Comment #1 from jwayway at hotmail.com --- Created attachment 70719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70719&action=edit Decided to make no cover message the same -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:18:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:18:14 +0000 Subject: [Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page In-Reply-To: <bug-15595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15595-70-CDW8tJMhzI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwayway at hotmail.com Attachment #70719|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:23:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:23:16 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-M90EPoZ4LC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:23:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:23:19 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-b88A2NFm84@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70433|0 |1 is obsolete| | --- Comment #10 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70720&action=edit Bug 19641 (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:24:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:24:00 +0000 Subject: [Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page In-Reply-To: <bug-15595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15595-70-6EDdQHtH67@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:24:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:24:02 +0000 Subject: [Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page In-Reply-To: <bug-15595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15595-70-ELU8RsBirr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595 --- Comment #2 from jwayway at hotmail.com --- Created attachment 70721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70721&action=edit Bug-15595: Google cover staff search and detail Test plan: 1. Apply patch 2. In system preferences enable GoogleJacketsIntra 3. Cover images from Google should show in results page and detail page 4. If the record doesn't have a cover, it should display "No cover image available" 4. Disabling the GoogleJacketIntra will cause the cover images not to show 5. Without patch there is no GoogleJacketsIntra syspref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:47:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:47:13 +0000 Subject: [Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins In-Reply-To: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19952-70-bzTrMfPZs6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:47:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:47:15 +0000 Subject: [Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins In-Reply-To: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19952-70-uHBaNeUkfA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 Te Rauhina Jackson <terauhina.jackson at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70423|0 |1 is obsolete| | --- Comment #2 from Te Rauhina Jackson <terauhina.jackson at gmail.com> --- Created attachment 70722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70722&action=edit Bug 19952: Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins This patch updates two UNIMARC cataloging plugin templates to use the Bootstrap grid instead of the YUI grid. - unimarc_field_210c_bis.tt - unimarc_field_686a.tt To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. >From the MARC edit page, trigger the plugin and confirm that the page in the popup window looks correct. Confirm that changes made in the popup window are saved to the corresponding field in the editor. Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:50:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:50:19 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-GMLPutee03@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70720|0 |1 is obsolete| | --- Comment #11 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70723&action=edit Bug 19641 (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:55:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:55:04 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-CyoSxDXWnG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70428|0 |1 is obsolete| | --- Comment #12 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70724&action=edit Bug 19641: Move patron templates to the footer This patch modifies the staff client patron module templates so that JavaScript is included in the footer instead of the header. This patch touches a lot of files because the changes are all interdependent, affecting a couple of module-wide include files. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. Patrons -> Patrons home, patron search results -> Manage pending modification requests -> Patron detail page -> Edit patron -> Set guarantor -> Fines -> Account, Pay fines, Create manual invoice, Create manual credit -> Print receipts for different kinds of charges -> Routing lists -> Circulation history -> Holds history -> Notices -> Statistics -> Files -> Purchase suggestions -> Discharges -> Housebound -> Set permissions -> Change password -> Print summary, slips, and overdues -> Update child to adult patron type Patron toolbar and patron search bar operations should work correctly on all pages. This patch also updates the template for searching the Norwegian national patron database, but it has NOT been tested. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:55:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:55:07 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-2uRxvQxh46@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70429|0 |1 is obsolete| | --- Comment #13 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70725&action=edit Bug 19641 (Follow-up) Update circulation.tt too This patch makes the same JS-to-footer changes to circulation.tt. Inclusion of this template in this bug is necessary because it includes members-toolbar.inc. To test, apply the patch and clear your browser cache if necessary. - Enter a patron card for checkout - Test any JavaScript-driven actions on the checkout page, for instance: - Select all/clear all controls - Datepicker/timepickers - Datatable sorting, columns configuration - Renewals, check-ins - Patron message interactions, print slip, and other toolbar actions - Checkout exports - Search to hold - Tab loading: Restrictions, Holds, Clubs Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 22:55:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 21:55:11 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-2OBj1PRcoM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Zoe Bennett <zoebennett1308 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70723|0 |1 is obsolete| | --- Comment #14 from Zoe Bennett <zoebennett1308 at gmail.com> --- Created attachment 70726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70726&action=edit Bug 19641 (Follow-up) Correct popup templates This patch corrects the footer include for two patron-related popup windows. popup-bottom.inc should be considered obsolete, and "'intranet-bottom.inc' popup_window=1" used in its place. To test you must have more than one adult-type patron category defined. - Locate and view a child-type patron record. - From the "More" menu in the toolbar, choose "Update child to adult patron." - The popup window which appears should look correct and work correctly. - Add a new patron and enter the first and last names of an existing patron. - When Koha asks to confirm a possible duplicate record, click the "View existing record" link. The popup which is triggered should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> Signed-off-by: Your Full Name <your_email> Signed-off-by: Your Full Name <your_email> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 23:45:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 22:45:15 +0000 Subject: [Koha-bugs] [Bug 19660] Set borrower password on first login from self registration In-Reply-To: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19660-70-9G3z6CkWrQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 --- Comment #2 from jwayway at hotmail.com --- Created attachment 70727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70727&action=edit Bug-19960 This is a follow up patch to fix the password field on the registration complete page. Please upload this patch along with the previous version :) Test plan: 1. Apply this patch 2. The password field has the pregenerated password if the syspref is enabled 3. Before the patch the password was displayed on the screen in a span tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 18 23:46:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 22:46:01 +0000 Subject: [Koha-bugs] [Bug 19660] Set borrower password on first login from self registration In-Reply-To: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19660-70-iGiCjZir5Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660 jwayway at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70727|Bug-19960 |Bug-19960: Fix password description| |field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 00:03:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 23:03:16 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14272-70-FkTG7ukz3j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50558|0 |1 is obsolete| | --- Comment #37 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70728&action=edit Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Fixing merge conflicts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 00:07:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 23:07:02 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14272-70-9ZL4oGTpDa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50559|0 |1 is obsolete| | --- Comment #38 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70729&action=edit Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Fixing merge conflicts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 00:11:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 23:11:12 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14272-70-Z8vytXz6wp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 00:11:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 23:11:16 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14272-70-59p2AO3e73@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59483|0 |1 is obsolete| | --- Comment #39 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70730&action=edit Bug 14272: [FOLLOW-UP] Show single news item This patch fixes merge conflicts, an error in the query, and changes the column name `new` to `content`. This patch is now ready to test. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 00:14:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 23:14:46 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14272-70-xFgVlQppCQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70730|0 |1 is obsolete| | --- Comment #40 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70731&action=edit Bug 14272: [FOLLOW-UP] Show single news item This patch fixes merge conflicts, an error in the query, and changes the column name `new` to `content`. This patch is now ready to test. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 00:57:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jan 2018 23:57:29 +0000 Subject: [Koha-bugs] [Bug 20040] New: FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared Message-ID: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040 Bug ID: 20040 Summary: FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org I think that the FailedLoginAttempts system preference is only meant to be set ifNorwegianPatronDBEnable is set to 'Enable'; my testing is all done with ifNorwegianPatronDBEnable set to 'Disable'. What's happening: Setting FailedLoginAttempts, then logging in with incorrect credentials will lock the account. The login screen says that the account is locked, and no further attempts to log in will work. It is entirely unclear how to unlock the account -- resetting the password does not work, and the lock is not set via borrower debarments, so it can't be disabled there. The only way I was able to re-enable logins for a locked patron was to blank out FailedLoginAttempts. If this is only meant to be used in conjunction with ifNorwegianPatronDBEnable, it shouldn't be settable unless that is enabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 01:00:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 00:00:09 +0000 Subject: [Koha-bugs] [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared In-Reply-To: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20040-70-PHOqcLiKwa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 01:04:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 00:04:00 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18725-70-zv02xvC0Sz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- While the rebase was easy enough to do, I still couldn't figure out how to get step 2 to happen. When I locked the table, the canary code paused the script execution until I unlocked it. I did try filling the message_queue table. Somewhere around 1.5 million messages, and it complained the table was full in sql. However, that doesn't prevent an update. And the number of records was a function of how much space was left. I attempted to 'dd' the drive full, and yet I was still able to run the script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 01:22:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 00:22:34 +0000 Subject: [Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same biblio In-Reply-To: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19832-70-qaiUuQwQPF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea <liz at catalyst.net.nz> --- This is clearly wrong, I have a library having this exact problem right now. Will give your solution a go and see what happens. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 01:58:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 00:58:06 +0000 Subject: [Koha-bugs] [Bug 20026] Add new permission related to personal data In-Reply-To: <bug-20026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20026-70-ryG2IOrWqu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20026 Lisette <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 02:57:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 01:57:21 +0000 Subject: [Koha-bugs] [Bug 19712] Fix command line options of delete_records_via_leader.pl In-Reply-To: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19712-70-a1WKRaeBHy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19712 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70732&action=edit Bug 19712: Followup adding missing use Pod::Usage pod2usage call failed otherwise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 03:53:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 02:53:07 +0000 Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19802-70-dDVdCQBcap@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69756|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70733&action=edit Bug 19802: Move Selenium code to t::lib::Selenium To make it reusable easily. Test plan: The basic_workflow.t tests should still pass after this change. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 03:53:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 02:53:09 +0000 Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19802-70-XEXdJMPvnw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70158|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70734&action=edit Bug 19802: Add stack trace to ease debugging Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 03:53:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 02:53:47 +0000 Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19802-70-PPn38DHxwb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Signed Off --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- prove before and after both pass, as expected. Code eyeballs well enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 04:15:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 03:15:05 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: <bug-13995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13995-70-DA4cxbsd50@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #25 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Josef Moravec from comment #24) > (In reply to Olli-Antti Kivilahti from comment #23) > > Created attachment 60963 [details] [review] [review] > > Bug 13995 - Proper Exception handling > > Is it ready for testing again? What is the test plan? Nope. Because the test that Olli-Antti Kivilahti added was only for one of the exceptions added. Still Failed QA, because of inadequate test coverage. Jonathan Druart came across as rather particular on this point in a recent IRC meeting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 04:27:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 03:27:54 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: <bug-13995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13995-70-lqgRvJGI6Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #26 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- This patch doesn't really require unit tests in my opinion. But we didn't agree (explicitly) on the one exception per file approach, and since this patch was posted several exceptions have been added. This patch is of big value because Olli put a lot of time thinking about the exceptions we might need and also how to organize them. This should be used as a basis for new exceptions addition. Maybe organized by type or module as the ones we already have (which should be rearranged too, virtualshelves, etc) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 05:03:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 04:03:37 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-0KtWKc6zlu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70592|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70735&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch set adds a new colum to saved_sql 'combine_params' If set, parameters that have the same name and data type will only be asked for once from the user To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <<cat>> AS one, <<dog|branches>> AS two, <<dog|YES_NO>> as three, <<cat>> as four, <<dog|branches>> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are still asked for five parameters 6 - Edit report, note the 'Combine params' options, say YES!!!!! 7 - Re-run the report, you shoudl be asked for three parameters 8 - Verify the results reflect the supplied parameters 9 - Create a new report (perhaps something more substantive) 10 - Save with 'combine params' checke 11 - View in saved reports and see the new 'combine params' column 12 - Verify it is correctly set 13 - Run the report and verify correct results 14 - prove -v t/db_dependent/Reports/Guided.t Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 05:03:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 04:03:41 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-gfLrscsdgl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70685|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70736&action=edit Bug 9634 [QA Followup] - Add new column to kohastructure.sql Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 05:04:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 04:04:02 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9634-70-3AzJBcFxDR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 06:00:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 05:00:15 +0000 Subject: [Koha-bugs] [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared In-Reply-To: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20040-70-CIVyuznuQj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18314 CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Barton, the preference is not related to ifNorwegianPatronDBEnable. See here: bug 18314 This login_attempts field is reset when a patron correctly logs in. When the account is locked the patron has to reset his/her password using the OpacResetPassword feature or ask a staff member to generate a new password. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 [Bug 18314] Account lockout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 06:00:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 05:00:15 +0000 Subject: [Koha-bugs] [Bug 18314] Account lockout In-Reply-To: <bug-18314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18314-70-xeuNAxjkMI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20040 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040 [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 06:02:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 05:02:17 +0000 Subject: [Koha-bugs] [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared In-Reply-To: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20040-70-U32W9Dd2xb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |major --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Not a blocker - feature can be turned off (workaround) and no data loss: https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines#Severity -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 06:07:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 05:07:41 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-JB6tZ0R9HN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #21) > (In reply to Katrin Fischer from comment #17) > > It's missing steps. > > > > - you need to update the po files after the patch was applied > > - you have to check that the string got not marked as 'fuzzy' > > - you have to reinstall the language > > > > Only then the test gives you a correct result. > > I don't get, isn't this covered in the steps 18? Sorry Viktor, it appears I didn't read to the end of the test plan... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 06:52:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 05:52:16 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-5bGqev73lk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The button's functionality is restored with the patch. But the problem of the non-functional exploding Dummy and FreeForm (which should work universally) remains. Actually using the button still leads to: Template process failed: file error - : not found at /home/vagrant/kohaclone/C4/Templates.pm line 122. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 06:53:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 05:53:35 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-SOMLVNcVIK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70701|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 70737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70737&action=edit Bug 20001: Fix confusion between array and arrayref Illrequest->available_backends always returned only 1 element TEST PLAN --------- See bug 7317 comment #20 for configuring ILL Make sure to restart_all Strangely, ILLIBS didn't exist, but IL did in default install, so use that as the patron code in your koha-conf.xml Make sure to turn on the ILL related system preference. 1) Configure ILL. -- this is the hard part. Hopefully the above will give you enough. 2) open OPAC and log in 3) Click the 'your interlibrary loan request' in the left pane 4) Click the 'Create a new request' button. -- when you hover your mouse over the links for the backends, they will have ARRAY(...) instead of a meaningful name. This is what triggers the error (see comment #7). 5) Run the following commands git checkout -b bug_20001 origin/master git bz apply 20001 restart_all 6) Refresh the OPAC page, and repeat step 4. -- when hovering your mouse over the links for the backends, they will have meaningful values now. 7) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 06:54:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 05:54:07 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-EfhPHR0Zu5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am passing QA on the fix as it's obviously correct, but this bug is not resolved with it yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 06:53:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 05:53:31 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-LSTKN8WbTA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 07:35:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 06:35:17 +0000 Subject: [Koha-bugs] [Bug 20041] New: ILL module missing from more menu in staff when activated Message-ID: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 Bug ID: 20041 Summary: ILL module missing from more menu in staff when activated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de Depends on: 7317 When the ILL module is activated and configured it shows as a new icon on the start page, but it's missing on the 'more' menu in the top navigation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 07:35:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 06:35:17 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7317-70-7dlQZEUaga@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20041 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 [Bug 20041] ILL module missing from more menu in staff when activated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 07:57:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 06:57:01 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-mG5aphOjd3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to M. Tompsett from comment #8) > (In reply to Matthias Meusburger from comment #6) > > Your patch works well, it prevents from crashing on a unknown barcode. > > > > However, I couldn't reproduce the crash on a payment. > > I will revise test plan so it is explicitly clear. I confirmed it does fail > on payments. I am also pleased to announce that FINALLY, I RTFM'd regarding > the offline client, and am much happier about it now. Thanks Mark, excellent work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 08:14:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 07:14:00 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-swdZJeMDRw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- As the create functionality works on the intranet side, I wonder if it's a problem with picking the right templates on OPAC? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 08:39:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 07:39:29 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-fBHJn6PlRb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- [% PROCESS $whole.opac_template %] doesn't work... but I am not sure why. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 09:46:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 08:46:50 +0000 Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and deletedbiblio_metadata In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19724-70-7i8tqslNrN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Resolved since Bug 17196 not in 16.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 09:46:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 08:46:51 +0000 Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers should use biblio_metadata.timestamp In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19725-70-i8muoRBcjD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Bug 19725 depends on bug 19724, which changed state. Bug 19724 Summary: Add timestamp to biblio_metadata and deletedbiblio_metadata https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 09:46:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 08:46:51 +0000 Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use biblio_metadata.timestamp In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19730-70-HDUDSFrwzL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730 Bug 19730 depends on bug 19724, which changed state. Bug 19724 Summary: Add timestamp to biblio_metadata and deletedbiblio_metadata https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 09:47:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 08:47:11 +0000 Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers should use biblio_metadata.timestamp In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19725-70-uhGKXT83FA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 09:55:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 08:55:05 +0000 Subject: [Koha-bugs] [Bug 11976] Add column settings + new column "Publication date" to the subscription table In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11976-70-Nu8I0LeKxk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #26 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 10:03:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 09:03:12 +0000 Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC only appears / works if no other list already exists In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19573-70-uIMzRh2hYn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 10:06:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 09:06:14 +0000 Subject: [Koha-bugs] [Bug 19756] Encoding issues when update DB is run from the interface In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19756-70-EPTR9WB4aZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 10:08:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 09:08:40 +0000 Subject: [Koha-bugs] [Bug 19867] HouseboundRoles.t is failing randomly In-Reply-To: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19867-70-Nfauzan2r1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19867 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 10:10:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 09:10:06 +0000 Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not accessible In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19760-70-udXkGoF7zz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 11:13:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 10:13:41 +0000 Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19200-70-5o4tH2E0qX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8612 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 [Bug 8612] CSV export profile to have custom fields in export csv basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 11:13:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 10:13:41 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: <bug-8612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8612-70-Xz1UXNpzP1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19200 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 [Bug 19200] Warns when exporting a basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 11:14:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 10:14:08 +0000 Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19200-70-5m4PFXcxzZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 8612 that is not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 11:21:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 10:21:27 +0000 Subject: [Koha-bugs] [Bug 20025] Running of koha-* scripts should be logged In-Reply-To: <bug-20025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20025-70-vxifEBgFty@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20025 --- Comment #2 from Mike <black23 at gmail.com> --- Hi Katrin, especially koha-dump. Because we need to know when Koha made backup and who run it. It contains personal data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 11:38:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 10:38:07 +0000 Subject: [Koha-bugs] [Bug 20025] Running of koha-* scripts should be logged In-Reply-To: <bug-20025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20025-70-VIzPLPQicg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20025 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- If someone has the information to run koha-dump, wouldn't they also be able to get the dump using a tool like mysqldump? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 11:50:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 10:50:45 +0000 Subject: [Koha-bugs] [Bug 20025] Running of koha-* scripts should be logged In-Reply-To: <bug-20025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20025-70-0xhRpn19eu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20025 --- Comment #4 from Mike <black23 at gmail.com> --- I agree, but Koha use CROn for automatic backup, logs make documented records about it. Direct export from db via CL tool or GUI tools should be logged manually. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 12:03:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 11:03:04 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-h1g00hD3Tg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 --- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to M. Tompsett from comment #2) > One would hope this case never happens. And if it does, stop editing the > files on a live system. That being said, this is a straight-forward regexp > tightening. Of course this should never happen in production, but it can be annoying during development. Thanks for the sign-off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 12:25:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 11:25:15 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-bbAcpLgzJv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Well, it is kind of hard to separate. Maybe apart from this: +sub _bib_indicator2 { + my ( $code ) = @_; + my %thes_mapping = ( a => 0, b => 1, c => 2, d => 3, k => 5, n => 4, r => 7, s => 7, v => 6, z => 7, '|' => 4 ); + return $thes_mapping{ $code } // $code // '4'; +} + +sub _bib_subfield2 { + my ( $indicator2, $subject_headings, $conventions ) = @_; + return if $indicator2 ne '7'; + return 'aat' if $subject_headings eq 'r'; + return 'sears' if $subject_headings eq 's'; + return $conventions if $subject_headings eq 'z'; +} I noted that some fields still contain more exceptions. Like: 653, 654 ind2, 655 ind1, 656 and 657 only 7 in ind2, 658, 662, 69X I still feel more for an approach I originally had in mind by adding a conf file containing essentially a hash that tells you what to do like: 600, ind1 => authind1 | authind2 | bibind1 | bibind2 | [fixed_value] | thesaurus where thesaurus could trigger a call to bib_indicator2. The uniform title stuff would move to that config file. It would give people more flexibility to make changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 12:27:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 11:27:50 +0000 Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15395-70-ZPCFyfdgPd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow correct handling of |Internationalization: |plural translation |plural forms, context, and | |more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:02:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:02:22 +0000 Subject: [Koha-bugs] [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared In-Reply-To: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20040-70-zsyiDTJ0ei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I have just quickly tested the feature on 17.05.x and everything works fine. Please read the description on the bug report and try again :) Changing the password unlock the account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:09:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:09:15 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-THf3CTSlqH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #15) > The button's functionality is restored with the patch. But the problem of > the non-functional exploding Dummy and FreeForm (which should work > universally) remains. Actually using the button still leads to: > > Template process failed: file error - : not found at > /home/vagrant/kohaclone/C4/Templates.pm line 122. Dummy works for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:11:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:11:19 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-UU8M3X2K0k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- https://screenshots.firefox.com/PlajuumMOPG7dPMe/catalogue.kohadev.org And FreeForm as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:33:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:33:07 +0000 Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag not existing In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19813-70-qhnaDhQFmE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:37:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:37:16 +0000 Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders subfields In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18458-70-MdS7RSEZzF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:42:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:42:40 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-UbGbdwnTat@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:42:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:42:45 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-ejgARumQdO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70739&action=edit Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn Amended the sql statement so it only affects the http://www.scholar.google.com url Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:42:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:42:42 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-vawCRzjBG8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70546|0 |1 is obsolete| | Attachment #70568|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70738&action=edit Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn 1)apply patch 2) go into administration --> search for OPACSearchForTitleIn 3) *click to edit* 4) look at the link and read the google scholar one. 5) check that the start link is https://scholar.google.com. 6) http://www.scholar.google is incorrect Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:43:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:43:38 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-lMGi9M3YuG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Small change, SO and QA in one step -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:44:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:44:08 +0000 Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing 'Holds history' tab for a patron In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19621-70-H5i9X8t6h5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:52:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:52:03 +0000 Subject: [Koha-bugs] [Bug 19783] make check_kohastructure.t compatible to package build process In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-u8SzKYlNxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> --- Moving it to db_dependent is the cleaner solution, I'll add a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:52:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:52:07 +0000 Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19840-70-eUMd7Uo3hx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Bug 18276 is not in 17.05.x but is this bug needed for it anyway ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:52:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:52:51 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16427-70-RBLijLvRXr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70666|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:53:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:53:30 +0000 Subject: [Koha-bugs] [Bug 20042] New: 00-load.t fails when Elasticsearch is not installed Message-ID: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 Bug ID: 20042 Summary: 00-load.t fails when Elasticsearch is not installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org 00-load.t fails when Elasticsearch is not installed. Blocks packaging. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:53:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:53:39 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-mmmjnv8OuP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:53:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:53:45 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-k3UBtVa1Dn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:56:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:56:27 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-I7MiEqzb18@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|make check_kohastructure.t |Move check_kohastructure.t |compatible to package build |to db_dependent |process | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:56:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:56:58 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-37fyxb3Id9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 --- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 70740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70740&action=edit Bug 19783: Move check_kohastructure.t to db_dependent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:57:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:57:25 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-DQAAOcuim6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 13:57:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 12:57:45 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-tcPRIKJgnH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:01:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:01:03 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-TeCRStjnXq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 --- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 70741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70741&action=edit Bug 20042: 00-load.t fails when Elasticsearch is not installed 00-load.t fails when Elasticsearch is not installed. Blocks packaging. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:01:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:01:27 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-elU4jJcGHk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:07:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:07:12 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16427-70-U2z9NR9aES@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:07:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:07:14 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16427-70-gZDxJ06JSW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70666|0 |1 is obsolete| | Attachment #70708|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70742&action=edit Bug 16427: Direct link to authority records missing staff detail view I added a magnigying glass icon in the staff detail view that links to the authority records. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: Topical Term. 2) When creating authority, in tab 1 under -HEADING--TOPICAL TERM enter the topical term or geographic name entry element and then save the new authority e.g. science. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 6, scroll down the - SUBJECT ADDED ENTRY--TOPICAL TERM and repeat this tag (the icon next to the title). 5) Edit the Topical term or geographic name entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your topical term e.g. science. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new topical term will be in the 'Subject(s)' list of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the topical term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:08:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:08:02 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18696-70-6xZHDYSY9f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 --- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 70743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70743&action=edit Bug 18696: Change debian/source/format to quilt debian/source/format uses 'native'. As Koha is not native Debian software, and to allow Debian revision numbers like -2 in 16.05.13-2, it should be changed to 'quilt'. This is only relevant to packaging and does not affect Koha itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:08:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:08:12 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16427-70-6H5kogppkb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Thanks for the follow-up! I squashed the two patches during sign-off for simplicity's sake. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:08:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:08:13 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18696-70-iAPSyryuE5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:10:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:10:44 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18696-70-hcOcn6SJzH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Severity|trivial |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:17:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:17:36 +0000 Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19702-70-kHZ1OAG3Aw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:18:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:18:48 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-xuOjIMeTYT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |17829 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Caused by commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6 Bug 17829: Move GetMember to Koha::Patron Due to a bad merge conflict during a rebase (that is exactly why we should not wait for moths to focus on these patches...) So I guess it impacts master as well. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:18:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:18:48 +0000 Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron In-Reply-To: <bug-17829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17829-70-CV3IwQPdU0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 [Bug 20003] Result summary of remaining checkouts items not displaying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:22:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:22:00 +0000 Subject: [Koha-bugs] [Bug 19788] Case sensitivity is not preserved when creating local system preferences In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19788-70-XrSEjVPmR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:22:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:22:03 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-YoWJjVdmpD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:22:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:22:26 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-1Z2Zy7nft2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 --- Comment #6 from Mirko Tietgen <mirko at abunchofthings.net> --- This is needed in 17.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:23:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:23:14 +0000 Subject: [Koha-bugs] [Bug 19788] Case sensitivity is not preserved when creating local system preferences In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19788-70-2jUxHxIgkr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788 --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:27:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:27:10 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-QN28E2KIDj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:27:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:27:12 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-BpJCMGFASu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70709|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70744&action=edit Bug 19987: If no z39.50/SRU servers the button should not show Test plan: [1.] Load the patch and make sure you have some Z39.50/SRU servers (Administration => Z39.50/SRU servers administration) [2.] Then go to authorities and notice that the 'New from Z39.50/SRU' button is there [3.] Next go to cataloging and notice that the 'New from Z39.50/SRU' button is there too [4.] Now make sure you have no Z39.50/SRU servers (remove the servers) (Administration => Z39.50/SRU servers administration) [5.] Go to authorities and notice that the 'New from Z39.50/SRU' button is not there [6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU' button is not there too :) Signed-off-by: Owen Leonard <oleonard at myacpl.org> I added a missing [% END %] during signoff. Hope no one minds! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:30:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:30:46 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-A80RYaUHIU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- A good follow-up would be to address the pages in Acquisitions which let you add to a basket from Z39.50 ("From an external source"). The link is in acquisitions-add-to-basket.inc which is included in acqui/basket.tt, acqui/booksellers.tt, and acqui/neworderbiblio.tt. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:30:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:30:59 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-fUupJBDPWh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:30:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:30:59 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: <bug-18417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18417-70-dzgVFRzbyo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11559 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 [Bug 11559] Professional cataloger's interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:45:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:45:19 +0000 Subject: [Koha-bugs] [Bug 20043] New: Error in fr-FR translation? Message-ID: <bug-20043-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20043 Bug ID: 20043 Summary: Error in fr-FR translation? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Just putting it here to not forget, there is something wrong in the MARC21slim2intranetDetail.xsl for fr-FR I bet on a translation issue. ==> /var/log/koha/kohadev/plack-error.log <== Error while loading stylesheet xml: /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/MARC21slim2intranetDetail.xsl:923: parser error : EntityRef: expecting ';' <span class="label">Note d'action : </span> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:50:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:50:26 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-dYVlJxXzjp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:50:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:50:28 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-etm5IBZ0ds@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70695|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70745&action=edit Bug 19771: Fix crashing in pending offline circulation actions list When the barcode is empty or invalid, an "Internal Server Error" is triggered on the kohadev box. TEST PLAN --------- 0) back up your database if you care about it. 1) Run the following commands: git checkout master git pull git checkout -b bug_19771 origin/master git bz apply 19771 -- This should be quite uneventful. Standard promptings. 2) Continue to run the following commands: git checkout master reset_all sudo koha-shell -c bash kohadev ./misc/cronjobs/create_te_koc_db.pl --sqlite3 -- This will create a borrowers.db in your current directory. 3) On the host where you intend on running the koct install it. -- https://sourceforge.net/projects/koha-oc/files/ download and install. 4) get the borrowers.db file to your host where you installed koct 5) point koct at the file you downloaded Database -> Select Borrowers DB File 6) Create a .koc file with the following transactions. check in, check out, check in (bad barcode), pay fines (any non-zero amount). 7) Run the following commands: restart_all -- we want to make sure caching for plack isn't in the way. 8) In the staff client: Home -> Circulation -> Upload offline circulation file (.koc) 9) Choose the file created and click 'Upload file'. 10) Add to offline circulation queue. 11) View pending offline circulation actions -- This should die. Reading /var/log/koha/kohadev/plack-error.log should be the same error as comment #0. However, this was only the bad biblio error. 12) Run the following commands: git checkout bug_19771 restart_all 13) Refresh staff client page. -- it should all come up. 14) Select the bad biblio line, and delete it. 15) Run the following commands: git checkout master restart_all 16) Refresh the staff client page. -- it should die. Same error as comment #0. This confirms the fine payment issue. 17) Run the following commands git checkout bug_19771 restart_all 18) Refresh the staff client page. -- it should all come up. 19) run the koha qa test tools 20) if you backed up your database, restore it. :) Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 14:50:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 13:50:40 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-6Ca3hoVrHW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:08:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:08:03 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11879-70-IZDLAcl8nq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #96 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 69028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69028 Bug 11879: Add the "Main contact method" field in borrower informations. Review of attachment 69028: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11879&attachment=69028) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/borrowers_primary_contact_method.sql @@ +1,2 @@ > +ALTER TABLE `borrowers` ADD COLUMN `primary_contact_method` VARCHAR(45) NULL DEFAULT NULL AFTER `lastseen`; > +ALTER TABLE `deletedborrowers` ADD COLUMN `primary_contact_method` VARCHAR(45) NULL DEFAULT NULL AFTER `overdrive_auth_token`; deletedborrowers and borrowers should maintain the same field order. ::: installer/data/mysql/kohastructure.sql @@ +1682,4 @@ > `lang` varchar(25) NOT NULL default 'default', -- lang to use to send notices to this patron > `login_attempts` int(4) default 0, -- number of failed login attemps > `overdrive_auth_token` text default NULL, -- persist OverDrive auth token > + `lastseen` datetime default NULL, -- last time a patron has been seed (connected at the OPAC or staff interface) This adds lastseen, but the borrowers_primary_contact_method did not add it at all. ::: installer/data/mysql/updatedatabase.pl @@ +14968,4 @@ > } > } > > + Totally not necessary to touch this. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +538,5 @@ > > [% UNLESS nophone && nophonepro && nomobile && noemail && noemailpro && nofax %] > <fieldset class="rows" id="memberentry_contact"> > + <legend id="contact_lgd">Contact</legend> > +<ol> Keep whitespace changes separate. @@ +602,4 @@ > [% IF ( mandatoryemailpro ) %]<span class="required">Required</span>[% END %] > </li> > [% END %] > + [% UNLESS nofax %] Keep whitespace changes separate. @@ +664,5 @@ > + [% END %] > + [% END %] > + </select> > + </li> > + </ol> This is the only place where you can really get away with these minor whitespace changes on the END and /ol. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ +275,5 @@ > + [% ELSE %] > + [% guarantor.firstname | html %] [% guarantor.surname | html %] > + [% END %] > + </li> > + [% END %] Where did this ELSIF clause come from?! This has nothing to do with primary_contact_method. ::: opac/opac-memberentry.pl @@ +93,5 @@ > libraries => \@libraries, > OPACPatronDetails => C4::Context->preference('OPACPatronDetails'), > ); > +my $check_BorrowerMandatoryField=C4::Context->preference("BorrowerMandatoryField"); > + my @field_check=split(/\|/,$check_BorrowerMandatoryField); Something is strange about this indentation. I would expect the same indentation level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:09:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:09:08 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11879-70-JQsPA1ydgB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #97 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 69029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69029 Bug 11879: Changes to Koha's schemas Review of attachment 69029: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11879&attachment=69029) ----------------------------------------------------------------- None of these have lastseen, as mentioned in the other patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:09:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:09:44 +0000 Subject: [Koha-bugs] [Bug 19160] CAS Single Log Out In-Reply-To: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19160-70-VJq1RMbRcj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Some first feedback: We successfully tested the patches on our 16.11.x branch, but want to run some more tests. So far it's looking good! We will try to sign off before end of January. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:14:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:14:19 +0000 Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-e69OhbdDyg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:14:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:14:22 +0000 Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-nlsoMINT8S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70528|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70746&action=edit Bug 16603: When processing uploaded offline circulation file, "apply directly" option fails This patch is a temporary mitigation of whatever the real problem is. The patch hides the "Apply directly" button so that the option isn't available. To test, apply the patch and generate a .koc file with some transactions. Upload the file via Circulation -> Offline circulation file upload. After the file is uploaded, you should see only a "Add to offline circulation queue" button, which should work correctly. Signed-off-by: Grace Smyth <gracesmythh at gmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:14:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:14:25 +0000 Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-9kteCmFT1J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70747&action=edit Bug 16603: (QA Follow-up) Add a FIXME Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:14:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:14:58 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11879-70-RKaxKtzchs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #98 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 69050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69050 Bug 11879: Follow-up - Streamline markup and make label corrections Review of attachment 69050: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11879&attachment=69050) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ +293,5 @@ > + Secondary email > + [% CASE 'fax' %] > + Fax > + [% END %] > + </li> This is nicer and friendlier on the po files, I'm sure. I believe it was done the other way because of a misunderstanding of HTML 1 (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML_Templates). The SWITCH isn't allowed inside HTML tags, that is <tag [% SWITCH ... %]> is really bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:15:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:15:13 +0000 Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-EOu56L6ofB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Would be better to fix, but I didn't see the problem in a quick look. This prevents the error for user so PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:27:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:27:51 +0000 Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19289-70-DsXYv60oWd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #19 from S?verine Queune <severine.queune at bulac.fr> --- Hi Jonathan, Nicolas applied this morning the patch in our local instance, and everything seems to work as expected, except that we don't have any more warnings if required fields are empty, and the order is saved. I just tried once again in Biblibre's sandbox#2 and behaviour is the same. I'm really sorry I didn't notice it during my tests, it's not logical for me to try to save a form without the required fields so I didn't think about testing it. Do you need a new bug report ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:39:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:39:33 +0000 Subject: [Koha-bugs] [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions In-Reply-To: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20038-70-EsC6gQu78o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:39:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:39:33 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-mtQ00IdFKB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:40:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:40:48 +0000 Subject: [Koha-bugs] [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions In-Reply-To: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20038-70-2YEQGN3ZBe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:40:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:40:50 +0000 Subject: [Koha-bugs] [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions In-Reply-To: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20038-70-yspQd0EvqO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70748&action=edit Bug 20038: Switch single-column templates to Bootstrap grid: Acquisitions This patch updates several acquisitions module templates to use the Bootstrap grid. - acqui/z3950_search.tt - Acquisitions -> Vendor -> View basket -> Add to basket -> From an external source. The Z39.50 search form should look correct. - Search for a title. The search results page should look correct. - acqui/addorder.tt - Acquisitions -> Vendor -> View basket -> Add to basket. Add an order to the basket which costs more than is available in the fund you select. The error/confirmation screen should look correct. - acqui\modordernotes.tt - Acquisitions -> Vendor -> View basket -> Add internal or vendor note. The note add form should look correct. - acqui/cancelorder.tt - Acquisitions -> Vendor -> View basket -> Cancel order (from an open basket which has existing orders). The confirmation screen should look correct. - acqui\basketheader.tt - Acquisitions -> Vendor -> New basket. The new basket edit form should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:48:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:48:29 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-ugHdObOPhs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |In Discussion --- Comment #25 from Nick Clemens <nick at bywatersolutions.com> --- This works as advertised, however see bug 19910 If we are going to honor the delimiter pref, I think we need to use it in displaying what format will be downloaded. Want another QA opinion here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:53:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:53:58 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-4x7ehfpynK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:54:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:54:01 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-N6RPNKas9P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70703|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70749&action=edit Bug 19977: Open only .pref files in Local Use tab (sysprefs) Test plan: 1. Open .../prog/en/modules/admin/preferences/circulation.pref with vim (check that it creates a .circulation.pref.swp in the same directory) 2. Go to the "Local Use" tab in admin/systempreferences.pl 3. Confirm that the page works normally Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 15:54:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 14:54:22 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-zuvQOrKVlr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:03:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:03:46 +0000 Subject: [Koha-bugs] [Bug 20044] New: Switch single-column templates to Bootstrap grid: Cataloging Message-ID: <bug-20044-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Bug ID: 20044 Summary: Switch single-column templates to Bootstrap grid: Cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Blocks: 19980 There are several single-column cataloging templates which can be updated to use the Bootstrap grid. - cataloguing\addbiblio.tt - cataloguing\addbooks.tt - cataloguing\merge.tt - cataloguing\moveitem.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:03:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:03:46 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-TjvGybT24w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20044 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:10:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:10:05 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-lCRqIdKDAn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70698|0 |1 is obsolete| | --- Comment #26 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70750&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fixes: - Basketgroup: there was an unnecessary space. " RRP tax excluded" replaced by "RRP tax excluded" - Late orders: - leading spaces before every line - surrounding spaces for [% orders.size %] Other changes: - quoted "Total orders in late" to no worry about additional spaces - Late orders: additional spaces which shouldn't be a problem because all the fields are enclosed by quotes. Test plan: 1. Set syspref "delimiter" to "#'s" 2. Change the language e.g. FR-fr 3. Create a vendor with minimal info 4. Create a basket with two items 5. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 6. Close this basket 7. "Export as CSV" 8. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 9. Create a basket group with two baskets (tick the close this basket group check box) 10. Go to the "Closed" tab to see your basket group 11. "Export as CSV" 12. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 13. Go to /cgi-bin/koha/acqui/lateorders.pl 14. Tick two orders. Of the same vendor, otherwise Koha won't let you tick orders of different vendors. 15. "Export as CSV" 16. You should see that the file contains commas "," This is the bug. Leave the file open for future comparison to ensure that there are no regressions. 17. Apply this patch 18. Translation stuff 1. cd misc/translator 2. perl translate update YOUR_LANG 3. manually edit the po file, remove the fuzzy tags. And translate the string. You can just copy the original and replace some parts by gibberish. 4. perl translate install YOUR_LANG 19. Re-export the same CSVs and compare with the original version to check that - delimiter syspref is honored - the headers are translatable - there is no whitespace regression (additional newlines or spaces) Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:10:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:10:03 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-qCuKCbtRic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:11:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:11:18 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-3neuE7tguc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:13:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:13:39 +0000 Subject: [Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter" In-Reply-To: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19928-70-CN9aCOGLKN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED QA Contact|nick at bywatersolutions.com |testopia at bugs.koha-communit | |y.org --- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Nick Clemens from comment #25) > This works as advertised, however see bug 19910 > > If we are going to honor the delimiter pref, I think we need to use it in > displaying what format will be downloaded. > > Want another QA opinion here Agreed, please see the changes made on bug 19910 and add the info here too. You can then switch back to Signed Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:18:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:18:01 +0000 Subject: [Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-20044-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20044-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20044-70-ti2wcynZXq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:18:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:18:03 +0000 Subject: [Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-20044-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20044-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20044-70-aSfen7dZwc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70751&action=edit Bug 20044: Switch single-column templates to Bootstrap grid: Cataloging This patch updates several cataloging module templates to use the Bootstrap grid. - cataloguing/addbooks.tt - Cataloging - The main page and the cataloging search results page should look correct. - cataloguing/addbiblio.tt - Cataloging -> New record - The record edit page should look correct. - cataloguing/merge.tt - Cataloging -> Search -> Select two records to merge. The merge reference selection page should look correct, as well as the source/destination selection page. - cataloguing/moveitem.tt - Catalog -> Search -> View record -> Edit -> Attach item. The barcode submit form and confirmation screens should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:18:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:18:37 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-2985XI9IxJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:18:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:18:39 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-WI1u5BqBnn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70741|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70752&action=edit Bug 20042: 00-load.t fails when Elasticsearch is not installed 00-load.t fails when Elasticsearch is not installed. Blocks packaging. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:29:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:29:10 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15770-70-w1mfZMjJs8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:29:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:29:12 +0000 Subject: [Koha-bugs] [Bug 20045] New: Switch single-column templates to Bootstrap grid: Various Message-ID: <bug-20045-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 Bug ID: 20045 Summary: Switch single-column templates to Bootstrap grid: Various Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: dcook at prosentient.com.au, josef.moravec at gmail.com, misilot at fit.edu, nengard at gmail.com, testopia at bugs.koha-community.org Blocks: 19980 This patch will convert several unrelated templates to use the Bootstrap grid: - about.tt - auth.tt - serials/subscription-add.tt - admin/admin-home.tt - reports/reports-home.tt - suggestion/suggestion.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:29:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:29:12 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-fhjYsCa0Yq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 [Bug 20045] Switch single-column templates to Bootstrap grid: Various -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:29:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:29:13 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15770-70-okYjhHkhdf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69982|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70753&action=edit Bug 15770: Do not format numbers if too big At several places we got the following error if we use numbers too big for Number::Format Template process failed: undef error - round() overflow. Try smaller precision or use Math::BigFloat at /home/koha/src/Koha/Number/Price.pm line 44 It make the app explodes. The goal here is to handle these errors gracefully and easily. Test plan: - Add a manual fine to a patron of 100000000000000 - Create a patron category with an enrolment fee of 123456789012345 Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:29:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:29:37 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-SHkpRXnb95@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #38 from S?verine Queune <severine.queune at bulac.fr> --- (In reply to Jonathan Druart from comment #37) > (In reply to S?verine Queune from comment #35) > > Did I miss a dependency ? The patch doesn?t seem to apply. > > It applied correctly here, could you test again with this rebased version? New patch applies correctly. - with "Allow and notify" option, I get this sotware error : Undefined subroutine &C4::Members::GetNoticeEmailAddress called at /home/koha/src/circ/pendingreserves.pl line 95. - "Mark as lost" works well : hold is cancelled, the fields set in the syspref are correctly updated (and when I choose itemlost is changed, itemlost_on is "timestamped" (can I say it ?)). Cancellation is blocked with this 2 options if hold is placed on biblio. - with the syspref set to "Do not allow", I only see the usual option "Cancel hold". (In reply to Katrin Fischer from comment #31) > Why the holds awaiting pickup list? That would mean, you got the book for > the patron, you checked it in, you sent the email notice to the patron and > THEN you notice it's actually not there... ? Wouldn't it make more sense to > this from the holds queue or holds to pull pages that you use when looking > for the item? That was definetly a good idea to use the "Holds to pull" list, thank you Katrin ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:39:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:39:24 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-RjKLnP3ATR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:39:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:39:26 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-DL947qfB0A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70744|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70754&action=edit Bug 19987: If no z39.50/SRU servers the button should not show Test plan: [1.] Load the patch and make sure you have some Z39.50/SRU servers (Administration => Z39.50/SRU servers administration) [2.] Then go to authorities and notice that the 'New from Z39.50/SRU' button is there [3.] Next go to cataloging and notice that the 'New from Z39.50/SRU' button is there too [4.] Now make sure you have no Z39.50/SRU servers (remove the servers) (Administration => Z39.50/SRU servers administration) [5.] Go to authorities and notice that the 'New from Z39.50/SRU' button is not there [6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU' button is not there too :) Signed-off-by: Owen Leonard <oleonard at myacpl.org> I added a missing [% END %] during signoff. Hope no one minds! Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:51:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:51:29 +0000 Subject: [Koha-bugs] [Bug 20046] New: Change configuration of the authorities z39.50 search Message-ID: <bug-20046-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20046 Bug ID: 20046 Summary: Change configuration of the authorities z39.50 search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, It would be nice if the search form for the z39.50 authorities search would be revised. The principle of this form could be reversed completely. at the moment, the informations must be entered in the field corresponding to the type of authority we are looking for. It could be only a form with two fields.The first one would be for enter the information and the other one for choose the type of authority. Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:56:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:56:14 +0000 Subject: [Koha-bugs] [Bug 20047] New: Add Z3950Server Object and use it for getting server count Message-ID: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 Bug ID: 20047 Summary: Add Z3950Server Object and use it for getting server count Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:56:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:56:28 +0000 Subject: [Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count In-Reply-To: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20047-70-Hj6abUtmuu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19987 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 [Bug 19987] If no z39.50/SRU servers, the z39.50/SRU buttons should not show -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:56:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:56:28 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-pAOkmtdikW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 [Bug 20047] Add Z3950Server Object and use it for getting server count -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:57:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:57:03 +0000 Subject: [Koha-bugs] [Bug 20048] New: koha-zebra missing --status Message-ID: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20048 Bug ID: 20048 Summary: koha-zebra missing --status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com Running a koha-zebra --status kohadev told me --status was an invalid option. Turns out the option was forgotten to be added around line 225. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:57:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:57:40 +0000 Subject: [Koha-bugs] [Bug 19965] 008 tag editor not showing completely In-Reply-To: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19965-70-uPBluFRXdf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19965 --- Comment #3 from Hussain A <reza0770 at gmail.com> --- Created attachment 70755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70755&action=edit java problem for 008 tag editor Dear Katrin Fischer, Thank you for your response As you indicated, the problem is seems to be from the Java, or whatever it is, do you have any suggestions to resolve this issue? Regards -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:59:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:59:12 +0000 Subject: [Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count In-Reply-To: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20047-70-sRfgDbjIl2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 16:59:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 15:59:14 +0000 Subject: [Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count In-Reply-To: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20047-70-3QrXBdYFrm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70756&action=edit Bug 20047 - Add Koha::Z3950Server Oject and use it to get server count To test: 1 - prove t/db_dependent/Koha/Z3950Servers.t 2 - Load cataloging and authority home pages 3 - Verify you can add form z395 on each page 4 - Delete all z3950 servers 5 - Verify option to add from Z3950 is removed on both pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:03:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:03:47 +0000 Subject: [Koha-bugs] [Bug 20048] koha-zebra missing --status In-Reply-To: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20048-70-UNOjX1IgdP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20048 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:03:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:03:49 +0000 Subject: [Koha-bugs] [Bug 20048] koha-zebra missing --status In-Reply-To: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20048-70-u5ms4ZzzyN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20048 --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70757&action=edit Bug 20048: --status shell command line check missing TEST PLAN 1) Run the following commands git checkout -b bug_20048 origin/master sudo perl ~/misc4dev/cp_debian_files.pl sudo koha-zebra --status kohadev -- Will get error message 2) Run the following commands git bz apply 20048 sudo perl ~/misc4dev/cp_debian_files.pl sudo koha-zebra --status kohadev -- Will not get error message, but actual status 3) NOTE: Koha QA Test tools do not check bash scripts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:04:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:04:26 +0000 Subject: [Koha-bugs] [Bug 19971] typo in the comments of parseQuery routine In-Reply-To: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19971-70-KIsnZaqE7o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:04:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:04:28 +0000 Subject: [Koha-bugs] [Bug 19971] typo in the comments of parseQuery routine In-Reply-To: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19971-70-4fyl9fWE3x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70654|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70758&action=edit Bug 19971 Typo in the comments of parseQuery routine TEST PLAN --------- 1) Run these commands: git checkout master git pull perldoc C4::Search 2) look for parseQuery -- NOTE: The sample code provided below this heading has the wrong function name! 3) Run these commands: git checkout -b bug_19971 origin/master perldoc C4::Search 4) look for parseQuery -- NOTE: The wrong function name is corrected. 5) Run koha qa test tools Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:06:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:06:03 +0000 Subject: [Koha-bugs] [Bug 20048] koha-zebra missing --status In-Reply-To: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20048-70-8WixMHosLA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20048 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|ASSIGNED |Needs Signoff CC| |tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:07:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:07:26 +0000 Subject: [Koha-bugs] [Bug 19965] 008 tag editor not showing completely In-Reply-To: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19965-70-NXwVuB5WFL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19965 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It's hard to tell, it could be a configuration issue. What in the file at the line it shows you? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:08:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:08:14 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19221-70-viqc2P0Y6A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:08:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:08:17 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19221-70-2vUbZY6Drf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70607|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70759&action=edit Bug 19221: Onboarding tool says user needs to be made superlibrarian I changed the "To give new patron superlibrarian permissions go to:" message to "To edit patron permissions, go to:". Please clarify if this is clearer or not. Test plan: 1) Apply patch 2) Go through the web installer 3) At the create koha administrator patron step, notice that at the bottom, there is a message saying "To edit patron permissions, go to:" https://bugs.koha-community.org/show_bug.cgi?id=19221 Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:09:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:09:45 +0000 Subject: [Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra In-Reply-To: <bug-17468-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17468-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17468-70-Ypaa7mfsSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20048 CC| |mtompset at hotmail.com --- Comment #11 from M. Tompsett <mtompset at hotmail.com> --- Bug 20048 was added as a see also, because the --status flag was uncheckable while testing this. This, however, does seem to work just fine as a replacement for the koha-stop-zebra, koha-start-zebra, and koha-restart-zebra scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:09:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:09:45 +0000 Subject: [Koha-bugs] [Bug 20048] koha-zebra missing --status In-Reply-To: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20048-70-LiMxU0Ah2v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20048 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17468 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:09:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:09:57 +0000 Subject: [Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various In-Reply-To: <bug-20045-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20045-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20045-70-eyBBOeDkNf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:10:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:10:00 +0000 Subject: [Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various In-Reply-To: <bug-20045-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20045-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20045-70-TO6YnZPZpo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70760&action=edit Bug 20045: Switch single-column templates to Bootstrap grid: Various This patch updates various unrelated templates to use the Bootstrap grid. - about.tt - The about page - auth.tt - The login page These pages should look correct. - reports/reports-home.tt - The reports home page - admin/admin-home.tt - The administration home page These pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. - serials/subscription-add.tt - Serials -> Add subscription. The entry form should look correct during each step of the add/edit process. - suggestion/suggestion.tt - Acquisitions -> Suggestions -> New suggestion. The page with the new suggestion form should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:14:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:14:48 +0000 Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not links to biblio In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19825-70-UnFbwEjK1b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:14:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:14:52 +0000 Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not links to biblio In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19825-70-faE4gUjWUE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70529|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70761&action=edit Bug 19825: Make links to biblios on pending offline circulation page working again 0) Do not apply the patch 1) Have pending offline circulation operations - you can use standalone application, Firefox add-on or built-in offline circulatin client - it does not matter in this case 2) Go to Circulation -> pending offline circulation actions 3) You see all barcode in red and without links - even if the item and biblio existed 4) Apply the patch 5) Repeat 1-3, now you should see the links to biblio on existing items Note: Don't add non-existent barcodes actions and payment actions unti bug 19771 is not fixed Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:22:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:22:11 +0000 Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode In-Reply-To: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17240-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17240-70-OPkVCf0c7t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240 Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:23:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:23:51 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15770-70-hEDFYSgN8h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70753|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70762&action=edit Bug 15770: Do not format numbers if too big At several places we got the following error if we use numbers too big for Number::Format Template process failed: undef error - round() overflow. Try smaller precision or use Math::BigFloat at /home/koha/src/Koha/Number/Price.pm line 44 It make the app explodes. The goal here is to handle these errors gracefully and easily. Test plan: - Add a manual fine to a patron of 100000000000000 - Create a patron category with an enrolment fee of 123456789012345 Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:23:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:23:48 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15770-70-5wKSrSszK8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:29:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:29:58 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-mK9sOFk0wC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:30:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:30:00 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-ZGICT0chT2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70752|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70763&action=edit Bug 20042: 00-load.t fails when Elasticsearch is not installed 00-load.t fails when Elasticsearch is not installed. Blocks packaging. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:37:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:37:36 +0000 Subject: [Koha-bugs] [Bug 20049] New: Add more information in the note when we attach an item Message-ID: <bug-20049-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20049 Bug ID: 20049 Summary: Add more information in the note when we attach an item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl hi, when we use the option to attach item to a record, we only have the note "The item has successfully been attached to "title of the record.";. It would be nice to have more informations in this notification like the notice number of the origin's record of the item and the number of the record to which we have just attached an item. The message could be: "The item(XXXXXXX)from(number of the origin notice) has successfully been attached to "title of the record(Number of the new record).". Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:41:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:41:58 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-OdcbBT45Mj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70764&action=edit Bug 19287: Fix conflict with bug 19304 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:42:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:42:39 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-g1ABjZjJxL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to S?verine Queune from comment #38) > (In reply to Jonathan Druart from comment #37) > > (In reply to S?verine Queune from comment #35) > - with "Allow and notify" option, I get this sotware error : > Undefined subroutine &C4::Members::GetNoticeEmailAddress called at > /home/koha/src/circ/pendingreserves.pl line 95. Yes, conflict with bug 19287, should be ok now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 17:54:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 16:54:40 +0000 Subject: [Koha-bugs] [Bug 5062] Acq terminology: list price, ordering price, vendor price, RRP In-Reply-To: <bug-5062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5062-70-0OJ96purSE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5062 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- It may have changed since 2010, but my tests show me that RRP is not the replacement price. At least, not in the "Orders by fund" report. Here's what I entered in my order - Qty : 2 - Vendor Price : 10 $ - Tax : 9,5 % - Discount : 10 % - Replacement cost : 9 $ - Budgeted cost : 9 $ - Total : 18 $ Here's what the report gave me - Qty : 2 - List Price : 10 $ - RRP : 10 $ - Budgeted cost : 9 $ - Total RRP : 20 $ - Total cost : 18 $ So Vendor Price = List Price = RRP Also, see https://en.wikipedia.org/wiki/List_price it says List Price may also be known as RRP Unless there's a sys pref I didn't see that influences how the is calculated RRP... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:11:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:11:51 +0000 Subject: [Koha-bugs] [Bug 20021] Shelving location labelled Home library in Staff interface and OPAC with Branches In-Reply-To: <bug-20021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20021-70-oPKYMmmYte@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20021 Elaine Bradtke <eb at efdss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org --- Comment #2 from Elaine Bradtke <eb at efdss.org> --- This was a problem with an upload, and the branch data was missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:13:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:13:28 +0000 Subject: [Koha-bugs] [Bug 20021] Shelving location labelled Home library in Staff interface and OPAC with Branches In-Reply-To: <bug-20021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20021-70-UoHmL9LyWg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20021 --- Comment #3 from Elaine Bradtke <eb at efdss.org> --- I suppose we can mark it resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:14:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:14:36 +0000 Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19289-70-QxU42n2sr9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70765&action=edit Bug 19289: Use jQuery validate plugin This is quite dirty but rewrite the JS checks is out of the scope of this bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:16:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:16:35 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-JfQW6ddsFX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |tomascohen at gmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:23:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:23:29 +0000 Subject: [Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation In-Reply-To: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17171-70-NxoHZZK4LK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65925|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70766&action=edit Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:23:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:23:27 +0000 Subject: [Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation In-Reply-To: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17171-70-Z0fgJvJhwR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:24:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:24:17 +0000 Subject: [Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation In-Reply-To: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17171-70-pkEjYGwGyu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Josef Moravec from comment #8) > The file cash_register_stats.tt is edited probably by accident - it should > be removed from this patch. Removed and rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:27:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:27:56 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-nGAwUy76g9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70605|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70767&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:27:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:27:54 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-C94eks11NJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:51:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:51:49 +0000 Subject: [Koha-bugs] [Bug 20021] Shelving location labelled Home library in Staff interface and OPAC with Branches In-Reply-To: <bug-20021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20021-70-p68Jd256mt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20021 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 18:57:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 17:57:01 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-2f9x6UbBEN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #20 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70768&action=edit Bug 18736: Followup - Fix SQL and uncomment db update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:00:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:00:19 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-4tzFIOjW07@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:00:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:00:21 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-ekyDkrghgN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70767|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70769&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:03:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:03:10 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: <bug-13995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13995-70-pKiROP8fqq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #27 from M. Tompsett <mtompset at hotmail.com> --- I understand the desire to single file each exception. That makes sense. We can use directory structure to sort them if needed. git bz apply 13995 git diff origin/master | grep "package Koha::Exception::" | sed -e "s#\+package ##g" | sed -e "s#;##g" > ~/new_exceptions git grep "'Koha::Exceptions::" | grep -v "isa\W*=" | grep ^Koha/Exceptions | cut -f2- -d: | sed -e "s#[=>{ ']*##g" > ~/existing_exceptions Looking at new and existing exceptions, we see that there may be some overlap and as Tom?s Cohen Arazi pointed out in comment #26, there is likely a need for better consolidation and sorting. So even if I wanted to sign this off, there is still clean up to do here. For this reason, I am leaving it Failed QA. I would be willing to sign off if this: 1) duplicates all the exceptions in Koha/Exceptions 2) would refactor nicely such another bug would merely remove the 's' from Exceptions 3) has test coverage for all the exception files -- if 1 & 2 are met, I'd be happy to write the test coverage just to get sign offs moved forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:06:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:06:09 +0000 Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching In-Reply-To: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19604-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19604-70-2BzmSin1k8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Still applies - queries return well for me, moving back to needs signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:17:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:17:36 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15770-70-s3fYj0DIcl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:17:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:17:43 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15770-70-GDA43TY0Rx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:17:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:17:53 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-ZyasrjGTLy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gracesmythh at gmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:18:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:18:00 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19221-70-yxzGwaXePO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |terauhina.jackson at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:18:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:18:18 +0000 Subject: [Koha-bugs] [Bug 19971] typo in the comments of parseQuery routine In-Reply-To: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19971-70-DGufp8Aqjs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:24:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:24:08 +0000 Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-geen0rNSnZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Nick Clemens from comment #5) > Would be better to fix, but I didn't see the problem in a quick look. This > prevents the error for user so PQA Can someone open another bug report please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:27:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:27:04 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-MbJxlXzgbP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70770&action=edit Bug 17682: Replace 2 occurrences in de-DE and nb-NO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:31:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:31:53 +0000 Subject: [Koha-bugs] [Bug 19188] Self checkout: missing space if fine amount is blocking renewal In-Reply-To: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19188-70-N5nPGKY6V8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19188 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am wondering if we should not display the currency with the Price plugin instead. Delaying the push for now as I do not have time to deep more into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:35:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:35:17 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-cCZf0UEKt6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- As EnhancedMessagingPreferencesOPAC is turned on by default, it will affect the OPAC too, is it wanted? I would say yes, but I prefer someone else to confirm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:43:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:43:49 +0000 Subject: [Koha-bugs] [Bug 18083] Don't show 'library' selection on popular titles page for single-branch libraries In-Reply-To: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18083-70-IE9YNOIBeq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70771&action=edit Bug 18083: Simplify the condition - if there are more than 1 library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:54:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:54:09 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-AUAecjyfS1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patches pushed to master for 18.05. Congratulations Charlotte for your first patches in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:54:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:54:27 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-PxyHNW1s8e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patch pushed to master for 18.05. Congratulations Grace for your first patch in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:55:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:55:19 +0000 Subject: [Koha-bugs] [Bug 19988] Change 'sex' to 'gender' In-Reply-To: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19988-70-GECJKzIzI0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patch pushed to master for 18.05. Congratulations Zoe for your first patch in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:55:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:55:06 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19221-70-PMHbk89SRD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patch pushed to master for 18.05. Congratulations Te Rauhina for your first patch in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:55:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:55:26 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15770-70-N1JDiC0Ipr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:55:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:55:32 +0000 Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline circulation file, " apply directly" option fails In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-A5mKcwXR2h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:55:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:55:43 +0000 Subject: [Koha-bugs] [Bug 18083] Don't show 'library' selection on popular titles page for single-branch libraries In-Reply-To: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18083-70-7ksbejTJCT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:55:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:55:52 +0000 Subject: [Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields In-Reply-To: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18878-70-ybjb6JUjoH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:01 +0000 Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a barcode file In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19585-70-G0d2CK69h1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:02 +0000 Subject: [Koha-bugs] [Bug 17467] Introduce a single koha-zebra script to handle Zebra daemons for instances In-Reply-To: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17467-70-hTyju617ZZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 --- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Nick Clemens from comment #26) > Created attachment 68628 [details] [review] > Bug 17467: Add missing --status switch handling > > Signed-off-by: Josef Moravec <josef.moravec at gmail.com> > > Signed-off-by: Nick Clemens <nick at bywatersolutions.com> I missed that one! Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:07 +0000 Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display in opac or staff side In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19677-70-I9fHkOwCQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:12 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-7IsO6DR64W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:20 +0000 Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not links to biblio In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19825-70-YuNaX32YxI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:26 +0000 Subject: [Koha-bugs] [Bug 19839] invoice.pl warns about bad variable scope In-Reply-To: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19839-70-AupRKIWxQJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:30 +0000 Subject: [Koha-bugs] [Bug 19971] typo in the comments of parseQuery routine In-Reply-To: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19971-70-Rq9NFHBfOO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:36 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-lCnc7DgaqB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:37 +0000 Subject: [Koha-bugs] [Bug 17467] Introduce a single koha-zebra script to handle Zebra daemons for instances In-Reply-To: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17467-70-slh0zV3NDm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:46 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-FxQVC0j8hO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:56:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:56:52 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-nv7vOrrYpx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:58:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:58:14 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19221-70-JxwHpUCSVU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 --- Comment #7 from Magnus Enger <magnus at libriotech.no> --- Congratulations Te Rauhina, and thanks to you (and everyone else involved in QA) for fixing this. Hooray! :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:58:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:58:16 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18696-70-fYwQXJfCmr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patch pushed to master for 18.05 Thanks Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:58:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:58:23 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-pyKPPQUOcK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patch pushed to master for 18.05 Thanks Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:58:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:58:30 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18696-70-zaL3R8sicH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:58:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:58:35 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-ZNDHPP52MW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:58:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:58:39 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18696-70-7XQBef5QuA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 19:58:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 18:58:44 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-afLi6ufkvD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:11:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:11:04 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-UAp47VGeUS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #392 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70772&action=edit Bug 7143: Update about page for new dev - Grace Smyth Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:12:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:12:51 +0000 Subject: [Koha-bugs] [Bug 16603] Hide option to apply directly when processing uploaded offline circulation file In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-E9hQC2uJl0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When processing uploaded |Hide option to apply |offline circulation file, |directly when processing |"apply directly" option |uploaded offline |fails |circulation file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:13:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:13:24 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-YyUT2ycjKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #393 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70773&action=edit Bug 7143: Update about page for new dev - Charlotte Cordwell Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:13:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:13:33 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-c06N4Pminh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #394 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70774&action=edit Bug 7143: Update about page for new dev - Te Rauhina Jackson Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:13:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:13:43 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-L72ZI3l3EG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #395 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70775&action=edit Bug 7143: Update about page for new dev - Zoe Bennett Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:14:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:14:41 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-DxPiOYZbQm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #396 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Last 4 patches pushed to master for 18.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:19:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:19:34 +0000 Subject: [Koha-bugs] [Bug 20050] New: When processing uploaded offline circulation file, " apply directly" option fails Message-ID: <bug-20050-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20050 Bug ID: 20050 Summary: When processing uploaded offline circulation file, "apply directly" option fails Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/offline_circ/process_koc.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, jonathan.druart at bugs.koha-community.org, kyle.m.hall at gmail.com This problem has been hidden by 16603, but still exists: I have an offline circulation file which was generated by the Windows offline circulation program. If I upload this file and choose "Add to offline circulation queue" it works as expected. If I upload the same file and choose "Apply directly," the process never completes. Firebug shows a seemingly never-ending series of calls to /cgi-bin/koha/tools/background-job-progress.pl?jobID=8c20822320e5fbd7579aa1f61411ba00 but nothing happens. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:19:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:19:34 +0000 Subject: [Koha-bugs] [Bug 16603] Hide option to apply directly when processing uploaded offline circulation file In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-SQmK6Q1kuY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20050 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:30:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:30:17 +0000 Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date In-Reply-To: <bug-19039-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19039-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19039-70-UPzSGm0qVA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:38:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:38:05 +0000 Subject: [Koha-bugs] [Bug 20051] New: Invalid markup in staff client's header.inc Message-ID: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Bug ID: 20051 Summary: Invalid markup in staff client's header.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 19851 Bug 19851 contains a markup error: 4 instances of ids which should be a classes. This creates a validation error for duplicate ids. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 [Bug 19851] Improve responsive layout handling of staff client menu bar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:38:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:38:05 +0000 Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff client menu bar In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19851-70-BJHm9M2QOf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 [Bug 20051] Invalid markup in staff client's header.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:49:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:49:14 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-PuBHsRLfsZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70769|0 |1 is obsolete| | --- Comment #9 from Charles Farmer <charles.farmer at inlibro.com> --- Created attachment 70776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70776&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:52:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:52:22 +0000 Subject: [Koha-bugs] [Bug 19957] Allow continued editing after saving a report In-Reply-To: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19957-70-R4Evo4ERHB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com --- Comment #10 from Charles Farmer <charles.farmer at inlibro.com> --- Passes qa1. Works as advertised: I was sent back to editing the form after a modification, and the behaviour of the controller when saving an erroneous SQL is kept as is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:53:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:53:50 +0000 Subject: [Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc In-Reply-To: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20051-70-Umz8cuhY9X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 20:53:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 19:53:53 +0000 Subject: [Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc In-Reply-To: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20051-70-oWEZVDSULA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70777&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 21:04:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 20:04:08 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-orO7rxAkzh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 21:04:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 20:04:10 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-5RhKTdcYy5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70681|0 |1 is obsolete| | --- Comment #4 from Roch D'Amour <roch.damour at inlibro.com> --- Created attachment 70778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70778&action=edit Bug 20003: Fix showing number of remaining checkouts during checking in Test plan: 0) Do not apply the patch 1) Have a patron with more then one checkout 2) Return one of patron's checkout and confirm the remaining number of checkout is not shown 3) Apply the patch 4) Try it again and confirm the number is now shown Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 21:33:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 20:33:46 +0000 Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match tools sidebar In-Reply-To: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19856-70-WPobYL2wUF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com --- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> --- I don't know if it was an innocuous mistake, but the first patch modified guided-reports-view.inc, and now the only available patch on this bug changes reports-menu.inc instead. >From what I read, Josef suggested _adding_ another patch, not replacing it altogether. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 21:42:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 20:42:19 +0000 Subject: [Koha-bugs] [Bug 1] Missing uploadedmarc table definition In-Reply-To: <bug-1-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-1-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1-70-Zu70ljffvt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 --- Comment #1 from Roch D'Amour <roch.damour at inlibro.com> --- Created attachment 70779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70779&action=edit Bug 19230: Preventing warn when deleting course To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves, create a course 3) When you are taken to the course page, you should notice the 'Argument "" isn't numeric in numeric gt' warn 4) Delete course 5) Notice warn, and that no confirm message popped up 6) Apply patch 7) Create a course again. Confirm the 'Argument "" isn't numeric in numeric gt' warn did not show 8) Delete the course 9) Notice no warn and the confirm message pops up Sponsored-by: Catalyst IT Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 21:46:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 20:46:39 +0000 Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course reserves In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19230-70-iOP0YRIcQN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 21:46:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 20:46:42 +0000 Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course reserves In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19230-70-2pIIaBx9Li@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69985|0 |1 is obsolete| | --- Comment #7 from Roch D'Amour <roch.damour at inlibro.com> --- Created attachment 70780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70780&action=edit Bug 19230: Preventing warn when deleting course To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves, create a course 3) When you are taken to the course page, you should notice the 'Argument "" isn't numeric in numeric gt' warn 4) Delete course 5) Notice warn, and that no confirm message popped up 6) Apply patch 7) Create a course again. Confirm the 'Argument "" isn't numeric in numeric gt' warn did not show 8) Delete the course 9) Notice no warn and the confirm message pops up Sponsored-by: Catalyst IT Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 22:01:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 21:01:50 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl In-Reply-To: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19955-70-7tMjL5xSM2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 22:01:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 21:01:55 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl In-Reply-To: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19955-70-zMpZFsjGQL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70437|0 |1 is obsolete| | --- Comment #4 from Charles Farmer <charles.farmer at inlibro.com> --- Created attachment 70781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70781&action=edit Bug 19955 - Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 22:04:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 21:04:48 +0000 Subject: [Koha-bugs] [Bug 19955] Add ability to process only one 'type' of message ( sms, email , etc ) for a given run of process_message_queue.pl In-Reply-To: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19955-70-qw07nZeMsA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19955 --- Comment #5 from Charles Farmer <charles.farmer at inlibro.com> --- Created attachment 70782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70782&action=edit Bug 19955 - minor grammatical correction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 22:59:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 21:59:36 +0000 Subject: [Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc In-Reply-To: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20051-70-i3giwkkV4l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 19 22:59:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jan 2018 21:59:39 +0000 Subject: [Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc In-Reply-To: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20051-70-RujyrNoigl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70777|0 |1 is obsolete| | --- Comment #2 from Charles Farmer <charles.farmer at inlibro.com> --- Created attachment 70783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70783&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 20 05:10:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jan 2018 04:10:46 +0000 Subject: [Koha-bugs] [Bug 4888] pre-set of field indicators value In-Reply-To: <bug-4888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4888-70-rmUWqknI1x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Attachment #14837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 20 21:40:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jan 2018 20:40:41 +0000 Subject: [Koha-bugs] [Bug 20052] New: Add Reports object class Message-ID: <bug-20052-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052 Bug ID: 20052 Summary: Add Reports object class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: nick at bywatersolutions.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 20 21:42:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jan 2018 20:42:18 +0000 Subject: [Koha-bugs] [Bug 20052] Add Reports object class In-Reply-To: <bug-20052-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20052-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20052-70-kkxqGjUWGY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 20 21:42:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jan 2018 20:42:20 +0000 Subject: [Koha-bugs] [Bug 20052] Add Reports object class In-Reply-To: <bug-20052-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20052-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20052-70-aSfriEY2Rz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70784&action=edit Bug 20052 - Add Koha Reports object class To test: prove -v t/db_dependent/Koha/Reports.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 14:10:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 13:10:52 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16188-70-phCr6o8rvv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 14:10:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 13:10:55 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16188-70-9jz5C8NS6E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 --- Comment #1 from Indranil Das Gupta <indradg at l2c2.co.in> --- Created attachment 70785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70785&action=edit Bug 16188 - SMS via email not applicable in India due to telecom regulation This patch is applicable only for Indian users of Koha Scenario : Under Indian law, transactional bulk SMS sending requires pre-registration and approval of message templates with the Telecom Regulatory Authority of India (TRAI). Most Indian telcos do not offer this facility and even if offered, use of the feature introduced by Bug #9021 may expose the user to serious civil and criminal liability due to unsanctioned use. More details over here - https://lists.katipo.co.nz/pipermail/koha/2016-April/045124.html. This patch informs users setting up their SMSSendDriver to "Email" that this feature won't work in India. And even if they do this, it reiterates this again at Home ? Administration ? SMS cellular providers. Test plan ========= 1/ Apply the patch 2/ Check if warning is displayed when setting up the SMSSendDriver syspref as as well when accessing 'SMS cellular providers' under 'Administration -> Additional parameters' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 14:15:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 13:15:46 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16188-70-aMNxYmoEWU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Informs users in India that release notes| |the SMS via email to telco | |feature is not supported | |within India. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 18:08:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 17:08:50 +0000 Subject: [Koha-bugs] [Bug 20053] New: Drop type attribute "text/javascript" used in OPAC template Message-ID: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Bug ID: 20053 Summary: Drop type attribute "text/javascript" used in OPAC template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: indradg at l2c2.co.in QA Contact: testopia at bugs.koha-community.org If you run the Koha OPAC pages through the W3C validator it generates warnings about type attribute "text/javascript", since W3C now officially describes this as obsolete in HTML5 but still conforming to the standard with warnings [1] Since we are already pumping up HTML5 with <!DOCTYPE html>, I was thinking if we should consider an omnibus update to the following 47 templates so affected. The 47 templates: includes/calendar.inc includes/columns_settings.inc includes/datatables.inc includes/doc-head-close.inc includes/greybox.inc includes/opac-bottom.inc includes/password_check.inc includes/slip-print.inc modules/clubs/clubs-tab.tt modules/clubs/enroll.tt modules/opac-account.tt modules/opac-advsearch.tt modules/opac-auth-detail.tt modules/opac-auth-MARCdetail.tt modules/opac-auth.tt modules/opac-basket.tt modules/opac-course-details.tt modules/opac-course-reserves.tt modules/opac-detail.tt modules/opac-downloadshelf.tt modules/opac-full-serial-issues.tt modules/opac-idref.tt modules/opac-illrequests.tt modules/opac-imageviewer.tt modules/opac-MARCdetail.tt modules/opac-memberentry.tt modules/opac-messaging.tt modules/opac-overdrive-search.tt modules/opac-passwd.tt modules/opac-password-recovery.tt modules/opac-readingrecord.tt modules/opac-request-article.tt modules/opac-reserve.tt modules/opac-results-grouped.tt modules/opac-results.tt modules/opac-review.tt modules/opac-search-history.tt modules/opac-shareshelf.tt modules/opac-shelves.tt modules/opac-showreviews.tt modules/opac-suggestions.tt modules/opac-tags.tt modules/opac-topissues.tt modules/opac-user.tt modules/sco/help.tt modules/sco/printslip.tt modules/sco/sco-main.tt Reference: [1] https://www.w3.org/TR/2017/REC-html52-20171214/obsolete.html#warnings-for-obsolete-but-conforming-features -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 18:09:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 17:09:18 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" used in OPAC template In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-smBE22upFS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 18:42:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 17:42:42 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" used in OPAC template In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-1t3J3RIO6D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 18:44:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 17:44:56 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" used in OPAC template In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-NpEJyoqXRL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #1 from Indranil Das Gupta <indradg at l2c2.co.in> --- Created attachment 70786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70786&action=edit Bug 20053 - Drop type attribute "text/javascript" in OPAC templates Conformance rules for HTML5 is generating warnings for <script> element with type="text/javascript" attribute when the OPAC page is checked with W3C Validator. This patch removes the cause of these warnings. Test plan ========= 1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch about 10+ warnings being generated by the validator. 2/ Apply patch and re-submit the page to the Validator. The warnings would be gone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 18:44:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 17:44:53 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" used in OPAC template In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-iiuhiAbDWo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 19:05:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 18:05:13 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-MZpuRgpKSs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Drop type attribute |Drop type attribute |"text/javascript" used in |"text/javascript" for |OPAC template |<script> elements used in | |OPAC templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 19:09:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 18:09:39 +0000 Subject: [Koha-bugs] [Bug 20054] New: Remove attribute "text/css" for <style> element used in the OPAC templates Message-ID: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Bug ID: 20054 Summary: Remove attribute "text/css" for <style> element used in the OPAC templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: indradg at l2c2.co.in QA Contact: testopia at bugs.koha-community.org Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. The type attribute is optional, and when none is provided it defaults to "text/css" - https://www.w3.org/TR/html5/document-metadata.html#element-attrdef-style-type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 19:34:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 18:34:48 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-tEeOoafIKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 19:34:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 18:34:51 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-sHd3fe02TT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 --- Comment #1 from Indranil Das Gupta <indradg at l2c2.co.in> --- Created attachment 70787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70787&action=edit Bug 20054 - Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 19:35:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 18:35:25 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-EvvqFlQv9a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20054 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 19:35:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 18:35:25 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-DSEiED0USX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20053 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 21 21:58:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jan 2018 20:58:16 +0000 Subject: [Koha-bugs] [Bug 6339] ExtendedPatronAttributes to allow for a DatePicker (JS Calendar) style field In-Reply-To: <bug-6339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6339-70-Uoqk5Ted5D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6339 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall at gmail.com |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 05:15:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 04:15:17 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16188-70-pXAsiN0Yap@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70785 Bug 16188 - SMS via email not applicable in India due to telecom regulation Review of attachment 70785: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16188&attachment=70785) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref @@ +129,4 @@ > - > - "Use the SMS::Send::" > - pref: SMSSendDriver > + - driver to send SMS messages. <em>(<a href="//lists.katipo.co.nz/pipermail/koha/2016-April/045114.html">Do not set this</a> to 'Email' if you are in India)</em><br/> https: is missing. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/sms_providers.tt @@ +55,5 @@ > [% ELSE %] > > <div class="dialog message"> > + There are no SMS cellular providers defined.<br/><br/> > + <em>This feature <a href="//lists.katipo.co.nz/pipermail/koha/2016-April/045114.html">does not work</a> if you are in India</em> https: is missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 05:15:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 04:15:31 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16188-70-DI8VLOkvht@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 07:19:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 06:19:47 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16188-70-3fbBuH58pK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70785|0 |1 is obsolete| | --- Comment #3 from Indranil Das Gupta <indradg at l2c2.co.in> --- Created attachment 70788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70788&action=edit Bug 16188 - SMS via email not applicable in India due to telecom regulation This patch is applicable only for Indian users of Koha Scenario : Under Indian law, transactional bulk SMS sending requires pre-registration and approval of message templates with the Telecom Regulatory Authority of India (TRAI). Most Indian telcos do not offer this facility and even if offered, use of the feature introduced by Bug #9021 may expose the user to serious civil and criminal liability due to unsanctioned use. More details over here - https://lists.katipo.co.nz/pipermail/koha/2016-April/045124.html. This patch informs users setting up their SMSSendDriver to "Email" that this feature won't work in India. And even if they do this, it reiterates this again at Home ? Administration ? SMS cellular providers. Test plan ========= 1/ Apply the patch 2/ Check if warning is displayed when setting up the SMSSendDriver syspref as as well when accessing 'SMS cellular providers' under 'Administration -> Additional parameters' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 07:19:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 06:19:44 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16188-70-soywrgacSu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 09:03:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 08:03:25 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-NOK1X7awJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7) > As EnhancedMessagingPreferencesOPAC is turned on by default, it will affect > the OPAC too, is it wanted? > I would say yes, but I prefer someone else to confirm. Yes, I think that is a logical step. To compare, the dbrev initialized the opac pref with the same value as the staff counterpart. A new install now does the same, while enabling them is probably preferred. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 09:05:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 08:05:37 +0000 Subject: [Koha-bugs] [Bug 20055] New: New suggestion from OPAC records borrowernumber instead of branchcode Message-ID: <bug-20055-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20055 Bug ID: 20055 Summary: New suggestion from OPAC records borrowernumber instead of branchcode Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: bob at calyx.net.au QA Contact: testopia at bugs.koha-community.org A new suggestion, from a user logged into the OPAC, causes the borrowernumber to be written to both the 'suggestedby' and 'branchcode' fields of the suggestions table. Version 17.05.06 on Debian 8, from packages. Until we upgraded from 16.11.11, both fields were written correctly. Sys pref settings: - suggestion : Allow - AnonSuggestions: Don't allow - AllowPurchaseSuggestionBranchChoice : Don't allow To check the error: - log in to the OPAC; - enter a new purchase suggestion; - log into the staff client: attempting to display the new suggestion fails due to the invalid branchcode; - locate the new suggestion in the database: observe that branchcode field contains the borrowernumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 09:49:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 08:49:29 +0000 Subject: [Koha-bugs] [Bug 20056] New: Resolve uninitialized warn in cmp_sysprefs.pl Message-ID: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 Bug ID: 20056 Summary: Resolve uninitialized warn in cmp_sysprefs.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Use of uninitialized value in addition (+) at misc/maintenance/cmp_sysprefs.pl line 125. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 09:50:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 08:50:11 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-dfQVKL8t2q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Resolve uninitialized warn |Uninitialized warn in |in cmp_sysprefs.pl |cmp_sysprefs.pl Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 09:50:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 08:50:23 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-RKxapowMHn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 09:52:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 08:52:47 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-N8gwq2jLQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 09:52:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 08:52:49 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-jApF42X3NU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70789&action=edit Bug 20056: Resolve uninitialized warn in cmp_sysprefs.pl When running a compare with --upd flag, I got the following warn: Use of uninitialized value in addition (+) at misc/maintenance/cmp_sysprefs.pl line 125. This is simply resolved by not returning undef but 0 in case of the Version syspref in the sub UpdateOnePref. Test plan: Look at this simple change. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 10:42:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 09:42:04 +0000 Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in patron modification screen In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19857-70-t8wd4wHafP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 10:44:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 09:44:45 +0000 Subject: [Koha-bugs] [Bug 16764] Update printers administration page In-Reply-To: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16764-70-LGhOTIazr7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 10:50:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 09:50:30 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19705-70-V70MMTjyEl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 11:01:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 10:01:16 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7376-70-CUtIVsQLxx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- >From my tests on master this one is still valid. Reading to the other bugs related to branch/library transfer limits it seems that those configuration options have no effect atm. Is this correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 11:46:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 10:46:39 +0000 Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19860-70-YwjjRk0Nra@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 11:46:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 10:46:40 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14546-70-okn5fuNQA8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 19860, which changed state. Bug 19860 Summary: Make staff client home page responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 11:47:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 10:47:19 +0000 Subject: [Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt In-Reply-To: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19338-70-UotWzzRjYy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 11:50:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 10:50:15 +0000 Subject: [Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt In-Reply-To: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19338-70-TVcg3ET63i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338 --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 11:53:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 10:53:43 +0000 Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for transfer-slip. In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19798-70-YaeTke6O9G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Bug 18276 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 11:56:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 10:56:38 +0000 Subject: [Koha-bugs] [Bug 18183] jQuery append error related to script tags in cloneItemBlock In-Reply-To: <bug-18183-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18183-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18183-70-ufNQfxA4Hw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18183 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 11:57:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 10:57:45 +0000 Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn't honor IntranetNumbersPreferPhrase In-Reply-To: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19807-70-7A0FaOal84@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 11:58:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 10:58:36 +0000 Subject: [Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt In-Reply-To: <bug-19918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19918-70-EnGoFcFGW7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 11:59:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 10:59:13 +0000 Subject: [Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin In-Reply-To: <bug-19899-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19899-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19899-70-XTG2WcBufQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Bug 18276 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:11:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:11:01 +0000 Subject: [Koha-bugs] [Bug 20029] Verbosity issue that makes the QA tools test suite report 2 failures In-Reply-To: <bug-20029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20029-70-ikn5AJfFXT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20029 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Failing tests are 22 and 23. not ok 22 - Check verbosity output (0) # Failed test 'Check verbosity output (0)' # at t/Perl.t line 261. # got: ' FAIL i_fail_yaml.yaml # OK git manipulation # FAIL yaml_valid # # FAIL perl/Authority.pm # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # FAIL pod coverage # OK spelling # OK valid # # OK perl/i_dont_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_compil.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_critic.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_license.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_patterns.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # FAIL spelling # OK valid # # FAIL perl/i_fail_template_name.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_unused_declared_variables.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # OK perl/i_m_ok.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/updatedatabase.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL sql/kohastructure.sql # FAIL charset_collate # OK git manipulation # # FAIL sql/sysprefs.sql # OK git manipulation # FAIL semicolon # FAIL sysprefs_order # # FAIL tmpl/i_fail_patterns.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_theme.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_tt_plugins.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # FAIL tmpl/i_fail_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # FAIL tt_valid # OK valid_template # # FAIL tmpl/i_fail_valid_template.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # OK tmpl/i_will_be_correct_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # ' # expected: ' FAIL i_fail_yaml.yaml # FAIL perl/Authority.pm # OK perl/i_dont_fail_spelling.pl # FAIL perl/i_fail_compil.pl # FAIL perl/i_fail_critic.pl # FAIL perl/i_fail_license.pl # FAIL perl/i_fail_patterns.pl # FAIL perl/i_fail_spelling.pl # FAIL perl/i_fail_template_name.pl # FAIL perl/i_fail_unused_declared_variables.pl # OK perl/i_m_ok.pl # FAIL perl/updatedatabase.pl # FAIL sql/kohastructure.sql # FAIL sql/sysprefs.sql # FAIL tmpl/i_fail_patterns.tt # FAIL tmpl/i_fail_patterns_theme.tt # FAIL tmpl/i_fail_patterns_tt_plugins.tt # FAIL tmpl/i_fail_tt_valid.tt # FAIL tmpl/i_fail_valid_template.tt # OK tmpl/i_will_be_correct_tt_valid.tt # ' not ok 23 - Check verbosity output (1) # Failed test 'Check verbosity output (1)' # at t/Perl.t line 262. # got: ' FAIL i_fail_yaml.yaml # OK git manipulation # FAIL yaml_valid # # FAIL perl/Authority.pm # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # FAIL pod coverage # OK spelling # OK valid # # OK perl/i_dont_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_compil.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_critic.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_license.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_patterns.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # FAIL spelling # OK valid # # FAIL perl/i_fail_template_name.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_unused_declared_variables.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # OK perl/i_m_ok.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/updatedatabase.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL sql/kohastructure.sql # FAIL charset_collate # OK git manipulation # # FAIL sql/sysprefs.sql # OK git manipulation # FAIL semicolon # FAIL sysprefs_order # # FAIL tmpl/i_fail_patterns.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_theme.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_tt_plugins.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # FAIL tmpl/i_fail_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # FAIL tt_valid # OK valid_template # # FAIL tmpl/i_fail_valid_template.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # OK tmpl/i_will_be_correct_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # ' # expected: ' FAIL i_fail_yaml.yaml # OK git manipulation # FAIL yaml_valid # # FAIL perl/Authority.pm # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # OK perl/i_dont_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_compil.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_critic.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_license.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_patterns.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # FAIL spelling # OK valid # # FAIL perl/i_fail_template_name.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_unused_declared_variables.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # OK perl/i_m_ok.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/updatedatabase.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL sql/kohastructure.sql # FAIL charset_collate # OK git manipulation # # FAIL sql/sysprefs.sql # OK git manipulation # FAIL sysprefs_order # # FAIL tmpl/i_fail_patterns.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_theme.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_tt_plugins.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # FAIL tmpl/i_fail_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # FAIL tt_valid # OK valid_template # # FAIL tmpl/i_fail_valid_template.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # OK tmpl/i_will_be_correct_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # ' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:20:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:20:45 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: <bug-19914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19914-70-TH0Z3ATmXx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |19560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 [Bug 19560] Unable to delete library when branchcode contains special characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:20:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:20:45 +0000 Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19560-70-ij2gfnHwFl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19914 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 [Bug 19914] Cannot locate the "Delete" in the library list table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:23:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:23:28 +0000 Subject: [Koha-bugs] [Bug 18754] Translatability: Get rid of exposed tt directives in opac-detail.tt In-Reply-To: <bug-18754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18754-70-NNw1M3Emhh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:23:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:23:29 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: <bug-19913-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19913-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19913-70-wmJj115mON@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Bug 19913 depends on bug 18754, which changed state. Bug 18754 Summary: Translatability: Get rid of exposed tt directives in opac-detail.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:23:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:23:50 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: <bug-19913-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19913-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19913-70-So7l6I6pe4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:25:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:25:20 +0000 Subject: [Koha-bugs] [Bug 19913] Embedded HTML5 videos are broken In-Reply-To: <bug-19913-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19913-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19913-70-RIyroBO1i2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:28:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:28:09 +0000 Subject: [Koha-bugs] [Bug 16782] Display report URL in staff client report interface In-Reply-To: <bug-16782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16782-70-izagMqcnAY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #27 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:36:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:36:59 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-iR71ThSfXQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #189 from Hugo Agud <hagud at orex.es> --- I have applied the patch propertly, but I am not able to make the local mana server work.. I follow all instructions. I have installed in a kohadev server, I had to install manual via cpan some of the perl packages, everything seems to goes fine.. but on localhost:5000 nothing appears.. is that the normal behaviour? PID/Program name tcp 0 0 0.0.0.0:5000 0.0.0.0:* LISTEN 2814/plackup tcp 0 0 127.0.0.1:3306 0.0.0.0:* LISTEN - tcp 0 0 127.0.0.1:11211 0.0.0.0:* LISTEN - tcp 0 0 0.0.0.0:111 0.0.0.0:* LISTEN - tcp 0 0 0.0.0.0:45397 0.0.0.0:* LISTEN - tcp 0 0 0.0.0.0:22 0.0.0.0:* LISTEN - tcp 0 0 127.0.0.1:25 0.0.0.0:* LISTEN - tcp6 0 0 :::41475 :::* LISTEN - tcp6 0 0 :::111 :::* LISTEN - tcp6 0 0 :::8080 :::* LISTEN - tcp6 0 0 :::80 :::* LISTEN - tcp6 0 0 :::22 :::* LISTEN - tcp6 0 0 ::1:25 :::* LISTEN - -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:40:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:40:33 +0000 Subject: [Koha-bugs] [Bug 20057] New: Auto-approve option for borrower modifications Message-ID: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Bug ID: 20057 Summary: Auto-approve option for borrower modifications Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We (Gothenburg University) allow patrons to change their own personal details at will. The need for either email verification (not everyone has a registered email address) or staff approval is an unnecessary obstacle. Here is a request (and code) for automatic approval of detail changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:41:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:41:09 +0000 Subject: [Koha-bugs] [Bug 20057] Auto-approve option for borrower modifications In-Reply-To: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20057-70-Z8Z3s650xB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #1 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> --- Created attachment 70790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70790&action=edit Syspref for auto approval of patron profile changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:54:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:54:15 +0000 Subject: [Koha-bugs] [Bug 20058] New: Option to use shelving location instead of homebranch for sorting Message-ID: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 Bug ID: 20058 Summary: Option to use shelving location instead of homebranch for sorting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com By default a checkin response via SIP2 has homebranch in AQ. AQ is used for sorting by our (Gothenburg University) machines. The provided patch adds a syspref to select permanent_location instead of homebranch as the value put in AQ. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:54:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:54:32 +0000 Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20058-70-qjk3ligAx7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 --- Comment #1 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> --- Created attachment 70791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70791&action=edit Add option to send permanent_location as AQ in SIP response -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:58:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:58:23 +0000 Subject: [Koha-bugs] [Bug 20059] New: Option to allow checkin of non-issued items without setting SIP-alert Message-ID: <bug-20059-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20059 Bug ID: 20059 Summary: Option to allow checkin of non-issued items without setting SIP-alert Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com SIP-alert is set from the return value of the checkin call. This sets the message NotIssued when the book is already available, causing SIP-alert to be set. SIP-alert is also used in sorting during checkin, which conflicts with more obvious alerts. Patch provides an option to allow NotIssued to be SIP-checked-in without triggering the alert flag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 12:59:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 11:59:20 +0000 Subject: [Koha-bugs] [Bug 20059] Option to allow checkin of non-issued items without setting SIP-alert In-Reply-To: <bug-20059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20059-70-iQ5hGIs55x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20059 --- Comment #1 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> --- Created attachment 70792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70792&action=edit Syspref for not setting alert flag when book is available (not on loan) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 13:03:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 12:03:50 +0000 Subject: [Koha-bugs] [Bug 20060] New: Uninitialized warn from Koha::Template::Plugin::Branches Message-ID: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 Bug ID: 20060 Summary: Uninitialized warn from Koha::Template::Plugin::Branches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Use of uninitialized value in string eq at /usr/share/koha/shadowclone/Koha/Template/Plugin/Branches.pm line 68. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 13:25:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 12:25:09 +0000 Subject: [Koha-bugs] [Bug 20061] New: koha-common is not pulling libsearch-elasticsearch-perl Message-ID: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Bug ID: 20061 Summary: koha-common is not pulling libsearch-elasticsearch-perl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net Bug 19542 introduced the harder dependency but failed to add it to PerlDependencies.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 13:25:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 12:25:18 +0000 Subject: [Koha-bugs] [Bug 20061] koha-common is not pulling libsearch-elasticsearch-perl In-Reply-To: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20061-70-OBLoNiiIOk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |19542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542 [Bug 19542] Koha should display Elasticsearch information in the about page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 13:25:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 12:25:18 +0000 Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19542-70-k0Pwqk1wcS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20061 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 [Bug 20061] koha-common is not pulling libsearch-elasticsearch-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 13:50:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 12:50:02 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20060-70-IZ6I1lQy0e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 13:50:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 12:50:05 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20060-70-7mDfIDeiAL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70793&action=edit Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches The warn comes from undefined C4::Context->userenv->{branch}. Can be triggered by calling mainpage.pl when being logged out in staff. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 13:50:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 12:50:21 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20060-70-C8Os4rrxmR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:03:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:03:37 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20060-70-XyIGFt8tXW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- To convince you. This is how userenv looks: $VAR1 = { 'branchprinter' => undef, 'emailaddress' => undef, 'branchname' => undef, 'surname' => undef, 'branch' => undef, 'persona' => undef, 'firstname' => undef, 'cardnumber' => undef, 'id' => '', 'barshelves' => undef, 'pubshelves' => undef, 'shibboleth' => undef, 'totshelves' => undef, 'flags' => undef, 'number' => undef }; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:30:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:30:09 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-Gw4RQaay4g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:30:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:30:11 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-INdMfh7XT5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70786|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70794&action=edit Bug 20053: Drop type attribute "text/javascript" in OPAC templates Conformance rules for HTML5 is generating warnings for <script> element with type="text/javascript" attribute when the OPAC page is checked with W3C Validator. This patch removes the cause of these warnings. Test plan ========= 1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch about 10+ warnings being generated by the validator. 2/ Apply patch and re-submit the page to the Validator. The warnings would be gone. Signed-off-by: Owen Leonard <oleonard at myacpl.org> The QA tool raises some warnings, but these are about issues which pre-date this patch. They should be addressed in a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:30:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:30:29 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-YSdFlWa8hL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:30:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:30:33 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-6vJEYtLum7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67610|0 |1 is obsolete| | Attachment #67611|0 |1 is obsolete| | Attachment #68297|0 |1 is obsolete| | --- Comment #75 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70795&action=edit Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:30:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:30:38 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-z7q1vPNk25@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #76 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70796&action=edit Bug 14576: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:30:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:30:42 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-SU8caDY6KL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #77 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70797&action=edit Bug 14576: Followup Fix (remove) extra call for item Fix rebase error code duplication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:34:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:34:19 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-Aj2WkDGqsm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Prevents warnings about release notes| |type attribute being | |generated for <script> | |elements when testing the | |OPAC pages using W3C | |Validator for HTML5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:35:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:35:07 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-EOX9iX1Po3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Prevents warnings about release notes| |type attribute being | |generated for <style> | |elements when testing the | |OPAC pages using W3C | |Validator for HTML5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:38:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:38:02 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-JlRUsXVlHo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:38:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:38:05 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-7R3Bjp0acf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70798&action=edit Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:41:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:41:40 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-iMcyi8Rt54@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70787|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 14:55:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 13:55:21 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8976-70-BWWiBwCwVm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 15:35:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 14:35:15 +0000 Subject: [Koha-bugs] [Bug 19873] Make it possible to search on value 0 In-Reply-To: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19873-70-DYIFc1fgwh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 --- Comment #4 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to M. Tompsett from comment #3) > Comment on attachment 70122 [details] [review] > Bug 19873 - Ability to search on 0 value > > Review of attachment 70122 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Search.pm > @@ +1532,4 @@ > > for ( my $i = 0 ; $i <= @operands ; $i++ ) { > > > > # COMBINE OPERANDS, INDEXES AND OPERATORS > > + if ( $operands[$i] ne '' ) { > > perhaps a $operands[$i] // q{} ne q{} would be in order. > We don't want floody logs if $operands[$i] is undef. > > @@ +1677,4 @@ > > query_desc => $query_desc, > > operator => ($operators[ $i - 1 ]) ? $operators[ $i - 1 ] : '', > > parsed_operand => $operand, > > + original_operand => ($operands[$i] ne '') ? $operands[$i] : '', > > perhaps a $operands[$i] // q{} is sufficient? > We don't want floody logs if $operands[$i] is undef. We want to search on 0 value. And $operands[$i] // q{} is false if $operands[$i] equals 0: (0 ne '') => 1 (0 // '') => 0 (0 // q{}) => 0 (0 ne q{}) => 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 15:54:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 14:54:31 +0000 Subject: [Koha-bugs] [Bug 20029] Verbosity issue that makes the QA tools test suite report 2 failures In-Reply-To: <bug-20029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20029-70-HSqjNx3YDv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20029 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- commit aa1a156ade9afb8f6e1268dd85bab6d0b6fa3831 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jan 22 11:51:26 2018 -0300 updatedatabase.pl must be valid But fail since Bug 19760: Die if koha-conf is not accessible commit 09b5f33c1a03e5c99e3b40a1ee9ff2ab4167fa6e Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jan 22 11:18:17 2018 -0300 follow-up pod coverage commit a7805b48e2d72626630ddc3ad72fc50ed7c303dc Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jan 22 11:12:18 2018 -0300 follow-up Lines should not terminate by semicolons in sysprefs.sql Test output has not been updated in previous commit commit 139edc158a9a2e546911ea9041ef37cdaafaefb9 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Jan 22 11:10:52 2018 -0300 follow-up Add the --failures flag Fix silly conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 16:23:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 15:23:36 +0000 Subject: [Koha-bugs] [Bug 19943] Koha::Biblio - Remove GetBiblioItemData In-Reply-To: <bug-19943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19943-70-pwVRAkYsMT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19943 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to M. Tompsett from comment #4) > Comment on attachment 70385 [details] [review] > Bug 19943: Koha::GetBiblioItemData - Replace existing occurrences > > Review of attachment 70385 [details] [review]: > ----------------------------------------------------------------- > > ::: circ/bookcount.pl > @@ +39,5 @@ > > my $biblionumber = $input->param('biblionumber'); > > > > my $idata = itemdatanum($itm); > > +my $biblio = Koha::Biblios->find( $biblionumber ); > > +die "No valid biblionumber passed" unless $biblio; # FIXME A bit rude! > > I believe if you purposefully call bookcount.pl directly so as to trigger > this, GetBiblioItemData wouldn't die this way in the old code. Also, you can > only call this from an existing catalogue/moredetail.tt page. > Perhaps the uglier: > $data = $biblio ? $biblio->unblessed : {}; Nope, I am waiting for output_and_exit_if_error from bug 18403 to deal with that. > ::: t/db_dependent/Biblio.t > @@ +198,5 @@ > > is( $marc->subfield( $title_field, $title_subfield ), $title, ); > > > > + my $biblioitem = Koha::Biblioitems->find( $biblioitemnumber ); > > + is( $biblioitem->_result->biblio->title, $title, # Should be $biblioitem->biblio instead, but not needed elsewhere for now > > + 'Do not know if this makes sense - compare result of previous two GetBiblioData tests.'); > > This test was proving that the GetBiblioItemData function worked by > confirming that the title set in the Biblio was the one retrieved in this > function. Given that this bug patch set removes the function, I'm not sure > this test is needed at all. I'd recommend removing this one test. I added a comment to tell that, so I think it's ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 16:30:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 15:30:23 +0000 Subject: [Koha-bugs] [Bug 20062] New: Remove support for Internet Explorer 7 in the staff client Message-ID: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 Bug ID: 20062 Summary: Remove support for Internet Explorer 7 in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org There are several templates in the staff client which include a JavaScript shim adding functionality to Internet Explorer < version 9, required for the search result browser feature: <!--[if lt IE 9]> <script type="text/javascript" src="[% interface %]/lib/shims/json2.min.js"></script> <![endif]--> Internet Explorer 7 was released in 2006 and should not be actively supported. The templates should be modified to omit this block, and the shim JS should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 16:51:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 15:51:56 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-zfVdvOEEPA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #39) > Could you test this one, Jonathan ? It fixes the problem, but it sounds like there is something else to fix: On a new DB: MariaDB [koha_kohadev]> select tagfield, tagsubfield, hidden from auth_subfield_structure where tagfield=551 and tagsubfield=9 and authtypecode="GEOGR_NAME"\G *************************** 1. row *************************** tagfield: 551 tagsubfield: 9 hidden: 1 Edit the subfields for GEOGR_NAME /admin/auth_subfields_structure.pl?op=add_form&tagfield=551&authtypecode=GEOGR_NAME Possible value for "Select to display or not"/hidden are -5 and 0, so "Show all" is displayed. Save without modifying anything: hidden is now '0' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 16:55:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 15:55:02 +0000 Subject: [Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id In-Reply-To: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20014-70-OsCklTX8qO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Retested on master, I can recreate: Setup a budget with some funds Duplicate the budget,make one of them inactive MarcFieldsToOrder: price: 975$p quantity: 975$q budget_code: 975$h MarcItemFieldsToOrder: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 975 from record: =975 \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK You will need to adjust subfield $h to the name of on of your funds that is duplicated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 16:56:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 15:56:26 +0000 Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client In-Reply-To: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20062-70-Wgc2E0KKLs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 16:56:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 15:56:29 +0000 Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client In-Reply-To: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20062-70-A5Zb4Lyl18@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70799&action=edit Bug 20062: Remove support for Internet Explorer 7 in the staff client This patch removes JavaScript files which were added to support Internet Explorer 7. Templates which included the files have been modified accordingly. To test, apply the patch and clear your browser cache if necessary. Perform a catalog search in the staff client and click through to view one of the search results. The search results navigation menu in the left-hand sidebar should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 16:57:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 15:57:48 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-ZqHSTgQ3Ct@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Is it possible that the lack of mention of CSV could confuse people who don't know what the text forms of CSV look like? If so, should we write ?CSV (Semicolon separated)? instead of ?Semicolon separated text? ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:02:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:02:16 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15869-70-V1yhv5KiCN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55543|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70800&action=edit Bug 15869 - change framework on overlay This patch allows for selection of framework to use when overlaying records - by default it is set to keep the initial framework To test: 1 - Create some records using one framework 2 - Export the records 3 - Edit the records to add fields not in original framework 4 - Stage records using a rule that will find matches 5 - Import 6 - Note records contain new fields on display, but they are lost on edit 7 - Apply patch 8 - Stage records again 9 - Select a framework that contains the new fields on import 10 - Import records 11 - Note records now use selected framework and are displayed/edited correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:02:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:02:13 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15869-70-SnW6jVut2q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:08:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:08:14 +0000 Subject: [Koha-bugs] [Bug 19270] Advanced Editor - Rancor - Add ability to search batches on arbitrary marc fields In-Reply-To: <bug-19270-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19270-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19270-70-eCfgafRUyV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19270 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Depends on 19269 which depends on 18823, need unit tests down the line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:08:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:08:21 +0000 Subject: [Koha-bugs] [Bug 19269] Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate In-Reply-To: <bug-19269-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19269-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19269-70-SgThcgKH5J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19269 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:15:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:15:28 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-DBqL9WDZ0M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #4 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- (In reply to Victor Grousset/tuxayo from comment #3) Not writing at least CSV might be right about the theoretical meaning of CSV. But if we only write "semicolon separated values" it might be possible that enough users don't realize that it's the same thing that I usually called CSV. (Opinion of someone having a better perceptive about this is needed) Also: isn't the extension still .csv anyway? So the OSes will try to open the file with a spreadsheet software. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:15:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:15:48 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-UdEsbo7uG5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Caroline Cyr La Rose from comment #3) > I'm stuck at step 4. > > I applied the patch and ran the two scripts update_dbix_class_files.pl and > updatedatabase.pl. I then went into admin>patron categories and got a > software error : > > Template process failed: undef error - The method quick_add_display is not > covered by tests! at C4/Templates.pm line 121. I add this message when dbix class files are not updated. Be sure to have quick_add_display in Koha/Schema/Result/Category.pm. If using Plack/Memcached, restart them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:18:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:18:30 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-RwIqIGzt5c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64422|0 |1 is obsolete| | --- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 70801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70801&action=edit Bug 18818: Display in quick add list now depends on a field in database test plan: 1 - Apply patch 2 - Run update misc/devel/update_dbix_class_files.pl 3 - Run installer/data/mysql/updatedatabase.pl 4 - Check in Administation>patron categories there is a field named "Display in Quick add patron" (and check everything is set to "Display") 5 - Try to edit and check that the field exists and edits well the field 6 - Go to Patrons => quick add patron and check that the list displayed only consists in wished categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:39:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:39:18 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-XCvZNXXEii@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 70802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70802&action=edit Bug 18818: (followup) correct template Main change is the use of Yes/No instead if Display/Don't display. It is more compact and more explicit. And fixes in categories.tt : - Template Toolkit markup inside HTML in <select id="quick_add_display"> - Missing double-quotes in HTML attributes - Missing value display in delete confirmation table - Correct capitalization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:44:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:44:06 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-XsHIdgYOyG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Marc V?ron from comment #2) > Works fine. > > There is a small capitalization issue (List view and edit) > > Display > Don't Display (should be: Don't display) > > For readability, what about a change to the following in both list end edit > form? > Show > Hide I've chosen to be more simple with Display in quick add : Yes/No. Some template fixes where needed. See follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:44:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:44:19 +0000 Subject: [Koha-bugs] [Bug 20063] New: $9 is lost when cataloguing authority records Message-ID: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20063 Bug ID: 20063 Summary: $9 is lost when cataloguing authority records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Cataloging Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 18811 Bug 18811 has terrible side-effects: commit 7e222bb0796196f1e466b73d909fd28d529cab75 Bug 18811: Change visibility checks in authorities.pl next if $tagslib->{$tag}->{$subfield}->{hidden}; I was trying to test the AuthDisplayHierarchy behaviour and notice that the $9 was not filled with the related (broader) authority id. Indeed it is hidden. See bug 18811 comment 33 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 [Bug 18811] Visibility settings inconsistent between framework and authority editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:44:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:44:19 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-sJsFmLVnq4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20063 [Bug 20063] $9 is lost when cataloguing authority records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:45:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:45:06 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-rdxFKgtnY0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #38) > Created attachment 70614 [details] [review] > Bug 18811: (QA follow-up) Allow hidden $9 subfields Patch moved to bug 20063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:45:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:45:12 +0000 Subject: [Koha-bugs] [Bug 20064] New: Cannot place a hold for any student Message-ID: <bug-20064-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20064 Bug ID: 20064 Summary: Cannot place a hold for any student Change sponsored?: --- Product: Koha Version: 16.11 Hardware: PC OS: Windows Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: msexton at jonesvilleschools.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com error message appears for Koha V 16.11.07 Cannot place hold Too many holds for this record: Student Name can only place a maximum of 0 hold(s) on this record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:45:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:45:31 +0000 Subject: [Koha-bugs] [Bug 20063] $9 is lost when cataloguing authority records In-Reply-To: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20063-70-yZnb0SIjsW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20063 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70803&action=edit Bug 20063: (bug 18811 follow-up) Allow hidden $9 subfields Although we could argue that the user should make all $9 subfields visible, this might be a good compromise. It selectively reverts the change from the first patch by accepting $9 subfields without checking the hidden flag in the framework. Test plan: [1] Make a subfield $9 visible for some authority field. [2] Put a value in it somewhere in authorities.pl [3] Make subfield $9 invisible in the auth framework. [4] Open and save the adjusted authority record. [5] Check the marcxml of this record. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:45:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:45:28 +0000 Subject: [Koha-bugs] [Bug 20063] $9 is lost when cataloguing authority records In-Reply-To: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20063-70-Nc95aRsBJv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20063 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:46:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:46:35 +0000 Subject: [Koha-bugs] [Bug 20064] Cannot place a hold for any student In-Reply-To: <bug-20064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20064-70-noFcRrLoPj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20064 Mark Sexton <msexton at jonesvilleschools.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msexton at jonesvilleschools.o | |rg Priority|P5 - low |P2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:47:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:47:52 +0000 Subject: [Koha-bugs] [Bug 20063] $9 is lost when cataloguing authority records In-Reply-To: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20063-70-lGM4LxYq0z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20063 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:48:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:48:06 +0000 Subject: [Koha-bugs] [Bug 20063] $9 is lost when cataloguing authority records In-Reply-To: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20063-70-iBGe4e9Bee@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20063 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:48:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:48:56 +0000 Subject: [Koha-bugs] [Bug 20063] $9 is lost when cataloguing authority records In-Reply-To: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20063-70-D08nTWoJJX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20063 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:49:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:49:21 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-jiB6tiEb0H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05 Thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 17:52:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 16:52:30 +0000 Subject: [Koha-bugs] [Bug 20065] New: perennial identifier implementation Message-ID: <bug-20065-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20065 Bug ID: 20065 Summary: perennial identifier implementation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: fcouffignal at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 70804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70804&action=edit example Add a system preference ? or a plugin ? ... to have perennial identifier in Koha -> object : choice between ARK, DOI, Handle, PURL (Marc bibliographic data) -> contributor : arkXiv, idHAL, IDRef, ISNI (Marc Authority data) see more : http://www.inist.fr/?Identifiants-perennes http://www.mediathequederoubaix.fr/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 19:02:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 18:02:19 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17978-70-5m4CtGbd46@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 19:02:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 18:02:30 +0000 Subject: [Koha-bugs] [Bug 20014] When adding to basket from a staged file item budgets are selected my matching on code, not id In-Reply-To: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20014-70-I2vtD9Rj8P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 19:49:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 18:49:27 +0000 Subject: [Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image Failed - "Cannot process file as an image" In-Reply-To: <bug-19898-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19898-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19898-70-adYarOZUE6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898 acovaliov at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acovaliov at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:17:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:17:05 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18725-70-ovq1O1v5XF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:17:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:17:08 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18725-70-ykAwclM6EM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68603|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70805&action=edit Bug 18725 - Process_message_queue sends duplicate emails if message_queue is not writable. Last week, we had a database server whose disk filled, causing database writes to fail. This meant that messages in message_queue marked 'pending' were not marked as 'sent' when they were added to the postfix mail queue; messages were sent every 15 minutes (as specified in the cron job) until the disk space issues were cleared. I would suggest adding a token write to the start of process_message_queue.pl as a 'canary in the coal mine'. If the database write fails, process_message_queue should stop, because it's not safe to proceed sending emails that may not be marked 'sent'. Test Plan: 1) Apply this patch 2) Make the message_queue table unwriteable somehow 3) Run process_message_queue.pl 4) Script should die with error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:24:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:24:03 +0000 Subject: [Koha-bugs] [Bug 19920] changepassword is exported from C4::Members but has been removed In-Reply-To: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19920-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19920-70-ZY4CqTVMqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:32:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:32:08 +0000 Subject: [Koha-bugs] [Bug 20066] New: Remove forbidden patterns from .inc and .tt files Message-ID: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 Bug ID: 20066 Summary: Remove forbidden patterns from .inc and .tt files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: indradg at l2c2.co.in QA Contact: testopia at bugs.koha-community.org The following files contain forbidden patterns a) includes/datatables.inc => [% interface %] instead of [% themelang %] b) modules/opac-auth-MARCdetail.tt => hard-coded path c) modules/opac-auth-detail.tt => hard-coded path This patch removes these. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:32:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:32:55 +0000 Subject: [Koha-bugs] [Bug 19963] ethnicity and ethnicity tables and columns survived update In-Reply-To: <bug-19963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19963-70-Wo9glH7KKg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19963 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I guess this change could fix it, but do not have more time to spend on that. There is the warning that is displayed anyway. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:33:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:33:13 +0000 Subject: [Koha-bugs] [Bug 20066] Remove forbidden patterns from .inc and .tt files In-Reply-To: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20066-70-KNscSe7GjK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |indradg at l2c2.co.in See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20053 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:33:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:33:13 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-kwC8lqxIZv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20066 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:33:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:33:40 +0000 Subject: [Koha-bugs] [Bug 19963] ethnicity and ethnicity tables and columns survived update In-Reply-To: <bug-19963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19963-70-a412LlFfFC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19963 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70806&action=edit Bug 19963: Update 3.21.00.033 to drop ethnicity data if '' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:45:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:45:49 +0000 Subject: [Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count In-Reply-To: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20047-70-djSHMZlswG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- The QA tool has a couple of complaints about this patch: FAIL Koha/Z3950Server.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid FAIL Koha/Z3950Servers.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:48:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:48:46 +0000 Subject: [Koha-bugs] [Bug 20067] New: Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl) Message-ID: <bug-20067-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Bug ID: 20067 Summary: Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 70807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70807&action=edit notice view Hi, Is it normal contents of authorised values of the ORDER_CANCELLATION category are displayed in items table for the materials specified fields? Test plan: 1. Fill with 2 in a subfield 952 $3 and save item 2. Display item table in normal view 3. See column Materials specified which display authorised values instead of number 2 See attached images Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:50:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:50:14 +0000 Subject: [Koha-bugs] [Bug 20067] Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl) In-Reply-To: <bug-20067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20067-70-6bqNyeUu0R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- Created attachment 70808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70808&action=edit item table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:50:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:50:59 +0000 Subject: [Koha-bugs] [Bug 20066] Remove forbidden patterns from .inc and .tt files In-Reply-To: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20066-70-KbPmvGyzv0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 --- Comment #1 from Indranil Das Gupta <indradg at l2c2.co.in> --- Created attachment 70810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70810&action=edit Bug 20066 - Remove forbidden patterns from .inc and .tt files This patch removes the forbidden patterns from the following files: a) datatables.inc => [% interface %] instead of [% themelang %] b) opac-auth-MARCdetail.tt => hard-coded path to JS resource. c) opac-auth-detail.tt => hard-coded path to JS resource. Test plan ========= 1/ Apply the patch from Bug 20053 and run koha-qa.pl. The QA tool will throw up these 3 files as FAIL for forbidden patterns use. 2/ Now apply this patch and run koha-qa.pl. The result should now be OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:50:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:50:43 +0000 Subject: [Koha-bugs] [Bug 20067] Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl) In-Reply-To: <bug-20067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20067-70-HYjwi1W58u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- Created attachment 70809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70809&action=edit authorized values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:55:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:55:39 +0000 Subject: [Koha-bugs] [Bug 20066] Remove forbidden patterns from .inc and .tt files In-Reply-To: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20066-70-pwDeQGJ5rD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:55:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:55:55 +0000 Subject: [Koha-bugs] [Bug 20066] Remove forbidden patterns from .inc and .tt files In-Reply-To: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20066-70-GhaHGtGD5r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20053 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 20:55:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 19:55:55 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-7EQNBHNN8m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 [Bug 20066] Remove forbidden patterns from .inc and .tt files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:00:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:00:03 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-VssGE3LXeu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #3 from Indranil Das Gupta <indradg at l2c2.co.in> --- @Owen: I've added the fix for the forbidden patterns detected by qa tools in a separate patch as you had suggested i.e. Bug 20066. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:03:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:03:21 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-ao6TEgIlxR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|lib.ibwya.net | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:03:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:03:14 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-tIHd8YCxpg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org Version|17.11 |master Severity|normal |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:13:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:13:24 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-LrhvCqFHDB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:13:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:13:28 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-WjMSxYPK4D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70811&action=edit Bug 19975: Fix search by tags at the OPAC This bug has certainly be caused by commit 091d6c513bcbee224ff06477e79be48cea7fe825 Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes The reason is quite simple, in Koha::ItemType->translated_description (called in opac-search.pl l.229) there is an eval to know if we have access to the translated description of the item type, to avoid retrieving it again. The evaluation of $@ later in opac-search.pl is supposed to test the 2 eval made few lines before (a "normal" search, without tags), but $@ contains the error message from the *last* eval command. So we are raising an error that have been correctly handled in Koha::ItemType. Test plan: At the OPAC, click Tag cloud, then click any of the tags => Without the patch you get Koha::ItemType::get_column generated this error: DBIx::Class::Row::get_column(): No such column 'translated_description' on Koha::Schema::Result::Itemtype at /usr/share/koha/lib/Koha/Object.pm line 307 => With the patch applied the page is correctly displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:21:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:21:46 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19985-70-ARgEIs3GMX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:21:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:21:51 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19985-70-hyeQKEeeqe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70812&action=edit Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty This table cannot contain more than 1 row, so we need to remove its data before trying to generate a new entry. Test plan: Set a default circ rule prove t/db_dependent/TestBuilder.t should return green Without this patch you get: # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:22:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:22:10 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19985-70-jQnMsqQguc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:28:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:28:03 +0000 Subject: [Koha-bugs] [Bug 19976] data restoration in newly installed koha 17.11.X In-Reply-To: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19976-70-7YIrqF1k7Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19976 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The table search_field has been created in 3.23.00.050, it's weird you do not have it in your dump from 16.05 >From which version exactly are you trying to upgrade? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:34:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:34:35 +0000 Subject: [Koha-bugs] [Bug 20055] New suggestion from OPAC records borrowernumber instead of branchcode In-Reply-To: <bug-20055-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20055-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20055-70-PB4PF5YGFc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20055 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Works for me on master and 17.05.06 Nothing in the logs? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 21:37:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 20:37:16 +0000 Subject: [Koha-bugs] [Bug 20064] Cannot place a hold for any student In-Reply-To: <bug-20064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20064-70-4uIdo0wbdw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20064 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Looks like a configuration issue, what do you have in your circulation rules? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 22:58:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 21:58:28 +0000 Subject: [Koha-bugs] [Bug 18775] The "Password Reset" notice should use the patron's homebranch's email as "from" address In-Reply-To: <bug-18775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18775-70-dBzDNrTHPz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775 VikDC <delcastillovictorandres at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |delcastillovictorandres at gma | |il.com Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #9 from VikDC <delcastillovictorandres at gmail.com> --- hi, i've made all set that you guys mentioned there but i can't make it work, if i use this command: "echo "TEST MAIL" | mail -s "Email test subject" myemail at domain.com" I got email in my account gmail, but when i try to use "forgotten password" koha (opac) says that i'll recieve an email, but i got nothing, i hope you can help me, i have more than a week trying to make it work, thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 22 23:40:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 22:40:44 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16188-70-BALudmd9Rs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70788|0 |1 is obsolete| | --- Comment #4 from Indranil Das Gupta <indradg at l2c2.co.in> --- Created attachment 70813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70813&action=edit Bug - SMS via email not applicable in India due to telecom regulation This patch is applicable only for Indian users of Koha Scenario : Under Indian law, transactional bulk SMS sending requires pre-registration and approval of message templates with the Telecom Regulatory Authority of India (TRAI). Most Indian telcos do not offer this facility and even if offered, use of the feature introduced by Bug #9021 may expose the user to serious civil and criminal liability due to unsanctioned use. More details over here - https://lists.katipo.co.nz/pipermail/koha/2016-April/045124.html. This patch informs users setting up their SMSSendDriver to "Email" that this feature won't work in India. And even if they do this, it reiterates this again at Home ? Administration ? SMS cellular providers. Test plan ========= 1/ Apply the patch 2/ Check if warning is displayed when setting up the SMSSendDriver syspref as as well when accessing 'SMS cellular providers' under 'Administration -> Additional parameters' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 00:52:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 23:52:04 +0000 Subject: [Koha-bugs] [Bug 20068] New: Warn on OPAC homepage if not logged in due to OPAC dashboard Message-ID: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Bug ID: 20068 Summary: Warn on OPAC homepage if not logged in due to OPAC dashboard Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org If accessing the OPAC homepage while not logged in, the following warn shows: Use of uninitialized value $overdues_count in numeric gt (>) at /home/vagrant/kohaclone/opac/opac-main.pl line 76. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 00:54:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 23:54:11 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-ooLvx1qsN4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 00:54:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jan 2018 23:54:14 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-7sA76c14Vj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 --- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70814&action=edit Bug 20068: Check if user logged in before passing dashboard params to template This prevents warns from dashboard variables when not logged in To test: 1) Go to OPAC main homepage. Do not log in 2) Notice warn 3) Apply patch and refresh 4) Warn should be gone 5) Log in 6) Confirm dashboard shows as normal Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 01:00:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 00:00:56 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-O6uJPzR73v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 01:01:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 00:01:10 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-JRvy2cVqn4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 [Bug 2093] Add OPAC dashboard for logged-in users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 01:01:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 00:01:10 +0000 Subject: [Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users In-Reply-To: <bug-2093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2093-70-bmf3GHToCA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 01:51:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 00:51:15 +0000 Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl In-Reply-To: <bug-18071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18071-70-canuCYNsFG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Enhancement, not backported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 01:51:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 00:51:16 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: <bug-17908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17908-70-UGcGge417W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Bug 17908 depends on bug 18071, which changed state. Bug 18071 Summary: Add new script update_authorities.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 01:55:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 00:55:11 +0000 Subject: [Koha-bugs] [Bug 18948] Reindexing should use aliases to avoid down time In-Reply-To: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18948-70-hNkVNP2XKh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 01:55:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 00:55:16 +0000 Subject: [Koha-bugs] [Bug 18948] Reindexing should use aliases to avoid down time In-Reply-To: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18948-70-S5RTCVUusj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70816&action=edit Bug 18948 - Elasticsearch - Reindexes should use aliases to avoid down time while reindexing To test: 1 - Delete your current indices for ES (if any) 2 - Reindex your records 3 - curl 'localhost:9200/_cat/indices?v' 4 - Note indices are now of form koha_kohadev_########## 5 - The numbers there are a result of appending 'time' command to name 6 - Ensure searching works as before the patches 7 - Reindex your records with a commit setting of 1 (to slow things down) you may need a large numebr fo records 8 - Ensure searching works during reindex 9 - Ensure reindexing completes successfully 10 - curl 'localhost:9200/_cat/indices?v' 11 - There should only be one index each for biblios and authorities ** - Note number in above 12 - Perform a partial reindex by passing a biblionumber to the command 13 - Curl the indices again and ensure number/name has not changed 14 - Delete all indexes curl -XDELETE 'localhost:9200/koha_kohadev_*?pretty' 15 - Edit a known biblio: http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=1 16 - Add a word to the title "potato" 17 - Save the record 18 - Search for potato 19 - You should arrive at the detail page for that record 20 - Confirm your index is of form koha_kohadev_########## -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 01:55:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 00:55:13 +0000 Subject: [Koha-bugs] [Bug 18948] Reindexing should use aliases to avoid down time In-Reply-To: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18948-70-TNBNkt6EQj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65147|0 |1 is obsolete| | Attachment #65159|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70815&action=edit Bug 18948 - Elasticsearch - Reindexes should use aliases to avoid down time while reindexing Refactoring of rebuild_elastic_search.pl to move code into Koha::SearchEngine::Elasticsearch::Indexer Current status: Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 01:56:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 00:56:32 +0000 Subject: [Koha-bugs] [Bug 18948] Reindexing should use aliases to avoid down time In-Reply-To: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18948-70-incQQbXThp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Ugly rebase, still needs unit tests and testing to confirm it works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 03:37:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 02:37:31 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19985-70-wZWoBmvNZl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70812|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70817&action=edit Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty This table cannot contain more than 1 row, so we need to remove its data before trying to generate a new entry. Test plan: Set a default circ rule prove t/db_dependent/TestBuilder.t should return green Without this patch you get: # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 03:37:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 02:37:29 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19985-70-Dex5zy8Uaf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:06:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:06:59 +0000 Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19580-70-8YE9d09kbb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:08:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:08:02 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19911-70-kZonNtNhrO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:07:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:07:45 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19921-70-eTa1gqkKFs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:08:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:08:15 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-m6bTojW63t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:08:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:08:34 +0000 Subject: [Koha-bugs] [Bug 19483] t/db_dependent/www/* crashes test harness due to misconfigured test plan In-Reply-To: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19483-70-jKWeGS46Q6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19483 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:08:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:08:47 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19937-70-IzqoiNqx59@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:09:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:09:17 +0000 Subject: [Koha-bugs] [Bug 19973] SQL syntax error in uk-UA/mandatory/sample_notices.sql In-Reply-To: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19973-70-RwcTbUdWax@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:09:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:09:37 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-0RjQaqjHNW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:10:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:10:38 +0000 Subject: [Koha-bugs] [Bug 17467] Introduce a single koha-zebra script to handle Zebra daemons for instances In-Reply-To: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17467-70-RWi4k6ydB0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #31 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed missed patch to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:10:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:10:54 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-TNUQD98r1C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #23 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:11:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:11:08 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-ZlpKekxfeG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:11:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:11:20 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor's temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-ku8x7NlwVA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:11:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:11:42 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-mvhOejDFog@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:11:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:11:57 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-8Vs5igp0AS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:12:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:12:21 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-mVmD33T6d2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:13:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:13:00 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18696-70-cHHJs0txOn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:13:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:13:16 +0000 Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display in opac or staff side In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19677-70-lufGFNhgJv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:13:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:13:43 +0000 Subject: [Koha-bugs] [Bug 16603] Hide option to apply directly when processing uploaded offline circulation file In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-8yhjIE5vg3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:14:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:14:16 +0000 Subject: [Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn In-Reply-To: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17682-70-Y8I1lfMSBf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:14:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:14:46 +0000 Subject: [Koha-bugs] [Bug 19839] invoice.pl warns about bad variable scope In-Reply-To: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19839-70-4LWqMpp9fb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:15:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:15:12 +0000 Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not links to biblio In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19825-70-gXR2RdpIPU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:15:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:15:34 +0000 Subject: [Koha-bugs] [Bug 19221] Onboarding tool says user needs to be made superlibrarian In-Reply-To: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19221-70-nbjYuSx553@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19221 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:15:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:15:50 +0000 Subject: [Koha-bugs] [Bug 19971] typo in the comments of parseQuery routine In-Reply-To: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19971-70-Wf7drvPjh7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19971 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:16:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:16:09 +0000 Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15770-70-DufOb2t8R4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:17:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:17:13 +0000 Subject: [Koha-bugs] [Bug 18878] Improve item form display / labels too far from input fields In-Reply-To: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18878-70-8n3I89nJyU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Enhancement, not backported for 17.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:17:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:17:27 +0000 Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a barcode file In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19585-70-xRgf8xY0Ob@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |FIXED --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Enhancement, not backported for 17.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:17:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:17:42 +0000 Subject: [Koha-bugs] [Bug 18083] Don't show 'library' selection on popular titles page for single-branch libraries In-Reply-To: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18083-70-z4j6zCpMi2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18083 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Enhancement, not backported for 17.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:18:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:18:09 +0000 Subject: [Koha-bugs] [Bug 19988] Change 'sex' to 'gender' In-Reply-To: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19988-70-XhtUGvpvxK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19988 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Enhancement, not backported for 17.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:18:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:18:28 +0000 Subject: [Koha-bugs] [Bug 19831] Turn on EnhancedMessagingPreferences by default for new installations In-Reply-To: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19831-70-j0wDjSNI03@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Enhancement, not backported for 17.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 05:18:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 04:18:57 +0000 Subject: [Koha-bugs] [Bug 20063] $9 is lost when cataloguing authority records In-Reply-To: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20063-70-6JJ58tMi9j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20063 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 06:27:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 05:27:04 +0000 Subject: [Koha-bugs] [Bug 20069] New: Database better performance Message-ID: <bug-20069-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20069 Bug ID: 20069 Summary: Database better performance Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: kumardglin at gmail.com QA Contact: testopia at bugs.koha-community.org Dear All, Please suggest the following. We have One million records in our Koha ILMS, but OPAC performance is very slow to show search results. 1. Can you suggest to perform the improving speed of the search results? 2. Anybody having more than One million records in Koha in India? Kind Regards, Kumar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 06:47:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 05:47:44 +0000 Subject: [Koha-bugs] [Bug 19976] data restoration in newly installed koha 17.11.X In-Reply-To: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19976-70-scsHJZXH6T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19976 --- Comment #2 from Mohammad Rasheed <rasheed at psmchs.edu.sa> --- (In reply to Jonathan Druart from comment #1) > The table search_field has been created in 3.23.00.050, it's weird you do > not have it in your dump from 16.05 > From which version exactly are you trying to upgrade? Hi Jonathan Goodday, Thank you very much for your reply. Actually I am trying to upgrade from 16.05 to 17.11.. Regards -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 06:51:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 05:51:01 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16188-70-eGuzFjcUH9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70813 Bug - SMS via email not applicable in India due to telecom regulation Review of attachment 70813: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16188&attachment=70813) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/sms_providers.tt @@ +55,5 @@ > [% ELSE %] > > <div class="dialog message"> > + There are no SMS cellular providers defined.<br/><br/> > + <em>This feature <a href="https://lists.katipo.co.nz/pipermail/koha/2016-April/045114.html">does not work</a> if you are in India.</em> This only displays when the cellular providers list is empty. This should likely be displayed by itself all the time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 08:52:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 07:52:43 +0000 Subject: [Koha-bugs] [Bug 20063] $9 is lost when cataloguing authority records In-Reply-To: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20063-70-wHmzJJXfJZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20063 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 09:30:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 08:30:40 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-Cxk33WlqG0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #190 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to Hugo Agud from comment #189) > I have applied the patch propertly, but I am not able to make the local mana > server work.. I follow all instructions. > > I have installed in a kohadev server, I had to install manual via cpan some > of the perl packages, everything seems to goes fine.. but on localhost:5000 > nothing appears.. is that the normal behaviour? > > PID/Program name > tcp 0 0 0.0.0.0:5000 0.0.0.0:* LISTEN > 2814/plackup > tcp 0 0 127.0.0.1:3306 0.0.0.0:* LISTEN > - > tcp 0 0 127.0.0.1:11211 0.0.0.0:* LISTEN > - > tcp 0 0 0.0.0.0:111 0.0.0.0:* LISTEN > - > tcp 0 0 0.0.0.0:45397 0.0.0.0:* LISTEN > - > tcp 0 0 0.0.0.0:22 0.0.0.0:* LISTEN > - > tcp 0 0 127.0.0.1:25 0.0.0.0:* LISTEN > - > tcp6 0 0 :::41475 :::* LISTEN > - > tcp6 0 0 :::111 :::* LISTEN > - > tcp6 0 0 :::8080 :::* LISTEN > - > tcp6 0 0 :::80 :::* LISTEN > - > tcp6 0 0 :::22 :::* LISTEN > - > tcp6 0 0 ::1:25 :::* LISTEN > - Hello Hugo, You can use the test server: https://mana-test.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 09:40:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 08:40:52 +0000 Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client In-Reply-To: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20062-70-6T4fmzqJBn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 09:40:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 08:40:55 +0000 Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client In-Reply-To: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20062-70-sx9zcOvXbY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70799|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70818&action=edit Bug 20062: Remove support for Internet Explorer 7 in the staff client This patch removes JavaScript files which were added to support Internet Explorer 7. Templates which included the files have been modified accordingly. To test, apply the patch and clear your browser cache if necessary. Perform a catalog search in the staff client and click through to view one of the search results. The search results navigation menu in the left-hand sidebar should work correctly. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 09:45:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 08:45:36 +0000 Subject: [Koha-bugs] [Bug 20061] koha-common is not pulling libsearch-elasticsearch-perl In-Reply-To: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20061-70-kwDEBAdDwn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> --- I am not sure if this should be a hard dependency - as long as Koha is supposed to work without Elasticsearch - for an enhancement that just displays Elasticsearch infos when Elasticsearch is activated (as far as I understand) Could we tie loading the module to a condition like the SearchEngine syspref setting instead or does that not make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 10:20:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 09:20:55 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14407-70-1GHSdM7NRU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #43 from Nicholas van Oudtshoorn <vanoudt at gmail.com> --- Thanks for fixing that - my bad :-( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 10:35:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 09:35:32 +0000 Subject: [Koha-bugs] [Bug 20032] Switch single-column templates to Bootstrap grid: Tools In-Reply-To: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20032-70-AOeR263vJb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 10:35:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 09:35:35 +0000 Subject: [Koha-bugs] [Bug 20032] Switch single-column templates to Bootstrap grid: Tools In-Reply-To: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20032-70-2GxNnWqLwr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70694|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70819&action=edit Bug 20032: Switch single-column templates to Bootstrap grid: Tools This patch updates several single-column Tools templates to use the Bootstrap grid. - batchMod-del.tt - Tools -> Batch item deletion -> Submit barcodes or item numbers for deletion. The grid is changed for the results and confirmation screens. - batchMod-edit.tt - Tools -> Batch item modification -> Submit barcodes or item numbers for modification. The grid is changed for the results and confirmation screens. - koha-news.tt - Tools -> News -> Edit or create a new news item. The grid is changed for the edit screen. - letter.tt - Tools -> Notices and Slips -> Edit or create a notice. The grid is changed for the edit screen. Each of these pages should look correct. The News and Notices page should have a single centered column with wide margins on either side. At lower browser widths the margins should disappear. The batch mod screens should be displayed at full screen width. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 10:36:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 09:36:04 +0000 Subject: [Koha-bugs] [Bug 20070] New: autoBarcode Increment Value Message-ID: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20070 Bug ID: 20070 Summary: autoBarcode Increment Value Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: mustaqeemabd at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi Bugzilla, Today I just found an error when enabling autoBarcode (generate in the form <branchcode>yymm0001.) in System Preferences. the problem is the barcode number is not auto increase for the next item added. I realize the problem because our branchcode is numeric (e.g 0001, 0002, 0003, LIB1). The barcode number is increase if code used is alphabet only (e.g LIB, LIBI, LIBII, LIBIII). Please help regarding this matter. Our Koha version 17.05. Step to regenerate the problem: 1) Enable autoBarcode (generate in the form <branchcode>yymm0001.) in Cataloging Preferences. 2) Add New Item (Appear great for the first item) 3) Add another New Item (this is where barcode number not auto increase). Thank you!! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 10:37:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 09:37:45 +0000 Subject: [Koha-bugs] [Bug 20070] autoBarcode Increment Value In-Reply-To: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20070-70-lzrDCPjRwk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20070 mustaqeem <mustaqeemabd at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 11:38:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 10:38:26 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-noxhg5SxjB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #191 from Hugo Agud <hagud at orex.es> --- Dear Alex thank you very much! we have added this line to Shared our $MANA_IP = "https://mana-test.koha-community.org"; and we have been able to work. REPORTS: We have been able to download reports from MANA BUT they are not able to execute because it dissapears spaces between orders.. we have got to review and separate some statements in order to make it works. We have NOT been able to upload a report or a serial patter , the systema it claims Can't call method "first_valid_email_address" on an undefined value at /home/vagrant/kohaclone/Koha/SharedContent.pm line 108. We have checked that the user has primary and secondary email and the library has also a library defined... (perhas it needs to be registered in MANA? we have not been able to register in MANA using syspref. Orex Digital (XXXXX) Primary email:info at orex.es Secondary email: info at orex.es SERIAL We have added a serial with a issn that MANA manage and it never finds it No subscription found on Mana Knowledge Base :( Please feel free to share you pattern with all others librarians once you are done Reviewing logs... dozens of Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc line 53. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc line 53. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 11:52:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 10:52:49 +0000 Subject: [Koha-bugs] [Bug 20071] New: Hide error displayed when db user tries to catalog anything Message-ID: <bug-20071-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20071 Bug ID: 20071 Summary: Hide error displayed when db user tries to catalog anything Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: indradg at l2c2.co.in QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When someone is logged in as the db user, attempts to catalog any document, it throws an exception: Software error: Can't call method "get_effective_marcorgcode" on an undefined value at /home/l2c2technologies/kohaclone/cataloguing/value_builder/marc21_orgcode.pl line 31. While this is understandable, the error needs to be handled gracefully rather than expose the user to this error screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 11:53:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 10:53:08 +0000 Subject: [Koha-bugs] [Bug 20071] Hide error displayed when db user tries to catalog anything In-Reply-To: <bug-20071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20071-70-CguTE9ToMk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20071 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |indradg at l2c2.co.in |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 12:22:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 11:22:30 +0000 Subject: [Koha-bugs] [Bug 20072] New: Fix build-git-snapshot for Debian source format quilt Message-ID: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Bug ID: 20072 Summary: Fix build-git-snapshot for Debian source format quilt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net With bug 18696 we need a few tiny changes to build-git-snapshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 12:22:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 11:22:50 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20072-70-ii8RluXneT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | Depends on| |18696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 [Bug 18696] Change debian/source/format to quilt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 12:22:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 11:22:50 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18696-70-kdlQEghSLh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20072 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 [Bug 20072] Fix build-git-snapshot for Debian source format quilt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 12:59:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 11:59:01 +0000 Subject: [Koha-bugs] [Bug 20057] Auto-approve option for borrower modifications In-Reply-To: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20057-70-V2iiKS3MXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #2 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> --- Testplan for this patch: 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:27:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:27:14 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-oO58MxcF5G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:31:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:31:14 +0000 Subject: [Koha-bugs] [Bug 19938] C4::Overdues::checkoverdues has inconsistent return type In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-4ltdHHcqxf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70489|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 70489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70489 Bug 19938: Do not fetch dashboard's info if no logged in Finally, see bug 20068... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:31:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:31:38 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17084-70-oOLa3ldA8u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #20 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 70820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70820&action=edit Bug 17084: Automatic debian/control updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:32:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:32:08 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17084-70-3DYb1MolkI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:32:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:32:18 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17084-70-Urk0qJ7uVJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:32:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:32:56 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17084-70-zqpzxEnkRV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70820|0 |1 is obsolete| | --- Comment #21 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 70821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70821&action=edit Bug 17084: Automatic debian/control updates Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:33:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:33:14 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17084-70-wq34EY0xBG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:33:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:33:26 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17084-70-3ECYPqLQl9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:34:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:34:41 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-qT2HBwltQ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70814|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70822&action=edit Bug 20068: Check if user logged in before passing dashboard params to template This prevents warns from dashboard variables when not logged in To test: 1) Go to OPAC main homepage. Do not log in 2) Notice warn 3) Apply patch and refresh 4) Warn should be gone 5) Log in 6) Confirm dashboard shows as normal Sponsored-by: Catalyst IT Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:35:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:35:55 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-UCmsHHRVsO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |Signed Off --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I have already written this change on bug 12001 and bug 19938 so I guess it is good to have it on its own bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:36:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:36:06 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-gQg32uNzli@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:37:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:37:41 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20072-70-5gyCu2bcrM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 --- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 70823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70823&action=edit Bug 20072 - Fix build-git-snapshot for Debian source format quilt With bug 18696 we need a few tiny changes to build-git-snapshot: - Debian revision number for debian/changelog - "orig" in the file name for the tar.gz archive Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:37:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:37:55 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20072-70-IIxPI1pLul@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:38:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:38:14 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20072-70-0f6YRxubuS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:55:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:55:06 +0000 Subject: [Koha-bugs] [Bug 20013] use Modern::Perl in Reserves perl scripts In-Reply-To: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20013-70-RoOXrqGORD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:55:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:55:09 +0000 Subject: [Koha-bugs] [Bug 20013] use Modern::Perl in Reserves perl scripts In-Reply-To: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20013-70-7gbimdLasB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70655|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70824&action=edit Bug-20013: use Modern::Perl in Reserve perl script Test plan: Check the following files that use strict; use warnings; doesn't exist and use Modern::Perl; is written instead. modrequest.pl modrequest_suspendall.pl placerequest.pl Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:56:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:56:00 +0000 Subject: [Koha-bugs] [Bug 19976] data restoration in newly installed koha 17.11.X In-Reply-To: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19976-70-gvrZ6iMXoz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19976 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I can imagine a bug if you are coming from 3.22, but if you are coming from 16.05 you should have this table in your database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:56:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:56:15 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-2Pmvf8SF8U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|CLOSED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:56:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:56:37 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-KOUAPSnkhf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 --- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> --- 17.11 is stable now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:57:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:57:03 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-7XPzt5UHoF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|katrin.fischer at bsz-bw.de, | |mtj at kohaaloha.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:58:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:58:24 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-ycjt3QL9DE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:58:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:58:43 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-ksnlIvmUAa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63602|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 13:59:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 12:59:20 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-RE6POGbQ1w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 --- Comment #5 from Mirko Tietgen <mirko at abunchofthings.net> --- This bug will get updated regularly, it is not supposed to be closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:01:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:01:06 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-Hm6XZ2lEnY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 --- Comment #6 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 70825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70825&action=edit Bug 17108 - Automatic debian/control updates (stable) Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:01:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:01:20 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-4d4Swo2orc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:01:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:01:26 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-Y77X67cvwo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:01:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:01:33 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-kqhiLFwpM7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:07:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:07:12 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18725-70-hwmwiTmFnJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:07:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:07:15 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18725-70-iQdV5AL865@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70805|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70826&action=edit Bug 18725 - Process_message_queue sends duplicate emails if message_queue is not writable. Last week, we had a database server whose disk filled, causing database writes to fail. This meant that messages in message_queue marked 'pending' were not marked as 'sent' when they were added to the postfix mail queue; messages were sent every 15 minutes (as specified in the cron job) until the disk space issues were cleared. I would suggest adding a token write to the start of process_message_queue.pl as a 'canary in the coal mine'. If the database write fails, process_message_queue should stop, because it's not safe to proceed sending emails that may not be marked 'sent'. Test Plan: 1) Apply this patch 2) Make the message_queue table unwriteable somehow 3) Run process_message_queue.pl 4) Script should die with error Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:08:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:08:59 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18725-70-HwZDbhK1gy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to M. Tompsett from comment #10) > While the rebase was easy enough to do, I still couldn't figure out how to > get step 2 to happen. > > When I locked the table, the canary code paused the script execution until I > unlocked it. > > I did try filling the message_queue table. Somewhere around 1.5 million > messages, and it complained the table was full in sql. However, that doesn't > prevent an update. And the number of records was a function of how much > space was left. > > I attempted to 'dd' the drive full, and yet I was still able to run the > script. Hmm. Perhaps make the binary db file readonly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:12:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:12:38 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-W6WJATiMOZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:17:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:17:01 +0000 Subject: [Koha-bugs] [Bug 20073] New: Move Elasticsearch settings to configuration files Message-ID: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Bug ID: 20073 Summary: Move Elasticsearch settings to configuration files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: ere.maijala at helsinki.fi There are a lot of settings in the code making customization difficult. These need to be moved to configuration files that can be overridden as necessary. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:17:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:17:36 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20073-70-qZame5hkwO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:20:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:20:17 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-oPz7KBa3hB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #6 is|1 |0 private| | Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:20:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:20:24 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-nPXbMm5VnI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:20:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:20:31 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-LybwLHHok7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:22:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:22:59 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20073-70-iViOSuXzWT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 70827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70827&action=edit Bug 20073: Move Elasticsearch configs to yaml files and improve the default settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:23:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:23:19 +0000 Subject: [Koha-bugs] [Bug 20074] New: Auth_subfield_structure changes hidden attribute Message-ID: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 Bug ID: 20074 Summary: Auth_subfield_structure changes hidden attribute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org >From bug 18811 comment40: It sounds like there is something else to fix: On a new DB: MariaDB [koha_kohadev]> select tagfield, tagsubfield, hidden from auth_subfield_structure where tagfield=551 and tagsubfield=9 and authtypecode="GEOGR_NAME"\G *************************** 1. row *************************** tagfield: 551 tagsubfield: 9 hidden: 1 Edit the subfields for GEOGR_NAME /admin/auth_subfields_structure.pl?op=add_form&tagfield=551&authtypecode=GEOGR_NAME Possible value for "Select to display or not"/hidden are -5 and 0, so "Show all" is displayed. Save without modifying anything: hidden is now '0'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:23:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:23:32 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-bDAFwcK9vS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:24:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:24:34 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-gIWBNkCqN0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #40) > It fixes the problem, but it sounds like there is something else to fix: > > On a new DB: > MariaDB [koha_kohadev]> select tagfield, tagsubfield, hidden from > auth_subfield_structure where tagfield=551 and tagsubfield=9 and > authtypecode="GEOGR_NAME"\G > *************************** 1. row *************************** > tagfield: 551 > tagsubfield: 9 > hidden: 1 > > Edit the subfields for GEOGR_NAME > /admin/auth_subfields_structure. > pl?op=add_form&tagfield=551&authtypecode=GEOGR_NAME > > Possible value for "Select to display or not"/hidden are -5 and 0, so "Show > all" is displayed. > Save without modifying anything: hidden is now '0' Moved this to a new report: bug 20074 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:25:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:25:10 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-bGBkLb35ll@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 [Bug 18811] Visibility settings inconsistent between framework and authority editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:25:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:25:10 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18811-70-D8kwxKvXNA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20074 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 [Bug 20074] Auth_subfield_structure changes hidden attribute -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:26:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:26:49 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-gSwkke0rnE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:26:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:26:58 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19993-70-c4TrtGv0OJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:27:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:27:00 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19993-70-Pxf7y3YKG4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70657|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70828&action=edit Bug 19993: use Modern::Perl in Acquisition perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; acqui-home.pl addorder.pl basketgroup.pl basketheader.pl booksellers.pl check_budget_total.pl check_duplicate_barcode_ajax.pl edi_ean.pl edifactmsgs.pl edimsg.pl finishreceive.pl histsearch.pl invoice.pl invoices.pl neworderbiblio.pl neworderempty.pl newordersuggestion.pl ordered.pl orderreceive.pl parcel.pl parcels.pl pdfformat/layout2pages.pm pdfformat/layout2pagesde.pm pdfformat/layout3pages.pm pdfformat/layout3pagesfr.pm spent.pl supplier.pl uncertainprice.pl updatesupplier.pl z3950_search.pl Signed-off-by: Owen Leonard <oleonard at myacpl.org> Corrected a single semicolon in edimsg.pl during signoff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:29:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:29:40 +0000 Subject: [Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count In-Reply-To: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20047-70-mRr2RV2skF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:29:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:29:43 +0000 Subject: [Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count In-Reply-To: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20047-70-TKRgeJakY0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70756|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70829&action=edit Bug 20047 - Add Koha::Z3950Server Oject and use it to get server count To test: 1 - prove t/db_dependent/Koha/Z3950Servers.t 2 - Load cataloging and authority home pages 3 - Verify you can add form z395 on each page 4 - Delete all z3950 servers 5 - Viery option to add from Z3950 is removed on both pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:29:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:29:50 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20073-70-NH9YVnsZJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #2 from Ere Maijala <ere.maijala at helsinki.fi> --- The patch contains the following changes: - Index settings moved from code to etc/searchengine/elasticsearch/index_config.yaml. An alternative can be specified in koha-conf.xml. - Field settings moved from code to etc/searchengine/elasticsearch/field_config.yaml. An alternative can be specified in koha-conf.xml. - Default settings have been improved to remove punctuation from phrases used for sorting etc. - State variables are used for storing configuration to avoid parsing it multiple times. - A possibility to reset the fields too has been added to the reset operation of mappings administration. - mappings.yaml has been moved from admin/searchengine/elasticsearch to etc/searchengine/elasticsearch. - An stdno field type has been added for standard identifiers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:30:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:30:18 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-zYuCDbauLt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:30:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:30:21 +0000 Subject: [Koha-bugs] [Bug 20047] Add Z3950Server Object and use it for getting server count In-Reply-To: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20047-70-gohAQC40dG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20047 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Owen Leonard from comment #2) > The QA tool has a couple of complaints about this patch: It still does, but ignore them, they are not relevant -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:30:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:30:24 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-8wxZmpgWpR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63692|0 |1 is obsolete| | Attachment #63693|0 |1 is obsolete| | Attachment #63694|0 |1 is obsolete| | Attachment #63695|0 |1 is obsolete| | Attachment #63696|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70830&action=edit Bug 12904: Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:33:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:33:35 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-PPdUY8SV2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #81 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #78) > > >For non-package installations, the following rewrite rules will need to be >added to the apache config file: > >RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L] > >RewriteRule ^(.*)_(.*).css$ $1.css [R=301,N,L] > > Wonder if this might not get lost - would there be a way to automate it? > What happens if you don't? We will have to highlight that in the release notes. People will quickly now that something is wrong if all JS and CSS files return 404 (In reply to Fridolin SOMERS from comment #79) > > RewriteRule ^(.*)_(.*).js$ $1.js [R=301,N,L] > This rewrite rules are quite large, what about files that already contain an > underscore ? > I think we should use a more explicit separator like "_kohav" with rewrite : > RewriteRule ^(.*)_kohav(.*).js. > > > +<script type="text/javascript" src="[% interface %]/[% theme %]/js/datatables_[% KOHA_VERSION %].js"></script> > The syspref "Version" contains a dot (ie 16.1200037) meaning that files will > have 2 dots, ie : > ../datatables_16.1200037.js > This may be a problem for some web-browsers like IE ? I am going to push these patches soon. Developers will have time to catch the issues before 18.05. If someone disagrees with these patches, tell us why. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:37:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:37:39 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20073-70-Cbm0FtKNII@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70827|0 |1 is obsolete| | --- Comment #3 from Ere Maijala <ere.maijala at helsinki.fi> --- Comment on attachment 70827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70827 Bug 20073: Move Elasticsearch configs to yaml files and improve the default settings. Oops, I omitted the required DB and UI changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:44:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:44:34 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-LR1Ttasftg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #82 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70831&action=edit Bug 12904: (QA follow-up) Don't send 301 status Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:44:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:44:48 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-6LffY6QN62@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #83 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70832&action=edit Bug 12904: Add mod_expire to etc/koha-httpd.conf Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:45:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:45:08 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-WxqpwnsIXz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #85 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70834&action=edit Bug 12904: Pass KOHA_VERSION in C4::Auth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:44:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:44:58 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-clJ2MlnWd4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70830|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70833&action=edit Bug 12904: Force browser to load new javascript files after upgrade This patch has been automatically generated using: perl kv.pl **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:46:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:46:00 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-gUvEIEkwTk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48742|0 |1 is obsolete| | --- Comment #86 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70835&action=edit script to update tt & inc files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:46:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:46:07 +0000 Subject: [Koha-bugs] [Bug 20061] koha-common is not pulling libsearch-elasticsearch-perl In-Reply-To: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20061-70-tkDksxXuku@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Mirko Tietgen from comment #1) > I am not sure if this should be a hard dependency > - as long as Koha is supposed to work without Elasticsearch > - for an enhancement that just displays Elasticsearch infos when > Elasticsearch is activated (as far as I understand) > > Could we tie loading the module to a condition like the SearchEngine syspref > setting instead or does that not make sense? I've always been strongly against having 'Break Koha' option switches. I think the SearchEngine syspref is a 'Break Koha' option switch as long as Elasticsearch Perl dependencies are not shipped/pulled. I agree we can workaround the about.pl problem. But we still have break switches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:49:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:49:19 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20073-70-pDajcPOFR4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #4 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 70836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70836&action=edit Bug 20073: Move Elasticsearch configs to yaml files and improve the default settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:49:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:49:22 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20073-70-2mKu6IUZAu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #5 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 70837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70837&action=edit Bug 20073: Add database and mappings UI support for isbn and stdno field types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:50:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:50:02 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-1ykOfQzXkv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70710|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:50:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:50:21 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-2lNGsmLidK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |zoebennett1308 at gmail.com |ity.org | Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:52:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:52:03 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20073-70-lb1zdKU7YP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #6 from Ere Maijala <ere.maijala at helsinki.fi> --- Ok, so I'm fumbling a bit with git-bz here, but the current patches should do it. Note that the isbn field type has been added in anticipation of a future patch that adds a bit of special handling for ISBNs so that they're indexed in all forms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:53:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:53:18 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20073-70-A3LaNFbO7Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:53:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:53:38 +0000 Subject: [Koha-bugs] [Bug 20075] New: Change authority hidden attribute in sql installer files Message-ID: <bug-20075-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Bug ID: 20075 Summary: Change authority hidden attribute in sql installer files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com See bug 18811 and 20074. We should not expect 0, 1 and 8. But only 0 and -5. (Note that it is just used as a boolean, so not a big deal.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 14:56:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 13:56:06 +0000 Subject: [Koha-bugs] [Bug 20069] Database better performance In-Reply-To: <bug-20069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20069-70-UNg77chuLE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20069 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:03:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:03:37 +0000 Subject: [Koha-bugs] [Bug 19993] use Modern::Perl in Acquisition perl scripts In-Reply-To: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19993-70-r10EzCJOIl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |charlotte.cordwell123 at gmail |ity.org |.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:03:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:03:53 +0000 Subject: [Koha-bugs] [Bug 20013] use Modern::Perl in Reserves perl scripts In-Reply-To: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20013-70-pamC5xSQRC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jwayway at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:08:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:08:20 +0000 Subject: [Koha-bugs] [Bug 20034] Switch single-column templates to Bootstrap grid: Circulation In-Reply-To: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20034-70-WcC12PEqmz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20034 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:08:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:08:23 +0000 Subject: [Koha-bugs] [Bug 20034] Switch single-column templates to Bootstrap grid: Circulation In-Reply-To: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20034-70-1qYdY1hite@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20034 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70699|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70838&action=edit Bug 20034: Switch single-column templates to Bootstrap grid: Circulation This patch updates two single-column circulation templates to use the Bootstrap grid. - circulation-home.tt - Circulation home page. This patch corrects what appears to have been a long-broken three-column layout. - article-requests.tt - Article requests list. Turn on the ArticleRequests system preference if necessary. Go to Circulation -> Article requests. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:11:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:11:55 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20073-70-1VUOrwdZ3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:13:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:13:00 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-0HdzFlk3H3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #131 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to ByWaterSandboxes from comment #130) > It does not affect messages in the message_queue. So it's not "all emails" :) I was going to fail QA this patch because I was testing overdue notices. However it seems that is was the first intention of this patch (see first patch, in comment 3). Why did you change your mind? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:17:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:17:51 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-XAbJfxcbeq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #192 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #177) > Can I get an answer to my comments 162-164? Still waiting for that, I am switching to FQA until I get what I asked 4 months ago, to avoid testers to lose their time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:19:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:19:54 +0000 Subject: [Koha-bugs] [Bug 20061] koha-common is not pulling libsearch-elasticsearch-perl In-Reply-To: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20061-70-n2CsLtrIXW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:23:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:23:38 +0000 Subject: [Koha-bugs] [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons In-Reply-To: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19982-70-akc2McuIbH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:23:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:23:41 +0000 Subject: [Koha-bugs] [Bug 19982] Switch single-column templates to Bootstrap grid: Patrons In-Reply-To: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19982-70-Hf15YOY1Kq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19982 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70560|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70839&action=edit Bug 19982 - Switch single-column templates to Bootstrap grid: Patrons This patch updates two single-column patron module templates to use the Bootstrap grid: - discharges.tt - The list of pending discharges. One or more discharges must have been made via the OPAC. From the staff client home page, look for "Discharge requests pending." - members-update.tt - The list of pending patron updates. One or more updates must have been submitted via the OPAC. From the staff client home page, look for "Patrons requesting modifications." Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:24:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:24:07 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-czs1MiTu3a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70648|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70840&action=edit Bug 20000: Changing 'use strict: use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use strict; use warnings;' in the following installer perl scripts: data/mysql/backfill_statistics.pl data/mysql/labels_upgrade.pl data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl data/mysql/updatedatabase.pl externalmodules.pl html-template-to-template-toolkit.pl install.pl Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:24:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:24:10 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-v7Jf5jOeRe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70841&action=edit Bug 20000: use Modern::Perl in installer perl scripts Fixing problems with the change to 'use strict: use warnings;' to 'use Modern::Perl;' in the following installer scripts data/mysql/patroncards_upgrade.pl data/mysql/update22to30.pl Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:24:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:24:05 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-ebWfNKNtef@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:24:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:24:17 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-YVktbS0H57@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:24:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:24:20 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-XjuQNhzko8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70842&action=edit Bug 20074: Fix hidden value in auth_subfields_structure The template included an else branch where a value not equal to 0 or -5 was interpreted as 0 (Show all). This effectively converted hidden values 1 and 8 to 0. This patch removes that else branch. Test plan: Toggle a authority field between Hide all and Show all. Check what happens. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:24:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:24:24 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-CrNeUiIN5r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70843&action=edit Bug 20074: Database revision to convert hidden to -5 The hidden value is used as a boolean in authority frameworks (in contrast with biblio framework). It is consistent to apply the same value (-5) to all non-zero values. Test plan: Check if you a have 0, 1 and 8 value in hidden somewhere. Run the dbrev. Verify that 1 and 8 are converted to -5. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:24:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:24:24 +0000 Subject: [Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts In-Reply-To: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20000-70-tgpG3fgJbT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:28:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:28:14 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-JCOHipZQnG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Another improvement would be to correct the sql installer files. See bug 20075 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:35:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:35:19 +0000 Subject: [Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch In-Reply-To: <bug-19365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19365-70-5sOO4ZFedf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:36:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:36:34 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-RuwpjisPeE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:36:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:36:37 +0000 Subject: [Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch In-Reply-To: <bug-19365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19365-70-FeWlTrDNor@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825 [Bug 18825] Elasticsearch - Update default authority mappings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:36:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:36:37 +0000 Subject: [Koha-bugs] [Bug 18825] Elasticsearch - Update default authority mappings In-Reply-To: <bug-18825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18825-70-CjxqnTDJDi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19365 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:37:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:37:47 +0000 Subject: [Koha-bugs] [Bug 20075] Change authority hidden attribute in sql installer files In-Reply-To: <bug-20075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20075-70-n8xy0NazPT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords| |RM_priority --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This needs to be pushed along with bug 20074 otherwise the new installs will contain wrong values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:39:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:39:18 +0000 Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use biblio_metadata.timestamp In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19730-70-FMxaygfiqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:39:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:39:27 +0000 Subject: [Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default In-Reply-To: <bug-18342-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18342-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18342-70-R4E6dw74XS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:40:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:40:09 +0000 Subject: [Koha-bugs] [Bug 20075] Change authority hidden attribute in sql installer files In-Reply-To: <bug-20075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20075-70-x0N29Z0h3m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #1) > This needs to be pushed along with bug 20074 otherwise the new installs will > contain wrong values. These 'wrong' values will be interpreted correctly. Not really a problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:40:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:40:25 +0000 Subject: [Koha-bugs] [Bug 19972] Holds to pull (pendingreserves.pl) should honor syspref "item-level_itypes" In-Reply-To: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19972-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19972-70-AO75ThnOty@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19972 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |victor.grousset at biblibre.co |ity.org |m CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:43:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:43:03 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-drRnf7LPX4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:48:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:48:07 +0000 Subject: [Koha-bugs] [Bug 20033] Switch single-column templates to Bootstrap grid: Catalog In-Reply-To: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20033-70-ehMTciP50E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20033 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70697|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70844&action=edit Bug 20033: Switch single-column templates to Bootstrap grid: Catalog This patch updates a few catalog-related single-column templates to use the Bootstrap grid. - basket/basket.tt - The staff client cart. Add some items to the cart and open the cart. - catalogue/advsearch.tt - The advanced search page. - catalogue/itemsearch.tt - The item search page, both the initial form and the search results. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:48:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:48:04 +0000 Subject: [Koha-bugs] [Bug 20033] Switch single-column templates to Bootstrap grid: Catalog In-Reply-To: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20033-70-malKpAdvKg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20033 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:48:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:48:21 +0000 Subject: [Koha-bugs] [Bug 20076] New: Overdues: remove redundant message when patrons don't have email addresses Message-ID: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Bug ID: 20076 Summary: Overdues: remove redundant message when patrons don't have email addresses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org When running overdue_notices.pl, one email message is sent to the library containing all the print versions of the related notices. But since a past enhancement, one message of the type print also is created for each of such notices. So now we have two print overdue notice generations. Which is why the email message is not longer relevant as it's superseded by the individual and ready to print messages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:48:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:48:34 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-K5OP0hVbs9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:51:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:51:48 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-NpA9rGJ6rk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:51:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:51:51 +0000 Subject: [Koha-bugs] [Bug 20052] Add Reports object class In-Reply-To: <bug-20052-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20052-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20052-70-MWr0T3GqGA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70784|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70845&action=edit Bug 20052 - Add Koha Reports object class To test: prove -v t/db_dependent/Koha/Reports.t Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:51:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:51:47 +0000 Subject: [Koha-bugs] [Bug 20052] Add Reports object class In-Reply-To: <bug-20052-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20052-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20052-70-PcJwqCNvN4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:52:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:52:25 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-m3YOvtA71Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 15:52:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 14:52:06 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-5wgWG5YWQB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70846&action=edit Bug 20076: Overdues: remove redundant message when patrons don't have email addresses When running overdue_notices.pl, one email message is sent to the library containing all the print versions of the related notices. But since a past enhancement, one message of the type print also is created for each of such notices. So now we have two print overdue notice generations. Which is why the email message is not longer relevant as it's superseded by the individual and ready to print messages. Test plan 1. Check the size of the message queue With the following SQL query (using an SQL report if you want) SELECT COUNT(*) FROM message_queue; 2. Run misc/cronjobs/overdue_notices.pl 3. Check the size of the message queue To ensure that no other overdues will create noise in this test plan. Or you can take them into account. 4. Choose a patron with no email address 5. Create an overdue (checkout an item and unfold "Checkout settings" and set a date in the past which is compatible with what you find in staff:/cgi-bin/koha/tools/overduerules.pl 6. Run misc/cronjobs/overdue_notices.pl 7. Check that you have two new messages in the queue 8. Inspect these two messages SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G 1. One has the type "print" and the borrowernumber matching the patron. 2. The other has subject: Overdue Notices borrowernumber: NULL message_transport_type: email and contains "These messages were not sent directly to the patrons." This is the one we don't want anymore. Because it's now obsolete due to the first message. 9. Apply this patch 10. Run misc/cronjobs/overdue_notices.pl 11. Check that only the print message is now generated and not the "Overdue Notices" one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:04:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:04:19 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-97OW05mNJ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- hiya, I am still seeing the Error even with the patch applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:08:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:08:50 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-OZygnfPIsD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70847&action=edit Bug 20074: (Follow-up) Remove another remainder of biblio hidden logic Script authorities.pl still contains a module 2 calculation on the hidden attribute, although it is used as a boolean. Since -5 mod 2 == 1, it does no harm, but we better remove it. Test plan: Edit and save an authority. Verify that everything still works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:09:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:09:04 +0000 Subject: [Koha-bugs] [Bug 20035] Switch single-column templates to Bootstrap grid: Patron clubs In-Reply-To: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20035-70-aYYlKm5oc4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:09:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:09:07 +0000 Subject: [Koha-bugs] [Bug 20035] Switch single-column templates to Bootstrap grid: Patron clubs In-Reply-To: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20035-70-NyxNzl0HLD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70702|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70848&action=edit Bug 20035: Switch single-column templates to Bootstrap grid: Patron clubs This patch updates two single-column Patron clubs templates to use the Bootstrap grid. - clubs/clubs-add-modify.tt - Tools -> Patron clubs -> New club. - clubs/templates-add-modify.tt - Tools -> Patron clubs -> New club template. Also changed in this file: Markup corrections. Label "for" attribute should match the form field's id attribute. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:19:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:19:54 +0000 Subject: [Koha-bugs] [Bug 19888] "Overdue Notices" email sent to KohaAdminEmailAddress should be optional In-Reply-To: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19888-70-lumYkrcoai@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Some confusion lead to the creation of bug 20076 which might be invalid. (In reply to Katrin Fischer from comment #1) > As there is no nice way to print the print notices at the moment we are > still relying on the email - it's not useless to us :) What do you mean by ?no nice way to print?? There is a script to generate PDFs which takes into account custom formatting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:21:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:21:11 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-mf2BkbqDhu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19888 --- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- This bugzilla and patch might be invalidated by: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888#c1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:21:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:21:11 +0000 Subject: [Koha-bugs] [Bug 19888] "Overdue Notices" email sent to KohaAdminEmailAddress should be optional In-Reply-To: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19888-70-2zesbDiq5b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20076 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:28:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:28:13 +0000 Subject: [Koha-bugs] [Bug 20036] Switch single-column templates to Bootstrap grid: Offline circulation In-Reply-To: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20036-70-CFvYL0yOXT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:28:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:28:16 +0000 Subject: [Koha-bugs] [Bug 20036] Switch single-column templates to Bootstrap grid: Offline circulation In-Reply-To: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20036-70-RsaJ6Onv63@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70704|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70849&action=edit Bug 20036: Switch single-column templates to Bootstrap grid: Offline circulation This patch updates three single-column offline circulation templates to use the Bootstrap grid. - offline_circ\process_koc.tt - Circulation -> Upload offline circulation. - offline_circ\enqueue_koc.tt - After uploading offline circulation file -> Add to offline circulation queue. The confirmation page is the page to be tested. - offline_circ\list.tt - From the confirmation page -> View pending offline circulation actions. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:42:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:42:32 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-707P2UsH6R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick at bywatersolutions.com |tomascohen at gmail.com CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:46:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:46:48 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-J2DgdvYZHF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:49:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:49:06 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-E7VIOhynaz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:49:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:49:09 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-xoFeG5MEYP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70811|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70850&action=edit Bug 19975: Fix search by tags at the OPAC This bug has certainly be caused by commit 091d6c513bcbee224ff06477e79be48cea7fe825 Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes The reason is quite simple, in Koha::ItemType->translated_description (called in opac-search.pl l.229) there is an eval to know if we have access to the translated description of the item type, to avoid retrieving it again. The evaluation of $@ later in opac-search.pl is supposed to test the 2 eval made few lines before (a "normal" search, without tags), but $@ contains the error message from the *last* eval command. So we are raising an error that have been correctly handled in Koha::ItemType. Test plan: At the OPAC, click Tag cloud, then click any of the tags => Without the patch you get Koha::ItemType::get_column generated this error: DBIx::Class::Row::get_column(): No such column 'translated_description' on Koha::Schema::Result::Itemtype at /usr/share/koha/lib/Koha/Object.pm line 307 => With the patch applied the page is correctly displayed Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> https://bugs.koha-community.org/show_bug.cgi?id=19775 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:52:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:52:32 +0000 Subject: [Koha-bugs] [Bug 20070] autoBarcode Increment Value In-Reply-To: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20070-70-gf1Yckslap@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20070 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:56:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:56:12 +0000 Subject: [Koha-bugs] [Bug 20071] Hide error displayed when db user tries to catalog anything In-Reply-To: <bug-20071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20071-70-qJEWQvyWAR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20071 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Almost everything will explode with the DB user, that's why there is a big warning on the main page. See bug 11590. *** This bug has been marked as a duplicate of bug 11590 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 16:56:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 15:56:12 +0000 Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user In-Reply-To: <bug-11590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11590-70-hrWIxvxfhy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 20071 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 18:14:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 17:14:18 +0000 Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use biblio_metadata.timestamp In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19730-70-apWPitW7Nf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69440|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70851&action=edit Bug 19730: Use biblio_metadata.timestamp in export_records.pl Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. REVISED TEST PLAN ----------------- 0. Do not apply patch 1. Find a biblio record, remember the biblionumber for step 3 2. Edit the record, modify a field (e.g. 003) that is not mapped to a DB column, so biblio_metadata.timestamp will be modified but not biblioitems.timestamp 3. In MySQL with the koha database selected: > select timestamp from biblio where biblionumber=###; > select timestamp from biblio_metadata where biblionumber=###; -- you'll need to change the ###'s based on the biblionumber you remembered in step 1. -- the two timestamps will differ. -- Remember the timestamp of biblio_metadata for step 4. 4. Run this command: $ sudo koha-shell -c bash kohadev $ export DATE="YYYY-MM-DD HH:mm:SS" -- use the timestamp remembered in step 3. 5. Run this command: $ ./misc/export_records.pl --date="$DATE" $ ls -la koha.mrc -- the file should be 0 bytes. 6. Run this command: $ exit $ git bz apply 19730 $ sudo koha-shell -c bash kohadev $ export DATE="YYYY-MM-DD HH:mm:SS" -- use the timestamp remembered in step 3. 7. Run this command: $ ./misc/export_records.pl --date="$DATE" $ ls -la koha.mrc -- the file should be a lot more than 0 bytes. 8. Run this command: $ /home/vagrant/qa-test-tools/koha-qa.pl -v 2 -c 1 -- this should pass. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 18:53:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 17:53:10 +0000 Subject: [Koha-bugs] [Bug 20077] New: Patroncards are printed blank Message-ID: <bug-20077-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20077 Bug ID: 20077 Summary: Patroncards are printed blank Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: martin.stastny at teamlibrary.cz QA Contact: testopia at bugs.koha-community.org Hello, we're experiencing problems with printing patroncards from Koha. The final result depends on used browser, for instance in opera I'm able to download blank pdf, however, in firefox I end up with "Not found. The document has moved here." error(under "here" link is nothing->nothing happens). We use self-build Koha with several changes from upstream, but we haven't edited this fuction. The logged errors are as following: manage.pl: CGI::param called in list context from package Template::Document line 57, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. create-pdf.pl: Use of uninitialized value in substitution iterator at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 233. create-pdf.pl: Use of uninitialized value $string_width in addition (+) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256. Thanks for helping Martin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 18:59:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 17:59:39 +0000 Subject: [Koha-bugs] [Bug 20078] New: Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus. Message-ID: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 Bug ID: 20078 Summary: Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com The indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) are not listed in C4::Search::getIndexes, and therefore cannot be used in the koha drop down menus. To re-create: Find a bib with 526$c and 526$d populated, e.g. +---------------+--------------+-------------+-------------+ | title | biblionumber | 526$c (arl) | 526$d (arp) | +---------------+--------------+-------------+-------------+ | Star flight / | 1347 | 5.5 | 14 | +---------------+--------------+-------------+-------------+ Entering the following in the search bar works: arl:5.5 as does arp:14 However entering the following in intranetuserjs: $(document).ready(function(){ // Add Accelerated Reading Level to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append('<option value="arl">Accelerated Reading Level</option>'); } // Add Accelerated Reading Point to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append('<option value="arp">Accelerated Reading Point</option>'); } }); Then running an advanced search using the respective values of Accelerated Reading Level and Accelerated Reading Point will fail. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:23:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:23:13 +0000 Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use biblio_metadata.timestamp In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19730-70-Hk5OHy6OQD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:23:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:23:16 +0000 Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use biblio_metadata.timestamp In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19730-70-4k3FXoDHcp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70851|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70852&action=edit Bug 19730: Use biblio_metadata.timestamp in export_records.pl Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. REVISED TEST PLAN ----------------- 0. Do not apply patch 1. Find a biblio record, remember the biblionumber for step 3 2. Edit the record, modify a field (e.g. 003, 015$q) that is not mapped to a DB column, so biblio_metadata.timestamp will be modified but not biblioitems.timestamp 3. In MySQL with the koha database selected: > select timestamp from biblio where biblionumber=###; > select timestamp from biblio_metadata where biblionumber=###; -- you'll need to change the ###'s based on the biblionumber you remembered in step 1. -- the two timestamps will differ. -- Remember the timestamp of biblio_metadata for step 4. 4. Run this command: $ sudo koha-shell -c bash kohadev $ export DATE="YYYY-MM-DD HH:mm:SS" -- use the timestamp remembered in step 3. 5. Run this command: $ ./misc/export_records.pl --date="$DATE" $ ls -la koha.mrc -- the file should be 0 bytes. 6. Run this command: $ exit $ git bz apply 19730 $ restart_all $ sudo koha-shell -c bash kohadev $ export DATE="YYYY-MM-DD HH:mm:SS" -- use the timestamp remembered in step 3. 7. Run this command: $ ./misc/export_records.pl --date="$DATE" $ ls -la koha.mrc -- the file should be a lot more than 0 bytes. 8. Run this command: $ /home/vagrant/qa-test-tools/koha-qa.pl -v 2 -c 1 -- this should pass. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:33:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:33:40 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18725-70-J736MHBeMZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70826|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70853&action=edit Bug 18725 - check for writability before sending each message This will mean that if we fill the disk in the middle of processing the message queue we will not continue to send messages even if the database was writable at the time of launch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:38:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:38:11 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-d3UZxLeJhs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70854&action=edit Bug 18336: Full stack tests for supplemental UTF-8 chars This patch introduces tests for Koha's support for 4-byte supplemental UTF-8 chars. encoding/decoding tools handle this gracefuly. The missing piece is the MySQL DB backend. The tests in this patch: - Adds a couple records for each flavour (MARC21 and UNIMARC) so search_utf8.t tests 4-byte chars are handled correctly - Adds emoji testing in auth_values_input_www.t To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => FAIL: It should fail if the DB hasn't been migrated into using utf8mb4 Sponsored-by: Hotchkiss School -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:38:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:38:15 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-KJiVEMiOcV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70855&action=edit Bug 18336: SET NAMES utf8mb4 in Koha::Database Sponsored-by: Hotchkiss School -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:38:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:38:20 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-qSUCEI0PTY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70856&action=edit Bug 18336: Convert schema from utf8 to utf8mb4 This patch adapts the DB structure so it uses utf8mb4 encoding and utf8mb4_generic_ci collation. Indexes for columns of type VARCHAR with prefix lenght higher than 191 are shortened because of the smaller max index lenght for utf8mb4 Note: please beware that testing this patchset risks your data and the patchset includes reinitializing the DB. To test: - Be on the master branch - Have a clean DB: $ reset_all (y) - Apply the first patch (Unit tests) - Run: $ kshell k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => FAIL: Tests fail because Koha doesn't support supplemental (UTF-8) chars. - Apply the rest of this patchset - Upgrade the schema: $ kshell k$ perl installer/data/mysql/updatedatabase.pl - Run the tests: k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => SUCCESS: Tests pass! - Now start from a clean DB - Run: $ reset_all (y) - Run the tests: k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => SUCCESS: Tests pass! Verify you can use emojis all over the place (MARC records, AV descriptions, etc). Sponsored-by: Hotchkiss School -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:38:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:38:25 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-ZrtcaZm2FQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70857&action=edit Bug 18336: DBIC update Sponsored-by: Hotchkiss School -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:38:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:38:30 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-0Vmuy17y3M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70858&action=edit Bug 18336: Atomic update Sponsored-by: Hotchkiss School -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:38:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:38:34 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-OIF9JW7rPI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70859&action=edit Bug 18336: Add explicit index names to kohastructure.sql This patch just adds an explicit index name to the search_marc_map table. The atomicupdate on this patchset is a good example of why we better have them. Sponsored-by: Hotchkiss School -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:41:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:41:56 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-lFmDrz6UJH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:42:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:42:29 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-zq1LB3cL9u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15794 | CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:42:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:42:29 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-3FKR4oA955@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18336 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:44:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:44:00 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-sw5PEyTQY3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 [Bug 15794] Allow the use of emojis as tags on records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:44:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:44:00 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-mU7t4mKlWt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18336 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:53:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:53:15 +0000 Subject: [Koha-bugs] [Bug 20079] New: Display stack trace for development installations Message-ID: <bug-20079-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Bug ID: 20079 Summary: Display stack trace for development installations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Starman -E should be development instead of deployment for dev installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:56:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:56:53 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: <bug-20079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20079-70-jcf3rnYGId@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 19:56:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 18:56:56 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: <bug-20079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20079-70-D1laSEtY0D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70860&action=edit Bug 20079: Display stack trace for development installations """The default value is development, which causes plackup to load the middleware components: AccessLog, StackTrace, and Lint unless --no-default-middleware is set.""" Test plan: Confirm that the stack trace is displayed when something is wrong (die somewhere to test) for dev installations (inside a devbox) The -E flag must remain deployment for non-dev installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:00:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:00:16 +0000 Subject: [Koha-bugs] [Bug 20080] New: Test for utf8mb4 encoding and collation Message-ID: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Bug ID: 20080 Summary: Test for utf8mb4 encoding and collation Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: QA tools Assignee: jonathan.druart at bugs.koha-community.org Reporter: tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:01:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:01:06 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-etHuG5BoAf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 [Bug 20080] Test for utf8mb4 encoding and collation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:01:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:01:06 +0000 Subject: [Koha-bugs] [Bug 20080] Test for utf8mb4 encoding and collation In-Reply-To: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20080-70-8sg6JNty6d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |tomascohen at gmail.com |ommunity.org | Depends on| |18336 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Bug 18336 introduces the use of a different collation and encoding. The QA tools should be adapted if that bug gets its patches pushed to master. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:06:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:06:33 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-QAtxqfrKhn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:07:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:07:35 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18477-70-0QBVBPIuZx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Critical, in the queue for too long already. Skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:07:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:07:46 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19985-70-V25sKyCApv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:07:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:07:59 +0000 Subject: [Koha-bugs] [Bug 18964] Add a --debugger flag to koha-plack In-Reply-To: <bug-18964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18964-70-e73CmfuSw0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Waiting for too long, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:09:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:09:23 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: <bug-20079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20079-70-jdI5FVH1bI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 [Bug 18964] Add a --debugger flag to koha-plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:09:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:09:23 +0000 Subject: [Koha-bugs] [Bug 18964] Add a --debugger flag to koha-plack In-Reply-To: <bug-18964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18964-70-RVIGTlH6Vg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 [Bug 20079] Display stack trace for development installations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:11:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:11:08 +0000 Subject: [Koha-bugs] [Bug 20080] Test for utf8mb4 encoding and collation In-Reply-To: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20080-70-IlBIogee0A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:11:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:11:11 +0000 Subject: [Koha-bugs] [Bug 20080] Test for utf8mb4 encoding and collation In-Reply-To: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20080-70-1UeUVpLcwg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 70861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70861&action=edit Bug 20080: Test for utf8mb4 encoding and collation Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:14:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:14:22 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: <bug-20079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20079-70-4GlcKDZq03@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70860|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70862&action=edit Bug 20079: Display stack trace for development installations """The default value is development, which causes plackup to load the middleware components: AccessLog, StackTrace, and Lint unless --no-default-middleware is set.""" Test plan: Confirm that the stack trace is displayed when something is wrong (die somewhere to test) for dev installations (inside a devbox) The -E flag must remain deployment for non-dev installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:50:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:50:25 +0000 Subject: [Koha-bugs] [Bug 20081] New: Enable uploaded pdfs to be viewed inline Message-ID: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Bug ID: 20081 Summary: Enable uploaded pdfs to be viewed inline Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When attaching files to bib records using the upload.pl plugin it would be nice to display viewable files in the browser instead of forcing download. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 20:55:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 19:55:50 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19705-70-3nXgm6WtUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- https://jenkins.koha-community.org/job/Koha_Master_D8/338/console # Failed test 'Static mode should exceed threshold' # at t/db_dependent/DecreaseLoanHighHolds.t line 125. # got: '0' # expected: '1' # Failed test 'Should have duration of 1' # at t/db_dependent/DecreaseLoanHighHolds.t line 127. # got: '0' # expected: '1' # Failed test 'due_date should be a DateTime object' # at t/db_dependent/DecreaseLoanHighHolds.t line 128. # got: '' # expected: 'DateTime' Can't call method "hour" on an undefined value at t/db_dependent/DecreaseLoanHighHolds.t line 131. # Looks like your test exited with 255 just after 5. [19:20:17] t/db_dependent/DecreaseLoanHighHolds.t ......................... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 15/17 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:01:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:01:03 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19705-70-KSaD0huP9u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:01:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:01:08 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19705-70-L5LPtBIDcL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 70863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70863&action=edit Bug 19705: Try to fix random failures from DecreaseLoanHighHolds.t No idea if it will do the trick, wait and see... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:02:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:02:10 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19705-70-gMzAdJ5t5u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:02:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:02:16 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19705-70-87fDEzsK8f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:02:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:02:36 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19705-70-QYkZYt2A26@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:25:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:25:07 +0000 Subject: [Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline In-Reply-To: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20081-70-frGSsQPqwq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70864&action=edit Bug 20081: Set inline headers for uploaded pdfs To test: 1 - Edit a framework and add the 'upload/pl' plugin to the 856 field 2 - Attach a pdf to one record 3 - Attach a different type of file to another (To attach, edit a record in the framework edited above and find the helper by the 856 field) 4 - Click the links on the record 5 - Verify the pdf opens inline 6 - Verify the other file does not 7 - prove t/db_dependent/Upload.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:25:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:25:05 +0000 Subject: [Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline In-Reply-To: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20081-70-YepIgyw1ou@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:25:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:25:50 +0000 Subject: [Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature (see also 6874) In-Reply-To: <bug-14294-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14294-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14294-70-XCUyZYGeLE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20018 CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:25:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:25:50 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20018-70-ZkYFzGckGs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14294 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:25:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:25:58 +0000 Subject: [Koha-bugs] [Bug 14282] Add configurable http headers for retrievable uploads (see 6874) In-Reply-To: <bug-14282-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14282-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14282-70-nBRvztGfj2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14282 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20018 CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:25:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:25:58 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20018-70-RtBXRS1n8u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14282 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:26:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:26:28 +0000 Subject: [Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline In-Reply-To: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20081-70-VBcU9l38NQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14282 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:26:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:26:28 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20018-70-cMGgKZmFco@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14282 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:26:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:26:42 +0000 Subject: [Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature (see also 6874) In-Reply-To: <bug-14294-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14294-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14294-70-w0BTNCXh6O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=20018 |?id=20081 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:26:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:26:42 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20018-70-Z97pZkd5Ir@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14294 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:26:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:26:28 +0000 Subject: [Koha-bugs] [Bug 14282] Add configurable http headers for retrievable uploads (see 6874) In-Reply-To: <bug-14282-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14282-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14282-70-bQH4BfuYip@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14282 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=20018 |?id=20081 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 21:26:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 20:26:42 +0000 Subject: [Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline In-Reply-To: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20081-70-HEKeK65o2h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14294 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 22:07:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 21:07:34 +0000 Subject: [Koha-bugs] [Bug 19473] Tag 008 position 06 always generate be "b" and position 7-10 and 7-14 are blank In-Reply-To: <bug-19473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19473-70-zOO9cbY4zx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19473 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 23 23:34:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 22:34:15 +0000 Subject: [Koha-bugs] [Bug 19965] 008 tag editor not showing completely In-Reply-To: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19965-70-9arMRkmpAu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19965 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |indradg at l2c2.co.in Status|NEW |RESOLVED --- Comment #5 from Indranil Das Gupta <indradg at l2c2.co.in> --- I can confirm that this is not a Koha 17.11 bug. The issue arose because the Hussain's setup had a custom staff client theme / template named - imam in the old 3.18.0 db, which wasn't ported over to 17.11. Closing this as RESOLVED-INVALID. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 00:20:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 23:20:28 +0000 Subject: [Koha-bugs] [Bug 19473] Tag 008 position 06 always generate be "b" and position 7-10 and 7-14 are blank In-Reply-To: <bug-19473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19473-70-w8bQS25p7f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19473 Indranil Das Gupta <indradg at l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|indradg at l2c2.co.in | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 00:22:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 23:22:19 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-YsstftXIY8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68340|0 |1 is obsolete| | --- Comment #55 from Charles Farmer <charles.farmer at inlibro.com> --- Created attachment 70865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70865&action=edit Bug 12532 - Send emails to guarantee and guarantor Adds setting "RedirectGuaranteeEmail". When setting is enabled, emails to patron with a guarantor will be send to both guarantor and guarantee. Does this by amending the C4::Members::GetNoticeEmail() sub. It does not affect values in the message_queue table. Test plan: Before applying 1) Select patron with guarantor 2) Enable checkout emails 3) Checkout item. Email will be sent only to guarantee 4) Apply patch 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' in system preferences 7) Go through step 1) to 3). Email should now be sent to both. 8) Run t/db_dependant/Members.t Sponsored by: Ville de Victoriaville Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 00:35:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 23:35:04 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-W49zHidw89@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I made this bug dependent on 18336, because (as Mark correctly pointed out) the big problem for this is the DB handling this 4-byte characters (emojis, some japanese chars, etc). Changing the DB like this is important for other areas, not just tags. Luckily, I've submitted the patches to implement the change (on bug 18336). It will need to be broadly tested, so start now :-D I will leave this bug open, for the specific task of integrating an emoji picker for the tags adding form in the OPAC :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 00:37:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jan 2018 23:37:27 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-OQ0tEJGBBh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com --- Comment #56 from Charles Farmer <charles.farmer at inlibro.com> --- I know I'm not supposed to mess with C4, but the test suite wouldn't run if I didn't expose GetNoticeEmailAddress through EXPORTER. Kept status 'Signed Off' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 02:08:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 01:08:13 +0000 Subject: [Koha-bugs] [Bug 19772] Wrong success message if PATRON_NOTE is not defined In-Reply-To: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19772-70-34OHiuF2vs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Sorry Jonathan, I can't actually reproduce this. When there is no notice called 'CHECKOUT_NOTE' (which is now what the notice is called), the note still saves and the title shows as expected (but obviously the notice isn't sent and the log shows that "No circulation CHECKOUT_NOTE letter transported by email at /home/vagrant/kohaclone/C4/Letters.pm line 697." message) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 02:40:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 01:40:42 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-5pJxaYTo2B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63905|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70867&action=edit Bug 15326: [FOLLOW-UP] Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 02:40:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 01:40:49 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-W1ygcwRSxF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64241|0 |1 is obsolete| | --- Comment #25 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70868&action=edit Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 02:40:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 01:40:35 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-SgwbquJTod@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63904|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70866&action=edit Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 02:40:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 01:40:56 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-u5acZUVCOw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64941|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70869&action=edit Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 02:41:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 01:41:02 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-WrMDi1mJVu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64942|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70870&action=edit Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 02:41:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 01:41:08 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-cZXzaI0Jyt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66255|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 70871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70871&action=edit Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 03:12:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 02:12:11 +0000 Subject: [Koha-bugs] [Bug 20082] New: Vietnamese language display name is incorrect Message-ID: <bug-20082-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20082 Bug ID: 20082 Summary: Vietnamese language display name is incorrect Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: dcowens76 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Currently the vi-VN language display name is in Chinese characters (??). This is incorrect. To reproduce this, install the vi-VN language and open the OPAC. The option for Vietnamese will display as those Chinese characters, rather than "Ti?ng Vi?t", which is the way Vietnamese people refer to their language. The display name is created by the installer in installer/data/mysql/mandatory/subtag_registry.sql: VALUES ( 'vi', 'language', 'vi', '??'); That should be changed to: VALUES ( 'vi', 'language', 'vi', 'Ti?ng Vi?t'); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 06:36:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 05:36:08 +0000 Subject: [Koha-bugs] [Bug 19976] data restoration in newly installed koha 17.11.X In-Reply-To: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19976-70-a7EeuOmREu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19976 --- Comment #4 from Mohammad Rasheed <rasheed at psmchs.edu.sa> --- (In reply to Jonathan Druart from comment #3) > I can imagine a bug if you are coming from 3.22, but if you are coming from > 16.05 you should have this table in your database. Hi Jonathan Thank you very much for your advise. The matter has been resolved. You are correct. I find the file and now koha 17.11 successfully working.... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 08:20:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 07:20:10 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-QHQw4ZkjYK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- hiya, acqui-search.tt is mising the bootstrap grid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 09:55:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 08:55:40 +0000 Subject: [Koha-bugs] [Bug 20084] New: Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error Message-ID: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Bug ID: 20084 Summary: Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org ## Reproduction ## This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode This show that this setup isn't completely bogus (although Code 39 is the only type working) 6. Export the batch 7. You should have a white page with a barcode And no errors in the relevant log file 8. Layout: set "Barcode type:" to Industrial2of5 9. Export the batch 10. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" ## Going further ## COOP2of5 fails also with the same error TODO: Fix at the same time or open another bug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 09:55:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 08:55:51 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error In-Reply-To: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20084-70-DFFNbj1oDw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |victor.grousset at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 10:12:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 09:12:09 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-4BuNp9Bzjj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 10:12:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 09:12:12 +0000 Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19755-70-gg50zNxHGd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69560|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70873&action=edit Bug 19755: Move template JavaScript to the footer: Acquisitions, part 3 This patch modifies even more staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Vendor -> Vendor details - Contracts datatable - Edit vendor - Add contacts, form validation - Acquisitions -> Vendor -> Invoices -> Invoice -> "Go to receipt" - Datatables, MARC and Card previews - Transfer - Confirmation of transfer, window closes - Acquisitions -> Vendor -> Receive shipments - Datatables, date pickers - Acquisitions -> Available funds table -> Spent report - Datatables - Acquisitions -> Vendor -> Uncertain prices - Datatables, form validation - Acquisitions -> Vendor -> Basket -> Add to basket from external source - Select and clear all on search form - Search results - Datatables, MARC and Card previews, in-table pop-up controls (click any table cell) Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 10:39:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 09:39:18 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-wpLHbHnSup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #193 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 70874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70874&action=edit Bug 17047 - Fix retrieving Mana token -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 10:50:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 09:50:11 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-1Yl3H8Y6SF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #194 from Alex Arnaud <alex.arnaud at biblibre.com> --- To be clear with the job done since Jonathan's QA: > Comment 161 - /cgi-bin/koha/svc/mana/getToken is not successfully returning a security token? Fixed > Comment 162 and Comment 163 Fixed > Comment 164 - How can we open issue on http://git.biblibre.com/biblibre/koha-mana We plan to move Mana server sources on Koha community repository > Comment 164 - I'd like a more complete README to run the server and the tests. http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md. Need to be completed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 10:52:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 09:52:39 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-5ntBNA9crO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #195 from Alex Arnaud <alex.arnaud at biblibre.com> --- I will work on Comment 191 as soon as possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 11:37:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 10:37:50 +0000 Subject: [Koha-bugs] [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions In-Reply-To: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20038-70-mnfAf27AXA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 11:37:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 10:37:53 +0000 Subject: [Koha-bugs] [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions In-Reply-To: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20038-70-MZ2kxTmXGi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70748|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70875&action=edit Bug 20038: Switch single-column templates to Bootstrap grid: Acquisitions This patch updates several acquisitions module templates to use the Bootstrap grid. - acqui/z3950_search.tt - Acquisitions -> Vendor -> View basket -> Add to basket -> From an external source. The Z39.50 search form should look correct. - Search for a title. The search results page should look correct. - acqui/addorder.tt - Acquisitions -> Vendor -> View basket -> Add to basket. Add an order to the basket which costs more than is available in the fund you select. The error/confirmation screen should look correct. - acqui\modordernotes.tt - Acquisitions -> Vendor -> View basket -> Add internal or vendor note. The note add form should look correct. - acqui/cancelorder.tt - Acquisitions -> Vendor -> View basket -> Cancel order (from an open basket which has existing orders). The confirmation screen should look correct. - acqui\basketheader.tt - Acquisitions -> Vendor -> New basket. The new basket edit form should look correct. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 12:10:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 11:10:50 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18725-70-f2ajb4wJ1I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 12:10:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 11:10:53 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18725-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18725-70-9a0BhmbCaH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70853|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 70876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70876&action=edit Bug 18725 - Process_message_queue sends duplicate emails if message_queue is not writable. Last week, we had a database server whose disk filled, causing database writes to fail. This meant that messages in message_queue marked 'pending' were not marked as 'sent' when they were added to the postfix mail queue; messages were sent every 15 minutes (as specified in the cron job) until the disk space issues were cleared. I would suggest adding a token write to the start of process_message_queue.pl as a 'canary in the coal mine'. If the database write fails, process_message_queue should stop, because it's not safe to proceed sending emails that may not be marked 'sent'. Test Plan: 1) Apply this patch 2) Make the message_queue table unwriteable somehow 3) Run process_message_queue.pl 4) Script should die with error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 12:23:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 11:23:16 +0000 Subject: [Koha-bugs] [Bug 18836] MySQL 5.7 - Table 'koha_library.club_enrollments' doesn't exist In-Reply-To: <bug-18836-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18836-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18836-70-r0bTW1Tziu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836 Paul Chau <chichau at optusnet.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chichau at optusnet.com.au --- Comment #15 from Paul Chau <chichau at optusnet.com.au> --- I am using ubuntu 16.04 The problem seems to be related to setting of sql-mode in /etc/mysql/mariadb.conf.d/50-server.cnf If anyone can confirm after changing sql-mode to other value like '' will allow clubenrollments to be created. Also somewhere from the net mentioned "SET SESSION sql_mode = '';" will help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 13:14:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 12:14:35 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-O0pwqwY62O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 --- Comment #3 from Claire Gravely <claire_gravely at hotmail.com> --- (In reply to Claire Gravely from comment #2) > hiya, > acqui-search.tt is mising the bootstrap grid. Ignore that. Everything is lovely! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 13:19:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 12:19:32 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-3oidPjHfgf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 --- Comment #4 from Claire Gravely <claire_gravely at hotmail.com> --- (In reply to Claire Gravely from comment #3) > (In reply to Claire Gravely from comment #2) > > hiya, > > acqui-search.tt is mising the bootstrap grid. > > Ignore that. Everything is lovely! Sorry, double checked the wrong bit :| It does seem to be missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 14:22:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 13:22:10 +0000 Subject: [Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials In-Reply-To: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20037-70-AKidVdj1GA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 14:23:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 13:23:09 +0000 Subject: [Koha-bugs] [Bug 20085] New: Better translatability of smart-rules.tt Message-ID: <bug-20085-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085 Bug ID: 20085 Summary: Better translatability of smart-rules.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Template smart-rules.tt in administration contains some if/elsif/else with translatable strings. For example : [% IF rule.onshelfholds == 1 %] Yes [% ELSIF rule.onshelfholds == 2 %] If all unavailable [% ELSE %] If any unavailable [% END %] Adding span to translatable strings will allow to have the same translation than : <select name="onshelfholds" id="onshelfholds"> <option value="1">Yes</option> <option value="0">If any unavailable</option> <option value="2">If all unavailable</option> </select> This is important to allow editing an existing circulation and fine rule. Actually for example in french some strings are translated differently : msgid "%s Yes %s If all unavailable %s If any unavailable %s" msgstr "%s Oui %s Si tous indisponibles %s Si aucun indisponible %s" msgid "If any unavailable" msgstr "Si au moins un exemplaire est indisponible" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 14:23:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 13:23:18 +0000 Subject: [Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt In-Reply-To: <bug-20085-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20085-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20085-70-bkJnDTt1i7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 14:30:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 13:30:27 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error In-Reply-To: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20084-70-NHH1TX7xEP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- ## Reproduction ## This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" ## going further ## COOP2of5 fails also with the same error TODO: Fix at the same time or open another bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 14:35:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 13:35:16 +0000 Subject: [Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is confusing In-Reply-To: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19690-70-QRXmn5rh9o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20085 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 14:35:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 13:35:16 +0000 Subject: [Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt In-Reply-To: <bug-20085-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20085-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20085-70-cfR6LjZis7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 14:35:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 13:35:52 +0000 Subject: [Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt In-Reply-To: <bug-20085-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20085-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20085-70-xhq1dCrHI9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 14:35:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 13:35:55 +0000 Subject: [Koha-bugs] [Bug 20085] Better translatability of smart-rules.tt In-Reply-To: <bug-20085-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20085-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20085-70-cjZrDsM94J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20085 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 70877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70877&action=edit Bug 20085: Better translatability of smart-rules.tt Template smart-rules.tt in administration contains some if/elsif/else with translatable strings. For example : [% IF rule.onshelfholds == 1 %] Yes [% ELSIF rule.onshelfholds == 2 %] If all unavailable [% ELSE %] If any unavailable [% END %] Adding span to translatable strings will allow to have the same translation than : <select name="onshelfholds" id="onshelfholds"> <option value="1">Yes</option> <option value="0">If any unavailable</option> <option value="2">If all unavailable</option> </select> This is important to allow editing an existing circulation and fine rule. Actually for example in french some strings are translated differently : msgid "%s Yes %s If all unavailable %s If any unavailable %s" msgstr "%s Oui %s Si tous indisponibles %s Si aucun indisponible %s" msgid "If any unavailable" msgstr "Si au moins un exemplaire est indisponible" This patch adds span to translatable strings. Also adds <em> on "Unlimited" and "None defined" so that there are more visible and that there translation is more simple. Test plan : 1) Look at PO files, for example fr-FR and see there is : msgid "%s Yes %s If all unavailable %s If any unavailable %s" msgid "If any unavailable" 2) Apply patch 3) update PO files 4) Look at PO files, for example fr-FR and see there is now only : msgid "If any unavailable" 5) Install translation 6) Go to Administration > Circulation and fine rule 7) Check that when editing an existing rule, edition comboboxes are set on the correct value 8) Create a default holds policy by item type and check that correct values are displayed in table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 14:50:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 13:50:11 +0000 Subject: [Koha-bugs] [Bug 20086] New: AddRenewal is not executed as a transaction and can results in partial success and doubled fines Message-ID: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 Bug ID: 20086 Summary: AddRenewal is not executed as a transaction and can results in partial success and doubled fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I can't recreate on demand, however, I can confirm several reports in the wild. On a large/busy system, grep for "Deadlock" in the plack error logs. On several sites we are seeing occasional: DBD::mysql::st execute failed: Deadlock found when trying to get lock; try restarting transaction [for Statement "UPDATE issues SET date_due = ?, renewals = ?, lastreneweddate = ? WHERE borrowernumber=? AND itemnumber=?" with ParamValues: 0='2099-01-01 23:59', 1=2, 2='2099-01-01', 3="#####", 4="#####"] at /usr/share/koha/lib/C4/Circulation.pm line 2895. (dates and numbers altered for privacy) In this case the fines are closed, but when the issue update fails the librarian repeats the renewal and fines are then recreated (koha finds no open fine, so calculates a new one) Ideally the whole sub would be a transaction -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 14:51:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 13:51:22 +0000 Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines In-Reply-To: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20086-70-JMUaQFEQrO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 15:11:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 14:11:46 +0000 Subject: [Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline In-Reply-To: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20081-70-ewIRLbmZtn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70864|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70878&action=edit Bug 20081: Set inline headers for uploaded pdfs To test: 1 - Edit a framework and add the 'upload/pl' plugin to the 856 field 2 - Attach a pdf to one record 3 - Attach a different type of file to another (To attach, edit a record in the framework edited above and find the helper by the 856 field) 4 - Click the links on the record 5 - Verify the pdf opens inline 6 - Verify the other file does not 7 - prove t/db_dependent/Upload.t Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 15:11:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 14:11:44 +0000 Subject: [Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline In-Reply-To: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20081-70-cU7c0Zh7RZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 15:24:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 14:24:07 +0000 Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines In-Reply-To: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20086-70-xkg8M076y9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70879&action=edit Bug 20086 - AddRenewal is not executed as a transaction and can results in partial success and doubled fines This patch starts a transaction and only commits if renewal and fines updates and charges are successful (partial in any cna be problematic) There is no feedback (as currently there is none either) but if part fails, all fails. I didn't include stats and notifications in the transaction, but we could. To test: 1 - Apply patch 2 - prove t/db_dependent/Circulation.t 3 - Attempt circs and renewals should be no difference 4 - If possible make part of transaction fail and ensure all fails -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 15:25:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 14:25:00 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error In-Reply-To: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20084-70-CtilyxYmfO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- I looked at http://manpages.org/pdfreusebarcode/3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 15:29:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 14:29:31 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-6MgoE4dulA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 15:31:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 14:31:10 +0000 Subject: [Koha-bugs] [Bug 17241] Start using Bower for installing and managing Koha's JavaScript Dependencies In-Reply-To: <bug-17241-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17241-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17241-70-R9YxR8k9hD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17241 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Martin Renvoize from comment #7) > https://www.quora.com/Why-use-Bower-when-there-is-npm makes for an > interesting read around this exact topic That argument assumes we are using something like webpack, which we do not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:04:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:04:19 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17111-70-mPR3JHb4Uj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatic debian/control |Automatic debian/control |updates (oldstable/16.05.x) |updates (oldstable/17.05.x) --- Comment #34 from Mirko Tietgen <mirko at abunchofthings.net> --- 17.05.x is oldstable now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:04:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:04:45 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17111-70-h3NuknmT8J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #35 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 70880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70880&action=edit d/control 17.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:05:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:05:18 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17111-70-XLKyGiBaPE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70880|0 |1 is obsolete| | --- Comment #36 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 70881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70881&action=edit d/control 17.05.08 https://bugs.koha-community.org/show_bug.cgi?id=17111 Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:05:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:05:53 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17111-70-zMbHwRyMkY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtj at kohaaloha.com |fridolin.somers at biblibre.co | |m Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:06:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:06:16 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17111-70-TJIQ7H7IMF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59732|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:06:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:06:37 +0000 Subject: [Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline In-Reply-To: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20081-70-YFuIVVfQhQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- The idea on 14282 was to do this somewhat less hardcoded and more configurable.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:07:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:07:28 +0000 Subject: [Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline In-Reply-To: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20081-70-5JFhNqv6Oi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:08:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:08:22 +0000 Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines In-Reply-To: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20086-70-9AU55Sv2cD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 Edie Discher <edischer at cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:26:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:26:15 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17111-70-lr9qHO6UNA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:26:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:26:24 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17111-70-nXS6Lf4rvU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:26:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:26:42 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-sb2D7YLfrh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:26:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:26:49 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-pPLhvY05kZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:33:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:33:09 +0000 Subject: [Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline In-Reply-To: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20081-70-2ze8Leo9DY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Hi Marcel, I saw that bug but wasn't sure what you envisioned, what would you suggest? My first thought was a syspref specifying the extensions that should be inline. -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:46:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:46:04 +0000 Subject: [Koha-bugs] [Bug 9983] printable fines page should include name/barcode In-Reply-To: <bug-9983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9983-70-dgsMCV3sJ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9983 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 16:48:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 15:48:46 +0000 Subject: [Koha-bugs] [Bug 17551] printinvoice.pl should allow full customization of content and style In-Reply-To: <bug-17551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17551-70-RW8eqw08vk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17551 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:02:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:02:00 +0000 Subject: [Koha-bugs] [Bug 17551] printinvoice.pl should allow full customization of content and style In-Reply-To: <bug-17551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17551-70-RxP4lEjBS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17551 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:03:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:03:27 +0000 Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines In-Reply-To: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20086-70-T146O8Het0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- What if we are already in a transaction? Several unit tests include a call to AddRenewal.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:13:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:13:11 +0000 Subject: [Koha-bugs] [Bug 20087] New: When UseACQFrameworkForBiblioRecords in on, required fields can be empty Message-ID: <bug-20087-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20087 Bug ID: 20087 Summary: When UseACQFrameworkForBiblioRecords in on, required fields can be empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org When the system preference UseACQFrameworkForBiblioRecords in fixed on "Use" (see bugzilla 19289), the order can be saved even though mandatory fields are not filled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:15:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:15:25 +0000 Subject: [Koha-bugs] [Bug 20087] When UseACQFrameworkForBiblioRecords in on, required fields can be empty In-Reply-To: <bug-20087-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20087-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20087-70-CenAYejK6E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20087 S?verine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:15:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:15:25 +0000 Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19289-70-edUBXp4k0U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 S?verine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20087 [Bug 20087] When UseACQFrameworkForBiblioRecords in on, required fields can be empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:15:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:15:13 +0000 Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets In-Reply-To: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19289-70-AqwRXIaSl6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #21 from S?verine Queune <severine.queune at bulac.fr> --- (In reply to Jonathan Druart from comment #20) > Created attachment 70765 [details] [review] > Bug 19289: Use jQuery validate plugin > > This is quite dirty but rewrite the JS checks is out of the scope of > this bug report. Hi Jonathan, I just create a new bud report (#20087) for this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:22:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:22:07 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-0ZpuJDlqbx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #9 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70857 Bug 18336: DBIC update Review of attachment 70857: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18336&attachment=70857) ----------------------------------------------------------------- Why did the size change from 255 to 191? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:37:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:37:55 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-LScHzV6kAT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- (In reply to M. Tompsett from comment #9) > Why did the size change from 255 to 191? After a conversation on IRC with tcohen: A lot of fields are shrunk from 255 to 191. This is because index size for VARCHAR on InnoDB has a max size, in bytes, of 767 bytes (or similar) and utf8 uses 3 bytes for each char, and utf8mb4, 4. 767/3 > 255. but 767/4 > 191. https://dev.mysql.com/doc/refman/5.5/en/charset-unicode-conversion.html Gain functionality (necessary for true unicode), lose space (not an issue yet). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:38:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:38:34 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-kstdTzN5KU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://dev.mysql.com/doc/r | |efman/5.5/en/charset-unicod | |e-conversion.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:41:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:41:32 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-Nyxcp24mJx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to M. Tompsett from comment #10) > (In reply to M. Tompsett from comment #9) > > Why did the size change from 255 to 191? > > After a conversation on IRC with tcohen: > A lot of fields are shrunk from 255 to 191. This is because A lot of *indexes* are shrunk from 255 to 191. This has the impact of making searches on things longer than 191 chars require some more CPU usage (probably). But no data is shrunk in most of the changes. The tags_* tables get the 'term' column shrunk, because I didn't manage to fix it other way. It seems a safe one, though. Tags are usually a single word... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 17:56:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 16:56:14 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-r2URmLopzW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #41 from S?verine Queune <severine.queune at bulac.fr> --- (In reply to Jonathan Druart from comment #40) > (In reply to S?verine Queune from comment #38) > > (In reply to Jonathan Druart from comment #37) > > > (In reply to S?verine Queune from comment #35) > > - with "Allow and notify" option, I get this sotware error : > > Undefined subroutine &C4::Members::GetNoticeEmailAddress called at > > /home/koha/src/circ/pendingreserves.pl line 95. > > Yes, conflict with bug 19287, should be ok now. Cancellation still works with the "Allow" only option. I have this (normal) Software error when I used the "Allow and notify" option : > The method 0 is not covered by tests! Email is "pending" on the patron account, but I can't be sure that, in a functional instance, cancellation is made because I can't refresh the error page, and when I go back to the "Holds to pull" page or the record, hold is still on the item. I will see tomorrow with Nicolas, maybe he could install this patch on our Koha-Test and we could see if everything works as expected. Is that ok with you ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 18:00:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 17:00:37 +0000 Subject: [Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts In-Reply-To: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19991-70-QojzyfuLcR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> --- After applying the patch, I still appear to have use strict in the following files: vagrant at kohadevbox:kohaclone(bug_19991)$ grep -r "use strict" opac/* opac/errors/403.pl:use strict; opac/errors/500.pl:use strict; opac/errors/400.pl:use strict; opac/errors/402.pl:use strict; opac/errors/404.pl:use strict; opac/errors/401.pl:use strict; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 18:05:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 17:05:14 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19992-70-qMQ2ftFKgc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 18:05:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 17:05:17 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19992-70-PsK08hbQOh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70647|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70882&action=edit Bug-19992: use Modern::Perl in Admin perl scripts Test plan: Check use warnings; use strict doesn't exist and use Modern::Perl is written instead in the following files: admin/admin-home.pl admin/aqcontract.pl admin/aqplan.pl admin/auth_tag_structure.pl admin/branch_transfer_limits.pl admin/check_budget_parent.pl admin/check_parent_total.pl admin/checkmarc.pl admin/classsources.pl admin/clone-rules.pl admin/didyoumean.pl admin/edi_accounts.pl admin/edi_ean_accounts.pl admin/import_export_framework.pl admin/item_circulation_alerts.pl admin/marctagstructure.pl admin/matching-rules.pl admin/printers.pl admin/smart-rules.pl admin/systempreferences.pl admin/transport-cost-matrix.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 18:17:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 17:17:07 +0000 Subject: [Koha-bugs] [Bug 19994] use Modern::Perl in Authorities perl scripts In-Reply-To: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19994-70-lskZrL7I31@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19994 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> --- The files: authorities/detail-biblio-search.pl authorities/export.pl still appear to have a use strict in them after applying the patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:09:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:09:40 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19995-70-tjY7gIDfuO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:09:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:09:43 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19995-70-WMCzHxElC7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70656|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70883&action=edit Bug 19995: Replacing 'use strict; use warnings;' with 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl;' and not 'use strict; use warnings;' in the following catalogue perl scripts. MARCdetail.pl export.pl image.pl imageviewer.pl issuehistory.pl labeledMARCdetail.pl moredetail.pl search.pl showmarc.pl updateitem.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:13:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:13:56 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19996-70-yuKjBMcbDk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:13:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:13:59 +0000 Subject: [Koha-bugs] [Bug 19996] use Modern::Perl in cataloguing perl scripts In-Reply-To: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19996-70-dlcs4D7qnj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70672|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70884&action=edit Bug 19996: use Modern::Perl in cataloguing perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; addbiblio.pl addbooks.pl additem.pl linkitem.pl moveitem.pl value_builder/normarc_field_007.pl value_builder/normarc_field_008.pl value_builder/normarc_leader.pl value_builder/unimarc_field_010.pl value_builder/unimarc_field_100.pl value_builder/unimarc_field_105.pl value_builder/unimarc_field_106.pl value_builder/unimarc_field_110.pl value_builder/unimarc_field_115a.pl value_builder/unimarc_field_115b.pl value_builder/unimarc_field_116.pl value_builder/unimarc_field_117.pl value_builder/unimarc_field_120.pl value_builder/unimarc_field_121a.pl value_builder/unimarc_field_121b.pl value_builder/unimarc_field_122.pl value_builder/unimarc_field_123a.pl value_builder/unimarc_field_123d.pl value_builder/unimarc_field_123e.pl value_builder/unimarc_field_123f.pl value_builder/unimarc_field_123g.pl value_builder/unimarc_field_123i.pl value_builder/unimarc_field_123j.pl value_builder/unimarc_field_124.pl value_builder/unimarc_field_124a.pl value_builder/unimarc_field_124b.pl value_builder/unimarc_field_124c.pl value_builder/unimarc_field_124d.pl value_builder/unimarc_field_124e.pl value_builder/unimarc_field_124f.pl value_builder/unimarc_field_124g.pl value_builder/unimarc_field_125.pl value_builder/unimarc_field_125a.pl value_builder/unimarc_field_125b.pl value_builder/unimarc_field_126.pl value_builder/unimarc_field_126a.pl value_builder/unimarc_field_126b.pl value_builder/unimarc_field_127.pl value_builder/unimarc_field_128a.pl value_builder/unimarc_field_128b.pl value_builder/unimarc_field_128c.pl value_builder/unimarc_field_130.pl value_builder/unimarc_field_135a.pl value_builder/unimarc_field_140.pl value_builder/unimarc_field_141.pl value_builder/unimarc_field_210c.pl value_builder/unimarc_field_210c_bis.pl value_builder/unimarc_field_225a.pl value_builder/unimarc_field_4XX.pl value_builder/unimarc_field_686a.pl value_builder/unimarc_field_700-4.pl value_builder/unimarc_leader.pl z3950_auth_search.pl z3950_search.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:16:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:16:58 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19997-70-1pYUU8C5Tb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:17:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:17:01 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19997-70-REMJJ5ie3k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70665|0 |1 is obsolete| | --- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70885&action=edit Bug 19997: use Modern::Perl in Circulation perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; bookcount.pl branchoverdues.pl branchtransfers.pl circulation.pl hold-transfer-slip.pl reserveratios.pl returns.pl selectbranchprinter.pl transfer-slip.pl transferstoreceive.pl view_holdsqueue.pl waitingreserves.pl ypattrodue-attr-search-authvalue.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:19:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:19:07 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19998-70-UT2mtPlxsu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:19:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:19:09 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19998-70-3zox09l32T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70670|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70886&action=edit Bug 19998 - use Modern::Perl in error perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; 400.pl 401.pl 402.pl 403.pl 404.pl 500.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:22:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:22:52 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20009-70-DOS8jnOUI9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:22:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:22:54 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20009-70-HK9HwCTrnY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70676|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70887&action=edit Bug 20009 - use Modern::Perl in Members perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; boraccount.pl default_messageprefs.pl deletemem.pl files.pl mancredit.pl maninvoice.pl member-flags.pl member-password.pl memberentry.pl members-home.pl members-update-do.pl moremember.pl notices.pl pay.pl paycollect.pl printfeercpt.pl printinvoice.pl printslip.pl readingrec.pl routing-lists.pl setstatus.pl update-child.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:26:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:26:08 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20010-70-gbsdlz53PK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:26:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:26:11 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20010-70-aExsrqgb0m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70680|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70888&action=edit Bug 20010: use Modern::Perl in Patroncards perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; create-pdf.pl edit-batch.pl edit-layout.pl edit-profile.pl edit-template.pl home.pl image-manage.pl manage.pl print.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:28:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:28:23 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20011-70-e8GJdE7yA7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:28:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:28:25 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20011-70-76M3pVCpHz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70669|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70889&action=edit Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins perl scripts plugins-home.pl plugins-uninstall.pl plugins-upload.pl run.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:33:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:33:16 +0000 Subject: [Koha-bugs] [Bug 20011] use Modern::Perl in plugins perl scripts In-Reply-To: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20011-70-qH0HFMFCuP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70889|0 |1 is obsolete| | --- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70890&action=edit Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins perl scripts plugins-home.pl plugins-uninstall.pl plugins-upload.pl run.pl Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:34:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:34:15 +0000 Subject: [Koha-bugs] [Bug 20010] use Modern::Perl in Patroncards perl scripts In-Reply-To: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20010-70-spthWNaDRq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70888|0 |1 is obsolete| | --- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70891&action=edit Bug 20010: use Modern::Perl in Patroncards perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; create-pdf.pl edit-batch.pl edit-layout.pl edit-profile.pl edit-template.pl home.pl image-manage.pl manage.pl print.pl Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:35:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:35:30 +0000 Subject: [Koha-bugs] [Bug 20009] use Modern::Perl in Members perl scripts In-Reply-To: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20009-70-N4cHqLwVkY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70887|0 |1 is obsolete| | --- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70892&action=edit Bug 20009 - use Modern::Perl in Members perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; boraccount.pl default_messageprefs.pl deletemem.pl files.pl mancredit.pl maninvoice.pl member-flags.pl member-password.pl memberentry.pl members-home.pl members-update-do.pl moremember.pl notices.pl pay.pl paycollect.pl printfeercpt.pl printinvoice.pl printslip.pl readingrec.pl routing-lists.pl setstatus.pl update-child.pl Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:36:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:36:09 +0000 Subject: [Koha-bugs] [Bug 19998] use Modern::Perl in error perl scripts In-Reply-To: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19998-70-UkxLi2Tqwx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70886|0 |1 is obsolete| | --- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70893&action=edit Bug 19998 - use Modern::Perl in error perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; 400.pl 401.pl 402.pl 403.pl 404.pl 500.pl Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:37:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:37:00 +0000 Subject: [Koha-bugs] [Bug 19997] use Modern::Perl in Circulation perl scripts In-Reply-To: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19997-70-E5ci2j4fvT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70885|0 |1 is obsolete| | --- Comment #4 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70894&action=edit Bug 19997: use Modern::Perl in Circulation perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; bookcount.pl branchoverdues.pl branchtransfers.pl circulation.pl hold-transfer-slip.pl reserveratios.pl returns.pl selectbranchprinter.pl transfer-slip.pl transferstoreceive.pl view_holdsqueue.pl waitingreserves.pl ypattrodue-attr-search-authvalue.pl Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:37:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:37:29 +0000 Subject: [Koha-bugs] [Bug 19995] use Modern::Perl in Catalogue perl scripts In-Reply-To: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19995-70-qteiQ5dirj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70883|0 |1 is obsolete| | --- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70895&action=edit Bug 19995: Replacing 'use strict; use warnings;' with 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl;' and not 'use strict; use warnings;' in the following catalogue perl scripts. MARCdetail.pl export.pl image.pl imageviewer.pl issuehistory.pl labeledMARCdetail.pl moredetail.pl search.pl showmarc.pl updateitem.pl Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:37:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:37:56 +0000 Subject: [Koha-bugs] [Bug 19992] use Modern::Perl in Admin perl scripts In-Reply-To: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19992-70-uXxRR6YAOl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70882|0 |1 is obsolete| | --- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70896&action=edit Bug-19992: use Modern::Perl in Admin perl scripts Test plan: Check use warnings; use strict doesn't exist and use Modern::Perl is written instead in the following files: admin/admin-home.pl admin/aqcontract.pl admin/aqplan.pl admin/auth_tag_structure.pl admin/branch_transfer_limits.pl admin/check_budget_parent.pl admin/check_parent_total.pl admin/checkmarc.pl admin/classsources.pl admin/clone-rules.pl admin/didyoumean.pl admin/edi_accounts.pl admin/edi_ean_accounts.pl admin/import_export_framework.pl admin/item_circulation_alerts.pl admin/marctagstructure.pl admin/matching-rules.pl admin/printers.pl admin/smart-rules.pl admin/systempreferences.pl admin/transport-cost-matrix.pl Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:41:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:41:19 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20012-70-NiAqLHsLPl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:41:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:41:22 +0000 Subject: [Koha-bugs] [Bug 20012] use Modern::Perl in Reports perl scripts In-Reply-To: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20012-70-tt4xQolyFr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70667|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70897&action=edit Bug 20012:use Modern::Perl in Reports perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; borrowers_out.pl cat_issues_top.pl catalogue_out.pl catalogue_stats.pl dictionary.pl issues_avg_stats.pl issues_stats.pl itemslost.pl manager.pl reports-home.pl serials_stats.pl stats.print.pl Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:44:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:44:04 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20015-70-FFlprHAgji@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70658|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70898&action=edit Bug-20015: use Modern::Perl in Serials perl script Test plan: Check that use strict; use warnings; doesn't exist in the following files and use Modern::Perl; is written instead. acqui-search-result.pl acqui-search.pl checkexpiration.pl reorder_members.pl routing-preview.pl routing.pl serials-collection.pl serials-edit.pl subscription-add.pl subscription-bib-search.pl subscription-renew.pl viewalerts.pl Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:47:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:47:36 +0000 Subject: [Koha-bugs] [Bug 20016] use Modern::Perl in svc scripts In-Reply-To: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20016-70-NMYzhaA3WK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70671|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70899&action=edit Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins svc scripts authentication bib bib_profile checkouts config/systempreferences import_bib new_bib https://bugs.koha-community.org/show_bug.cgi?id=20016 Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:50:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:50:31 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20017-70-BfU6UNnU1c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70664|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70900&action=edit Bug-29917: use Modern::Perl in Tools perl scripts Test plan: Check that the following files don't contain use strict; use warnings; and have use Modern::Perl instead. background-job-progress.pl batchMod.pl copy-holidays.pl exceptionHolidays.pl holidays.pl import_borrowers.pl koha-news.pl letter.pl manage-marc-import.pl newHolidays.pl overduerules.pl quotes-upload.pl quotes.pl quotes/quotes-upload_ajax.pl quotes/quotes_ajax.pl scheduler.pl stage-marc-import.pl upload-cover-image.pl Also the credits have been added to newHolidays.pl https://bugs.koha-community.org/show_bug.cgi?id=20017 Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:52:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:52:49 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20018-70-fcxpG9obGx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70674|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70901&action=edit Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins perl scripts enqueue_koc.pl list.pl process.pl process_koc.pl service.pl https://bugs.koha-community.org/show_bug.cgi?id=20018 Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:52:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:52:44 +0000 Subject: [Koha-bugs] [Bug 20018] use Modern::Perl in offline circulation perl scripts In-Reply-To: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20018-70-yr440xN4ae@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:53:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:53:27 +0000 Subject: [Koha-bugs] [Bug 20017] use Modern::Perl in Tools perl scripts In-Reply-To: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20017-70-78jbNsH5in@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:53:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:53:50 +0000 Subject: [Koha-bugs] [Bug 20015] use Modern::Perl in Serials perl scripts In-Reply-To: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20015-70-YAwyguxuT7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:59:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:59:16 +0000 Subject: [Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts In-Reply-To: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20019-70-o4YDb2ufp0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 19:59:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 18:59:33 +0000 Subject: [Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts In-Reply-To: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20019-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20019-70-fdPKwEXh7O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70712|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70902&action=edit Bug-20019 - use Modern::Perl in misc perl scripts Test Plan: Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; services/itemrecorddisplay.pl suggestion/suggestion.pl tags/list.pl tags/review.pl virtualshelves/sendshelf.pl help.pl changelanguage.pl koha_perl_deps.pl debian/bd-to-depends debian/build-git-snapshot debian/list-deps docs/CAS/CASProxy/examples/koha_webservice.pl docs/CAS/CASProxy/examples/proxy_cas.pl docs/CAS/CASProxy/examples/proxy_cas_callback.pl docs/CAS/CASProxy/examples/proxy_cas_data.pl Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:02:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:02:11 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20020-70-jm7HSXL0J1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:02:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:02:14 +0000 Subject: [Koha-bugs] [Bug 20020] use Modern::Perl in XT scripts In-Reply-To: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20020-70-SEiv8zJjEN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70673|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Created attachment 70903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70903&action=edit Bug 20020: use Modern::Perl in XT scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; author/podcorrectness.t author/show-template-structure.pl author/translatable-templates.t author/valid-templates.t find-license-problems fix-old-fsf-address single_quotes.t verify-debian-docbook.t Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:12:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:12:45 +0000 Subject: [Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts In-Reply-To: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20022-70-icoTBbU2W5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Appears to be missing 'use Modern::Perl;' in: t/Barcodes_annual.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:36:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:36:22 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-aFoaKWeflI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 NancyK. <nkeener at washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nkeener at washoecounty.us Priority|P5 - low |P1 - high --- Comment #6 from NancyK. <nkeener at washoecounty.us> --- We are getting more of these multiple in-transits happening. The item is never in any of the indicated locations. A real scrambled mess. NancyK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:41:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:41:39 +0000 Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4319-70-557fLcyRCV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Maksim <maksim.sen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:43:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:43:56 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-NW3eOFwP9P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70854|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70904&action=edit Bug 18336: Full stack tests for supplemental UTF-8 chars This patch introduces tests for Koha's support for 4-byte supplemental UTF-8 chars. encoding/decoding tools handle this gracefuly. The missing piece is the MySQL DB backend. The tests in this patch: - Adds a couple records for each flavour (MARC21 and UNIMARC) so search_utf8.t tests 4-byte chars are handled correctly - Adds emoji testing in auth_values_input_www.t To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => FAIL: It should fail if the DB hasn't been migrated into using utf8mb4 Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:44:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:44:00 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-bttfKzajp6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70855|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70905&action=edit Bug 18336: SET NAMES utf8mb4 in Koha::Database Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:44:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:44:05 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-3qnoRtv1zg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70856|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70906&action=edit Bug 18336: Convert schema from utf8 to utf8mb4 This patch adapts the DB structure so it uses utf8mb4 encoding and utf8mb4_generic_ci collation. Indexes for columns of type VARCHAR with prefix lenght higher than 191 are shortened because of the smaller max index lenght for utf8mb4 Note: please beware that testing this patchset risks your data and the patchset includes reinitializing the DB. To test: - Be on the master branch - Have a clean DB: $ reset_all (y) - Apply the first patch (Unit tests) - Run: $ kshell k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => FAIL: Tests fail because Koha doesn't support supplemental (UTF-8) chars. - Apply the rest of this patchset - Upgrade the schema: $ kshell k$ perl installer/data/mysql/updatedatabase.pl - Run the tests: k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => SUCCESS: Tests pass! - Now start from a clean DB - Run: $ reset_all (y) - Run the tests: k$ prove t/db_dependent/www/search_utf8.t \ t/db_dependent/www/auth_values_input_www.t => SUCCESS: Tests pass! Verify you can use emojis all over the place (MARC records, AV descriptions, etc). Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:44:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:44:09 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-xCf8vE1EXI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70857|0 |1 is obsolete| | --- Comment #15 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70907&action=edit Bug 18336: DBIC update Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:44:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:44:12 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-gAmzjyyM9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70858|0 |1 is obsolete| | --- Comment #16 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70908&action=edit Bug 18336: Atomic update Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:44:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:44:15 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-2DZTMCkbwy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70859|0 |1 is obsolete| | --- Comment #17 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70909&action=edit Bug 18336: Add explicit index names to kohastructure.sql This patch just adds an explicit index name to the search_marc_map table. The atomicupdate on this patchset is a good example of why we better have them. Sponsored-by: Hotchkiss School Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 20:45:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 19:45:37 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-fQQb3XWd08@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from M. Tompsett <mtompset at hotmail.com> --- Followed test plan. Also added a patron with emojis in so many fields, including username and password! And the patron was able to log in with emojis! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 21:10:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 20:10:56 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-tmEv2xBe8A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Maksim <maksim.sen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 21:59:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 20:59:25 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search (histsearch.pl) In-Reply-To: <bug-17457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17457-70-2suMNnXlBH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 David Bourgault <david.bourgault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 21:59:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 20:59:29 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search (histsearch.pl) In-Reply-To: <bug-17457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17457-70-WfJrz8Kkhd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 --- Comment #11 from David Bourgault <david.bourgault at inlibro.com> --- Created attachment 70910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70910&action=edit Bug 17457 - Add tests for each marc flavour + Added a `run_flavoured_tests` sub that runs for each MARC flavour * Moved SearchWithISBNVariation tests to the new sub I copied a lot of the necessary utility functions over Biblio.t (as of Jonathan's suggestion). I also tried to name and organize the code in such a way that it can be reused if anyone else needs to run "flavoured" tests in the future. prove t/db_dependant/Acquisition.t OK QA tool green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 22:37:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 21:37:46 +0000 Subject: [Koha-bugs] [Bug 19122] IncludeSeeFromInSearches is broken In-Reply-To: <bug-19122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19122-70-9fu6NmDVlq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19122 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #12 from Barton Chittenden <barton at bywatersolutions.com> --- Does this fix the combination of sysprefs documented in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715#c2 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 24 23:38:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jan 2018 22:38:54 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-9PkhzsaMU6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow the use of emojis as |Add emoji picker to tag |tags on records |entry in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 02:50:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 01:50:54 +0000 Subject: [Koha-bugs] [Bug 20080] Test for utf8mb4 encoding and collation In-Reply-To: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20080-70-4EwvrSoilC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Lacks test plan, and I did try to figure it out. I figure something about prove t/Perl.t in qa-test-tools, but I think there is a data/4/sql and/or data/5/sql file which may affect this, but I keep getting failures. I'm not sure what I'm doing wrong. Easier for you to explain how to prove this works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 09:15:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 08:15:49 +0000 Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines In-Reply-To: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20086-70-651pJZkJa7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #2) > What if we are already in a transaction? Several unit tests include a call > to AddRenewal.. Should not be a problem for DBIx. Only the outer transaction will commit. Use of txn_do is recommended. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 10:24:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 09:24:18 +0000 Subject: [Koha-bugs] [Bug 18696] Change debian/source/format to quilt In-Reply-To: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18696-70-dM1t55QNKK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 10:26:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 09:26:21 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.05.x) In-Reply-To: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17111-70-eBKkbzHDdE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #37 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 10:28:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 09:28:24 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19318-70-W7JUJ8CTvG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Hi Kyle, Do you know if someone is working on that ? Because I will be working on something similar, that is a way to choose between several "storage spaces", eventually a subdirectory in that storage space, and other options like keeping the original name and using another URL to access those files. But I think that the configuration of those storage spaces should not happen in authorised values, but on the server ($KOHA_CONF probably) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 10:29:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 09:29:12 +0000 Subject: [Koha-bugs] [Bug 19429] No confirm message when deleting an invoice from invoice search In-Reply-To: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19429-70-gr9m2GnEXH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 10:31:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 09:31:33 +0000 Subject: [Koha-bugs] [Bug 19401] No confirm message when deleting an invoice from invoice detail page In-Reply-To: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19401-70-pRXZ1GCIt8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 10:36:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 09:36:22 +0000 Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff client menu bar In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19851-70-qVuOtkFp0R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- This looks more like enhancement to me. BTW I will wait for Bug 20051 to decide if I backport to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 10:54:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 09:54:56 +0000 Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19560-70-O73msFPo1h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #31 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 10:56:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 09:56:16 +0000 Subject: [Koha-bugs] [Bug 19914] Cannot locate the "Delete" in the library list table In-Reply-To: <bug-19914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19914-70-peK28upjuN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19914 --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 10:57:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 09:57:43 +0000 Subject: [Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P) In-Reply-To: <bug-18417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18417-70-fPCUV3G8VX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417 --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 11:39:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 10:39:42 +0000 Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19875-70-qtJ5au6bgc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 --- Comment #5 from Christophe Croullebois <christophe.croullebois at biblibre.com> --- (In reply to Roch D'Amour from comment #4) > I applied the patch, searched for results with a "&" in the title, and > subscribed to the RSS feed. The feed show up, but I only get entrys up > untill the records with the "&" in the title. After this records, nothing > else show up. I followed the test plan, and I was wondering what do you > meant by "subscribe is ok | nok"? Hello, what you describe is the result without patch =>nok Effectively if you have 10 result in the search and if a title with "&" is in the row 5, you'll see only the 5 firt rows. After applying the patch you'll see the 10 result and your subscribe must be ok (you can see links active in your browser). Hoping be clearer. Thx for your test Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 11:49:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 10:49:08 +0000 Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19875-70-qLQI2r73vo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Christophe Croullebois <christophe.croullebois at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70155|0 |1 is obsolete| | --- Comment #6 from Christophe Croullebois <christophe.croullebois at biblibre.com> --- Created attachment 70911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70911&action=edit Bug 19875: escape & in rss feed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 11:58:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 10:58:36 +0000 Subject: [Koha-bugs] [Bug 14138] Patroncard: Warn user if PDF creation fails In-Reply-To: <bug-14138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14138-70-VfyyyCZQ6y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #12 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Oh, a follow up patch got forgotten ;) http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=patroncards/create-pdf.pl;hb=7e1c6dddde372f622cc88f993f72b8f81d0b6252#l66 ?#Note fo bug 14138: Indenting follows in separate patch to ease review? I'm not sure it's worth doing anything about this. This is a notification just in case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 12:04:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 11:04:01 +0000 Subject: [Koha-bugs] [Bug 20088] New: Use of uninitialized value in array element in svc/holds Message-ID: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20088 Bug ID: 20088 Summary: Use of uninitialized value in array element in svc/holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Resolve: Use of uninitialized value in array element at svc/holds line 56. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 12:16:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 11:16:57 +0000 Subject: [Koha-bugs] [Bug 20088] Use of uninitialized value in array element in svc/holds In-Reply-To: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20088-70-VK2sDHUEgu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20088 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70912&action=edit Bug 20088: Fix uninitialized warning from svc/holds Use of uninitialized value in array element at svc/holds line 56. Test plan: Check if the warn is no longer in the logs; the warning is triggered by an ajax call from the circulation template in staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 12:16:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 11:16:54 +0000 Subject: [Koha-bugs] [Bug 20088] Use of uninitialized value in array element in svc/holds In-Reply-To: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20088-70-fsmZlnrcst@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20088 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 12:21:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 11:21:52 +0000 Subject: [Koha-bugs] [Bug 20088] Use of uninitialized value in array element in svc/holds In-Reply-To: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20088-70-gkT6mDr7N5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20088 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 14:33:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 13:33:47 +0000 Subject: [Koha-bugs] [Bug 20089] New: Does Koha::Database->schema always return a connected object? Message-ID: <bug-20089-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20089 Bug ID: 20089 Summary: Does Koha::Database->schema always return a connected object? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org My log says no: DBD::mysql::st execute failed: MySQL server has gone away [for Statement "SELECT `me`.`variable`, `me`.`value`, `me`.`options`, `me`.`explanation`, `me`.`type` FROM `systempreferences` `me` WHERE ( `me`.`variable` = ? )" with ParamValues: 0='opacgroupresults'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. I see them quite often, always for preferences. Note that we do not test the cached $database->{schema} in sub schema. If we do, we will however add some time. ( 0.0043 instead of 0.0003 ) What do you think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 14:39:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 13:39:12 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error In-Reply-To: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20084-70-alrZWZlLXE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 14:40:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 13:40:21 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error In-Reply-To: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20084-70-Imisc61Z3F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Thanks Fridolin :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 14:41:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 13:41:24 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20084-70-zmWsIQJOey@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron card creator: |Patron card creator: |layout: Industrial2of5 |layouts Industrial2of5 and |broken with "Invalid |COOP2of5 broken with error |Characters" error |"Invalid Characters" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 14:41:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 13:41:43 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-exc3cdIvMK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Blou <philippe.blouin at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com, | |philippe.blouin at inlibro.com --- Comment #149 from Blou <philippe.blouin at inlibro.com> --- Hello David, We'd be interested in testing ( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 14:46:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 13:46:06 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20084-70-jDSScH1Fbw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #4 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70913&action=edit Bug 20084: fix Industrial2of5 and COOP2of5 patron card layouts == Test plan == This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working...) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 9. Layout: set "Barcode type:" to COOP2of5 10. Export the batch 11. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 12. Apply this patch 13. Retry with both non-working patches 1. You should have a white page with a barcode 2. And no errors in the relevant log file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 14:53:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 13:53:57 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-yecilphSVi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #150 from Blou <philippe.blouin at inlibro.com> --- We're interested in testing. In fact, we'd need this ASAP for one of our client. So David, if you're around, you'll get some testing starting.... as soon as we can apply it. We're getting a SHA1 on the first patch, whoever tries to apply it here. So maybe if you have no signoff it would be a good opportunity to rebase and squash a few patches. We stand ready, today or tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 15:19:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 14:19:54 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20084-70-i9W3FdSgFc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- == Going further, not confirmed or not fixed here == Someone interested might want to check issues with 2 other types. 1. "Code 39 + Modulo10" doesn't seem to work Although "Code 39" and "Code 39 + Modulo43" work. Might be my test setup. 2. EAN13 barcodes doesn't seem to work. C4::Patroncards::Patroncard->draw_barcode() has an if-elsif for all types but EAN13. C4/Labels/Label.pm has an elsif for EAN13 This is suspicious! I tried to the copy it to Patroncard but got an Invalid Length error. With the quick solution falling and having no idea what was I doing, Ctrl-Z was spammed and these regretful words were written. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 16:05:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 15:05:34 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20084-70-7hT92NqOeW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70913|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 70914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70914&action=edit Bug 20084: fix Industrial2of5 and COOP2of5 patron card layouts == Test plan == This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working...) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 9. Layout: set "Barcode type:" to COOP2of5 10. Export the batch 11. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 12. Apply this patch 13. Retry with both non-working patches 1. You should have a white page with a barcode 2. And no errors in the relevant log file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 16:09:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 15:09:16 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20084-70-NmqvAN7u9x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Fixed quotes not needed anymore "*$params{barcode_data}" ? $params{barcode_data} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 16:22:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 15:22:26 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-6cysVNxk2q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 16:22:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 15:22:33 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-QDNcPwePyu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #10 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70916&action=edit [SIGNED-OFF] Bug 19474 [follow-up] Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 16:22:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 15:22:29 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-ptActk9QRx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68211|0 |1 is obsolete| | Attachment #69197|0 |1 is obsolete| | Attachment #70315|0 |1 is obsolete| | --- Comment #9 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70915&action=edit [SIGNED-OFF] Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 16:22:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 15:22:36 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-kHVxqsQLHZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #11 from Claire Gravely <claire_gravely at hotmail.com> --- Created attachment 70917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70917&action=edit [SIGNED-OFF] Bug 19474 (Follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 17:28:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 16:28:29 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-Hin7nB0eNz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70705|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 17:28:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 16:28:11 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-w6TBZzMy2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #42 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 17:28:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 16:28:35 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-j6gbUJhJzu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 17:28:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 16:28:46 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-AmGJCYThdD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #43 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 70918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70918&action=edit Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list The goal to this enhancement is to add the ability to cancel a hold and mark items as lost from the 'Holds to pull' page. A new pref is added to control the behaviour, default is off To mark items as lost you need to set the new pref CanMarkHoldsToPullAsLost to one of these two values: - "Allow to mark items as lost" => The item will be marked as lost and the hold will be cancelled - "Allow to mark items as lost and notify the patron" => Same as previously but the patron will be notified as well. The notification is done using a new notice template (code=CANCEL_HOLD_ON_LOST). Feel free to suggest another default wording. To update the values of the items when one of these 2 buttons are used, you need to fill the UpdateItemWhenLostFromHoldList with something like: 'itemlost: 1' Test plan: 1/ Place holds on some items 2/ Go to Home > Circulation > Holds to pull >From here you can cancel the hold or 3/ Mark the items as lost => You will receive feedback messages depending on different situations: * The CANCEL_HOLD_ON_LOST does not exist * The patron does not have an email address (but the notice has been enqueued! It is the current behaviour with other notices) * The notice has been enqueued * The hold has been cancelled QA Notes: >From which library do we want to pick the notice? This patch use reserves.branchcode Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 17:28:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 16:28:49 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-A50YC31OfT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 --- Comment #44 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 70919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70919&action=edit Bug 19287: Fix conflict with bug 19304 Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 17:38:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 16:38:18 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-Z1dVYt2MVf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 18:07:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 17:07:35 +0000 Subject: [Koha-bugs] [Bug 20090] New: Missing Script Statement for Novelist Select on Some Record Displays in OPAC Message-ID: <bug-20090-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 Bug ID: 20090 Summary: Missing Script Statement for Novelist Select on Some Record Displays in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: techservspec at gmail.com QA Contact: testopia at bugs.koha-community.org This applies to libraries using Novelist Select enhanced content in their OPAC. Items with a UPC code but no ISBN are causing a script error (a call to an undefined function) in the opac-detail display. This is preventing custom jQuery/scripts from running (as well as keeping any content from Novelist from displaying). The cause: Not all of the conditionals for Novelist in opac-detail.tt are checking for UPCs, most notably the statement that adds the script for using Novelist. This can result in calls to non-existent functions. To test (note that you must subscribe to Novelist Select): 1. If your library does not use the patron ratings feature, activate it for the purposes of this test. 2. Display a record in the opac that has an ISBN number. Note that the rating option has 5 stars to choose from. 3. Display a record that does not have an ISBN in the 020 field, but has a upc (or other code) in the 024 field. The rating option will display as 5 radio buttons and a "rate it" button (the radio buttons are normally replaced by stars via a built-in jQuery script). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 18:29:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 17:29:17 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: <bug-20090-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20090-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20090-70-3RuWMppn7z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 David Kuhn <techservspec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 18:29:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 17:29:19 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: <bug-20090-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20090-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20090-70-Vgz5G9WNnK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 --- Comment #1 from David Kuhn <techservspec at gmail.com> --- Created attachment 70920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70920&action=edit Bug 20090 - Missing Script Statement for Novelist Select on Some Record Displays in OPAC This patch adds a check for UPCs and well as ISBNs to the Novelist Select conditionals in opac-detail.tt To test (note that you must subscribe to Novelist Select): 1. If your library does not use the raton ratings feature, activate it for the purposes of this test. 2. Display a record that does not have an ISBN in the 020 field, but has a upc (or other code) in the 024 field. The rating option will display as 5 radio buttons and a "rate it" button. 3. Apply the patch. 4. Display the same record again. The radio buttons will be replaced with stars. This indicates that the scripts on the page completed. Rather that using the patron ratings as in indicator, you can also use a web page inspector/debugger such as firebug or the built-in inspectors in most newer browsers to check for script errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 18:30:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 17:30:25 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: <bug-20090-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20090-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20090-70-gJab7wIbCd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 David Kuhn <techservspec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 18:31:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 17:31:25 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-BSTF8SsJ0A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #60 from David Gustafsson <glasklas at gmail.com> --- Have discovered several serious issues with the current patch in this issue, so do not recommend that any one uses it or re-roll it against master. My personal view is that the current approach is based on some invalid assumptions (that positions of fields in marc is stable and carry significance for example). Have rewritten most of the core logic, and could perhaps submit it here when cleaned up. But for our needs (Gothenburg University Library) I'm not sure we want to get this in to Koha, but instead refactor and use as a plugin, but because of time-constraints I'm not sure will have time to submit the code for at least a couple of weeks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 19:27:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 18:27:55 +0000 Subject: [Koha-bugs] [Bug 14237] allow bibs to be added to course without items In-Reply-To: <bug-14237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14237-70-CDAL8MuzU5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Amber Hunt <amber at marlboro.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amber at marlboro.edu --- Comment #3 from Amber Hunt <amber at marlboro.edu> --- This would be so helpful for our library as well. We have items records for many of electronic resources, but they do not have barcodes so I have to add a fake barcode to add them to course reserves. It be similar to the "Add to" option for Cart and List that is available through the detailed record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 20:05:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 19:05:51 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-NnKmG7rS0h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 20:26:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 19:26:33 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17168-70-PHkt5PQ4Jb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 20:26:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 19:26:37 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17168-70-yix4WJPgha@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60665|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70921&action=edit Bug 17168 - Add a command line script for updating patron category based on status This patch adds a new script update_patrons_category.pl which allows for updating patron categories in a batch upon meeting provided criteria. This script additionally can replace j2a.pl. To test: 1 - perl update_patrons_category.pl -h 2 - Ensure help text makes sense and covers all options 3 - Test converting patrons supplying only fromcat and tocat perl update_patrons_category.pl -f PT -t J -v --confirm perl update_patrons_category.pl -f J -t PT -v --confirm 4 - All patrons should have been switched to and from Juveniles 5 - Try without --confirm switch perl update_patrons_category.pl -f PT -t J -v 6 - Should list all patrons but not update 7 - Set the age for juvenile patrons to be outside the range provided in categories (or set the upper age limit for juveniles to '2') 8 - Test with verbosity and with without --confirm perl update_patrons_category.pl -f J -a -t PT -v perl update_patrons_category.pl -f J -a -t PT -v --confirm 9 - Repeat above and verify linked/unlinked guarantors are removed in above scenario 10 - Test various fine and registration limits 11 - Test matching on specific fields i.e. --field surname=acosta 12 - Sign off Sponsored by: Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 20:31:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 19:31:14 +0000 Subject: [Koha-bugs] [Bug 15678] Make pickup branch editable on holds tab on circulation/patron detail screens In-Reply-To: <bug-15678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15678-70-9PI72fP8ly@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15678 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com --- Comment #2 from Jessie Zairo <jzairo at bywatersolutions.com> --- This is still valid in 17.05.06 and 17.11.01. If you attempt to update the pickup branch via the Holds tab in Patron details (moremember.pl) you receive a dialogue box of: There was an error: error Method Not Allowed.. The work around is you can change the pickup location in request.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 20:31:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 19:31:43 +0000 Subject: [Koha-bugs] [Bug 15678] Make pickup branch editable on holds tab on circulation/patron detail screens In-Reply-To: <bug-15678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15678-70-m9VyFApb94@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15678 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 25 20:32:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jan 2018 19:32:05 +0000 Subject: [Koha-bugs] [Bug 15678] Make pickup branch editable on holds tab on circulation/patron detail screens In-Reply-To: <bug-15678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15678-70-3upoAtW9qx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15678 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 01:19:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 00:19:50 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: <bug-20090-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20090-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20090-70-h6rrFgoHm9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |techservspec at gmail.com CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 02:09:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 01:09:07 +0000 Subject: [Koha-bugs] [Bug 20088] Use of uninitialized value in array element in svc/holds In-Reply-To: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20088-70-NXqKuUta8a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20088 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 02:09:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 01:09:09 +0000 Subject: [Koha-bugs] [Bug 20088] Use of uninitialized value in array element in svc/holds In-Reply-To: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20088-70-0lwGGhHddR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20088 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70912|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70922&action=edit Bug 20088: Fix uninitialized warning from svc/holds Use of uninitialized value in array element at svc/holds line 56. Test plan: Check if the warn is no longer in the logs; the warning is triggered by an ajax call from the circulation template in staff. -- that's the patron details page when the patron has a hold. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 02:24:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 01:24:12 +0000 Subject: [Koha-bugs] [Bug 20070] autoBarcode Increment Value In-Reply-To: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20070-70-FDC7qbfIR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20070 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Version|master |17.05 Severity|major |normal --- Comment #1 from Liz Rea <liz at catalyst.net.nz> --- Hi, I'm not able to reproduce this problem in current Master. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 02:25:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 01:25:44 +0000 Subject: [Koha-bugs] [Bug 20064] Cannot place a hold for any student In-Reply-To: <bug-20064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20064-70-oOkfIuKVSs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20064 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |liz at catalyst.net.nz Resolution|--- |INVALID --- Comment #2 from Liz Rea <liz at catalyst.net.nz> --- Hi, I wasn't able to reproduce this problem with correctly configured circulation rules. Be sure to check the rules for all branches, including the default rules. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 02:45:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 01:45:46 +0000 Subject: [Koha-bugs] [Bug 20057] Auto-approve option for borrower modifications In-Reply-To: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20057-70-ZogR7Qh4tC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70790|0 |1 is obsolete| | --- Comment #3 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 70925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70925&action=edit Bug 20057 - Syspref for auto approval of patron profile changes Testplan for this patch: 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. Signed-off-by: Liz Rea <liz at catalyst.net.nz> This works, we may want some different text for this situation in the OPAC, it still says the librarian has to approve the change. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 02:45:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 01:45:54 +0000 Subject: [Koha-bugs] [Bug 20057] Auto-approve option for borrower modifications In-Reply-To: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20057-70-i7pN3pc9Pt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #4 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 70926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70926&action=edit Bug 20057 - followup - add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 02:50:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 01:50:13 +0000 Subject: [Koha-bugs] [Bug 20057] Auto-approve option for borrower modifications In-Reply-To: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20057-70-ozh43mGjdx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70926|0 |1 is obsolete| | Attachment #70926|1 |0 is patch| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 02:51:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 01:51:18 +0000 Subject: [Koha-bugs] [Bug 20057] Auto-approve option for borrower modifications In-Reply-To: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20057-70-YLZUQsRPf0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #5 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 70927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70927&action=edit Bug 20057 - followup - add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 02:51:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 01:51:20 +0000 Subject: [Koha-bugs] [Bug 20070] autoBarcode Increment Value In-Reply-To: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20070-70-yOfAJunHTj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20070 --- Comment #2 from mustaqeem <mustaqeemabd at gmail.com> --- I try use Koha demo(https://koha-community.org/demo/) by ByWater Solution also happen like that. If the code is numeric or alphanumeric, it will not increase. (e.g the first barcode is 000118010001 or LIB118010001, the number will be same for other items.) The other thing we found is if we have few branches (e.g ABC, DEF), barcode number will be like ABC18010001, ABC18010002, DEF18010003, DEF18010004, ABC18010005 (is it ok for DEF branch to start the barcode like that or it is suppose to start at 0001 for each branch?) Thank you. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 03:03:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 02:03:04 +0000 Subject: [Koha-bugs] [Bug 20041] ILL module missing from more menu in staff when activated In-Reply-To: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20041-70-QUSG57oyNW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 03:03:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 02:03:07 +0000 Subject: [Koha-bugs] [Bug 20041] ILL module missing from more menu in staff when activated In-Reply-To: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20041-70-lHPPINjvHe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 --- Comment #1 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 70928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70928&action=edit Bug 20041 - ILL module missing from more menu in staff when activated Apply this patch Check that ILL requests are now listed in More menu when ILL requests syspref is enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 03:30:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 02:30:55 +0000 Subject: [Koha-bugs] [Bug 10775] Create humans.txt from the history document In-Reply-To: <bug-10775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10775-70-N0KjDzHV2g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10775 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 03:35:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 02:35:58 +0000 Subject: [Koha-bugs] [Bug 14987] patron card creator not displaying correct cardnumber In-Reply-To: <bug-14987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14987-70-Qo6aT0rB6Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 03:38:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 02:38:01 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-mO44q7BFnw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- TEST PLAN --------- 0) Back up database as desired. 1) Run the following commands: $ kshell k$ ./misc/maintenance/cmp_sysprefs.pl -cmd backup -file ~/sysprefs.bak 2) Go to the local tab of the system preferences in the staff client. 3) Reduce the last digit of version by one and save -- it will force you into an upgrade screen login. -- Don't upgrade! 4) Run the following commands: k$ ./misc/maintenance/cmp_sysprefs.pl -cmd compare -file ~/syspref.bak -upd -- Warning encountered from comment #0. 5) Run the following commands: k$ exit $ git bz apply 20056 $ kshell k$ ./misc/maintenance/cmp_sysprefs.pl -cmd compare -file ~/syspref.bak -upd k$ exit -- Warning was silenced. 6) Either restore db or reset_all 7) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 03:39:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 02:39:27 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-V0x88jLrUk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 03:39:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 02:39:30 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-V0orfYHCe0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70789|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70930&action=edit Bug 20056: Resolve uninitialized warn in cmp_sysprefs.pl When running a compare with --upd flag, I got the following warn: Use of uninitialized value in addition (+) at misc/maintenance/cmp_sysprefs.pl line 125. This is simply resolved by not returning undef but 0 in case of the Version syspref in the sub UpdateOnePref. Test plan: Look at this simple change. See comment #2 for fuller test plan. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 04:35:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 03:35:57 +0000 Subject: [Koha-bugs] [Bug 20066] Remove forbidden patterns from .inc and .tt files In-Reply-To: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20066-70-0cv85fKguZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Bug 20053 removed the javascript type, and yet, this keeps it. It does not apply in any order. Please fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 07:29:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 06:29:19 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-TPR3yCo4Z6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to M. Tompsett from comment #3) > See comment #2 for fuller test plan. > Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Thanks ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 07:47:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 06:47:31 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19985-70-UOX4dQVtUQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Passed QA --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3) > Trivial, skipping QA. Please adjust status if you do so. This has been pushed while still in the signoff queue. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 07:47:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 06:47:46 +0000 Subject: [Koha-bugs] [Bug 19985] TestBuilder.t fails if default circ rule exists In-Reply-To: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19985-70-P69MelUd84@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:24:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:24:18 +0000 Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use biblio_metadata.timestamp In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19730-70-69LiTXOIDV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:24:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:24:21 +0000 Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use biblio_metadata.timestamp In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19730-70-B71L8Aq5vX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70852|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70932&action=edit Bug 19730: Use biblio_metadata.timestamp in export_records.pl Since bug 17196, biblioitems.timestamp is not always updated after a change in the MARC record. Filtering should be based on biblio_metadata.timestamp instead. REVISED TEST PLAN ----------------- 0. Do not apply patch 1. Find a biblio record, remember the biblionumber for step 3 2. Edit the record, modify a field (e.g. 003, 015$q) that is not mapped to a DB column, so biblio_metadata.timestamp will be modified but not biblioitems.timestamp 3. In MySQL with the koha database selected: > select timestamp from biblio where biblionumber=###; > select timestamp from biblio_metadata where biblionumber=###; -- you'll need to change the ###'s based on the biblionumber you remembered in step 1. -- the two timestamps will differ. -- Remember the timestamp of biblio_metadata for step 4. 4. Run this command: $ sudo koha-shell -c bash kohadev $ export DATE="YYYY-MM-DD HH:mm:SS" -- use the timestamp remembered in step 3. 5. Run this command: $ ./misc/export_records.pl --date="$DATE" $ ls -la koha.mrc -- the file should be 0 bytes. 6. Run this command: $ exit $ git bz apply 19730 $ restart_all $ sudo koha-shell -c bash kohadev $ export DATE="YYYY-MM-DD HH:mm:SS" -- use the timestamp remembered in step 3. 7. Run this command: $ ./misc/export_records.pl --date="$DATE" $ ls -la koha.mrc -- the file should be a lot more than 0 bytes. 8. Run this command: $ /home/vagrant/qa-test-tools/koha-qa.pl -v 2 -c 1 -- this should pass. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:24:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:24:34 +0000 Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use biblio_metadata.timestamp In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19730-70-JoO79oXFaO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:35:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:35:54 +0000 Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course reserves In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19230-70-BaSh2UTNE7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:35:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:35:57 +0000 Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course reserves In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19230-70-XvwJu3U8Yl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70780|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70933&action=edit Bug 19230: Preventing warn when deleting course To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves, create a course 3) When you are taken to the course page, you should notice the 'Argument "" isn't numeric in numeric gt' warn 4) Delete course 5) Notice warn, and that no confirm message popped up 6) Apply patch 7) Create a course again. Confirm the 'Argument "" isn't numeric in numeric gt' warn did not show 8) Delete the course 9) Notice no warn and the confirm message pops up Sponsored-by: Catalyst IT Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:36:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:36:10 +0000 Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course reserves In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19230-70-Vp352B3CfE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:43:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:43:42 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-sGsWBvTxAV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70850|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70934&action=edit Bug 19975: Fix search by tags at the OPAC This bug has certainly be caused by commit 091d6c513bcbee224ff06477e79be48cea7fe825 Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes The reason is quite simple, in Koha::ItemType->translated_description (called in opac-search.pl l.229) there is an eval to know if we have access to the translated description of the item type, to avoid retrieving it again. The evaluation of $@ later in opac-search.pl is supposed to test the 2 eval made few lines before (a "normal" search, without tags), but $@ contains the error message from the *last* eval command. So we are raising an error that have been correctly handled in Koha::ItemType. Test plan: At the OPAC, click Tag cloud, then click any of the tags => Without the patch you get Koha::ItemType::get_column generated this error: DBIx::Class::Row::get_column(): No such column 'translated_description' on Koha::Schema::Result::Itemtype at /usr/share/koha/lib/Koha/Object.pm line 307 => With the patch applied the page is correctly displayed Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:43:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:43:56 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-xJxfXSPp9U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:44:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:44:32 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-odJpagOlAn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:54:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:54:11 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-PM83T1YWYT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:54:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:54:15 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-Bo4TdZF1hF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70449|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70935&action=edit Bug 19522: Coding style: Fix alignement after previous patch Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:54:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:54:20 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-DFYlN5LOA2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70450|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70936&action=edit Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unit?s" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unit?s" dropdown with french units Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:54:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:54:25 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-qCkunxsOaO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70451|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70937&action=edit Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:54:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:54:30 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-S4eca2NfiS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70452|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70938&action=edit Bug 19522: Label creator: translate empty list message The name of the element wasn't translated in the message. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. ensure that the list is empty 4. then you should see "pas de Batches actuellement" 5. then you should see "cr?er un nouveau batch." 6. apply this patch 7. install the language 8. refresh the page 9. then you should see "pas de Lots actuellement" 10. then you should see "cr?er un nouveau lot ." Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:54:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:54:34 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-o017tkBiZO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70453|0 |1 is obsolete| | --- Comment #60 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70939&action=edit Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. install the fr_FR locale 8. refresh the page 9. then you should see "Cote" in the column names Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:54:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:54:39 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-m69WtMbbYO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70454|0 |1 is obsolete| | --- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70940&action=edit Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des ?tiquettes" Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 08:55:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 07:55:00 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-7jAdXaT0CI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |m.de.rooy at rijksmuseum.nl QA Contact|kyle at bywatersolutions.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 09:16:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 08:16:53 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-PUyC4ZyX87@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 09:33:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 08:33:55 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-qsf3aztsxq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Josef Moravec <josef.moravec at gmail.com> --- Sorry, one more thing: When a patron has adult category, the "Update child to adult patron" looks disabled, but you can click on it, you get a dialog asking you if you want to update the child, and if you click OK, there is internal server error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 10:15:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 09:15:51 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18198-70-HFAIskpD0l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 10:15:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 09:15:54 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18198-70-xcQTAikch8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68170|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 70941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70941&action=edit Bug 18198: MARC21: Further improve handling of 5XX$u in GetMarcNotes Bug 14306 only handled field 555 in MARC21 as an URI. But a lot of other 5XX fields have a $u subfield for URIs; actually $u is not used in any other way. This patch generalizes the change made for 555 and extends it to all 5XX $u. Test plan: [1] Run t/Biblio.t [2] Run t/db_dependent/Biblio.t [3] Edit a MARC21 record. Add a URL into 505u, 520u, 555u. [4] Check presentation on opac-detail (tab Title notes) [5] Check presentation on catalogue/detail (tab Descriptions) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 10:16:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 09:16:48 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18198-70-tc9LDnXoPb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Josef Moravec from comment #4) > Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Great -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 10:26:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 09:26:50 +0000 Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron category report In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19669-70-LT32gMEcKR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #14 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Link for reports/itemtypes.plugin is stil in staff:/cgi-bin/koha/reports/reports-home.pl with the name "Catalog by itemtype" New bug for this or do we use the current one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 10:29:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 09:29:59 +0000 Subject: [Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API In-Reply-To: <bug-16213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16213-70-K7AaEVZWhp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 10:30:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 09:30:03 +0000 Subject: [Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API In-Reply-To: <bug-16213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16213-70-7gdAKMMok5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68179|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 70942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70942&action=edit Bug 16213: Allow to select hold's itemtype when using API Test plan: 1/ Use your usual "REST testing" tool to place a title-level hold with an itemtype. The request should look like this: POST /api/v1/holds { "borrowernumber": 1234, "biblionumber": 456, "branchcode": "CPL", "itemtype": "A" } 2/ Check that the hold was placed and the itemtype is correctly selected 3/ prove t/db_dependent/api/v1/holds.t Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 10:30:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 09:30:06 +0000 Subject: [Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API In-Reply-To: <bug-16213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16213-70-kppf540VUs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 --- Comment #8 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 70943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70943&action=edit Bug 16213: (QA follow-up) Fix terminology Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 10:58:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 09:58:45 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-C5JIgqmbS7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 11:00:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 10:00:07 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-l42ZAHNzAC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 11:00:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 10:00:11 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-ImmVY782yW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70915|0 |1 is obsolete| | Attachment #70916|0 |1 is obsolete| | Attachment #70917|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 70944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70944&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 11:00:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 10:00:17 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-7tP9I17Em4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #14 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 70946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70946&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 11:00:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 10:00:14 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-xQU7StQPHB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #13 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 70945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70945&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 11:00:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 10:00:20 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-9kWcbiBOrc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #15 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 70947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70947&action=edit Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 11:56:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 10:56:42 +0000 Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit In-Reply-To: <bug-15788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15788-70-FgTRtp2rtU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- I think ideally we would add a third 'delete' permission, updated site link: http://devs.bywatersolutions.com/2016/11/30/Split-borrowers-permission-into-create-edit/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:14:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:14:06 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-6XXUjcSew5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:14:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:14:14 +0000 Subject: [Koha-bugs] [Bug 19888] "Overdue Notices" email sent to KohaAdminEmailAddress should be optional In-Reply-To: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19888-70-x8dMbaqWuH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:17:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:17:26 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-CbJKSVzDmQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70948&action=edit Bug 14769: Introduce Koha::Authority::BiblioIndicators -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:17:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:17:30 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-y4dVq1LF0d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70949&action=edit Bug 14769: Add unit tests for Koha::Authority::BiblioIndicators -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:17:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:17:34 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-AsAOtnO7Af@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70950&action=edit Bug 14769: Add Koha::Authority::controlled_biblio_indicators -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:17:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:17:39 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-YmWdG7ZwLs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 70951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70951&action=edit Bug 14769: Call controlled_biblio_indicators in authority merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:18:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:18:45 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-nsD53ZqAvQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Still work in progress. I will still merge the code of Janusz into BiblioIndicators.pm and partially into the config file that it uses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:18:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:18:56 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-GmzI2ftDtZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:19:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:19:30 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14769-70-GfPNhFKIDB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:32:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:32:07 +0000 Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron category report In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19669-70-zUtPNtJwiR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Victor Grousset/tuxayo from comment #14) > Link for reports/itemtypes.plugin is stil in > staff:/cgi-bin/koha/reports/reports-home.pl > with the name "Catalog by itemtype" > > New bug for this or do we use the current one? I'd say new bug since this one has been released. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 12:58:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 11:58:26 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19792-70-waLR3aFEIz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Nicolas Legrand <nicolas.legrand at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr --- Comment #14 from Nicolas Legrand <nicolas.legrand at bulac.fr> --- Well, what about a prompt correction such as?: - by default on acquisition home, GetBudgetHierarchy loads the last budget period - add a form on acquisition home to make GetBudgetHierarchy choose a different budget period or all of them It remains bloated, but it'll be more expeditious for those who appreciate having an unreasonable amount of budgets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 13:20:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 12:20:02 +0000 Subject: [Koha-bugs] [Bug 18964] Add a --debugger flag to koha-plack In-Reply-To: <bug-18964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18964-70-zWTnM4vevE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Remote debugging release notes| |capabilities are added to | |the koha-plack script. This | |is very important for | |developers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 13:29:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 12:29:12 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19792-70-DAbOybkPKm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 S?verine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 13:32:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 12:32:48 +0000 Subject: [Koha-bugs] [Bug 8090] item links should have descriptive text In-Reply-To: <bug-8090-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8090-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8090-70-AizHLz1hB5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8090 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 13:41:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 12:41:08 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-14E7nVVDST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #196 from Hugo Agud <hagud at orex.es> --- good morning I have applied last patch 'Fix reteiving Mana Token' I am able to get token but I am not able to share anything with mana, same error than before Use of uninitialized value $loggedinuser in string ne at /home/vagrant/kohaclone/Koha/SharedContent.pm line 106. Can't call method "first_valid_email_address" on an undefined value at /home/vagrant/kohaclone/Koha/SharedContent.pm line 108. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 13:45:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 12:45:17 +0000 Subject: [Koha-bugs] [Bug 20091] New: FailedLoginAttempts is not part of NorwegianPatronDatabase pref group Message-ID: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 Bug ID: 20091 Summary: FailedLoginAttempts is not part of NorwegianPatronDatabase pref group Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 13:47:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 12:47:10 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-4ffyOKxLZv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 13:47:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 12:47:12 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-sKCJVUkCfm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70952&action=edit Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading To test: 1 - View systempreferences patron tab 2 - Note FailedLoginAttempts is uner 'Norwegian Patron Database' 3 - apply patch 4 - Now it is under 'General' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 13:48:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 12:48:00 +0000 Subject: [Koha-bugs] [Bug 20080] Test for utf8mb4 encoding and collation In-Reply-To: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20080-70-JgA3JDoe0D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Those tests are failing in master already. So, to test: To test: - Apply this patch - Change kohastructure.sql with a fake commit creating a table "the old way" - Run: $ kshell k$ qa -c 1 -v 2 => SUCCESS: The QA script gives an error, due to bad encoding/collation - Add a new commit fixing the encoding/collation - Run: $ kshell k$ qa -c 2 -v 2 => SUCCESS: No encoding/collation problems reported! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 13:49:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 12:49:49 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-BnpNXSpYHz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 14:01:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 13:01:33 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-Rvncbd7AIs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #5 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Sorry, no enough proofreading. Here is a fixed version of my last message. Minor changes but at least it doesn't burn the eyes anymore. Not writing CSV might be right about the theoretical meaning of CSV. But if we only write "semicolon separated values" it might be possible that enough users don't realize that it's the same thing that is usually called CSV. (Opinion of someone having a better perceptive about this is needed) Also: isn't the extension still .csv anyway? So the OSes will try to open the file with a spreadsheet software. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 14:17:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 13:17:49 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19792-70-9ZaGWibqVy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #15 from Blou <philippe.blouin at inlibro.com> --- > How many budgets/funds? What are the performances before/after this patch? Over 500 aqbudgets. Performance went from 30+ seconds to less than 1 second. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 14:26:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 13:26:32 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-8UkzVWwUTe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 14:26:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 13:26:35 +0000 Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19641-70-N60bejy9bz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #16 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 70953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70953&action=edit Bug 19641: Follow-up - Fix update child menu option This follow-up corrects handling of clicks on the "Update child" menu option when the patron is an adult. Previously the click handler was conditionally added via template markup. This patch modifies it to use the data-tooltip attribute as an indicator that the option is disabled. To test, apply the patch and clear your browser cache if necessary. - Open an adult patron's record for viewing. - Choose More -> Update child from the toolbar menu. - The menu item should be disabled, and should show a tooltip. - Clicking the menu item should do nothing. - Open a child patron's record for viewing. - Choose More -> Update child from the toolbar menu. - The patron should be updated to an adult category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 14:44:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 13:44:12 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-AnGfICv0en@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 14:44:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 13:44:15 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-VqnmUm5R8X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70952|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70954&action=edit Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading To test: 1 - View systempreferences patron tab 2 - Note FailedLoginAttempts is uner 'Norwegian Patron Database' 3 - apply patch 4 - Now it is under 'General' Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 14:45:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 13:45:15 +0000 Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl In-Reply-To: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14850-70-H98DvKO0h8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at collect | |o.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 14:45:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 13:45:36 +0000 Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl In-Reply-To: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14850-70-rIyd4ODHub@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 14:50:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 13:50:17 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-CgPkhVuBdC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70801|0 |1 is obsolete| | --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 70955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70955&action=edit Bug 18818: Display in quick add list now depends on a field in database This patch allows to manage the patron categories contained in 'Quick add new patron'. Test plan: 1) Apply patch 2) Update database structure : installer/data/mysql/updatedatabase.pl 3) Update DBIx shema : misc/devel/update_dbix_class_files.pl 4) Check in 'Administation > Patron categories' there is a field named "Display in Quick add patron" (and check everything is set to "Display") 5) Try to edit and check that the field exists and edits well the field 6) Go to 'Patrons > quick add patron' and check that the list contains only wished categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 14:50:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 13:50:31 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-S4Wktc0gGl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70802|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 70956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70956&action=edit Bug 18818: (followup) correct template Main change is the use of Yes/No instead if Display/Don't display. It is more compact and more explicit. And fixes in categories.tt : - Template Toolkit markup inside HTML in <select id="quick_add_display"> - Missing double-quotes in HTML attributes - Missing value display in delete confirmation table - Correct capitalization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 15:03:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 14:03:49 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19792-70-usVyCA6O9h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #16 from Blou <philippe.blouin at inlibro.com> --- (In reply to Nicolas Legrand from comment #14) > Well, what about a prompt correction such as?: > > - by default on acquisition home, GetBudgetHierarchy loads the last budget > period > - add a form on acquisition home to make GetBudgetHierarchy choose a > different budget period or all of them > Prompt correction? As in simple & fast? There's nothing quick and dirty about changing default behavior in a screen. That would be a totally different ticket. Although, feel welcome to pile on this one. We fixed it for the sponsor, we pointed it to the community, but if it wants to go in a different direction it's as well, we're pretty detached regarding it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 15:25:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 14:25:26 +0000 Subject: [Koha-bugs] [Bug 20080] Test for utf8mb4 encoding and collation In-Reply-To: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20080-70-BEqxyxmPCV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 15:25:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 14:25:29 +0000 Subject: [Koha-bugs] [Bug 20080] Test for utf8mb4 encoding and collation In-Reply-To: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20080-70-XyIHh1u3JV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70861|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70957&action=edit Bug 20080: Test for utf8mb4 encoding and collation Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 15:25:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 14:25:32 +0000 Subject: [Koha-bugs] [Bug 20080] Test for utf8mb4 encoding and collation In-Reply-To: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20080-70-9CLsuqVmHF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20080 --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70958&action=edit Bug 20080: Followup: corrected unless/if logic Changed unless to if, because unless was the wrong logic. TEST PLAN --------- 1) Run the following commands on a kohadev box: cd ~/qa-test-tools git pull git checkout -b bug_20080 origin/master git bz apply 20080 cd ~/kohaclone git pull git checkout -b bug_20080 origin/master git bz apply 18336 2) Edit ~/kohaclone/installer/data/mysql/kohastructure.sql changing CHARSET and COLLATE on a table to just utf8, instead of the utf8mb variation it is. 3) Run the following commands: git add installer/data/mysql/kohastructure.sql git commit -- doesn't matter what the commit message is. 4) Run the following commands: kshell qa -v 2 -c 1 -- this should fail with a collation problem. 5) Edit ~/kohaclone/installer/data/mysql/kohastructure.sql changing CHARSET and COLLATE on a table back to the utf8mb variation it was. 6) Run the following commands: kshell qa -v 2 -c 2 -- this should pass Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 15:27:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 14:27:07 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-vHamcIa6ix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70955|0 |1 is obsolete| | --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 70959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70959&action=edit Bug 18818: Display in quick add list now depends on a field in database This patch allows to manage the patron categories contained in 'Quick add new patron'. Test plan: 1) Apply patch 2) Update database structure : installer/data/mysql/updatedatabase.pl 3) Update DBIx shema : misc/devel/update_dbix_class_files.pl 4) Check in 'Administation > Patron categories' there is a field named "Display in Quick add patron" (and check everything is set to "Display") 5) Try to edit and check that the field exists and edits well the field 6) Go to 'Patrons > quick add patron' and check that the list contains only wished categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 15:27:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 14:27:22 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-JZvIMfbLHR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70956|0 |1 is obsolete| | --- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 70960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70960&action=edit Bug 18818: (followup) correct template Main change is the use of Yes/No instead if Display/Don't display. It is more compact and more explicit. And fixes in categories.tt : - Template Toolkit markup inside HTML in <select id="quick_add_display"> - Missing double-quotes in HTML attributes - Missing value display in delete confirmation table - Correct capitalization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 15:56:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 14:56:00 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-BrJgDrSBYe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 --- Comment #12 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 70959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70959 Bug 18818: Display in quick add list now depends on a field in database Review of attachment 70959: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18818&attachment=70959) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt @@ +212,5 @@ > <li> > + <label for="quick_add_display">Display in quick add patron list:</label> > + <select id=quick_add_display name=quick_add_display> > + <option value=1 [% UNLESS category.quick_add_display %]selected=selected [% END %]>Display</option> > + <option value=0 [% UNLESS category.quick_add_display %]selected=selected [% END %]>Don't Display</option> https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML Violation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 15:56:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 14:56:52 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-OF2h8BYSnY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:08:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:08:08 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19792-70-ypwJiG77PI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #17 from Nicolas Legrand <nicolas.legrand at bulac.fr> --- I did a benchmark on a 16.11.00 with NYTProf, with and without the patch, with GetBudgetHierarchy being called with arguments. We have 517 aqbudgets lines. acqui-home without 19792 ran in 19.5s, 4.83s is spent in GetBudgetHierarchy. acqui-home with 19792 ran in 12.3s, 38.6ms is spent in GetBudgetHierarchy. So it does improve our performances even when GetBudgetHierarchy is called without arguments. I'll test monday on orderreceive which load GetBudgetHierarchy with a budgetid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:16:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:16:14 +0000 Subject: [Koha-bugs] [Bug 20041] ILL module missing from more menu in staff when activated In-Reply-To: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20041-70-2SGpwpOAOK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:16:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:16:17 +0000 Subject: [Koha-bugs] [Bug 20041] ILL module missing from more menu in staff when activated In-Reply-To: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20041-70-APcBSYiBSt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70928|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70961&action=edit Bug 20041 - ILL module missing from more menu in staff when activated Apply this patch Check that ILL requests are now listed in More menu when ILL requests syspref is enabled Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:22:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:22:37 +0000 Subject: [Koha-bugs] [Bug 20016] use Modern::Perl in svc scripts In-Reply-To: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20016-70-UsIFskev1Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Jon Knight signed a patch supplied by Zoe Bennett. It looks good to me too. Changing to signed off, since I think that was just a forgotten step. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:26:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:26:14 +0000 Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few scripts to explode In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19808-70-oXkDClFZwV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #34 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Bug 17829 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:27:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:27:43 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-jpyOsXLhne@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70959|0 |1 is obsolete| | --- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 70962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70962&action=edit Bug 18818: Display in quick add list now depends on a field in database This patch allows to manage the patron categories contained in 'Quick add new patron'. Test plan: 1) Apply patch 2) Update database structure : installer/data/mysql/updatedatabase.pl 3) Update DBIx shema : misc/devel/update_dbix_class_files.pl 4) Check in 'Administation > Patron categories' there is a field named "Display in Quick add patron" (and check everything is set to "Display") 5) Try to edit and check that the field exists and edits well the field 6) Go to 'Patrons > quick add patron' and check that the list contains only wished categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:27:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:27:58 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-RKhZBxgf4H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70960|0 |1 is obsolete| | --- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 70963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70963&action=edit Bug 18818: (followup) correct template Main change is the use of Yes/No instead if Display/Don't display. It is more compact and more explicit. And fixes in categories.tt : - Template Toolkit markup inside HTML in <select id="quick_add_display"> - Missing double-quotes in HTML attributes - Missing value display in delete confirmation table - Correct capitalization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:28:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:28:12 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-B2rpIytnEP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 --- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 70964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70964&action=edit Bug 18818: define new column as boolean in DBIC Schema See https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:33:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:33:35 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-VhoHS3eonz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #68 from Nick Clemens <nick at bywatersolutions.com> --- Hi Aleisha, Overall things work well and are pretty intuitive. Can you squash some of the patches to ease readability? (e.e. the removed old_recalls stuff) Couple errors: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: <p><strong>Warning</strong>: Your library does not allow recalls for x item types.</p> Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Could overdue recalls be a tab/filter on the recalls queue? When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Question - should canceling a recall extend the due date? or notify patron somehow? is calendar used to calculate new due date for recall? I think it should be I think circ rules should include 'number of open recalls' to (optionally) limit how many a patron can have Is it valid for two patrons to recall the second item? I would think the second one not be a hold? -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:38:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:38:20 +0000 Subject: [Koha-bugs] [Bug 20092] New: Link for deleted report itemtypes.plugin still in the UI Message-ID: <bug-20092-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20092 Bug ID: 20092 Summary: Link for deleted report itemtypes.plugin still in the UI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org Followup of bug 19669 Link for reports/itemtypes.plugin is still in staff:/cgi-bin/koha/reports/reports-home.pl with the name "Catalog by itemtype" Which causes a 500 error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:38:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:38:49 +0000 Subject: [Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing In-Reply-To: <bug-12872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12872-70-rwG5TV2gKN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:38:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:38:52 +0000 Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron category report In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19669-70-Mxx3YP0MVU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20092 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:38:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:38:52 +0000 Subject: [Koha-bugs] [Bug 20092] Link for deleted report itemtypes.plugin still in the UI In-Reply-To: <bug-20092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20092-70-3c75ooZfIj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20092 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19669 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:40:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:40:37 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8962-70-LMprCftFNm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 16:42:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 15:42:42 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-Ekcry3CDJe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Hmmm..I agree the file extension may be confusing - would you think it is better to say: XXXX Separated text (.csv file) that makes more sense to me loglically and/or we could use .txt format unless generating a csv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:04:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:04:46 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-4ATsdFKD4g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- (In reply to Nick Clemens from comment #6) > Hmmm..I agree the file extension may be confusing - would you think it is > better to say: > > XXXX Separated text (.csv file) > > that makes more sense to me logically +1 for using csv and the actual separator. After a quick web search I'm not sure "XXXX Separated text" is used elsewhere. But saying "text" in nice to convey that it's essentially text (formatted, but still text) > and/or we could use .txt format unless generating a csv Then it would be opened by a text editor instead of a spreadsheet software right? Well when the file is saved and opened by the file manager. Else (Open instead of save) the mime type transferred by Koha should make it open in the spreadsheet software. (assuming Koha says "mime type csv" or something like that) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:15:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:15:22 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-DH14tKkA8Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 69004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69004 Bug 13990 - ILS-DI LookupPatron Requries ID Type Review of attachment 69004: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13990&attachment=69004) ----------------------------------------------------------------- ::: C4/ILSDI/Services.pm @@ +303,3 @@ > - borrowernumber > + - firstname > + - surname I would have put these in the same order as the loop, but it isn't really a big deal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:18:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:18:39 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-x4o3rvKcxn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Jon Knight from comment #2) > This begs the question: should Koha be constraining the list of id_type's > that can be passed into this routine from the client? Or is being able to > search on any column in the borrowers table regarded as a useful feature > (we've found "email" to be handy for sure). I think searching on any valid field is handy. Though, some fields are more useful than others. No error checking on valid fields is in this patch, but that isn't the tight scope of this bug. However, if you list it, you should search it. And this patch makes the list and what is searched matched nicely. I think email was a reasonable addition to the searchable list that is stated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:33:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:33:22 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-6CSbeDih8J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:33:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:33:25 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-7qcX3skNFC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69004|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70965&action=edit Bug 13990 - ILS-DI LookupPatron Requries ID Type Patch provides a constrained set of borrower attributes to try in turn if the ID type is not specified. Also added "email" to the POD documented list of id types seeing as its quite a useful one for integration developers. Test plan: 1) without the patch applied, turn on ils-di interface in your admin sysprefs and then try accessing the URL: https://your-server/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=Mabel replacing "your-server" your Koha dev test domain name (localhost:8080 if you're using a kohadevbox VM) and "Mabel" with the first name of a patron (Mabel is in the test database already if you're using that). You should get back an error message in the XML. 2) Apply the patch and repeat. This time you should get an <id> element in the XML with Mabel's patron ID in it. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:33:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:33:28 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-WcD2rv0ccn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #7 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70966&action=edit Bug 13990: Followup - fix various whitespace errors - tabs to 4 spaces - trailing whitespace - missing vertical whitespace before =head3 Without this patch, this bug fails qa test tools. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:33:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:33:59 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-j7NMmnIFkv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67706|0 |1 is obsolete| | Attachment #67707|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70967&action=edit Bug 19360 - Give items URL a link text This patch allows a user to write in a link text when adding an item to a MARC record in addition to a URI. The link text is displayed instead of the URI (only if a link text has been entered, otherwise the URI value is displayed) which makes the link more readable. Test plan: 1. Add a MARC record (of any framework) 2. Add an item making sure to write in a URL e.g. https://www.google.com 3. Notice on the additem page there is no 'Link text' input 4. Submit the add item form 5. Search for the item in the intranet and OPAC and notice that the whole URL is displayed, which would get annoying if the URL is long 6. Apply patch 7. Update the database by going to Administration->Global system preferences-> local use and change the 'version' system preference to an previous version and then click 'Save' 8. This will prompt the update process 9. After going through the update process repeat step 1 and add an item. When adding the item notice there is a 'Link text' option write in an appropriate name e.g. 'Google' and write in the URI value 10. Submit the form 11. Repeat step 5 and notice that the link text value is displayed instead of the URL 12. Click on the link and check that it works 13. Add another item to a record and write in a URI but no link text value 14. Search for the item in intranet and OPAC and notice that when no link text is entered but a URI is then the URI is displayed Sponsored-By: Catalyst IT Signed-off-by: David Bourgault <david.bourgault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:34:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:34:03 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-BpftSfuArD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70968&action=edit Bug 19360 - Added missing atomicupdate SQL file Test plan: 1. Add a MARC record (of any framework) 2. Add an item making sure to write in a URL e.g. https://www.google.com 3. Notice on the additem page there is no 'Link text' input 4. Submit the add item form 5. Search for the item in the intranet and OPAC and notice that the whole URL is displayed, which would get annoying if the URL is long 6. Apply patch 7. Update the database by going to Administration->Global system preferences-> local use and change the 'version' system preference to an previous version and then click 'Save' 8. This will prompt the update process 9. After going through the update process repeat step 1 and add an item. When adding the item notice there is a 'Link text' option write in an appropriate name e.g. 'Google' and write in the URI value 10. Submit the form 11. Repeat step 5 and notice that the link text value is displayed instead of the URL 12. Click on the link and check that it works 13. Add another item to a record and write in a URI but no link text value 14. Search for the item in intranet and OPAC and notice that when no link text is entered but a URI is then the URI is displayed Sponsored-By: Catalyst IT Signed-off-by: David Bourgault <david.bourgault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:34:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:34:06 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-rCGaao129V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70969&action=edit Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:33:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:33:57 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-n1hnMQd73l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:34:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:34:47 +0000 Subject: [Koha-bugs] [Bug 20093] New: Add more information in the deleting message for an authority Message-ID: <bug-20093-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20093 Bug ID: 20093 Summary: Add more information in the deleting message for an authority Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, It would be nice if we had more informations in the deleting message for an athorities. At the moment, the message is only : ?Are you sure you ant to delete this authority??. The message could contain more informations form the authority record like the notice number and the type of the authority. The message could be : ? Are you sure you want to delete the common name authority (for example) (statement of the term) ____ (record number) ___??. Or it could be somthing else. Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 17:35:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 16:35:22 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-LBn9nDq3TL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Was an easy rebase, split the schema updtaes to separate patch and added cfhanges to kohastructure and deleteditems table - very cool feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 18:54:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 17:54:41 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick_add patron list In-Reply-To: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18818-70-njNp5rHaQl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Owen Leonard <oleonard at myacpl.org> --- I'm getting this error when I run updatedatabase.pl: {UNKNOWN}: DBIx::Class::ResultSource::column_info(): No such column quick_add_display at /home/vagrant/kohaclone/Koha/Schema/Result/Category.pm line 273 Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm line 150. at /usr/share/perl5/Class/C3/Componentised.pm line 155 Compilation failed in require at /home/vagrant/kohaclone/Koha/Database.pm line 50. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 19:20:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 18:20:19 +0000 Subject: [Koha-bugs] [Bug 20094] New: gather_print_notices.pl uses first language in opaclanguages syspref bit first cannot be configured Message-ID: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20094 Bug ID: 20094 Summary: gather_print_notices.pl uses first language in opaclanguages syspref bit first cannot be configured Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We saw this problem on a site with multiple opaclanguages selected, all notices were defaulting to arabic template and printed as RTL. The cronjob gets the template which calls C4::Languages::getlanguage() The interface is read as 'opac' and no language is selected (no cookie, etc.) We eventually grab the first from the pref (bug 10560) The languages in the pref are loaded randomly into the admin view, try searching for 'opaclanguages' a few times or refreshing page, the order is random. Uncheck and recheck a language and save, note the pref is filled in the display order Run gather_print_notices.pl with different languages as first in the pref, note that a different template is used for each. I think the solution is just to allow for passing a specified language to the cron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 19:22:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 18:22:01 +0000 Subject: [Koha-bugs] [Bug 20094] gather_print_notices.pl uses first language in opaclanguages syspref but first cannot be configured In-Reply-To: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20094-70-q73BlxTvFW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20094 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|gather_print_notices.pl |gather_print_notices.pl |uses first language in |uses first language in |opaclanguages syspref bit |opaclanguages syspref but |first cannot be configured |first cannot be configured -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 19:28:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 18:28:55 +0000 Subject: [Koha-bugs] [Bug 15678] Make pickup branch editable on holds tab on circulation/patron detail screens In-Reply-To: <bug-15678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15678-70-apLm8d3sxw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15678 --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- This is working for me on master. This feature does rely on the REST api being configured and activated, can you verify this is the case on your system? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 19:35:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 18:35:24 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-9m6EkYftHI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 19:35:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 18:35:28 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-bJB1u4uW6Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70930|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70970&action=edit Bug 20056: Resolve uninitialized warn in cmp_sysprefs.pl When running a compare with --upd flag, I got the following warn: Use of uninitialized value in addition (+) at misc/maintenance/cmp_sysprefs.pl line 125. This is simply resolved by not returning undef but 0 in case of the Version syspref in the sub UpdateOnePref. Test plan: Look at this simple change. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 19:35:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 18:35:30 +0000 Subject: [Koha-bugs] [Bug 18617] starting plack on reboot can fail on non-standard apache configs In-Reply-To: <bug-18617-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18617-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18617-70-xd8WduUpdQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18617 --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- I like the idea of not having to grep the apache configuration files. I was testing this, and discovered that this doesn't fully work. I'm going to attach a follow up which should. If that makes you happy, Liz, then sign off, and I'll sign off, and we can set this to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 19:38:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 18:38:22 +0000 Subject: [Koha-bugs] [Bug 18617] starting plack on reboot can fail on non-standard apache configs In-Reply-To: <bug-18617-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18617-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18617-70-CeX368tznO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18617 --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70971&action=edit Bug 18617: Follow up - correctly check plack.enabled file first This patch was required, because without it, the apache2 config grepping logic was preventing the elif from checking the existence of the enabled file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 19:42:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 18:42:12 +0000 Subject: [Koha-bugs] [Bug 20088] Use of uninitialized value in array element in svc/holds In-Reply-To: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20088-70-3lyvO9L67H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20088 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 19:42:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 18:42:15 +0000 Subject: [Koha-bugs] [Bug 20088] Use of uninitialized value in array element in svc/holds In-Reply-To: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20088-70-Ch3bA1nJqL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20088 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70922|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70972&action=edit Bug 20088: Fix uninitialized warning from svc/holds Use of uninitialized value in array element at svc/holds line 56. Test plan: Check if the warn is no longer in the logs; the warning is triggered by an ajax call from the circulation template in staff. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 20:10:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 19:10:08 +0000 Subject: [Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline In-Reply-To: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20081-70-fJOJB4cdNs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Arturo <library at sll.texas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library at sll.texas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 20:10:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 19:10:15 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: <bug-13640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13640-70-HEjgCVIZpX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 20:55:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 19:55:35 +0000 Subject: [Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc In-Reply-To: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20051-70-7w7ivXxMlA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 20:55:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 19:55:38 +0000 Subject: [Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc In-Reply-To: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20051-70-ddRiSwzHtT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70783|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70973&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:00:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:00:59 +0000 Subject: [Koha-bugs] [Bug 20094] gather_print_notices.pl uses first language in opaclanguages syspref but first cannot be configured In-Reply-To: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20094-70-qx4MZXhfDd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20094 Danielle Elder <danielle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:04:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:04:43 +0000 Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15395-70-s64ZB6kbas@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62335|0 |1 is obsolete| | --- Comment #57 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70974&action=edit Bug 15395: Example usage of I18N Template::Toolkit plugin Moved this patch for example usage to teh end of patch set and resolved minor conflict while applyin Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:04:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:04:46 +0000 Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15395-70-LvZp5LqIMs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62709|0 |1 is obsolete| | --- Comment #58 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70975&action=edit Bug 15395: Fix several issues in translation process - Change location of generated PO files to ease its integration into Pootle (po/xx-XX-messages.po instead of xx_XX/LC_MESSAGES/Koha.po) - Use msginit for PO creation to try to set correctly Plural-Forms header. If it fails, set a default one - 'install' command now creates the PO file if it doesn't already exist - Fix locale name when language code is different from ll-CC (where ll is the language code and CC is the country code). Test plan: 1. `perl translate install ar-Arab` should results in po/ar/LC_MESSAGES/Koha.mo and po/ar-Arab-messages.po 2. `perl translate install gl` should results in po/gl/LC_MESSAGES/Koha.mo and po/gl-messages.po 3. `perl translate install zh-Hans-CN` should results in po/zh_CN/LC_MESSAGES/Koha.mo and po/zh-Hans-CN-messages.po 4. `perl translate install fr-FR` should results in po/fr_FR/LC_MESSAGES/Koha.mo and po/fr-FR-messages.po -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:04:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:04:50 +0000 Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15395-70-eTGjI5lmJZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65894|0 |1 is obsolete| | --- Comment #59 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70976&action=edit Bug 15395: Remove the use of Locale::Util's set_locale -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:06:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:06:03 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-yONddgtFKl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Need unit tests to cover changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:31:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:31:36 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-nYIOJ1w7sU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:31:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:31:39 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-ilWN9UbSmy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70643|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70977&action=edit Bug 19910 - Use the delimiter syspref to name download link To test: 1 - Set delimiter syspref to anything but comma 2 - Donwload report results as comma separated text 3 - They actually follow the syspref 4 - Apply patch 5 - Download link should now match pref selection 6 - Change pref, note link changes 7 - Verify things still work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:33:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:33:22 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-i7A88kDTlg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- updated text to include (.csv) and moved to an include so can be used elsewhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:52:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:52:41 +0000 Subject: [Koha-bugs] [Bug 20041] ILL module missing from more menu in staff when activated In-Reply-To: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20041-70-oQ4eWLR6xg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:52:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:52:44 +0000 Subject: [Koha-bugs] [Bug 20041] ILL module missing from more menu in staff when activated In-Reply-To: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20041-70-8v9tEhysbN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70961|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70978&action=edit Bug 20041 - ILL module missing from more menu in staff when activated Apply this patch Check that ILL requests are now listed in More menu when ILL requests syspref is enabled Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 21:55:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 20:55:52 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-2d65kz90kE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Maksim Sen <maksim.sen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70798|0 |1 is obsolete| | --- Comment #3 from Maksim Sen <maksim.sen at inlibro.com> --- Created attachment 70979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70979&action=edit Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Maksim Sen <maksim at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:00:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:00:38 +0000 Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7468-70-h06Ac83Nat@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #14 from Charles Farmer <charles.farmer at inlibro.com> --- Created attachment 70980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70980&action=edit Bug 7468 - Showing the error message according to the community interface patterns, fixing a javascript condition TEST PLAN++ 1) Apply all the patches 2) Connect to the intranet with an account with permissions to visit the "Tools" page 3) Go to /cgi-bin/koha/labels/label-home.pl . Either by entering the URL directly . OR, from the front page, by clicking "Tools", followed by the hyperlink "Label creator" under the "Catalog" section 4) Under the "+ New" button, a new option should be available: "Barcode range" 5) Fill the "From:" and the "To:" fields of the "Print barcode range" form . Keeping both fields at "0" should trigger a warning beside the first field: "*Cannot be smaller than 1" . If the value "From:" is greater the "To:" value, a warning should appear beside the second field: "*Cannot be smaller than the starting value" . Make sure the form doesn't let you enter non-numerical values . For a casual test, use "From: 1000" and "To: 1100" 6) After pressing the "Print Range" button, choose a template, a layout, and a starting position . The "DEFAULT TEMPLATE 01" has a page height of 5pt and a page width of 0pt, don't use it . All the default layouts should look alike, since we're only printing a barcode over a number, and not bibliographic information . Using a layout not defined as 'Barcode' will show a warning message 7) Clicking the "Export" button should lead to a second dialog window with a "Download as PDF" hyperlink. Clicking the link should prop up a download dialog box 8) Save the PDF locally, or simply open it, and make sure the options you used were taken into account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:03:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:03:32 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-2MXNj89zch@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:03:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:03:35 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-E8zqv7IfyH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70778|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70981&action=edit Bug 20003: Fix showing number of remaining checkouts during checking in Test plan: 0) Do not apply the patch 1) Have a patron with more then one checkout 2) Return one of patron's checkout and confirm the remaining number of checkout is not shown 3) Apply the patch 4) Try it again and confirm the number is now shown Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:06:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:06:39 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-86MaZCTDVW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 70982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70982&action=edit Bug 20003: QA Followup - use patron checkouts method instead of Koha::Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:07:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:07:25 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-Mi1QL4qaZA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Added a possible followup to use the method provided in Patron.pm instead of calling from Koha::Checkouts - feel free to obsolete if other method is preferred -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:07:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:07:54 +0000 Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7468-70-VuMvptT0Pr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Charles Farmer <charles.farmer at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |charles.farmer at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:13:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:13:48 +0000 Subject: [Koha-bugs] [Bug 19827] checkuniquemember is exported from C4::Members but has been removed In-Reply-To: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19827-70-ZnzDMvst3F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70652|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour <roch.damour at inlibro.com> --- Created attachment 70983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70983&action=edit Bug 19827: Removing &checkuniquemember from the export in C4/Members.pm Test Plan: - Check that the line &checkuniquemember has been removed from the export in C4/Members.pm Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:20:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:20:23 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-1kcYrzrfmB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 Maksim Sen <maksim.sen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70954|0 |1 is obsolete| | --- Comment #3 from Maksim Sen <maksim.sen at inlibro.com> --- Created attachment 70984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70984&action=edit Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading To test: 1 - View systempreferences patron tab 2 - Note FailedLoginAttempts is uner 'Norwegian Patron Database' 3 - apply patch 4 - Now it is under 'General' Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Maksim Sen <maksim at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:29:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:29:22 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn't appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-A6WkfaIlbX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:29:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:29:25 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn't appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-osIUU2eYv4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70646|0 |1 is obsolete| | --- Comment #3 from Roch D'Amour <roch.damour at inlibro.com> --- Created attachment 70985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70985&action=edit Bug 19986: 'Server name' doesn't appear as required Test plan: [1.] Go to Admin -> z39.50/SRU servers [2.] Make a new z39.50 server [3.] Fill in the required field (hostname, port, database) [4.] Save the server [5.] Notice that the form does not submit, tells you that Sever name is required [6.] Repeat steps 2 - 5 but this time make a new SRU server [6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server and a new SRRU server) [7.] See that now 'Server name:' is red and on the right side of the box there is a required note [8.] Save both servers and it should have created a new z39.50 server and a new SRU server https://bugs.koha-community.org/show_bug.cgi?id=19833 Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:38:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:38:40 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18887-70-fHOV3runzY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65234|0 |1 is obsolete| | --- Comment #12 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70987&action=edit Bug 18887 - Add new schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:38:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:38:43 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18887-70-QWxwJ0ELix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65235|0 |1 is obsolete| | --- Comment #13 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70988&action=edit Bug 18887 - Update existing schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:38:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:38:47 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18887-70-uPUwEGqnh4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65236|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70989&action=edit Bug 18887 - Add Koha::CirculationRule(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:38:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:38:50 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18887-70-XT0XyBwRqG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65237|0 |1 is obsolete| | --- Comment #15 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70990&action=edit Bug 18887 - Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend_Revamp_RFC This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:38:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:38:38 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18887-70-o6ENQfF0JD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65233|0 |1 is obsolete| | --- Comment #11 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70986&action=edit Bug 18887 - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:38:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:38:52 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18887-70-Ndo4uz3d7z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67620|0 |1 is obsolete| | --- Comment #16 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70991&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:39:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:39:12 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18887-70-omYgxbh2sj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <pianohacker at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:49:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:49:49 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-OwczRxImVE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67024|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70992&action=edit Bug 18925 - Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:49:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:49:51 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-1qvFZOGmT6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67025|0 |1 is obsolete| | --- Comment #10 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70993&action=edit Bug 18925 - Update Schema Files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:49:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:49:54 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-82jEg5p9sN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67026|0 |1 is obsolete| | --- Comment #11 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70994&action=edit Bug 18925 - Remove schema files for deleted tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 22:49:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 21:49:57 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-3wFKu9fcv9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67621|0 |1 is obsolete| | --- Comment #12 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70995&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 23:05:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 22:05:29 +0000 Subject: [Koha-bugs] [Bug 20048] koha-zebra missing --status In-Reply-To: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20048-70-BVQacnl1ag@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20048 Maksim Sen <maksim.sen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen at inlibro.com --- Comment #2 from Maksim Sen <maksim.sen at inlibro.com> --- Hello M. Tompsett, Would it be possible to add a step on how/where to get misc4dev and cp_debian_files.pl for the test? Thank you, Maksim Sen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 26 23:24:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jan 2018 22:24:23 +0000 Subject: [Koha-bugs] [Bug 19827] checkuniquemember is exported from C4::Members but has been removed In-Reply-To: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19827-70-T70eH2sz0z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827 Roch D'Amour <roch.damour at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour at inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 27 01:51:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jan 2018 00:51:52 +0000 Subject: [Koha-bugs] [Bug 20095] New: automatic_item_modification_by_age.pl not logged Message-ID: <bug-20095-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20095 Bug ID: 20095 Summary: automatic_item_modification_by_age.pl not logged Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: george at nekls.org QA Contact: testopia at bugs.koha-community.org automatic_item_modification_by_age.pl is not logged in the action_logs table when the CronjobLog system preference set to "Log." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 27 02:21:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jan 2018 01:21:05 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-dBUBLFo0cF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70995|0 |1 is obsolete| | --- Comment #13 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 70996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70996&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 06:50:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 05:50:59 +0000 Subject: [Koha-bugs] [Bug 20096] New: Regarding duplicate data in statistics and logs data Message-ID: <bug-20096-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20096 Bug ID: 20096 Summary: Regarding duplicate data in statistics and logs data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: tejoskumar at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi I noticed that there is duplicate data in statistics table and logs table with respect to check-in check out and renewal. If a user id (staff id or patron id if renewal done online) is added to statistics table there is no need to create a log for transactions. Hope this will help remove duplicate data if implemented. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 07:45:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 06:45:40 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-iebgFgRdRe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70965|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70997&action=edit Bug 13990 - ILS-DI LookupPatron Requries ID Type Patch provides a constrained set of borrower attributes to try in turn if the ID type is not specified. Also added "email" to the POD documented list of id types seeing as its quite a useful one for integration developers. Test plan: 1) without the patch applied, turn on ils-di interface in your admin sysprefs and then try accessing the URL: https://your-server/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=Mabel replacing "your-server" your Koha dev test domain name (localhost:8080 if you're using a kohadevbox VM) and "Mabel" with the first name of a patron (Mabel is in the test database already if you're using that). You should get back an error message in the XML. 2) Apply the patch and repeat. This time you should get an <id> element in the XML with Mabel's patron ID in it. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 07:45:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 06:45:46 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-PhEu0XVD3i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70966|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70998&action=edit Bug 13990: Followup - fix various whitespace errors - tabs to 4 spaces - trailing whitespace - missing vertical whitespace before =head3 Without this patch, this bug fails qa test tools. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 07:45:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 06:45:51 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-ybeYMaTSqe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #11 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 70999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70999&action=edit Bug 13990: QA Followup - Add unit test coverage prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 07:45:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 06:45:59 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-T1lzubyhiM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #12 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71000&action=edit Bug 13990: Followup: silence warnings on testing prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 07:47:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 06:47:48 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-ASKZHqWftz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from M. Tompsett <mtompset at hotmail.com> --- Moved back to signed off, as full case unit testing was added for the affected function: C4::ILSDI::Services::LookupPatron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 13:27:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 12:27:33 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-qOwAVp6MfR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 13:27:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 12:27:38 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-FvLM2jipGK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71002&action=edit Bug 13990: Followup - fix various whitespace errors - tabs to 4 spaces - trailing whitespace - missing vertical whitespace before =head3 Without this patch, this bug fails qa test tools. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 13:27:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 12:27:35 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-llx1xxS5TF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70997|0 |1 is obsolete| | Attachment #70998|0 |1 is obsolete| | Attachment #70999|0 |1 is obsolete| | Attachment #71000|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71001&action=edit Bug 13990 - ILS-DI LookupPatron Requries ID Type Patch provides a constrained set of borrower attributes to try in turn if the ID type is not specified. Also added "email" to the POD documented list of id types seeing as its quite a useful one for integration developers. Test plan: 1) without the patch applied, turn on ils-di interface in your admin sysprefs and then try accessing the URL: https://your-server/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=Mabel replacing "your-server" your Koha dev test domain name (localhost:8080 if you're using a kohadevbox VM) and "Mabel" with the first name of a patron (Mabel is in the test database already if you're using that). You should get back an error message in the XML. 2) Apply the patch and repeat. This time you should get an <id> element in the XML with Mabel's patron ID in it. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 13:27:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 12:27:41 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-09yw6cqSc0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71003&action=edit Bug 13990: QA Followup - Add unit test coverage prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 28 13:27:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 12:27:45 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-SzpaFj5csZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71004&action=edit Bug 13990: Followup: silence warnings on testing prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 00:11:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 23:11:28 +0000 Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7468-70-wSEONEhTnI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Jovana Dunisijevic <jdjunisijevic at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdjunisijevic at prosentient.c | |om.au --- Comment #15 from Jovana Dunisijevic <jdjunisijevic at prosentient.com.au> --- Hi everyone, This is what we are trying to do, which is similar to your idea, David. Our idea is to preprint barcodes, given the starting barcode value and the number/amount of barcodes that will be printed. With additional verification as to check if one of the new barcodes haven't already been used. I am already working on this. Would like to hear some thoughts about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 00:11:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jan 2018 23:11:50 +0000 Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7468-70-eYZ1zl4a5X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 01:07:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 00:07:18 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-NuMsx8GJHb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65241|0 |1 is obsolete| | --- Comment #3 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71005&action=edit Bug 18928 - Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 01:07:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 00:07:20 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-7HLKPZxJIA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65242|0 |1 is obsolete| | --- Comment #4 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71006&action=edit Bug 18928 - Remove schema files for deleted tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 01:20:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 00:20:27 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-VE71i2uoap@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65243|0 |1 is obsolete| | --- Comment #4 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71007&action=edit Bug 18930 - Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 01:36:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 00:36:57 +0000 Subject: [Koha-bugs] [Bug 20071] Hide error displayed when db user tries to catalog anything In-Reply-To: <bug-20071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20071-70-KeOf2WHzrz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20071 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea <liz at catalyst.net.nz> --- Also why we put the onboarding tool to allow a superlibrarian to be created at install time. You should probably never, ever, have a reason to log in as this user now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:03:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:03:05 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-xoNSQ6Usl0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #151 from David Cook <dcook at prosentient.com.au> --- (In reply to Blou from comment #150) > We're interested in testing. In fact, we'd need this ASAP for one of our > client. So David, if you're around, you'll get some testing starting.... as > soon as we can apply it. > > We're getting a SHA1 on the first patch, whoever tries to apply it here. > > So maybe if you have no signoff it would be a good opportunity to rebase and > squash a few patches. > > We stand ready, today or tomorrow. I'll look at rebasing it now. Cheers! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:08:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:08:26 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-itSIT6xwhM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #152 from David Cook <dcook at prosentient.com.au> --- Merge conflict for #18585 but that should be easy enough to fix... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:12:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:12:02 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18585-70-9uizZkS6gp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #23 from David Cook <dcook at prosentient.com.au> --- Looks like this one doesn't apply anymore... I'll rebase it in a minute -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:15:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:15:44 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-MBIMkMKA3H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64479|0 |1 is obsolete| | --- Comment #153 from David Cook <dcook at prosentient.com.au> --- Created attachment 71008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71008&action=edit Bug 10662 - Build OAI-PMH Harvesting Client This patch adds an OAI-PMH harvesting client to Koha. The client runs as a daemon in the background. Users interact with the client via the Koha web user interface, which communicates with the daemon via a unix socket using a simple JSON-based protocol. The harvester ingests MARCXML. You can harvest other metadata formats, but you must use a XSLT to transform them into MARCXML, if you want them to be imported into Koha. You can supply your own download and import modules via the oai-pmh-harvester.yaml configuration file, but the default modules supplied in this patch should be good enough for your purposes. If they're not, raise a Bugzilla issue. There is a cleanup_database.pl addition, because high volume harvesting will cause the oai_harvester_import_queue table to fill quickly. This table is not required for adding/updating records. It's mostly just for general monitoring and audit purposes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:15:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:15:56 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-cQFNjn0d69@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64480|0 |1 is obsolete| | --- Comment #154 from David Cook <dcook at prosentient.com.au> --- Created attachment 71009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71009&action=edit Bug 10662 - Remove workaround for pre-17710 behaviour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:16:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:16:07 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-0NrXkeWcHs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64481|0 |1 is obsolete| | --- Comment #155 from David Cook <dcook at prosentient.com.au> --- Created attachment 71010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71010&action=edit Bug 10662 - Modify OAI-PMH harvester to import RDFXML Typically, the OAI-PMH harvester only imports MARCXML, but this patch allows you to also import RDFXML. This functionality was requested by Stockholm University Library, and importing RDFXML requires a parallel import of MARCXML if you want to be able to use the RDFXML. That is to say, you can download and import RDFXML using this patch, but it will probably only be useful if you're also importing MARCXML which can be linked to the RDFXML using the OAI-PMH repository and identifier as a link. This might change in the future if Koha moves away from MARCXML as the central required metadata format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:16:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:16:17 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-HLfkYcdBw5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65016|0 |1 is obsolete| | --- Comment #156 from David Cook <dcook at prosentient.com.au> --- Created attachment 71011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71011&action=edit Add RDF::Query dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:16:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:16:26 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-biOsUhPtfm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65017|0 |1 is obsolete| | --- Comment #157 from David Cook <dcook at prosentient.com.au> --- Created attachment 71012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71012&action=edit Fix configuration typo for Debian instances -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:16:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:16:34 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-co300nWJo7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65018|0 |1 is obsolete| | --- Comment #158 from David Cook <dcook at prosentient.com.au> --- Created attachment 71013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71013&action=edit Standardize OAI-PMH test success/failure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:16:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:16:42 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-9q9AaZhIrW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65019|0 |1 is obsolete| | --- Comment #159 from David Cook <dcook at prosentient.com.au> --- Created attachment 71014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71014&action=edit Use old style of UUID generation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:16:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:16:50 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-OLaZ508ljz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68508|0 |1 is obsolete| | --- Comment #160 from David Cook <dcook at prosentient.com.au> --- Created attachment 71015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71015&action=edit Fix problems reported by Koha QA tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:19:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:19:14 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18585-70-AyqN5uFYO3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69632|0 |1 is obsolete| | --- Comment #24 from David Cook <dcook at prosentient.com.au> --- Created attachment 71016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71016&action=edit Bug 18585 - Connect to RDF triplestore This commit adds a 'triplestore' method to C4::Context. It takes a model name as a parameter and returns a RDF::Trine::Model object if triplestore.yaml is properly configured. (At the moment, it just supports RDF::Trine::Store::SPARQL, but it would be trivial to add support for RDF::Trine::Store::DBI too, or any other RDF::Trine::Store::* backend.) This code will provide a base from which people can use RDF::Trine for querying and updating a RDF triplestore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:19:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:19:11 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18585-70-NvtPleEUn1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 02:24:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 01:24:58 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-vgLgopqrpd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #161 from David Cook <dcook at prosentient.com.au> --- OK, both #18585 and #10662 have been updated. You should be able to apply 18585, 18586, 18713, and now 10662. Actually, you could probably test 10662 on its own without the RDF specific patches. If it doesn't work, I should write a patch to make the RDF optional... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 08:31:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 07:31:37 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-9AYvH6sx3e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Wondering, should we also keep the case sensitivity on subfields for the auth frameworks? The item search fields table might be another use case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 08:32:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 07:32:51 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18477-70-omVxwIAPcd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Pushed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 10:08:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 09:08:03 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19318-70-hPkyu0eBDE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 10:08:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 09:08:29 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19318-70-G1h2BbVpHV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71017&action=edit Bug 19318: Allow multiple storage spaces for file uploads This patch allow to configure multiple storage spaces to be used when uploading a file. Configuration is done in $KOHA_CONF. Element 'upload_path' is replaced by 'storage', which is repeatable and can contain the following elements: - name: The storage's identifier (also used for display) - adapter: The storage's adapter is a Perl module who is responsible for actually writing in the storage (creating/deleting files/directories). There is actually only one adapter, 'directory', which writes directly on the filesystem. - adapter_params: Additional parameters required for the storage's adapter - hash_filename: Whether to prepend hashvalue to the filename or not - temporary: Whether the storage is temporary or not - baseurl: Base URL of the storage, if one doesn't want to (or can't) use opac-retrieve-file.pl This is all documented in Koha::Storage There is two built-in storages: - 'TMP', the default temporary storage (not configurable) - 'DEFAULT', the default persistent storage (configurable in $KOHA_CONF) Note that if $KOHA_CONF is not updated, uploads should continues to work (the 'DEFAULT' storage will use 'upload_path', if set) This patch affects the following pages: - Tools ? Upload - Tools ? Upload local cover image (ZIP file upload) - Tools ? Stage MARC records for import - Tools ? Upload patron images - Circulation ? Offline circulation file upload - Cataloguing plugin upload.pl Test plan: 0. Before applying the patch, be sure to use the pages mentioned above and upload some files, those files should continue to be accessible after the patch 1. Apply the patch, run updatedatabase and update_dbix_class_files 2. Without modifying $KOHA_CONF, verify that files uploaded in step 0 are still accessible (you can find them in tools/upload.pl) 3. Verify that you can still upload files using the pages mentioned above 4. Edit your $KOHA_CONF, copy the <storage> element from etc/koha-conf.xml in the source, set the <path> using the value of <upload_path> and remove <upload_path> 5. Verify that you can still upload files 6. Add another storage in $KOHA_CONF, set <hash_filename> to 0, and a <baseurl>. Now try to use the cataloguing plugin and see how the generated URL change. Also note that the files keep their original filename (without the hashvalue prepended) 7. Create some subdirectories under the main storage's path (using a shell). Try to upload a new files and see that these directories appear in a dropdown list. Select one, finish the upload and verify that the file has been uploaded to the selected subdirectory. 8. Run prove t/ImportBatch.t t/Koha/Storage.t t/db_dependent/ImportBatch.t t/db_dependent/Upload.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 10:08:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 09:08:39 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19318-70-XKoiNWJG0c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 10:31:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 09:31:57 +0000 Subject: [Koha-bugs] [Bug 20097] New: marc2dcxml croaks on format dc Message-ID: <bug-20097-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Bug ID: 20097 Summary: marc2dcxml croaks on format dc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Format 'dc' could be accepted by C4::Record::marc2dcxml since there is a xslt. I saw this error in my log: The format argument (dc) not accepted. Please pass a valid format (oaidc, srwdc, or rdfdc) at opac/opac-export.pl line 80. [Probably from Googlebot or so.] I would prefer to see 'Format not supported' rather than 'Internal server error'. We can achieve that by using the same regex in opac-export.pl and Record.pm. Note that I skip catalogue/export.pl here, since it has no fallback at the end, and will not be called by bots. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 10:32:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 09:32:15 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: <bug-20097-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20097-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20097-70-mIBWbykzOR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 10:38:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 09:38:22 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: <bug-20097-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20097-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20097-70-FefLWAno4y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 10:38:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 09:38:25 +0000 Subject: [Koha-bugs] [Bug 20097] marc2dcxml croaks on format dc In-Reply-To: <bug-20097-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20097-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20097-70-U0sM4MCgdO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20097 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71018&action=edit Bug 20097: Use same regex in marc2dcxml and opac-export This regex allows: dc, oaidc, srwdc, and rdfdc. Test plan: [1] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=dc [2] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=oaidc [3] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=nodc. This one should trigger a not-supported message. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 11:56:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 10:56:42 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19792-70-hGXMPbO687@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #18 from Nicolas Legrand <nicolas.legrand at bulac.fr> --- (In reply to Blou from comment #16) > (In reply to Nicolas Legrand from comment #14) [...] > > Prompt correction? As in simple & fast? There's nothing quick and dirty > about changing default behavior in a screen. That would be a totally > different ticket. Ha sure! Nevertheless, I didn't mean ?quick and dirty?. For the moment, I hardcoded the budgetid for GetBudgetHierarchy in acquisition home. That's quick and dirty ;). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 12:13:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 11:13:27 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19792-70-7mkf2AJGC9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #19 from Nicolas Legrand <nicolas.legrand at bulac.fr> --- I just tried NYTProf on orderreceive.pl which loaded twice GetBudgetHierarchy with a budget id. orderreceive without 19792 ran in 6.05s, 38.9ms is spent in GetBudgetHierarchy. orderreceive with 19792 ran in 4.81s, 359ms is spent in GetBudgetHierarchy. Therefore, the function is still faster with this patch, even when launched with a budget id. We will use this patch in production as it saves some seconds in a module that became a sluggishness nightmare since 16.11. We would like to warmly thank InLibro and Collecto for this improvement! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 12:17:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 11:17:37 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11827-70-IPM5Ncp1Yg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71019&action=edit Allow translating "Cancel Rating", and use string formatting for couple other strings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 12:17:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 11:17:48 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11827-70-VDFU7zYKzF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 12:57:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 11:57:56 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18786-70-qG6An43oSr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 12:57:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 11:57:58 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18786-70-KYAhzqJbnt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69156|0 |1 is obsolete| | Attachment #69157|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71020&action=edit Bug 18786 - Update database Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 12:58:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 11:58:03 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18786-70-sOxkVQlI4x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #22 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 71021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71021&action=edit Bug 18786 - Add ability to create custom payment types Some libraries would like to be able to specify more specific payment types such as cash, check, credit card, or even canned food ( for food drives ). This feature will allow a library to specify payment types as authorised values of the type PAYMENT_TYPE. Test Plan: 1) Apply patches 2) Update database 3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card' 4) Go to the fines section of a patron who has several fines 5) Tab 'Fines' 6) Click on 'Pay' for an individual fine 7) Verify that in the form a 'Pay an individual fine' dropdown appears with payment types 8) Select a payment type, confirm payment 9) Verify that payment type appears in "Description of charges" in tab 'Account' Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 13:02:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 12:02:03 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18786-70-HIa0Hk3U1u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |josef.moravec at gmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12001 --- Comment #23 from Josef Moravec <josef.moravec at gmail.com> --- I agree with you Kyle, better to not have more hardcoded values in Koha... Passed QA, note for RM: on boraccount.pl, the payment type is not shown now, but should be fixed by bug 12001 I think, with GetMemberAccountRecords refactoring -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 13:02:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 12:02:03 +0000 Subject: [Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages In-Reply-To: <bug-12001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12001-70-AK1s6QGPDu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18786 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 13:38:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 12:38:04 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-jY96xbARup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #19) > Wondering, should we also keep the case sensitivity on subfields for the > auth frameworks? The item search fields table might be another use case. Katrin, possibly. But a separate bug for sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 13:48:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 12:48:25 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11827-70-lQaRgRCPmz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 14:03:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 13:03:04 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-CbrdEeuv8N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 71022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71022&action=edit Bug 18336: Fix missing utf8_bin > utf8mb4_bin translation in kohastructure.sql Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 14:03:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 13:03:35 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-OdSp74YI9f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 14:07:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 13:07:41 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-ZAjOwOadlo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I've had trouble posting the patches here. Please use this branch to get the patches: https://github.com/tomascohen/koha/tree/bug_15794_emoji_tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 14:09:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 13:09:30 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-CngTBpox0c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Tom?s Cohen Arazi from comment #21) > Created attachment 71022 [details] [review] > Bug 18336: Fix missing utf8_bin > utf8mb4_bin translation in > kohastructure.sql > > Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> This was covered on the atomic update, but I forgot to add it to kohastructure.sql. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 14:36:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 13:36:47 +0000 Subject: [Koha-bugs] [Bug 20048] koha-zebra missing --status In-Reply-To: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20048-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20048-70-h2zKWSAPVp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20048 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Needs Signoff |RESOLVED --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- The reason for this bug is that a patch was lost when pushing bug 17468. This was addressed by the release manager already. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 15:49:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 14:49:40 +0000 Subject: [Koha-bugs] [Bug 20098] New: Inventory: CSV export: itemlost column is always empty Message-ID: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 Bug ID: 20098 Summary: Inventory: CSV export: itemlost column is always empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org It's mapped with the name "lost" instead of "itemlost" == Reproduce == 1. Have a lost item 2. Go to staff:/cgi-bin/koha/tools/inventory.pl 3. Tick "Optional filters" ? "items.itemlost" ? "name of Authorized values for the lost state" 4. Tick "Export to CSV file" 5. Submit 6. Open the CSV 7. Check that the lost item is in the list 8. You should observe that the "Lost status" column is empty for all items This is the bug -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 15:50:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 14:50:01 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20098-70-wPFzwpvXQl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |victor.grousset at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 16:22:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 15:22:22 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20098-70-NByIJxym7y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 71023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71023&action=edit Bug 20098: Inventory tool: CVS export: fix itemlost column It was mapped with "lost" instead of "itemlost". == Test plan == 1. Have a lost item 2. Go to staff:/cgi-bin/koha/tools/inventory.pl 3. Tick "Optional filters" ? "items.itemlost" ? "name of Authorized values for the lost state" 4. Tick "Export to CSV file" 5. Submit 6. Open the CSV 7. Check that the lost item is in the list 8. You should observe that the "Lost status" column is empty for all items This is the bug 9. Apply this patch 10. Click submit to re-export the CSV 11. Open the CSV 12. Check that the lost item is in the list 13. You should observe that the "Lost status" column now filled with the expected values. 14. Smile because it works! :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 16:23:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 15:23:47 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20098-70-HecSsmDM80@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 16:26:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 15:26:13 +0000 Subject: [Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections In-Reply-To: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18336-70-v6KUpkR6m1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336 --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Tom?s Cohen Arazi from comment #20) > (In reply to Katrin Fischer from comment #19) > > Wondering, should we also keep the case sensitivity on subfields for the > > auth frameworks? The item search fields table might be another use case. > > Katrin, possibly. But a separate bug for sure. Agreed - I just noticed we didn't do it for those tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 16:37:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 15:37:19 +0000 Subject: [Koha-bugs] [Bug 16662] Letsencrypt II: Return of the cryptosaurus. (make it work for existing instances) In-Reply-To: <bug-16662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16662-70-wy9CEq7ijG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662 Claudio <costalc at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:12:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:12:58 +0000 Subject: [Koha-bugs] [Bug 14391] Granular permissions for the administration module In-Reply-To: <bug-14391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14391-70-u4uXhfuWVp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Jeanne Heicher <nppublib at pa.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nppublib at pa.net --- Comment #2 from Jeanne Heicher <nppublib at pa.net> --- I, too, vote for granularity in the permissions for the Admin module in Koha. As a library director, I have people doing tasks where they need access to parts of the admin module, but giving them the keys to the kingdom is not an option. This week we are struggling with updating our MARC frameworks. I will not be able to have my cataloger do this by herself (because of the permissions), so I will have to spend a lot of my time working with her to get the job done. If I could just give her permissions to alter the MARC frameworks, I would have a couple of work days more in my schedule this week to do what I need to do apart from the catalog improvements. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:13:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:13:34 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-951SGR8QSv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70794|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71024&action=edit Bug 20053: Drop type attribute "text/javascript" in OPAC templates Conformance rules for HTML5 is generating warnings for <script> element with type="text/javascript" attribute when the OPAC page is checked with W3C Validator. This patch removes the cause of these warnings. Test plan ========= 1/ Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch about 10+ warnings being generated by the validator. 2/ Apply patch and re-submit the page to the Validator. The warnings would be gone. Signed-off-by: Owen Leonard <oleonard at myacpl.org> The QA tool raises some warnings, but these are about issues which pre-date this patch. They should be addressed in a separate bug. Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:13:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:13:37 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-tskVkCejU7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71025&action=edit Bug 20053: (QA follow-up) Also drop language attribute in OPAC templates Only one occurence in opac-password-recovery.tt Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:13:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:13:48 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-Yam6xa9180@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:20:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:20:48 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-apTwGjfYSk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:32:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:32:09 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn't appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-7FafKdf8vU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70985|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71026&action=edit Bug 19986: 'Server name' doesn't appear as required Test plan: [1.] Go to Admin -> z39.50/SRU servers [2.] Make a new z39.50 server [3.] Fill in the required field (hostname, port, database) [4.] Save the server [5.] Notice that the form does not submit, tells you that Sever name is required [6.] Repeat steps 2 - 5 but this time make a new SRU server [6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server and a new SRRU server) [7.] See that now 'Server name:' is red and on the right side of the box there is a required note [8.] Save both servers and it should have created a new z39.50 server and a new SRU server Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:32:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:32:19 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn't appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-pNGHGtPJ04@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:39:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:39:29 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-4sStrB5yUm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70979|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71027&action=edit Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: maksim <maksim at inlibro.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:39:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:39:39 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-a8oT0oJzbO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:42:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:42:35 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-5k96b94KeC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70984|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71028&action=edit Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading To test: 1 - View systempreferences patron tab 2 - Note FailedLoginAttempts is uner 'Norwegian Patron Database' 3 - apply patch 4 - Now it is under 'General' Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Maksim Sen <maksim at inlibro.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:42:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:42:50 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-zx2jCm5CFb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:46:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:46:49 +0000 Subject: [Koha-bugs] [Bug 19827] checkuniquemember is exported from C4::Members but has been removed In-Reply-To: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19827-70-Mb9WW56qYW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Assignee|koha-bugs at lists.koha-commun |zoebennett1308 at gmail.com |ity.org | QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:47:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:47:07 +0000 Subject: [Koha-bugs] [Bug 19827] checkuniquemember is exported from C4::Members but has been removed In-Reply-To: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19827-70-wPL2wECWDm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70983|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71029&action=edit Bug 19827: Removing &checkuniquemember from the export in C4/Members.pm Test Plan: - Check that the line &checkuniquemember has been removed from the export in C4/Members.pm Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 17:47:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 16:47:15 +0000 Subject: [Koha-bugs] [Bug 19827] checkuniquemember is exported from C4::Members but has been removed In-Reply-To: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19827-70-bdiLYqjxMT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 18:16:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 17:16:04 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18786-70-vqTAKwk8Tf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- What I am not sure about is the relation to the already existing SIP payment types - will both work together nicely for reports etc? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 20:52:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 19:52:40 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11827-70-hNjKYRmHVx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:08:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:08:43 +0000 Subject: [Koha-bugs] [Bug 18617] starting plack on reboot can fail on non-standard apache configs In-Reply-To: <bug-18617-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18617-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18617-70-Em1IRy7n16@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18617 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC|gmcharlt at gmail.com, | |katrin.fischer at bsz-bw.de, | |mtompset at hotmail.com | Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:16:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:16:33 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-hDPmgj5uUw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- I would recommend posting just the non-emoji picker parts, and then having people do the following on a kohadevbox: cd ~ git clone https://github.com/OneSignal/emoji-picker.git cd emoji-picker/lib mkdir ~/kohaclone/koha-tmpl/opac-tmpl/lib/emoji-picker cp -r -v . ~/kohaclone/koha-tmpl/opac-tmpl/lib/emoji-picker cd ~/kohaclone git add `find ~/kohaclone/koha-tmpl/opac-tmpl/lib/emoji-picker` git commit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:20:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:20:39 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: <bug-18743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18743-70-Mpj11bKTED@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Maksim Sen <maksim.sen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68298|0 |1 is obsolete| | --- Comment #8 from Maksim Sen <maksim.sen at inlibro.com> --- Created attachment 71030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71030&action=edit Bug 18743 - ALTERNATE: Take IndependantBranches syspref into account --- THIS IS AN ALTERNATE PATCH I am submitting it here, because it covers less than Alex's patch, but does so in a simpler fashion. APPLY ONLY THIS PATCH, OR THE OTHER, NOT BOTH. --- Displays suggestions for all libraries when IndependantBranches is set to no, or user is Super librarian by adding a missing if statement. TEST PLAN [0] Apply patch [1] Set IndependentBranches to 'Yes'. [2] Create a suggestion with a user from branch A. [3] As a superlibrarian, visit the suggestion page, you should see the suggestion. [4] As staff from branch A, visit the sugg. page, you should see the suggestion. [5] As staff from branch B, visit the sugg. pase, you should NOT see the suggestion. [6] As staff from branch A, make sure the amount of suggestions to the left of "Suggestions pending approval: " is the same as the amount of suggestions in the suggestions page. [7] Set IndependentBranches to 'No'. [8] Redo step 3-5. You should always see the suggestion. [9] Sign-off. [10] Have fun. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:29:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:29:12 +0000 Subject: [Koha-bugs] [Bug 16260] Moderate the impact of AllowHoldsOnPatronsPossessions In-Reply-To: <bug-16260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16260-70-65EEJZ41kw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:46:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:46:39 +0000 Subject: [Koha-bugs] [Bug 19888] "Overdue Notices" email sent to KohaAdminEmailAddress should be optional In-Reply-To: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19888-70-RaV7c78LQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #2) > Some confusion lead to the creation of bug 20076 which might be invalid. > > > (In reply to Katrin Fischer from comment #1) > > As there is no nice way to print the print notices at the moment we are > > still relying on the email - it's not useless to us :) > > What do you mean by ?no nice way to print?? There is a script to generate > PDFs which takes into account custom formatting. Yes, but there is on nice way to get those to the patrons. Putting them in a publicly accessible directory in on the web server is out of question (privacy). FTP complicated etc. Koha misses a way to print them from GUI or at least get them from there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:47:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:47:53 +0000 Subject: [Koha-bugs] [Bug 19888] "Overdue Notices" email sent to KohaAdminEmailAddress should be optional In-Reply-To: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19888-70-uR7QSoeT4i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #3) > (In reply to Victor Grousset/tuxayo from comment #2) > > Some confusion lead to the creation of bug 20076 which might be invalid. > > > > > > (In reply to Katrin Fischer from comment #1) > > > As there is no nice way to print the print notices at the moment we are > > > still relying on the email - it's not useless to us :) > > > > What do you mean by ?no nice way to print?? There is a script to generate > > PDFs which takes into account custom formatting. > > Yes, but there is on nice way to get those to the patrons. Putting them in a > publicly accessible directory in on the web server is out of question > (privacy). FTP complicated etc. Koha misses a way to print them from GUI or > at least get them from there. Can't type... no nice way to get those to the staff users [!] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:48:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:48:08 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: <bug-18743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18743-70-8yOMYVhFRS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Maksim Sen <maksim.sen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:51:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:51:08 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-SgRvltrrL5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 70977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70977 Bug 19910 - Use the delimiter syspref to name download link Review of attachment 70977: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19910&attachment=70977) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/delimiter_text.inc @@ +3,5 @@ > + [% CASE ',' %]Comma separated text (.csv) > + [% CASE '/' %]Slash separated text (.csv) > + [% CASE ';' %]Semicolon separated text (.csv) > + [% CASE '\\' %]Backslash separated text (.csv) > + [% CASE 'tabulation' %]Tab separated text (.csv) Please check if these are translatable - you might have to wrap them in spans to get them picked up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:57:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:57:57 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: <bug-18743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18743-70-VpNwblLfmw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Maksim Sen <maksim.sen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:58:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:58:04 +0000 Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19792-70-GPhfAM3mDP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Nicolas Legrand from comment #14) > Well, what about a prompt correction such as?: > > - by default on acquisition home, GetBudgetHierarchy loads the last budget > period We have libraries with multiple active budgets in the same or similar timeframes (timeframes could overlap, external funds for 2 years, regular budget for 1 year, ...). If we do this, I'd prefer to default to active budgets and only load inactive on demand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 21:58:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 20:58:58 +0000 Subject: [Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined In-Reply-To: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19772-70-fggKtEYJqJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong success message if |Wrong success message if |PATRON_NOTE is not defined |CHECKOUT_NOTE is not | |defined CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 29 22:05:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 21:05:32 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-28mxr9P0q9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am using Jonathan's koha-conf.xml configuration now with most extra features turned off. I think the problems I saw might be related to a special combination of features. If I can I will do more testing and open a separate bug if I manage to find the problem case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:07:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:07:02 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18887-70-CTSdvNX8PC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #17 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71031&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:07:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:07:19 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-qHGwGZy2bY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70992|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71032&action=edit Bug 18925 - Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:07:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:07:38 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-vnp7wOYa0e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #15 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71033&action=edit Bug 18925: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:08:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:08:20 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-MT0JJnpi6Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65247|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71034&action=edit Bug 18936 - Convert issuingrules fields to circulation_rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:08:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:08:23 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-IlzABtljOK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65248|0 |1 is obsolete| | --- Comment #10 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71035&action=edit Bug 18936: (followup) Fix upgrade step -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:08:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:08:26 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-0hKelMSf74@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65249|0 |1 is obsolete| | --- Comment #11 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71036&action=edit Bug 18936: Fix api/v1/holds.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:08:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:08:29 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-d45lpKq42Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67629|0 |1 is obsolete| | --- Comment #12 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71037&action=edit Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules This necessitates moving the circ rules from using '*' to using undef/NULL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:08:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:08:31 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-4DGzFPvy7I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67758|0 |1 is obsolete| | --- Comment #13 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71038&action=edit Bug 18936: (follow-up) Update REST definition for /.../kinds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:08:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:08:34 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-YnxJ6Kfe08@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68236|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71039&action=edit Bug 18936: (follow-up) fix rental odiscount lookup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:08:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:08:36 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-bvLkFQhQwT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #15 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71040&action=edit Bug 18936: (follow-up) Remove issuingrules from kohastructure.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:08:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:08:38 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-QMjh5sHifn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #16 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71041&action=edit Bug 18936: (follow-up) fix tests, null vs. empty behavior for limiting rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:11:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:11:45 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18887-70-n8QMiGIYVa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71031|0 |1 is obsolete| | --- Comment #18 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71042&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:25:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:25:53 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-RtNOSyINhY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71032|0 |1 is obsolete| | --- Comment #16 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71043&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:26:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:26:05 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-BuZdRgkP9i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70993|0 |1 is obsolete| | --- Comment #17 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71044&action=edit Bug 18925: Update schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:26:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:26:18 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-sKdEzt5fta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70994|0 |1 is obsolete| | --- Comment #18 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71045&action=edit Bug 18925: Remove schema files for deleted tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:26:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:26:54 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-A8vfPeUJGH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71033|0 |1 is obsolete| | --- Comment #20 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71047&action=edit Bug 18925: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:26:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:26:44 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-LSJ8WeiQae@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70996|0 |1 is obsolete| | --- Comment #19 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71046&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:30:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:30:09 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-sL8DxDNpUE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68231|0 |1 is obsolete| | --- Comment #8 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71048&action=edit Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:30:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:30:13 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-meso1RFwE7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68232|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71049&action=edit Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:30:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:30:17 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-56pIf0FOsd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68233|0 |1 is obsolete| | --- Comment #10 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71050&action=edit Bug 15522: Add production JS build mode To use, run yarn build (or make js-build) with PRODUCTION=1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:30:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:30:23 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-Hh8BmdoPFO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68234|0 |1 is obsolete| | --- Comment #11 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71051&action=edit Bug 15522: New interface for updated circulation rules Test plan: 1) Make sure all dependencies are applied, and that their DB upgrades have been applied. 2) Build JS (see previous patches for HOWTO). 3) Load .../cgi-bin/koha/admin/policy.pl . 4) Try changing an existing rule (one with a textbox or dropdown). Hit "Save rules", ensure that your changes are saved. 5) Until changes are saved, all cells that are changed or affected by your changes should be highlighted in yellow. 6) Same as above, but deleting a rule by hitting the "x" next to it. 7) Add rows and columns using the "Choose rule..." and "Choose category/item type..." dropdowns. 8) Add rules by clicking the pencil in a currently unset rule cell. Ensure changes are saved. 9) Hit "Cleanup rules"; all redundant rules should be removed. As this only removes rules that are the same as the defaults, this should not change any effective rules. 10) Use the filters at the top right ("Circulation", "Holds" and "Fines") to filter the kinds of rules that are shown. 11) Ensure that any desired library can be shown, including (if selected) all at the same time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:30:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:30:28 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-R3NTVcfeiL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68235|0 |1 is obsolete| | --- Comment #12 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 71052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71052&action=edit Bug 15522: Remove old circulation rules interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 00:31:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jan 2018 23:31:02 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-aP0Qom4uga@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jesse Weaver <pianohacker at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 02:11:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 01:11:17 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-Ab1foEYErt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #11 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71053&action=edit Bug 15794: Add Emoji Picker TEST PLAN --------- 1) apply this patch 2) Run the commands in comment #10 3) Attempt to add emoji tags in OPAC -- some system preferences may need setting 4) run koha qa test tools NOTE: The failure resulting from the click will be a different bug. Also, do not include the emoji picker library, as the PNG files are too large to attach. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 02:12:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 01:12:17 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-E8ZwoFN2iT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from M. Tompsett <mtompset at hotmail.com> --- Remember to apply the dependency first, and run an update, and perhaps even a reset_all just to make sure your data in prepared for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 02:27:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 01:27:31 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-oglZof8pUe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #13 from M. Tompsett <mtompset at hotmail.com> --- Additionally follow up bug that needs creating, updating the about area with the list of One Signal emoji-picker under the MIT and Apache licenses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 05:30:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 04:30:42 +0000 Subject: [Koha-bugs] [Bug 16188] SMS via email not applicable in India due to telecom regulation In-Reply-To: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16188-70-A11Y2OCf90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16188 --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71054&action=edit Bug 16188: Followup - Add message where there are providers. Before patch, the warning is only displayed if the provider list is empty. After the patch, a more pronounced warning is displayed when there is at least one provider. TEST PLAN --------- 1) Apply first patch. 2) restart_all 3) Warning is visible in Patron preferences for setting SMS::Driver::Email. 4) Set it to Email anyways. 5) SMS Providers becomes visible in Administration 6) Warning is visible when there are no providers. 7) Create a provider. -- warning disappears. 8) apply this second patch 9) restart_all 10) Reload the SMS Providers page 11) There is now a very visible warning. 12) Run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 07:57:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 06:57:02 +0000 Subject: [Koha-bugs] [Bug 20061] koha-common is not pulling libsearch-elasticsearch-perl In-Reply-To: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20061-70-Kdh70AsjvQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20061 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There has been talk about getting ElasticSearch production ready for 18.05 - I think if that is the goal, we should ship with the dependency. Is it hard to pack or are there other reasons against it? Size? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 07:57:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 06:57:42 +0000 Subject: [Koha-bugs] [Bug 20062] Remove support for Internet Explorer 7 in the staff client In-Reply-To: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20062-70-om9aO3UfST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20062 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Should we add a note for the release notes here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:02:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:02:59 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-rKtjhk8F0T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Isn't bug 19888 a duplicate? *** This bug has been marked as a duplicate of bug 19888 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:02:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:02:59 +0000 Subject: [Koha-bugs] [Bug 19888] "Overdue Notices" email sent to KohaAdminEmailAddress should be optional In-Reply-To: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19888-70-yuqaFgGrsW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 20076 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:03:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:03:40 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-NwpTIQYGJS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:03:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:03:58 +0000 Subject: [Koha-bugs] [Bug 19888] "Overdue Notices" email sent to KohaAdminEmailAddress should be optional In-Reply-To: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19888-70-bm1uTVJYTd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 20076 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:03:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:03:58 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-RFPWITeB1t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 19888 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:04:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:04:52 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-L6Fhdyfotq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Please create a system preference for this behaviour instead of just silently removing a feature some libraries rely on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:06:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:06:05 +0000 Subject: [Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus. In-Reply-To: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20078-70-DRLXccbXZb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:12:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:12:18 +0000 Subject: [Koha-bugs] [Bug 20094] gather_print_notices.pl uses first language in opaclanguages syspref but first cannot be configured In-Reply-To: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20094-70-AdvG10zANF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20094 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, should it not use the setting from the patron record? And as a fallback the language added to the default section of notices? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:13:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:13:42 +0000 Subject: [Koha-bugs] [Bug 20096] Regarding duplicate data in statistics and logs data In-Reply-To: <bug-20096-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20096-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20096-70-rMdrgjgyI8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20096 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |enhancement --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi, thx for filing! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:18:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:18:03 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-fk2baq6kpc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Noticing this is PQA :) Should we prepare a wiki page with instructions to go with it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:20:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:20:41 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-Cfz4hSsnN3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #61 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi David, we've always been keen on this one. If you have something to submit, I'd be interested in testing. As we work in a union catalog setting (union catalog is 'master'), Koha's missing ability to protect fields and subfields from being overwritten is sometimes a problem for us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:55:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:55:51 +0000 Subject: [Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted In-Reply-To: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19559-70-AXPLIBsokR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 08:58:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 07:58:57 +0000 Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19580-70-nF78pxYqYC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 09:05:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 08:05:15 +0000 Subject: [Koha-bugs] [Bug 16660] Elasticsearch broken if OpacSuppression is activated In-Reply-To: <bug-16660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16660-70-2eekkpzjla@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16660 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Too tuchy to push now in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 09:10:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 08:10:24 +0000 Subject: [Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category In-Reply-To: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19921-70-lOMtJmcB7z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 09:13:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 08:13:12 +0000 Subject: [Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded In-Reply-To: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19911-70-MTpCpptAaE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 09:27:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 08:27:55 +0000 Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18915-70-uXKdBili7G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #28 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 11:31:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 10:31:53 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-EELZGXAcxD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #62 from David Gustafsson <glasklas at gmail.com> --- Hi! The code can be found here, but there are some parts (help section, tests, user UI) that has not really been adjusted for the new code. Have performed some limited manual testing and seems to work, but it will probably be confusing to configure for someone who has not looked through the code first: https://github.com/ub-digit/Koha/tree/bug_14957 I will try to clean up, make ui more intuitive, and document the functionality, but right now as previously noted there is not enough time for me to do this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 11:37:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 10:37:52 +0000 Subject: [Koha-bugs] [Bug 20099] New: Filtering by Library returns incorrect results Message-ID: <bug-20099-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20099 Bug ID: 20099 Summary: Filtering by Library returns incorrect results Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dch at interleaf.ie QA Contact: testopia at bugs.koha-community.org I have 3 libraries; AB; AB_C and AB_D If I Refine Search for Holding Library AB_C I get the correct results, all biblios which have at least one item in AB_C; similarly for Holding Library AB_D but if I Refine Search for Holding Library AB I get all biblios which have at least one item in AB, or AB_C or AB_D. The system is treating AB_C and AB_D as subsets of AB but AB_C is a completely different value to AB. The problem is the same in the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 11:39:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 10:39:37 +0000 Subject: [Koha-bugs] [Bug 20099] Filtering by Library returns incorrect results In-Reply-To: <bug-20099-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20099-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20099-70-J65lfzpWkJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20099 Daphne Hoolahan <dch at interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 CC| |bc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 11:44:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 10:44:36 +0000 Subject: [Koha-bugs] [Bug 20094] gather_print_notices.pl uses first language in opaclanguages syspref but first cannot be configured In-Reply-To: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20094-70-p6GXPqR4P0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20094 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Default isn't defined anywhere though, it just means to use the notices marked as default, and we don't have that for print notices. We could also add a syspref for 'DefaultLanguage', or just a checkbox when selecting languages to specify one as the default and force that to be saved first in the pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 12:06:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 11:06:18 +0000 Subject: [Koha-bugs] [Bug 18312] Export is broken unless a file is supplied In-Reply-To: <bug-18312-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18312-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18312-70-tlUMDa4VvL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 Ahmad Najeh <ahmad.najeh at majancollege.edu.om> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED CC| |ahmad.najeh at majancollege.ed | |u.om Resolution|FIXED |--- --- Comment #17 from Ahmad Najeh <ahmad.najeh at majancollege.edu.om> --- Hi, We have koha version "'when I tried to export record per item type I got this message Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'biblioitems.itemtype' in 'where clause' at /usr/share/koha/lib/Koha/Objects.pm line 150 For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. Anybody can help?Please. Thanks Ahmad -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 13:12:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 12:12:59 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20098-70-4SCnNt18BH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 13:23:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 12:23:21 +0000 Subject: [Koha-bugs] [Bug 20094] gather_print_notices.pl uses first language in opaclanguages syspref but first cannot be configured In-Reply-To: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20094-70-AU1ljmLC4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20094 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, will take another look at the GUI tonight - we don't have the version yet with multi-lang notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 14:28:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 13:28:54 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-lDyYyVE73y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70944|0 |1 is obsolete| | Attachment #70945|0 |1 is obsolete| | Attachment #70946|0 |1 is obsolete| | Attachment #70947|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71055&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 14:29:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 13:29:51 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-ObVKhGEpLB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71057&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically ILL module styles. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 14:29:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 13:29:54 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-4RR3eobldz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71058&action=edit Bug 19474: (follow-up) Convert staff client CSS to SCSS This patch brings staff-global.scss up to date with changes which have been recently committed to staff-global.css, specifically staff client responsiveness improvements (Bug 19851). Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 14:29:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 13:29:57 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-faAMOCtTee@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71059&action=edit Bug 19474: (QA follow-up) Fix sass lint yaml configuration Test plan: QA tools should report green on the .sass-lint.yml file now Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 14:29:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 13:29:43 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-6ffXB3ESQt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71055|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71056&action=edit Bug 19474: Convert staff client CSS to SCSS This patch converts staff-global.css to Sass, using SCSS syntax. This changes the build process for Koha to include installation and execution of yarn to install npm dependencies and run SCSS -> CSS conversion. To test, apply the patch and run the following: $ sudo apt-get install nodejs npm [not necessary in kohadevbox] $ sudo npm install -g yarn $ yarn install $ yarn build Clear your browser cache if necessary and confirm that CSS styling throughout the staff client looks correct. The "yarn build" command triggers a gulp process which compiles SCSS to CSS, adds automatic vendor-prefixing, and minifies the resulting CSS file. There is also a "yarn css" command available which might be used by developers who are making changes to SCSS. This command does two things differently: 1. Adds .css.map files which aid CSS debugging using in-browser inspector tools. 2. Compiles staff-global.css without minification. It can be useful to see unminified CSS during development, especially to see how SCSS compiles. This patch adds a configuration file for sass-lint, .sass-lint.yml. Currently this configuration is not used during the build process but can be used in a code editor which supports linting. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 14:31:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 13:31:30 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-4pfhEMoIHF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #16) > Noticing this is PQA :) Should we prepare a wiki page with instructions to > go with it? Yes, that seems like an excellent idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 14:47:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 13:47:10 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18786-70-jIEol03RFR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #24) > What I am not sure about is the relation to the already existing SIP payment > types - will both work together nicely for reports etc? Yes they will! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 15:04:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 14:04:58 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-dVpX9x6DOg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #23 from Owen Leonard <oleonard at myacpl.org> --- https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 15:11:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 14:11:55 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-KXJmFav9uw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Failed QA --- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> --- This works, but it generates new HTML validation errors: > Error: Bad value > /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&format=csv&report_id=2&reportname=Test? &sql_params=foo? > for attribute href on element a: Tab, new line or carriage return found. Please fix this. Also, please fix the commit message: - "Bug XXXXX -" should be "Bug XXXXX:" according to https://wiki.koha-community.org/wiki/Commit_messages - Bug's URL should be removed (it's wrong) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 15:36:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 14:36:20 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-japdSvGXj4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 15:36:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 14:36:23 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-kMmrXxrJS7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70639|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71060&action=edit Bug 18497: Use report id to retrieve saved SQL instead of passing param This patch takes some of the code when executing report and moves it to a sub to be reused when downloading To test: 1 - Run some very long report (see comment #1) 2 - Try to download, erk! 3 - Apply patch 4 - Run report, results hould not have changed 5 - Try to download, success! 6 - Ensure reports work as before Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 15:36:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 14:36:27 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-pDV0CtkBhw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71061&action=edit Bug 18497: (follow-up) Chomp newlines in BLOCK To test: Run report Validate results page at: https://validator.w3.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 15:56:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 14:56:40 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-sdx4vJ7Xuj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- You are re-adding subroutines that have been removed from the codebase, this is definitely the wrong way. Use the new methods added to the Koha modules instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 15:57:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 14:57:14 +0000 Subject: [Koha-bugs] [Bug 19976] data restoration in newly installed koha 17.11.X In-Reply-To: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19976-70-tajdSprV7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19976 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 15:57:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 14:57:48 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-gVJxmeKtA4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to M. Tompsett from comment #13) > Additionally follow up bug that needs creating, updating the about area with > the list of One Signal emoji-picker under the MIT and Apache licenses. Mark, I will add your signature to the version in my github. BTW, I've just updated the patch so the emoji picker works on the results page too! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 16:06:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 15:06:10 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-OqjMFr44Lp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71053|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 16:07:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 15:07:45 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-RkCG4ii76U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #21 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71062&action=edit Bug 18736: (follow-up) fix wrong call to _get_rounding_sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 16:10:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 15:10:51 +0000 Subject: [Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table In-Reply-To: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18477-70-HSFYTrHlOp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #18) > Pushed? Indeed! Commit id 85b0424eb704d416950510c30b41a10ce56cbc3b in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 16:27:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 15:27:07 +0000 Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron category report In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19669-70-vKUwjeqO07@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #10) > (In reply to Kyle M Hall from comment #9) > > Created attachment 70030 [details] [review] [review] > > Bug 19669 [QA Followup] - Remove itemstypes.plugin > > > > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> > > Kyle, Are you sure about that? > If yes we should remove it on a specific bug report, as well as the > reports/manager.pl stuffs. Oops, I forgot to remove this commit before the push, I am going to revert it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 16:27:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 15:27:58 +0000 Subject: [Koha-bugs] [Bug 20092] Link for deleted report itemtypes.plugin still in the UI In-Reply-To: <bug-20092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20092-70-1CbDOulzWc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20092 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I pushed commit 7140a5e4ecc68759c1bee04571386f9cc9a16d92 Bug 19669: (QA follow-up) Remove itemstypes.plugin but it was a mistake, I am going to revert it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 16:42:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 15:42:05 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-bUw9ockDef@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #22 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 71063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71063&action=edit Bug 18736 (follow-up) Use CAST instead of CEIL for appropriate rounding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 16:49:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 15:49:21 +0000 Subject: [Koha-bugs] [Bug 20068] Warn on OPAC homepage if not logged in due to OPAC dashboard In-Reply-To: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20068-70-2sdcAbR9nJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20068 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 16:57:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 15:57:49 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-nKrYUR6ZIs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #23 from M. Tompsett <mtompset at hotmail.com> --- The only thing lacking is test coverage of C4::Budgets::GetBudgetsPlanCell, where some changes were made. This would be a Failed QA, but I know Nick is creating an improve test coverage bug elsewhere to link here, right? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:09:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:09:48 +0000 Subject: [Koha-bugs] [Bug 20101] New: Cronjob automatic_item_modification_by_age.pl does not log run in action logs Message-ID: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Bug ID: 20101 Summary: Cronjob automatic_item_modification_by_age.pl does not log run in action logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:09:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:09:58 +0000 Subject: [Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs In-Reply-To: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20101-70-UiqalhXP32@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:11:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:11:50 +0000 Subject: [Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs In-Reply-To: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20101-70-iHufyTIPSK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:11:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:11:53 +0000 Subject: [Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs In-Reply-To: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20101-70-WLu9MXFIXf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71064&action=edit Bug 20101 - Cronjob automatic_item_modification_by_age.pl does not log run in action logs C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. Test Plan: 1) Apply this patch 2) Enable CronjobLog 3) Run automatic_item_modification_by_age.pl succesfully 4) Note the run is noted in the action logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:20:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:20:44 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-Hsq2Mj9LyK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #5) > $dbh->do("UPDATE branchtransfers SET datearrived = NOW(), comments = ? > WHERE itemnumber = ?", undef, "Canceled, new transfer from $frombranch to > $tobranch created", $itemnumber); > > We should at least limit this update by adding datearrived IS NULL. No need > to update here all arrived items. > In this case you might even wonder if you should not DELETE those records > instead? > I am wondering if transferbook (the sub calling ModItemTransfer) should > check if there is no open transfer in the table. It is possible to add > multiple transfers by selecting different destinations. What do you think? Good idea. I'll submit a followup for that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:23:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:23:25 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-uvjSPy0uyR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68574|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71065&action=edit Bug 19530 - Added commentary for last test when prove -v Before patch, prove -v had no comment for the last test. After patch, it says something in line with second last test. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:23:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:23:32 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-MorfSblyOV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71066&action=edit Bug 19530 - Don't update the date arrived for closed transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:23:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:23:40 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-DH7Nvf8A53@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:26:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:26:44 +0000 Subject: [Koha-bugs] [Bug 19530] Prevent multiple transfers from existing for one item In-Reply-To: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19530-70-Ns2uUniGe4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19530 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- > > I am wondering if transferbook (the sub calling ModItemTransfer) should > > check if there is no open transfer in the table. It is possible to add > > multiple transfers by selecting different destinations. What do you think? I'm not sure what you mean. How do you select multiple destination? Do you mean to give feedback that a previous transfer was closed? If so I think we should put that out of scope for this bug and create a new bug report to add user feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:27:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:27:59 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn't appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-eZ46zZ8BNJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |gracesmythh at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:28:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:28:22 +0000 Subject: [Koha-bugs] [Bug 20041] ILL module missing from more menu in staff when activated In-Reply-To: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20041-70-hVIVZGnTdO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |liz at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:35:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:35:45 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-lbN5DZBmc9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18314 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 [Bug 18314] Account lockout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:35:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:35:45 +0000 Subject: [Koha-bugs] [Bug 18314] Account lockout In-Reply-To: <bug-18314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18314-70-68pHcbsz9c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:38:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:38:31 +0000 Subject: [Koha-bugs] [Bug 18964] Add a --debugger flag to koha-plack In-Reply-To: <bug-18964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18964-70-NTUlbD4yXm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18964 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:41:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:41:01 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-VtGEENpaJU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- .gitignore is not tracked yet, so I get: error: The following untracked working tree files would be overwritten by merge: .gitignore Please move or remove them before you merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:54:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:54:49 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-KSNa0fjGwh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What about the staff interface? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:54:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:54:37 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-aA4nu2sLl1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What about the staff interface? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 17:57:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 16:57:34 +0000 Subject: [Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates In-Reply-To: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20053-70-NX4XzU85Sk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Jonathan Druart from comment #6) > What about the staff interface? The staff client templates should be similarly modified, but with so many "move template javascript to the footer" patches in various stages of QA I think it should wait. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:00:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:00:21 +0000 Subject: [Koha-bugs] [Bug 20041] ILL module missing from more menu in staff when activated In-Reply-To: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20041-70-60YPhffo1k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Please make sure the commit messages start with "Bug 12345: " https://wiki.koha-community.org/wiki/Commit_messages#Examples -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:02:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:02:00 +0000 Subject: [Koha-bugs] [Bug 20102] New: Remove attribute "text/css" for <style> element used in staff client templates Message-ID: <bug-20102-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20102 Bug ID: 20102 Summary: Remove attribute "text/css" for <style> element used in staff client templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. The type attribute is optional, and when none is provided it defaults to "text/css" - https://www.w3.org/TR/html5/document-metadata.html#element-attrdef-style-type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:02:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:02:00 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-tvV5KntEY3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20102 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:02:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:02:46 +0000 Subject: [Koha-bugs] [Bug 20054] Remove attribute "text/css" for <style> element used in the OPAC templates In-Reply-To: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20054-70-3BZZLdIINE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- I have submitted Bug 20102 - Remove attribute "text/css" for <style> element used in staff client templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:07:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:07:17 +0000 Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course reserves In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19230-70-elmhADEMv0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71067&action=edit Bug 19230: (follow-up) Preventing warn when deleting course Simplify 'unless' statement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:12:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:12:06 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-l8CULG8IQa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 --- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Do we need it in patroncards/manage.tt as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:15:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:15:00 +0000 Subject: [Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc In-Reply-To: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20051-70-sBuSpeGzHu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- git grep tells me we are going to affect that line: koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt: $('ul[aria-labelledby="drop3"]').html('<li><a class="toplinks">You cannot change your branch or logout while using offline circulation</a></li>'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:17:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:17:22 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20072-70-XdLxzKjqH1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Please make sure the commit messages start with "Bug 12345: " https://wiki.koha-community.org/wiki/Commit_messages#Examples -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:18:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:18:11 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-vDVsCfPIHP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Please make sure the " (QA follow-up) " flag is correct https://wiki.koha-community.org/wiki/Commit_messages#Examples -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:19:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:19:24 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-x5PJNxOhNo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Please make sure the commit messages start with "Bug 12345: " Please make sure the "follow-up" and " (QA follow-up) " flags are correct https://wiki.koha-community.org/wiki/Commit_messages#Examples -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:20:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:20:06 +0000 Subject: [Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs In-Reply-To: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20101-70-Q2OulN5c6T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:20:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:20:09 +0000 Subject: [Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs In-Reply-To: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20101-70-bry1riHSZB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71064|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71068&action=edit Bug 20101 - Cronjob automatic_item_modification_by_age.pl does not log run in action logs C4::Log::cronlogaction() was never implemented in automatic_item_modification_by_age.pl. Test Plan: 1) Apply this patch 2) Enable CronjobLog 3) Run automatic_item_modification_by_age.pl succesfully 4) Note the run is noted in the action logs NOTE: Create rule in tools! Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:22:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:22:07 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-xsdVOD3C3m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #24) > .gitignore is not tracked yet, so I get: > > error: The following untracked working tree files would be overwritten by > merge: > .gitignore > Please move or remove them before you merge. Sounds like you added your own .gitignore file. Just remove it and everything should apply just fine. You could add a followup to merge the two versions if what you have in yours would be generally useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:25:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:25:39 +0000 Subject: [Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type In-Reply-To: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13990-70-NwqPI6tGr2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:25:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:25:45 +0000 Subject: [Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API In-Reply-To: <bug-16213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16213-70-c0ZV3KK7xF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:25:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:25:51 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17084-70-7u9SbtyEbk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:25:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:25:57 +0000 Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course reserves In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19230-70-ZMfvWrW3HE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:26:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:26:03 +0000 Subject: [Koha-bugs] [Bug 19827] checkuniquemember is exported from C4::Members but has been removed In-Reply-To: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19827-70-OZ0kHvUnhc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:26:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:26:09 +0000 Subject: [Koha-bugs] [Bug 19975] Tag cloud searching does not working In-Reply-To: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19975-70-9DfAWwE0b9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:26:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:26:14 +0000 Subject: [Koha-bugs] [Bug 19986] 'Server name' doesn't appear as required when creating new z39.50/sru server In-Reply-To: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19986-70-VBRvLX0Dht@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19986 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:26:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:26:20 +0000 Subject: [Koha-bugs] [Bug 20003] Result summary of remaining checkouts items not displaying. In-Reply-To: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20003-70-6klj12rw74@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:26:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:26:26 +0000 Subject: [Koha-bugs] [Bug 20041] ILL module missing from more menu in staff when activated In-Reply-To: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20041-70-8Wh7ZKdJt3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:26:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:26:31 +0000 Subject: [Koha-bugs] [Bug 20056] Uninitialized warn in cmp_sysprefs.pl In-Reply-To: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20056-70-3qwq7SM9SQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20056 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:26:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:26:46 +0000 Subject: [Koha-bugs] [Bug 20091] FailedLoginAttempts is not part of NorwegianPatronDatabase pref group In-Reply-To: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20091-70-kwN19CDns1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20091 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:26:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:26:40 +0000 Subject: [Koha-bugs] [Bug 20088] Use of uninitialized value in array element in svc/holds In-Reply-To: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20088-70-6js8XZMbmt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20088 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:26:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:26:57 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20072-70-S6WZca2JjQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:27:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:27:05 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20072-70-5Lte1DPsTk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:27:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:27:18 +0000 Subject: [Koha-bugs] [Bug 20072] Fix build-git-snapshot for Debian source format quilt In-Reply-To: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20072-70-mhpmJ9KZCB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Patch pushed to master for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:37:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:37:12 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-MGLgw9tlqt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I thought it was not a good idea to commit the .gitignore file, but actually it does. .git/info/exclude must be used for local modifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:38:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:38:32 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (stable) In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17108-70-6YXMzYhmk7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sending to RMaints queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:46:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:46:30 +0000 Subject: [Koha-bugs] [Bug 8872] Improve encoding for xslt files, showmarc and opac-showmarc In-Reply-To: <bug-8872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8872-70-d01aNjVuel@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8872 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20083 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:57:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:57:15 +0000 Subject: [Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs In-Reply-To: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20101-70-uw679pc3RT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71069&action=edit Bug 20101: Followup - quiet warns If the user has never run the tools, the system preference won't exist, the JSON will be empty, and warns will trigger. TEST PLAN --------- 1) back up systempreferences and log files as desired. 2) in sql client: S> delete from systempreferences where variable='automatic_item_modification_by_age_configuration'; S> quit 3) run the following commands on a kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 4) test the first patch 5) cat /var/log/koha/kohadev/plack-error.log -- notice there is a nasty warn 6) apply this patch 7) repeat steps 3-5 -- this time no nasty warns 8) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 18:59:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 17:59:48 +0000 Subject: [Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs In-Reply-To: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20101-70-aUk6yUjkvR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71069|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 71070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71070&action=edit Bug 20101: Followup - quiet warns If the user has never run the tools, the system preference won't exist, the JSON will be empty, and warns will trigger. TEST PLAN --------- 1) back up systempreferences and log files as desired. 2) in sql client: S> delete from systempreferences where variable='automatic_item_modification_by_age_configuration'; S> quit 3) run the following commands on a kohadevbox: echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 4) test the first patch 5) cat /var/log/koha/kohadev/plack-error.log -- notice there is a nasty warn 6) apply this patch 7) repeat steps 3-5 -- this time no nasty warns 8) run koha qa test tools Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 19:21:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 18:21:34 +0000 Subject: [Koha-bugs] [Bug 20103] New: Remove Readonly::XS Message-ID: <bug-20103-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 Bug ID: 20103 Summary: Remove Readonly::XS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com >From the Readonly CPAN page: "Install this module, but do not use it. ... Programs that you write do not need to know whether Readonly::XS is installed or not. They should just "use Readonly" and let Readonly worry about whether or not it can use XS. If the Readonly::XS is present, Readonly will be faster. If not, it won't. Either way, it will still work, and your code will not have to change." This removes the Readonly::XS from the PerlDependencies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 19:30:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 18:30:14 +0000 Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS In-Reply-To: <bug-20103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20103-70-sIZlXtKsRh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 19:30:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 18:30:17 +0000 Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS In-Reply-To: <bug-20103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20103-70-yaB1ikYcGZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71071&action=edit Bug 20103: Remove Readonly::XS from PerlDependencies While having Readonly::XS is a good thing on slower systems the CPAN page for Readonly says it isn't required to be used directly, so we don't need to check for it. Additionally, even reading /usr/share/perl5/Readonly.pm you see "# Modern perl doesn't need Readonly::XS" on an if statement checking for version 5.8! Koha requires 5.20 (see C4::Log::cronlogaction's use of caller). TEST PLAN --------- Can you run a fresh install? Does the about page list Readonly::XS? It shouldn't after the patch. Run koha qa test tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 19:42:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 18:42:12 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18198-70-Qk9i4E2YKh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Please provide tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 19:46:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 18:46:09 +0000 Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again) In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16588-70-0LdkmpMyNZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #34 from M. Tompsett <mtompset at hotmail.com> --- The removal of Readonly::XS is actually a separate problem, in that even if we were keeping Readonly, we shouldn't be using or checking for Readonly::XS. See bug 20103 instead. This will conflict with the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 19:46:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 18:46:23 +0000 Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again) In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16588-70-S7E6ddn2Uk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20103 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 19:46:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 18:46:23 +0000 Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS In-Reply-To: <bug-20103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20103-70-yOZjYwyXs3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16588 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 19:47:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 18:47:12 +0000 Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS In-Reply-To: <bug-20103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20103-70-8ENSaoaU6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 19:50:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 18:50:18 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12932-70-vtEF4YOKuw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | Status|NEW |ASSIGNED CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:20:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:20:53 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-qOFhS1nPdf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Did we discuss and vote this change in a dev meeting or the mailing list (I do not find track of that)? I do not understand why the .css is no longer part of the codebase. Do not you think RM should generate it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:26:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:26:12 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12932-70-k7uhcwRQYk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71072&action=edit Bug 12932: When all modules installed, Perl version check ignored The description in comment #0 is quite true, because the scope of the $checkmodule variable is local to just the module checking. If we change the scope, we can include the perl check as part of the new scope, and thus properly set its value. As Debian Jessie, Stretch and Ubuntu Xenial all have good versions of Perl by default, the easiest way to test this is to: - make sure to have some optional modules not installed. - change the system preference 'Version' to one just under the current version in your SQL client. - modify the version check line to 5.030000 - restart_all and try going to the staff client. -- This should inform you that your perl version is bad. - git reset hard back to origin/master - apply the patch - modify the version check line to 5.030000 - change the system preference 'Version' to one just under the current version in your SQL client. - restart_all and try going to the staff client. -- This should trigger the patch, and you should be informed your perl version is bad. - git reset hard back to origin/master - apply the patch - run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:30:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:30:13 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-4V4Au2OTxB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #28 from Owen Leonard <oleonard at myacpl.org> --- I think most of the discussion so far centered around a different bug, Bug 15522. We discussed the idea of implementing this kind of workflow on the mailing list here: http://lists.koha-community.org/pipermail/koha-devel/2017-August/043910.html ...and during a dev meeting: http://meetings.koha-community.org/2017/development_irc_meeting_9_august_2017.2017-08-09-22.00.log.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:31:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:31:33 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12932-70-izoxuWHrXL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- sudo apt-get remove libwebservices-ils-perl -- it's currently the only one that is really not packaged with koha-common. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:37:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:37:36 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12932-70-peueCqZ1UR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:37:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:37:38 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12932-70-PvA8Mjgj1g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71072|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71073&action=edit Bug 12932: When all modules installed, Perl version check ignored The description in comment #0 is quite true, because the scope of the $checkmodule variable is local to just the module checking. If we change the scope, we can include the perl check as part of the new scope, and thus properly set its value. As Debian Jessie, Stretch and Ubuntu Xenial all have good versions of Perl by default, the easiest way to test this is to: - make sure to have some optional modules not installed. - change the system preference 'Version' to one just under the current version in your SQL client. - modify the version check line to 5.030000 - restart_all and try going to the staff client. -- This should not inform you that your perl version is bad. - git reset hard back to origin/master - apply the patch - modify the version check line to 5.030000 - change the system preference 'Version' to one just under the current version in your SQL client. - restart_all and try going to the staff client. -- This should trigger the patch, and you should be informed your perl version is bad. - git reset hard back to origin/master - apply the patch - run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:44:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:44:46 +0000 Subject: [Koha-bugs] [Bug 18312] Export is broken unless a file is supplied In-Reply-To: <bug-18312-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18312-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18312-70-2QaVRNC8mH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18312 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Ahmad Najeh from comment #17) > Software error: > DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column > 'biblioitems.itemtype' in 'where clause' at > /usr/share/koha/lib/Koha/Objects.pm line 150 > For help, please send mail to the webmaster ([no address given]), giving > this error message and the time and date of the error. Please open a new bug report with more information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:46:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:46:41 +0000 Subject: [Koha-bugs] [Bug 20104] New: Update minimum version of Perl to 5.20 Message-ID: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Bug ID: 20104 Summary: Update minimum version of Perl to 5.20 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The C4::Log::cronlogaction uses caller, which did not exist prior to 5.20. And since Xenial, Debian 8, and Debian 9 all have versions at least 5.20 (the current version of perl is 5.26), it makes sense to update the version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:47:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:47:05 +0000 Subject: [Koha-bugs] [Bug 20104] Update minimum version of Perl to 5.20 In-Reply-To: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20104-70-gWdglYQUk8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | Status|NEW |ASSIGNED Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:47:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:47:49 +0000 Subject: [Koha-bugs] [Bug 20104] Update minimum version of Perl to 5.20 In-Reply-To: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20104-70-ErkETvq8nj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:47:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:47:49 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12932-70-WRnS4xaHa8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20104 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 [Bug 20104] Update minimum version of Perl to 5.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:47:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:47:51 +0000 Subject: [Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined In-Reply-To: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19772-70-XGB7jEwOqC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Aleisha, yes it is what I describe :) The message says "everything is ok and sent" whereas the email has not been sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:48:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:48:42 +0000 Subject: [Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined In-Reply-To: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19772-70-rwfzDYOrOK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED Severity|major |normal --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Maybe we should disable the feature if the notice template is not configured. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:51:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:51:22 +0000 Subject: [Koha-bugs] [Bug 20104] Update minimum version of Perl to 5.20 In-Reply-To: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20104-70-nBkycmHq3B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:57:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:57:52 +0000 Subject: [Koha-bugs] [Bug 20070] autoBarcode Increment Value In-Reply-To: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20070-70-mbrBQYfoBz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20070 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Confirmed, it certainly comes from that line: 108 $head =~ s/\d{4}$//; # else strip the old yymm in C4::Barcodes::hbyymmincr::process_head This value of autoBarcode is deprecated and should not be used. Take a look at the notice in the bottom of the file: """ This format is deprecated and SHOULD NOT BE USED. It is fairly clear the originator of the format did not intend to accommodate multiple branch libraries, given that the format caps the available namespace to 10,000 barcodes per year TOTAL... Also, the question of what to do with an item that changes branch is unsettled... Nothing prevents the barcode from working fine, but it will look out of place with the old branchcode in it. Rebarcoding a single item is trivial, but if you consider the scenario of branches being consolidated, it is an unnecessary. burden to force the rebarcoding of thousands of items, especially when the format will limit you to under 10,000 on the year! The main purpose of the format seems to be to get the branch code into the barcode. This is wholly unnecessary, since the barcodes can be printed with the branchcode directly on it, without it being part of the barcode itself... The API for this module should exist almost exclusively through C4::Barcodes... One novel aspect of this format is the fact that the barcode is tied to a branch... """ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:58:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:58:26 +0000 Subject: [Koha-bugs] [Bug 20104] Update minimum version of Perl to 5.20 In-Reply-To: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20104-70-JNSccDjUXn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:58:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:58:28 +0000 Subject: [Koha-bugs] [Bug 20104] Update minimum version of Perl to 5.20 In-Reply-To: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20104-70-dy4SdRJ2Sk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71074&action=edit Bug 20104: Update minimum version of Perl to 5.20 This patch not only updates the version check, but repurposes the perlversion parameter, so as to not have to retranslate templates again when the version number changes after this. The changes are very self-evident. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 20:58:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 19:58:29 +0000 Subject: [Koha-bugs] [Bug 20070] autoBarcode broken for hbyymmincr if branchcode is numeric In-Reply-To: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20070-70-HKYfdMDBOm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20070 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|autoBarcode Increment Value |autoBarcode broken for | |hbyymmincr if branchcode is | |numeric -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:03:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:03:28 +0000 Subject: [Koha-bugs] [Bug 20095] automatic_item_modification_by_age.pl not logged In-Reply-To: <bug-20095-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20095-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20095-70-CV1L2ShvXX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20095 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:04:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:04:14 +0000 Subject: [Koha-bugs] [Bug 20099] Filtering by Library returns incorrect results In-Reply-To: <bug-20099-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20099-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20099-70-qTmfwGD7T6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20099 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|OPAC |Searching Version|17.11 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:20:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:20:31 +0000 Subject: [Koha-bugs] [Bug 20095] automatic_item_modification_by_age.pl not logged In-Reply-To: <bug-20095-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20095-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20095-70-E4q7eqMlqs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20095 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from George Williams (NEKLS) <george at nekls.org> --- *** This bug has been marked as a duplicate of bug 20101 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:20:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:20:31 +0000 Subject: [Koha-bugs] [Bug 20101] Cronjob automatic_item_modification_by_age.pl does not log run in action logs In-Reply-To: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20101-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20101-70-hGekAfgCj2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20101 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #5 from George Williams (NEKLS) <george at nekls.org> --- *** Bug 20095 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:23:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:23:41 +0000 Subject: [Koha-bugs] [Bug 20105] New: Ability to allow Article Request to be without an attached record Message-ID: <bug-20105-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20105 Bug ID: 20105 Summary: Ability to allow Article Request to be without an attached record Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: kyle at bywatersolutions.com Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A library inquired about allowing article requests to work similarly to purchase suggestions. Instead of having patron search for the subscription or record that they would like the article from- instead they would like the patron to fill out a form (as they would in a purchase suggestion) with fields (from the system preference : ArticleRequestsMandatoryFields, ArticleRequestsMandatoryFieldsItemOnly, ArticleRequestsMandatoryFieldsRecordOnly Currently when the Request Article link is clicked, it brings up the opac-request-article.pl with a biblio number. This may have a dual purpose - it could potentially be used for ILL material form for a library also! Kelly Bywater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:24:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:24:05 +0000 Subject: [Koha-bugs] [Bug 20105] Ability to allow Article Request to be without an attached record In-Reply-To: <bug-20105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20105-70-lwc3Dvf74q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20105 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:30:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:30:25 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20098-70-dOq8oBMbco@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:30:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:30:28 +0000 Subject: [Koha-bugs] [Bug 20098] Inventory: CSV export: itemlost column is always empty In-Reply-To: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20098-70-z1WisPMIGj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20098 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71023|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71075&action=edit Bug 20098: Inventory tool: CVS export: fix itemlost column It was mapped with "lost" instead of "itemlost". == Test plan == 1. Have a lost item 2. Go to staff:/cgi-bin/koha/tools/inventory.pl 3. Tick "Optional filters" ? "items.itemlost" ? "name of Authorized values for the lost state" 4. Tick "Export to CSV file" 5. Submit 6. Open the CSV 7. Check that the lost item is in the list 8. You should observe that the "Lost status" column is empty for all items This is the problem 9. Apply this patch 10. Click submit to re-export the CSV 11. Open the CSV 12. Check that the lost item is in the list 13. You should observe that the "Lost status" column now filled with the expected values. 14. Smile because it works! :D Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:31:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:31:47 +0000 Subject: [Koha-bugs] [Bug 20106] New: Hea - Add notes to system preferences (administration page, example for geolocation) Message-ID: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20106 Bug ID: 20106 Summary: Hea - Add notes to system preferences (administration page, example for geolocation) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com At the moment we have a nice administration page for Hea, but also have system preferences where you can set those values up for a single library. We should: - Add a note above the preferences to tell people about the administration page - Add an example for UsageStatsGeolocation to make the way to use it more clear. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:42:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:42:37 +0000 Subject: [Koha-bugs] [Bug 20099] Filtering by Library returns incorrect results In-Reply-To: <bug-20099-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20099-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20099-70-hojBsmW8V3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20099 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I have just tested quickly, I have a branchcode "CPL", I search for "d" and use the CPL facet. I get 240 results and the url is http://pro.kohadev.org/cgi-bin/koha/catalogue/search.pl?idx=kw&q=d&sort_by=relevance_dsc&limit=holdingbranch:CPL If I replace CPL with CP, I get the "no result" page Do you recreate this issue on a sandbox? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:45:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:45:55 +0000 Subject: [Koha-bugs] [Bug 20105] Ability to allow Article Request to be without an attached record In-Reply-To: <bug-20105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20105-70-5d3EK4FKpr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20105 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I like the idea, but maybe we'd need to add some more fields then for the source? Like differentiate between the 'source title' and the 'article/chapter title'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:46:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:46:07 +0000 Subject: [Koha-bugs] [Bug 20106] Hea - Add notes to system preferences (administration page, example for geolocation) In-Reply-To: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20106-70-i6iBsSZZ7v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20106 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 21:50:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 20:50:17 +0000 Subject: [Koha-bugs] [Bug 20099] Filtering by Library returns incorrect results In-Reply-To: <bug-20099-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20099-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20099-70-68P5oVyfew@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20099 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think the issue is the underscore. My guess is that Zebra treats it as a space, so you end up with Zebra treating AB_D and AB_C as 2 words. When doing a keyword search or limit on AB it will then naturally return the records from all branches with the 'word' AB. My normal advice is: never use spaces or underscores or - in your codes (library, itemtype, locatio, collection, ...) in Koha, because of how Zebra will treat them. Sometimes you might want that behaviour, but other times it's really not helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 30 22:33:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 21:33:49 +0000 Subject: [Koha-bugs] [Bug 20107] New: Editing a public note in Course Reserves Message-ID: <bug-20107-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20107 Bug ID: 20107 Summary: Editing a public note in Course Reserves Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 71076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71076&action=edit cgi-bin/koha/course_reserves/add_items.pl If you add a public note in the course reserve module in the item on cgi-bin/koha/course_reserves/add_items.pl it will appear on the OPAC. If you need to edit or remove that public note located at cgi-bin/koha/course_reserves/add_items.pl you can click edit under the actions column on cgi-bin/koha/course_reserves/course-details.pl. When editing, the field will appear blank, even though you may have an existing note in there. You can add a new note in the blank field which will replace the existing note. Currently the only way to erase the existing note in there is to create a new note or type a blank space which will remove the existing note. it would be helpful to be able to see what is actually in the note field on cgi-bin/koha/course_reserves/add_items.pl to edit or remove. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 00:32:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 23:32:29 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20060-70-Zz8v7rOlG8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70793|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71078&action=edit Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches The warn comes from undefined C4::Context->userenv->{branch}. Can be triggered by calling mainpage.pl when being logged out in staff. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 00:32:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 23:32:25 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20060-70-KQpWnmlx7A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 00:33:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 23:33:46 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20060-70-aWaNw924nF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- I triggered this with just "localhost:8081" in the address bar in chrome. A url with mainpage did not trigger it for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 00:58:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jan 2018 23:58:52 +0000 Subject: [Koha-bugs] [Bug 3116] ISBD parsing does not preserve subfield order In-Reply-To: <bug-3116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3116-70-OgRNHh35hE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3116 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement Status|Needs Signoff |Failed QA --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- This adds functionality to C4::Biblio. It requires tests. None were provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 01:05:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 00:05:08 +0000 Subject: [Koha-bugs] [Bug 7047] renewing serials note not visible In-Reply-To: <bug-7047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7047-70-3iaoSHzibF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 69474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69474 Bug 7047 - Storing subscription renewal note in suggestion to be displayed on the suggestion page. Review of attachment 69474: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7047&attachment=69474) ----------------------------------------------------------------- ::: C4/Serials.pm @@ +1504,4 @@ > =cut > > sub ReNewSubscription { > + my ( $subscriptionid, $user, $startdate, $numberlength, $weeklength, $monthlength, $note, $branchcode ) = @_; This parameter list is huge. Rather than add another parameter, I would recommend converting it to a hashref. https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_should_be_used_as_arguments Thankfully, it is a very small refactor (git grep ReNewSubscription), and is much easier to maintain or expand in the future. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 01:08:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 00:08:39 +0000 Subject: [Koha-bugs] [Bug 20108] New: Hold Queue Timeout Message-ID: <bug-20108-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20108 Bug ID: 20108 Summary: Hold Queue Timeout Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be good if there were a preference to set a Hold Queue Timeout, where a hold request goes to a branch queue for X amount of days, and if it isn't filled, it goes to the next library queue according to the cost matrix, etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 01:24:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 00:24:42 +0000 Subject: [Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined In-Reply-To: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19772-70-xpQyERDrlm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 --- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Hi Jonathan, Sorry I think I'm understanding the problem now. I'll make a fix where the Checkout Notes feature can't be enabled unless the library also has a CHECKOUT_NOTE notice configured. Patch to come soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 03:13:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 02:13:47 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15869-70-9aEi6lYA12@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- I don't think this is Academy, because line 567 of C4/ImportBatch.pm in master is probably the wrong condition. I think it should be >= 1, not ==1. Read lines 251/252 of tools/manage-marc-import.pl where 4 parameters are passed. This means adding a parameter in the middle is messed up. If the code is cleaned up, then perhaps, but I'm marking this Failed QA, because it reads awful and probably explains why imports are flaky sometimes. Also, it fails to meet the "must have tests" coding guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 03:40:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 02:40:11 +0000 Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19596-70-Oxsvhm2keX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, mtj at kohaaloha.com --- Comment #9 from Mason James <mtj at kohaaloha.com> --- (In reply to Jonathan Druart from comment #7) > Pushed to master for 17.11, thanks to everybody involved! Fridolin, can we get this backported to 17.05.x please :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 03:52:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 02:52:18 +0000 Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with deleted biblio / null biblionumber In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19596-70-vvIe1wu9x8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596 --- Comment #10 from Mason James <mtj at kohaaloha.com> --- (In reply to Mason James from comment #9) > (In reply to Jonathan Druart from comment #7) > > Pushed to master for 17.11, thanks to everybody involved! > > Fridolin, can we get this backported to 17.05.x please :) fyi: it seems this patch can be skipped for 16.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 05:18:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 04:18:51 +0000 Subject: [Koha-bugs] [Bug 20055] New suggestion from OPAC records borrowernumber instead of branchcode In-Reply-To: <bug-20055-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20055-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20055-70-1XUJRQRUXE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20055 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 07:00:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 06:00:29 +0000 Subject: [Koha-bugs] [Bug 20055] New suggestion from OPAC records borrowernumber instead of branchcode In-Reply-To: <bug-20055-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20055-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20055-70-Y2nx4khJGF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20055 Bob Birchall <bob at calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Bob Birchall <bob at calyx.net.au> --- (In reply to Jonathan Druart from comment #1) > Works for me on master and 17.05.06 > > Nothing in the logs? Well, apparently we were running a patch which was needed for mellon/SSO to work. 17.05.x broke the patch, due to an API change to GetMember(). A one line update fixed the error. My understanding is there are no implications for Koha. So I guess we can close this. Thanks Jonathan. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 07:37:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 06:37:31 +0000 Subject: [Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined In-Reply-To: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19772-70-VZZLUzirX3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Could there be a case where a library wants to activate the feature, but use it without email? We have some cases like the suggestions emails where you just delete the notice in that case. Maybe we could just adapt the text a little and remove the error/warning? Making the options dependent seems more hassle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:25:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:25:39 +0000 Subject: [Koha-bugs] [Bug 19483] t/db_dependent/www/* crashes test harness due to misconfigured test plan In-Reply-To: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19483-70-5HswQdizv6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19483 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:28:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:28:51 +0000 Subject: [Koha-bugs] [Bug 19937] Silence warnings t/db_dependent/www/batch.t In-Reply-To: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19937-70-QMj8mVKcaG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:30:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:30:53 +0000 Subject: [Koha-bugs] [Bug 19973] SQL syntax error in uk-UA/mandatory/sample_notices.sql In-Reply-To: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19973-70-15VgSwBo5j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:33:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:33:07 +0000 Subject: [Koha-bugs] [Bug 19968] Undefined subroutine &Date::Calc::Today In-Reply-To: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19968-70-sSV5iWNlrc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:34:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:34:04 +0000 Subject: [Koha-bugs] [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins, part 1 In-Reply-To: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19866-70-7jZFUn50m7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:36:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:36:51 +0000 Subject: [Koha-bugs] [Bug 20109] New: Allow translating "Remove" in Add Fund Message-ID: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 Bug ID: 20109 Summary: Allow translating "Remove" in Add Fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When a user has been added to the fund, the link to "Remove" that user is not translatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:38:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:38:33 +0000 Subject: [Koha-bugs] [Bug 20109] Allow translating "Remove" in Add Fund In-Reply-To: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20109-70-pkU8S6gsaN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71079&action=edit Bug 20109: Allow translating "Remove" in Add Fund When a user has been added to the fund, the link to "Remove" that user is not translatable. Test plan: 1) Install language xx-YY 2) Go to Home -> Administration -> Budgets -> Funds -> Add Fund 3) Add a user to the fund 4) Notice how the "Remove" link after the user's name is not translated 5) Apply patch 6) Look in xx-YY-staff-prog.po, and if needed, translate the msgid "Remove" 7) Update and reinstall the language 8) Do 2 and 3 again. The "Remove" link should now be translated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:41:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:41:24 +0000 Subject: [Koha-bugs] [Bug 17467] Introduce a single koha-zebra script to handle Zebra daemons for instances In-Reply-To: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17467-70-cw3XqDo5h5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #32 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:41:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:41:25 +0000 Subject: [Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra In-Reply-To: <bug-17468-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17468-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17468-70-cChykG9ZU0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468 Bug 17468 depends on bug 17467, which changed state. Bug 17467 Summary: Introduce a single koha-zebra script to handle Zebra daemons for instances https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:41:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:41:25 +0000 Subject: [Koha-bugs] [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style In-Reply-To: <bug-18114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18114-70-5JRkqrXOdO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114 Bug 18114 depends on bug 17467, which changed state. Bug 17467 Summary: Introduce a single koha-zebra script to handle Zebra daemons for instances https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:48:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:48:15 +0000 Subject: [Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible In-Reply-To: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20001-70-C23Uvtx5sQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #25 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Bug 7317 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:53:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:53:38 +0000 Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19771-70-sZLDleeE5x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Those lines has been modified by Bug 18276. If needed for 17.05.x please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 08:55:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 07:55:54 +0000 Subject: [Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor's temporary files, and die In-Reply-To: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19977-70-GU9RNiArr8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 09:02:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 08:02:17 +0000 Subject: [Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/SRU buttons should not show In-Reply-To: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19987-70-wCYZiPxqVU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 09:03:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 08:03:53 +0000 Subject: [Koha-bugs] [Bug 20042] 00-load.t fails when Elasticsearch is not installed In-Reply-To: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20042-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20042-70-Sk1wpz0D7l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20042 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 09:06:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 08:06:28 +0000 Subject: [Koha-bugs] [Bug 19422] kohastructure.sql missing DROP TABLES In-Reply-To: <bug-19422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19422-70-2gjentIOjs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 09:07:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 08:07:25 +0000 Subject: [Koha-bugs] [Bug 19783] Move check_kohastructure.t to db_dependent In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19783-70-c4TRvgnbaB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 09:10:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 08:10:51 +0000 Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display in opac or staff side In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19677-70-ZoTk2Xk6Nx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 09:15:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 08:15:04 +0000 Subject: [Koha-bugs] [Bug 20050] When processing uploaded offline circulation file, "apply directly" option fails In-Reply-To: <bug-20050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20050-70-Q108giGbZ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20050 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Note that even if Plack is enabled, this page is processed directly by Apache : ProxyPass "/cgi-bin/koha/offline_circ/process_koc.pl" "!" This may have some effect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 09:28:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 08:28:53 +0000 Subject: [Koha-bugs] [Bug 16603] Hide option to apply directly when processing uploaded offline circulation file In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16603-70-g75F9cmVwj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 09:46:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 08:46:35 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-GGAbNTbywu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71060|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71080&action=edit Bug 18497: Use report id to retrieve saved SQL instead of passing param This patch takes some of the code when executing report and moves it to a sub to be reused when downloading To test: 1 - Run some very long report (see comment #1) 2 - Try to download, erk! 3 - Apply patch 4 - Run report, results hould not have changed 5 - Try to download, success! 6 - Ensure reports work as before Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 09:46:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 08:46:39 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-caUkbWAgAr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71061|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 71081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71081&action=edit Bug 18497: (follow-up) Chomp newlines in BLOCK To test: Run report Validate results page at: https://validator.w3.org/ Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 09:46:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 08:46:57 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18497-70-4mkvEmmEAD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 10:34:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 09:34:30 +0000 Subject: [Koha-bugs] [Bug 20109] Allow translating "Remove" in Add Fund In-Reply-To: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20109-70-I1vCMaIxls@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 10:34:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 09:34:52 +0000 Subject: [Koha-bugs] [Bug 20109] Allow translating "Remove" in Add Fund In-Reply-To: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20109-70-OGq7ZEfkE8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 10:37:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 09:37:04 +0000 Subject: [Koha-bugs] [Bug 20110] New: Adding same user multiple times to same budget fund Message-ID: <bug-20110-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20110 Bug ID: 20110 Summary: Adding same user multiple times to same budget fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org It is possible to add the same user multiple times into the same budget fund -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 10:39:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 09:39:48 +0000 Subject: [Koha-bugs] [Bug 20110] Adding same user multiple times to same budget fund In-Reply-To: <bug-20110-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20110-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20110-70-0SPm7yHGuC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20110 paxed <pasi.kallinen at joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi |ity.org | Status|NEW |Needs Signoff --- Comment #1 from paxed <pasi.kallinen at joensuu.fi> --- Created attachment 71082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71082&action=edit Fix adding same user to the same budget fund multiple times In javascript, using indexOf to test if a number exists in an array of strings doesn't work, and makes it possible to add the same user multiple times into the same budget fund. Make borrowernumber into string and compare that instead. Test plan: 1) Go to Home -> Administration -> Budgets -> Funds -> Add Fund 2) Add a user to the fund 3) Try to add the same user again to the same fund. No error. 4) Apply patch 5) Do 1, 2, and 3 again. You should now get an error message saying the user is already in the list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 10:58:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 09:58:11 +0000 Subject: [Koha-bugs] [Bug 20111] New: Patron card creator - some strings are not translatable Message-ID: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Bug ID: 20111 Summary: Patron card creator - some strings are not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org Hopefully at least 80% of the fixes and 70% of the test plan of bug 19522 will be reusable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 10:58:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 09:58:40 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-lPJCZf2YNq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20111 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 10:58:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 09:58:40 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20111-70-ZRhqoCj0F4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19522 Assignee|koha-bugs at lists.koha-commun |victor.grousset at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 11:02:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 10:02:35 +0000 Subject: [Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable In-Reply-To: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20111-70-LOp4gurLFr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Component|Tools |I18N/L10N -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 11:03:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 10:03:48 +0000 Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not translatable In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19522-70-EqsUjNlysV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 --- Comment #63 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- (In reply to Jonathan Druart from comment #62) > Do we need it in patroncards/manage.tt as well? Created and took bug 20111 for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 12:53:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 11:53:18 +0000 Subject: [Koha-bugs] [Bug 19279] performance of linked items in search In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19279-70-MoibHey53J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67036|0 |1 is obsolete| | --- Comment #3 from Hugo Agud <hagud at orex.es> --- Created attachment 71083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71083&action=edit Bug 19279 - performance of linked items in search When catalog has fields 773 (461 in UNIMARC), those linked items are fetched for display in search results. Look like the code could be more performant by replacing item search by $9 with direct call with GetMarcItem(). Test plan : - Get a record A with a lot of items - Create a new record B - Create a linked items from B to A with a field 773 (461 in UNIMARC) : biblionumber in $0 and itemnumber in $9 - Display B record details => Compare execution times with and without patch Signed-off-by: Hugo Agud <hagud at orex.es> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 12:53:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 11:53:54 +0000 Subject: [Koha-bugs] [Bug 19279] performance of linked items in search In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19279-70-78mxPwCs79@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 13:06:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 12:06:23 +0000 Subject: [Koha-bugs] [Bug 18825] Elasticsearch - Update default authority mappings In-Reply-To: <bug-18825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18825-70-7zV1IdCrKT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi --- Comment #2 from Ere Maijala <ere.maijala at helsinki.fi> --- I think there may be a couple of subfield lists that need to be fixed: - 110 should include b - 111 should not include b - 130 should not include c - 150 should be 150abgvxyz - 151 should be 151agvxyz - 155 should be 155avxyz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 13:09:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 12:09:27 +0000 Subject: [Koha-bugs] [Bug 20060] Uninitialized warn from Koha::Template::Plugin::Branches In-Reply-To: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20060-70-NEJEvDsxsk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20060 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to M. Tompsett from comment #4) > I triggered this with just "localhost:8081" in the address bar in chrome. A > url with mainpage did not trigger it for me. Thx for signing off. Mainpage triggered it while being logged out iirc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 13:11:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 12:11:30 +0000 Subject: [Koha-bugs] [Bug 20002] Can't call method "description" on an undefined value at /usr/share/koha/intranet/cgi-bin/members/summary-print.pl line 107. In-Reply-To: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20002-70-ZGhLbeRl1F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20002 --- Comment #4 from Mohd Hafiz Yusoff <mhby87 at gmail.com> --- Anybody cal help me? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 13:40:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 12:40:32 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17809-70-LeVzdOOQEd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Katrin Fischer from comment #16) > I am worried about the atomicupdate - it looks like only checks for the > authorised value code, but not for the category, so this might lead to wrong > warning messages. Some of those codes look like classifications we might > have as collections in our databases for example. > > > + my $number_cc = $schema->resultset('AuthorisedValue')->search( > + { > + authorised_value => 'CC' > + } > + )->count; > + if ( $number_cc > 1 ) { Ideed. M. Tompsett can you work on it ? I do it if you want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 13:40:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 12:40:41 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17809-70-1HDONhQQX8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 13:40:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 12:40:49 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17809-70-HYEbQFNZAv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 13:56:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 12:56:43 +0000 Subject: [Koha-bugs] [Bug 20112] New: Optionally show invalid ISBN/ISSN 020/022 $z Message-ID: <bug-20112-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20112 Bug ID: 20112 Summary: Optionally show invalid ISBN/ISSN 020/022 $z Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently the invalid ISBN and ISSN are indexed (bug 14617), but aren't displayed. It would be nice to find a way to display them if the library wants to do so. Having a class or similar for hiding them if necessary would be enough. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 13:57:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 12:57:47 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18198-70-pPMqyrUNou@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 13:57:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 12:57:50 +0000 Subject: [Koha-bugs] [Bug 18198] MARC21: Further improve handling of 5XX$u in GetMarcNotes In-Reply-To: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18198-70-r7xfyDVirf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18198 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71085&action=edit Bug 18198: (QA follow-up) Add tests for GetMarcNotes As requested by the RM, this patch adds a separate unit test for GetMarcNotes. We test MARC21 and UNIMARC. The NotesBlacklist pref is tested and also handling URLs in 5XX$u for MARC21. Test plan: Run t/Biblio/GetMarcNotes.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:07:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:07:50 +0000 Subject: [Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc In-Reply-To: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20051-70-esmZGUbbyy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:07:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:07:53 +0000 Subject: [Koha-bugs] [Bug 20051] Invalid markup in staff client's header.inc In-Reply-To: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20051-70-yqqPyQKbWe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70973|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71086&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Fix for QA: Corrected ID reference in circ/offline.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:20:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:20:25 +0000 Subject: [Koha-bugs] [Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges In-Reply-To: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20100-70-Tk22GQNEcI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |Patrons Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org Group|Koha security | Version|unspecified |master CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Thx for responding, Jonathan and Katrin. Your response tell me at least that there is no need to keep this report under Security. I am thinking of an approach to hide superlib privs from non-superlibs based on a preference or so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:21:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:21:28 +0000 Subject: [Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges? In-Reply-To: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20100-70-eje1NBt8Hn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Summary|A non-superlibrarian should |Should a non-superlibrarian |not be able to add |be able to add |superlibrarian privileges |superlibrarian privileges? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:30:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:30:00 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12932-70-KRtRGgQ9iW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:30:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:30:03 +0000 Subject: [Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed In-Reply-To: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12932-70-NMM0u18HUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71073|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71087&action=edit Bug 12932: When all modules installed, Perl version check ignored The description in comment #0 is quite true, because the scope of the $checkmodule variable is local to just the module checking. If we change the scope, we can include the perl check as part of the new scope, and thus properly set its value. As Debian Jessie, Stretch and Ubuntu Xenial all have good versions of Perl by default, the easiest way to test this is to: - make sure to have some optional modules not installed. - change the system preference 'Version' to one just under the current version in your SQL client. - modify the version check line to 5.030000 - restart_all and try going to the staff client. -- This should not inform you that your perl version is bad. - git reset hard back to origin/master - apply the patch - modify the version check line to 5.030000 - change the system preference 'Version' to one just under the current version in your SQL client. - restart_all and try going to the staff client. -- This should trigger the patch, and you should be informed your perl version is bad. - git reset hard back to origin/master - apply the patch - run koha qa test tools Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:38:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:38:18 +0000 Subject: [Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges? In-Reply-To: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20100-70-OioF41EKjU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, so you could only add one using the onboarding tool then or by deactivating the pref? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:45:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:45:35 +0000 Subject: [Koha-bugs] [Bug 20109] Allow translating "Remove" in Add Fund In-Reply-To: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20109-70-BShtoCCJjQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71079|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 71088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71088&action=edit Bug 20109: Allow translating "Remove" in Add Fund When a user has been added to the fund, the link to "Remove" that user is not translatable. Test plan: 1) Install language xx-YY 2) Go to Home -> Administration -> Budgets -> Funds -> Add Fund 3) Add a user to the fund 4) Notice how the "Remove" link after the user's name is not translated 5) Apply patch 6) Look in xx-YY-staff-prog.po, and if needed, translate the msgid "Remove" 7) Update and reinstall the language 8) Do 2 and 3 again. The "Remove" link should now be translated. Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi> Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:45:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:45:33 +0000 Subject: [Koha-bugs] [Bug 20109] Allow translating "Remove" in Add Fund In-Reply-To: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20109-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20109-70-LL3jCCpN0T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:48:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:48:17 +0000 Subject: [Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges? In-Reply-To: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20100-70-Q4HTkhuIly@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #5) > Hm, so you could only add one using the onboarding tool then or by > deactivating the pref? A superlib can always add another one. The point is that a non-superlib should not be able to do so (imo). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 14:53:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 13:53:55 +0000 Subject: [Koha-bugs] [Bug 20113] New: Show statistic fields on spend and ordered reports Message-ID: <bug-20113-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20113 Bug ID: 20113 Summary: Show statistic fields on spend and ordered reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org On the acquisitions start page the amounts ordered and spent for each fund are linked to a list of the connected orders. It would be nice if this list also displayed the statistics1 and statistics2 values from the order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 15:32:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 14:32:12 +0000 Subject: [Koha-bugs] [Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin In-Reply-To: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11827-70-lMqohMIIzx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This looks fine, and works correctly. I request one small fix: Our capitalization rules (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lower_cases_in_strings) say that only the first letter of the first word should be capitalized. I realize that the patch matches what the plugin has in its code, but we should follow the rules if we're adding it to our template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 15:47:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 14:47:44 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-kxNJixGQuM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #11 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Katrin Fischer from comment #10) > Please check if these are translatable - you might have to wrap them in > spans to get them picked up. This is what it looks like in po/en-GB-staff-prog.po after applying the patch and updating the translation: #. %1$s: SWITCH Koha.Preference('delimiter') #. %2$s: CASE '#' #. %3$s: CASE ',' #. %4$s: CASE '/' #. %5$s: CASE ';' #. %6$s: CASE '\\' #. %7$s: CASE 'tabulation' #. %8$s: END #: intranet-tmpl/prog/en/includes/delimiter_text.inc:1 #, c-format msgid "" "%s %sPound (#) separated text (.csv) %sComma separated text (.csv) %sSlash " "separated text (.csv) %sSemicolon separated text (.csv) %sBackslash " "separated text (.csv) %sTab separated text (.csv) %s " msgstr "" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 15:58:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 14:58:53 +0000 Subject: [Koha-bugs] [Bug 20114] New: Build better $query_cgi Message-ID: <bug-20114-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114 Bug ID: 20114 Summary: Build better $query_cgi Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com The current code for building $query_cgi in build_query_compat generates an invalid query string for many searches (advanced search, clicking a search link in biblio details etc). When the $query_cgi is incorrect, for example using pagination results in a search error. Have tried to fix this, and while there might still be issues, now works considerably better than before. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 15:59:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 14:59:13 +0000 Subject: [Koha-bugs] [Bug 20114] Build better $query_cgi In-Reply-To: <bug-20114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20114-70-HsB9KTX1ol@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 16:12:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 15:12:32 +0000 Subject: [Koha-bugs] [Bug 20114] Build better $query_cgi In-Reply-To: <bug-20114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20114-70-yIYvThhzrt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114 --- Comment #1 from David Gustafsson <glasklas at gmail.com> --- Created attachment 71089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71089&action=edit Bug 20114: Build better $query_cgi Build a more complete $query_cgi fixing issues with pagination after performing either an advanced search or visiting a search link from biblio details. To test: 1) Go to the details page for a biblio. 2) Click a link that will produce enough hits to trigger pagination. 3) Try going to next page. 4) This will produce a search error. 5) Apply patch. 6) Repeat steps 1 to 3. 7) Pagination should now work as expected. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 17:22:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 16:22:38 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19910-70-ZsLRmvLykX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Nice, we are good then. Thx, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 17:24:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 16:24:00 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-YxHcNjTbab@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70558|0 |1 is obsolete| | --- Comment #38 from David Gustafsson <glasklas at gmail.com> --- Created attachment 71090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71090&action=edit Bug 19575: Use canonical field names and resolve aliased fields Adjust elastic search mappings to more closely match Zebra equivalents resolving serveral issues with coded Zebra searches in templates and sorting of search results in UI. Also make field names in search strings case insensitive to accept case variations in template links and user input. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 17:24:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 16:24:22 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-OqLyV01xPa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #39 from David Gustafsson <glasklas at gmail.com> --- Found one more hard coded field value in authorities search that needed lower-casing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 17:32:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 16:32:32 +0000 Subject: [Koha-bugs] [Bug 20094] gather_print_notices.pl uses first language in opaclanguages syspref but first cannot be configured In-Reply-To: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20094-70-MFuVQKYbCO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20094 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 17:37:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 16:37:13 +0000 Subject: [Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges? In-Reply-To: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20100-70-PXcp7p8hRu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71091&action=edit Bug 20100: Introduce preference ProtectSuperlibPrivs This pref allows you to block changes to superlibrarian privileges at client and server side for non-superlibrarians. This patch only contains the db rev and the preference description. Test plan: Run dbrev or new install. Check pref value. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 17:37:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 16:37:17 +0000 Subject: [Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges? In-Reply-To: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20100-70-5t6QH8iYav@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71092&action=edit Bug 20100: Disallow access to superlib privileges at server side Depends on pref ProtectSuperlibPrivs. If enabled, script member-flags.pl will not allow you to add or remove superlib privs when you are no superlibrarian. The follow-up patch will enable the check at client side. Test plan: [1] Enable the pref. Do not apply the third patch (client side). [2] Login as superlib and add/remove superlib privs to a staff user. [3] Login as another user (no superlib, but having borrowers, permissions and staff_access). Verify that you have an internal server error when you add or remove superlib privs. The log contains a warning. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 17:37:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 16:37:22 +0000 Subject: [Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges? In-Reply-To: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20100-70-zu7XrzYVe5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 71093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71093&action=edit Bug 20100: Disallow access to superlibrarian privileges at client side This last patch activates the check at client side. If the pref ProtectSuperlibPrivs is enabled, non-superlibs should not be able to change superlibrarian privileges via the interface. Test plan: [1] Enable the pref. [2] Login as superlib and add/remove superlib privs to a staff user. [3] Login as another user (no superlib, but having borrowers, permissions and staff_access). Verify that you cannot add or remove superlib privs. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 17:38:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 16:38:42 +0000 Subject: [Koha-bugs] [Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges? In-Reply-To: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20100-70-YeRtNvCBdT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- This is the idea. Will finish up tomorrow. No refactoring of the complete script here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 18:20:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 17:20:28 +0000 Subject: [Koha-bugs] [Bug 16662] Letsencrypt II: Return of the cryptosaurus. (make it work for existing instances) In-Reply-To: <bug-16662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16662-70-TgcKsjVOW4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #4 from Dobrica Pavlinusic <dpavlin at rot13.org> --- You are missing jessie-backports in sources.list like: deb http://ftp.debian.org/debian jessie-backports main -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:09:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:09:55 +0000 Subject: [Koha-bugs] [Bug 20115] New: Languages appear in a different order in the footer Message-ID: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Bug ID: 20115 Summary: Languages appear in a different order in the footer Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The language chooser displays languages in a different order when the page is refresh. It should stick to the same order. A default order can depend on the pref values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:17:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:17:05 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20115-70-rWuaix8l3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:17:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:17:09 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20115-70-jJIZ2Sjx0M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71094&action=edit Bug 20115: Set the languages order with the pref values To avoid the languages to be ordered randomly, it is better to stick on a default order. Let's suppose that the order in the pref is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:17:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:17:13 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20115-70-Z5kZXNFohi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71095&action=edit Bug 20115: Make the prefs sortable If we depend on the order, we should make it sortable. I let the customization to someone else (we would need an icon to tell the user it's sortable). Something does not work here: If fr-FR and fr-CA is installed, but only 1 is ticked, it will be considered as last. I do not think it's a blocker as it does not make really make sense to have it installed but not used (the interface is also weird, there is a dropdown list with only 1 entry) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:17:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:17:16 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20115-70-r1vNkL6fP1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71096&action=edit Bug 20115: Trigger "modified" when sort is changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:17:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:17:41 +0000 Subject: [Koha-bugs] [Bug 20094] gather_print_notices.pl uses first language in opaclanguages syspref but first cannot be configured In-Reply-To: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20094-70-zm8Wz09kkO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20094 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I think bug 20115 will answer your need, could you confirm? *** This bug has been marked as a duplicate of bug 20115 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:17:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:17:41 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20115-70-5iajRtgOzy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 20094 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:20:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:20:45 +0000 Subject: [Koha-bugs] [Bug 20116] New: Cache language list Message-ID: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Bug ID: 20116 Summary: Cache language list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 20115 C4::Languages::getTranslatedLanguages calls _get_language_dirs that list directories to know the available themes. It sounds like we could avoid that and cache it instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 [Bug 20115] Languages appear in a different order in the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:20:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:20:45 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20115-70-RNxQFwa2Xp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20116 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 [Bug 20116] Cache language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:21:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:21:33 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-G1tASHZ9HL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:21:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:21:36 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-fntXI8XHqY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71097&action=edit Bug 20116: Prepare the ground Just refactoring to make the next patch more readable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:21:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:21:39 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-W3vAcOu1Jj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 71098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71098&action=edit Bug 20116: Cache language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:25:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:25:06 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-s3ApgnB0j1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Do these patches make sense? It seems that some call to getTranslatedLanguages are wrong: 1. members/memberentry.pl: my $translated_languages = C4::Languages::getTranslatedLanguages( 'opac', C4::Context->preference('template') ); # template is for the intranet, we should use opacthemes instead 2. tools/letter.pl 159 my $translated_languages = 160 C4::Languages::getTranslatedLanguages( 'opac', 161 C4::Context->preference('template') ); Additional note: "template" and "opacthemes" are confusing, the same terms must be used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 19:27:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 18:27:22 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-U5TfKRfPNV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- TODO: We should add a warning to koha-translate to restart memcached (or better, clear only what is needed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 20:40:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 19:40:47 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14224-70-vZ1uy39cS9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #126 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Jonathan Druart from comment #125) > (In reply to Kelly McElligott from comment #124) > > We had a question about what email this note would be emailed to- the > > Kohaadminemail set up in System preferences or the Item's Home Branch's > > email set up in Libraries and Groups. However, when testing this new system > > preference "allowcheckoutnotes' it appears that the patron that left the > > note receives the email not the librarian. Can you verify that this is the > > case.? > > Yes that sounds like a bug, could you report it? I can confirm this is the case. :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 20:46:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 19:46:35 +0000 Subject: [Koha-bugs] [Bug 20110] Adding same user multiple times to same budget fund In-Reply-To: <bug-20110-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20110-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20110-70-OXivPp2Ycl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20110 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71082|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 71099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71099&action=edit Bug 20110: Adding same user multiple times to same budget In javascript, using indexOf to test if a number exists in an array of strings doesn't work, and makes it possible to add the same user multiple times into the same budget fund. Make borrowernumber into string and compare that instead. Test plan: 1) Go to Home -> Administration -> Budgets -> Funds -> Add Fund 2) Add a user to the fund 3) Try to add the same user again to the same fund. No error. 4) Apply patch 5) Do 1, 2, and 3 again. You should now get an error message saying the user is already in the list. Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 20:46:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 19:46:33 +0000 Subject: [Koha-bugs] [Bug 20110] Adding same user multiple times to same budget fund In-Reply-To: <bug-20110-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20110-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20110-70-euUBrj4ZHA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20110 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 21:22:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 20:22:34 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14224-70-GPKKGlhQlO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #127 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to Christopher Brannon from comment #126) > (In reply to Jonathan Druart from comment #125) > > (In reply to Kelly McElligott from comment #124) > > > We had a question about what email this note would be emailed to- the > > > Kohaadminemail set up in System preferences or the Item's Home Branch's > > > email set up in Libraries and Groups. However, when testing this new system > > > preference "allowcheckoutnotes' it appears that the patron that left the > > > note receives the email not the librarian. Can you verify that this is the > > > case.? > > > > Yes that sounds like a bug, could you report it? > > I can confirm this is the case. :/ I believe this has been fixed in Bug 19496! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 21:36:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 20:36:30 +0000 Subject: [Koha-bugs] [Bug 19546] Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm breaks opac and staff In-Reply-To: <bug-19546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19546-70-fDKCYx7Jej@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton <gmcharlt at gmail.com> --- Reopening. Saw this happen on a Debian 8.10 system with a fresh install of 17.11.02 from package. A (truly terrible workaround) got Plack running: /usr/share/perl5/Mojolicious/Plugin && ln -s /usr/share/koha/lib/Koha Koha Version of Mojolicious is 7.21 from the 7.21+dfsg-1~kohadev1 package. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 22:58:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 21:58:38 +0000 Subject: [Koha-bugs] [Bug 20117] New: Need to store SMS notices in patron notices Message-ID: <bug-20117-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20117 Bug ID: 20117 Summary: Need to store SMS notices in patron notices Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org We should have a record of the SMS notices that are sent out in the patron accounts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 23:16:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 22:16:49 +0000 Subject: [Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined In-Reply-To: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19772-70-R2PRhvWDLN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 --- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to Katrin Fischer from comment #6) > Could there be a case where a library wants to activate the feature, but use > it without email? We have some cases like the suggestions emails where you > just delete the notice in that case. Maybe we could just adapt the text a > little and remove the error/warning? Making the options dependent seems more > hassle. I'm still working on the patch for Bug 17698 where the checkout notes will be shown on the staff dashboard, similar to how patron modifications are shown. I could add a patch to this bug that depends on 17698 where, if no notice is defined, it will not try to send an email and instead just show the note on the staff dashboard? hope that makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 31 23:28:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jan 2018 22:28:46 +0000 Subject: [Koha-bugs] [Bug 20117] Need to store SMS notices in patron notices In-Reply-To: <bug-20117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20117-70-urQWAK9KSW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20117 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> --- I discovered this is stored. For some reason it missed one of our tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.