[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 2 10:33:12 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |josef.moravec at gmail.com

--- Comment #142 from Josef Moravec <josef.moravec at gmail.com> ---
Hi,

these patchset doesn't apply. So just few comments from quick reading of the
code:

You don't have to change signature of GetHiddenItemnumbers, you can ask for
patron category here... And you can than leave the $search_context as is.

Also the "opac" param in GetMarcBiblio and EmbedItemsInMarcBiblio is not
needed, you can use C4::Context->interface when you need to know the actual
interface

And some squashing would be nice here ;)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list