[Koha-bugs] [Bug 12365] Notes for rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

--- Comment #16 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 67802
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67802
Bug 12365 - Notes for rules

Review of attachment 67802:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12365&attachment=67802)
-----------------------------------------------------------------

::: Koha/Schema/Result/Issuingrule.pm
@@ +300,5 @@
>      extra => { list => ["no", "yes", "bib_only", "item_only"] },
>      is_nullable => 0,
>    },
> +  "note",
> +  { data_type => "varchar", is_nullable => 1, size => 100 },

The Schema files changes should be generated by update_dbix_class_files.pl
script and should be in separate commit.

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ +436,5 @@
>                        <th>Item level holds</th>
>                        <th>Article requests</th>
>                        <th>Rental discount (%)</th>
> +                      <th>Note</th>
> +                      <th colspan="2"> </th>

The colspan parameter is not needed here and should be removed

-- 
You are receiving this mail because:
You are watching all bug changes.