[Koha-bugs] [Bug 19884] Improve performance of GetItem

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi David,

It looks like you find a good place where we can improve speed performance,
good catch.
However it is like we are going backward reintroducing raw SQL queries. I would
prefer to avoid such changes.

Did you try to make a mix of both approaches, like: generate only 1 query with
my $items = Koha::Items->search({ -in => $barcodes }); in place of your my
$items = C4::Items::GetItems($itemnumbers);
I guess we will need to call $items->unblessed and an interesting addition
would be to fill itype according to ->effective_itemtype (so perf will be
impacted if not item-level_itypes, like in your patch). Does it make sense?

Something else, did you make sure serials will not be impacted? GetItem fetches
serialseq and publisheddate. At first glance it looks safe but we need to be
sure.

-- 
You are receiving this mail because:
You are watching all bug changes.