[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #165 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've taken a look at the patches for a first QA review. 

1) Currently fails QA script:

 FAIL   t/db_dependent/Koha/Patrons/Import.t
   FAIL   critic
                "$headerrow_0" is declared but not used at line 320, column 5.
Unused variables clutter code and make it harder to read.

2) Tests fail:

kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ perl
t/db_dependent/Koha/Patrons/Import.t
1..124
ok 1 - use Koha::Patrons::Import;
ok 2 - An object of class 'Koha::Patrons::Import' isa 'Koha::Patrons::Import'
# Subtest: test_methods
    1..1
    ok 1 - Koha::Patrons::Import->can(...)
ok 3 - test_methods
# Subtest: test_attributes
    1..1
    ok 1 - Koha::Patrons::Import->can(...)
ok 4 - test_attributes
ok 5 -  Koha::Patrons::Import->import_patrons carps if no file handle is passed
ok 6 - Got the expected undef from import_patrons with nothing much
ok 7 -  Koha::Patrons::Import->import_patrons carps if no file handle is passed
ok 8 - Got the expected undef from import_patrons with no file handle
Use of uninitialized value $matchpoint in string eq at
/home/vagrant/kohaclone/Koha/Patrons/Import.pm line 170, <$handle_1> line 2.
# Looks like your test exited with 255 just after 8.

3) Might be me, but trying to run the script always gives me the help, no error
or anything. Used -c and -f with a random file.

Can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.