[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
-    $patron = Koha::Patrons->find( $borrower->{borrowernumber} );
+    $patron = Koha::Patrons->find( $patron->borrowernumber ); # FIXME Refetch
just in case, to avoid regressions. But must not be needed

[...]

    my $toomany = TooMany( $patron_unblessed, $item->{biblionumber}, $item, {
onsite_checkout => $onsite_checkout, switch_onsite_checkout =>
$switch_onsite_checkout, } );

You do not refetch $patron_unblessed. I would opt for not refetching $patron.
But this is not consistent..

-- 
You are receiving this mail because:
You are watching all bug changes.