[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #6)
> -    $patron = Koha::Patrons->find( $borrower->{borrowernumber} );
> +    $patron = Koha::Patrons->find( $patron->borrowernumber ); # FIXME
> Refetch just in case, to avoid regressions. But must not be needed
> 
> [...]
> 
>     my $toomany = TooMany( $patron_unblessed, $item->{biblionumber}, $item,
> { onsite_checkout => $onsite_checkout, switch_onsite_checkout =>
> $switch_onsite_checkout, } );
> 
> You do not refetch $patron_unblessed. I would opt for not refetching
> $patron. But this is not consistent..

Good catch Marcel. I also think it's not needed, that's why I added the FIXME.
But I would prefer not to do it on this bug report as it will need more
attention.

-- 
You are receiving this mail because:
You are watching all bug changes.