[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |In Discussion

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am not convinced.

1. I prefer the version without Marcel's patch (especially because of the size
of the parameter list)

2. GetBudgetHierarchy is called from a lot of other places, with a budget_id
For all these calls we are going to get worst performance(?)

3. GetBudgetHierarchy is not tested when called without parameter

4. There is a FIXME you removed, but you did not fix the problem, you hid it

5.
> This causes slow downs and performance issues for some libraries.

How many budgets/funds? What are the performances before/after this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.