[Koha-bugs] [Bug 19938] New: Refactor C4::Overdues::checkoverdues

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

            Bug ID: 19938
           Summary: Refactor C4::Overdues::checkoverdues
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mtompset at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

While retesting a bug, I ran a prove -r -v t, which generated a lot of log
noise. One such entry was:
[Tue Jan  9 03:54:58 2018] starman: Use of uninitialized value $overdues_count
in numeric gt (>) at /home/vagrant/kohaclone/opac/opac-main.pl line 76.

The $overdues_count was set by a call to checkoverdues. Reading the code I
noticed someone actually commented:
# returning the count and the results is silly

So, this is a refactor of the function and all the calls. It was surprisingly
small.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.