[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Jan 10 08:23:47 CET 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Fixed the patch subjects according to guidelines (XXXX: (follow-up) state what
was fixed)
Should is_cancelable be removed after this change? It seems the only remaining
occurrences are in tests:
Koha/Hold.pm:=head3 is_cancelable
Koha/Hold.pm:sub is_cancelable {
t/db_dependent/Hold.t:# Test method is_cancelable
t/db_dependent/Hold.t:ok( $hold->is_cancelable(), "Unfound hold is cancelable"
);
t/db_dependent/Hold.t:ok( $hold->is_cancelable, "Waiting hold is cancelable" );
t/db_dependent/Hold.t:ok( !$hold->is_cancelable, "In transit hold is not
cancelable" );
Sorry Marcel, forgot to check the QA contact first!
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list