[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #44 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 70336
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70336
Bug 17656 - Update irregularities on subscription renewals

Review of attachment 70336:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17656&attachment=70336)
-----------------------------------------------------------------

::: C4/Serials.pm
@@ +2713,4 @@
>      return @$serials;
>  }
>  
> +=head2 GessEnddate

typo

@@ +2718,5 @@
> +my $enddate = GessEnddate($startdate_iso $frequencyid, $numberlength, $weeklength, $monthlength);
> +
> +=cut
> +
> +sub GuessEnddate {

Better to add new subs just to Koha namespace... but I understand it here - we
do not have all the objects needed for serials management (frequencies and
number patterns are missing) and calling C4 subs from Koha namespace is not
good idea... If you are not willing to add needed objects, we could just fill a
bug for now...

::: Koha/Subscription.pm
@@ +77,5 @@
> +Return the length type (issues, weeks, months)
> +
> +=cut
> +
> +sub subtype {

Maybe lengthtype would be better name? Not blocker

::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
@@ +52,5 @@
> +        <input type="hidden" id="numbering3" value="[% numbering3 %]" />
> +        <input type="hidden" id="whenmorethan1" value="[% whenmorethan1 %]" />
> +        <input type="hidden" id="whenmorethan2" value="[% whenmorethan2 %]" />
> +        <input type="hidden" id="whenmorethan3" value="[% whenmorethan3 %]" />
> +        <input type="hidden" id="locale" value="[% locale %]" />

Why do you include all the data when renewing subscription? It should be not
needed!

-- 
You are receiving this mail because:
You are watching all bug changes.