[Koha-bugs] [Bug 19160] CAS Single Log Out

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am not going to test this patch, but I would like to make sure the changes
make sense.

1. I do not understand the code in opac-user.pl, why is it here? It sounds like
it will be better at its place in C4::Auth.

2. You should move out get_session the code you copy/pasted from there

3. I guess it is just my undestanding of CAS that is bad but why do we call
get_session then delete it? 
Is cas_ticket == sessionID?

Side note: it will not work if SessionStorage=memcached (but we should remove
that), CGI::Session::Driver::memcached->traverse does nothing.

Another one: from the pod of CGI::Session->find :
"Experimental feature.
Note: find() is meant to be convenient, not necessarily efficient. It's best
suited in cron scripts."

-- 
You are receiving this mail because:
You are watching all bug changes.