[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Thx for your adjustments! Looks good to me. Final comments:

This is not a blocker for me, but OpacExportOptions controls the options listed
by detail sidebar. Your custom exports are listed no matter what. It might be
better to let OpacExportOptions also control if the custom exports should be
added to the list somehow. Maybe not one by one, but just on directory level
(show them all or not)?
But do not make big adjustments here. It could be handled on a new report or we
could simply state: remove the xsl files from biblioexport.

XSLTParse4Display is not yet tested, but your change should officially be
tested ;)
    Also I recommend to remove the opac parameter. It is not consistent with
the approach followed in the sub. Not changing the parameters could help you
here.
    Please send XSLTCustomExport and OPACXSLTCustomExport to the routine; this
is consistent and does the same thing.
    Since your change only deals with the $xslfilename, I could live without a
test script (but I am not sure about the RM).

CustomXSLTExportList is new and should really have its own test (should not be
hard)
    Mock opachtdocs and create the dir in a tempdir. Check on returned title
and method.

-- 
You are receiving this mail because:
You are watching all bug changes.