[Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #2 from Charles Farmer <charles.farmer at inlibro.com> ---
To my knowledge, emptying $itemnumber is only done so we don't fall back onto
the same item after saving changes. On one hand, we load back into the
$op=additem interface if changes were accepted, otherwise, we load the same
item again.

What's lost on me is the reason why we'd want to proceed with the deletion
logic at all if the newitem has a barcode already used. Is there code anywhere
edging on that voodoo logic of deleting an item from an unsaved biblionotice?

What would make sense, imo, is pushing that deletion logic upward inside the
'else' block and doing that at the same time as ModItemFromMarc. But again,
without a strong regression test suite of that particular part, I went with the
easy way out and changed as little as I could with my patch, behavior-wise.

-- 
You are receiving this mail because:
You are watching all bug changes.