[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 16 01:46:41 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #20)
> So actually we are trying to remove a warning because there are wrong calls
> in opac-main.
> The dashboard's info should be fetched only if a patron is logged in.
> I did this change on bug 12001 already.
> I am suggesting a new patch to avoid the change of the subroutine's
> prototype (which is wrong instead, but let remove the subroutine instead)
> and future conflict (with bug 19933).
> 
> Deal?

While the problem that triggered this code change is that, and your simpler
change would suffice, I was hoping for a more thorough fix of the checkoverdues
function. Granted, this is only an intermediary step towards one that deals
with Koha::Checkouts filtered on is_overdue.

If you prefer, I could attempt to Koha::Checkouts the checkoverdues accessing
areas of code.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list