[Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 70648
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70648
Bug 20000: Changing 'use strict: use warnings;' to 'use Modern::Perl;'

Review of attachment 70648:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20000&attachment=70648)
-----------------------------------------------------------------

::: installer/data/mysql/labels_upgrade.pl
@@ +17,4 @@
>  # You should have received a copy of the GNU General Public License
>  # along with Koha; if not, see <http://www.gnu.org/licenses>.
>  
> +use Modern::Perl;

Commented out with '# FIXME - Bug 2505' would make more sense.

@@ -17,5 @@
>  # You should have received a copy of the GNU General Public License
>  # along with Koha; if not, see <http://www.gnu.org/licenses>.
>  
> -#use strict;
> -#use warnings; FIXME - Bug 2505

These are commented out.

::: installer/data/mysql/patroncards_upgrade.pl
@@ +17,4 @@
>  # You should have received a copy of the GNU General Public License
>  # along with Koha; if not, see <http://www.gnu.org/licenses>.
>  
> +use Modern::Perl;

not commented?

@@ -17,5 @@
>  # You should have received a copy of the GNU General Public License
>  # along with Koha; if not, see <http://www.gnu.org/licenses>.
>  
> -#use strict;
> -#use warnings; FIXME - Bug 2505

commented.

::: installer/data/mysql/update22to30.pl
@@ -11,5 @@
>  # - Would also be a good idea to offer to do a backup at this time...
>  
>  # NOTE:  If you do something more than once in here, make it table driven.
> -use strict;
> -#use warnings; FIXME - Bug 2505

This is a strange case.
Do we have anyone really using pre-3.0 still? I thought this script might be
pointless by now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.