[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #96 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 69028
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69028
Bug 11879: Add the "Main contact method" field in borrower informations.

Review of attachment 69028:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11879&attachment=69028)
-----------------------------------------------------------------

::: installer/data/mysql/atomicupdate/borrowers_primary_contact_method.sql
@@ +1,2 @@
> +ALTER TABLE `borrowers` ADD COLUMN `primary_contact_method` VARCHAR(45) NULL DEFAULT NULL AFTER `lastseen`;
> +ALTER TABLE `deletedborrowers` ADD COLUMN `primary_contact_method` VARCHAR(45) NULL DEFAULT NULL AFTER `overdrive_auth_token`;

deletedborrowers and borrowers should maintain the same field order.

::: installer/data/mysql/kohastructure.sql
@@ +1682,4 @@
>    `lang` varchar(25) NOT NULL default 'default', -- lang to use to send notices to this patron
>    `login_attempts` int(4) default 0, -- number of failed login attemps
>    `overdrive_auth_token` text default NULL, -- persist OverDrive auth token
> +  `lastseen` datetime default NULL, -- last time a patron has been seed (connected at the OPAC or staff interface)

This adds lastseen, but the borrowers_primary_contact_method did not add it at
all.

::: installer/data/mysql/updatedatabase.pl
@@ +14968,4 @@
>      }
>  }
>  
> +

Totally not necessary to touch this.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ +538,5 @@
>  
>  [% UNLESS nophone && nophonepro && nomobile && noemail && noemailpro && nofax %]
>    <fieldset class="rows" id="memberentry_contact">
> +    <legend id="contact_lgd">Contact</legend>
> +<ol>

Keep whitespace changes separate.

@@ +602,4 @@
>  	  [% IF ( mandatoryemailpro ) %]<span class="required">Required</span>[% END %]
>      </li>
>          [% END %]
> +    [% UNLESS nofax %]

Keep whitespace changes separate.

@@ +664,5 @@
> +            [% END %]
> +         [% END %]
> +       </select>
> +    </li>
> +    </ol>

This is the only place where you can really get away with these minor
whitespace changes on the END and /ol.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ +275,5 @@
> +            [% ELSE %]
> +                [% guarantor.firstname | html %] [% guarantor.surname | html %]
> +            [% END %]
> +        </li>
> +    [% END %]

Where did this ELSIF clause come from?! This has nothing to do with
primary_contact_method.

::: opac/opac-memberentry.pl
@@ +93,5 @@
>      libraries         => \@libraries,
>      OPACPatronDetails => C4::Context->preference('OPACPatronDetails'),
>  );
> +my $check_BorrowerMandatoryField=C4::Context->preference("BorrowerMandatoryField");
> +        my @field_check=split(/\|/,$check_BorrowerMandatoryField);

Something is strange about this indentation. I would expect the same
indentation level.

-- 
You are receiving this mail because:
You are watching all bug changes.