[Koha-bugs] [Bug 19975] Tag cloud searching does not working

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70811|0                           |1
        is obsolete|                            |

--- Comment #3 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 70850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70850&action=edit
Bug 19975: Fix search by tags at the OPAC

This bug has certainly be caused by
  commit 091d6c513bcbee224ff06477e79be48cea7fe825
    Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes

The reason is quite simple, in Koha::ItemType->translated_description
(called in opac-search.pl l.229) there is an eval to know if we have
access to the translated description of the item type, to avoid
retrieving it again.

The evaluation of $@ later in opac-search.pl is supposed to test the 2
eval made few lines before (a "normal" search, without tags), but
$@ contains the error message from the *last* eval command.
So we are raising an error that have been correctly handled in
Koha::ItemType.

Test plan:
At the OPAC, click Tag cloud, then click any of the tags

=> Without the patch you get
Koha::ItemType::get_column generated this error:
DBIx::Class::Row::get_column(): No such column 'translated_description' on
Koha::Schema::Result::Itemtype at /usr/share/koha/lib/Koha/Object.pm line 307

=> With the patch applied the page is correctly displayed

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

https://bugs.koha-community.org/show_bug.cgi?id=19775

-- 
You are receiving this mail because:
You are watching all bug changes.