[Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 70879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70879&action=edit
Bug 20086 - AddRenewal is not executed as a transaction and can results in
partial success and doubled fines

This patch starts a transaction and only commits if renewal and fines
updates and charges are successful (partial in any cna be problematic)

There is no feedback (as currently there is none either) but if part
fails, all fails.

I didn't include stats and notifications in the transaction, but we
could.

To test:
1 - Apply patch
2 - prove t/db_dependent/Circulation.t
3 - Attempt circs and renewals should be no difference
4 - If possible make part of transaction fail and ensure all fails

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.