[Koha-bugs] [Bug 7047] renewing serials note not visible

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 69474
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69474
Bug 7047 - Storing subscription renewal note in suggestion to be displayed on
the suggestion page.

Review of attachment 69474:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7047&attachment=69474)
-----------------------------------------------------------------

::: C4/Serials.pm
@@ +1504,4 @@
>  =cut
>  
>  sub ReNewSubscription {
> +    my ( $subscriptionid, $user, $startdate, $numberlength, $weeklength, $monthlength, $note, $branchcode ) = @_;

This parameter list is huge. Rather than add another parameter, I would
recommend converting it to a hashref.
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_should_be_used_as_arguments
Thankfully, it is a very small refactor (git grep ReNewSubscription), and is
much easier to maintain or expand in the future.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.