[Koha-bugs] [Bug 15869] Change framework on overlay

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |mtompset at hotmail.com

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
I don't think this is Academy, because line 567 of C4/ImportBatch.pm in master
is probably the wrong condition. I think it should be >= 1, not ==1. Read lines
251/252 of tools/manage-marc-import.pl where 4 parameters are passed. This
means adding a parameter in the middle is messed up. If the code is cleaned up,
then perhaps, but I'm marking this Failed QA, because it reads awful and
probably explains why imports are flaky sometimes. Also, it fails to meet the
"must have tests" coding guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.