[Koha-bugs] [Bug 20110] Adding same user multiple times to same budget fund

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20110

paxed <pasi.kallinen at joensuu.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at joensuu.fi
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #1 from paxed <pasi.kallinen at joensuu.fi> ---
Created attachment 71082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71082&action=edit
Fix adding same user to the same budget fund multiple times

In javascript, using indexOf to test if a number exists in an array
of strings doesn't work, and makes it possible to add the same user
multiple times into the same budget fund.
Make borrowernumber into string and compare that instead.

Test plan:

1) Go to Home -> Administration -> Budgets -> Funds -> Add Fund
2) Add a user to the fund
3) Try to add the same user again to the same fund. No error.
4) Apply patch
5) Do 1, 2, and 3 again. You should now get an error message
   saying the user is already in the list.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.