From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:32:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:32:39 +0000
Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS
functionalities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #4 from Katrin Fischer ---
I've changed the documentation on the wiki - can you please check if it's
correct now? https://wiki.koha-community.org/wiki/Use_of_Cookies
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:35:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:35:59 +0000
Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS
functionalities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:36:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:36:03 +0000
Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS
functionalities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76583|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer ---
Created attachment 76600
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76600&action=edit
Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is
activated"
This reverts commit ce6ec1e7faef217950e3450788ea444dad26d7c0.
https://bugs.koha-community.org/show_bug.cgi?id=21024
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:37:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:37:41 +0000
Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828
--- Comment #26 from Katrin Fischer ---
Hi Cab, just some additional info:
https://wiki.koha-community.org/wiki/Sandboxes
There is also a video on how to use them. Please feel free to jump into chat if
you get stuck too!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:43:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:43:39 +0000
Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return
results alphabetically
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #14 from Katrin Fischer ---
Hi Nick, the first patch is removing t/db_dependent/Patrons.t. I think this is
what Jonathan meant?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:47:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:47:34 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:47:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:47:38 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76569|0 |1
is obsolete| |
--- Comment #2 from Katrin Fischer ---
Created attachment 76601
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76601&action=edit
Bug 21018: Fix TrackClicks for 952$u
Caused by
commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53
Bug 19847: Track links within the records and 404 for others
We should also accept uri stored in items.uri (952$u)
Test plan:
- Turn on TrackClicks
- Defined uri for some items
- At the OPAC click on the link (from opac-detail.pl)
=> Without this patch you will get 404 (redirected from tracklinks.pl)
=> With this patch applied you will be redirected correctly and the
linktracker will be filled correctly
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:53:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:53:38 +0000
Subject: [Koha-bugs] [Bug 21019] Borrower address not shown on reserve
pop-up on returns.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:53:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:53:42 +0000
Subject: [Koha-bugs] [Bug 21019] Borrower address not shown on reserve
pop-up on returns.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76562|0 |1
is obsolete| |
--- Comment #2 from Katrin Fischer ---
Created attachment 76602
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76602&action=edit
Bug 21019: Fix display of patron's address on reserve pop-up on returns.pl
Caused by
commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6
Bug 17829: Move GetMember to Koha::Patron
address variable has been replaced by boraddress (wrong resolution
conflict?)
It does not affect master (thanks bug 18789)
Test plan:
Confirm the address of the patron with a hold placed on the item is now
displayed when this item is checked in
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:54:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:54:04 +0000
Subject: [Koha-bugs] [Bug 21019] [17.11] Borrower address not shown on
reserve pop-up on returns.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |normal
Summary|Borrower address not shown |[17.11] Borrower address
|on reserve pop-up on |not shown on reserve pop-up
|returns.pl |on returns.pl
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:56:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 17:56:10 +0000
Subject: [Koha-bugs] [Bug 21015] Members.pm slow because it loads twice
Koha::Schema
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #2 from Katrin Fischer ---
Hi, this is already looking good. Could you still add a little test plan to see
where the routine is used for the testers?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 20:52:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 18:52:11 +0000
Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
Do you plan on changing the icons on the opac-detail page and others as well?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 20:52:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 18:52:52 +0000
Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76400|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer ---
Created attachment 76604
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76604&action=edit
Bug 15287: Compiled CSS
This patch contains the compiled CSS.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 20:53:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 18:53:00 +0000
Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 20:52:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 18:52:47 +0000
Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76399|0 |1
is obsolete| |
--- Comment #4 from Katrin Fischer ---
Created attachment 76603
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76603&action=edit
Bug 15287: Use font-awesome on the OPAC
This patch replaces Bootstrap's glyphicons with Font Awesome icons.
To test, apply the patch and clear your browser cache and regenerate the
OPAC CSS from the LESS file if necessary. Check these icons and confirm
they look correct:
- Cart and Lists icons in the OPAC header
- User icon in the header when the browser window is narrow
- Languages menu when multiple languages are installed and
the OpacLangSelectorMode system preference is "top" or "both top and
footer."
- Set the SuspendHoldsOpac system preference to "allow" and log in to
the OPAC as a user who has one or more holds.
- Check the appearance of the "suspend" and "resume" buttons both in
the table of holds and at the bottom.
- With one or more clubs defined, log in to the OPAC and check the "Clubs"
tab on the user summary page. The "Enroll" and "Cancel enrollment"
buttons should look correct.
- On the "your messaging" tab in the OPAC, the "Digests only" information
icon should look correct.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 20:55:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 18:55:18 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307
--- Comment #3 from Katrin Fischer ---
Ok, a little confused by the graph - didn't spot any patch with patches still
needing work. Can you point me the right direction?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 21:01:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 19:01:24 +0000
Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC
templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 21:01:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 19:01:29 +0000
Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC
templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76598|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 76605
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76605&action=edit
Bug 20999: Remove invalid 'style="block"' from OPAC templates
This patch removes an invalid attribute from OPAC template markup. There
should be no visible change to the OPAC.
To test, apply the patch and confirm that the following pages still look
correct when using various cover image sources: Coce, Amazon, Google:
- Bibliographic detail page (opac-detail.pl)
- The shelf browser
- Catalog search results
- Recent comments
Signed-off-by: Charles Farmer
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:40:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 20:40:45 +0000
Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on
Authorities "New from Z39.50" Button
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:40:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 20:40:50 +0000
Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on
Authorities "New from Z39.50" Button
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76584|0 |1
is obsolete| |
--- Comment #16 from Katrin Fischer ---
Created attachment 76606
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76606&action=edit
Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50"
Button
This patch makes a third stab at resolving this issue by reorganizing
the authorities toolbar buttons to more closely match the bibliographic
toolbar buttons:
- "New from Z39.50" has been added to the "New authority" dropdown.
- "Edit" is now a dropdown, like on the bibliographic detail page:
- Edit record
- Edit as new (duplicate)
- Replace record via Z39.50/SRU
- Delete record
To test, apply the patch and go to the authorities module. Testing with
existing Z39.50 authority sources configured:
- On the authorities home page and the authorities search results
page, the "New authority" menu should have a "New from Z39.50" link.
- View the details for an authority record. The menus should appear as
described above. Test each option.
Remove all Z39.50 authority servers and test again. The "New from
Z39.50" link should no longer appear.
Signed-off-by: Charles Farmer
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:47:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 20:47:41 +0000
Subject: [Koha-bugs] [Bug 20765] Search for items by acqdate does not work
in label batch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20765
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|Signed Off |Failed QA
--- Comment #3 from Katrin Fischer ---
Hi Frido, I get the same number of results with and without this patch on my
kohadevbox. I am using the MARC21 sample data, searching with: 01/01/2016 to
01/01/2017 - 2 results.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:51:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 20:51:24 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
content type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
--- Comment #22 from Katrin Fischer ---
Owen, could we get your opinion on Jonathan's follow-up?
Patches don't apply right now as attached to the bug, but I am not sure if only
some should be applied. Please take a look.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 23:07:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 21:07:01 +0000
Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in
catalog.js do not match strings in catalog-strings.inc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 23:07:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 21:07:05 +0000
Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in
catalog.js do not match strings in catalog-strings.inc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76582|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 76607
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76607&action=edit
Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match
strings in catalog-strings.inc
The naming mismatch can cause javascript errors.
Test Plan:
1) Confirm the string vars used in catalog.js match the ones in
catalog-strings.inc
Signed-off-by: Pierre-Luc Lapointe
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 01:56:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 23:56:28 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
types
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 01:56:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Jul 2018 23:56:32 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
types
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960
--- Comment #14 from Aleisha Amohia ---
Created attachment 76608
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76608&action=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS
This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.
To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.
= STAFF CLIENT =
- catalogue/advsearch.tt
- catalogue/detail.tt
- catalogue/results.tt
- reserve/request.tt
- virtualshelves/shelves.tt
= OPAC =
- opac-advsearch.tt
- opac-detail.tt
- opac-readingrecord.tt
- opac-reserve.tt
- opac-results-grouped.tt
- opac-shelves.tt
- opac-user.tt
Sponsored-by: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 03:55:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 01:55:24 +0000
Subject: [Koha-bugs] [Bug 12365] Notes for rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 03:55:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 01:55:30 +0000
Subject: [Koha-bugs] [Bug 12365] Notes for rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #67802|0 |1
is obsolete| |
--- Comment #17 from Aleisha Amohia ---
Created attachment 76609
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76609&action=edit
Bug 12365 - Notes for rules
Lee Jamison rescued this patch.
It is a clean re-build of attachments 61865 and 63902
to fix the merge conflict introduced during application of both
attachments.
To test:
Follow test plan in Comment 2
Signed-off-by: Mark Tompsett
Signed-off-by: macon lauren KohaCon17
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 07:27:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 05:27:16 +0000
Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on
returns page.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #7 from Fridolin SOMERS ---
Pushed to 17.11.x for 17.11.08
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:18:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 06:18:18 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
biblio_metadata, and items tables with their "alive" cousins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #185 from Katrin Fischer ---
Should we move this to FQA for now?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:27:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 06:27:30 +0000
Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields
function
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #24 from Katrin Fischer ---
How can we make progress here? Waiting for patches for bug 20443?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:48:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 06:48:02 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
moremember.pl page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Depends on| |6758
--- Comment #9 from Fridolin SOMERS ---
Depends on Bug 6758 that is pushed to master since 17.11
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758
[Bug 6758] Capture membership renewal date for reporting purposes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:48:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 06:48:02 +0000
Subject: [Koha-bugs] [Bug 6758] Capture membership renewal date for
reporting purposes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |20867
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867
[Bug 20867] Ability to show membership renewal date on moremember.pl page
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:49:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 06:49:26 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
CGI::Compile Perl dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_17_11_candidate,
| |rel_18_05_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:51:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 06:51:06 +0000
Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on
moremember.pl page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Stable |RESOLVED
--- Comment #10 from Fridolin SOMERS ---
Template has been changed by Bug 18789 so I don't push to 17.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:13:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 07:13:44 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
patrons using the quicksearch at the top
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_17_11_candidate
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:18:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 07:18:29 +0000
Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for
patrons using the quicksearch at the top
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_17_11_candidate, |
|rel_18_05_candidate |
Status|Pushed to Master |Pushed to Stable
--- Comment #11 from Martin Renvoize ---
Pushed to 18.05.x for 18.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:21:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 07:21:09 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
end with server error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #8 from Martin Renvoize ---
Pushed to 18.05.x for 18.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:21:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 07:21:17 +0000
Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could
end with server error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_18_05_candidate |
Status|Pushed to Master |Pushed to Stable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:24:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 07:24:36 +0000
Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export
"Count of checkouts" column as CSV
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #7 from Martin Renvoize ---
Pushed to 18.05.x for 18.05.02, trivial bugfix.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:35:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 07:35:29 +0000
Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828
--- Comment #27 from Cab Vinton ---
(In reply to Katrin Fischer from comment #26)
> Hi Cab, just some additional info:
> https://wiki.koha-community.org/wiki/Sandboxes
> There is also a video on how to use them. Please feel free to jump into chat
> if you get stuck too!
Thank you, Katrin. I'd found that info previously, but missed the tutorial
video.
Great job by Nicole as usual. Feel comfortable now w/ trying my first sign off
:-)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:09:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:09:21 +0000
Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect
parameter
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Pushed to Master |Pushed to Stable
--- Comment #6 from Martin Renvoize ---
Pushed to 18.05.x for 18.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:12:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:12:36 +0000
Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of
holds in OPAC account when there is only one branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #13 from Martin Renvoize ---
Pushed to 18.05.x for 18.05.02, trivial bugfix.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:14:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:14:52 +0000
Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the
title checked out during placing hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421
Cab Vinton changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bibliwho at gmail.com
--- Comment #2 from Cab Vinton ---
Received the following error message on attempting to place a hold:
Software error:
Global symbol "$multihold" requires explicit package name (did you forget to
declare "my $multihold"?) at /home/koha/src/reserve/request.pl line 374.
Execution of /home/koha/src/reserve/request.pl aborted due to compilation
errors.
Tested in Sandbox 06.
Apologies if my testing went off the rails. First attempt to sign off on a
patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:17:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:17:50 +0000
Subject: [Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from
zebra-output.log when EasyAnalyticalRecords is not used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--- Comment #11 from Martin Renvoize ---
Pushed to 18.05.x for 18.05.02, always good to silence some warnings :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:19:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:19:55 +0000
Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_18_05_candidate |
Status|Pushed to Master |Pushed to Stable
--- Comment #12 from Martin Renvoize ---
Pushed to 18.05.x for 18.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:31:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:31:50 +0000
Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #6 from Martin Renvoize ---
Minor enhancement, but the change could be unexpected for unsuspecting users.
Choosing not to backport.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:34:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:34:10 +0000
Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list
if there are no lists in staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #16 from Martin Renvoize ---
Pushed to 18.05.x for 18.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:43:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:43:59 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:44:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:44:02 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900
--- Comment #4 from Marcel de Rooy ---
Created attachment 76610
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76610&action=edit
Bug 20900: Add CPL branch in t_Batch.t too
Same fix as previous patch.
Test plan:
Run t/db_dependent/Labels/t_Batch.t (without CPL branch)
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:44:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:44:55 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900
--- Comment #5 from Marcel de Rooy ---
Hmm. Fast?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:53:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 08:53:39 +0000
Subject: [Koha-bugs] [Bug 19519] Ability to bind the rotating collection
with branch during creating
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519
Cab Vinton changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bibliwho at gmail.com
--- Comment #8 from Cab Vinton ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 19519:
Something went wrong !
Applying: Bug 19519: Add ability to bind
rotating collectino with library during creation
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 19519: Add ability to bind rotating collectino with
library during creation
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 19519 - Ability to bind the rotating collection with branch during creating
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:05:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 09:05:14 +0000
Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a
patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #5 from Martin Renvoize ---
Pushed to 18.05.x for 18.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:08:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 09:08:15 +0000
Subject: [Koha-bugs] [Bug 10348] Show number of items on tab headings in the
staff client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
--- Comment #8 from Martin Renvoize ---
Enhancement, not backporting to 18.05.x branch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:11:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 09:11:13 +0000
Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #11 from Martin Renvoize ---
Pushed to 18.05.x for 18.05.02, cosmetic code tidy up only.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:14:28 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 09:14:28 +0000
Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type
patrons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #7 from Martin Renvoize ---
Enhancement, not backporting to 18.05.x branch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:20:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 09:20:12 +0000
Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user
is logged in to OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #14 from Martin Renvoize ---
Enhancement, won't be backported to 18.05.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:22:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 09:22:59 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
account page instead of back to search results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #23 from Martin Renvoize ---
Enhancement, changes behaviour, not backporting for 18.05.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:36:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 09:36:38 +0000
Subject: [Koha-bugs] [Bug 20492] Add missing case for advanced search year
limit in _fix_limit_special_cases
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492
Cab Vinton changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bibliwho at gmail.com
--- Comment #3 from Cab Vinton ---
It would be helpful to know what specifically the ElasticSearch syntax format
is supposed to look like.
Sandbox 13 is still showing "yr,st-numeric=YYYY-YYYY" for the Year limit search
in both the OPAC & staff client.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:38:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 09:38:15 +0000
Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the
title checked out during placing hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72935|0 |1
is obsolete| |
--- Comment #3 from Josef Moravec ---
Created attachment 76611
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76611&action=edit
Bug 20421: Inform staff that patron does have the title checked out during
placing hold
Test plan:
1) Enable the CheckPrevCheckout and DisplayMultiPlaceHold system preferences
2) Have a patron with some checkouts history
3) Try to place hold on one of titles from history for this patron
4) You should see an information at the top of confirm request page, but
you still should be able to place a hold
5) Try this with multiple titles - one or more of them should be from
history
6) You should see this information in "Information" column
7) There is also new column placed at the beggining with checkbox, you
could uncheck it for titles you do not want to place a hold on it
8) Confirm the hold is placed only on checked titles
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:40:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 09:40:01 +0000
Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the
title checked out during placing hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421
--- Comment #4 from Josef Moravec ---
(In reply to Cab Vinton from comment #2)
> Received the following error message on attempting to place a hold:
>
> Software error:
> Global symbol "$multihold" requires explicit package name (did you forget to
> declare "my $multihold"?) at /home/koha/src/reserve/request.pl line 374.
> Execution of /home/koha/src/reserve/request.pl aborted due to compilation
> errors.
>
> Tested in Sandbox 06.
>
> Apologies if my testing went off the rails. First attempt to sign off on a
> patch.
My bad, now it is corrected and rebased on master, you can try it again.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:09:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 10:09:29 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:09:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 10:09:32 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75455|0 |1
is obsolete| |
--- Comment #70 from Ere Maijala ---
Created attachment 76612
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76612&action=edit
Bug 19893 - Alternative optimized indexing for Elasticsearch
Implement optimized indexing for Elasticsearch
How to test:
1) Time a full elasticsearch re-index without this patch by running the
rebuild_elastic_search.pl with the -d flag:
`koha-shell -c "time rebuild_elastic_search.pl -d"`.
2) Apply this patch.
3) Time a full re-index again, it should be about twice at fast (for a
couple of thousand biblios, with fewer biblios results may be more
unpredictable).
Sponsored-by: Gothenburg University Library
Signed-off-by: Ere Maijala
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:09:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 10:09:41 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75660|0 |1
is obsolete| |
--- Comment #72 from Ere Maijala ---
Created attachment 76614
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76614&action=edit
Bug 19893: Add index status
Add persistent per index "index status" state to provide useful
user feedback when update of Elasticsearch server mappings fails
Signed-off-by: Ere Maijala
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:09:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 10:09:37 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75588|0 |1
is obsolete| |
--- Comment #71 from Ere Maijala ---
Created attachment 76613
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76613&action=edit
Bug 19893: Remove serialization format setting
Default to base64 encoded binary MARC with MARCXML
fallback if record exceeds maximum size
Signed-off-by: Ere Maijala
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:11:43 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 10:11:43 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #73 from Ere Maijala ---
I took the liberty of adding "if (@body)" check in bulk_index so that e.g. an
empty authority index can be created without errors.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:13:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 10:13:04 +0000
Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:25:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 10:25:07 +0000
Subject: [Koha-bugs] [Bug 20902] Labels/t_Batch.t fails on fresh database
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20902
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #2 from Marcel de Rooy ---
*** This bug has been marked as a duplicate of bug 20900 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:25:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 10:25:07 +0000
Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900
--- Comment #6 from Marcel de Rooy ---
*** Bug 20902 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:49:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 10:49:22 +0000
Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources
when paging
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507
Cab Vinton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |bibliwho at gmail.com
--- Comment #2 from Cab Vinton ---
(In reply to Owen Leonard from comment #1)
> Created attachment 76436 [details] [review]
> Bug 20507: Shelf browser does not update image sources when paging
>
> This patch updates the shelfbrowser include so that the system
> preference check for Coce will function correctly.
>
> To test, apply the patch and test the OPAC shelf browser with each of
> the enhanced content options enabled: Coce, Amazon, Google. In each
> case, page through the shelf browser to confirm that covers load
> correctly.
The patch seemed to work fine in Sandbox 06, clearing the cache for each
content option.
Several items had covers missing, but these all appeared to titles for which no
covers were available in the first place.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:14:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:14:52 +0000
Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the
title checked out during placing hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421
Cab Vinton changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #5 from Cab Vinton ---
All good now :-)
Cheers.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:18:50 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:18:50 +0000
Subject: [Koha-bugs] [Bug 20492] Add missing case for advanced search year
limit in _fix_limit_special_cases
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492
--- Comment #4 from David Gustafsson ---
Yes, but it will be converted to the right format, so both formats are
supported.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:20:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:20:14 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #74 from David Gustafsson ---
Ok, great! Thanks for the sign-off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:46:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:46:49 +0000
Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options
to define which records to modify
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #18 from Marcel de Rooy ---
*** This bug has been marked as a duplicate of bug 12759 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:46:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:46:49 +0000
Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch
record modification/deletion tools
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liz at catalyst.net.nz
--- Comment #25 from Marcel de Rooy ---
*** Bug 17273 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:46:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:46:51 +0000
Subject: [Koha-bugs] [Bug 17892] Move _extract_biblionumbers to a module
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17892
Bug 17892 depends on bug 17273, which changed state.
Bug 17273 Summary: Batch MARC Modification - improve options to define which records to modify
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |RESOLVED
Resolution|--- |DUPLICATE
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:49:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:49:57 +0000
Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287
--- Comment #6 from Owen Leonard ---
(In reply to Katrin Fischer from comment #3)
> Do you plan on changing the icons on the opac-detail page and others as well?
I do not have an immediate plan for that, although I think it's a good idea to
refresh those icons (as part of 20554 maybe?).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:53:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:53:11 +0000
Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for
unissued items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75694|0 |1
is obsolete| |
--- Comment #20 from Marcel de Rooy ---
Created attachment 76615
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76615&action=edit
Bug 20487: AddReturn should clear items.onloan for unissued items
If an item is no longer issued but somehow still has a date in the onloan
column, checking it in should clear that date.
Adding a ModItem call in the NotIssued section.
Test plan:
[1] Run t/db_dependent/Circulation.t
[2] Bonus: Checkout item, delete issue from table, checkin. Verify that
items.onloan has been cleared.
Signed-off-by: Marcel de Rooy
Signed-off-by: Charles Farmer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:53:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:53:15 +0000
Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for
unissued items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75695|0 |1
is obsolete| |
--- Comment #21 from Marcel de Rooy ---
Created attachment 76616
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76616&action=edit
Bug 20487: (QA follow-up) Requested db revision
As requested in comment12, we can update these cases in a dbrev too.
Signed-off-by: Marcel de Rooy
Checked out item, deleted issue record, ran dbrev.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:53:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:53:51 +0000
Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for
unissued items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487
--- Comment #22 from Marcel de Rooy ---
Simple rebase on Circulation.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:56:05 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
article requests are permitted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72913|0 |1
is obsolete| |
--- Comment #32 from Marcel de Rooy ---
Created attachment 76617
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76617&action=edit
Bug 17530: Add Koha::IssuingRules->guess_article_requestable_itemtypes
This routine looks at the issuingrules and makes a fast 'intelligent
guess' if article requests may be allowed for item types while
branch code and patron category may not be available.
We also add Koha::Biblio->may_article_request using the routine based
on default item type or parameter. Implemented as both class and instance
method. Added a few tests.
Test plan:
[1] Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t
[2] Run t/db_dependent/ArticleRequests.t to test Koha::Biblio changes.
Signed-off-by: Marcel de Rooy
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:56:10 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
article requests are permitted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72914|0 |1
is obsolete| |
--- Comment #33 from Marcel de Rooy ---
Created attachment 76618
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76618&action=edit
Bug 17530: Use may_article_request method in opac-search
If you enable pref ArticleRequests, until now all search results got the
'Request article' link. This patch tries to improve the situation by
using the new sub with the itemtype of the search result.
In most cases the number of links will drastically decrease. It may still
be possible sometimes that a link is shown while it effectively is not
possible, but we do not get the performance burden of determining that and
going through all items.
Test plan:
[1] Look for two borrowers P1 and P2 within categories C1 resp. C2.
[2] Look for two biblios B1 and B2 with default item types I1 resp. I2.
(See 942c in case of MARC21.)
[3] Make sure that no circ rules allow article requests. Enable the pref.
[4] Add/modify circ rule category=C1, itemtype=I1, art_req=yes.
Log out. Search for B1 and B2, verify that only B1 has AR link.
Log in as P1. Verify that only B1 has AR link.
Log in as P2. Verify that no biblio has AR link.
[5] Add/modify circ rule category=C2, itemtype=I2, art_req=item_only.
Log out. Search for B1 and B2, verify that both have AR links.
Log in as P1. Verify that only B1 has AR link.
Log in as P2. Verify that only B2 has AR link.
Signed-off-by: Marcel de Rooy
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:56:15 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
article requests are permitted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72915|0 |1
is obsolete| |
--- Comment #34 from Marcel de Rooy ---
Created attachment 76619
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76619&action=edit
Bug 17530: Use can_article_request to control sidebar link
Before this patch, the 'Request article' link is displayed whenever the
pref is enabled. In many cases this might be useless. Instead of a guess
as in opac-search, we now call can_article_request to know for sure.
Note: at least this is the case when a user has logged in.
Update sidebar template with template variable artreqpossible.
Add code in opac-detail, MARCdetail and ISBDdetail to fill it.
Test plan:
[1] Look for two biblios with items: one that should allow article requests
and one that should not (respecting branch, patron, item type).
[2] Verify on detail, ISBD and MARC that the link is displayed for
the first biblio and hidden for the second biblio.
Signed-off-by: Marcel de Rooy
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:56:20 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
article requests are permitted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72931|0 |1
is obsolete| |
--- Comment #35 from Marcel de Rooy ---
Created attachment 76620
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76620&action=edit
Bug 17530: (QA follow-up) Replace our variable by cached value
Instead of saving the state locally in a variable during Plack lifetime,
we move the saved hash to the cache. We clear the key when we enter
smart-rules.pl. This makes a change in circ rules immediately effective.
Test plan:
Run the modified tests.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:56:24 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
article requests are permitted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75697|0 |1
is obsolete| |
--- Comment #36 from Marcel de Rooy ---
Created attachment 76621
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76621&action=edit
Bug 17530: (QA follow-up) Replace class_or_self variables
See comment23. Requested by QA.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:56:29 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
article requests are permitted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75751|0 |1
is obsolete| |
--- Comment #37 from Marcel de Rooy ---
Created attachment 76622
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76622&action=edit
Bug 17530: (QA follow-up) Move may_article_request to ItemType
As requested by QA, we should move may_article_request out of Biblio.
For reasons of performance removed the wrapper layer of may_article_request
in opac-search. No need to look up all item types. For readability kept
the routine in the detail scripts.
Note for running ArticleRequests.t: A possible failure on the subtest
'search_limited' is addressed on bug 20866. So you can ignore that one.
As long as the subtest for may_article_request passes.
Test plan:
See previous patches.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:58:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:58:05 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76491|0 |1
is obsolete| |
Attachment #76492|0 |1
is obsolete| |
--- Comment #12 from Nick Clemens ---
Created attachment 76623
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76623&action=edit
Bug 7547: printing a sorted cart
This patch adds a DataTables-generated print button to the OPAC cart. To
make that process easier, the DataTables plugin has been upgraded to the
latest version (1.10.18) with the Buttons plugin included.
Changes to the OPAC LESS file style the DataTables button to look like
the static version.
Other templates in the OPAC which use the DataTables plugin have been
modified to use up-to-date option names.
To test, apply the patch and add several titles to the cart.
- Open the cart
- Re-sort the cart using something other than the default sort
- Click the 'Print' button.
- A print view should open in a separate window, sorted correctly,
and automatically show the print dialog.
- Click the cart's 'More details' button and click the print button.
- This should trigger the print dialog directly.
- Test DataTables sorting on other modified pages:
- Bibliographic detail page (holdings table)
- Course reserves (table of courses)
- Course details (table of titles)
- Full subscription history
- Detail page for a subscription -> More details -> Full history
- Most popular
- Purchase suggestions
- Self checkouts
- Tag cloud
- Your fines
- Your interlibrary loan requests
- Your reading history
- Your search history
- Your search IDREF for ppn (I don't know how to test this)
The DataTables plugin is removed from "Your routing lists" and Self
check-in because it is unused.
Signed-off-by: Katrin Fischer
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:57:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:57:47 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
article requests are permitted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
--- Comment #38 from Marcel de Rooy ---
Jonathan: Did you see the last changes after your comment ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:58:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:58:08 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547
--- Comment #13 from Nick Clemens ---
Created attachment 76624
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76624&action=edit
Bug 7547: (QA follow-up) Make button background transparent for consistency
Test plan:
Add some records to cart in opac and show the cart, look at the print
button/link
--> without patch it has darker background than other buttons
--> with this patch it has the same background
Note: tested wir firefox 45, firefox 60 and chromium 66
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:58:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:58:12 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547
--- Comment #14 from Nick Clemens ---
Created attachment 76625
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76625&action=edit
Bug 7547: (RM follow-up) Compiled css
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:58:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:58:55 +0000
Subject: [Koha-bugs] [Bug 19519] Ability to bind the rotating collection
with branch during creating
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |BLOCKED
--- Comment #9 from Owen Leonard ---
Depends on Bug 18606 which is currently Failed QA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:58:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 11:58:59 +0000
Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828
--- Comment #28 from Cab Vinton ---
(In reply to Jonathan Druart from comment #22)
> Did you test the rebase patches?
So I've learned how to sign off on patches, but the status of this patch is
Failed QA.
If a dashboard XML file needs to be created, then not sure whether testing via
a sandbox would work.
Tried Sandbox 06 anyway & got the following:
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 6828:
Something went wrong !
Applying: Bug 6828[ENH] - Add basic Dashboard
for staff users.
.git/rebase-apply/patch:483: trailing whitespace.
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M C4/Auth.pm
M installer/data/mysql/sysprefs.sql
M installer/data/mysql/updatedatabase.pl
M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
M koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
M mainpage.pl
.git/rebase-apply/patch:483: trailing whitespace.
warning: 1 line applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging mainpage.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging C4/Auth.pm
CONFLICT (content): Merge conflict in C4/Auth.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 6828[ENH] - Add basic Dashboard for staff users.
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 6828 - Add Admin Dashboard for staff users.
10217 - [SIGNED-OFF] Bug 6828[ENH] - Add basic Dashboard for staff users.
10218 - [SIGNED-OFF] Bug 6828 follow-up: adapt dashboard to new staff client
theme
60692 - Bug 6828[ENH] - Add basic Dashboard for staff users.
60693 - Bug 6828 follow-up: adapt dashboard to new staff client theme
Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/SIGNED-OFF-Bug-6828ENH---Add-basic-Dashboard-for-s-EpoHfa.patch .
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:20:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 12:20:00 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468
--- Comment #22 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #21)
> Marcel, (last patch) could not we use only null (instead of undefined vs
> null)?
Please see comment19. I need both values. These are standard values in
javascript helping us to make the distinction between not yet initialized and
null returned by a cancel. In order to meet your comment, I added comments.
> There is also a tiny ergonomic issue, hit /circ/article-requests.pl, click
> the "processing" tab. There are the "select all" and "clear all" links, if
> the table is empty and you click on one of them they will disappear.
Good catch. Fixed on last follow-up.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:20:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 12:20:23 +0000
Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468
--- Comment #23 from Marcel de Rooy ---
Created attachment 76626
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76626&action=edit
Bug 20468: (QA follow-up) Deactivate select/clear all for empty tab
This only pertains to the second (Processing) tab.
Test plan:
[1] Have one entry in Pending and zero in Processing.
[2] Click on Processing tab.
[3] Without this patch, you would see Select all/Clear all.
With this patch, you won't.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:22:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 12:22:26 +0000
Subject: [Koha-bugs] [Bug 20469] Add item status to staff article requests
form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73388|0 |1
is obsolete| |
--- Comment #7 from Marcel de Rooy ---
Created attachment 76628
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76628&action=edit
Bug 20469: (Follow-up) Make translation of status possible
As Mark noticed, adding a span for each status will allow for translation.
Note that the menu options in the block before are inside html tags like
.... and will be translated (as long as spaces match).
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:22:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 12:22:22 +0000
Subject: [Koha-bugs] [Bug 20469] Add item status to staff article requests
form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73282|0 |1
is obsolete| |
--- Comment #6 from Marcel de Rooy ---
Created attachment 76627
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76627&action=edit
Bug 20469: Add item status to staff article request form
A method Koha::Item->is_waiting_or_transit is added (with tests).
The template checks if an item is checked out, on hold (waiting or
transit), or is available. (Note: This can be extended in the future
in a general include as we have at opac side.)
Test plan:
[1] Run t/db_dependent/Koha/Items.t
[2] Place an article request on an item on loan. Verify status on form.
[3] Place an article request on a waiting item. Check status again.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:24:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 12:24:33 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #75 from Ere Maijala ---
Created attachment 76629
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76629&action=edit
Fix Elasticsearch tests.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:56:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 12:56:00 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Attachment #73550|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:56:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 12:56:25 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73797|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:56:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 12:56:12 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73551|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:06:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:06:21 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
payments/fines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #111 from Marcel de Rooy ---
- - "Any of these characters can be used as a separator between integer
and decimal parts in the price fields. To work well with thousands separators
you must (usually) choose between dot and comma to avoid ambiguity. So
thousands separators come at the expense of handling both dots and commas. It
you want to format price output, please use the system preference
'CurrencyFormat'"
+ - "Any of these characters can be used as a separator between integer
and decimal parts in the decimal number fields that use the associated
normalizing/unformatting mechanism. To also use thousands separators you must
choose between dot and comma to avoid ambiguity. So using thousands separators
comes at the expense of handling both dots and commas as decimal separators.
This means reserving one character for decimal separation and another for
thousands separation. So you must not use characters from the DecimalSeparators
preference also as thousands separator. Also, if you want to format price
output, please use the system preference 'CurrencyFormat'"
The second description is imo too long. Let me try to suggest something
shorter:
Any of these characters can be used as a separator between integer and decimal
part of a price field. To avoid ambiguity, do not use the same characters as
thousands separator. Use pref CurrencyFormat to format price ouput.
=> Instead of the cryptic "fields that use the associated
normalizing/unformatting mechanism", you might add something like:
(This pref is currently used on the patron fines tab.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:07:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:07:57 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
payments/fines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Signed Off
--- Comment #112 from Marcel de Rooy ---
Does the followups require all the fields to be retested? And put back the
patch to "Needs Signoff".
TODO wait answer, blocking question
Imo we can keep the signed off state. Please adjust the last follow-up and let
me finish QA on friday(?).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:08:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:08:07 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
payments/fines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:10:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:10:26 +0000
Subject: [Koha-bugs] [Bug 19436] Add SRU support for authorities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Patch doesn't apply
--- Comment #24 from Nick Clemens ---
Changes from 15360 cause conflicts, can you rebase/add a follow up?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:14:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:14:45 +0000
Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in
catalog.js do not match strings in catalog-strings.inc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Status|Passed QA |Pushed to Master
--- Comment #4 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:15:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:15:05 +0000
Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined"
when CircSidebar is turned on
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Status|Passed QA |Pushed to Master
--- Comment #8 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:15:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:15:34 +0000
Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing
CGI::Compile Perl dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #9 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:15:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:15:19 +0000
Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |nick at bywatersolutions.com
--- Comment #7 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:15:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:15:49 +0000
Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on
Authorities "New from Z39.50" Button
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Status|Passed QA |Pushed to Master
--- Comment #17 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:16:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:16:03 +0000
Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC
templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Status|Passed QA |Pushed to Master
--- Comment #4 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:16:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:16:17 +0000
Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |nick at bywatersolutions.com
--- Comment #15 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:16:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:16:32 +0000
Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when
staff user doesn't have place_holds permission
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |nick at bywatersolutions.com
--- Comment #8 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:16:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:16:48 +0000
Subject: [Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove
get_saved_report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #12 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:17:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:17:19 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25
(Nov 2016, May and Dec 2017)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |nick at bywatersolutions.com
--- Comment #20 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:17:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:17:03 +0000
Subject: [Koha-bugs] [Bug 20272] XSLT_Handler should use alphanumeric error
codes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20272
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Status|Passed QA |Pushed to Master
--- Comment #8 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:17:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:17:32 +0000
Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates
23-26 (Nov 2016, May and Apr 2018)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |nick at bywatersolutions.com
--- Comment #24 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:17:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:17:51 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #31 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:18:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:18:06 +0000
Subject: [Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier
metadata"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
Status|Passed QA |Pushed to Master
--- Comment #11 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:18:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:18:51 +0000
Subject: [Koha-bugs] [Bug 19436] Add SRU support for authorities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436
--- Comment #25 from Marcel de Rooy ---
(In reply to Nick Clemens from comment #24)
> Changes from 15360 cause conflicts, can you rebase/add a follow up?
You should have waited a bit with that one, huh ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:29:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:29:00 +0000
Subject: [Koha-bugs] [Bug 1884] Managing Suggestions - way to archive/clean
up approved/rejected orders
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1884
S?verine Queune changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |severine.queune at bulac.fr
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:50:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:50:06 +0000
Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong
content type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #23 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #22)
> Owen, could we get your opinion on Jonathan's follow-up?
> Patches don't apply right now as attached to the bug, but I am not sure if
> only some should be applied. Please take a look.
They apply correctly, it's either Owen's patch (the first one), or mines (the 3
others).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:52:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:52:00 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307
--- Comment #4 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #3)
> Ok, a little confused by the graph - didn't spot any patch with patches
> still needing work. Can you point me the right direction?
I do not plan to get back to this soon.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:53:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:53:26 +0000
Subject: [Koha-bugs] [Bug 21019] [17.11] Borrower address not shown on
reserve pop-up on returns.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_17_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:55:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 13:55:41 +0000
Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is
enabled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018
--- Comment #3 from Jonathan Druart ---
Important note: We certainly need to add an index on this column to boost this
query.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:09:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 14:09:35 +0000
Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons
payments/fines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #113 from Victor Grousset/tuxayo ---
Thanks Marcel for your feedback, I hope to process it in the following days.
I just came to ask this question: Should the DecimalSeparators syspref be
shared to HEA?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:39:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 14:39:51 +0000
Subject: [Koha-bugs] [Bug 21026] New: Statistics tab in patron account
should show descriptions instead of codes
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21026
Bug ID: 21026
Summary: Statistics tab in patron account should show
descriptions instead of codes
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
The statistics tab in the patron account shows codes instead of descriptions
for
- collection
- location
- item types
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:56:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 14:56:00 +0000
Subject: [Koha-bugs] [Bug 21027] New: Totals in statistics tab change when
StatisticsFields is changed
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027
Bug ID: 21027
Summary: Totals in statistics tab change when StatisticsFields
is changed
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
As we understand it the totals in the last line of the statistics table in the
patron account should be always the same, independent of the selection made in
the StatisticsFields system preference.
This is not the case.
When "location" is removed, the total is less than with "location".
I think this might have something to do with the group and empty values for
some entries, but have not been able to find the problem yet.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:17:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 15:17:34 +0000
Subject: [Koha-bugs] [Bug 20469] Add item status to staff article requests
form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:17:37 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 15:17:37 +0000
Subject: [Koha-bugs] [Bug 20469] Add item status to staff article requests
form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76627|0 |1
is obsolete| |
Attachment #76628|0 |1
is obsolete| |
--- Comment #8 from Owen Leonard ---
Created attachment 76630
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76630&action=edit
Bug 20469: Add item status to staff article request form
A method Koha::Item->is_waiting_or_transit is added (with tests).
The template checks if an item is checked out, on hold (waiting or
transit), or is available. (Note: This can be extended in the future
in a general include as we have at opac side.)
Test plan:
[1] Run t/db_dependent/Koha/Items.t
[2] Place an article request on an item on loan. Verify status on form.
[3] Place an article request on a waiting item. Check status again.
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:17:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 15:17:15 +0000
Subject: [Koha-bugs] [Bug 21028] New: www/history.t is failing on jenkins
for Ubuntu 18.04
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028
Bug ID: 21028
Summary: www/history.t is failing on jenkins for Ubuntu 18.04
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Test Suite
Assignee: chris at bigballofwax.co.nz
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
CC: martin.renvoize at ptfs-europe.com,
mirko at abunchofthings.net, nick at bywatersolutions.com,
tomascohen at gmail.com
t/db_dependent/www/history.t is failing with the following error on Ubuntu
18.04 (at least with the image from koha-testing-docker):
koha_1 | # Failed test 'Cyrillic characters with umlauts show correctly
on the history page.'
koha_1 | # at t/db_dependent/www/history.t line 68.
It is *not* an encoding issue, the problem is that history.txt is not found:
Could not read the history.txt file. Please make sure is correctly
defined in koha-conf.xml.
>From koha-conf.xml:
/usr/share/doc/koha-common
Indeed this location does not contain history.txt:
root at 95f30c756223:/kohadevbox/koha# ls /usr/share/doc/koha-common
changelog.Debian.gz copyright
I have no idea if it is a koha issue, a packaging issue, or a koha-testing
issue.
Does anyone has an idea?
https://jenkins.koha-community.org/job/Koha_18.05_U18/14/consoleFull
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:17:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 15:17:39 +0000
Subject: [Koha-bugs] [Bug 20469] Add item status to staff article requests
form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469
--- Comment #9 from Owen Leonard ---
Created attachment 76631
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76631&action=edit
Bug 20469: (Follow-up) Make translation of status possible
As Mark noticed, adding a span for each status will allow for translation.
Note that the menu options in the block before are inside html tags like
.... and will be translated (as long as spaces match).
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:17:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 15:17:56 +0000
Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request
endpoint
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #2 from Andrew Isherwood ---
Hi Benjamin
I'm not aware of anywhere where we query that table on type or value, it's only
ever the illrequest_id we query via the join. So I'm not sure of the value of
adding these indexes.
I might be missing something though, so please put me straight if so!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:21:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 15:21:01 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946
--- Comment #20 from Tom?s Cohen Arazi ---
Created attachment 76632
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76632&action=edit
Bug 20946: (QA follow-up) make outstanding_debits return the account lines only
This patch was discussed with Jonathan on a QA conversation. It is
better to keep this simpler and more reusable. And is the right approach
in this case.
This patch makes Koha::Account::outstanding_debits return the account
lines, and a method is added to Koha::Account::Lines so the outstanding
amount is calculated on the resultset. This is done the dame way it was
done before, and the tests got adjusted.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:21:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 15:21:19 +0000
Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:30:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 15:30:33 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76439|0 |1
is obsolete| |
--- Comment #21 from Tom?s Cohen Arazi ---
Created attachment 76633
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76633&action=edit
Bug 20978: Unit tests
This patch adds unit tests for Koha::Account::add_credit.
Signed-off-by: Josef Moravec
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:30:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Jul 2018 15:30:39 +0000
Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
In-Reply-To: