From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:32:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:32:39 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I've changed the documentation on the wiki - can you please check if it's correct now? https://wiki.koha-community.org/wiki/Use_of_Cookies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:35:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:35:59 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:36:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:36:03 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76583|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 76600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76600&action=edit Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated" This reverts commit ce6ec1e7faef217950e3450788ea444dad26d7c0. https://bugs.koha-community.org/show_bug.cgi?id=21024 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:37:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:37:41 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 --- Comment #26 from Katrin Fischer --- Hi Cab, just some additional info: https://wiki.koha-community.org/wiki/Sandboxes There is also a video on how to use them. Please feel free to jump into chat if you get stuck too! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:43:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:43:39 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- Hi Nick, the first patch is removing t/db_dependent/Patrons.t. I think this is what Jonathan meant? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:47:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:47:34 +0000 Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:47:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:47:38 +0000 Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76569|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 76601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76601&action=edit Bug 21018: Fix TrackClicks for 952$u Caused by commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53 Bug 19847: Track links within the records and 404 for others We should also accept uri stored in items.uri (952$u) Test plan: - Turn on TrackClicks - Defined uri for some items - At the OPAC click on the link (from opac-detail.pl) => Without this patch you will get 404 (redirected from tracklinks.pl) => With this patch applied you will be redirected correctly and the linktracker will be filled correctly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:53:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:53:38 +0000 Subject: [Koha-bugs] [Bug 21019] Borrower address not shown on reserve pop-up on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:53:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:53:42 +0000 Subject: [Koha-bugs] [Bug 21019] Borrower address not shown on reserve pop-up on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76562|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 76602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76602&action=edit Bug 21019: Fix display of patron's address on reserve pop-up on returns.pl Caused by commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6 Bug 17829: Move GetMember to Koha::Patron address variable has been replaced by boraddress (wrong resolution conflict?) It does not affect master (thanks bug 18789) Test plan: Confirm the address of the patron with a hold placed on the item is now displayed when this item is checked in Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:54:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:54:04 +0000 Subject: [Koha-bugs] [Bug 21019] [17.11] Borrower address not shown on reserve pop-up on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Summary|Borrower address not shown |[17.11] Borrower address |on reserve pop-up on |not shown on reserve pop-up |returns.pl |on returns.pl CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 19:56:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 17:56:10 +0000 Subject: [Koha-bugs] [Bug 21015] Members.pm slow because it loads twice Koha::Schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi, this is already looking good. Could you still add a little test plan to see where the routine is used for the testers? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 20:52:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 18:52:11 +0000 Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Do you plan on changing the icons on the opac-detail page and others as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 20:52:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 18:52:52 +0000 Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76400|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 76604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76604&action=edit Bug 15287: Compiled CSS This patch contains the compiled CSS. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 20:53:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 18:53:00 +0000 Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 20:52:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 18:52:47 +0000 Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76399|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 76603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76603&action=edit Bug 15287: Use font-awesome on the OPAC This patch replaces Bootstrap's glyphicons with Font Awesome icons. To test, apply the patch and clear your browser cache and regenerate the OPAC CSS from the LESS file if necessary. Check these icons and confirm they look correct: - Cart and Lists icons in the OPAC header - User icon in the header when the browser window is narrow - Languages menu when multiple languages are installed and the OpacLangSelectorMode system preference is "top" or "both top and footer." - Set the SuspendHoldsOpac system preference to "allow" and log in to the OPAC as a user who has one or more holds. - Check the appearance of the "suspend" and "resume" buttons both in the table of holds and at the bottom. - With one or more clubs defined, log in to the OPAC and check the "Clubs" tab on the user summary page. The "Enroll" and "Cancel enrollment" buttons should look correct. - On the "your messaging" tab in the OPAC, the "Digests only" information icon should look correct. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 20:55:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 18:55:18 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #3 from Katrin Fischer --- Ok, a little confused by the graph - didn't spot any patch with patches still needing work. Can you point me the right direction? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 21:01:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 19:01:24 +0000 Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 21:01:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 19:01:29 +0000 Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76598|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 76605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76605&action=edit Bug 20999: Remove invalid 'style="block"' from OPAC templates This patch removes an invalid attribute from OPAC template markup. There should be no visible change to the OPAC. To test, apply the patch and confirm that the following pages still look correct when using various cover image sources: Coce, Amazon, Google: - Bibliographic detail page (opac-detail.pl) - The shelf browser - Catalog search results - Recent comments Signed-off-by: Charles Farmer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:40:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 20:40:45 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:40:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 20:40:50 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76584|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 76606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76606&action=edit Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button This patch makes a third stab at resolving this issue by reorganizing the authorities toolbar buttons to more closely match the bibliographic toolbar buttons: - "New from Z39.50" has been added to the "New authority" dropdown. - "Edit" is now a dropdown, like on the bibliographic detail page: - Edit record - Edit as new (duplicate) - Replace record via Z39.50/SRU - Delete record To test, apply the patch and go to the authorities module. Testing with existing Z39.50 authority sources configured: - On the authorities home page and the authorities search results page, the "New authority" menu should have a "New from Z39.50" link. - View the details for an authority record. The menus should appear as described above. Test each option. Remove all Z39.50 authority servers and test again. The "New from Z39.50" link should no longer appear. Signed-off-by: Charles Farmer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:47:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 20:47:41 +0000 Subject: [Koha-bugs] [Bug 20765] Search for items by acqdate does not work in label batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20765 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- Hi Frido, I get the same number of results with and without this patch on my kohadevbox. I am using the MARC21 sample data, searching with: 01/01/2016 to 01/01/2017 - 2 results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:51:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 20:51:24 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #22 from Katrin Fischer --- Owen, could we get your opinion on Jonathan's follow-up? Patches don't apply right now as attached to the bug, but I am not sure if only some should be applied. Please take a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 23:07:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 21:07:01 +0000 Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 23:07:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 21:07:05 +0000 Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76582|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 76607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76607&action=edit Bug 20977: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc The naming mismatch can cause javascript errors. Test Plan: 1) Confirm the string vars used in catalog.js match the ones in catalog-strings.inc Signed-off-by: Pierre-Luc Lapointe Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 01:56:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 23:56:28 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 01:56:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2018 23:56:32 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 --- Comment #14 from Aleisha Amohia --- Created attachment 76608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76608&action=edit Bug 7960: Add class to item type descriptions so they can be hidden with CSS This patch adds the class "itypetext" around item type descriptions so they can easily be hidden with CSS. To test: 1. Navigate to the pages listed below to confirm that the text descriptions do show. 2. Add .itypetext { display:none; } to IntranetUserCSS and OPACUserCSS system preferences and save. 3. Go back to the pages listed below and confirm that the text descriptions DO NOT show. = STAFF CLIENT = - catalogue/advsearch.tt - catalogue/detail.tt - catalogue/results.tt - reserve/request.tt - virtualshelves/shelves.tt = OPAC = - opac-advsearch.tt - opac-detail.tt - opac-readingrecord.tt - opac-reserve.tt - opac-results-grouped.tt - opac-shelves.tt - opac-user.tt Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 03:55:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 01:55:24 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 03:55:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 01:55:30 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67802|0 |1 is obsolete| | --- Comment #17 from Aleisha Amohia --- Created attachment 76609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76609&action=edit Bug 12365 - Notes for rules Lee Jamison rescued this patch. It is a clean re-build of attachments 61865 and 63902 to fix the merge conflict introduced during application of both attachments. To test: Follow test plan in Comment 2 Signed-off-by: Mark Tompsett Signed-off-by: macon lauren KohaCon17 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 07:27:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 05:27:16 +0000 Subject: [Koha-bugs] [Bug 18521] Renew and search hotkeys are swapped on returns page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18521 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:18:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 06:18:18 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #185 from Katrin Fischer --- Should we move this to FQA for now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:27:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 06:27:30 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #24 from Katrin Fischer --- How can we make progress here? Waiting for patches for bug 20443? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:48:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 06:48:02 +0000 Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |6758 --- Comment #9 from Fridolin SOMERS --- Depends on Bug 6758 that is pushed to master since 17.11 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 [Bug 6758] Capture membership renewal date for reporting purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:48:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 06:48:02 +0000 Subject: [Koha-bugs] [Bug 6758] Capture membership renewal date for reporting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20867 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867 [Bug 20867] Ability to show membership renewal date on moremember.pl page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:49:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 06:49:26 +0000 Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate, | |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:51:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 06:51:06 +0000 Subject: [Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS --- Template has been changed by Bug 18789 so I don't push to 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:13:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 07:13:44 +0000 Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:18:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 07:18:29 +0000 Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_17_11_candidate, | |rel_18_05_candidate | Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:21:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 07:21:09 +0000 Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:21:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 07:21:17 +0000 Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:24:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 07:24:36 +0000 Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02, trivial bugfix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:35:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 07:35:29 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 --- Comment #27 from Cab Vinton --- (In reply to Katrin Fischer from comment #26) > Hi Cab, just some additional info: > https://wiki.koha-community.org/wiki/Sandboxes > There is also a video on how to use them. Please feel free to jump into chat > if you get stuck too! Thank you, Katrin. I'd found that info previously, but missed the tutorial video. Great job by Nicole as usual. Feel comfortable now w/ trying my first sign off :-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:09:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:09:21 +0000 Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:12:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:12:36 +0000 Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of holds in OPAC account when there is only one branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02, trivial bugfix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:14:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:14:52 +0000 Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the title checked out during placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com --- Comment #2 from Cab Vinton --- Received the following error message on attempting to place a hold: Software error: Global symbol "$multihold" requires explicit package name (did you forget to declare "my $multihold"?) at /home/koha/src/reserve/request.pl line 374. Execution of /home/koha/src/reserve/request.pl aborted due to compilation errors. Tested in Sandbox 06. Apologies if my testing went off the rails. First attempt to sign off on a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:17:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:17:50 +0000 Subject: [Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from zebra-output.log when EasyAnalyticalRecords is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02, always good to silence some warnings :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:19:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:19:55 +0000 Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:31:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:31:50 +0000 Subject: [Koha-bugs] [Bug 14222] Sort holds in OPAC by priority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Minor enhancement, but the change could be unexpected for unsuspecting users. Choosing not to backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:34:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:34:10 +0000 Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list if there are no lists in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #16 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:43:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:43:59 +0000 Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:44:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:44:02 +0000 Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 --- Comment #4 from Marcel de Rooy --- Created attachment 76610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76610&action=edit Bug 20900: Add CPL branch in t_Batch.t too Same fix as previous patch. Test plan: Run t/db_dependent/Labels/t_Batch.t (without CPL branch) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:44:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:44:55 +0000 Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 --- Comment #5 from Marcel de Rooy --- Hmm. Fast? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:53:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 08:53:39 +0000 Subject: [Koha-bugs] [Bug 19519] Ability to bind the rotating collection with branch during creating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com --- Comment #8 from Cab Vinton --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 19519:

Something went wrong !

Applying: Bug 19519: Add ability to bind rotating collectino with library during creation fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt). error: could not build fake ancestor Patch failed at 0001 Bug 19519: Add ability to bind rotating collectino with library during creation The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 19519 - Ability to bind the rotating collection with branch during creating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:05:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 09:05:14 +0000 Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:08:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 09:08:15 +0000 Subject: [Koha-bugs] [Bug 10348] Show number of items on tab headings in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize --- Enhancement, not backporting to 18.05.x branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:11:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 09:11:13 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02, cosmetic code tidy up only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:14:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 09:14:28 +0000 Subject: [Koha-bugs] [Bug 20585] Label surname as name for organisation type patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20585 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Enhancement, not backporting to 18.05.x branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:20:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 09:20:12 +0000 Subject: [Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Enhancement, won't be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:22:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 09:22:59 +0000 Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #23 from Martin Renvoize --- Enhancement, changes behaviour, not backporting for 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:36:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 09:36:38 +0000 Subject: [Koha-bugs] [Bug 20492] Add missing case for advanced search year limit in _fix_limit_special_cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com --- Comment #3 from Cab Vinton --- It would be helpful to know what specifically the ElasticSearch syntax format is supposed to look like. Sandbox 13 is still showing "yr,st-numeric=YYYY-YYYY" for the Year limit search in both the OPAC & staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:38:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 09:38:15 +0000 Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the title checked out during placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72935|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 76611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76611&action=edit Bug 20421: Inform staff that patron does have the title checked out during placing hold Test plan: 1) Enable the CheckPrevCheckout and DisplayMultiPlaceHold system preferences 2) Have a patron with some checkouts history 3) Try to place hold on one of titles from history for this patron 4) You should see an information at the top of confirm request page, but you still should be able to place a hold 5) Try this with multiple titles - one or more of them should be from history 6) You should see this information in "Information" column 7) There is also new column placed at the beggining with checkbox, you could uncheck it for titles you do not want to place a hold on it 8) Confirm the hold is placed only on checked titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:40:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 09:40:01 +0000 Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the title checked out during placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 --- Comment #4 from Josef Moravec --- (In reply to Cab Vinton from comment #2) > Received the following error message on attempting to place a hold: > > Software error: > Global symbol "$multihold" requires explicit package name (did you forget to > declare "my $multihold"?) at /home/koha/src/reserve/request.pl line 374. > Execution of /home/koha/src/reserve/request.pl aborted due to compilation > errors. > > Tested in Sandbox 06. > > Apologies if my testing went off the rails. First attempt to sign off on a > patch. My bad, now it is corrected and rebased on master, you can try it again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:09:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 10:09:29 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:09:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 10:09:32 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75455|0 |1 is obsolete| | --- Comment #70 from Ere Maijala --- Created attachment 76612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76612&action=edit Bug 19893 - Alternative optimized indexing for Elasticsearch Implement optimized indexing for Elasticsearch How to test: 1) Time a full elasticsearch re-index without this patch by running the rebuild_elastic_search.pl with the -d flag: `koha-shell -c "time rebuild_elastic_search.pl -d"`. 2) Apply this patch. 3) Time a full re-index again, it should be about twice at fast (for a couple of thousand biblios, with fewer biblios results may be more unpredictable). Sponsored-by: Gothenburg University Library Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:09:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 10:09:41 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75660|0 |1 is obsolete| | --- Comment #72 from Ere Maijala --- Created attachment 76614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76614&action=edit Bug 19893: Add index status Add persistent per index "index status" state to provide useful user feedback when update of Elasticsearch server mappings fails Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:09:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 10:09:37 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75588|0 |1 is obsolete| | --- Comment #71 from Ere Maijala --- Created attachment 76613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76613&action=edit Bug 19893: Remove serialization format setting Default to base64 encoded binary MARC with MARCXML fallback if record exceeds maximum size Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:11:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 10:11:43 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #73 from Ere Maijala --- I took the liberty of adding "if (@body)" check in bulk_index so that e.g. an empty authority index can be created without errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:13:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 10:13:04 +0000 Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:25:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 10:25:07 +0000 Subject: [Koha-bugs] [Bug 20902] Labels/t_Batch.t fails on fresh database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20902 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Marcel de Rooy --- *** This bug has been marked as a duplicate of bug 20900 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:25:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 10:25:07 +0000 Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 --- Comment #6 from Marcel de Rooy --- *** Bug 20902 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:49:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 10:49:22 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bibliwho at gmail.com --- Comment #2 from Cab Vinton --- (In reply to Owen Leonard from comment #1) > Created attachment 76436 [details] [review] > Bug 20507: Shelf browser does not update image sources when paging > > This patch updates the shelfbrowser include so that the system > preference check for Coce will function correctly. > > To test, apply the patch and test the OPAC shelf browser with each of > the enhanced content options enabled: Coce, Amazon, Google. In each > case, page through the shelf browser to confirm that covers load > correctly. The patch seemed to work fine in Sandbox 06, clearing the cache for each content option. Several items had covers missing, but these all appeared to titles for which no covers were available in the first place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:14:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:14:52 +0000 Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the title checked out during placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Cab Vinton --- All good now :-) Cheers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:18:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:18:50 +0000 Subject: [Koha-bugs] [Bug 20492] Add missing case for advanced search year limit in _fix_limit_special_cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 --- Comment #4 from David Gustafsson --- Yes, but it will be converted to the right format, so both formats are supported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:20:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:20:14 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #74 from David Gustafsson --- Ok, great! Thanks for the sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:46:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:46:49 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |DUPLICATE --- Comment #18 from Marcel de Rooy --- *** This bug has been marked as a duplicate of bug 12759 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:46:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:46:49 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #25 from Marcel de Rooy --- *** Bug 17273 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:46:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:46:51 +0000 Subject: [Koha-bugs] [Bug 17892] Move _extract_biblionumbers to a module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17892 Bug 17892 depends on bug 17273, which changed state. Bug 17273 Summary: Batch MARC Modification - improve options to define which records to modify https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:49:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:49:57 +0000 Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 --- Comment #6 from Owen Leonard --- (In reply to Katrin Fischer from comment #3) > Do you plan on changing the icons on the opac-detail page and others as well? I do not have an immediate plan for that, although I think it's a good idea to refresh those icons (as part of 20554 maybe?). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:53:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:53:11 +0000 Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75694|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Created attachment 76615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76615&action=edit Bug 20487: AddReturn should clear items.onloan for unissued items If an item is no longer issued but somehow still has a date in the onloan column, checking it in should clear that date. Adding a ModItem call in the NotIssued section. Test plan: [1] Run t/db_dependent/Circulation.t [2] Bonus: Checkout item, delete issue from table, checkin. Verify that items.onloan has been cleared. Signed-off-by: Marcel de Rooy Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:53:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:53:15 +0000 Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75695|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy --- Created attachment 76616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76616&action=edit Bug 20487: (QA follow-up) Requested db revision As requested in comment12, we can update these cases in a dbrev too. Signed-off-by: Marcel de Rooy Checked out item, deleted issue record, ran dbrev. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:53:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:53:51 +0000 Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 --- Comment #22 from Marcel de Rooy --- Simple rebase on Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:56:05 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72913|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy --- Created attachment 76617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76617&action=edit Bug 17530: Add Koha::IssuingRules->guess_article_requestable_itemtypes This routine looks at the issuingrules and makes a fast 'intelligent guess' if article requests may be allowed for item types while branch code and patron category may not be available. We also add Koha::Biblio->may_article_request using the routine based on default item type or parameter. Implemented as both class and instance method. Added a few tests. Test plan: [1] Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t [2] Run t/db_dependent/ArticleRequests.t to test Koha::Biblio changes. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:56:10 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72914|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy --- Created attachment 76618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76618&action=edit Bug 17530: Use may_article_request method in opac-search If you enable pref ArticleRequests, until now all search results got the 'Request article' link. This patch tries to improve the situation by using the new sub with the itemtype of the search result. In most cases the number of links will drastically decrease. It may still be possible sometimes that a link is shown while it effectively is not possible, but we do not get the performance burden of determining that and going through all items. Test plan: [1] Look for two borrowers P1 and P2 within categories C1 resp. C2. [2] Look for two biblios B1 and B2 with default item types I1 resp. I2. (See 942c in case of MARC21.) [3] Make sure that no circ rules allow article requests. Enable the pref. [4] Add/modify circ rule category=C1, itemtype=I1, art_req=yes. Log out. Search for B1 and B2, verify that only B1 has AR link. Log in as P1. Verify that only B1 has AR link. Log in as P2. Verify that no biblio has AR link. [5] Add/modify circ rule category=C2, itemtype=I2, art_req=item_only. Log out. Search for B1 and B2, verify that both have AR links. Log in as P1. Verify that only B1 has AR link. Log in as P2. Verify that only B2 has AR link. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:56:15 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72915|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 76619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76619&action=edit Bug 17530: Use can_article_request to control sidebar link Before this patch, the 'Request article' link is displayed whenever the pref is enabled. In many cases this might be useless. Instead of a guess as in opac-search, we now call can_article_request to know for sure. Note: at least this is the case when a user has logged in. Update sidebar template with template variable artreqpossible. Add code in opac-detail, MARCdetail and ISBDdetail to fill it. Test plan: [1] Look for two biblios with items: one that should allow article requests and one that should not (respecting branch, patron, item type). [2] Verify on detail, ISBD and MARC that the link is displayed for the first biblio and hidden for the second biblio. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:56:20 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72931|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy --- Created attachment 76620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76620&action=edit Bug 17530: (QA follow-up) Replace our variable by cached value Instead of saving the state locally in a variable during Plack lifetime, we move the saved hash to the cache. We clear the key when we enter smart-rules.pl. This makes a change in circ rules immediately effective. Test plan: Run the modified tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:56:24 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75697|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Created attachment 76621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76621&action=edit Bug 17530: (QA follow-up) Replace class_or_self variables See comment23. Requested by QA. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:56:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:56:29 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75751|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy --- Created attachment 76622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76622&action=edit Bug 17530: (QA follow-up) Move may_article_request to ItemType As requested by QA, we should move may_article_request out of Biblio. For reasons of performance removed the wrapper layer of may_article_request in opac-search. No need to look up all item types. For readability kept the routine in the detail scripts. Note for running ArticleRequests.t: A possible failure on the subtest 'search_limited' is addressed on bug 20866. So you can ignore that one. As long as the subtest for may_article_request passes. Test plan: See previous patches. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:58:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:58:05 +0000 Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76491|0 |1 is obsolete| | Attachment #76492|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 76623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76623&action=edit Bug 7547: printing a sorted cart This patch adds a DataTables-generated print button to the OPAC cart. To make that process easier, the DataTables plugin has been upgraded to the latest version (1.10.18) with the Buttons plugin included. Changes to the OPAC LESS file style the DataTables button to look like the static version. Other templates in the OPAC which use the DataTables plugin have been modified to use up-to-date option names. To test, apply the patch and add several titles to the cart. - Open the cart - Re-sort the cart using something other than the default sort - Click the 'Print' button. - A print view should open in a separate window, sorted correctly, and automatically show the print dialog. - Click the cart's 'More details' button and click the print button. - This should trigger the print dialog directly. - Test DataTables sorting on other modified pages: - Bibliographic detail page (holdings table) - Course reserves (table of courses) - Course details (table of titles) - Full subscription history - Detail page for a subscription -> More details -> Full history - Most popular - Purchase suggestions - Self checkouts - Tag cloud - Your fines - Your interlibrary loan requests - Your reading history - Your search history - Your search IDREF for ppn (I don't know how to test this) The DataTables plugin is removed from "Your routing lists" and Self check-in because it is unused. Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:57:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:57:47 +0000 Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no article requests are permitted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530 --- Comment #38 from Marcel de Rooy --- Jonathan: Did you see the last changes after your comment ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:58:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:58:08 +0000 Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #13 from Nick Clemens --- Created attachment 76624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76624&action=edit Bug 7547: (QA follow-up) Make button background transparent for consistency Test plan: Add some records to cart in opac and show the cart, look at the print button/link --> without patch it has darker background than other buttons --> with this patch it has the same background Note: tested wir firefox 45, firefox 60 and chromium 66 Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:58:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:58:12 +0000 Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 --- Comment #14 from Nick Clemens --- Created attachment 76625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76625&action=edit Bug 7547: (RM follow-up) Compiled css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:58:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:58:55 +0000 Subject: [Koha-bugs] [Bug 19519] Ability to bind the rotating collection with branch during creating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #9 from Owen Leonard --- Depends on Bug 18606 which is currently Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:58:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 11:58:59 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 --- Comment #28 from Cab Vinton --- (In reply to Jonathan Druart from comment #22) > Did you test the rebase patches? So I've learned how to sign off on patches, but the status of this patch is Failed QA. If a dashboard XML file needs to be created, then not sure whether testing via a sandbox would work. Tried Sandbox 06 anyway & got the following: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 6828:

Something went wrong !

Applying: Bug 6828[ENH] - Add basic Dashboard for staff users. .git/rebase-apply/patch:483: trailing whitespace. warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Auth.pm M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref M koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt M mainpage.pl .git/rebase-apply/patch:483: trailing whitespace. warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging mainpage.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging C4/Auth.pm CONFLICT (content): Merge conflict in C4/Auth.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 6828[ENH] - Add basic Dashboard for staff users. The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 6828 - Add Admin Dashboard for staff users. 10217 - [SIGNED-OFF] Bug 6828[ENH] - Add basic Dashboard for staff users. 10218 - [SIGNED-OFF] Bug 6828 follow-up: adapt dashboard to new staff client theme 60692 - Bug 6828[ENH] - Add basic Dashboard for staff users. 60693 - Bug 6828 follow-up: adapt dashboard to new staff client theme Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/SIGNED-OFF-Bug-6828ENH---Add-basic-Dashboard-for-s-EpoHfa.patch . -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:20:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 12:20:00 +0000 Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #22 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #21) > Marcel, (last patch) could not we use only null (instead of undefined vs > null)? Please see comment19. I need both values. These are standard values in javascript helping us to make the distinction between not yet initialized and null returned by a cancel. In order to meet your comment, I added comments. > There is also a tiny ergonomic issue, hit /circ/article-requests.pl, click > the "processing" tab. There are the "select all" and "clear all" links, if > the table is empty and you click on one of them they will disappear. Good catch. Fixed on last follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:20:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 12:20:23 +0000 Subject: [Koha-bugs] [Bug 20468] Multiselect on staff article requests form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #23 from Marcel de Rooy --- Created attachment 76626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76626&action=edit Bug 20468: (QA follow-up) Deactivate select/clear all for empty tab This only pertains to the second (Processing) tab. Test plan: [1] Have one entry in Pending and zero in Processing. [2] Click on Processing tab. [3] Without this patch, you would see Select all/Clear all. With this patch, you won't. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:22:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 12:22:26 +0000 Subject: [Koha-bugs] [Bug 20469] Add item status to staff article requests form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73388|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 76628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76628&action=edit Bug 20469: (Follow-up) Make translation of status possible As Mark noticed, adding a span for each status will allow for translation. Note that the menu options in the block before are inside html tags like .... and will be translated (as long as spaces match). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:22:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 12:22:22 +0000 Subject: [Koha-bugs] [Bug 20469] Add item status to staff article requests form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73282|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 76627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76627&action=edit Bug 20469: Add item status to staff article request form A method Koha::Item->is_waiting_or_transit is added (with tests). The template checks if an item is checked out, on hold (waiting or transit), or is available. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Run t/db_dependent/Koha/Items.t [2] Place an article request on an item on loan. Verify status on form. [3] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:24:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 12:24:33 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #75 from Ere Maijala --- Created attachment 76629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76629&action=edit Fix Elasticsearch tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:56:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 12:56:00 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Attachment #73550|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:56:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 12:56:25 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73797|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:56:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 12:56:12 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73551|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:06:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:06:21 +0000 Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #111 from Marcel de Rooy --- - - "Any of these characters can be used as a separator between integer and decimal parts in the price fields. To work well with thousands separators you must (usually) choose between dot and comma to avoid ambiguity. So thousands separators come at the expense of handling both dots and commas. It you want to format price output, please use the system preference 'CurrencyFormat'" + - "Any of these characters can be used as a separator between integer and decimal parts in the decimal number fields that use the associated normalizing/unformatting mechanism. To also use thousands separators you must choose between dot and comma to avoid ambiguity. So using thousands separators comes at the expense of handling both dots and commas as decimal separators. This means reserving one character for decimal separation and another for thousands separation. So you must not use characters from the DecimalSeparators preference also as thousands separator. Also, if you want to format price output, please use the system preference 'CurrencyFormat'" The second description is imo too long. Let me try to suggest something shorter: Any of these characters can be used as a separator between integer and decimal part of a price field. To avoid ambiguity, do not use the same characters as thousands separator. Use pref CurrencyFormat to format price ouput. => Instead of the cryptic "fields that use the associated normalizing/unformatting mechanism", you might add something like: (This pref is currently used on the patron fines tab.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:07:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:07:57 +0000 Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #112 from Marcel de Rooy --- Does the followups require all the fields to be retested? And put back the patch to "Needs Signoff". TODO wait answer, blocking question Imo we can keep the signed off state. Please adjust the last follow-up and let me finish QA on friday(?). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:08:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:08:07 +0000 Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:10:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:10:26 +0000 Subject: [Koha-bugs] [Bug 19436] Add SRU support for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #24 from Nick Clemens --- Changes from 15360 cause conflicts, can you rebase/add a follow up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:14:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:14:45 +0000 Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:15:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:15:05 +0000 Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:15:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:15:34 +0000 Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:15:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:15:19 +0000 Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:15:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:15:49 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:16:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:16:03 +0000 Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:16:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:16:17 +0000 Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:16:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:16:32 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:16:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:16:48 +0000 Subject: [Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:17:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:17:19 +0000 Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #20 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:17:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:17:03 +0000 Subject: [Koha-bugs] [Bug 20272] XSLT_Handler should use alphanumeric error codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20272 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:17:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:17:32 +0000 Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #24 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:17:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:17:51 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:18:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:18:06 +0000 Subject: [Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier metadata" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:18:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:18:51 +0000 Subject: [Koha-bugs] [Bug 19436] Add SRU support for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 --- Comment #25 from Marcel de Rooy --- (In reply to Nick Clemens from comment #24) > Changes from 15360 cause conflicts, can you rebase/add a follow up? You should have waited a bit with that one, huh ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:29:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:29:00 +0000 Subject: [Koha-bugs] [Bug 1884] Managing Suggestions - way to archive/clean up approved/rejected orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1884 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:50:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:50:06 +0000 Subject: [Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #23 from Jonathan Druart --- (In reply to Katrin Fischer from comment #22) > Owen, could we get your opinion on Jonathan's follow-up? > Patches don't apply right now as attached to the bug, but I am not sure if > only some should be applied. Please take a look. They apply correctly, it's either Owen's patch (the first one), or mines (the 3 others). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:52:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:52:00 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #4 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > Ok, a little confused by the graph - didn't spot any patch with patches > still needing work. Can you point me the right direction? I do not plan to get back to this soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:53:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:53:26 +0000 Subject: [Koha-bugs] [Bug 21019] [17.11] Borrower address not shown on reserve pop-up on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:55:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 13:55:41 +0000 Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #3 from Jonathan Druart --- Important note: We certainly need to add an index on this column to boost this query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:09:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 14:09:35 +0000 Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #113 from Victor Grousset/tuxayo --- Thanks Marcel for your feedback, I hope to process it in the following days. I just came to ask this question: Should the DecimalSeparators syspref be shared to HEA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:39:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 14:39:51 +0000 Subject: [Koha-bugs] [Bug 21026] New: Statistics tab in patron account should show descriptions instead of codes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21026 Bug ID: 21026 Summary: Statistics tab in patron account should show descriptions instead of codes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The statistics tab in the patron account shows codes instead of descriptions for - collection - location - item types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:56:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 14:56:00 +0000 Subject: [Koha-bugs] [Bug 21027] New: Totals in statistics tab change when StatisticsFields is changed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Bug ID: 21027 Summary: Totals in statistics tab change when StatisticsFields is changed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com As we understand it the totals in the last line of the statistics table in the patron account should be always the same, independent of the selection made in the StatisticsFields system preference. This is not the case. When "location" is removed, the total is less than with "location". I think this might have something to do with the group and empty values for some entries, but have not been able to find the problem yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:17:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:17:34 +0000 Subject: [Koha-bugs] [Bug 20469] Add item status to staff article requests form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:17:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:17:37 +0000 Subject: [Koha-bugs] [Bug 20469] Add item status to staff article requests form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76627|0 |1 is obsolete| | Attachment #76628|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 76630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76630&action=edit Bug 20469: Add item status to staff article request form A method Koha::Item->is_waiting_or_transit is added (with tests). The template checks if an item is checked out, on hold (waiting or transit), or is available. (Note: This can be extended in the future in a general include as we have at opac side.) Test plan: [1] Run t/db_dependent/Koha/Items.t [2] Place an article request on an item on loan. Verify status on form. [3] Place an article request on a waiting item. Check status again. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:17:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:17:15 +0000 Subject: [Koha-bugs] [Bug 21028] New: www/history.t is failing on jenkins for Ubuntu 18.04 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 Bug ID: 21028 Summary: www/history.t is failing on jenkins for Ubuntu 18.04 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: martin.renvoize at ptfs-europe.com, mirko at abunchofthings.net, nick at bywatersolutions.com, tomascohen at gmail.com t/db_dependent/www/history.t is failing with the following error on Ubuntu 18.04 (at least with the image from koha-testing-docker): koha_1 | # Failed test 'Cyrillic characters with umlauts show correctly on the history page.' koha_1 | # at t/db_dependent/www/history.t line 68. It is *not* an encoding issue, the problem is that history.txt is not found: Could not read the history.txt file. Please make sure is correctly defined in koha-conf.xml. >From koha-conf.xml: /usr/share/doc/koha-common Indeed this location does not contain history.txt: root at 95f30c756223:/kohadevbox/koha# ls /usr/share/doc/koha-common changelog.Debian.gz copyright I have no idea if it is a koha issue, a packaging issue, or a koha-testing issue. Does anyone has an idea? https://jenkins.koha-community.org/job/Koha_18.05_U18/14/consoleFull -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:17:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:17:39 +0000 Subject: [Koha-bugs] [Bug 20469] Add item status to staff article requests form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 --- Comment #9 from Owen Leonard --- Created attachment 76631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76631&action=edit Bug 20469: (Follow-up) Make translation of status possible As Mark noticed, adding a span for each status will allow for translation. Note that the menu options in the block before are inside html tags like .... and will be translated (as long as spaces match). Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:17:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:17:56 +0000 Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #2 from Andrew Isherwood --- Hi Benjamin I'm not aware of anywhere where we query that table on type or value, it's only ever the illrequest_id we query via the join. So I'm not sure of the value of adding these indexes. I might be missing something though, so please put me straight if so! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:21:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:21:01 +0000 Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 --- Comment #20 from Tom?s Cohen Arazi --- Created attachment 76632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76632&action=edit Bug 20946: (QA follow-up) make outstanding_debits return the account lines only This patch was discussed with Jonathan on a QA conversation. It is better to keep this simpler and more reusable. And is the right approach in this case. This patch makes Koha::Account::outstanding_debits return the account lines, and a method is added to Koha::Account::Lines so the outstanding amount is calculated on the resultset. This is done the dame way it was done before, and the tests got adjusted. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:21:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:21:19 +0000 Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:30:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:30:33 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76439|0 |1 is obsolete| | --- Comment #21 from Tom?s Cohen Arazi --- Created attachment 76633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76633&action=edit Bug 20978: Unit tests This patch adds unit tests for Koha::Account::add_credit. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:30:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:30:39 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76440|0 |1 is obsolete| | --- Comment #22 from Tom?s Cohen Arazi --- Created attachment 76634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76634&action=edit Bug 20978: Add Koha::Account::add_credit This patch adds: - Koha::Account::add_credit - A single source of truth for accounttype and offset_type values To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:30:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:30:46 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76441|0 |1 is obsolete| | --- Comment #23 from Tom?s Cohen Arazi --- Created attachment 76635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76635&action=edit Bug 20978: (follow-up) Another use case from C4::Circulation Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:30:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:30:55 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76515|0 |1 is obsolete| | --- Comment #24 from Tom?s Cohen Arazi --- Created attachment 76636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76636&action=edit Bug 20978: (follow-up) POD completeness Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:34:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:34:12 +0000 Subject: [Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to create a new basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Fanny Mion Mouton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fanny.mion-mouton at bulac.fr --- Comment #4 from Fanny Mion Mouton --- At BULAC, we have a preference for the first option : "1. You are on the vendor view (/acqui/supplier.pl?booksellerid=X), click on "New > Duplicate a basket", then you select the order lines you want to duplicate" ! Tanks a lot ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:35:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:35:39 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:35:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:35:42 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76609|0 |1 is obsolete| | --- Comment #18 from Owen Leonard --- Created attachment 76637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76637&action=edit Bug 12365: Notes for rules This patch adds a note column to the circ and fine rules to act as a description line for the rule. To test: 1) Apply patch, update database (may have to also update schema) 2) Go to Admin -> Circ and fine rules 3) Scroll to the right, notice new Note column 4) Confirm it works to create a brand new rule with a Note 5) Confirm it works to modify an existing rule with a Note Sponsored-by: Catalyst IT Lee Jamison rescued this patch. It is a clean re-build of attachments 61865 and 63902 to fix the merge conflict introduced during application of both attachments. Signed-off-by: Mark Tompsett Signed-off-by: macon lauren KohaCon17 Signed-off-by: Katrin Fischer Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:37:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:37:37 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #19 from Owen Leonard --- I amended the commit message to include the original test plan. A couple of follow-ups I'd like to see: 1. Put a maxlength attribute on the form field, since the database column limits to 100 characters. 2. Add some way to show/hide the notes to conserve space, perhaps a popover? https://getbootstrap.com/docs/3.3/javascript/#popovers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:51:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 15:51:06 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:14:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 16:14:23 +0000 Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | --- Comment #8 from Tom?s Cohen Arazi --- Kyle, I've tested the patches and they work as expected. All good :-D My only doubt is about terminology. I know the 'Writeoff' value is used on the offset types, but at least on the UI we should use a common way of writing it. I've found: - Write off - Writeoff And then I mostly found references to 'Write-off' everywhere on the internet. Certainly not a big deal, but worth fixing on this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:19:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 16:19:59 +0000 Subject: [Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #1 from Martin Renvoize --- Glad you created a bug for this, I was also coming up empty and about to do the same when I saw yours come in :). Afraid I can't add much more than that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:40:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 16:40:10 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #53 from Owen Leonard --- (In reply to Katrin Fischer from comment #42) > - OpacMainUserBlock remains at the bottom - is that intended? I think Quote of the Day and OpacMainUserBlock shouldn't show if you're looking at one news item. A problem I found: If there is no news to display, OpacMainUserBlock and Quote of the Day don't show at all. I think the [% END %] at line 131 is misplaced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:41:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 16:41:39 +0000 Subject: [Koha-bugs] [Bug 20962] Overhaul to notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #8 from Barton Chittenden --- (In reply to Jonathan Druart from comment #5) > is going to be deprecated, you should use the TT syntax for notice > instead. > It basically means there will certainly no need to dev anything to support > that (apart of adapting the template to your needs). When I first read through the RFC, this was the point that concerned me the most. Currently, we have the following ways of looping through detail inside of notices: <> ---- Detail here ---- Whatever CLAIMSERIAL does. Not all of these fit nicely with -- and having a more flexible and consistent looping construct was one of Kyle's motivations for introducing TT into notices. TT exists as a parsing layer in all notices right now -- rather than extending tags, I would prefer to extend Koha/Template/Plugin to create more user friendly looping constricts in TT, then deprecate <>, , the '----' detail, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:47:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 16:47:58 +0000 Subject: [Koha-bugs] [Bug 21029] New: "Suspend until" in modal in staff patron account is not translatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Bug ID: 21029 Summary: "Suspend until" in modal in staff patron account is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr To test: - Place a hold on an item - Go to the patron account - Click on the Suspend button on the holds tab - View the modal, the label before the date field "Suspend until:" is not translatable. The label is part of the holds.js file. As .js files are never translatable it needs to be moved to template level. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:52:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 16:52:12 +0000 Subject: [Koha-bugs] [Bug 21030] New: Date widget on suspend modal not working correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Bug ID: 21030 Summary: Date widget on suspend modal not working correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The date widget on the modal for suspending holds is behaving strangely with the pull downs for seleting a month or year being unusable. To test: - Place a hold on an item - Go to the patron account - Click on the Suspend button on the holds tab - Click on the calendar to enter a date - Click on the pull downs for month and year, the pull downs don't open - Verify the arrow buttons still work for moving between months -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:56:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 16:56:39 +0000 Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:58:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 16:58:51 +0000 Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:01:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 17:01:45 +0000 Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:04:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 17:04:42 +0000 Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | Status|Pushed to Master |Pushed to Stable --- Comment #10 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:07:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 17:07:12 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #18 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:09:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 17:09:36 +0000 Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:11:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 17:11:35 +0000 Subject: [Koha-bugs] [Bug 7547] Printing a sorted cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Severity|minor |enhancement CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #16 from Martin Renvoize --- Enhancement, not porting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:14:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 17:14:46 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable Severity|enhancement |minor --- Comment #9 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:17:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 17:17:49 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |17.11 Severity|normal |major CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- We've just seen this behaviour in 17.11. The problem seems to appear as soon as another graphic in addition to the photo is added to the patron cards. This should be fixed. If it goes unnoticed, this could be quite a privacy issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:17:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 17:17:50 +0000 Subject: [Koha-bugs] [Bug 20495] Refactor C4::Reports.Guided - remove get_saved_report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #13 from Martin Renvoize --- Enhancement, not back porting for 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:19:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 17:19:04 +0000 Subject: [Koha-bugs] [Bug 20272] XSLT_Handler should use alphanumeric error codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20272 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize --- Enhancement, not back porting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:07:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 18:07:50 +0000 Subject: [Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- I find that my staff user can see the list created by another staff member and edit it, but can't view it. When trying to view it I get an incorrectly-styled dialog, "You do not have permission to view this list." Also, the 'delete' button appears but doesn't work. Should I be able to add to a staff list if I have the correct permission? The staff lists are not available in the "Add to list" window triggered from the biblio detail page. One QA tool failure: FAIL Koha/Virtualshelf.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for is_staff OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:49:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 18:49:38 +0000 Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76450|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 76638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76638&action=edit Bug 19617: Allow 'writeoff of selected' This patch adds a writeoff equivilent to 'Pay selected' Test Plan: 1) Apply this patch 2) Find a patron with fines 3) On the "Pay fines" tab, select one or more fines and use the "Write off selected" button. 4) Note the fine amount you used was written off for those fines. Signed-off-by: Kyle M Hall Signed-off-by: Martha Fuerst Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:49:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 18:49:44 +0000 Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617 --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 76639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76639&action=edit Bug 19617: (QA follow-up) Fix typo for type Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:50:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 18:50:13 +0000 Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:53:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 18:53:12 +0000 Subject: [Koha-bugs] [Bug 18216] Apache2.4 403 errors for Gitified or git clone installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18216 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 21:12:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 19:12:09 +0000 Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 76640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76640&action=edit Bug 20990: (QA follow-up) make outstanding_credits return the account lines only This patch was discussed with Jonathan on a QA conversation. It is better to keep this simpler and more reusable. And is the right approach in this case. This patch makes Koha::Account::outstanding_credits return the account lines, code that used the $total value, will just use $lines->total_outstanding; Tests are adjusted accordingly. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Test pass. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 21:21:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 19:21:29 +0000 Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 76641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76641&action=edit Bug 20942: (QA follow-up) Use $lines->total_outstanding This patch makes the controller code use $lines->total_outstanding instead of expecting ->outstanding_debits and ->outstanding_credits return the total. Tests should pass as before. No behaviour change is expected. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests still pass, no behaviour change. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 21:25:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 19:25:10 +0000 Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 --- Comment #11 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #9) > General question: cannot we have only one of $to_api_mapping and > $to_model_mapping, and generate the other one? It seems that we are > duplicating the information. I don't think this is urgent, but yes, we could have a hash of hashes, one of them generated by reverse. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 21:28:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 19:28:11 +0000 Subject: [Koha-bugs] [Bug 21019] [17.11] Borrower address not shown on reserve pop-up on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 21:28:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 19:28:15 +0000 Subject: [Koha-bugs] [Bug 21019] [17.11] Borrower address not shown on reserve pop-up on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76602|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 76642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76642&action=edit Bug 21019: Fix display of patron's address on reserve pop-up on returns.pl Caused by commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6 Bug 17829: Move GetMember to Koha::Patron address variable has been replaced by boraddress (wrong resolution conflict?) It does not affect master (thanks bug 18789) Test plan: Confirm the address of the patron with a hold placed on the item is now displayed when this item is checked in Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 21:28:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 19:28:54 +0000 Subject: [Koha-bugs] [Bug 21019] [17.11] Borrower address not shown on reserve pop-up on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 21:29:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 19:29:54 +0000 Subject: [Koha-bugs] [Bug 20944] Add routes to add credits and debits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 21:29:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 19:29:54 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 [Bug 20944] Add routes to add credits and debits to a patron's account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 22:32:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 20:32:31 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #9 from Chris Nighswonger --- (In reply to Derryn from comment #0) > Steps to reproduce: > > 1. In the patron creator, set up a layout with patron images enabled > 2. Create a batch starting with a patron that does NOT have a picture stored > 3. Next choose one that DOES > 4. Finally choose one that does NOT > 5. Export the batch > 6. Resulting PDF will show > i) the first one is correct (no picture) > ii) the second one will correctly show it's own picture > iii) the third one will (incorrectly) show the previous patron's picture I cannot duplicate this in 18.05.01.000. Maybe you can attach a screen-shot of your layout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 22:38:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 20:38:45 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #10 from Chris Nighswonger --- (In reply to lightpurpledye from comment #6) > Possibly related: If the image file for one patron has a greater > horizontal:vertical ratio than the image file for the patron immediately > after them in the batch, then the first patron's image is shown below the > second patron's image. > > e.g. Steps to reproduce > 1. In the patron creator, set up a layout with patron images enabled. > 2. Create a batch starting with a patron that has a 300x100 image stored. > 3. Next choose one with a 200x100 image. > 4. Export the batch. > 5. Resulting PDF will show: > i) The first one is correct (patron a's picture) > ii) The second one is incorrect (There are 100 pixels of patron a showing > underneath patron b). > > This suggests to me that when the PROCESS_IMAGES loop has an iteration it > actually prints the image in every subsequent image position and then relies > on the incorrect images being printed over in the next iteration. This would > explain why, if a patron does not have an image stored, they would get the > previous patron's image. > > If this turns out to be unrelated, I can open a separate bug report for it. I cannot duplicate this in 18.05.01.000 either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 22:40:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 20:40:00 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #11 from Chris Nighswonger --- (In reply to Katrin Fischer from comment #8) > We've just seen this behaviour in 17.11. The problem seems to appear as soon > as another graphic in addition to the photo is added to the patron cards. > > This should be fixed. If it goes unnoticed, this could be quite a privacy > issue. Katrin, can you provide exact steps to duplicate the problem you are seeing? Also, can you confirm the issue exists in 18.05.01.000? I seem to be unable to reproduce any of the variations of this bug locally on 18.05.01.000. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 22:47:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 20:47:30 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #12 from Chris Nighswonger --- Better yet, could someone(s) provide me with the results of the following query: SELECT layout_xml FROM creator_layouts\G -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 22:53:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 20:53:12 +0000 Subject: [Koha-bugs] [Bug 20962] Overhaul to notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #9 from Joy Nelson --- > > # Step 5 - Allow for 'digesting' of all notices in queue regardless of type > Our implementation team found this (#5) intriguing. One email versus 3 emails is great. Are you allowing for the option of not including certain messages in the digest? For example, X library would not want overdue notices to be part of a larger digest message. Overdue notices would be sent separately, but other messages could be digestible - member renew, checkout, predue, hold placed... It's not listed in the initial message but on the RFC wiki page, you mention #8 "Do not disturb" option. YES. this would be so helpful! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 23:34:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 21:34:22 +0000 Subject: [Koha-bugs] [Bug 15287] Use font-awesome on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 --- Comment #7 from Katrin Fischer --- > I do not have an immediate plan for that, although I think it's a good idea > to refresh those icons (as part of 20554 maybe?). That could work - or have a separate bug. Was wondering, but should not block this or the other bug unnecessarily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 23:39:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 21:39:20 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Cab, you can also mark the patch as signed off from the sandboxes by using the form at the bottom. We can add your name in QA for this one, maybe for your next! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 00:08:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 22:08:40 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #4 from Cab Vinton --- (In reply to Katrin Fischer from comment #3) > Hi Cab, you can also mark the patch as signed off from the sandboxes by > using the form at the bottom. We can add your name in QA for this one, maybe > for your next! OK, thank you, Katrin. Was thinking I should post on BugZilla, where it's just as easy to update the status. But that's probably not necessary ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 00:12:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 22:12:23 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #5 from Katrin Fischer --- (In reply to Cab Vinton from comment #4) > (In reply to Katrin Fischer from comment #3) > > Hi Cab, you can also mark the patch as signed off from the sandboxes by > > using the form at the bottom. We can add your name in QA for this one, maybe > > for your next! > > OK, thank you, Katrin. Was thinking I should post on BugZilla, where it's > just as easy to update the status. But that's probably not necessary ... Setting the status is alright, but using the sign-off feature will also add your name as a sign-off to the patches, which will make your name go into release notes etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 00:13:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 22:13:34 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #6 from Katrin Fischer --- ... also your sign-offs made my day, thx! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 00:19:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2018 22:19:24 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #7 from Cab Vinton --- Ah, gotcha. Excellent. The tutorial video was helpful. Think developers should add a code to the bugs needing Sign Offs -- TBAI (Testable by Any Idiot) ;-) With several hundred bugs, it can take some time to identify the ones that don't require CLI access, don't have too many moving parts, etc. Not complaining by any means, but it might increase the number of bugs that get signed off by everyday librarians, which should be a good thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 03:45:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 01:45:36 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- Is this work in progress or are other solutions to this acceptable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 07:30:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 05:30:17 +0000 Subject: [Koha-bugs] [Bug 18983] koha-create does not default to --create-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18983 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I had this same issue... I had to specify "koha-create --create-db library" rather than "koha-create library" as I was getting the following error message with the latter command: 'failed to load external entity "/etc/koha/sites/library/koha-conf.xml"' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 08:50:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 06:50:20 +0000 Subject: [Koha-bugs] [Bug 20402] OAuth2 client credentials grant for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #73 from David Cook --- I know this has already been pushed... but it looks like this allows for only 1 API client? What if you want to have multiple API clients? BibLibre might have Coral talking to Koha's REST API, but maybe a client's Drupal website wants to talk to Koha's REST API too? Right now, I suppose you could share the credentials amongst all the clients, but that doesn't seem like a great long-term option? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 09:01:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 07:01:51 +0000 Subject: [Koha-bugs] [Bug 20402] OAuth2 client credentials grant for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 --- Comment #74 from Julian Maurice --- (In reply to David Cook from comment #73) > I know this has already been pushed... but it looks like this allows for > only 1 API client? What if you want to have multiple API clients? You could define as many API clients as you want in $KOHA_CONF. But this has been replaced by bug 20568 and bug 20612. You can now define API keys in the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 09:23:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 07:23:20 +0000 Subject: [Koha-bugs] [Bug 21019] [17.11] Borrower address not shown on reserve pop-up on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #4 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 Ticky dependancy bug ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 09:30:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 07:30:51 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #65 from Martin Renvoize --- I agree this should be moved to Koha::Acquisitions::Invoices::Adjustments, InvoiceAdjustments without the prepended Acquisitions could well be confused with Accounts processing in the future... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 10:09:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 08:09:30 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #66 from Martin Renvoize --- When running the QA scripts I'm seeing a number of warnings: Argument "" isn't numeric in numeric gt (>) at /home/martin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt line 85. Argument "" isn't numeric in numeric gt (>) at /home/martin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt line 162. Argument "" isn't numeric in numeric gt (>) at /home/martin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt line 85. Argument "" isn't numeric in numeric gt (>) at /home/martin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt line 103. And also some POD warnings too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 10:26:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 08:26:15 +0000 Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76091|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen --- Created attachment 76643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76643&action=edit Bug 20949: Koha depends on Clone Clone was not declared a dependency before. It used to be a dependency of Hash::Merge but isn't in the recent version. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 10:26:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 08:26:31 +0000 Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76092|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen --- Created attachment 76644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76644&action=edit Bug 20949: Followup: debian/control Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 10:35:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 08:35:19 +0000 Subject: [Koha-bugs] [Bug 21031] New: Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 Bug ID: 21031 Summary: Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au If you install Koha using the Debian packages and you enable Plack, you should be able to reach the API using the following URL: "/api/v1/" If you install Koha using the Debian packages and you don't enable Plack (or you install from source or you're using a git install or whatever else), you can only get the same API response by visiting "/api/v1/app.pl/api/v1/spec" It appears to me that the Rewrite rules in etc/koha-httpd.conf, debian/templates/apache-shared-opac.conf, and debian/templates/apache-shared-intranet.conf don't work. Fixing this doesn't seem quite as easy as just copying over the Apache configuration for Plack-enabled instances, unfortunately, but I'm looking at this... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 11:08:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 09:08:23 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 11:08:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 09:08:25 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 --- Comment #1 from David Cook --- Created attachment 76645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76645&action=edit Bug 21031 - Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration The Rewrite rules for Apache don't work unless you're using debian/templates/apache-shared-opac-plack.conf or debian/templates/apache-shared-intranet-plack.conf. This patch fixes the Rewrite rules for the non-Plack Debian Apache configuration templates as well as the standard Apache configuration file that comes with Koha. __BEFORE APPLYING__ 1. Visit /api/v1/app.pl/api/v1/spec on your git dev install 2. This should display a large page of JSON 3. Visit /api/v1/spec on your git dev install 4. This should generate a 404 error __APPLY PATCH__ __AFTER APPLYING__ 5. Visit /api/v1/app.pl/api/v1/spec on your git dev install 6. This should display a large page of JSON 7. Visit /api/v1/spec on your git dev install 8. This should display a large page of JSON (identical to the one from earlier steps) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 11:10:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 09:10:16 +0000 Subject: [Koha-bugs] [Bug 20402] OAuth2 client credentials grant for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 --- Comment #75 from David Cook --- (In reply to Julian Maurice from comment #74) > You could define as many API clients as you want in $KOHA_CONF. > But this has been replaced by bug 20568 and bug 20612. You can now define > API keys in the interface. Oooh awesome! I've wanted that feature for so long :D. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 11:24:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 09:24:26 +0000 Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 11:25:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 09:25:08 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Christian Stelzenm?ller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 11:26:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 09:26:11 +0000 Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- This is evil, someone working on a fix? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 11:30:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 09:30:22 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #13 from Christian Stelzenm?ller --- Here are the results from your requested query: BSZ Bibliothek Ausweis <firstname> <surname> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 12:01:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 10:01:38 +0000 Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #21 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02, I felt that although this is marked as an enhancement, many librarians would see it as a bug not being in sync with MARC21 guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 12:04:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 10:04:37 +0000 Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #25 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02, I felt that although this is marked as an enhancement, many librarians would see it as a bug not being in sync with MARC21 guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 12:05:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 10:05:17 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #32 from Martin Renvoize --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 12:06:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 10:06:25 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Bug 18589 depends on bug 20651, which changed state. Bug 20651 Summary: Improve display of "Toggle full supplier metadata" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 12:06:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 10:06:25 +0000 Subject: [Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier metadata" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #12 from Martin Renvoize --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:16:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:16:29 +0000 Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:16:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:16:31 +0000 Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 --- Comment #12 from Ere Maijala --- Created attachment 76646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76646&action=edit Bug 20244: Improve Elasticsearch ISBN indexing https://bugs.koha-community.org/show_bug.cgi?id=20244 Test plan: 1. Add a record with an ISBN-10 or ISBN-13 that can be converted to ISBN-10 (e.g. 1-56619-909-3). 2. Verify that the record can be found by searching for "1-56619-909-3", "1566199093", "978-1-56619-909-4" and "9781566199094". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:16:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:16:35 +0000 Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 --- Comment #13 from Ere Maijala --- Created attachment 76647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76647&action=edit Bug 20244: Add alt script indexing and fix sort field indexing https://bugs.koha-community.org/show_bug.cgi?id=20244 Test plan: 1. Add a record with alternate script fields in 880 (sample attached in the bug). 2. Make sure the the record can be found e.g. with the alternate script title. 3. Add a record with multiple authors. 4. Check that in the index there is only a single author__sort field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:16:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:16:38 +0000 Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 --- Comment #14 from Ere Maijala --- Created attachment 76648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76648&action=edit Bug 20244: Do not add records to zebraqueue when Elasticsearch is active https://bugs.koha-community.org/show_bug.cgi?id=20244 Otherwise the table will just keep growing. Test plan: 1. Add or edit some biblio records. 2. Verify in the database that they were not added to the zebraqueue table. 3. Verify that the changes are still reflected in the Elasticsearch index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:16:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:16:42 +0000 Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 --- Comment #15 from Ere Maijala --- Created attachment 76649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76649&action=edit Bug 20244: Improve indexing so that multiple subfields are joined together https://bugs.koha-community.org/show_bug.cgi?id=20244 Also adds 245b to the title field. Joining the subfields in a single field affects relevancy, exact phrase search etc. It is especially important for authorities where working phrase search is required for finding matches. Test plan: 1. Add a personal name authority record with 100 $aTester $b1999 $eaut 2. Add a personal name authority record with 100 $aTester $baut $c1999 2. Make sure you can find the first and only the first record by doing a "Search main heading" search for Personal name with "starts with" option (N.B. the exact match option may still have issues). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:19:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:19:10 +0000 Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #76 from Ere Maijala --- David, Martin: Please also check out some further fixes (built on top of the work done here) in bug 20244. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:21:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:21:48 +0000 Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 --- Comment #16 from Ere Maijala --- Note that bug 19365 provides further fixes to authority searches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:22:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:22:02 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19365 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:22:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:22:02 +0000 Subject: [Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20664 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:24:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:24:45 +0000 Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19365 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:24:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:24:45 +0000 Subject: [Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20244 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:30:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:30:48 +0000 Subject: [Koha-bugs] [Bug 20244] Elasticsearch - Indexing improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20244 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:31:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:31:16 +0000 Subject: [Koha-bugs] [Bug 19365] link_bibs_to_authorities.pl doesn't work with Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:31:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 11:31:36 +0000 Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:04:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 12:04:31 +0000 Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #114 from Marcel de Rooy --- (In reply to Victor Grousset/tuxayo from comment #113) > I just came to ask this question: Should the DecimalSeparators syspref be > shared to HEA? Good idea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:48:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 12:48:11 +0000 Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug 12509 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:48:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 12:48:13 +0000 Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug 12509 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70070|0 |1 is obsolete| | Attachment #70071|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 76650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76650&action=edit Bug 19849: Minor fixes & refactor of opac-reserve.tt & opac-user.tt - make next patch easely reviewable. - fix lone quote. (Replace by - add forgotten condition for 9999-12-31 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:48:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 12:48:16 +0000 Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug 12509 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 --- Comment #4 from Owen Leonard --- Created attachment 76651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76651&action=edit Bug 19849: Make a string translatable again after a rebase error Bug 16621 reverted part of bug 12509 1. Log in the OPAC and staff interface 2. Restrict the user logged in the OPAC (restricting yourself works) Staff interface ? Patron page ? Restrictions ? Add manual restriction Put this comment the "OVERDUES_PROCESS Give the books back or we're comming!" 3. Install the fr_FR locale and switch the interface to it 4. Go to OPAC: /cgi-bin/koha/opac-user.pl 5. Then you should see the ugly comment with "OVERDUES_PROCESS" 6. Apply this patch 7. Update the translation: ./translate update or equivalent 8. Open misc/translator/po/fr-FR-opac-bootstrap.po 9. Find the string containing "Restriction added by overdues process" 10. Remove the fuzzy flag 11. Install the language 12. Refresh the page in the OPAC 13. Then you should see the translation + the comment instead of "OVERDUES_PROCESS" + the comment Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:50:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 12:50:06 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:05:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:05:13 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #14 from Chris Nighswonger --- (In reply to Christian Stelzenm?ller from comment #13) > Here are the results from your requested query: > > > > > > > > > BSZ Bibliothek > text_alignment="L" /> > Ausweis > text_alignment="L" /> > <firstname> <surname> > > Just to confirm: This layout does produce one of the above described symptoms? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:10:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:10:56 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:13:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:13:25 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > I've changed the documentation on the wiki - can you please check if it's > correct now? https://wiki.koha-community.org/wiki/Use_of_Cookies It's used to add records to a list as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:21:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:21:37 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #15 from Katrin Fischer --- Yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:43:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:43:19 +0000 Subject: [Koha-bugs] [Bug 21032] New: Refining a search made on a specific index fail Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Bug ID: 21032 Summary: Refining a search made on a specific index fail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com Try a simple search like (OPAC or staff): title:foo. Click on a facet: badaboum! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:51:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:51:56 +0000 Subject: [Koha-bugs] [Bug 21033] New: Remove few warns in acqui/basket.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Bug ID: 21033 Summary: Remove few warns in acqui/basket.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:53:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:53:30 +0000 Subject: [Koha-bugs] [Bug 2092] Koha should support Unicode 6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2092 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:57:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:57:52 +0000 Subject: [Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:57:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:57:55 +0000 Subject: [Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 --- Comment #1 from Marcel de Rooy --- Created attachment 76652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76652&action=edit Bug 21033: Remove few warns in acqui/basket.pl Resolve (line numbers based on 16.11.x): Use of uninitialized value in hash element at acqui/basket.pl line 337. Use of uninitialized value in hash element at acqui/basket.pl line 338. Use of uninitialized value in hash element at acqui/basket.pl line 340. Use of uninitialized value in hash element at acqui/basket.pl line 342. Use of uninitialized value in hash element at acqui/basket.pl line 344. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 486. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 591. Test plan: Open a basket that contains no prices. Compare warnings before and after this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:59:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:59:35 +0000 Subject: [Koha-bugs] [Bug 21032] Refining a search made on a specific index fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 --- Comment #1 from Alex Arnaud --- Created attachment 76653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76653&action=edit Bug 21032 - fix using facet for searches made on specific index Test plan: - Try a simple search (OPAC or staff) like "title:foo", - click on a facet: badaboum! - apply this patch, - retry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:59:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:59:17 +0000 Subject: [Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:59:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 13:59:57 +0000 Subject: [Koha-bugs] [Bug 21032] Refining a search made on a specific index fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 16:00:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 14:00:05 +0000 Subject: [Koha-bugs] [Bug 21032] Refining a search made on a specific index fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 16:06:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 14:06:36 +0000 Subject: [Koha-bugs] [Bug 20729] Update style of datepickers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #7 from Owen Leonard --- I think there are few places in Koha where a datepicker field has the same width as all form fields around it. I think the only global CSS applied to input widths is for form fields in sidebar filter forms. The alternative is to remove the CSS padding property and modify all templates with datepickers in order to ensure that the "size" attribute of the input field is large enough to accommodate the calendar icon without overlapping the input text. I think that's a less desirable solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 16:14:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 14:14:45 +0000 Subject: [Koha-bugs] [Bug 21019] [17.11] Borrower address not shown on reserve pop-up on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_17_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 16:18:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 14:18:29 +0000 Subject: [Koha-bugs] [Bug 20729] Update style of datepickers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > Looks uglier for me, at least when editing a patron: > > https://screenshots.firefox.com/yo0iX4PG4RacDzOX/pro.kohadev.org I would not say that it is ugly. Just a bit funny at first. I would not object to this change if it fixes the line wrap problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 16:19:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 14:19:56 +0000 Subject: [Koha-bugs] [Bug 21032] Refining a search made on a specific index fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr, | |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 16:56:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 14:56:05 +0000 Subject: [Koha-bugs] [Bug 8548] Add callnumber sort option to overdue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #13 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #12) > Nice patch, but I think more an enhancement than a bug fix! > > This patch has been pushed to 16.11.x and will be in 16.11.07. Could not find this patch in 16.11.x (even higher than .07) Probably a copy-paste error here.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 17:30:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 15:30:36 +0000 Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76551|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 76655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76655&action=edit Bug 20997: (follow-up) Minor POD fixes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 17:30:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 15:30:40 +0000 Subject: [Koha-bugs] [Bug 21032] Refining a search made on a specific index fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from S?verine Queune --- Thanks for this patch ! It works correctly except when facets end with punctuation. Status set to 'Failed', sorry Alex :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 17:30:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 15:30:21 +0000 Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76550|0 |1 is obsolete| | --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 76654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76654&action=edit Bug 20997: ->apply should be applied to Koha::Account::Lines This patch makes ->apply get passed an object set class instead of single account lines. The change is fully covered by tests. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 17:32:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 15:32:06 +0000 Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #15 from Tom?s Cohen Arazi --- Testers: I've rebased so it applies after some dependencies got changes. I also fixed the Koha::Account::Lines param move and tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 19:34:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 17:34:41 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #2 from Jon Knight --- On my kohadevbox I seem to get 404 errors for all the URLs in the test plan? Do I need to turn something on first? Going to an known API end point seems to work - for example http://localhost:8080/api/v1/app.pl/api/v1/patrons/50 or http://localhost:8080/api/v1/patrons/50 I'd sort of assumed that kohadevbox is a git install, so should be able to test this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 20:14:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 18:14:55 +0000 Subject: [Koha-bugs] [Bug 21034] New: Re-indent circulation.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Bug ID: 21034 Summary: Re-indent circulation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org I would like to re-indent circulation.tt and remove trailing spaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 21:16:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 19:16:58 +0000 Subject: [Koha-bugs] [Bug 21034] Re-indent circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 21:17:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 19:17:01 +0000 Subject: [Koha-bugs] [Bug 21034] Re-indent circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 --- Comment #1 from Owen Leonard --- Created attachment 76656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76656&action=edit Bug 20520: Re-indent moremember.tt This patch reindents the template for the checkout page, circulation.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the checkout page under various circumstances: - No card number submitted - Name submitted (patron search results) - Card number submitted - Restricted patron - Patron with circulation messages - On-site checkouts - Check all tabs: checkouts, relatives' checkouts holds, article requests, restrictions, clubs HTML validation before and after the patch should return the same results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 21:44:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 19:44:01 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74757|0 |1 is obsolete| | Attachment #74758|0 |1 is obsolete| | --- Comment #61 from Owen Leonard --- Created attachment 76657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76657&action=edit Bug 19474: (follow-up) Bring scss up to date with latest CSS changes This patch catches the scss up to the latest changes in master: Bug 19946 Bug 20045 Bug 20343 Bug 18327 Bug 20322 Bug 18799 Bug 20622 Bug 20329 Bug 20744 Bug 20931 Bug 20793 Bug 20651 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 22:08:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 20:08:29 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 --- Comment #7 from Katrin Fischer --- (In reply to Jonathan Druart from comment #6) > (In reply to Katrin Fischer from comment #4) > > I've changed the documentation on the wiki - can you please check if it's > > correct now? https://wiki.koha-community.org/wiki/Use_of_Cookies > > It's used to add records to a list as well. Updated the cookie documentation, thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 22:11:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 20:11:05 +0000 Subject: [Koha-bugs] [Bug 8548] Add callnumber sort option to overdue report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548 --- Comment #14 from Katrin Fischer --- Likely a typo, also judging from the first comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 22:20:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 20:20:22 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #2 from Lisette --- I was able to recreate this with both withdrawn and a damaged status. It is properly hiding items that are not withdrawn or damaged. Lost items hide properly, as well as items at hidden branches, with hidden itype, or with hidden shelving location. Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 22:41:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 20:41:01 +0000 Subject: [Koha-bugs] [Bug 20769] Duplicate fine generated when lost item is returned with BlockReturnOfLostItems activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20769 Andrew changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew --- Lucy, are you forgiving the accumulated fine when the item becomes lost? So that there's a $5 fine, it gets cleared when the item becomes lost, and then re-accumulates when the item later becomes found and is turned in? Or does the original $5 fine remain and then duplicate, creating a total fine of $10? Altogether, I'm not sure this syspref performs as most users will expect -- it blocks *only* the return of the item, still allowing it to be marked as found and generate a refund. My sense is most users would expect this to perform more like BlockReturnofWithdrawn items, which stops Koha from interacting with the item at all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 23:21:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 21:21:49 +0000 Subject: [Koha-bugs] [Bug 21035] New: runreport.pl prints only a newline when printing a row that has a field that contains an embedded newline. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21035 Bug ID: 21035 Summary: runreport.pl prints only a newline when printing a row that has a field that contains an embedded newline. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz when runrepurt.pl is run using the --format=csv or --format=tsv options, any fields which contain embedded newlines will cause the row of results to be blank, displaying only a newline. To replicate: 1) Choose two items, say barcode '123' and '456' 2) Change the public note on 123 to read Line1 Line2 (I.e. type 'Line1', then press Enter, type 'Line2' and click update). 3) Change the public note on 456 to read Public note has one and only one line. Click update. 4) Create a report with the followng query: select barcode, itemnotes from items where barcode in ( '123', '456' ) Let's say that this is report number 10. 5) run ./misc/cronjobs/runreport.pl --format=csv 10: $ perl ./misc/cronjobs/runreport.pl --format=csv 9 456,"Public note has one and only one line." The same results hold when using --format=tsv When using --format=html, both rows are displayed: $ perl ./misc/cronjobs/runreport.pl --format=html 10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 23:31:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2018 21:31:11 +0000 Subject: [Koha-bugs] [Bug 21035] runreport.pl prints only a newline when printing a row that has a field that contains an embedded newline. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21035 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 02:34:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 00:34:27 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #20 from Aleisha Amohia --- Created attachment 76658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76658&action=edit Bug 12365: [FOLLOW-UP] Adding maxlength attribute and popover Test that you can't add a note of more than 100 characters. Test notes with rules, notes are hidden by 'Click to view note' and the popover correctly displays note. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 02:35:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 00:35:50 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62932|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 02:36:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 00:36:00 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 02:36:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 00:36:22 +0000 Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #15 from Aleisha Amohia --- Forgot to make original patches obsolete. Ready to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:04:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:04:34 +0000 Subject: [Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan at calyx.net.au Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Dilan Johnpull? --- Attempted to apply but ran into merge fails: $ git bz apply -s 10659 Bug 10659 - Upgrade jQuery star ratings plugin 76487 - Bug 10659: Upgrade jQuery star ratings plugin 76488 - Bug 10659: (follow-up) Add plugin information to the about page 76489 - Bug 10659: (follow-up) Compiled CSS Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10659: Upgrade jQuery star ratings plugin Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt M koha-tmpl/opac-tmpl/bootstrap/less/opac.less Falling back to patching base and 3-way merge... Removing koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.rating.js Auto-merging koha-tmpl/opac-tmpl/bootstrap/less/opac.less Removing koha-tmpl/opac-tmpl/bootstrap/images/star-ratings-sprite.png Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Removing koha-tmpl/opac-tmpl/bootstrap/css/jquery.rating.css Applying: Bug 10659: (follow-up) Add plugin information to the about page Applying: Bug 10659: (follow-up) Compiled CSS Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/opac.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css Failed to merge in the changes. Patch failed at 0001 Bug 10659: (follow-up) Compiled CSS The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-10659-follow-up-Compiled-CSS-XWX9Pf.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:27:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:27:52 +0000 Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76490|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 76659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76659&action=edit Bug 21006: Add unit tests for GetMarcItem To test: prove -v t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:27:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:27:55 +0000 Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 --- Comment #7 from Nick Clemens --- Created attachment 76660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76660&action=edit Bug 21006: Add GetMarcItems method and refactor GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:27:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:27:59 +0000 Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 --- Comment #8 from Nick Clemens --- Created attachment 76661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76661&action=edit Bug 21006: Unit tests for GetMarcItems To test: prove -v t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:27:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:27:49 +0000 Subject: [Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:30:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:30:39 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:30:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:30:44 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #54 from Aleisha Amohia --- Created attachment 76662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76662&action=edit Bug 14272: [FOLLOW-UP] Fixing template error To test, confirm that OpacMainUserBlock and Quote of the Day do not show if viewing a single news item, but do show otherwise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:33:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:33:09 +0000 Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:33:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:33:15 +0000 Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76313|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpull? --- Created attachment 76663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76663&action=edit Bug 19039: Results of virtual shelves (lists) not sortable by date In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'. Test plan: 1) In the staff client, view a list containing several items 2) Notice that you can't sort by 'date added' 3) Apply the patch 4) Repeat step 1 5) The list can now be sorted by 'date added' Signed-off-by: Dilan Johnpull? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:55:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:55:03 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 03:55:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 01:55:35 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Dilan Johnpull? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76548|0 |1 is obsolete| | --- Comment #12 from Dilan Johnpull? --- Created attachment 76664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76664&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a
, with the preference name as the
and the description as the
. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpull? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 04:18:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 02:18:36 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69940|0 |1 is obsolete| | --- Comment #63 from Aleisha Amohia --- Created attachment 76665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76665&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 04:18:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 02:18:43 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69941|0 |1 is obsolete| | --- Comment #64 from Aleisha Amohia --- Created attachment 76666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76666&action=edit Bug 13952: [FOLLOW-UP] Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 04:18:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 02:18:49 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69942|0 |1 is obsolete| | --- Comment #65 from Aleisha Amohia --- Created attachment 76667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76667&action=edit Bug 13952: [FOLLOW-UP] Fixing import for default auth type Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 04:18:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 02:18:57 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69943|0 |1 is obsolete| | Attachment #69944|0 |1 is obsolete| | --- Comment #66 from Aleisha Amohia --- Created attachment 76668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76668&action=edit Bug 13952: [FOLLOW-UP] Fixing export on default biblio framework Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 04:48:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 02:48:21 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #67 from Aleisha Amohia --- Hello, I've rebased the patches and tested them. When importing authority types, it appears that the modal box never closes, but I waited a few minutes and it did eventually close and all the data had loaded in correctly. So technically the feature works, but it's very slow. I'm not sure how to make it faster. Will set to Needs Signoff for now and allow testing to happen unless someone can give a tip for why it's slow and how to fix that - but for now, it does work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 06:09:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 04:09:50 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 --- Comment #3 from David Cook --- (In reply to Jon Knight from comment #2) > On my kohadevbox I seem to get 404 errors for all the URLs in the test plan? > Do I need to turn something on first? Going to an known API end point seems > to work - for example > > http://localhost:8080/api/v1/app.pl/api/v1/patrons/50 > > or > > http://localhost:8080/api/v1/patrons/50 > > I'd sort of assumed that kohadevbox is a git install, so should be able to > test this? Hi Jon, Thanks for taking the time to try and test this out! I think the kohadevbox can't be used for testing this patch though. The kohadevbox is actually a package install which gets converted into using git, but it's not a git install per se. kohadevbox uses koha-gitify which re-writes the installed stable package Apache configuration, so using kohadevbox you're not actually testing these patches, unfortunately. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 08:50:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 06:50:16 +0000 Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 08:54:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 06:54:08 +0000 Subject: [Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #13 from Fridolin SOMERS --- Depends on Bug 17829 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 08:58:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 06:58:59 +0000 Subject: [Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 09:16:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 07:16:11 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #13 from Ere Maijala --- Created attachment 76669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76669&action=edit Bug 20664: Optimize retrieval of biblio and item data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Optimizes embedding of item data in MARC and fixes several bottlenecks encountered while profiling OAI-PMH and exporting of records. There are two changes to accomplish this: 1.) Create optimized method for fetching item fields for MARC embedding. 2.) Use the cache service more and where repeated calls are made. Also the now-unnecessary frameworkcode parameter to _strip_item_fields() has been removed. Test plan: 1.) Before applying the patch, time an export_records.pl run for a set of biblios that also have items. Run it a couple of times to account for initial slowness and possible fluctuations. For example: time misc/export_records.pl --record-type bibs --starting_biblionumber 960000 --ending_biblionumber 965000 --format xml --filename unoptimized.xml 2.) Apply the patch. 3.) Time the export process again with a different output file: time misc/export_records.pl --record-type bibs --starting_biblionumber 960000 --ending_biblionumber 965000 --format xml --filename optimized.xml 4.) Verify that the optimized process is faster. 5.) Compare the resulting export files to make sure they're identical: diff -u unoptimized.xml optimized.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 09:16:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 07:16:08 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 09:18:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 07:18:01 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #14 from Ere Maijala --- The latest patch is more simple and avoids any attempts at caching prepared statements. Fortunately MySQL prepares quickly, so the performance improvement is still good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 09:46:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 07:46:29 +0000 Subject: [Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 09:47:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 07:47:29 +0000 Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 09:48:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 07:48:42 +0000 Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19040 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 09:48:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 07:48:42 +0000 Subject: [Koha-bugs] [Bug 19040] Change prototype of C4::Biblio::GetMarcBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19040 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893 [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 09:49:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 07:49:16 +0000 Subject: [Koha-bugs] [Bug 20893] batchRebuildItemsTables.pl has incorrect parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20893 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #8 from Fridolin SOMERS --- Depends on Bug 19040 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 09:54:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 07:54:41 +0000 Subject: [Koha-bugs] [Bug 17869] Don't show pick-up library for list of holds in OPAC account when there is only one branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 10:00:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 08:00:29 +0000 Subject: [Koha-bugs] [Bug 20697] Remove some Host-Item-Number noise from zebra-output.log when EasyAnalyticalRecords is not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20697 --- Comment #12 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 Work I tried to start a long time ago. I'm pleased to see it done ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 10:09:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 08:09:43 +0000 Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08. Follow-up not needed, it depends on Bug 9634 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 10:10:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 08:10:14 +0000 Subject: [Koha-bugs] [Bug 20945] Report params not escaped when downloading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS --- Depends on Bug 18497 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 10:13:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 08:13:18 +0000 Subject: [Koha-bugs] [Bug 17886] Don't show option to add to existing list if there are no lists in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #17 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 10:53:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 08:53:23 +0000 Subject: [Koha-bugs] [Bug 21032] Refining a search made on a specific index fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 --- Comment #3 from Alex Arnaud --- (In reply to S?verine Queune from comment #2) > Thanks for this patch ! > It works correctly except when facets end with punctuation. > Status set to 'Failed', sorry Alex :( Hello S?verine, Thanks for testing! In my opinion, this should be a separate bug. But i'm not able to reproduce this issue. I have a search result with 2 different facets: "Pakita," and "Pakita". Clicking one or the other, it works and i get the same results for the two. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 13:00:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 11:00:02 +0000 Subject: [Koha-bugs] [Bug 15214] bulkmarcimport should log if an authority has been updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15214 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 13:52:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 11:52:07 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #8 from Ere Maijala --- Created attachment 76670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76670&action=edit Sample MARCXML file containing biblios with interleaved holdings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 14:27:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 12:27:08 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76542|0 |1 is obsolete| | --- Comment #9 from Ere Maijala --- Created attachment 76671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76671&action=edit Bug 20447: MARC Holdings support https://bugs.koha-community.org/show_bug.cgi?id=20447 Enable by setting "SummaryHoldings" option to "Use". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 14:27:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 12:27:12 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #10 from Ere Maijala --- Created attachment 76672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76672&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:32:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:32:36 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73975|0 |1 is obsolete| | --- Comment #240 from Alex Arnaud --- Created attachment 76673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76673&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:32:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:32:53 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73976|0 |1 is obsolete| | --- Comment #241 from Alex Arnaud --- Created attachment 76674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76674&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:33:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:33:09 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73977|0 |1 is obsolete| | --- Comment #242 from Alex Arnaud --- Created attachment 76675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76675&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:33:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:33:23 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73978|0 |1 is obsolete| | --- Comment #243 from Alex Arnaud --- Created attachment 76676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76676&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after for example) https://mana-kb.koha-community.org 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:33:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:33:36 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73979|0 |1 is obsolete| | --- Comment #244 from Alex Arnaud --- Created attachment 76677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76677&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:33:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:33:58 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73980|0 |1 is obsolete| | --- Comment #245 from Alex Arnaud --- Created attachment 76678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76678&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:34:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:34:27 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73981|0 |1 is obsolete| | --- Comment #246 from Alex Arnaud --- Created attachment 76679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76679&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:34:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:34:43 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73982|0 |1 is obsolete| | --- Comment #247 from Alex Arnaud --- Created attachment 76680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76680&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:34:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:34:59 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73983|0 |1 is obsolete| | --- Comment #248 from Alex Arnaud --- Created attachment 76681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76681&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:35:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:35:15 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73984|0 |1 is obsolete| | --- Comment #249 from Alex Arnaud --- Created attachment 76682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76682&action=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:35:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:35:29 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73985|0 |1 is obsolete| | --- Comment #250 from Alex Arnaud --- Created attachment 76683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76683&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:35:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:35:42 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73986|0 |1 is obsolete| | --- Comment #251 from Alex Arnaud --- Created attachment 76684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76684&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud (2018-07-04) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:42:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 13:42:04 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #252 from Alex Arnaud --- (In reply to Jonathan Druart from comment #239) > I can get back to this one when the documentation to test locally (server > too) will be completed. I have updated the README.md of Mana server. There you'll find a link to the documentation of Mana feature in Koha. And a documentation on Mana server (install and use). Also i've just rebased the 12 patches above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:02:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:02:09 +0000 Subject: [Koha-bugs] [Bug 20991] Error will reset category when editing a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:04:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:04:38 +0000 Subject: [Koha-bugs] [Bug 20520] Re-indent moremember.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #12 from Fridolin SOMERS --- Enhancement and does not apply easily on 17.11.x. Not pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:04:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:04:39 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Bug 20779 depends on bug 20520, which changed state. Bug 20520 Summary: Re-indent moremember.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:05:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:05:51 +0000 Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Depends on Bug 17893 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:05:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:05:52 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Bug 20979 depends on bug 20977, which changed state. Bug 20977 Summary: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:07:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:07:12 +0000 Subject: [Koha-bugs] [Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is turned on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS --- Depends on Bug 19700 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:14:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:14:03 +0000 Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Patch "Compiled CSS" does not apply on 17.11.x. Sorry I have never used this compilation. Must I run it or do we not back-port such patches ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:18:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:18:26 +0000 Subject: [Koha-bugs] [Bug 14446] More noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 --- Comment #3 from Marcel de Rooy --- Created attachment 76685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76685&action=edit Bug 14446: Workaround to resolve uninitialized value in goto warning Forcing both GetTab calls to list context resolves the warning. A workaround, not a real fix. Test plan: Search for something in the syspref text bar. Without this patch, you will have a warn: Use of uninitialized value in goto With this patch, you won't. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:18:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:18:23 +0000 Subject: [Koha-bugs] [Bug 14446] More noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:18:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:18:45 +0000 Subject: [Koha-bugs] [Bug 14446] More noisy warns in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:19:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:19:12 +0000 Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20693 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:19:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:19:12 +0000 Subject: [Koha-bugs] [Bug 20693] Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20920 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:19:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:19:23 +0000 Subject: [Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|More noisy warns in |Resolve "Use of |admin/preferences.pl |uninitialized value in | |goto" in | |admin/preferences.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:24:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:24:10 +0000 Subject: [Koha-bugs] [Bug 20693] Plack fails, because 'libcgi-emulate-psgi-perl' package is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20693 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:25:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:25:18 +0000 Subject: [Koha-bugs] [Bug 20920] Plack timeout because of missing CGI::Compile Perl dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #11 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:29:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:29:36 +0000 Subject: [Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #19 from Fridolin SOMERS --- Patch does not apply easily on 17.11.x. If back-port is possible, please provide a rebased patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:31:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:31:03 +0000 Subject: [Koha-bugs] [Bug 21036] New: Just a bunch of warnings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 Bug ID: 21036 Summary: Just a bunch of warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:31:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:31:24 +0000 Subject: [Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:34:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:34:23 +0000 Subject: [Koha-bugs] [Bug 21036] Just a bunch of warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 --- Comment #1 from Marcel de Rooy --- Created attachment 76686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76686&action=edit Bug 21036: Fix CGI::param in list context warning from opac-passwd.pl Resolve: CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_prodclone_opac_opac_2dpasswd_2epl line 55, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. Add a scalar. Test plan: Speaks for itself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:34:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:34:27 +0000 Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #3 from Andrew Isherwood --- Created attachment 76687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76687&action=edit Bug 20996: Remove prefix use of borrower category This patch removes the potential use of borrower category as a ILL request ID prefix. It makes no sense. We provide the ability for a site to define a request prefix based on branch, there is no use case for using the borrower category. Add to this that the borrower for every request was being retrieved in order to get the category, it's a huge performance hit also. We also now require the block in the block and complain if it's not present. The request prefix should be defined in this block. This patch also improves the performance of the API request that returns all requests, optionally including additional data. It also deprecates the overloaded TO_JSON method and moves the request augmentation code into the API route's controller. It may be that we want to shift it out of there at some point, but it is fine where it is for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:34:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:34:39 +0000 Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #4 from Andrew Isherwood --- Created attachment 76688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76688&action=edit Bug 20996: Fix unit tests - Remove unit tests relating to TO_JSON - Add tests for new explicit embedding - Modify tests relating to now deprecated brw_cat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:35:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:35:15 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:35:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:35:50 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:40:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:40:20 +0000 Subject: [Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:53:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 14:53:38 +0000 Subject: [Koha-bugs] [Bug 21036] Just a bunch of warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 --- Comment #2 from Marcel de Rooy --- Created attachment 76689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76689&action=edit Bug 21036: Fix uninitialized value within @itemnumber in string ne Line from 16.11 log: Use of uninitialized value within @itemnumber in string ne at /usr/share/koha/prodclone/reserve/modrequest.pl line 70. Test plan: Read the change. Not 100% identical (numeric zero) but should be enough. This line is probably not needed at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:36:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 15:36:06 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #16 from Chris Nighswonger --- Created attachment 76690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76690&action=edit This patch corrects referential problems which caused the script to "re-use" images as well as other sorts of bad image behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:36:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 15:36:19 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:42:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 15:42:56 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #17 from Chris Nighswonger --- Comment on attachment 76690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76690 This patch corrects referential problems which caused the script to "re-use" images as well as other sorts of bad image behaviour. Some kind soul please correct the spelling of "relegated" on line 180 during QA! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:50:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 15:50:52 +0000 Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #22 from Fridolin SOMERS --- (In reply to Martin Renvoize from comment #21) > Pushed to 18.05.x for 18.05.02, I felt that although this is marked as an > enhancement, many librarians would see it as a bug not being in sync with > MARC21 guidelines. Same for 17.11.x, will be in 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:51:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 15:51:22 +0000 Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #23 from Fridolin SOMERS --- Not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:51:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 15:51:23 +0000 Subject: [Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26 (April 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 Bug 20710 depends on bug 19835, which changed state. Bug 19835 Summary: Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:51:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 15:51:22 +0000 Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Bug 20709 depends on bug 19835, which changed state. Bug 19835 Summary: Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:01:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:01:31 +0000 Subject: [Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #26 from Fridolin SOMERS --- (In reply to Martin Renvoize from comment #25) > Pushed to 18.05.x for 18.05.02, I felt that although this is marked as an > enhancement, many librarians would see it as a bug not being in sync with > MARC21 guidelines. Same for 17.11.x, will be in 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:11:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:11:18 +0000 Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:11:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:11:22 +0000 Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #2 from Jonathan Druart --- Created attachment 76691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76691&action=edit Bug 15836: DB changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:11:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:11:27 +0000 Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #3 from Jonathan Druart --- Created attachment 76692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76692&action=edit Bug 15836: DBIC Schema change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:11:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:11:31 +0000 Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #4 from Jonathan Druart --- Created attachment 76693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76693&action=edit Bug 15836: UI changes The script admin/classsources.pl has been adjusted to follow usual patterns used in other Koha scripts. $op can be add_source, add_source_validate, etc. Deletion steps have been removed (there is a JS confirmation box) to simplify both script and template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:11:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:11:32 +0000 Subject: [Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700 --- Comment #11 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 Thanks a lot Bernardo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:11:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:11:36 +0000 Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #5 from Jonathan Druart --- Created attachment 76694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76694&action=edit Bug 15836: Add the ability to defined custom methods to split call number in labels Currently the call number splitting seems to be mostly implemented for DDC and LC classifications. Those are both not very common in some countries. A lot of libraries use their own custom classification schemes so the call number plitting is something that should be individually configurable. This enhancement adds the ability to define custom splitting rules based on regular expressions. How does it work so far? >From C4/Labels/Label.pm there are 3 differents splitting methods defined, depending on items.cn_source. if cn_source is "lcc' or 'nlm' we split using Library::CallNumber::LC if cn_source is 'ddc' we split using a in-house method Finally there is a fallback method to split on space And nothing else is done for other cn_source The idea of this patch is to mimick what was done for the "filing rules" and add the ability to define "splitting rules" that will be used by the "Classification sources". A classification source will then have: * a filing rule used to sort items by callnumbers * a splitting rule used to print labels To acchieve this goal this enhancement will do the following modifications at DB level: * New table class_split_rules * New column class_sources.class_split_rule Test plan: * Execute the update database entry to create the new table and column. I. UI Changes a) Create/modify/delete a filing rule b) Create/modify/delete a splitting rule c) Create/modify/delete a classification source => A filing rule or splitting rule cannot be removed if used by a classification source II. Splitting rule using regular expressions a) Create a splitting rule using the "Splitting routine" "RegEx" b) Define several regular expressions, they will be applied one after the other in the same order you define them. Something like: s/\s/\n/g # Break on spaces s/(\s?=)/\n=/g # Break on = (unless it's done already) s/^(J|K)\n/$1 / # Remove the first break if callnumber starts with J or K c) You can test the regular expressions using filling the textarea with a list of callnumbers. Then click "Test" and confirm the callnumbers are split how you expected. d) Finally create a new classification source that will use this new splitting rule. III. Print the label! a) Create a layout. It should have the "Split call numbers" checkbox ticked, and display itemcallnumber b) Use this layout to export labels, use items with different classification source ('lcc', 'ddc', but also the new one you have create) => The callnumbers should have been split according to the regex you defined earlier! Notes: * The update database entry fill the class_sources.class_split_rule with the value of class_sources.class_sort_rule If default rules exist it will not work, we should add a note in the release notes (would be enough?) * C4::ClassSplitRoutine::* should be moved to Koha::ClassSplitRule, but it sounded better to keep the same pattern as ClassSortRoutines * Should not we use a LONGTEXT for class_split_rules.split_regex instead of VARCHAR(255)? * class_sources.sql should be filled for other languages before pushed to master! IMPORTANT NOTES: The regular expressions are stored as it, and eval is used to evaluate it (perlcritic raises a warning about it (Expression form of "eval"). It can lead to serious security issues (execution of arbitrary code on the server), especially if the modifier 'e' is used. We could then remedy the situation with one of these following points: - Assume that this DB data is safe (We can add a new permission?) - Assume that the data is not safe and deal with possible attack Cons: how be sure we are exhaustive? Making sure it matches ^s///[^e/]*$ would be enough? - Use Template Toolkit syntax instead (Really safer?) [% callnumber.replace('\s', '\n').replace ... %] - Cut the regex parts: find, replace, modifiers like we already do for Marc modification template. Cons: we are going to have escape problems, the "find" and "replace" parts should not be handle the same way (think "\n", "\\n", "\1", "\s", etc.) I did not manage to implement this one easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:11:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:11:41 +0000 Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #6 from Jonathan Druart --- Created attachment 76695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76695&action=edit Bug 15836: Mark C4::ClassSource subs DEPRECATED These subs are no longer used from scripts and should be removed. It should be done on a separate bug report given that additional work is needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:12:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:12:02 +0000 Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Labels: Offer configuration |Labels: Offer configuration |option for splitting call |option for splitting call |number in layout definition |numbers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:12:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:12:58 +0000 Subject: [Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #7 from Jonathan Druart --- Created attachment 76696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76696&action=edit Screenshot of the feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:21:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:21:24 +0000 Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 --- Comment #10 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #9) > Patch "Compiled CSS" does not apply on 17.11.x. You should only apply the first one then regenerate the .css > Sorry I have never used this compilation. There is a wiki page, search for "lessc" > Must I run it or do we not back-port such patches ? You are the Rmaint ;) IMO it's "just" a loading icon, not really important. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 18:50:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 16:50:38 +0000 Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- How do you run the command? Which version of perl? Which OS? I do not recreate with perl misc/migration_tools/bulkmarcimport.pl -b --file koha.mrc on Debian 8.10 with perl v5.20.2 If you have a patch that fixes your issue, please submit it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 19:52:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 17:52:28 +0000 Subject: [Koha-bugs] [Bug 16242] Move staff client JavaScript out of language directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21029 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 [Bug 21029] "Suspend until" in modal in staff patron account is not translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 19:52:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 17:52:28 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16242 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 [Bug 16242] Move staff client JavaScript out of language directory -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 19:56:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 17:56:21 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 --- Comment #1 from Jonathan Druart --- Created attachment 76697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76697&action=edit Bug 21029: Make "Suspend until:" translatable The label was part of the holds.js file. As .js files are never translatable it needs to be moved to template level. Test plan: - Place a hold on an item - Go to the patron account - Click on the Suspend button on the holds tab - View the modal, the label before the date field "Suspend until:" is now translatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 19:56:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 17:56:28 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 19:56:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 17:56:18 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 20:07:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 18:07:06 +0000 Subject: [Koha-bugs] [Bug 21035] runreport.pl prints only a newline when printing a row that has a field that contains an embedded newline. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21035 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 20:07:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 18:07:10 +0000 Subject: [Koha-bugs] [Bug 21035] runreport.pl prints only a newline when printing a row that has a field that contains an embedded newline. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21035 --- Comment #1 from Jonathan Druart --- Created attachment 76698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76698&action=edit Bug 21035: Handle new lines when running reports See https://metacpan.org/pod/Text::CSV_XS#Embedded-newlines Test plan: 1) Choose two items, say barcode '123' and '456' 2) Change the public note on 123 to read Line1 Line2 (I.e. type 'Line1', then press Enter, type 'Line2' and click update). 3) Change the public note on 456 to read Public note has one and only one line. Click update. 4) Create a report with the followng query: select barcode, itemnotes from items where barcode in ( '123', '456' ) Let's say that this is report number 10. 5) run ./misc/cronjobs/runreport.pl --format=csv REPORT_ID: => You should see both lines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 20:07:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 18:07:18 +0000 Subject: [Koha-bugs] [Bug 21035] runreport.pl prints only a newline when printing a row that has a field that contains an embedded newline. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21035 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 20:11:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 18:11:39 +0000 Subject: [Koha-bugs] [Bug 21037] New: auth_show_hidden_data.pl gives false positives about 942$a and 152$b fields. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21037 Bug ID: 21037 Summary: auth_show_hidden_data.pl gives false positives about 942$a and 152$b fields. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org Because the authority record subfields 152$b (UNIMARC) 942$a (MARC21) are used for the authority type. And they won't disappear if hidden when an authority record is saved. (tested on the 942$a and few colleagues remember it's the same for 152$b) It seems that exemptions for these fields are hard coded. These false positives create noise and might lead to errors where users would think that they need to make them visible. So they could be filtered out unless there is a reason to keep them, right? == Going further == Maybe it's for another bug if these ? cases are not as clear as the other ones. But if it's clear then better one bug than two :) 001 is the RECORD IDENTIFIER and 100$a (UNIMARC: General Processing Data) is recreated if missing. So same question for these. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 20:12:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 18:12:06 +0000 Subject: [Koha-bugs] [Bug 21037] auth_show_hidden_data.pl gives false positives about 942$a and 152$b fields. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21037 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 20:47:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 18:47:17 +0000 Subject: [Koha-bugs] [Bug 16242] Move staff client JavaScript out of language directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 [Bug 21030] Date widget on suspend modal not working correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 20:47:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 18:47:17 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16242 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Confirmed on 17.05.13 (but certainly since 16.05) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16242 [Bug 16242] Move staff client JavaScript out of language directory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 20:57:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 18:57:36 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 --- Comment #2 from Jonathan Druart --- I recreate on Firefox, not chromium -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 21:01:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 19:01:44 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #3 from Jonathan Druart --- Owen, could you take a look at this one? I have no idea how to fix it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 21:05:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 19:05:26 +0000 Subject: [Koha-bugs] [Bug 21036] Just a bunch of warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #2) > Read the change. Not 100% identical (numeric zero) but should be enough. > This line is probably not needed at all. Regarding commit 26469d87a261682dcbde0f41faa844133d10ed5e bug 2520: don't change item-level requests to bib-level It is used to test if item_level_hold it not set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 21:07:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 19:07:44 +0000 Subject: [Koha-bugs] [Bug 21001] OpenLibrary book covers broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 --- Comment #2 from Jonathan Druart --- https://github.com/internetarchive/openlibrary/issues/1014 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 22:21:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 20:21:32 +0000 Subject: [Koha-bugs] [Bug 21038] New: Reserves should be holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21038 Bug ID: 21038 Summary: Reserves should be holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When moderating a discharge request from the discharge tab in the patron's account in staff, existing holds will trigger a message: Borrower has reserves Reserves should be holds to match terminology used in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 22:23:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 20:23:24 +0000 Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76586|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 76699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76699&action=edit Bug 20953: Prevent several discharge requests on OPAC On OPAC, a user can requested a discharge even if one is already pending. This generates several pending discharges in staff interface that can not be deleted. This is because request operation leads to page 'opac-discharge.pl?op=request' and user can refresh this page performing a new request. Perl code must check that operation is allowed. Patch reoganised the code so that the following FIXME is obsolete : 'FIXME looks like $available is not needed' Patch also replaces 'op' arg test to also check undef : input->param("op") // '' Test plan : 1) Set system preference 'useDischarge' to 'Allow' 2) Choose a patron without checkouts nor fines nor restrictions 3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl 4) Click on 'ask for a discharge' tab => You see /cgi-bin/koha/opac-discharge.pl with text 'What is a discharge? ...' 5) Click on 'Ask for a discharge' link => You see /cgi-bin/koha/opac-discharge.pl?op=request with text 'Your discharge request has been sent ...' 6) In a new browser tab/page, go to intranet on /cgi-bin/koha/members/discharges.pl => You see one discharge requets for the patron 7) Come back to OPAC and refresh page => You see /cgi-bin/koha/opac-discharge.pl with text 'Your discharge will be available on this page within a few days.' 8) Come back to intranet and refresh /cgi-bin/koha/opac-discharge.pl => There is still one requets for the patron 9) Come back to OPAC and enter URL /cgi-bin/koha/opac-discharge.pl?op=get => You see /cgi-bin/koha/opac-discharge.pl with text 'Your discharge will be available on this page within a few days.' 10) Come back to intranet and refresh /cgi-bin/koha/opac-discharge.pl => There is still one requets for the patron 11) Click on 'allow' on patron discharge request 12) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl => You see link 'Get your discharge' 13) enter URL /cgi-bin/koha/opac-discharge.pl?op=request => You see same page and no new discharge requets is created 14) Come back to intranet on patron details page 15) Remove the discharge restriction 16) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl => You see text 'What is a discharge?...' 17) enter URL /cgi-bin/koha/opac-discharge.pl?op=get => You see same page and no new discharge requets is created Signed-off-by: Charles Farmer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 22:23:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 20:23:21 +0000 Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 22:26:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 20:26:30 +0000 Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to Jonathan Druart from comment #3) > Important note: We certainly need to add an index on this column to boost > this query. Do you mean items.uri and deleteditems.uri? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 22:29:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 20:29:26 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 22:29:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 20:29:30 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76697|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 76700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76700&action=edit Bug 21029: Make "Suspend until:" translatable The label was part of the holds.js file. As .js files are never translatable it needs to be moved to template level. Test plan: - Place a hold on an item - Go to the patron account - Click on the Suspend button on the holds tab - View the modal, the label before the date field "Suspend until:" is now translatable. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 22:31:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2018 20:31:22 +0000 Subject: [Koha-bugs] [Bug 20989] Hold Notes to be added later In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20989 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- +1 It would be nice if it could be edited in the OPAC, but also from the staff side. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 08:15:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 06:15:44 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi --- Comment #4 from Ere Maijala --- Is there a reason for only accepting v0 or v1 in the RewriteCond? Especially since the rule uses 0-9? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 08:41:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 06:41:25 +0000 Subject: [Koha-bugs] [Bug 21036] Just a bunch of warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > (In reply to Marcel de Rooy from comment #2) > > Read the change. Not 100% identical (numeric zero) but should be enough. > > This line is probably not needed at all. > > Regarding > commit 26469d87a261682dcbde0f41faa844133d10ed5e > bug 2520: don't change item-level requests to bib-level > > It is used to test > > if item_level_hold it not set. Thx. That should still work as expected. The itemnumber==0 case is only hypothetical; we do not have such items. Clearing the field should be fine. If the line is needed or not here actually depends on if ModReserve and the routines it calls, can handle an empty string for itemnumber. I would think they do, but to be safe I do not remove the line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 08:52:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 06:52:24 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #61 from Fridolin SOMERS --- (In reply to Alex Arnaud from comment #60) > (In reply to Fridolin SOMERS from comment #57) > > (In reply to Fridolin SOMERS from comment #55) > > > Oups, looks like patch makes a lot of unwanted changes in > > > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref > > > > Oh I found it : > > Tabs instead of 4 spaces in many places. > > This brakes the file which is a YAML. > > I have rebased the patches and removed unwanted changes on circulation.pref Thanks a lot Alex ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 09:15:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 07:15:12 +0000 Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76228|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 76701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76701&action=edit Bug 11983: Centralised Koha::Patrons method OPTION 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 09:17:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 07:17:48 +0000 Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #7 from Martin Renvoize --- The option 2 patch now includes the beginnings of tests (I still need to test method chaining). Would appreciate any further feedback on this option.. method names, how they're constructed, whether it's a reasonable idea and should form the basis of a coding guideline to improve the consistency of Koha::Objects internal apis etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 09:44:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 07:44:09 +0000 Subject: [Koha-bugs] [Bug 21037] auth_show_hidden_data.pl gives false positives about 942$a and 152$b fields. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21037 --- Comment #1 from Victor Grousset/tuxayo --- Just tested to show and hide and save 100$a and 001. There is no data loss. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 09:46:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 07:46:50 +0000 Subject: [Koha-bugs] [Bug 21039] New: auth_show_hidden_data.pl should also check if the subfield is ignore Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21039 Bug ID: 21039 Summary: auth_show_hidden_data.pl should also check if the subfield is ignore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: victor.grousset at biblibre.com QA Contact: testopia at bugs.koha-community.org Because after testing, an ignored subfield looses it's data when editing and saving. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 09:47:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 07:47:03 +0000 Subject: [Koha-bugs] [Bug 21037] auth_show_hidden_data.pl gives false positives about 942$a and 152$b fields. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21037 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21039 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 09:47:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 07:47:03 +0000 Subject: [Koha-bugs] [Bug 21039] auth_show_hidden_data.pl should also check if the subfield is ignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21039 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21037 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:11:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 08:11:23 +0000 Subject: [Koha-bugs] [Bug 21039] auth_show_hidden_data.pl should also check if the subfield is ignored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21039 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|auth_show_hidden_data.pl |auth_show_hidden_data.pl |should also check if the |should also check if the |subfield is ignore |subfield is ignored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:16:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 08:16:51 +0000 Subject: [Koha-bugs] [Bug 21036] Just a bunch of warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 --- Comment #5 from Marcel de Rooy --- Created attachment 76702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76702&action=edit Bug 21036: Fix warnings from C4/Biblio Use of uninitialized value $isbn in string ne at /usr/share/koha/prodclone/C4/Biblio.pm line 1794. (16.11 line number) Trivial edit. And these warnings from TransformHtmlToXml (with 16.11 line numbers): Use of uninitialized value in substr at /usr/share/koha/prodclone/C4/Biblio.pm line 2527. Use of uninitialized value in substr at /usr/share/koha/prodclone/C4/Biblio.pm line 2528. substr outside of string at /usr/share/koha/prodclone/C4/Biblio.pm line 2528. Indicator in 952 is empty at /usr/share/koha/prodclone/C4/Biblio.pm line 2534. The last warning is not needed and can be removed. Note that the code used the construct @$indicator[$j] for $$indicator[$j]. The first is an array slice. This worked in list context. But apparently the second was meant to be used. And can be rewritten as $indicator->[$j] which generally is considered more readable. The code around indicator1/2 and ind1/2 is simplified. This change is applied twice in the same sub. Test plan: Read the changes. Run t/Biblio/TransformHtmlToXml.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:17:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 08:17:51 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 --- Comment #5 from David Cook --- (In reply to Ere Maijala from comment #4) > Is there a reason for only accepting v0 or v1 in the RewriteCond? Especially > since the rule uses 0-9? Very good question. I was just keeping it consistent with what's in "debian/templates/apache-shared-opac-plack.conf" and "debian/templates/apache-shared-intranet-plack.conf". I imagine they all should be updated to 0-9 for the RewriteCond too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 12:27:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 10:27:07 +0000 Subject: [Koha-bugs] [Bug 21036] Just a bunch of warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 --- Comment #6 from Marcel de Rooy --- Created attachment 76703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76703&action=edit Bug 21036: Remove odd number of elements warnings from AuthoritiesMarc.pm Like this one (16.11 line number): Odd number of elements in anonymous hash at C4/AuthoritiesMarc.pm line 1070. We need to add a scalar to some MARC::Field::subfield calls. In list context the empty list returned might affect the parameter hash around it. Test plan: Could reproduce this warning easily from OPAC authority search. opac-authorities-home.pl calling BuildSummary. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 12:30:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 10:30:35 +0000 Subject: [Koha-bugs] [Bug 21036] Just a bunch of warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76703|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 76704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76704&action=edit Bug 21036: Remove odd number of elements warnings from AuthoritiesMarc.pm Like this one (16.11 line number): Odd number of elements in anonymous hash at C4/AuthoritiesMarc.pm line 1070. We need to add a scalar to some MARC::Field::subfield calls. In list context an empty list returned affects the hash built around it. Test plan: Could reproduce this warning easily from OPAC authority search. opac-authorities-home.pl calling BuildSummary. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 12:58:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 10:58:15 +0000 Subject: [Koha-bugs] [Bug 21036] Fix a bunch of older warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |Needs Signoff Summary|Just a bunch of warnings |Fix a bunch of older | |warnings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:39:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 13:39:11 +0000 Subject: [Koha-bugs] [Bug 5667] koha-conf.xml missing entry for z39.50 publicserver In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5667 Mukami changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rmacharia at kca.ac.ke -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:18:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:18:43 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:18:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:18:56 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76122|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:19:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:19:09 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76123|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:19:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:19:22 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:19:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:19:34 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76125|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:19:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:19:59 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76127|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:19:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:19:46 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:20:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:20:24 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:20:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:20:44 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76129|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:20:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:20:49 +0000 Subject: [Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #5 from Andrew Isherwood --- Created attachment 76705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76705&action=edit Bug 20996: Further enhance performance We were immediately unblessing all request objects after retrieval then, at a later stage, re-instantiating each one so we could call methods on that. This was a very bad idea. We now preserve the objects for as long as we can. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:21:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:21:00 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76130|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:21:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:21:21 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76131|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:21:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:21:34 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76132|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:21:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:21:58 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76134|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:21:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:21:46 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76133|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:22:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:22:17 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76135|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:22:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:22:31 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76144|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:23:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:23:33 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #266 from Martin Renvoize --- Created attachment 76707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76707&action=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:23:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:23:39 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #267 from Martin Renvoize --- Created attachment 76708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76708&action=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:23:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:23:46 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #268 from Martin Renvoize --- Created attachment 76709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76709&action=edit Bug 11897: Stockrotation Add a stock rotation system to Koha. Stockrotation is used to manage the rotation of materials between library branches on a scheduled basis. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:23:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:23:27 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #265 from Martin Renvoize --- Created attachment 76706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76706&action=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:27:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:27:44 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #269 from Martin Renvoize --- Right, I have squashed the commits as far as I can to clean this bug up a bit and make it easier to QA as a whole, I've kept the signoff line as the same user was about to signoff again as they've been receiving all the updates as they were written and are happy the system is all still working. I have another customer going through it all with fresh eyes (they've only been using it a couple of weeks) who will add a second signoff line for us. All QA feedback to date has been accounted for in the squashed set of patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:29:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:29:08 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:29:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:29:33 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #270 from Martin Renvoize --- Would love some UI feedback if you get a moment Owen ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:32:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:32:50 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76709|0 |1 is obsolete| | --- Comment #271 from Martin Renvoize --- Created attachment 76710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76710&action=edit Bug 11897: Stockrotation The stock rotation feature adds a batch process to automate rotation of catalgue items with a staff client page under tools to manage rotas/schedules. Once a rota is configured, and your staff user has the right permissions to allocate items, then an additional tab will appear on biblio records allowing the management of of which rota, if any, individual items belong to. It also includes a cron script to process the items on a daily basis. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:59:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:59:25 +0000 Subject: [Koha-bugs] [Bug 21040] New: Funds from inactive budgets appear in 'Funds' dropdown on suggestion.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21040 Bug ID: 21040 Summary: Funds from inactive budgets appear in 'Funds' dropdown on suggestion.pl Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This is similar to Bug 14850- when assigning a purchase suggestion to a specific fund, all funds appear from both Inactive and Active budgets. It would be nice to have the ability to have the option to only see Active budgets or the ability to toggle between both. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:59:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:59:38 +0000 Subject: [Koha-bugs] [Bug 21040] Funds from inactive budgets appear in 'Funds' dropdown on suggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21040 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14850 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:59:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 14:59:38 +0000 Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21040 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 17:07:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 15:07:22 +0000 Subject: [Koha-bugs] [Bug 21040] Funds from inactive budgets appear in 'Funds' dropdown on suggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21040 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 17:51:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 15:51:47 +0000 Subject: [Koha-bugs] [Bug 19430] Can't receive serials from subscription detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19430 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- Just commenting, this error occurs on clicking receive when there are no expected issues, the biblio information retrieval is tied to having issues in status 1,3 in the GetSerials2 sub -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 19:11:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 17:11:49 +0000 Subject: [Koha-bugs] [Bug 21041] New: "Merge patrons" button remains disabled with "Select all" option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Bug ID: 21041 Summary: "Merge patrons" button remains disabled with "Select all" option Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The option to merge selected patron button can't be used if patrons are selected using the "Select all" option link : the button remains grey. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 19:59:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 17:59:19 +0000 Subject: [Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add routes to add credits |Add routes to add credits |and debits to a patron's |to a patron's account |account | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:04:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:04:56 +0000 Subject: [Koha-bugs] [Bug 21042] New: Pay amount does not mark lost items as returned when those accountlines are paid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042 Bug ID: 21042 Summary: Pay amount does not mark lost items as returned when those accountlines are paid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This is problematic - if I click pay selected the item is returned, but pay amount and clearing the fines doesn't return it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:08:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:08:04 +0000 Subject: [Koha-bugs] [Bug 21042] Pay amount does not mark lost items as returned when those accountlines are paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:08:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:08:06 +0000 Subject: [Koha-bugs] [Bug 21042] Pay amount does not mark lost items as returned when those accountlines are paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042 --- Comment #1 from Nick Clemens --- Created attachment 76711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76711&action=edit Bug 21042: Make 'pay amount' also return lost fines To test: 1 - Checkout an item to a patron, and make it lost ( but not returned) and ensure fine is levied against the account 2 - Add some other fines to their account 3 - Click 'Pay amount' and pay everything they owe 4 - Note the book is not returned 5 - Repeat with 'Pay selected' and note item is returned 6 - Apply patch 7 - Repeat 1-5 and note item is returned in both cases -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:08:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:08:34 +0000 Subject: [Koha-bugs] [Bug 21042] Pay amount does not mark lost items as returned when those accountlines are paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042 --- Comment #2 from Nick Clemens --- Note, I did not test this patch, it also presumably suffers from bug 19876 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:49:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:49:43 +0000 Subject: [Koha-bugs] [Bug 21043] New: Add routes to add debits to a patron's account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Bug ID: 21043 Summary: Add routes to add debits to a patron's account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:50:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:50:11 +0000 Subject: [Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:50:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:50:11 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20944 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 [Bug 20944] Add routes to add credits to a patron's account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:50:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:50:19 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20944 Depends on| |21002 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:50:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:50:19 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 [Bug 21043] Add routes to add debits to a patron's account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:50:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:50:19 +0000 Subject: [Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21043 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:52:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:52:35 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 [Bug 21043] Add routes to add debits to a patron's account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:52:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:52:46 +0000 Subject: [Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15165 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 [Bug 15165] REST API routes to list, edit and pay borrower's accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:52:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:52:46 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 [Bug 20944] Add routes to add credits to a patron's account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:52:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:52:50 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Patrons_account_l | |ines_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:52:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 18:52:35 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15165 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 [Bug 15165] REST API routes to list, edit and pay borrower's accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 23:51:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 21:51:49 +0000 Subject: [Koha-bugs] [Bug 20989] Hold Notes to be added later In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20989 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #2 from Lisette --- +1 This would be great. We don't allow patrons to add hold notes, but I also think the ability to edit on the OPAC when allowed would be great. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 23:58:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2018 21:58:16 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 02:15:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 00:15:41 +0000 Subject: [Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 02:15:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 00:15:45 +0000 Subject: [Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76685|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 76712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76712&action=edit [SIGNED-OFF] Bug 14446: Workaround to resolve uninitialized value in goto warning Forcing both GetTab calls to list context resolves the warning. A workaround, not a real fix. Test plan: Search for something in the syspref text bar. Without this patch, you will have a warn: Use of uninitialized value in goto With this patch, you won't. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 07:41:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 05:41:31 +0000 Subject: [Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 --- Comment #5 from Marcel de Rooy --- Thx Aleisha. For QA: The workaround is based on the fact that YAML::Syck contains this code: sub Load { if (wantarray) { my ($rv) = YAML::Syck::LoadYAML( $_[0] ); @{$rv}; } else { @_ = $_[0]; goto &YAML::Syck::LoadYAML; } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 07:55:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 05:55:25 +0000 Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 07:55:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 05:55:28 +0000 Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76305|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 76713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76713&action=edit Bug 20927: moredetail.pl crash on nonexistent biblionumber moredetail.pl crashes when trying to view a nonexistent biblionumber. The case should be handled like it is done in detail.pl. Signed-off-by: Pasi Kallinen Signed-off-by: Maryse Simard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 07:55:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 05:55:52 +0000 Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 07:59:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 05:59:31 +0000 Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 --- Comment #5 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > I would recommend to use output_and_exit_if_error (introduced by bug 18043). > > You can find examples on bug 20661 and bug 20351. > > I was waiting for these patches to get attention before continuing in this > direction (and so apply the method to other modules). Solution is identical in detail. I saw output_and_exit_if_error somewhere recently and was not really impressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:04:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:04:14 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:04:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:04:18 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76600|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 76714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76714&action=edit Revert "Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated" This reverts commit ce6ec1e7faef217950e3450788ea444dad26d7c0. https://bugs.koha-community.org/show_bug.cgi?id=21024 Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:04:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:04:30 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:10:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:10:15 +0000 Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:10:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:10:18 +0000 Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75934|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 76715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76715&action=edit Bug 7136: Correct description of Grace period for subscriptions The grace period is used with the serialsUpdate.pl cronjob. It will generate the next issue and set the one before to 'Late' with an optional note. There is on trace of a 'waiting' status for serials. To test: - check help file on the subscription edit form for the description of the 'Grace period'. Signed-off-by: Maryse Simard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:10:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:10:36 +0000 Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:13:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:13:11 +0000 Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:25:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:25:01 +0000 Subject: [Koha-bugs] [Bug 5789] Fines don't work when items have null homebranch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5789 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |In Discussion Assignee|kyle.m.hall at gmail.com |barton at bywatersolutions.com --- Comment #16 from Marcel de Rooy --- Changing status to In Discussion. Leaving this in Signed Off is confusing. I do not object to an additional check of the branchcode in the fines script btw. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:38:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:38:09 +0000 Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |In Discussion --- Comment #17 from Marcel de Rooy --- Moving this to In Discussion. Leaving it in SO is confusing. We seem to wait for progress on 14716. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:38:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:38:32 +0000 Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |liz at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:57:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 06:57:32 +0000 Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when using SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:27:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:27:31 +0000 Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when using SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:27:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:27:34 +0000 Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when using SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76574|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 76716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76716&action=edit Bug 21020: Fix return branch on transfer - SIP Caused by commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Since this commit AddReturn return a Koha::Issue object, not a hashref with item's info. Test plan: 1 - Enable SIP server on your test instance For kohadevbox: cp /etc/koha/SIPConfig.xml /etc/koha/sites/kohadev/ create patron with user/pass term1/term1 and grant circulation privileges 2 - enable AutomaticItemReturn 3 - Checkin an item which will generate a transfer via SIP2: perl /home/vagrant/kohaclone/misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l LPL --item {BARCODE} -m checkin -t CR 4 - Note no CT field 5 - Apply patch 6 - Repeate checkin via SIP2 7 - Transfer destination is correctly returned in CT Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:32:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:32:30 +0000 Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |maryse.simard at inlibro.com |ity.org | Patch complexity|--- |Small patch Severity|minor |enhancement --- Comment #3 from Marcel de Rooy --- Not a bugfix but an enhancement. This field is important for the release maintainers. Please check next time. Assignee was not filled. Patch complexity not filled. These fields are helpful for QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:40:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:40:37 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 --- Comment #19 from abernaud --- OK, thanks for trying to help, Jonathan ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:48:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:48:50 +0000 Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:48:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:48:38 +0000 Subject: [Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy --- QA Comment: When you edit a list, you can define its sort order: title, author, copyright date or callnumber. All other (sortable) columns in the staff list view are in that group. Dateadded is not. Somehow it feels inconsistent not to add this column to that group. And allow the same sort order on OPAC. Not a blocker for me but at least reason for feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:53:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:53:51 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:53:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:53:54 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76700|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 76717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76717&action=edit Bug 21029: Make "Suspend until:" translatable The label was part of the holds.js file. As .js files are never translatable it needs to be moved to template level. Test plan: - Place a hold on an item - Go to the patron account - Click on the Suspend button on the holds tab - View the modal, the label before the date field "Suspend until:" is now translatable. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:54:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:54:04 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:59:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:59:30 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:59:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 07:59:33 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76436|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 76718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76718&action=edit Bug 20507: Shelf browser does not update image sources when paging This patch updates the shelfbrowser include so that the system preference check for Coce will function correctly. To test, apply the patch and test the OPAC shelf browser with each of the enhanced content options enabled: Coce, Amazon, Google. In each case, page through the shelf browser to confirm that covers load correctly. Signed-off-by: Cab Vinton Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:00:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 08:00:43 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 --- Comment #9 from Marcel de Rooy --- (In reply to Cab Vinton from comment #7) > Ah, gotcha. > > Excellent. The tutorial video was helpful. Excellent? But I still had to add your signoff line ;) Would you not forget next time ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:00:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 08:00:57 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:14:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 08:14:18 +0000 Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > Important note: We certainly need to add an index on this column to boost > this query. Koha::Items->search( { uri => $uri } )->count You need to add biblionumber to limit the results. No need to scan the whole table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:14:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 08:14:58 +0000 Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:58:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 08:58:20 +0000 Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug 12509 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76650|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 76719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76719&action=edit Bug 19849: Minor fixes & refactor of opac-reserve.tt & opac-user.tt - make next patch easely reviewable. - fix lone quote. (Replace by - add forgotten condition for 9999-12-31 Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:58:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 08:58:24 +0000 Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug 12509 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76651|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 76720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76720&action=edit Bug 19849: Make a string translatable again after a rebase error Bug 16621 reverted part of bug 12509 1. Log in the OPAC and staff interface 2. Restrict the user logged in the OPAC (restricting yourself works) Staff interface ? Patron page ? Restrictions ? Add manual restriction Put this comment the "OVERDUES_PROCESS Give the books back or we're comming!" 3. Install the fr_FR locale and switch the interface to it 4. Go to OPAC: /cgi-bin/koha/opac-user.pl 5. Then you should see the ugly comment with "OVERDUES_PROCESS" 6. Apply this patch 7. Update the translation: ./translate update or equivalent 8. Open misc/translator/po/fr-FR-opac-bootstrap.po 9. Find the string containing "Restriction added by overdues process" 10. Remove the fuzzy flag 11. Install the language 12. Refresh the page in the OPAC 13. Then you should see the translation + the comment instead of "OVERDUES_PROCESS" + the comment Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:58:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 08:58:17 +0000 Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug 12509 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:58:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 08:58:50 +0000 Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug 12509 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:20:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 09:20:59 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:26:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 09:26:25 +0000 Subject: [Koha-bugs] [Bug 21044] New: Error 400 'broken link' when enabling SSL from end to end Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21044 Bug ID: 21044 Summary: Error 400 'broken link' when enabling SSL from end to end Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: henri.jacob at univ-rennes1.fr QA Contact: testopia at bugs.koha-community.org Our Koha services (v16.05) are hosted on a CentOS server behind a http reverse-proxy (Apache) in mod_cgi mode. We plan to offer SSL access "from end to end" to both staff and opac clients. For this purpose, we configured the Apache Koha server like this: Apache configuration file /etc/httpd/conf.d/ssl.conf (with auto-certified certificate): SSLEngine on SSLProtocol all -SSLv3 SSLCipherSuite ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-...... SSLHonorCipherOrder on SSLCompression off SSLCertificateFile /etc/certificats/auto-signes/.crt SSLCertificateKeyFile /etc/certificats/auto-signes/.key And the http reverse-proxy is configured like that : ServerName xxxxxxxx Use SSL sssssss.univ-rennes1.fr Include conf/SSLProxy-authentifie.conf SSLProxyCACertificateFile /etc/certificats/auto-signes/.crt ProxyPass / http://:8880/ min=0 max=100 smax=50 ttl=10 timeout=900 ProxyPassReverse / http://:8880/ Why do the 'broken link' error occur ? We have seen some hard-coded references like 'http://localhost' and 'http://localhost:8080' . Should we modify all these references to 'http://localhost' and 'https://localhost:8443' ? Does-it works with an auto-certified certificate ? We read these pages about this subject: Enabling SSL for Koha staff view : https://lists.katipo.co.nz/public/koha/2011-May/029006.html Access Koha via SSL : https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5576 Thank you for any suggestion, best regards, Henri Jacob -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:04:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:04:23 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 abernaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-claire.bernaudin at univ- | |rennes1.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:05:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:05:18 +0000 Subject: [Koha-bugs] [Bug 21045] New: Default checkout limit by patron category for all libraries not managed by SIP2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21045 Bug ID: 21045 Summary: Default checkout limit by patron category for all libraries not managed by SIP2 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: anne-claire.bernaudin at univ-rennes1.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Hello We're on Koha 16.05, using selfcheck machines from Nedap. In our circulation rules, we defined Default checkout limit by patron category for "all libraries". This limit is only configured in the "all libraries" page, and not for each library. The Circcontrol syspref is set to "the library you are logged in at". In this configuration, the selfcheck machines, using the SIP protocol, ignore the "Default checkout limit by patron category". For example, for a patron category called "L", the limit is set to 20 documents. I'm able to check out 20 documents in library 1 through the staff client, and then to add some more check outs through the selfcheck machine. Please note that the Default checkout limit by patron category defined for all libraries is correctly managed by the staff client (for a patron having the patron category "L", I can't check out more than 20 documents, whatever library I'm logged in at). Also please note that this problem seems to happen only with selfcheck machines from Nedap. The problem apparently doesn't exist for Bibliotheca selfcheck machines. Could someone confirm this ? Thanks Anne-Claire (from Rennes, France) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:09:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:09:31 +0000 Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Can we attempt to deal with the discharges that may have been created and cannot be removed by staff? Can you provide an update statement Frido? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:09:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:09:37 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #20 from Marcel de Rooy --- I would suggest to add release notes. If people did not really care about such things as classification schemes, they might be up for a surprise when their data is not consistent in that area. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:12:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:12:22 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:12:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:12:34 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #22 from Marcel de Rooy --- Created attachment 76722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76722&action=edit Bug 19915: (QA follow-up) Tidy up GetItemsForInventory.t Standard edits like modules, schema, Koha objects instead of DBIC. Removing unneeded autoflush. Moving initial test to a first subtest. No need to clear issues if you clear items. Adding a FIXME for OldWay; would be nice to remove that code.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:12:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:12:39 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #23 from Marcel de Rooy --- Created attachment 76723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76723&action=edit Bug 19915: Use cn_sort values for getting inventory items To test: 1 - Catalog an item under LCC with callnumber GT95 2 - cn_sort should calculate as GT0095 3 - Go to inventory tool 4 - Enter a range that should have your item e.g LC GT90 to GT100 5 - Item is not returned 6 - Apply patch 7 - Item should be returned 8 - Verify things otherwise work as expected Signed-off-by: Anne-Claire Bernaudin Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:12:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:12:45 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76120|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy --- Created attachment 76724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76724&action=edit Bug 19915: Only show class sources in use Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:12:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:12:50 +0000 Subject: [Koha-bugs] [Bug 20545] Add multi-language support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545 abernaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-claire.bernaudin at univ- | |rennes1.fr --- Comment #9 from abernaud --- Hello, in my opinion, we should only use the language that was set in the request, assuming that it's the language selected on the self check GUI, as Katrin said in Comment #5. All the messages displayed on the selfcheck machines aren't coming from Koha : some messages are sent directly by the selfcheck machine itself. So it would be better to use the language set on the GUI. Best wishes Anne-Claire (from Rennes, France) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:12:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:12:27 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #21 from Marcel de Rooy --- Created attachment 76721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76721&action=edit Bug 19915: Add unit test to GetItemsForInventory.t prove -v t/db_dependent/Items/GetItemsForInventory.t Signed-off-by: Anne-Claire Bernaudin Signed-off-by: Marcel de Rooy Moved the betwen typo edit back here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:13:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:13:54 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #25 from Marcel de Rooy --- No blocker for me, but adding an option to control the switch from callnumber to cn_sort might be handy for some people? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:22:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 10:22:17 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #186 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #185) > Should we move this to FQA for now? Yeah I think so. Is anyone planning to work on the issues mentioned by Jonathan/Josef ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 13:05:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 11:05:19 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 13:05:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 11:05:22 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76645|0 |1 is obsolete| | --- Comment #6 from Ere Maijala --- Created attachment 76725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76725&action=edit Bug 21031 - Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration The Rewrite rules for Apache don't work unless you're using debian/templates/apache-shared-opac-plack.conf or debian/templates/apache-shared-intranet-plack.conf. This patch fixes the Rewrite rules for the non-Plack Debian Apache configuration templates as well as the standard Apache configuration file that comes with Koha. __BEFORE APPLYING__ 1. Visit /api/v1/app.pl/api/v1/spec on your git dev install 2. This should display a large page of JSON 3. Visit /api/v1/spec on your git dev install 4. This should generate a 404 error __APPLY PATCH__ __AFTER APPLYING__ 5. Visit /api/v1/app.pl/api/v1/spec on your git dev install 6. This should display a large page of JSON 7. Visit /api/v1/spec on your git dev install 8. This should display a large page of JSON (identical to the one from earlier steps) Signed-off-by: Ere Maijala -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 13:30:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 11:30:17 +0000 Subject: [Koha-bugs] [Bug 19850] Enhance invoicing functionality for each line item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19850 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 14:11:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 12:11:53 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 76726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76726&action=edit Bug 20978: (QA follow-up) Do not delete existing data on tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 14:19:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 12:19:31 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76726|0 |1 is obsolete| | --- Comment #26 from Tom?s Cohen Arazi --- Created attachment 76727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76727&action=edit Bug 20978: (QA follow-up) Do not delete existing data on tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 14:22:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 12:22:41 +0000 Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76442|0 |1 is obsolete| | --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 76728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76728&action=edit Bug 20980: Add 'Manual Credit' and fix existing offsets This patch adds a new offset type 'Manual Credit'. And adds an atomic update for fixing existing offsets. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 14:22:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 12:22:48 +0000 Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76443|0 |1 is obsolete| | --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 76729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76729&action=edit Bug 20980: Make mancredit.pl use Koha::Account::add_credit This patch makes creating a manual credit from the UI record the account offset as 'Manual Credit', and properly set account_offsets.credit_id instead of account_offsets.debit_id. To test: - Create a manual credit (of 'Credit' type) for a known patron (acevedo?) - Run: $ sudo koha-mysql kohadev > SELECT * FROM account_offsets; => FAIL: The account offset for the manual credit has type=Manual Debit, credit_id=NULL and debit_id=accountlines_id - Run the atomic update: $ updatedatabase - Run: $ sudo koha-mysql kohadev > SELECT * FROM account_offsets; => SUCCESS: The account offset has been corrected and now has type=Manual Credit, credit_id=accountlines_id and debit_id=NULL - Create a new manual credit (of 'Forgiven' type) for a known patron - Run: $ sudo koha-mysql kohadev > SELECT * FROM account_offsets; => SUCCESS: The account offset has been stored correctly as a credit! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 14:22:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 12:22:54 +0000 Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76444|0 |1 is obsolete| | --- Comment #20 from Tom?s Cohen Arazi --- Created attachment 76730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76730&action=edit Bug 20980: (follow-up) Only use UpdateStats for 'payment' and 'writeoff' This patch makes Koha::Account::add_credit record statistics logs (through C4::Stats::UpdateStats) only for the 'payment' and 'writeoff' credit types. Both credit types are whitelisted in UpdateStats, so we keep the current behaviour. Another option would've been to add new account types to the white list, but with the account offsets it seems that using the statistics table for account changes won't be useful for too long, as offsets contain the same (and more) information. To test: - Apply the patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 14:23:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 12:23:10 +0000 Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 --- Comment #22 from Tom?s Cohen Arazi --- Created attachment 76732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76732&action=edit Bug 20980: (QA follow-up) Do not delete existing data on tests fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 14:23:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 12:23:02 +0000 Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76445|0 |1 is obsolete| | --- Comment #21 from Tom?s Cohen Arazi --- Created attachment 76731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76731&action=edit Bug 20980: (follow-up) Offset name consistency This patch makes 'credit' account types generate 'Manual Credit' offset. The original patch used 'Payment' but I think the code wants to distinguish between payments and manually added credits (otherwise they would've picked the same accounttype value, and they don't. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 14:37:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 12:37:12 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76727|0 |1 is obsolete| | --- Comment #27 from Tom?s Cohen Arazi --- Created attachment 76733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76733&action=edit Bug 20978: (QA follow-up) Do not delete existing data on tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 14:41:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 12:41:55 +0000 Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76732|0 |1 is obsolete| | --- Comment #23 from Tom?s Cohen Arazi --- Created attachment 76734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76734&action=edit Bug 20980: (QA follow-up) Do not delete existing data on tests fix Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 15:16:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 13:16:13 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76671|0 |1 is obsolete| | --- Comment #11 from Ere Maijala --- Created attachment 76735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76735&action=edit Bug 20447: MARC Holdings support https://bugs.koha-community.org/show_bug.cgi?id=20447 Enable by setting "SummaryHoldings" option to "Use". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 15:16:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 13:16:18 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76672|0 |1 is obsolete| | --- Comment #12 from Ere Maijala --- Created attachment 76736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76736&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 15:30:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 13:30:59 +0000 Subject: [Koha-bugs] [Bug 21046] New: ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Bug ID: 21046 Summary: ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org Using ILS-DI AuthenticatePatron (cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=userid&password=pass) with a user having an empty cardnumber returns a wrong borrowernumber if there is at least one other empty cardnumber. Put the severity to critical because this has very bad consequences on Koha and front applications. Patch is coming. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 15:31:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 13:31:22 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 15:31:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 13:31:28 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 15:41:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 13:41:31 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #1 from Alex Arnaud --- Created attachment 76737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76737&action=edit Bug 21046: Return the correct borrowernumber when there is empty cardnumber(s) Test plan: - Use a patron with an empty cardnumber to authenticate with ILSDI AuthenticatePatron (cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=userid&password=pass), - make sure you have other patron(s) with empty cardnumber and there borrowernumber is smaller than the one you authenticate with, - you should get a wrong borrowernumber, - apply this patch, - test again, you should get the right one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 15:42:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 13:42:11 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 15:42:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 13:42:18 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:32:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:32:06 +0000 Subject: [Koha-bugs] [Bug 21047] New: Wrong koha to marc mapping on bibliosubtitle in SQL files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Bug ID: 21047 Summary: Wrong koha to marc mapping on bibliosubtitle in SQL files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org SQL files in installer/data/mysql/ create frameworks with a koha to MARC mapping on obsolete table bibliosubtitle. This table was removed when upgrading from Koha 2.2 to 3.0. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:32:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:32:13 +0000 Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:35:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:35:00 +0000 Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:35:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:35:03 +0000 Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 --- Comment #1 from Fridolin SOMERS --- Created attachment 76738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76738&action=edit Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files SQL files in installer/data/mysql/ create frameworks with a koha to MARC mapping on obsolete table bibliosubtitle. This table was removed when upgrading from Koha 2.2 to 3.0. Test plan : 1) Create a new install with web installer 2) Check that creating a record is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:37:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:37:57 +0000 Subject: [Koha-bugs] [Bug 20962] Overhaul to notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962 --- Comment #10 from Katrin Fischer --- Hi all, after reading the RFC more closely I have some additional comments, Step 1 is the main concern for us: Comment on: Step 1 - Move Overdues into member messaging preferences I think this change is not as straightforward as it sounds at first and could cause unwanted changes in behaviour and regressions for some use cases. At the moment it's possible to: - Configure per patron category, if overdue notices will be sent - Configure per library, patron category and notice level which notice template will be used. - Configure per library, notice level, patron category and notice level which transport types will be used (multiple). I assume that with the new feature the notification methods would be moved out of notice triggers into the messaging preferences table. 1) Library: Looking at the overdue_notices.pl script I understand that notices are usually grouped by items.homebranch using the settings for the said library. So multiple libraries in one Koha installation can handle their notices differently. The patron can receive different notices by different transport types from different branches. With the change as I understand it, this would change and only one notification methods setting would apply to all libraries. 2) Notification method: The 'Note' on the RFC mentions that for mutiple levels of overdues, they should be included in one notice type for messaging preferences. I understand this would mean one line in the table for all 3 levels of notices applied with the settings made there applied to all of them. Currently message transport types can be different per library and notice level. I think this would no longer work with the suggested change. A very common use case here is: Sent the first 2 overdues by email, sent the 3rd in a more formal way as a postal notice. If this would no longer be possible it would cause big problems for us. 3) Patron's choice: As stated before it would cause a problem for us, if patrons can opt out of overdue notices themselves. Overdue notices appearing in the messaging preferences in OPAC should be a configurable option to allow for different use cases. 4) ON/OFF swith: Currently there is a switch on patron category level. I understand that the intention would be to make this more granular to be by library and patron category? Comment on: Step 2 - Enable 'postal' as a specific option rather than simply a fallback,for all notice types Would the fallback to postal for users without valid email address or mobile number still be available? It could be optional, but we are relying quite heavily on this behaviour at the moment. Comment on: Step 3 - option to process all print notices together Is this refering to the functionality currently implemented in gather_print_notices.pl? For privacy reasons there should always be an option to get the files with notices from the server instead of sending them by email (for example using Bug 11317 - Add a way to access files from the intranet) Comment on: Step 4 - extend tags to other circulation notices I think this would be great. As we are planning to obsolete the <<...>> syntax by TT at some point, it would make sense to ensure there is a working TT equivalent for all notices too. Comment on: Step 6 - Allow circulation notices to be created for any item status change A tool to send notices based on configurable triggers sounds like a great idea. Comment on: Step 8 - Do not disturb for message queue I like the idea and it definitely makes sense for SMS. Only a technical thing maybe: As the scheduled cronjobs generate notices and add them into the message queue, it would probably make sense to make the change on the processing of the message_queue, allowing it to ignore notices of some types during the DND time periods. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:40:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:40:45 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:41:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:41:56 +0000 Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when using SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:42:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:42:09 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:42:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:42:26 +0000 Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:42:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:42:42 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:42:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:42:55 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:43:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:43:08 +0000 Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:43:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:43:25 +0000 Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug 12509 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:43:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:43:53 +0000 Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:44:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:44:06 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #28 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:43:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:43:39 +0000 Subject: [Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26 (April 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:46:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:46:28 +0000 Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #24 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:46:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:46:43 +0000 Subject: [Koha-bugs] [Bug 20731] Move template JavaScript to the footer: Call number browser MARC plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:46:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:46:54 +0000 Subject: [Koha-bugs] [Bug 20667] Update two-column templates with Bootstrap grid: Acquisitions part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:47:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:47:07 +0000 Subject: [Koha-bugs] [Bug 20668] Update two-column templates with Bootstrap grid: Acquisitions part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:47:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:47:19 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:47:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:47:41 +0000 Subject: [Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:47:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:47:53 +0000 Subject: [Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:47:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:47:30 +0000 Subject: [Koha-bugs] [Bug 20220] Move template JavaScript to the footer: Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:48:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:48:08 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #144 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 16:48:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 14:48:25 +0000 Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:12:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 15:12:48 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #26 from Eric Phetteplace --- (In reply to Marcel de Rooy from comment #25) > No blocker for me, but adding an option to control the switch from > callnumber to cn_sort might be handy for some people? What is the use case for sorting by callnumber? I cannot think of a reason one would want to sort by a non-normalized call number. Especially for inventory purposes, having a sort that supposedly matches your shelves is the only useful one, unless I'm missing something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:14:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 15:14:20 +0000 Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76446|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 76739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76739&action=edit Bug 20990: Unit tests for Koha::Account->outstanding_credits Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:14:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 15:14:24 +0000 Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76447|0 |1 is obsolete| | --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 76740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76740&action=edit Bug 20990: Add Koha::Account->outstanding_credits This patch adds a method that retrieves (for a patron's account) the outstanding credits (i.e. those that haven't been applied to any debit. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:14:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 15:14:28 +0000 Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76448|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 76741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76741&action=edit Bug 20990: (follow-up) Fix test description Test plan: prove -v t/db_dependent/Koha/Account.t --> Test message of first test of subtest outtanding_credits correctly says "Outstanding credits total..." Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:14:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 15:14:32 +0000 Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76525|0 |1 is obsolete| | --- Comment #15 from Tom?s Cohen Arazi --- Created attachment 76742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76742&action=edit Bug 20990: Make same changes that were made to outstanding_debits Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:14:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 15:14:36 +0000 Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76640|0 |1 is obsolete| | --- Comment #16 from Tom?s Cohen Arazi --- Created attachment 76743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76743&action=edit Bug 20990: (QA follow-up) make outstanding_credits return the account lines only This patch was discussed with Jonathan on a QA conversation. It is better to keep this simpler and more reusable. And is the right approach in this case. This patch makes Koha::Account::outstanding_credits return the account lines, code that used the $total value, will just use $lines->total_outstanding; Tests are adjusted accordingly. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Test pass. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:21:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 15:21:36 +0000 Subject: [Koha-bugs] [Bug 15971] Allow use of all biblio and biblioitems fields (like issn) in serial claim letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15971 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow use of all biblio and |Allow use of all biblio and |biblioitems fields in |biblioitems fields (like |serial claim letters |issn) in serial claim | |letters --- Comment #1 from Katrin Fischer --- This is sadly still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:34:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 15:34:02 +0000 Subject: [Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 --- Comment #27 from Katrin Fischer --- Koha libraries might have migrated without filling the classification source subfield which would result in an empty cn_sort. Also, as we only have a limited selection of filing rules available, maybe there are use cases where a simple sort works better? Not sure about that, but it feels like almost every library here has their own homegrown classification scheme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:58:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 15:58:11 +0000 Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #8 from Martin Renvoize --- So the core proposal here is that we stop adding `->search_for_functionality_x` methods to the DB level Koha::Objects and rather add generalized filters for complex joins etc if we need to. If we really want to add a `for_functionality_x` method/routine to centralize code for say patron manipulations (where we may have a UI and Script driven element) we should break that out into a subclass of some kind that contains the functions/methods for just that area of functionality. Koha::Patron::BulkActions perhaps as an example.. containing `->bulk_selection(filter_a, filter_b)` which internally just calls either a large constructed query (like the code in option 1) or a chained set of queries (from option 2) and then various available `->bulk_actions` that may be applied to the selected set. `->bulk_delete`, `bulk_anonymise`, `bulk_modify` for example? Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:25:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 16:25:16 +0000 Subject: [Koha-bugs] [Bug 1884] Managing Suggestions - way to archive/clean up approved/rejected orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1884 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:25:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 16:25:35 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:26:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 16:26:58 +0000 Subject: [Koha-bugs] [Bug 14049] Ability to add custom fields to OPAC purchase suggestion form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:28:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 16:28:36 +0000 Subject: [Koha-bugs] [Bug 1971] Suggestion : Should have only one entry by title + a counter of waiting persons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1971 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:30:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 16:30:29 +0000 Subject: [Koha-bugs] [Bug 5539] Options for Suggestion Emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5539 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:40:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 16:40:34 +0000 Subject: [Koha-bugs] [Bug 21048] New: suggest_status not behaving properly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Bug ID: 21048 Summary: suggest_status not behaving properly Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: lisetteslatah at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 76744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76744&action=edit Status Blank - members/purchase-suggestions.pl If you set up suggest_status in the authorized values and then select one of these AV as a status it does not behave properly. 1. The tab in suggestions.pl is labeled 'Status unknown' 2. If you click on 'Status unknown' it will show the AV you selected in the status. 3. If you click on the suggestion title to open the full information, the status is blank. 4. If you edit the suggestion it now says 'No status' (the reason, if entered, is still filled.) 5. On the patron's purchase suggestion page on the staff side, the status is blank but the reason still shows up. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:41:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 16:41:09 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer --- Created attachment 76745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76745&action=edit No status when viewing suggestion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:42:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 16:42:37 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #2 from Lisette Scheer --- Created attachment 76746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76746&action=edit Visible when filtering suggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:44:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 16:44:46 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #3 from Lisette Scheer --- Created attachment 76747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76747&action=edit OPAC View 6. The OPAC side shows the authorized value instead of the OPAC description. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 19:41:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 17:41:52 +0000 Subject: [Koha-bugs] [Bug 20962] Overhaul to notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962 --- Comment #11 from Barton Chittenden --- (In reply to Katrin Fischer from comment #10) > 2) Notification method: The 'Note' on the RFC mentions that for mutiple > levels of overdues, they should be included in one notice type for messaging > preferences. I understand this would mean one line in the table for all 3 > levels of notices applied with the settings made there applied to all of > them. > > Currently message transport types can be different per library and notice > level. I think this would no longer work with the suggested change. A very > common use case here is: > Sent the first 2 overdues by email, sent the 3rd in a more formal way as a > postal notice. > > If this would no longer be possible it would cause big problems for us. > > 3) Patron's choice: As stated before it would cause a problem for us, if > patrons can opt out of overdue notices themselves. Overdue notices appearing > in the messaging preferences in OPAC should be a configurable option to > allow for different use cases. To give another concrete case here, one of our partners has an Audio-Visual department in one of their libraries which lends laptops, video cameras, tablets etc. This department is organized as its own branch. They have very specialized notices and overdue triggers due to the monetary value of the items they're lending -- for this library, losing control of the timing content and method of notice delivery is not an option. Another thing to keep in mind is that the library updating borrower messaging preferences is currently awkward -- the library can currently modify default messaging preferences, but in order for that to propagate, we have to run a script. If we move more control over borrower messaging preferences, then I think we need to have a more sophisticated system of allowing the library to a) control which options borrowers have control over (so that borrowers can't entirely disable overdue notices, for example) and b) some way of allowing borrowers to specify which preferences they want to stick when the library makes changes, so that library changes don't automatically break patron customizations. Any change to message triggers and borrower messaging preferences is going to require some *very* careful thought; there's a much broader spectrum of use-cases and work flows than meets the eye. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 21:03:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 19:03:24 +0000 Subject: [Koha-bugs] [Bug 21049] New: Rancor 007 field does not retain value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Bug ID: 21049 Summary: Rancor 007 field does not retain value Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When using Rancor, 007 field editor, you select the material type, and as soon as the record is saved, it reverts to the first material type in the list. The information is saved correctly, but every time the record gets edited the correct material type has to be selected again or else it is saved as the material type listed first in the dropdown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 21:03:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 19:03:36 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 21:56:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 19:56:58 +0000 Subject: [Koha-bugs] [Bug 6647] Label item search should use standard pagination routine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 21:57:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 19:57:01 +0000 Subject: [Koha-bugs] [Bug 6647] Label item search should use standard pagination routine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75858|0 |1 is obsolete| | --- Comment #2 from Maryse Simard --- Created attachment 76748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76748&action=edit Bug 6647: Label item search should use standard pagination routine This patch doesn't fix how pagination links are generated for the label item search results, but it does modify the template so that the pagination links are styled like they are on catalog search results. To test, apply the patch and go to Tools -> Labels. - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Perform a search which would return multiple results. - Confirm that the style of the pagination bar matches the one on the catalog search results page. - Confirm that current-page number highlighting works correctly. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 22:25:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 20:25:50 +0000 Subject: [Koha-bugs] [Bug 21009] Item URIs longer than 255 bytes are silently truncated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009 Pierre-Luc Lapointe changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pierre-luc.lapointe at inLibro | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 22:25:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 20:25:39 +0000 Subject: [Koha-bugs] [Bug 21009] Item URIs longer than 255 bytes are silently truncated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009 Pierre-Luc Lapointe changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76578|0 |1 is obsolete| | --- Comment #3 from Pierre-Luc Lapointe --- Created attachment 76749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76749&action=edit Bug 21009: Fix max length of inputs on editing/adding items There is a "max length" value you can define at framework level to limit the size of the input. But it is not taken into account on the add/edit item form. It is a regression that has been introduced by commit 47d2de9c024bfb93d56184f298f334b20685cd86 Bug 12176: Remove HTML from additem.pl max_length vs maxlength Test plan: - Define a maximum length for an item subfield - Add or edit an item => Without this patch the maxlength attribute of the inputs are not defined (maxlength="") => With this fix you will see the maxlength attributes correctly set with the value you defined in the framework Note: We could/should set this value to the size of the DB column when mapped For instance 952$u is mapped with items.uri, which is a varchar(255). This length restriction should done at framework level Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 00:44:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2018 22:44:40 +0000 Subject: [Koha-bugs] [Bug 20283] Editing a course item for an inactive course affects the item fields directly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20283 nchan at cca.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nchan at cca.edu --- Comment #1 from nchan at cca.edu --- I'm having the same issue. Additionally, when deleting an inactive course that contains reserve items, the values that are normally changed when the course is marked "active" are changed permanently in the item record. Course reserve class is inactive. Item in the course reserve list has correct location, item type, and shelving location. Course reserve class is deleted (due to inactivity). Item that was listed in the course reserve list now has a location status of "reserves," item type of "reserve," and location is changed based on branch where the course reserves were held. Switching the course to "active" before deleting the course also causes the same result. This is pretty frustrating to go back and fix manually due to the number of items that may be in a course (and once the course is deleted, it may be hard to track down the original list). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 13:56:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2018 11:56:56 +0000 Subject: [Koha-bugs] [Bug 6647] Label item search should use standard pagination routine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 13:56:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2018 11:56:59 +0000 Subject: [Koha-bugs] [Bug 6647] Label item search should use standard pagination routine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76748|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 76750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76750&action=edit Bug 6647: Label item search should use standard pagination routine This patch doesn't fix how pagination links are generated for the label item search results, but it does modify the template so that the pagination links are styled like they are on catalog search results. To test, apply the patch and go to Tools -> Labels. - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Perform a search which would return multiple results. - Confirm that the style of the pagination bar matches the one on the catalog search results page. - Confirm that current-page number highlighting works correctly. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 13:58:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2018 11:58:38 +0000 Subject: [Koha-bugs] [Bug 6647] Label item search should use standard pagination routine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Stumbled on bug 21050 while testing this. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 13:58:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2018 11:58:13 +0000 Subject: [Koha-bugs] [Bug 21050] New: Datepickers on LabelItemSearch broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 Bug ID: 21050 Summary: Datepickers on LabelItemSearch broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Something is wrong with the JavaScript on the label item search. The visible problem is the missing datepickers on the date fields in the search form. To test: - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 14:00:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2018 12:00:01 +0000 Subject: [Koha-bugs] [Bug 21009] Max length of inputs on editing/adding items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item URIs longer than 255 |Max length of inputs on |bytes are silently |editing/adding items is |truncated |broken CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 14:04:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2018 12:04:11 +0000 Subject: [Koha-bugs] [Bug 21009] Max length of inputs on editing/adding items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 14:04:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2018 12:04:15 +0000 Subject: [Koha-bugs] [Bug 21009] Max length of inputs on editing/adding items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76749|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 76751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76751&action=edit Bug 21009: Fix max length of inputs on editing/adding items There is a "max length" value you can define at framework level to limit the size of the input. But it is not taken into account on the add/edit item form. It is a regression that has been introduced by commit 47d2de9c024bfb93d56184f298f334b20685cd86 Bug 12176: Remove HTML from additem.pl max_length vs maxlength Test plan: - Define a maximum length for an item subfield - Add or edit an item => Without this patch the maxlength attribute of the inputs are not defined (maxlength="") => With this fix you will see the maxlength attributes correctly set with the value you defined in the framework Note: We could/should set this value to the size of the DB column when mapped For instance 952$u is mapped with items.uri, which is a varchar(255). This length restriction should done at framework level Signed-off-by: Pierre-Luc Lapointe Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 14:08:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2018 12:08:58 +0000 Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75914|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 76752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76752&action=edit Bug 20900: Add CPL test branch in rollingloans.t Trivial fix. Test plan: Without this patch and a CPL library, run rollingsloans.t. See warns. With this patch, no warns. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 14:09:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2018 12:09:02 +0000 Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76610|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 76753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76753&action=edit Bug 20900: Add CPL branch in t_Batch.t too Same fix as previous patch. Test plan: Run t/db_dependent/Labels/t_Batch.t (without CPL branch) Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 14:09:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2018 12:09:20 +0000 Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 12:19:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 10:19:32 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- Just some small remarks, no blockers: Instead of "Click to edit" and "Click to collapse" I think it should just be "Edit" and "Collapse" as there is no need to extra label a link for clicking. Also... I think the German translation would be horribly long :) Attaching a patch with the suggested change, feel free to disagree! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 12:23:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 10:23:14 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76664|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 76754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76754&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a
, with the preference name as the
and the description as the
. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpull? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 12:23:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 10:23:18 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #15 from Katrin Fischer --- Created attachment 76755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76755&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 12:27:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 10:27:34 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #16 from Katrin Fischer --- There is no question that this is more modern and prettier looking than before. The new filter functionality is a great addition, as are the "(modified)" labels on prefs changed. I am still a little torn on usability. I have the impression that it takes me a little longer to find things with the new styling. In the old interface the prefs were (ugly) Courier and in one column, so scanning over the page was pretty fast. This might be just a thing of 'being used to the old way'. I'd love another opinion as this is a bigger change and it would be good to get another set of eyes on it. Could be another sign-off or QA opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 13:02:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 11:02:04 +0000 Subject: [Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 13:02:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 11:02:08 +0000 Subject: [Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 --- Comment #6 from Katrin Fischer --- Created attachment 76756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76756&action=edit Bug 14446: Workaround to resolve uninitialized value in goto warning Forcing both GetTab calls to list context resolves the warning. A workaround, not a real fix. Test plan: Search for something in the syspref text bar. Without this patch, you will have a warn: Use of uninitialized value in goto With this patch, you won't. Signed-off-by: Aleisha Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 13:07:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 11:07:23 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- What should be the next step here? I am bit lost in the discussion, has consensus be reached or should we move this out of the queue for more discussion? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 13:13:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 11:13:16 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- I don't have enough data to test this properly, but seems straight forward. Alex, maybe you could have another look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 14:04:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 12:04:05 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer --- Trying to tackle this: 1) QA scripts Only the second looks valid, as this class is new and added by the patch set: FAIL Koha/CmsPage.pm FAIL pod coverage POD coverage was greater before, try perl FAIL Koha/CmsPages.pm FAIL pod coverage POD is missing for 'object_class' FAIL Koha/Schema/Result/CmsPage.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Can you please fix? 2) Code review a) Schema patches would be much better in a separate patch. Ok for now as the patch still applies. For a rebase separating those change might be good. b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) 3) Unit tests ... all passing! 4) Feature tests OPAC a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) f) Navigation looks strange when working with multiple levels. Repeating the level before seems unnecessary and only takes up space? Level 1 Level 1 ? Level 2 Level 2 ? Level 3 Also, clicking on the different links, sometimes a part of the navigation disappears. I think this is a little too wonky to pass. Can you take another look please? (blocker) Intranet Where do the pages appear in the intranet? Generally I think this will be a great and really helpful addition and looking forward to return to this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 14:33:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 12:33:40 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer --- Hi Aleisha, thx for the follow-up! Some notes: 1) I'd like to see "click to view note" changed to just "view note". As the text is formatted as a link, there should be no need to add the additional instruction. 2) When there are multiple lines with notes and you click on one of them, they will just overlay each other, with the first note being behind the second and so on, There seems to be no way to make them disappear again. I think my expectation was that the note would disappear clicking on the next note or just clicking outside the note field again. A longer note can also overlay the buttons, so I think putting some more thought into this would be worthwhile. 3) Tiny: Can you make your patch subject: Bug XXXX: (follow-up)? I would have fixed it as part of QA, but then stumbled on 2). (see: https://wiki.koha-community.org/wiki/Commit_messages#Follow-ups) Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 14:35:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 12:35:15 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #22 from Katrin Fischer --- 4) Editing a note no longer works! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 14:37:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 12:37:50 +0000 Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the title checked out during placing hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Patch doesn't apply, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 14:39:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 12:39:45 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Option for escaping slashes |Elasticsearch - Option for |in search queries |escaping slashes in search | |queries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 14:50:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 12:50:36 +0000 Subject: [Koha-bugs] [Bug 20334] Elasticsearch - Option for escaping slashes in search queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- Hi David, 1) Can you please add an entry for the new system preference in sysprefs.sql? 2) I wonder, is this something where picking a sensible default behaviour could make sense? Honestly I am more than a little confused by the different options, but I can confirm that searching for something containing / won't work right now, which is a problem. For example, it will break when someone copies a MARC record for search. Example: Dutch : an essential grammar / William Z. Shetter and Inge Van der Cruysse-Van Antwerpen 3) The system preference doesn't mention that it applies to Elasticsearch only - I think we need to add this information. 4) My sample search: Dutch / William doesn't work with any of the settings. What am I missing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 15:02:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 13:02:12 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #13 from Katrin Fischer --- I'd love to test this, but I am stuck on my Elasticsearch authority search not working at all. This is what I've tried: I've reset my mappings using: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 Then I've done a complete reindex. When I search for an authority, I get an Internal server error resolving to: [Request] ** [http://localhost:9200]-[400] [query_shard_exception] No mapping found for [Heading__sort.phrase] in order to sort on, with: {"index":"koha_kohadev_authorities","index_uuid":"FwdgBXbyRq-5E0F3sa4LTA"}, called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/share/perl5/Catmandu/Store/ElasticSearch/Bag.pm line 167. With vars: {'request' => {'method' => 'GET','path' => '/koha_kohadev_authorities/data/_search','ignore' => [],'mime_type' => 'application/json','qs' => {},'body' => {'sort' => [{'Heading__sort.phrase' => 'asc'}],'query' => {'bool' => {'should' => [{'match' => {'Heading-Main' => 'k'}}]}},'size' => 20,'from' => 0},'serialize' => 'std'},'status_code' => 400,'body' => {'status' => 400,'error' => {'type' => 'search_phase_execution_exception','grouped' => bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' ),'failed_shards' => [{'shard' => 0,'reason' => {'index' => 'koha_kohadev_authorities','type' => 'query_shard_exception','reason' => 'No mapping found for [Heading__sort.phrase] in order to sort on','index_uuid' => 'FwdgBXbyRq-5E0F3sa4LTA'},'node' => 'vSTPqetISteesIkQSA_Ehg','index' => 'koha_kohadev_authorities'}],'phase' => 'query','reason' => 'all shards failed','root_cause' => [{'type' => 'query_shard_exception','index' => 'koha_kohadev_authorities','reason' => 'No mapping found for [Heading__sort.phrase] in order to sort on','index_uuid' => 'FwdgBXbyRq-5E0F3sa4LTA'}]}}} Unable to perform your search. Please try again. Anyone able to help or point me in the right direction? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 15:50:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 13:50:29 +0000 Subject: [Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Just noticed, there is a typo in the author line: Kyle M Hall watet instead of water -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:08:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:08:08 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I am not sure we should allow returning of a borrowernumber for an empty cardnumber. This could lead to all kinds of problems. I feel we should return an error for an empty cardnumber. What if 2 patrons pick the same password or are imported with the same default password? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:08:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:08:45 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #3 from Katrin Fischer --- We assume cardnumbers need to be unique, NULL should not be treated as a valid value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:15:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:15:13 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:15:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:15:17 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70920|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 76757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76757&action=edit Bug 20090: Missing script statement for Novelist Select on some record displays in OPAC This patch adds a check for UPCs and well as ISBNs to the Novelist Select conditionals in opac-detail.tt To test (note that you must subscribe to Novelist Select): 1. If your library does not use the raton ratings feature, activate it for the purposes of this test. 2. Display a record that does not have an ISBN in the 020 field, but has a upc (or other code) in the 024 field. The rating option will display as 5 radio buttons and a "rate it" button. 3. Apply the patch. 4. Display the same record again. The radio buttons will be replaced with stars. This indicates that the scripts on the page completed. Rather that using the patron ratings as in indicator, you can also use a web page inspector/debugger such as firebug or the built-in inspectors in most newer browsers to check for script errors. Signed-off-by: Katrin Fischer I couldn't check with Novelist Select, but read and checked changed made carefully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:19:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:19:04 +0000 Subject: [Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20410 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:19:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:19:04 +0000 Subject: [Koha-bugs] [Bug 20410] Remove OpacGroupResults system preference and feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20332 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:18:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:18:57 +0000 Subject: [Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I think PazPar2 and grouped results are going to be deprecated, see bug 20410. But changes make sense from carefully reading and checking them. I am going to sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:19:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:19:52 +0000 Subject: [Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72414|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 76758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76758&action=edit Bug 20332: Allow translating some grouped opac results texts The grouped OPAC results page has several untranslatable javascript-added texts, including the selection modifiers "Clear all" and "Select all" links, and the entries in the shelves/lists dropdown. Compare to opac-results.tt Signed-off-by: Pasi Kallinen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:19:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:19:49 +0000 Subject: [Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:22:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:22:41 +0000 Subject: [Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:22:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:22:44 +0000 Subject: [Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76576|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 76759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76759&action=edit Bug 21023: Remove warning in t/db_dependent/Circulation/Chargelostitem.t To test: - Run: $ kshell k$ prove t/db_dependent/Circulation/Chargelostitem.t => FAIL: Warning is displayed - Apply this patch - Run: k$ prove t/db_dependent/Circulation/Chargelostitem.t => SUCCESS: Tests pass! No warning! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:27:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:27:34 +0000 Subject: [Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Marcel, I've tried testing this, but can't reproduce the errors. What exactly do you mean by: Open a basket that contains no prices. ? I've tried closing and reopening a basket with one order line where I left all entries empty, but that didn't do it. Closing an empty basket is not possible, so I am a little lost here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:56:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:56:26 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:56:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:56:30 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #8 from Katrin Fischer --- Created attachment 76760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76760&action=edit Bug 20084: Fix Industrial2of5 and COOP2of5 patron card layouts == Test plan == This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working...) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 9. Layout: set "Barcode type:" to COOP2of5 10. Export the batch 11. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 12. Apply this patch 13. Retry with both non-working patches 1. You should have a white page with a barcode 2. And no errors in the relevant log file Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:58:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:58:08 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Updating severity too - not being able to print is not good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 16:57:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 14:57:46 +0000 Subject: [Koha-bugs] [Bug 21051] New: CGI::param called in list context when editing a patron card layout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 Bug ID: 21051 Summary: CGI::param called in list context when editing a patron card layout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: - Edit a patron card layout - Save or cancel editing CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_patroncards_edit_2dlayout_2epl line 186, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_patroncards_edit_2dlayout_2epl line 186, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_patroncards_edit_2dlayout_2epl line 186, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 57, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:09:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:09:23 +0000 Subject: [Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Katrin Fischer --- Can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:12:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:12:11 +0000 Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |charles.farmer at inlibro.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:13:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:13:45 +0000 Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 --- Comment #2 from Katrin Fischer --- Can't reproduce the problem, but we have seen similar recently and this will not hurt. Please don't forget to assign bugs to yourself when providing or planning to provide a patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:14:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:14:07 +0000 Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:14:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:14:11 +0000 Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 --- Comment #3 from Katrin Fischer --- Created attachment 76761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76761&action=edit Bug 21025: Add GetPreparedLetter to Koha::Patron::Discharge Test plan (shamelessly ripped from Bug20953): 1) Set system preference 'useDischarge' to 'Allow' 2) Choose a patron without checkouts nor fines nor restrictions 3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl 4) Click on 'ask for a discharge' tab => You see /cgi-bin/koha/opac-discharge.pl with text 'What is a discharge? ...' 5) Click on 'Ask for a discharge' link => You see /cgi-bin/koha/opac-discharge.pl?op=request with text 'Your discharge request has been sent ...' 6) In a new browser tab/page, go to intranet on /cgi-bin/koha/members/discharges.pl => You see one discharge requets for the patron => Click on 'allow' on patron discharge request 7) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl => You see link 'Get your discharge' 8) Click on the link to get your generated PDF => An error message should appear informing you to contact your website's admin 9) Apply this patch 10) Click again on the link to get your generated PDF => This time, a download prompt should appear Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:31:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:31:41 +0000 Subject: [Koha-bugs] [Bug 20974] Remove files left behind after removing Solr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:31:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:31:44 +0000 Subject: [Koha-bugs] [Bug 20974] Remove files left behind after removing Solr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76229|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 76762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76762&action=edit Bug 20974: Remove files left behind after removing Solr Some files were left behind when Bug 12538 removed support for Solr. This patch removes them. To test, apply the patch and fail to observe the existence of these files: koha-tmpl/opac-tmpl/bootstrap/en/includes/search/facets.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/page-numbers.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/resort_form.inc Perform a search in the OPAC to confirm that nothing broke. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:33:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:33:42 +0000 Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76738|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 76763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76763&action=edit Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files SQL files in installer/data/mysql/ create frameworks with a koha to MARC mapping on obsolete table bibliosubtitle. This table was removed when upgrading from Koha 2.2 to 3.0. Test plan : 1) Create a new install with web installer 2) Check that creating a record is OK Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:34:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:34:22 +0000 Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I think it would be good to also add a database update cleaning up existing frameworks. What do you think, Frido? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:39:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:39:22 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 --- Comment #16 from Katrin Fischer --- This will only explode when there is a record found locally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:43:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:43:43 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68804|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 76764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76764&action=edit Bug 18822 - Better error response Apply this patch first to see a change in the error feedback - instead of [Object object] you should get a text readable error Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:43:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:43:47 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75561|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 76765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76765&action=edit Bug 18822: Check if we have MARC::Record and convert if not when using ES The new_record_from_zebra subroutine assumes that when using ES we always get MARC::Record objects when using ES, but sometimes we get them as xml via Z39 or internally. This adds a test to new_from_zebra to confirm we have a record object and to convert it if not To test: 1 - Perform an advanced search from the advanced editor, make sure to select 'Local catalog' and a remote source 2 - Error 'Internal search error [Object object]' 3 - Apply patch 4 - Repeat search, success! 5 - Select and deselect various servers, search should still work Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:44:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:44:05 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:48:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:48:00 +0000 Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- No test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:49:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:49:36 +0000 Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:49:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:49:55 +0000 Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76545|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 76766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76766&action=edit Bug 21008: Use patron object to get category_type This patch makes borrower_add_additional_fields() in both pay.pl and paycollect.pl use the right object to pick the category_type. It also populates the extendedattributes template variable in pay.pl which was missed by a change. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 17:49:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 15:49:59 +0000 Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76547|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 76767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76767&action=edit Bug 21008: Use Koha::Patron->is_child Signed-off-by: Tomas Cohen Arazi Edit: I removed the category parameter as it is not really used. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:11:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:11:08 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75664|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 76768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76768&action=edit Bug 16575: Irregular behaviour using window.print() followed by window.location.href This patch updates the OPAC and staff client carts to use CSS to control print output, removing a print parameter which was passed to the script. Currently, when you click "Print" on the OPAC basket, it navigates to a new page and initiates window.print() followed by a window.location.href change again. Unfortunately, due to differences in IE, Chrome, and FF, it will either show the print options, navigate away without showing them, or refuse to navigate away after printing. By changing to using print CSS, we don't navigate away from the basket in the first place, so we prevent this irregular behavior. TEST PLAN 1) Apply the patch 2) Create an OPAC basket by clicking "Add to cart" on multiple items 3) Using Chrome, IE, and Firefox (of any version), click the "Print" button 4) You should see the relevant print menu without the OPAC basket re-loading in any way. 5) After printing is complete, you should still be on the OPAC basket pop-up 6) Perform the same tests in the staff client Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:11:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:11:13 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75665|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 76769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76769&action=edit Bug 16575: (follow-up) Compiled CSS This patch contains the compiled CSS for the OPAC print stylesheet. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:11:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:11:35 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Signed Off --- Comment #13 from Katrin Fischer --- I redid the second patch from scratch as it did no longer apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:16:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:16:25 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:16:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:16:29 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75549|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 76770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76770&action=edit Bug 20814: Display issue with 'Saved reports' tabs when memcached is off This patch changes the configuration of the saved reports table so that columns which were previously excluded from the table altogether are now hidden. This prevents a JavaScript error when DataTables tries to reference a missing column. To test, apply the patch and go to Reports -> Use saved. You should have at least one report category configured and assigned to reports in order for the tabs display to be visible. Test the table of saved reports under a variety of these circumstances: - memcached disabled or enabled - reports exist or don't exist which require update from the old marcxml syntax - cache_expiry and/or update columns are configured in Administration -> Columns settings to be shown or hidden The report category tabs and the table should render correctly under all circumstances. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:36:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:36:17 +0000 Subject: [Koha-bugs] [Bug 19938] C4::Overdues::checkoverdues has inconsistent return type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #28 from Katrin Fischer --- Sorry, don't see the noise. Can you pleas recheck and amend test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:37:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:37:53 +0000 Subject: [Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:37:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:37:56 +0000 Subject: [Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76140|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 76771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76771&action=edit Bug 20698 - Remove obsolete template: transfer-slip.tt This patch removes an unused template file, circ/transfer-slip.tt. Its use was removed by Bug 7001: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9ded4fa008668df8c485fbbc76efa3cc9cc00d7#patch12 To test, apply the patch and confirm that the file has been removed. Confirm that no references to the template exist in the codebase. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:41:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:41:07 +0000 Subject: [Koha-bugs] [Bug 10442] Remove references to non-standard "error" class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Katrin Fischer --- Patch doesn't apply, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:45:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:45:45 +0000 Subject: [Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:45:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:45:48 +0000 Subject: [Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75487|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 76772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76772&action=edit Bug 20805: Update child to adult patron process broken on several patron-related pages This patch fixes a problem with several patron-related pages, where the "Update child to adult patron" menu item doesn't work. With some pages, the right category information wasn't being passed from the script to the template. With some, the right JavaScript variable weren't being passed from the template to the included JavaScript file. To test, apply the patch locate some patrons with "child" type patron categories. With each patron, go to one of the following pages and test the "update child" process in the toolbar's "More" menu. - Circulation -> - Batch check out - Notices - Statistics - Files - Housebound - Delete (test from the deletion confirmation screen). All test should be performed on a system with multiple adult patron categories configured AND on a system with only a single adult patron category. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:47:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:47:29 +0000 Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76643|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 76773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76773&action=edit Bug 20949: Koha depends on Clone Clone was not declared a dependency before. It used to be a dependency of Hash::Merge but isn't in the recent version. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:47:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:47:33 +0000 Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76644|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 76774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76774&action=edit Bug 20949: Followup: debian/control Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 18:47:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 16:47:52 +0000 Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 19:17:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 17:17:26 +0000 Subject: [Koha-bugs] [Bug 20656] Print summary for patron shows paid fines and formats payments badly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I think I like the new display better. As it's supposed to be a summary displaying only open credits and fines makes sense to me, but the heading should then be changed to match the new display. Signing, but waiting for follow-up and maybe another opinion here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 19:17:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 17:17:52 +0000 Subject: [Koha-bugs] [Bug 20656] Print summary for patron shows paid fines and formats payments badly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74829|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 76775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76775&action=edit Bug 20656: Don't print lines that have no balance on print summary To test: 1 - Add at least two fines to a patron 2 - Pay off one of them 3 - Print summary - all 3 lines show 4 - Apply patch 5 - Print summary - only line with balance shows Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 19:17:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 17:17:55 +0000 Subject: [Koha-bugs] [Bug 20656] Print summary for patron shows paid fines and formats payments badly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74830|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 76776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76776&action=edit Bug 20656: Better formatting for print summary This patch is a slightly edited c&p from boraccount.tt 1 - Manually add a credit with no notes to patron 2 - Print summary 3 - Inspect the line 4 - Note that td has extra newlines and no words 5 - Apply patch 6 - Print summary again 7 - Note better formatting Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 19:21:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 17:21:58 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I think ultimately we should do something more clever here, like checking if the orders have all been received or cancelled before complaining. But this is a bug fix and as such perfect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 19:22:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 17:22:19 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 19:22:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 17:22:23 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76248|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 76777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76777&action=edit Bug 20979: Fix confirm deletion popup when deleting a biblio When deleting an empty bib, error messages pops up "1 order(s) are using this record. You need order managing permissions to delete this record." even though user has superlibrarian permissions. Prevents the deletion of the bib record. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 19:27:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 17:27:02 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 20:18:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 18:18:54 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com, | |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com, | |stephane.delaune at biblibre.c | |om --- Comment #4 from Katrin Fischer --- Need some reinforcements here, I think we are looking at a bigger issue. With and without the patch I don't get it to work with the -update option: $ ./bulkmarcimport.pl -b -file ../../data/Katrin-biblios.mrc -v -update Characteristic MARC flavour: MARC21 .DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`biblio_metadata`, CONSTRAINT `record_metadata_fk_1` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `biblio_metadata` ( `format`, `marcflavour`, `metadata`) VALUES ( ?, ?, ? )" with ParamValues: 0='marcxml', 1='MARC21', 2=" 00647cas a2200229 4500 012079189 DE-576 20180708032646.0 tu 860818cuuuuuuuuxx m 0ita c (OCoLC)72970470 (DE-599)BSZ012079189 DE-576 ger DE-576 line 1. Use of uninitialized value in sprintf at /home/vagrant/kohaclone/Koha/Exceptions/Exception.pm line 19, line 1. Invalid parameter passed, biblionumber= does not exist I've also tried using it with match: $ ./bulkmarcimport.pl -b -file ../../data/Katrin-biblios.mrc -v -match Control-number,001 -update The result is always the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 20:19:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 18:19:04 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 20:19:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 18:19:54 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #5 from Katrin Fischer --- Should add: tests were done on a freshly reset_all MARC21 database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 8 20:48:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jul 2018 18:48:19 +0000 Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #4 from Katrin Fischer --- Testing without items bulkmarcimport seems to mostly work (apart from the update option, see bug 20811). I also tested with a record exported from Koha with 3 items: /home/vagrant/kohaclone/misc$ ./stage_file.pl --match 3 --file ../data/bib-69.utf8 --item-action replace --add-items ... staging MARC records -- please wait ... finished staging MARC records ... looking for matches with records already in database Invalid normalization routine required (Biblionumber) at /home/vagrant/kohaclone/C4/Matcher.pm line 874. ... finished looking for matches MARC record staging report ------------------------------------ Input file: ../data/bib-69.utf8 Record type: biblio Number of input records: 1 Number of valid records: 1 Number of invalid records: 0 Number of records matched: 1 Number of items parsed: 3 Batch number assigned: 2 kohadev-koha at kohadevbox:/home/vagrant/kohaclone/misc$ ./commit_file.pl --batch-number 2 ... importing MARC records -- please wait ... finished importing MARC records MARC record import report ---------------------------------------- Batch number: 2 Number of new records added: 0 Number of records replaced: 1 Number of records ignored: 0 Number of items added: 0 Number of items replaced: 3 Number of items ignored: 0 Then I deleted the record and tried another import: ./stage_file.pl --match 3 --file ../data/bib-69.utf8 --item-action always_add --add-items ./commit_file.pl --batch-number 4 Record and items were added. Tested on master. I think we need more information to track this problem down. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 08:15:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 06:15:47 +0000 Subject: [Koha-bugs] [Bug 20745] indexing/searching not active at end of installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 08:30:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 06:30:05 +0000 Subject: [Koha-bugs] [Bug 20745] indexing/searching not active at end of installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 08:30:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 06:30:18 +0000 Subject: [Koha-bugs] [Bug 20745] indexing/searching not active at end of installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745 --- Comment #17 from Mason James --- (In reply to Tom?s Cohen Arazi from comment #13) > Added the 17.11 RMaint because the original patches got backported. Frido, just confirming this bug exists in 17.11.07 the patch fixes the bug :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 09:21:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 07:21:21 +0000 Subject: [Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 --- Comment #3 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #2) > Hi Marcel, > > I've tried testing this, but can't reproduce the errors. What exactly do you > mean by: > > Open a basket that contains no prices. > > ? > > I've tried closing and reopening a basket with one order line where I left > all entries empty, but that didn't do it. Closing an empty basket is not > possible, so I am a little lost here. Thanks for testing! Hmm. I couldn't reproduce on master too. A closer look reveals that older production data has NULL values in fields like tax_rate_on_ordering whereas you cannot create these NULL values anymore on a new record. I can imagine that other people might have some older acq data too and see the same warnings? In this case a dbrev replacing NULL by 0 would do the job too, but changing these two lines does not hurt? Will adjust the commit message to reflect these findings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 09:37:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 07:37:35 +0000 Subject: [Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76652|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 76778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76778&action=edit Bug 21033: Remove few warns in acqui/basket.pl Resolve (line numbers based on 16.11.x): Use of uninitialized value in hash element at acqui/basket.pl line 337. Use of uninitialized value in hash element at acqui/basket.pl line 338. Use of uninitialized value in hash element at acqui/basket.pl line 340. Use of uninitialized value in hash element at acqui/basket.pl line 342. Use of uninitialized value in hash element at acqui/basket.pl line 344. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 486. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 591. Test plan: If you have older acq data, you may have records in aqorders with field tax_rate_on_ordering is NULL. These orders will trigger the above warns. If you do not have, you could simulate by setting this field to NULL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 09:43:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 07:43:22 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #4 from Alex Arnaud --- (In reply to Katrin Fischer from comment #2) > I am not sure we should allow returning of a borrowernumber for an empty > cardnumber. This could lead to all kinds of problems. I feel we should > return an error for an empty cardnumber. It's quite common to have borrowers without cradnumber. Mostly when using third party import tools. So this leads to have dangerous behavior on portals that use Koha as back-end. Some patron get the loans, reserves and all information about an other one. > > What if 2 patrons pick the same password or are imported with the same > default password? Duplicate password doesn't matter here because we retrieve patrons with their userid (which is unique). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 10:06:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 08:06:40 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 --- Comment #13 from Alex Arnaud --- (In reply to Katrin Fischer from comment #12) > I don't have enough data to test this properly, but seems straight forward. > Alex, maybe you could have another look? I already had many looks. I'd like Nick to valid/sign Julian's patches and i could pass QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 10:57:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 08:57:04 +0000 Subject: [Koha-bugs] [Bug 21052] New: New patron card printer profile won't save if paper bin is empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052 Bug ID: 21052 Summary: New patron card printer profile won't save if paper bin is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When adding a new printer profile in the patron card creator tool, you can save without entering a paper bin, but it will not create a new entry in the database. There is no error, the field is not marked as required. To test: - Add a new printer profile - Fill in description, leave other fields unchanged - Save - Verify that the new printer profile doesn't appear in the list and hasn't been created -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 10:57:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 08:57:29 +0000 Subject: [Koha-bugs] [Bug 21052] New patron card printer profile won't save if paper bin is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |cnighswonger at foundations.ed | |u Component|Templates |Label/patron card printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 11:13:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 09:13:13 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #18 from Alex Arnaud --- (In reply to Katrin Fischer from comment #17) > What should be the next step here? I am bit lost in the discussion, has > consensus be reached or should we move this out of the queue for more > discussion? If i understand correctly, storing the entire record in all_fields_* would help us to hide some fields like nonpublicnote (Nick, another advantage?) by creating all_fields and all_fields_opac. But this could be done with a staff/opac parameter on ES configuration form like David did in bug 20589. I wrote this patch in order to make Koha compliant with ES 6. But if we remove this "feature", it is the same result. And the job is also done in bug 20589. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 11:30:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 09:30:10 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 11:30:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 09:30:14 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76690|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 76779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76779&action=edit Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image This patch corrects referential problems which caused the script to "re-use" images as well as other sorts of bad image behaviour. To test: 1. Ensure that you can reproduce the original bug or some variation thereof using the steps described in either of these two comments: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604#c0 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604#c6 NOTE: This is not an easy bug to reproduce. 2. Once you can reproduce the bug, apply this patch and follow the same steps used to reproduce the bug. 3. Observe that the symptoms are corrected. Signed-off-by: Chris Nighswonger Signed-off-by: Christian Stelzenm?ller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 11:40:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 09:40:55 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #5 from Katrin Fischer --- Ah, I think I've misread the test plan then! userid makes sense and can't be empty. Sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 11:49:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 09:49:26 +0000 Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 11:49:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 09:49:29 +0000 Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76763|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 76780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76780&action=edit Bug 21047: Remove koha to marc mapping on bibliosubtitle in SQL files SQL files in installer/data/mysql/ create frameworks with a koha to MARC mapping on obsolete table bibliosubtitle. This table was removed when upgrading from Koha 2.2 to 3.0. Test plan : 1) Create a new install with web installer 2) Check that creating a record is OK Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 11:50:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 09:50:12 +0000 Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 11:50:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 09:50:29 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #14 from Katrin Fischer --- (In reply to Alex Arnaud from comment #13) > (In reply to Katrin Fischer from comment #12) > > I don't have enough data to test this properly, but seems straight forward. > > Alex, maybe you could have another look? > > I already had many looks. I'd like Nick to valid/sign Julian's patches and i > could pass QA. Sounds like a plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 11:51:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 09:51:23 +0000 Subject: [Koha-bugs] [Bug 20745] indexing/searching not active at end of installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745 --- Comment #18 from Fridolin SOMERS --- (In reply to Mason James from comment #17) > (In reply to Tom?s Cohen Arazi from comment #13) > > Added the 17.11 RMaint because the original patches got backported. > > Frido, just confirming this bug exists in 17.11.07 > > the patch fixes the bug :) Ohhh thanks for this, I will backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 11:52:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 09:52:46 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #19 from Katrin Fischer --- > If i understand correctly, storing the entire record in all_fields_* would > help us to hide some fields like nonpublicnote (Nick, another advantage?) by > creating all_fields and all_fields_opac. But this could be done with a > staff/opac parameter on ES configuration form like David did in bug 20589. > > I wrote this patch in order to make Koha compliant with ES 6. But if we > remove this "feature", it is the same result. And the job is also done in > bug 20589. Which job does 20589? Resolving the ES6 issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:00:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:00:54 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75766|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 76781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76781&action=edit Bug 20819: DBIx schema changes No test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:00:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:00:58 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75767|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 76782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76782&action=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:01:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:01:08 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75819|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 76784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76784&action=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:01:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:01:12 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75820|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 76785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76785&action=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:01:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:01:03 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75818|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 76783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76783&action=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:02:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:02:32 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #13 from Marcel de Rooy --- Trivial rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:05:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:05:10 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #20 from Alex Arnaud --- (In reply to Katrin Fischer from comment #19) > > If i understand correctly, storing the entire record in all_fields_* would > > help us to hide some fields like nonpublicnote (Nick, another advantage?) by > > creating all_fields and all_fields_opac. But this could be done with a > > staff/opac parameter on ES configuration form like David did in bug 20589. > > > > I wrote this patch in order to make Koha compliant with ES 6. But if we > > remove this "feature", it is the same result. And the job is also done in > > bug 20589. > > Which job does 20589? Resolving the ES6 issue? Removing deprecated _all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:08:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:08:03 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 --- Comment #15 from Julian Maurice --- I wished Nick would review my patch to be sure that it doesn't go against his first patches. But I think this should not prevent the QA to be done. He can review the patches while pushing them ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:11:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:11:17 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 --- Comment #16 from Julian Maurice --- (In reply to Katrin Fischer from comment #12) > I don't have enough data to test this properly, but seems straight forward. > Alex, maybe you could have another look? If you want, here is a tiny script to generate thousands of new biblio: https://nopaste.xyz/?6a713982d73e1ab2#44I4RKe2ynghhda8Gp48a9f3bQSXjWbPUoeawx1Npqc= (You may want to change the title field for MARC21) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:23:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:23:11 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #21 from Katrin Fischer --- Trying to unravel these Elasticsearch patches gives me a headache. ;) What would be your "next steps" - should we drop this patch in favour of 20589? So in order to 'unlock' bug 20589 we'd have to qa bug 18316, correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:34:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:34:44 +0000 Subject: [Koha-bugs] [Bug 20745] indexing/searching not active at end of installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:35:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:35:31 +0000 Subject: [Koha-bugs] [Bug 20745] indexing/searching not active at end of installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #20 from Fridolin SOMERS --- Depends on Bug 20234 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:50:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:50:41 +0000 Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #5 from Ian Bays --- For the bulkmarcimport error: install is a "standard install" at version 17.11.04.000 Command line used: ~/kohaclone/misc/migration_tools/bulkmarcimport.pl -file Results/$x.mrc -v > Logs/$x.txt Repeating error is: ERROR: Adding items to bib 4026 failed: Undefined subroutine &C4::Items::TransformMarcToKoha called at /usr/share/koha/lib/C4/Items.pm line 379, line 4026. Koha About information: Koha version: 17.11.04.000 OS version ('uname -a'): Linux ncol.dh.bytemark.co.uk 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 Perl interpreter: /usr/bin/perl Perl version: 5.024001 Perl @INC: /usr/share/koha/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base MySQL version: mysql Ver 15.1 Distrib 10.1.26-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 12:59:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 10:59:35 +0000 Subject: [Koha-bugs] [Bug 21053] New: editing 008 field with a hash overwrites data Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053 Bug ID: 21053 Summary: editing 008 field with a hash overwrites data Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: bernard.scaife at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 76786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76786&action=edit 008 screenshots Entering a hash (#) at any position in 008 field of a bib record causes all subsequent data in field to be overwritten with default values when record is saved. To reproduce: 1. Find and edit a bib record which has an 008 which differs from the default values for the MARC framework 2. Choose 008 helper 3. Add # in any position before the end of the field noting the current values of the data 4. Save record 5. Edit record and select 008 helper 6. Review characters after # and note changes See attached example screenshots -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:03:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:03:02 +0000 Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #6 from Ian Bays --- The commit error was on the same system at the same version with the commit line described earlier. If it helps the stage command used was: /usr/share/koha/bin/stage_file.pl --file Results/ncol_bib.mrc --match 1 --add-items --item-action always_add --no-replace where match 1 is match on ISBN and aggressive ISBN matching is turned on. PERL5LIB is: echo $PERL5LIB /usr/share/koha/lib -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:03:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:03:57 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #14 from Nicolas Legrand --- Have you tried sort 'None'?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:05:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:05:37 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Won't this be a breaking change for anyone currently using ILS-DI that doesn't have cardnumber and userid set to the same thing? Would it be better to try cardnumber and fall back to userid, and simply not allow either to be an empty field? That would make it behave like the rest of Koha's login functionality, while minimizing breakages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:12:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:12:12 +0000 Subject: [Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 --- Comment #4 from Kyle M Hall --- (In reply to Katrin Fischer from comment #3) > Just noticed, there is a typo in the author line: > Kyle M Hall > watet instead of water Thanks for the catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:12:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:12:51 +0000 Subject: [Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75015|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 76787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76787&action=edit Bug 19383: Add ability to print hold receipts automatically -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:13:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:13:07 +0000 Subject: [Koha-bugs] [Bug 19383] Add ability to print hold receipts automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76787|application/mbox |text/plain mime type| | Attachment #76787|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:51:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:51:08 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #15 from Katrin Fischer --- I was doing a 'standard' search in authorities search, without changing any settings. What do you mean by none? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:51:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:51:49 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 --- Comment #18 from Nick Clemens --- Created attachment 76789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76789&action=edit Bug 19502: (follow-up) Pass parameters to avoid making templates depend on search engine https://bugs.koha-community.org/show_bug.cgi?id=19502 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:51:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:51:46 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73024|0 |1 is obsolete| | Attachment #74587|0 |1 is obsolete| | Attachment #75816|0 |1 is obsolete| | Attachment #76371|0 |1 is obsolete| | Attachment #76372|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 76788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76788&action=edit Bug 19502: Limit pagination to first 10000 results when using ES This patch is to avoid hitting an error page. We should eventually make the max number returned configurable for ES. To test: 1 - Have Koha running ES with 10,000+ records 2 - Search for '*' 3 - Click 'Last' to view last page of results 4 - 'Cannot perform search' error 5 - Apply patch 6 - Search again 7 - View 'Last' page 8 - No error, you go to the last of 10000 9 - Note the warning above the pagination buttons Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:51:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:51:53 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 --- Comment #19 from Nick Clemens --- Created attachment 76790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76790&action=edit Bug 19502: Retrieve index.max_result_window from ES This avoid hardcoding '10000' in two different places and allow users to adjust this setting. Also, this patch fixes a bug when the search return less than 10000 results Test plan: 1. Do a search that returns 10000+ records. 2. Note the warning above the pagination buttons 3. Go to the last page, no error 4. Change the ES setting: curl -XPUT http://elasticsearch/koha_master_biblios/_settings -d \ '{"index": {"max_result_window": 20000}}' 5. Do another search that returns more than 10000 but less than 20000 6. Note that the warning does not show up 7. Go to the last page, still no error Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:51:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:51:56 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 --- Comment #20 from Nick Clemens --- Created attachment 76791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76791&action=edit Bug 19502: Remove debug warn Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 13:52:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 11:52:00 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 --- Comment #21 from Nick Clemens --- Created attachment 76792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76792&action=edit Bug 19502: Add POD for max_result_window Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 14:11:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 12:11:19 +0000 Subject: [Koha-bugs] [Bug 20559] Occurrences of loading-small.gif still exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #10) > (In reply to Fridolin SOMERS from comment #9) > > Patch "Compiled CSS" does not apply on 17.11.x. > > You should only apply the first one then regenerate the .css > > > Sorry I have never used this compilation. > > There is a wiki page, search for "lessc" > > > Must I run it or do we not back-port such patches ? > > You are the Rmaint ;) > IMO it's "just" a loading icon, not really important. Ok thanks a lot. I prefer to skip this time since its minor. Not pushed to 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 14:14:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 12:14:54 +0000 Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 --- Comment #9 from Fridolin SOMERS --- (In reply to Nick Clemens from comment #8) > Can we attempt to deal with the discharges that may have been created and > cannot be removed by staff? Can you provide an update statement Frido? Seems hard, I'd say just add a warning text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 14:56:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 12:56:43 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #14 from Jon Knight --- Do we need to keep a copy of the template in use during the consent in the database along with the borrower ID and date? The UK ICO page on consenting seems to say we do: https://ico.org.uk/for-organisations/guide-to-the-general-data-protection-regulation-gdpr/consent/how-should-we-obtain-record-and-manage-consent/ (second example). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:00:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:00:42 +0000 Subject: [Koha-bugs] [Bug 19688] OpacHiddenItems itype problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19688 DEVINIM changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:15:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:15:49 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #7 from Alex Arnaud --- (In reply to Kyle M Hall from comment #6) > Won't this be a breaking change for anyone currently using ILS-DI that > doesn't have cardnumber and userid set to the same thing? Would it be better > to try cardnumber and fall back to userid, and simply not allow either to be > an empty field? That would make it behave like the rest of Koha's login > functionality, while minimizing breakages. Not sure to understand how it could be broken. For me this patch make sense even though i didn't find a bug. We pass a userid to the function, so we retrieve the patron with the userid. It is unique, and it has been authenticated by checkpw just before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:24:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:24:34 +0000 Subject: [Koha-bugs] [Bug 21054] New: Extra closing body tag in sco-main.tt prevents slip printing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 Bug ID: 21054 Summary: Extra closing body tag in sco-main.tt prevents slip printing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 16732 added an extra closing body tag to sco-main.tt Bug 18387 notes that page errors kick the SCO user out. The extra body tag creates an html error and prevents receipt printing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:26:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:26:46 +0000 Subject: [Koha-bugs] [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |16732 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:26:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:26:48 +0000 Subject: [Koha-bugs] [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 --- Comment #1 from Nick Clemens --- Created attachment 76793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76793&action=edit Bug 21054: Remove extraneous tag from sco-main.tt To test: 1 - Enable sco and setup AutoSelfCheck 2 - Try to use self checkout and print receipt 3 - You shoudl be redirected to the login page 4 - Apply patch and restart all the things 5 - Try to use self checkout and print a receipt 6 - Success! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:26:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:26:46 +0000 Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21054 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:31:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:31:55 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76788|0 |1 is obsolete| | --- Comment #22 from Alex Arnaud --- Created attachment 76794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76794&action=edit Bug 19502: Limit pagination to first 10000 results when using ES This patch is to avoid hitting an error page. We should eventually make the max number returned configurable for ES. To test: 1 - Have Koha running ES with 10,000+ records 2 - Search for '*' 3 - Click 'Last' to view last page of results 4 - 'Cannot perform search' error 5 - Apply patch 6 - Search again 7 - View 'Last' page 8 - No error, you go to the last of 10000 9 - Note the warning above the pagination buttons Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:32:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:32:04 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76789|0 |1 is obsolete| | --- Comment #23 from Alex Arnaud --- Created attachment 76795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76795&action=edit Bug 19502: (follow-up) Pass parameters to avoid making templates depend on search engine https://bugs.koha-community.org/show_bug.cgi?id=19502 Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:32:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:32:16 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76790|0 |1 is obsolete| | --- Comment #24 from Alex Arnaud --- Created attachment 76796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76796&action=edit Bug 19502: Retrieve index.max_result_window from ES This avoid hardcoding '10000' in two different places and allow users to adjust this setting. Also, this patch fixes a bug when the search return less than 10000 results Test plan: 1. Do a search that returns 10000+ records. 2. Note the warning above the pagination buttons 3. Go to the last page, no error 4. Change the ES setting: curl -XPUT http://elasticsearch/koha_master_biblios/_settings -d \ '{"index": {"max_result_window": 20000}}' 5. Do another search that returns more than 10000 but less than 20000 6. Note that the warning does not show up 7. Go to the last page, still no error Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:32:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:32:20 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:32:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:32:23 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #6 from Nick Clemens --- Created attachment 76797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76797&action=edit Bug 18387: Allow sco-user to access errors templates To test: 1 - Enable AuthoSelfCheck prefs 2 - In opacuserjs or scouserjs add a fetch of an unreachable resources 3 - Visit the SCO 4 - Sign in as a patron then click 'finish' 5 - Say 'yes' to receipt 6 - Note you are directed to log in 7 - Apply patch 8 - Restart all the things 9 - Repeat 4 & 5 10 - Sucess, receipt prints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:32:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:32:27 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76791|0 |1 is obsolete| | --- Comment #25 from Alex Arnaud --- Created attachment 76798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76798&action=edit Bug 19502: Remove debug warn Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:32:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:32:38 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76792|0 |1 is obsolete| | --- Comment #26 from Alex Arnaud --- Created attachment 76799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76799&action=edit Bug 19502: Add POD for max_result_window Signed-off-by: Nick Clemens Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:34:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:34:32 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:37:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:37:44 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #22 from Nick Clemens --- (In reply to Katrin Fischer from comment #21) > What would be your "next steps" - should we drop this patch in favour of > 20589? If Alex agrees then yes, we should take David's approach > So in order to 'unlock' bug 20589 we'd have to qa bug 18316, correct? Yes, please :-) It looks like it had passed QA and was failed by Joubu on RM review, perhaps he could take a second look now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 15:50:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 13:50:41 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #23 from Alex Arnaud --- (In reply to Katrin Fischer from comment #21) > Trying to unravel these Elasticsearch patches gives me a headache. ;) > > What would be your "next steps" - should we drop this patch in favour of > 20589? Yes! I'm ok for giving up on this one and working on bug 20589. > > So in order to 'unlock' bug 20589 we'd have to qa bug 18316, correct? I think since David took part on bug 18316 (boosting feature), he should provide a new patch on 20589 without boosting (the 2 patch conflicts). On 20589, we need: removing deprecated _all + staff/opac options for a field David, are you ok? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 16:01:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 14:01:06 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #16 from Nicolas Legrand --- Ther(In reply to Katrin Fischer from comment #15) > I was doing a 'standard' search in authorities search, without changing any > settings. What do you mean by none? there is a sort menu after the input field which can be set to 'Heading A-Z', 'Heading Z-A' or 'None'. I remember Nick once told me it wasn't working well. Plus there is some 'sort' trouble in your log so I thought about this, but maybe it is not relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 16:25:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 14:25:40 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #8 from Kyle M Hall --- (In reply to Alex Arnaud from comment #7) > (In reply to Kyle M Hall from comment #6) > > Won't this be a breaking change for anyone currently using ILS-DI that > > doesn't have cardnumber and userid set to the same thing? Would it be better > > to try cardnumber and fall back to userid, and simply not allow either to be > > an empty field? That would make it behave like the rest of Koha's login > > functionality, while minimizing breakages. > > Not sure to understand how it could be broken. For me this patch make sense > even though i didn't find a bug. We pass a userid to the function, so we > retrieve the patron with the userid. It is unique, and it has been > authenticated by checkpw just before. Never mind me, I am a dummy. I should have read the patch more closely. I blame mornings ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 16:43:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 14:43:29 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #24 from David Gustafsson --- Yes, exactly. :) Waiting for bug_18316 to be merged, and will then refactor and rebase this patch upon the master with 18316 included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 16:44:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 14:44:15 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #25 from David Gustafsson --- bug 18316 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 18:50:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 16:50:04 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #3 from Kyle M Hall --- (In reply to Liz Rea from comment #2) > Is this work in progress or are other solutions to this acceptable. If you have thoughts or plans I'd love to hear them! As far as I'm aware, we haven't put pen to paper yet :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 19:01:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 17:01:04 +0000 Subject: [Koha-bugs] [Bug 21055] New: Add columns to statitics that can be mapped to patron information by the library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21055 Bug ID: 21055 Summary: Add columns to statitics that can be mapped to patron information by the library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org With the need for better patron privacy it would be nice if the borrowernumber could be removed from statistics without losing the ability to get meaningful statistics. We already discussed adding age, patron category and other information, but it might also be interesting to have 2 or more columsn that can be mapped to patron data and patron attributes by the library as we can't tell where classes, departments or other statistically relevant data might be stored. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 19:05:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 17:05:57 +0000 Subject: [Koha-bugs] [Bug 20978] Add Koha::Account::add_credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #29 from Martin Renvoize --- Awesome to see the code cleanup going on here! Not backporting to 18.05.x series at the moment as it's an enhancement/refactoring piece. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 19:05:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 17:05:58 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 20978, which changed state. Bug 20978 Summary: Add Koha::Account::add_credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 19:05:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 17:05:59 +0000 Subject: [Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Bug 20944 depends on bug 20978, which changed state. Bug 20978 Summary: Add Koha::Account::add_credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 19:05:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 17:05:59 +0000 Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Bug 20980 depends on bug 20978, which changed state. Bug 20978 Summary: Add Koha::Account::add_credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 19:05:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 17:05:59 +0000 Subject: [Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Bug 20997 depends on bug 20978, which changed state. Bug 20978 Summary: Add Koha::Account::add_credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 19:06:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 17:06:00 +0000 Subject: [Koha-bugs] [Bug 21002] Add Koha::Account::add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Bug 21002 depends on bug 20978, which changed state. Bug 20978 Summary: Add Koha::Account::add_credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 20:02:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 18:02:12 +0000 Subject: [Koha-bugs] [Bug 20683] Update German web installer for 18.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20683 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #3 from Mirko Tietgen --- (In reply to Katrin Fischer from comment #2) > Someone, please? Will do. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 20:04:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 18:04:53 +0000 Subject: [Koha-bugs] [Bug 21056] New: Changing the logged in library can fail sporadically Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 Bug ID: 21056 Summary: Changing the logged in library can fail sporadically Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We are getting reports that sometimes changing the logged in library via selectbranchprinter.pl sometimes appears to fail. Flushing the session after updating the branch appears to fix this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 20:07:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 18:07:12 +0000 Subject: [Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 20:07:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 18:07:17 +0000 Subject: [Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 20:07:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 18:07:56 +0000 Subject: [Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 --- Comment #1 from Kyle M Hall --- Created attachment 76800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76800&action=edit [tag] [reply] [?] Private Description Kyle M Hall 2018-07-09 18:04:53 UTC We are getting reports that sometimes changing the logged in library via selectbranchprinter.pl sometimes appears to fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 20:08:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 18:08:29 +0000 Subject: [Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76800|[tag] [reply] [?] Private |Patch description|Description Kyle M Hall | |2018-07-09 18:04:53 UTC We | |are getting reports that | |sometimes changing the | |logged in library via | |selectbranchprinter.pl | |sometimes appears to fail | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 20:29:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 18:29:36 +0000 Subject: [Koha-bugs] [Bug 21055] Add columns to statistics table that can be mapped to patron information by the library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21055 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add columns to statitics |Add columns to statistics |that can be mapped to |table that can be mapped to |patron information by the |patron information by the |library |library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 20:33:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 18:33:52 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 --- Comment #27 from Katrin Fischer --- yay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 20:45:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 18:45:54 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #17 from Katrin Fischer --- Hi Nicolas, thx! 'None' works. Is there a bug already about the broken sorting for authorities with Elasticsearch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 9 22:01:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jul 2018 20:01:54 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #9 from Katrin Fischer --- Kyle, you or me for sign-off now? ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 02:25:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 00:25:44 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #43 from Nightly Build Bot --- Created attachment 76801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76801&action=edit Bug 17111 - Automatic debian/control updates (oldstable/17.11.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 06:38:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 04:38:15 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 --- Comment #26 from Aleisha Amohia --- Created attachment 76802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76802&action=edit Bug 12759: [FOLLOW-UP] Using tabs for diff ways of adding records This patch includes the changes for both batch record modification and deletion. Checks that all public lists are included and only private lists created by the logged in user. Hides the virtualshelves option if authorities are selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 06:38:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 04:38:11 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 06:40:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 04:40:39 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76802|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia --- Created attachment 76803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76803&action=edit Bug 12759: [FOLLOW-UP] Using tabs for diff ways of adding records This patch includes the changes for both batch record modification and deletion. Checks that all public lists are included and only private lists created by the logged in user. Hides the virtualshelves option if authorities are selected. Doesn't show shelf option at all if none exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 08:35:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 06:35:22 +0000 Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when using SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 08:36:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 06:36:58 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 08:43:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 06:43:05 +0000 Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #22 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 08:54:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 06:54:24 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/17.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76801|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 08:54:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 06:54:26 +0000 Subject: [Koha-bugs] [Bug 20703] Add ability to void any credit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Martin Renvoize --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 08:56:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 06:56:10 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 08:57:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 06:57:28 +0000 Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 08:59:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 06:59:34 +0000 Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug 12509 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 09:01:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 07:01:15 +0000 Subject: [Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26 (April 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02, although it's marked as an enhancement I believe librarians would see it as a bug that we don't reflect the current MARC21 recommendations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 09:01:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 07:01:20 +0000 Subject: [Koha-bugs] [Bug 20710] Update MARC21 frameworks to Update 26 (April 2018) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20710 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 09:02:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 07:02:32 +0000 Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #12 from Martin Renvoize --- Enhancement, not backporting to the 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 09:02:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 07:02:38 +0000 Subject: [Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 09:56:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 07:56:57 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #26 from Alex Arnaud --- (In reply to David Gustafsson from comment #24) > Yes, exactly. :) Waiting for bug_18316 to be merged, and will then refactor > and rebase this patch upon the master with 18316 included. You can build bug 20589 upon 18316 and make it depend on it without waiting for it to be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:18:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:18:34 +0000 Subject: [Koha-bugs] [Bug 20024] Backup files should be encrypted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20024 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #2 from Mirko Tietgen --- If there is an elegant way to do that, I'm not opposed to somebody providing a patch. I don't see how this would work in an automated process. I guess there would be a passphrase and/or key file on the same server. Not to speak of the actual Koha installation and database running on that server. If somebody has access to the server, they don't need the backup files to access personal data? Everything that happens afterwards (transferring backups to a different server etc.) is a custom workflow anyway, sysadmins could apply encryption during that process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:19:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:19:01 +0000 Subject: [Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #25 from Martin Renvoize --- I've decided not to backport this one to the 18.05.x series. Although it's a nasty bug, it's been around a long time and I feel it appropriate to wait for 18.11 release, giving people time to prepare for the resulting internal api changes this patch, and it's dependencies, bring. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:19:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:19:01 +0000 Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Bug 20990 depends on bug 20980, which changed state. Bug 20980 Summary: Manual credit offsets are stored as debits https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:22:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:22:49 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug 17858 depends on bug 20731, which changed state. Bug 20731 Summary: Move template JavaScript to the footer: Call number browser MARC plugin https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:22:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:22:48 +0000 Subject: [Koha-bugs] [Bug 20731] Move template JavaScript to the footer: Call number browser MARC plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Enhancement, not backporting to 18.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:23:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:23:36 +0000 Subject: [Koha-bugs] [Bug 20667] Update two-column templates with Bootstrap grid: Acquisitions part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #9 from Martin Renvoize --- I love this update :) Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:23:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:23:36 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 20667, which changed state. Bug 20667 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:23:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:23:37 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 20667, which changed state. Bug 20667 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:55 +0000 Subject: [Koha-bugs] [Bug 20668] Update two-column templates with Bootstrap grid: Acquisitions part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:55 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:56 +0000 Subject: [Koha-bugs] [Bug 20672] Update two-column templates with Bootstrap grid: Acquisitions part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20672 Bug 20672 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:56 +0000 Subject: [Koha-bugs] [Bug 20738] Update two-column templates with Bootstrap grid: Administration part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20738 Bug 20738 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:56 +0000 Subject: [Koha-bugs] [Bug 20690] Update two-column templates with Bootstrap grid: Acquisitions part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20690 Bug 20690 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:56 +0000 Subject: [Koha-bugs] [Bug 20736] Update two-column templates with Bootstrap grid: Administration part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20736 Bug 20736 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:56 +0000 Subject: [Koha-bugs] [Bug 20740] Update two-column templates with Bootstrap grid: Administration part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Bug 20740 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:56 +0000 Subject: [Koha-bugs] [Bug 20739] Update two-column templates with Bootstrap grid: Administration part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20739 Bug 20739 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:56 +0000 Subject: [Koha-bugs] [Bug 20741] Update two-column templates with Bootstrap grid: Administration part 5 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20741 Bug 20741 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:57 +0000 Subject: [Koha-bugs] [Bug 20742] Update two-column templates with Bootstrap grid: Administration part 6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20742 Bug 20742 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:57 +0000 Subject: [Koha-bugs] [Bug 20743] Update two-column templates with Bootstrap grid: Administration part 7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20743 Bug 20743 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:24:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:24:55 +0000 Subject: [Koha-bugs] [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 Bug 20654 depends on bug 20668, which changed state. Bug 20668 Summary: Update two-column templates with Bootstrap grid: Acquisitions part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:25:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:25:32 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #20 from Martin Renvoize --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:25:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:25:33 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug 17858 depends on bug 19709, which changed state. Bug 19709 Summary: Move template JavaScript to the footer: Labels https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:25:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:25:33 +0000 Subject: [Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641 Bug 20641 depends on bug 19709, which changed state. Bug 19709 Summary: Move template JavaScript to the footer: Labels https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:26:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:26:56 +0000 Subject: [Koha-bugs] [Bug 20220] Move template JavaScript to the footer: Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Martin Renvoize --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:26:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:26:57 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug 17858 depends on bug 20220, which changed state. Bug 20220 Summary: Move template JavaScript to the footer: Holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:27:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:27:25 +0000 Subject: [Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #7 from Martin Renvoize --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:27:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:27:25 +0000 Subject: [Koha-bugs] [Bug 6647] Label item search should use standard pagination routine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Bug 6647 depends on bug 20641, which changed state. Bug 20641 Summary: Switch single-column templates to Bootstrap grid: Various, part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:27:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:27:26 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Bug 19980 depends on bug 20641, which changed state. Bug 20641 Summary: Switch single-column templates to Bootstrap grid: Various, part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:28:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:28:04 +0000 Subject: [Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Martin Renvoize --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:28:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:28:04 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Bug 19980 depends on bug 20650, which changed state. Bug 20650 Summary: Switch single-column templates to Bootstrap grid: Various, part 3 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:29:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:29:05 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #145 from Martin Renvoize --- Nice enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:29:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:29:55 +0000 Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #12 from Martin Renvoize --- Enhancement, not backporting to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:34:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:34:29 +0000 Subject: [Koha-bugs] [Bug 21057] New: Patrons visiting the library (Patrons visits records) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21057 Bug ID: 21057 Summary: Patrons visiting the library (Patrons visits records) Change sponsored?: --- Product: Koha Version: 18.05 Hardware: PC OS: Linux Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: abdullrahman.hegazy4 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 76804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76804&action=edit This is an image of actual working example in the library. This module stores the cardnumber of the patrons who visits the library building. * Its not a bug. * The module is already creadted and working, but i think it needs alot of enhancemnts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:42:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:42:32 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #18 from Nicolas Legrand --- (In reply to Katrin Fischer from comment #17) > Hi Nicolas, thx! 'None' works. Great! > Is there a bug already about the broken sorting for authorities with > Elasticsearch? I think it's Bug 19604. I cc Nick so he can confirm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:46:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:46:38 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 10:49:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 08:49:00 +0000 Subject: [Koha-bugs] [Bug 20024] Backup files should be encrypted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20024 --- Comment #3 from Mike --- It can be option (parameter) in backup cronjob. I thing that really relevant for cases when backups are tranfering on on other servers/storage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 11:01:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 09:01:20 +0000 Subject: [Koha-bugs] [Bug 20683] Update German web installer for 18.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20683 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75249|0 |1 is obsolete| | --- Comment #4 from Mirko Tietgen --- Created attachment 76805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76805&action=edit Bug 20683: Update German web installer for 18.05 Adds translations for 2 new notices CANCEL_HOLD_ON_LOST and CHECKOUT_NOTE. Some small changes to older notices to match them with the English templates. To test: - Install German - Run the web installer on an empty database - Make sure all files install correctly and there are no SQL errors - Check notices were loaded correctly Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 11:01:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 09:01:37 +0000 Subject: [Koha-bugs] [Bug 20683] Update German web installer for 18.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20683 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 12:20:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 10:20:21 +0000 Subject: [Koha-bugs] [Bug 19509] Show checkout status in item search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19509 SiobhanC changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |siobhancottam at gmail.com --- Comment #1 from SiobhanC --- Has there been any progress on this enhancement? The checked out/reserved/withdrawn/lost status (i.e. that which is used in the Holdings table of a title record) would be very useful in the item search results. This might be a duplicate of bug 17748? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 12:21:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 10:21:01 +0000 Subject: [Koha-bugs] [Bug 19509] Show checkout status in item search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19509 SiobhanC changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17748 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 12:21:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 10:21:01 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 SiobhanC changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19509 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 12:34:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 10:34:09 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #19 from Nick Clemens --- (In reply to Nicolas Legrand from comment #18) > (In reply to Katrin Fischer from comment #17) > > Hi Nicolas, thx! 'None' works. > > Great! > > > Is there a bug already about the broken sorting for authorities with > > Elasticsearch? > > I think it's Bug 19604. I cc Nick so he can confirm. I believe that is correct, 19604 will at least improve the sorting situation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 13:09:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 11:09:15 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #10 from Kyle M Hall --- Created attachment 76806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76806&action=edit Bug 21046: Return the correct borrowernumber when there is empty cardnumber(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 13:09:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 11:09:26 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76737|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 13:10:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 11:10:02 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 13:10:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 11:10:17 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 --- Comment #11 from Kyle M Hall --- (In reply to Katrin Fischer from comment #9) > Kyle, you or me for sign-off now? ;) You can qa ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 13:12:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 11:12:06 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |katrin.fischer at bsz-bw.de |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 13:19:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 11:19:01 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 13:19:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 11:19:56 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #27 from David Gustafsson --- Yes I could do that, but would still rather wait until bug 20589 is merged since that would mean not having to perform further rebasing/refactoring if more changes introduced in 20589. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 15:04:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 13:04:36 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- (In reply to Jonathan Druart from comment #9) > Then install plack :) The script in question does not run under plack. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 15:37:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 13:37:40 +0000 Subject: [Koha-bugs] [Bug 21057] Patrons visiting the library (Patrons visits records) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21057 Abdullrahman Hegazy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abdullrahman.hegazy4 at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 15:41:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 13:41:31 +0000 Subject: [Koha-bugs] [Bug 20896] Move Serial enumeration to the right of callnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896 Jana Doyle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdoyle at vt.edu --- Comment #2 from Jana Doyle --- Catalogers at Virginia Tech, especially those that work primarily with serials, are requesting this enhancement. Presently, their eyes must scan four columns to the right to find "the rest of" the call number. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 15:41:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 13:41:49 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens --- The issue seems to be the call to system(): tools/upload-cover-image.pl: 107 unless ( system( "unzip", $filename, '-d', $dirname ) == 0 ) { 108 $error = 'UZIPFAIL'; 109 } This prints the reults to STDOUT, that is where the ' inflating' that upsets apache comes from -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 15:49:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 13:49:55 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 15:49:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 13:49:59 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #12 from Nick Clemens --- Created attachment 76807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76807&action=edit Bug 20564: Don't use system to unzip files To test: 1 - Setup a zip file for patron images and cover images 2 - Test each tool 3 - Get a '500 error' after upload (note images do upload and attach) 4 - Apply patch 5 - Restart all the things 6 - Test agtain, uploads should complete and results display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 15:50:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 13:50:17 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 16:28:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 14:28:07 +0000 Subject: [Koha-bugs] [Bug 5594] Option to configure default sort order for items on bib records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594 Jana Doyle changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 CC| |jdoyle at vt.edu --- Comment #2 from Jana Doyle --- Agreed, Eric. Some of our serials have thousands of items, in multiple locations, and multiple copies. It is time consuming for staff to find items, check in new issues and do maintenance (withdraw or relocate items) in this environment. This enhancement is of high importance to us. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 17:51:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 15:51:12 +0000 Subject: [Koha-bugs] [Bug 19850] Enhance invoicing functionality for each line item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Advanced_Invoicin | |g_RFC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:13:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:13:42 +0000 Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:13:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:13:46 +0000 Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76409|0 |1 is obsolete| | Attachment #76410|0 |1 is obsolete| | Attachment #76411|0 |1 is obsolete| | Attachment #76412|0 |1 is obsolete| | Attachment #76641|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 76808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76808&action=edit Bug 20942: OpenAPI spec for /patrons/{patron_id}/account This patch adds the OpenAPI spec for the following paths: - /patrons/{patron_id}/account It also adds object definitions for: - balance - account line Account line is to be used on both /account/lines (when implemented) and for embeding the outstanding lines in the balance endpoint (/patrons/{patron_id}/account). Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:14:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:14:02 +0000 Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 --- Comment #13 from Kyle M Hall --- Created attachment 76809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76809&action=edit Bug 20942: Unit tests for /patrons/{patron_id}/account This patch adds tests for the /patrons/{patron_id}/account endpoint. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => FAIL: Tests should fail because the endpoint is not implemented. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:14:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:14:06 +0000 Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 --- Comment #14 from Kyle M Hall --- Created attachment 76810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76810&action=edit Bug 20942: Add route to get patron's account balance This patch implements the /patrons/{patron_id}/account endpoint. It can be used to get the patron's balance information, including outstanding lines. To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: tests pass! - Make your favourite REST testing tool (RESTer on Firefox?) do: GET /api/v1/patrons/{patron_id}/account to a valid patron_id. Play with Koha's UI to add credits/payments and notice the endpoint returns the right info following the voted RFC. [1] - Sign off :-D [1] https://wiki.koha-community.org/wiki/Patrons_account_lines_endpoint_RFC Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:14:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:14:10 +0000 Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 --- Comment #15 from Kyle M Hall --- Created attachment 76811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76811&action=edit Bug 20942: Split debit and credit lines This patch splits the balance to match this object schema: { balance => #, outstanding_credits => { total => #, lines => [ credit_line_1, ..., credit_line_n ] }, outstanding_debits => { total => #, lines => [ debit_line_1, ..., debit_line_m ] } } This change is made to ease usage from the UI. Also because the outstanding credits need to be applied to outstanding debits in order to the balance value to make sense. So we still need to have each total. Tests are added for this change, and the schema files are adjusted as well. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests pass! - Sign off :-D staff_id is changed into user_id as voted on the dev meeting the RFC got approved. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:14:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:14:14 +0000 Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 --- Comment #16 from Kyle M Hall --- Created attachment 76812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76812&action=edit Bug 20942: (QA follow-up) Use $lines->total_outstanding This patch makes the controller code use $lines->total_outstanding instead of expecting ->outstanding_debits and ->outstanding_credits return the total. Tests should pass as before. No behaviour change is expected. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests still pass, no behaviour change. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:42:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:42:49 +0000 Subject: [Koha-bugs] [Bug 21058] New: Missing class for results_summary spans Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Bug ID: 21058 Summary: Missing class for results_summary spans Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: david.bourgault at inlibro.com Reporter: david.bourgault at inlibro.com QA Contact: testopia at bugs.koha-community.org Some results_summary spans have other CSS class which can be annoying when doing CSS customization. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:44:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:44:29 +0000 Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #7 from Barton Chittenden --- (In reply to Fridolin SOMERS from comment #6) > Depends on Bug 17893 not in 17.11.x This *is* broken in 17.11.x, do we need a separate patch for that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:52:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:52:16 +0000 Subject: [Koha-bugs] [Bug 21058] Missing class for results_summary spans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 David Bourgault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:52:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:52:18 +0000 Subject: [Koha-bugs] [Bug 21058] Missing class for results_summary spans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 --- Comment #1 from David Bourgault --- Created attachment 76813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76813&action=edit Bug 21058: Added HTML classes in MARC21slim2_Detail.xsl This is a very small patch. I've simply added the following classes to their respective spans in the detail XSLs for both interfaces. - in_note (773$n) - preceeding_entry_note (780$n) - succeeding_entry_note (785$n) To test: 0. Apply patch 1. Open details page of notice with a 773$n, 780$n or 785$n field 2. Inspect element. The class should be visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:52:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:52:38 +0000 Subject: [Koha-bugs] [Bug 21058] Missing class for results_summary spans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 --- Comment #2 from David Bourgault --- Created attachment 76814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76814&action=edit Bug 21058: Added HTML class to showRDAtag264 Adds the HTML class "rda264" to the span generated by the XSLT function showRDAtag264. To test, same as previous, using a notice with a 264 tag. Both patches only apply to MARC21. I was unsure how to name the class, so I've chose the simplest, most explicit name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:58:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:58:44 +0000 Subject: [Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 76815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76815&action=edit Bug 20944: OpenAPI spec for /patrons/{patron_id}/account/credits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:58:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:58:49 +0000 Subject: [Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 76816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76816&action=edit Bug 20944: Add route to add credits to a patron's account This patch adds the /patrons/{patron_id}/account/credits endpoint, that can be used to add credits to a patron's account. It is implemented so the new credits are used to pay existing debts. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests pass! - Make your favourite REST testing tool (RESTer on Firefox?) do: POST /api/v1/patrons/{patron_id}/account/credits { "amount": 100 } - Play with other possible attributes on the credit object. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 19:59:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 17:59:09 +0000 Subject: [Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 10 23:46:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 21:46:41 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:21:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:21:50 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #137 from Alex Buckley --- Hi everyone on the CC list Just a heads up that you will be receiving a lot of emails while I obsolete and attach newly rebased patches onto this bug report. I have rebased the rebase patches against master (as of 11 July 2018). As we are already using recalls in production we have been able to identify several bugs in the recalls which had not been previously found, and I have written patches to fix these bugs which I am also attaching to this bug report: * Transfer recall modal always appears upon the return of a recalled item even if it is being returned to the library where it is to be picked up from. * When recall fields in the circulation rules are empty when a patron tries to confirm a recall on the OPAC an 'Internal Server Error' is thrown. i.e. There are no default values for the recall circ fields. * At present if recalls and course reserves are both enabled then if you try to view the opac-course-details.pl page for a course with a currently issued course reserve then an 'Internal Server Error' is thrown. The root cause of this is: Koha::Item->avail_for_recall does not have tests. avail_for_recall is used in the item-status.inc used by both opac-course-details.pl and opac-detail.pl and the error is caused by course reserves not handing back an avail_for_recall value as opac-detail.pl does. Hopefully with rebased recalls patches + new bug fix patches we can action this recalls feature along and get it into 18.11 release. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:22:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:22:37 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72311|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:23:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:23:08 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:22:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:22:54 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72312|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:23:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:23:24 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:23:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:23:36 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:23:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:23:49 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:24:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:24:14 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:24:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:24:27 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72319|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:24:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:24:01 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72317|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:24:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:24:38 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:24:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:24:50 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:25:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:25:06 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72322|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:25:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:25:19 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72323|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:25:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:25:46 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72325|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:25:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:25:32 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:26:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:26:10 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72326|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:26:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:26:25 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72327|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:26:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:26:38 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72328|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:27:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:27:02 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72330|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:27:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:27:16 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72331|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:26:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:26:50 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72329|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:27:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:27:31 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:27:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:27:43 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:27:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:27:55 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:28:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:28:07 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:28:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:28:20 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:28:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:28:35 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:28:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:28:47 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:31:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:31:55 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #138 from Alex Buckley --- Created attachment 76817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76817&action=edit Bug 19532: Database updates Adding the recalls table and the old_recalls table. Sponsored-by: Catalyst IT Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:32:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:32:51 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #139 from Alex Buckley --- Created attachment 76818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76818&action=edit Bug 19532: Module files for Recall and OldRecall Koha/Recall.pm Koha/Recalls.pm Koha/Old/Recall.pm Koha/Old/Recalls.pm and the schema files for Recall and OldRecall. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:33:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:33:48 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #140 from Alex Buckley --- Created attachment 76819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76819&action=edit Bug 19532: Some DB fixes Removing the old_recalls table, as suggested in Comment 5 Renaming 'found' column to 'status' Adding 'old' column Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:35:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:35:00 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #141 from Alex Buckley --- Created attachment 76820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76820&action=edit Bug 19532: Some module fixes Removing files related to OldRecall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:35:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:35:52 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #142 from Alex Buckley --- Created attachment 76821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76821&action=edit Bug 19532: Circulation rules Adding 3 new rules and columns to issuingrules - recall_due_date_interval - recall_overdue_fine - recall_shelf_time Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:36:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:36:43 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #143 from Alex Buckley --- Created attachment 76822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76822&action=edit Bug 19532: Recall an item in OPAC This patch: - adds the 'Recall' button to the item on it's detail page - adds ability to place a recall - the recall is stored in the recalls table - the due date for the checkout is updated to whatever has been set in the issuing rule under recall_due_date_interval - error messages for if the user isn't logged in, the user tries to place a recall on an item they have already recalled, or if storing the recall in the db fails for any reason Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:37:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:37:43 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #144 from Alex Buckley --- Created attachment 76823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76823&action=edit Bug 19532: Cancel recall and see recalls in OPAC This patch adds ability for user to cancel a recall They can also see their recalls in the user summary Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:38:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:38:51 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #145 from Alex Buckley --- Created attachment 76824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76824&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:40:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:40:02 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #146 from Alex Buckley --- Created attachment 76825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76825&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add
Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:41:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:41:10 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #147 from Alex Buckley --- Created attachment 76826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76826&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:42:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:42:31 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #148 from Alex Buckley --- Created attachment 76827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76827&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:43:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:43:35 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #149 from Alex Buckley --- Created attachment 76828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76828&action=edit Bug 19532: Overdue recalls report Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:44:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:44:56 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #150 from Alex Buckley --- Created attachment 76829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76829&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:46:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:46:44 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #151 from Alex Buckley --- Created attachment 76830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76830&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:48:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:48:50 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #152 from Alex Buckley --- Created attachment 76831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76831&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:49:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:49:54 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #153 from Alex Buckley --- Created attachment 76832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76832&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 00:51:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 22:51:39 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #154 from Alex Buckley --- Created attachment 76833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76833&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:15:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:15:20 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #155 from Alex Buckley --- Created attachment 76834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76834&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:16:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:16:52 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #156 from Alex Buckley --- Created attachment 76835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76835&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:18:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:18:12 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #157 from Alex Buckley --- Created attachment 76836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76836&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:19:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:19:36 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #158 from Alex Buckley --- Created attachment 76837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76837&action=edit Bug 19532: Tests for Koha/Recalls Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:20:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:20:46 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #159 from Alex Buckley --- Created attachment 76838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76838&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:21:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:21:55 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #160 from Alex Buckley --- Created attachment 76839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76839&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:22:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:22:54 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #161 from Alex Buckley --- Created attachment 76840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76840&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:23:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:23:49 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #162 from Alex Buckley --- Created attachment 76841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76841&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:25:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:25:07 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #163 from Alex Buckley --- Created attachment 76842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76842&action=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning:

Warning: Your library does not allow recalls for x item types.

Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls Signed-off-by: Nick Clemens Conflicts: Koha/Schema/Result/Borrower.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:26:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:26:29 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #164 from Alex Buckley --- Created attachment 76843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76843&action=edit Bug 19532 (follow-up) Update characterset for recalls table Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:32:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:32:43 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #165 from Alex Buckley --- Created attachment 76844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76844&action=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:34:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:34:06 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #166 from Alex Buckley --- Created attachment 76845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76845&action=edit Bug 19532 - Fixes to stop transfer recall modal from being displayed incorrectly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:35:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:35:57 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #167 from Alex Buckley --- Created attachment 76846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76846&action=edit Bug 19532 - Recalls for Course Reserves. This ptach fixes the 'Template process error Koha::Item->avail_for_recall' which is thrown when loading a Course pgae in opac-course-details.pl with course reserves which are currently issued. It also allows recalls to be placed from Course reserves Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:37:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:37:23 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #168 from Alex Buckley --- Created attachment 76847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76847&action=edit Bug 19532 - Fix for recall OPAC confirmation failing when recall circ rule is empty Sponsored-BY: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 01:42:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jul 2018 23:42:50 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #169 from Alex Buckley --- All of my rebased patches + additional fixes are attached now. I just double checked applying all of the patches on this bug report to master as of 11 July 2018 and they all apply correctly. I am setting this bug report to 'Needs signoff' to try and get it moving now it can be tested more easily as it applies on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:27:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:27:32 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64244|0 |1 is obsolete| | --- Comment #41 from Aleisha Amohia --- Created attachment 76848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76848&action=edit Bug 8630 - Adlibris covers (syspref files) This patch adds a system preference for cover images from Swedish book retailer Adlibris. Images are retrieved via http or https from an external web server. This might leak OPAC and Staff interface data to third parties and should thus be used with caution. Sponsored-By: Halland County Library Test plan: Test 1: Test upgrade procedure for clean installation. Start by removing existing sysprefs, if present: $ mysql -u kohaadmin -p -D koha > DELETE FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; * Apply this patch which will add a pref file, update the 'syspref' structure and add an atomic upgrade file. * Install the update: Koha$ perl installer/data/mysql/updatedatabase.pl * Once upgraded and logged in, Select 'More', 'Administration', 'Global Preferences' and finally 'Enhanced content'. There should be a new option called 'Adlibris'. The first option should default to "Don't show", if not the patch is broken. The second options should show the default URL: http://www.adlibris.com/se/organisationer/showimagesafe.aspx If not, the patch is broken. Test 2: Changing sysprefs * In the control panel, change the first value from "Don't show" to "Show" and save the changes. Use MySQL client to inspect changes: $ mysql -u kohaadmin -p -D koha > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; The column 'value' should now have the value '1', if not the patch is broken. Test 3: Apply update to existing data * Re-execute the installer now that the database has the data already: Koha$ perl installer/data/mysql/updatedatabase.pl If any errors occur the patch is broken. Examine the database contents: $ mysql -u kohaadmin -p -D koha > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; If the values were overwritten by the installer the patch is broken. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:27:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:27:43 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73126|0 |1 is obsolete| | --- Comment #43 from Aleisha Amohia --- Created attachment 76850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76850&action=edit Bug 8630 - Adlibris covers (intranet CSS) This defined two new CSS classes for use by the intranet templates. Apply this patch before doing the testing of "intranet templates". Sponsored-By: Halland County Library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:27:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:27:38 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73125|0 |1 is obsolete| | --- Comment #42 from Aleisha Amohia --- Created attachment 76849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76849&action=edit Bug 8630 - Adlibris covers (intranet templates) Changes to staff interface (intranet) templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test results.tt * From the main intranet page, select "Search the catalog" and enter the title we added, "1984" and press "Search". * You should end up with the url: http://127.0.1.1:8080/cgi-bin/koha/catalogue/search.pl?q=1984 * The cover image should be shown in the leftmost column. * If cover is clicked, the full cover image should be shown. * Test detail.tt (continue from the search results used in prev. test) * Click on the title text, you should be sent to: http://127.0.1.1:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 * The cover image should be shown on the right. * If clicked, the full cover should be shown. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:27:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:27:49 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73127|0 |1 is obsolete| | --- Comment #44 from Aleisha Amohia --- Created attachment 76851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76851&action=edit Bug 8630 - Adlibris covers (OPAC templates) Changes to OPAC templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test opac-results.tt * Search library catalog from OPAC for "1984". * You should be sent to: http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx=&q=1984 * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * Test opac-detail.tt (continued from previous test's location) * Click on the title with cover (1984, ISBN: 9780451524935) * Cover should be displayed to the left in full size. * If clicked, should link to the full-size image. Test opac-results-grouped.tt * This template is only used if an external "grouping" server is setup and the syspref "OPACGroupResults" is set to "Use". * Personally I did not test this, b/c: terminally lazy * Test opac-showreviews.tt * Could not find any links to this location, manually enter it: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl * Image should be shown to the right in full size. * If clicked it should take you to the detail view with the comments tab opened. * Test opac-showreviews-rss.tt * Click on the RSS icon from previous test's start location. URL should be: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl?format=rss * An image tag linking to the full-size image without any styling class should be present. * Test opac-user.tt * Click on your username to open: http://127.0.1.1/cgi-bin/koha/opac-user.pl * Covers should be shown for checked out items with CSS class: adlibris-cover * When clicked the destination should be the same as clicking the title column entry: opac-details.pl * Test opac-opensearch.tt * Click on "Advanced search" and enter "1984" then press "Search" * This search screen uses a different template. * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * If clicked, should link to the OPAC detail view. * Test opac-readingrecord.tt * Click on your logged-in name to go to your personal page. * Click on "Your reading history" tab on the left. http://127.0.1.1/cgi-bin/koha/opac-readingrecord.pl * Covers should be shown in leftmost column with CSS class: adlibris-cover * If clicked, should link to the same as the 'Title' link. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:27:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:27:55 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73128|0 |1 is obsolete| | --- Comment #45 from Aleisha Amohia --- Created attachment 76852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76852&action=edit Bug 8630 - Adlibris covers (OPAC less changes) This patch adds two new CSS classes specific to Adlibris covers. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:28:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:28:01 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #46 from Aleisha Amohia --- Created attachment 76853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76853&action=edit Bug 8630: [FOLLOW-UP] Make Adlibris cover show on OPAC overdues tab and fix alignment of cover on Staff detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:42:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:42:45 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |chris at bigballofwax.co.nz --- Comment #28 from Chris Cormack --- Work for this is being done on bug 20589 and bug 18316 Moving this out of signed off, to save peoples time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:45:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:45:21 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:45:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:45:26 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76806|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 76854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76854&action=edit Bug 21046: Return the correct borrowernumber when there is empty cardnumber(s) Test plan: - Use a patron with an empty cardnumber to authenticate with ILSDI AuthenticatePatron (cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=userid&password=pass), - make sure you have other patron(s) with empty cardnumber and there borrowernumber is smaller than the one you authenticate with, - you should get a wrong borrowernumber, - apply this patch, - test again, you should get the right one Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:50:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:50:31 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75587|0 |1 is obsolete| | --- Comment #19 from Chris Cormack --- Created attachment 76855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76855&action=edit Bug 18250: Update LSB block of koha-common init script Currently koha-common may start before memcached. We should prevent that. If we add memcached to the LSB section of the koha-common init script, Debian's insserv will know about this requirement. Note: This patch is only a step in resolving the issue. Test plan: [1] Copy the updated koha-common script to /etc/init.d [2] Look for S..koha-common and S..memcached in /etc/rcX.d (say X=5) [3] Run sudo update-rc.d koha-common disable [4] Run sudo update-rc.d koha-common enable [5] Look again for S..koha-common in /etc/rcX.d (say X=5). The number for koha-common should now be higher than for memcached. Signed-off-by: Mirko Tietgen Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:50:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:50:50 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:50:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:50:55 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75589|0 |1 is obsolete| | --- Comment #20 from Chris Cormack --- Created attachment 76856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76856&action=edit Bug 18250: Force startup order in postinst script This is a workaround meant to correct upgrading installs. We force the order by disable/enable. Test plan: [1] When upgrading an existing install, check that the startup order after the upgrade has been corrected in /etc/rcX.d (say X=5). Signed-off-by: Mirko Tietgen Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:59:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:59:54 +0000 Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:59:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:59:30 +0000 Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76773|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 76857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76857&action=edit Bug 20949: Koha depends on Clone Clone was not declared a dependency before. It used to be a dependency of Hash::Merge but isn't in the recent version. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 03:59:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 01:59:59 +0000 Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76774|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 76858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76858&action=edit Bug 20949: Followup: debian/control Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 04:05:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 02:05:53 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 04:05:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 02:05:59 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73129|0 |1 is obsolete| | --- Comment #47 from Aleisha Amohia --- Created attachment 76859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76859&action=edit Bug 8630: Regenerated minified OPAC CSS Regenerated minified OPAC CSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 04:07:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 02:07:13 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #48 from Aleisha Amohia --- Ready for testing. Use Test Plan in Comment 44 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 04:08:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 02:08:15 +0000 Subject: [Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 04:08:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 02:08:19 +0000 Subject: [Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76758|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 76860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76860&action=edit Bug 20332: Allow translating some grouped opac results texts The grouped OPAC results page has several untranslatable javascript-added texts, including the selection modifiers "Clear all" and "Select all" links, and the entries in the shelves/lists dropdown. Compare to opac-results.tt Signed-off-by: Pasi Kallinen Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:44:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:44:07 +0000 Subject: [Koha-bugs] [Bug 20683] Update German web installer for 18.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20683 --- Comment #5 from Katrin Fischer --- Thx, Mirko! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:45:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:45:52 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:46:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:46:12 +0000 Subject: [Koha-bugs] [Bug 17625] 245f and 245g are not displayed in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |joy at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:46:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:46:50 +0000 Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:47:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:47:21 +0000 Subject: [Koha-bugs] [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:47:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:47:35 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:47:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:47:55 +0000 Subject: [Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Nick, please don't forget to set the assignee on your bugs! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:48:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:48:49 +0000 Subject: [Koha-bugs] [Bug 21042] Pay amount does not mark lost items as returned when those accountlines are paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21042 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:50:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:50:41 +0000 Subject: [Koha-bugs] [Bug 19990] opac/opac-discharge.pl has a FIXME that can be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Katrin Fischer --- I think this is a duplicate of another bug in PQA (please reset if I am wrong: Bug 20953 - Discharge can be requested several times on OPAC >Patch reoganised the code so that the following FIXME is obsolete : > 'FIXME looks like $available is not needed' >Patch also replaces 'op' arg test to also check undef : input->param("op") // '' *** This bug has been marked as a duplicate of bug 20953 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:50:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:50:41 +0000 Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #10 from Katrin Fischer --- *** Bug 19990 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:51:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:51:29 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |larit at live.fi |ity.org | --- Comment #6 from Katrin Fischer --- Hi Lari, please set the assignee to yourself if you plan to work on a bug or are providing patches for it, thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:52:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:52:03 +0000 Subject: [Koha-bugs] [Bug 20986] MARC21 Supplement and Index Textual Holdings don't display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |joy at bywatersolutions.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:51:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:51:46 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |claire.hernandez at biblibre.c |ity.org |om CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:52:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:52:25 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:53:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:53:03 +0000 Subject: [Koha-bugs] [Bug 18480] Get rid of unwanted / distracting link in patron search for fund owner In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:53:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:53:16 +0000 Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:53:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:53:40 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | --- Comment #27 from Katrin Fischer --- Kyle, assigning this to you, ok? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:54:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:54:19 +0000 Subject: [Koha-bugs] [Bug 20435] Allow lowercase prefix in inventory value builder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:54:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:54:00 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andreas.jonsson at kreablo.se |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:54:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:54:40 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Who should this be assigned to? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:54:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:54:56 +0000 Subject: [Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:55:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:55:46 +0000 Subject: [Koha-bugs] [Bug 19962] Introduce koha-sip to replace koha-*-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pongtawat at punsarn.asia |ity.org | Version|17.11 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:56:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:56:04 +0000 Subject: [Koha-bugs] [Bug 19625] Shibboleth auto-provisioning is broken in plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 07:56:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 05:56:35 +0000 Subject: [Koha-bugs] [Bug 20595] EDI: Add support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20595 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 08:36:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 06:36:42 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|larit at live.fi |ere.maijala at helsinki.fi --- Comment #7 from Ere Maijala --- I'm afraid Lari might be unable to work on this, so I'm taking it for any further work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 09:18:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 07:18:32 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 14:32:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 12:32:25 +0000 Subject: [Koha-bugs] [Bug 19044] Add BDS integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19044 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 15:48:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 13:48:20 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Jonathan Druart --- > Invalid parameter passed, biblionumber= does not exist This sounds like another bug, I would prefer to discuss it on a separate bug report. Try without the --update flag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 15:53:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 13:53:45 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #7 from Katrin Fischer --- The ModBiblio call is inside the check for a set update flag... if ($update)... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 15:53:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 13:53:58 +0000 Subject: [Koha-bugs] [Bug 21007] Add new patron column for date of last successful login attempt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21007 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 15:54:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 13:54:49 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #8 from Jonathan Druart --- heh yes :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:11:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:11:45 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Bug 20979 depends on bug 20977, which changed state. Bug 20977 Summary: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:12:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:12:05 +0000 Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 --- Comment #8 from Fridolin SOMERS --- (In reply to Barton Chittenden from comment #7) > (In reply to Fridolin SOMERS from comment #6) > > Depends on Bug 17893 not in 17.11.x > > This *is* broken in 17.11.x, do we need a separate patch for that? Ok sorry, I will try to rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:11:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:11:44 +0000 Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:16:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:16:39 +0000 Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED Assignee|pasi.kallinen at joensuu.fi |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Ok I will provide a patch then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:18:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:18:24 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:18:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:18:29 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #9 from Jonathan Druart --- Created attachment 76861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76861&action=edit Bug 20811: Fix update flag in bulkmarcimport I have no idea why we have these two variables $id and $originalid, it seems that they should not cohabit. It feels like Users and original authors of this script should provide an update and refresh it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:20:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:20:20 +0000 Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:20:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:20:25 +0000 Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76090|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 76862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76862&action=edit Bug 20919: Remove unecessary search calls on the biblio detail page There is a countanalytics flag that is set for items used in analytical biblio records. This flag is only used in the template when 'analyze' has been passed to the script. In order to avoid unecessary search calls (1 per item), $analyse must be tested. Test plan: 0. Do not apply the patch 1. tail -f /var/log/koha/kohadev/zebra-output.log 2. Hit a bibliographic record detail page with several items 3. Notice that the log has 1 line per item: 11:30:36-14/06 zebrasrv(32) [warn] ir_session (exception) 4. Apply the patch 5. Hit the page again 6. There is nothing in the zebra log file If you are familiar with analytic records, confirm that you are not allowed to remove an item that is used in analytical biblio records. Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:30:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:30:34 +0000 Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #6 from Jonathan Druart --- Created attachment 76863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76863&action=edit Bug 21018: Allow uris defined in the item We need to search for uri defined for the itemnumber we passed in parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:32:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:32:39 +0000 Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > (In reply to Jonathan Druart from comment #3) > > Important note: We certainly need to add an index on this column to boost > > this query. > > Do you mean items.uri and deleteditems.uri? only items.uri, but with the last patch it's not needed. (In reply to Marcel de Rooy from comment #5) > (In reply to Jonathan Druart from comment #3) > > Important note: We certainly need to add an index on this column to boost > > this query. > > Koha::Items->search( { uri => $uri } )->count > > You need to add biblionumber to limit the results. No need to scan the whole > table. Oops, yes you are right. It's itemnumber actually. Maybe we should add more tests here, items.uri check should only be if itemnumber is passed. But I would prefer to not complexity it now as it's improvement and not bug fixing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:32:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:32:47 +0000 Subject: [Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:59:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:59:43 +0000 Subject: [Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 16:59:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 14:59:46 +0000 Subject: [Koha-bugs] [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66897|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 76864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76864&action=edit Bug 19263: Rancor - Add auto-001 widget To test: 1 - Define a new authorised valued category "CONTROL_NUM_SEQUENCE" 2 - Add a value/sequence The authorised_value is the starting value - shoudl end in a number that can be incremented e.g. "control_sequence_001" The description field is the name for the seqeuence Opac description is unused 3 - Edit a record in rancor 4 - Note the new widget and option to increment or assign manually -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 17:06:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 15:06:48 +0000 Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #9 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #6) > Depends on Bug 17893 not in 17.11.x Ahhhh my mistake, Bug 17893 is in 17.11.x. Patch pushed to 17.11.x for v17.11.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 17:07:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 15:07:19 +0000 Subject: [Koha-bugs] [Bug 20977] Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #10 from Fridolin SOMERS --- Depends on Bug 17893 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 17:07:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 15:07:20 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Bug 20979 depends on bug 20977, which changed state. Bug 20977 Summary: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 17:23:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 15:23:03 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Maybe we should consider backporting this or at least fixing kohastructure in the other branches. We ran into the problem updating an instance to 17.11 today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 17:23:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 15:23:39 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 --- Comment #9 from Katrin Fischer --- Also it came up on the mailing list a few times now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 17:25:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 15:25:29 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Keywords| |rel_17_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 17:26:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 15:26:31 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 17:27:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 15:27:08 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED Resolution|FIXED |REMIND -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 18:10:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 16:10:39 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #8 from Kyle M Hall --- (In reply to Katrin Fischer from comment #7) > Kyle, would you be ok to make this dependent on some patches in PQA when > rebasing? > > bug 11911 - new permission for managing suggestions > bug 7651 - new permission for managing currencies > > Both are adding new permissions. I am keen on resolving as many permission > bugs as possible this release and would be happy to help with this one to > have a better foundation. I'm a bit late replying, but yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 18:16:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 16:16:35 +0000 Subject: [Koha-bugs] [Bug 21059] New: callback function in OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21059 Bug ID: 21059 Summary: callback function in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle at bywatersolutions.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Work to be done: Add the ability to define a callback function when adding an item to an order Define a callback function in intranetuserjs/OPACuserjs to remove items from the cart upon placing an order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 18:36:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 16:36:31 +0000 Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 --- Comment #7 from Jonathan Druart --- Created attachment 76865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76865&action=edit [COUNTER-PATCH] Bug 20927: Shortcut moredetail.pl on nonexistent biblionumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 18:38:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 16:38:23 +0000 Subject: [Koha-bugs] [Bug 20927] moredetail.pl crash on nonexistent biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #5) > Solution is identical in detail. > I saw output_and_exit_if_error somewhere recently and was not really > impressed. Identical but much more changes are needed. See this counter-patch (to apply on top of bug 20661) and you will get why it's better ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 18:41:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 16:41:23 +0000 Subject: [Koha-bugs] [Bug 21060] New: Article requests: Null borrowernumber when borrower is deleted and keep request data for statistics Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21060 Bug ID: 21060 Summary: Article requests: Null borrowernumber when borrower is deleted and keep request data for statistics Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a patron is deleted the article requests will also be deleted. This can leave holes in statistics. It would be nicer to cancel them and null the borrowernumber instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 18:48:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 16:48:37 +0000 Subject: [Koha-bugs] [Bug 21061] New: Clean up expired password recovery requests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21061 Bug ID: 21061 Summary: Clean up expired password recovery requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org >From reading the code it looks like entries to borrower_password_recovery are only cleaned up when an expired verification link is clicked or a password is reset successfully. It would be nice to have an option in cleanup_database to regularly clean up the table by deleting requests expired more than x days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 18:50:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 16:50:51 +0000 Subject: [Koha-bugs] [Bug 21062] New: Clean up borrower_password_recovery when patron is deleted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21062 Bug ID: 21062 Summary: Clean up borrower_password_recovery when patron is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When a patron is deleted, any entries in borrower_password_recovery should be deleted as well by cascade. CREATE TABLE `borrower_password_recovery` ( `borrowernumber` int(11) NOT NULL, `uuid` varchar(128) COLLATE utf8_unicode_ci NOT NULL, `valid_until` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, PRIMARY KEY (`borrowernumber`), KEY `borrowernumber` (`borrowernumber`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 19:42:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 17:42:38 +0000 Subject: [Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #9 from Jonathan Druart --- I prefer the second approach even if more verbose. It's easier to read and to test. It will certainly be easier to maintain and less error prone. Few remarks: - The having could be replaced with a join, and so more efficient. - filter_by_last_issued sounds wrong. I agree we should have a pattern (here "filter_by_") to explicitly tell what we are doing, but it should also be meaningful. Maybe it is for native English speakers ;) - filter_by_has_issues($options) is not enough explicit IMO. Moreover $options is a boolean, and "issue" must be "checkout". I would suggest: $patrons->filter_by_has_pending_checkouts and another one (?) But maybe I am making things more complicated here. (note: it seems that this subroutine will not be used by cleanborrowers.pl, we do not have this use case) - Should not filter_by_has_issues be filter_by_have_issues? - filter_by_when_expired - the interface allows to filter by "expired before", now we provide a "and/or expire after", but it is not used. It means more code, more tests and so... more potential bugs. It is not a big deal for this one, but we could have filter_by_expired_before that will be easier to read/write/test. Not blocker but worth mentioning/discussing it I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 19:46:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 17:46:54 +0000 Subject: [Koha-bugs] [Bug 21037] auth_show_hidden_data.pl gives false positives about 942$a and 152$b fields. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21037 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18811 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 [Bug 18811] Visibility settings inconsistent between framework and authority editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 19:46:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 17:46:54 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21037 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21037 [Bug 21037] auth_show_hidden_data.pl gives false positives about 942$a and 152$b fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 19:47:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 17:47:01 +0000 Subject: [Koha-bugs] [Bug 21039] auth_show_hidden_data.pl should also check if the subfield is ignored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21039 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |18811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 [Bug 18811] Visibility settings inconsistent between framework and authority editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 19:47:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 17:47:01 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21039 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21039 [Bug 21039] auth_show_hidden_data.pl should also check if the subfield is ignored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 20:23:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 18:23:29 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 --- Comment #20 from emjhet at pa.net --- (In reply to Mike from comment #12) > It is not depend on number of codes, but time that Koha consume to process > them. Think that this is problem with websere timeout time. If it is set on > 600 s (default), problem can be relevant for about 500 - 1000 barcodes. So, > we need solve it by universal way = make Inventory tool improvements that > make processing of barcodes on background, similar like import staging. > Webserver will not wait for it and timeouts will gone. "Small" change can > make Inventory tool really usefu(In reply to Mike from comment #12) > It is not depend on number of codes, but time that Koha consume to process > them. Think that this is problem with websere timeout time. If it is set on > 600 s (default), problem can be relevant for about 500 - 1000 barcodes. So, > we need solve it by universal way = make Inventory tool improvements that > make processing of barcodes on background, similar like import staging. > Webserver will not wait for it and timeouts will gone. "Small" change can > make Inventory tool really usefull. So is this still a problem in Koha 17.11.06? I don't want to take the time to scan thousands of items just to have it not work (again.) I believe I was using 17.05 the last time it did not work. What do we need to do to get the results from the inventory process? Not having this ability really limits the usefulness of Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 21:12:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 19:12:53 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #42 from Martin Renvoize --- Compile time warnings when running the QA script on this I'm afraid.. Looks like $borrower is returned in the patch but it's not part of the method signature anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 21:14:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 19:14:49 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #43 from Martin Renvoize --- (In reply to Martin Renvoize from comment #42) > Compile time warnings when running the QA script on this I'm afraid.. Looks > like $borrower is returned in the patch but it's not part of the method > signature anymore. Needs more digging.. borrower is indeed defined later in the method but it's not defined before it's called here.. failing qa until that's fixed :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 21:21:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 19:21:47 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Martin Renvoize --- Sorry Nick, although I don't like the way this is done I would Pass QA on it as there's already precedent and we can refactor it once there's been discussion on bug 11983. Failing QA for because there's a fair number of issues reported by the QA script instead: OK Koha/Patrons.pm FAIL misc/cronjobs/update_patrons_category.pl FAIL critic "$min_dob" is declared but not used at line 157, column 1. Unused variables clutter code and make it harder to read. "$au" is declared but not used at line 155, column 1. Unused variables clutter code and make it harder to read. "$max_dob" is declared but not used at line 158, column 1. Unused variables clutter code and make it harder to read. "$ao" is declared but not used at line 156, column 1. Unused variables clutter code and make it harder to read. FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 189) FAIL valid Global symbol "$ageunder" requires explicit package name (did you forget to declare "my $ageunder"?) Global symbol "$ageover" requires explicit package name (did you forget to declare "my $ageover"?) misc/cronjobs/update_patrons_category.pl had compilation errors. OK t/db_dependent/Patrons.t Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - a25919ad28 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 21:31:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 19:31:15 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |martin.renvoize at ptfs-europe | |.com --- Comment #57 from Martin Renvoize --- Sorry guys, can't get this set to apply right now: Applying: Bug 18736: (follow-up) Undo changes to GetLateOrders error: sha1 information is lacking or useless (C4/Acquisition.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 22:06:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 20:06:11 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 22:06:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 20:06:20 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76559|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart --- Created attachment 76866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76866&action=edit Bug 7376 Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 22:09:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 20:09:06 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70213|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 76867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76867&action=edit Bug 18639 - Add replacementprice field to aqorders Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 22:09:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 20:09:11 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70214|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 76868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76868&action=edit Bug 18639 - Schema updates (DO NOT PUSH) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 22:09:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 20:09:15 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70215|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 76869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76869&action=edit Bug 18639 - Add replacementprice field to acquisitions workflow To test: 0 - Apply patches and updatedatabase 1 - Add an order to a basket 2 - You should note new 'Retail price field' 3 - You should have a separate 'Replacement price' field 4 - Enter values and ensure they are saved as expected 5 - In the basket you should see the replacement price 6 - Modify order and ensure value is loaded and saved correctly 7 - Add and cancle an order and esure replacement price shows/saves 8 - Close basket 9 - Receive an order 10 - You should be able to edit replacement price 11 - 'retail price' field is not editable 12 - Check associated item, replacement price in item should be updated 13 - Cancel receipt, check item. receive again with new replacement price, check item 14 - Price should be correctly updated 15 - Finish receipt, value should show in table 16 - Test with receive from file Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 22:09:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 20:09:19 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70216|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 76870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76870&action=edit Bug 18639 - Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 22:09:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 20:09:22 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #13 from Martin Renvoize --- Created attachment 76871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76871&action=edit Bug 18639 Use replacementprice when creating order from quote Updates column name from rrp -> replacementprice when creating order from EDI QUOTE message Also ensure other rrp_tax* fields populated Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 22:11:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 20:11:19 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75946|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 22:12:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 20:12:04 +0000 Subject: [Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Seems ok here - https://screenshots.firefox.com/3CmAOf29z2fHLjzR/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 22:12:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 20:12:12 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Martin Renvoize --- All seems to work as expected and seems to make sense. I look the liberty of re-basing it against master whilst signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:20:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:20:37 +0000 Subject: [Koha-bugs] [Bug 20210] Claimed Return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20210 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:22:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:22:56 +0000 Subject: [Koha-bugs] [Bug 15439] Current Location incorrect when item in transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15439 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:27:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:27:10 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:27:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:27:14 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #4 from Jonathan Druart --- Created attachment 76872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76872&action=edit Bug 21048: Fix display of suggestion's status (SUGGEST_STATUS) When a suggestion's status is set to a customized value (AV SUGGEST_STATUS), the description is not always displayed correctly. Test plan: - Create different values for the AV SUGGEST_STATUS - Create several suggestions - Change the status using the SUGGEST_STATUS values - Edit the suggestion and change again the status - View the suggestions for a given patron (members/purchase-suggestions.pl?borrowernumber=XX), the statuses must displayed correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:29:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:29:07 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- I only have recreated the first issue (and find another one when editing a suggestion). The tab displayed ok for me. Which exact version of Koha are you using? On master I see the tabs which have status with suggestions. Emtpy tabs are not displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:29:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:29:21 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master Severity|trivial |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:31:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:31:29 +0000 Subject: [Koha-bugs] [Bug 21051] CGI::param called in list context when editing a patron card layout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |16154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 [Bug 16154] Replace CGI->param with CGI->multi_param in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:31:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:31:29 +0000 Subject: [Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 [Bug 21051] CGI::param called in list context when editing a patron card layout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:40:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:40:31 +0000 Subject: [Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- What is the value of SessionStorage? >From CGI::Session: """ Always explicitly calling flush() on the session before the program exits is recommended. For extra safety, call it immediately after every important session update. """ Maybe we should add this line below (there is another ->param call later). It sounds like we should put some flush call to C4::Auth as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:59:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:59:01 +0000 Subject: [Koha-bugs] [Bug 21053] editing 008 field with a hash overwrites data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 11 23:59:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 21:59:10 +0000 Subject: [Koha-bugs] [Bug 21053] editing 008 field with a hash overwrites data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053 --- Comment #1 from Jonathan Druart --- Created attachment 76873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76873&action=edit Bug 21053: Encode URI characters in plugin 008 A # (or &) at any position in 008 field of a bib record causes all subsequent data in field to be overwritten with default values when record is saved. These characters need to be correctly encoded before being passed as parameters of the url To reproduce: 1. Find and edit a bib record which has an 008 which differs from the default values for the MARC framework 2. Choose 008 helper 3. Add # in any position before the end of the field noting the current values of the data 4. Save record 5. Edit record and select 008 helper 6. Review characters after # -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 00:00:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 22:00:18 +0000 Subject: [Koha-bugs] [Bug 21053] editing 008 field with a hash overwrites data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Version|17.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 00:04:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 22:04:32 +0000 Subject: [Koha-bugs] [Bug 21052] New patron card printer profile won't save if paper bin is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Same for other labels/* forms In the logs: Database returned the following error on attempted INSERT: Duplicate entry 'DEFAULT PRINTER-0-Tray 1-Labels' for key 'printername' at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 164. or profile_id is currently undefined. at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 184. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 00:09:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jul 2018 22:09:40 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Screenshots? Which values are different? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 07:24:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 05:24:17 +0000 Subject: [Koha-bugs] [Bug 21052] New patron card printer profile won't save if paper bin is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052 --- Comment #2 from Katrin Fischer --- We've also managed to create a template that takes up 100% CPU and brings down Koha when trying to print a PDF. But so far have not been able to figure out how to reproduce it on another system. There are some serious issues with the forms not checking for good input. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 07:32:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 05:32:53 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #2 from Katrin Fischer --- - Use a patron who hasn't checked out items before - Set StatisticsFields to itype|ccode - Check out some items without location - Verify that statistics stable shows the correct number of checkouts - Check out one item with a location or just change one of your checked out items - Verify the total is still correct - Change StatisticsFields to location|itype|ccode - Verify the total has changed now - it's only 1 (the one with a location) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 07:33:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 05:33:45 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #3 from Katrin Fischer --- I retested it on master... not quite the same result as last time, but still something strange going on here. Hope the test plan works for you. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 07:44:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 05:44:44 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #4 from Katrin Fischer --- Created attachment 76874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76874&action=edit statistics tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 07:45:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 05:45:25 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #5 from Katrin Fischer --- Created attachment 76875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76875&action=edit current checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 07:46:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 05:46:44 +0000 Subject: [Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027 --- Comment #6 from Katrin Fischer --- For the screenshot the pref was set to location|itype|ccode. If location is removed, the number of checkouts shows as 2 (which is correct). Note: in the screenshot, the shelving location is also not shown? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 08:28:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 06:28:02 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 --- Comment #10 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #8) > Maybe we should consider backporting this or at least fixing kohastructure > in the other branches. We ran into the problem updating an instance to 17.11 > today. Same for us, we have patched our 17.11 with this for our upgrades. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 08:29:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 06:29:18 +0000 Subject: [Koha-bugs] [Bug 20175] Set a correct default value for club_enrollments.date_created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|VERIFIED |RESOLVED Resolution|REMIND |FIXED --- Comment #11 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08. The db update can be run even if already applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 08:38:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 06:38:05 +0000 Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when using SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |17680 Blocks|17680 | --- Comment #9 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 08:38:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 06:38:05 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21020 Depends on|21020 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 [Bug 21020] Return branch not set for transfer when using SIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 08:39:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 06:39:48 +0000 Subject: [Koha-bugs] [Bug 21029] "Suspend until" in modal in staff patron account is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 08:58:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 06:58:28 +0000 Subject: [Koha-bugs] [Bug 20946] Cannot pay fines for patrons with credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20946 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin SOMERS --- Code in pay.pl has changed a lot with Bug 10021 that is not in 17.11.x. I'm really not sure how to rebase. Can you provide rebased patches ? Maybe squashed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 09:00:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 07:00:38 +0000 Subject: [Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 09:01:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 07:01:59 +0000 Subject: [Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 09:04:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 07:04:59 +0000 Subject: [Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #10 from Martin Renvoize --- Reverted in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 09:05:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 07:05:00 +0000 Subject: [Koha-bugs] [Bug 21024] JS error on search result breaks JS functionalities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21024 Bug 21024 depends on bug 20864, which changed state. Bug 20864 Summary: Only set bibs_selected cookie when BrowseResultSelection is activated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 09:09:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 07:09:03 +0000 Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug 12509 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 09:10:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 07:10:32 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #45 from Martin Renvoize --- Created attachment 76876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76876&action=edit Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 09:10:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 07:10:54 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 09:11:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 07:11:44 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #46 from Martin Renvoize --- All seems to work as expected and can't see any regressions, Signing Off. I also amended the commit message to add the missing ':' to silence the QA scripts ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 09:43:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 07:43:55 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 --- Comment #7 from David Cook --- Thanks for the sign off! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 10:49:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 08:49:37 +0000 Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #7 from Katrin Fischer --- Hi Ian and others, we have run several tests with 17.11.07 as we plan to update soon and could not see any errors. We are using a package installation with Debian. The problem could only exist in 17.05 or there is another difference we haven't figured out yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 11:22:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 09:22:02 +0000 Subject: [Koha-bugs] [Bug 21063] New: Allow columns in intranet ILL request datatable to be customisable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Bug ID: 21063 Summary: Allow columns in intranet ILL request datatable to be customisable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com Currently the columns in this datatable are static, they should be customisable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 11:22:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 09:22:29 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 11:22:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 09:22:29 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 [Bug 21063] Allow columns in intranet ILL request datatable to be customisable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 11:35:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 09:35:39 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76777|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 76877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76877&action=edit Bug 20979: Fix confirm deletion popup when deleting a biblio When deleting an empty bib, error messages pops up "1 order(s) are using this record. You need order managing permissions to delete this record." even though user has superlibrarian permissions. Prevents the deletion of the bib record. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 11:39:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 09:39:01 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76877|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 76878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76878&action=edit Bug 20979: Fix confirm deletion popup when deleting a biblio When deleting an empty bib, error messages pops up "1 order(s) are using this record. You need order managing permissions to delete this record." even though user has superlibrarian permissions. Prevents the deletion of the bib record. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 11:40:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 09:40:15 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- A trivial patch, looks good and tests good. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 11:52:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 09:52:21 +0000 Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69777|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 76879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76879&action=edit Bug 18947 - LDAP: do not assume anonymous bind if no user or password To test: Ideally tested on a working ldap server with bind by auth and no anonymous bind 1 - Define an LDAP config with bind by auth 2 - Don't define user/pass 3 - Define anonymous_bind = 0 4 - Attempt bind by auth 5 - Error is something like: LDAP search failed to return object : XXXXXXXXX: LdapErr: XXXX-XXXXXX, comment: In order to perform this operation a successful bind must be completed on the connection., data 0, v2580 at /usr/share/koha/lib/C4/Auth_with_ldap.pm line 102. 6 - Define user/pass 7 - Now bind by auth should work 8 - remove user/pass 9 - Apply patch 10 - Attempt again 11 - Bind by auth shoudl succeed prove -v t/db_dependent/Auth_with_ldap.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 11:52:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 09:52:57 +0000 Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Can't believe I hadn't come across this until now! Signing Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:01:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:01:31 +0000 Subject: [Koha-bugs] [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76793|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 76880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76880&action=edit Bug 21054: Remove extraneous tag from sco-main.tt To test: 1 - Enable sco and setup AutoSelfCheck 2 - Try to use self checkout and print receipt 3 - You shoudl be redirected to the login page 4 - Apply patch and restart all the things 5 - Try to use self checkout and print a receipt 6 - Success! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:01:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:01:59 +0000 Subject: [Koha-bugs] [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- Very trivial fix, works as expected, Signing Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:17:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:17:50 +0000 Subject: [Koha-bugs] [Bug 21064] New: Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Bug ID: 21064 Summary: Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl undef causes a JS error, undefined seems to be the correct term to use -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:18:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:18:19 +0000 Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76862|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 76881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76881&action=edit Bug 20919: Remove unecessary search calls on the biblio detail page There is a countanalytics flag that is set for items used in analytical biblio records. This flag is only used in the template when 'analyze' has been passed to the script. In order to avoid unecessary search calls (1 per item), $analyse must be tested. Test plan: 0. Do not apply the patch 1. tail -f /var/log/koha/kohadev/zebra-output.log 2. Hit a bibliographic record detail page with several items 3. Notice that the log has 1 line per item: 11:30:36-14/06 zebrasrv(32) [warn] ir_session (exception) 4. Apply the patch 5. Hit the page again 6. There is nothing in the zebra log file If you are familiar with analytic records, confirm that you are not allowed to remove an item that is used in analytical biblio records. Signed-off-by: Hugo Agud Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:18:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:18:59 +0000 Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Another fairly trivial but important improvement. All appears to work well and I can't find any regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:19:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:19:52 +0000 Subject: [Koha-bugs] [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- So trivial I've decided to just pass qa directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:19:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:19:55 +0000 Subject: [Koha-bugs] [Bug 21064] Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:19:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:19:57 +0000 Subject: [Koha-bugs] [Bug 21064] Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 --- Comment #1 from Nick Clemens --- Created attachment 76882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76882&action=edit Bug 21064: Use undefined instead of undef To test: 1 - Load the advanced cataloging editor 2 - Refresh the page several times 3 - Check the JS console, you shoudl see an error: 'undef is not defined' 4 - Apply patch 5 - Try again, should be no error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:20:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:20:23 +0000 Subject: [Koha-bugs] [Bug 21064] Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Depends on| |19267 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:20:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:20:23 +0000 Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 [Bug 21064] Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:32:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:32:44 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76760|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 76883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76883&action=edit Bug 20084: Fix Industrial2of5 and COOP2of5 patron card layouts == Test plan == This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working...) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 9. Layout: set "Barcode type:" to COOP2of5 10. Export the batch 11. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 12. Apply this patch 13. Retry with both non-working patches 1. You should have a white page with a barcode 2. And no errors in the relevant log file Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:33:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:33:22 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #70914|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:34:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:34:20 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize --- Fairly trivial fix, I can't find any regressions and the QA scripts pass.. i'd love to see accompanying tests, but that can wait as we're in C4. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:40:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:40:32 +0000 Subject: [Koha-bugs] [Bug 21032] Refining a search made on a specific index fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:40:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:40:34 +0000 Subject: [Koha-bugs] [Bug 21032] Refining a search made on a specific index fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76653|0 |1 is obsolete| | --- Comment #4 from S?verine Queune --- Created attachment 76884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76884&action=edit Bug 21032 - fix using facet for searches made on specific index Test plan: - Try a simple search (OPAC or staff) like "title:foo", - click on a facet: badaboum! - apply this patch, - retry Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 12:42:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 10:42:23 +0000 Subject: [Koha-bugs] [Bug 21032] Refining a search made on a specific index fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 --- Comment #5 from S?verine Queune --- Tested in our 2 different instances (dev and test) and both work ! The problem I mentioned on comment 2 seems to be specific to the sandbox. Thank you Alex ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 13:17:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 11:17:36 +0000 Subject: [Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Katrin Fischer --- Upping severity a bit - storing patron information that is/can never be deleted outside of SQL is not nice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 13:19:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 11:19:11 +0000 Subject: [Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Katrin Fischer --- Upping severity a bit - keeping potential sensitive data about patrons with no way to delete them aside from SQL is not good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 13:19:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 11:19:40 +0000 Subject: [Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > What is the value of SessionStorage? > > From CGI::Session: > """ > Always explicitly calling flush() on the session before the program exits is > recommended. For extra safety, call it immediately after every important > session update. > """ > > Maybe we should add this line below (there is another ->param call later). > > It sounds like we should put some flush call to C4::Auth as well. I certainly wouldn't hurt! Do you want to just add that as a followup here, or do you want to file a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 13:30:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 11:30:22 +0000 Subject: [Koha-bugs] [Bug 21065] New: Data in accountoffsets and accountlines is deleted with the patron leaving gaps in financial reports Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21065 Bug ID: 21065 Summary: Data in accountoffsets and accountlines is deleted with the patron leaving gaps in financial reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The tables accountoffsets and accountlines are both "cleaned up" when a patron is deleted by using FK constraints. This is a problem because 1) The patrons have a "right to be forgotten" with GDPR and you can't refuse to delete them if their fines are paid etc. 2) Especially for partial payments and in other cases the data in accountlines and accountoffsets is neded to create reliable reports for statistics, but also for financial reports. It's not possible to determine from other tables like statistics and action_logs what fines are linked to which payment which doesn't allow to create reports by fine/fee type and similar. Instead of deleting the info, we should really just anonymize it. -- CREATE TABLE `accountoffsets` ( `borrowernumber` int(11) NOT NULL DEFAULT '0', `accountno` smallint(6) NOT NULL DEFAULT '0', `offsetaccount` smallint(6) NOT NULL DEFAULT '0', `offsetamount` decimal(28,6) DEFAULT NULL, `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, KEY `accountoffsets_ibfk_1` (`borrowernumber`), CONSTRAINT `accountoffsets_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; CREATE TABLE `accountlines` ( `accountlines_id` int(11) NOT NULL AUTO_INCREMENT, `issue_id` int(11) DEFAULT NULL, `borrowernumber` int(11) NOT NULL DEFAULT '0', `accountno` smallint(6) NOT NULL DEFAULT '0', `itemnumber` int(11) DEFAULT NULL, `date` date DEFAULT NULL, `amount` decimal(28,6) DEFAULT NULL, `description` mediumtext COLLATE utf8_unicode_ci, `dispute` mediumtext COLLATE utf8_unicode_ci, `accounttype` varchar(5) COLLATE utf8_unicode_ci DEFAULT NULL, `amountoutstanding` decimal(28,6) DEFAULT NULL, `lastincrement` decimal(28,6) DEFAULT NULL, `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, `notify_id` int(11) NOT NULL DEFAULT '0', `notify_level` int(2) NOT NULL DEFAULT '0', `note` text COLLATE utf8_unicode_ci, `manager_id` int(11) DEFAULT NULL, PRIMARY KEY (`accountlines_id`), KEY `acctsborridx` (`borrowernumber`), KEY `timeidx` (`timestamp`), KEY `itemnumber` (`itemnumber`), CONSTRAINT `accountlines_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `accountlines_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE SET NULL ON UPDATE SET NULL ) ENGINE=InnoDB AUTO_INCREMENT=4666 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 14:01:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 12:01:07 +0000 Subject: [Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- Can we add a syspref to specify the CAS protocol version and have the behaviour adjust as required on each case? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 14:21:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 12:21:21 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76861|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 76886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76886&action=edit Bug 20811: Fix update flag in bulkmarcimport I have no idea why we have these two variables $id and $originalid, it seems that they should not cohabit. It feels like Users and original authors of this script should provide an update and refresh it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 14:21:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 12:21:17 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75599|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 76885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76885&action=edit Bug 20811: Fix wrong usage of ModBiblio Since commit cefa7c21e28b88351ee8ae0dfefb80a515323df9 Bug 5635: bulkmarcimport new parameters & features AddBiblio call has been replaced with ModBiblio, but the return values are different. We should not replace the value of $biblionumber with what returns this subroutine. Test plan: If you are familiar with bulkmarcimport.pl you should know what to test, I am not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 14:22:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 12:22:15 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76885|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 76887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76887&action=edit Bug 20811: Fix wrong usage of ModBiblio Since commit cefa7c21e28b88351ee8ae0dfefb80a515323df9 Bug 5635: bulkmarcimport new parameters & features AddBiblio call has been replaced with ModBiblio, but the return values are different. We should not replace the value of $biblionumber with what returns this subroutine. Test plan: If you are familiar with bulkmarcimport.pl you should know what to test, I am not. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 14:22:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 12:22:18 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76886|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 76888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76888&action=edit Bug 20811: Fix update flag in bulkmarcimport I have no idea why we have these two variables $id and $originalid, it seems that they should not cohabit. It feels like Users and original authors of this script should provide an update and refresh it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 14:23:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 12:23:17 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Martin Renvoize --- Works as expected.. the $id and $originalid may both be populated if $match is used.. some of the logging in there is rather odd but that shouldn't require any fixes in this bug. Signing Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 14:33:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 12:33:57 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76571|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 76889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76889&action=edit Bug 21022: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 14:34:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 12:34:03 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76573|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 76891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76891&action=edit Bug 21022: (follow-up) Move overloaded full_message method to subclass We shouldn't have it overloaded on the base class, as it could get huge and difficult to find things, and read. This patch moves things to Koha::Exceptions::Object. We should overload the full_message method on each exceptions class, as needed. To test: - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 14:34:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 12:34:00 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76572|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 76890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76890&action=edit Bug 21022: Use passed message if present This patch makes 'full_message' use the passed exception message instead of trying to build it from the parameters. This is particularly useful for some situations in which we don't have all the information but would like to keep using the same exception. To test: - Apply this patchset - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 14:34:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 12:34:36 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Seems sane, code is reasonable and well structured, signing off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 15:21:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 13:21:17 +0000 Subject: [Koha-bugs] [Bug 11889] Disown a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #37 from Marcel de Rooy --- Anyone having an idea how we can get this running again ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 15:33:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 13:33:20 +0000 Subject: [Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 --- Comment #2 from Katrin Fischer --- It could work - if people are ok with that. Cleaner would be fixing the external module, but much harder to do :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 15:33:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 13:33:32 +0000 Subject: [Koha-bugs] [Bug 20265] Add syspref to hide news published date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy --- Dilan: I have the impression that something like .newsitem .newsfooter { display:none; } does not really need a syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 15:37:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 13:37:42 +0000 Subject: [Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 --- Comment #3 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #2) > It could work - if people are ok with that. Cleaner would be fixing the > external module, but much harder to do :( Is there a bug filed for the Authen::CAS::Client library? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 15:40:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 13:40:18 +0000 Subject: [Koha-bugs] [Bug 21066] New: Use opac_news.timestamp as a real timestamp or add opac_news.updated_on ? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Bug ID: 21066 Summary: Use opac_news.timestamp as a real timestamp or add opac_news.updated_on ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org I would propose to use the opac_news.timestamp field readonly and fill/update it automatically via SQL. Or do we still need the original publish date and add a modified/updated_on timestamp? What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 15:51:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 13:51:34 +0000 Subject: [Koha-bugs] [Bug 20769] Duplicate fine generated when lost item is returned with BlockReturnOfLostItems activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20769 --- Comment #2 from Lucy Vaux-Harvey --- Hi Andrew, WhenLostForgiveFine is set to Don't forgive so a full duplicate fine is being charged. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:10:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:10:08 +0000 Subject: [Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 --- Comment #4 from Katrin Fischer --- Thx, Tomas! https://rt.cpan.org/Ticket/Display.html?id=125833 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:14:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:14:41 +0000 Subject: [Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 --- Comment #5 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #4) > Thx, Tomas! > > https://rt.cpan.org/Ticket/Display.html?id=125833 I still think we should have a 'CASVersion' syspref that controls this behaviour, until there's a response from the library maintainer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:33:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:33:04 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize --- This has now had at least two QA runs (Tomas and Myself) and I believe all outstanding QA failing issues are resolved. I'm going to Pass QA and suggest we catch any fallout between now and release and even with all of our eyes on it there's bound to have been something creep through. Jonathan has done a great job, thankyou very much. As a side note.. after having discussed a few issues with him I have a few followup bugs to create that relate to this but should not hold up it's continuance. One being a case where none of us was entirely 100% sure about where a 'sync' key was passed into ModBiblio in the pate for the NL syncing code (which I was going to asign to Magnus) and a second where a few pre-existing race conditions are made much more obvious by this work. Passing QA :) Jonathan, can you add Signoff lines for Josef, Tomas and Me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:36:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:36:30 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72341|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 76892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76892&action=edit Bug 20079: Display stack trace for development installations """The default value is development, which causes plackup to load the middleware components: AccessLog, StackTrace, and Lint unless --no-default-middleware is set.""" Test plan: Confirm that the stack trace is displayed when something is wrong (die somewhere to test) for dev installations (inside a devbox) The -E flag must remain deployment for non-dev installs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:37:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:37:25 +0000 Subject: [Koha-bugs] [Bug 21067] New: Under plack, 500 errors only show as "Internal Server Error" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21067 Bug ID: 21067 Summary: Under plack, 500 errors only show as "Internal Server Error" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When plack is not running, 500 errors will show the error message of the perl file where the error occurred, as well as a contact email address, something like this: 500 Internal Server Error Use of uninitialized value within @itemnumber in string ne at /usr/share/koha/intranet/cgi-bin/reserve/modrequest.pl line 70. To report a broken link or any other issue, please contact the Koha Administrator. (I think the text is actually from koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt) Under plack, all we see is Internal Server Error This means that a) Errors are less likely to be reported to the server administrator because there's no mailto. b) We can't immediately see the error message when the error is reported. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:37:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:37:46 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- A trivial patch that just serves to improves developers lives when working with plack :) I bet half of us are effectively running this way anyway.. going to go straight to Passed QA for this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:37:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:37:52 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:38:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:38:01 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:38:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:38:06 +0000 Subject: [Koha-bugs] [Bug 20079] Display stack trace for development installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:40:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:40:38 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:40:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:40:42 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76889|0 |1 is obsolete| | Attachment #76890|0 |1 is obsolete| | Attachment #76891|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 76893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76893&action=edit Bug 21022: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:40:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:40:46 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 --- Comment #9 from Jonathan Druart --- Created attachment 76894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76894&action=edit Bug 21022: Use passed message if present This patch makes 'full_message' use the passed exception message instead of trying to build it from the parameters. This is particularly useful for some situations in which we don't have all the information but would like to keep using the same exception. To test: - Apply this patchset - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:40:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:40:50 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 --- Comment #10 from Jonathan Druart --- Created attachment 76895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76895&action=edit Bug 21022: (follow-up) Move overloaded full_message method to subclass We shouldn't have it overloaded on the base class, as it could get huge and difficult to find things, and read. This patch moves things to Koha::Exceptions::Object. We should overload the full_message method on each exceptions class, as needed. To test: - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:43:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:43:21 +0000 Subject: [Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- I agree with Cait, we need an update here - frameworks with the wrong code cannot be edited (the koha field cannot anyways) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:45:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:45:36 +0000 Subject: [Koha-bugs] [Bug 21068] New: NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 Bug ID: 21068 Summary: NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When QAing Bug 20287 the one thing I wasn't 100% sure about was line 289 which we have marked with a FIXME. I could not find anywhere in koha that passed in a sync key to ModMember and as such we believe it was safe to remove it. This bug serves as a note to get Magnus to double check our assumptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:45:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:45:49 +0000 Subject: [Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 [Bug 20287] Move AddMember and ModMember to Koha::Patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:45:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:45:49 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:46:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:46:02 +0000 Subject: [Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:50:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:50:08 +0000 Subject: [Koha-bugs] [Bug 21069] New: Koha::Patron->generate_userid use encourages a race condition Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21069 Bug ID: 21069 Summary: Koha::Patron->generate_userid use encourages a race condition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We're using ->generate_userid followed later down a script by ->store in a number of places. This is a race condition whereby we could inadvertantly end up with duplicate userid's on the system. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:51:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:51:42 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21069 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21069 [Bug 21069] Koha::Patron->generate_userid use encourages a race condition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:51:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:51:42 +0000 Subject: [Koha-bugs] [Bug 21069] Koha::Patron->generate_userid use encourages a race condition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21069 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 [Bug 20287] Move AddMember and ModMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 16:59:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 14:59:11 +0000 Subject: [Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Attachment #76712|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 17:43:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 15:43:29 +0000 Subject: [Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #13 from Lucy Vaux-Harvey --- I've tried testing this patch on one of the sandboxes but can't access the Upload patron images tool at http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/tools/picture-upload.pl Software error is: Global symbol "$filename" requires explicit package name (did you forget to declare "my $filename"?) at /home/koha/src/tools/picture-upload.pl line 118. Execution of /home/koha/src/tools/picture-upload.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 18:41:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 16:41:10 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Charles Quain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |csq at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 18:42:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 16:42:06 +0000 Subject: [Koha-bugs] [Bug 2696] Fine payments should show what was paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Charles Quain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |csq at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:11:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:11:10 +0000 Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #115 from Victor Grousset/tuxayo --- Created attachment 76896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76896&action=edit Bug 12310: (QA follow-up) Simplify DecimalSeparators syspref description Thanks Marcel for the new version :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:11:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:11:41 +0000 Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75959|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:36:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:36:53 +0000 Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #76588|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:38:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:38:13 +0000 Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:38:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:38:17 +0000 Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76761|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 76897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76897&action=edit Bug 21025: Add GetPreparedLetter to Koha::Patron::Discharge Test plan (shamelessly ripped from Bug20953): 1) Set system preference 'useDischarge' to 'Allow' 2) Choose a patron without checkouts nor fines nor restrictions 3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl 4) Click on 'ask for a discharge' tab => You see /cgi-bin/koha/opac-discharge.pl with text 'What is a discharge? ...' 5) Click on 'Ask for a discharge' link => You see /cgi-bin/koha/opac-discharge.pl?op=request with text 'Your discharge request has been sent ...' 6) In a new browser tab/page, go to intranet on /cgi-bin/koha/members/discharges.pl => You see one discharge requets for the patron => Click on 'allow' on patron discharge request 7) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl => You see link 'Get your discharge' 8) Click on the link to get your generated PDF => An error message should appear informing you to contact your website's admin 9) Apply this patch 10) Click again on the link to get your generated PDF => This time, a download prompt should appear Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:42:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:42:53 +0000 Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:42:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:42:58 +0000 Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76766|0 |1 is obsolete| | Attachment #76767|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 76898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76898&action=edit Bug 21008: Use patron object to get category_type This patch makes borrower_add_additional_fields() in both pay.pl and paycollect.pl use the right object to pick the category_type. It also populates the extendedattributes template variable in pay.pl which was missed by a change. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:43:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:43:03 +0000 Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 --- Comment #11 from Jonathan Druart --- Created attachment 76899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76899&action=edit Bug 21008: Use Koha::Patron->is_child Signed-off-by: Tomas Cohen Arazi Edit: I removed the category parameter as it is not really used. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:54:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:54:40 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #6 from Lisette Scheer --- We are on 17.11.07.000. On master on Sandbox It shows a bunch of tabs labeled "Status unknown (0)' and a tab for whichever ones have at least 1 purchase suggestion with that value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:56:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:56:16 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #7 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Lisette Scheer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:57:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:57:02 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #8 from sandboxes at biblibre.com --- Created attachment 76900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76900&action=edit Bug 21048: Fix display of suggestion's status (SUGGEST_STATUS) When a suggestion's status is set to a customized value (AV SUGGEST_STATUS), the description is not always displayed correctly. Test plan: - Create different values for the AV SUGGEST_STATUS - Create several suggestions - Change the status using the SUGGEST_STATUS values - Edit the suggestion and change again the status - View the suggestions for a given patron (members/purchase-suggestions.pl?borrowernumber=XX), the statuses must displayed correctly Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 19:56:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 17:56:52 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76872|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:18:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:18:24 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #9 from Jonathan Druart --- (In reply to Lisette Scheer from comment #6) > We are on 17.11.07.000. > On master on Sandbox It shows a bunch of tabs labeled "Status unknown (0)' > and a tab for whichever ones have at least 1 purchase suggestion with that > value. How did you do that? :) I have created a new suggestion on another sandbox (5) and there is only one tab! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:48:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:48:53 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #14 from Jonathan Druart --- Created attachment 76901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76901&action=edit Bug 20287: Move fixup_cardnumber Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:48:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:48:58 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #15 from Jonathan Druart --- Created attachment 76902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76902&action=edit Bug 20287: Move trim values to a method Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:49:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:49:05 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #16 from Jonathan Druart --- Created attachment 76903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76903&action=edit Bug 20287: Koha::Object->get_from_storage May be part of a separate bug report if needed TODO - add POD + tests Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:49:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:49:15 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #17 from Jonathan Druart --- Created attachment 76904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76904&action=edit Bug 20287: Move AddMember to Koha::Patron->store Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:49:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:49:27 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #19 from Jonathan Druart --- Created attachment 76906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76906&action=edit Bug 20287: Fix export issues in tests t/db_dependent/Holds/RevertWaitingStatus.t .. Undefined subroutine &C4::Circulation::MoveReserve called at /home/vagrant/kohaclone/C4/Circulation.pm line 1316. Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:49:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:49:32 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #20 from Jonathan Druart --- Created attachment 76907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76907&action=edit Bug 20287: Remove warning If there are no patrons in DB: Use of uninitialized value in addition (+) Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:49:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:49:36 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #21 from Jonathan Druart --- Created attachment 76908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76908&action=edit Bug 20287: New warning in t/db_dependent/Koha/Object.t (?) Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:49:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:49:41 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #22 from Jonathan Druart --- Created attachment 76909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76909&action=edit Bug 20287: Use DBIC transaction instead of AutoCommit=0 Remove error "Already in a transaction" Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:49:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:49:23 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #18 from Jonathan Druart --- Created attachment 76905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76905&action=edit Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:49:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:49:46 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #23 from Jonathan Druart --- Created attachment 76910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76910&action=edit Bug 20287: Remove AddMember_Auto I am not sure I understood the point of this subroutine. Did I miss something here? Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:49:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:49:52 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #24 from Jonathan Druart --- Created attachment 76911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76911&action=edit Bug 20287: Add plain_text_password (& Remove AddMember_Opac) But actually we could remove it if it does not make sense for other use. Callers could deal with it since the password is not generated here Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:49:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:49:57 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #25 from Jonathan Druart --- Created attachment 76912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76912&action=edit Bug 20287: Move ModMember to Koha::Patron Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:02 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #26 from Jonathan Druart --- Created attachment 76913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76913&action=edit Bug 20287: ->store new deal with enrolment fee Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:06 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #27 from Jonathan Druart --- Created attachment 76914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76914&action=edit Bug 20287: Fix test t/db_dependent/Members.t and prevent regressions Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:11 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #28 from Jonathan Druart --- Created attachment 76915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76915&action=edit Bug 20287: There is a warning, we just want to unset the value here Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:17 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #29 from Jonathan Druart --- Created attachment 76916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76916&action=edit Bug 20287: Replace ModMember in patrons import Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:22 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #30 from Jonathan Druart --- Created attachment 76917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76917&action=edit Bug 20287: Fix update of patrons, clean the data before ->store Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:26 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #31 from Jonathan Druart --- Created attachment 76918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76918&action=edit Bug 20287: generate_userid now set the userid Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:31 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #32 from Jonathan Druart --- Created attachment 76919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76919&action=edit Bug 20287: Replace occurrences of AddMember in REST API Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:35 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #33 from Jonathan Druart --- Created attachment 76920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76920&action=edit Bug 20287: Replace occurrences of ModMember in REST API Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:40 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #34 from Jonathan Druart --- Created attachment 76921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76921&action=edit Bug 20287: Fix tests expecting a warning The new Koha::Patron-based implementation encapsulates some error conditions that raised warnings and the tests expected that warning. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:45 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #35 from Jonathan Druart --- Created attachment 76922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76922&action=edit Bug 20287: Use more simple object for Object.t We initially use Koha::Patron to test Object.t, but now it overwrites ->store and so it is better to use a more simple object. ApiKey has foreign keys and unique key. We lost one test: there is only one unique key whereas we had 2 on borrowers (I did not find a better option) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:51 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #36 from Jonathan Druart --- Created attachment 76923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76923&action=edit Bug 20287: Test exception DuplicateID for Koha::Patron->store Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:50:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:50:56 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #37 from Jonathan Druart --- Created attachment 76924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76924&action=edit Bug 20287: (QA follow-up) Fix warning on undefined Signed-off-by: Tomas Cohen Arazi Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 20:55:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 18:55:08 +0000 Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart --- + logged_in_user => $loggedinuser, You should not do that, a Koha::Patron object is already passed using this variable name in C4::Auth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 21:19:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 19:19:10 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #10 from Lisette Scheer --- Created attachment 76925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76925&action=edit Multiple Status Unknown tabs This was on BibLibre sandbox 06 both on master and with your patch applied. I created 3 suggest_status AV, made 3 purchase suggestions and assigned one to 2 of the statuses and left one pending. Each time it added a new tab, but left the status unknown tabs visible. There were the same number of status unknown tabs when I had 1 AV as when I had 3. I tried on BibLibre sandbox 07 on master and before I even added any suggest_status AV I put in a purchase suggestion and it did this again. Perhaps it is an issue with the BibLibre sandboxes? I'd try on another but those are the only ones I've been able to get to work today. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 21:32:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 19:32:41 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 --- Comment #9 from Jason Etheridge --- Created attachment 76926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76926&action=edit Bug 14493: export_borrowers.pl - Export patron attributes Tweaked Vitor's original patch to accomodate changes to the file. --- export_borrowers.pl changed to support patron attributes Test plan: - Use export_borrowers.pl to export all patron and all fields - The patrons extended attributes are not exported - Apply the patch - Use export_borrowers.pl with the no fields specified or with the field patron_attributes - The patrons extended attributes will be exported in one column Create by: Vitor Fernandes Sponsored by: KEEP SOLUTIONS Signed-off-by: Jason Etheridge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 21:33:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 19:33:55 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Jason Etheridge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jason at esilibrary.com Assignee|vfernandes at keep.pt |jason at esilibrary.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 21:34:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 19:34:32 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #38 from Jonathan Druart --- Created attachment 76927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76927&action=edit Bug 20287: (follow-up) Test exception DuplicateID for Koha::Patron->store -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 21:48:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 19:48:02 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Jason Etheridge changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 21:50:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 19:50:17 +0000 Subject: [Koha-bugs] [Bug 21070] New: request.pl details links to biblio instead of moredetail.pl for that item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Bug ID: 21070 Summary: request.pl details links to biblio instead of moredetail.pl for that item Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: lisetteslatah at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 76928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76928&action=edit detailscolumnview If someone needs to modify an item that is placed on an item level hold for someone, it seems like it would make sense for the "Details column (see detachment) barcode link to go to moredetail.pl for that item number than for it to go to the biblio page. The behavior would be more like clicking on a barcode from either the biblio page or the check-in screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 21:50:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 19:50:27 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 22:09:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 20:09:04 +0000 Subject: [Koha-bugs] [Bug 13498] 'email' templates used for printing slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 22:09:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 20:09:54 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 22:47:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 20:47:30 +0000 Subject: [Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart --- I am currently working on moving this code the Koha namespace and I do not understand what is needed exactly here. So far we have: xxx 1 Damaged pouet peout 0 Maybe we just need a couple variable=value, right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 23:26:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 21:26:43 +0000 Subject: [Koha-bugs] [Bug 20549] Avoid indexer race condition when moving item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20549 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Alex Buckley --- The bug that I wrote this patch for turned out to be a cataloging issue rather than a race condition in the execution of a reindex. The cataloging issue was causing Zebra to return two biblios when searching for the barcode of an item moved from one biblio to another. Therefore I am going to set this bug report to 'Resolved Fixed'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 12 23:44:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jul 2018 21:44:35 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 02:36:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 00:36:31 +0000 Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 --- Comment #6 from Liz Rea --- I just had to add the extra configs because of this last night lol. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:03:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:03:21 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #15 from Marcel de Rooy --- Hmm. The first patch is obviously needed. But I have my doubts on the second patch. Can we move it to another report to expedite handling the first ? About the second: > I have no idea why we have these two variables $id and $originalid, it > seems that they should not cohabit. > It feels like Users and original authors of this script should provide an > update and refresh it. I do not know either. But because of that it seems to me that we need more proof that this change is valid. Why do you change it? How did you test it? etc. The only assignment to $id that I see is line 328 when the condition $match is true and @$results == 1. Does $id here become the biblionumber of the only match/duplicate? Apparently this record is updated by the script. $originalid is the 999c or 001 from the imported batch record. So it seems to me that it should not be a valid biblionumber. And certainly no candidate for $biblionumber. Look also at the remaining lines testing if there is a biblionumber. I have the strong feeling that this is a very bad change ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:03:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:03:56 +0000 Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Hi Liz, could you sign off so we can count Martin for QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:11:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:11:05 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76757|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 76929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76929&action=edit Bug 20090: Missing script statement for Novelist Select on some record displays in OPAC This patch adds a check for UPCs and well as ISBNs to the Novelist Select conditionals in opac-detail.tt To test (note that you must subscribe to Novelist Select): 1. If your library does not use the raton ratings feature, activate it for the purposes of this test. 2. Display a record that does not have an ISBN in the 020 field, but has a upc (or other code) in the 024 field. The rating option will display as 5 radio buttons and a "rate it" button. 3. Apply the patch. 4. Display the same record again. The radio buttons will be replaced with stars. This indicates that the scripts on the page completed. Rather that using the patron ratings as in indicator, you can also use a web page inspector/debugger such as firebug or the built-in inspectors in most newer browsers to check for script errors. Signed-off-by: Katrin Fischer I couldn't check with Novelist Select, but read and checked changed made carefully. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:11:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:11:18 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:11:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:11:02 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:13:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:13:17 +0000 Subject: [Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76759|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 76930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76930&action=edit Bug 21023: Remove warning in t/db_dependent/Circulation/Chargelostitem.t To test: - Run: $ kshell k$ prove t/db_dependent/Circulation/Chargelostitem.t => FAIL: Warning is displayed - Apply this patch - Run: k$ prove t/db_dependent/Circulation/Chargelostitem.t => SUCCESS: Tests pass! No warning! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:13:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:13:28 +0000 Subject: [Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:19:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:19:39 +0000 Subject: [Koha-bugs] [Bug 20974] Remove files left behind after removing Solr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- How did you test this, guys? git grep -E "INCLUDE [']?facets.inc" git grep -E "INCLUDE [']?page-numbers.inc" git grep -E "INCLUDE [']?resort_form.inc" Every statement still produces results ! "Perform a search in the OPAC" is stated too simply? The test depends on more settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:24:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:24:06 +0000 Subject: [Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76771|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 76931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76931&action=edit Bug 20698 - Remove obsolete template: transfer-slip.tt This patch removes an unused template file, circ/transfer-slip.tt. Its use was removed by Bug 7001: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9ded4fa008668df8c485fbbc76efa3cc9cc00d7#patch12 To test, apply the patch and confirm that the file has been removed. Confirm that no references to the template exist in the codebase. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:24:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:24:16 +0000 Subject: [Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:24:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:24:02 +0000 Subject: [Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:27:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:27:24 +0000 Subject: [Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:30:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:30:11 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #47 from Marcel de Rooy --- Please add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:48:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:48:32 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- > 5) After printing is complete, you should still be on the OPAC basket > pop-up The popup is still open, but I did not return to it. (Chrome, FF) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:54:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:54:55 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 --- Comment #15 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #13) > I redid the second patch from scratch as it did no longer apply. You made a mistake: Patch 2 was: From: Owen Leonard Date: Wed, 30 May 2018 14:18:43 +0000 Subject: [PATCH] Bug 16575: (follow-up) Compiled CSS This patch contains the compiled CSS for the OPAC print stylesheet. --- koha-tmpl/opac-tmpl/bootstrap/css/print.css | 2 +- But it became (you changed ANOTHER file): From: Katrin Fischer Date: Sun, 8 Jul 2018 01:21:23 +0000 Subject: [PATCH 2/2] Bug 16575: (follow-up) Compiled CSS This patch contains the compiled CSS for the OPAC print stylesheet. --- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:55:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:55:11 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 08:55:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 06:55:18 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 09:18:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 07:18:45 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 09:18:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 07:18:49 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76770|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 76932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76932&action=edit Bug 20814: Display issue with 'Saved reports' tabs when memcached is off This patch changes the configuration of the saved reports table so that columns which were previously excluded from the table altogether are now hidden. This prevents a JavaScript error when DataTables tries to reference a missing column. To test, apply the patch and go to Reports -> Use saved. You should have at least one report category configured and assigned to reports in order for the tabs display to be visible. Test the table of saved reports under a variety of these circumstances: - memcached disabled or enabled - reports exist or don't exist which require update from the old marcxml syntax - cache_expiry and/or update columns are configured in Administration -> Columns settings to be shown or hidden The report category tabs and the table should render correctly under all circumstances. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 09:19:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 07:19:47 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 09:19:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 07:19:26 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 --- Comment #6 from Marcel de Rooy --- Memcache should not be off anymore, but this does not hurt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 09:35:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 07:35:07 +0000 Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #116 from Victor Grousset/tuxayo --- Created attachment 76933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76933&action=edit Bug 12310: (follow-up) Add relevant sysprefs to HEA DecimalSeparators: the new one CurrencyFormat: related because it's the display format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 09:38:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 07:38:27 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 --- Comment #16 from Katrin Fischer --- Hm, what I did was skipping the second original patch as it didn't apply and running the opac-less command - strange that I came out with a changed file anyway. I would have expected an empty file. And also a bit strange that the print file was not regenerated, have to investigate. Thx for noticing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 09:44:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 07:44:02 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 --- Comment #17 from Katrin Fischer --- not an empty file, but no changed in the one I actually committed... sorry for being unclear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 09:45:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 07:45:30 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #19 from Marcel de Rooy --- Chris: I have the impression that you are clearing the wrong variables at the end of the for loop. You undef image, alt_image and binary_data. These three vars are all created in the for loop. I guess they should not present a problem? But $image_data is created outside the loop and is not cleared. Isn't that the cause of the issue? Look at my $binary_data = $image_data->{'imagefile'} Since $image_data is not cleared, bad things may still happen?? Changing status for feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 09:46:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 07:46:36 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 09:47:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 07:47:13 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #20 from Marcel de Rooy --- (In reply to Chris Nighswonger from comment #17) > Some kind soul please correct the spelling of "relegated" on line 180 during > QA! Your kind soul? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:06:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:06:58 +0000 Subject: [Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #117 from Victor Grousset/tuxayo --- In HEA I've added the sysprefs next to other i18n ones. And added CurrencyFormat as it's somewhat linked with the one introduced by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:29:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:29:36 +0000 Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #40 from Julian Maurice --- Created attachment 76934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76934&action=edit Bug 20988: Add template macros to ease template rewriting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:30:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:30:13 +0000 Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76335|0 |1 is obsolete| | Attachment #76336|0 |1 is obsolete| | Attachment #76337|0 |1 is obsolete| | Attachment #76338|0 |1 is obsolete| | Attachment #76339|0 |1 is obsolete| | Attachment #76340|0 |1 is obsolete| | Attachment #76341|0 |1 is obsolete| | Attachment #76342|0 |1 is obsolete| | Attachment #76343|0 |1 is obsolete| | Attachment #76344|0 |1 is obsolete| | Attachment #76345|0 |1 is obsolete| | Attachment #76346|0 |1 is obsolete| | Attachment #76347|0 |1 is obsolete| | Attachment #76348|0 |1 is obsolete| | Attachment #76349|0 |1 is obsolete| | Attachment #76350|0 |1 is obsolete| | Attachment #76351|0 |1 is obsolete| | Attachment #76352|0 |1 is obsolete| | Attachment #76353|0 |1 is obsolete| | Attachment #76354|0 |1 is obsolete| | Attachment #76355|0 |1 is obsolete| | Attachment #76356|0 |1 is obsolete| | Attachment #76357|0 |1 is obsolete| | Attachment #76358|0 |1 is obsolete| | Attachment #76359|0 |1 is obsolete| | Attachment #76360|0 |1 is obsolete| | Attachment #76361|0 |1 is obsolete| | Attachment #76362|0 |1 is obsolete| | Attachment #76363|0 |1 is obsolete| | Attachment #76364|0 |1 is obsolete| | Attachment #76365|0 |1 is obsolete| | Attachment #76934|0 |1 is obsolete| | --- Comment #41 from Julian Maurice --- Created attachment 76935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76935&action=edit Bug 20988: Add template macros to ease template rewriting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:32:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:32:39 +0000 Subject: [Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:32:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:32:43 +0000 Subject: [Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76772|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 76936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76936&action=edit Bug 20805: Update child to adult patron process broken on several patron-related pages This patch fixes a problem with several patron-related pages, where the "Update child to adult patron" menu item doesn't work. With some pages, the right category information wasn't being passed from the script to the template. With some, the right JavaScript variable weren't being passed from the template to the included JavaScript file. To test, apply the patch locate some patrons with "child" type patron categories. With each patron, go to one of the following pages and test the "update child" process in the toolbar's "More" menu. - Circulation -> - Batch check out - Notices - Statistics - Files - Housebound - Delete (test from the deletion confirmation screen). All test should be performed on a system with multiple adult patron categories configured AND on a system with only a single adult patron category. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:32:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:32:29 +0000 Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #42 from Julian Maurice --- There's a new version of koha-i18n, written in Perl this time. It is available at the same URL (https://github.com/jajm/koha-i18n). It tries to wrap longer strings, so it should address comment 36. I obsoleted all generated patches, the result can be seen here: https://gitlab.com/jajm/Koha/commits/bug/20988 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:32:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:32:52 +0000 Subject: [Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:55:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:55:43 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76764|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy --- Created attachment 76937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76937&action=edit Bug 18822 - Better error response Apply this patch first to see a change in the error feedback - instead of [Object object] you should get a text readable error Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:55:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:55:39 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:55:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:55:48 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76765|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Created attachment 76938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76938&action=edit Bug 18822: Check if we have MARC::Record and convert if not when using ES The new_record_from_zebra subroutine assumes that when using ES we always get MARC::Record objects when using ES, but sometimes we get them as xml via Z39 or internally. This adds a test to new_from_zebra to confirm we have a record object and to convert it if not To test: 1 - Perform an advanced search from the advanced editor, make sure to select 'Local catalog' and a remote source 2 - Error 'Internal search error [Object object]' 3 - Apply patch 4 - Repeat search, success! 5 - Select and deselect various servers, search should still work Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:57:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:57:01 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 --- Comment #21 from Marcel de Rooy --- Second patch: no eval around new_from_xml as in the Zebra counterpart. No blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:57:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:57:16 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 10:59:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 08:59:37 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:26:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:26:37 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:30:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:30:07 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- >From the plack counterpart: RewriteCond %{REQUEST_URI} !^/api/v[0-1]+/app.pl RewriteRule ^/api/(v[0-9]+)/(.*)$ /api/$1/app.pl/api/$1/$2 [L,PT] >From your patch: RewriteCond %{REQUEST_URI} !^/api/v[0-1]+/app.pl RewriteRule ^(v[0-9]+)/(.*)$ /api/$1/app.pl/api/$1/$2 [L] Not the same. You start with v[0-9] which seems to be wrong ;) How did you test? Note btw that v[0-9]+ may not be what we want. It covers v987654321 for instance. We do not have v0, but only v1. Hoping for v2 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:31:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:31:59 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement CC| |m.de.rooy at rijksmuseum.nl --- Comment #15 from Marcel de Rooy --- Moving to enh Please explain why it should be seen as a bugfix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:34:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:34:33 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |lisetteslatah at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:35:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:35:05 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lisetteslatah at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:47:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:47:27 +0000 Subject: [Koha-bugs] [Bug 20772] Bib metadata pertaining to an ILL request should be editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 Niamh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:50:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:50:13 +0000 Subject: [Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 --- Comment #3 from Martin Renvoize --- Created attachment 76939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76939&action=edit Bug 20773: (followup) Remove MySQLism -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:50:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:50:34 +0000 Subject: [Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:54:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:54:16 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Marcel de Rooy --- Line 680 still contains: [% IF s.authorised_value == selected_status %] Around line 308 you are replacing it by suggestion.STATUS. Please explain. If I am not mistaken, it comes from: my $suggestion_ref = $input->Vars; Where is the field STATUS filled? See the following warn when I haved added an additional status and I am saving a suggestion with that status. No suggestions TEST3 letter transported by email at /usr/share/koha/devclone/C4/Letters.pm line 602. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:54:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:54:32 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 11:54:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 09:54:39 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:16:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:16:11 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #1 from Andrew Isherwood --- Created attachment 76940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76940&action=edit Bug 21063: Add "Columns settings" for ILL This patch adds the "Columns settings" values for the illrequests table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:16:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:16:23 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #2 from Andrew Isherwood --- Created attachment 76941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76941&action=edit Bug 21063: Add ability to show / hide columns This patch adds the "Column visibility" functionality to the main ILL request list table. To test: - Ensure ILL is enabled and you have some requests - Apply patch - From the "Koha administration screen, select "Configure columns" - In the "Columns settings" page: => TEST: Ensure an "Interlibrary loans" category exists - Upon expanding the category: => TEST: Ensure a table is displayed showing columns => TEST: Ensure the "action" column has "Cannot be toggled" pre-selected => TEST: Change values for columns and ensure they're saved - From the main staff menu, select "ILL requests" - In the table: => TEST: Click the "Column visibility" button and ensure a modal containing all columns (except "Action") is displayed => TEST: Select various columns and ensure they are shown and hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:16:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:16:57 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:20:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:20:34 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #21 from Chris Nighswonger --- Changing status to more accurately reflect the current discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:22:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:22:50 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:22:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:22:59 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76941|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:23:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:23:11 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:27:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:27:03 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #15 from Marcel de Rooy --- (In reply to Jon Knight from comment #14) > Do we need to keep a copy of the template in use during the consent in the > database along with the borrower ID and date? The UK ICO page on consenting > seems to say we do: > > https://ico.org.uk/for-organisations/guide-to-the-general-data-protection- > regulation-gdpr/consent/how-should-we-obtain-record-and-manage-consent/ > > (second example). Thx for your interest in this patch. The link says: === If consent was given online, your records should include the data submitted as well as a timestamp to link it to the relevant version of the data capture form. You keep records that include an ID and the data submitted online together with a timestamp. You also keep a copy of the version of the data-capture form and any other relevant documents in use at that date. === This patch registers the borrower ID and the timestamp of consent given. What each library should keep somehow (not described), is: a version history of the template, esp. the exact text for the consent and a history of the referenced privacy page text. In that way you can 'prove' that the user gave consent for a specific version of template and privacy page. (Note: the privacy page is only specified in this patch by a preference called PrivacyPolicyURL. The library itself should create that local page.) I am no legal expert, but I can't imagine that we need to save these texts at an individual consent level. Hope this is clear enough? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:31:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:31:56 +0000 Subject: [Koha-bugs] [Bug 20975] Improve auto escaping performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- (In reply to Jonathan Druart from comment #7) > The performances are good, I guess it helps to avoid 1 object creation > (::Escaped::HTML) by variable. It's actually worse than that. Template::Stash::AutoEscaping creates an object for each string concatenation, and Template::Toolkit concatenates stuff to its internal buffer all the time. I ran benchmark_AutoEscaping.pl (using Template::Stash::AutoEscaping) with NYTProf and it spends most of the time in Template::Stash::AutoEscaping::Escaped::Base::concat (63% of total time) where it creates 50000 new objects. But apparently most of the time here is spent doing simple string concatenation. (not so) fun fact: the "HTML-escaping" process represents less than 3% of concat in terms of time spent. I don't know how (or if) this can be improved, but I think the time loss is not acceptable, and unless we find a better solution we should keep using html filter manually (and probably add a rule in coding guidelines) Note that we can use TT filters as blocks, like this: [% FILTER html %] [% this_will_be_escaped %] and [% this.will(be).escaped | too %] [% END %] Maybe this could reduce the hassle of writing "|html" everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:33:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:33:53 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #3 from Andrew Isherwood --- Created attachment 76942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76942&action=edit Bug 21063: Add "Columns settings" for ILL This patch adds the "Columns settings" values for the illrequests table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:34:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:34:05 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #4 from Andrew Isherwood --- Created attachment 76943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76943&action=edit Bug 21063: Add ability to show / hide columns This patch adds the "Column visibility" functionality to the main ILL request list table. To test: - Ensure ILL is enabled and you have some requests - Apply patch - From the "Koha administration screen, select "Configure columns" - In the "Columns settings" page: => TEST: Ensure an "Interlibrary loans" category exists - Upon expanding the category: => TEST: Ensure a table is displayed showing columns => TEST: Ensure the "action" column has "Cannot be toggled" pre-selected => TEST: Change values for columns and ensure they're saved - From the main staff menu, select "ILL requests" - In the table: => TEST: Click the "Column visibility" button and ensure a modal containing all columns (except "Action") is displayed => TEST: Select various columns and ensure they are shown and hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:34:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:34:24 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:40:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:40:26 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #22 from Chris Nighswonger --- (In reply to Marcel de Rooy from comment #19) > Chris: > I have the impression Just an impression? ;-) Did you test and find a case where this fix does not work? that you are clearing the wrong variables at the end > of the for loop. You undef image, alt_image and binary_data. These three > vars are all created in the for loop. I guess they should not present a > problem? But $image_data is created outside the loop and is not cleared. > Isn't that the cause of the issue? I don't think so. > > Look at > my $binary_data = $image_data->{'imagefile'} > > Since $image_data is not cleared, bad things may still happen?? $binary_data is a reference to $image_data->{'imagefile'} which, in turn, is a reference to a hash created by DBI containing the results of the SELECT. DBI creates a new hash on every row retrieval[1], ensuring that the data contained at our reference is fresh every time. Image::Magick, on the other hand, does not automatically "destroy" the original structure on each call, and so we need to take care of that.[2] [1] "By default a reference to a new hash is returned for each row." https://metacpan.org/pod/DBI#fetchrow_hashref [2] "Once you are finished with a PerlMagick object you should consider destroying it." http://www.graphicsmagick.org/perl.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:53:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:53:41 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org --- Comment #16 from Jonathan Druart --- I do not have time to work more on this script. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:55:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:55:27 +0000 Subject: [Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:55:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:55:29 +0000 Subject: [Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 --- Comment #6 from Kyle M Hall --- Created attachment 76944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76944&action=edit Bug 20718: Add missing POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:55:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:55:37 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #48 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #47) > Please add unit tests Switching to NSO, I'd like a confirmation that the code is doing what we are expecting it to do. Then I will try to provide tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 12:58:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 10:58:06 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #16 from Nick Clemens --- (In reply to Marcel de Rooy from comment #15) > Moving to enh > Please explain why it should be seen as a bugfix. The naming and use of this field has caused a lot of confusion for libraries - They enter a price here, expecting it to be used as the 'replacementprice' in the item record, however, it is used as the cost for the order. They generally expect the cost to be the vendor price or something else. I consider a bug as it doesn't behave in the manner expected by the end user. Changes on 13321 also changed the way fields behaved (rrp is now basis for order calculation) and this restores some functionality that was expected by users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:07:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:07:48 +0000 Subject: [Koha-bugs] [Bug 20773] bug 20724 follow-up - Database cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:15:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:15:15 +0000 Subject: [Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Jonathan Druart --- Upping severity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:17:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:17:36 +0000 Subject: [Koha-bugs] [Bug 21071] New: Search results not sorting in staff client advanced search when only AdvancedSearchTypes checkboxes are used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21071 Bug ID: 21071 Summary: Search results not sorting in staff client advanced search when only AdvancedSearchTypes checkboxes are used Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: lucy.vaux-harvey at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Sorting of search results in the staff client advanced search does not work if you run a search using ONLY the Item types/Shelving locations/Collections checkbox limiters. Reported on 17.11.05. Tested and works correctly at 17.05. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:19:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:19:02 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:24:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:24:26 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #21 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:24:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:24:37 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:24:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:24:58 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:25:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:25:10 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #23 from Katrin Fischer --- Pushing this back into the QA queue (for discussion between QA and developer we usually don't use "In Discussion" - only when you can't agree) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:25:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:25:15 +0000 Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:25:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:25:30 +0000 Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:26:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:26:04 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:25:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:25:47 +0000 Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:26:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:26:20 +0000 Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #17 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:26:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:26:37 +0000 Subject: [Koha-bugs] [Bug 21009] Max length of inputs on editing/adding items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:26:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:26:58 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:27:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:27:12 +0000 Subject: [Koha-bugs] [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:27:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:27:24 +0000 Subject: [Koha-bugs] [Bug 6647] Label item search should use standard pagination routine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:27:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:27:37 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #12 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #11) > Line 680 still contains: > [% IF s.authorised_value == selected_status %] > Around line 308 you are replacing it by suggestion.STATUS. Please explain. > If I am not mistaken, it comes from: my $suggestion_ref = $input->Vars; > Where is the field STATUS filled? 361 suggestion => $suggestion_ref, > See the following warn when I haved added an additional status and I am > saving a suggestion with that status. > No suggestions TEST3 letter transported by email at > /usr/share/koha/devclone/C4/Letters.pm line 602. I guess this existed prior to this change. It looks like a configuration issue, or an expected behavior, ModSuggestion is sending an email to the author of the suggestion when the status is changed. The notice template used is the one with the same code as the status (that is pretty bad, it should at least be prefixed by something). I would not consider this as blocker for this bugfix/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 13:46:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 11:46:52 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart --- (In reply to Lisette Scheer from comment #10) > Created attachment 76925 [details] > Multiple Status Unknown tabs This is very weird. I do not have access to sandbox and cannot recreate locally so it's hard help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 14:19:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 12:19:47 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #17 from Martin Renvoize --- >From a RMaint perspective, I agree that I'd treat it as an enhancement. Although it's somewhat of a bugfix in that it makes functionality clearer, it is a change of said functionality which has been in stable branches for long enough that it would not be an expected change on a stable branch only receiving bugfixes. I'd look at it as a positive being an enhancement.. we can advertise it as such for the next release and give it the attention it deserves in the release notes ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 14:30:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 12:30:04 +0000 Subject: [Koha-bugs] [Bug 21072] New: Should not show 'Update patron to adult' if no adult patron categories Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21072 Bug ID: 21072 Summary: Should not show 'Update patron to adult' if no adult patron categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1 - Remove or change all 'Adult' patron categories 2 - Find or create a 'Child' patron whose age is above the category limit 3 - Go to patron details 4 - Click 'Update child to adult patron' 5 - Internal server error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 14:30:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 12:30:15 +0000 Subject: [Koha-bugs] [Bug 21072] Should not show 'Update patron to adult' if no adult patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21072 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 14:31:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 12:31:14 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #18 from Martin Renvoize --- If I had my QA hat on, I'd be asking for a corresponding documentation update patch linked to here (as a merge request on the gitlab koha-manual) and some release notes text summarising the change. I'd also be interested to understand whether we ought to also include a DB update script which moved the rrp value's into replacementprice field as that's what the functional change appears to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 14:35:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 12:35:41 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 14:43:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 12:43:03 +0000 Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639 --- Comment #19 from Katrin Fischer --- As it includes database changes and such I would not backport it. I think it's somewhat in a grey area between enh and bug. Too much of a change for a backport is my feel, but not a strict enh either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 14:55:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 12:55:18 +0000 Subject: [Koha-bugs] [Bug 21073] New: Improve plugin performance Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Bug ID: 21073 Summary: Improve plugin performance Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Right now, to check if a plugin is functional and what methods it exposes we load the module and test for a given method at run time. This is highly inefficient. It makes far more sense to do this at install time and store the data in the db. I believe we should store a table of methods that each plugin exposes and check that instead. Then, at install time we can test that a) the plugin can be loaded and b) add the available methods to the plugin_methods table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 14:55:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 12:55:24 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:08:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:08:29 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75811|0 |1 is obsolete| | Attachment #75812|0 |1 is obsolete| | Attachment #75822|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 76945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76945&action=edit Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:08:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:08:35 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #26 from Jonathan Druart --- Created attachment 76946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76946&action=edit Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:08:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:08:41 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #27 from Jonathan Druart --- Created attachment 76947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76947&action=edit Bug 12159: (QA follow-up) Silencing POD warn from qa tools *** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:10:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:10:05 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #28 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:16:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:16:04 +0000 Subject: [Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:47:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:47:04 +0000 Subject: [Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:47:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:47:18 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:47:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:47:30 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:48:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:48:22 +0000 Subject: [Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:48:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:48:31 +0000 Subject: [Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:48:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:48:51 +0000 Subject: [Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:48:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:48:59 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:49:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:49:20 +0000 Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:49:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:49:24 +0000 Subject: [Koha-bugs] [Bug 21074] New: (just a try) Display sparql data from wikidata or bnf Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21074 Bug ID: 21074 Summary: (just a try) Display sparql data from wikidata or bnf Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: claire.hernandez at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:49:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:49:35 +0000 Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:49:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:49:43 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:49:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:49:58 +0000 Subject: [Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:50:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:50:32 +0000 Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:53:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:53:07 +0000 Subject: [Koha-bugs] [Bug 21074] (just a try) Display sparql data from wikidata or bnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21074 --- Comment #1 from claire.hernandez at biblibre.com --- Created attachment 76948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76948&action=edit victor hugo biblio with wikidata informations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:53:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:53:36 +0000 Subject: [Koha-bugs] [Bug 21074] (just a try) Display sparql data from wikidata or bnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21074 --- Comment #2 from claire.hernandez at biblibre.com --- Created attachment 76949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76949&action=edit harry potter biblio with wikidata informations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:54:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:54:00 +0000 Subject: [Koha-bugs] [Bug 21074] (just a try) Display sparql data from wikidata or bnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21074 --- Comment #3 from claire.hernandez at biblibre.com --- Created attachment 76950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76950&action=edit harry potter biblio with bnf informations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 15:54:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 13:54:26 +0000 Subject: [Koha-bugs] [Bug 21074] (just a try) Display sparql data from wikidata or bnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21074 --- Comment #4 from claire.hernandez at biblibre.com --- Created attachment 76951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76951&action=edit victor hugo biblio with bnf information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 16:05:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 14:05:18 +0000 Subject: [Koha-bugs] [Bug 21074] (just a try) Display sparql data from wikidata or bnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21074 --- Comment #5 from claire.hernandez at biblibre.com --- Created attachment 76952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76952&action=edit Bug 21074 - Display sparql data from wikidata or bnf Exploration of how I could integrate live data from a sparql endpoint. - "Wikidata is a free and open knowledge base that can be read and edited by both humans and machines. Wikidata acts as central storage for the structured data of its Wikimedia sister projects including Wikipedia, Wikivoyage, Wikisource, and others." - Bnf is the french national library Have a look to page examples in attachment. For a biblio: - checks if there is an ark - try to grab data about the work or expression - get the author id - try to grab data about the author - display what you have in a div in the opac - there is a button to display some debug things We can imagine whatever we want with linked data. This is just a simple example. We could mix the data sources and think to the way to display pertinent information to the borrower to explore new reading (or other) paths. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 16:44:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 14:44:13 +0000 Subject: [Koha-bugs] [Bug 21075] New: AutoUnsuspendHolds should unsuspend holds <= today Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Bug ID: 21075 Summary: AutoUnsuspendHolds should unsuspend holds <= today Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This is an issue because of the datepicker on the holds page in intranet - it doesn't allow you to select today's date, so it sets the date to tomorrow, if you then update another hold you have just extended the suspension - and it can keep happening. To recreate: 1 - Place a hold in your system 2 - Set that hold (or all holds) to expire today update reserves set suspend_until=CONCAT( CURDATE()," 00:00:00"); 3 - Run misc/cronjobs/holds/auto_unsuspend_holds.p 4 - Note the hold is sitll suspended 5 - Visit /cgi-bin/koha/reserve/request.pl for the book with the hold 6 - Note the suspend date is tomorrow (and cannot be set to today] 7 - Click update holds - the date in db is now set to tomorrow -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 17:15:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 15:15:04 +0000 Subject: [Koha-bugs] [Bug 21075] AutoUnsuspendHolds should unsuspend holds <= today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 --- Comment #1 from Nick Clemens --- Created attachment 76953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76953&action=edit Bug 21075: AutoUnsuspendHolds should unsuspend holds <= today To recreate: 1 - Place a hold in your system 2 - Set that hold (or all holds) to expire today update reserves set suspend_until=CONCAT( CURDATE()," 00:00:00"); 3 - Run misc/cronjobs/holds/auto_unsuspend_holds.p 4 - Note the hold is sitll suspended 5 - Visit /cgi-bin/koha/reserve/request.pl for the book with the hold 6 - Note the suspend date is tomorrow (and cannot be set to today] 7 - Click update holds - the date in db is now set to tomorrow 8 - Reset to today 9 - Apply patch 10 - Run the cron again 11 - Visit the page and note hold is unsuspended -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 17:15:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 15:15:07 +0000 Subject: [Koha-bugs] [Bug 19676] Debian 9 vs. Plack vs. /tmp -- attention to PrivateTmp for apache2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19676 Pongtawat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pongtawat at punsarn.asia Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Pongtawat --- *** This bug has been marked as a duplicate of bug 20428 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 17:15:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 15:15:09 +0000 Subject: [Koha-bugs] [Bug 21075] AutoUnsuspendHolds should unsuspend holds <= today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 --- Comment #2 from Nick Clemens --- Created attachment 76954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76954&action=edit Bug 21075: Unit tests prove -v t/db_dependent/Reserves/AutoUnsuspendReserves.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 17:15:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 15:15:07 +0000 Subject: [Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 Pongtawat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com --- Comment #56 from Pongtawat --- *** Bug 19676 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 17:15:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 15:15:02 +0000 Subject: [Koha-bugs] [Bug 21075] AutoUnsuspendHolds should unsuspend holds <= today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 17:18:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 15:18:24 +0000 Subject: [Koha-bugs] [Bug 21075] AutoUnsuspendHolds should unsuspend holds <= today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 18:10:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 16:10:29 +0000 Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not enforced after item is captured for hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- I would not classify this as a minor bug. If limits are not being enforced in all conditions, this is a problem. At the very least, there needs to be a preference to change this oversight, if for some reason there is justification to keep this unusual behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 19:28:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 17:28:13 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #1 from Kyle M Hall --- Created attachment 76955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76955&action=edit Bug 21073: Add new table, schema and classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 19:28:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 17:28:24 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #2 from Kyle M Hall --- Created attachment 76956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76956&action=edit Bug 21073: Improve plugin performance Right now, to check if a plugin is functional and what methods it exposes we load the module and test for a given method at run time. This is highly inefficient. It makes far more sense to do this at install time and store the data in the db. I believe we should store a table of methods that each plugin exposes and check that instead. Then, at install time we can test that a) the plugin can be loaded and b) add the available methods to the plugin_methods table. Test Plan: 1) Apply this patch 2) Restart all the things 3) Run updatedatabase.pl 4) Verify you can use existing plugins 5) Verify you can install new plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 19:28:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 17:28:34 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 19:37:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 17:37:58 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76955|0 |1 is obsolete| | Attachment #76956|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 76957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76957&action=edit Bug 21073: Add new table, schema and classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 19:38:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 17:38:11 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 --- Comment #4 from Kyle M Hall --- Created attachment 76958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76958&action=edit Bug 21073: Improve plugin performance Right now, to check if a plugin is functional and what methods it exposes we load the module and test for a given method at run time. This is highly inefficient. It makes far more sense to do this at install time and store the data in the db. I believe we should store a table of methods that each plugin exposes and check that instead. Then, at install time we can test that a) the plugin can be loaded and b) add the available methods to the plugin_methods table. Test Plan: 1) Apply this patch 2) Restart all the things 3) Run updatedatabase.pl 4) Verify you can use existing plugins 5) Verify you can install new plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 19:49:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 17:49:01 +0000 Subject: [Koha-bugs] [Bug 21076] New: Javascript error on article requests page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21076 Bug ID: 21076 Summary: Javascript error on article requests page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com TypeError: $(...).autocomplete(...).data(...) is undefined[Learn More] Calling code on patron search box when not always present -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 19:51:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 17:51:20 +0000 Subject: [Koha-bugs] [Bug 21076] Javascript error on article requests page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21076 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 19:51:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 17:51:22 +0000 Subject: [Koha-bugs] [Bug 21076] Javascript error on article requests page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21076 --- Comment #1 from Nick Clemens --- Created attachment 76959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76959&action=edit Bug 21076: Don't call autocomplete code after patron found To test: 1 - Enable article requests 2 - Search on staff client 3 - Click 'Request article' 4 - Find a patron 5 - View error in console 6 - Apply patch 7 - Reload 8 - Not error is gone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 21:08:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 19:08:19 +0000 Subject: [Koha-bugs] [Bug 21075] AutoUnsuspendHolds should unsuspend holds <= today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Pierre-Luc Lapointe changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76954|0 |1 is obsolete| | --- Comment #3 from Pierre-Luc Lapointe --- Created attachment 76960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76960&action=edit Bug 21075: Unit tests prove -v t/db_dependent/Reserves/AutoUnsuspendReserves.t Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 21:08:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 19:08:29 +0000 Subject: [Koha-bugs] [Bug 21075] AutoUnsuspendHolds should unsuspend holds <= today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Pierre-Luc Lapointe changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-luc.lapointe at inLibro | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 21:21:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 19:21:29 +0000 Subject: [Koha-bugs] [Bug 21053] editing 008 field with a hash overwrites data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 21:21:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 19:21:32 +0000 Subject: [Koha-bugs] [Bug 21053] editing 008 field with a hash overwrites data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76873|0 |1 is obsolete| | --- Comment #2 from Maryse Simard --- Created attachment 76961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76961&action=edit Bug 21053: Encode URI characters in plugin 008 A # (or &) at any position in 008 field of a bib record causes all subsequent data in field to be overwritten with default values when record is saved. These characters need to be correctly encoded before being passed as parameters of the url To reproduce: 1. Find and edit a bib record which has an 008 which differs from the default values for the MARC framework 2. Choose 008 helper 3. Add # in any position before the end of the field noting the current values of the data 4. Save record 5. Edit record and select 008 helper 6. Review characters after # Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 21:28:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 19:28:16 +0000 Subject: [Koha-bugs] [Bug 21076] Javascript error on article requests page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21076 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 21:28:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 19:28:19 +0000 Subject: [Koha-bugs] [Bug 21076] Javascript error on article requests page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21076 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76959|0 |1 is obsolete| | --- Comment #2 from Maryse Simard --- Created attachment 76962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76962&action=edit Bug 21076: Don't call autocomplete code after patron found To test: 1 - Enable article requests 2 - Search on staff client 3 - Click 'Request article' 4 - Find a patron 5 - View error in console 6 - Apply patch 7 - Reload 8 - Not error is gone Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 21:28:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 19:28:20 +0000 Subject: [Koha-bugs] [Bug 21064] Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Pierre-Luc Lapointe changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76882|0 |1 is obsolete| | --- Comment #2 from Pierre-Luc Lapointe --- Created attachment 76963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76963&action=edit Bug 21064: Use undefined instead of undef To test: 1 - Load the advanced cataloging editor 2 - Refresh the page several times 3 - Check the JS console, you shoudl see an error: 'undef is not defined' 4 - Apply patch 5 - Try again, should be no error Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 21:28:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 19:28:31 +0000 Subject: [Koha-bugs] [Bug 21064] Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Pierre-Luc Lapointe changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-luc.lapointe at inLibro | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 21:44:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 19:44:44 +0000 Subject: [Koha-bugs] [Bug 21035] runreport.pl prints only a newline when printing a row that has a field that contains an embedded newline. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21035 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76698|0 |1 is obsolete| | --- Comment #2 from Maryse Simard --- Created attachment 76964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76964&action=edit Bug 21035: Handle new lines when running reports See https://metacpan.org/pod/Text::CSV_XS#Embedded-newlines Test plan: 1) Choose two items, say barcode '123' and '456' 2) Change the public note on 123 to read Line1 Line2 (I.e. type 'Line1', then press Enter, type 'Line2' and click update). 3) Change the public note on 456 to read Public note has one and only one line. Click update. 4) Create a report with the followng query: select barcode, itemnotes from items where barcode in ( '123', '456' ) Let's say that this is report number 10. 5) run ./misc/cronjobs/runreport.pl --format=csv REPORT_ID: => You should see both lines Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 21:44:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 19:44:42 +0000 Subject: [Koha-bugs] [Bug 21035] runreport.pl prints only a newline when printing a row that has a field that contains an embedded newline. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21035 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 23:15:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 21:15:12 +0000 Subject: [Koha-bugs] [Bug 21077] New: Fix comment for statistics.type in installer/data/mysql/kohastructure.sql Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21077 Bug ID: 21077 Summary: Fix comment for statistics.type in installer/data/mysql/kohastructure.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In installer/data/mysql/kohastructure.sql, the CREATE TABLE statement for statistics reads: DROP TABLE IF EXISTS `statistics`; CREATE TABLE `statistics` ( -- information related to transactions (circulation and fines) in Koha ... `type` varchar(16) default NULL, -- transaction type (locause, issue, return, renew, writeoff, payment, Credit*) ... There's a typo for 'locause', this should be 'localuse'. Also, 'Credit*' is never used. As far as I know, the list of valid values for statistics.type isn't documented anywhere else, so it's valuable to have these annotated correctly here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jul 13 23:26:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jul 2018 21:26:51 +0000 Subject: [Koha-bugs] [Bug 21077] Fix comment for statistics.type in installer/data/mysql/kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21077 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 13:38:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 11:38:00 +0000 Subject: [Koha-bugs] [Bug 11889] Disown a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #38 from Katrin Fischer --- I am ok with your suggestion in comment#35. I was only suggesting to maybe reuse the Anonymous patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 13:51:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 11:51:04 +0000 Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 --- Comment #60 from Katrin Fischer --- > Thus, I am wondering what it is about the 999$c that permits an > auto-generated unique identifier to be created when it can not be created in > the 001, and if anything can be done to either duplicate the 999$c into the > 001 or use the 001 instead of the 999$c. The biblionumber is not a sequentially created number of the application, but it's the primary key assigned by the database. That's why it will only be set after saving a record for the first time - before it doesn't exist. I strongly advise against trying to change the configuration to use 001 instead, because the indexing won't match and you will get a lot of hard to fix problems. Indexing relies on the biblionumber to be in 999$c and you can't map 2 fields at the time (so duplicating won't work). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 13:55:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 11:55:42 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 --- Comment #21 from Katrin Fischer --- > So is this still a problem in Koha 17.11.06? I don't want to take the time > to scan thousands of items just to have it not work (again.) I believe I was > using 17.05 the last time it did not work. What do we need to do to get the > results from the inventory process? Not having this ability really limits > the usefulness of Koha I think noone was able to retest this yet. If you have a test system available to you, you could create a report in order to get a long list of barcodes and test with that. That could help to verify if the bug still exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 14:01:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 12:01:28 +0000 Subject: [Koha-bugs] [Bug 5594] Option to configure default sort order for items on bib records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594 --- Comment #3 from Katrin Fischer --- For the default sort order there is: OPACHoldingsDefaultSortField But I tihnk this is more about having a better sort for enumchron? This is sorted alphabetically right now, anything else is hard for a free text field. If enumchron was created by serials, we could maybe use fields from serial to sort better, but that would not be an easy development I think. Should we change the bug title to refer to enumchron specifically or move this to a separate bug maybe? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 14:08:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 12:08:58 +0000 Subject: [Koha-bugs] [Bug 21044] Error 400 'broken link' when enabling SSL from end to end In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Henri, Koha works well with https, we have always been running it with https on both staff and opac since 3.2. And there should be no hardcoded http. Sadly I can't tell you what went wrong for you - please bring this to the mailing list where many more people will read it and be able to offer suggestions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 14:10:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 12:10:05 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 14:18:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 12:18:56 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #29 from Katrin Fischer --- Why BLOCKED? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 14:21:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 12:21:37 +0000 Subject: [Koha-bugs] [Bug 5594] Option to configure default sort order for items on bib records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13420 --- Comment #4 from Katrin Fischer --- Ah, actually we got a bug already for sorting on volume information: bug 13420 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 14:21:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 12:21:37 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5594 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 14:26:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 12:26:32 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 --- Comment #11 from Katrin Fischer --- The bug title is not very descrpitive, maybe fix in order to lure testers in? Should this still be "In discussion" or NSO? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 14:33:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 12:33:28 +0000 Subject: [Koha-bugs] [Bug 15704] split up 264 index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 --- Comment #5 from Katrin Fischer --- >Am I doing something wrong here? Why is it showing up on my master? How did you search for it? Since we switched to dom indexing you can always search everything in the record within the keyword index, so it should always show up. There also was bug 14198. The interesting question is if you can find it in the specific indexes for place, year and publisher. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 14:38:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 12:38:13 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 --- Comment #16 from Katrin Fischer --- (In reply to Fridolin SOMERS from comment #15) > Can you confirm this depends on Bug 14826 ? Yes, it's a problem since account_offsets was reintroduced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 16:29:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 14:29:49 +0000 Subject: [Koha-bugs] [Bug 21078] New: Overdrive JS breaks when window opened from another site Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Bug ID: 21078 Summary: Overdrive JS breaks when window opened from another site Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries use a homepage outside of koha and a widget to open the catalog. When doing this the overdrive.js is unable to access the window.opener properties and dies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 16:32:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 14:32:51 +0000 Subject: [Koha-bugs] [Bug 21078] Overdrive JS breaks when window opened from another site In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 16:32:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 14:32:54 +0000 Subject: [Koha-bugs] [Bug 21078] Overdrive JS breaks when window opened from another site In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 --- Comment #1 from Nick Clemens --- Created attachment 76965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76965&action=edit Bug 21078: ovedrive.js Catch error if window.opener is not accessible To Test: 0 - Enable overdrive search results on your koha 1 - From an source develop a link to your koha instance that opens a new window: Test 2 - Click that link 3 - Note Overdrive results do not load 4 - Note error in JS console 5 - Apply patch 6 - Click the link again 7 - Note OD results load 8 - Note no error in console -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 16:33:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 14:33:12 +0000 Subject: [Koha-bugs] [Bug 21078] Overdrive JS breaks when window opened from another site In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 14 17:33:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 14 Jul 2018 15:33:43 +0000 Subject: [Koha-bugs] [Bug 21078] Overdrive JS breaks when window opened from another site In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21078 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 11:53:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 09:53:43 +0000 Subject: [Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 --- Comment #12 from Katrin Fischer --- Are there some plans to continue here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 15:49:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 13:49:32 +0000 Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #8 from Katrin Fischer --- Lowering severity until we have more information. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 16:18:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 14:18:11 +0000 Subject: [Koha-bugs] [Bug 20771] Incorrect wording on branch-specific notice setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20771 --- Comment #2 from Katrin Fischer --- https://gitlab.com/koha-community/koha-manual/merge_requests/139 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 17:41:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 15:41:10 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #20 from Katrin Fischer --- I feel this is not an enh as the autocomplate displays, but doesn't work without this patch. Changing to 'normal'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 17:43:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 15:43:20 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #21 from Katrin Fischer --- Sorry, but I can' test this - I switched the sort to none, but the auto-complete feature triggers the same error for the sorting. I think we need to fix this first. [Request] ** [http://localhost:9200]-[400] [query_shard_exception] No mapping found for [Heading__sort.phrase] in order to sort on, with: {"index_uuid":"FwdgBXbyRq-5E0F3sa4LTA","index":"koha_kohadev_authorities"}, called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/share/perl5/Catmandu/Store/ElasticSearch/Bag.pm line 167. With vars: {'body' => {'status' => 400,'error' => {'failed_shards' => [{'index' => 'koha_kohadev_authorities','node' => 'vSTPqetISteesIkQSA_Ehg','reason' => {'index' => 'koha_kohadev_authorities','index_uuid' => 'FwdgBXbyRq-5E0F3sa4LTA','reason' => 'No mapping found for [Heading__sort.phrase] in order to sort on','type' => 'query_shard_exception'},'shard' => 0}],'type' => 'search_phase_execution_exception','root_cause' => [{'type' => 'query_shard_exception','reason' => 'No mapping found for [Heading__sort.phrase] in order to sort on','index_uuid' => 'FwdgBXbyRq-5E0F3sa4LTA','index' => 'koha_kohadev_authorities'}],'reason' => 'all shards failed','phase' => 'query','grouped' => bless( do{\(my $o = 1)}, 'JSON::PP::Boolean' )}},'request' => {'path' => '/koha_kohadev_authorities/data/_search','qs' => {},'ignore' => [],'mime_type' => 'application/json','serialize' => 'std','body' => {'sort' => [{'Heading__sort.phrase' => 'asc'}],'size' => 50,'from' => 0,'query' => {'bool' => {'should' => [{'wildcard' => {'Heading-Main.phrase' => 'sew*'}}]}}},'method' => 'GET'},'status_code' => 400} Unable to perform your search. Please try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 17:46:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 15:46:24 +0000 Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20273 Status|Signed Off |Patch doesn't apply --- Comment #18 from Katrin Fischer --- Basic searches for authorities with a sort not being 'none' fail and block other bugs. Patches here currently don't apply, can someone take a look? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 17:46:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 15:46:24 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 17:48:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 15:48:06 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #22 from Katrin Fischer --- It seems it can't work right now without fixing authority sorting. We could also mark it BLOCKED instead if that is preferred. Hopefully it can be resolved soon! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 17:48:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 15:48:17 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:17:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:17:55 +0000 Subject: [Koha-bugs] [Bug 20974] Remove files left behind after removing Solr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Failed QA |Signed Off --- Comment #4 from Katrin Fischer --- Hi Marcel, please take a closer look. There are small differences: 1) git grep -E "INCLUDE [']?facets.inc" koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:[% INCLUDE 'facets.inc' %] This is the intranet version of the file. The patch removes from bootstrap. 2) git grep -E "INCLUDE [']?page-numbers.inc" koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: [% INCLUDE 'page-numbers.inc' %] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: [% INCLUDE 'page-numbers.inc' %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt: [% INCLUDE 'page-numbers.inc' %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:
[% INCLUDE 'page-numbers.inc' %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:
[% INCLUDE 'page-numbers.inc' %]
The file removed is from includes/search/, not includes. The file in includes is still there. 3) git grep -E "INCLUDE [']?resort_form.inc" Same for this one, the difference is includes/search vs. includes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:29:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:29:11 +0000 Subject: [Koha-bugs] [Bug 21077] Fix comment for statistics.type in installer/data/mysql/kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:29:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:29:14 +0000 Subject: [Koha-bugs] [Bug 21077] Fix comment for statistics.type in installer/data/mysql/kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21077 --- Comment #1 from Katrin Fischer --- Created attachment 76966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76966&action=edit Bug 21017: Fix database documentation for statistics.type There's a typo for 'locause', this should be 'localuse'. Also, 'Credit*' is never used. https://bugs.koha-community.org/show_bug.cgi?id=20177 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:29:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:29:30 +0000 Subject: [Koha-bugs] [Bug 21077] Fix comment for statistics.type in installer/data/mysql/kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:31:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:31:08 +0000 Subject: [Koha-bugs] [Bug 6828] Add admin dashboard for staff users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Admin Dashboard for |Add admin dashboard for |staff users. |staff users -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:33:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:33:38 +0000 Subject: [Koha-bugs] [Bug 6828] Add admin dashboard for staff users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:33:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:33:41 +0000 Subject: [Koha-bugs] [Bug 6828] Add admin dashboard for staff users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10218|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:37:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:37:38 +0000 Subject: [Koha-bugs] [Bug 6828] Add admin dashboard for staff users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #29 from Katrin Fischer --- First problem here was that there was a set of old patches not obsoleted. So the conflict was inevitable. I've fixed this, but the other patches still don't apply. @Cab - you are correct, because of the cronjob and XML file needed this is not testable by a sandbox. Generally if you are looking for some easier ones, we have a keyword "Academy" on bugzilla, that we use to mark them. If there are none, feel free to bug me and I am happy to take a look at the queue with you. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:40:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:40:51 +0000 Subject: [Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 --- Comment #2 from Katrin Fischer --- Strange, still broken for me. This is the URL: http://localhost:8081/cgi-bin/koha/labels/label-item-search.pl?batch_id=0&type=labels Looking at the source code the jquery libraries are at the bottom of the page, but there is a lot of JavaScript code above. Can you take another look and confirm you were looking on master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:43:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:43:14 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- Hi Lisette, can you share how you set up your SUGGEST_STATUS values? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:50:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:50:15 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.22 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:51:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:51:30 +0000 Subject: [Koha-bugs] [Bug 19509] Show checkout status in item search result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19509 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Hi SiobhanC, you are right, thx for pointing out the duplicate! To my knowledge this development is currently not funded/actively worked on. *** This bug has been marked as a duplicate of bug 17748 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:51:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:51:30 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #1 from Katrin Fischer --- *** Bug 19509 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 19:55:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 17:55:26 +0000 Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 --- Comment #8 from Katrin Fischer --- Is this also valid for master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:01:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:01:43 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76769|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 76967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76967&action=edit Bug 16575: (follow-up) Compiled CSS This patch contains the compiled CSS for the OPAC print stylesheet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:01:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:01:38 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:02:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:02:07 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 --- Comment #19 from Katrin Fischer --- I fixed the CSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:04:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:04:05 +0000 Subject: [Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Component|Architecture, internals, |Templates |and plumbing | --- Comment #2 from Katrin Fischer --- Is the bug that there are 2 Edit links for both that lead to the same page? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:39:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:39:07 +0000 Subject: [Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:40:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:40:04 +0000 Subject: [Koha-bugs] [Bug 20979] Error message when deleting bib attached to order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20979 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:42:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:42:08 +0000 Subject: [Koha-bugs] [Bug 21054] Extra closing body tag in sco-main.tt prevents slip printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:42:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:42:46 +0000 Subject: [Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:45:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:45:33 +0000 Subject: [Koha-bugs] [Bug 21009] Max length of inputs on editing/adding items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21009 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:51:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:51:24 +0000 Subject: [Koha-bugs] [Bug 19502] Result sets limited to 10000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #29 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:56:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:56:17 +0000 Subject: [Koha-bugs] [Bug 18250] koha-common should start after memcached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #22 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 20:58:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 18:58:15 +0000 Subject: [Koha-bugs] [Bug 20949] Koha depends on Clone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20949 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:02:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:02:13 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #15 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Cab Vinton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:02:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:02:00 +0000 Subject: [Koha-bugs] [Bug 20953] Discharge can be requested several times on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #12 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:02:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:02:41 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75855|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:02:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:02:51 +0000 Subject: [Koha-bugs] [Bug 20779] Style refresh for patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 --- Comment #16 from sandboxes at biblibre.com --- Created attachment 76968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76968&action=edit Bug 20779: Style refresh for patron detail page This patch makes style and markup changes to the patron detail page template in order to make the display of information somewhat more compact and to increase the visibility of the edit controls. To test you should enable the patronimages system preference. Apply the patch and view the detail page for a patron. - Check that the page looks correct and that sections like "Alternate address" and "Alternative contact" are empty when there is no data. - Check that the "Manage patron image" tool works correctly. Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:04:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:04:27 +0000 Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:07:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:07:23 +0000 Subject: [Koha-bugs] [Bug 6647] Label item search should use standard pagination routine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:09:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:09:17 +0000 Subject: [Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #18 from Martin Renvoize --- Enhancement, not back porting to the 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:09:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:09:17 +0000 Subject: [Koha-bugs] [Bug 20942] Add route to get patron's account balance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 Bug 20942 depends on bug 20990, which changed state. Bug 20990 Summary: Add Koha::Account::outstanding_credits https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:11:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:11:40 +0000 Subject: [Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:12:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:12:52 +0000 Subject: [Koha-bugs] [Bug 21023] Remove warning in t/db_dependent/Circulation/Chargelostitem.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21023 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:19:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:19:41 +0000 Subject: [Koha-bugs] [Bug 20090] Missing Script Statement for Novelist Select on Some Record Displays in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20090 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:21:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:21:09 +0000 Subject: [Koha-bugs] [Bug 20332] Untranslatable strings in grouped OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20332 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:21:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:21:43 +0000 Subject: [Koha-bugs] [Bug 20698] Remove obsolete template: transfer-slip.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20698 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:23:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:23:54 +0000 Subject: [Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:26:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:26:36 +0000 Subject: [Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 21:29:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 19:29:03 +0000 Subject: [Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #23 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 22:34:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 20:34:39 +0000 Subject: [Koha-bugs] [Bug 20805] Update child to adult patron process broken on several patron-related pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20805 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 22:36:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 20:36:38 +0000 Subject: [Koha-bugs] [Bug 20814] Display issue with 'Saved reports' tabs when memcached is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 22:41:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 20:41:05 +0000 Subject: [Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 22:45:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 20:45:17 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 15 22:53:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 15 Jul 2018 20:53:41 +0000 Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 --- Comment #9 from Liz Rea --- I don't have a non-production LDAP to test against :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 02:22:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 00:22:28 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 --- Comment #9 from David Cook --- (In reply to Marcel de Rooy from comment #8) > From the plack counterpart: > RewriteCond %{REQUEST_URI} !^/api/v[0-1]+/app.pl > RewriteRule ^/api/(v[0-9]+)/(.*)$ /api/$1/app.pl/api/$1/$2 [L,PT] > > From your patch: > RewriteCond %{REQUEST_URI} !^/api/v[0-1]+/app.pl > RewriteRule ^(v[0-9]+)/(.*)$ /api/$1/app.pl/api/$1/$2 [L] > > Not the same. You start with v[0-9] which seems to be wrong ;) > How did you test? > It might seem wrong but it's not wrong ;). The reason is that these directives are happening in a Directory block with a RewriteBase of /api/ (note that in Apache 2.4 without an explicit RewriteBase an implicit one will be created anyway), so Apache strips off the "/api/" part after it matches the RewriteCond. You can check this using a logging directive like "LogLevel alert rewrite:trace3". I tested by putting in the Apache config with the directives I've included in these patches along with the logging I mention above and I observed that my test plan worked. > Note btw that v[0-9]+ may not be what we want. It covers v987654321 for > instance. We do not have v0, but only v1. Hoping for v2 :) That may be true but I don't think that's within the scope of this bug report. This patch is just trying to bring the CGI config in line with the Plack config. I'd like to reset this status back to Signed Off. I can provide some logging output if that would be helpful in regards to the RewriteRule? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 03:10:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 01:10:41 +0000 Subject: [Koha-bugs] [Bug 21074] (just a try) Display sparql data from wikidata or bnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21074 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 07:53:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 05:53:09 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #30 from Martin Renvoize --- I believe Tomas is working on bug 20443.. which I think is the blocker here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 09:20:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 07:20:42 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Marcel de Rooy --- (In reply to Chris Nighswonger from comment #22) > (In reply to Marcel de Rooy from comment #19) > > Chris: > > I have the impression > > Just an impression? ;-) Did you test and find a case where this fix does not > work? Please keep in mind that we both have the same goal: fix bugs and improve code. QAing is more than testing. A careful look at the code can in my experience reveal bugs just as easy or show you what to test. > $binary_data is a reference to $image_data->{'imagefile'} which, in turn, is > a reference to a hash created by DBI containing the results of the SELECT. > DBI creates a new hash on every row retrieval[1], ensuring that the data > contained at our reference is fresh every time. The crux is here indeed. This is only partially true. The code does only update $image_data in two of the if statement branches. So my observation and request is just to clear $image_data each time in the loop or put its definition into the loop. Clearing the other variables might be unneeded since they are created in the loop. So this reveals a test case: Make sure that record 1 in the loop is a patron image and record 2 comes in the eq 'none' branch. Record 2 will use the old value of $image_data. > Image::Magick, on the other hand, does not automatically "destroy" the > original structure on each call, and so we need to take care of that.[2] Fine with me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 09:21:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 07:21:30 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #25 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #23) > Pushing this back into the QA queue (for discussion between QA and developer > we usually don't use "In Discussion" - only when you can't agree) It is a FQA which I have set the last time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 09:27:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 07:27:33 +0000 Subject: [Koha-bugs] [Bug 21074] (just a try) Display sparql data from wikidata or bnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21074 --- Comment #6 from claire.hernandez at biblibre.com --- Link to the koha-devel discussion : http://lists.koha-community.org/pipermail/koha-devel/2018-July/044706.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 09:27:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 07:27:56 +0000 Subject: [Koha-bugs] [Bug 21074] (just a try) Display sparql data from wikidata or bnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21074 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 09:34:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 07:34:03 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #26 from Katrin Fischer --- I think setting back to SO after the dev has commented or provided a follow-up is process-wise ok and standard - requires another check then by QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 09:36:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 07:36:14 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #27 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #26) > I think setting back to SO after the dev has commented or provided a > follow-up is process-wise ok and standard - requires another check then by > QA. No problem. But normally this process between author and QAer does not need additional interfering. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 09:40:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 07:40:22 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Marcel de Rooy --- (In reply to David Cook from comment #9) > (In reply to Marcel de Rooy from comment #8) > > From the plack counterpart: > > RewriteCond %{REQUEST_URI} !^/api/v[0-1]+/app.pl > > RewriteRule ^/api/(v[0-9]+)/(.*)$ /api/$1/app.pl/api/$1/$2 [L,PT] > > > > From your patch: > > RewriteCond %{REQUEST_URI} !^/api/v[0-1]+/app.pl > > RewriteRule ^(v[0-9]+)/(.*)$ /api/$1/app.pl/api/$1/$2 [L] > > > > Not the same. You start with v[0-9] which seems to be wrong ;) > > How did you test? > > > > It might seem wrong but it's not wrong ;). > > The reason is that these directives are happening in a Directory block with > a RewriteBase of /api/ (note that in Apache 2.4 without an explicit > RewriteBase an implicit one will be created anyway), so Apache strips off > the "/api/" part after it matches the RewriteCond. You can check this using > a logging directive like "LogLevel alert rewrite:trace3". > > I tested by putting in the Apache config with the directives I've included > in these patches along with the logging I mention above and I observed that > my test plan worked. > > > Note btw that v[0-9]+ may not be what we want. It covers v987654321 for > > instance. We do not have v0, but only v1. Hoping for v2 :) > > That may be true but I don't think that's within the scope of this bug > report. This patch is just trying to bring the CGI config in line with the > Plack config. > > I'd like to reset this status back to Signed Off. I can provide some logging > output if that would be helpful in regards to the RewriteRule? I did it for you now. Yeah, your log might be helpful to prove :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 09:51:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 07:51:00 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 09:51:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 07:51:03 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76887|0 |1 is obsolete| | Attachment #76888|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 76969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76969&action=edit Bug 20811: Fix wrong usage of ModBiblio Since commit cefa7c21e28b88351ee8ae0dfefb80a515323df9 Bug 5635: bulkmarcimport new parameters & features AddBiblio call has been replaced with ModBiblio, but the return values are different. We should not replace the value of $biblionumber with what returns this subroutine. Test plan: If you are familiar with bulkmarcimport.pl you should know what to test, I am not. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 09:52:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 07:52:46 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #18 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > I do not have time to work more on this script. OK I will obsolete the second patch. With the first patch we fix something ugly. If more scripts need attention, we can do so on a new report. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:01:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:01:10 +0000 Subject: [Koha-bugs] [Bug 20974] Remove files left behind after removing Solr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 --- Comment #5 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #4) > Hi Marcel, please take a closer look. There are small differences: > > > 1) git grep -E "INCLUDE [']?facets.inc" > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:[% INCLUDE > 'facets.inc' %] > > This is the intranet version of the file. The patch removes from bootstrap. > > 2) git grep -E "INCLUDE [']?page-numbers.inc" > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: > [% INCLUDE 'page-numbers.inc' %] > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: [% > INCLUDE 'page-numbers.inc' %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt: > [% INCLUDE 'page-numbers.inc' %] > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: >
[% INCLUDE 'page-numbers.inc' %]
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: >
[% INCLUDE 'page-numbers.inc' %]
> > The file removed is from includes/search/, not includes. The file in > includes is still there. > > 3) git grep -E "INCLUDE [']?resort_form.inc" > Same for this one, the difference is includes/search vs. includes. Hmm. Sorry for overlooking this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:06:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:06:20 +0000 Subject: [Koha-bugs] [Bug 20974] Remove files left behind after removing Solr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:06:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:06:24 +0000 Subject: [Koha-bugs] [Bug 20974] Remove files left behind after removing Solr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76762|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 76970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76970&action=edit Bug 20974: Remove files left behind after removing Solr Some files were left behind when Bug 12538 removed support for Solr. This patch removes them. To test, apply the patch and fail to observe the existence of these files: koha-tmpl/opac-tmpl/bootstrap/en/includes/search/facets.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/page-numbers.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/search/resort_form.inc Perform a search in the OPAC to confirm that nothing broke. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:06:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:06:36 +0000 Subject: [Koha-bugs] [Bug 20974] Remove files left behind after removing Solr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:09:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:09:54 +0000 Subject: [Koha-bugs] [Bug 20714] Bug1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20714 jasjot kaur changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |waytojasjot at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:10:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:10:17 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76768|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Created attachment 76971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76971&action=edit Bug 16575: Irregular behaviour using window.print() followed by window.location.href This patch updates the OPAC and staff client carts to use CSS to control print output, removing a print parameter which was passed to the script. Currently, when you click "Print" on the OPAC basket, it navigates to a new page and initiates window.print() followed by a window.location.href change again. Unfortunately, due to differences in IE, Chrome, and FF, it will either show the print options, navigate away without showing them, or refuse to navigate away after printing. By changing to using print CSS, we don't navigate away from the basket in the first place, so we prevent this irregular behavior. TEST PLAN 1) Apply the patch 2) Create an OPAC basket by clicking "Add to cart" on multiple items 3) Using Chrome, IE, and Firefox (of any version), click the "Print" button 4) You should see the relevant print menu without the OPAC basket re-loading in any way. 5) After printing is complete, you should still be on the OPAC basket pop-up 6) Perform the same tests in the staff client Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:10:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:10:22 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76967|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy --- Created attachment 76972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76972&action=edit Bug 16575: (follow-up) Compiled CSS This patch contains the compiled CSS for the OPAC print stylesheet. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:10:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:10:53 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #19) > I fixed the CSS. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:11:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:11:01 +0000 Subject: [Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:19:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:19:43 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #28 from Katrin Fischer --- This is a privacy issue, I just didn't want it to die "in discussion". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:22:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:22:00 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #29 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #28) > This is a privacy issue, I just didn't want it to die "in discussion". Yeah it is. No problem! Thx for following up.. Imo we are just clearing one variable away from PQA. I only need to convince Chris.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:30:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:30:05 +0000 Subject: [Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 --- Comment #11 from David Cook --- (In reply to Marcel de Rooy from comment #10) > I did it for you now. Yeah, your log might be helpful to prove :) Thanks, Marcel. I'll redo my tests in the morning and copy some of the log output here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:40:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:40:44 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 10:55:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 08:55:17 +0000 Subject: [Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 11:02:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 09:02:12 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #16 from Jon Knight --- I was focusing on the example box with the tick (in other words the right, approved way the ICO expect this to be handled) that says: "You keep records that include an ID and the data submitted online together with a timestamp. You also keep a copy of the version of the data-capture form and any other relevant documents in use at that date." So to me that does imply the need to save these texts at an individual consent level, as they all form part of the consent package for that user. Indeed the "crossed" part (wrong) of that example says, "You keep the time and date of consent linked to an IP address, with a web link to your current data-capture form and privacy policy" so they seem to think that just knowing what the PrivacyPolicyURL was set to at the time of consent is not enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 11:32:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 09:32:50 +0000 Subject: [Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #17 from Marcel de Rooy --- I was looking at the same text as you. But I concluded that we need to save the consent tekst somewhere in a version history not on consent level (that would be unneeded redundancy). But not implying that saving a URL would be enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 11:34:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 09:34:12 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #15 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #12) > (In reply to Marcel de Rooy from comment #11) > > Line 680 still contains: > > [% IF s.authorised_value == selected_status %] > > Around line 308 you are replacing it by suggestion.STATUS. Please explain. > > If I am not mistaken, it comes from: my $suggestion_ref = $input->Vars; > > Where is the field STATUS filled? > > 361 suggestion => $suggestion_ref, OK. But what about line 680? The selected_status there is not filled anywhere? > > See the following warn when I haved added an additional status and I am > > saving a suggestion with that status. > > No suggestions TEST3 letter transported by email at > > /usr/share/koha/devclone/C4/Letters.pm line 602. > > I guess this existed prior to this change. It looks like a configuration > issue, or an expected behavior, ModSuggestion is sending an email to the > author of the suggestion when the status is changed. The notice template > used is the one with the same code as the status (that is pretty bad, it > should at least be prefixed by something). I would not consider this as > blocker for this bugfix/ No, it is certainly not a blocker here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 11:41:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 09:41:39 +0000 Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 11:57:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 09:57:06 +0000 Subject: [Koha-bugs] [Bug 18851] Use Test::DBIx::Class in tests breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #36 from Fridolin SOMERS --- 17.05.x end of life is in septembre so I will keep as it is -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 11:59:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 09:59:34 +0000 Subject: [Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers at biblibre.co | |m --- Comment #40 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 12:22:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 10:22:52 +0000 Subject: [Koha-bugs] [Bug 21079] New: Unify metadata schema across backends Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079 Bug ID: 21079 Summary: Unify metadata schema across backends Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com Currently different ILL backends return metadata in disparate property names, for example, an article will have the property "./metadata/titleLevel/title" for it's containing journal title on the BLDSS backend, whereas the FreeForm backend will store it in "title". Some work was done by Martin in Bug 20640 that introduced the mapping of certain metadata properties to a common schema. For example, the property described above is mapped to "container_title". This mapping work currently only exists for the BLDSS backend. Work on Bug 21063 has highlighted the fact that these metadata properties vary according to the backend. This bug proposes extending the mapping to other backends. This will be carried out for the FreeForm backend by Andrew Isherwood. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 12:24:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 10:24:01 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079 [Bug 21079] Unify metadata schema across backends -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 12:24:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 10:24:01 +0000 Subject: [Koha-bugs] [Bug 20640] Allow migrating a request between backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079 [Bug 21079] Unify metadata schema across backends -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 12:24:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 10:24:01 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079 [Bug 21079] Unify metadata schema across backends -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 12:24:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 10:24:01 +0000 Subject: [Koha-bugs] [Bug 21079] Unify metadata schema across backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Depends on| |7317, 20640 Blocks| |21063 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 [Bug 21063] Allow columns in intranet ILL request datatable to be customisable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 12:31:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 10:31:08 +0000 Subject: [Koha-bugs] [Bug 21079] Unify metadata schema across backends In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |unspecified --- Comment #1 from Andrew Isherwood --- It's more than likely this work won't touch core Koha, I just thought it was worth creating a bug to highlight that this will need to be done for any other backends in existence. I'll post details of what was done to the FreeForm backend once it is complete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 12:40:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 10:40:32 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76958|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 76973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76973&action=edit Bug 21073: Improve plugin performance Right now, to check if a plugin is functional and what methods it exposes we load the module and test for a given method at run time. This is highly inefficient. It makes far more sense to do this at install time and store the data in the db. I believe we should store a table of methods that each plugin exposes and check that instead. Then, at install time we can test that a) the plugin can be loaded and b) add the available methods to the plugin_methods table. Test Plan: 1) Apply this patch 2) Restart all the things 3) Run updatedatabase.pl 4) Verify you can use existing plugins 5) Verify you can install new plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 12:57:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 10:57:31 +0000 Subject: [Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #3 from Mirko Tietgen --- The Bionic nightly package does contain /usr/share/doc/koha-common/history.txt. Log mentions [https://apt.abunchofthings.net/koha-nightly/unstable-bionic-log.txt] > cp docs/history.txt blib/DOC_DIR/history.txt > Installing /build/koha-18.06.01~git+20180716093736.12fd02af/debian/tmp/usr/share/koha/doc/history.txt > # exclude history.txt from compression as about.pl needs it uncompressed > dh_compress --exclude=history.txt If the test uses /usr/share/doc/koha-common/history.txt, I suppose it is necessary to copy that file from /kohadevbox/koha/doc/, like the Jenkins log shows for Debian scripts? Or rather use /kohadevbox/koha/doc/history.txt instead. But if that is the problem, I would expect the test to fail for other distros. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:06:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:06:15 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:06:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:06:17 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74936|0 |1 is obsolete| | Attachment #75698|0 |1 is obsolete| | --- Comment #24 from Nick Clemens --- Created attachment 76974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76974&action=edit Bug 17168: Add a command line script for updating patron category based on status This patch adds a new script update_patrons_category.pl which allows for updating patron categories in a batch upon meeting provided criteria. This script additionally can replace j2a.pl. To test: 1 - perl update_patrons_category.pl -h 2 - Ensure help text makes sense and covers all options 3 - Test converting patrons supplying only fromcat and tocat perl update_patrons_category.pl -f PT -t J -v --confirm perl update_patrons_category.pl -f J -t PT -v --confirm 4 - All patrons should have been switched to and from Juveniles 5 - Try without --confirm switch perl update_patrons_category.pl -f PT -t J -v 6 - Should list all patrons but not update 7 - Set the age for juvenile patrons to be outside the range provided in categories (or set the upper age limit for juveniles to '2') 8 - Test with verbosity and with without --confirm perl update_patrons_category.pl -f J -a -t PT -v perl update_patrons_category.pl -f J -a -t PT -v --confirm 9 - Repeat above and verify linked/unlinked guarantors are removed in above scenario 10 - Test various fine and registration limits 11 - Test matching on specific fields i.e. --field surname=acosta 12 - Sign off Sponsored by: Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:06:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:06:21 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #25 from Nick Clemens --- Created attachment 76975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76975&action=edit Bug 17168: (follow-up) Tidy, clean params/options, use date tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:06:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:06:24 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #26 from Nick Clemens --- Created attachment 76976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76976&action=edit Bug 17168: (follow-up) Clean up QA errors Cleanup variable names Remove Dumper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:33:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:33:49 +0000 Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:33:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:33:53 +0000 Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72807|0 |1 is obsolete| | Attachment #72808|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 76977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76977&action=edit Bug 19604: Elasticsearch Fixes for build_authorities_query for auth searching To test: 1 - Do some authority searches in Zebra 2 - Switch to ES and repeat, results will vary and some may fail 3 - Apply patch and dependencies 4 - Reindex ES 5 - Repeat searches, they should suceed and results should be similar to Zebra 6 - Slight differences are okay, but results should (mostly) meet expectations A few notes: We add a 'normalizer' to ensure we get a single token from the heading indexes, this makes 'starts with' work as expcted We switch to 'AND' for fields searched from cataloging editor - this matches Zebra results We force the '__sort' fields for sorting - if sorting looks wrong try reducing the heading field to a single subfield - this will need to be addressed on a future bug (multiple subfields create an array, ES sorts those randomly) Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:33:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:33:57 +0000 Subject: [Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 --- Comment #20 from Nick Clemens --- Created attachment 76978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76978&action=edit Bug 19604: Unit tests 1 - Apply previous patches 2 - prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t 3 - Should be green 4 - high fives! Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:43:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:43:30 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:43:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:43:34 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74335|0 |1 is obsolete| | Attachment #74336|0 |1 is obsolete| | Attachment #74337|0 |1 is obsolete| | Attachment #74338|0 |1 is obsolete| | Attachment #74339|0 |1 is obsolete| | Attachment #74340|0 |1 is obsolete| | Attachment #74341|0 |1 is obsolete| | Attachment #74342|0 |1 is obsolete| | Attachment #74370|0 |1 is obsolete| | Attachment #74371|0 |1 is obsolete| | Attachment #74422|0 |1 is obsolete| | Attachment #74427|0 |1 is obsolete| | Attachment #74438|0 |1 is obsolete| | --- Comment #58 from Nick Clemens --- Created attachment 76979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76979&action=edit Bug 18736: Add OrderPriceRounding syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:43:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:43:39 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #59 from Nick Clemens --- Created attachment 76980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76980&action=edit Bug 18736: Use rounding syspref to determine correct prices in calculations To test: Place an order (no tax just for simplicity) listprice/rrp = 16.99 discount = 42% quantity = 8 estimated calculated at 9.85 but order total is 78.83, but 8 times 9.85 = 78.80 Apply patches, set OrderPriceRounding syspref to 'Nearest cent' Not order total is now as expected View ordered.pl and confirm values are correct Complete order, view invoice and confirm values View spent.pl and confirm values Go through acquisitions module and confirm prices throughout are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:44:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:44:12 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #60 from Nick Clemens --- Created attachment 76981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76981&action=edit Bug 18736: Unit tests for rounding Unit tests to highlight the issue To test: Prove t/db_dependent/Budgets.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:44:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:44:17 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #61 from Nick Clemens --- Created attachment 76982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76982&action=edit Bug 18736: (follow-up) - Fix SQL and uncomment db update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:44:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:44:22 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #62 from Nick Clemens --- Created attachment 76983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76983&action=edit Bug 18736: (follow-up) fix wrong call to _get_rounding_sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:44:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:44:28 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #63 from Nick Clemens --- Created attachment 76984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76984&action=edit Bug 18736: (follow-up) Use CAST instead of CEIL for appropriate rounding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:44:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:44:33 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #64 from Nick Clemens --- Created attachment 76985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76985&action=edit Bug 18736: (follow-up) Correctly assign values in subroutines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:44:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:44:38 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #65 from Nick Clemens --- Created attachment 76986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76986&action=edit Bug 18736: (follow-up) Add tests and FIXME for GetbudgetsPlanCell prove t/db_dependent/Budgets.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:44:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:44:43 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #66 from Nick Clemens --- Created attachment 76987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76987&action=edit Bug 18736: Follow to prevent duplicate run noise TEST PLAN --------- update the database twice -- noise apply patch update the database -- no noise -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:44:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:44:48 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #67 from Nick Clemens --- Created attachment 76988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76988&action=edit Bug 18736: Follow to clean up admin policy preference Two preferences were merged into the same box. This likely was unintended. This reformats them. TEST PLAN --------- Go to Acquisitions tab of the system preference -- in the policy section PurgeSuggestionsOlderThan and OrderPriceRounding are in the same box Apply this patch Refresh the page -- OrderPriceRounding is in its own box, and better formatted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:44:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:44:53 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #68 from Nick Clemens --- Created attachment 76989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76989&action=edit Bug 18736: (follow-up) Add missing test cases We now fully cover GetBudgetsPlanCell in these tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:44:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:44:59 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #69 from Nick Clemens --- Created attachment 76990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76990&action=edit Bug 18736: (follow-up) Undo changes to GetLateOrders GetLateOrders calculates subtotal based on rrp which is a 2 decimal precision field. If we need more precision here it should be fixed on a separate bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:45:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:45:04 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #70 from Nick Clemens --- Created attachment 76991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76991&action=edit Bug 18736: (follow-up) Unit tests Test coverage for new C4::Acquisition functions. prove t/Acquisition.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:47:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:47:49 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #71 from Nick Clemens --- Applied cleanly on master for me - I moved additional tests to subtest in Acquisition.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 13:55:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 11:55:49 +0000 Subject: [Koha-bugs] [Bug 19524] Share patron lists between staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #12 from Kyle M Hall --- Created attachment 76992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76992&action=edit Bug 19524: Use existing logged_in_user variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 14:39:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 12:39:27 +0000 Subject: [Koha-bugs] [Bug 21048] suggest_status not behaving properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #16 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #15) > (In reply to Jonathan Druart from comment #12) > > (In reply to Marcel de Rooy from comment #11) > > > Line 680 still contains: > > > [% IF s.authorised_value == selected_status %] > > > Around line 308 you are replacing it by suggestion.STATUS. Please explain. > > > If I am not mistaken, it comes from: my $suggestion_ref = $input->Vars; > > > Where is the field STATUS filled? > > > > 361 suggestion => $suggestion_ref, > OK. But what about line 680? The selected_status there is not filled > anywhere? It sounds like a bug but I cannot recreate from the UI, maybe this is never used? Could you have a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 14:45:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 12:45:29 +0000 Subject: [Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 --- Comment #13 from Blou --- We'd love to, and we'll certain support (with testing) anyone working on it or similar patch, but it won't be us (inLibro) doing the coding at this point I'm sorry to say. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:11:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:11:06 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #19 from Jonathan Druart --- First patch is useless without the second patch... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:12:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:12:46 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #31 from Jonathan Druart --- (In reply to Katrin Fischer from comment #29) > Why BLOCKED? See comment 20. (In reply to Martin Renvoize from comment #30) > I believe Tomas is working on bug 20443.. which I think is the blocker here. See assignee field, I am working on it. Please do not change anything here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:18:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:18:56 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > First patch is useless without the second patch... Not so sure about that. Please explain. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:19:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:19:01 +0000 Subject: [Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #2) > Is the bug that there are 2 Edit links for both that lead to the same page? step 4 is used for both housebound module and additional attributes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:23:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:23:42 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #21 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #20) > (In reply to Jonathan Druart from comment #19) > > First patch is useless without the second patch... > > Not so sure about that. Please explain. Comments 6 to 9 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:26:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:26:13 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #22 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #21) > (In reply to Marcel de Rooy from comment #20) > > (In reply to Jonathan Druart from comment #19) > > > First patch is useless without the second patch... > > > > Not so sure about that. Please explain. > > Comments 6 to 9 I saw them. But that does not make this patch useless. We fix a wrong call. If it is in enclosed by if($update), the fix is conditional. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:33:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:33:10 +0000 Subject: [Koha-bugs] [Bug 21040] Funds from inactive budgets appear in 'Funds' dropdown on suggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21040 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:45:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:45:32 +0000 Subject: [Koha-bugs] [Bug 21040] Funds from inactive budgets appear in 'Funds' dropdown on suggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21040 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11176 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:45:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:45:32 +0000 Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21040 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:46:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:46:22 +0000 Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 --- Comment #6 from Marjorie Barry-Vila --- In 17.05, there is an other problem: when creating a new suggestion, active funds do not appear at first time. You have to save the suggestion and then go back to see active funds (with all inactive funds too). Anyone works on this? Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:50:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:50:01 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #23 from Katrin Fischer --- It doesn't work, see my tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:54:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:54:30 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #24 from Katrin Fischer --- We fix a wrong call... but the feature will remain broken. Might just be hiding the real problem. Maybe we should change this bug to 'update option is broken in bulkmarcimport.pl' for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 15:55:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 13:55:53 +0000 Subject: [Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #25 from Jonathan Druart --- Removing from PQA for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:13:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:13:15 +0000 Subject: [Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 --- Comment #3 from Jonathan Druart --- Hum, it is failing now (?) ReferenceError: _ is not defined at line: var MSG_PLEASE_ENTER_A_VALID_DATE = (_("Please enter a valid date (should match %s).")); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:21:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:21:45 +0000 Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 [Bug 21050] Datepickers on LabelItemSearch broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:21:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:21:45 +0000 Subject: [Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Depends on| |19709 --- Comment #4 from Jonathan Druart --- Caused by commit 3c887b4e07acf9459767a7b934aa4f6c16cae534 Bug 19709: Move template JavaScript to the footer: Labels Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 [Bug 19709] Move template JavaScript to the footer: Labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:23:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:23:22 +0000 Subject: [Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:23:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:23:25 +0000 Subject: [Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 --- Comment #5 from Jonathan Druart --- Created attachment 76993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76993&action=edit Bug 21050: Fix datepickers on LabelItemSearch calendar.inc must be in the jsinclude block when jsfooter is set Test plan: - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Date picker should work now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:27:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:27:57 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:28:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:28:02 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74893|0 |1 is obsolete| | Attachment #74894|0 |1 is obsolete| | Attachment #74895|0 |1 is obsolete| | Attachment #74896|0 |1 is obsolete| | Attachment #74897|0 |1 is obsolete| | Attachment #74898|0 |1 is obsolete| | Attachment #74899|0 |1 is obsolete| | Attachment #74900|0 |1 is obsolete| | Attachment #75043|0 |1 is obsolete| | --- Comment #67 from Nick Clemens --- Created attachment 76994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76994&action=edit Bug 19166: Database changes Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:28:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:28:59 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76994|0 |1 is obsolete| | --- Comment #68 from Nick Clemens --- Created attachment 76995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76995&action=edit Bug 19166: Database changes Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:29:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:29:06 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #69 from Nick Clemens --- Created attachment 76996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76996&action=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Conflicts: C4/Budgets.pm Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:29:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:29:12 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #70 from Nick Clemens --- Created attachment 76997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76997&action=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:29:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:29:17 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #71 from Nick Clemens --- Created attachment 76998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76998&action=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:29:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:29:24 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #72 from Nick Clemens --- Created attachment 76999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76999&action=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:29:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:29:30 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #73 from Nick Clemens --- Created attachment 77000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77000&action=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: S?verine QUEUNE Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:29:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:29:37 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #74 from Nick Clemens --- Created attachment 77001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77001&action=edit Bug 19166: Correct charset collate Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:29:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:29:50 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #76 from Nick Clemens --- Created attachment 77003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77003&action=edit Bug 19166: (follow-up) Adjust table and files and QA issues Move to aqinvoice_adjustment Move to Koha::Acquisition::Invoice::Adjustments Test if variable exists before count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:29:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:29:44 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #75 from Nick Clemens --- Created attachment 77002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77002&action=edit Bug 19166: (follow-up) Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a
to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:29:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:29:56 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #77 from Nick Clemens --- Created attachment 77004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77004&action=edit Bug 19166: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:31:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:31:16 +0000 Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #78 from Nick Clemens --- QA tool will warn of deleted/created in same patchset - pfft - can squash on push It also complains of pod on the Schema files - I think is a red herring TT warns cleared -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:34:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:34:58 +0000 Subject: [Koha-bugs] [Bug 21071] Search results not sorting in staff client advanced search when only AdvancedSearchTypes checkboxes are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21071 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Looks ok on master, can you define "does not work"? Do you get an error? No result? Sort option is not selected? Do you sort on the search result or the advanced search view? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:43:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:43:30 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #30 from Chris Nighswonger --- (In reply to Marcel de Rooy from comment #24) > (In reply to Chris Nighswonger from comment #22) > > (In reply to Marcel de Rooy from comment #19) > > > Chris: > > > I have the impression > > > > Just an impression? ;-) Did you test and find a case where this fix does not > > work? > Please keep in mind that we both have the same goal: fix bugs and improve > code. QAing is more than testing. A careful look at the code can in my > experience reveal bugs just as easy or show you what to test. No offense intended. I understand that we have the same goal. I appreciate your contribution to the QA process. Please keep in mind that my time is extremely limited. Much more so than devs who are paid to work on Koha as I am paid to work on other projects. When you provide QA feedback without a supporting proof-case, it means that the dev has to spend time ensuring 1. your observation is valid and 2. Ensuring that the fix does not cause other problems. Time is expensive to be spending on an impression without accompanying demonstrable failure cases. > > > $binary_data is a reference to $image_data->{'imagefile'} which, in turn, is > > a reference to a hash created by DBI containing the results of the SELECT. > > DBI creates a new hash on every row retrieval[1], ensuring that the data > > contained at our reference is fresh every time. > The crux is here indeed. This is only partially true. The code does only > update $image_data in two of the if statement branches. So my observation > and request is just to clear $image_data each time in the loop or put its > definition into the loop. Clearing the other variables might be unneeded > since they are created in the loop. > So this reveals a test case: Make sure that record 1 in the loop is a patron > image and record 2 comes in the eq 'none' branch. Record 2 will use the old > value of $image_data. FTR: I have no problem undefing the entire $image_data reference. As soon as I have time, I will submit a follow-up patch. I also inadvertently removed the statements which short-circuit the loop in the case of no image data. That needs to be corrected as well. That said: Your suggested case does not cause the failure you suggest. I understand that $image_data never drops out of scope during the loop execution. I understand that in theory the reference can contain "stale" data. I just have not been handed and cannot establish a test case where it does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:58:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:58:28 +0000 Subject: [Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #4 from Jonathan Druart --- It's a www test, so it means the interface is hit. It's not test related. So I am expecting about.pl to not display the history.txt content (tab Timeline) on bionic. Could someone confirm? There is something hidden we should understand asap, it could have other problematic side-effects. Or Maybe none... :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:58:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:58:50 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:58:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:58:53 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66557|0 |1 is obsolete| | Attachment #66558|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 77005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77005&action=edit Bug 18635 - Koha::Patron->guarantees() should return results alphabetically To test: 1 - Add the same guarantor to a number of patrons, ensuring random order alphabetically 2 - View the guarantors record, note unordered list of guarantees 3 - Apply patch 4 - Guarantees are alphabetical Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:58:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:58:57 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #16 from Nick Clemens --- Created attachment 77006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77006&action=edit Bug 18635 - Unit tests To test: 1 - Apply this patch only 2 - Prove t/db_dependent/Patron.t 3 - Tests fail 4 - Apply other patch 5 - Tests pass Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 16:59:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 14:59:53 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #17 from Nick Clemens --- (In reply to Jonathan Druart from comment #13) > (In reply to Marcel de Rooy from comment #12) > > Nick, > > What are you doing here?! > > Deleting tests without further notice? > > > > Failed QA > > Which tests are missing? Maybe as_list, is it what you meant? When I moved the tests I also deleted tests, that was an error, undone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 17:10:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 15:10:50 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #18 from Jonathan Druart --- I do not think it was, tests in t/db_dependent/Patrons.t are pointless. Anyway, did you see that we already have a subtest for this method, in the same file? t/db_dependent/Koha/Patrons.t:subtest 'guarantees' => sub { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 17:54:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 15:54:33 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 17:54:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 15:54:37 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72878|0 |1 is obsolete| | Attachment #72879|0 |1 is obsolete| | Attachment #72880|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 77007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77007&action=edit Bug 19482 - DB changes Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 17:54:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 15:54:41 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #18 from Nick Clemens --- Created attachment 77008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77008&action=edit Bug 19482 - Add support for defining 'mandatory' mappings To test: 1 - Apply patch 2 - ./installer/data/mysql/updatedatabase.pl 3 - Clear all ES mappings form the db: DELETE FROM search_field; DELETE FROM search_marc_map; DELETE FROM search_marc_to_field; 4 - Reset ES mapping: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 5 - issues should now be uneditable and not removable Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 17:54:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 15:54:44 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #19 from Nick Clemens --- Created attachment 77009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77009&action=edit Bug 19482: (follow-up) QA fixes Remove debug statement Use disaled select to match other fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 17:54:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 15:54:48 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #20 from Nick Clemens --- Created attachment 77010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77010&action=edit Bug 19482: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 18:17:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 16:17:17 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77005|0 |1 is obsolete| | Attachment #77006|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 77011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77011&action=edit Bug 18635 - Koha::Patron->guarantees() should return results alphabetically To test: 1 - Add the same guarantor to a number of patrons, ensuring random order alphabetically 2 - View the guarantors record, note unordered list of guarantees 3 - Apply patch 4 - Guarantees are alphabetical Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 18:17:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 16:17:21 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #20 from Nick Clemens --- Created attachment 77012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77012&action=edit Bug 18635 - Unit tests To test: 1 - Apply this patch only 2 - Prove t/db_dependent/Koha/Patrons.t 3 - Tests fail 4 - Apply other patch 5 - Tests pass Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 18:30:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 16:30:23 +0000 Subject: [Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77012|0 |1 is obsolete| | --- Comment #21 from Nick Clemens --- Created attachment 77013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77013&action=edit Bug 18635 - Unit tests I also adjust a few tests that assume value of $nb_of_patrons to not rely on existing datas To test: 1 - Apply this patch only 2 - Prove t/db_dependent/Koha/Patrons.t 3 - Tests fail 4 - Apply other patch 5 - Tests pass Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 18:31:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 16:31:16 +0000 Subject: [Koha-bugs] [Bug 20736] Update two-column templates with Bootstrap grid: Administration part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20736 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 16 18:31:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 16 Jul 2018 16:31:19 +0000 Subject: [Koha-bugs] [Bug 20736] Update two-column templates with Bootstrap grid: Administration part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20736 --- Comment #1 from Owen Leonard --- Created attachment 77014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77014&action=edit Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
123 Line1 Line2
456 Public note has one and only one line.