[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jul 2 21:12:09 CEST 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 76640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76640&action=edit
Bug 20990: (QA follow-up) make outstanding_credits return the account lines
only

This patch was discussed with Jonathan on a QA conversation. It is
better to keep this simpler and more reusable. And is the right approach
in this case.

This patch makes Koha::Account::outstanding_credits return the account
lines, code that used the $total value, will just use

    $lines->total_outstanding;

Tests are adjusted accordingly.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Account.t
=> SUCCESS: Test pass.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list