[Koha-bugs] [Bug 21036] Just a bunch of warnings

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #3)
> (In reply to Marcel de Rooy from comment #2)
> > Read the change. Not 100% identical (numeric zero) but should be enough.
> > This line is probably not needed at all.
> 
> Regarding
>   commit 26469d87a261682dcbde0f41faa844133d10ed5e
>   bug 2520: don't change item-level requests to bib-level
> 
> It is used to test
>   <input type="hidden" name="itemnumber" value="" />
> if item_level_hold it not set.

Thx.
That should still work as expected. The itemnumber==0 case is only
hypothetical; we do not have such items. Clearing the field should be fine.

If the line is needed or not here actually depends on if ModReserve and the
routines it calls, can handle an empty string for itemnumber. I would think
they do, but to be safe I do not remove the line.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.