[Koha-bugs] [Bug 15326] Add CMS feature

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Trying to tackle this:

1) QA scripts
Only the second looks valid, as this class is new and added by the patch set:

 FAIL   Koha/CmsPage.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl

 FAIL   Koha/CmsPages.pm
   FAIL   pod coverage
                POD is missing for 'object_class'

 FAIL   Koha/Schema/Result/CmsPage.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

Can you please fix?

2) Code review

a) Schema patches would be much better in a separate patch. Ok for now as the
patch still applies. For a rebase separating those change might be good.

b) In opac-cmspages there is:
+        flagsrequired   => { borrow => 1 },
The borrow permission has been removed since. (blocker)

c) Comment was removed unnecessarily, just needs to be moved into its right
spot below again:
-# If GoogleIndicTransliteration system preference is On Set parameter to load
Google's javascript in OPAC search screens

d) One file uses qw( -utf-8) but another does not:
+use CGI;
+use CGI qw( -utf8 );  (blocker)


3) Unit tests
... all passing!

4) Feature tests

OPAC

a) I feel we don't need the "Pages" heading. It only takes up space and states
the obvious. (non-blocker... but navigation needs work, see below)

b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use
it to place text on the start page instead of using the news feature, which
means it repeats on all pages. I'd really like to see this changed.

c) Personally I'd change "Location" to "Interface" to avoid confusion with the
item value in translations. But I see it's the same on news. So out of scope
here.

d) Parent pages can be deleted without warning. Childs will be moved to top
level. This is acceptable behaviour as they are not left orphaned. But it might
be something to improve on in the future.

e) In the test plan and in the code I see there should be a confirmation
message on deleting a single or multiple entries, but this doesn't work.
(blocker)

f) Navigation looks strange when working with multiple levels. Repeating the
level before seems unnecessary and only takes up space?

    Level 1
    Level 1 › Level 2
    Level 2 › Level 3

Also, clicking on the different links, sometimes a part of the navigation
disappears. I think this is a little too wonky to pass. Can you take another
look please? (blocker)

Intranet

Where do the pages appear in the intranet?



Generally I think this will be a great and really helpful addition and looking
forward to return to this!

-- 
You are receiving this mail because:
You are watching all bug changes.