[Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #2)
> Hi Marcel,
> 
> I've tried testing this, but can't reproduce the errors. What exactly do you
> mean by:
> 
> Open a basket that contains no prices.
> 
> ?
> 
> I've tried closing and reopening a basket with one order line where I left
> all entries empty, but that didn't do it. Closing an empty basket is not
> possible, so I am a little lost here.

Thanks for testing! Hmm. I couldn't reproduce on master too. A closer look
reveals that older production data has NULL values in fields like
tax_rate_on_ordering whereas you cannot create these NULL values anymore on a
new record.
I can imagine that other people might have some older acq data too and see the
same warnings? In this case a dbrev replacing NULL by 0 would do the job too,
but changing these two lines does not hurt?
Will adjust the commit message to reflect these findings.

-- 
You are receiving this mail because:
You are watching all bug changes.