[Koha-bugs] [Bug 21046] ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21046

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Alex Arnaud from comment #7)
> (In reply to Kyle M Hall from comment #6)
> > Won't this be a breaking change for anyone currently using ILS-DI that
> > doesn't have cardnumber and userid set to the same thing? Would it be better
> > to try cardnumber and fall back to userid, and simply not allow either to be
> > an empty field? That would make it behave like the rest of Koha's login
> > functionality, while minimizing breakages.
> 
> Not sure to understand how it could be broken. For me this patch make sense
> even though i didn't find a bug. We pass a userid to the function, so we
> retrieve the patron with the userid. It is unique, and it has been
> authenticated by checkpw just before.

Never mind me, I am a dummy.

I should have read the patch more closely. I blame mornings ;)

-- 
You are receiving this mail because:
You are watching all bug changes.