[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > Important note: We certainly need to add an index on this column to boost
> > this query.
> 
> Do you mean items.uri and deleteditems.uri?

only items.uri, but with the last patch it's not needed.

(In reply to Marcel de Rooy from comment #5)
> (In reply to Jonathan Druart from comment #3)
> > Important note: We certainly need to add an index on this column to boost
> > this query.
> 
> Koha::Items->search( { uri => $uri } )->count
> 
> You need to add biblionumber to limit the results. No need to scan the whole
> table.

Oops, yes you are right. It's itemnumber actually.
Maybe we should add more tests here, items.uri check should only be if
itemnumber is passed. But I would prefer to not complexity it now as it's
improvement and not bug fixing.

-- 
You are receiving this mail because:
You are watching all bug changes.