[Koha-bugs] [Bug 21048] suggest_status not behaving properly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #12)
> (In reply to Marcel de Rooy from comment #11)
> > Line 680 still contains:
> > [% IF s.authorised_value == selected_status %]
> > Around line 308 you are replacing it by suggestion.STATUS. Please explain.
> > If I am not mistaken, it comes from: my $suggestion_ref  = $input->Vars;
> > Where is the field STATUS filled?
> 
> 361     suggestion   => $suggestion_ref,
OK. But what about line 680? The selected_status there is not filled anywhere?

> > See the following warn when I haved added an additional status and I am
> > saving a suggestion with that status.
> > No suggestions TEST3 letter transported by email at
> > /usr/share/koha/devclone/C4/Letters.pm line 602.
> 
> I guess this existed prior to this change. It looks like a configuration
> issue, or an expected behavior, ModSuggestion is sending an email to the
> author of the suggestion when the status is changed. The notice template
> used is the one with the same code as the status (that is pretty bad, it
> should at least be prefixed by something). I would not consider this as
> blocker for this bugfix/
No, it is certainly not a blocker here.

-- 
You are receiving this mail because:
You are watching all bug changes.